From bugzilla-daemon at bugs.koha-community.org Wed Jan 1 00:11:21 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 31 Dec 2019 23:11:21 +0000 Subject: [Koha-bugs] [Bug 24324] New: delete_records_via_leader.pl cron error with item Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24324 Bug ID: 24324 Summary: delete_records_via_leader.pl cron error with item Change sponsored?: --- Product: Koha Version: 19.05 Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Command-line Utilities Assignee: koha-bugs at lists.koha-community.org Reporter: danielle at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: robin at catalyst.net.nz This cron gives the following error when run with the -i option but not without. /usr/share/koha/bin/cronjobs/delete_records_via_leader.pl -c -i -v > /var/lib/koha/redacted/d_leader_deleted_bib.log The method Koha::Items->itemnumber is not covered by tests! Trace begun at /usr/share/koha/lib/Koha/Objects.pm line 389 Koha::Objects::AUTOLOAD('Koha::Items=HASH(0x7c1ce60)') called at /usr/share/koha/bin/cronjobs/delete_records_via_leader.pl line 100 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jan 1 00:15:54 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 31 Dec 2019 23:15:54 +0000 Subject: [Koha-bugs] [Bug 24324] delete_records_via_leader.pl cron error with item deletion In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24324 Danielle Elder changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|delete_records_via_leader.p |delete_records_via_leader.p |l cron error with item |l cron error with item | |deletion -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 2 01:14:56 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Jan 2020 00:14:56 +0000 Subject: [Koha-bugs] [Bug 14759] Replacement for Text::Unaccent In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14759 --- Comment #36 from David Cook --- Perhaps we could make this a pluggable configuration option? We could even leave it with Text::Unaccent, and then us non-Debian using folk could manually switch to using Text::Unaccent::PurePerl? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 2 04:21:02 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Jan 2020 03:21:02 +0000 Subject: [Koha-bugs] [Bug 15127] (Plack on packages) plack.psgi should check for changed files In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15127 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |WONTFIX Status|NEW |RESOLVED --- Comment #4 from Tomás Cohen Arazi --- Starman author discourages this use and for production is not relevant. Perhaps for plugins but again, better think about it in a narrower context then this bug -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 2 06:32:54 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Jan 2020 05:32:54 +0000 Subject: [Koha-bugs] [Bug 24325] New: I have created a new serial record in the catalog but that record is not searched at the time of new subscription to the serial. Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24325 Bug ID: 24325 Summary: I have created a new serial record in the catalog but that record is not searched at the time of new subscription to the serial. Change sponsored?: --- Product: Koha Version: 19.05 Hardware: PC OS: Windows Status: NEW Severity: normal Priority: P5 - low Component: Searching Assignee: koha-bugs at lists.koha-community.org Reporter: glwaghmode84 at gmail.com QA Contact: testopia at bugs.koha-community.org I have created a new serial record in the catalog but that record is not searched at the time of new subscription to the serial. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jan 2 07:34:47 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Jan 2020 06:34:47 +0000 Subject: [Koha-bugs] [Bug 24325] I have created a new serial record in the catalog but that record is not searched at the time of new subscription to the serial. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24325 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Status|NEW |RESOLVED Resolution|--- |INVALID --- Comment #1 from Katrin Fischer --- Hi, this sounds more like a support request than a bug report. Usually if a record cannot be found, there is a problem with the search engine/indexing. Please ask on the mailing list (https://koha-community.org/support/koha-mailing-lists/) or drop into the Koha IRC channel for support (https://koha-community.org/get-involved/irc/). Make sure to include the version of your Koha installation, how you installed it and which search engine you are using (Zebra or Elasticsearch). -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jan 2 07:48:14 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Jan 2020 06:48:14 +0000 Subject: [Koha-bugs] [Bug 24279] Claims Returned does not work when set from moredetail.pl or additem.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24279 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #96683|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer --- Created attachment 96724 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96724&action=edit Bug 24279 - Claims Returned does not work when set from moredetail.pl Test Plan: 1) Configure Claimes Returned 2) Apply this patch 3) Go to moredetail.pl for that item 4) Note the claims returned lost status does not show in the lost status pulldown Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 2 07:48:41 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Jan 2020 06:48:41 +0000 Subject: [Koha-bugs] [Bug 24279] Claims Returned does not work when set from moredetail.pl or additem.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24279 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #96684|0 |1 is obsolete| | --- Comment #4 from Katrin Fischer --- Created attachment 96725 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96725&action=edit Bug 24279 - Claims Returned does not work when set from additem.pl Test Plan: 1) Configure Claimes Returned 2) Apply this patch 3) Go to additem.pl for that item 4) Note the claims returned lost status does not show in the lost status pulldown Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 2 07:51:13 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Jan 2020 06:51:13 +0000 Subject: [Koha-bugs] [Bug 24279] Claims Returned does not work when set from moredetail.pl or additem.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24279 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |Manual --- Comment #5 from Katrin Fischer --- This works as a quick fix and I've signed it off. I wonder if it's transparent to the users why the value will be missing on the pull downs. Also: are there other possible loop holes if we only fix this on template level? Thinking of the REST API for one. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 2 07:56:45 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Jan 2020 06:56:45 +0000 Subject: [Koha-bugs] [Bug 24171] Cannot do automatic renewal with itemBarcodeFallbackSearch In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24171 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 2 07:56:48 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Jan 2020 06:56:48 +0000 Subject: [Koha-bugs] [Bug 24171] Cannot do automatic renewal with itemBarcodeFallbackSearch In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24171 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #96362|0 |1 is obsolete| | --- Comment #8 from Katrin Fischer --- Created attachment 96726 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96726&action=edit Bug 24171: Preserve auto_renew when triggering itemBarcodeFallbackSearch The auto_renew parameter is not sent to the template when the popup triggered by itemBarcodeFallbackSearch is displayed. Test plan: - Turn on itemBarcodeFallbackSearch - Open a patron account - Check the checkboxes for automatic-renewal - Search for a title keyword in the checkout input box - Verify that auto-renewal flag is set Note for QA: The auto_renew flag will be set in any cases. Should we expect regression? Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 2 07:56:52 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Jan 2020 06:56:52 +0000 Subject: [Koha-bugs] [Bug 24171] Cannot do automatic renewal with itemBarcodeFallbackSearch In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24171 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #96603|0 |1 is obsolete| | --- Comment #9 from Katrin Fischer --- Created attachment 96727 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96727&action=edit Bug 24171: Check auto_renew if confirmation is needed Test plan: Add some fines Check auto_renew and check an item out, using a title keyword Pick one item You get the confirmation box => Notice that the auto_renew checkbox is checked Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 2 07:57:35 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Jan 2020 06:57:35 +0000 Subject: [Koha-bugs] [Bug 24171] Cannot do automatic renewal with itemBarcodeFallbackSearch In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24171 --- Comment #10 from Katrin Fischer --- In Firefox the option appears as disabled without the 'checked', but I think this is a browser issue and disabling it makes sense when you can't remove the option in that moment. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 2 08:02:11 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Jan 2020 07:02:11 +0000 Subject: [Koha-bugs] [Bug 24244] Cannot create suggestion with branch set to 'Any' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24244 --- Comment #9 from Katrin Fischer --- (In reply to Katrin Fischer from comment #8) > (In reply to Jonathan Druart from comment #7) > > (In reply to Katrin Fischer from comment #6) > > > It appears to fix the staff side, but we still got big trouble in the OPAC: > > > - Activate anonymous suggestions for the OPAC > > > - Place a suggestion while logged out > > > - Boom! > > > > > > Broken FK constraint at /usr/share/perl5/Exception/Class/Base.pm line 88 > > > > It works for me. > > Strange :( I can retest, but thought I had made sure yesterday to restart > everything. I still see the error, double checked that I had the patches applied and 'restart_all' was done before testing. I think the problem is, that I hadn't set an Anonymous patron, it was still the default of 0. - Not sure if this is a bug we need to fix. Signing off now. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 2 08:03:31 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Jan 2020 07:03:31 +0000 Subject: [Koha-bugs] [Bug 24244] Cannot create suggestion with branch set to 'Any' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24244 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 2 08:03:35 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Jan 2020 07:03:35 +0000 Subject: [Koha-bugs] [Bug 24244] Cannot create suggestion with branch set to 'Any' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24244 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #96293|0 |1 is obsolete| | --- Comment #10 from Katrin Fischer --- Created attachment 96728 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96728&action=edit Bug 24244: Add test Signed-off-by: Jonathan Druart Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 2 08:03:38 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Jan 2020 07:03:38 +0000 Subject: [Koha-bugs] [Bug 24244] Cannot create suggestion with branch set to 'Any' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24244 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #96294|0 |1 is obsolete| | --- Comment #11 from Katrin Fischer --- Created attachment 96729 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96729&action=edit Bug 24244: Send null instead of empty string if branch not set Fix NewSuggestion if branchcode is passed with an empty string. Error was "Broken FK constraint" Test plan: Create a new suggestion, select "any" for the library. Signed-off-by: Jonathan Druart Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 2 08:04:32 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Jan 2020 07:04:32 +0000 Subject: [Koha-bugs] [Bug 24244] Cannot create suggestion with branch set to 'Any' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24244 --- Comment #12 from Katrin Fischer --- > I still see the error, double checked that I had the patches applied and > 'restart_all' was done before testing. I think the problem is, that I hadn't > set an Anonymous patron, it was still the default of 0. - Not sure if this > is a bug we need to fix. Signing off now. ... or if we want to, fix separately as the issue seems to be a different constraint? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 2 08:10:44 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Jan 2020 07:10:44 +0000 Subject: [Koha-bugs] [Bug 24326] New: Problem with advance_notices_digest.t Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24326 Bug ID: 24326 Summary: Problem with advance_notices_digest.t Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Test Suite Assignee: chris at bigballofwax.co.nz Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org Depends on: 20478 (In reply to Jonathan Druart from comment #26) > There is something terribly wrong with this test file, the cronjob script is > run outside the transaction and so changes are effective. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20478 [Bug 20478] Advance notices: send separate digest messages per library -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 2 08:10:44 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Jan 2020 07:10:44 +0000 Subject: [Koha-bugs] [Bug 20478] Advance notices: send separate digest messages per library In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20478 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |24326 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24326 [Bug 24326] Problem with advance_notices_digest.t -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 2 08:11:30 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Jan 2020 07:11:30 +0000 Subject: [Koha-bugs] [Bug 20478] Advance notices: send separate digest messages per library In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20478 --- Comment #29 from Katrin Fischer --- (In reply to Martin Renvoize from comment #28) > Agreed, we should create a distinct bug for this.. I've created a bug, but not sure I got it right: Bug 24326 - Problem with advance_notices_digest.t -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 2 08:13:53 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Jan 2020 07:13:53 +0000 Subject: [Koha-bugs] [Bug 24254] Add Koha::Biblio get_visible_items method In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24254 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #2 from Katrin Fischer --- Hi Nick, should this be NSO? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 2 08:27:54 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Jan 2020 07:27:54 +0000 Subject: [Koha-bugs] [Bug 23839] Several dead links on community web site In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23839 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|NEW |RESOLVED --- Comment #1 from Katrin Fischer --- 1) I've commented out Nextpress with a note to this bug. I couldn't access it - the site appears to have some problems at the moment. 2) The Slideshare link appears to be working correctly now. 3) I've updated the Bywater Solutions links. Changes were necessary because of their new website. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 2 09:47:33 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Jan 2020 08:47:33 +0000 Subject: [Koha-bugs] [Bug 24177] Internal Server error when clicking cash register (Report) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24177 --- Comment #12 from Govind Basedia --- Dear sir I am upgrade koha 19.11.00 to 19.11.01 but no upgrade your site.please check Many time install koha common but version no change. Koha version: 19.11.00.000 OS version ('uname -a'): Linux koha-desktop 4.15.0-72-generic #81~16.04.1-Ubuntu SMP Tue Nov 26 16:30:00 UTC 2019 i686 Perl interpreter: /usr/bin/perl Perl version: 5.022001 Perl @INC: /usr/share/koha/lib /usr/share/koha/installer /usr/share/koha/lib/installer /etc/perl /usr/local/lib/i386-linux-gnu/perl/5.22.1 /usr/local/share/perl/5.22.1 /usr/lib/i386-linux-gnu/perl5/5.22 /usr/share/perl5 /usr/lib/i386-linux-gnu/perl/5.22 /usr/share/perl/5.22 /usr/local/lib/site_perl /usr/lib/i386-linux-gnu/perl-base . /var/lib/koha/library/plugins MySQL version: mysql Ver 14.14 Distrib 5.7.28, for Linux (i686) using EditLine wrapper Apache version: Server version: Apache/2.4.18 (Ubuntu) PSGI: Plack (deployment) Memcached: Servers: 127.0.0.1:11211 | Namespace: koha_library | Status: running. | Config read from: koha-conf.xml Zebra version: Zebra 2.0.59 (C) 1994-2014, Index Data Zebra is free software, covered by the GNU General Public License, and you are welcome to change it and/or distribute copies of it under certain conditions. SHA1 ID: c00bfddbf0f3608340d61298acc61dafb167f9b2 Using ICU Date and time: 12/31/2019 15:06 Time zone: Used: Asia/Kolkata | Config: Undefined | Environment (TZ): Undefined -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 2 09:51:08 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Jan 2020 08:51:08 +0000 Subject: [Koha-bugs] [Bug 24177] Internal Server error when clicking cash register (Report) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24177 --- Comment #13 from Katrin Fischer --- (In reply to Govind Basedia from comment #12) > Dear sir > I am upgrade koha 19.11.00 to 19.11.01 but no upgrade your site.please check > Many time install koha common but version no change. > It's possible that the Debian packages have not been built yet - so actually your Koha version is still on 19.11.00 with the bug. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 2 10:27:16 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Jan 2020 09:27:16 +0000 Subject: [Koha-bugs] [Bug 24177] Internal Server error when clicking cash register (Report) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24177 --- Comment #14 from Govind Basedia --- koha at koha-V520-15IKL:~$ sudo apt-get install koha-common [sudo] password for koha: Reading package lists... Done Building dependency tree Reading state information... Done koha-common is already the newest version (19.11.00-1). The following packages were automatically installed and are no longer required: libncursesw5 libtinfo5 Use 'sudo apt autoremove' to remove them. 0 upgraded, 0 newly installed, 0 to remove and 0 not upgraded. koha at koha-V520-15IKL:~$ -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 2 10:57:51 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Jan 2020 09:57:51 +0000 Subject: [Koha-bugs] [Bug 24177] Internal Server error when clicking cash register (Report) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24177 --- Comment #15 from Katrin Fischer --- (In reply to Govind Basedia from comment #14) > koha at koha-V520-15IKL:~$ sudo apt-get install koha-common > [sudo] password for koha: > Reading package lists... Done > Building dependency tree > Reading state information... Done > koha-common is already the newest version (19.11.00-1). > The following packages were automatically installed and are no longer > required: > libncursesw5 libtinfo5 > Use 'sudo apt autoremove' to remove them. > 0 upgraded, 0 newly installed, 0 to remove and 0 not upgraded. > koha at koha-V520-15IKL:~$ There are no packages for .01 yet, please try again in a few days. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 2 11:37:32 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Jan 2020 10:37:32 +0000 Subject: [Koha-bugs] [Bug 24327] New: anonymous suggestions should not be allowed if AnonymousPatron misconfigured Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24327 Bug ID: 24327 Summary: anonymous suggestions should not be allowed if AnonymousPatron misconfigured Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: OPAC Assignee: jonathan.druart at bugs.koha-community.org Reporter: jonathan.druart at bugs.koha-community.org QA Contact: testopia at bugs.koha-community.org If anonymous suggestions (AnonSuggestions) are allowed but AnonymousPatron is not set correctly, it's possible to create a suggestion without being logged in and the app explodes with a FK constraint: DBD::mysql::st execute failed: Cannot add or update a child row: a foreign key constraint fails (`koha_kohadev`.`suggestions`, CONSTRAINT `suggestions_ibfk_suggestedby` FOREIGN KEY (`suggestedby`) REFERENCES `bo rrowers` (`borrowernumber`) ON DELETE SET NULL ON UPDATE CASCADE) [for Statement "INSERT INTO `suggestions` ( `STATUS`, `author`, `branchcode`, `collectiontitle`, `copyrightdate`, `isbn`, `itemtype`, `note`, `pa tronreason`, `place`, `publishercode`, `quantity`, `suggestedby`, `suggesteddate`, `title`) VALUES ( ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ? )" with ParamValues: 0="ASKED", 1="", 2=undef, 3="", 4=undef, 5="" , 6="AUDIOBOOK", 7="", 8="", 9="", 10="", 11=undef, 12="0", 13='2020-01-02T10:28:40', 14="xxx"] at /usr/share/perl5/DBIx/Class/Storage/DBI.pm line 1836. Broken FK constraint at /usr/share/perl5/Exception/Class/Base.pm line 88 Exception::Class::Base::throw('Koha::Exceptions::Object::FKConstraint', 'error', 'Broken FK constraint', 'broken_fk', 'suggestedby') called at /kohadevbox/koha/Koha/Object.pm line 164 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 2 11:37:49 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Jan 2020 10:37:49 +0000 Subject: [Koha-bugs] [Bug 24244] Cannot create suggestion with branch set to 'Any' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24244 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=24327 --- Comment #13 from Jonathan Druart --- (In reply to Katrin Fischer from comment #6) > It appears to fix the staff side, but we still got big trouble in the OPAC: > - Activate anonymous suggestions for the OPAC > - Place a suggestion while logged out > - Boom! > > Broken FK constraint at /usr/share/perl5/Exception/Class/Base.pm line 88 Opened bug 24327. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 2 11:37:49 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Jan 2020 10:37:49 +0000 Subject: [Koha-bugs] [Bug 24327] anonymous suggestions should not be allowed if AnonymousPatron misconfigured In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24327 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=24244 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 2 11:43:25 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Jan 2020 10:43:25 +0000 Subject: [Koha-bugs] [Bug 24327] anonymous suggestions should not be allowed if AnonymousPatron misconfigured In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24327 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 2 11:43:28 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Jan 2020 10:43:28 +0000 Subject: [Koha-bugs] [Bug 24327] anonymous suggestions should not be allowed if AnonymousPatron misconfigured In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24327 --- Comment #1 from Jonathan Druart --- Created attachment 96730 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96730&action=edit Bug 24327: Add warning to the about page is AnonSugggestions but AnonymousPatron This patch adds a warning to the about page if AnonSuggestions is set but AnonymousPatron. Test plan: Turn on AnonSuggestions and set AnonymousPatron to 0 => You see a warning on the about page Turn on AnonSuggestions and set AnonymousPatron to an invalid value => You see a warning on the about page Turn off AnonSuggestions => No warning Turn on AnonSuggestions and set AnonymousPatron to a valid value => No warning -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 2 11:43:31 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Jan 2020 10:43:31 +0000 Subject: [Koha-bugs] [Bug 24327] anonymous suggestions should not be allowed if AnonymousPatron misconfigured In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24327 --- Comment #2 from Jonathan Druart --- Created attachment 96731 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96731&action=edit Bug 24327: Redirect to the login form if AnonSuggestion misconfigured Test plan: Turn on AnonSuggestion but set AnonymousPatron to an invalid value Go to /cgi-bin/koha/opac-suggestions.pl?op=add => You see the login form -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 2 12:16:34 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Jan 2020 11:16:34 +0000 Subject: [Koha-bugs] [Bug 24294] Creating an order with ACQ framework using 00x fields doesn't work In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24294 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jan 2 12:16:37 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Jan 2020 11:16:37 +0000 Subject: [Koha-bugs] [Bug 24294] Creating an order with ACQ framework using 00x fields doesn't work In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24294 --- Comment #3 from Jonathan Druart --- Created attachment 96732 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96732&action=edit Bug 24294: Add default value support for control fields in ACQ framework When trying to add an order using the ACQ framework with a 008@ tag, Koha explodes: Control fields (generally, just tags below 010) do not have subfields, use data() at /home/vagrant/kohaclone/C4/Acquisition.pm line 3272. Test plan: Set a default value for a control field in the ACQ framework Turn on UseACQFrameworkForBiblioRecords Create a new order from a new record The default value should be displayed Save => No crash -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 2 12:23:21 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Jan 2020 11:23:21 +0000 Subject: [Koha-bugs] [Bug 24316] Fix non-English web installers by removing obsolete authorised value MANUAL_INV In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24316 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #7 from Jonathan Druart --- Should not we remove it (again) for existing installs? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 2 12:40:58 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Jan 2020 11:40:58 +0000 Subject: [Koha-bugs] [Bug 24264] Elasticsearch - Cannot search for genre/form authorities In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24264 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 2 12:41:02 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Jan 2020 11:41:02 +0000 Subject: [Koha-bugs] [Bug 24264] Elasticsearch - Cannot search for genre/form authorities In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24264 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #96694|0 |1 is obsolete| | --- Comment #7 from Jonathan Druart --- Created attachment 96733 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96733&action=edit Bug 24264: Use raw field when limiting by authtype To test: 1 - Have a genre form record in your authorities file 2 - Search authorities for 'Default' 3 - The result is returned 4 - Set the dropdown to 'Genre/Form' and search matchign term 5 - No results 6 - Apply patch 7 - Restart all the things 8 - Repeat search for 'Genre/Form' and search matching term 9 - Record is returned Signed-off-by: Myka Kennedy Stephens Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 2 12:51:28 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Jan 2020 11:51:28 +0000 Subject: [Koha-bugs] [Bug 24314] Update de-DE MARC21 frameworks for updates 28+29 (May and November 2019) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24314 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #6 from Jonathan Druart --- authorities_normal_marc21.sql - Still getting DBD::mysql::st execute failed: Incorrect integer value: '' for column `koha_kohadev`.`auth_subfield_structure`.`linkid` at row 34 at /usr/share/perl5/DBIx/RunSQL.pm line 273. But not related to this patch. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 2 12:51:50 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Jan 2020 11:51:50 +0000 Subject: [Koha-bugs] [Bug 24314] Update de-DE MARC21 frameworks for updates 28+29 (May and November 2019) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24314 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 2 12:51:53 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Jan 2020 11:51:53 +0000 Subject: [Koha-bugs] [Bug 24314] Update de-DE MARC21 frameworks for updates 28+29 (May and November 2019) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24314 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #96676|0 |1 is obsolete| | --- Comment #7 from Jonathan Druart --- Created attachment 96734 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96734&action=edit Bug 24314: Update de-DE MARC21 frameworks for updates 28+29 (May and November 2019) This updates the MARC framework files in the de-DE (German) installer to the latest MARC standard. The files also include some translation changes and fixes. Files have been generated using the po files on translate.koha-community.org. To test: - Run the de-DE installer on a fresh database - Verify that all files are installed without errors - Verify that the frameworks are correctly in place Signed-off-by: Bernardo Gonzalez Kriegel MARC21 files load without problems, no qa errors. Loaded into 'en' install (delete fw then load) all frameworks look good. Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 2 13:01:19 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Jan 2020 12:01:19 +0000 Subject: [Koha-bugs] [Bug 24327] Anonymous suggestions should not be allowed if AnonymousPatron misconfigured In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24327 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|anonymous suggestions |Anonymous suggestions |should not be allowed if |should not be allowed if |AnonymousPatron |AnonymousPatron |misconfigured |misconfigured CC| |katrin.fischer at bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 2 13:03:52 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Jan 2020 12:03:52 +0000 Subject: [Koha-bugs] [Bug 24316] Fix non-English web installers by removing obsolete authorised value MANUAL_INV In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24316 --- Comment #8 from Katrin Fischer --- I think it's ok - since the authorised_value category was missing, this shoudl not have been installed in fresh installations. And for everyone updating it would have worked correctly, only fresh 19.11 would be in danger (and the sql was broken there). But we can still.. not blocking :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 2 13:10:07 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Jan 2020 12:10:07 +0000 Subject: [Koha-bugs] [Bug 17258] [OMNIBUS] MySQL 5.7 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17258 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |24137 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24137 [Bug 24137] Marc21 bibliographic fails to install for ru-Ru and uk-UA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 2 13:10:07 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Jan 2020 12:10:07 +0000 Subject: [Koha-bugs] [Bug 24137] Marc21 bibliographic fails to install for ru-Ru and uk-UA In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24137 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |17258 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17258 [Bug 17258] [OMNIBUS] MySQL 5.7 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 2 13:11:54 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Jan 2020 12:11:54 +0000 Subject: [Koha-bugs] [Bug 24328] New: Bibliographic frameworks fail to install Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24328 Bug ID: 24328 Summary: Bibliographic frameworks fail to install Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: Installation and upgrade (command-line installer) Assignee: jonathan.druart at bugs.koha-community.org Reporter: jonathan.druart at bugs.koha-community.org QA Contact: testopia at bugs.koha-community.org Blocks: 17258 With strict mode enabled (tested with MariaDB 10.4.11) ERROR 1366 (22007) at line 8029: Incorrect integer value: '' for column `koha_kohadev`.`auth_subfield_structure`.`linkid` at row 769 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17258 [Bug 17258] [OMNIBUS] MySQL 5.7 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 2 13:11:54 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Jan 2020 12:11:54 +0000 Subject: [Koha-bugs] [Bug 17258] [OMNIBUS] MySQL 5.7 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17258 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |24328 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24328 [Bug 24328] Bibliographic frameworks fail to install -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 2 13:12:29 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Jan 2020 12:12:29 +0000 Subject: [Koha-bugs] [Bug 24137] Marc21 bibliographic fails to install for ru-Ru and uk-UA In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24137 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=24328 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 2 13:12:29 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Jan 2020 12:12:29 +0000 Subject: [Koha-bugs] [Bug 24328] Bibliographic frameworks fail to install In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24328 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=24137 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 2 13:14:33 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Jan 2020 12:14:33 +0000 Subject: [Koha-bugs] [Bug 24328] Bibliographic frameworks fail to install In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24328 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 2 13:17:00 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Jan 2020 12:17:00 +0000 Subject: [Koha-bugs] [Bug 24264] Elasticsearch - Cannot search for genre/form authorities In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24264 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas at bywatersolutions.com, | |martin.renvoize at ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 2 13:17:25 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Jan 2020 12:17:25 +0000 Subject: [Koha-bugs] [Bug 24328] Bibliographic frameworks fail to install In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24328 --- Comment #1 from Jonathan Druart --- Created attachment 96735 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96735&action=edit Bug 24328: Fix bibliographic frameworks install (linkid) Had to gunzip this, otherwise I get a 413. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 2 13:18:40 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Jan 2020 12:18:40 +0000 Subject: [Koha-bugs] [Bug 24328] Bibliographic frameworks fail to install In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24328 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |24312, 24314 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24312 [Bug 24312] Update MARC21 frameworks to Updates 28+29 (May and November 2019) https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24314 [Bug 24314] Update de-DE MARC21 frameworks for updates 28+29 (May and November 2019) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 2 13:18:40 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Jan 2020 12:18:40 +0000 Subject: [Koha-bugs] [Bug 24312] Update MARC21 frameworks to Updates 28+29 (May and November 2019) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24312 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |24328 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24328 [Bug 24328] Bibliographic frameworks fail to install -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 2 13:18:40 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Jan 2020 12:18:40 +0000 Subject: [Koha-bugs] [Bug 24314] Update de-DE MARC21 frameworks for updates 28+29 (May and November 2019) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24314 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |24328 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24328 [Bug 24328] Bibliographic frameworks fail to install -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 2 13:19:12 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Jan 2020 12:19:12 +0000 Subject: [Koha-bugs] [Bug 24314] Update de-DE MARC21 frameworks for updates 28+29 (May and November 2019) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24314 --- Comment #8 from Jonathan Druart --- (In reply to Jonathan Druart from comment #6) > authorities_normal_marc21.sql - Still getting > DBD::mysql::st execute failed: Incorrect integer value: '' for column > `koha_kohadev`.`auth_subfield_structure`.`linkid` at row 34 at > /usr/share/perl5/DBIx/RunSQL.pm line 273. > > But not related to this patch. See bug 24328. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 2 13:19:20 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Jan 2020 12:19:20 +0000 Subject: [Koha-bugs] [Bug 24244] Cannot create suggestion with branch set to 'Any' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24244 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |20.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 2 13:19:22 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Jan 2020 12:19:22 +0000 Subject: [Koha-bugs] [Bug 24244] Cannot create suggestion with branch set to 'Any' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24244 --- Comment #14 from Martin Renvoize --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 2 13:19:24 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Jan 2020 12:19:24 +0000 Subject: [Koha-bugs] [Bug 24282] SCSS conversion broke style in search results item status In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24282 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |20.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 2 13:19:25 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Jan 2020 12:19:25 +0000 Subject: [Koha-bugs] [Bug 24282] SCSS conversion broke style in search results item status In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24282 --- Comment #5 from Martin Renvoize --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 2 13:19:27 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Jan 2020 12:19:27 +0000 Subject: [Koha-bugs] [Bug 24317] Sample patron data not loading for non-English installations In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24317 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |20.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 2 13:19:29 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Jan 2020 12:19:29 +0000 Subject: [Koha-bugs] [Bug 24317] Sample patron data not loading for non-English installations In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24317 --- Comment #5 from Martin Renvoize --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 2 13:21:44 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Jan 2020 12:21:44 +0000 Subject: [Koha-bugs] [Bug 24316] Fix non-English web installers by removing obsolete authorised value MANUAL_INV In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24316 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 2 13:21:48 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Jan 2020 12:21:48 +0000 Subject: [Koha-bugs] [Bug 24316] Fix non-English web installers by removing obsolete authorised value MANUAL_INV In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24316 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #96692|0 |1 is obsolete| | Attachment #96699|0 |1 is obsolete| | --- Comment #9 from Jonathan Druart --- Created attachment 96736 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96736&action=edit Bug 24316: Remove obsolete sample data for MANUAL_INV authorised value Bug 23049 replaced the MANUAL_INV authorised value by a dedicated table, but missed to remove the authorised value sample data from the non-English installers. This patch corrects this oversight. Note: The German (de-DE) file was changed a bit more, adding 2 missing translations for the new RETURN_CLAIM_RESOLUTION and to match the sequence of the en file. To test: - Verify the SQL file changes are valid by loading those files OR - Run the installers for each language on an empty database - Verify there is no error loading the optional authorised value data Signed-off-by: Bernardo Gonzalez Kriegel Tested with 24317 and a small followup for this bug for es-ES Tested doing clean install for de-DE es-ES fr-CA it-IT nb-NO pl-PL up to loading of all mandatory & optional data. All languages load without problems. Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 2 13:21:51 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Jan 2020 12:21:51 +0000 Subject: [Koha-bugs] [Bug 24316] Fix non-English web installers by removing obsolete authorised value MANUAL_INV In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24316 --- Comment #10 from Jonathan Druart --- Created attachment 96737 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96737&action=edit Bug 24316: (follow up) Fix es-ES web installer Same correction, as other languages, removing obsolete authorised value MANUAL_INV. Same test Signed-off-by: Katrin Fischer Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 2 13:23:36 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Jan 2020 12:23:36 +0000 Subject: [Koha-bugs] [Bug 7882] Add ability to move and reorder fields in MARC editor In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7882 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 2 13:24:18 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Jan 2020 12:24:18 +0000 Subject: [Koha-bugs] [Bug 18355] Add 'permanent location' alongside 'shelving location' when located on cart In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18355 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Permanent location should |Add 'permanent location' |show with cart location |alongside 'shelving | |location' when located on | |cart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 2 13:26:30 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Jan 2020 12:26:30 +0000 Subject: [Koha-bugs] [Bug 18355] Add 'permanent location' alongside 'shelving location' when located on cart In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18355 --- Comment #46 from Martin Renvoize --- Currently awaiting QA of bug 21466 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 2 13:27:01 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Jan 2020 12:27:01 +0000 Subject: [Koha-bugs] [Bug 23783] Add display of languages from MARC21 field 041 to the OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23783 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com Summary|Show languages from MARC21 |Add display of languages |field 041 in OPAC |from MARC21 field 041 to | |the OPAC -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 2 13:27:43 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Jan 2020 12:27:43 +0000 Subject: [Koha-bugs] [Bug 23783] Add display of languages from MARC21 field 041 to the OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23783 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This enhancement adds release notes| |display handling for the | |MARC21 041 field, | |languages, into the OPAC. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 2 13:28:43 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Jan 2020 12:28:43 +0000 Subject: [Koha-bugs] [Bug 23783] Add display of languages from MARC21 field 041 to the OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23783 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the|This enhancement adds |This enhancement adds release notes|display handling for the |display handling for the |MARC21 041 field, |041 MARC21 languages field, |languages, into the OPAC. |into the OPAC results and | |item details pages. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 2 13:38:48 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Jan 2020 12:38:48 +0000 Subject: [Koha-bugs] [Bug 3820] More detailed patron record changes log In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3820 --- Comment #45 from Nick Clemens --- Just a note on this one: the DB rev for cardnumber changes has a side effect of updating the timestamp in the logs - historical changes are going to be lost by this upgrade as they will now all appear to have been done at upgrade time. We will still have the historical cardnumber, I am not sure if this is worth filing as a bug -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 2 13:39:43 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Jan 2020 12:39:43 +0000 Subject: [Koha-bugs] [Bug 10469] Display more when editing subfields in frameworks In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10469 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 2 13:39:46 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Jan 2020 12:39:46 +0000 Subject: [Koha-bugs] [Bug 10469] Display more when editing subfields in frameworks In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10469 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #96690|0 |1 is obsolete| | --- Comment #6 from Jonathan Druart --- Created attachment 96738 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96738&action=edit Bug 10469: Display more when editing subfields in frameworks This patch removes the accordion feature from the MARC subfields structure editor. The form is not long, and I think in this case the accordion makes the process more difficult to navigate. To test, apply the patch and go to Administration -> MARC frameworks -> Framework structure -> Subfield structure -> Edit. Choose a tag with multiple subfields to best test the changes. The whole form should apppear, and tabs functionality should work correctly. Test that making changes under multiple tabs works correctly. Signed-off-by: Katrin Fischer Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 2 13:43:39 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Jan 2020 12:43:39 +0000 Subject: [Koha-bugs] [Bug 24329] New: Patron cardnumbre change times are lost during upgrade for bug 3820 Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24329 Bug ID: 24329 Summary: Patron cardnumbre change times are lost during upgrade for bug 3820 Change sponsored?: --- Product: Koha Version: master Hardware: PC OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: System Administration Assignee: koha-bugs at lists.koha-community.org Reporter: martin.renvoize at ptfs-europe.com QA Contact: testopia at bugs.koha-community.org CC: barton at bywatersolutions.com, baselibrary.consortium at nhs.net, dcook at prosentient.com.au, emma.perks at heartofengland.nhs.uk, fiona.borthwick at ptfs-europe.com, gmcharlt at gmail.com, josef.moravec at gmail.com, katrin.fischer at bsz-bw.de, kyle at bywatersolutions.com, martin.renvoize at ptfs-europe.com, nengard at gmail.com, nick at bywatersolutions.com, pe.havel at gmail.com Depends on: 3820 The DB rev for cardnumber changes on bug 3820 has a side effect of updating the timestamp in the logs - historical changes are going to be lost by this upgrade as they will now all appear to have been done at upgrade time. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3820 [Bug 3820] More detailed patron record changes log -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jan 2 13:43:39 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Jan 2020 12:43:39 +0000 Subject: [Koha-bugs] [Bug 3820] More detailed patron record changes log In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3820 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |24329 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24329 [Bug 24329] Patron cardnumbre change times are lost during upgrade for bug 3820 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 2 13:43:50 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Jan 2020 12:43:50 +0000 Subject: [Koha-bugs] [Bug 24329] Patron cardnumbre change times are lost during upgrade for bug 3820 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24329 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |major -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 2 13:43:56 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Jan 2020 12:43:56 +0000 Subject: [Koha-bugs] [Bug 24329] Patron cardnumbre change times are lost during upgrade for bug 3820 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24329 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the|This enhancement will add a | release notes|log of the specific fields | |that were changed when | |modifying/editing a patron, | |including the before and | |after values for each | |updated field. | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jan 2 13:45:50 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Jan 2020 12:45:50 +0000 Subject: [Koha-bugs] [Bug 14973] Suggestions - Search and warn user about existing biblio when submitting a suggestion In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14973 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |20.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 2 13:45:53 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Jan 2020 12:45:53 +0000 Subject: [Koha-bugs] [Bug 14973] Suggestions - Search and warn user about existing biblio when submitting a suggestion In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14973 --- Comment #61 from Martin Renvoize --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 2 13:45:55 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Jan 2020 12:45:55 +0000 Subject: [Koha-bugs] [Bug 23783] Add display of languages from MARC21 field 041 to the OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23783 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |20.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 2 13:45:57 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Jan 2020 12:45:57 +0000 Subject: [Koha-bugs] [Bug 23783] Add display of languages from MARC21 field 041 to the OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23783 --- Comment #5 from Martin Renvoize --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 2 13:46:22 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Jan 2020 12:46:22 +0000 Subject: [Koha-bugs] [Bug 14973] Suggestions - Search and warn user about existing biblio when submitting a suggestion In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14973 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_20_05_target | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 2 13:46:51 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Jan 2020 12:46:51 +0000 Subject: [Koha-bugs] [Bug 14973] Suggestions - Search and warn user about existing biblio when submitting a suggestion In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14973 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |new feature -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 2 13:47:04 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Jan 2020 12:47:04 +0000 Subject: [Koha-bugs] [Bug 24312] Update MARC21 frameworks to Updates 28+29 (May and November 2019) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24312 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #4 from Jonathan Druart --- Should not we update the other languages as well? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 2 13:47:54 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Jan 2020 12:47:54 +0000 Subject: [Koha-bugs] [Bug 14973] Suggestions - Search and warn user about existing biblio when submitting a suggestion In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14973 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This new feature adds a release notes| |warning to the suggestions | |process to alert the user | |to the presence of an | |apparent holding that | |already satisfies the | |suggestion they are about | |to submit. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 2 13:49:39 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Jan 2020 12:49:39 +0000 Subject: [Koha-bugs] [Bug 14973] Add an alert during purchase suggestion submissions to warn the user when an existing biblio appears to satisfy the request In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14973 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Suggestions - Search and |Add an alert during |warn user about existing |purchase suggestion |biblio when submitting a |submissions to warn the |suggestion |user when an existing | |biblio appears to satisfy | |the request -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 2 14:03:53 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Jan 2020 13:03:53 +0000 Subject: [Koha-bugs] [Bug 24329] Patron cardnumbre change times are lost during upgrade for bug 3820 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24329 --- Comment #1 from Martin Renvoize --- Created attachment 96739 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96739&action=edit Bug 24329: Correction to updatedatabase Ensure timestamp is not overwriteen during upgrade when applying updates for bug 3820 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jan 2 14:03:56 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Jan 2020 13:03:56 +0000 Subject: [Koha-bugs] [Bug 24329] Patron cardnumbre change times are lost during upgrade for bug 3820 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24329 --- Comment #2 from Martin Renvoize --- Created attachment 96740 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96740&action=edit Bug 24329: Prevent update of timestamp on action_logs updates -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jan 2 14:04:14 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Jan 2020 13:04:14 +0000 Subject: [Koha-bugs] [Bug 24329] Patron cardnumbre change times are lost during upgrade for bug 3820 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24329 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 2 14:06:02 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Jan 2020 13:06:02 +0000 Subject: [Koha-bugs] [Bug 24267] C4::Breeding::ImportBreedingAuth is ineffective In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24267 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 2 14:06:06 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Jan 2020 13:06:06 +0000 Subject: [Koha-bugs] [Bug 24267] C4::Breeding::ImportBreedingAuth is ineffective In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24267 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #96502|0 |1 is obsolete| | Attachment #96503|0 |1 is obsolete| | Attachment #96504|0 |1 is obsolete| | --- Comment #12 from Jonathan Druart --- Created attachment 96741 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96741&action=edit Bug 24267: Improve ImportBreedingAuth git grep ImportBreedingAuth - there is only one call to this routine from SearchZ3950Auth We pass it a MARC record, '2' for overwrite_auth We then check for this record in the DB and get the breeding id, however, when overwrite_auth is 2 we always add the auth to the batch and return the new breeding id. We don't actually use any of the other parameters returned here either To recreate: 1 - Browse to Authorities 2 - Select New form Z3950 3 - Perform a search that returns results 4 - SELECT COUNT(*) FROM import_auths 5 - Repeat the search 6 - SELECT COUNT(*) FROM import_auths 7 - There are 20 more records 8 - SELECT * FROM import_auths - note the repeated rows Signed-off-by: Marcel de Rooy Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 2 14:06:09 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Jan 2020 13:06:09 +0000 Subject: [Koha-bugs] [Bug 24267] C4::Breeding::ImportBreedingAuth is ineffective In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24267 --- Comment #13 from Jonathan Druart --- Created attachment 96742 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96742&action=edit Bug 24267: Unit tests Signed-off-by: Marcel de Rooy Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 2 14:06:13 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Jan 2020 13:06:13 +0000 Subject: [Koha-bugs] [Bug 24267] C4::Breeding::ImportBreedingAuth is ineffective In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24267 --- Comment #14 from Jonathan Druart --- Created attachment 96743 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96743&action=edit Bug 24267: (QA follow-up) Remove two calls, add transaction Call to GetAuthorizedHeading is already done just before calling ImportBreedingAuth. Call to GuessAuthTypeCode is not used. Adding transaction to test (check your database, kidclamp ;) Test plan: Add new authority via Z3950 in the interface. Run t/db_dependent/Breeding.t Signed-off-by: Marcel de Rooy Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 2 14:12:04 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Jan 2020 13:12:04 +0000 Subject: [Koha-bugs] [Bug 14963] Add the ability to suggest purchase from existing titles In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14963 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Ability to suggest purchase |Add the ability to suggest |on existing catalogue |purchase from existing |record |titles CC| |martin.renvoize at ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 2 14:12:58 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Jan 2020 13:12:58 +0000 Subject: [Koha-bugs] [Bug 14963] Add the ability to suggest purchase from existing titles In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14963 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This new feature adds the release notes| |ability to create a new | |purchase suggestion from an | |existing catalogue record. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 2 14:16:01 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Jan 2020 13:16:01 +0000 Subject: [Koha-bugs] [Bug 14963] Add the ability to suggest purchase from existing titles In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14963 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |20.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 2 14:16:03 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Jan 2020 13:16:03 +0000 Subject: [Koha-bugs] [Bug 14963] Add the ability to suggest purchase from existing titles In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14963 --- Comment #27 from Martin Renvoize --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 2 14:16:06 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Jan 2020 13:16:06 +0000 Subject: [Koha-bugs] [Bug 14973] Add an alert during purchase suggestion submissions to warn the user when an existing biblio appears to satisfy the request In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14973 --- Comment #62 from Martin Renvoize --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 2 14:30:42 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Jan 2020 13:30:42 +0000 Subject: [Koha-bugs] [Bug 18433] Allow to select results to export in item search In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18433 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #33 from Jonathan Druart --- (In reply to Owen Leonard from comment #27) > I agree with Jonathan that the best behavior would be to allow the user to > select items on multiple pages and have it remember across pages. I say this > not knowing how difficult it might be to implement it. > > At the very least the "Export selected results" button should return to its > default state if the first page of selections is getting lost, but I don't > think it's enough. This is still valid. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 2 14:30:51 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Jan 2020 13:30:51 +0000 Subject: [Koha-bugs] [Bug 24329] Patron cardnumber change times are lost during upgrade for bug 3820 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24329 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Patron cardnumbre change |Patron cardnumber change |times are lost during |times are lost during |upgrade for bug 3820 |upgrade for bug 3820 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jan 2 14:32:22 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Jan 2020 13:32:22 +0000 Subject: [Koha-bugs] [Bug 24312] Update MARC21 frameworks to Updates 28+29 (May and November 2019) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24312 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #5 from Katrin Fischer --- (In reply to Jonathan Druart from comment #4) > Should not we update the other languages as well? Bernardo sent the information to the koha-translate mailing list that there are not strings to translate - I'd maybe give it a bit longer so we catch more translations. - Say 2 weeks? (holidays...) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 2 14:58:55 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Jan 2020 13:58:55 +0000 Subject: [Koha-bugs] [Bug 21520] More complex OAI sets mappings In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21520 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org Status|Signed Off |Failed QA --- Comment #6 from Jonathan Druart --- Hi Matts, A couple QA remarks: 1. FAIL koha-tmpl/intranet-tmpl/prog/en/modules/admin/oai_set_mappings.tt FAIL tt_valid lines 49, 50, 77, 78 You are not allowed to build a HTML tag using TT conditional as it breaks the translator script. 2. update database: a. rule_order is always null, is that expected? b. first rule should have a null for "rule_operator", isn't it? Before: +--------+-----------+--------------+----------+-----------+ | set_id | marcfield | marcsubfield | operator | marcvalue | +--------+-----------+--------------+----------+-----------+ | 3 | 100 | a | equal | pouet | | 3 | 200 | a | equal | pouet | | 3 | 300 | a | equal | pouet | +--------+-----------+--------------+----------+-----------+ After the update: +--------+------------+---------------+-----------+--------------+----------+-----------+ | set_id | rule_order | rule_operator | marcfield | marcsubfield | operator | marcvalue | +--------+------------+---------------+-----------+--------------+----------+-----------+ | 3 | NULL | or | 100 | a | equal | pouet | | 3 | NULL | or | 200 | a | equal | pouet | | 3 | NULL | or | 300 | a | equal | pouet | +--------+------------+---------------+-----------+--------------+----------+-----------+ -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jan 2 14:59:06 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Jan 2020 13:59:06 +0000 Subject: [Koha-bugs] [Bug 21520] More complex OAI sets mappings In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21520 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |matthias.meusburger at biblibr |ity.org |e.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jan 2 15:01:31 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Jan 2020 14:01:31 +0000 Subject: [Koha-bugs] [Bug 24308] Suggestions table on suggestions.pl should have separate columns for dates In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24308 --- Comment #5 from Owen Leonard --- Just for reference, here is the method we've used most commonly: https://wiki.koha-community.org/wiki/DataTables_HowTo#Sorting_dates_regardless_of_date_format_preference We added the "title-string" sorting method when we were on DataTables 1.9.x. The use of HTML5 data attributes was introduced with DataTables v1.10.5, after the other method had become our standard. There's no reason not to switch to this more up-to-date sorting configuration especially since it's built into DataTables instead of relying on an addition. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 2 15:04:37 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Jan 2020 14:04:37 +0000 Subject: [Koha-bugs] [Bug 24321] Make objects.search use mappings from Koha::Object(s) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24321 --- Comment #21 from Tomás Cohen Arazi --- Created attachment 96744 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96744&action=edit Bug 24321: Clean /patrons -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 2 15:04:40 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Jan 2020 14:04:40 +0000 Subject: [Koha-bugs] [Bug 24308] Suggestions table on suggestions.pl should have separate columns for dates In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24308 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 2 15:04:43 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Jan 2020 14:04:43 +0000 Subject: [Koha-bugs] [Bug 24308] Suggestions table on suggestions.pl should have separate columns for dates In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24308 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #96642|0 |1 is obsolete| | --- Comment #6 from Owen Leonard --- Created attachment 96745 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96745&action=edit Bug 24308: Suggestions table on suggestions.pl should have separate columns for dates Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 2 15:05:13 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Jan 2020 14:05:13 +0000 Subject: [Koha-bugs] [Bug 24321] Make objects.search use mappings from Koha::Object(s) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24321 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Change sponsored?|--- |Sponsored Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 2 15:05:41 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Jan 2020 14:05:41 +0000 Subject: [Koha-bugs] [Bug 24267] C4::Breeding::ImportBreedingAuth is ineffective In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24267 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |20.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 2 15:05:42 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Jan 2020 14:05:42 +0000 Subject: [Koha-bugs] [Bug 24267] C4::Breeding::ImportBreedingAuth is ineffective In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24267 --- Comment #15 from Martin Renvoize --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 2 15:05:44 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Jan 2020 14:05:44 +0000 Subject: [Koha-bugs] [Bug 24316] Fix non-English web installers by removing obsolete authorised value MANUAL_INV In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24316 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |20.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 2 15:05:46 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Jan 2020 14:05:46 +0000 Subject: [Koha-bugs] [Bug 24316] Fix non-English web installers by removing obsolete authorised value MANUAL_INV In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24316 --- Comment #11 from Martin Renvoize --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 2 15:07:53 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Jan 2020 14:07:53 +0000 Subject: [Koha-bugs] [Bug 24321] Make objects.search use mappings from Koha::Object(s) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24321 --- Comment #22 from Tomás Cohen Arazi --- Full test plan: - Apply this patchset and run: $ kshell k$ prove t/db_dependent/Koha/Objects.t \ t/Koha/REST/Plugin/Query.t \ t/db_dependent/Koha/REST/Plugin/Objects.t \ t/db_dependent/api/v1 => SUCCESS: Tests pass! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 2 15:09:01 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Jan 2020 14:09:01 +0000 Subject: [Koha-bugs] [Bug 24262] Translate installer data in YAML format In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24262 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_20_05_target CC| |martin.renvoize at ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 2 15:19:28 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Jan 2020 14:19:28 +0000 Subject: [Koha-bugs] [Bug 24080] Add a 'payout' process to accounts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24080 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are on the CC list for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 2 15:19:31 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Jan 2020 14:19:31 +0000 Subject: [Koha-bugs] [Bug 24080] Add a 'payout' process to accounts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24080 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #96608|0 |1 is obsolete| | -- You are receiving this mail because: You are on the CC list for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 2 15:19:34 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Jan 2020 14:19:34 +0000 Subject: [Koha-bugs] [Bug 24080] Add a 'payout' process to accounts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24080 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #96609|0 |1 is obsolete| | -- You are receiving this mail because: You are on the CC list for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 2 15:19:36 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Jan 2020 14:19:36 +0000 Subject: [Koha-bugs] [Bug 24080] Add a 'payout' process to accounts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24080 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #96610|0 |1 is obsolete| | -- You are receiving this mail because: You are on the CC list for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 2 15:19:39 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Jan 2020 14:19:39 +0000 Subject: [Koha-bugs] [Bug 24080] Add a 'payout' process to accounts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24080 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #96605|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. You are on the CC list for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jan 2 15:19:41 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Jan 2020 14:19:41 +0000 Subject: [Koha-bugs] [Bug 24080] Add a 'payout' process to accounts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24080 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #96606|0 |1 is obsolete| | -- You are receiving this mail because: You are on the CC list for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 2 15:19:44 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Jan 2020 14:19:44 +0000 Subject: [Koha-bugs] [Bug 24080] Add a 'payout' process to accounts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24080 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #96607|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. You are on the CC list for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jan 2 15:20:03 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Jan 2020 14:20:03 +0000 Subject: [Koha-bugs] [Bug 24327] Anonymous suggestions should not be allowed if AnonymousPatron misconfigured In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24327 ByWater Sandboxes changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #96730|0 |1 is obsolete| | --- Comment #3 from ByWater Sandboxes --- Created attachment 96746 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96746&action=edit Bug 24327: Add warning to the about page is AnonSugggestions but AnonymousPatron This patch adds a warning to the about page if AnonSuggestions is set but AnonymousPatron. Test plan: Turn on AnonSuggestions and set AnonymousPatron to 0 => You see a warning on the about page Turn on AnonSuggestions and set AnonymousPatron to an invalid value => You see a warning on the about page Turn off AnonSuggestions => No warning Turn on AnonSuggestions and set AnonymousPatron to a valid value => No warning Signed-off-by: hc -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 2 15:20:05 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Jan 2020 14:20:05 +0000 Subject: [Koha-bugs] [Bug 24327] Anonymous suggestions should not be allowed if AnonymousPatron misconfigured In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24327 ByWater Sandboxes changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #96731|0 |1 is obsolete| | --- Comment #4 from ByWater Sandboxes --- Created attachment 96747 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96747&action=edit Bug 24327: Redirect to the login form if AnonSuggestion misconfigured Test plan: Turn on AnonSuggestion but set AnonymousPatron to an invalid value Go to /cgi-bin/koha/opac-suggestions.pl?op=add => You see the login form Signed-off-by: hc -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 2 15:20:08 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Jan 2020 14:20:08 +0000 Subject: [Koha-bugs] [Bug 24080] Add a 'payout' process to accounts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24080 --- Comment #37 from Tomás Cohen Arazi --- Created attachment 96748 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96748&action=edit Bug 24080: Payout account debit type Signed-off-by: Kyle M Hall Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. You are on the CC list for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jan 2 15:20:12 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Jan 2020 14:20:12 +0000 Subject: [Koha-bugs] [Bug 24080] Add a 'payout' process to accounts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24080 --- Comment #38 from Tomás Cohen Arazi --- Created attachment 96749 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96749&action=edit Bug 24080: Add 'payout' method to Koha::Account::Line This enhancement adds a 'payout' method to Koha::Account::Line which can be used to 'pay out' a credit to a patron. When such a credit is 'paid out' this method will create a corresponding account debit line with an amount equal to the amountoutstanding on the original credit and the two acocuntlines will be immediately applied against each other. Test Plan: 1) Run the included tests and verify they pass. 2) Signoff Signed-off-by: Kyle M Hall Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. You are on the CC list for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jan 2 15:20:17 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Jan 2020 14:20:17 +0000 Subject: [Koha-bugs] [Bug 24080] Add a 'payout' process to accounts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24080 --- Comment #39 from Tomás Cohen Arazi --- Created attachment 96750 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96750&action=edit Bug 24080: Add updatecharge payout permission Add a new subpermission called 'payout' to the 'updatecharges' permission group which will allow/prevent payout actions to be performed by staff. Signed-off-by: Kyle M Hall Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are on the CC list for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 2 15:20:21 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Jan 2020 14:20:21 +0000 Subject: [Koha-bugs] [Bug 24080] Add a 'payout' process to accounts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24080 --- Comment #40 from Tomás Cohen Arazi --- Created attachment 96751 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96751&action=edit Bug 24080: Add payout option to patron account page This enhancement adds a refined workflow to allow librarians to pay out money to patrons and record these payouts on the patrons account. The use case is that a patron has somehow accrued credit, through a refund perhaps, and the library wants to be able to physically hand over some money to balance the patrons account. Test plan: 1) Undertake a series of transactions that result in some outstanding credit on a patrons account. 2) Note that a new 'Issue payout' button appears next to a credit with an outstanding balance (but only if your user has the payout permission or is a superlibrarian) 3) Click the 'Issue payout' button and a modal should appear pre-populated with the amountoutstanding. 4) You should be able to edit the amount you wish to payout, make payment or cancel. 5) Signoff Signed-off-by: Kyle M Hall Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are on the CC list for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 2 15:20:25 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Jan 2020 14:20:25 +0000 Subject: [Koha-bugs] [Bug 24080] Add a 'payout' process to accounts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24080 --- Comment #41 from Tomás Cohen Arazi --- Created attachment 96752 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96752&action=edit Bug 24080: Adjust text in modal Signed-off-by: Tomas Cohen Arazi Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. You are on the CC list for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jan 2 15:20:29 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Jan 2020 14:20:29 +0000 Subject: [Koha-bugs] [Bug 24080] Add a 'payout' process to accounts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24080 --- Comment #42 from Tomás Cohen Arazi --- Created attachment 96753 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96753&action=edit Bug 24080: (QA follow-up) Remove processing for removed field Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. You are on the CC list for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jan 2 15:20:58 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Jan 2020 14:20:58 +0000 Subject: [Koha-bugs] [Bug 24327] Anonymous suggestions should not be allowed if AnonymousPatron misconfigured In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24327 Holly changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |hc at interleaf.ie --- Comment #5 from Holly --- Both test plans were successful. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 2 15:25:45 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Jan 2020 14:25:45 +0000 Subject: [Koha-bugs] [Bug 13897] Use YAML files for installer data In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13897 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #96591|0 |1 is obsolete| | --- Comment #36 from Martin Renvoize --- Created attachment 96754 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96754&action=edit Bug 13897: Use YAML files for installer data This patch modifies C4/Installer.pm to add support for loading YAML files into database. As an example of the functionality, optional auth_val.sql file is replaced by auth_val.yml The rationale behind this feature is to enable the translation of the data that is loaded into the database. That will be addressed in another bug. But taking into account that goal, translatable values are declared in the YAML files, to ease identification by translate script. Also file description is moved into the yaml file. To test: 0) Do a clean install with all optional data, then dump authorised_values table, reserve. 1) Apply the patch 2) Do a clean install in English (marc21/unimarc) 3) On optional data check for description of auth_val "Some basic default authorised values for ..." 4) Select all optional data 5) Finish installation 6) Dump again authorised_values table and compare with that of point '0'. No differences should be found. Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 2 15:25:48 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Jan 2020 14:25:48 +0000 Subject: [Koha-bugs] [Bug 13897] Use YAML files for installer data In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13897 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #96592|0 |1 is obsolete| | --- Comment #37 from Martin Renvoize --- Created attachment 96755 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96755&action=edit Bug 13897: Catch the error and warn it Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 2 15:30:28 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Jan 2020 14:30:28 +0000 Subject: [Koha-bugs] [Bug 13897] Use YAML files for installer data In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13897 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #38 from Martin Renvoize --- I really like this approach, thanks for working on it Bernardo.. signing off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 2 15:35:56 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Jan 2020 14:35:56 +0000 Subject: [Koha-bugs] [Bug 24211] Compress/uncompress translation files In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24211 --- Comment #2 from Martin Renvoize --- Nice idea :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 2 15:36:56 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Jan 2020 14:36:56 +0000 Subject: [Koha-bugs] [Bug 24302] Add a way to specify nested objects to embed in OpenAPI In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24302 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 2 15:36:58 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Jan 2020 14:36:58 +0000 Subject: [Koha-bugs] [Bug 24302] Add a way to specify nested objects to embed in OpenAPI In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24302 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #96640|0 |1 is obsolete| | --- Comment #5 from Tomás Cohen Arazi --- Comment on attachment 96640 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96640 Bug 24302: Add a way to specify nested objects to embed in OpenAPI Rebased -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 2 15:37:25 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Jan 2020 14:37:25 +0000 Subject: [Koha-bugs] [Bug 24302] Add a way to specify nested objects to embed in OpenAPI In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24302 --- Comment #6 from Tomás Cohen Arazi --- Created attachment 96756 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96756&action=edit Bug 24302: Add a way to specify nested objects to embed in OpenAPI This patch introduces a helper for handling x-koha-embed headers on API requests. It reads the embed definitions and adds them to the stash for later use (either manually on the controllers, or in the objects.search helper. x-koha-embed needs to be defined as a list on the OpenAPI spec. It throws an exception when invalid combinations are found. To test: 1. Apply this patch 2. Run: $ kshell k$ prove t/Koha/REST/Plugin/Query.t => SUCCESS: Tests pass! 3.Sign off :-D -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 2 15:42:48 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Jan 2020 14:42:48 +0000 Subject: [Koha-bugs] [Bug 23913] Use a single menu to sort lists in the OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23913 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com Text to go in the| |This enhancement modifies release notes| |the sorting form on the | |OPAC list contents view so | |that the two menus (sort | |field and direction) are | |combined into one. | | | |This | |makes it consistent with | |the sort menu on the search | |results page. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 2 15:44:48 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Jan 2020 14:44:48 +0000 Subject: [Koha-bugs] [Bug 23889] Improve style of menu header in advanced cataloging editor In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23889 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This enhancement updates release notes| |the styling of dropdown | |menu headers to make them | |apply more consistently | |across the system. CC| |martin.renvoize at ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 2 15:45:39 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Jan 2020 14:45:39 +0000 Subject: [Koha-bugs] [Bug 23889] Improve style of menu header in advanced cataloging editor In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23889 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |20.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 2 15:45:40 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Jan 2020 14:45:40 +0000 Subject: [Koha-bugs] [Bug 23889] Improve style of menu header in advanced cataloging editor In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23889 --- Comment #8 from Martin Renvoize --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 2 15:45:42 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Jan 2020 14:45:42 +0000 Subject: [Koha-bugs] [Bug 23913] Use a single menu to sort lists in the OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23913 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |20.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 2 15:45:44 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Jan 2020 14:45:44 +0000 Subject: [Koha-bugs] [Bug 23913] Use a single menu to sort lists in the OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23913 --- Comment #4 from Martin Renvoize --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 2 15:45:54 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Jan 2020 14:45:54 +0000 Subject: [Koha-bugs] [Bug 13897] Use YAML files for installer data In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13897 --- Comment #39 from Jonathan Druart --- Bernardo, should not we move it out of the 'en' directory? I think we should move it to installer/data/mysql/optional, then remove the other auth_val.sql files. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 2 15:51:26 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Jan 2020 14:51:26 +0000 Subject: [Koha-bugs] [Bug 23261] RecordedBooks - notify patron of need to login / register to see availability In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23261 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |The enhancement makes the release notes| |RBDigital Recorded Books | |subscription more | |discoverable to library | |patrons by adding a notice | |to the OPAC for patrons to | |register and login with | |RBDigital if they have not | |already done so. CC| |martin.renvoize at ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 2 15:51:35 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Jan 2020 14:51:35 +0000 Subject: [Koha-bugs] [Bug 23261] RecordedBooks - notify patron of need to login / register to see availability In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23261 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the|The enhancement makes the |This enhancement makes the release notes|RBDigital Recorded Books |RBDigital Recorded Books |subscription more |subscription more |discoverable to library |discoverable to library |patrons by adding a notice |patrons by adding a notice |to the OPAC for patrons to |to the OPAC for patrons to |register and login with |register and login with |RBDigital if they have not |RBDigital if they have not |already done so. |already done so. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 2 15:52:03 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Jan 2020 14:52:03 +0000 Subject: [Koha-bugs] [Bug 24286] FindDuplicateAuthority does not escape forward slash in 'GENRE/FORM' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24286 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #2 from Jonathan Druart --- Please replace s/\//\\\// with s#/#\\/# to make it a bit more readable. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 2 15:54:49 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Jan 2020 14:54:49 +0000 Subject: [Koha-bugs] [Bug 18731] Add routes for acquisition orders In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18731 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |24321 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24321 [Bug 24321] Make objects.search use mappings from Koha::Object(s) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 2 15:54:49 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Jan 2020 14:54:49 +0000 Subject: [Koha-bugs] [Bug 24321] Make objects.search use mappings from Koha::Object(s) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24321 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |18731 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18731 [Bug 18731] Add routes for acquisition orders -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 2 16:04:07 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Jan 2020 15:04:07 +0000 Subject: [Koha-bugs] [Bug 24330] New: When importing patrons from CSV, automatically strip BOM from file if it exists Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24330 Bug ID: 24330 Summary: When importing patrons from CSV, automatically strip BOM from file if it exists Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Tools Assignee: koha-bugs at lists.koha-community.org Reporter: kyle at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org We have a partner that exports UTF-8 CSV files, and is experiencing the same thing as the author of this article: https://www.freecodecamp.org/news/a-quick-tale-about-feff-the-invisible-character-cd25cd4630e7/ In short, Excel is inserting an invisible UTF-8 character at the start of the file, so that the column name "cardnumber" is actually named "\x{feff}cardnumber", causing "cardnumber" to be blank. A simple solution is provided here: https://stackoverflow.com/questions/24390034/remove-bom-from-string-with-perl -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 2 16:16:25 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Jan 2020 15:16:25 +0000 Subject: [Koha-bugs] [Bug 17268] Advanced cataloging editor - rancor - macros are lost when browser storage cleared In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17268 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #96616|0 |1 is obsolete| | Attachment #96617|0 |1 is obsolete| | Attachment #96618|0 |1 is obsolete| | --- Comment #14 from Nick Clemens --- Created attachment 96757 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96757&action=edit Bug 17268: Add macros table and permissions Bug 17268: Change public to shared -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 2 16:16:28 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Jan 2020 15:16:28 +0000 Subject: [Koha-bugs] [Bug 17268] Advanced cataloging editor - rancor - macros are lost when browser storage cleared In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17268 --- Comment #15 from Nick Clemens --- Created attachment 96758 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96758&action=edit Bug 17268: Advanced cataloging editor macros - add endpoint -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 2 16:16:31 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Jan 2020 15:16:31 +0000 Subject: [Koha-bugs] [Bug 17268] Advanced cataloging editor - rancor - macros are lost when browser storage cleared In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17268 --- Comment #16 from Nick Clemens --- Created attachment 96759 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96759&action=edit Bug 17268: Make shared macros use their own path Bug 17268: Update API to use shared instead of public -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 2 16:16:34 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Jan 2020 15:16:34 +0000 Subject: [Koha-bugs] [Bug 17268] Advanced cataloging editor - rancor - macros are lost when browser storage cleared In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17268 --- Comment #17 from Nick Clemens --- Created attachment 96760 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96760&action=edit Bug 17268: DO NOT PUSH: Schema update -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 2 16:16:51 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Jan 2020 15:16:51 +0000 Subject: [Koha-bugs] [Bug 24016] manager_id in Koha::Patron::Message->store should not depend on userenv alone In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24016 --- Comment #13 from Martin Renvoize --- Created attachment 96761 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96761&action=edit Bug 24016: (RM follow-up) Remove userenv requirement entirely Koha::* Object based classes would not require a userenv to be set to function correctly at all. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 2 16:35:59 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Jan 2020 15:35:59 +0000 Subject: [Koha-bugs] [Bug 24330] When importing patrons from CSV, automatically strip BOM from file if it exists In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24330 --- Comment #1 from Kyle M Hall --- Created attachment 96762 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96762&action=edit Example CSV with a BOM -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 2 16:36:29 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Jan 2020 15:36:29 +0000 Subject: [Koha-bugs] [Bug 24330] When importing patrons from CSV, automatically strip BOM from file if it exists In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24330 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jan 2 16:36:32 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Jan 2020 15:36:32 +0000 Subject: [Koha-bugs] [Bug 24330] When importing patrons from CSV, automatically strip BOM from file if it exists In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24330 --- Comment #2 from Kyle M Hall --- Created attachment 96763 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96763&action=edit Bug 24330: When importing patrons from CSV, automatically strip BOM from file if it exists We have a partner that exports UTF-8 CSV files, and is experiencing the same thing as the author of this article: https://www.freecodecamp.org/news/a-quick-tale-about-feff-the-invisible-character-cd25cd4630e7/ In short, Excel is inserting an invisible UTF-8 character at the start of the file, so that the column name "cardnumber" is actually named "\x{feff}cardnumber", causing "cardnumber" to be blank. A simple solution is provided here: https://stackoverflow.com/questions/24390034/remove-bom-from-string-with-perl Test Plan: 1) Download the example.csv file 2) Attempt to import it using the patron import tool 3) Note the invalid column name error 4) Apply this patch, restart all the things! 5) Attempt the import again 6) Assuming you have a branchcode MPL and a cataegory code S, the patron should import! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 2 16:36:41 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Jan 2020 15:36:41 +0000 Subject: [Koha-bugs] [Bug 24330] When importing patrons from CSV, automatically strip BOM from file if it exists In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24330 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |kyle at bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 2 17:04:18 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Jan 2020 16:04:18 +0000 Subject: [Koha-bugs] [Bug 22407] OMNIBUS: Use DBIC relations to fetch related object rather than searching for the object In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22407 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_20_05_target -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 2 17:05:28 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Jan 2020 16:05:28 +0000 Subject: [Koha-bugs] [Bug 24331] New: Internal server error when placing hold on item if itemtype undefined Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24331 Bug ID: 24331 Summary: Internal server error when placing hold on item if itemtype undefined Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Hold requests Assignee: koha-bugs at lists.koha-community.org Reporter: nick at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com Error is: Can't call method "notforloan" on an undefined value at /usr/share/koha/lib/C4/Reserves.pm line 1199. C4::Reserves::IsAvailableForItemLevelRequest: 1198 my $itemtype = $item->effective_itemtype; 1199 my $notforloan_per_itemtype = Koha::ItemTypes->find($itemtype)->notforloan; We should check that we found an itemtype before calling notforloan -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jan 2 17:18:37 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Jan 2020 16:18:37 +0000 Subject: [Koha-bugs] [Bug 24016] manager_id in Koha::Patron::Message->store should not depend on userenv alone In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24016 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com Attachment #96761|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 2 17:19:08 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Jan 2020 16:19:08 +0000 Subject: [Koha-bugs] [Bug 23261] RecordedBooks - notify patron of need to login / register to see availability In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23261 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |20.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 2 17:19:10 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Jan 2020 16:19:10 +0000 Subject: [Koha-bugs] [Bug 23261] RecordedBooks - notify patron of need to login / register to see availability In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23261 --- Comment #8 from Martin Renvoize --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 2 17:19:12 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Jan 2020 16:19:12 +0000 Subject: [Koha-bugs] [Bug 24016] manager_id in Koha::Patron::Message->store should not depend on userenv alone In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24016 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |20.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 2 17:19:14 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Jan 2020 16:19:14 +0000 Subject: [Koha-bugs] [Bug 24016] manager_id in Koha::Patron::Message->store should not depend on userenv alone In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24016 --- Comment #14 from Martin Renvoize --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 2 17:33:26 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Jan 2020 16:33:26 +0000 Subject: [Koha-bugs] [Bug 24332] New: Automatic Login Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24332 Bug ID: 24332 Summary: Automatic Login Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Self checkout Assignee: koha-bugs at lists.koha-community.org Reporter: cbrannon at cdalibrary.org QA Contact: testopia at bugs.koha-community.org Would like to see AutoSelfCheckID setup to allow multiple accounts. This login is the only way to tell where items are checked out, and having only one login for all libraries is not helpful. Yes, we can manually login, but it would be preferred to have this automated. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 2 18:09:23 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Jan 2020 17:09:23 +0000 Subject: [Koha-bugs] [Bug 24184] Reword FallbackToSMSIfNoEmail syspref text In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24184 Joy Nelson changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable Version(s)|20.05.00 |20.05.00, 19.11.02 released in| | CC| |joy at bywatersolutions.com --- Comment #11 from Joy Nelson --- Pushed to 19.11.x branch for 19.11.02 joy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 2 18:12:43 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Jan 2020 17:12:43 +0000 Subject: [Koha-bugs] [Bug 24241] Description missing for subpermission manage_accounts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24241 Joy Nelson changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |joy at bywatersolutions.com Version(s)|20.05.00 |20.05.00, 19.11.01 released in| | Status|Pushed to master |Pushed to stable --- Comment #6 from Joy Nelson --- Pushed to 19.11.x branch for 19.11.02 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 2 18:21:54 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Jan 2020 17:21:54 +0000 Subject: [Koha-bugs] [Bug 24085] Double submission of forms on returns.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24085 Joy Nelson changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|20.05.00 |20.05.00, 19.11.02 released in| | Status|Pushed to master |Pushed to stable CC| |joy at bywatersolutions.com --- Comment #6 from Joy Nelson --- Pushed to 19.11.x branch for 19.11.02 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 2 18:23:27 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Jan 2020 17:23:27 +0000 Subject: [Koha-bugs] [Bug 24240] List on opac missing close form tag under some conditions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24240 Joy Nelson changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable CC| |joy at bywatersolutions.com Version(s)|20.05.00 |20.05.00, 19.11.02 released in| | --- Comment #5 from Joy Nelson --- Pushed to 19.11.x branch for 19.11.02 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 2 18:24:26 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Jan 2020 17:24:26 +0000 Subject: [Koha-bugs] [Bug 18823] Advanced editor - Rancor - add ability to edit records in import batches In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18823 Cori Lynn Arnold changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Failed QA --- Comment #172 from Cori Lynn Arnold --- Alex, Please address Nick's comment 171 re: "Edit as new (Duplicate)" I think it's fine if we just label it that. Also, please make sure to provide a thorough test plan before sending it back to "Needs Sign Off" Thanks! -cori lynn -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 2 18:29:39 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Jan 2020 17:29:39 +0000 Subject: [Koha-bugs] [Bug 24245] opac-registration-confirmation.tt has incorrect HTML body id In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24245 Joy Nelson changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable CC| |joy at bywatersolutions.com Version(s)|20.05.00 |20.05.00, 19.11.02 released in| | --- Comment #5 from Joy Nelson --- Pushed to 19.11.x branch for 19.11.02 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 2 18:34:23 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Jan 2020 17:34:23 +0000 Subject: [Koha-bugs] [Bug 23786] Advanced Editor: Make font configurations stick for a user In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23786 Cori Lynn Arnold changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |WONTFIX --- Comment #1 from Cori Lynn Arnold --- Turns out this is due to session variables, so the changes were not saved since we had new sessions everyday. Now that we've solved that problem, this problem is moot. I'm going to close this bug. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 2 19:06:39 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Jan 2020 18:06:39 +0000 Subject: [Koha-bugs] [Bug 9156] System preference itemcallnumber not pulling more than 2 subfields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9156 --- Comment #14 from Nick Clemens --- Created attachment 96764 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96764&action=edit Bug 9156: Clarify order in the syspref -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 2 19:07:43 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Jan 2020 18:07:43 +0000 Subject: [Koha-bugs] [Bug 9156] System preference itemcallnumber not pulling more than 2 subfields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9156 --- Comment #15 from Nick Clemens --- (In reply to Katrin Fischer from comment #12) > Failing QA because of Andrew's comment. Spoke with Andrew, we agreed order in record should preserved, attached a follow-up to be explicit about this in the pref -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 2 19:25:09 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Jan 2020 18:25:09 +0000 Subject: [Koha-bugs] [Bug 24312] Update MARC21 frameworks to Updates 28+29 (May and November 2019) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24312 --- Comment #6 from Bernardo Gonzalez Kriegel --- (In reply to Katrin Fischer from comment #5) > (In reply to Jonathan Druart from comment #4) > > Should not we update the other languages as well? > > Bernardo sent the information to the koha-translate mailing list that there > are not strings to translate - I'd maybe give it a bit longer so we catch > more translations. - Say 2 weeks? (holidays...) In fact, I said that there are a few new strings :) "there are small changes on MARC21 frameworks, see Bug 24312 [1] Translation strings have been updated on https://translate.koha-community.org/projects/marc21/" But to answer Jonathan question, we normally expect that the translation team for each language takes sql files from https://translate.koha-community.org/files/, then open a bug to update each language dir, just as Katrin did in Bug 24314 Normally we do not update language files or installed frameworks (perhaps not the best solution, but that is what we have done in the past) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 2 19:29:24 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Jan 2020 18:29:24 +0000 Subject: [Koha-bugs] [Bug 24286] FindDuplicateAuthority does not escape forward slash in 'GENRE/FORM' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24286 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #96524|0 |1 is obsolete| | --- Comment #3 from Nick Clemens --- Created attachment 96765 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96765&action=edit Bug 24286: Escape forward slash in GENRE/FORM (and any authtype) Note that bug 24267 will fix the issue during Z39 searching for new auth, but the duplicate check at saving will still fail To test: 0 - Set SearchEngine to Elasticsearch, QueryRegexEscapeOptions to 'Don't Escape' 1 - Browse to Authorities 2 - Select New->New from Z3950 3 - Search for subject 'Short stories' 4 - Auth search explodes 5 - Apply patch 6 - Repeat and confirm the search results return 7 - Import and save the GENRE/FORM record for Short stories 8 - Repeat the search and import the same record 9 - Confirm that upon save you are notified of duplicate, don't save 10 - set QueryRegexEscapeOptions to 'Escape' and confirm Z39 searching works and importing/save notifies of duplicate 11 - set SearchEngine to Zebra and confirm Z39 searching works and importing/save notifies of duplicate -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 2 19:50:04 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Jan 2020 18:50:04 +0000 Subject: [Koha-bugs] [Bug 24196] Advanced editor - Save silently fails on session timeout In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24196 Cori Lynn Arnold changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |DUPLICATE Status|NEW |RESOLVED --- Comment #1 from Cori Lynn Arnold --- Duplicate of Bug 24323 *** This bug has been marked as a duplicate of bug 24323 *** -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jan 2 19:50:04 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Jan 2020 18:50:04 +0000 Subject: [Koha-bugs] [Bug 24323] Advanced editor - Invalid 008 with helper silently fails to save In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24323 --- Comment #3 from Cori Lynn Arnold --- *** Bug 24196 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 2 19:50:42 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Jan 2020 18:50:42 +0000 Subject: [Koha-bugs] [Bug 24205] Advanced editor - Save to .mrc hangs when 00X fields have delimeters In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24205 Cori Lynn Arnold changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |DUPLICATE Status|NEW |RESOLVED --- Comment #1 from Cori Lynn Arnold --- Fix for 24323 solves this issue as well. *** This bug has been marked as a duplicate of bug 24323 *** -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jan 2 19:50:42 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Jan 2020 18:50:42 +0000 Subject: [Koha-bugs] [Bug 24323] Advanced editor - Invalid 008 with helper silently fails to save In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24323 --- Comment #4 from Cori Lynn Arnold --- *** Bug 24205 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 2 20:02:20 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Jan 2020 19:02:20 +0000 Subject: [Koha-bugs] [Bug 13897] Use YAML files for installer data In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13897 --- Comment #40 from Bernardo Gonzalez Kriegel --- (In reply to Jonathan Druart from comment #39) > Bernardo, should not we move it out of the 'en' directory? > > I think we should move it to installer/data/mysql/optional, then remove the > other auth_val.sql files. It would not be a problem, if there were no descriptions to be translated. Currently we have localized versions, all translated ./de-DE/optional/auth_val.sql ./es-ES/optional/auth_val.sql ./it-IT/necessari/auth_val.sql ./pl-PL/optional/auth_val.sql ./nb-NO/2-Valgfritt/auth_val.sql ./fr-CA/facultatif/auth_val.sql with the same content, sort of. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 2 20:08:01 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Jan 2020 19:08:01 +0000 Subject: [Koha-bugs] [Bug 9156] System preference itemcallnumber not pulling more than 2 subfields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9156 ByWater Sandboxes changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #96499|0 |1 is obsolete| | --- Comment #16 from ByWater Sandboxes --- Created attachment 96766 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96766&action=edit Bug 9156: (follow-up) Simpliy code The MARC::Field as_string method can join multiple subfield using a delimiter, this simplifies the code here Signed-off-by: Andrew Fuerste-Henry -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 2 20:08:04 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Jan 2020 19:08:04 +0000 Subject: [Koha-bugs] [Bug 9156] System preference itemcallnumber not pulling more than 2 subfields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9156 ByWater Sandboxes changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #96764|0 |1 is obsolete| | --- Comment #17 from ByWater Sandboxes --- Created attachment 96767 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96767&action=edit Bug 9156: Clarify order in the syspref Signed-off-by: Andrew Fuerste-Henry -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 2 20:08:46 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Jan 2020 19:08:46 +0000 Subject: [Koha-bugs] [Bug 9156] System preference itemcallnumber not pulling more than 2 subfields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9156 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #18 from Andrew Fuerste-Henry --- signing off again based on clarification -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 2 20:09:23 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Jan 2020 19:09:23 +0000 Subject: [Koha-bugs] [Bug 3426] Change itemcallnumber system preference to allow multiple tags In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3426 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- Status|BLOCKED |Signed Off --- Comment #14 from Andrew Fuerste-Henry --- Switching back to signed off based on work in 9156 -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jan 2 20:27:32 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Jan 2020 19:27:32 +0000 Subject: [Koha-bugs] [Bug 24334] New: Barcode should be included in Marcitemfieldstoorder Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24334 Bug ID: 24334 Summary: Barcode should be included in Marcitemfieldstoorder Change sponsored?: --- Product: Koha Version: 19.05 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Acquisitions Assignee: koha-bugs at lists.koha-community.org Reporter: kelly at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org When libraries are ordering shelf-ready books, most of these records from the vendor include a barcode. The system preference marcitemfieldstoorder, does not accept a barcode to be included in this system preference, so the library can not save the barcode of the item that they are receiving. Currently, there are a lot of item level fields that can be used such as a non-public note, public note, URI, call number, etc. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 2 20:40:04 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Jan 2020 19:40:04 +0000 Subject: [Koha-bugs] [Bug 24335] New: Cannot mark checkout notes seen/not seen in bulk Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24335 Bug ID: 24335 Summary: Cannot mark checkout notes seen/not seen in bulk Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs at lists.koha-community.org Reporter: andrew at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com On checkout-notes.pl the Mark Seen and Mark Not Seen buttons at the top of the page remain greyed out when one selects notes from the list. To test: - turn on AllowCheckoutNotes - generate a checkout and a checkout note - go to /cgi-bin/koha/circ/checkout-notes.pl - click the checkbox for your note - verify that the Mark Seen button at the top of the screen remains grey and inoperable -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jan 2 20:54:24 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Jan 2020 19:54:24 +0000 Subject: [Koha-bugs] [Bug 24328] Bibliographic frameworks fail to install In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24328 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bgkriegel at gmail.com Status|Needs Signoff |Signed Off --- Comment #2 from Bernardo Gonzalez Kriegel --- Count this as signed Signed-off-by: Bernardo Gonzalez Kriegel If needed I can upload a gzipped signed patch, but present one it's Ok Tested enabling strict mode (MySQL), load failed before patch, load ok after patch. Comment: This field 'linkid' can be removed from the inserts, it's default value is '0' and we are inserting just that in all cases. select count(*),linkid from auth_subfield_structure group by linkid" +----------+--------+ | count(*) | linkid | +----------+--------+ | 13398 | 0 | +----------+--------+ -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 2 21:15:42 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Jan 2020 20:15:42 +0000 Subject: [Koha-bugs] [Bug 24206] Change URLs for default options in OPACSearchForTitleIn In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24206 --- Comment #10 from David Nind --- Thanks Katrin! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 2 21:31:21 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Jan 2020 20:31:21 +0000 Subject: [Koha-bugs] [Bug 24206] Change URLs for default options in OPACSearchForTitleIn In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24206 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 2 21:31:25 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Jan 2020 20:31:25 +0000 Subject: [Koha-bugs] [Bug 24206] Change URLs for default options in OPACSearchForTitleIn In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24206 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #96673|0 |1 is obsolete| | --- Comment #11 from David Nind --- Created attachment 96768 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96768&action=edit Bug 24206: Update URLs for default options in OPACSearchForTitleIn - Worldcat: now https - BookFinder: now https - OpenLibrary: remove / before search parameters To test: - Verify changes to the installer files are correct - Bonus: run the web installer for en, de-DE and nb-NO and verfiy the content of OPACSearchForTitleIn is correct Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 2 21:31:28 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Jan 2020 20:31:28 +0000 Subject: [Koha-bugs] [Bug 24206] Change URLs for default options in OPACSearchForTitleIn In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24206 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #96675|0 |1 is obsolete| | --- Comment #12 from David Nind --- Created attachment 96769 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96769&action=edit Bug 24206: Update content of OpacSearchForTitleIn for existing installations This includes a database update for existing installations. Using the REPLACE function it makes the same changes to the URLs as the previous patch did for new installations: - Worldcat: now https - BookFinder: now https - OpenLibrary: remove / before search parameters To test: - Verify the current content of your preference OpacSearchForTitleIn (without changes from first patch!) - Run the database update - Verify everything still works, but changes have been made Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 2 21:33:17 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Jan 2020 20:33:17 +0000 Subject: [Koha-bugs] [Bug 24206] Change URLs for default options in OPACSearchForTitleIn In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24206 --- Comment #13 from Katrin Fischer --- Thx David! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 2 22:34:54 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Jan 2020 21:34:54 +0000 Subject: [Koha-bugs] [Bug 24328] Bibliographic frameworks fail to install In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24328 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |katrin.fischer at bsz-bw.de --- Comment #3 from Katrin Fischer --- Thx Jonathan, consider it PQA from me ;) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 2 22:39:09 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Jan 2020 21:39:09 +0000 Subject: [Koha-bugs] [Bug 24328] Bibliographic frameworks fail to install In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24328 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #96735|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 2 22:39:36 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Jan 2020 21:39:36 +0000 Subject: [Koha-bugs] [Bug 24328] Bibliographic frameworks fail to install In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24328 --- Comment #4 from Katrin Fischer --- Created attachment 96770 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96770&action=edit Zipped patch with sign-off lines -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 2 22:44:02 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Jan 2020 21:44:02 +0000 Subject: [Koha-bugs] [Bug 9156] System preference itemcallnumber not pulling more than 2 subfields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9156 --- Comment #19 from Katrin Fischer --- Comment on attachment 96767 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96767 Bug 9156: Clarify order in the syspref Review of attachment 96767: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=9156&attachment=96767) ----------------------------------------------------------------- ::: C4/Reserves.pm @@ +1195,5 @@ > # FIXME - a lot of places in the code do this > # or something similar - need to be > # consolidated > + my $itemtype = Koha::ItemTypes->find( $item->effective_itemtype ); > + my $notforloan_per_itemtype = defined $itemtype ? $itemtype->notforloan : 0; I think this got in by accident - can you please resubmit the patch? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 2 22:44:09 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Jan 2020 21:44:09 +0000 Subject: [Koha-bugs] [Bug 9156] System preference itemcallnumber not pulling more than 2 subfields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9156 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 2 22:51:14 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Jan 2020 21:51:14 +0000 Subject: [Koha-bugs] [Bug 24323] Advanced editor - Invalid 008 with helper silently fails to save In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24323 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 2 22:51:17 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Jan 2020 21:51:17 +0000 Subject: [Koha-bugs] [Bug 24323] Advanced editor - Invalid 008 with helper silently fails to save In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24323 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #96723|0 |1 is obsolete| | --- Comment #5 from Katrin Fischer --- Created attachment 96771 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96771&action=edit Bug 24323: Advanced editor - Invalid 008 with helper silently fails to save This patch adds a "else if" to fall through if the error message isn't one of the previously defined ones ("syntax" and "invalid") and presents the human with a generic message that "Something went wrong, cannot save." Prior to testing: a/Verify that Advanced Editor is enabled b/Download the errorrecord.mrc from bug To test: 1/Apply patch 2/Go to Cataloging->Advanced Editor 3/Click "Import Record" button and navigate to the record saved from step b/ 4/Add an 003 field (as required by the default cataloging config) 5/Hit "Save to catalog" 6/Verify that a message is passed to the user that the file was unable to be saved Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 2 22:51:54 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Jan 2020 21:51:54 +0000 Subject: [Koha-bugs] [Bug 24323] Advanced editor - Invalid 008 with helper silently fails to save In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24323 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #6 from Katrin Fischer --- I think it would be nice if the feedback would be more precise, highlighting the problem in the 008, but this is definitely a good step forward. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 2 22:52:39 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Jan 2020 21:52:39 +0000 Subject: [Koha-bugs] [Bug 24332] Allow setting up AutoSelfCheckID for multiple accounts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24332 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Summary|Automatic Login |Allow setting up | |AutoSelfCheckID for | |multiple accounts -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 2 22:53:32 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Jan 2020 21:53:32 +0000 Subject: [Koha-bugs] [Bug 21250] Auto-self-checkout not fully compatible with multi-branch library setup In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21250 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Auto-self-checkout not |Auto-self-checkout not |fully compatible with |fully compatible with |two-branch library setup |multi-branch library setup -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jan 2 22:53:48 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Jan 2020 21:53:48 +0000 Subject: [Koha-bugs] [Bug 24332] Allow setting up AutoSelfCheckID for multiple accounts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24332 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |DUPLICATE --- Comment #1 from Katrin Fischer --- *** This bug has been marked as a duplicate of bug 21250 *** -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 2 22:53:48 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Jan 2020 21:53:48 +0000 Subject: [Koha-bugs] [Bug 21250] Auto-self-checkout not fully compatible with multi-branch library setup In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21250 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |cbrannon at cdalibrary.org --- Comment #17 from Katrin Fischer --- *** Bug 24332 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jan 2 22:54:34 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Jan 2020 21:54:34 +0000 Subject: [Koha-bugs] [Bug 17268] Advanced cataloging editor - rancor - macros are lost when browser storage cleared In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17268 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #18 from Katrin Fischer --- Not ready for testing yet? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 2 23:01:11 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Jan 2020 22:01:11 +0000 Subject: [Koha-bugs] [Bug 24327] Anonymous suggestions should not be allowed if AnonymousPatron misconfigured In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24327 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 2 23:01:14 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Jan 2020 22:01:14 +0000 Subject: [Koha-bugs] [Bug 24327] Anonymous suggestions should not be allowed if AnonymousPatron misconfigured In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24327 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #96746|0 |1 is obsolete| | --- Comment #6 from Katrin Fischer --- Created attachment 96772 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96772&action=edit Bug 24327: Add warning to the about page is AnonSugggestions but AnonymousPatron This patch adds a warning to the about page if AnonSuggestions is set but AnonymousPatron. Test plan: Turn on AnonSuggestions and set AnonymousPatron to 0 => You see a warning on the about page Turn on AnonSuggestions and set AnonymousPatron to an invalid value => You see a warning on the about page Turn off AnonSuggestions => No warning Turn on AnonSuggestions and set AnonymousPatron to a valid value => No warning Signed-off-by: hc Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 2 23:01:18 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Jan 2020 22:01:18 +0000 Subject: [Koha-bugs] [Bug 24327] Anonymous suggestions should not be allowed if AnonymousPatron misconfigured In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24327 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #96747|0 |1 is obsolete| | --- Comment #7 from Katrin Fischer --- Created attachment 96773 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96773&action=edit Bug 24327: Redirect to the login form if AnonSuggestion misconfigured Test plan: Turn on AnonSuggestion but set AnonymousPatron to an invalid value Go to /cgi-bin/koha/opac-suggestions.pl?op=add => You see the login form Signed-off-by: hc Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 2 23:02:13 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Jan 2020 22:02:13 +0000 Subject: [Koha-bugs] [Bug 24327] Anonymous suggestions should not be allowed if AnonymousPatron misconfigured In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24327 --- Comment #8 from Katrin Fischer --- Hi Holly, at the moment your sign off line shows "hc" as the name, which will turn up in the Release notes - would you like us to change it so it shows your full name instead? Signed-off-by: hc -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 2 23:05:59 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Jan 2020 22:05:59 +0000 Subject: [Koha-bugs] [Bug 24308] Suggestions table on suggestions.pl should have separate columns for dates In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24308 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 2 23:06:02 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Jan 2020 22:06:02 +0000 Subject: [Koha-bugs] [Bug 24308] Suggestions table on suggestions.pl should have separate columns for dates In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24308 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #96745|0 |1 is obsolete| | --- Comment #7 from Katrin Fischer --- Created attachment 96774 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96774&action=edit Bug 24308: Suggestions table on suggestions.pl should have separate columns for dates Signed-off-by: Owen Leonard Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 2 23:10:08 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Jan 2020 22:10:08 +0000 Subject: [Koha-bugs] [Bug 14963] Add the ability to suggest purchase from existing titles In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14963 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #28 from Katrin Fischer --- What do you think of using a little 'present' icon instead of the money (bill) icon? Also we could slightly rephrase it to make it shorter: Currently: New purchase suggestion for this title Suggestion: Suggest for purchase -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 2 23:35:53 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Jan 2020 22:35:53 +0000 Subject: [Koha-bugs] [Bug 24329] Patron cardnumber change times are lost during upgrade for bug 3820 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24329 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 2 23:35:56 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Jan 2020 22:35:56 +0000 Subject: [Koha-bugs] [Bug 24329] Patron cardnumber change times are lost during upgrade for bug 3820 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24329 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #96739|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer --- Created attachment 96775 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96775&action=edit Bug 24329: Correction to updatedatabase Ensure timestamp is not overwriteen during upgrade when applying updates for bug 3820 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jan 2 23:36:02 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Jan 2020 22:36:02 +0000 Subject: [Koha-bugs] [Bug 24329] Patron cardnumber change times are lost during upgrade for bug 3820 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24329 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #96740|0 |1 is obsolete| | --- Comment #4 from Katrin Fischer --- Created attachment 96776 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96776&action=edit Bug 24329: Prevent update of timestamp on action_logs updates Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 2 23:40:18 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Jan 2020 22:40:18 +0000 Subject: [Koha-bugs] [Bug 24294] Creating an order with ACQ framework using 00x fields doesn't work with default value In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24294 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Creating an order with ACQ |Creating an order with ACQ |framework using 00x fields |framework using 00x fields |doesn't work |doesn't work with default | |value -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 2 23:44:51 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Jan 2020 22:44:51 +0000 Subject: [Koha-bugs] [Bug 24294] Creating an order with ACQ framework using 00x fields doesn't work with default value In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24294 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Patch complexity|--- |Small patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 2 23:44:55 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Jan 2020 22:44:55 +0000 Subject: [Koha-bugs] [Bug 24294] Creating an order with ACQ framework using 00x fields doesn't work with default value In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24294 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #96732|0 |1 is obsolete| | --- Comment #4 from Katrin Fischer --- Created attachment 96777 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96777&action=edit Bug 24294: Add default value support for control fields in ACQ framework When trying to add an order using the ACQ framework with a 008@ tag, Koha explodes: Control fields (generally, just tags below 010) do not have subfields, use data() at /home/vagrant/kohaclone/C4/Acquisition.pm line 3272. Test plan: Set a default value for a control field in the ACQ framework Turn on UseACQFrameworkForBiblioRecords Create a new order from a new record The default value should be displayed Save => No crash Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jan 2 23:47:10 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Jan 2020 22:47:10 +0000 Subject: [Koha-bugs] [Bug 24134] Add placeholder for 2 digit years to allow autogeneration of dates in 008 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24134 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=24294 --- Comment #5 from Katrin Fischer --- I'd really like to see this one moving. Jonathan fixes the default value behaviour on controlfields in bug 24294, but the placeholders are not replaced. Maybe we could treat this as a preexisting bug - meaning, we let this move in, but file a new bug for fixing the placeholder behaviour in acquisitions? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jan 2 23:47:10 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Jan 2020 22:47:10 +0000 Subject: [Koha-bugs] [Bug 24294] Creating an order with ACQ framework using 00x fields doesn't work with default value In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24294 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=24134 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jan 2 23:51:48 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Jan 2020 22:51:48 +0000 Subject: [Koha-bugs] [Bug 14385] Extend OpacHiddenItems to allow specifying exempt borrower categories In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14385 --- Comment #198 from Katrin Fischer --- (In reply to Jonathan Druart from comment #197) > From this commit 70651422a7517338a68e22321d9918757746ef33 > Bug 14385: (QA follow-up) Additional changes and fixes > > @ Biblio.pm:1551 @ sub GetAuthorisedValueDesc { > > #---- branch > if ( $tagslib->{$tag}->{$subfield}->{'authorised_value'} eq > "branches" ) { > - return Koha::Libraries->find($value)->branchname; > + my $branch = Koha::Libraries->find($value); > + return $branch? $branch->branchname: q{}; > } > > > We are actually hiding a data inconsistency. I would recommend to revert > that change and fix the failing test properly instead. I think this got lost here - should we file a new bug report? Not sure how to phrase it. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 3 00:10:32 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 Jan 2020 23:10:32 +0000 Subject: [Koha-bugs] [Bug 24249] OPAC lists page should require login for login-dependent operations In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24249 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #2 from Katrin Fischer --- Hi Owen, I am not sure what the difference here is between before and after. I haven't been able to find a link to the 'add list' form, but only 'log in' links. Can you explain the change a bit more? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 3 02:20:02 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Jan 2020 01:20:02 +0000 Subject: [Koha-bugs] [Bug 21250] Auto-self-checkout not fully compatible with multi-branch library setup In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21250 --- Comment #18 from Christopher Brannon --- Would like to see a more straight forward solution to this. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Jan 3 07:13:33 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Jan 2020 06:13:33 +0000 Subject: [Koha-bugs] [Bug 21250] Auto-self-checkout not fully compatible with multi-branch library setup In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21250 --- Comment #19 from Katrin Fischer --- (In reply to Christopher Brannon from comment #18) > Would like to see a more straight forward solution to this. Agreed - was just linking both as I think it's the same problem and maybe this is still helpful as a workaround. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 3 07:25:24 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Jan 2020 06:25:24 +0000 Subject: [Koha-bugs] [Bug 24094] Authority punctuation mismatch prevents linking to correct records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24094 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|trivial |normal CC| |katrin.fischer at bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Jan 3 07:28:35 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Jan 2020 06:28:35 +0000 Subject: [Koha-bugs] [Bug 24125] Deleting an authority clears the record heading In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24125 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #4 from Katrin Fischer --- It can be a useful feature for things like subjects etc. you no longer want to use. I remember using it to clean out migration errors. Maybe we could solve this with an option/checkbox on the form? If there are linked records - Delete only the linking field ($9, UNIMARC?) - Delete the whole entry -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 3 07:29:54 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Jan 2020 06:29:54 +0000 Subject: [Koha-bugs] [Bug 24125] Deleting an authority clears the record heading In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24125 --- Comment #5 from Katrin Fischer --- Hm, radio button? If there are linked bibliographic records - Delete only the linking field ($9, UNIMARC?) - Delete the whole entry - Don't delete authority record -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 3 07:31:34 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Jan 2020 06:31:34 +0000 Subject: [Koha-bugs] [Bug 23001] When the whole authority record is searched, search always returns all records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23001 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |INVALID --- Comment #2 from Katrin Fischer --- Closing INVALID, not sure what was going on there, but looks ok now! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 3 07:43:40 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Jan 2020 06:43:40 +0000 Subject: [Koha-bugs] [Bug 24226] Advanced editor - drops subfields/punctuation when manually linking authority records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24226 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #1 from Katrin Fischer --- Thinking about this one, I am not sure if it always fits expectations. I can see where it's annoying when you have already written up a nice entry. But what if you are working with very minimal records and want to use the more complete information/punctuation from your authority records? Should additional subfields like dates be added that haven't been there before? They would require a change of punctuation too if I am not mistaken. Wondering if we could create a flexible solution that works well in different scenarios, maybe using a dialog or an option in the editor? Also: when an authority main heading is updated, the linked records are changed as well... so there are other workflows that might change your entered heading automatically. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 3 07:46:45 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Jan 2020 06:46:45 +0000 Subject: [Koha-bugs] [Bug 21294] Indentify boolean fields on the DB structure In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21294 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |Academy CC| |katrin.fischer at bsz-bw.de --- Comment #3 from Katrin Fischer --- Wondering if locating candidates for Booleans could be a good Academy/beginners task. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Jan 3 07:52:00 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Jan 2020 06:52:00 +0000 Subject: [Koha-bugs] [Bug 23974] hours_between and days_between lack tests In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23974 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 3 07:52:04 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Jan 2020 06:52:04 +0000 Subject: [Koha-bugs] [Bug 23974] hours_between and days_between lack tests In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23974 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95210|0 |1 is obsolete| | --- Comment #26 from Katrin Fischer --- Created attachment 96778 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96778&action=edit Bug 23974: Improve readability This patch does not change anything, just a bit of cleaning Signed-off-by: Martin Renvoize Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 3 07:52:07 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Jan 2020 06:52:07 +0000 Subject: [Koha-bugs] [Bug 23974] hours_between and days_between lack tests In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23974 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95211|0 |1 is obsolete| | --- Comment #27 from Katrin Fischer --- Created attachment 96779 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96779&action=edit Bug 23974: Add new tests for hours_between Signed-off-by: Martin Renvoize Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 3 07:52:10 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Jan 2020 06:52:10 +0000 Subject: [Koha-bugs] [Bug 23974] hours_between and days_between lack tests In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23974 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95212|0 |1 is obsolete| | --- Comment #28 from Katrin Fischer --- Created attachment 96780 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96780&action=edit Bug 23974: Add tests for days_between Signed-off-by: Martin Renvoize Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 3 07:52:14 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Jan 2020 06:52:14 +0000 Subject: [Koha-bugs] [Bug 23974] hours_between and days_between lack tests In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23974 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95213|0 |1 is obsolete| | --- Comment #29 from Katrin Fischer --- Created attachment 96781 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96781&action=edit Bug 23974: both methods should have the same logic/construction Signed-off-by: Martin Renvoize Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 3 07:52:17 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Jan 2020 06:52:17 +0000 Subject: [Koha-bugs] [Bug 23974] hours_between and days_between lack tests In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23974 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95889|0 |1 is obsolete| | --- Comment #30 from Katrin Fischer --- Created attachment 96782 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96782&action=edit Bug 23974: (follow-up) Add same day loan tests Hourly loans can be short enough to not cross a day boundary and as such we should test for that scenario in the hour_between tests too. Signed-off-by: Martin Renvoize Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 3 07:52:20 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Jan 2020 06:52:20 +0000 Subject: [Koha-bugs] [Bug 23974] hours_between and days_between lack tests In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23974 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95893|0 |1 is obsolete| | --- Comment #31 from Katrin Fischer --- Created attachment 96783 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96783&action=edit Bug 23974: Add POD for hours_between Add a bit of missing POD whilst we're working in here Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 3 07:52:24 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Jan 2020 06:52:24 +0000 Subject: [Koha-bugs] [Bug 23974] hours_between and days_between lack tests In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23974 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95894|0 |1 is obsolete| | --- Comment #32 from Katrin Fischer --- Created attachment 96784 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96784&action=edit Bug 23974: Test Notes Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 3 07:52:27 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Jan 2020 06:52:27 +0000 Subject: [Koha-bugs] [Bug 23974] hours_between and days_between lack tests In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23974 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95895|0 |1 is obsolete| | --- Comment #33 from Katrin Fischer --- Created attachment 96785 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96785&action=edit Bug 23974: Add tests for issue on closed day Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 3 07:52:31 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Jan 2020 06:52:31 +0000 Subject: [Koha-bugs] [Bug 23974] hours_between and days_between lack tests In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23974 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95896|0 |1 is obsolete| | --- Comment #34 from Katrin Fischer --- Created attachment 96786 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96786&action=edit Bug 23974: Add test descriptions Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 3 07:55:02 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Jan 2020 06:55:02 +0000 Subject: [Koha-bugs] [Bug 23974] hours_between and days_between lack tests In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23974 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #35 from Katrin Fischer --- The dangerous bits here are the changes to Calendar.pm and not the .t parts. Testing focused on tests passing - changes appear to make sense to me. Expecting QA to take another closer look. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 3 07:58:55 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Jan 2020 06:58:55 +0000 Subject: [Koha-bugs] [Bug 21633] Did finesMode = test ever send email? In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21633 --- Comment #4 from Katrin Fischer --- I think if we can't fix it easily (there is not code yet...) then we should finally remove the option to end confusion. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 3 08:03:12 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Jan 2020 07:03:12 +0000 Subject: [Koha-bugs] [Bug 24214] due date displayed in iso format (when sticky) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24214 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 3 08:03:15 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Jan 2020 07:03:15 +0000 Subject: [Koha-bugs] [Bug 24214] due date displayed in iso format (when sticky) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24214 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #96193|0 |1 is obsolete| | --- Comment #2 from Katrin Fischer --- Created attachment 96787 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96787&action=edit Bug 24214: Fix due date formatting when sticky When checking out and sticky due date is selected, on the next screen the due date is displayed iso-formatted, instead of following the dateformat syspref Test plan: 0/ Do not apply the patch 1/ Check an item out, with a selected due date. Tick "Remember for session" 2/ Next screen you see the date like YYYY-MM-DD HH:MM regarless the value of the dateformat syspref 3/ Apply this patch 4/ Reload the page => The date is correctly formatted 5/ Check an item out => Due date is correctly set Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 3 08:03:37 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Jan 2020 07:03:37 +0000 Subject: [Koha-bugs] [Bug 24214] Due date displayed in ISO format (when sticky) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24214 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|due date displayed in iso |Due date displayed in ISO |format (when sticky) |format (when sticky) CC| |katrin.fischer at bsz-bw.de Version|unspecified |master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 3 08:08:36 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Jan 2020 07:08:36 +0000 Subject: [Koha-bugs] [Bug 22671] Built-in offline circulation interface not working In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22671 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Severity|minor |normal --- Comment #1 from Katrin Fischer --- I can't replicate this. I am testing with current master in Firefox on Ubuntu without problems. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Jan 3 08:12:42 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Jan 2020 07:12:42 +0000 Subject: [Koha-bugs] [Bug 23136] The Filter Suggestions option to Search by Requester worked across all the tabs simultaneously In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23136 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED CC| |katrin.fischer at bsz-bw.de Resolution|--- |WORKSFORME --- Comment #2 from Katrin Fischer --- Hi Paul, I've tested on master and the filters on the suggestion page work across all the tabs for me - they change according to my search. I am marking WORKSFORME, please provide a step by step or maybe a screenshot to clear things up if there is still a problem. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Jan 3 08:13:48 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Jan 2020 07:13:48 +0000 Subject: [Koha-bugs] [Bug 23136] The Filter Suggestions option to Search by Requester worked across all the tabs simultaneously In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23136 --- Comment #3 from Katrin Fischer --- Also tested in 18.11. now. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 3 08:17:34 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Jan 2020 07:17:34 +0000 Subject: [Koha-bugs] [Bug 24104] Item search - dropdown buttons overflow In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24104 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 3 08:17:37 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Jan 2020 07:17:37 +0000 Subject: [Koha-bugs] [Bug 24104] Item search - dropdown buttons overflow In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24104 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95797|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer --- Created attachment 96788 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96788&action=edit Bug 24104: Item search - Prevent "Edit" dropdown button to overflow Making it displays on the left fixes the problem. Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 3 08:17:48 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Jan 2020 07:17:48 +0000 Subject: [Koha-bugs] [Bug 24104] Item search - dropdown buttons overflow In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24104 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Status|Signed Off |Passed QA --- Comment #4 from Katrin Fischer --- Nice fix! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 3 08:25:35 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Jan 2020 07:25:35 +0000 Subject: [Koha-bugs] [Bug 23243] Allow filtering out of historic subscription expirations in the check expiration of serials page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23243 --- Comment #7 from Katrin Fischer --- I can see the point of this change and agree with it, but wonder if it really makes things clearer to the end user: What is a historic expiration? (and how to translate that...) Wondering if usability wise this would be a better solution: Provide 2 date fields: Expired between (preset to today) And ____ Or maybe instead of 'history expirations' we should say: Include expirations before today. The date logic on the form is a bit hard to grasp in training in my experience. QA tools are clean now. -- You are receiving this mail because: You are on the CC list for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 3 08:31:09 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Jan 2020 07:31:09 +0000 Subject: [Koha-bugs] [Bug 7907] PDF printing of lists In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7907 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |WONTFIX Status|NEW |RESOLVED --- Comment #7 from Katrin Fischer --- (In reply to Owen Leonard from comment #6) > Macs and Windows 10 have built-in printing to PDF, and earlier versions of > Windows have applications like CutePDF Writer which can print to PDF. I > don't think this is functionality which should be built into Koha. In Ubuntu you can also 'Print to file'. Agreeing with Owen here, marking as WONTFIX - please feel free to still comment/discuss! -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Jan 3 08:34:17 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Jan 2020 07:34:17 +0000 Subject: [Koha-bugs] [Bug 24054] Typo in ClaimReturnedWarningThreshold system preference In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24054 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 3 09:02:53 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Jan 2020 08:02:53 +0000 Subject: [Koha-bugs] [Bug 21633] Did finesMode = test ever send email? In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21633 --- Comment #5 from Magnus Enger --- (In reply to Katrin Fischer from comment #4) > I think if we can't fix it easily (there is not code yet...) then we should > finally remove the option to end confusion. Agreed. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Jan 3 10:13:08 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Jan 2020 09:13:08 +0000 Subject: [Koha-bugs] [Bug 24330] When importing patrons from CSV, automatically strip BOM from file if it exists In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24330 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 3 10:13:11 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Jan 2020 09:13:11 +0000 Subject: [Koha-bugs] [Bug 24330] When importing patrons from CSV, automatically strip BOM from file if it exists In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24330 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #96763|0 |1 is obsolete| | --- Comment #3 from David Nind --- Created attachment 96789 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96789&action=edit Bug 24330: When importing patrons from CSV, automatically strip BOM from file if it exists We have a partner that exports UTF-8 CSV files, and is experiencing the same thing as the author of this article: https://www.freecodecamp.org/news/a-quick-tale-about-feff-the-invisible-character-cd25cd4630e7/ In short, Excel is inserting an invisible UTF-8 character at the start of the file, so that the column name "cardnumber" is actually named "\x{feff}cardnumber", causing "cardnumber" to be blank. A simple solution is provided here: https://stackoverflow.com/questions/24390034/remove-bom-from-string-with-perl Test Plan: 1) Download the example.csv file 2) Attempt to import it using the patron import tool 3) Note the invalid column name error 4) Apply this patch, restart all the things! 5) Attempt the import again 6) Assuming you have a branchcode MPL and a cataegory code S, the patron should import! Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 3 10:43:28 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Jan 2020 09:43:28 +0000 Subject: [Koha-bugs] [Bug 21520] More complex OAI sets mappings In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21520 --- Comment #7 from Matthias Meusburger --- Hi Joubu, thanks for the feedback. 1. I will attach a QA Follow-up 2. a. rule_order is always null, is that expected? => Kind of :) In fact, rule_order will be populated when a rule is modified/created in the GUI. The updatedatabase doesn't need to do it, because at this point, we only have rules with 'or' operator, and the order is not important. b. first rule should have a null for "rule_operator", isn't it? => Same as 2.a. The first rule_operator could have been set to null by the updatedatabase, but it doesn't need to, since it will always be ignored in the code. However, when a rule is modified/created is the GUI, the first rule_operator will be set to null (just for better readability in the database). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 3 11:50:12 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Jan 2020 10:50:12 +0000 Subject: [Koha-bugs] [Bug 23261] RecordedBooks - notify patron of need to login / register to see availability In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23261 --- Comment #9 from Martin Renvoize --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 3 11:50:14 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Jan 2020 10:50:14 +0000 Subject: [Koha-bugs] [Bug 24217] use strict for all modules In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24217 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |20.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 3 11:50:16 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Jan 2020 10:50:16 +0000 Subject: [Koha-bugs] [Bug 24217] use strict for all modules In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24217 --- Comment #9 from Martin Renvoize --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 3 11:54:58 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Jan 2020 10:54:58 +0000 Subject: [Koha-bugs] [Bug 21520] More complex OAI sets mappings In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21520 --- Comment #8 from Matthias Meusburger --- Created attachment 96790 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96790&action=edit Bug 21520: QA Follow-up: do not build html tags with TT conditions -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 3 11:55:25 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Jan 2020 10:55:25 +0000 Subject: [Koha-bugs] [Bug 21520] More complex OAI sets mappings In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21520 Matthias Meusburger changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 3 12:01:49 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Jan 2020 11:01:49 +0000 Subject: [Koha-bugs] [Bug 21684] Koha::Object[s]->delete methods must behave identically as the corresponding DBIx::Class ones In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21684 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |20.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 3 12:01:51 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Jan 2020 11:01:51 +0000 Subject: [Koha-bugs] [Bug 21684] Koha::Object[s]->delete methods must behave identically as the corresponding DBIx::Class ones In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21684 --- Comment #23 from Martin Renvoize --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 3 12:01:53 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Jan 2020 11:01:53 +0000 Subject: [Koha-bugs] [Bug 23260] Anonymize (remove) patron data from items_last_borrower In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23260 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |20.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 3 12:01:55 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Jan 2020 11:01:55 +0000 Subject: [Koha-bugs] [Bug 23260] Anonymize (remove) patron data from items_last_borrower In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23260 --- Comment #49 from Martin Renvoize --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 3 12:01:57 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Jan 2020 11:01:57 +0000 Subject: [Koha-bugs] [Bug 24150] Add missing Koha::Old::*[s] classes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24150 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |20.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 3 12:01:59 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Jan 2020 11:01:59 +0000 Subject: [Koha-bugs] [Bug 24150] Add missing Koha::Old::*[s] classes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24150 --- Comment #9 from Martin Renvoize --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 3 12:04:24 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Jan 2020 11:04:24 +0000 Subject: [Koha-bugs] [Bug 23260] Anonymize (remove) patron data from items_last_borrower In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23260 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |ASSIGNED CC| |martin.renvoize at ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 3 12:04:32 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Jan 2020 11:04:32 +0000 Subject: [Koha-bugs] [Bug 23260] Anonymize (remove) patron data from items_last_borrower In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23260 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 3 12:04:38 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Jan 2020 11:04:38 +0000 Subject: [Koha-bugs] [Bug 23260] Anonymize (remove) patron data from items_last_borrower In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23260 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 3 12:04:44 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Jan 2020 11:04:44 +0000 Subject: [Koha-bugs] [Bug 23260] Anonymize (remove) patron data from items_last_borrower In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23260 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 3 12:04:50 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Jan 2020 11:04:50 +0000 Subject: [Koha-bugs] [Bug 23260] Anonymize (remove) patron data from items_last_borrower In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23260 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|20.05.00 | released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 3 12:07:11 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Jan 2020 11:07:11 +0000 Subject: [Koha-bugs] [Bug 23260] Anonymize (remove) patron data from items_last_borrower In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23260 --- Comment #50 from Martin Renvoize --- OK, this isn't pushed.. my mistake on updating the bug prematurely.. had too many tabs open.. Moving onto this one now and having a read as that recent comments make it sound contentious. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 3 12:29:05 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Jan 2020 11:29:05 +0000 Subject: [Koha-bugs] [Bug 24152] Add the ability to purge pseudonymized data In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24152 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com --- Comment #4 from Martin Renvoize --- I'd like to see tests for the new `filter_by_last_update` method added to Koha::Objects (and really, I'd love to see that in it's own mini bug for fast QA and push in the future.. smaller bugs in a tree means others can benefit from such nice little additions more quickly) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 3 12:53:51 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Jan 2020 11:53:51 +0000 Subject: [Koha-bugs] [Bug 23260] Anonymize (remove) patron data from items_last_borrower In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23260 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Patch doesn't apply --- Comment #51 from Martin Renvoize --- error: sha1 information is lacking or useless (Koha/Patrons.pm). error: could not build fake ancestor Patch failed at 0001 Bug 23260: (follow-up) optimize anonymise_items_last_borrower -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 3 13:11:08 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Jan 2020 12:11:08 +0000 Subject: [Koha-bugs] [Bug 23260] Anonymize (remove) patron data from items_last_borrower In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23260 --- Comment #52 from Martin Renvoize --- OK, the patch doesn't apply currently, SHA1 errors. However, I think I agree with Jonathan here, I'm not sure there's a requirement at all for introducing a Koha::Item::LastPatron object.. we have a nice method in Koha::Item for returning a Koha::Patron object for the last_borrower. I think we can simply inline the search and removal here rather than adding a new class. Finally.. as for the 'update' debate.. personally I think we should ban update calls as a direct passthrough in Koha::Objects but allow the manual "I know what I'm doing" reach inside _resultset version. So, I would encourage _resultset->update() as the format for that particular case. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 3 13:38:08 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Jan 2020 12:38:08 +0000 Subject: [Koha-bugs] [Bug 23260] Anonymize (remove) patron data from items_last_borrower In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23260 --- Comment #53 from Martin Renvoize --- Created attachment 96791 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96791&action=edit Bug 23260: [ALTERNATIVE] Inline code to anonymise_issue_history This alternative patch reduces the complexity of the change by simply updateing the existing anonymise_issue_history method to include anonymisation of the items_last_borrowers table. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 3 13:41:56 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Jan 2020 12:41:56 +0000 Subject: [Koha-bugs] [Bug 23260] Anonymize (remove) patron data from items_last_borrower In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23260 --- Comment #54 from Martin Renvoize --- OK, I've gone into 'golf mode' and submitted an alternative patch which I feel accomplishes the same result but in a significantly reduced amount of clear code. I'd still be interested in a squashed patch for the original 4 commit submission as I struggled to fully asses it given I could not apply... but I'd also be very interested in peoples opinions regarding my alternative approach.. (It would obviously fail qa as it stands as it requires some additional tests adding to cover the change) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 3 13:43:27 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Jan 2020 12:43:27 +0000 Subject: [Koha-bugs] [Bug 24092] Change Koha::Item to use Items::LastPatrons instead of ItemLastBorrower resultset In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24092 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |In Discussion CC| |martin.renvoize at ptfs-europe | |.com --- Comment #1 from Martin Renvoize --- I'm not at all sure this is a good idea at this time.. see discussion on bug 23260 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Jan 3 13:46:22 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Jan 2020 12:46:22 +0000 Subject: [Koha-bugs] [Bug 9156] System preference itemcallnumber not pulling more than 2 subfields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9156 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 3 13:46:26 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Jan 2020 12:46:26 +0000 Subject: [Koha-bugs] [Bug 9156] System preference itemcallnumber not pulling more than 2 subfields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9156 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #96767|0 |1 is obsolete| | --- Comment #20 from Nick Clemens --- Created attachment 96792 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96792&action=edit Bug 9156: Clarify order in the syspref -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 3 13:55:11 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Jan 2020 12:55:11 +0000 Subject: [Koha-bugs] [Bug 22284] Groups of pickup locations for holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |tomascohen at gmail.com |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 3 13:55:20 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Jan 2020 12:55:20 +0000 Subject: [Koha-bugs] [Bug 22284] Groups of pickup locations for holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the|SPONSORED BY: Vermont | release notes|Organization of Koha | |Automated Libraries | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 3 13:56:22 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Jan 2020 12:56:22 +0000 Subject: [Koha-bugs] [Bug 21684] Koha::Object[s]->delete methods must behave identically as the corresponding DBIx::Class ones In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21684 --- Comment #24 from Martin Renvoize --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 3 13:56:24 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Jan 2020 12:56:24 +0000 Subject: [Koha-bugs] [Bug 22284] Groups of pickup locations for holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |20.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 3 13:56:26 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Jan 2020 12:56:26 +0000 Subject: [Koha-bugs] [Bug 22284] Groups of pickup locations for holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 --- Comment #287 from Martin Renvoize --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 3 14:01:18 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Jan 2020 13:01:18 +0000 Subject: [Koha-bugs] [Bug 24327] Anonymous suggestions should not be allowed if AnonymousPatron misconfigured In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24327 --- Comment #9 from Holly --- Hi Katrin, That would be great. I'll sign in full in the future, hc is just a habit. Thanks, Holly -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 3 14:06:46 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Jan 2020 13:06:46 +0000 Subject: [Koha-bugs] [Bug 21684] Koha::Object[s]->delete methods must behave identically as the corresponding DBIx::Class ones In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21684 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |minor -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 3 14:06:51 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Jan 2020 13:06:51 +0000 Subject: [Koha-bugs] [Bug 21684] Koha::Object[s]->delete methods must behave identically as the corresponding DBIx::Class ones In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21684 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_20_05_target | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 3 14:07:15 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Jan 2020 13:07:15 +0000 Subject: [Koha-bugs] [Bug 24150] Add missing Koha::Old::*[s] classes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24150 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |minor -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 3 14:08:52 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Jan 2020 13:08:52 +0000 Subject: [Koha-bugs] [Bug 24016] manager_id in Koha::Patron::Message->store should not depend on userenv alone In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24016 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |Using `userenv` within release notes| |Koha::* object classes is | |deprecated in favour of | |passing parameters. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 3 14:10:01 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Jan 2020 13:10:01 +0000 Subject: [Koha-bugs] [Bug 22284] Groups of pickup locations for holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_20_05_target | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 3 14:30:46 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Jan 2020 13:30:46 +0000 Subject: [Koha-bugs] [Bug 24331] Internal server error when placing hold on item if itemtype undefined In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24331 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Jan 3 14:30:49 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Jan 2020 13:30:49 +0000 Subject: [Koha-bugs] [Bug 24331] Internal server error when placing hold on item if itemtype undefined In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24331 --- Comment #1 from Nick Clemens --- Created attachment 96793 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96793&action=edit Bug 24331: Don't die on items with no type To test: 1 - Find or create an item with no itemtype set 2 - Attempt to place a hold 3 - INternal server error 4 - Apply patch 5 - Repeat 6 - No error 7 - Set the items itemtype to an itemtype marked not for loan 8 - Set circ rules to allow holds on this itemtype 9 - Attempt to place hold, item is not holdable 10 - Remove not for loan from itemtype 11 - Item is holdable -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 3 14:31:00 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Jan 2020 13:31:00 +0000 Subject: [Koha-bugs] [Bug 24331] Internal server error when placing hold on item if itemtype undefined In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24331 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |nick at bywatersolutions.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Jan 3 15:00:28 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Jan 2020 14:00:28 +0000 Subject: [Koha-bugs] [Bug 22284] Groups of pickup locations for holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |gmcharlt at gmail.com Component|Architecture, internals, |Hold requests |and plumbing | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 3 15:26:23 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Jan 2020 14:26:23 +0000 Subject: [Koha-bugs] [Bug 5919] MARC21 fields 583 and 586 should display in OPAC Details In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5919 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #6 from Katrin Fischer --- Note: these changes were only made on the OPAC side and for 530 there is no label. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 3 15:33:13 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Jan 2020 14:33:13 +0000 Subject: [Koha-bugs] [Bug 24336] New: Ask for confirmation before deleting a suggestion in the OPAC Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24336 Bug ID: 24336 Summary: Ask for confirmation before deleting a suggestion in the OPAC Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: oleonard at myacpl.org QA Contact: testopia at bugs.koha-community.org In the OPAC suggestions are deleted without offering the patron any kind of warning. The patron should be asked for confirmation. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 3 15:33:13 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Jan 2020 14:33:13 +0000 Subject: [Koha-bugs] [Bug 12937] Deleting suggestions should ask for a confirmation In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12937 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=24336 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 3 15:57:26 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Jan 2020 14:57:26 +0000 Subject: [Koha-bugs] [Bug 21633] Did finesMode = test ever send email? In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21633 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Jan 3 15:57:29 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Jan 2020 14:57:29 +0000 Subject: [Koha-bugs] [Bug 21633] Did finesMode = test ever send email? In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21633 --- Comment #6 from Nick Clemens --- Created attachment 96794 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96794&action=edit Bug 21633: Remove finesMode 'test' -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 3 15:58:19 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Jan 2020 14:58:19 +0000 Subject: [Koha-bugs] [Bug 24337] New: Checkout note cannot be marked seen if more than 20 exist Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24337 Bug ID: 24337 Summary: Checkout note cannot be marked seen if more than 20 exist Change sponsored?: --- Product: Koha Version: 19.05 Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Circulation Assignee: koha-bugs at lists.koha-community.org Reporter: andrew at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com When there are more than 20 checkout notes in the system, Koha fails to attach actions to the Seen/Not Seen buttons for checkout notes that are not on the first page of notes at cgi-bin/koha/circ/checkout-notes.pl. To Test: - create 21 checkout notes - go to cgi-bin/koha/circ/checkout-notes.pl - inspect the Seen/Not Seen buttons on the 21st note, see that there is no event attached I also filed bug 24335 while looking at this. I don't think it's related, but mentioning it just in case. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 3 15:58:51 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Jan 2020 14:58:51 +0000 Subject: [Koha-bugs] [Bug 24337] Checkout note cannot be marked seen if more than 20 exist In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24337 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick at bywatersolutions.com, | |oleonard at myacpl.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 3 16:26:15 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Jan 2020 15:26:15 +0000 Subject: [Koha-bugs] [Bug 20863] Delete bib_list and intranet_bib_list cookies when cart is emptied out In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20863 Michal Denar changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |black23 at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 3 16:35:02 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Jan 2020 15:35:02 +0000 Subject: [Koha-bugs] [Bug 24016] manager_id in Koha::Patron::Message->store should not depend on userenv alone In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24016 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 3 16:35:16 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Jan 2020 15:35:16 +0000 Subject: [Koha-bugs] [Bug 24217] use strict for all modules In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24217 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 3 16:46:44 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Jan 2020 15:46:44 +0000 Subject: [Koha-bugs] [Bug 24089] Upgrade jQuery Validate plugin in the staff client In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24089 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |trivial Component|Templates |Architecture, internals, | |and plumbing CC| |martin.renvoize at ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 3 16:47:36 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Jan 2020 15:47:36 +0000 Subject: [Koha-bugs] [Bug 23957] Remove button style with famfamfam icon background and replace with Font Awesome In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23957 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |minor CC| |martin.renvoize at ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 3 16:48:15 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Jan 2020 15:48:15 +0000 Subject: [Koha-bugs] [Bug 23956] Replace famfamfam calendar icon in staff client with CSS data-url In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23956 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |minor CC| |martin.renvoize at ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 3 16:48:39 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Jan 2020 15:48:39 +0000 Subject: [Koha-bugs] [Bug 23956] Replace famfamfam calendar icon in staff client with CSS data-url In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23956 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |20.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 3 16:48:41 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Jan 2020 15:48:41 +0000 Subject: [Koha-bugs] [Bug 23956] Replace famfamfam calendar icon in staff client with CSS data-url In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23956 --- Comment #3 from Martin Renvoize --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 3 16:48:42 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Jan 2020 15:48:42 +0000 Subject: [Koha-bugs] [Bug 23957] Remove button style with famfamfam icon background and replace with Font Awesome In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23957 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |20.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 3 16:48:44 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Jan 2020 15:48:44 +0000 Subject: [Koha-bugs] [Bug 23957] Remove button style with famfamfam icon background and replace with Font Awesome In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23957 --- Comment #10 from Martin Renvoize --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 3 16:48:46 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Jan 2020 15:48:46 +0000 Subject: [Koha-bugs] [Bug 24089] Upgrade jQuery Validate plugin in the staff client In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24089 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |20.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 3 16:48:48 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Jan 2020 15:48:48 +0000 Subject: [Koha-bugs] [Bug 24089] Upgrade jQuery Validate plugin in the staff client In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24089 --- Comment #4 from Martin Renvoize --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 3 16:53:41 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Jan 2020 15:53:41 +0000 Subject: [Koha-bugs] [Bug 24181] Make our datepicker inputs sexy In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24181 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |20.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 3 16:53:43 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Jan 2020 15:53:43 +0000 Subject: [Koha-bugs] [Bug 24181] Make our datepicker inputs sexy In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24181 --- Comment #14 from Martin Renvoize --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 3 17:02:27 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Jan 2020 16:02:27 +0000 Subject: [Koha-bugs] [Bug 23594] Batch modification for itemtypes on suggestions page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23594 Liz Rea changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |wizzyrea at gmail.com --- Comment #9 from Liz Rea --- This still applies, QA? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 3 17:02:45 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Jan 2020 16:02:45 +0000 Subject: [Koha-bugs] [Bug 23590] Allow to modify the manager of a suggestion In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23590 Liz Rea changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |wizzyrea at gmail.com --- Comment #51 from Liz Rea --- This still applies, QA? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 3 17:03:15 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Jan 2020 16:03:15 +0000 Subject: [Koha-bugs] [Bug 22784] Archiving Purchase Suggestions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22784 Liz Rea changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |wizzyrea at gmail.com --- Comment #20 from Liz Rea --- This still applies, QA? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 3 17:12:40 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Jan 2020 16:12:40 +0000 Subject: [Koha-bugs] [Bug 24063] Add Sami language characters to Zebra In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24063 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This patch adds some release notes| |additional characters to | |the default zebra mappings | |for Sami languages to aid | |in searching on systems | |with such data present. CC| |martin.renvoize at ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 3 17:14:04 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Jan 2020 16:14:04 +0000 Subject: [Koha-bugs] [Bug 24212] OPAC send list dialog opens too small in IE In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24212 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com Severity|enhancement |normal -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 3 17:14:41 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Jan 2020 16:14:41 +0000 Subject: [Koha-bugs] [Bug 24059] Remove unused Greybox assets from detail.tt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24059 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com Severity|enhancement |normal -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 3 17:16:01 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Jan 2020 16:16:01 +0000 Subject: [Koha-bugs] [Bug 24059] Remove unused Greybox assets from detail.tt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24059 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |20.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 3 17:16:03 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Jan 2020 16:16:03 +0000 Subject: [Koha-bugs] [Bug 24059] Remove unused Greybox assets from detail.tt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24059 --- Comment #5 from Martin Renvoize --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 3 17:16:05 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Jan 2020 16:16:05 +0000 Subject: [Koha-bugs] [Bug 24063] Add Sami language characters to Zebra In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24063 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |20.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 3 17:16:07 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Jan 2020 16:16:07 +0000 Subject: [Koha-bugs] [Bug 24063] Add Sami language characters to Zebra In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24063 --- Comment #4 from Martin Renvoize --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 3 17:16:09 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Jan 2020 16:16:09 +0000 Subject: [Koha-bugs] [Bug 24212] OPAC send list dialog opens too small in IE In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24212 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |20.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 3 17:16:11 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Jan 2020 16:16:11 +0000 Subject: [Koha-bugs] [Bug 24212] OPAC send list dialog opens too small in IE In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24212 --- Comment #7 from Martin Renvoize --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 3 17:17:44 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Jan 2020 16:17:44 +0000 Subject: [Koha-bugs] [Bug 22784] Archiving Purchase Suggestions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22784 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #21 from Katrin Fischer --- (In reply to Liz Rea from comment #20) > This still applies, QA? Please don't - only person from the QA team seeing this will probably be me and the people who can't QA because they are already on the bug report having worked on it :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 3 17:22:33 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Jan 2020 16:22:33 +0000 Subject: [Koha-bugs] [Bug 24173] Advanced Editor: Show subtitle & published date on the search page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24173 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com Text to go in the| |Add Subtitle (all parts) release notes| |and date published to the | |results that come up for | |the Advanced Editor Search. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 3 17:22:47 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Jan 2020 16:22:47 +0000 Subject: [Koha-bugs] [Bug 24173] Advanced Editor: Show subtitle & published date on the search page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24173 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the|Add Subtitle (all parts) |This enhancement adds release notes|and date published to the |Subtitle (all parts) and |results that come up for |date published to the |the Advanced Editor Search. |results that come up for | |the Advanced Editor Search. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 3 17:26:11 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Jan 2020 16:26:11 +0000 Subject: [Koha-bugs] [Bug 24314] Update de-DE MARC21 frameworks for updates 28+29 (May and November 2019) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24314 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com Status|Passed QA |BLOCKED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 3 17:26:19 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Jan 2020 16:26:19 +0000 Subject: [Koha-bugs] [Bug 24314] Update de-DE MARC21 frameworks for updates 28+29 (May and November 2019) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24314 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|BLOCKED |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 3 17:26:36 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Jan 2020 16:26:36 +0000 Subject: [Koha-bugs] [Bug 24314] Update de-DE MARC21 frameworks for updates 28+29 (May and November 2019) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24314 --- Comment #9 from Martin Renvoize --- Waiting on PQA on bug 24312 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 3 17:29:21 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Jan 2020 16:29:21 +0000 Subject: [Koha-bugs] [Bug 7882] Add ability to move and reorder fields in MARC editor In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7882 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |Manual, | |release-notes-needed CC| |martin.renvoize at ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 3 17:30:45 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Jan 2020 16:30:45 +0000 Subject: [Koha-bugs] [Bug 7882] Add ability to move and reorder fields in MARC editor In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7882 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |20.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 3 17:30:49 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Jan 2020 16:30:49 +0000 Subject: [Koha-bugs] [Bug 7882] Add ability to move and reorder fields in MARC editor In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7882 --- Comment #65 from Martin Renvoize --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 3 17:30:51 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Jan 2020 16:30:51 +0000 Subject: [Koha-bugs] [Bug 24173] Advanced Editor: Show subtitle & published date on the search page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24173 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |20.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 3 17:30:53 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Jan 2020 16:30:53 +0000 Subject: [Koha-bugs] [Bug 24173] Advanced Editor: Show subtitle & published date on the search page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24173 --- Comment #5 from Martin Renvoize --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 3 17:33:26 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Jan 2020 16:33:26 +0000 Subject: [Koha-bugs] [Bug 10469] Display more when editing subfields in frameworks In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10469 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com Keywords| |release-notes-needed -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 3 17:33:33 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Jan 2020 16:33:33 +0000 Subject: [Koha-bugs] [Bug 10469] Display more when editing subfields in frameworks In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10469 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |Manual -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 3 17:33:49 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Jan 2020 16:33:49 +0000 Subject: [Koha-bugs] [Bug 10469] Display more when editing subfields in frameworks In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10469 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |20.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 3 17:33:50 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Jan 2020 16:33:50 +0000 Subject: [Koha-bugs] [Bug 24095] Missing MSG_CONFIRM_DELETE_HOLD variable on the OPAC user account page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24095 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|agustinmoyano at theke.io |oleonard at myacpl.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 3 17:33:51 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Jan 2020 16:33:51 +0000 Subject: [Koha-bugs] [Bug 10469] Display more when editing subfields in frameworks In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10469 --- Comment #7 from Martin Renvoize --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 3 17:34:36 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Jan 2020 16:34:36 +0000 Subject: [Koha-bugs] [Bug 22784] Archiving Purchase Suggestions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22784 --- Comment #22 from Tomás Cohen Arazi --- (In reply to Liz Rea from comment #20) > This still applies, QA? I can take a look on Monday -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 3 17:36:11 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Jan 2020 16:36:11 +0000 Subject: [Koha-bugs] [Bug 24080] Add a 'payout' process to accounts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24080 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |20.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes. You are on the CC list for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Jan 3 17:36:13 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Jan 2020 16:36:13 +0000 Subject: [Koha-bugs] [Bug 24080] Add a 'payout' process to accounts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24080 --- Comment #43 from Martin Renvoize --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are on the CC list for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 3 17:38:09 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Jan 2020 16:38:09 +0000 Subject: [Koha-bugs] [Bug 24080] Add a 'payout' process to accounts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24080 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This patchset adds an release notes| |audited process for paying | |out excess credits on a | |patrons account. -- You are receiving this mail because: You are watching all bug changes. You are on the CC list for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Jan 3 17:38:17 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Jan 2020 16:38:17 +0000 Subject: [Koha-bugs] [Bug 24080] Add a 'payout' process to accounts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24080 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_20_05_target, | |RM_priority | -- You are receiving this mail because: You are watching all bug changes. You are on the CC list for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Jan 3 17:47:02 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Jan 2020 16:47:02 +0000 Subject: [Koha-bugs] [Bug 24235] /misc/cronjobs/advance_notices.pl DUEDGST does NOT send sms, just e-mail In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24235 Joy Nelson changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |joy at bywatersolutions.com Status|Pushed to master |Pushed to stable Version(s)|20.05.00 |20.05.00, 19.11.02 released in| | --- Comment #12 from Joy Nelson --- Pushed to 19.11.x branch for 19.11.02 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 3 17:47:41 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Jan 2020 16:47:41 +0000 Subject: [Koha-bugs] [Bug 24080] Add a 'payout' process to accounts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24080 --- Comment #44 from Martin Renvoize --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are on the CC list for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 3 17:53:14 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Jan 2020 16:53:14 +0000 Subject: [Koha-bugs] [Bug 24338] New: CASH is missing from the default payment_types Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24338 Bug ID: 24338 Summary: CASH is missing from the default payment_types Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Fines and fees Assignee: koha-bugs at lists.koha-community.org Reporter: martin.renvoize at ptfs-europe.com QA Contact: testopia at bugs.koha-community.org Bug 23321 added cash registers to koha which utilise a payment_type value of CASH which is expected to be present in the system by default. It appears that this part of the DB update went missing during subsequent rebases of the patchset :( -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 3 17:53:23 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Jan 2020 16:53:23 +0000 Subject: [Koha-bugs] [Bug 24338] CASH is missing from the default payment_types In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24338 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |major -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Jan 3 17:53:26 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Jan 2020 16:53:26 +0000 Subject: [Koha-bugs] [Bug 24338] CASH is missing from the default payment_types In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24338 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |martin.renvoize at ptfs-europe |ity.org |.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 3 17:53:36 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Jan 2020 16:53:36 +0000 Subject: [Koha-bugs] [Bug 24338] CASH is missing from the default payment_types In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24338 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |22321 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22321 [Bug 22321] Make it possible to edit illrequests.borrowernumber -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 3 17:53:36 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Jan 2020 16:53:36 +0000 Subject: [Koha-bugs] [Bug 22321] Make it possible to edit illrequests.borrowernumber In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22321 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |24338 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24338 [Bug 24338] CASH is missing from the default payment_types -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Jan 3 17:58:58 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Jan 2020 16:58:58 +0000 Subject: [Koha-bugs] [Bug 24339] New: SIP codes are missing from the default payment_types on installation Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24339 Bug ID: 24339 Summary: SIP codes are missing from the default payment_types on installation Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Fines and fees Assignee: koha-bugs at lists.koha-community.org Reporter: martin.renvoize at ptfs-europe.com QA Contact: testopia at bugs.koha-community.org Bug 22610 moved the sip payment types out of accounttypes and into the payment_types authorized values.. however, it appears during rebases that the installation side of this was lost and only existing systems will populate the payment_type defaults on upgrade. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Jan 3 17:59:11 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Jan 2020 16:59:11 +0000 Subject: [Koha-bugs] [Bug 24339] SIP codes are missing from the default payment_types on installation In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24339 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |22610 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22610 [Bug 22610] SIP Payment Types should be moved out of accountype -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 3 17:59:11 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Jan 2020 16:59:11 +0000 Subject: [Koha-bugs] [Bug 22610] SIP Payment Types should be moved out of accountype In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22610 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |24339 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24339 [Bug 24339] SIP codes are missing from the default payment_types on installation -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 3 17:59:31 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Jan 2020 16:59:31 +0000 Subject: [Koha-bugs] [Bug 24339] SIP codes are missing from the default payment_types on installation In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24339 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |24338 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24338 [Bug 24338] CASH is missing from the default payment_types -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Jan 3 17:59:31 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Jan 2020 16:59:31 +0000 Subject: [Koha-bugs] [Bug 24338] CASH is missing from the default payment_types In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24338 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |24339 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24339 [Bug 24339] SIP codes are missing from the default payment_types on installation -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 3 18:01:58 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Jan 2020 17:01:58 +0000 Subject: [Koha-bugs] [Bug 24338] CASH is missing from the default payment_types In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24338 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |23894 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23894 [Bug 23894] accountlines.payment_type and accountlines.credit_type should be merged -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 3 18:01:58 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Jan 2020 17:01:58 +0000 Subject: [Koha-bugs] [Bug 23894] accountlines.payment_type and accountlines.credit_type should be merged In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23894 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |24338 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24338 [Bug 24338] CASH is missing from the default payment_types -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 3 18:03:53 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Jan 2020 17:03:53 +0000 Subject: [Koha-bugs] [Bug 24338] CASH is missing from the default payment_types In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24338 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|22321 |23321 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22321 [Bug 22321] Make it possible to edit illrequests.borrowernumber https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23321 [Bug 23321] Add 'cash registers' to the accounts system -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 3 18:03:53 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Jan 2020 17:03:53 +0000 Subject: [Koha-bugs] [Bug 22321] Make it possible to edit illrequests.borrowernumber In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22321 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|24338 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24338 [Bug 24338] CASH is missing from the default payment_types -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 3 18:03:53 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Jan 2020 17:03:53 +0000 Subject: [Koha-bugs] [Bug 23321] Add 'cash registers' to the accounts system In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23321 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |24338 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24338 [Bug 24338] CASH is missing from the default payment_types -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 3 18:09:30 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Jan 2020 17:09:30 +0000 Subject: [Koha-bugs] [Bug 24339] SIP codes are missing from the default payment_types on installation In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24339 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |martin.renvoize at ptfs-europe |ity.org |.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Jan 3 18:23:49 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Jan 2020 17:23:49 +0000 Subject: [Koha-bugs] [Bug 24095] Missing MSG_CONFIRM_DELETE_HOLD variable on the OPAC user account page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24095 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 3 18:23:51 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Jan 2020 17:23:51 +0000 Subject: [Koha-bugs] [Bug 24095] Missing MSG_CONFIRM_DELETE_HOLD variable on the OPAC user account page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24095 --- Comment #2 from Owen Leonard --- Created attachment 96795 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96795&action=edit Bug 24095: Missing MSG_CONFIRM_DELETE_HOLD variable on the OPAC user account page This patch corrects markup in the table of holds in the OPAC so that the hold deletion confirmation message appears correctly. The onclick event removed from holds-table.inc was made obsolete by Bug 21870. To test, apply the patch and log in to the OPAC as a user who has holds. - From the "your summary" page in the OPAC, open the holds tab. - Click any "Cancel" button. You should be shown a confirmation modal. - Test both the confirm and cancel operations. - Log in to self-checkout and confirm that the holds tab there is unaffected: Although it uses the same include, the hold cancellation option isn't shown there. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 3 18:35:10 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Jan 2020 17:35:10 +0000 Subject: [Koha-bugs] [Bug 24340] New: We ought to be able to disable SIP using koha-sip Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24340 Bug ID: 24340 Summary: We ought to be able to disable SIP using koha-sip Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Command-line Utilities Assignee: koha-bugs at lists.koha-community.org Reporter: wizzyrea at gmail.com QA Contact: testopia at bugs.koha-community.org CC: robin at catalyst.net.nz We ought to be able to disable SIP with koha-sip --disable inst At minimum, disabling SIP should - Stop running SIP services for that instance - back up the latest existent SIPconfig, and remove the SIPconfig.xml from /etc/koha/sites/inst/ so that it can't start. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 3 18:39:11 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Jan 2020 17:39:11 +0000 Subject: [Koha-bugs] [Bug 24341] New: Allow for more complex markup in OPAC confirmation dialogs Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24341 Bug ID: 24341 Summary: Allow for more complex markup in OPAC confirmation dialogs Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard at myacpl.org Reporter: oleonard at myacpl.org QA Contact: testopia at bugs.koha-community.org CC: testopia at bugs.koha-community.org Depends on: 21870 The confirmation dialogs made possible by Bug 21870 currently use jQuery's text() function to add content to the dialog's body. Using html() instead will allow us to show more than just plain text. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21870 [Bug 21870] Convert browser alerts to modals: OPAC user summary -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 3 18:39:11 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Jan 2020 17:39:11 +0000 Subject: [Koha-bugs] [Bug 21870] Convert browser alerts to modals: OPAC user summary In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21870 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |24341 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24341 [Bug 24341] Allow for more complex markup in OPAC confirmation dialogs -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 3 18:49:19 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Jan 2020 17:49:19 +0000 Subject: [Koha-bugs] [Bug 24341] Allow for more complex markup in OPAC confirmation dialogs In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24341 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 3 18:49:21 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Jan 2020 17:49:21 +0000 Subject: [Koha-bugs] [Bug 24341] Allow for more complex markup in OPAC confirmation dialogs In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24341 --- Comment #1 from Owen Leonard --- Created attachment 96796 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96796&action=edit Bug 24341: Allow for more complex markup in OPAC confirmation dialogs This patch changes the globally-available confirmModal() function in the OPAC so that it uses jQuery's html() function for adding information to the confirmation modal's body. This will allow for more than just plain text to be added. This patch also removes some obsolete lines from the JavaScript in opac-user.tt and renames some variable for clarity. To test, apply the patch log in to the OPAC as a user who has holds and article requests. - Test the following interactions, both the confirmation and cancel options for each: - Cancel a hold - Suspend all holds - Resume all holds - Cancel an article request -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 3 18:51:20 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Jan 2020 17:51:20 +0000 Subject: [Koha-bugs] [Bug 24340] We ought to be able to disable SIP using koha-sip In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24340 Liz Rea changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Jan 3 18:51:22 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Jan 2020 17:51:22 +0000 Subject: [Koha-bugs] [Bug 24340] We ought to be able to disable SIP using koha-sip In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24340 --- Comment #1 from Liz Rea --- Created attachment 96797 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96797&action=edit Bug 24340: allow koha-sip --disable inst To test: - Enable sip for your testing instance sudo koha-sip --enable inst - Start sip for your testing instance sudo koha-sip --start inst - Verify it is running ps ax |grep sip -> you should see processes - Disable sip for your testing intance sudo koha-sip --disable inst - Verify that the following has happened: * the SIPconfig.xml file has been moved to SIPconfig.xml.bak * SIP is no longer running for your instance - no SIP processes * SIP Cannot be started for the instance because of no config. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 3 19:03:57 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Jan 2020 18:03:57 +0000 Subject: [Koha-bugs] [Bug 22381] Wording on Calendar-related system preferences not standardized In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22381 Joy Nelson changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|20.05.00 |20.05.00, 19.11.02 released in| | Status|Pushed to master |Pushed to stable CC| |joy at bywatersolutions.com --- Comment #16 from Joy Nelson --- Pushed to 19.11.x for 19.11.02 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 3 19:09:37 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Jan 2020 18:09:37 +0000 Subject: [Koha-bugs] [Bug 24336] Ask for confirmation before deleting a suggestion in the OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24336 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |24341 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24341 [Bug 24341] Allow for more complex markup in OPAC confirmation dialogs -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 3 19:09:37 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Jan 2020 18:09:37 +0000 Subject: [Koha-bugs] [Bug 24341] Allow for more complex markup in OPAC confirmation dialogs In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24341 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |24336 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24336 [Bug 24336] Ask for confirmation before deleting a suggestion in the OPAC -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 3 19:13:44 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Jan 2020 18:13:44 +0000 Subject: [Koha-bugs] [Bug 24215] Warnings about guarantor relationships show ARRAY errors In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24215 Joy Nelson changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |joy at bywatersolutions.com Version(s)|20.05.00 |20.05.00, 19.11.02 released in| | Status|Pushed to master |Pushed to stable --- Comment #13 from Joy Nelson --- Pushed to 19.11.x branch for 19.11.02 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 3 19:13:47 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Jan 2020 18:13:47 +0000 Subject: [Koha-bugs] [Bug 24336] Ask for confirmation before deleting a suggestion in the OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24336 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 3 19:13:50 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Jan 2020 18:13:50 +0000 Subject: [Koha-bugs] [Bug 24336] Ask for confirmation before deleting a suggestion in the OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24336 --- Comment #1 from Owen Leonard --- Created attachment 96798 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96798&action=edit Bug 24336: Ask for confirmation before deleting a suggestion in the OPAC This patch modifies the OPAC suggestions interface so that patrons will be asked for confirmation before deleting suggestions. The patch also makes some minor markup changes to improve consistency between this interface and others in the OPAC. To test, apply the patch and log in to the OPAC as a user who has submitted multiple suggestions. - From the list of your suggestions, confirm that the "New purchase suggestion" and "Delete" links have Font Awesome icons. - Check the checkbox corresponding to one of your suggestions. You can also now click the title of the suggestions to control the checkbox. - When you check a box the "Delete" link at the top of the page should activate. - Clicking the delete link should trigger a confirmation modal showing the title(s) you selected. - The message and button labels should reflect whether one or multiple titles are being deleted. - Test that the confirm and cancel controls work correctly. - Also test this process via the delete button at the bottom of the table of suggestions. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 3 19:31:44 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Jan 2020 18:31:44 +0000 Subject: [Koha-bugs] [Bug 17268] Advanced cataloging editor - rancor - macros are lost when browser storage cleared In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17268 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrew at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 3 19:42:43 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Jan 2020 18:42:43 +0000 Subject: [Koha-bugs] [Bug 24335] Cannot mark checkout notes seen/not seen in bulk In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24335 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |oleonard at myacpl.org |ity.org | Status|NEW |ASSIGNED -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 3 19:49:05 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Jan 2020 18:49:05 +0000 Subject: [Koha-bugs] [Bug 24335] Cannot mark checkout notes seen/not seen in bulk In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24335 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 3 19:49:08 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Jan 2020 18:49:08 +0000 Subject: [Koha-bugs] [Bug 24335] Cannot mark checkout notes seen/not seen in bulk In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24335 --- Comment #1 from Owen Leonard --- Created attachment 96799 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96799&action=edit Bug 24335: Cannot mark checkout notes seen/not seen in bulk This patch changes the way checkbox events are handled on the checkout notes page so that checking a checkbox enables the batch operation controls. Note: The addition of a "markseen" class is a preventative measure to avoid future problems where using the "btn-small" class might not be specific enough. To test you should have multiple checkout notes to work with, both seen and unseen. Apply the patch and go to "Checkout notes pending" from the staff client home page. - Check any checkbox. The "Mark seen" and "Mark not seen" should go from disabled to enabled. - Test that the buttons work correctly. - Click the "Select all" and "Clear all" controls and confirm that the buttons are enabled and disabled correctly. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 3 20:01:02 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Jan 2020 19:01:02 +0000 Subject: [Koha-bugs] [Bug 21959] Batch item modification - ability to apply regular expression on text fields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21959 --- Comment #30 from Victor Grousset/tuxayo --- Additional info: It's sponsored by the City of Nîmes. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 3 20:19:26 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Jan 2020 19:19:26 +0000 Subject: [Koha-bugs] [Bug 24337] Checkout note cannot be marked seen if more than 20 exist In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24337 --- Comment #1 from Owen Leonard --- I think the patch for Bug 24335 fixes this. However, there remains the ambiguity about whether or not those batch operations will affect checked items which are not on the current "page" of the table. For instance: - I check all items on the first page - I navigate to the next page - I check all the items on the second page - I click the "Mark seen" button Result: Only the checked items on the second page are marked seen. One possible solution: A prompt asking the user whether they want to finish what they're doing before switching pages in the table. I bring this up in case this bug should be repurposed to address that issue. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 3 20:22:59 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Jan 2020 19:22:59 +0000 Subject: [Koha-bugs] [Bug 24342] New: Self check needs on screen keyboard for login Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24342 Bug ID: 24342 Summary: Self check needs on screen keyboard for login Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Self checkout Assignee: koha-bugs at lists.koha-community.org Reporter: cbrannon at cdalibrary.org QA Contact: testopia at bugs.koha-community.org For those of us using touch screens, the option to have an on screen keyboard (either numeric pad, full keyboard, or definable) would be a great asset. Not everyone carries their card. Some have the number written down or memorized. I've done a workaround with jquery and css using http://keith-wood.name/keypad.html, but it took a while to get just right. This would be a great permanent addition. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 3 20:42:10 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Jan 2020 19:42:10 +0000 Subject: [Koha-bugs] [Bug 24335] Cannot mark checkout notes seen/not seen in bulk In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24335 ByWater Sandboxes changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #96799|0 |1 is obsolete| | --- Comment #2 from ByWater Sandboxes --- Created attachment 96800 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96800&action=edit Bug 24335: Cannot mark checkout notes seen/not seen in bulk This patch changes the way checkbox events are handled on the checkout notes page so that checking a checkbox enables the batch operation controls. Note: The addition of a "markseen" class is a preventative measure to avoid future problems where using the "btn-small" class might not be specific enough. To test you should have multiple checkout notes to work with, both seen and unseen. Apply the patch and go to "Checkout notes pending" from the staff client home page. - Check any checkbox. The "Mark seen" and "Mark not seen" should go from disabled to enabled. - Test that the buttons work correctly. - Click the "Select all" and "Clear all" controls and confirm that the buttons are enabled and disabled correctly. Signed-off-by: Andrew Fuerste-Henry -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 3 20:42:54 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Jan 2020 19:42:54 +0000 Subject: [Koha-bugs] [Bug 24335] Cannot mark checkout notes seen/not seen in bulk In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24335 --- Comment #3 from Andrew Fuerste-Henry --- Patch worked for me, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 3 20:43:07 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Jan 2020 19:43:07 +0000 Subject: [Koha-bugs] [Bug 24335] Cannot mark checkout notes seen/not seen in bulk In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24335 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 3 20:44:05 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Jan 2020 19:44:05 +0000 Subject: [Koha-bugs] [Bug 24337] Checkout note cannot be marked seen if more than 20 exist In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24337 --- Comment #2 from Andrew Fuerste-Henry --- I tried this while signing off on 24335. The Seen/Not Seen buttons on the second page still didn't work for me. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 3 20:57:26 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Jan 2020 19:57:26 +0000 Subject: [Koha-bugs] [Bug 24337] Checkout note cannot be marked seen if more than 20 exist In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24337 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |oleonard at myacpl.org |ity.org | Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Jan 3 20:57:34 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Jan 2020 19:57:34 +0000 Subject: [Koha-bugs] [Bug 24337] Checkout note cannot be marked seen if more than 20 exist In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24337 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Version|19.05 |master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 3 21:06:55 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Jan 2020 20:06:55 +0000 Subject: [Koha-bugs] [Bug 24337] Checkout note cannot be marked seen if more than 20 exist In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24337 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |24335 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24335 [Bug 24335] Cannot mark checkout notes seen/not seen in bulk -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 3 21:06:55 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Jan 2020 20:06:55 +0000 Subject: [Koha-bugs] [Bug 24335] Cannot mark checkout notes seen/not seen in bulk In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24335 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |24337 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24337 [Bug 24337] Checkout note cannot be marked seen if more than 20 exist -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 3 21:09:04 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Jan 2020 20:09:04 +0000 Subject: [Koha-bugs] [Bug 24337] Checkout note cannot be marked seen if more than 20 exist In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24337 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 3 21:09:06 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Jan 2020 20:09:06 +0000 Subject: [Koha-bugs] [Bug 24337] Checkout note cannot be marked seen if more than 20 exist In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24337 --- Comment #3 from Owen Leonard --- Created attachment 96801 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96801&action=edit Bug 24337: Checkout note cannot be marked seen if more than 20 exist This patch modifies the event handler on the individual "Mark seen" / "Mark unseen" buttons in the table of checkout notes. For an event to be successfully attached to a hidden element it must be given a context. To test you should have multiple checkout notes to work with, both seen and unseen. Apply the patch and go to "Checkout notes pending" from the staff client home page. - Navigate to the second "page" of data in the DataTable. - Test the functionality of the "Mark seen" and "Mark unseen" buttons. They should work correctly. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 3 21:10:13 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Jan 2020 20:10:13 +0000 Subject: [Koha-bugs] [Bug 24337] Checkout note cannot be marked seen if more than 20 exist In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24337 --- Comment #4 from Owen Leonard --- (In reply to Andrew Fuerste-Henry from comment #2) > The Seen/Not Seen buttons on the second page still didn't work for me. Thanks Andrew, I misunderstood. Hopefully this patch works for you. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 3 21:32:30 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Jan 2020 20:32:30 +0000 Subject: [Koha-bugs] [Bug 24337] Checkout note cannot be marked seen if more than 20 exist In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24337 ByWater Sandboxes changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #96801|0 |1 is obsolete| | --- Comment #5 from ByWater Sandboxes --- Created attachment 96802 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96802&action=edit Bug 24337: Checkout note cannot be marked seen if more than 20 exist This patch modifies the event handler on the individual "Mark seen" / "Mark unseen" buttons in the table of checkout notes. For an event to be successfully attached to a hidden element it must be given a context. To test you should have multiple checkout notes to work with, both seen and unseen. Apply the patch and go to "Checkout notes pending" from the staff client home page. - Navigate to the second "page" of data in the DataTable. - Test the functionality of the "Mark seen" and "Mark unseen" buttons. They should work correctly. Signed-off-by: Andrew Fuerste-Henry -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 3 21:33:30 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Jan 2020 20:33:30 +0000 Subject: [Koha-bugs] [Bug 24337] Checkout note cannot be marked seen if more than 20 exist In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24337 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #6 from Andrew Fuerste-Henry --- In retrospect, I didn't describe it well. Signing off. Thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 3 21:49:22 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Jan 2020 20:49:22 +0000 Subject: [Koha-bugs] [Bug 24176] Make datelastborrowed a column in holdings_table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24176 Maryse Simard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #96001|0 |1 is obsolete| | --- Comment #2 from Maryse Simard --- Created attachment 96803 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96803&action=edit Bug 24176: add datelastborrowed column Signed-off-by: Maryse Simard -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 3 22:21:26 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Jan 2020 21:21:26 +0000 Subject: [Koha-bugs] [Bug 22831] Elasticsearch - add a maintenance script for checking DB vs index counts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22831 Bouzid Fergani changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95156|0 |1 is obsolete| | --- Comment #19 from Bouzid Fergani --- Created attachment 96804 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96804&action=edit Bug 22831: Elasticsearch - add a maintenance script for checking DB vs index counts This script uses Array::Utils and adds a dependency To test: 1 - Have Koha with ES running 2 - Delete some records from ES curl -X DELETE "es:9200/koha_kohadev_biblios/data/5" curl -X DELETE "es:9200/koha_kohadev_authorities/data/5" 3 - perl misc/maintenance/compare_es_to_db.pl 4 - Note you are notified of problems in both indexes 5 - perl misc/search_tools/rebuild_elastic_search.pl -a 6 - perl misc/maintenance/compare_es_to_db.pl 7 - Note you are only notified about problems in biblios (assuming you don't have other issues) 8 - perl misc/search_tools/rebuild_elasticsearch.pl -b 9 - perl misc/maintenance/compare_es_to_db.pl 10 - Both counts match, no problems Signed-off-by: Ere Maijala Signed-off-by: Bouzid Fergani -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 3 22:21:29 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Jan 2020 21:21:29 +0000 Subject: [Koha-bugs] [Bug 22831] Elasticsearch - add a maintenance script for checking DB vs index counts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22831 Bouzid Fergani changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95157|0 |1 is obsolete| | --- Comment #20 from Bouzid Fergani --- Created attachment 96805 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96805&action=edit Bug 22831: (follow-up) Determine where the record is missing and provide link, show counter Signed-off-by: Ere Maijala Signed-off-by: Bouzid Fergani -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 3 22:21:32 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Jan 2020 21:21:32 +0000 Subject: [Koha-bugs] [Bug 22831] Elasticsearch - add a maintenance script for checking DB vs index counts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22831 Bouzid Fergani changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95176|0 |1 is obsolete| | --- Comment #21 from Bouzid Fergani --- Created attachment 96806 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96806&action=edit Bug 22831: (follow-up) Sort results, group by db Signed-off-by: Bouzid Fergani -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 3 22:23:54 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Jan 2020 21:23:54 +0000 Subject: [Koha-bugs] [Bug 24324] delete_records_via_leader.pl cron error with item deletion In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24324 Liz Rea changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 3 22:23:57 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Jan 2020 21:23:57 +0000 Subject: [Koha-bugs] [Bug 24324] delete_records_via_leader.pl cron error with item deletion In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24324 --- Comment #1 from Liz Rea --- Created attachment 96807 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96807&action=edit Bug 24324: Resolve error with delete_records_via_leader.pl To test: Have a record with the 000 position 5 set to "deleted" (record status) Use koha-shell to run the job with the -i flag: perl misc/cronjobs/delete_records_via_leader.pl -c -i -v * items and the record should be deleted Mark another record with the 000 position 5 set to deleted (record status) Use koha-shell to run the job without the -i flag: perl misc/cronjobs/delete_records_via_leader.pl -c -v * if the record had items, it will not be deleted * if the record did not have items, it will be deleted. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Jan 3 22:27:10 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Jan 2020 21:27:10 +0000 Subject: [Koha-bugs] [Bug 24324] delete_records_via_leader.pl cron error with item deletion In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24324 Liz Rea changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #96807|0 |1 is obsolete| | --- Comment #2 from Liz Rea --- Created attachment 96808 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96808&action=edit Bug 24324: Resolve error with delete_records_via_leader.pl To test: Have a record with the 000 position 5 set to "deleted" (record status) Use koha-shell to run the job with the -i flag: perl misc/cronjobs/delete_records_via_leader.pl -c -i -v * items and the record should be deleted Mark another record with the 000 position 5 set to deleted (record status) Use koha-shell to run the job without the -i flag: perl misc/cronjobs/delete_records_via_leader.pl -c -v * if the record had items, it will not be deleted * if the record did not have items, it will be deleted. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Jan 3 22:37:15 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Jan 2020 21:37:15 +0000 Subject: [Koha-bugs] [Bug 24336] Ask for confirmation before deleting a suggestion in the OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24336 Maryse Simard changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |maryse.simard at inlibro.com Status|Needs Signoff |Failed QA --- Comment #2 from Maryse Simard --- When selecting multiple titles to delete, the modal shows only [object Object] in it's body instead of the list of titles. The rest works perfectly. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 3 22:41:14 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Jan 2020 21:41:14 +0000 Subject: [Koha-bugs] [Bug 24340] We ought to be able to disable SIP using koha-sip In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24340 Liz Rea changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |wizzyrea at gmail.com --- Comment #2 from Liz Rea --- Another feature that would be neat, but that I probably won't do for this patch, is the ability to re-enable from a backed up config, if it exists. I don't know why someone would want to do that, but we're keeping a backup so why not allow it. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Jan 3 22:41:19 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Jan 2020 21:41:19 +0000 Subject: [Koha-bugs] [Bug 24336] Ask for confirmation before deleting a suggestion in the OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24336 Maryse Simard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #96798|0 |1 is obsolete| | --- Comment #3 from Maryse Simard --- Created attachment 96809 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96809&action=edit Bug 24336: Ask for confirmation before deleting a suggestion in the OPAC This patch modifies the OPAC suggestions interface so that patrons will be asked for confirmation before deleting suggestions. The patch also makes some minor markup changes to improve consistency between this interface and others in the OPAC. To test, apply the patch and log in to the OPAC as a user who has submitted multiple suggestions. - From the list of your suggestions, confirm that the "New purchase suggestion" and "Delete" links have Font Awesome icons. - Check the checkbox corresponding to one of your suggestions. You can also now click the title of the suggestions to control the checkbox. - When you check a box the "Delete" link at the top of the page should activate. - Clicking the delete link should trigger a confirmation modal showing the title(s) you selected. - The message and button labels should reflect whether one or multiple titles are being deleted. - Test that the confirm and cancel controls work correctly. - Also test this process via the delete button at the bottom of the table of suggestions. Signed-off-by: Maryse Simard -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 3 22:42:15 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Jan 2020 21:42:15 +0000 Subject: [Koha-bugs] [Bug 24336] Ask for confirmation before deleting a suggestion in the OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24336 Maryse Simard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #4 from Maryse Simard --- Sorry, I forgot to apply the dependency. Everything works well. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 3 23:10:57 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Jan 2020 22:10:57 +0000 Subject: [Koha-bugs] [Bug 20930] Validate and cache parsed YAML/JSON type system preferences In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20930 Michal Denar changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply --- Comment #22 from Michal Denar --- Ho Owen, can You rebase this patch on master? Applying: Bug 20930: Dump and load system preferences of YAML/JSON type Using index info to reconstruct a base tree... M C4/Context.pm M Koha/Config/SysPref.pm M Koha/Exceptions/Config.pm M t/db_dependent/Context.t Falling back to patching base and 3-way merge... No changes -- Patch already applied. Applying: Bug 20930: First example - Change OpacHiddenItems to type YAML Using index info to reconstruct a base tree... M C4/Biblio.pm M C4/Items.pm M installer/data/mysql/sysprefs.sql M opac/opac-search.pl M t/db_dependent/Items.t Falling back to patching base and 3-way merge... No changes -- Patch already applied. Applying: Bug 20930: Display human readable errors in preferences page Using index info to reconstruct a base tree... M koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences.tt M koha-tmpl/intranet-tmpl/prog/js/pages/preferences.js M svc/config/systempreferences Falling back to patching base and 3-way merge... Auto-merging koha-tmpl/intranet-tmpl/prog/js/pages/preferences.js CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/js/pages/preferences.js Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences.tt CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences.tt error: Failed to merge in the changes. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 3 23:13:17 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Jan 2020 22:13:17 +0000 Subject: [Koha-bugs] [Bug 24137] Marc21 bibliographic fails to install for ru-Ru and uk-UA In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24137 Joy Nelson changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable Version(s)|20.05.00 |20.05.00, 19.11.02 released in| | CC| |joy at bywatersolutions.com --- Comment #28 from Joy Nelson --- Pushed to 19.11.x for 19.11.02 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 3 23:24:48 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Jan 2020 22:24:48 +0000 Subject: [Koha-bugs] [Bug 24259] Circulation fails if no circ rule defined but checkout override confirmed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24259 Joy Nelson changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |joy at bywatersolutions.com Status|Pushed to master |Pushed to stable Version(s)|20.05.00 |20.05.00, 19.11.02 released in| | --- Comment #7 from Joy Nelson --- Pushed to 19.11.x for 19.11.02 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 3 23:30:24 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Jan 2020 22:30:24 +0000 Subject: [Koha-bugs] [Bug 23784] Show subtitle, number and parts in course reserves list of items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23784 ByWater Sandboxes changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #94971|0 |1 is obsolete| | --- Comment #2 from ByWater Sandboxes --- Created attachment 96810 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96810&action=edit Bug 23784: Show subtitle, number and part in course reserve list of records At the moment only the title will display in the course reserves details, but not the information from other title fields. For series with multiple volumes that can lead to confusing display. The patch makes use of the new include to display 245$abnp. To test: - Add mulitple records to a course reserce course Make sure you have some with different combinations of 245$b$n$p - Look at the course details in the OPAC - Verify only $a displays - Apply patch - Reload - Verify now the full information displays Depending on your installation, you might want ot check that the 245 are correctly mapped and save the record once so the database fields are correctly filled. Signed-off-by: Andrew Fuerste-Henry -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 3 23:31:53 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Jan 2020 22:31:53 +0000 Subject: [Koha-bugs] [Bug 23784] Show subtitle, number and parts in course reserves list of items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23784 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrew at bywatersolutions.com Status|Needs Signoff |Signed Off --- Comment #3 from Andrew Fuerste-Henry --- Katrin, this works and it good, so I'm signing it off. But can I interest you in widening it a bit to also include the staff side (course-details.pl)? I'd happily rush back to test and sign off again. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 3 23:33:20 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Jan 2020 22:33:20 +0000 Subject: [Koha-bugs] [Bug 24169] Advanced editor: icons/buttons for sorting the search results are missing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24169 Joy Nelson changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|20.05.00 |20.05.00, 19.11.02 released in| | Status|Pushed to master |Pushed to stable CC| |joy at bywatersolutions.com --- Comment #11 from Joy Nelson --- Pushed to 19.11.x branch for 19.11.02 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jan 3 23:38:12 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Jan 2020 22:38:12 +0000 Subject: [Koha-bugs] [Bug 24232] Deleting a bib record after attaching the last item to another bib In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24232 Joy Nelson changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |joy at bywatersolutions.com Status|Pushed to master |Pushed to stable Version(s)|20.05.00 |20.05.00, 19.11.02 released in| | --- Comment #20 from Joy Nelson --- Pushed to 19.11.x branch for 19.11.02 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jan 4 00:06:23 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 Jan 2020 23:06:23 +0000 Subject: [Koha-bugs] [Bug 17595] Add button for creating manual invoice (aka fine or fee) to patron toolbar In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17595 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Component|Circulation |Fines and fees CC| |katrin.fischer at bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jan 4 01:00:24 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 04 Jan 2020 00:00:24 +0000 Subject: [Koha-bugs] [Bug 19201] SPAM In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19201 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |INVALID CC| |katrin.fischer at bsz-bw.de Summary|Koha |SPAM -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jan 4 01:07:31 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 04 Jan 2020 00:07:31 +0000 Subject: [Koha-bugs] [Bug 24232] Deleting a bib record after attaching the last item to another bib In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24232 --- Comment #21 from Tomás Cohen Arazi --- We should rename the bug for something like 'Wrong permissions...' -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jan 4 01:58:38 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 04 Jan 2020 00:58:38 +0000 Subject: [Koha-bugs] [Bug 23784] Show subtitle, number and parts in course reserves list of items in OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23784 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Show subtitle, number and |Show subtitle, number and |parts in course reserves |parts in course reserves |list of items |list of items in OPAC --- Comment #4 from Katrin Fischer --- (In reply to Andrew Fuerste-Henry from comment #3) > Katrin, this works and it good, so I'm signing it off. But can I interest > you in widening it a bit to also include the staff side (course-details.pl)? > I'd happily rush back to test and sign off again. I am not sure when I would get to that - could we agree on a separate bug report to not hold this up? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jan 4 17:01:24 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 04 Jan 2020 16:01:24 +0000 Subject: [Koha-bugs] [Bug 20816] Add ability to send custom field(s) containing patron information in SIP patron responses In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20816 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #93493|0 |1 is obsolete| | --- Comment #5 from Nick Clemens --- Created attachment 96811 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96811&action=edit Bug 20816: Add ability to define custom templated fields in SIP patron responses To test: 1 - You will need to enable SIP on your testing instance cp etc/SIPconfig.xml /etc/koha/sites/kohadev/ sudo koha-start-sip add a user listed in the SIPconfig to your system and give them permissions (superlibrarian works) on koha-testing-docker you should be able to start sip with user koha/koha without any adjustments 2 - If you copied the above file you should be set to get custom field DE with dateexpiry Otherwise edit the sip login for the user to have a custom section like: 3 - send a status test using the sip cli tester: perl misc/sip_cli_emulator.pl -a 127.0.0.1 -p 6001 -su koha -sp koha -l kohalibrary --patron 23529001000463 -m patron_status_request 4 - send an information test using the sip cli tester: perl misc/sip_cli_emulator.pl -a 127.0.0.1 -p 6001 -su koha -sp koha -l kohalibrary --patron 23529001000463 -m patron_information 5 - confirm you receive the DE field with a dateexpiry 6 - Add your own custom fields and confirm it works with several 7 - prove -v t/db_dependent/SIP/Patron.t 8 - prove -v t/db_dependent/SIP/ -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jan 4 17:01:27 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 04 Jan 2020 16:01:27 +0000 Subject: [Koha-bugs] [Bug 20816] Add ability to send custom field(s) containing patron information in SIP patron responses In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20816 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #93494|0 |1 is obsolete| | --- Comment #6 from Nick Clemens --- Created attachment 96812 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96812&action=edit Bug 20816: Make SIP tests pass under ES -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jan 4 17:50:38 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 04 Jan 2020 16:50:38 +0000 Subject: [Koha-bugs] [Bug 20930] Validate and cache parsed YAML/JSON type system preferences In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20930 Michal Denar changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jan 4 18:27:07 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 04 Jan 2020 17:27:07 +0000 Subject: [Koha-bugs] [Bug 20930] Validate and cache parsed YAML/JSON type system preferences In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20930 --- Comment #23 from Michal Denar --- Im sorry, my fault. Patched twice. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jan 4 18:43:08 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 04 Jan 2020 17:43:08 +0000 Subject: [Koha-bugs] [Bug 24342] Self check needs on screen keyboard for login In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24342 --- Comment #1 from Owen Leonard --- Isn't this a hardware/OS issue? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Jan 4 19:15:51 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 04 Jan 2020 18:15:51 +0000 Subject: [Koha-bugs] [Bug 24342] Self check needs on screen keyboard for login In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24342 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #2 from Katrin Fischer --- I think I see the point for the web based self check system - it would spare you having to attach a keyboard to the computer used and just use a touch screen, possibly built into a station instead. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jan 4 19:57:23 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 04 Jan 2020 18:57:23 +0000 Subject: [Koha-bugs] [Bug 24340] We ought to be able to disable SIP using koha-sip In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24340 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Jan 4 19:57:26 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 04 Jan 2020 18:57:26 +0000 Subject: [Koha-bugs] [Bug 24340] We ought to be able to disable SIP using koha-sip In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24340 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #96797|0 |1 is obsolete| | --- Comment #3 from David Nind --- Created attachment 96813 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96813&action=edit Bug 24340: allow koha-sip --disable inst To test: - Enable sip for your testing instance sudo koha-sip --enable inst - Start sip for your testing instance sudo koha-sip --start inst - Verify it is running ps ax |grep sip -> you should see processes - Disable sip for your testing intance sudo koha-sip --disable inst - Verify that the following has happened: * the SIPconfig.xml file has been moved to SIPconfig.xml.bak * SIP is no longer running for your instance - no SIP processes * SIP Cannot be started for the instance because of no config. Signed-off-by: David Nind -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jan 4 20:01:06 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 04 Jan 2020 19:01:06 +0000 Subject: [Koha-bugs] [Bug 24340] We ought to be able to disable SIP using koha-sip In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24340 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david at davidnind.com --- Comment #4 from David Nind --- Hi Liz. I've signed this off, but I think the debian/docs/koha-sip.xml file needs updating so that the option is listed in the man page for the package command. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Jan 4 20:13:27 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 04 Jan 2020 19:13:27 +0000 Subject: [Koha-bugs] [Bug 24340] We ought to be able to disable SIP using koha-sip In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24340 --- Comment #5 from David Nind --- Notes for those testing using koha-testing-docker. After applying the patch the change to the script isn't recognised, and I get an error message when using the disable option: Error: invalid option switch (--disable) I had to restart the environment (CTRL-C, then kd, then ku to bring up a fresh instance) as restart_all and flush_memcached didn't seem to work to recognise the script change. koha-testing-docker has SIP enabled by default so before you test you may want to stop SIP (koha-sip --stop kohadev) and delete the /etc/koha/sites/kohadev/SIPconfig.xml file. Also, on koha-testing-docker the instance name is kohadev. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jan 4 20:45:33 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 04 Jan 2020 19:45:33 +0000 Subject: [Koha-bugs] [Bug 23568] Detect OPAC location by IP address In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23568 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard at myacpl.org |koha-bugs at lists.koha-commun | |ity.org -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jan 4 20:45:55 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 04 Jan 2020 19:45:55 +0000 Subject: [Koha-bugs] [Bug 23576] OPAC - Logged in elsewhere In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23576 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard at myacpl.org |koha-bugs at lists.koha-commun | |ity.org -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jan 4 21:00:10 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 04 Jan 2020 20:00:10 +0000 Subject: [Koha-bugs] [Bug 24211] Compress/uncompress translation files In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24211 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jan 4 21:00:14 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 04 Jan 2020 20:00:14 +0000 Subject: [Koha-bugs] [Bug 24211] Compress/uncompress translation files In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24211 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #96174|0 |1 is obsolete| | --- Comment #3 from David Nind --- Created attachment 96814 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96814&action=edit Bug 24211: Compress/uncompress translation files This patch adds the ability to compress/uncompress translations files. On update/install the files are uncompressed first The only gain is to use less space. To test: 1) Apply the patch 2) Go to misc/translator 3) Try it $ ./translate compress fr-FR (check po/*.gz) $ ./translate uncompress fr-FR ( check normal files) 4) Try again with verbose mode $ ./translate compress fr-FR -v (list compressed files) $ ./translate uncompress fr-FR -v (list uncompressed files) 5) Try update compressed files $ ./translate compress fr-FR $ ./translate update fr-FR (result is uncompressed) 6) Try install compressed files $ ./translate compress fr-FR $ ./translate install fr-FR 7) Try compress all $ ./translate compress (add '-v' for verbose output) 8) Try uncompress all $ ./translate uncompress (add '-v' for verbose output) Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jan 4 21:26:08 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 04 Jan 2020 20:26:08 +0000 Subject: [Koha-bugs] [Bug 23015] Create a "GetPickupLocation" endpoint for the ILS-DI Service In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23015 Arthur Suzuki changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #94039|0 |1 is obsolete| | --- Comment #10 from Arthur Suzuki --- Created attachment 96815 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96815&action=edit Bug 23015: Implements a new ILS-DI service to get available pickup libraries for an item or record test plan : 1 / Set a library A as available pickup location in the intranet 2 / query ILS-DI service with any record which has at least an item in A or an item which can be transfered to A => should send all informations about A 3 / Remove A from available pickup locations from the item in the intranet then repeat 2 => should give empty reply 4 / Try with unexisting patron, unexisting item or unexisting record, should throw an explicit error Signed-off-by: Christophe Croullebois -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jan 4 21:26:12 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 04 Jan 2020 20:26:12 +0000 Subject: [Koha-bugs] [Bug 23015] Create a "GetPickupLocation" endpoint for the ILS-DI Service In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23015 --- Comment #11 from Arthur Suzuki --- Created attachment 96816 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96816&action=edit Bug 23015: Adding tests for GetPickupLocation method -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jan 4 21:49:18 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 04 Jan 2020 20:49:18 +0000 Subject: [Koha-bugs] [Bug 20930] Validate and cache parsed YAML/JSON type system preferences In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20930 Michal Denar changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jan 4 21:49:22 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 04 Jan 2020 20:49:22 +0000 Subject: [Koha-bugs] [Bug 20930] Validate and cache parsed YAML/JSON type system preferences In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20930 Michal Denar changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #96108|0 |1 is obsolete| | Attachment #96109|0 |1 is obsolete| | Attachment #96110|0 |1 is obsolete| | Attachment #96111|0 |1 is obsolete| | Attachment #96112|0 |1 is obsolete| | --- Comment #24 from Michal Denar --- Created attachment 96817 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96817&action=edit Bug 20930: Dump and load system preferences of YAML/JSON type Currently, C4::Context->preference('YAMLpref') returns a string that needs to be parsed by any code using the preference. My suggestion is to return a parsed version instead (a hash/array ref or a string) and using the syspref cache with the parsed value. Like this, we could: - centralize parsing of YAML system preferences - optimize use of system preference cache by caching the parsed version instead. Parse once and store in cache; no need to re-parse on each call! We can centralize this functionality into Koha::Config::SysPref->value() (used by C4::Context->preference). Use database column systempreferences.type with value of "YAML" to trigger this functionality in "value()"-method. To test: 1. Make sure memcached is available 2. Run tests with caching enabled, e.g.: MEMCACHED_SERVERS=localhost:11211 prove t/db_dependent/Context.t 3. Make sure all tests pass and none were skipped Signed-off-by: Owen Leonard Signed-off-by: Michal Denar -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jan 4 21:49:26 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 04 Jan 2020 20:49:26 +0000 Subject: [Koha-bugs] [Bug 20930] Validate and cache parsed YAML/JSON type system preferences In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20930 --- Comment #25 from Michal Denar --- Created attachment 96818 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96818&action=edit Bug 20930: First example - Change OpacHiddenItems to type YAML To test: 1. prove t/db_dependent/Items.t 2. Check that desired items are still hidden in OPAC by using OpacHiddenItems as documented here: https://wiki.koha-community.org/wiki/OpacHiddenItems Signed-off-by: Owen Leonard Signed-off-by: Michal Denar -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jan 4 21:49:29 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 04 Jan 2020 20:49:29 +0000 Subject: [Koha-bugs] [Bug 20930] Validate and cache parsed YAML/JSON type system preferences In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20930 --- Comment #26 from Michal Denar --- Created attachment 96819 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96819&action=edit Bug 20930: Display human readable errors in preferences page Displays human readable error when YAML/JSON preference has invalid syntax. If multiple preferences are modified at the same time, notifies librarian of the preferences that were saved and the ones that had errors. To test: 1. Apply patches 2. Write invalid YAML syntax to OpacHiddenItems system preference 3. Observe "Error; Preference OpacHiddenItems has invalid syntax" error You should also receive a hint on line and column numbers of where the error occured. 4. Write valid YAML syntax to OpacHiddenItems system preference 5. Observe "Saved preference OpacHiddenItems" message 6. Test steps 2-5 for both single preference modification and together with other system preferences. Signed-off-by: Owen Leonard Signed-off-by: Michal Denar -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jan 4 21:49:33 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 04 Jan 2020 20:49:33 +0000 Subject: [Koha-bugs] [Bug 20930] Validate and cache parsed YAML/JSON type system preferences In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20930 --- Comment #27 from Michal Denar --- Created attachment 96820 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96820&action=edit Bug 20930: Make line and column number alert translatable To test: 1. Apply patch 2. Store invalid YAML syntax into OpacHiddenItems preference 3. Observe error 4. You should also see line and column number of where the error occured Signed-off-by: Owen Leonard Signed-off-by: Michal Denar -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jan 4 21:49:36 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 04 Jan 2020 20:49:36 +0000 Subject: [Koha-bugs] [Bug 20930] Validate and cache parsed YAML/JSON type system preferences In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20930 --- Comment #28 from Michal Denar --- Created attachment 96821 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96821&action=edit Bug 20930: (follow-up) Improve formatting of error message This patch makes a few changes to system preferences JavaScript so that the error message for invalid YAML is output on one line. CSS has been modified to improve the readability of multiple error messages. The order of CSS files loaded by preferences.tt has been changed to ensure that CSS in preferences.css overrides plugin-related CSS. Unrelated: An incorrect ";" has been replaced with ":" in preferences.tt. To test, apply the patch and repeat the previous test plan. Confirm that the error messages appear as expected. Signed-off-by: Michal Denar -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jan 4 21:52:37 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 04 Jan 2020 20:52:37 +0000 Subject: [Koha-bugs] [Bug 5695] Cart display should show proper item type In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5695 --- Comment #2 from Owen Leonard --- Created attachment 96822 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96822&action=edit Screenshot of an idea Is this something people would want? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jan 4 22:52:21 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 04 Jan 2020 21:52:21 +0000 Subject: [Koha-bugs] [Bug 23784] Show subtitle, number and parts in course reserves list of items in OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23784 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=24343 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jan 4 22:52:21 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 04 Jan 2020 21:52:21 +0000 Subject: [Koha-bugs] [Bug 24343] New: Show subtitle, number and parts in course reserves list of titles in staff client Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24343 Bug ID: 24343 Summary: Show subtitle, number and parts in course reserves list of titles in staff client Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Course reserves Assignee: koha-bugs at lists.koha-community.org Reporter: oleonard at myacpl.org QA Contact: testopia at bugs.koha-community.org CC: andrew at bywatersolutions.com, katrin.fischer at bsz-bw.de, testopia at bugs.koha-community.org It would be nice if the subtitle and number/part information (MARC21: 245$b$n$p) showed in the course reserves list of records. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Jan 4 22:58:49 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 04 Jan 2020 21:58:49 +0000 Subject: [Koha-bugs] [Bug 24343] Show subtitle, number and parts in course reserves list of titles in staff client In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24343 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Jan 4 22:58:52 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 04 Jan 2020 21:58:52 +0000 Subject: [Koha-bugs] [Bug 24343] Show subtitle, number and parts in course reserves list of titles in staff client In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24343 --- Comment #1 from Owen Leonard --- Created attachment 96823 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96823&action=edit Bug 24343: Show subtitle, number and parts in course reserves list of titles in staff client Adapted from Bug 23784: At the moment only the title will display in the course reserves details, but not the information from other title fields. For series with multiple volumes that can lead to confusing display. The patch makes use of the new include to display 245$abnp. To test: - Add mulitple records to a course reserve course Make sure you have titles with different combinations of 245$b$n$p - Look at the course details in the staff client - Verify only $a displays - Apply patch - Reload - Verify now the full information displays Depending on your installation, you might want ot check that the 245 are correctly mapped and save the record once so the database fields are correctly filled. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Jan 4 23:00:07 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 04 Jan 2020 22:00:07 +0000 Subject: [Koha-bugs] [Bug 23784] Show subtitle, number and parts in course reserves list of items in OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23784 --- Comment #5 from Owen Leonard --- Bug 24343 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 5 00:11:22 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 04 Jan 2020 23:11:22 +0000 Subject: [Koha-bugs] [Bug 24344] New: Add the ability to suggest purchase from existing titles Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24344 Bug ID: 24344 Summary: Add the ability to suggest purchase from existing titles Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: oleonard at myacpl.org QA Contact: testopia at bugs.koha-community.org CC: testopia at bugs.koha-community.org Depends on: 14963 +++ This bug was initially created as a clone of Bug #14963 +++ Katrin Fischer suggested: > What do you think of using a little 'present' icon instead of the money > (bill) icon? > > Also we could slightly rephrase it to make it shorter: > > Currently: > New purchase suggestion for this title > > Suggestion: > Suggest for purchase Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14963 [Bug 14963] Add the ability to suggest purchase from existing titles -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 5 00:11:22 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 04 Jan 2020 23:11:22 +0000 Subject: [Koha-bugs] [Bug 14963] Add the ability to suggest purchase from existing titles In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14963 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |24344 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24344 [Bug 24344] Add the ability to suggest purchase from existing titles -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 5 00:12:59 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 04 Jan 2020 23:12:59 +0000 Subject: [Koha-bugs] [Bug 24344] Modify OPAC link to suggest existing record for purchase In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24344 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Add the ability to suggest |Modify OPAC link to suggest |purchase from existing |existing record for |titles |purchase -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 5 00:15:09 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 04 Jan 2020 23:15:09 +0000 Subject: [Koha-bugs] [Bug 24344] Modify OPAC link to suggest existing record for purchase In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24344 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 5 00:15:12 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 04 Jan 2020 23:15:12 +0000 Subject: [Koha-bugs] [Bug 24344] Modify OPAC link to suggest existing record for purchase In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24344 --- Comment #1 from Owen Leonard --- Created attachment 96824 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96824&action=edit Bug 24344: Modify OPAC link to suggest existing record for purchase This patch modifies the link to suggest purchase of an existing record from the OPAC. The icon is changed to "gift" and the text shortened to "Suggest for purchase." To test, apply the patch and view the detail page of any record in the OPAC. Confirm that the modifications look good. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 5 00:16:05 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 04 Jan 2020 23:16:05 +0000 Subject: [Koha-bugs] [Bug 14963] Add the ability to suggest purchase from existing titles In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14963 --- Comment #29 from Owen Leonard --- Bug 24344 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 5 00:24:42 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 04 Jan 2020 23:24:42 +0000 Subject: [Koha-bugs] [Bug 24345] New: Fix process of suggesting purchase of existing title for non-logged-in users Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24345 Bug ID: 24345 Summary: Fix process of suggesting purchase of existing title for non-logged-in users Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: OPAC Assignee: koha-bugs at lists.koha-community.org Reporter: oleonard at myacpl.org QA Contact: testopia at bugs.koha-community.org CC: testopia at bugs.koha-community.org Depends on: 14963 If AnonSuggestions is disabled and a non-logged-in user tries to suggest purchase of an existing title the suggestion form isn't correctly populated with the title information. To reproduce: - View a title in the OPAC as a non-logged-in user - Click the link to suggest purchase of an additional copy - Log in - Instead of a pre-populated suggestion form you'll see either your list of existing suggestions (if any) or nothing. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14963 [Bug 14963] Add the ability to suggest purchase from existing titles -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Jan 5 00:24:42 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 04 Jan 2020 23:24:42 +0000 Subject: [Koha-bugs] [Bug 14963] Add the ability to suggest purchase from existing titles In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14963 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |24345 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24345 [Bug 24345] Fix process of suggesting purchase of existing title for non-logged-in users -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 5 00:27:08 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 04 Jan 2020 23:27:08 +0000 Subject: [Koha-bugs] [Bug 23569] OMNIBUS: OPAC security measures In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23569 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Security for patrons |OMNIBUS: OPAC security | |measures Assignee|oleonard at myacpl.org |koha-bugs at lists.koha-commun | |ity.org Version|unspecified |master -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 5 02:38:04 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 05 Jan 2020 01:38:04 +0000 Subject: [Koha-bugs] [Bug 24346] New: News needs to be able to display on the self checkout / checkin modules Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24346 Bug ID: 24346 Summary: News needs to be able to display on the self checkout / checkin modules Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Tools Assignee: koha-bugs at lists.koha-community.org Reporter: cbrannon at cdalibrary.org QA Contact: testopia at bugs.koha-community.org It would be great if there were a side panel on the login screen for news. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Jan 5 11:15:50 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 05 Jan 2020 10:15:50 +0000 Subject: [Koha-bugs] [Bug 10498] Place a hold at time of ordering In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10498 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Place Hold on Order |Place a hold at time of | |ordering -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 5 11:17:27 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 05 Jan 2020 10:17:27 +0000 Subject: [Koha-bugs] [Bug 10517] koha-restore fails to create mysqluser@mysql_hostname so zebra update fails In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10517 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|kohe-restore fails to |koha-restore fails to |create |create |mysqluser at mysql_hostname so |mysqluser at mysql_hostname so |zebra update fails |zebra update fails Keywords| |Academy --- Comment #7 from Katrin Fischer --- Formatting this as a patch might be a good 'rescue' task :) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Jan 5 11:20:41 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 05 Jan 2020 10:20:41 +0000 Subject: [Koha-bugs] [Bug 10518] Add sorting for Cyrillic characters In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10518 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Relevance option for |Add sorting for Cyrillic |non-Latin scripts |characters Component|Searching |Searching - Zebra --- Comment #3 from Katrin Fischer --- Problem here is not relevance but alphabetic sorting, changing the bug title to reflect this. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 5 11:21:54 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 05 Jan 2020 10:21:54 +0000 Subject: [Koha-bugs] [Bug 10561] DisplayOPACiconsXSLT description should be clearer In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10561 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|DisplayOPACiconsXSLT |DisplayOPACiconsXSLT |shouldn't control more than |description should be |icon display |clearer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 5 11:24:46 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 05 Jan 2020 10:24:46 +0000 Subject: [Koha-bugs] [Bug 10655] Include list of holds on circ slip or offer separate printing option In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10655 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Component|Circulation |Notices -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 5 11:25:47 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 05 Jan 2020 10:25:47 +0000 Subject: [Koha-bugs] [Bug 10707] Inventory not removing lost status In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10707 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Summary|inventory not removing lost |Inventory not removing lost |status |status Resolution|--- |WORKSFORME --- Comment #6 from Katrin Fischer --- See comment#4 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 5 11:29:03 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 05 Jan 2020 10:29:03 +0000 Subject: [Koha-bugs] [Bug 10758] Show bibliographic information of deleted records in acquisitions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10758 --- Comment #66 from Katrin Fischer --- I'd really love to see progress here, it's a big issue in the acquisition module as we display the cancelled orders so prominently. I get asked to manually delete them on a regular basis by one our libraries as you can't see what was cancelled. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 5 11:32:33 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 05 Jan 2020 10:32:33 +0000 Subject: [Koha-bugs] [Bug 10816] Relational operators in Search In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10816 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |Manual CC| |katrin.fischer at bsz-bw.de --- Comment #3 from Katrin Fischer --- It sounds like this is something for the Manual - marking as such. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 5 11:34:13 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 05 Jan 2020 10:34:13 +0000 Subject: [Koha-bugs] [Bug 10822] Matcher should use SimpleSearch for auths In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10822 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|jcamins at cpbibliography.com |koha-bugs at lists.koha-commun | |ity.org CC| |katrin.fischer at bsz-bw.de -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 5 11:39:19 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 05 Jan 2020 10:39:19 +0000 Subject: [Koha-bugs] [Bug 11025] Display UNIMARC fields having $5 subfield with related items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11025 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Component|OPAC |MARC Bibliographic data | |support CC| |katrin.fischer at bsz-bw.de -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 5 11:40:07 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 05 Jan 2020 10:40:07 +0000 Subject: [Koha-bugs] [Bug 11028] Add new filters in lateorders.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11028 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Summary|add new filters in |Add new filters in |lateorders.pl |lateorders.pl -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Jan 5 11:43:29 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 05 Jan 2020 10:43:29 +0000 Subject: [Koha-bugs] [Bug 11036] Track logins to the OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11036 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |22794 CC| |katrin.fischer at bsz-bw.de Summary|track log ins to the OPAC |Track logins to the OPAC --- Comment #1 from Katrin Fischer --- The number of logins to the OPAC was discussed here for the national library statistics (DBS), so so being able to retrieve this information would be nice. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22794 [Bug 22794] Omnibus: Improve and extend logging in Koha -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 5 11:43:29 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 05 Jan 2020 10:43:29 +0000 Subject: [Koha-bugs] [Bug 22794] Omnibus: Improve and extend logging in Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22794 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |11036 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11036 [Bug 11036] Track logins to the OPAC -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Jan 5 11:49:46 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 05 Jan 2020 10:49:46 +0000 Subject: [Koha-bugs] [Bug 11043] rename biblioitems.itemtype In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11043 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |WONTFIX Status|NEW |RESOLVED --- Comment #8 from Katrin Fischer --- Discussion here boiled down to the fact, that UNIMARC users have not mapped biblioitems.itemtype to the itemtypes authorised value. I believe this needs a different fix than suggested and is much more complex. We rely on items.itype and bilbioitems.itemtype to be the same list of itemtypes in more and more spots. Some I know of: - Suggesting the itemtype for the item when cataloguing - Search: In MARC21 both are indexed as itemtype, allowing to easily search for records without items too (only MARC21?) - Article requests on records without items - Hold limit checking If UNIMARC uses the field differently, there is a bigger discussion to be had on how to handle this to give both MARC formats the same behaviour in circ etc. I believe if necessary document type should be a separate thing. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 5 11:54:51 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 05 Jan 2020 10:54:51 +0000 Subject: [Koha-bugs] [Bug 11052] Missing field in french unimarc authorities framework In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11052 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |18309 CC| |katrin.fischer at bsz-bw.de --- Comment #1 from Katrin Fischer --- It looks like bug 18309 hasn't added 103 - maybe because it's SUDOC specific? Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18309 [Bug 18309] UNIMARC update from IFLA for new Koha installations -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 5 11:54:51 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 05 Jan 2020 10:54:51 +0000 Subject: [Koha-bugs] [Bug 18309] UNIMARC update from IFLA for new Koha installations In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18309 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |11052 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11052 [Bug 11052] Missing field in french unimarc authorities framework -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 5 11:55:26 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 05 Jan 2020 10:55:26 +0000 Subject: [Koha-bugs] [Bug 11052] Missing field 103 in French UNIMARC authorities framework In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11052 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Component|Cataloging |MARC Bibliographic data | |support Summary|Missing field in french |Missing field 103 in French |unimarc authorities |UNIMARC authorities |framework |framework -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 5 11:57:45 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 05 Jan 2020 10:57:45 +0000 Subject: [Koha-bugs] [Bug 11062] Invoice's shipment/shipping cost should be included PRE-gst tax (as an option) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11062 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #10 from Katrin Fischer --- Could this be revived now that bug 13323 has been closed? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Jan 5 12:00:23 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 05 Jan 2020 11:00:23 +0000 Subject: [Koha-bugs] [Bug 11082] Warn user when trying to delete an item linked with an order In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11082 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Summary|Warn user when trying to |Warn user when trying to |suppress an item linked |delete an item linked with |with an order |an order -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 5 12:02:53 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 05 Jan 2020 11:02:53 +0000 Subject: [Koha-bugs] [Bug 20424] New UNIMARC ZEBRA indexes according to last IFLA updates In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20424 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=11118 CC| |katrin.fischer at bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 5 12:02:53 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 05 Jan 2020 11:02:53 +0000 Subject: [Koha-bugs] [Bug 11118] Fixing UNIMARC indexing of 072, 207, 208, 230, 464 fields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11118 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=20424 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 5 12:08:53 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 05 Jan 2020 11:08:53 +0000 Subject: [Koha-bugs] [Bug 24347] New: Add a 'search to order' option similar to 'search to hold' Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24347 Bug ID: 24347 Summary: Add a 'search to order' option similar to 'search to hold' Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: new feature Priority: P5 - low Component: Acquisitions Assignee: koha-bugs at lists.koha-community.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org On bug 11149 it was noted that the search options when reordering an existing record are limited. Instead of relying on ccl queries or rebuilding search features in the acq module, it could be nice to have a "search to order" feature. This could work similar to the "search to hold" functionality. Only you would not start from a patron record, but from your basket. Searching in the catalog you would see an "Add to order" link that would redirect you to the order page of your basket with the record already linked to the order. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Jan 5 12:10:09 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 05 Jan 2020 11:10:09 +0000 Subject: [Koha-bugs] [Bug 11149] From an existing record: change default to key on exact words instead of any words. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11149 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Status|NEW |RESOLVED Resolution|--- |WONTFIX --- Comment #1 from Katrin Fischer --- I think we can't change this in genearal, but it's possible to use ccl queries in this field, so you could type: ti,phr:search terms This will achieve what was asked for here. Maybe another idea for bigger catalogs would be to have something like an 'advanced search' option. Or an "search to order" feature that would give us all the search capabilities of the normal catalog search - I filed bug 24347 for this idea. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 5 12:12:50 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 05 Jan 2020 11:12:50 +0000 Subject: [Koha-bugs] [Bug 11154] Collapsable results - simple view of search results In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11154 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Summary|collapsable results |Collapsable results - | |simple view of search | |results -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 5 12:18:51 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 05 Jan 2020 11:18:51 +0000 Subject: [Koha-bugs] [Bug 11187] notices showing the --- if only one title In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11187 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |WONTFIX Status|NEW |RESOLVED --- Comment #2 from Katrin Fischer --- I believe this is an issue with the email program, that interprets the --- in a certain way. I haven't seen this behavior in other programs like Outlook. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 5 12:22:13 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 05 Jan 2020 11:22:13 +0000 Subject: [Koha-bugs] [Bug 11195] Rename biblioitems.publishercode into publisher In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11195 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|rename |Rename |biblioitems.publishercode |biblioitems.publishercode |into publisher |into publisher --- Comment #2 from Katrin Fischer --- (In reply to Katrin Fischer from comment #1) > Changing a database column name like this one is not without risk as it's > used in a lot of Koha's code. I wonder if we should resolve this WONTFIX for > now. Also used in reports... this can be fixed, but wonder if it's worth the trouble? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 5 12:24:21 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 05 Jan 2020 11:24:21 +0000 Subject: [Koha-bugs] [Bug 11197] Allow holds to be automatically confirmed, when no transfer is needed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11197 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Resolution|--- |FIXED Status|NEW |RESOLVED --- Comment #1 from Katrin Fischer --- I think the new pref HoldsAutoFill might resolve this. Please reopen if I missed something! -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Jan 5 12:27:40 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 05 Jan 2020 11:27:40 +0000 Subject: [Koha-bugs] [Bug 11234] Is returning biblioitems.marc field in C4::Biblio subs really necessary? In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11234 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |INVALID CC| |katrin.fischer at bsz-bw.de Status|NEW |RESOLVED --- Comment #1 from Katrin Fischer --- I believe this is no longer valid with the introduction of the biblio_metadata table. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 5 12:30:12 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 05 Jan 2020 11:30:12 +0000 Subject: [Koha-bugs] [Bug 11257] Document <> for duedgst and preduedgst and update sample notices In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11257 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |Academy Summary|Document <> |Document <> |for duedgst and preduedgst |for duedgst and preduedgst | |and update sample notices --- Comment #3 from Katrin Fischer --- Current sample notice for (PRE)DUEDGST just reads: You have <> items due Certainly room for improvement there! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 5 12:34:18 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 05 Jan 2020 11:34:18 +0000 Subject: [Koha-bugs] [Bug 11285] Vocabulary disambiguation In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11285 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |Academy --- Comment #30 from Katrin Fischer --- This could be a nice playground for someone playing with the new contextualisation features. For an example see: Bug 23983 - Contextualization of "Order" (verb) vs "Order" (noun) I'd suggest moving each case into a separate depending bug report. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 5 12:36:32 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 05 Jan 2020 11:36:32 +0000 Subject: [Koha-bugs] [Bug 11335] Show thumbnails of patrons on patron search results In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11335 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|show thumbnails of patrons |Show thumbnails of patrons |on patron search results |on patron search results CC| |katrin.fischer at bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Jan 5 12:39:08 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 05 Jan 2020 11:39:08 +0000 Subject: [Koha-bugs] [Bug 11344] Perldoc issues in misc/cronjobs/advance_notices.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11344 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |Academy CC| |katrin.fischer at bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 5 12:44:55 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 05 Jan 2020 11:44:55 +0000 Subject: [Koha-bugs] [Bug 11426] Make HighlightOwnItemsOnOPAC work with XSLT In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11426 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #8 from Katrin Fischer --- Should this be 'Needs signoff'? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 5 12:48:44 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 05 Jan 2020 11:48:44 +0000 Subject: [Koha-bugs] [Bug 11442] Show dashes (--) between Subject (Marc 6XX) subfields in authority cataloging plugin In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11442 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|REOPENED |NEW CC| |katrin.fischer at bsz-bw.de Summary|Show dashes (--) between |Show dashes (--) between |Subject (Marc 6XX) |Subject (Marc 6XX) |subfields |subfields in authority | |cataloging plugin --- Comment #6 from Katrin Fischer --- Still valid. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 5 12:52:01 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 05 Jan 2020 11:52:01 +0000 Subject: [Koha-bugs] [Bug 11446] Authority not searching full corporate name with and (&) symbol In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11446 --- Comment #4 from Katrin Fischer --- Still valid. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 5 12:53:42 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 05 Jan 2020 11:53:42 +0000 Subject: [Koha-bugs] [Bug 11454] Cannot indicate time for hard due dates on circulation rules In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11454 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Summary|Cannot indicate time on |Cannot indicate time for |Circulation Rules |hard due dates on | |circulation rules -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Jan 5 12:54:52 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 05 Jan 2020 11:54:52 +0000 Subject: [Koha-bugs] [Bug 11455] Ask for confirmation when replacing an existing circulation rule In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11455 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Rule Replacement |Ask for confirmation when |Confirmation |replacing an existing | |circulation rule CC| |katrin.fischer at bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Jan 5 12:56:59 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 05 Jan 2020 11:56:59 +0000 Subject: [Koha-bugs] [Bug 11460] Correction to default itemcallnumber system preference in UNIMARC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11460 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |Academy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 5 13:00:56 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 05 Jan 2020 12:00:56 +0000 Subject: [Koha-bugs] [Bug 11494] Pay patron fines shows cryptic, untranslatable, account types In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11494 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Status|NEW |RESOLVED Resolution|--- |FIXED --- Comment #1 from Katrin Fischer --- Just tested on master - it looks like this has been resolved with the accouting work. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Jan 5 13:01:45 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 05 Jan 2020 12:01:45 +0000 Subject: [Koha-bugs] [Bug 11496] The number of tested records when searching for duplicates during import is too low In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11496 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #7 from Katrin Fischer --- Should this be 'Needs signoff'? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 5 13:03:53 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 05 Jan 2020 12:03:53 +0000 Subject: [Koha-bugs] [Bug 11511] Keep stats on opac logins In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11511 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Status|NEW |RESOLVED Resolution|--- |DUPLICATE --- Comment #1 from Katrin Fischer --- *** This bug has been marked as a duplicate of bug 11036 *** -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 5 13:03:53 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 05 Jan 2020 12:03:53 +0000 Subject: [Koha-bugs] [Bug 11036] Track logins to the OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11036 --- Comment #2 from Katrin Fischer --- *** Bug 11511 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 5 13:07:13 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 05 Jan 2020 12:07:13 +0000 Subject: [Koha-bugs] [Bug 11780] Need to prevent specific fields from being overwritten with z39.50 import In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11780 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |DUPLICATE Status|NEW |RESOLVED --- Comment #3 from Katrin Fischer --- *** This bug has been marked as a duplicate of bug 14957 *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 5 13:07:13 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 05 Jan 2020 12:07:13 +0000 Subject: [Koha-bugs] [Bug 14957] Write protecting MARC fields based on source of import In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |Jeremy.evans at nibsc.org --- Comment #186 from Katrin Fischer --- *** Bug 11780 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 5 13:07:56 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 05 Jan 2020 12:07:56 +0000 Subject: [Koha-bugs] [Bug 11519] Keep local MARC tags during data import In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11519 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |DUPLICATE Status|NEW |RESOLVED --- Comment #3 from Katrin Fischer --- *** This bug has been marked as a duplicate of bug 14957 *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 5 13:07:56 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 05 Jan 2020 12:07:56 +0000 Subject: [Koha-bugs] [Bug 14957] Write protecting MARC fields based on source of import In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |iming at rosewoodfarm.com.au --- Comment #187 from Katrin Fischer --- *** Bug 11519 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 5 13:10:36 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 05 Jan 2020 12:10:36 +0000 Subject: [Koha-bugs] [Bug 11520] Invoice isn't really an invoice In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11520 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |FIXED --- Comment #5 from Katrin Fischer --- As per comment#4 Also: there are now separte fields for RRP and replacement cost. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 5 13:19:17 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 05 Jan 2020 12:19:17 +0000 Subject: [Koha-bugs] [Bug 11581] HTTP 404s generated badly in some cases In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11581 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Blocks| |10581 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10581 [Bug 10581] Authority search: no results should not display as 404 error page -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 5 13:19:17 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 05 Jan 2020 12:19:17 +0000 Subject: [Koha-bugs] [Bug 10581] Authority search: no results should not display as 404 error page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10581 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |11581 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11581 [Bug 11581] HTTP 404s generated badly in some cases -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 5 13:20:27 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 05 Jan 2020 12:20:27 +0000 Subject: [Koha-bugs] [Bug 11582] Have same display/hidden options for authority subfields like bibliographic subfields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11582 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Have possibility to display |Have same display/hidden |authority subfield like |options for authority |bibliographic subfield |subfields like | |bibliographic subfields -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 5 13:24:04 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 05 Jan 2020 12:24:04 +0000 Subject: [Koha-bugs] [Bug 11583] Add WYSIWYG editor for HTML notices/letters In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11583 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Summary|Add wysiwyg editor for HTML |Add WYSIWYG editor for HTML |notices/letters |notices/letters --- Comment #1 from Katrin Fischer --- I wonder if this is still doable with the new TT syntax vs the more simple placeholders we had before. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 5 13:26:32 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 05 Jan 2020 12:26:32 +0000 Subject: [Koha-bugs] [Bug 11594] Store both item leven and record level itemtype in statistics In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11594 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|store both item type and |Store both item leven and |document type in statistics |record level itemtype in | |statistics CC| |katrin.fischer at bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Jan 5 13:28:38 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 05 Jan 2020 12:28:38 +0000 Subject: [Koha-bugs] [Bug 11581] HTTP 404s generated badly in some cases In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11581 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=11612 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 5 13:28:38 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 05 Jan 2020 12:28:38 +0000 Subject: [Koha-bugs] [Bug 11612] 404 error page for Intranet may leak information In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11612 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=11581 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 5 13:31:10 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 05 Jan 2020 12:31:10 +0000 Subject: [Koha-bugs] [Bug 11641] ILS-DI: Some more work for HoldTitle and HoldItem In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11641 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Depends on| |23531, 11999 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11999 [Bug 11999] Add two checks in CanBookBeReserved and CanItemBeReserved https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23531 [Bug 23531] ILS-DI doesn't implement needed_before_date and pickup_expiry_date parameters -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Jan 5 13:31:10 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 05 Jan 2020 12:31:10 +0000 Subject: [Koha-bugs] [Bug 11999] Add two checks in CanBookBeReserved and CanItemBeReserved In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11999 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |11641 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11641 [Bug 11641] ILS-DI: Some more work for HoldTitle and HoldItem -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 5 13:31:10 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 05 Jan 2020 12:31:10 +0000 Subject: [Koha-bugs] [Bug 23531] ILS-DI doesn't implement needed_before_date and pickup_expiry_date parameters In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23531 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |11641 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11641 [Bug 11641] ILS-DI: Some more work for HoldTitle and HoldItem -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 5 13:35:28 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 05 Jan 2020 12:35:28 +0000 Subject: [Koha-bugs] [Bug 11690] topissues should ignore suppressed titles/items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11690 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal CC| |katrin.fischer at bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 5 13:36:30 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 05 Jan 2020 12:36:30 +0000 Subject: [Koha-bugs] [Bug 11691] provide exports of the stock MARC templates on the website In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11691 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Product|Koha |Project Infrastructure CC| |katrin.fischer at bsz-bw.de QA Contact|testopia at bugs.koha-communit | |y.org | Version|master |unspecified Component|Websites, Mailing Lists, |Project website |etc | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 5 13:39:14 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 05 Jan 2020 12:39:14 +0000 Subject: [Koha-bugs] [Bug 11727] Offline synch should list number of pages to go In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11727 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #1 from Katrin Fischer --- Hi paxed, which offline sync are you referring to? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Jan 5 13:51:02 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 05 Jan 2020 12:51:02 +0000 Subject: [Koha-bugs] [Bug 11887] Add script for collections agency reports In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11887 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Status|ASSIGNED |Needs Signoff --- Comment #10 from Katrin Fischer --- (In reply to Lisette Scheer from comment #9) > (In reply to Owen Leonard from comment #8) > > Should this be 'Needs signoff?' > > I agree with Owen, it looks like this should be "Needs Signoff" instead of > assigned. Nick? Just switching it... amazingly it still applies. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 5 13:51:28 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 05 Jan 2020 12:51:28 +0000 Subject: [Koha-bugs] [Bug 11887] Add script for collections agency reports In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11887 --- Comment #11 from Katrin Fischer --- (In reply to Katrin Fischer from comment #10) > (In reply to Lisette Scheer from comment #9) > > (In reply to Owen Leonard from comment #8) > > > Should this be 'Needs signoff?' > > > > I agree with Owen, it looks like this should be "Needs Signoff" instead of > > assigned. Nick? > > Just switching it... amazingly it still applies. Maybe not so amazing for a new script... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 5 13:53:04 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 05 Jan 2020 12:53:04 +0000 Subject: [Koha-bugs] [Bug 11892] Add controls on overdue notices configuration In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11892 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Resolution|--- |DUPLICATE Status|NEW |RESOLVED --- Comment #1 from Katrin Fischer --- *** This bug has been marked as a duplicate of bug 11318 *** -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Jan 5 13:53:04 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 05 Jan 2020 12:53:04 +0000 Subject: [Koha-bugs] [Bug 11318] Overdues won't send if first trigger lacks a delay value In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11318 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m --- Comment #2 from Katrin Fischer --- *** Bug 11892 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 5 13:54:43 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 05 Jan 2020 12:54:43 +0000 Subject: [Koha-bugs] [Bug 11895] Keep stats on course reserves In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11895 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |22794 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22794 [Bug 22794] Omnibus: Improve and extend logging in Koha -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 5 13:54:43 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 05 Jan 2020 12:54:43 +0000 Subject: [Koha-bugs] [Bug 22794] Omnibus: Improve and extend logging in Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22794 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |11895 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11895 [Bug 11895] Keep stats on course reserves -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 5 13:56:50 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 05 Jan 2020 12:56:50 +0000 Subject: [Koha-bugs] [Bug 11903] Different quick searches for different item editors In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11903 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #1 from Katrin Fischer --- I believe this is because one is using the cataloging module default and the other is using the tools default. I am not sure if there is a great solution here - it makes sense for me to have the cataloging search above the items form. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 5 14:00:34 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 05 Jan 2020 13:00:34 +0000 Subject: [Koha-bugs] [Bug 24348] New: Record matching rules: required match checks does not work Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24348 Bug ID: 24348 Summary: Record matching rules: required match checks does not work Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: MARC Bibliographic record staging/import Assignee: koha-bugs at lists.koha-community.org Reporter: andreas.jonsson at kreablo.se QA Contact: testopia at bugs.koha-community.org The required match checks where broken by commit 53545ba739e1706da7f3e52c145f0f6c8bbfb18c of Bug 22046. _passes_required_checks takes the marc record data as parameter, but the refactoring done in bug 22046 results in the record id beeing passed instead. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Jan 5 14:00:34 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 05 Jan 2020 13:00:34 +0000 Subject: [Koha-bugs] [Bug 22046] Simplify C4::Matcher->get_matches In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22046 Andreas Jonsson changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=24348 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 5 14:00:58 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 05 Jan 2020 13:00:58 +0000 Subject: [Koha-bugs] [Bug 11952] utility scripts hard-coded to expect apache, breaks when koha is installed under nginx In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11952 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #1 from Katrin Fischer --- I am not sure if this is a bug, unless we decide to officially support Nginx (nto sure what the status there is) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 5 14:04:46 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 05 Jan 2020 13:04:46 +0000 Subject: [Koha-bugs] [Bug 24348] Record matching rules: required match checks does not work In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24348 --- Comment #1 from Andreas Jonsson --- Created attachment 96825 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96825&action=edit Bug 24348: Pass marc record to _passes_required_checks -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Jan 5 14:06:42 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 05 Jan 2020 13:06:42 +0000 Subject: [Koha-bugs] [Bug 24348] Record matching rules: required match checks does not work In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24348 --- Comment #2 from Andreas Jonsson --- Test plan: * Add record matching rule: Matching rule code: test Description: 001 and 003 Match threshold: 1000 Record type: Bibliografic record Match points: Search index: Control-number Score: 1000 Tag: 001 Subfields: Offset: Length: Normalization rule: none Required match checks: Source (incoming) record check field Tag: 003 Subfields: Offset: Length: Normalization rule: none Target (database) record check field Tag: 003 Subfields: Offset: Length: Normalization rule: none * Note the match rule identity number. * Stage a marc-file for import, for instance this one ftp://ftp.libris.kb.se/pub/export2/X/marc/X.20200104.marc sudo /usr/sbin/koha-shell -c "perl /home/vagrant/kohaclone/misc/stage_file.pl --match 4 --file 'X.20200104.marc' --format ISO2709 --comment 'test'" kohadev * Note the batch number and commit the file using the batch number: sudo /usr/sbin/koha-shell -c "perl /home/vagrant/kohaclone/misc/commit_file.pl --batch-number 1" kohadev * Again, stage the same marc-file for import: sudo /usr/sbin/koha-shell -c "perl /home/vagrant/kohaclone/misc/stage_file.pl --match 4 --file 'X.20200104.marc' --format ISO2709 --comment 'test'" kohadev * Note the number of records matched. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 5 14:06:54 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 05 Jan 2020 13:06:54 +0000 Subject: [Koha-bugs] [Bug 11994] Add option for installing a search plugin for Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11994 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |Academy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 5 14:07:00 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 05 Jan 2020 13:07:00 +0000 Subject: [Koha-bugs] [Bug 24348] Record matching rules: required match checks does not work In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24348 Andreas Jonsson changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Jan 5 14:10:57 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 05 Jan 2020 13:10:57 +0000 Subject: [Koha-bugs] [Bug 12004] Regional preference on holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12004 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #1 from Katrin Fischer --- I wonder if we need this to be a separate thing or something that you could calculate into your cost matrix - libraries in the same region get lower 'cost values' than those outside the region. Adding another dimension might make it even harder to track why something happened in a certain way. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 5 14:11:51 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 05 Jan 2020 13:11:51 +0000 Subject: [Koha-bugs] [Bug 12011] ReservesNeedReturns breaks 'Hold Filled' notice functionality In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12011 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|ReservesNeedReturns breaks |ReservesNeedReturns breaks |'Hold Filled' functionality |'Hold Filled' notice | |functionality CC| |katrin.fischer at bsz-bw.de -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 5 14:16:34 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 05 Jan 2020 13:16:34 +0000 Subject: [Koha-bugs] [Bug 24348] Record matching rules: required match checks does not work In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24348 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|normal |major CC| |katrin.fischer at bsz-bw.de -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 5 14:36:46 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 05 Jan 2020 13:36:46 +0000 Subject: [Koha-bugs] [Bug 12035] PDF print: Purchase order overflows incorrectly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12035 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Purchase Order Overflows |PDF print: Purchase order |Incorrectly |overflows incorrectly CC| |katrin.fischer at bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Jan 5 14:39:08 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 05 Jan 2020 13:39:08 +0000 Subject: [Koha-bugs] [Bug 12038] Need a provision to search specific barcode/accession number In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12038 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #1 from Katrin Fischer --- Could the problem be related to QueryAutoTruncate? It sounds like it might depend on the type of barcodes in use at the library. The item search requires specific truncation, so this might be a valid workaround looking for a specific item it can be the first choice. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 5 14:40:53 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 05 Jan 2020 13:40:53 +0000 Subject: [Koha-bugs] [Bug 12044] Checkout should not be possible if a patron's fines will block the transaction In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12044 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #1 from Katrin Fischer --- Should probably also take AllowFineOverride into account (see bug 11553) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 5 14:41:07 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 05 Jan 2020 13:41:07 +0000 Subject: [Koha-bugs] [Bug 11553] Balance exceeding noissuescharge should be more prominent when AllowFineOverride is enabled In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11553 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED CC| |katrin.fischer at bsz-bw.de Resolution|--- |DUPLICATE --- Comment #1 from Katrin Fischer --- *** This bug has been marked as a duplicate of bug 12044 *** -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 5 14:41:07 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 05 Jan 2020 13:41:07 +0000 Subject: [Koha-bugs] [Bug 12044] Checkout should not be possible if a patron's fines will block the transaction In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12044 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com --- Comment #2 from Katrin Fischer --- *** Bug 11553 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 5 14:43:00 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 05 Jan 2020 13:43:00 +0000 Subject: [Koha-bugs] [Bug 12077] Give superlibrarian ability to remove selected patron fine history. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12077 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #1 from Katrin Fischer --- For the unwanted credit, does the new 'void' and credit related features solve the issue? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Jan 5 14:46:06 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 05 Jan 2020 13:46:06 +0000 Subject: [Koha-bugs] [Bug 12093] Add css classes to item statuses in detail view In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12093 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff CC| |katrin.fischer at bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Jan 5 14:46:29 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 05 Jan 2020 13:46:29 +0000 Subject: [Koha-bugs] [Bug 12093] Add css classes to item statuses in detail view In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12093 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply --- Comment #1 from Katrin Fischer --- Assignee is not set and bug number is missing from commit message. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 5 14:46:35 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 05 Jan 2020 13:46:35 +0000 Subject: [Koha-bugs] [Bug 12093] Add css classes to item statuses in detail view In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12093 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |Academy -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 5 14:47:32 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 05 Jan 2020 13:47:32 +0000 Subject: [Koha-bugs] [Bug 12104] Add print label to serials receive In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12104 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Summary|add print label to serials |Add print label to serials |receive |receive -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Jan 5 14:48:43 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 05 Jan 2020 13:48:43 +0000 Subject: [Koha-bugs] [Bug 12108] OPAC "issues for subscription" page does not handle custom frequencies In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12108 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |DUPLICATE CC| |katrin.fischer at bsz-bw.de Status|NEW |RESOLVED --- Comment #1 from Katrin Fischer --- *** This bug has been marked as a duplicate of bug 11589 *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 5 14:48:43 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 05 Jan 2020 13:48:43 +0000 Subject: [Koha-bugs] [Bug 11589] Sample serial frequencies do not match template frequencies In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11589 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |gmcharlt at gmail.com --- Comment #3 from Katrin Fischer --- *** Bug 12108 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 5 14:54:25 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 05 Jan 2020 13:54:25 +0000 Subject: [Koha-bugs] [Bug 12142] option to automatically add a processing fee when an item is marked lost In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12142 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Resolution|--- |FIXED Status|NEW |RESOLVED --- Comment #1 from Katrin Fischer --- We now got a 'Processing fee (when lost)' on item type level. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Jan 5 14:59:20 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 05 Jan 2020 13:59:20 +0000 Subject: [Koha-bugs] [Bug 12171] Make Quick Spine Label Creator Quicker In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12171 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED CC| |katrin.fischer at bsz-bw.de Status|NEW |RESOLVED --- Comment #2 from Katrin Fischer --- Closing FIXED as I think Owen pointed out different ways of resolving this. Please reopen with more information if there is still something missing. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 5 15:01:50 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 05 Jan 2020 14:01:50 +0000 Subject: [Koha-bugs] [Bug 8908] Starman/Plack hangs when faced with zombie Zebra In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8908 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |WORKSFORME --- Comment #3 from Katrin Fischer --- (In reply to Katrin Fischer from comment #2) > I am not sure if this is still valid. There has been no new information > provided since 2012. It's unclear how to turn Zebra into a zombie. No new information provided since 2012 - assuming WORKSFORME. Please reopen if this is still an issue. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 5 15:01:50 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 05 Jan 2020 14:01:50 +0000 Subject: [Koha-bugs] [Bug 12173] Improving Plack support on the staff client OMNIBUS In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12173 Bug 12173 depends on bug 8908, which changed state. Bug 8908 Summary: Starman/Plack hangs when faced with zombie Zebra https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8908 What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |WORKSFORME -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 5 15:02:26 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 05 Jan 2020 14:02:26 +0000 Subject: [Koha-bugs] [Bug 12173] Improving Plack support on the staff client OMNIBUS In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12173 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|NEW |RESOLVED --- Comment #1 from Katrin Fischer --- Closing as all dependent bugs are now resolved. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 5 15:05:53 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 05 Jan 2020 14:05:53 +0000 Subject: [Koha-bugs] [Bug 12215] Add 'sql dump' as report output option In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12215 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Feature request: add 'sql |Add 'sql dump' as report |dump' as report output |output option |option | CC| |katrin.fischer at bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 5 15:09:01 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 05 Jan 2020 14:09:01 +0000 Subject: [Koha-bugs] [Bug 12225] SIP does not respect the "no block" flag In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12225 --- Comment #6 from Katrin Fischer --- Hi Colin, could you give an update here? Is the old patch something that could be reused or should we obsolete it? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 5 15:10:16 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 05 Jan 2020 14:10:16 +0000 Subject: [Koha-bugs] [Bug 12235] Logs organized inconsistently In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12235 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Status|NEW |RESOLVED Resolution|--- |DUPLICATE --- Comment #1 from Katrin Fischer --- *** This bug has been marked as a duplicate of bug 10352 *** -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Jan 5 15:10:16 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 05 Jan 2020 14:10:16 +0000 Subject: [Koha-bugs] [Bug 10352] Cataloguing log search mixing itemnumber/bibnumber In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10352 --- Comment #27 from Katrin Fischer --- *** Bug 12235 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 5 15:12:23 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 05 Jan 2020 14:12:23 +0000 Subject: [Koha-bugs] [Bug 12247] order_manage_all only works if branch is set in basket In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12247 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #1 from Katrin Fischer --- In a central system I could imagine a basket without branch meaning that it can include orders for different branches. So not sure if making the field mandatory will work in every setting? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 5 15:13:50 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 05 Jan 2020 14:13:50 +0000 Subject: [Koha-bugs] [Bug 12260] Printing a page from bootstrap shows unnecessary links In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12260 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Keywords| |Academy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 5 15:16:48 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 05 Jan 2020 14:16:48 +0000 Subject: [Koha-bugs] [Bug 12277] Minimize need for scrolling on new order page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12277 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Improve screen layout |Minimize need for scrolling |during acuqisition and |on new order page |creating new catalog record | CC| |katrin.fischer at bsz-bw.de -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 5 15:17:23 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 05 Jan 2020 14:17:23 +0000 Subject: [Koha-bugs] [Bug 12278] Total amount of each invoice should be displayed in invoices page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12278 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|the amount of each invoice |Total amount of each |should be displayed in |invoice should be displayed |invoices page |in invoices page CC| |katrin.fischer at bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Jan 5 15:17:57 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 05 Jan 2020 14:17:57 +0000 Subject: [Koha-bugs] [Bug 12284] More granular display options for authorities In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12284 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |DUPLICATE Status|NEW |RESOLVED --- Comment #2 from Katrin Fischer --- *** This bug has been marked as a duplicate of bug 11582 *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 5 15:17:57 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 05 Jan 2020 14:17:57 +0000 Subject: [Koha-bugs] [Bug 11582] Have same display/hidden options for authority subfields like bibliographic subfields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11582 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |ztajoli at gmail.com --- Comment #1 from Katrin Fischer --- *** Bug 12284 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 5 15:18:32 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 05 Jan 2020 14:18:32 +0000 Subject: [Koha-bugs] [Bug 12303] use public reports to generate a new items widget In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12303 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED CC| |katrin.fischer at bsz-bw.de Resolution|--- |FIXED --- Comment #1 from Katrin Fischer --- We have this with the plugin system now. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 5 15:22:07 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 05 Jan 2020 14:22:07 +0000 Subject: [Koha-bugs] [Bug 12351] order from new empty should include UPC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12351 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |FIXED CC| |katrin.fischer at bsz-bw.de --- Comment #1 from Katrin Fischer --- This can now be achieved using the UseACQFrameworkForBiblioRecords system preference. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Jan 5 15:24:22 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 05 Jan 2020 14:24:22 +0000 Subject: [Koha-bugs] [Bug 12358] patrons can't see hold notes in the opac In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12358 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #4 from Katrin Fischer --- Maybe we should split notes - have patron and staff notes? On migration we could handle all existing notes as 'staff' (internal) notes. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 5 15:26:52 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 05 Jan 2020 14:26:52 +0000 Subject: [Koha-bugs] [Bug 12366] Better handling of Zebra errors when searching empty indexes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12366 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED CC| |katrin.fischer at bsz-bw.de Resolution|--- |FIXED --- Comment #2 from Katrin Fischer --- (In reply to David Cook from comment #0) > Currently, if you turn on "OpacSuppression" (i.e. Hide) or "dontmerge" (i.e. > Do), Zebra will return errors, if the OpacSuppression index is empty or if > the Koha-Auth-Number index is empty. This has been fixed a onger while ago - turning on OpacSuppression with no suppressed records is no longer breaking search (thankfully). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 5 15:29:30 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 05 Jan 2020 14:29:30 +0000 Subject: [Koha-bugs] [Bug 12389] hide collections/locations if not for that branch In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12389 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #1 from Katrin Fischer --- I don't think that would work in every setting and should likely be configurable. At the moment the settings for branch limitations only reflect on the staff side, but we still assume libraries can search the complete catalog, so nothing is hidden there. What about floating items etc.? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 5 15:29:44 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 05 Jan 2020 14:29:44 +0000 Subject: [Koha-bugs] [Bug 12389] Hide collections/locations if not for that library In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12389 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|hide collections/locations |Hide collections/locations |if not for that branch |if not for that library -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 5 15:31:05 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 05 Jan 2020 14:31:05 +0000 Subject: [Koha-bugs] [Bug 12392] trying to vote gets invalid parameter In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12392 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |WORKSFORME Status|NEW |RESOLVED --- Comment #4 from Katrin Fischer --- Voting appears to work nicely now. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Jan 5 15:33:01 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 05 Jan 2020 14:33:01 +0000 Subject: [Koha-bugs] [Bug 12401] card view on z searches sometimes throws error In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12401 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #3 from Katrin Fischer --- The screencast links no longer work - can you upload a broken record maybe? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 5 15:33:57 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 05 Jan 2020 14:33:57 +0000 Subject: [Koha-bugs] [Bug 12408] logs keeping patron info even if privacy='never' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12408 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Blocks| |22794 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22794 [Bug 22794] Omnibus: Improve and extend logging in Koha -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Jan 5 15:33:57 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 05 Jan 2020 14:33:57 +0000 Subject: [Koha-bugs] [Bug 22794] Omnibus: Improve and extend logging in Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22794 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |12408 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12408 [Bug 12408] logs keeping patron info even if privacy='never' -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Jan 5 15:36:05 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 05 Jan 2020 14:36:05 +0000 Subject: [Koha-bugs] [Bug 12442] Query... variables should be defined within loop in Search.pm In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12442 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #2 from Katrin Fischer --- David, can you tell if this is still valid and provide a little more information? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 5 15:39:15 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 05 Jan 2020 14:39:15 +0000 Subject: [Koha-bugs] [Bug 12090] Disabling Library Location In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12090 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |DUPLICATE --- Comment #3 from Katrin Fischer --- Opting for the newer bug as it has had a bit more discussion. *** This bug has been marked as a duplicate of bug 12450 *** -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Jan 5 15:39:15 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 05 Jan 2020 14:39:15 +0000 Subject: [Koha-bugs] [Bug 12450] Closing libraries for the summer In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12450 --- Comment #9 from Katrin Fischer --- *** Bug 12090 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Jan 5 15:41:27 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 05 Jan 2020 14:41:27 +0000 Subject: [Koha-bugs] [Bug 12474] Improve Amazon cover image alt text in Bootstrap In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12474 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |Academy CC| |katrin.fischer at bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 5 15:44:41 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 05 Jan 2020 14:44:41 +0000 Subject: [Koha-bugs] [Bug 12498] Show start and end date on budget page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12498 --- Comment #2 from Katrin Fischer --- (In reply to Katrin Fischer from comment #1) > Hm, not sure if this makes sense any more... Yes it does. :) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 5 15:45:42 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 05 Jan 2020 14:45:42 +0000 Subject: [Koha-bugs] [Bug 12503] Problem with label alignment In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12503 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED CC| |katrin.fischer at bsz-bw.de Resolution|--- |WORKSFORME --- Comment #6 from Katrin Fischer --- Closing WORKSFORME per comment#3 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 5 15:47:02 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 05 Jan 2020 14:47:02 +0000 Subject: [Koha-bugs] [Bug 12506] "Warning at %" message is unclear in aqbudgets.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12506 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |Academy CC| |katrin.fischer at bsz-bw.de --- Comment #1 from Katrin Fischer --- I am not sure how to fix this, but maybe getting some new eyes on it can help. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 5 15:49:48 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 05 Jan 2020 14:49:48 +0000 Subject: [Koha-bugs] [Bug 12546] Add 'Other Controlnumber' as search option for staff client and OPAC advanced search pages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12546 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Add 'OCLC Number' as search |Add 'Other Controlnumber' |item for staff client and |as search option for staff |OPAC advanced search pages |client and OPAC advanced | |search pages CC| |katrin.fischer at bsz-bw.de --- Comment #2 from Katrin Fischer --- See discussion for naming on bug 6499. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 5 16:55:24 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 05 Jan 2020 15:55:24 +0000 Subject: [Koha-bugs] [Bug 12506] "Warning at %" message is unclear in aqbudgets.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12506 --- Comment #2 from Owen Leonard --- I'm not an acquisitions, but I'm confused about why this is confusing. However, we could improve the hint on aqbudgets.pl: Warning at %: "Show a warning when the amount remaining in the fund reaches a certain percentage of the total. Enter 0 to disable." Warning at amount: "Show a warning when the amount remaining in the fund reaches a certain number. Enter 0 to disable." But I think the root of the problem isn't budget_encumb, I think it's the fact that creating or modifying funds doesn't give any contextual information about the amount available in the parent fund or parent budget. I think that's what's confusing about the "Fund amount exceeds..." messages. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Jan 5 17:27:15 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 05 Jan 2020 16:27:15 +0000 Subject: [Koha-bugs] [Bug 10561] DisplayOPACiconsXSLT description should be clearer In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10561 --- Comment #4 from Owen Leonard --- Is this bug still valid? The current description of the preference is: "[Show/Don't show] the format, audience, and material type icons in XSLT MARC21 results and detail pages in the OPAC." -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 5 17:39:32 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 05 Jan 2020 16:39:32 +0000 Subject: [Koha-bugs] [Bug 10561] DisplayOPACiconsXSLT description should be clearer In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10561 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|NEW |RESOLVED --- Comment #5 from Katrin Fischer --- (In reply to Owen Leonard from comment #4) > Is this bug still valid? The current description of the preference is: > > "[Show/Don't show] the format, audience, and material type icons in XSLT > MARC21 results and detail pages in the OPAC." I didn't check - I think you are right, that reads well! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 5 17:41:28 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 05 Jan 2020 16:41:28 +0000 Subject: [Koha-bugs] [Bug 10561] DisplayOPACiconsXSLT description should be clearer In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10561 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |REOPENED Resolution|FIXED |--- --- Comment #6 from Katrin Fischer --- (In reply to Katrin Fischer from comment #5) > (In reply to Owen Leonard from comment #4) > > Is this bug still valid? The current description of the preference is: > > > > "[Show/Don't show] the format, audience, and material type icons in XSLT > > MARC21 results and detail pages in the OPAC." > > I didn't check - I think you are right, that reads well. OK; rethinking: The issue David pointed out is that it doesn't just hide the icons, it hides the whole thing, including descriptions etc. - I think that's the thing David was pointing out: >However, turning on/off "DisplayOPACiconsXSLT" also displays/hides information >on the "Type", "Format", "Literary Form", etc. In other words, lots of valuable >information from the fixed fields in the Leader, 006, 007, and/or 008. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 5 17:41:34 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 05 Jan 2020 16:41:34 +0000 Subject: [Koha-bugs] [Bug 10561] DisplayOPACiconsXSLT description should be clearer In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10561 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|REOPENED |NEW -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 5 17:43:47 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 05 Jan 2020 16:43:47 +0000 Subject: [Koha-bugs] [Bug 12506] "Warning at %" message is unclear in aqbudgets.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12506 --- Comment #3 from Katrin Fischer --- (In reply to Owen Leonard from comment #2) > I'm not an acquisitions, but I'm confused about why this is confusing. > However, we could improve the hint on aqbudgets.pl: > > Warning at %: "Show a warning when the amount remaining in the fund reaches > a certain percentage of the total. Enter 0 to disable." > > Warning at amount: "Show a warning when the amount remaining in the fund > reaches a certain number. Enter 0 to disable." Is it the 'amount remaining' or 'amount spent + encumbered'? I thought it was the latter, but haven't verified it yet. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Jan 5 20:52:54 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 05 Jan 2020 19:52:54 +0000 Subject: [Koha-bugs] [Bug 23944] Phase out use of jquery.cookie.js in favor of js.cookie.js In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23944 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #94951|0 |1 is obsolete| | Attachment #94953|0 |1 is obsolete| | --- Comment #3 from Owen Leonard --- Created attachment 96826 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96826&action=edit Bug 23944: Phase out use of jquery.cookie.js in favor of js.cookie.js This patch adds a new JavaScript file to the staff client's global JavaScript include file: js.cookie-2.2.1.min.js. This "plugin" will replace jquery.cookie.js which is no longer maintained. The "About" page in the staff client is updated to include this new resource as well as adding previously-missing information about the old plugin which will remain until all instances of its usage have been removed. To test, apply the patch and check the About page to confirm the correct information is included. No functionality change is introduced by this bug. The only other observable change is the existence of the new files and the inclusion of the minified version of the file in any staff client page. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 5 20:52:56 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 05 Jan 2020 19:52:56 +0000 Subject: [Koha-bugs] [Bug 23944] Phase out use of jquery.cookie.js in favor of js.cookie.js In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23944 --- Comment #4 from Owen Leonard --- Created attachment 96827 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96827&action=edit Bug 23944: (follow-up) Update circulation to use new library This patch updates the circulation page to use the new JavaScript Cookie library for cookie management. To test, apply the patch and open a patron record for checkout in the staff client. - Click "Search to hold" in the toolbar and perform a catalog search which will return results. - On the search results page, the toolbar at the top of the results should include a split "Place hold" button. The button's menu should include "Place hold for " and "Forget " options. Test that these work correctly. - In the table of search results each title should include a "Place hold for " link. - Go to the checkouts page for a patron with one or more checked-out items. - Check the "Always show checkouts immediately" checkbox. - The patron's checkouts should load. - Open another patron for checkout who has checked-out items. - The table of checkouts should load automatically. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 5 20:54:39 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 05 Jan 2020 19:54:39 +0000 Subject: [Koha-bugs] [Bug 24347] Add a 'search to order' option similar to 'search to hold' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24347 --- Comment #1 from Owen Leonard --- If anyone is interested in this feature I recommend helping test Bug 23944, "Phase out use of jquery.cookie.js in favor of js.cookie.js" which I would view as a dependency. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 5 21:55:05 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 05 Jan 2020 20:55:05 +0000 Subject: [Koha-bugs] [Bug 10498] Place a hold at time of ordering In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10498 --- Comment #12 from Michal Denar --- +1 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 5 22:01:36 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 05 Jan 2020 21:01:36 +0000 Subject: [Koha-bugs] [Bug 24344] Modify OPAC link to suggest existing record for purchase In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24344 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 5 22:01:40 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 05 Jan 2020 21:01:40 +0000 Subject: [Koha-bugs] [Bug 24344] Modify OPAC link to suggest existing record for purchase In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24344 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #96824|0 |1 is obsolete| | --- Comment #2 from Jonathan Druart --- Created attachment 96828 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96828&action=edit Bug 24344: Modify OPAC link to suggest existing record for purchase This patch modifies the link to suggest purchase of an existing record from the OPAC. The icon is changed to "gift" and the text shortened to "Suggest for purchase." To test, apply the patch and view the detail page of any record in the OPAC. Confirm that the modifications look good. Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 5 22:02:04 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 05 Jan 2020 21:02:04 +0000 Subject: [Koha-bugs] [Bug 24345] Fix process of suggesting purchase of existing title for non-logged-in users In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24345 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |jonathan.druart at bugs.koha-c |ity.org |ommunity.org CC| |jonathan.druart at bugs.koha-c | |ommunity.org -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 5 22:07:10 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 05 Jan 2020 21:07:10 +0000 Subject: [Koha-bugs] [Bug 24345] Fix process of suggesting purchase of existing title for non-logged-in users In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24345 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 5 22:07:14 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 05 Jan 2020 21:07:14 +0000 Subject: [Koha-bugs] [Bug 24345] Fix process of suggesting purchase of existing title for non-logged-in users In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24345 --- Comment #1 from Jonathan Druart --- Created attachment 96829 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96829&action=edit Bug 24345: Fix process of suggesting purchase of existing title for non-logged-in users The 'op' parameter is removed from the CGI object ($input) before get_template_and_user is called. When the user is redirected to the login form (from checkauth, called from get_template_and_user), the op is lost. Moving down the deletion fixes the problem. Test plan: Logout at the OPAC Go the detail page of a bibliographic record Click the "Suggest for purchase" link Fill the login form => Without this patch you will see your suggestion list => With this patch applied the new suggestion form will be displayed, prefilled with the biblio's info -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 5 22:14:26 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 05 Jan 2020 21:14:26 +0000 Subject: [Koha-bugs] [Bug 24345] Fix process of suggesting purchase of existing title for non-logged-in users In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24345 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 5 22:14:29 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 05 Jan 2020 21:14:29 +0000 Subject: [Koha-bugs] [Bug 24345] Fix process of suggesting purchase of existing title for non-logged-in users In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24345 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #96829|0 |1 is obsolete| | --- Comment #2 from Owen Leonard --- Created attachment 96830 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96830&action=edit Bug 24345: Fix process of suggesting purchase of existing title for non-logged-in users The 'op' parameter is removed from the CGI object ($input) before get_template_and_user is called. When the user is redirected to the login form (from checkauth, called from get_template_and_user), the op is lost. Moving down the deletion fixes the problem. Test plan: Logout at the OPAC Go the detail page of a bibliographic record Click the "Suggest for purchase" link Fill the login form => Without this patch you will see your suggestion list => With this patch applied the new suggestion form will be displayed, prefilled with the biblio's info Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 5 22:26:28 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 05 Jan 2020 21:26:28 +0000 Subject: [Koha-bugs] [Bug 10758] Show bibliographic information of deleted records in acquisitions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10758 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |20271 --- Comment #67 from Jonathan Druart --- That should be done on top of bug 20271. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271 [Bug 20271] Merge deleted biblio, biblioitems, biblio_metadata, and items tables with their "alive" cousins -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 5 22:26:28 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 05 Jan 2020 21:26:28 +0000 Subject: [Koha-bugs] [Bug 20271] Merge deleted biblio, biblioitems, biblio_metadata, and items tables with their "alive" cousins In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |10758 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10758 [Bug 10758] Show bibliographic information of deleted records in acquisitions -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 5 22:30:10 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 05 Jan 2020 21:30:10 +0000 Subject: [Koha-bugs] [Bug 11426] Make HighlightOwnItemsOnOPAC work with XSLT In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11426 --- Comment #9 from Jonathan Druart --- (In reply to Katrin Fischer from comment #8) > Should this be 'Needs signoff'? No, see my previous comment. It only makes the feature work for non-XSLT view. We need it for the XSLT view. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 5 22:38:09 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 05 Jan 2020 21:38:09 +0000 Subject: [Koha-bugs] [Bug 24263] borrowers.relationship should not contain an empty string In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24263 --- Comment #10 from Jonathan Druart --- It's following an existing pattern (reset or modify an invalid value in -> store). Throwing an exception here would mean to catch it in all our Koha::Patron->store. That is much more work, especially to fix a major bug that impacts stable branches. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 5 23:09:05 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 05 Jan 2020 22:09:05 +0000 Subject: [Koha-bugs] [Bug 24329] Patron cardnumber change times are lost during upgrade for bug 3820 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24329 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 5 23:09:13 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 05 Jan 2020 22:09:13 +0000 Subject: [Koha-bugs] [Bug 24329] Patron cardnumber change times are lost during upgrade for bug 3820 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24329 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #96775|0 |1 is obsolete| | Attachment #96776|0 |1 is obsolete| | --- Comment #5 from Jonathan Druart --- Created attachment 96831 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96831&action=edit Bug 24329: Correction to updatedatabase Ensure timestamp is not overwriteen during upgrade when applying updates for bug 3820 Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Jan 5 23:09:20 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 05 Jan 2020 22:09:20 +0000 Subject: [Koha-bugs] [Bug 24329] Patron cardnumber change times are lost during upgrade for bug 3820 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24329 --- Comment #6 from Jonathan Druart --- Created attachment 96832 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96832&action=edit Bug 24329: Prevent update of timestamp on action_logs updates Signed-off-by: Katrin Fischer Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 5 23:09:28 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 05 Jan 2020 22:09:28 +0000 Subject: [Koha-bugs] [Bug 24329] Patron cardnumber change times are lost during upgrade for bug 3820 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24329 --- Comment #7 from Jonathan Druart --- Created attachment 96833 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96833&action=edit Bug 24329: Add a test Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jan 5 23:09:55 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 05 Jan 2020 22:09:55 +0000 Subject: [Koha-bugs] [Bug 24329] Patron cardnumber change times are lost during upgrade for bug 3820 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24329 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |martin.renvoize at ptfs-europe |ity.org |.com CC| |jonathan.druart at bugs.koha-c | |ommunity.org -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Jan 5 23:13:42 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 05 Jan 2020 22:13:42 +0000 Subject: [Koha-bugs] [Bug 10758] Show bibliographic information of deleted records in acquisitions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10758 --- Comment #68 from Katrin Fischer --- (In reply to Jonathan Druart from comment #67) > That should be done on top of bug 20271. We could do it in a different way too - I know that we got some logic in a table now where 2 biblionumbers are stored in different columns - that way FK can be set. Martin did it, I just fail to remember the bug report and table. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Jan 6 00:40:49 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 05 Jan 2020 23:40:49 +0000 Subject: [Koha-bugs] [Bug 12561] Omnibus: Deprecate non-XSLT detail and result views In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12561 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_20_05_target -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 6 00:42:15 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 05 Jan 2020 23:42:15 +0000 Subject: [Koha-bugs] [Bug 12566] Duplicate checks for self registered patrons (other than email) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12566 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|normal |enhancement -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Jan 6 00:45:51 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 05 Jan 2020 23:45:51 +0000 Subject: [Koha-bugs] [Bug 12580] DataTables overflow their container elements In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12580 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #2 from Katrin Fischer --- (In reply to David Cook from comment #1) > An idea might be to add more "Show/hide" column options to more DataTables. > > This would work nicely: http://datatables.net/examples/api/show_hide.html > > However, that's in DataTables 1.10, whereas we're using DataTables 1.9 which > is now considered legacy. Unfortunately, I couldn't find an equivalent in > the legacy docs: http://legacy.datatables.net/ref We now have this is in a lot of the larger tables with the Colvis plugin. I am not sure there is a general solution to this - long text like urls won't wrap in the browser and will always cause trouble in tables - it also would in other applications. Should we still keep this open? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 6 00:56:05 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 05 Jan 2020 23:56:05 +0000 Subject: [Koha-bugs] [Bug 12611] Add ICU to options when creating a new instance In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12611 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Localisation enchancement |Add ICU to options when |in installation procedure |creating a new instance Component|Installation and upgrade |Packaging |(web-based installer) | CC| |katrin.fischer at bsz-bw.de, | |mirko at abunchofthings.net --- Comment #1 from Katrin Fischer --- The web installer is too late for that, as the files will already have been put in place when you run it, but there is an option for ICU in the tarball installation (bug 7698). Maybe we should add an option to the debian package installation as well? Changing bug title. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 6 00:59:57 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 05 Jan 2020 23:59:57 +0000 Subject: [Koha-bugs] [Bug 12628] reports/cat_issues_top.pl incorrect checkout range query In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12628 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |Academy --- Comment #3 from Katrin Fischer --- This might be a nice rescue bug. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 6 01:01:22 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Jan 2020 00:01:22 +0000 Subject: [Koha-bugs] [Bug 12638] UTF-8 support; C4::Members::AttributeTypes::GetAttributeTypes_hashref should be rewrite In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12638 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #5 from Katrin Fischer --- Is this still an issue now (5 and something years later) or could it be closed? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 6 01:02:33 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Jan 2020 00:02:33 +0000 Subject: [Koha-bugs] [Bug 3150] Move emails for sending cart and list contents into notices tool In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3150 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=12643 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 6 01:02:33 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Jan 2020 00:02:33 +0000 Subject: [Koha-bugs] [Bug 12643] Emailing cart should send more details view instead of simple view In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12643 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=3150 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 6 01:37:16 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Jan 2020 00:37:16 +0000 Subject: [Koha-bugs] [Bug 12713] Highlight records/item already checked out by patron in the OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12713 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Mark records already in |Highlight records/item |possession of the patron |already checked out by | |patron in the OPAC -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 6 01:42:04 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Jan 2020 00:42:04 +0000 Subject: [Koha-bugs] [Bug 12719] Fix bulkmarcimport.pl documentation In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12719 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |Academy CC| |katrin.fischer at bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 6 01:48:29 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Jan 2020 00:48:29 +0000 Subject: [Koha-bugs] [Bug 12723] A separate fee for renewals In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12723 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Component|System Administration |Fines and fees -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Jan 6 02:35:09 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Jan 2020 01:35:09 +0000 Subject: [Koha-bugs] [Bug 12786] Permission to allow everyone in staff client to see all patron lists In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12786 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|NEW |RESOLVED --- Comment #6 from Katrin Fischer --- We now got the option to mark any patron list as 'shared', which means it will be visible to all staff members. I feel this is a more flexible solution than another permission - marking resolved, please reopen if it doesn't fit your needs. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 6 03:10:12 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Jan 2020 02:10:12 +0000 Subject: [Koha-bugs] [Bug 24347] Add a 'search to order' option similar to 'search to hold' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24347 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |oleonard at myacpl.org |ity.org | Status|NEW |ASSIGNED -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 6 06:10:05 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Jan 2020 05:10:05 +0000 Subject: [Koha-bugs] [Bug 12366] Better handling of Zebra errors when searching empty indexes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12366 --- Comment #3 from David Cook --- (In reply to Katrin Fischer from comment #2) > (In reply to David Cook from comment #0) > > Currently, if you turn on "OpacSuppression" (i.e. Hide) or "dontmerge" (i.e. > > Do), Zebra will return errors, if the OpacSuppression index is empty or if > > the Koha-Auth-Number index is empty. > > This has been fixed a onger while ago - turning on OpacSuppression with no > suppressed records is no longer breaking search (thankfully). Hehe I'm the one who fixed it. But I think this bug report is still valid as there are other searches that can contain syntax errors which cause Zebra to fail, but Koha to just report that 0 records matched. My goal with this bug report is for us to highlight that there was a problem with the search query. Otherwise, people might get the mistaken impression that there really are no relevant records in the database, when really the only problem is their syntax :(. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 6 06:13:01 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Jan 2020 05:13:01 +0000 Subject: [Koha-bugs] [Bug 12442] Query... variables should be defined within loop in Search.pm In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12442 --- Comment #3 from David Cook --- (In reply to Katrin Fischer from comment #2) > David, can you tell if this is still valid and provide a little more > information? I haven't looked in a long time, but I'd imagine that it's still valid. I think an example is QueryAutoTruncate. When it's on, all the index/operand pairs should have truncation enabled. However, there are some indexes that don't support truncation, so they'll turn QueryAutoTruncate off. So in theory you could have something like this: Pair0-Truncated, Pair1-Can't truncate disable auto truncation,Pair2-NotTruncated, Pair3-NotTruncated When really it should be like this: Pair0-Truncated, Pair1-Can't truncate, Pair2-Truncated, Pair3-Truncated Apologies if that still sounds too vague. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 6 06:16:33 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Jan 2020 05:16:33 +0000 Subject: [Koha-bugs] [Bug 12580] DataTables overflow their container elements In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12580 --- Comment #3 from David Cook --- (In reply to Katrin Fischer from comment #2) > I am not sure there is a general solution to this - long text like urls > won't wrap in the browser and will always cause trouble in tables - it also > would in other applications. Should we still keep this open? I figure it's still relevant. I was probably a bit too specific when I originally opened this bug report. I think it's really just a case of making sure that the wrappers and such expand to fill the whole page when there is this kind of overflow. Otherwise, the web page (usually the staff client) looks bad when scrolling over to the right. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 6 10:40:01 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Jan 2020 09:40:01 +0000 Subject: [Koha-bugs] [Bug 12580] DataTables overflow their container elements In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12580 --- Comment #4 from Katrin Fischer --- But maybe this should be a coding guideline then and not a bug report? The issue I see with such bug reports is that they don't get found and cannot really be fixed, as what they describe is not specific enough. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 6 10:46:26 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Jan 2020 09:46:26 +0000 Subject: [Koha-bugs] [Bug 12366] Better handling of Zebra errors when searching empty indexes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12366 --- Comment #4 from Katrin Fischer --- I am sorry, but I don't feel we should keep it open without having something broken we can name and fix - it will just remain open forever. If we want to document Zebra's behaviour in certain cases, the wiki would be a better place in my opinion than the bug tracker. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 6 11:45:50 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Jan 2020 10:45:50 +0000 Subject: [Koha-bugs] [Bug 12908] Add a German RELTERMS authorized value list to the web installer In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12908 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |WONTFIX --- Comment #1 from Katrin Fischer --- Marking this WONTFIX in favor of displaying the relator term instead of translating the relator code. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 6 11:46:51 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Jan 2020 10:46:51 +0000 Subject: [Koha-bugs] [Bug 12917] Centralize reserves "last pickup date" calculation In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12917 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #3 from Katrin Fischer --- Wonderig if this is still valid as we got Koha:Hold(s) for a while now? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 6 11:53:27 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Jan 2020 10:53:27 +0000 Subject: [Koha-bugs] [Bug 12939] Allow more renewals when another item of the record is available In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12939 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Summary|title level renewal |Allow more renewals when |restrictions |another item of the record | |is available -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Jan 6 11:58:06 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Jan 2020 10:58:06 +0000 Subject: [Koha-bugs] [Bug 12951] Login failure shows wrong message if user doesn't have the right permissions (staff client) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12951 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED CC| |katrin.fischer at bsz-bw.de Resolution|--- |WORKSFORME --- Comment #6 from Katrin Fischer --- (In reply to Owen Leonard from comment #5) > I can't reproduce this problem in master. Is it still valid? Same for me - it shows the correct message: Error: Invalid username or password -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 6 12:07:55 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Jan 2020 11:07:55 +0000 Subject: [Koha-bugs] [Bug 12960] Fee descriptions autofill with unnecessary/incorrect info In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12960 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|NEW |RESOLVED --- Comment #1 from Katrin Fischer --- (In reply to Nick Clemens from comment #0) > 1 - When adding manual invoices to a patron account the 'description' field > on the 'Create manual invoice' tab prefills to the type code for any type > except 'Lost item' (i.e 'F' for fine, 'A' for 'Account manag...') This is > not helpful to the user and is made even more unnecessary by bug 12415 Fixed, now a full description is added, that is more helpful. Wondering if we should leave it empty instead tho as it's a double up of information. > 2 - Copier fees description defaults to 'Copier fees' and the amount to > "0.25" which is just an odd assumption unless that is configurable. > Additionally, the account type for 'Copier Fees' shows as 'Copie' in both > the accounts tab and on receipts. For English that should probably be > either 'Copy' or stay with 'Copier fees' Fixed with the new debit types table. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 6 12:09:52 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Jan 2020 11:09:52 +0000 Subject: [Koha-bugs] [Bug 24349] New: Debit types table only shows 2 entries, but says there are 15 Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24349 Bug ID: 24349 Summary: Debit types table only shows 2 entries, but says there are 15 Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Fines and fees Assignee: koha-bugs at lists.koha-community.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org If you look at the administration > debit types page, the paging on the table reads: Showing 1 to 2 of 2 (filtered from 15 total entries) But there have been no filters set. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 6 12:11:06 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Jan 2020 11:11:06 +0000 Subject: [Koha-bugs] [Bug 24263] borrowers.relationship should not contain an empty string In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24263 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |tomascohen at gmail.com |y.org | --- Comment #11 from Tomás Cohen Arazi --- Fair enough. We will take care of those at some point. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 6 12:11:20 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Jan 2020 11:11:20 +0000 Subject: [Koha-bugs] [Bug 12962] easier to see circ rule edits In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12962 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=15522 CC| |katrin.fischer at bsz-bw.de -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 6 12:11:20 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Jan 2020 11:11:20 +0000 Subject: [Koha-bugs] [Bug 15522] New interface for revamped circulation rules In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15522 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=12962 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 6 12:38:27 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Jan 2020 11:38:27 +0000 Subject: [Koha-bugs] [Bug 13015] AdvancedSearchLanguages doesn't support all language codes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13015 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Language filter on search |AdvancedSearchLanguages |should take all languages |doesn't support all | |language codes CC| |katrin.fischer at bsz-bw.de --- Comment #1 from Katrin Fischer --- (In reply to Nicole C. Engard from comment #0) > All languages on this list > http://www.loc.gov/standards/iso639-2/php/code_list.php work in the advanced > search language filter system preference, but they do not. System preference: AdvancedSearchLanguages The list is built and translated from our database tables. We've been adding missing languages, but I am not sure how to solve this. Could we auto-generate a multi-select pref from the entries in the database? Then you could only see the available options and check/uncheck them. It would also remove the need to figure out the language codes to use. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 6 12:40:20 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Jan 2020 11:40:20 +0000 Subject: [Koha-bugs] [Bug 13032] Command line switch to add page breaks to overdue_notices.pl sent to the library In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13032 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Feature Request -- command |Command line switch to add |line switch to add page |page breaks to |breaks to |overdue_notices.pl sent to |overdue_notices.pl |the library -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Jan 6 12:48:53 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Jan 2020 11:48:53 +0000 Subject: [Koha-bugs] [Bug 24350] New: Can't place holds Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24350 Bug ID: 24350 Summary: Can't place holds Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: blocker Priority: P5 - low Component: Hold requests Assignee: koha-bugs at lists.koha-community.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com Depends on: 22284 When trying to place a hold in staff on master, I have the following error: Template process failed: undef error - Not a HASH reference at /home/vagrant/kohaclone/Koha/Template/Plugin/Branches.pm line 96. at /home/vagrant/kohaclone/C4/Templates.pm line 122 It works pre cd4dfc6e121a8f867fee5fcf8ccfd594bf163ba7 I haven't done a git bisect, but as this is the most recent holds work, I am going to add a link suspecting it to be the cause. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 [Bug 22284] Groups of pickup locations for holds -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Jan 6 12:48:53 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Jan 2020 11:48:53 +0000 Subject: [Koha-bugs] [Bug 22284] Groups of pickup locations for holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |24350 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24350 [Bug 24350] Can't place holds -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 6 12:59:01 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Jan 2020 11:59:01 +0000 Subject: [Koha-bugs] [Bug 13033] Waiting holds do not alert on check-in. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13033 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |WORKSFORME --- Comment #2 from Katrin Fischer --- (In reply to Katrin Fischer from comment #1) > Hi Barton and Nick, > was WaitingNotifyAtCheckin turned on? Marking WORKSFORME - just tested in 'almost' master (see bug 24350) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 6 12:59:21 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Jan 2020 11:59:21 +0000 Subject: [Koha-bugs] [Bug 24350] Can't place holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24350 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com Assignee|koha-bugs at lists.koha-commun |tomascohen at gmail.com |ity.org | --- Comment #1 from Tomás Cohen Arazi --- It makes sense to blame that dev as it reengineers the pickup locations code. I will take a look. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Jan 6 13:05:44 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Jan 2020 12:05:44 +0000 Subject: [Koha-bugs] [Bug 23112] Circulation of ILL items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23112 --- Comment #46 from Andrew Isherwood --- (In reply to Jonathan Druart from comment #45) > Comment on attachment 95566 [details] [review] > Bug 23112: Add circulation to ILL requests > > Review of attachment 95566 [details] [review]: > ----------------------------------------------------------------- > > Also, I think you should use patron-title.inc to display patron's info. Aha, good spot, thanks! I'm about to add a patch to address that. > > ::: Koha/Illrequest.pm > @@ +1211,5 @@ > > + # For some reason, AddIssue requires an unblessed Patron > > + $issue_args[0] = $patron->unblessed; > > + my $issue = C4::Circulation::AddIssue(@issue_args); > > + > > + if ($issue && %{$issue}) { > > AddIssue return a Koha::Checkout object. The test will work but I think it's > confusing. Do you mean the variable name $issue is confusing? If so, I thought it made sense since the function returning it is called AddIssue and, internally, AddIssue also calls the returned value $issue. > > ::: koha-tmpl/intranet-tmpl/prog/en/modules/ill/ill-requests.tt > @@ +704,4 @@ > > > > [% INCLUDE 'ill-list-table-strings.inc' %] > > [% Asset.js("js/ill-list-table.js") | $raw %] > > + [% Asset.js("js/ill-check-out.js") | $raw %] > > Where does this file come from? Another good spot, this include was leftover junk from an earlier attempt at this bug. About to attach a patch that removes this include. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 6 13:06:12 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Jan 2020 12:06:12 +0000 Subject: [Koha-bugs] [Bug 23112] Circulation of ILL items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23112 --- Comment #47 from Andrew Isherwood --- Created attachment 96834 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96834&action=edit Bug 23112: (follow-up) Address QA feedback As per comment #46 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 6 13:06:59 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Jan 2020 12:06:59 +0000 Subject: [Koha-bugs] [Bug 13060] number of holds on acq multiplying by copies ordered In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13060 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Status|NEW |RESOLVED Resolution|--- |FIXED --- Comment #3 from Katrin Fischer --- Just retested and the correct number of holds are shown. Display has been changed since to show item and record level holds separately. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 6 13:06:59 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Jan 2020 12:06:59 +0000 Subject: [Koha-bugs] [Bug 23112] Circulation of ILL items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23112 Andrew Isherwood changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 6 13:10:01 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Jan 2020 12:10:01 +0000 Subject: [Koha-bugs] [Bug 13063] 111n display wrong in opac In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13063 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Resolution|--- |WORKSFORME Status|NEW |RESOLVED --- Comment #3 from Katrin Fischer --- (In reply to Owen Leonard from comment #2) > This works for me in master. Can you please verify the version number? If > you can reproduce the problem in master please attach the MARC record. Closing WORKSFORME as per Owen's comment. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 6 13:11:20 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Jan 2020 12:11:20 +0000 Subject: [Koha-bugs] [Bug 13070] Managing staged MARC records, sorting by title should ignore articles In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13070 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=13054 --- Comment #4 from Katrin Fischer --- Is this a possible duplicate of bug 13054? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 6 13:11:20 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Jan 2020 12:11:20 +0000 Subject: [Koha-bugs] [Bug 13054] Allow server-side sorting by title to ignore custom sets of articles In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13054 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=13070 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 6 13:12:43 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Jan 2020 12:12:43 +0000 Subject: [Koha-bugs] [Bug 23838] Add ability to view item renew history In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23838 --- Comment #34 from Andrew Isherwood --- (In reply to Jonathan Druart from comment #33) > + $('#patronRenewals #incomplete').append(note + ': ' + > data.length + ' ' + out_of + ' ' + renewals + ' ' + renewals_logged).show(); > > To make this correctly translatable you should use the .format() JS function. Hi Jonathan This was addressed in this follow up patch https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96189&action=diff Did you not have all patches applied when you looked at this? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 6 13:17:34 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Jan 2020 12:17:34 +0000 Subject: [Koha-bugs] [Bug 13072] Plugins (Tools): you can't input diacritics In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13072 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Resolution|--- |FIXED Status|NEW |RESOLVED --- Comment #2 from Katrin Fischer --- Just tested with v2.1.32 - it looks all nice and well now. I remember we did some fixes for encoding a longer time ago. Suspecting this is fixed for good. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 6 13:20:19 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Jan 2020 12:20:19 +0000 Subject: [Koha-bugs] [Bug 13090] Using <> in html notices gives wrong encoding in generated letters In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13090 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #2 from Katrin Fischer --- Needs verifying, but what i suspect is that the HTML tags used in OPAC info might be displaying, because they get escaped (or were, this is an old bug report). -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Jan 6 13:23:09 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Jan 2020 12:23:09 +0000 Subject: [Koha-bugs] [Bug 13111] Allow librarians to add star ratings on behalf of a borrower In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13111 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=12789 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 6 13:23:09 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Jan 2020 12:23:09 +0000 Subject: [Koha-bugs] [Bug 12789] Add display of star ratings to staff client In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12789 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=13111 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Jan 6 13:31:27 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Jan 2020 12:31:27 +0000 Subject: [Koha-bugs] [Bug 13165] Active Hold Limit In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13165 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #1 from Katrin Fischer --- You kinda lost me there "I would love to see holds updated to act kind of like the Netflix DVD queue system." :) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 6 13:35:38 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Jan 2020 12:35:38 +0000 Subject: [Koha-bugs] [Bug 13175] remove duplicated functions() in koha-* bash scripts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13175 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de, | |mirko at abunchofthings.net Component|Command-line Utilities |Packaging -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 6 13:41:55 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Jan 2020 12:41:55 +0000 Subject: [Koha-bugs] [Bug 13185] On Site Checkouts - Should not be able to clear today's date In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13185 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |INVALID CC| |katrin.fischer at bsz-bw.de --- Comment #3 from Katrin Fischer --- I think this might be INVALID with the feature to set the due date maually from bug 13647. Marking as such, please reopen if I am mistaken. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Jan 6 13:44:02 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Jan 2020 12:44:02 +0000 Subject: [Koha-bugs] [Bug 24351] New: Connection to remote mysql server errors Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24351 Bug ID: 24351 Summary: Connection to remote mysql server errors Change sponsored?: --- Product: Koha Version: 19.11 Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Installation and upgrade (command-line installer) Assignee: koha-bugs at lists.koha-community.org Reporter: seemaalbal at gmail.com QA Contact: testopia at bugs.koha-community.org Hi I am installing Koha 19.11 on Debian 4.9. My SQL server is running on another instance. My my.cnf looks like this: [client] host= user=root password=xxxxx I have successfully installed library instance using the koha-create --create-db command This has installed a koha site in my apache2. However, the koha-conf.xml under /etc/koha/sites//koha-conf.xml had db hostname as localhost. I have edited this to point to my sql server. However, when I do a wget localhost:8080 I still get an internal server error. DBI Connect('database= References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24351 Seema Albal changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Connection to remote mysql |During Installation, |server errors |connection to remote mysql | |server fails Priority|P5 - low |P1 - high -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 6 13:53:49 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Jan 2020 12:53:49 +0000 Subject: [Koha-bugs] [Bug 13209] Show hold wait time estimate in OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13209 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Summary|show hold wait time |Show hold wait time |estimate in opac |estimate in OPAC -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Jan 6 13:54:49 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Jan 2020 12:54:49 +0000 Subject: [Koha-bugs] [Bug 13212] Use CSS3 ellipsis instead of FacetLabelTruncationLength In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13212 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |RESOLVED CC| |katrin.fischer at bsz-bw.de Resolution|--- |WONTFIX --- Comment #4 from Katrin Fischer --- (In reply to Owen Leonard from comment #3) > This works, but I don't think it's the right place to use this CSS3 feature. > I think it's important for libraries to be able to choose to display the > full facet using FacetLabelTruncationLength if they want to, without > resorting to custom CSS rules. Agreed, marking WONTFIX for now. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 6 13:55:41 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Jan 2020 12:55:41 +0000 Subject: [Koha-bugs] [Bug 13213] choose what fields don't overlay In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13213 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |DUPLICATE Status|NEW |RESOLVED CC| |katrin.fischer at bsz-bw.de --- Comment #1 from Katrin Fischer --- *** This bug has been marked as a duplicate of bug 14957 *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 6 13:55:41 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Jan 2020 12:55:41 +0000 Subject: [Koha-bugs] [Bug 14957] Write protecting MARC fields based on source of import In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nengard at gmail.com --- Comment #188 from Katrin Fischer --- *** Bug 13213 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 6 13:57:40 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Jan 2020 12:57:40 +0000 Subject: [Koha-bugs] [Bug 13243] Make it possible to have library-level patron restrictions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13243 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Summary|Restrict Patron just to the |Make it possible to have |library the Item is from |library-level patron | |restrictions -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 6 14:00:34 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Jan 2020 13:00:34 +0000 Subject: [Koha-bugs] [Bug 13249] AutoCreateAuthorities doesn't work for fields different from 700 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13249 --- Comment #3 from Katrin Fischer --- I wonder if this has something to do with MARC21 vs. UNIMARC. 700 is an authority controlled field in MARC21, the others are not. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 6 14:05:04 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Jan 2020 13:05:04 +0000 Subject: [Koha-bugs] [Bug 21633] Did finesMode = test ever send email? In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21633 Magnus Enger changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 6 14:05:08 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Jan 2020 13:05:08 +0000 Subject: [Koha-bugs] [Bug 21633] Did finesMode = test ever send email? In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21633 Magnus Enger changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #96794|0 |1 is obsolete| | --- Comment #7 from Magnus Enger --- Created attachment 96835 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96835&action=edit Bug 21633: Remove finesMode 'test' -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Jan 6 14:05:28 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Jan 2020 13:05:28 +0000 Subject: [Koha-bugs] [Bug 13260] lists sent from kohaadmineamailaddress instead of patron email In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13260 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |DUPLICATE CC| |katrin.fischer at bsz-bw.de --- Comment #2 from Katrin Fischer --- *** This bug has been marked as a duplicate of bug 6973 *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 6 14:05:28 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Jan 2020 13:05:28 +0000 Subject: [Koha-bugs] [Bug 6973] Allow reply-to on cart emails to go to the sender of the cart In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6973 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nengard at gmail.com --- Comment #22 from Katrin Fischer --- *** Bug 13260 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug. You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 6 14:09:29 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Jan 2020 13:09:29 +0000 Subject: [Koha-bugs] [Bug 13137] Tabbing in the items editor for serials does not behave correctly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13137 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED CC| |katrin.fischer at bsz-bw.de Resolution|--- |DUPLICATE --- Comment #1 from Katrin Fischer --- *** This bug has been marked as a duplicate of bug 13305 *** -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 6 14:09:29 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Jan 2020 13:09:29 +0000 Subject: [Koha-bugs] [Bug 13305] Fix tab order in cataloguing/item editor In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13305 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com --- Comment #5 from Katrin Fischer --- *** Bug 13137 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 6 14:11:42 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Jan 2020 13:11:42 +0000 Subject: [Koha-bugs] [Bug 13310] Show hold count in staff catalog search results In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13310 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Status|NEW |RESOLVED Resolution|--- |FIXED --- Comment #1 from Katrin Fischer --- I think this has been resolved, in staff it looks like this for me now: Holds (1) | Add to cart | Edit record | Edit items | OPAC view -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 6 14:13:22 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Jan 2020 13:13:22 +0000 Subject: [Koha-bugs] [Bug 13317] tools/export.pl should show help when executed with no args, from CLI In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13317 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #1 from Katrin Fischer --- This still appears to be true for the export_records.pl script. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 6 14:19:58 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Jan 2020 13:19:58 +0000 Subject: [Koha-bugs] [Bug 13366] Required fields not indicated on patron form In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13366 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |DUPLICATE Status|NEW |RESOLVED --- Comment #2 from Katrin Fischer --- *** This bug has been marked as a duplicate of bug 4030 *** -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Jan 6 14:19:58 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Jan 2020 13:19:58 +0000 Subject: [Koha-bugs] [Bug 4030] Patron attribute types cannot be made mandatory In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4030 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |cbrannon at cdalibrary.org --- Comment #7 from Katrin Fischer --- *** Bug 13366 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 6 14:25:26 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Jan 2020 13:25:26 +0000 Subject: [Koha-bugs] [Bug 13389] Calendar maintenance In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13389 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|NEW |RESOLVED CC| |katrin.fischer at bsz-bw.de --- Comment #1 from Katrin Fischer --- Hi Christopher, there already is such a thing: cleanup_database.pl --unique-holidays DAYS Delete all unique holidays older than DAYS -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 6 14:28:56 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Jan 2020 13:28:56 +0000 Subject: [Koha-bugs] [Bug 13420] Holdings table sorting on volume information incorrect In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13420 --- Comment #21 from Katrin Fischer --- Should we change this to 'Needs Signoff' to get some opinions? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 6 14:36:27 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Jan 2020 13:36:27 +0000 Subject: [Koha-bugs] [Bug 13491] make Selfcheck follow the CircAutoPrintQuickSlip In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13491 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|NEW |RESOLVED CC| |katrin.fischer at bsz-bw.de --- Comment #1 from Katrin Fischer --- I think CircAutoPrintQuickSlip would not be a good fit, as it includes options not available for the self check feature. Maybe SelfCheckReceiptPrompt already does the trick. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 6 14:43:02 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Jan 2020 13:43:02 +0000 Subject: [Koha-bugs] [Bug 13509] Cross reference link for "Author" in search results always uses keyword search. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13509 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Status|NEW |RESOLVED Resolution|--- |FIXED --- Comment #1 from Katrin Fischer --- This issue is due to the not uri-encoded & in the generated URL. It's fixed by the use of str:uri-encode in the XSLT templates now. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 6 14:44:19 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Jan 2020 13:44:19 +0000 Subject: [Koha-bugs] [Bug 13512] Add sort-string-utf.chr for Polish and Latin In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13512 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Keywords| |Academy --- Comment #5 from Katrin Fischer --- This is another good rescue patch. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 6 14:45:00 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Jan 2020 13:45:00 +0000 Subject: [Koha-bugs] [Bug 13513] Improve POD of C4::Circulation AnonymiseIssueHistory In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13513 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |Academy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 6 14:50:39 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Jan 2020 13:50:39 +0000 Subject: [Koha-bugs] [Bug 24343] Show subtitle, number and parts in course reserves list of titles in staff client In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24343 ByWater Sandboxes changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #96823|0 |1 is obsolete| | --- Comment #2 from ByWater Sandboxes --- Created attachment 96836 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96836&action=edit Bug 24343: Show subtitle, number and parts in course reserves list of titles in staff client Adapted from Bug 23784: At the moment only the title will display in the course reserves details, but not the information from other title fields. For series with multiple volumes that can lead to confusing display. The patch makes use of the new include to display 245$abnp. To test: - Add mulitple records to a course reserve course Make sure you have titles with different combinations of 245$b$n$p - Look at the course details in the staff client - Verify only $a displays - Apply patch - Reload - Verify now the full information displays Depending on your installation, you might want ot check that the 245 are correctly mapped and save the record once so the database fields are correctly filled. Signed-off-by: Andrew Fuerste-Henry -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 6 14:52:07 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Jan 2020 13:52:07 +0000 Subject: [Koha-bugs] [Bug 24343] Show subtitle, number and parts in course reserves list of titles in staff client In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24343 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #3 from Andrew Fuerste-Henry --- Thanks, Owen! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 6 14:52:29 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Jan 2020 13:52:29 +0000 Subject: [Koha-bugs] [Bug 23784] Show subtitle, number and parts in course reserves list of items in OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23784 --- Comment #6 from Andrew Fuerste-Henry --- Signed off Owen's bug. Thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 6 14:58:35 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Jan 2020 13:58:35 +0000 Subject: [Koha-bugs] [Bug 13550] Automatic processing status In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13550 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #1 from Katrin Fischer --- (In reply to Christopher Brannon from comment #0) > It would be great if Koha had the ability to flag items based on criteria > for automatic processing. For example, lets say you have a collection that > rotates libraries. It would be great to have some way to flag that > collection, and when criteria is met, and the item is checked in, it is put > into a predetermined processing status and handed off rather than going back > out on the shelves. > > Perhaps new items have a short loan period, and after a certain length of > time in the collection, it needs to be changed. It could be flagged to > either automatically change to a new loan period, or if it needs to be > handled for processing (labels and such), it could be flagged for processing. > > Perhaps you have items that need to be reset, or batteries to be replaced, > either every time it comes in or on a set interval. It could be flagged for > processing. > > It would also be beneficial to have reports on flagged items past due, for > items that have not necessarily circed. > > Christopher I think some of this can be solved using the Automatic item modifications by age tool and the UpdateItemLocationOnCheckin and UpdateNotForLoanStatusOnCheckin systempreferences. But as a whole it's a lot of different requirements that I think would be hard to put into one tool. What I got from the descriptions: - flag new items after certain time (Automatic item modifications by age) - flag items after a certain time period - flag items on every return Some of that could maybe be achieved with reports. But I think the idea is more to have a flag that can be removed once processed? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Jan 6 15:04:08 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Jan 2020 14:04:08 +0000 Subject: [Koha-bugs] [Bug 24343] Show subtitle, number and parts in course reserves list of titles in staff client In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24343 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |oleonard at myacpl.org |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 6 15:08:29 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Jan 2020 14:08:29 +0000 Subject: [Koha-bugs] [Bug 13561] Item search: Allow searching for custom 952 subfields (more_subfields) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13561 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |DUPLICATE Status|NEW |RESOLVED --- Comment #1 from Katrin Fischer --- *** This bug has been marked as a duplicate of bug 20689 *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 6 15:08:29 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Jan 2020 14:08:29 +0000 Subject: [Koha-bugs] [Bug 20689] Make it possible to add capital letter subfields to item search fields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20689 --- Comment #43 from Katrin Fischer --- *** Bug 13561 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 6 15:11:10 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Jan 2020 14:11:10 +0000 Subject: [Koha-bugs] [Bug 13576] Add a default circulation rule to the optional sample data In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13576 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED CC| |katrin.fischer at bsz-bw.de Status|NEW |RESOLVED --- Comment #6 from Katrin Fischer --- I think this has been solved by the onboarding tool that forces you to add a circulation rule at time of installation. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 6 15:17:32 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Jan 2020 14:17:32 +0000 Subject: [Koha-bugs] [Bug 13588] Should GetKohaAuthorisedValueLib return lib if lib_opac is empty and opac==1 ? In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13588 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |INVALID Status|NEW |RESOLVED --- Comment #2 from Katrin Fischer --- GetKohaAuthorisedValueLib is no more and there is 20307 for translations in the future. Closing INVALID because of the change of code since this was filed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 6 15:22:35 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Jan 2020 14:22:35 +0000 Subject: [Koha-bugs] [Bug 24073] Allow suggestion management page to default to all libraries In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24073 Marjorie Barry-Vila changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marjorie.barry-vila at collect | |o.ca -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 6 15:33:16 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Jan 2020 14:33:16 +0000 Subject: [Koha-bugs] [Bug 13661] Prevent sabotaging Zebra indexing from the cataloguing module by creating a subfield with a very long word. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13661 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |FIXED --- Comment #2 from Katrin Fischer --- I never got an answer from Olli - but I assume that the maxlength setting will prevent entering words longer than 999 (his example is 1008), that probably cause this issue. Please reopen if more is needed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 6 15:38:47 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Jan 2020 14:38:47 +0000 Subject: [Koha-bugs] [Bug 13677] UseKohaPlugins is on Catalog enrichtment tab In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13677 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |WONTFIX --- Comment #1 from Katrin Fischer --- We also have OPAC plugins and such... maybe it's good in enhanced content. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Jan 6 15:48:41 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Jan 2020 14:48:41 +0000 Subject: [Koha-bugs] [Bug 13701] Sharing lists: Text hardcoded to 2 weeks, but could be any time frame In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13701 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |Academy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 6 15:49:42 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Jan 2020 14:49:42 +0000 Subject: [Koha-bugs] [Bug 13710] add column for patron category on overdue report (overdue.pl) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13710 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED CC| |katrin.fischer at bsz-bw.de Resolution|--- |FIXED --- Comment #1 from Katrin Fischer --- This is available now! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 6 15:51:25 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Jan 2020 14:51:25 +0000 Subject: [Koha-bugs] [Bug 13720] Freeze columns/headers on circulation rules In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13720 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Summary|freeze columns/headers |Freeze columns/headers on | |circulation rules See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=15522 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Jan 6 15:51:25 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Jan 2020 14:51:25 +0000 Subject: [Koha-bugs] [Bug 15522] New interface for revamped circulation rules In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15522 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=13720 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 6 15:52:06 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Jan 2020 14:52:06 +0000 Subject: [Koha-bugs] [Bug 13721] Apply tag to all versions/formats of a title In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13721 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|apply tags to all titles |Apply tag to all | |versions/formats of a title CC| |katrin.fischer at bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 6 15:57:24 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Jan 2020 14:57:24 +0000 Subject: [Koha-bugs] [Bug 13738] Add RESTful Borrower service In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13738 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |FIXED --- Comment #9 from Katrin Fischer --- I believe this has been resolved with the patrons routes? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 6 15:57:25 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Jan 2020 14:57:25 +0000 Subject: [Koha-bugs] [Bug 13737] [OMNIBUS] Add Koha RESTful Services In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13737 Bug 13737 depends on bug 13738, which changed state. Bug 13738 Summary: Add RESTful Borrower service https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13738 What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 6 16:00:39 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Jan 2020 15:00:39 +0000 Subject: [Koha-bugs] [Bug 13742] Object accessor for overduerules- and overduerules_transport_types-tables. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13742 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |WONTFIX Status|ASSIGNED |RESOLVED --- Comment #4 from Katrin Fischer --- Depending bug has been resolved WONTFIX a long time ago and the attached patch here would need a lot of work to fit into our new infrastructure/coding guidelines... marking WONTFIX for now, please reopen if I am mistaken. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 6 16:01:35 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Jan 2020 15:01:35 +0000 Subject: [Koha-bugs] [Bug 13710] add column for patron category on overdue report (overdue.pl) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13710 --- Comment #2 from Marjorie Barry-Vila --- (In reply to Katrin Fischer from comment #1) > This is available now! Hi Katrin, This is available in 19.05? I don't see the category of the patron in the table? Maybe you are talking about the filter on the category that is available? Regards Marjorie -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Jan 6 16:02:08 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Jan 2020 15:02:08 +0000 Subject: [Koha-bugs] [Bug 13710] add column for patron category on overdue report (overdue.pl) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13710 --- Comment #3 from Marjorie Barry-Vila --- Created attachment 96837 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96837&action=edit overdue.pl -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Jan 6 16:06:46 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Jan 2020 15:06:46 +0000 Subject: [Koha-bugs] [Bug 13752] Item level holds crossed if item moved to another bib In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13752 --- Comment #3 from Katrin Fischer --- Wondering: if you move the order using the transfer option, the biblionumber would not change. There must be another step we are missing? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Jan 6 16:09:27 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Jan 2020 15:09:27 +0000 Subject: [Koha-bugs] [Bug 13756] Holds over date In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13756 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |FIXED CC| |katrin.fischer at bsz-bw.de --- Comment #2 from Katrin Fischer --- (In reply to Christopher Brannon from comment #0) > Would like to see hold over date calculated at time of hold and recorded in > the requests table with the hold. As I understand it, holds over dates are > calculated when the holds over table is looked at. This is a very loose > calculation, since if the value of ReservesMaxPickUpDelay is changed at any > time, the holds over period changes with that, regardless of when the hold > was filled. Some libraries may prefer to have that date fixed in place on > the table, while others might want the fluid, on the spot calculation, so > perhaps it should be an option. > > For me, as someone dealing with consistency and reports, a fixed date in the > table is preferred. It would be great to be able to run custom reports and > see those dates. It would be great to have that date show in the holds > information for both item and patron screens on the staff side. It would be > great to be able to print that date on the hold slips. It would be great to > know that if we let patrons know how long they have to pick something up, > that won't change because an adjustment is made to ReservesMaxPickUpDelay > (although, how often does that happen?). > > My two cents. > > Christopher I believe this is all resolved - the 'hold pickup expiration date' is saved to reserves.expirationdate (currently overwriting a 'not needed after' date set by the patron) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 6 16:19:08 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Jan 2020 15:19:08 +0000 Subject: [Koha-bugs] [Bug 24347] Add a 'search to order' option similar to 'search to hold' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24347 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Medium patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 6 16:19:11 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Jan 2020 15:19:11 +0000 Subject: [Koha-bugs] [Bug 24347] Add a 'search to order' option similar to 'search to hold' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24347 --- Comment #2 from Owen Leonard --- Created attachment 96838 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96838&action=edit Bug 24347: Add a 'search to order' option similar to 'search to hold' This patch modifes the process of searching for an existing record to add to a basket. Now the search is performed as a keyword search in the regular catalog rather than via a custom search script. Options are added to the search results and detail pages to add results to an order. This process follows the same pattern as the "Search to hold" feature: When the search is initiated, a cookie is set with the requisite information--in this case vendor id and basket number. If the search results or bibliographic detail pages detect that a "searchToOrder" cookie is present, the correct "Add order" link will be shown. Like with the "search to hold" feature, the cookie expires in 10 minutes. To test, apply the patch and log into the staff client as a user who has permission to add to a basket in acquisitions. - Go to Acquisitions -> Vendor -> Basket -> Add to basket. - Using the "From an existing record" option, perform a search. - On the search results page, test the "Add order" link which appears with each result. Clicking the link should take you to the "New order" page for the correct vendor and basket. The catalog details section of the form should include the correct information. - From the search results page view the bibliographic details page for any record. There should be a new toolbar button, "Add order." Verify that it works correctly. - Test the same thing from all bibliographic detail pages: Normal, MARC, Labeled MARC, ISBD, as well as the items page (moredetail.pl). - Test this process for both the locations in acquisitions where one can add to an existing basket: Vendor search results and the basket detail page - Test the cookie timeout: Wait 10 minutes and perform another catalog search. The "Add order" link should no longer be present. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 6 16:19:13 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Jan 2020 15:19:13 +0000 Subject: [Koha-bugs] [Bug 24347] Add a 'search to order' option similar to 'search to hold' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24347 --- Comment #3 from Owen Leonard --- Created attachment 96839 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96839&action=edit Bug 24347: (follow-up) Remove custom catalog search from acquisitions This patch removes the "neworderbiblio" script and template which are made obsolete by the "search to order" feature. deleted: acqui/neworderbiblio.pl deleted: koha-tmpl/intranet-tmpl/prog/en/modules/acqui/neworderbiblio.tt Some documentation in addorder.pl has been corrected to remove reference to neworderbiblio.pl. To test, apply the patch and verify that the correct files have been removed. Search the Koha codebase to verify that no links to acqui/neworderbiblio.pl remain. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 6 16:19:25 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Jan 2020 15:19:25 +0000 Subject: [Koha-bugs] [Bug 24347] Add a 'search to order' option similar to 'search to hold' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24347 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |23944 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23944 [Bug 23944] Phase out use of jquery.cookie.js in favor of js.cookie.js -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 6 16:19:25 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Jan 2020 15:19:25 +0000 Subject: [Koha-bugs] [Bug 23944] Phase out use of jquery.cookie.js in favor of js.cookie.js In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23944 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |24347 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24347 [Bug 24347] Add a 'search to order' option similar to 'search to hold' -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 6 16:24:12 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Jan 2020 15:24:12 +0000 Subject: [Koha-bugs] [Bug 24352] New: OpacItemLocation is buggy Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24352 Bug ID: 24352 Summary: OpacItemLocation is buggy Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org The different settings from the OpacItemLocation don't appear to work correctly. When "collection" is selected, collection is not visible, but a label 'Location(s)' shows up? The callnumber never showed for me in my testing? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 6 16:24:46 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Jan 2020 15:24:46 +0000 Subject: [Koha-bugs] [Bug 13848] XSLT and OpacItemLocation sys pref In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13848 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED CC| |katrin.fischer at bsz-bw.de Resolution|--- |WORKSFORME --- Comment #6 from Katrin Fischer --- At the moment I can't replicate the callnumber issue on master, but have filed bug 24352 to deal with some other oddity. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 6 16:26:03 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Jan 2020 15:26:03 +0000 Subject: [Koha-bugs] [Bug 24353] New: privacy_guarantor_checkouts incorrectly shows No on moremember.pl Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24353 Bug ID: 24353 Summary: privacy_guarantor_checkouts incorrectly shows No on moremember.pl Change sponsored?: --- Product: Koha Version: 19.05 Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Patrons Assignee: koha-bugs at lists.koha-community.org Reporter: andrew at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com To Test: - find/create a patron with a guarantor - Set AllowStaffToSetCheckoutsVisibilityForGuarantor and AllowPatronToSetCheckoutsVisibilityForGuarantor to Allow - Edit patron to set Show Checkouts to Guarantor to Yes - Confirm patron incorrectly shows "No" on moremember.pl - Confirm patron correctly shows "Yes" on memberentry.pl and opac-privacy.pl - Confirm patron correctly shows privacy_guarantor_checkouts=1 in database -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 6 16:28:31 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Jan 2020 15:28:31 +0000 Subject: [Koha-bugs] [Bug 13883] Add sample notices for TalkingTechItiva In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13883 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|TalkingTechItiva |Add sample notices for |housekeeping |TalkingTechItiva -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 6 16:30:02 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Jan 2020 15:30:02 +0000 Subject: [Koha-bugs] [Bug 13900] Records are not showing after zebra indexing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13900 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |INVALID CC| |katrin.fischer at bsz-bw.de --- Comment #1 from Katrin Fischer --- This is a very old support request - hopefully resolved elsewhere. Closing. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 6 16:30:22 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Jan 2020 15:30:22 +0000 Subject: [Koha-bugs] [Bug 24351] During Installation, connection to remote mysql server fails In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24351 --- Comment #1 from Seema Albal --- Error message mentions it can't connect to local server while the SQL server is remote. mainpage.pl: DBI connect('database=koha_libraryname;host=localhost;port=3306','koha_libraryname',...) failed: Can't connect to local MySQL server through socket '/var/run/mysqld/mysqld.sock' (2 "No such file or directory") at /usr/share/perl5/DBIx/Class/Storage/DBI.pm line 1517.: /usr/share/koha/intranet/cgi-bin/mainpage.pl -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Jan 6 16:31:04 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Jan 2020 15:31:04 +0000 Subject: [Koha-bugs] [Bug 24321] Make objects.search use mappings from Koha::Object(s) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24321 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #96744|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 6 16:31:06 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Jan 2020 15:31:06 +0000 Subject: [Koha-bugs] [Bug 24321] Make objects.search use mappings from Koha::Object(s) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24321 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #96711|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 6 16:31:09 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Jan 2020 15:31:09 +0000 Subject: [Koha-bugs] [Bug 24321] Make objects.search use mappings from Koha::Object(s) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24321 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #96712|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 6 16:31:12 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Jan 2020 15:31:12 +0000 Subject: [Koha-bugs] [Bug 24321] Make objects.search use mappings from Koha::Object(s) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24321 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #96713|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 6 16:31:14 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Jan 2020 15:31:14 +0000 Subject: [Koha-bugs] [Bug 24321] Make objects.search use mappings from Koha::Object(s) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24321 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #96714|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 6 16:31:16 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Jan 2020 15:31:16 +0000 Subject: [Koha-bugs] [Bug 24321] Make objects.search use mappings from Koha::Object(s) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24321 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #96715|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 6 16:31:18 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Jan 2020 15:31:18 +0000 Subject: [Koha-bugs] [Bug 24321] Make objects.search use mappings from Koha::Object(s) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24321 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #96716|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 6 16:31:21 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Jan 2020 15:31:21 +0000 Subject: [Koha-bugs] [Bug 24321] Make objects.search use mappings from Koha::Object(s) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24321 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #96717|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 6 16:31:23 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Jan 2020 15:31:23 +0000 Subject: [Koha-bugs] [Bug 24321] Make objects.search use mappings from Koha::Object(s) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24321 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #96718|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 6 16:31:25 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Jan 2020 15:31:25 +0000 Subject: [Koha-bugs] [Bug 24321] Make objects.search use mappings from Koha::Object(s) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24321 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #96719|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 6 16:31:28 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Jan 2020 15:31:28 +0000 Subject: [Koha-bugs] [Bug 24321] Make objects.search use mappings from Koha::Object(s) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24321 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #96720|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 6 16:31:30 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Jan 2020 15:31:30 +0000 Subject: [Koha-bugs] [Bug 24321] Make objects.search use mappings from Koha::Object(s) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24321 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #96721|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 6 16:31:33 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Jan 2020 15:31:33 +0000 Subject: [Koha-bugs] [Bug 24321] Make objects.search use mappings from Koha::Object(s) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24321 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #96722|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 6 16:32:30 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Jan 2020 15:32:30 +0000 Subject: [Koha-bugs] [Bug 24321] Make objects.search use mappings from Koha::Object(s) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24321 --- Comment #23 from Tomás Cohen Arazi --- Created attachment 96840 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96840&action=edit Bug 24321: Add Koha::Objects->attributes_from_api This patch makes the 'attributes_from_api' method from the singular class available from the result set class. To test: 1. Apply this patch 2. Run: $ kshell k$ prove t/db_dependent/Koha/Objects.t => SUCCESS: Tests pass! 4. Sign off :-D 5. Yeah, I skipped 3 :-P -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 6 16:32:33 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Jan 2020 15:32:33 +0000 Subject: [Koha-bugs] [Bug 24321] Make objects.search use mappings from Koha::Object(s) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24321 --- Comment #24 from Tomás Cohen Arazi --- Created attachment 96841 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96841&action=edit Bug 24321: Make dbic_merge_sorting accept a result set as parameter This patch makes dbic_merge_sorting accept a result set as parameter and solves a FIXME in _build_order_atom. To test: 1. Apply this patch 2. Run: $ kshell k$ prove t/Koha/REST/Plugin/Query.t => SUCCESS: Tests pass! 3. Sign off :-D -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 6 16:32:38 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Jan 2020 15:32:38 +0000 Subject: [Koha-bugs] [Bug 24321] Make objects.search use mappings from Koha::Object(s) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24321 --- Comment #25 from Tomás Cohen Arazi --- Created attachment 96842 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96842&action=edit Bug 24321: Make objects.search use mappings from Koha::Object(s) This patch simplifies the objects.search helper so it relies entirely on the result set object for the attribute mappings. The result is no more to_api or to_model mappings are passed. The controllers need to be cleaned up after this patch. To test: 1. Apply this patch 2. Run: $ kshell k$ prove t/db_dependent/Koha/REST/Plugin/Objects.t => SUCCESS: Tests pass! 3. Sign off :-D Note: the original version of this helpers accepted arbitrary mappings and are now constrianed to real mappings on the Koha::Object level. As such, the number of tests got reduced. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 6 16:32:42 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Jan 2020 15:32:42 +0000 Subject: [Koha-bugs] [Bug 24321] Make objects.search use mappings from Koha::Object(s) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24321 --- Comment #26 from Tomás Cohen Arazi --- Created attachment 96843 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96843&action=edit Bug 24321: Clean /cities -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 6 16:32:46 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Jan 2020 15:32:46 +0000 Subject: [Koha-bugs] [Bug 24321] Make objects.search use mappings from Koha::Object(s) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24321 --- Comment #27 from Tomás Cohen Arazi --- Created attachment 96844 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96844&action=edit Bug 24321: Clean /acquisitions/funds -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 6 16:32:50 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Jan 2020 15:32:50 +0000 Subject: [Koha-bugs] [Bug 24321] Make objects.search use mappings from Koha::Object(s) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24321 --- Comment #28 from Tomás Cohen Arazi --- Created attachment 96845 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96845&action=edit Bug 24321: Clean /acquisitions/vendors -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 6 16:32:54 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Jan 2020 15:32:54 +0000 Subject: [Koha-bugs] [Bug 24321] Make objects.search use mappings from Koha::Object(s) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24321 --- Comment #29 from Tomás Cohen Arazi --- Created attachment 96846 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96846&action=edit Bug 24321: Clean /libraries -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 6 16:32:59 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Jan 2020 15:32:59 +0000 Subject: [Koha-bugs] [Bug 24321] Make objects.search use mappings from Koha::Object(s) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24321 --- Comment #30 from Tomás Cohen Arazi --- Created attachment 96847 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96847&action=edit Bug 24321: Clean /checkouts -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 6 16:33:02 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Jan 2020 15:33:02 +0000 Subject: [Koha-bugs] [Bug 24321] Make objects.search use mappings from Koha::Object(s) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24321 --- Comment #31 from Tomás Cohen Arazi --- Created attachment 96848 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96848&action=edit Bug 24321: Clean /biblios -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 6 16:33:06 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Jan 2020 15:33:06 +0000 Subject: [Koha-bugs] [Bug 24321] Make objects.search use mappings from Koha::Object(s) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24321 --- Comment #32 from Tomás Cohen Arazi --- Created attachment 96849 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96849&action=edit Bug 24321: Clean /items -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 6 16:33:10 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Jan 2020 15:33:10 +0000 Subject: [Koha-bugs] [Bug 24321] Make objects.search use mappings from Koha::Object(s) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24321 --- Comment #33 from Tomás Cohen Arazi --- Created attachment 96850 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96850&action=edit Bug 24321: Clean /patrons/{patron_id}/account -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 6 16:33:14 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Jan 2020 15:33:14 +0000 Subject: [Koha-bugs] [Bug 24321] Make objects.search use mappings from Koha::Object(s) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24321 --- Comment #34 from Tomás Cohen Arazi --- Created attachment 96851 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96851&action=edit Bug 24321: Clean /holds -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 6 16:33:17 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Jan 2020 15:33:17 +0000 Subject: [Koha-bugs] [Bug 24321] Make objects.search use mappings from Koha::Object(s) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24321 --- Comment #35 from Tomás Cohen Arazi --- Created attachment 96852 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96852&action=edit Bug 24321: Clean /patrons -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 6 16:35:18 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Jan 2020 15:35:18 +0000 Subject: [Koha-bugs] [Bug 13710] add column for patron category on overdue report (overdue.pl) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13710 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|FIXED |DUPLICATE --- Comment #4 from Katrin Fischer --- Hi Marjorie, I am sorry, I thought that had made it into 19.05 when I was testing earlier - it's resolved by bug 21852 that will be in 19.11. Marking as duplicate now in this case. *** This bug has been marked as a duplicate of bug 21852 *** -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Jan 6 16:35:18 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Jan 2020 15:35:18 +0000 Subject: [Koha-bugs] [Bug 21852] Add more columns and column configuration to overdues report In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21852 --- Comment #36 from Katrin Fischer --- *** Bug 13710 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 6 16:37:31 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Jan 2020 15:37:31 +0000 Subject: [Koha-bugs] [Bug 24321] Make objects.search use mappings from Koha::Object(s) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24321 --- Comment #36 from Tomás Cohen Arazi --- Rebased on top of bug 21684 which is in master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 6 16:38:13 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Jan 2020 15:38:13 +0000 Subject: [Koha-bugs] [Bug 13710] add column for patron category on overdue report (overdue.pl) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13710 --- Comment #5 from Marjorie Barry-Vila --- (In reply to Katrin Fischer from comment #4) > Hi Marjorie, I am sorry, I thought that had made it into 19.05 when I was > testing earlier - it's resolved by bug 21852 that will be in 19.11. Marking > as duplicate now in this case. > > *** This bug has been marked as a duplicate of bug 21852 *** Great! Thank you, Marjorie -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Jan 6 16:39:30 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Jan 2020 15:39:30 +0000 Subject: [Koha-bugs] [Bug 13925] koha-restore doesn't start Zebra In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13925 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Version|3.18 |master --- Comment #3 from Katrin Fischer --- (In reply to Rudolf Byker from comment #2) > This is still the case in 2019. But I'm not sure if it's a bug. Zebra may be > started as follows: > > sudo koha-zebra --start "${INSTANCE}" I am not sure about it being a bug either - but maybe we could add a note to the output? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 6 16:41:27 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Jan 2020 15:41:27 +0000 Subject: [Koha-bugs] [Bug 12090] Disabling Library Location In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12090 --- Comment #4 from Christopher Brannon --- (In reply to Katrin Fischer from comment #2) > Just a ntoe: there is HoldsQueueSkipClosed now that might help with some of > the issues mentioned. This is a tricky preference. I'm not finding sufficient information on it. If this option is set to closed, is the hold queue re-evaluated and a hold moved over to a library if it becomes open while the hold is still in a request state? For example: Library A & B have book in question. Library A is closed 3 days out of the week, but is the closer library. Book goes on hold the last of the 3 days library A is closed, and goes into library B's queue. The next day, both libraries are open, and the hold hasn't been filled yet. Does the hold request move to library A the next day, or does is stay stuck to library B? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 6 16:42:18 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Jan 2020 15:42:18 +0000 Subject: [Koha-bugs] [Bug 13953] Bad QueryParser YAML config + old version of YAML::XS can cause segfault In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13953 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |12742 CC| |katrin.fischer at bsz-bw.de Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12742 [Bug 12742] Omnibus: QueryParser -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 6 16:42:18 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Jan 2020 15:42:18 +0000 Subject: [Koha-bugs] [Bug 12742] Omnibus: QueryParser In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12742 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |13953 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13953 [Bug 13953] Bad QueryParser YAML config + old version of YAML::XS can cause segfault -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 6 16:43:14 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Jan 2020 15:43:14 +0000 Subject: [Koha-bugs] [Bug 13956] Add budget information to funds pull down on creating an order In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13956 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Add budget information to |Add budget information to |funds pull down on crating |funds pull down on creating |an order |an order -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Jan 6 16:46:56 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Jan 2020 15:46:56 +0000 Subject: [Koha-bugs] [Bug 24176] Make datelastborrowed a column in holdings_table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24176 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |lucas at bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 6 16:48:19 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Jan 2020 15:48:19 +0000 Subject: [Koha-bugs] [Bug 13978] Add cancellation link to hold notification e-mails In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13978 --- Comment #2 from Katrin Fischer --- I think achieving this without having to log in first is the harder bit, because you want a link that cannot be guessed and misused by someone else. You'd need a token or similar that only the email recipient and Koha know. A link into the catalog would be easier. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Jan 6 16:48:22 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Jan 2020 15:48:22 +0000 Subject: [Koha-bugs] [Bug 12225] SIP does not respect the "no block" flag In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12225 --- Comment #7 from Colin Campbell --- (In reply to Katrin Fischer from comment #6) > Hi Colin, could you give an update here? Is the old patch something that > could be reused or should we obsolete it? think the old patch is still valid, I'll set up a test against a current system to confirm. I think some of the effects of the underlying problem are worked around by some later changes -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 6 16:50:37 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Jan 2020 15:50:37 +0000 Subject: [Koha-bugs] [Bug 13983] Title shows doubled up in fine description In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13983 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |WONTFIX Status|NEW |RESOLVED --- Comment #3 from Katrin Fischer --- This is a very old issue by now - I am marking it resolved WONTFIX because I tihnk it was due to old data. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Jan 6 16:52:16 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Jan 2020 15:52:16 +0000 Subject: [Koha-bugs] [Bug 13988] Log activities related to Acquisitions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13988 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |MOVED --- Comment #2 from Katrin Fischer --- I feel this bug is a bit too general - there are some newer bugs making a start on this like bug 24190. Closing in favor of the more granular approach. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Jan 6 16:54:09 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Jan 2020 15:54:09 +0000 Subject: [Koha-bugs] [Bug 12225] SIP does not respect the "no block" flag In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12225 --- Comment #8 from Katrin Fischer --- Thx! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 6 16:54:28 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Jan 2020 15:54:28 +0000 Subject: [Koha-bugs] [Bug 24354] New: Add public API for library information Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24354 Bug ID: 24354 Summary: Add public API for library information Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: REST API Assignee: koha-bugs at lists.koha-community.org Reporter: oleonard at myacpl.org It would be useful in the OPAC to have access to basic library data like address, phone number, web site, OPAC info, etc. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Jan 6 16:57:52 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Jan 2020 15:57:52 +0000 Subject: [Koha-bugs] [Bug 14010] search by biblionumber on serials In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14010 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #1 from Katrin Fischer --- Is this something more people would be interested in? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 6 17:02:37 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Jan 2020 16:02:37 +0000 Subject: [Koha-bugs] [Bug 12645] Extend Koha::Template::Plugin::Branches for use in masthead.inc In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12645 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard at myacpl.org |koha-bugs at lists.koha-commun | |ity.org -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 6 17:02:51 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Jan 2020 16:02:51 +0000 Subject: [Koha-bugs] [Bug 12645] Extend Koha::Template::Plugin::Branches for use in masthead.inc In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12645 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Component|Templates |OPAC -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 6 17:04:21 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Jan 2020 16:04:21 +0000 Subject: [Koha-bugs] [Bug 24355] New: Holds should note a short loan period when decreaseLoanHighHolds in use and conditions met Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24355 Bug ID: 24355 Summary: Holds should note a short loan period when decreaseLoanHighHolds in use and conditions met Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Hold requests Assignee: koha-bugs at lists.koha-community.org Reporter: cbrannon at cdalibrary.org QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com It seems reasonable to show on circulation.pl holds tab or request.pl, or in the opac itself, if an item will circulate for a shorter length of time (and show how long), if conditions are met in the decreaseLoanHighHolds preferences. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Jan 6 17:26:19 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Jan 2020 16:26:19 +0000 Subject: [Koha-bugs] [Bug 15850] Correct eslint errors in cataloging.js In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15850 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Correct JSHint errors in |Correct eslint errors in |cataloging.js |cataloging.js -- You are receiving this mail because: You are watching all bug changes. You are on the CC list for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Jan 6 17:37:20 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Jan 2020 16:37:20 +0000 Subject: [Koha-bugs] [Bug 24351] During Installation, connection to remote mysql server fails In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24351 --- Comment #2 from Seema Albal --- And this is the error on the browser: Software error: DBIx::Class::Storage::DBI::catch {...} (): DBI Connection failed: Can't connect to local MySQL server through socket '/var/run/mysqld/mysqld.sock' (2 "No such file or directory") at /usr/share/perl5/DBIx/Class/Storage/DBI.pm line 1520. at /usr/share/koha/lib/Koha/Database.pm line 107 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 6 18:09:08 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Jan 2020 17:09:08 +0000 Subject: [Koha-bugs] [Bug 18731] Add routes for acquisition orders In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18731 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95056|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 6 18:09:10 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Jan 2020 17:09:10 +0000 Subject: [Koha-bugs] [Bug 18731] Add routes for acquisition orders In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18731 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95054|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 6 18:09:13 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Jan 2020 17:09:13 +0000 Subject: [Koha-bugs] [Bug 18731] Add routes for acquisition orders In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18731 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95055|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 6 18:10:47 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Jan 2020 17:10:47 +0000 Subject: [Koha-bugs] [Bug 18731] Add routes for acquisition orders In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18731 --- Comment #20 from Tomás Cohen Arazi --- Created attachment 96853 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96853&action=edit Bug 18731: Make authenticate_api_request stash the embed structure -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 6 18:10:51 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Jan 2020 17:10:51 +0000 Subject: [Koha-bugs] [Bug 18731] Add routes for acquisition orders In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18731 --- Comment #21 from Tomás Cohen Arazi --- Created attachment 96854 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96854&action=edit Bug 18731: Unit tests This patch implements unit tests for the orders endpoint. Sponsored-by: Camden County -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 6 18:10:55 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Jan 2020 17:10:55 +0000 Subject: [Koha-bugs] [Bug 18731] Add routes for acquisition orders In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18731 --- Comment #22 from Tomás Cohen Arazi --- Created attachment 96855 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96855&action=edit Bug 18731: OpenAPI definitions This patch introduces the OpenAPI definitions required for the orders endpoint. It matches the voted RFC. Sponsored-by: Camden County Signed-off-by: Matthias Meusburger -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 6 18:10:59 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Jan 2020 17:10:59 +0000 Subject: [Koha-bugs] [Bug 18731] Add routes for acquisition orders In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18731 --- Comment #23 from Tomás Cohen Arazi --- Created attachment 96856 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96856&action=edit Bug 18731: /acquisitions/orders endpoint This patches implement the /acquisitions/orders endpoint. The attribute names are consistent with the voted RFC To test: 1. Apply this patchset 2. Run: $ kshell k$ prove t/db_dependent/api/v1/acquisitions_orders.t => SUCCESS: Tests pass! 3. Test the API with your favourite tool (Postman?) => SUCCESS: It works as expected! 4 Sign off :-D Sponsored-by: Camden County Signed-off-by: Matthias Meusburger -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 6 18:11:03 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Jan 2020 17:11:03 +0000 Subject: [Koha-bugs] [Bug 18731] Add routes for acquisition orders In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18731 --- Comment #24 from Tomás Cohen Arazi --- Created attachment 96857 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96857&action=edit Bug 18731: Add API mappings to K::A::{Basket,Invoice} This patch adds to_api_mapping definitions to the following classes: - Koha::Acquisition::Basket - Koha::Acquisition::Invoice They are implemented following the proposed RFCs: https://wiki.koha-community.org/wiki/Acquisitions_baskets_endpoint_RFC https://wiki.koha-community.org/wiki/Acquisitions_invoices_endpoint_RFC -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 6 18:11:08 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Jan 2020 17:11:08 +0000 Subject: [Koha-bugs] [Bug 18731] Add routes for acquisition orders In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18731 --- Comment #25 from Tomás Cohen Arazi --- Created attachment 96858 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96858&action=edit Bug 18731: Use the stashed koha.embed in objects.search This patch makes the objects.search helper use the koha.embed structure that is embedded in the authenticate_api_request step. This way, any controller using it will benefit from automatic embed handling. To test: 1. Apply this patch 2. Run: $ kshell k$ prove t/db_dependent/Koha/REST/Plugin/Objects.t => SUCCESS: Tests pass! 3. Sign off :-D -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 6 18:13:54 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Jan 2020 17:13:54 +0000 Subject: [Koha-bugs] [Bug 18731] Add routes for acquisition orders In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18731 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 6 18:18:02 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Jan 2020 17:18:02 +0000 Subject: [Koha-bugs] [Bug 18731] Add routes for acquisition orders In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18731 --- Comment #26 from Tomás Cohen Arazi --- I've set this back to NSO as I introduced some important changes. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 6 18:21:40 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Jan 2020 17:21:40 +0000 Subject: [Koha-bugs] [Bug 15850] Correct eslint errors in cataloging.js In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15850 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are on the CC list for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 6 18:21:43 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Jan 2020 17:21:43 +0000 Subject: [Koha-bugs] [Bug 15850] Correct eslint errors in cataloging.js In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15850 --- Comment #1 from Owen Leonard --- Created attachment 96859 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96859&action=edit Bug 15850: Correct eslint errors in cataloging.js This patch makes corrections to cataloging.js so that there are no issues flagged by eslint. The fewer eslint warnings we have to see makes it more likely that real problems will be noticed. Some functions were unused have been removed. To test, apply the patch and clear your browser cache if necessary. - Open a MARC record for editing in the basic cataloging editor. - Test the JavaScript-driven functionality affected by the changed file: - Open the authority browser from a field (e.g. 100a) which is linked to an authority type. - Clone a repeatable tag. - Clone a repeatable subfield - "Unclone" a tag or subfield: This should remove the tag or subfield (if possible) or clear the contents of the tag or subfield if not. - Clone a subfield on the item edit page (In my MARC21 installation I had to modify the default framework in order to have a repeatable item subfield to test with). -- You are receiving this mail because: You are watching all bug changes. You are on the CC list for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Jan 6 18:30:49 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Jan 2020 17:30:49 +0000 Subject: [Koha-bugs] [Bug 13491] make Selfcheck follow the CircAutoPrintQuickSlip In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13491 --- Comment #2 from Peggy Thrasher --- Could we change the SelfCheckReceiptPrompt to give the option of not displaying, choosing a quick slip, or choosing a complete slip? We always provide the complete slip, and our selfcheck patrons get confused when they get a quick slip. We just want the option to give them a complete slip from the selfcheck station. Thanks Peggy -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Jan 6 19:17:15 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Jan 2020 18:17:15 +0000 Subject: [Koha-bugs] [Bug 24356] New: objects.search prefetch Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24356 Bug ID: 24356 Summary: objects.search prefetch Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs at lists.koha-community.org Reporter: tomascohen at gmail.com QA Contact: testopia at bugs.koha-community.org It would be great if objects.search added the prefetch automatically when an embed action is requested. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 6 19:17:35 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Jan 2020 18:17:35 +0000 Subject: [Koha-bugs] [Bug 24356] objects.search prefetch In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24356 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |24321 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24321 [Bug 24321] Make objects.search use mappings from Koha::Object(s) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 6 19:17:35 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Jan 2020 18:17:35 +0000 Subject: [Koha-bugs] [Bug 24321] Make objects.search use mappings from Koha::Object(s) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24321 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |24356 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24356 [Bug 24356] objects.search prefetch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 6 20:24:42 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Jan 2020 19:24:42 +0000 Subject: [Koha-bugs] [Bug 24351] During Installation, connection to remote mysql server fails In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24351 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david at davidnind.com --- Comment #3 from David Nind --- Hopefully this will point you in the right direction to solve the problem you are having: https://wiki.koha-community.org/wiki/Install_Koha_3.6_on_Debian_squeeze_using_a_separate_MySQL_server While it mentions Koha 3.6 I think it is still mostly correct. Instead of using the sudo koha-create --create-db command you need to follow these steps: 1. sudo koha-create --request-db 2. Follow the instructions in the file created: create the database with the user name and password on your remote database server and set the required permissions. 3. Test that you can connect to the remote mysql server from your Koha server, for example: sudo mysql -u -p -h . (Some database servers may be setup to not allow remote access, you will need to sort that out. You will need to install the database client packages on your Koha server.) 4. Populate the database: koha-create --populate-db 5. Carry on with your Koha installation... If this doesn't work, I would post a message to the Koha mailing list or try the IRC channel. If it does work, please post a comment as appropriate. Notes: * You may need to revert any changes you may have made, such as changes to my.cnf or Apache * You will need to delete the instance you have created: sudo koha-remove * I assume you didn't mean you were installing on Debian 4.9 (a very very old version of Debian) * I will look at testing these steps properly when I get a chance and incorporating these instructions or updating them into the main guide available at https://wiki.koha-community.org/wiki/Koha_on_Debian -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 6 20:26:50 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Jan 2020 19:26:50 +0000 Subject: [Koha-bugs] [Bug 24351] During Installation, connection to remote mysql server fails In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24351 --- Comment #4 from Katrin Fischer --- Hi Seema, you can try to restart Plack and Memcached to make sure that your changes to the configuration files have taken effect. But this should be really discussed on the mailing list as it's a installation/setup issue and probably not a bug: https://koha-community.org/support/koha-mailing-lists/ It will also mean a lot more people are reading and will be able to help out - only very few of us are reading all the new bugs :) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Jan 6 20:27:05 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Jan 2020 19:27:05 +0000 Subject: [Koha-bugs] [Bug 24351] During Installation, connection to remote mysql server fails In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24351 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Version|19.11 |19.05 Resolution|--- |INVALID Status|NEW |RESOLVED -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 6 21:35:30 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Jan 2020 20:35:30 +0000 Subject: [Koha-bugs] [Bug 24131] Improved formatting for output of updatedatabase In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24131 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=14073 CC| |katrin.fischer at bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Jan 6 21:35:30 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Jan 2020 20:35:30 +0000 Subject: [Koha-bugs] [Bug 14073] HTML tags not working in database update message In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14073 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=24131 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 6 21:41:56 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Jan 2020 20:41:56 +0000 Subject: [Koha-bugs] [Bug 14080] Cancelled orders should show on invoice In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14080 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|cancelled orders should |Cancelled orders should |show on invoice |show on invoice --- Comment #2 from Katrin Fischer --- (In reply to Nicole C. Engard from comment #0) > Created attachment 38672 [details] > cancelled on basket only > > Right now if you cancel an order it doesn't show under on the receiving page > as a confirmation (under already received would make sense) and it doesn't > show on the invoice. This item can only be seen in the basket, but most > people want to know what was cancelled on their invoice. > > Side note - you also can't find it by doing an order search. This can't quite work as suggested, as there is no link between the invoice and the cancelled orders. You'd have to somehow make that link manually after it was cancelled (when it's cancelled before receiving from the basket page) or we could make the link when it's cancelled from the receive page. But I wonder if that is really necessary? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 6 21:49:43 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Jan 2020 20:49:43 +0000 Subject: [Koha-bugs] [Bug 14083] Make it possible to record the date the order was placed/sent to the vendor In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14083 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|new acq date field |Make it possible to record | |the date the order was | |placed/sent to the vendor -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 6 21:52:41 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Jan 2020 20:52:41 +0000 Subject: [Koha-bugs] [Bug 14085] Search for biblionumber in acquisitions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14085 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=14010 Summary|search biblionumber in |Search for biblionumber in |acquisitions |acquisitions CC| |katrin.fischer at bsz-bw.de -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 6 21:52:41 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Jan 2020 20:52:41 +0000 Subject: [Koha-bugs] [Bug 14010] search by biblionumber on serials In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14010 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=14085 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Jan 6 21:53:59 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Jan 2020 20:53:59 +0000 Subject: [Koha-bugs] [Bug 21187] GDPR: Force patrons password renew In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21187 --- Comment #1 from Marjorie Barry-Vila --- +1 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Jan 6 21:54:57 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Jan 2020 20:54:57 +0000 Subject: [Koha-bugs] [Bug 24191] Sorting doesn't use to_model In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24191 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas at bywatersolutions.com Status|Pushed to stable |Pushed to oldstable --- Comment #13 from Lucas Gass --- backported to 19.05.x for 19.05.07 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 6 21:59:02 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Jan 2020 20:59:02 +0000 Subject: [Koha-bugs] [Bug 23112] Circulation of ILL items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23112 --- Comment #48 from Jonathan Druart --- (In reply to Andrew Isherwood from comment #46) > > ::: Koha/Illrequest.pm > > @@ +1211,5 @@ > > > + # For some reason, AddIssue requires an unblessed Patron > > > + $issue_args[0] = $patron->unblessed; > > > + my $issue = C4::Circulation::AddIssue(@issue_args); > > > + > > > + if ($issue && %{$issue}) { > > > > AddIssue return a Koha::Checkout object. The test will work but I think it's > > confusing. > > Do you mean the variable name $issue is confusing? If so, I thought it made > sense since the function returning it is called AddIssue and, internally, > AddIssue also calls the returned value $issue. You should only test for $issue, the "&& %$issue" does not make sense to me. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 6 21:59:14 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Jan 2020 20:59:14 +0000 Subject: [Koha-bugs] [Bug 24090] Subfield text in red when mandatory in record edition In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24090 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas at bywatersolutions.com Status|Pushed to stable |Pushed to oldstable --- Comment #7 from Lucas Gass --- backported to 19.05.x for 19.05.07 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 6 22:20:13 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Jan 2020 21:20:13 +0000 Subject: [Koha-bugs] [Bug 15751] Koha offline circulation Firefox addon does not update last seen date for check-ins In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15751 Michal Denar changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |black23 at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 6 22:20:24 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Jan 2020 21:20:24 +0000 Subject: [Koha-bugs] [Bug 24350] Can't place holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24350 --- Comment #2 from Jonathan Druart --- Created attachment 96860 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96860&action=edit Bug 24350: Fix Branches.pickup_locations This will fix the following error: Template process failed: undef error - Not a HASH reference at /home/vagrant/kohaclone/Koha/Template/Plugin/Branches.pm line 96. at /home/vagrant/kohaclone/C4/Templates.pm line 122 Koha::Libraries->pickup_locations does not always return an array, but arrayref if $biblio is not a Koha::Biblio object. I do not think it's the correct fix, the pattern in Koha::Libraries->pickup_locations is wrong: we should not expect 2 different types for a given parameter, biblio should always be a Koha::Biblio (idem for item btw). That could be fixed easily if the template had the Koha::Biblio object sent. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 6 22:23:00 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Jan 2020 21:23:00 +0000 Subject: [Koha-bugs] [Bug 24357] New: Hide checkout box when OverduesBlockCirc is set to Block Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24357 Bug ID: 24357 Summary: Hide checkout box when OverduesBlockCirc is set to Block Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs at lists.koha-community.org Reporter: caroline.cyr-la-rose at inlibro.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com Created attachment 96861 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96861&action=edit patron with overdue items If OverduesBlockCirc is set to Block, the checkout box appears in the user's patron file. We can scan the barcode, but only after the item is scanned there is a message saying the patron cannot check out. If NoIssuesCharge is enabled, and the patron owes more than the amount specified, the check out box does not appear at all. Instead, there is a message saying Cannot check out. I think if OverduesBlockCirc is set to Block, the checkout box should be hidden, with a message Cannot check out Patron has overdue items, etc... See screenshots 1) patron with overdue items 2) warning saying that patron cannot checkout after I've already scanned the item's barcode 3) patron with charges over the amount in NoIssuesCharge -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 6 22:23:35 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Jan 2020 21:23:35 +0000 Subject: [Koha-bugs] [Bug 24357] Hide checkout box when OverduesBlockCirc is set to Block In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24357 --- Comment #1 from Caroline Cyr La Rose --- Created attachment 96862 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96862&action=edit warning saying that patron cannot checkout after I've already scanned the item's barcode -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 6 22:23:55 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Jan 2020 21:23:55 +0000 Subject: [Koha-bugs] [Bug 13420] Holdings table sorting on volume information incorrect In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13420 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Needs Signoff --- Comment #22 from Jonathan Druart --- (In reply to Katrin Fischer from comment #21) > Should we change this to 'Needs Signoff' to get some opinions? Yes, done. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 6 22:24:03 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Jan 2020 21:24:03 +0000 Subject: [Koha-bugs] [Bug 24357] Hide checkout box when OverduesBlockCirc is set to Block In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24357 --- Comment #2 from Caroline Cyr La Rose --- Created attachment 96863 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96863&action=edit patron with charges over the amount in NoIssuesCharge -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 6 22:29:27 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Jan 2020 21:29:27 +0000 Subject: [Koha-bugs] [Bug 24247] Button fixes for OPAC lists pages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24247 Michal Denar changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 6 22:29:30 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Jan 2020 21:29:30 +0000 Subject: [Koha-bugs] [Bug 24247] Button fixes for OPAC lists pages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24247 Michal Denar changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #96351|0 |1 is obsolete| | --- Comment #2 from Michal Denar --- Created attachment 96864 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96864&action=edit Bug 24247: Button fixes for OPAC lists pages This patch makes minor markup changes to the OPAC lists page so that link and form controls are styled consistently. To test you should have virtualshelves and OpacAllowSharingPrivateLists enabled. - Apply the patch and log in to the OPAC. - Create a new private list. - When you view the list of your private lists, the "Share" link should have a Font Awesome icon. - View the contents of your list. The "Share" link in the list toolbar should have the same icon. The "New list" link should have a + icon. Signed-off-by: Michal Denar -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 6 22:30:19 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Jan 2020 21:30:19 +0000 Subject: [Koha-bugs] [Bug 12638] UTF-8 support; C4::Members::AttributeTypes::GetAttributeTypes_hashref should be rewrite In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12638 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=20443 Resolution|--- |LATER --- Comment #6 from Jonathan Druart --- (In reply to Katrin Fischer from comment #5) > Is this still an issue now (5 and something years later) or could it be > closed? Still an issue for old version of Perl I'd say. Will be fixed by bug 20443. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 6 22:30:19 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Jan 2020 21:30:19 +0000 Subject: [Koha-bugs] [Bug 20443] Move C4::Members::Attributes to Koha namespace In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20443 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=12638 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 6 22:30:46 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Jan 2020 21:30:46 +0000 Subject: [Koha-bugs] [Bug 21232] Problems when linking a subscription to a non-existing biblionumber In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21232 Joy Nelson changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |joy at bywatersolutions.com --- Comment #13 from Joy Nelson --- I've been attempting to push this to 19.11.x and I can apply the patch, but it does not perform as expected. I am not warned that my biblionumber is invalid. I'm not stopped from completing the addition of the serial linked to a 'bad' bibnumber. Any ideas? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 6 22:35:41 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Jan 2020 21:35:41 +0000 Subject: [Koha-bugs] [Bug 24312] Update MARC21 frameworks to Updates 28+29 (May and November 2019) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24312 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 6 22:35:47 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Jan 2020 21:35:47 +0000 Subject: [Koha-bugs] [Bug 24312] Update MARC21 frameworks to Updates 28+29 (May and November 2019) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24312 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #96670|0 |1 is obsolete| | --- Comment #7 from Jonathan Druart --- Created attachment 96865 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96865&action=edit Bug 24312: Update MARC21 frameworks to Updates 28+29 (May and November 2019) MARC21 format changes Bibliographic ------------- Update 28 (May 2019) New subfield f in 540 New subfield g in 506,540 New subfield q in 506,540 New subfield 2 in 540 New subfield 2 in 100,110,111,130,240, 700,710,711,730,758 800,810,811,830 New subfield 7 in 856 New code b in 007/01 Sound Recording Update 29 (November 2019) New field 688 New subfield i in 041 New subfield t in 041 New subfield g in 751 Renamed subfield g in 041 Authority --------- Update 28 (May 2019) New subfield 0 and 1 in 024 Renamed subfield 2 in 024 New subfield 7 in 856 Update 29 (November 2019) No changes To test: 1) Remove all your frameworks 2) Check mandatory bibliographic and authority files load without problem 3) Check new fields/subfields Signed-off-by: Katrin Fischer Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 6 22:36:14 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Jan 2020 21:36:14 +0000 Subject: [Koha-bugs] [Bug 24312] Update MARC21 frameworks to Updates 28+29 (May and November 2019) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24312 --- Comment #8 from Jonathan Druart --- Should be pushed along with bug 24328. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 6 22:39:26 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Jan 2020 21:39:26 +0000 Subject: [Koha-bugs] [Bug 21520] More complex OAI sets mappings In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21520 --- Comment #9 from Jonathan Druart --- (In reply to Matthias Meusburger from comment #7) Why not fix the existing data then? That seems quite easy to do. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 6 22:40:49 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Jan 2020 21:40:49 +0000 Subject: [Koha-bugs] [Bug 21232] Problems when linking a subscription to a non-existing biblionumber In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21232 --- Comment #14 from Joy Nelson --- Must have been a cache issue. A bit of playing with FF and the settings and few hard cache clears and all's well. It's working now. :) joy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 6 22:41:31 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Jan 2020 21:41:31 +0000 Subject: [Koha-bugs] [Bug 24027] Adding multiple items is slow In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24027 Michal Denar changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |black23 at gmail.com --- Comment #13 from Michal Denar --- Hi, any test plan? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 6 22:43:32 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Jan 2020 21:43:32 +0000 Subject: [Koha-bugs] [Bug 21232] Problems when linking a subscription to a non-existing biblionumber In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21232 Joy Nelson changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|20.05.00 |20.05.00, 19.11.02 released in| | Status|Pushed to master |Pushed to stable --- Comment #15 from Joy Nelson --- Pushed to 19.11.x branch for 19.11.02 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 6 22:46:15 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Jan 2020 21:46:15 +0000 Subject: [Koha-bugs] [Bug 23838] Add ability to view item renew history In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23838 --- Comment #35 from Jonathan Druart --- (In reply to Andrew Isherwood from comment #34) Indeed, sorry about that. Looks like I forgot to squash the patches! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 6 22:46:43 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Jan 2020 21:46:43 +0000 Subject: [Koha-bugs] [Bug 21232] Problems when linking a subscription to a non-existing biblionumber In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21232 --- Comment #16 from Katrin Fischer --- Comment on attachment 96576 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96576 Bug 21232: Add a client-side check on biblionumber when creating a subscription Review of attachment 96576: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=21232&attachment=96576) ----------------------------------------------------------------- ::: koha-tmpl/intranet-tmpl/prog/js/subscription-add.js @@ +60,5 @@ > } > > + var bib_exists = $("input[name='title']").val().length; > + > + if (!bib_exists) alert(_("Bibliographic record does not exist!")); This won't translate - got missed before. Can we fix it in a follow-up? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 6 22:48:54 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Jan 2020 21:48:54 +0000 Subject: [Koha-bugs] [Bug 23260] Anonymize (remove) patron data from items_last_borrower In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23260 --- Comment #55 from Jonathan Druart --- Martin, your alternative approach looks good to me! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 6 23:00:12 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Jan 2020 22:00:12 +0000 Subject: [Koha-bugs] [Bug 24357] Hide checkout box when OverduesBlockCirc is set to Block In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24357 --- Comment #3 from Caroline Cyr La Rose --- Steps to reproduce: 1) Go to Administration > Global system preferences 2) Search for OverduesBlockCirc 3) Set to Block 4) Save 5) Search for NoIssuesCharge 6) Enter a small amount, like 5 7) Save 8) Go to a patron's file 9) Make a checkout with a date in the past 10) The checkout box is still available; try to make another checkout; you should get a warning saying this patron cannot checkout 11) Go to another patron's file 12) Add a manual charge that is over the NoIssuesCharge amount, 10 for example 13) Go to the Check out tab; notice the checkout box is not available because the patron has more outstanding charges than is allowed -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Jan 6 23:03:50 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Jan 2020 22:03:50 +0000 Subject: [Koha-bugs] [Bug 14086] date ordered on ordered fund search doesn't match order date In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14086 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #2 from Katrin Fischer --- I disagree in that the date ordered should be the date the basket was closed as that changes the status to 'ordered'. But the problem reported needs a bit more testing. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 6 23:06:12 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Jan 2020 22:06:12 +0000 Subject: [Koha-bugs] [Bug 14088] Show qty on order search In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14088 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=14087 CC| |katrin.fischer at bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Jan 6 23:06:12 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Jan 2020 22:06:12 +0000 Subject: [Koha-bugs] [Bug 14087] show all price fields on order search In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14087 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=14088 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 6 23:06:37 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Jan 2020 22:06:37 +0000 Subject: [Koha-bugs] [Bug 14089] show reason for cancellation on order search results In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14089 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=14087 CC| |katrin.fischer at bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Jan 6 23:06:37 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Jan 2020 22:06:37 +0000 Subject: [Koha-bugs] [Bug 14087] show all price fields on order search In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14087 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=14089 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 6 23:08:33 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Jan 2020 22:08:33 +0000 Subject: [Koha-bugs] [Bug 24358] New: "Bibliographic record does not exist!" is not translatable Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24358 Bug ID: 24358 Summary: "Bibliographic record does not exist!" is not translatable Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: I18N/L10N Assignee: jonathan.druart at bugs.koha-community.org Reporter: jonathan.druart at bugs.koha-community.org QA Contact: testopia at bugs.koha-community.org CC: frederic at tamil.fr It's in a .js -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 6 23:08:51 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Jan 2020 22:08:51 +0000 Subject: [Koha-bugs] [Bug 21232] Problems when linking a subscription to a non-existing biblionumber In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21232 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |24358 --- Comment #17 from Jonathan Druart --- (In reply to Katrin Fischer from comment #16) > Comment on attachment 96576 [details] [review] > Bug 21232: Add a client-side check on biblionumber when creating a > subscription > > Review of attachment 96576 [details] [review]: > ----------------------------------------------------------------- > > ::: koha-tmpl/intranet-tmpl/prog/js/subscription-add.js > @@ +60,5 @@ > > } > > > > + var bib_exists = $("input[name='title']").val().length; > > + > > + if (!bib_exists) alert(_("Bibliographic record does not exist!")); > > This won't translate - got missed before. Can we fix it in a follow-up? Sorry about that, see bug 24358. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24358 [Bug 24358] "Bibliographic record does not exist!" is not translatable -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 6 23:08:51 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Jan 2020 22:08:51 +0000 Subject: [Koha-bugs] [Bug 24358] "Bibliographic record does not exist!" is not translatable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24358 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |21232 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21232 [Bug 21232] Problems when linking a subscription to a non-existing biblionumber -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 6 23:11:50 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Jan 2020 22:11:50 +0000 Subject: [Koha-bugs] [Bug 23260] Anonymize (remove) patron data from items_last_borrower In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23260 --- Comment #56 from Tomás Cohen Arazi --- I talked to Agustín this weekend and he was surprised as he was sure he implemented what Jonathan requested. I agree he should've squashed the patches, though. He was sure he removed the introduced classes I like the alternative, but would prefer to hear from Agustin first when he's back and maybe he can adjust the details. Also, we should find some criteria for when doing what we do everywhere is ok, and when improving the codebase is a requirement. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 6 23:12:29 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Jan 2020 22:12:29 +0000 Subject: [Koha-bugs] [Bug 24358] "Bibliographic record does not exist!" is not translatable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24358 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 6 23:12:33 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Jan 2020 22:12:33 +0000 Subject: [Koha-bugs] [Bug 24358] "Bibliographic record does not exist!" is not translatable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24358 --- Comment #1 from Jonathan Druart --- Created attachment 96866 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96866&action=edit Bug 24358: (bug 21232) Make the alert string translatable "Bibliographic record does not exist!" was not translatable as it was defined in the .js file Test plan: Repeat test plan from bug 21232 Bonus point: update and install a localized version and confirm that the message is translatable -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 6 23:14:43 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Jan 2020 22:14:43 +0000 Subject: [Koha-bugs] [Bug 23800] Batch modification tool orders items by barcode incremental by default (regression to 17.11) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23800 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas at bywatersolutions.com --- Comment #22 from Lucas Gass --- Having some trouble rebasing this for 19.05.x, if this is needed in 19.05 could a rebase be provided? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 6 23:18:02 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Jan 2020 22:18:02 +0000 Subject: [Koha-bugs] [Bug 14086] date ordered on ordered fund search doesn't match order date In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14086 --- Comment #3 from Katrin Fischer --- (In reply to Katrin Fischer from comment #2) > I disagree in that the date ordered should be the date the basket was closed > as that changes the status to 'ordered'. But the problem reported needs a > bit more testing. Too tired writing this... Nicole said it should be 'basket created', I think it should be 'basket closed'. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Jan 6 23:19:54 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Jan 2020 22:19:54 +0000 Subject: [Koha-bugs] [Bug 14085] Search for biblionumber in acquisitions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14085 Suzanne Fayle changed: What |Removed |Added ---------------------------------------------------------------------------- CC|sfayle at roseman.edu | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 6 23:20:32 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Jan 2020 22:20:32 +0000 Subject: [Koha-bugs] [Bug 14083] Make it possible to record the date the order was placed/sent to the vendor In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14083 Suzanne Fayle changed: What |Removed |Added ---------------------------------------------------------------------------- CC|sfayle at roseman.edu | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 6 23:20:37 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Jan 2020 22:20:37 +0000 Subject: [Koha-bugs] [Bug 24277] Date Received in acquisitions cannot be changed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24277 --- Comment #7 from Jonathan Druart --- (In reply to Katrin Fischer from comment #6) > Comment on attachment 96614 [details] [review] > Bug 24277: Fix date received editing when receiving an order > > Review of attachment 96614 [details] [review]: > ----------------------------------------------------------------- > > ::: C4/Acquisition.pm > @@ -1398,2 @@ > > received_itemnumbers => \@received_itemnumbers, > > - order_internalnote => $order_internalnote, > > Was this change intentional? Yes, it's a POD update. It's not part of the param list. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 6 23:21:59 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Jan 2020 22:21:59 +0000 Subject: [Koha-bugs] [Bug 24277] Date Received in acquisitions cannot be changed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24277 --- Comment #8 from Katrin Fischer --- (In reply to Jonathan Druart from comment #7) > (In reply to Katrin Fischer from comment #6) > > Comment on attachment 96614 [details] [review] [review] > > Bug 24277: Fix date received editing when receiving an order > > > > Review of attachment 96614 [details] [review] [review]: > > ----------------------------------------------------------------- > > > > ::: C4/Acquisition.pm > > @@ -1398,2 @@ > > > received_itemnumbers => \@received_itemnumbers, > > > - order_internalnote => $order_internalnote, > > > > Was this change intentional? > > Yes, it's a POD update. It's not part of the param list. Oops, sorry. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 6 23:27:20 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Jan 2020 22:27:20 +0000 Subject: [Koha-bugs] [Bug 14091] Allow to delete a cancelled order line In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14091 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|way to distinguish deleted |Allow to delete a cancelled |versus cancelled in acq |order line CC| |katrin.fischer at bsz-bw.de --- Comment #1 from Katrin Fischer --- We can do this using the cancellation reasons. It's also possible to delete a basket, but not to delete an order line. I think for input errors being able to delete a cancelled order line might be nice. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 6 23:28:41 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Jan 2020 22:28:41 +0000 Subject: [Koha-bugs] [Bug 14092] Order search doesn't allow to search for 'all statuses' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14092 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Summary|order search doesn't allow |Order search doesn't allow |for all statuses |to search for 'all | |statuses' See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=14087 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 6 23:28:41 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Jan 2020 22:28:41 +0000 Subject: [Koha-bugs] [Bug 14087] show all price fields on order search In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14087 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=14092 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 6 23:28:57 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Jan 2020 22:28:57 +0000 Subject: [Koha-bugs] [Bug 22284] Groups of pickup locations for holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 --- Comment #288 from Jonathan Druart --- # Failed test 'No tests run for subtest "pickup_locations() tests"' # at t/db_dependent/Template/Plugin/Branches.t line 151. Can't call method "unblessed" on unblessed reference at /kohadevbox/koha/Koha/Template/Plugin/Branches.pm line 93. # Looks like your test exited with 255 just after 3. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 6 23:31:33 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Jan 2020 22:31:33 +0000 Subject: [Koha-bugs] [Bug 14093] way for course and course items to expire In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14093 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Status|NEW |RESOLVED Resolution|--- |DUPLICATE --- Comment #1 from Katrin Fischer --- *** This bug has been marked as a duplicate of bug 10239 *** -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 6 23:31:33 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Jan 2020 22:31:33 +0000 Subject: [Koha-bugs] [Bug 10239] Add start end end dates to course reserves In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10239 --- Comment #1 from Katrin Fischer --- *** Bug 14093 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 6 23:34:20 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Jan 2020 22:34:20 +0000 Subject: [Koha-bugs] [Bug 24359] New: Remove items from Holds Queue when checked in Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24359 Bug ID: 24359 Summary: Remove items from Holds Queue when checked in Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Hold requests Assignee: koha-bugs at lists.koha-community.org Reporter: joy at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com Currently, if an item is checked in and the hold is triggered/captured, the item will not come off the holds queue until the the cronjob runs again. This causes some confusion for multibranch systems when other branches attempt to fill holds that have already been filled. Proposal: Remove bib/items from the Holds Queue after checkin and before the next holds queue cron runs to update the holds queue. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 6 23:35:42 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Jan 2020 22:35:42 +0000 Subject: [Koha-bugs] [Bug 24230] intranet_js plugin hook is after body end tag In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24230 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable CC| |lucas at bywatersolutions.com --- Comment #6 from Lucas Gass --- backported to 19.05.x for 19.05.07 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 6 23:39:49 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Jan 2020 22:39:49 +0000 Subject: [Koha-bugs] [Bug 13806] No input sanitization where creating Reports subgroup In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13806 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas at bywatersolutions.com Status|Pushed to stable |Pushed to oldstable --- Comment #7 from Lucas Gass --- backported to 19.05.x for 19.05.07 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 6 23:47:59 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Jan 2020 22:47:59 +0000 Subject: [Koha-bugs] [Bug 20948] Item-level hold info displayed regardless its priority (detail.pl) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20948 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable CC| |lucas at bywatersolutions.com --- Comment #29 from Lucas Gass --- backported to 19.05.x for 19.05.07 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 6 23:51:15 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Jan 2020 22:51:15 +0000 Subject: [Koha-bugs] [Bug 24150] Add missing Koha::Old::*[s] classes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24150 --- Comment #10 from Jonathan Druart --- Created attachment 96867 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96867&action=edit Bug 24150: Add missing koha_object[s]_class methods -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 6 23:53:07 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Jan 2020 22:53:07 +0000 Subject: [Koha-bugs] [Bug 24150] Add missing Koha::Old::*[s] classes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24150 --- Comment #11 from Jonathan Druart --- Tests are failing with: koha_1 | # Failed test 'Testing Koha::Old::Patrons' koha_1 | # at t/db_dependent/TestBuilder.t line 397. koha_1 | # got: '' koha_1 | # expected: 'Koha::Old::Patron' koha_1 | koha_1 | # Failed test 'Module Koha::Old::Patrons should have koha_object[s]_class method if needed' koha_1 | # at t/db_dependent/TestBuilder.t line 399. koha_1 | # got: 'Can't call method "get_from_storage" on an undefined value at t/db_dependent/TestBuilder.t line 398. koha_1 | # ' koha_1 | # expected: '' koha_1 | # Looks like you failed 2 tests of 70. koha_1 | koha_1 | # Failed test 'Test all classes' koha_1 | # at t/db_dependent/TestBuilder.t line 409. koha_1 | # Looks like you planned 5 tests but ran 4. koha_1 | # Looks like you failed 1 test of 4 run. koha_1 | koha_1 | # Failed test 'build_object() tests' koha_1 | # at t/db_dependent/TestBuilder.t line 425. koha_1 | Can't call method "_result" on an undefined value at t/db_dependent/TestBuilder.t line 402. This patch is not enough to fix them, a PK is missing on deletedborrowers, I am going to fix that ASAP, certainly will need to open a new bug report to deal with that. Do not backport! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jan 6 23:59:30 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Jan 2020 22:59:30 +0000 Subject: [Koha-bugs] [Bug 21270] "Not finding what you're looking" display needs to be fixed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21270 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas at bywatersolutions.com Status|Pushed to stable |Pushed to oldstable --- Comment #27 from Lucas Gass --- backported to 19.05.x for 19.05.07 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 7 00:08:29 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Jan 2020 23:08:29 +0000 Subject: [Koha-bugs] [Bug 24184] Reword FallbackToSMSIfNoEmail syspref text In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24184 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable --- Comment #12 from Lucas Gass --- backported to 19.05.x for 19.05.07 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 7 00:25:39 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Jan 2020 23:25:39 +0000 Subject: [Koha-bugs] [Bug 24358] "Bibliographic record does not exist!" is not translatable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24358 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 7 00:25:42 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Jan 2020 23:25:42 +0000 Subject: [Koha-bugs] [Bug 24358] "Bibliographic record does not exist!" is not translatable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24358 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #96866|0 |1 is obsolete| | --- Comment #2 from Lucas Gass --- Created attachment 96868 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96868&action=edit Bug 24358: (bug 21232) Make the alert string translatable "Bibliographic record does not exist!" was not translatable as it was defined in the .js file Test plan: Repeat test plan from bug 21232 Bonus point: update and install a localized version and confirm that the message is translatable Signed-off-by: Lucas Gass -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 7 00:42:59 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 Jan 2020 23:42:59 +0000 Subject: [Koha-bugs] [Bug 5463] limit to available shows on hold items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5463 Michael Spagnuolo changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mspagnuolo at nrhtx.com --- Comment #2 from Michael Spagnuolo --- This still seems to be an issue. Patrons have complained about this issue to staff. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 7 02:49:11 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Jan 2020 01:49:11 +0000 Subject: [Koha-bugs] [Bug 24340] We ought to be able to disable SIP using koha-sip In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24340 --- Comment #6 from Liz Rea --- (In reply to David Nind from comment #4) > Hi Liz. I've signed this off, but I think the debian/docs/koha-sip.xml file > needs updating so that the option is listed in the man page for the package > command. good point, I'll make a patch for that. :) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jan 7 03:02:32 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Jan 2020 02:02:32 +0000 Subject: [Koha-bugs] [Bug 12366] Better handling of Zebra errors when searching empty indexes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12366 --- Comment #5 from David Cook --- (In reply to Katrin Fischer from comment #4) > I am sorry, but I don't feel we should keep it open without having something > broken we can name and fix - it will just remain open forever. If we want to > document Zebra's behaviour in certain cases, the wiki would be a better > place in my opinion than the bug tracker. I think that you might be misunderstanding me, but no worries. I agree about it remaining open forever. I have ideas about an alternative bug report that catches errors from Zebra and does something with them. I just don't have the time/energy to work on it. Maybe one day. But no argument about closing this one in this case. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 7 06:21:16 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Jan 2020 05:21:16 +0000 Subject: [Koha-bugs] [Bug 24351] During Installation, connection to remote mysql server fails In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24351 --- Comment #5 from Seema Albal --- (In reply to David Nind from comment #3) > Hopefully this will point you in the right direction to solve the problem > you are having: > https://wiki.koha-community.org/wiki/Install_Koha_3. > 6_on_Debian_squeeze_using_a_separate_MySQL_server > This helped! Thanks -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 7 07:39:20 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Jan 2020 06:39:20 +0000 Subject: [Koha-bugs] [Bug 24351] During Installation, connection to remote mysql server fails In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24351 Seema Albal changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |REOPENED Resolution|INVALID |--- --- Comment #6 from Seema Albal --- Just updating what actually worked... Following the steps in the wiki page, I landed the "Sorry, this page is under maintenance ...." page. Looked around and found that using this method, I had to do koha-enable mylibrary Upon doing that and restarting, (and still editing koha-conf.xml with right db host values), I got the same error again!! Then, as per @Katrin_Fischer, I did $service memcached restart (At this time browser setup gave maintenance page) $koha-plack --enable mylibrary $koha-plack --start mylibrary This required some additional apache2 modules to be installed and restarted (after this some 503 Service unavailable error) And this did the trick!! Thanks! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 7 07:40:27 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Jan 2020 06:40:27 +0000 Subject: [Koha-bugs] [Bug 24351] During Installation, connection to remote mysql server fails In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24351 Seema Albal changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|REOPENED |RESOLVED --- Comment #7 from Seema Albal --- Thanks.. please ignore the 503 error in the above comment. Got the web installer running now! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 7 07:59:06 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Jan 2020 06:59:06 +0000 Subject: [Koha-bugs] [Bug 24351] During Installation, connection to remote mysql server fails In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24351 --- Comment #8 from David Nind --- Excellent! Glad to hear you got there!! -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jan 7 09:04:23 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Jan 2020 08:04:23 +0000 Subject: [Koha-bugs] [Bug 10517] koha-restore fails to create mysqluser@mysql_hostname so zebra update fails In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10517 --- Comment #8 from Rudolf Byker --- Hi Katrin, I don't understand your last message. To whom was it directed? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jan 7 09:28:06 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Jan 2020 08:28:06 +0000 Subject: [Koha-bugs] [Bug 10517] koha-restore fails to create mysqluser@mysql_hostname so zebra update fails In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10517 --- Comment #9 from Katrin Fischer --- The attached file is not a properly formatted patch file and can't be processed with our tools - I set the "Academy" keyword the same time as the comment. It's a keyword we use for easy bugs and tasks that are good for people starting out developing on Koha. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jan 7 09:28:22 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Jan 2020 08:28:22 +0000 Subject: [Koha-bugs] [Bug 23571] fines.pl may block server In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23571 --- Comment #3 from Hugo Agud --- I have installed the patch , and from sudo koha-shell kohadev I have launched two terminal session but there is no error message at second terminal, perhaps I have done something wrong SESSION 1 kohadev-koha at kohadevbox:/tmp$ perl /home/vagrant/kohaclone/misc/cronjobs/fines.pl -v -l -o Use of uninitialized value $lockfile in concatenation (.) or string at /home/vagrant/kohaclone/misc/cronjobs/fines.pl line 93. WARNING: Could not create lock file : No such file or directory Verify if directories /var/lock/koha/koha_kohadev, /var/lock/koha_fines_koha_kohadev or /tmp/koha_fines_koha_kohadev exist and check file permissions writing to /var/lib/koha/kohadev/tmp/koha_kohadev_2020-01-07.log Use of uninitialized value in subtraction (-) at /home/vagrant/kohaclone/C4/Overdues.pm line 250. Use of uninitialized value in numeric eq (==) at /home/vagrant/kohaclone/C4/Overdues.pm line 266. Use of uninitialized value in subtraction (-) at /home/vagrant/kohaclone/C4/Overdues.pm line 250. SESSION 2 kohadev-koha at kohadevbox:/home/vagrant$ perl /home/vagrant/kohaclone/misc/cronjobs/fines.pl -v -l -o Use of uninitialized value $lockfile in concatenation (.) or string at /home/vagrant/kohaclone/misc/cronjobs/fines.pl line 93. WARNING: Could not create lock file : No such file or directory Verify if directories /var/lock/koha/koha_kohadev, /var/lock/koha_fines_koha_kohadev or /tmp/koha_fines_koha_kohadev exist and check file permissions writing to /var/lib/koha/kohadev/tmp/koha_kohadev_2020-01-07.log Use of uninitialized value in subtraction (-) at /home/vagrant/kohaclone/C4/Overdues.pm line 250. Use of uninitialized value in numeric eq (==) at /home/vagrant/kohaclone/C4/Overdues.pm line 266 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 7 11:17:38 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Jan 2020 10:17:38 +0000 Subject: [Koha-bugs] [Bug 23113] members/pay.tt account_grp is not longer used In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23113 --- Comment #1 from Andrew Isherwood --- Created attachment 96869 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96869&action=edit Bug 23112: (follow-up) Fix test as per feedback As per comment #48 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 7 11:18:25 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Jan 2020 10:18:25 +0000 Subject: [Koha-bugs] [Bug 23113] members/pay.tt account_grp is not longer used In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23113 Andrew Isherwood changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrew.isherwood at ptfs-europ | |e.com Attachment #96869|0 |1 is obsolete| | --- Comment #2 from Andrew Isherwood --- Comment on attachment 96869 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96869 Bug 23112: (follow-up) Fix test as per feedback Sorry, attached to the wrong bug! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 7 11:18:52 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Jan 2020 10:18:52 +0000 Subject: [Koha-bugs] [Bug 23112] Circulation of ILL items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23112 --- Comment #49 from Andrew Isherwood --- Created attachment 96870 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96870&action=edit Bug 23112: (follow-up) Fix test as per feedback As per comment #48 https://bugs.koha-community.org/show_bug.cgi?id=23113 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 7 11:19:17 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Jan 2020 10:19:17 +0000 Subject: [Koha-bugs] [Bug 24322] National Library of Medicine (NLM) call number to XSLT Detail In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24322 Joonas Kylmälä changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |joonas.kylmala at helsinki.fi --- Comment #2 from Joonas Kylmälä --- Please include a test plan for this. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 7 11:20:50 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Jan 2020 10:20:50 +0000 Subject: [Koha-bugs] [Bug 23112] Circulation of ILL items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23112 --- Comment #50 from Andrew Isherwood --- (In reply to Jonathan Druart from comment #48) > (In reply to Andrew Isherwood from comment #46) > > > ::: Koha/Illrequest.pm > > > @@ +1211,5 @@ > > > > + # For some reason, AddIssue requires an unblessed Patron > > > > + $issue_args[0] = $patron->unblessed; > > > > + my $issue = C4::Circulation::AddIssue(@issue_args); > > > > + > > > > + if ($issue && %{$issue}) { > > > > > > AddIssue return a Koha::Checkout object. The test will work but I think it's > > > confusing. > > > > Do you mean the variable name $issue is confusing? If so, I thought it made > > sense since the function returning it is called AddIssue and, internally, > > AddIssue also calls the returned value $issue. > > You should only test for $issue, the "&& %$issue" does not make sense to me. I've now attached a patch to address this. I'm puzzled why I did this extra test, it seems like the sort of thing that would be deliberate. Looking at AddIssue, I can't see a case where an empty hashref could be returned, so I'm not sure why I would have added this extra test. Anyway, thanks for pointing it out Jonathan. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 7 11:21:06 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Jan 2020 10:21:06 +0000 Subject: [Koha-bugs] [Bug 24322] National Library of Medicine (NLM) call number to XSLT Detail In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24322 --- Comment #3 from Joonas Kylmälä --- Also, format the commit title with "Bug 24322: XXX" instead of "Bug 24322 - XXX" -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 7 11:23:02 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Jan 2020 10:23:02 +0000 Subject: [Koha-bugs] [Bug 24322] National Library of Medicine (NLM) call number to XSLT Detail In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24322 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #4 from Katrin Fischer --- Also spotted a small thing, it should have its own class: + -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 7 11:32:07 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Jan 2020 10:32:07 +0000 Subject: [Koha-bugs] [Bug 15148] Serials: Test prediction pattern starts at First issue date, not Subscription start date In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15148 --- Comment #8 from Fridolin SOMERS --- Look at serials/subscription-add.pl _guess_enddate() : } elsif($frequency->{'unit'} eq 'month') { ($year, $month, $day) = Add_Delta_YM(split(/-/, $startdate_iso), 0, $numberlength * $frequency->{'unitsperissue'} / $frequency->{'issuesperunit'}); It is called by : if($subtype eq "issues") { $enddate = _guess_enddate($firstacquidate, $periodicity, $numberlength, $weeklength, $monthlength) } else { $enddate = _guess_enddate($startdate, $periodicity, $numberlength, $weeklength, $monthlength) } You see subscription start date is used. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 7 11:40:49 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Jan 2020 10:40:49 +0000 Subject: [Koha-bugs] [Bug 24150] Add missing Koha::Old::*[s] classes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24150 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #96867|0 |1 is obsolete| | --- Comment #12 from Jonathan Druart --- Created attachment 96871 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96871&action=edit Bug 24150: Add missing koha_object[s]_class methods and skip for deletedborrowers deletedborrowers does not have a PK, and adding it is out of the scope of this patchset. Indeed we will have to handle possible duplication of borrowernumber values, which does not seem trivial. Having bug 20271 in mind, we will have to deal with this problematic anyway later. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 7 11:41:12 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Jan 2020 10:41:12 +0000 Subject: [Koha-bugs] [Bug 24150] Add missing Koha::Old::*[s] classes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24150 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |additional_work_needed -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 7 11:41:28 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Jan 2020 10:41:28 +0000 Subject: [Koha-bugs] [Bug 24150] Add missing Koha::Old::*[s] classes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24150 --- Comment #13 from Jonathan Druart --- RMaints: we should not backport this patchset. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 7 11:44:24 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Jan 2020 10:44:24 +0000 Subject: [Koha-bugs] [Bug 7365] Koha should support PostgreSQL In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7365 Alexander Borkowski changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |alexander.borkowski at kau.se -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 7 11:50:34 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Jan 2020 10:50:34 +0000 Subject: [Koha-bugs] [Bug 21520] More complex OAI sets mappings In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21520 --- Comment #10 from Matthias Meusburger --- Well, I hesitated, but I chose not to, having those two things in mind: - Keep It Simple, Stupid. - If it's not broken, don't fix it. That being said, I can come up with a follow-up for the updatedatabase if you want me to. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 7 11:51:38 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Jan 2020 10:51:38 +0000 Subject: [Koha-bugs] [Bug 21684] Koha::Object[s]->delete methods must behave identically as the corresponding DBIx::Class ones In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21684 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |additional_work_needed Depends on| |17669 --- Comment #25 from Jonathan Druart --- # Failed test 'Test delete via UploadedFile as well as UploadedFiles' # at t/db_dependent/Upload.t line 193. DBIx::Class::Row::delete(): Not in database at /kohadevbox/koha/Koha/Object.pm line 219 Failing test, the previous test was expecting 0E0 if the delete failed, now it raises an exception. I think we can simply adjust the test accordingly. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17669 [Bug 17669] Add purging temporary uploads to cleanup_database -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 7 11:51:38 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Jan 2020 10:51:38 +0000 Subject: [Koha-bugs] [Bug 17669] Add purging temporary uploads to cleanup_database In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17669 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |21684 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21684 [Bug 21684] Koha::Object[s]->delete methods must behave identically as the corresponding DBIx::Class ones -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 7 12:12:37 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Jan 2020 11:12:37 +0000 Subject: [Koha-bugs] [Bug 21684] Koha::Object[s]->delete methods must behave identically as the corresponding DBIx::Class ones In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21684 --- Comment #26 from Jonathan Druart --- Created attachment 96872 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96872&action=edit Bug 21684: Fix UploadedFile[s]->delete Tests were failing with: # Failed test 'Test delete via UploadedFile as well as UploadedFiles' # at t/db_dependent/Upload.t line 193. DBIx::Class::Row::delete(): Not in database at /kohadevbox/koha/Koha/Object.pm line 219 I am not sure this patch is perfect, a set of uploaded files should be deleted in a transaction, which would be rollback if something is wrong. But it will be tricky to restore the files after they have been deleted. It seems that we should deal with that with a more complicated process and should be part of a separate bug. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 7 12:13:02 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Jan 2020 11:13:02 +0000 Subject: [Koha-bugs] [Bug 21684] Koha::Object[s]->delete methods must behave identically as the corresponding DBIx::Class ones In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21684 --- Comment #27 from Jonathan Druart --- Marcel, could I get your opinion on this follow-up? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 7 12:20:37 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Jan 2020 11:20:37 +0000 Subject: [Koha-bugs] [Bug 24360] New: issues.renewal limits to 127 Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24360 Bug ID: 24360 Summary: issues.renewal limits to 127 Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Circulation Assignee: koha-bugs at lists.koha-community.org Reporter: jonathan.druart at bugs.koha-community.org QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com Certainly not a big deal but reporting it here anyway. >From a test in t/db_dependent/Circulation/issue.t: koha_1 | DBD::mysql::st execute failed: Out of range value for column 'renewals' at row 1 [for Statement "UPDATE issues SET date_due = ?, renewals = ?, lastreneweddate = ? koha_1 | WHERE borrowernumber=? koha_1 | AND itemnumber=?" with ParamValues: 0='2019-12-24 00:00', 1=128, 2='2019-12-24', 3='494', 4='1266'] at /kohadevbox/koha/C4/Circulation.pm line 2936. The values for issue has been generated from TestBuilder, which set issues.renewal to 127. However the test calls AddRenewal which increments this value, and we reach the limit. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 7 12:23:42 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Jan 2020 11:23:42 +0000 Subject: [Koha-bugs] [Bug 9290] Restricting patron category for online purchase suggestion In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9290 --- Comment #12 from Vinod --- Hello, Seems very slow progress in this bug, may I know any temporary solution so that I can hide the purchase suggestion menu on OPAC from a specific category of users? Thanking You. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 7 12:25:21 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Jan 2020 11:25:21 +0000 Subject: [Koha-bugs] [Bug 24361] New: Fix warnings (or failing tests) from bug 24217 Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24361 Bug ID: 24361 Summary: Fix warnings (or failing tests) from bug 24217 Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: Test Suite Assignee: jonathan.druart at bugs.koha-community.org Reporter: jonathan.druart at bugs.koha-community.org QA Contact: testopia at bugs.koha-community.org We added use Modern::Perl to some of our modules, we should expect warnings in logs or test failing -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 7 12:25:55 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Jan 2020 11:25:55 +0000 Subject: [Koha-bugs] [Bug 24217] use strict for all modules In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24217 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |24361 --- Comment #10 from Jonathan Druart --- See bug 24361 for follow-ups. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24361 [Bug 24361] Fix warnings (or failing tests) from bug 24217 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 7 12:25:55 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Jan 2020 11:25:55 +0000 Subject: [Koha-bugs] [Bug 24361] Fix warnings (or failing tests) from bug 24217 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24361 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |24217 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24217 [Bug 24217] use strict for all modules -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 7 12:27:44 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Jan 2020 11:27:44 +0000 Subject: [Koha-bugs] [Bug 24361] Fix warnings (or failing tests) from bug 24217 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24361 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 7 12:27:48 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Jan 2020 11:27:48 +0000 Subject: [Koha-bugs] [Bug 24361] Fix warnings (or failing tests) from bug 24217 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24361 --- Comment #1 from Jonathan Druart --- Created attachment 96873 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96873&action=edit Bug 24361: Fix warning in C4::Record line 435 Use of uninitialized value in concatenation (.) or string at /kohadevbox/koha/C4/Record.pm line 435 Caught by a failing test: # Failed test 'Export csv with wrong marcxml should raise a warning' # at t/db_dependent/Exporter/Record.t line 113. # found warning: problem with :721 : :1: parser error : Start tag expected, '<' not found # found warning: Use of uninitialized value in concatenation (.) or string at /kohadevbox/koha/C4/Record.pm line 435. # expected to find warning: (?^u:.*Start tag expected.*) Test plan: Make sure the tests pass now -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 7 12:33:48 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Jan 2020 11:33:48 +0000 Subject: [Koha-bugs] [Bug 24321] Make objects.search use mappings from Koha::Object(s) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24321 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 7 12:33:51 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Jan 2020 11:33:51 +0000 Subject: [Koha-bugs] [Bug 24321] Make objects.search use mappings from Koha::Object(s) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24321 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #96840|0 |1 is obsolete| | Attachment #96841|0 |1 is obsolete| | Attachment #96842|0 |1 is obsolete| | Attachment #96843|0 |1 is obsolete| | Attachment #96844|0 |1 is obsolete| | Attachment #96845|0 |1 is obsolete| | Attachment #96846|0 |1 is obsolete| | Attachment #96847|0 |1 is obsolete| | Attachment #96848|0 |1 is obsolete| | Attachment #96849|0 |1 is obsolete| | Attachment #96850|0 |1 is obsolete| | Attachment #96851|0 |1 is obsolete| | Attachment #96852|0 |1 is obsolete| | --- Comment #37 from Josef Moravec --- Created attachment 96874 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96874&action=edit Bug 24321: Add Koha::Objects->attributes_from_api This patch makes the 'attributes_from_api' method from the singular class available from the result set class. To test: 1. Apply this patch 2. Run: $ kshell k$ prove t/db_dependent/Koha/Objects.t => SUCCESS: Tests pass! 4. Sign off :-D 5. Yeah, I skipped 3 :-P Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 7 12:33:57 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Jan 2020 11:33:57 +0000 Subject: [Koha-bugs] [Bug 24321] Make objects.search use mappings from Koha::Object(s) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24321 --- Comment #38 from Josef Moravec --- Created attachment 96875 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96875&action=edit Bug 24321: Make dbic_merge_sorting accept a result set as parameter This patch makes dbic_merge_sorting accept a result set as parameter and solves a FIXME in _build_order_atom. To test: 1. Apply this patch 2. Run: $ kshell k$ prove t/Koha/REST/Plugin/Query.t => SUCCESS: Tests pass! 3. Sign off :-D Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 7 12:34:02 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Jan 2020 11:34:02 +0000 Subject: [Koha-bugs] [Bug 24321] Make objects.search use mappings from Koha::Object(s) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24321 --- Comment #39 from Josef Moravec --- Created attachment 96876 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96876&action=edit Bug 24321: Make objects.search use mappings from Koha::Object(s) This patch simplifies the objects.search helper so it relies entirely on the result set object for the attribute mappings. The result is no more to_api or to_model mappings are passed. The controllers need to be cleaned up after this patch. To test: 1. Apply this patch 2. Run: $ kshell k$ prove t/db_dependent/Koha/REST/Plugin/Objects.t => SUCCESS: Tests pass! 3. Sign off :-D Note: the original version of this helpers accepted arbitrary mappings and are now constrianed to real mappings on the Koha::Object level. As such, the number of tests got reduced. Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 7 12:34:07 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Jan 2020 11:34:07 +0000 Subject: [Koha-bugs] [Bug 24321] Make objects.search use mappings from Koha::Object(s) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24321 --- Comment #40 from Josef Moravec --- Created attachment 96877 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96877&action=edit Bug 24321: Clean /cities Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 7 12:34:12 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Jan 2020 11:34:12 +0000 Subject: [Koha-bugs] [Bug 24321] Make objects.search use mappings from Koha::Object(s) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24321 --- Comment #41 from Josef Moravec --- Created attachment 96878 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96878&action=edit Bug 24321: Clean /acquisitions/funds Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 7 12:34:17 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Jan 2020 11:34:17 +0000 Subject: [Koha-bugs] [Bug 24321] Make objects.search use mappings from Koha::Object(s) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24321 --- Comment #42 from Josef Moravec --- Created attachment 96879 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96879&action=edit Bug 24321: Clean /acquisitions/vendors Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 7 12:34:23 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Jan 2020 11:34:23 +0000 Subject: [Koha-bugs] [Bug 24321] Make objects.search use mappings from Koha::Object(s) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24321 --- Comment #43 from Josef Moravec --- Created attachment 96880 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96880&action=edit Bug 24321: Clean /libraries Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 7 12:34:28 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Jan 2020 11:34:28 +0000 Subject: [Koha-bugs] [Bug 24321] Make objects.search use mappings from Koha::Object(s) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24321 --- Comment #44 from Josef Moravec --- Created attachment 96881 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96881&action=edit Bug 24321: Clean /checkouts Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 7 12:34:33 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Jan 2020 11:34:33 +0000 Subject: [Koha-bugs] [Bug 24321] Make objects.search use mappings from Koha::Object(s) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24321 --- Comment #45 from Josef Moravec --- Created attachment 96882 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96882&action=edit Bug 24321: Clean /biblios Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 7 12:34:37 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Jan 2020 11:34:37 +0000 Subject: [Koha-bugs] [Bug 24321] Make objects.search use mappings from Koha::Object(s) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24321 --- Comment #46 from Josef Moravec --- Created attachment 96883 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96883&action=edit Bug 24321: Clean /items Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 7 12:34:41 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Jan 2020 11:34:41 +0000 Subject: [Koha-bugs] [Bug 24321] Make objects.search use mappings from Koha::Object(s) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24321 --- Comment #47 from Josef Moravec --- Created attachment 96884 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96884&action=edit Bug 24321: Clean /patrons/{patron_id}/account Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 7 12:34:46 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Jan 2020 11:34:46 +0000 Subject: [Koha-bugs] [Bug 24321] Make objects.search use mappings from Koha::Object(s) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24321 --- Comment #48 from Josef Moravec --- Created attachment 96885 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96885&action=edit Bug 24321: Clean /holds Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 7 12:34:50 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Jan 2020 11:34:50 +0000 Subject: [Koha-bugs] [Bug 24321] Make objects.search use mappings from Koha::Object(s) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24321 --- Comment #49 from Josef Moravec --- Created attachment 96886 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96886&action=edit Bug 24321: Clean /patrons Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 7 12:34:54 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Jan 2020 11:34:54 +0000 Subject: [Koha-bugs] [Bug 24321] Make objects.search use mappings from Koha::Object(s) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24321 --- Comment #50 from Josef Moravec --- Created attachment 96887 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96887&action=edit Bug 24321: (follow-up) Fix number of tests in t/db_dependent/Koha/Objects.t Test plan: prove t/db_dependent/Koha/Objects.t Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 7 12:52:22 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Jan 2020 11:52:22 +0000 Subject: [Koha-bugs] [Bug 23173] ILL should be able to search third party sources prior to request creation In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23173 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_20_05_target -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 7 13:31:40 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Jan 2020 12:31:40 +0000 Subject: [Koha-bugs] [Bug 21684] Koha::Object[s]->delete methods must behave identically as the corresponding DBIx::Class ones In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21684 --- Comment #28 from Jonathan Druart --- Created attachment 96888 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96888&action=edit Bug 21684: Koha::Object->delete must return a Koha::Object Not a DBIx::Class object. Tests have been added, add Bookseller.t fixed -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 7 13:32:37 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Jan 2020 12:32:37 +0000 Subject: [Koha-bugs] [Bug 23113] members/pay.tt account_grp is not longer used In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23113 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Severity|enhancement |trivial Version|unspecified |master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 7 13:40:52 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Jan 2020 12:40:52 +0000 Subject: [Koha-bugs] [Bug 23113] members/pay.tt account_grp is not longer used In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23113 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 7 13:40:55 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Jan 2020 12:40:55 +0000 Subject: [Koha-bugs] [Bug 23113] members/pay.tt account_grp is not longer used In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23113 --- Comment #3 from Owen Leonard --- Created attachment 96889 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96889&action=edit Bug 23113: members/pay.tt account_grp is not longer used This patch removes obsolete markup from pay.tt. To test, apply the patch and search the Koha codebase for instances of "account_grp" There should be none. Log in to the staff client and go to the account of a patron who has fines. Confirm that the "Accounting" page ("Make a payment" tab) works correctly. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 7 13:43:10 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Jan 2020 12:43:10 +0000 Subject: [Koha-bugs] [Bug 23113] members/pay.tt account_grp is not longer used In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23113 Andrew Isherwood changed: What |Removed |Added ---------------------------------------------------------------------------- CC|andrew.isherwood at ptfs-europ | |e.com | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 7 14:06:00 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Jan 2020 13:06:00 +0000 Subject: [Koha-bugs] [Bug 24275] Inventory table should be sortable by title without leading articles (allow for title sort with anti-the) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24275 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 7 14:06:03 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Jan 2020 13:06:03 +0000 Subject: [Koha-bugs] [Bug 24275] Inventory table should be sortable by title without leading articles (allow for title sort with anti-the) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24275 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #96485|0 |1 is obsolete| | --- Comment #3 from Nick Clemens --- Created attachment 96890 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96890&action=edit Bug 24275: Apply anti-the to title column in inventory table To test: 1 - Go to Tools->Inventory 2 - Click submit (or add options to get a subset of titles) 3 - Try sorting by title, note that titles with leading articles sort including the articles 4 - Apply patch 5 - Reload the page 6 - Note that leading articles are ignored for sorting Signed-off-by: Deb -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jan 7 14:06:41 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Jan 2020 13:06:41 +0000 Subject: [Koha-bugs] [Bug 13121] Move search results "action" links ("Place hold, " "Add tag, " etc) into include file In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13121 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 7 14:06:43 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Jan 2020 13:06:43 +0000 Subject: [Koha-bugs] [Bug 13121] Move search results "action" links ("Place hold, " "Add tag, " etc) into include file In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13121 --- Comment #2 from Owen Leonard --- Created attachment 96891 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96891&action=edit Bug 13121: Move search results "action" links ("Place hold," "Add tag," etc) into include file This patch moves markup for controls repeated across several OPAC templates into a single include: Place hold, Request article, Add tag, Save to lists, and Add to cart. To test, apply the patch and view the following OPAC pages: - Search results - Shelf contents view - User tags list On each of these pages all the controls should work correctly: - Place hold - Request art - Add tag - Save to lists - Add to cart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 7 14:20:33 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Jan 2020 13:20:33 +0000 Subject: [Koha-bugs] [Bug 24361] Fix warnings (or failing tests) from bug 24217 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24361 --- Comment #2 from Jonathan Druart --- Created attachment 96892 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96892&action=edit Bug 24361: (bug 24217 follow-up) Fix several warnings in C4 modules With bug 24217 pushed, lot of warnings appears during the tests are run. Most of them are "Use of uninitialized value in " Test plan: Take a look at the output of run 1049 https://jenkins.koha-community.org/job/Koha_Master_D9/1049/consoleFull Most of the warnings from this run will be removed by this patch At least 2 are not fixed: Use of uninitialized value in numeric eq (==) at /kohadevbox/koha/C4/Reserves.pm line 791. t/db_dependent/Items_DelItemCheck.t => see 23463 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 7 14:23:38 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Jan 2020 13:23:38 +0000 Subject: [Koha-bugs] [Bug 24362] New: Elasticsearch - Sorting by title does not ignore leading articles Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24362 Bug ID: 24362 Summary: Elasticsearch - Sorting by title does not ignore leading articles Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Searching - Elasticsearch Assignee: koha-bugs at lists.koha-community.org Reporter: nick at bywatersolutions.com Zebra respects the 2nd indicator for 24 fields to correctly sort titles We need to do the same in ES -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 7 14:28:31 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Jan 2020 13:28:31 +0000 Subject: [Koha-bugs] [Bug 21684] Koha::Object[s]->delete methods must behave identically as the corresponding DBIx::Class ones In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21684 --- Comment #29 from Marcel de Rooy --- (In reply to Jonathan Druart from comment #25) > # Failed test 'Test delete via UploadedFile as well as UploadedFiles' > # at t/db_dependent/Upload.t line 193. > DBIx::Class::Row::delete(): Not in database at > /kohadevbox/koha/Koha/Object.pm line 219 > > Failing test, the previous test was expecting 0E0 if the delete failed, now > it raises an exception. I think we can simply adjust the test accordingly. Yes, we should bring that in line with the changed delete subs. The subroutines in UploadedFile[s] also need attention.. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 7 14:29:34 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Jan 2020 13:29:34 +0000 Subject: [Koha-bugs] [Bug 21684] Koha::Object[s]->delete methods must behave identically as the corresponding DBIx::Class ones In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21684 --- Comment #30 from Marcel de Rooy --- (In reply to Jonathan Druart from comment #27) > Marcel, could I get your opinion on this follow-up? Looking now -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 7 14:42:15 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Jan 2020 13:42:15 +0000 Subject: [Koha-bugs] [Bug 21684] Koha::Object[s]->delete methods must behave identically as the corresponding DBIx::Class ones In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21684 --- Comment #31 from Marcel de Rooy --- How do we view this line now in both modules? return $rv==0 ? "0E0" : $rv; Also in delete_missing. The Upload.t test also refers to -1 values. Are they still possible? At first glance the test should still be adjusted a bit more, although it passes now. Second patch + my $deleted = $self->_result()->delete; + if ( ref $deleted ) { + my $object_class = Koha::Object::_get_object_class( $self->_result->result_class ); + $deleted = $object_class->_new_from_dbic($deleted); + } + return $deleted; Isnt this a bit expensive to do since we will generally not even look at what we get back? Most often $obj->delete is not even tested. Parameterize the return?? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 7 14:43:34 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Jan 2020 13:43:34 +0000 Subject: [Koha-bugs] [Bug 24350] Can't place holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24350 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|tomascohen at gmail.com |jonathan.druart at bugs.koha-c | |ommunity.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 7 14:43:42 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Jan 2020 13:43:42 +0000 Subject: [Koha-bugs] [Bug 24350] Can't place holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24350 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 7 14:45:38 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Jan 2020 13:45:38 +0000 Subject: [Koha-bugs] [Bug 24363] New: Datepicker calendar is not sexy on additem.pl Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24363 Bug ID: 24363 Summary: Datepicker calendar is not sexy on additem.pl Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard at myacpl.org Reporter: caroline.cyr-la-rose at inlibro.com QA Contact: testopia at bugs.koha-community.org Created attachment 96893 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96893&action=edit Screenshot showing the date acquired field in additem I just wanted to mention that the datepicker calendar icon looks weird in the additem form (probably elsewhere too). Could we make it bigger and centered? Also the ellipsis (...) is not next to the box as it was before. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 7 14:46:08 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Jan 2020 13:46:08 +0000 Subject: [Koha-bugs] [Bug 24363] Datepicker calendar is not sexy on additem.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24363 Caroline Cyr La Rose changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |24181 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24181 [Bug 24181] Make our datepicker inputs sexy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 7 14:46:08 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Jan 2020 13:46:08 +0000 Subject: [Koha-bugs] [Bug 24181] Make our datepicker inputs sexy In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24181 Caroline Cyr La Rose changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |24363 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24363 [Bug 24363] Datepicker calendar is not sexy on additem.pl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 7 14:46:51 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Jan 2020 13:46:51 +0000 Subject: [Koha-bugs] [Bug 24350] Can't place holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24350 --- Comment #3 from Tomás Cohen Arazi --- (In reply to Jonathan Druart from comment #2) > Created attachment 96860 [details] [review] > Bug 24350: Fix Branches.pickup_locations > > This will fix the following error: > Template process failed: undef error - Not a HASH reference at > /home/vagrant/kohaclone/Koha/Template/Plugin/Branches.pm line 96. > at /home/vagrant/kohaclone/C4/Templates.pm line 122 > > Koha::Libraries->pickup_locations does not always return an array, but > arrayref if $biblio is not a Koha::Biblio object. > > I do not think it's the correct fix, the pattern in > Koha::Libraries->pickup_locations is wrong: we should not expect 2 > different types for a given parameter, biblio should always be a > Koha::Biblio (idem for item btw). > That could be fixed easily if the template had the Koha::Biblio object > sent. I think we should fix this blocker with your patch, Jonathan, and file a separate bug for refactoring things. This way people can keep testing the feature and writing the manual pages, while we implement things in a different way. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 7 14:47:13 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Jan 2020 13:47:13 +0000 Subject: [Koha-bugs] [Bug 24362] Elasticsearch - Sorting by title does not ignore leading articles In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24362 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |DUPLICATE Status|NEW |RESOLVED CC| |katrin.fischer at bsz-bw.de --- Comment #1 from Katrin Fischer --- *** This bug has been marked as a duplicate of bug 24350 *** -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 7 14:47:13 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Jan 2020 13:47:13 +0000 Subject: [Koha-bugs] [Bug 24350] Can't place holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24350 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick at bywatersolutions.com --- Comment #4 from Katrin Fischer --- *** Bug 24362 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 7 14:47:28 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Jan 2020 13:47:28 +0000 Subject: [Koha-bugs] [Bug 24363] Datepicker calendar is not sexy on additem.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24363 --- Comment #1 from Caroline Cyr La Rose --- I use Firefox 71.0 on Ubuntu 18.04 btw... just in case this changes something -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 7 14:48:23 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Jan 2020 13:48:23 +0000 Subject: [Koha-bugs] [Bug 24181] Make our datepicker inputs sexy In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24181 Caroline Cyr La Rose changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |caroline.cyr-la-rose at inlibr | |o.com --- Comment #15 from Caroline Cyr La Rose --- The calendar icon in additem looks weird... see bug #24363 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 7 14:49:53 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Jan 2020 13:49:53 +0000 Subject: [Koha-bugs] [Bug 22774] Limit Purchase Suggestion in a specified Time period In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22774 Kelly McElligott changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kelly at bywatersolutions.com Status|Needs Signoff |Failed QA --- Comment #4 from Kelly McElligott --- Hi, Upon testing this, I received this error when trying to place a hold on the OPAC side. Could not compile /kohadevbox/koha/opac/opac-suggestions.pl: Global symbol "$suggestions_loop" requires explicit package name (did you forget to declare "my $suggestions_loop"?) at /kohadevbox/koha/opac/opac-suggestions.pl line 144 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 7 14:52:05 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Jan 2020 13:52:05 +0000 Subject: [Koha-bugs] [Bug 24150] Add missing Koha::Old::*[s] classes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24150 --- Comment #14 from Martin Renvoize --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 7 14:53:59 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Jan 2020 13:53:59 +0000 Subject: [Koha-bugs] [Bug 24364] New: Display item holding library in opac issues Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24364 Bug ID: 24364 Summary: Display item holding library in opac issues Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: matthias.meusburger at biblibre.com QA Contact: testopia at bugs.koha-community.org Be able to display the item's holding library in OPAC issues. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 7 14:57:33 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Jan 2020 13:57:33 +0000 Subject: [Koha-bugs] [Bug 24150] Add missing Koha::Old::*[s] classes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24150 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|additional_work_needed | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 7 15:00:55 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Jan 2020 14:00:55 +0000 Subject: [Koha-bugs] [Bug 24361] Fix warnings (or failing tests) from bug 24217 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24361 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 7 15:01:03 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Jan 2020 14:01:03 +0000 Subject: [Koha-bugs] [Bug 24361] Fix warnings (or failing tests) from bug 24217 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24361 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 7 15:01:28 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Jan 2020 14:01:28 +0000 Subject: [Koha-bugs] [Bug 24361] Fix warnings (or failing tests) from bug 24217 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24361 --- Comment #3 from Martin Renvoize --- Code is sensible and tests are improved.. passing qa for a quick push whilst we work on the final two failures. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 7 15:01:30 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Jan 2020 14:01:30 +0000 Subject: [Koha-bugs] [Bug 24364] Display item holding library in opac issues In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24364 --- Comment #1 from Matthias Meusburger --- Created attachment 96894 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96894&action=edit Bug 24364: Display item holding library in opac issues Test plan: 1) Create a SHOW_LIB patron attribute type, with YES_NO as authorized value category. (Administration -> Patron attribute types -> New patron attribute type) Check 'Display in OPAC' and 'Editable in OPAC' if you want users to be able to toggle library display themselves. 2) Set the SHOW_LIB attribute to yes for a given patron. 3) Check that the library is displayed in this patron's opac issues. ('Your summary' -> 'Checked out' and 'Overdue' tabs) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 7 15:01:57 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Jan 2020 14:01:57 +0000 Subject: [Koha-bugs] [Bug 24364] Display item holding library in opac issues In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24364 Matthias Meusburger changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Assignee|oleonard at myacpl.org |matthias.meusburger at biblibr | |e.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 7 15:02:04 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Jan 2020 14:02:04 +0000 Subject: [Koha-bugs] [Bug 24361] Fix warnings (or failing tests) from bug 24217 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24361 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master --- Comment #4 from Martin Renvoize --- First two patches pushed to master. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 7 15:02:17 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Jan 2020 14:02:17 +0000 Subject: [Koha-bugs] [Bug 24361] Fix warnings (or failing tests) from bug 24217 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24361 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |20.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 7 15:24:44 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Jan 2020 14:24:44 +0000 Subject: [Koha-bugs] [Bug 21684] Koha::Object[s]->delete methods must behave identically as the corresponding DBIx::Class ones In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21684 --- Comment #32 from Jonathan Druart --- Created attachment 96895 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96895&action=edit Bug 21684: (follow-up) Fix UploadedFile[s]->delete This can be squashed -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 7 15:27:40 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Jan 2020 14:27:40 +0000 Subject: [Koha-bugs] [Bug 21684] Koha::Object[s]->delete methods must behave identically as the corresponding DBIx::Class ones In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21684 --- Comment #33 from Jonathan Druart --- (In reply to Marcel de Rooy from comment #31) > How do we view this line now in both modules? > return $rv==0 ? "0E0" : $rv; > Also in delete_missing. I do not understand exactly what you mean. > The Upload.t test also refers to -1 values. Are they still possible? At > first glance the test should still be adjusted a bit more, although it > passes now. Indeed, done. > Second patch > + my $deleted = $self->_result()->delete; > + if ( ref $deleted ) { > + my $object_class = Koha::Object::_get_object_class( > $self->_result->result_class ); > + $deleted = $object_class->_new_from_dbic($deleted); > + } > + return $deleted; > Isnt this a bit expensive to do since we will generally not even look at > what we get back? I do not think it's expensive, the _new_from_dbic will do nothing if the object is not reused after ->delete. So only _get_object_class will be effective. > Most often $obj->delete is not even tested. It is widely tested in Objects.t > Parameterize the return?? Not a good idea IMO. We must behave like DBIx::Class, it's the whole point of this patchset. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 7 15:28:11 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Jan 2020 14:28:11 +0000 Subject: [Koha-bugs] [Bug 22284] Groups of pickup locations for holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrew at bywatersolutions.com Text to go in the| |Adds the ability to define release notes| |groups of libraries for use | |in holds policy. Sponsored | |by VOKAL. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 7 15:28:47 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Jan 2020 14:28:47 +0000 Subject: [Koha-bugs] [Bug 13070] Managing staged MARC records, sorting by title should ignore articles In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13070 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick at bywatersolutions.com Status|NEW |RESOLVED Resolution|--- |DUPLICATE --- Comment #5 from Nick Clemens --- I think Katrin is right, manage staged marc doesn't work because of server side processing, combining these *** This bug has been marked as a duplicate of bug 13054 *** -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 7 15:28:47 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Jan 2020 14:28:47 +0000 Subject: [Koha-bugs] [Bug 13054] Allow server-side sorting by title to ignore custom sets of articles In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13054 --- Comment #4 from Nick Clemens --- *** Bug 13070 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 7 15:32:53 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Jan 2020 14:32:53 +0000 Subject: [Koha-bugs] [Bug 13054] Allow server-side sorting by title to ignore custom sets of articles In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13054 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick at bywatersolutions.com --- Comment #5 from Nick Clemens --- A possible workaround for titles at least would be to respect the non-filing indications into the title field in the DB, or a new title_sort field - this would need to address the different MARC21/UNIMARC implementations -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jan 7 15:39:21 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Jan 2020 14:39:21 +0000 Subject: [Koha-bugs] [Bug 21684] Koha::Object[s]->delete methods must behave identically as the corresponding DBIx::Class ones In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21684 --- Comment #34 from Marcel de Rooy --- (In reply to Jonathan Druart from comment #33) > I do not understand exactly what you mean. Short version: Get rid of 0E0 ? > I do not think it's expensive, the _new_from_dbic will do nothing if the > object is not reused after ->delete. So only _get_object_class will be > effective. Sounds good to me. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 7 15:50:36 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Jan 2020 14:50:36 +0000 Subject: [Koha-bugs] [Bug 24365] New: Using strict from TmplTokenizer.pm broke the translator script Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24365 Bug ID: 24365 Summary: Using strict from TmplTokenizer.pm broke the translator script Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: major Priority: P5 - low Component: I18N/L10N Assignee: jonathan.druart at bugs.koha-community.org Reporter: jonathan.druart at bugs.koha-community.org QA Contact: testopia at bugs.koha-community.org CC: frederic at tamil.fr I am not sure what happened here, but adding strict for TmplTokenizer.pm breaks a test for translation: kohadev-koha at 5dbfd5c26b19:/kohadevbox/koha$ prove xt/author/translatable-templates.t xt/author/translatable-templates.t .. 1/? # Failed test 'opac_bootstrap templates are translatable' # at xt/author/translatable-templates.t line 91. # /tmp/nUR3OD9D9y:19466:8: invalid multibyte sequence # # msgmerge: found 1 fatal error # xt/author/translatable-templates.t .. 2/? # Failed test 'staff_prog templates are translatable' # at xt/author/translatable-templates.t line 91. # /tmp/DdbDRQTBzl:6111:13: invalid multibyte sequence # # /tmp/DdbDRQTBzl:6122:13: invalid multibyte sequence # # /tmp/DdbDRQTBzl:10911:14: invalid multibyte sequence # # /tmp/DdbDRQTBzl:11301:14: invalid multibyte sequence # # /tmp/DdbDRQTBzl:49459:66: invalid multibyte sequence # # /tmp/DdbDRQTBzl:65223:27: invalid multibyte sequence # # /tmp/DdbDRQTBzl:88587:10: invalid multibyte sequence # # /tmp/DdbDRQTBzl:94544:43: invalid multibyte sequence # # /tmp/DdbDRQTBzl:94544:71: invalid multibyte sequence # # /tmp/DdbDRQTBzl:94549:8: invalid multibyte sequence # # msgmerge: found 10 fatal errors # # Looks like you failed 2 tests of 2. xt/author/translatable-templates.t .. Dubious, test returned 2 (wstat 512, 0x200) Failed 2/2 subtests Test Summary Report ------------------- xt/author/translatable-templates.t (Wstat: 512 Tests: 2 Failed: 2) Failed tests: 1-2 Non-zero exit status: 2 Files=1, Tests=2, 8 wallclock secs ( 0.02 usr 0.01 sys + 8.55 cusr 0.08 csys = 8.66 CPU) Result: FAIL -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 7 15:50:58 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Jan 2020 14:50:58 +0000 Subject: [Koha-bugs] [Bug 24217] use strict for all modules In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24217 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |24365 --- Comment #11 from Jonathan Druart --- It broke the translator script, see bug 24365. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24365 [Bug 24365] Using strict from TmplTokenizer.pm broke the translator script -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 7 15:50:58 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Jan 2020 14:50:58 +0000 Subject: [Koha-bugs] [Bug 24365] Using strict from TmplTokenizer.pm broke the translator script In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24365 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |24217 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24217 [Bug 24217] use strict for all modules -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 7 15:54:11 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Jan 2020 14:54:11 +0000 Subject: [Koha-bugs] [Bug 24365] Using strict from TmplTokenizer.pm broke the translator script In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24365 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 7 15:54:15 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Jan 2020 14:54:15 +0000 Subject: [Koha-bugs] [Bug 24365] Using strict from TmplTokenizer.pm broke the translator script In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24365 --- Comment #1 from Jonathan Druart --- Created attachment 96896 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96896&action=edit Bug 24365: (bug 24217 follow-up) Fix encoding issue for translator script I am not sure what happened here, but adding strict for TmplTokenizer.pm breaks a test for translation. It has been caught by a failing test: % prove xt/author/translatable-templates.t will display lines "invalid multibyte sequence" I did a diff between the generated files and found: < msgid "Ã rbok" --- > msgid "Årbok" Which made me think of an encoding issue. Specifying the encoding when write open the file fixes the problem. Test plan: % prove xt/author/translatable-templates.t must return green -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 7 15:57:45 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Jan 2020 14:57:45 +0000 Subject: [Koha-bugs] [Bug 21684] Koha::Object[s]->delete methods must behave identically as the corresponding DBIx::Class ones In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21684 --- Comment #35 from Jonathan Druart --- (In reply to Marcel de Rooy from comment #34) > (In reply to Jonathan Druart from comment #33) > > I do not understand exactly what you mean. > Short version: Get rid of 0E0 ? How? It's the expected behavior (DBI return value). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 7 15:58:56 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Jan 2020 14:58:56 +0000 Subject: [Koha-bugs] [Bug 21684] Koha::Object[s]->delete methods must behave identically as the corresponding DBIx::Class ones In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21684 --- Comment #36 from Jonathan Druart --- As I wrote in the commit message, IMO the whole thing needs a rewrite, to deal with deleting a set in a transaction. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 7 16:02:56 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Jan 2020 15:02:56 +0000 Subject: [Koha-bugs] [Bug 21684] Koha::Object[s]->delete methods must behave identically as the corresponding DBIx::Class ones In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21684 --- Comment #37 from Marcel de Rooy --- (In reply to Jonathan Druart from comment #35) > (In reply to Marcel de Rooy from comment #34) > > (In reply to Jonathan Druart from comment #33) > > > I do not understand exactly what you mean. > > Short version: Get rid of 0E0 ? > > How? It's the expected behavior (DBI return value). Theoretically it might not be DBI. And DBIx depends on the backend. But we can leave it for now; much more of this kind. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 7 16:03:51 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Jan 2020 15:03:51 +0000 Subject: [Koha-bugs] [Bug 24150] Add missing Koha::Old::*[s] classes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24150 --- Comment #15 from Jonathan Druart --- Created attachment 96897 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96897&action=edit Bug 24150: Prevent random failure comparing updated_on Jenkins is currently failing (slow server, datetime comparison, etc.) koha_1 | # Failed test at t/db_dependent/Koha/Old.t line 48. koha_1 | # Structures begin differing at: koha_1 | # $got->{updated_on} = '2020-01-07 14:15:22' koha_1 | # $expected->{updated_on} = '2020-01-07 14:15:21' koha_1 | # Looks like you failed 1 test of 1. koha_1 | koha_1 | # Failed test 'Koha::Old::Patrons' koha_1 | # at t/db_dependent/Koha/Old.t line 49. koha_1 | # Looks like you failed 1 test of 2. koha_1 | [14:15:22] t/db_dependent/Koha/Old.t ............................................... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 7 16:04:09 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Jan 2020 15:04:09 +0000 Subject: [Koha-bugs] [Bug 24150] Add missing Koha::Old::*[s] classes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24150 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |additional_work_needed -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 7 16:07:02 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Jan 2020 15:07:02 +0000 Subject: [Koha-bugs] [Bug 24365] Using strict from TmplTokenizer.pm broke the translator script In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24365 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com Status|Needs Signoff |Signed Off --- Comment #2 from Martin Renvoize --- Trivial fix, PQA and Pushing -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 7 16:07:08 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Jan 2020 15:07:08 +0000 Subject: [Koha-bugs] [Bug 24365] Using strict from TmplTokenizer.pm broke the translator script In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24365 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 7 16:07:30 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Jan 2020 15:07:30 +0000 Subject: [Koha-bugs] [Bug 21684] Koha::Object[s]->delete methods must behave identically as the corresponding DBIx::Class ones In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21684 --- Comment #38 from Jonathan Druart --- Created attachment 96898 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96898&action=edit Bug 21684: Fix Hold.t -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 7 16:07:48 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Jan 2020 15:07:48 +0000 Subject: [Koha-bugs] [Bug 22284] Groups of pickup locations for holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 Caroline Cyr La Rose changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|Manual, | |release-notes-needed | CC| |caroline.cyr-la-rose at inlibr | |o.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 7 16:07:49 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Jan 2020 15:07:49 +0000 Subject: [Koha-bugs] [Bug 24365] Using strict from TmplTokenizer.pm broke the translator script In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24365 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |20.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 7 16:07:51 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Jan 2020 15:07:51 +0000 Subject: [Koha-bugs] [Bug 24365] Using strict from TmplTokenizer.pm broke the translator script In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24365 --- Comment #3 from Martin Renvoize --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 7 16:11:59 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Jan 2020 15:11:59 +0000 Subject: [Koha-bugs] [Bug 24366] New: Merging biblioitems should happen in Koha::Biblio->to_api Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24366 Bug ID: 24366 Summary: Merging biblioitems should happen in Koha::Biblio->to_api Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: REST API Assignee: koha-bugs at lists.koha-community.org Reporter: tomascohen at gmail.com Now we can embed objects, we need to make sure the JSON representation of a biblio object (which includes information from biblioitems) is generated in Koha::Biblio->to_api instead of the API controller. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jan 7 16:12:05 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Jan 2020 15:12:05 +0000 Subject: [Koha-bugs] [Bug 24366] Merging biblioitems should happen in Koha::Biblio->to_api In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24366 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |tomascohen at gmail.com |ity.org | Depends on| |24228 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24228 [Bug 24228] Add a parameter to recursively embed objects in Koha::Object(s)->to_api -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 7 16:12:05 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Jan 2020 15:12:05 +0000 Subject: [Koha-bugs] [Bug 24228] Add a parameter to recursively embed objects in Koha::Object(s)->to_api In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24228 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |24366 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24366 [Bug 24366] Merging biblioitems should happen in Koha::Biblio->to_api -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 7 16:21:29 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Jan 2020 15:21:29 +0000 Subject: [Koha-bugs] [Bug 24363] Datepicker calendar is not sexy on additem.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24363 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 7 16:21:32 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Jan 2020 15:21:32 +0000 Subject: [Koha-bugs] [Bug 24363] Datepicker calendar is not sexy on additem.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24363 --- Comment #2 from Lucas Gass --- Created attachment 96899 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96899&action=edit Bug 24363: Small CSS change to align datepicker within input This is a small CSS change to align the datepicker within the input TEST PLAN: 1. Look at additem.pl datepicker and notice it isn't too sexy. 2. Apply patch and regenerate CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client) 3. Look at the additem.pl datepicker and see that it looks better. 4. Since the SCSS for ui-datepicker-trigger is global take some time to look at other date pickers in the Koha staff client and confirm they also look good. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 7 16:21:50 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Jan 2020 15:21:50 +0000 Subject: [Koha-bugs] [Bug 24363] Datepicker calendar is not sexy on additem.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24363 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas at bywatersolutions.com Assignee|oleonard at myacpl.org |lucas at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 7 16:27:10 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Jan 2020 15:27:10 +0000 Subject: [Koha-bugs] [Bug 22784] Archiving Purchase Suggestions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22784 ByWater Sandboxes changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95533|0 |1 is obsolete| | --- Comment #23 from ByWater Sandboxes --- Created attachment 96900 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96900&action=edit Bug 22784: DB Changes Sponsored-by: BULAC - http://www.bulac.fr/ Signed-off-by: Séverine QUEUNE Signed-off-by: Kelly McElligott -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 7 16:27:13 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Jan 2020 15:27:13 +0000 Subject: [Koha-bugs] [Bug 22784] Archiving Purchase Suggestions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22784 ByWater Sandboxes changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95534|0 |1 is obsolete| | --- Comment #24 from ByWater Sandboxes --- Created attachment 96901 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96901&action=edit Bug 22784: DBIC Changes Sponsored-by: BULAC - http://www.bulac.fr/ Signed-off-by: Séverine QUEUNE Signed-off-by: Kelly McElligott -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 7 16:27:15 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Jan 2020 15:27:15 +0000 Subject: [Koha-bugs] [Bug 22784] Archiving Purchase Suggestions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22784 ByWater Sandboxes changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95535|0 |1 is obsolete| | --- Comment #25 from ByWater Sandboxes --- Created attachment 96902 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96902&action=edit Bug 22784: Add the ability to archive/unarchive a purchase suggestions There are performance issues when searching suggestions if there are thousands of suggestions. To prevent that we are going to add the ability to archive purchase suggestions, in order to remove them from the search list (by default). Test plan: 0. Apply all the patches, execute the updatedatabase.pl script, restart all 1. Create some suggestions 2. Search for them 3. Use the "Archive" action button for one of them 4. Restart the search => The archived suggestion does no longer appear in the list 5. Use the filter "Included archived" in the "Suggestion information" filter box => The archived suggestion is now displayed 6. Use other filters => The "archived" filter is kept from one search to another 7. Use one of the action at the bottom of the suggestion list (change the status for instance) => The "archived" filter is still kept Sponsored-by: BULAC - http://www.bulac.fr/ Signed-off-by: Séverine QUEUNE Signed-off-by: Kelly McElligott -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 7 16:27:19 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Jan 2020 15:27:19 +0000 Subject: [Koha-bugs] [Bug 22784] Archiving Purchase Suggestions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22784 ByWater Sandboxes changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95536|0 |1 is obsolete| | --- Comment #26 from ByWater Sandboxes --- Created attachment 96903 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96903&action=edit Bug 22784: Bugfix - do not modify #description build Debian packages from a git repository Signed-off-by: Séverine QUEUNE Signed-off-by: Kelly McElligott -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 7 16:27:22 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Jan 2020 15:27:22 +0000 Subject: [Koha-bugs] [Bug 22784] Archiving Purchase Suggestions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22784 ByWater Sandboxes changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95537|0 |1 is obsolete| | --- Comment #27 from ByWater Sandboxes --- Created attachment 96904 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96904&action=edit Bug 22784: Do not display an empty table This is terrible and highlight that the whole script must be rewrite. GetDistinctValues does not handle the "archived" flag (and we do not want to put our hands there), so let's hack that and plan to rewrite the whole script. Signed-off-by: Séverine QUEUNE Signed-off-by: Kelly McElligott -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 7 16:27:26 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Jan 2020 15:27:26 +0000 Subject: [Koha-bugs] [Bug 22784] Archiving Purchase Suggestions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22784 ByWater Sandboxes changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95538|0 |1 is obsolete| | --- Comment #28 from ByWater Sandboxes --- Created attachment 96905 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96905&action=edit Bug 22784: Add a cronjob to archive suggestions given age or status criteria In order to deal automatically with suggestions that need to be archived, this cronjob will help to add the "archived" flag following their age or status. Test plan: - Execute the script with the --help parameter and read the documentation. - Does it make sense? - Use it without the --confirm flag and try several combination For instance you will want to archive suggestions that have been rejected for more than a week: perl misc/cronjobs/archive_purchase_suggestions.pl --age-date-field=rejecteddate --age=weeks:1 or even suggestion that have been suggested for more than a year and have a ORDERED status: perl misc/cronjobs/archive_purchase_suggestions.pl --age-date-field=suggesteddate --age=years:1 --status=ORDERED - Use it with the --confirm flag and make sure the suggestions have been archived. Sponsored-by: BULAC - http://www.bulac.fr/ Signed-off-by: Séverine QUEUNE Signed-off-by: Kelly McElligott -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 7 16:29:52 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Jan 2020 15:29:52 +0000 Subject: [Koha-bugs] [Bug 24362] Elasticsearch - Sorting by title does not ignore leading articles In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24362 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|DUPLICATE |--- Status|RESOLVED |REOPENED -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jan 7 16:30:01 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Jan 2020 15:30:01 +0000 Subject: [Koha-bugs] [Bug 24362] Elasticsearch - Sorting by title does not ignore leading articles In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24362 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|REOPENED |NEW -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 7 16:39:56 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Jan 2020 15:39:56 +0000 Subject: [Koha-bugs] [Bug 22773] Bulk Close invoices and Filter invoice view (open/closed) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22773 ByWater Sandboxes changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #93375|0 |1 is obsolete| | --- Comment #14 from ByWater Sandboxes --- Created attachment 96906 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96906&action=edit Bug 22773: Bulk Close invoices and Filter invoice view (open/closed) Signed-off-by: Andrew Fuerste-Henry Signed-off-by: Kelly McElligott -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 7 16:39:59 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Jan 2020 15:39:59 +0000 Subject: [Koha-bugs] [Bug 22773] Bulk Close invoices and Filter invoice view (open/closed) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22773 ByWater Sandboxes changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #93448|0 |1 is obsolete| | --- Comment #15 from ByWater Sandboxes --- Created attachment 96907 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96907&action=edit Bug 22773: (follow-up) Fix capitalization Signed-off-by: Kelly McElligott -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 7 16:40:01 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Jan 2020 15:40:01 +0000 Subject: [Koha-bugs] [Bug 22773] Bulk Close invoices and Filter invoice view (open/closed) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22773 ByWater Sandboxes changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #93660|0 |1 is obsolete| | --- Comment #16 from ByWater Sandboxes --- Created attachment 96908 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96908&action=edit Bug 22773: Message appearing if any invoice selected Signed-off-by: Kelly McElligott -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 7 16:40:04 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Jan 2020 15:40:04 +0000 Subject: [Koha-bugs] [Bug 22773] Bulk Close invoices and Filter invoice view (open/closed) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22773 ByWater Sandboxes changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #94411|0 |1 is obsolete| | --- Comment #17 from ByWater Sandboxes --- Created attachment 96909 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96909&action=edit Bug 22773: (follow-up) Recommended changes are made on datatable and butons Signed-off-by: Kelly McElligott -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 7 16:40:06 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Jan 2020 15:40:06 +0000 Subject: [Koha-bugs] [Bug 22773] Bulk Close invoices and Filter invoice view (open/closed) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22773 ByWater Sandboxes changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95290|0 |1 is obsolete| | --- Comment #18 from ByWater Sandboxes --- Created attachment 96910 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96910&action=edit Bug 22773: The deprecated plugin is removed Signed-off-by: Kelly McElligott -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 7 16:44:05 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Jan 2020 15:44:05 +0000 Subject: [Koha-bugs] [Bug 22773] Bulk Close invoices and Filter invoice view (open/closed) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22773 Kelly McElligott changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kelly at bywatersolutions.com Status|Needs Signoff |Signed Off --- Comment #19 from Kelly McElligott --- I am signing off on this bug. To comment on Jonathan's comments. 2. Click "Show only subscriptions" label does not select the checkbox. Missing id. I created a subscription order and this worked as the other orders did. If there are no subscriptions then it produces no results which will not let you move on. 3. You can select subscriptions from the 2 tabs then click "Merge selected invoices". It's expected but as the button is inside the tab (so 2 buttons) it's not obvious. I am not sure what this means? I did merge two invoices and it worked correctly. If anything the merge button is not as pronounced (no black outline) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 7 16:48:51 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Jan 2020 15:48:51 +0000 Subject: [Koha-bugs] [Bug 24362] Elasticsearch - Sorting by title does not ignore leading articles In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24362 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |DUPLICATE --- Comment #2 from Katrin Fischer --- *** This bug has been marked as a duplicate of bug 22771 *** -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jan 7 16:48:51 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Jan 2020 15:48:51 +0000 Subject: [Koha-bugs] [Bug 22771] Elasticsearch - Sort by title do not considerate second indicator of field 245 (marc21) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22771 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick at bywatersolutions.com --- Comment #2 from Katrin Fischer --- *** Bug 24362 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jan 7 16:53:39 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Jan 2020 15:53:39 +0000 Subject: [Koha-bugs] [Bug 24367] New: With strict enabled, Search.t is too verbose Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24367 Bug ID: 24367 Summary: With strict enabled, Search.t is too verbose Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs at lists.koha-community.org Reporter: jonathan.druart at bugs.koha-community.org QA Contact: testopia at bugs.koha-community.org Depends on: 24217 There are tons of warnings displayed when running Search.t Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24217 [Bug 24217] use strict for all modules -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 7 16:53:39 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Jan 2020 15:53:39 +0000 Subject: [Koha-bugs] [Bug 24217] use strict for all modules In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24217 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |24367 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24367 [Bug 24367] With strict enabled, Search.t is too verbose -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 7 16:55:13 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Jan 2020 15:55:13 +0000 Subject: [Koha-bugs] [Bug 24312] Update MARC21 frameworks to Updates 28+29 (May and November 2019) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24312 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |20.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 7 16:55:15 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Jan 2020 15:55:15 +0000 Subject: [Koha-bugs] [Bug 24312] Update MARC21 frameworks to Updates 28+29 (May and November 2019) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24312 --- Comment #9 from Martin Renvoize --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 7 16:55:17 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Jan 2020 15:55:17 +0000 Subject: [Koha-bugs] [Bug 24314] Update de-DE MARC21 frameworks for updates 28+29 (May and November 2019) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24314 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |20.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 7 16:55:18 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Jan 2020 15:55:18 +0000 Subject: [Koha-bugs] [Bug 24314] Update de-DE MARC21 frameworks for updates 28+29 (May and November 2019) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24314 --- Comment #10 from Martin Renvoize --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 7 16:55:20 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Jan 2020 15:55:20 +0000 Subject: [Koha-bugs] [Bug 24328] Bibliographic frameworks fail to install In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24328 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |20.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 7 16:55:22 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Jan 2020 15:55:22 +0000 Subject: [Koha-bugs] [Bug 24328] Bibliographic frameworks fail to install In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24328 --- Comment #5 from Martin Renvoize --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 7 16:55:47 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Jan 2020 15:55:47 +0000 Subject: [Koha-bugs] [Bug 24367] With strict enabled, Search.t is too verbose In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24367 --- Comment #1 from Jonathan Druart --- Created attachment 96911 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96911&action=edit Bug 24367: Remove warning from Search.t Not done yet. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 7 17:28:20 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Jan 2020 16:28:20 +0000 Subject: [Koha-bugs] [Bug 24150] Add missing Koha::Old::*[s] classes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24150 --- Comment #16 from Martin Renvoize --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 7 17:28:38 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Jan 2020 16:28:38 +0000 Subject: [Koha-bugs] [Bug 24150] Add missing Koha::Old::*[s] classes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24150 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|additional_work_needed | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 7 17:29:59 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Jan 2020 16:29:59 +0000 Subject: [Koha-bugs] [Bug 23982] Count/pagination broken for reports with duplicated column names In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23982 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|additional_work_needed | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 7 17:30:26 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Jan 2020 16:30:26 +0000 Subject: [Koha-bugs] [Bug 23982] Count/pagination broken for reports with duplicated column names In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23982 --- Comment #11 from Martin Renvoize --- Test Fix pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 7 17:30:55 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Jan 2020 16:30:55 +0000 Subject: [Koha-bugs] [Bug 22744] Remove confusing 'Do not notify' checkboxes from messaging preferences In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22744 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|additional_work_needed | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 7 17:34:41 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Jan 2020 16:34:41 +0000 Subject: [Koha-bugs] [Bug 21684] Koha::Object[s]->delete methods must behave identically as the corresponding DBIx::Class ones In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21684 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|additional_work_needed | --- Comment #39 from Martin Renvoize --- 4 followups pushed.. code all makes sense to me and resolves the failures. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 7 17:50:47 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Jan 2020 16:50:47 +0000 Subject: [Koha-bugs] [Bug 24350] Can't place holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24350 Caroline Cyr La Rose changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 7 17:50:50 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Jan 2020 16:50:50 +0000 Subject: [Koha-bugs] [Bug 24350] Can't place holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24350 Caroline Cyr La Rose changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #96860|0 |1 is obsolete| | --- Comment #5 from Caroline Cyr La Rose --- Created attachment 96912 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96912&action=edit Bug 24350: Fix Branches.pickup_locations This will fix the following error: Template process failed: undef error - Not a HASH reference at /home/vagrant/kohaclone/Koha/Template/Plugin/Branches.pm line 96. at /home/vagrant/kohaclone/C4/Templates.pm line 122 Koha::Libraries->pickup_locations does not always return an array, but arrayref if $biblio is not a Koha::Biblio object. I do not think it's the correct fix, the pattern in Koha::Libraries->pickup_locations is wrong: we should not expect 2 different types for a given parameter, biblio should always be a Koha::Biblio (idem for item btw). That could be fixed easily if the template had the Koha::Biblio object sent. Signed-off-by: Caroline Cyr La Rose -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 7 17:53:48 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Jan 2020 16:53:48 +0000 Subject: [Koha-bugs] [Bug 24350] Can't place holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24350 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com --- Comment #6 from Martin Renvoize --- Agreed that longer term we should do the refactoring fix.. but this is a pragmatic solution to get things working again so I'm happy to take it as is.. I'll add a dependant bug for the refactor now so we don't forget it. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 7 18:01:59 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Jan 2020 17:01:59 +0000 Subject: [Koha-bugs] [Bug 24350] Can't place holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24350 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #96912|0 |1 is obsolete| | --- Comment #7 from Martin Renvoize --- Created attachment 96913 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96913&action=edit Bug 24350: Fix Branches.pickup_locations This will fix the following error: Template process failed: undef error - Not a HASH reference at /home/vagrant/kohaclone/Koha/Template/Plugin/Branches.pm line 96. at /home/vagrant/kohaclone/C4/Templates.pm line 122 Koha::Libraries->pickup_locations does not always return an array, but arrayref if $biblio is not a Koha::Biblio object. I do not think it's the correct fix, the pattern in Koha::Libraries->pickup_locations is wrong: we should not expect 2 different types for a given parameter, biblio should always be a Koha::Biblio (idem for item btw). That could be fixed easily if the template had the Koha::Biblio object sent. Signed-off-by: Caroline Cyr La Rose Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 7 18:03:30 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Jan 2020 17:03:30 +0000 Subject: [Koha-bugs] [Bug 21684] Koha::Object[s]->delete methods must behave identically as the corresponding DBIx::Class ones In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21684 --- Comment #40 from Martin Renvoize --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 7 18:03:46 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Jan 2020 17:03:46 +0000 Subject: [Koha-bugs] [Bug 24350] Can't place holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24350 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 7 18:04:00 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Jan 2020 17:04:00 +0000 Subject: [Koha-bugs] [Bug 24350] Can't place holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24350 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |20.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 7 18:04:02 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Jan 2020 17:04:02 +0000 Subject: [Koha-bugs] [Bug 24350] Can't place holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24350 --- Comment #8 from Martin Renvoize --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 7 18:06:26 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Jan 2020 17:06:26 +0000 Subject: [Koha-bugs] [Bug 24368] New: Koha::Libraries->pickup_locations needs refactoring/ratifying Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24368 Bug ID: 24368 Summary: Koha::Libraries->pickup_locations needs refactoring/ratifying Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs at lists.koha-community.org Reporter: martin.renvoize at ptfs-europe.com QA Contact: testopia at bugs.koha-community.org Koha::Libraries->pickup_locations is wrong: we should not expect 2 different types for a given parameter, biblio should always be a Koha::Biblio (idem for item btw). See bug 24350 for further details -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jan 7 18:06:37 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Jan 2020 17:06:37 +0000 Subject: [Koha-bugs] [Bug 24368] Koha::Libraries->pickup_locations needs refactoring/ratifying In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24368 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |24350 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24350 [Bug 24350] Can't place holds -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 7 18:06:37 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Jan 2020 17:06:37 +0000 Subject: [Koha-bugs] [Bug 24350] Can't place holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24350 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |24368 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24368 [Bug 24368] Koha::Libraries->pickup_locations needs refactoring/ratifying -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 7 18:19:31 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Jan 2020 17:19:31 +0000 Subject: [Koha-bugs] [Bug 24368] Koha::Libraries->pickup_locations needs refactoring/ratifying In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24368 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com --- Comment #1 from Tomás Cohen Arazi --- In my opinion, we might not need the TT plugin in a short term, as we could just implement API calls that invoke the underlying ->pickup_locations methods in Koha::Biblio and Koha::Item (bug 24302 for reference). -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 7 18:26:45 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Jan 2020 17:26:45 +0000 Subject: [Koha-bugs] [Bug 24369] New: Add ability to set CORS header in Koha Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24369 Bug ID: 24369 Summary: Add ability to set CORS header in Koha Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs at lists.koha-community.org Reporter: kyle at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org The reports API can produce JSON that would be useful on other library related websites, but the use of it appears to be blocked by default via CORS. It would be nice if there were a Koha syspref to set the CORS header rather than mucking about with htaccess files and whatnot. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 7 18:27:01 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Jan 2020 17:27:01 +0000 Subject: [Koha-bugs] [Bug 24369] Add ability to set CORS header in Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24369 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |tomascohen at gmail.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jan 7 18:27:09 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Jan 2020 17:27:09 +0000 Subject: [Koha-bugs] [Bug 24369] Add ability to set CORS header in Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24369 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 7 18:39:18 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Jan 2020 17:39:18 +0000 Subject: [Koha-bugs] [Bug 24369] Add ability to set CORS header in Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24369 --- Comment #1 from Tomás Cohen Arazi --- There are two APIs actually that could benefit from this: - /svc - /api/v1 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 7 18:42:08 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Jan 2020 17:42:08 +0000 Subject: [Koha-bugs] [Bug 24370] New: Editing Purchase Suggestion changes the Acquisition Library Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24370 Bug ID: 24370 Summary: Editing Purchase Suggestion changes the Acquisition Library Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Acquisitions Assignee: koha-bugs at lists.koha-community.org Reporter: lisetteslatah at gmail.com QA Contact: testopia at bugs.koha-community.org Editing a suggestion changes the Acquisition Library to be the user's logged in branch. As a multi-branch system, we'd like to be able to edit and keep that information. This helps us track requests and spending from different branches. The branch is only changed on edit, not when batch changing statuses. Lisette -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 7 18:46:05 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Jan 2020 17:46:05 +0000 Subject: [Koha-bugs] [Bug 24366] Merging biblioitems should happen in Koha::Biblio->to_api In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24366 --- Comment #1 from Tomás Cohen Arazi --- Created attachment 96914 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96914&action=edit Bug 24366: Unit tests -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 7 18:46:19 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Jan 2020 17:46:19 +0000 Subject: [Koha-bugs] [Bug 24366] Merging biblioitems should happen in Koha::Biblio->to_api In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24366 --- Comment #2 from Tomás Cohen Arazi --- Created attachment 96915 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96915&action=edit Bug 24366: Merge biblioitem in Koha::Biblio->to_api This patch moves the bilbioitem object merge into the Koha::Biblio->to_api method, as opposed to doing it in the controller. This is an inevitable change as other endpoints might require to embed biblio objects, and they need to carry the biblioitem information. Also, if we merge the tables, the transition will be straightforward (remove the tests this patch introduces, and merge the mappings from Koha::Biblioitem into Koha::Biblio). To test: 1. Apply this patches 2. Run: $ kshell k$ prove t/db_dependent/Koha/Biblio.t \ t/db_dependent/api/v1/biblios.t => SUCCESS: Tests pass! i.e. the new to_api method is tested, and the API tests don't expect any behavior change. 3. Sign off :-D -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 7 18:47:07 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Jan 2020 17:47:07 +0000 Subject: [Koha-bugs] [Bug 24366] Merging biblioitems should happen in Koha::Biblio->to_api In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24366 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |20212 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20212 [Bug 20212] Slowness in Receiving in Acquisitions -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 7 18:47:07 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Jan 2020 17:47:07 +0000 Subject: [Koha-bugs] [Bug 20212] Slowness in Receiving in Acquisitions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20212 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |24366 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24366 [Bug 24366] Merging biblioitems should happen in Koha::Biblio->to_api -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 7 18:47:19 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Jan 2020 17:47:19 +0000 Subject: [Koha-bugs] [Bug 24366] Merging biblioitems should happen in Koha::Biblio->to_api In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24366 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 7 18:49:41 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Jan 2020 17:49:41 +0000 Subject: [Koha-bugs] [Bug 18731] Add routes for acquisition orders In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18731 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #96856|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 7 18:49:43 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Jan 2020 17:49:43 +0000 Subject: [Koha-bugs] [Bug 18731] Add routes for acquisition orders In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18731 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #96857|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 7 18:49:46 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Jan 2020 17:49:46 +0000 Subject: [Koha-bugs] [Bug 18731] Add routes for acquisition orders In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18731 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #96858|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 7 18:50:54 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Jan 2020 17:50:54 +0000 Subject: [Koha-bugs] [Bug 18731] Add routes for acquisition orders In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18731 --- Comment #27 from Tomás Cohen Arazi --- Created attachment 96916 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96916&action=edit Bug 18731: /acquisitions/orders endpoint This patches implement the /acquisitions/orders endpoint. The attribute names are consistent with the voted RFC To test: 1. Apply this patchset 2. Run: $ kshell k$ prove t/db_dependent/api/v1/acquisitions_orders.t => SUCCESS: Tests pass! 3. Test the API with your favourite tool (Postman?) => SUCCESS: It works as expected! 4 Sign off :-D Sponsored-by: Camden County Signed-off-by: Matthias Meusburger -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 7 18:50:58 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Jan 2020 17:50:58 +0000 Subject: [Koha-bugs] [Bug 18731] Add routes for acquisition orders In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18731 --- Comment #28 from Tomás Cohen Arazi --- Created attachment 96917 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96917&action=edit Bug 18731: Add API mappings to K::A::{Basket,Invoice} This patch adds to_api_mapping definitions to the following classes: - Koha::Acquisition::Basket - Koha::Acquisition::Invoice They are implemented following the proposed RFCs: https://wiki.koha-community.org/wiki/Acquisitions_baskets_endpoint_RFC https://wiki.koha-community.org/wiki/Acquisitions_invoices_endpoint_RFC -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 7 18:51:02 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Jan 2020 17:51:02 +0000 Subject: [Koha-bugs] [Bug 18731] Add routes for acquisition orders In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18731 --- Comment #29 from Tomás Cohen Arazi --- Created attachment 96918 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96918&action=edit Bug 18731: Use the stashed koha.embed in objects.search This patch makes the objects.search helper use the koha.embed structure that is embedded in the authenticate_api_request step. This way, any controller using it will benefit from automatic embed handling. To test: 1. Apply this patch 2. Run: $ kshell k$ prove t/db_dependent/Koha/REST/Plugin/Objects.t => SUCCESS: Tests pass! 3. Sign off :-D -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 7 18:55:58 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Jan 2020 17:55:58 +0000 Subject: [Koha-bugs] [Bug 13327] OPACPopupAuthorsSearch doesn't work with XSLT views In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13327 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 7 18:56:00 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Jan 2020 17:56:00 +0000 Subject: [Koha-bugs] [Bug 13327] OPACPopupAuthorsSearch doesn't work with XSLT views In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13327 --- Comment #2 from Owen Leonard --- Created attachment 96919 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96919&action=edit Bug 13327: OPACPopupAuthorsSearch doesn't work with XSLT views This patch reimplements the OPACPopupAuthorsSearch feature so that it will work in the XSLT view. To test, apply the patch and view the detail page for a bibliographic record in the OPAC. Test under the following conditions: - OPACPopupAuthorsSearch ENABLED, OPACXSLTDetailsDisplay "default" - OPACPopupAuthorsSearch ENABLED, OPACXSLTDetailsDisplay empty - OPACPopupAuthorsSearch DISABLED, OPACXSLTDetailsDisplay "default" - OPACPopupAuthorsSearch DISABLED, OPACXSLTDetailsDisplay empty In each of these cases, test the detail page's listing of additional authors/contributors. Test records which have both multiple contributors and which have only one additional author. When OPACPopupAuthorsSearch is turned on, verify that the author selection modal appears and that your selections are correctly combined to build a search string. Note that OPACPopupAuthorsSearch feature has a problem with terms containing parentheses. The issue predates this patch. Also note that the QA tools will give a false positive about Bootstrap button styles. This rule only applies to the staff client. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 7 19:00:10 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Jan 2020 18:00:10 +0000 Subject: [Koha-bugs] [Bug 24181] Make our datepicker inputs sexy In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24181 --- Comment #16 from Caroline Cyr La Rose --- I was going through all the datepickers and found one that is still thinner, in checkexpiration.pl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 7 19:02:42 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Jan 2020 18:02:42 +0000 Subject: [Koha-bugs] [Bug 23893] Add ->new_from_api and ->set_from_api methods to Koha::Object In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23893 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 7 19:02:45 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Jan 2020 18:02:45 +0000 Subject: [Koha-bugs] [Bug 23893] Add ->new_from_api and ->set_from_api methods to Koha::Object In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23893 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #96655|0 |1 is obsolete| | Attachment #96656|0 |1 is obsolete| | Attachment #96657|0 |1 is obsolete| | Attachment #96658|0 |1 is obsolete| | Attachment #96659|0 |1 is obsolete| | Attachment #96660|0 |1 is obsolete| | Attachment #96661|0 |1 is obsolete| | Attachment #96665|0 |1 is obsolete| | Attachment #96666|0 |1 is obsolete| | --- Comment #29 from Kyle M Hall --- Created attachment 96920 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96920&action=edit Bug 23893: Unit tests This patch introduces tests for the implemented methods. Signed-off-by: Josef Moravec Signed-off-by: Tomas Cohen Arazi Signed-off-by: John Doe -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 7 19:03:01 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Jan 2020 18:03:01 +0000 Subject: [Koha-bugs] [Bug 23893] Add ->new_from_api and ->set_from_api methods to Koha::Object In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23893 --- Comment #30 from Kyle M Hall --- Created attachment 96921 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96921&action=edit Bug 23893: Implement Koha::Object->from_api_mapping This patch implements the from_api_mapping method, that calculates (and caches) the reserve mapping from the to_api_mapping method. A generic to_api_mapping is added to simplify things a bit in the generic to_api method and so the mappings are reusable in the way they are in from_api_mapping. To test: 1. Apply this patches 2. Run: $ kshell k$ prove t/db_dependent/Koha/Object.t => SUCCESS: Tests pass! 3. Sign off :-D Signed-off-by: Josef Moravec Signed-off-by: Tomas Cohen Arazi Signed-off-by: John Doe -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 7 19:03:04 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Jan 2020 18:03:04 +0000 Subject: [Koha-bugs] [Bug 23893] Add ->new_from_api and ->set_from_api methods to Koha::Object In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23893 --- Comment #31 from Kyle M Hall --- Created attachment 96922 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96922&action=edit Bug 23893: Add new_from_api and set_from_api to Koha::Object This patch introduces the following methods to the Koha::Object class: - set_from_api - new_from_api This methods are going to be used when writing API controllers that map to the attributes to the DB schema ones. To test: 1. Apply this patchset 2. Run: $ kshell k$ prove t/db_dependent/Koha/Object.t => SUCCESS: Tests pass! 3. Sign off :-D Signed-off-by: Josef Moravec Signed-off-by: Tomas Cohen Arazi Signed-off-by: John Doe -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 7 19:03:07 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Jan 2020 18:03:07 +0000 Subject: [Koha-bugs] [Bug 23893] Add ->new_from_api and ->set_from_api methods to Koha::Object In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23893 --- Comment #32 from Kyle M Hall --- Created attachment 96923 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96923&action=edit Bug 23893: Use in /cities This patch makes the cities controller use the new methods from Koha::Object. To test: 1. Apply this patch 2. Run: $ kshell k$ prove t/db_dependent/api/v1/cities.t => SUCCESS: Tests pass! 3. Sign off :-D Signed-off-by: Josef Moravec Signed-off-by: Tomas Cohen Arazi Signed-off-by: John Doe -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 7 19:03:10 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Jan 2020 18:03:10 +0000 Subject: [Koha-bugs] [Bug 23893] Add ->new_from_api and ->set_from_api methods to Koha::Object In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23893 --- Comment #33 from Kyle M Hall --- Created attachment 96924 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96924&action=edit Bug 23893: Use in /patrons This patch makes the patrons endpoint use the new methods from Koha::Object. To test: 1. Apply this patch 2. Run: $ kshell k$ prove t/db_dependent/api/v1/patrons.t => SUCCESS: Tests pass! 3. Sign off :-D Signed-off-by: Josef Moravec Signed-off-by: Tomas Cohen Arazi Signed-off-by: John Doe -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 7 19:03:14 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Jan 2020 18:03:14 +0000 Subject: [Koha-bugs] [Bug 23893] Add ->new_from_api and ->set_from_api methods to Koha::Object In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23893 --- Comment #34 from Kyle M Hall --- Created attachment 96925 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96925&action=edit Bug 23893: No special care for booleans Tests pass without that changes. If we need them they should be at Koha::Object anyway. About the date, I also think that that should be moved to Koha::Object (we can guess it, like we do in Koha::Object->store, retrieve the datatype and adjust). Also we can send a DT object to DBIC, no need for an sql formatted date Signed-off-by: Tomas Cohen Arazi Signed-off-by: John Doe -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 7 19:03:18 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Jan 2020 18:03:18 +0000 Subject: [Koha-bugs] [Bug 23893] Add ->new_from_api and ->set_from_api methods to Koha::Object In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23893 --- Comment #35 from Kyle M Hall --- Created attachment 96926 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96926&action=edit Bug 23893: (QA follow-up) Explicit date format This patch makes the input date format explicit. It also adds a missing POD. Signed-off-by: Tomas Cohen Arazi Signed-off-by: John Doe -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 7 19:03:21 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Jan 2020 18:03:21 +0000 Subject: [Koha-bugs] [Bug 23893] Add ->new_from_api and ->set_from_api methods to Koha::Object In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23893 --- Comment #36 from Kyle M Hall --- Created attachment 96927 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96927&action=edit Bug 23893: Remove Overloaded method from Koha::Patron That way we are dealing with any date fields for any Koha::Object Signed-off-by: John Doe -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 7 19:03:24 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Jan 2020 18:03:24 +0000 Subject: [Koha-bugs] [Bug 23893] Add ->new_from_api and ->set_from_api methods to Koha::Object In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23893 --- Comment #37 from Kyle M Hall --- Created attachment 96928 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96928&action=edit Bug 23893: Catch dt_from_string exceptions This patch adds exception handling to the attributes_from_api() method. This can happen with invalid date/datetimes, for example. Tests are added: 1. Apply this patch 2. Run: $ kshell k$ prove t/db_dependent/Koha/Object.t => SUCCESS: Tests pass! 3. Sign off :-D Signed-off-by: Tomas Cohen Arazi Signed-off-by: John Doe -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 7 19:19:56 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Jan 2020 18:19:56 +0000 Subject: [Koha-bugs] [Bug 23893] Add ->new_from_api and ->set_from_api methods to Koha::Object In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23893 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #96920|0 |1 is obsolete| | Attachment #96921|0 |1 is obsolete| | Attachment #96922|0 |1 is obsolete| | Attachment #96923|0 |1 is obsolete| | Attachment #96924|0 |1 is obsolete| | Attachment #96925|0 |1 is obsolete| | Attachment #96926|0 |1 is obsolete| | Attachment #96927|0 |1 is obsolete| | Attachment #96928|0 |1 is obsolete| | --- Comment #38 from Kyle M Hall --- Created attachment 96929 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96929&action=edit Bug 23893: Unit tests This patch introduces tests for the implemented methods. Signed-off-by: Josef Moravec Signed-off-by: Tomas Cohen Arazi Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 7 19:20:07 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Jan 2020 18:20:07 +0000 Subject: [Koha-bugs] [Bug 23893] Add ->new_from_api and ->set_from_api methods to Koha::Object In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23893 --- Comment #39 from Kyle M Hall --- Created attachment 96930 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96930&action=edit Bug 23893: Implement Koha::Object->from_api_mapping This patch implements the from_api_mapping method, that calculates (and caches) the reserve mapping from the to_api_mapping method. A generic to_api_mapping is added to simplify things a bit in the generic to_api method and so the mappings are reusable in the way they are in from_api_mapping. To test: 1. Apply this patches 2. Run: $ kshell k$ prove t/db_dependent/Koha/Object.t => SUCCESS: Tests pass! 3. Sign off :-D Signed-off-by: Josef Moravec Signed-off-by: Tomas Cohen Arazi Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 7 19:20:10 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Jan 2020 18:20:10 +0000 Subject: [Koha-bugs] [Bug 23893] Add ->new_from_api and ->set_from_api methods to Koha::Object In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23893 --- Comment #40 from Kyle M Hall --- Created attachment 96931 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96931&action=edit Bug 23893: Add new_from_api and set_from_api to Koha::Object This patch introduces the following methods to the Koha::Object class: - set_from_api - new_from_api This methods are going to be used when writing API controllers that map to the attributes to the DB schema ones. To test: 1. Apply this patchset 2. Run: $ kshell k$ prove t/db_dependent/Koha/Object.t => SUCCESS: Tests pass! 3. Sign off :-D Signed-off-by: Josef Moravec Signed-off-by: Tomas Cohen Arazi Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 7 19:20:14 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Jan 2020 18:20:14 +0000 Subject: [Koha-bugs] [Bug 23893] Add ->new_from_api and ->set_from_api methods to Koha::Object In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23893 --- Comment #41 from Kyle M Hall --- Created attachment 96932 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96932&action=edit Bug 23893: Use in /cities This patch makes the cities controller use the new methods from Koha::Object. To test: 1. Apply this patch 2. Run: $ kshell k$ prove t/db_dependent/api/v1/cities.t => SUCCESS: Tests pass! 3. Sign off :-D Signed-off-by: Josef Moravec Signed-off-by: Tomas Cohen Arazi Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 7 19:20:17 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Jan 2020 18:20:17 +0000 Subject: [Koha-bugs] [Bug 23893] Add ->new_from_api and ->set_from_api methods to Koha::Object In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23893 --- Comment #42 from Kyle M Hall --- Created attachment 96933 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96933&action=edit Bug 23893: Use in /patrons This patch makes the patrons endpoint use the new methods from Koha::Object. To test: 1. Apply this patch 2. Run: $ kshell k$ prove t/db_dependent/api/v1/patrons.t => SUCCESS: Tests pass! 3. Sign off :-D Signed-off-by: Josef Moravec Signed-off-by: Tomas Cohen Arazi Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 7 19:20:21 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Jan 2020 18:20:21 +0000 Subject: [Koha-bugs] [Bug 23893] Add ->new_from_api and ->set_from_api methods to Koha::Object In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23893 --- Comment #43 from Kyle M Hall --- Created attachment 96934 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96934&action=edit Bug 23893: No special care for booleans Tests pass without that changes. If we need them they should be at Koha::Object anyway. About the date, I also think that that should be moved to Koha::Object (we can guess it, like we do in Koha::Object->store, retrieve the datatype and adjust). Also we can send a DT object to DBIC, no need for an sql formatted date Signed-off-by: Tomas Cohen Arazi Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 7 19:20:25 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Jan 2020 18:20:25 +0000 Subject: [Koha-bugs] [Bug 23893] Add ->new_from_api and ->set_from_api methods to Koha::Object In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23893 --- Comment #44 from Kyle M Hall --- Created attachment 96935 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96935&action=edit Bug 23893: (QA follow-up) Explicit date format This patch makes the input date format explicit. It also adds a missing POD. Signed-off-by: Tomas Cohen Arazi Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 7 19:20:29 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Jan 2020 18:20:29 +0000 Subject: [Koha-bugs] [Bug 23893] Add ->new_from_api and ->set_from_api methods to Koha::Object In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23893 --- Comment #45 from Kyle M Hall --- Created attachment 96936 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96936&action=edit Bug 23893: Remove Overloaded method from Koha::Patron That way we are dealing with any date fields for any Koha::Object Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 7 19:20:32 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Jan 2020 18:20:32 +0000 Subject: [Koha-bugs] [Bug 23893] Add ->new_from_api and ->set_from_api methods to Koha::Object In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23893 --- Comment #46 from Kyle M Hall --- Created attachment 96937 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96937&action=edit Bug 23893: Catch dt_from_string exceptions This patch adds exception handling to the attributes_from_api() method. This can happen with invalid date/datetimes, for example. Tests are added: 1. Apply this patch 2. Run: $ kshell k$ prove t/db_dependent/Koha/Object.t => SUCCESS: Tests pass! 3. Sign off :-D Signed-off-by: Tomas Cohen Arazi Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 7 19:27:37 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Jan 2020 18:27:37 +0000 Subject: [Koha-bugs] [Bug 18731] Add routes for acquisition orders In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18731 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #96855|0 |1 is obsolete| | --- Comment #30 from Tomás Cohen Arazi --- Created attachment 96938 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96938&action=edit Bug 18731: OpenAPI definitions This patch introduces the OpenAPI definitions required for the orders endpoint. It matches the voted RFC. Sponsored-by: Camden County Signed-off-by: Matthias Meusburger -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 7 19:38:51 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Jan 2020 18:38:51 +0000 Subject: [Koha-bugs] [Bug 24061] Print List (opac-shelves.pl) broken in Chrome In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24061 Gabriel DeCarufel changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |gabriel.decarufel at inlibro.c | |om Status|Needs Signoff |Signed Off --- Comment #27 from Gabriel DeCarufel --- printing a public list from the OPAC in chrome now works with this patch. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 7 19:47:40 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Jan 2020 18:47:40 +0000 Subject: [Koha-bugs] [Bug 24061] Print List (opac-shelves.pl) broken in Chrome In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24061 Guillaume Paquet changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |guillaume.paquet at inLibro.co | |m --- Comment #28 from Guillaume Paquet --- The patch was tested on Chrome 79 and worked properly. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 7 19:49:40 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Jan 2020 18:49:40 +0000 Subject: [Koha-bugs] [Bug 24321] Make objects.search use mappings from Koha::Object(s) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24321 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 7 19:49:44 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Jan 2020 18:49:44 +0000 Subject: [Koha-bugs] [Bug 24321] Make objects.search use mappings from Koha::Object(s) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24321 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #96874|0 |1 is obsolete| | Attachment #96875|0 |1 is obsolete| | Attachment #96876|0 |1 is obsolete| | Attachment #96877|0 |1 is obsolete| | Attachment #96878|0 |1 is obsolete| | Attachment #96879|0 |1 is obsolete| | Attachment #96880|0 |1 is obsolete| | Attachment #96881|0 |1 is obsolete| | Attachment #96882|0 |1 is obsolete| | Attachment #96883|0 |1 is obsolete| | Attachment #96884|0 |1 is obsolete| | Attachment #96885|0 |1 is obsolete| | Attachment #96886|0 |1 is obsolete| | Attachment #96887|0 |1 is obsolete| | --- Comment #51 from Kyle M Hall --- Created attachment 96939 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96939&action=edit Bug 24321: Add Koha::Objects->attributes_from_api This patch makes the 'attributes_from_api' method from the singular class available from the result set class. To test: 1. Apply this patch 2. Run: $ kshell k$ prove t/db_dependent/Koha/Objects.t => SUCCESS: Tests pass! 4. Sign off :-D 5. Yeah, I skipped 3 :-P Signed-off-by: Josef Moravec Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 7 19:50:03 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Jan 2020 18:50:03 +0000 Subject: [Koha-bugs] [Bug 24321] Make objects.search use mappings from Koha::Object(s) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24321 --- Comment #52 from Kyle M Hall --- Created attachment 96940 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96940&action=edit Bug 24321: Make dbic_merge_sorting accept a result set as parameter This patch makes dbic_merge_sorting accept a result set as parameter and solves a FIXME in _build_order_atom. To test: 1. Apply this patch 2. Run: $ kshell k$ prove t/Koha/REST/Plugin/Query.t => SUCCESS: Tests pass! 3. Sign off :-D Signed-off-by: Josef Moravec Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 7 19:50:07 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Jan 2020 18:50:07 +0000 Subject: [Koha-bugs] [Bug 24321] Make objects.search use mappings from Koha::Object(s) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24321 --- Comment #53 from Kyle M Hall --- Created attachment 96941 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96941&action=edit Bug 24321: Make objects.search use mappings from Koha::Object(s) This patch simplifies the objects.search helper so it relies entirely on the result set object for the attribute mappings. The result is no more to_api or to_model mappings are passed. The controllers need to be cleaned up after this patch. To test: 1. Apply this patch 2. Run: $ kshell k$ prove t/db_dependent/Koha/REST/Plugin/Objects.t => SUCCESS: Tests pass! 3. Sign off :-D Note: the original version of this helpers accepted arbitrary mappings and are now constrianed to real mappings on the Koha::Object level. As such, the number of tests got reduced. Signed-off-by: Josef Moravec Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 7 19:50:10 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Jan 2020 18:50:10 +0000 Subject: [Koha-bugs] [Bug 24321] Make objects.search use mappings from Koha::Object(s) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24321 --- Comment #54 from Kyle M Hall --- Created attachment 96942 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96942&action=edit Bug 24321: Clean /cities Signed-off-by: Josef Moravec Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 7 19:50:14 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Jan 2020 18:50:14 +0000 Subject: [Koha-bugs] [Bug 24321] Make objects.search use mappings from Koha::Object(s) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24321 --- Comment #55 from Kyle M Hall --- Created attachment 96943 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96943&action=edit Bug 24321: Clean /acquisitions/funds Signed-off-by: Josef Moravec Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 7 19:50:18 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Jan 2020 18:50:18 +0000 Subject: [Koha-bugs] [Bug 24321] Make objects.search use mappings from Koha::Object(s) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24321 --- Comment #56 from Kyle M Hall --- Created attachment 96944 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96944&action=edit Bug 24321: Clean /acquisitions/vendors Signed-off-by: Josef Moravec Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 7 19:50:22 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Jan 2020 18:50:22 +0000 Subject: [Koha-bugs] [Bug 24321] Make objects.search use mappings from Koha::Object(s) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24321 --- Comment #57 from Kyle M Hall --- Created attachment 96945 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96945&action=edit Bug 24321: Clean /libraries Signed-off-by: Josef Moravec Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 7 19:50:25 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Jan 2020 18:50:25 +0000 Subject: [Koha-bugs] [Bug 24321] Make objects.search use mappings from Koha::Object(s) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24321 --- Comment #58 from Kyle M Hall --- Created attachment 96946 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96946&action=edit Bug 24321: Clean /checkouts Signed-off-by: Josef Moravec Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 7 19:50:29 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Jan 2020 18:50:29 +0000 Subject: [Koha-bugs] [Bug 24321] Make objects.search use mappings from Koha::Object(s) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24321 --- Comment #59 from Kyle M Hall --- Created attachment 96947 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96947&action=edit Bug 24321: Clean /biblios Signed-off-by: Josef Moravec Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 7 19:50:33 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Jan 2020 18:50:33 +0000 Subject: [Koha-bugs] [Bug 24321] Make objects.search use mappings from Koha::Object(s) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24321 --- Comment #60 from Kyle M Hall --- Created attachment 96948 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96948&action=edit Bug 24321: Clean /items Signed-off-by: Josef Moravec Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 7 19:50:37 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Jan 2020 18:50:37 +0000 Subject: [Koha-bugs] [Bug 24321] Make objects.search use mappings from Koha::Object(s) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24321 --- Comment #61 from Kyle M Hall --- Created attachment 96949 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96949&action=edit Bug 24321: Clean /patrons/{patron_id}/account Signed-off-by: Josef Moravec Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 7 19:50:40 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Jan 2020 18:50:40 +0000 Subject: [Koha-bugs] [Bug 24321] Make objects.search use mappings from Koha::Object(s) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24321 --- Comment #62 from Kyle M Hall --- Created attachment 96950 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96950&action=edit Bug 24321: Clean /holds Signed-off-by: Josef Moravec Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 7 19:50:44 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Jan 2020 18:50:44 +0000 Subject: [Koha-bugs] [Bug 24321] Make objects.search use mappings from Koha::Object(s) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24321 --- Comment #63 from Kyle M Hall --- Created attachment 96951 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96951&action=edit Bug 24321: Clean /patrons Signed-off-by: Josef Moravec Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 7 19:50:47 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Jan 2020 18:50:47 +0000 Subject: [Koha-bugs] [Bug 24321] Make objects.search use mappings from Koha::Object(s) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24321 --- Comment #64 from Kyle M Hall --- Created attachment 96952 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96952&action=edit Bug 24321: (follow-up) Fix number of tests in t/db_dependent/Koha/Objects.t Test plan: prove t/db_dependent/Koha/Objects.t Signed-off-by: Josef Moravec Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 7 19:52:58 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Jan 2020 18:52:58 +0000 Subject: [Koha-bugs] [Bug 24371] New: OPAC 'Showing only available items/Show all items' is double encoded Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24371 Bug ID: 24371 Summary: OPAC 'Showing only available items/Show all items' is double encoded Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: lucas at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org The show all items link is double encoded when attempt to limit a seach via the facets and toggle 'Showing only available items/Show all items' To Recreate: 1. Make an OPAC search with plenty of results. 2. Use the search facets to limit the search in some way, item type, author, etc. 3. Click on 'Limit to currently available items', everything is still fine. 4. Attempt to return to 'Show all items', there will be no search results. The ':' is being double encoded here. (%253A). I think... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 7 19:57:27 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Jan 2020 18:57:27 +0000 Subject: [Koha-bugs] [Bug 24371] OPAC 'Showing only available items/Show all items' is double encoded In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24371 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 7 19:57:29 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Jan 2020 18:57:29 +0000 Subject: [Koha-bugs] [Bug 24371] OPAC 'Showing only available items/Show all items' is double encoded In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24371 --- Comment #1 from Lucas Gass --- Created attachment 96953 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96953&action=edit Bug 24371: Change URI filter to $raw TO TEST: 1. Make an OPAC search with plenty of results. 2. Use the search facets to limit the search in some way, item type, author, etc. 3. Click on 'Limit to currently available items', everything is still fine. 4. Attempt to return to 'Show all items', there will be no search results. 5. Apply patch 6. Ateempt steps 1-4 again. 7. Should work this time. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 7 20:01:46 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Jan 2020 19:01:46 +0000 Subject: [Koha-bugs] [Bug 24371] OPAC 'Showing only available items/Show all items' is double encoded In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24371 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard at myacpl.org |lucas at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 7 20:04:30 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Jan 2020 19:04:30 +0000 Subject: [Koha-bugs] [Bug 24363] Datepicker calendar is not sexy on additem.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24363 --- Comment #3 from Caroline Cyr La Rose --- in additem, I would center it also, so that it looks like the other ones. I tried to track downs all the other pages where the calendar icon appears (when the bullet is a star, the calendar is wonky): - memberentry - moremember (when adding a manual restriction) * request (when placing a hold and in the existing holds list) - holidays - lateorders * suggestion (when adding a new suggestion (in suggestion management section), when searching for a suggestion) - invoices - aqbudgetperiods * neworderempty (when adding an item while placing an order) - histsearch - parcels - orderreceive * circulation (when picking a due date or a renewal date) * returns (when specifying a return date) - pendingreserves - reserveratios - subscription-add - serials-edit (in the receiving table, but also in the item form if the issue has an item) - checkexpiration - subscription-numberpatterns - clubs-add-modify * import-borrowers * cleanborrowers * modborrowers - review * batchMod - export * inventory - viewlog - koha-news - scheduler - categories - smart-rules I may be missing some (or a lot). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 7 20:05:19 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Jan 2020 19:05:19 +0000 Subject: [Koha-bugs] [Bug 24363] Datepicker calendar is not sexy on additem.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24363 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 7 20:12:05 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Jan 2020 19:12:05 +0000 Subject: [Koha-bugs] [Bug 24228] Add a parameter to recursively embed objects in Koha::Object(s)->to_api In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24228 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 7 20:12:09 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Jan 2020 19:12:09 +0000 Subject: [Koha-bugs] [Bug 24228] Add a parameter to recursively embed objects in Koha::Object(s)->to_api In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24228 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #96686|0 |1 is obsolete| | Attachment #96687|0 |1 is obsolete| | --- Comment #15 from Kyle M Hall --- Created attachment 96954 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96954&action=edit Bug 24228: Add parameters to Koha::Object(s)->to_api to automatically embed objects This patch makes Koha::Object(s)->to_api have an 'embeds' parameter that using dot notation (e.g. resource.related_resource.another_one) allows embedding objects recursively. To test: 1. Apply this patch 2. prove t/db_dependent/Koha/Object.t Signed-off-by: Tomas Cohen Arazi Signed-off-by: Agustin Moyano Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 7 20:12:22 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Jan 2020 19:12:22 +0000 Subject: [Koha-bugs] [Bug 24228] Add a parameter to recursively embed objects in Koha::Object(s)->to_api In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24228 --- Comment #16 from Kyle M Hall --- Created attachment 96955 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96955&action=edit Bug 24228: Make ->to_api params a hashref This patch makes the parameters for Koha::Object(s)->to_api a hashref preparing the ground for new parameters. The proposed syntax is: $object->to_api( { embed => { 'items' => { 'children' => { 'homebranch' => {} } } } } ); Tests are added for the Koha::Objects implementation and tests for Koha::Object are adjusted to the new syntax, and a test for the single result accessor is added as well. To test: 1. Apply this patches 2. Run: $ kshell k$ prove t/db_dependent/Koha/Object.t t/db_dependent/Koha/Objects.t => SUCCESS: Tests pass! 3. Sign off :-D Signed-off-by: Tomas Cohen Arazi Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 7 20:24:53 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Jan 2020 19:24:53 +0000 Subject: [Koha-bugs] [Bug 24302] Add a way to specify nested objects to embed in OpenAPI In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24302 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 7 20:24:56 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Jan 2020 19:24:56 +0000 Subject: [Koha-bugs] [Bug 24302] Add a way to specify nested objects to embed in OpenAPI In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24302 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #96756|0 |1 is obsolete| | --- Comment #7 from Kyle M Hall --- Created attachment 96956 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96956&action=edit Bug 24302: Add a way to specify nested objects to embed in OpenAPI This patch introduces a helper for handling x-koha-embed headers on API requests. It reads the embed definitions and adds them to the stash for later use (either manually on the controllers, or in the objects.search helper. x-koha-embed needs to be defined as a list on the OpenAPI spec. It throws an exception when invalid combinations are found. To test: 1. Apply this patch 2. Run: $ kshell k$ prove t/Koha/REST/Plugin/Query.t => SUCCESS: Tests pass! 3.Sign off :-D Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 7 20:30:51 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Jan 2020 19:30:51 +0000 Subject: [Koha-bugs] [Bug 24372] New: Elasticsearch - cannot search for titles containing a colon next to a search term using the colon Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24372 Bug ID: 24372 Summary: Elasticsearch - cannot search for titles containing a colon next to a search term using the colon Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Searching - Elasticsearch Assignee: koha-bugs at lists.koha-community.org Reporter: nick at bywatersolutions.com Using an example record in the testing DB, try searching for: Pictura murală din nordul Moldovei: modificari estetice si restarare = Mural painting in the north of Moldavia: aesthetic modification and restoration In ES the search fails. If you look at the query we end up with terms like: Moldoveimodificari AND Moldaviaaesthetic This is because of this line in Koha/SearchEngine/Elasticsearch/QueryBuilder.pm 935 # Remove unquoted colons that have whitespace on either side of them 936 $term =~ s/(\:[:\s]+|[:\s]+:)$lookahead//g; Removing colons with a space on either side, we must be careful to put that space back: 936 $term =~ s/(\:[:\s]+|[:\s]+:)$lookahead/ /g; -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jan 7 20:44:28 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Jan 2020 19:44:28 +0000 Subject: [Koha-bugs] [Bug 24302] Add a way to specify nested objects to embed in OpenAPI In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24302 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #96956|0 |1 is obsolete| | --- Comment #8 from Kyle M Hall --- Created attachment 96957 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96957&action=edit Bug 24302: Add a way to specify nested objects to embed in OpenAPI This patch introduces a helper for handling x-koha-embed headers on API requests. It reads the embed definitions and adds them to the stash for later use (either manually on the controllers, or in the objects.search helper. x-koha-embed needs to be defined as a list on the OpenAPI spec. It throws an exception when invalid combinations are found. To test: 1. Apply this patch 2. Run: $ kshell k$ prove t/Koha/REST/Plugin/Query.t => SUCCESS: Tests pass! 3.Sign off :-D Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 7 20:48:28 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Jan 2020 19:48:28 +0000 Subject: [Koha-bugs] [Bug 24373] New: Correct basic cataloging editor CSS Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24373 Bug ID: 24373 Summary: Correct basic cataloging editor CSS Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: trivial Priority: P5 - low Component: Templates Assignee: oleonard at myacpl.org Reporter: oleonard at myacpl.org QA Contact: testopia at bugs.koha-community.org Depends on: 23259 Bug 23259 removed some low-level CSS which negatively affected the appearance of the basic cataloging editor. There shouldn't be green stripes around the tag/subfield tabs. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23259 [Bug 23259] Remove reset-fonts-grids.css -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 7 20:48:28 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Jan 2020 19:48:28 +0000 Subject: [Koha-bugs] [Bug 23259] Remove reset-fonts-grids.css In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23259 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |24373 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24373 [Bug 24373] Correct basic cataloging editor CSS -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 7 20:48:32 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Jan 2020 19:48:32 +0000 Subject: [Koha-bugs] [Bug 24366] Merging biblioitems should happen in Koha::Biblio->to_api In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24366 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 7 20:48:35 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Jan 2020 19:48:35 +0000 Subject: [Koha-bugs] [Bug 24366] Merging biblioitems should happen in Koha::Biblio->to_api In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24366 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #96914|0 |1 is obsolete| | Attachment #96915|0 |1 is obsolete| | --- Comment #3 from Kyle M Hall --- Created attachment 96958 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96958&action=edit Bug 24366: Unit tests Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 7 20:48:50 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Jan 2020 19:48:50 +0000 Subject: [Koha-bugs] [Bug 24366] Merging biblioitems should happen in Koha::Biblio->to_api In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24366 --- Comment #4 from Kyle M Hall --- Created attachment 96959 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96959&action=edit Bug 24366: Merge biblioitem in Koha::Biblio->to_api This patch moves the bilbioitem object merge into the Koha::Biblio->to_api method, as opposed to doing it in the controller. This is an inevitable change as other endpoints might require to embed biblio objects, and they need to carry the biblioitem information. Also, if we merge the tables, the transition will be straightforward (remove the tests this patch introduces, and merge the mappings from Koha::Biblioitem into Koha::Biblio). To test: 1. Apply this patches 2. Run: $ kshell k$ prove t/db_dependent/Koha/Biblio.t \ t/db_dependent/api/v1/biblios.t => SUCCESS: Tests pass! i.e. the new to_api method is tested, and the API tests don't expect any behavior change. 3. Sign off :-D Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 7 20:51:34 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Jan 2020 19:51:34 +0000 Subject: [Koha-bugs] [Bug 12224] Allow easy printing of patron check-in slip In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12224 Guillaume Paquet changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |guillaume.paquet at inLibro.co | |m --- Comment #27 from Guillaume Paquet --- Tested and works properly. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 7 20:56:20 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Jan 2020 19:56:20 +0000 Subject: [Koha-bugs] [Bug 24373] Correct basic cataloging editor CSS In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24373 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 7 20:56:22 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Jan 2020 19:56:22 +0000 Subject: [Koha-bugs] [Bug 24373] Correct basic cataloging editor CSS In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24373 --- Comment #1 from Owen Leonard --- Created attachment 96960 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96960&action=edit Bug 24373: Correct basic cataloging editor CSS This patch makes minor corrections to the basic MARC editor CSS, fixing an error caused by Bug 23259. To test, apply the patch and clear your browser cache if necessary. Open the basic MARC editor and check the numbered tabs. There should be no stripe of green background showing below the tabs. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 7 21:23:43 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Jan 2020 20:23:43 +0000 Subject: [Koha-bugs] [Bug 18986] High Hold Items with Decreased Loan Period Can't Be Checked-Out with Self-Check In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18986 Christopher Brannon changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |cbrannon at cdalibrary.org Severity|normal |major Priority|P5 - low |P1 - high Version|16.11 |master --- Comment #1 from Christopher Brannon --- This is a huge inconvenience to patrons. This should be addressed. These items will check out through SIP, but with Koha's SCO module. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 7 21:29:00 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Jan 2020 20:29:00 +0000 Subject: [Koha-bugs] [Bug 18731] Add routes for acquisition orders In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18731 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 7 21:29:03 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Jan 2020 20:29:03 +0000 Subject: [Koha-bugs] [Bug 18731] Add routes for acquisition orders In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18731 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #96853|0 |1 is obsolete| | Attachment #96854|0 |1 is obsolete| | Attachment #96916|0 |1 is obsolete| | Attachment #96917|0 |1 is obsolete| | Attachment #96918|0 |1 is obsolete| | Attachment #96938|0 |1 is obsolete| | --- Comment #31 from Kyle M Hall --- Created attachment 96961 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96961&action=edit Bug 18731: Make authenticate_api_request stash the embed structure Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 7 21:29:20 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Jan 2020 20:29:20 +0000 Subject: [Koha-bugs] [Bug 24123] bulkmarcimport.pl doesn't support UTF-8 encoded MARCXML records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24123 Michal Denar changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |black23 at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 7 21:30:09 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Jan 2020 20:30:09 +0000 Subject: [Koha-bugs] [Bug 18731] Add routes for acquisition orders In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18731 --- Comment #32 from Kyle M Hall --- Created attachment 96962 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96962&action=edit Bug 18731: Unit tests This patch implements unit tests for the orders endpoint. Sponsored-by: Camden County Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 7 21:30:12 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Jan 2020 20:30:12 +0000 Subject: [Koha-bugs] [Bug 18731] Add routes for acquisition orders In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18731 --- Comment #33 from Kyle M Hall --- Created attachment 96963 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96963&action=edit Bug 18731: /acquisitions/orders endpoint This patches implement the /acquisitions/orders endpoint. The attribute names are consistent with the voted RFC To test: 1. Apply this patchset 2. Run: $ kshell k$ prove t/db_dependent/api/v1/acquisitions_orders.t => SUCCESS: Tests pass! 3. Test the API with your favourite tool (Postman?) => SUCCESS: It works as expected! 4 Sign off :-D Sponsored-by: Camden County Signed-off-by: Matthias Meusburger Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 7 21:30:16 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Jan 2020 20:30:16 +0000 Subject: [Koha-bugs] [Bug 18731] Add routes for acquisition orders In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18731 --- Comment #34 from Kyle M Hall --- Created attachment 96964 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96964&action=edit Bug 18731: Add API mappings to K::A::{Basket,Invoice} This patch adds to_api_mapping definitions to the following classes: - Koha::Acquisition::Basket - Koha::Acquisition::Invoice They are implemented following the proposed RFCs: https://wiki.koha-community.org/wiki/Acquisitions_baskets_endpoint_RFC https://wiki.koha-community.org/wiki/Acquisitions_invoices_endpoint_RFC Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 7 21:30:19 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Jan 2020 20:30:19 +0000 Subject: [Koha-bugs] [Bug 18731] Add routes for acquisition orders In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18731 --- Comment #35 from Kyle M Hall --- Created attachment 96965 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96965&action=edit Bug 18731: Use the stashed koha.embed in objects.search This patch makes the objects.search helper use the koha.embed structure that is embedded in the authenticate_api_request step. This way, any controller using it will benefit from automatic embed handling. To test: 1. Apply this patch 2. Run: $ kshell k$ prove t/db_dependent/Koha/REST/Plugin/Objects.t => SUCCESS: Tests pass! 3. Sign off :-D Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 7 21:30:23 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Jan 2020 20:30:23 +0000 Subject: [Koha-bugs] [Bug 18731] Add routes for acquisition orders In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18731 --- Comment #36 from Kyle M Hall --- Created attachment 96966 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96966&action=edit Bug 18731: OpenAPI definitions This patch introduces the OpenAPI definitions required for the orders endpoint. It matches the voted RFC. Sponsored-by: Camden County Signed-off-by: Matthias Meusburger Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 7 21:36:10 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Jan 2020 20:36:10 +0000 Subject: [Koha-bugs] [Bug 13952] Import and export of authority types In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13952 Marjorie Barry-Vila changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marjorie.barry-vila at collect | |o.ca -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 7 21:50:24 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Jan 2020 20:50:24 +0000 Subject: [Koha-bugs] [Bug 24123] bulkmarcimport.pl doesn't support UTF-8 encoded MARCXML records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24123 Michal Denar changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 7 21:50:27 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Jan 2020 20:50:27 +0000 Subject: [Koha-bugs] [Bug 24123] bulkmarcimport.pl doesn't support UTF-8 encoded MARCXML records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24123 Michal Denar changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #96160|0 |1 is obsolete| | --- Comment #4 from Michal Denar --- Created attachment 96967 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96967&action=edit Bug 24123: Fix import of UTF-8 encoded MARC21 MARCXML using bulkmarcimport (elastic only) If elastic is used as search engine, the bulkmarcimport.pl will not handle correctly UTF-8 encoded MARCXML Koha::SearchEngine::Search->new uses a require statement to load the correct Search module. This is done l.257 of bulkmarcimport.pl: 257 my $searcher = Koha::SearchEngine::Search->new Koha::SearchEngine::Elasticsearch::Search will `use MARC::File::XML`, and so resets the arguments set before: 216 $MARC::File::XML::_load_args{BinaryEncoding} = 'utf-8'; 220 $MARC::File::XML::_load_args{RecordFormat} = $recordformat; An easy (but dirty) fix could be to move the declaration of my $searcher before in the script. The tricky (but correct) fix would be to remove the long standing "ugly hack follows" comment. This patch is the easy, and dirty, fix Test plan: Use the command line tool to import MARXCML records that contains unicode characters into Koha Something like `misc/migration_tools/bulkmarcimport.pl -biblios -file record.marcxml -m=MARCXML` Without this patch you will notice that unicode characters will not be displayed correctly Signed-off-by: Michal Denar Nice work, Jonathan -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 7 21:52:50 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Jan 2020 20:52:50 +0000 Subject: [Koha-bugs] [Bug 23377] bulkmarcimport.pl disables syspref caching In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23377 Michal Denar changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |black23 at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 7 22:34:26 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Jan 2020 21:34:26 +0000 Subject: [Koha-bugs] [Bug 14180] Make "Always show checkouts immediately" a global setting In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14180 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |WONTFIX Status|NEW |RESOLVED --- Comment #11 from Katrin Fischer --- (In reply to Séverine Queune from comment #10) > We added this code on 'IntranetUserJS' syspref and it works perfectly for us > :) > (Found on Biblibre's documentation) > > > $(document).ready(function() { > > if ( typeof script !== 'undefined' && ! > $.cookie("issues-table-load-immediately-" + script) ) { > $.cookie("issues-table-load-immediately-" + script, true, { expires: 365 > }); > } > > }); Using Severine's workaround - marking WONTFIX. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 7 22:37:18 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Jan 2020 21:37:18 +0000 Subject: [Koha-bugs] [Bug 24363] Datepicker calendar is not sexy on additem.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24363 --- Comment #4 from Jonathan Druart --- Created attachment 96968 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96968&action=edit Bug 24363: Vertical align datepicker icon on additem -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 7 22:38:05 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Jan 2020 21:38:05 +0000 Subject: [Koha-bugs] [Bug 14210] Manage staged marc records deletes replaced item when undoing import into catalog In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14210 --- Comment #3 from Katrin Fischer --- I wonder if we store if the item was added or replaced - if it was replaced, we could keep it and only delete it if it was added. Would still need a big note somewhere and documentation. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 7 22:41:36 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Jan 2020 21:41:36 +0000 Subject: [Koha-bugs] [Bug 14225] Include external library calendar / event list in Koha's search results In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14225 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Summary|calendar results in Koha |Include external library | |calendar / event list in | |Koha's search results -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 7 22:42:54 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Jan 2020 21:42:54 +0000 Subject: [Koha-bugs] [Bug 14227] RDA toolkit integration In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14227 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|rda toolkit integration |RDA toolkit integration --- Comment #3 from Katrin Fischer --- Does someone else know, how other ILS have implemented this? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 7 22:43:21 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Jan 2020 21:43:21 +0000 Subject: [Koha-bugs] [Bug 24363] Datepicker calendar is not sexy on additem.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24363 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #5 from Jonathan Druart --- (In reply to Jonathan Druart from comment #4) > Created attachment 96968 [details] [review] > Bug 24363: Vertical align datepicker icon on additem That was my try to fix the additem form, but it was not perfect as the '...' was not displaying good. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 7 22:43:34 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Jan 2020 21:43:34 +0000 Subject: [Koha-bugs] [Bug 24363] Datepicker calendar is not sexy on additem.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24363 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #96968|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 7 22:44:55 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Jan 2020 21:44:55 +0000 Subject: [Koha-bugs] [Bug 14233] Add logging support to notices' management In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14233 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Blocks| |22794 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22794 [Bug 22794] Omnibus: Improve and extend logging in Koha -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 7 22:44:55 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Jan 2020 21:44:55 +0000 Subject: [Koha-bugs] [Bug 22794] Omnibus: Improve and extend logging in Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22794 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |14233 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14233 [Bug 14233] Add logging support to notices' management -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 7 22:47:20 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Jan 2020 21:47:20 +0000 Subject: [Koha-bugs] [Bug 14234] Include the user manual with Koha package In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14234 --- Comment #6 from Katrin Fischer --- Note: we have no replaced the former help page with links to the manual, but at the same time, we allow to host the manual locally. System preference: KohaManualBaseURL. While you still would have to download it separately, that solves some of the initially reported problem I think. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 7 22:50:56 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Jan 2020 21:50:56 +0000 Subject: [Koha-bugs] [Bug 14251] Allow use of CSS in discharge letter In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14251 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|style discharge letter |Allow use of CSS in | |discharge letter -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 7 22:54:19 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Jan 2020 21:54:19 +0000 Subject: [Koha-bugs] [Bug 14282] Add configurable http headers for retrievable uploads (see 6874) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14282 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=6874 CC| |katrin.fischer at bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 7 22:54:19 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Jan 2020 21:54:19 +0000 Subject: [Koha-bugs] [Bug 6874] Attach files to bibliographic records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6874 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=14282 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 7 22:54:40 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Jan 2020 21:54:40 +0000 Subject: [Koha-bugs] [Bug 14282] Add configurable http headers for retrievable uploads (see 6874) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14282 --- Comment #1 from Katrin Fischer --- Hi Marcel, can you explain this one a bit more? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 7 22:54:42 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Jan 2020 21:54:42 +0000 Subject: [Koha-bugs] [Bug 24361] Fix warnings (or failing tests) from bug 24217 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24361 --- Comment #5 from Jonathan Druart --- Created attachment 96969 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96969&action=edit Bug 24361: (follow-up) Fix CalcFine.t I mixed up 2 possible solutions, the "not defined" is handled by the "! defined $item->{replacementprice}" part t/db_dependent/Circulation/CalcFine.t .. 1/3 # Failed test 'Amount is calculated correctly' # at t/db_dependent/Circulation/CalcFine.t line 167. # got: '29' # expected: '6' # Looks like you failed 1 test of 2. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 7 22:54:55 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Jan 2020 21:54:55 +0000 Subject: [Koha-bugs] [Bug 24361] Fix warnings (or failing tests) from bug 24217 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24361 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |additional_work_needed -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 7 22:58:34 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Jan 2020 21:58:34 +0000 Subject: [Koha-bugs] [Bug 22284] Groups of pickup locations for holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 --- Comment #289 from Jonathan Druart --- There is a (random?) failure on Master_D9 run 1053: koha_1 | # Failed test 'ReservesControlBranch: ItemHomeLibrary, biblio1, patron1 should return 6 but returns 7' koha_1 | # at t/db_dependent/Koha/Biblio.t line 419. koha_1 | koha_1 | # Failed test 'ReservesControlBranch: PatronLibrary, biblio1, patron1 should return 6 but returns 7' koha_1 | # at t/db_dependent/Koha/Biblio.t line 419. koha_1 | # Looks like you planned 29 tests but ran 31. koha_1 | # Looks like you failed 2 tests of 31 run. koha_1 | koha_1 | # Failed test 'pickup_locations' koha_1 | # at t/db_dependent/Koha/Biblio.t line 436. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 7 22:58:43 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Jan 2020 21:58:43 +0000 Subject: [Koha-bugs] [Bug 12224] Allow easy printing of patron check-in slip In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12224 Guillaume Paquet changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #91477|0 |1 is obsolete| | Attachment #91478|0 |1 is obsolete| | --- Comment #28 from Guillaume Paquet --- Created attachment 96970 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96970&action=edit Bug 12224: (follow-up) Allow easy printing of patron check-ins for today This is adds sample notice for other languages. Sponsored-by: Koha-Suomi Oy Signed-off-by: Guillaume Paquet -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 7 22:59:03 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Jan 2020 21:59:03 +0000 Subject: [Koha-bugs] [Bug 14307] Holds Overdue Honor Holidays In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14307 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |DUPLICATE Status|NEW |RESOLVED CC| |katrin.fischer at bsz-bw.de --- Comment #1 from Katrin Fischer --- I believe this was fixed by bug 12063. *** This bug has been marked as a duplicate of bug 12063 *** -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 7 22:59:03 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Jan 2020 21:59:03 +0000 Subject: [Koha-bugs] [Bug 12063] Change date calculation for reserve expiration to skip all holidays In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12063 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tmisilo at gmail.com --- Comment #92 from Katrin Fischer --- *** Bug 14307 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 7 22:59:30 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Jan 2020 21:59:30 +0000 Subject: [Koha-bugs] [Bug 24061] Print List (opac-shelves.pl) broken in Chrome In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24061 Gabriel DeCarufel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95715|0 |1 is obsolete| | --- Comment #29 from Gabriel DeCarufel --- Created attachment 96971 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96971&action=edit Bug 24061: close after timeout if onafterprint no supported Not supported on Chrome < 63 https://www.w3schools.com/tags/ev_onafterprint.asp Signed-off-by: Gabriel DeCarufel -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 7 23:01:12 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Jan 2020 22:01:12 +0000 Subject: [Koha-bugs] [Bug 12224] Allow easy printing of patron check-in slip In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12224 Gabriel DeCarufel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #96970|0 |1 is obsolete| | --- Comment #29 from Gabriel DeCarufel --- Created attachment 96972 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96972&action=edit Bug 12224: (follow-up) Allow easy printing of patron check-ins for today This is adds sample notice for other languages. Sponsored-by: Koha-Suomi Oy Signed-off-by: Guillaume Paquet -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 7 23:03:08 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Jan 2020 22:03:08 +0000 Subject: [Koha-bugs] [Bug 14340] 773x ISSN Index In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14340 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de, | |oleonard at myacpl.org --- Comment #1 from Katrin Fischer --- I am not sure what Nicole meant here, can someone help? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 7 23:05:29 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Jan 2020 22:05:29 +0000 Subject: [Koha-bugs] [Bug 23049] Replace MANUAL_INV authorised value with a dedicated table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas at bywatersolutions.com --- Comment #226 from Lucas Gass --- enchancment wont be backported to 19.05.x series -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 7 23:05:41 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Jan 2020 22:05:41 +0000 Subject: [Koha-bugs] [Bug 23049] Replace MANUAL_INV authorised value with a dedicated table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jan 7 23:05:57 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 Jan 2020 22:05:57 +0000 Subject: [Koha-bugs] [Bug 14281] text notices include 
 tags
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14281

Katrin Fischer  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |DUPLICATE
                 CC|                            |katrin.fischer at bsz-bw.de

--- Comment #1 from Katrin Fischer  ---


*** This bug has been marked as a duplicate of bug 14347 ***

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan  7 23:05:57 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 07 Jan 2020 22:05:57 +0000
Subject: [Koha-bugs] [Bug 14347] Running overdue_notices.pl with --html flag
 set does not create well structured html
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14347

Katrin Fischer  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |nengard at gmail.com

--- Comment #1 from Katrin Fischer  ---
*** Bug 14281 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan  7 23:05:58 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 07 Jan 2020 22:05:58 +0000
Subject: [Koha-bugs] [Bug 23049] Replace MANUAL_INV authorised value with a
 dedicated table
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049

Lucas Gass  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to stable            |RESOLVED
         Resolution|---                         |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan  7 23:05:59 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 07 Jan 2020 22:05:59 +0000
Subject: [Koha-bugs] [Bug 21739] 'Copier fees' should not be used as
 accounttype on maninvoice.pl
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21739
Bug 21739 depends on bug 23049, which changed state.

Bug 23049 Summary: Replace MANUAL_INV authorised value with a dedicated table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to stable            |RESOLVED
         Resolution|---                         |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan  7 23:06:00 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 07 Jan 2020 22:06:00 +0000
Subject: [Koha-bugs] [Bug 22393] Remove last remaining manualinvoice use
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22393
Bug 22393 depends on bug 23049, which changed state.

Bug 23049 Summary: Replace MANUAL_INV authorised value with a dedicated table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to stable            |RESOLVED
         Resolution|---                         |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan  7 23:06:00 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 07 Jan 2020 22:06:00 +0000
Subject: [Koha-bugs] [Bug 23046] Add tax handling to accounts
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23046
Bug 23046 depends on bug 23049, which changed state.

Bug 23049 Summary: Replace MANUAL_INV authorised value with a dedicated table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to stable            |RESOLVED
         Resolution|---                         |FIXED

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan  7 23:06:00 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 07 Jan 2020 22:06:00 +0000
Subject: [Koha-bugs] [Bug 23805] Add a dedicated credit_types table
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23805
Bug 23805 depends on bug 23049, which changed state.

Bug 23049 Summary: Replace MANUAL_INV authorised value with a dedicated table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to stable            |RESOLVED
         Resolution|---                         |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan  7 23:06:01 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 07 Jan 2020 22:06:01 +0000
Subject: [Koha-bugs] [Bug 24241] Description missing for subpermission
 manage_accounts
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24241
Bug 24241 depends on bug 23049, which changed state.

Bug 23049 Summary: Replace MANUAL_INV authorised value with a dedicated table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to stable            |RESOLVED
         Resolution|---                         |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan  7 23:06:01 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 07 Jan 2020 22:06:01 +0000
Subject: [Koha-bugs] [Bug 24316] Fix non-English web installers by removing
 obsolete authorised value MANUAL_INV
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24316
Bug 24316 depends on bug 23049, which changed state.

Bug 23049 Summary: Replace MANUAL_INV authorised value with a dedicated table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to stable            |RESOLVED
         Resolution|---                         |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan  7 23:07:01 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 07 Jan 2020 22:07:01 +0000
Subject: [Koha-bugs] [Bug 24241] Description missing for subpermission
 manage_accounts
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24241

Lucas Gass  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |lucas at bywatersolutions.com

--- Comment #7 from Lucas Gass  ---
missing dependencies for 19.05.x, no backport

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan  7 23:09:19 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 07 Jan 2020 22:09:19 +0000
Subject: [Koha-bugs] [Bug 14355] Suggestions: Organize by: Library broken
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14355

--- Comment #1 from Katrin Fischer  ---
I've just retested this and I think the reason is we have 2 different forms:

1st form filters on your homebranch by default.
2nd form changes the tabs.

Every time the tabs are changed to library and saved, the default setting on
the second form returns... and so the filtering and you only see a tab for your
own library.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan  7 23:09:42 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 07 Jan 2020 22:09:42 +0000
Subject: [Koha-bugs] [Bug 14355] Suggestions: Organize by: Library broken
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14355

--- Comment #2 from Katrin Fischer  ---
... Changing the tabs should not reset the other filters, but keep what you
have previously chosen.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan  7 23:15:08 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 07 Jan 2020 22:15:08 +0000
Subject: [Koha-bugs] [Bug 21739] 'Copier fees' should not be used as
 accounttype on maninvoice.pl
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21739

Martin Renvoize  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|NEW                         |RESOLVED

--- Comment #4 from Martin Renvoize  ---
There is now a dedicated debit_types table and handling to optionally
enable/disable types for manual invoices.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan  7 23:15:31 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 07 Jan 2020 22:15:31 +0000
Subject: [Koha-bugs] [Bug 14378] koha-run-backups should check disk usage
 first
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14378

Katrin Fischer  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |WONTFIX
                 CC|                            |katrin.fischer at bsz-bw.de

--- Comment #4 from Katrin Fischer  ---
>From the comments I think that this is probably not something we can fix Koha
side apart from making the backups smaller by giving options. Closing WONTFIX.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan  7 23:17:56 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 07 Jan 2020 22:17:56 +0000
Subject: [Koha-bugs] [Bug 14379] Batch item modification tool - Can't change
 custom subfields
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14379

Katrin Fischer  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de

--- Comment #5 from Katrin Fischer  ---
(In reply to Claudio from comment #4)
> Subfield $1 is missing in Batch Item Modification tool (tag 952). Is there a
> reason for this? I can not find a configuration rule...

There was, because it behaved differently than changing the lost status form
the items tab. I think this part was fixed, as MarkLostItemsAsReturned includes
the option 'batch item modification tool' now.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan  7 23:22:39 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 07 Jan 2020 22:22:39 +0000
Subject: [Koha-bugs] [Bug 23442] Add a 'refund' process to accounts
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23442

Michal Denar  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |black23 at gmail.com
             Status|Needs Signoff               |Patch doesn't apply

--- Comment #17 from Michal Denar  ---
Hi Martin,
I get error:
{UNKNOWN}: Can't locate object method "payout" via package
"Koha::Schema::Result::Accountline" at
/home/vagrant/kohaclone/members/boraccount.pl line 139. at
/home/vagrant/kohaclone/members/boraccount.pl line 151
 at /usr/share/perl5/DBIx/Class/Exception.pm line 77

    in DBIx::Class::Exception::throw at
/usr/share/perl5/DBIx/Class/Exception.pm line 77

Miss I something?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan  7 23:25:17 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 07 Jan 2020 22:25:17 +0000
Subject: [Koha-bugs] [Bug 22393] Remove last remaining manualinvoice use
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22393

Michal Denar  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |black23 at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan  7 23:26:11 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 07 Jan 2020 22:26:11 +0000
Subject: [Koha-bugs] [Bug 14414] add field for processing fee for invoices
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14414

Katrin Fischer  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de

--- Comment #2 from Katrin Fischer  ---
Is this something invoice adjustments could be reused for? Maybe with a default
value added to the vendor and an invoice adjustment created automatically? Or
would this be better as a specific column in the invoices table?

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan  7 23:29:14 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 07 Jan 2020 22:29:14 +0000
Subject: [Koha-bugs] [Bug 14433] Allow to select items for which a checkout
 receipt should be printed
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14433

Katrin Fischer  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|To print a slip as receipit |Allow to select items for
                   |for a single issue          |which a checkout receipt
                   |(checkout)                  |should be printed
                 CC|                            |katrin.fischer at bsz-bw.de

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan  7 23:30:42 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 07 Jan 2020 22:30:42 +0000
Subject: [Koha-bugs] [Bug 24085] Double submission of forms on returns.pl
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24085

Lucas Gass  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |lucas at bywatersolutions.com

--- Comment #7 from Lucas Gass  ---
For 19.05.x I run into merge conflicts which I am able to solve but the QA tool
does not like what I have done:

 FAIL   koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tt
   OK     filters
   OK     forbidden patterns
   OK     git manipulation
   OK     js_in_body
   OK     spelling
   OK     tt_valid
   FAIL   valid_template
                parse error -
/kohadevbox/koha/koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tt line
873: unexpected token (END)
  [% END # /IF WrongTransfer && !transfertodo %]


Please advise!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan  7 23:33:05 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 07 Jan 2020 22:33:05 +0000
Subject: [Koha-bugs] [Bug 24329] Patron cardnumber change times are lost
 during upgrade for bug 3820
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24329

--- Comment #8 from Martin Renvoize  ---
Thanks for adding a test Jonathan.. shame on me for missing that in the initial
set.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan  7 23:33:17 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 07 Jan 2020 22:33:17 +0000
Subject: [Koha-bugs] [Bug 14452] Remember if user used more/fewer options on
 advanced search
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14452

Katrin Fischer  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|NEW                         |RESOLVED

--- Comment #3 from Katrin Fischer  ---
I am not sure when that was fixed, but there is definitely a Cookie for it:
https://wiki.koha-community.org/wiki/Use_of_Cookies (search_path_code)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan  7 23:35:35 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 07 Jan 2020 22:35:35 +0000
Subject: [Koha-bugs] [Bug 24240] List on opac missing close form tag under
 some conditions
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24240

Lucas Gass  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |lucas at bywatersolutions.com
             Status|Pushed to stable            |Pushed to oldstable

--- Comment #6 from Lucas Gass  ---
backported to 19.05.x for 19.05.07

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan  7 23:38:53 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 07 Jan 2020 22:38:53 +0000
Subject: [Koha-bugs] [Bug 14473] Warning about unsaved changes in cataloging
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14473

Katrin Fischer  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Warning unsaved changes     |Warning about unsaved
                   |                            |changes in cataloging
                 CC|                            |katrin.fischer at bsz-bw.de

--- Comment #1 from Katrin Fischer  ---
The advanced editor does this already - so it might be nice to have the same on
the normal editor.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan  7 23:39:44 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 07 Jan 2020 22:39:44 +0000
Subject: [Koha-bugs] [Bug 24245] opac-registration-confirmation.tt has
 incorrect HTML body id
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24245

Lucas Gass  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to stable            |Pushed to oldstable

--- Comment #6 from Lucas Gass  ---
backported to 19.05.x for 19.05.07

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan  7 23:41:25 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 07 Jan 2020 22:41:25 +0000
Subject: [Koha-bugs] [Bug 14488] Multi-Volume ordering through acquisition
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14488

Katrin Fischer  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de

--- Comment #1 from Katrin Fischer  ---
Maybe using a standing order could work here?

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan  7 23:45:48 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 07 Jan 2020 22:45:48 +0000
Subject: [Koha-bugs] [Bug 24235] /misc/cronjobs/advance_notices.pl DUEDGST
 does NOT send sms, just e-mail
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24235

Lucas Gass  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |lucas at bywatersolutions.com
             Status|Pushed to stable            |Pushed to oldstable

--- Comment #13 from Lucas Gass  ---
backported to 19.05.x for 19.05.07

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan  7 23:48:11 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 07 Jan 2020 22:48:11 +0000
Subject: [Koha-bugs] [Bug 14527] UNIMARC: zebra error 114 when searching for
 items added before or after a specific date / 995$5 is not indexed
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14527

Katrin Fischer  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|zebra error 114 when        |UNIMARC: zebra error 114
                   |searching for items added   |when searching for items
                   |before or after a specific  |added before or after a
                   |date                        |specific date / 995$5 is
                   |                            |not indexed

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan  7 23:51:23 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 07 Jan 2020 22:51:23 +0000
Subject: [Koha-bugs] [Bug 22381] Wording on Calendar-related system
 preferences not standardized
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22381

Lucas Gass  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to stable            |Pushed to oldstable

--- Comment #17 from Lucas Gass  ---
backported to 19.05.x for 19.05.07

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan  7 23:55:34 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 07 Jan 2020 22:55:34 +0000
Subject: [Koha-bugs] [Bug 24263] borrowers.relationship should not contain
 an empty string
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24263

--- Comment #12 from Martin Renvoize  ---
Should this be set to PQA Tomas?

The comments read like it should.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan  7 23:58:33 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 07 Jan 2020 22:58:33 +0000
Subject: [Koha-bugs] [Bug 14581] Display Google Books cover in RSS page
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14581

Katrin Fischer  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Display of book jacket in   |Display Google Books cover
                   |RSS page                    |in RSS page
                 CC|                            |katrin.fischer at bsz-bw.de

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan  7 23:59:29 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 07 Jan 2020 22:59:29 +0000
Subject: [Koha-bugs] [Bug 22381] Wording on Calendar-related system
 preferences not standardized
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22381

--- Comment #18 from Lucas Gass  ---
Oops, I was too hasty with my backport. This bug has a dependency that is not
in 19.05.x, reverting this. 

No backported to 19.05.x

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  8 00:00:35 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 07 Jan 2020 23:00:35 +0000
Subject: [Koha-bugs] [Bug 14593] Send notifications for pending moderation
 staff actions
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14593

Katrin Fischer  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Version|3.20                        |master

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  8 00:02:48 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 07 Jan 2020 23:02:48 +0000
Subject: [Koha-bugs] [Bug 14400] Automated backup to cloud storage
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14400

Katrin Fischer  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |WONTFIX
                 CC|                            |katrin.fischer at bsz-bw.de
             Status|NEW                         |RESOLVED

--- Comment #2 from Katrin Fischer  ---
I feel like this is a WONTFIX as there are many cloud providers and this
appears more to be a task on system administration level. We would start
rebuilding tools that probably already exist.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  8 00:04:37 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 07 Jan 2020 23:04:37 +0000
Subject: [Koha-bugs] [Bug 24215] Warnings about guarantor relationships show
 ARRAY errors
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24215

Lucas Gass  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |lucas at bywatersolutions.com

--- Comment #14 from Lucas Gass  ---
missing dependency for 19.05.x, no backport

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  8 00:05:00 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 07 Jan 2020 23:05:00 +0000
Subject: [Koha-bugs] [Bug 24215] Warnings about guarantor relationships show
 ARRAY errors
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24215

Lucas Gass  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to stable            |RESOLVED
         Resolution|---                         |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  8 00:05:01 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 07 Jan 2020 23:05:01 +0000
Subject: [Koha-bugs] [Bug 24263] borrowers.relationship should not contain
 an empty string
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24263
Bug 24263 depends on bug 24215, which changed state.

Bug 24215 Summary: Warnings about guarantor relationships show ARRAY errors
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24215

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to stable            |RESOLVED
         Resolution|---                         |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  8 00:05:18 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 07 Jan 2020 23:05:18 +0000
Subject: [Koha-bugs] [Bug 14601] Cardnumber should not be required for
 patron import
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14601

Katrin Fischer  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |DUPLICATE
             Status|NEW                         |RESOLVED

--- Comment #9 from Katrin Fischer  ---


*** This bug has been marked as a duplicate of bug 23077 ***

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  8 00:05:18 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 07 Jan 2020 23:05:18 +0000
Subject: [Koha-bugs] [Bug 23077] Can't import patrons without cardnumber
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23077

Katrin Fischer  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |danielle at bywatersolutions.c
                   |                            |om

--- Comment #17 from Katrin Fischer  ---
*** Bug 14601 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  8 00:09:54 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 07 Jan 2020 23:09:54 +0000
Subject: [Koha-bugs] [Bug 14615] Staff cart email doesn't include a link
 back to the staff client
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14615

Katrin Fischer  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=3150

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  8 00:09:54 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 07 Jan 2020 23:09:54 +0000
Subject: [Koha-bugs] [Bug 3150] Move emails for sending cart and list
 contents into notices tool
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3150

Katrin Fischer  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=14615

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  8 00:13:35 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 07 Jan 2020 23:13:35 +0000
Subject: [Koha-bugs] [Bug 24137] Marc21 bibliographic fails to install for
 ru-Ru and uk-UA
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24137

Lucas Gass  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |lucas at bywatersolutions.com
             Status|Pushed to stable            |Pushed to oldstable

--- Comment #29 from Lucas Gass  ---
backported to 19.05.x for 19.05.07

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  8 00:16:49 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 07 Jan 2020 23:16:49 +0000
Subject: [Koha-bugs] [Bug 14650] Add public/staff notes to batch item
 modification
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14650

Katrin Fischer  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|NEW                         |RESOLVED

--- Comment #1 from Katrin Fischer  ---
They do, as soon as one of the items has a public or internal note set the
column is shown in the items table. They can also be edited using the bulk edit
form.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  8 00:24:55 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 07 Jan 2020 23:24:55 +0000
Subject: [Koha-bugs] [Bug 14729] circ rule for number of on shelf holds
 allowed
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14729

Katrin Fischer  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #1 from Katrin Fischer  ---
Exists in current versions. :)

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  8 00:25:50 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 07 Jan 2020 23:25:50 +0000
Subject: [Koha-bugs] [Bug 14729] circ rule for number of on shelf holds
 allowed
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14729

Katrin Fischer  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |REOPENED
         Resolution|FIXED                       |---

--- Comment #2 from Katrin Fischer  ---
Sorry, I was confusing 'on shelf' with 'on site' - not solved. Reopening (and
stopping for today :) )

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  8 00:25:55 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 07 Jan 2020 23:25:55 +0000
Subject: [Koha-bugs] [Bug 14729] circ rule for number of on shelf holds
 allowed
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14729

Katrin Fischer  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|REOPENED                    |NEW

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  8 00:28:47 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 07 Jan 2020 23:28:47 +0000
Subject: [Koha-bugs] [Bug 14742] 082 field corrupt in FA Framework in new
 installs
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14742

Katrin Fischer  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |DUPLICATE
             Status|NEW                         |RESOLVED
                 CC|                            |katrin.fischer at bsz-bw.de

--- Comment #1 from Katrin Fischer  ---


*** This bug has been marked as a duplicate of bug 14778 ***

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  8 00:28:47 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 07 Jan 2020 23:28:47 +0000
Subject: [Koha-bugs] [Bug 14778] DBIC should create/own the DB handler
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14778

Martin Renvoize  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|Oldversions                 |---

Katrin Fischer  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |david.roberts at ptfs-europe.c
                   |                            |om

--- Comment #103 from Katrin Fischer  ---
*** Bug 14742 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  8 00:29:57 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 07 Jan 2020 23:29:57 +0000
Subject: [Koha-bugs] [Bug 14742] 082 field corrupt in FA Framework in new
 installs
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14742

--- Comment #2 from Katrin Fischer  ---


*** This bug has been marked as a duplicate of bug 14478 ***

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  8 00:29:57 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 07 Jan 2020 23:29:57 +0000
Subject: [Koha-bugs] [Bug 14478] Fast Add Framework contains no 082 field
 but 082 subfields
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14478

Katrin Fischer  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |david.roberts at ptfs-europe.c
                   |                            |om

--- Comment #1 from Katrin Fischer  ---
*** Bug 14742 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  8 00:33:34 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 07 Jan 2020 23:33:34 +0000
Subject: [Koha-bugs] [Bug 14754] Always warn before leaving a page with
 unsaved changes [OMNIBUS]
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14754

Katrin Fischer  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|save fail safe              |Always warn before leaving
                   |                            |a page with unsaved changes
                   |                            |[OMNIBUS]
                 CC|                            |katrin.fischer at bsz-bw.de
             Blocks|                            |14473


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14473
[Bug 14473] Warning about unsaved changes in cataloging
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  8 00:33:34 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 07 Jan 2020 23:33:34 +0000
Subject: [Koha-bugs] [Bug 14473] Warning about unsaved changes in cataloging
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14473

Katrin Fischer  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |14754


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14754
[Bug 14754] Always warn before leaving a page with unsaved changes [OMNIBUS]
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  8 00:37:02 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 07 Jan 2020 23:37:02 +0000
Subject: [Koha-bugs] [Bug 14780] Datetime format picker error in Circulation
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14780

Katrin Fischer  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |WORKSFORME
                 CC|                            |katrin.fischer at bsz-bw.de
             Status|NEW                         |RESOLVED

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  8 00:38:47 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 07 Jan 2020 23:38:47 +0000
Subject: [Koha-bugs] [Bug 14728] ignore warning for rest of session
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14728

Katrin Fischer  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |DUPLICATE
                 CC|                            |katrin.fischer at bsz-bw.de
             Status|NEW                         |RESOLVED

--- Comment #1 from Katrin Fischer  ---


*** This bug has been marked as a duplicate of bug 14787 ***

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  8 00:38:48 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 07 Jan 2020 23:38:48 +0000
Subject: [Koha-bugs] [Bug 14787] Allow confirm/continue option to circ
 warnings at checkout
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14787

Katrin Fischer  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |nicole at bywatersolutions.com

--- Comment #1 from Katrin Fischer  ---
*** Bug 14728 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  8 05:35:34 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 08 Jan 2020 04:35:34 +0000
Subject: [Koha-bugs] [Bug 23015] Create a "GetPickupLocation" endpoint for
 the ILS-DI Service
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23015

Arthur Suzuki  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  8 05:50:02 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 08 Jan 2020 04:50:02 +0000
Subject: [Koha-bugs] [Bug 23531] ILS-DI doesn't implement needed_before_date
 and pickup_expiry_date parameters
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23531

Arthur Suzuki  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  8 05:54:43 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 08 Jan 2020 04:54:43 +0000
Subject: [Koha-bugs] [Bug 24322] National Library of Medicine (NLM) call
 number to XSLT Detail
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24322

Olli-Antti Kivilahti  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #96701|0                           |1
        is obsolete|                            |

--- Comment #5 from Olli-Antti Kivilahti  ---
Created attachment 96973
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96973&action=edit
Bug 24322: National Library of Medicine (NLM) call number to XSLT Detail

Thank you Joonas and Katrin for your excellent discoveries.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  8 05:55:22 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 08 Jan 2020 04:55:22 +0000
Subject: [Koha-bugs] [Bug 24322] National Library of Medicine (NLM) call
 number to XSLT Detail
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24322

Olli-Antti Kivilahti  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  8 07:54:26 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 08 Jan 2020 06:54:26 +0000
Subject: [Koha-bugs] [Bug 14806] Action Log for Modifying
 message_transport_types
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14806

Katrin Fischer  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |22794


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22794
[Bug 22794] Omnibus: Improve and extend logging in Koha
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  8 07:54:26 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 08 Jan 2020 06:54:26 +0000
Subject: [Koha-bugs] [Bug 22794] Omnibus: Improve and extend logging in Koha
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22794

Katrin Fischer  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |14806


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14806
[Bug 14806] Action Log for Modifying message_transport_types
-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  8 07:56:05 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 08 Jan 2020 06:56:05 +0000
Subject: [Koha-bugs] [Bug 14814] Allow to choose a supplier on the
 suggestions form
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14814

Katrin Fischer  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Suggestions improvements    |Allow to choose a supplier
                   |                            |on the suggestions form

--- Comment #2 from Katrin Fischer  ---
I am not quite sure where we would display the supplier in the steps following
in acq, as you have already picked a supplier at the time of 'ordering form a
suggestion'.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  8 07:57:12 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 08 Jan 2020 06:57:12 +0000
Subject: [Koha-bugs] [Bug 14818] Add missing DBIx::Class relationships
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14818

Katrin Fischer  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de

--- Comment #1 from Katrin Fischer  ---
Hi Jonathan, this doesn't have much info or linked bugs - ca it be closed?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  8 07:59:27 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 08 Jan 2020 06:59:27 +0000
Subject: [Koha-bugs] [Bug 14837] Allow to send separate DUEDGST und
 PREDUEDGST for item's homebranches
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14837

Katrin Fischer  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |DUPLICATE
             Status|NEW                         |RESOLVED

--- Comment #2 from Katrin Fischer  ---


*** This bug has been marked as a duplicate of bug 20478 ***

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  8 07:59:27 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 08 Jan 2020 06:59:27 +0000
Subject: [Koha-bugs] [Bug 20478] Advance notices: send separate digest
 messages per library
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20478

--- Comment #30 from Katrin Fischer  ---
*** Bug 14837 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  8 08:01:50 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 08 Jan 2020 07:01:50 +0000
Subject: [Koha-bugs] [Bug 14865] Update Koha::Logger documentation based on
 wiki docs
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14865

Katrin Fischer  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de
             Blocks|                            |22794


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22794
[Bug 22794] Omnibus: Improve and extend logging in Koha
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  8 08:01:50 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 08 Jan 2020 07:01:50 +0000
Subject: [Koha-bugs] [Bug 22794] Omnibus: Improve and extend logging in Koha
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22794

Katrin Fischer  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |14865


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14865
[Bug 14865] Update Koha::Logger documentation based on wiki docs
-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  8 08:02:56 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 08 Jan 2020 07:02:56 +0000
Subject: [Koha-bugs] [Bug 14887] Allow printing of lost fines/fees in notices
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14887

Katrin Fischer  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|lost item fee displays as   |Allow printing of lost
                   |0.00 for <> in  |fines/fees in notices
                   |overdue notice.             |

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  8 08:06:07 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 08 Jan 2020 07:06:07 +0000
Subject: [Koha-bugs] [Bug 14898] After adding manual invoice redirect to pay
 tab instead of account tab
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14898

Katrin Fischer  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
          Component|Patrons                     |Fines and fees

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  8 08:08:18 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 08 Jan 2020 07:08:18 +0000
Subject: [Koha-bugs] [Bug 14908] Item search: Item search results not
 properly sorted by Date. Date filter also not working
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14908

Katrin Fischer  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|NEW                         |RESOLVED

--- Comment #9 from Katrin Fischer  ---
This appears to have been fixed - just tested date filtering on master.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  8 08:11:26 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 08 Jan 2020 07:11:26 +0000
Subject: [Koha-bugs] [Bug 14911] Item search: Display additional 245
 subfields in search results
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14911

Katrin Fischer  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=23499
            Summary|Serial Subscr. and Item     |Item search: Display
                   |search: Display additional  |additional 245 subfields in
                   |245 subfields in search     |search results
                   |results                     |

--- Comment #3 from Katrin Fischer  ---
Splitting bugs up here - making this one about item search and linking to the
existing bug report for serials subscription search in see also.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  8 08:11:26 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 08 Jan 2020 07:11:26 +0000
Subject: [Koha-bugs] [Bug 23499] Show subtitle in serials search
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23499

Katrin Fischer  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=14911

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  8 08:15:20 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 08 Jan 2020 07:15:20 +0000
Subject: [Koha-bugs] [Bug 14941] Subfield defaults: Add information about
 substitutable values
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14941

Katrin Fischer  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |Manual

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  8 08:16:43 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 08 Jan 2020 07:16:43 +0000
Subject: [Koha-bugs] [Bug 14944] show error in frameworks/cataloging if
 upload path not set
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14944

Katrin Fischer  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED
                 CC|                            |katrin.fischer at bsz-bw.de

--- Comment #2 from Katrin Fischer  ---
(In reply to Marcel de Rooy from comment #1)
> Are you sure?
> If I upload a file without this entry in koha-conf, I get this warning:
> Your koha-conf.xml does not contain a valid upload_path.
> Nice in yellow :)

Closing resolved fixed as per Marcel's comment.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  8 08:17:32 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 08 Jan 2020 07:17:32 +0000
Subject: [Koha-bugs] [Bug 14947] Overdue Items warning not updated after
 renewal
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14947

Katrin Fischer  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de
             Status|NEW                         |RESOLVED
         Resolution|---                         |DUPLICATE

--- Comment #1 from Katrin Fischer  ---


*** This bug has been marked as a duplicate of bug 14798 ***

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  8 08:17:32 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 08 Jan 2020 07:17:32 +0000
Subject: [Koha-bugs] [Bug 14798] Renew and checkin do not update parts of
 checkout page
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14798

Katrin Fischer  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |cbrannon at cdalibrary.org

--- Comment #2 from Katrin Fischer  ---
*** Bug 14947 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  8 08:19:29 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 08 Jan 2020 07:19:29 +0000
Subject: [Koha-bugs] [Bug 14958] wrong suggestions are displayed with
 IndependentBranches
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14958

Katrin Fischer  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |DUPLICATE
                 CC|                            |katrin.fischer at bsz-bw.de

--- Comment #1 from Katrin Fischer  ---


*** This bug has been marked as a duplicate of bug 18743 ***

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  8 08:19:29 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 08 Jan 2020 07:19:29 +0000
Subject: [Koha-bugs] [Bug 18743] Filter suggestion lists correctly for
 IndependentBranches
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18743

--- Comment #37 from Katrin Fischer  ---
*** Bug 14958 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  8 08:24:59 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 08 Jan 2020 07:24:59 +0000
Subject: [Koha-bugs] [Bug 15003] Help should be a wiki,
 not translatable via po-files
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15003

Katrin Fischer  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de

--- Comment #1 from Katrin Fischer  ---
Hi Paxed, 

there is quite a few different requests in this one - would you mind reviewing
what is still needed since we changed from help files to links to the manual?
URL is configurable now for example.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  8 08:28:53 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 08 Jan 2020 07:28:53 +0000
Subject: [Koha-bugs] [Bug 15060] Change standard ISBD view for 245/242/246
 in MARC21
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15060

Katrin Fischer  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Setup standard ISBD view    |Change standard ISBD view
                   |                            |for 245/242/246 in MARC21
                 CC|                            |katrin.fischer at bsz-bw.de

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  8 08:29:43 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 08 Jan 2020 07:29:43 +0000
Subject: [Koha-bugs] [Bug 24322] National Library of Medicine (NLM) call
 number to XSLT Detail
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24322

--- Comment #6 from Joonas Kylmälä  ---
You didn't add the test plan still – you really should because 1) you will
likely get more people signing off this because they don't need to delve into
the code to check what this thing does and what is the feature (though a bit
more verbose commit message would help also with this) 2) it gives a baseline
for what things to test and others can do in addition other types of testing
than what is just mentioned in the test plan.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  8 08:59:17 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 08 Jan 2020 07:59:17 +0000
Subject: [Koha-bugs] [Bug 24322] National Library of Medicine (NLM) call
 number to XSLT Detail
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24322

--- Comment #7 from Olli-Antti Kivilahti  ---
TEST PLAN:

1. Find a bib record
2. Add MARC21 field 060
3. Show the bib via the bib detail page (detail.pl)
4. Observe the field 060 as NLM next to the other call numbers for this bib.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  8 09:33:44 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 08 Jan 2020 08:33:44 +0000
Subject: [Koha-bugs] [Bug 10517] koha-restore fails to create
 mysqluser@mysql_hostname so zebra update fails
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10517

--- Comment #10 from Rudolf Byker  ---
There is more than one attachment. The one from 2013 is not a patch. My one
from 2019-05-10 is a patch created with "diff". Which one are you referring to?

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  8 09:55:09 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 08 Jan 2020 08:55:09 +0000
Subject: [Koha-bugs] [Bug 10517] koha-restore fails to create
 mysqluser@mysql_hostname so zebra update fails
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10517

--- Comment #11 from Katrin Fischer  ---
HI Rudolf, yours actually :) - diff doesn't create a patch file that can be
used with our tools. Have a look at git format --patch and
https://wiki.koha-community.org/wiki/Commit_messages. If you compare to patch
files from other bugs you will see yours is missing the header line with
authorship etc.
Also missing bug reference (subject line), description, test plan etc. So this
needs a little more work. Please let us know if we can help - I was not sure if
you were still around and just trying to encourage someone to maybe pick this
up to finish. Usually in January we have a group of students tackle things, but
it won't happen this year :(

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  8 09:55:57 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 08 Jan 2020 08:55:57 +0000
Subject: [Koha-bugs] [Bug 10517] koha-restore fails to create
 mysqluser@mysql_hostname so zebra update fails
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10517

--- Comment #12 from Katrin Fischer  ---
... oh and status should be set to "Needs Sign-off" once the patch is fixed up
and Assignee should be you, if you intent continuing work on it.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  8 10:01:08 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 08 Jan 2020 09:01:08 +0000
Subject: [Koha-bugs] [Bug 10517] koha-restore fails to create
 mysqluser@mysql_hostname so zebra update fails
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10517

--- Comment #13 from Katrin Fischer  ---

> used with our tools. Have a look at git format --patch and

git format-patch

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  8 10:06:26 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 08 Jan 2020 09:06:26 +0000
Subject: [Koha-bugs] [Bug 10517] koha-restore fails to create
 mysqluser@mysql_hostname so zebra update fails
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10517

--- Comment #14 from Rudolf Byker  ---
OK, let me be your student then, and try the things you suggested. (BTW, I also
noticed that my patch was reversed. :facepalm: )

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  8 10:14:42 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 08 Jan 2020 09:14:42 +0000
Subject: [Koha-bugs] [Bug 14759] Replacement for Text::Unaccent
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14759

--- Comment #37 from Martin Renvoize  ---
Created attachment 96974
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96974&action=edit
Bug 14759: Replace Text::Unaccent with Unicode::Normalize

As shown in the comments on the bug, it appears that Unicode::Normalize
is the most reliable way to strip accents from strings for this use
case.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  8 10:17:32 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 08 Jan 2020 09:17:32 +0000
Subject: [Koha-bugs] [Bug 14759] Replacement for Text::Unaccent
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14759

Martin Renvoize  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #42120|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  8 10:17:46 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 08 Jan 2020 09:17:46 +0000
Subject: [Koha-bugs] [Bug 14759] Replacement for Text::Unaccent
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14759

Martin Renvoize  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|In Discussion               |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  8 10:30:42 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 08 Jan 2020 09:30:42 +0000
Subject: [Koha-bugs] [Bug 10517] koha-restore fails to create
 mysqluser@mysql_hostname so zebra update fails
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10517

Rudolf Byker  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #89529|0                           |1
        is obsolete|                            |
           Assignee|koha-bugs at lists.koha-commun |rudolfbyker at gmail.com
                   |ity.org                     |
             Status|NEW                         |Needs Signoff

--- Comment #15 from Rudolf Byker  ---
Created attachment 96975
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96975&action=edit
Use `DROP USER IF EXISTS` and remove ` || true`.

All right, here is my attempt at a proper patch!

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  8 10:31:00 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 08 Jan 2020 09:31:00 +0000
Subject: [Koha-bugs] [Bug 10517] koha-restore fails to create
 mysqluser@mysql_hostname so zebra update fails
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10517

Rudolf Byker  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Change sponsored?|---                         |Sponsored
   Patch complexity|---                         |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  8 10:41:47 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 08 Jan 2020 09:41:47 +0000
Subject: [Koha-bugs] [Bug 12104] Add print label to serials receive
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12104

Séverine Queune  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Change sponsored?|Seeking developer           |---

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  8 11:01:04 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 08 Jan 2020 10:01:04 +0000
Subject: [Koha-bugs] [Bug 20076] Overdues: remove redundant message when
 patrons don't have email addresses
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20076

Sophie MEYNIEUX  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |arthur.suzuki at biblibre.com
                   |ity.org                     |

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  8 11:54:49 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 08 Jan 2020 10:54:49 +0000
Subject: [Koha-bugs] [Bug 20076] Overdues: remove redundant message when
 patrons don't have email addresses
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20076

--- Comment #9 from Arthur Suzuki  ---
Hi Katrin,
Bit of followup on my side : maybe easiest to make this parameter a commandline
parameter than a syspref?
At least it'll be less of a hassle to maintain.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  8 12:05:23 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 08 Jan 2020 11:05:23 +0000
Subject: [Koha-bugs] [Bug 24329] Patron cardnumber change times are lost
 during upgrade for bug 3820
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24329

Martin Renvoize  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|                            |20.05.00
        released in|                            |
             Status|Passed QA                   |Pushed to master

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  8 12:05:25 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 08 Jan 2020 11:05:25 +0000
Subject: [Koha-bugs] [Bug 24329] Patron cardnumber change times are lost
 during upgrade for bug 3820
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24329

--- Comment #9 from Martin Renvoize  ---
Nice work everyone!

Pushed to master for 20.05

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  8 12:51:46 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 08 Jan 2020 11:51:46 +0000
Subject: [Koha-bugs] [Bug 24339] SIP codes are missing from the default
 payment_types on installation
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24339

--- Comment #1 from Martin Renvoize  ---
Created attachment 96976
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96976&action=edit
Bug 24339: Add SIP2 payment types for installation

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  8 13:09:14 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 08 Jan 2020 12:09:14 +0000
Subject: [Koha-bugs] [Bug 20076] Overdues: remove redundant message when
 patrons don't have email addresses
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20076

--- Comment #10 from Katrin Fischer  ---
(In reply to Arthur Suzuki from comment #9)
> Hi Katrin,
> Bit of followup on my side : maybe easiest to make this parameter a
> commandline parameter than a syspref?
> At least it'll be less of a hassle to maintain.

I think a cronjob parameter is more hassle than a syspref in maintaining - I
need my admins to change that, a pref I can switch ;)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  8 13:17:13 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 08 Jan 2020 12:17:13 +0000
Subject: [Koha-bugs] [Bug 14282] Add configurable http headers for
 retrievable uploads (see 6874)
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14282

--- Comment #2 from Marcel de Rooy  ---
Yes, not much info here, but there are some pointers on bug 6874.
We now use a general http header when downloading an uploaded file with
tools/upload.pl: type=application/octet-stream. For PDF files we hardcoded
application/pdf. This allows some browsers to show the file contents for e.g. a
PDF file rightaway, etc. The idea for this bug was to make that configurable,
i.e. add other headers where locally needed. From a preference or config file.

But it did not move since then ;)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  8 13:20:53 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 08 Jan 2020 12:20:53 +0000
Subject: [Koha-bugs] [Bug 20076] Overdues: remove redundant message when
 patrons don't have email addresses
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20076

--- Comment #11 from Katrin Fischer  ---
(In reply to Katrin Fischer from comment #10)
> (In reply to Arthur Suzuki from comment #9)
> > Hi Katrin,
> > Bit of followup on my side : maybe easiest to make this parameter a
> > commandline parameter than a syspref?
> > At least it'll be less of a hassle to maintain.
> 
> I think a cronjob parameter is more hassle than a syspref in maintaining - I
> need my admins to change that, a pref I can switch ;)

Also: think package installations with instances. If some libraries want the
message and others not, I have a lot more maintenance/lines in the job.
Currently it works for us with one line for everyone. Preferences mean more
flexibility.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  8 13:23:04 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 08 Jan 2020 12:23:04 +0000
Subject: [Koha-bugs] [Bug 24160] Short loan collection holds
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24160

Fiona Borthwick  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |fiona.borthwick at ptfs-europe
                   |                            |.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  8 13:25:41 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 08 Jan 2020 12:25:41 +0000
Subject: [Koha-bugs] [Bug 24157] Additional acquisitions permissions
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24157

Fiona Borthwick  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |fiona.borthwick at ptfs-europe
                   |                            |.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  8 13:31:16 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 08 Jan 2020 12:31:16 +0000
Subject: [Koha-bugs] [Bug 21946] Group circulation by item type
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21946

Nick Clemens  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Patch doesn't apply         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  8 13:31:19 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 08 Jan 2020 12:31:19 +0000
Subject: [Koha-bugs] [Bug 21946] Group circulation by item type
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21946

Nick Clemens  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #93096|0                           |1
        is obsolete|                            |

--- Comment #79 from Nick Clemens  ---
Created attachment 96977
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96977&action=edit
Bug 21946: Database updates

Signed-off-by: Liz Rea 

Signed-off-by: Lisette Scheer 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  8 13:31:23 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 08 Jan 2020 12:31:23 +0000
Subject: [Koha-bugs] [Bug 21946] Group circulation by item type
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21946

Nick Clemens  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #93097|0                           |1
        is obsolete|                            |

--- Comment #80 from Nick Clemens  ---
Created attachment 96978
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96978&action=edit
Bug 21946: Update C4::Circulation->TooMany to check parent itemtypes

To test:
1 - prove -v t/db_dependent/Circulation/TooMany.t

Signed-off-by: Liz Rea 

Signed-off-by: Lisette Scheer 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  8 13:31:27 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 08 Jan 2020 12:31:27 +0000
Subject: [Koha-bugs] [Bug 21946] Group circulation by item type
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21946

Nick Clemens  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #93098|0                           |1
        is obsolete|                            |

--- Comment #81 from Nick Clemens  ---
Created attachment 96979
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96979&action=edit
Bug 21946: Update Administration->Item types to allow for defining parent types

To test:
1 - Browse to Administration -> Item types
2 - Not a new colum for prent type
3 - Edit an existing type and not you can select any type (except the current)
as a parent
4 - Select one
5 - Edit the type you selected as parent
6 - Note it cannot have a parent defined
7 - Edit a new type, note you can select a parent

Signed-off-by: Liz Rea 

Signed-off-by: Lisette Scheer 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  8 13:31:30 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 08 Jan 2020 12:31:30 +0000
Subject: [Koha-bugs] [Bug 21946] Group circulation by item type
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21946

Nick Clemens  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #93099|0                           |1
        is obsolete|                            |

--- Comment #82 from Nick Clemens  ---
Created attachment 96980
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96980&action=edit
Bug 21946: Fix display of parent types

Signed-off-by: Liz Rea 

Signed-off-by: Lisette Scheer 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  8 13:31:34 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 08 Jan 2020 12:31:34 +0000
Subject: [Koha-bugs] [Bug 21946] Group circulation by item type
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21946

Nick Clemens  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #93100|0                           |1
        is obsolete|                            |

--- Comment #83 from Nick Clemens  ---
Created attachment 96981
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96981&action=edit
Bug 21946: Use objects for displaying circulation rules

Signed-off-by: Liz Rea 

Signed-off-by: Lisette Scheer 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  8 13:31:37 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 08 Jan 2020 12:31:37 +0000
Subject: [Koha-bugs] [Bug 21946] Group circulation by item type
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21946

Nick Clemens  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #93101|0                           |1
        is obsolete|                            |

--- Comment #84 from Nick Clemens  ---
Created attachment 96982
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96982&action=edit
Bug 21946: Display parent-child relationship on smart-rules.pl

To test:
 1 - Set some itemtypes to have a parent
 2 - Browse to Administration -> Circulation and fines rules
 3 - Note new description of parent/child relationships at top of page
 4 - Note that itemtype dropdown for circ rules shows child types under parents
 5 - Set a rule for a child type
 6 - Note it displays as Parent->Child
 7 - Have three child types under a parent
 8 - Set the parent 'Current checkouts allowed' to 3
 9 - Set the children 'Current checkouts allowed' to:
     type1 = 2
     type2 = 1
     type3 = 1
10 - Create some items of the type above
11 - Note you can checkout 2 of type 1, and not 3
12 - Note you can checkout 1 of type 2, but not 2
13 - Note that you now cannot checkout any of type3
14 - Note you cannot checkout any of the parent type
15 - Return one of the other items and note you can now checkout an item of
type3
16 - Return another item and note you can checkout an item of the parent type
17 - Return all
18 - Set the parent type to 1
19 - Now note you can only checkout 1 of any of the children
20 - Set the parent to 0
21 - Note you cannot checkout any of the child types

Signed-off-by: Liz Rea 

Signed-off-by: Lisette Scheer 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  8 13:31:41 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 08 Jan 2020 12:31:41 +0000
Subject: [Koha-bugs] [Bug 21946] Group circulation by item type
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21946

Nick Clemens  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #93102|0                           |1
        is obsolete|                            |

--- Comment #85 from Nick Clemens  ---
Created attachment 96983
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96983&action=edit
Bug 21946: (follow-up) Correct dropdown when editing rule

Signed-off-by: Liz Rea 

Signed-off-by: Lisette Scheer 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  8 13:31:44 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 08 Jan 2020 12:31:44 +0000
Subject: [Koha-bugs] [Bug 21946] Group circulation by item type
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21946

Nick Clemens  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #93103|0                           |1
        is obsolete|                            |

--- Comment #86 from Nick Clemens  ---
Created attachment 96984
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96984&action=edit
Bug 21946: (QA follow-up) - remove console.log

To make QA tools happy

Signed-off-by: Liz Rea 

Signed-off-by: Lisette Scheer 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  8 13:31:48 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 08 Jan 2020 12:31:48 +0000
Subject: [Koha-bugs] [Bug 21946] Group circulation by item type
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21946

Nick Clemens  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #93104|0                           |1
        is obsolete|                            |

--- Comment #87 from Nick Clemens  ---
Created attachment 96985
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96985&action=edit
Bug 21946: (follow-up) Address QA concerns

1 - Correct hashref for searching
2 - Correct undef for all (this only simplifies later logic so didn't affect
outcomes)
3 - remove duplicated query
4 - Use get_column instead of loops
5 - Fix typo
6 - Whitespace fixes removed from earlier patches

Signed-off-by: Lisette Scheer 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  8 13:31:51 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 08 Jan 2020 12:31:51 +0000
Subject: [Koha-bugs] [Bug 21946] Group circulation by item type
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21946

Nick Clemens  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #93105|0                           |1
        is obsolete|                            |

--- Comment #88 from Nick Clemens  ---
Created attachment 96986
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96986&action=edit
Bug 21946: DO NOT PUSH - Schema updates

Signed-off-by: Lisette Scheer 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  8 13:31:55 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 08 Jan 2020 12:31:55 +0000
Subject: [Koha-bugs] [Bug 21946] Group circulation by item type
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21946

--- Comment #89 from Nick Clemens  ---
Created attachment 96987
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96987&action=edit
Bug 21946: Update unit tests to pass under ES

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  8 13:45:25 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 08 Jan 2020 12:45:25 +0000
Subject: [Koha-bugs] [Bug 20076] Overdues: remove redundant message when
 patrons don't have email addresses
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20076

--- Comment #12 from Magnus Enger  ---
(In reply to Katrin Fischer from comment #11)
> Also: think package installations with instances. If some libraries want the
> message and others not, I have a lot more maintenance/lines in the job.
> Currently it works for us with one line for everyone. Preferences mean more
> flexibility.

I agree wirh Katrin here. Sysprefs give more flexibility, espcially in a
multi-tenant setup. It also means libraries that do not have hands on access to
their Koha server can change things without relying on their provider to do it
for them.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  8 13:49:58 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 08 Jan 2020 12:49:58 +0000
Subject: [Koha-bugs] [Bug 24339] SIP codes are missing from the default
 payment_types on installation
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24339

--- Comment #2 from Martin Renvoize  ---
Created attachment 96988
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96988&action=edit
Bug 24339: Remove SIP payment types from staff pay screens

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  8 13:50:15 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 08 Jan 2020 12:50:15 +0000
Subject: [Koha-bugs] [Bug 24339] SIP codes are missing from the default
 payment_types on installation
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24339

Martin Renvoize  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  8 13:52:14 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 08 Jan 2020 12:52:14 +0000
Subject: [Koha-bugs] [Bug 24339] SIP codes are missing from the default
 payment_types on installation
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24339

--- Comment #3 from Martin Renvoize  ---
Test plan

1) Perform a fresh install and note that the SIP code payments types are
populated in the authorised_values table.
2) Make a payment via the staff client and note that the payment_type dropdown
still does not appear when only the SIP types are defined.
3) Define some additional payment types and make a payment again.. Note that
the new payment types are displayed in the dropdown but the SIP one's are not.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  8 13:52:36 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 08 Jan 2020 12:52:36 +0000
Subject: [Koha-bugs] [Bug 24339] SIP codes are missing from the default
 payment_types on installation
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24339

Martin Renvoize  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de,
                   |                            |kyle at bywatersolutions.com,
                   |                            |tomascohen at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  8 13:54:36 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 08 Jan 2020 12:54:36 +0000
Subject: [Koha-bugs] [Bug 24252] Add credits, debits,
 credit_offsets and debit_offsets relationships to
 Koha::Account::Line
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24252

Martin Renvoize  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         QA Contact|testopia at bugs.koha-communit |tomascohen at gmail.com
                   |y.org                       |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  8 14:06:37 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 08 Jan 2020 13:06:37 +0000
Subject: [Koha-bugs] [Bug 19008] More database cleanups
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19008

Magnus Enger  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

--- Comment #38 from Magnus Enger  ---
So I did a small rebase and added a followup with some POD. Setting the status
to "Signed off". Please change it back if my changes require another signoff.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  8 14:09:29 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 08 Jan 2020 13:09:29 +0000
Subject: [Koha-bugs] [Bug 19008] More database cleanups
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19008

--- Comment #39 from Magnus Enger  ---
This is clearly a step in the right direction, the cleanups added by these
patches are sorely needed. 

But I think the actions of the cleanup-script should be governed by sysprefs,
not command line switches. There are several reasons for this: 

- On a package install with several instances this means we can have one line
in the cron-setup to trigger the script, with koha-foreach, but all the sites
can have their individual configurations

- Libraries that do not have hands on access to their Koha server can change
the setup without going through their provider

- And most importantly, I think: Libraries can tell what they are cleaning up
and anonymizing, by looking at the sysprefs, instead of having to figure out
what the command line switches are and do. (I *think* it is a requirement of
the GDPR that libraries should be able to tell what they are doing with their
data. Having a few sysprefs to look at seems way better than having to ask a
provider what the command line switches of the cronjob are set to.)

But priority number 1 should be getting these patches in in the first place,
then we can do the enhancement on another bug.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  8 14:11:30 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 08 Jan 2020 13:11:30 +0000
Subject: [Koha-bugs] [Bug 24263] borrowers.relationship should not contain
 an empty string
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24263

Tomás Cohen Arazi  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  8 14:11:32 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 08 Jan 2020 13:11:32 +0000
Subject: [Koha-bugs] [Bug 24263] borrowers.relationship should not contain
 an empty string
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24263

Tomás Cohen Arazi  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #96531|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  8 14:11:34 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 08 Jan 2020 13:11:34 +0000
Subject: [Koha-bugs] [Bug 24263] borrowers.relationship should not contain
 an empty string
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24263

Tomás Cohen Arazi  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #96532|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  8 14:11:36 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 08 Jan 2020 13:11:36 +0000
Subject: [Koha-bugs] [Bug 24263] borrowers.relationship should not contain
 an empty string
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24263

Tomás Cohen Arazi  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #96533|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  8 14:11:58 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 08 Jan 2020 13:11:58 +0000
Subject: [Koha-bugs] [Bug 23442] Add a 'refund' process to accounts
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23442

Martin Renvoize  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Patch doesn't apply         |Needs Signoff

--- Comment #18 from Martin Renvoize  ---
Erm, 

I can't replicate that.. did you apply the chain of dependencies and are you
running against master?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  8 14:12:37 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 08 Jan 2020 13:12:37 +0000
Subject: [Koha-bugs] [Bug 24263] borrowers.relationship should not contain
 an empty string
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24263

--- Comment #13 from Tomás Cohen Arazi  ---
Created attachment 96989
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96989&action=edit
Bug 24263: Add tests

Signed-off-by: Martin Renvoize 
Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  8 14:12:41 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 08 Jan 2020 13:12:41 +0000
Subject: [Koha-bugs] [Bug 24263] borrowers.relationship should not contain
 an empty string
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24263

--- Comment #14 from Tomás Cohen Arazi  ---
Created attachment 96990
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96990&action=edit
Bug 24263: DB changes

Signed-off-by: Martin Renvoize 
Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  8 14:12:45 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 08 Jan 2020 13:12:45 +0000
Subject: [Koha-bugs] [Bug 24263] borrowers.relationship should not contain
 an empty string
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24263

--- Comment #15 from Tomás Cohen Arazi  ---
Created attachment 96991
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96991&action=edit
Bug 24263: Replace borrowers.relationship with NULL when was empty string

When you create a new patron, its relationship field is populated with
an empty string when we are expecting NULL.

Otherwise the about page will display a warning about a missing/wrong
relationship in data (that is not in the syspref)

Test plan:
0/ Do not apply the patches from this bug report
1/ Create a new patron (child)
2/ Notice that relationship column in DB is set to an empty string
3/ Go to the about page, notice the invalid warning about relationship
values not in the syspref
4/ Apply DB changes and tests
5/ Execute the update DB entry
=> The value in DB is now NULL when was ""
6/ Execute the tests
=> It fails
7/ Apply the last patch
8/ Add and edit a patron (child)
=> relationship is set to NULL in DB
9/ Execute the tests
=> They pass!

Signed-off-by: Martin Renvoize 
Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  8 14:12:48 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 08 Jan 2020 13:12:48 +0000
Subject: [Koha-bugs] [Bug 24263] borrowers.relationship should not contain
 an empty string
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24263

--- Comment #16 from Tomás Cohen Arazi  ---
Created attachment 96992
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96992&action=edit
Bug 24263: (QA follow-up) Atomic update fixes

Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  8 14:27:17 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 08 Jan 2020 13:27:17 +0000
Subject: [Koha-bugs] [Bug 24277] Date Received in acquisitions cannot be
 changed
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24277

Tomás Cohen Arazi  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |tomascohen at gmail.com
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  8 14:27:19 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 08 Jan 2020 13:27:19 +0000
Subject: [Koha-bugs] [Bug 24277] Date Received in acquisitions cannot be
 changed
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24277

Tomás Cohen Arazi  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #96614|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  8 14:44:39 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 08 Jan 2020 13:44:39 +0000
Subject: [Koha-bugs] [Bug 23442] Add a 'refund' process to accounts
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23442

--- Comment #19 from Michal Denar  ---
I'm on masted, all depencies applied. I'll try it again.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  8 14:45:55 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 08 Jan 2020 13:45:55 +0000
Subject: [Koha-bugs] [Bug 24277] Date Received in acquisitions cannot be
 changed
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24277

Tomás Cohen Arazi  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #96614|1                           |0
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  8 14:46:46 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 08 Jan 2020 13:46:46 +0000
Subject: [Koha-bugs] [Bug 24277] Date Received in acquisitions cannot be
 changed
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24277

Tomás Cohen Arazi  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |ASSIGNED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  8 14:46:51 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 08 Jan 2020 13:46:51 +0000
Subject: [Koha-bugs] [Bug 24277] Date Received in acquisitions cannot be
 changed
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24277

Tomás Cohen Arazi  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         QA Contact|testopia at bugs.koha-communit |tomascohen at gmail.com
                   |y.org                       |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  8 14:57:51 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 08 Jan 2020 13:57:51 +0000
Subject: [Koha-bugs] [Bug 24277] Date Received in acquisitions cannot be
 changed
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24277

Tomás Cohen Arazi  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  8 14:57:53 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 08 Jan 2020 13:57:53 +0000
Subject: [Koha-bugs] [Bug 24277] Date Received in acquisitions cannot be
 changed
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24277

Tomás Cohen Arazi  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #96614|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  8 14:58:08 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 08 Jan 2020 13:58:08 +0000
Subject: [Koha-bugs] [Bug 24277] Date Received in acquisitions cannot be
 changed
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24277

Tomás Cohen Arazi  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  8 14:58:21 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 08 Jan 2020 13:58:21 +0000
Subject: [Koha-bugs] [Bug 24277] Date Received in acquisitions cannot be
 changed
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24277

Tomás Cohen Arazi  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  8 14:58:46 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 08 Jan 2020 13:58:46 +0000
Subject: [Koha-bugs] [Bug 24277] Date Received in acquisitions cannot be
 changed
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24277

--- Comment #9 from Tomás Cohen Arazi  ---
Created attachment 96993
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96993&action=edit
Bug 24277: Regression tests

Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  8 14:58:49 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 08 Jan 2020 13:58:49 +0000
Subject: [Koha-bugs] [Bug 24277] Date Received in acquisitions cannot be
 changed
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24277

--- Comment #10 from Tomás Cohen Arazi  ---
Created attachment 96994
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96994&action=edit
Bug 24277: Fix date received editing when receiving an order

Bug 8417 added the ability to edit the date received, but a merge
conflict was wrongly resolved during a rebase of
  commit 20d9ed618fbe3cdcb9c04444a1f8a584b0364069
  Bug 13321: Rename variables

Test plan:
Create an order
Receive it
Set a date (different from today)
=> The date you picked should have been set in DB for the order

Signed-off-by: Andrew Fuerste-Henry 
Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  8 15:05:59 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 08 Jan 2020 14:05:59 +0000
Subject: [Koha-bugs] [Bug 24252] Add credits, debits,
 credit_offsets and debit_offsets relationships to
 Koha::Account::Line
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24252

Tomás Cohen Arazi  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  8 15:06:01 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 08 Jan 2020 14:06:01 +0000
Subject: [Koha-bugs] [Bug 24252] Add credits, debits,
 credit_offsets and debit_offsets relationships to
 Koha::Account::Line
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24252

Tomás Cohen Arazi  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #96518|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  8 15:08:40 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 08 Jan 2020 14:08:40 +0000
Subject: [Koha-bugs] [Bug 24252] Add credits, debits,
 credit_offsets and debit_offsets relationships to
 Koha::Account::Line
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24252

--- Comment #4 from Tomás Cohen Arazi  ---
Created attachment 96995
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96995&action=edit
Bug 24252: Add relations to Koha::Account::Line

This patch adds two new relationships to the Koha::Account::Line object.

* credit_offsets - returns all credit type Koha::Account::Offsets
  related to this Koha::Account::Line.
* debit_offsets - returns all debit type Koha::Account::Offsets related
  to this Koha::Account::Line.
* credits - returns all credits related to this Koha::Account::Line.
* debits - returns all debits related to this Koha::Account::Line.

Signed-off-by: Kyle M Hall 
Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  8 15:08:45 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 08 Jan 2020 14:08:45 +0000
Subject: [Koha-bugs] [Bug 20307] Language overlay for authorized values
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20307

--- Comment #74 from Martin Renvoize  ---
This is looking pretty solid to me at the moment.. would love to see a QA stamp
on it soon if anyone has the time to take a look :)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  8 15:11:25 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 08 Jan 2020 14:11:25 +0000
Subject: [Koha-bugs] [Bug 24374] New: Make SMS-errors from
 process_message_queue.pl more informational
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24374

            Bug ID: 24374
           Summary: Make SMS-errors from process_message_queue.pl more
                    informational
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Notices
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: magnus at libriotech.no
        QA Contact: testopia at bugs.koha-community.org

The Debian packages run process_message_queue.pl thusly:

  koha-foreach --chdir --enabled --email
/usr/share/koha/bin/cronjobs/process_message_queue.pl

This can result in errors like this in an email to the server admin: 

Cannot use regional phone numbers with an international driver at
/usr/share/koha/lib/C4/SMS.pm line 120.

Not very informative... It would be great if we could add the actual SMS number
that failed, as well as the name of the Koha instance/site where it came from.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  8 15:19:42 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 08 Jan 2020 14:19:42 +0000
Subject: [Koha-bugs] [Bug 20307] Language overlay for authorized values
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20307

--- Comment #75 from Tomás Cohen Arazi  ---
(In reply to Martin Renvoize from comment #74)
> This is looking pretty solid to me at the moment.. would love to see a QA
> stamp on it soon if anyone has the time to take a look :)

Am I allowed to remove the use of C4::Language in Koha::*?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  8 15:21:59 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 08 Jan 2020 14:21:59 +0000
Subject: [Koha-bugs] [Bug 24054] Typo in ClaimReturnedWarningThreshold
 system preference
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24054

Martin Renvoize  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|                            |20.05.00
        released in|                            |
             Status|Passed QA                   |Pushed to master

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  8 15:22:01 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 08 Jan 2020 14:22:01 +0000
Subject: [Koha-bugs] [Bug 24054] Typo in ClaimReturnedWarningThreshold
 system preference
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24054

--- Comment #3 from Martin Renvoize  ---
Nice work everyone!

Pushed to master for 20.05

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  8 15:22:02 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 08 Jan 2020 14:22:02 +0000
Subject: [Koha-bugs] [Bug 24104] Item search - dropdown buttons overflow
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24104

Martin Renvoize  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to master
         Version(s)|                            |20.05.00
        released in|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  8 15:22:04 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 08 Jan 2020 14:22:04 +0000
Subject: [Koha-bugs] [Bug 24104] Item search - dropdown buttons overflow
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24104

--- Comment #5 from Martin Renvoize  ---
Nice work everyone!

Pushed to master for 20.05

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  8 15:25:50 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 08 Jan 2020 14:25:50 +0000
Subject: [Koha-bugs] [Bug 24263] borrowers.relationship should not contain
 an empty string
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24263

Martin Renvoize  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to master
         Version(s)|                            |20.05.00
        released in|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  8 15:25:52 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 08 Jan 2020 14:25:52 +0000
Subject: [Koha-bugs] [Bug 24263] borrowers.relationship should not contain
 an empty string
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24263

--- Comment #17 from Martin Renvoize  ---
Nice work everyone!

Pushed to master for 20.05

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  8 15:25:54 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 08 Jan 2020 14:25:54 +0000
Subject: [Koha-bugs] [Bug 24327] Anonymous suggestions should not be allowed
 if AnonymousPatron misconfigured
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24327

Martin Renvoize  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to master
         Version(s)|                            |20.05.00
        released in|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  8 15:25:56 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 08 Jan 2020 14:25:56 +0000
Subject: [Koha-bugs] [Bug 24327] Anonymous suggestions should not be allowed
 if AnonymousPatron misconfigured
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24327

--- Comment #10 from Martin Renvoize  ---
Nice work everyone!

Pushed to master for 20.05

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  8 15:27:17 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 08 Jan 2020 14:27:17 +0000
Subject: [Koha-bugs] [Bug 24277] Date Received in acquisitions cannot be
 changed
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24277

Martin Renvoize  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|                            |20.05.00
        released in|                            |
             Status|Passed QA                   |Pushed to master

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  8 15:27:19 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 08 Jan 2020 14:27:19 +0000
Subject: [Koha-bugs] [Bug 24277] Date Received in acquisitions cannot be
 changed
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24277

--- Comment #11 from Martin Renvoize  ---
Nice work everyone!

Pushed to master for 20.05

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  8 15:33:38 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 08 Jan 2020 14:33:38 +0000
Subject: [Koha-bugs] [Bug 20307] Language overlay for authorized values
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20307

--- Comment #76 from Tomás Cohen Arazi  ---
(In reply to Tomás Cohen Arazi from comment #75)
> (In reply to Martin Renvoize from comment #74)
> > This is looking pretty solid to me at the moment.. would love to see a QA
> > stamp on it soon if anyone has the time to take a look :)
> 
> Am I allowed to remove the use of C4::Language in Koha::*?

I agree this should be pushed. And until we have a guideline for this, we can
deal with fixing it on a separate bug.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  8 15:34:26 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 08 Jan 2020 14:34:26 +0000
Subject: [Koha-bugs] [Bug 21466] Data inconsistencies - koha fields linked
 to AV cat values must have a corresponding authorised value
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21466

Martin Renvoize  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |RM_priority

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  8 15:36:23 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 08 Jan 2020 14:36:23 +0000
Subject: [Koha-bugs] [Bug 20307] Language overlay for authorized values
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20307

--- Comment #77 from Kyle M Hall  ---
Could you please add unit tests for the new subs?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  8 15:36:37 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 08 Jan 2020 14:36:37 +0000
Subject: [Koha-bugs] [Bug 21959] Batch item modification - ability to apply
 regular expression on text fields
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21959

Martin Renvoize  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |Manual,
                   |                            |release-notes-needed

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  8 15:39:32 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 08 Jan 2020 14:39:32 +0000
Subject: [Koha-bugs] [Bug 23893] Add ->new_from_api and ->set_from_api
 methods to Koha::Object
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23893

Martin Renvoize  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|rel_20_05_target            |release-notes-needed

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  8 15:42:07 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 08 Jan 2020 14:42:07 +0000
Subject: [Koha-bugs] [Bug 24321] Make objects.search use mappings from
 Koha::Object(s)
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24321

Martin Renvoize  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |release-notes-needed

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  8 15:43:36 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 08 Jan 2020 14:43:36 +0000
Subject: [Koha-bugs] [Bug 21959] Batch item modification - ability to apply
 regular expression on text fields
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21959

Martin Renvoize  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|                            |20.05.00
        released in|                            |
             Status|Passed QA                   |Pushed to master

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  8 15:43:38 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 08 Jan 2020 14:43:38 +0000
Subject: [Koha-bugs] [Bug 21959] Batch item modification - ability to apply
 regular expression on text fields
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21959

--- Comment #31 from Martin Renvoize  ---
Nice work everyone!

Pushed to master for 20.05

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  8 15:43:40 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 08 Jan 2020 14:43:40 +0000
Subject: [Koha-bugs] [Bug 23893] Add ->new_from_api and ->set_from_api
 methods to Koha::Object
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23893

Martin Renvoize  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|                            |20.05.00
        released in|                            |
             Status|Passed QA                   |Pushed to master

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  8 15:43:42 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 08 Jan 2020 14:43:42 +0000
Subject: [Koha-bugs] [Bug 23893] Add ->new_from_api and ->set_from_api
 methods to Koha::Object
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23893

--- Comment #47 from Martin Renvoize  ---
Nice work everyone!

Pushed to master for 20.05

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  8 15:43:44 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 08 Jan 2020 14:43:44 +0000
Subject: [Koha-bugs] [Bug 24308] Suggestions table on suggestions.pl should
 have separate columns for dates
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24308

Martin Renvoize  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|                            |20.05.00
        released in|                            |
             Status|Passed QA                   |Pushed to master

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  8 15:43:46 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 08 Jan 2020 14:43:46 +0000
Subject: [Koha-bugs] [Bug 24308] Suggestions table on suggestions.pl should
 have separate columns for dates
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24308

--- Comment #8 from Martin Renvoize  ---
Nice work everyone!

Pushed to master for 20.05

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  8 15:43:48 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 08 Jan 2020 14:43:48 +0000
Subject: [Koha-bugs] [Bug 24321] Make objects.search use mappings from
 Koha::Object(s)
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24321

Martin Renvoize  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|                            |20.05.00
        released in|                            |
             Status|Passed QA                   |Pushed to master

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  8 15:43:50 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 08 Jan 2020 14:43:50 +0000
Subject: [Koha-bugs] [Bug 24321] Make objects.search use mappings from
 Koha::Object(s)
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24321

--- Comment #65 from Martin Renvoize  ---
Nice work everyone!

Pushed to master for 20.05

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  8 15:48:37 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 08 Jan 2020 14:48:37 +0000
Subject: [Koha-bugs] [Bug 24255] Add totals methods Koha::Account::Lines
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24255

Kyle M Hall  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  8 15:48:40 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 08 Jan 2020 14:48:40 +0000
Subject: [Koha-bugs] [Bug 24255] Add totals methods Koha::Account::Lines
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24255

Kyle M Hall  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #96405|0                           |1
        is obsolete|                            |

--- Comment #4 from Kyle M Hall  ---
Created attachment 96996
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96996&action=edit
Bug 24255: Add summation methods to Koha::Account::Lines

This patch adds a number of summation methods to Koha::Account::Lines
giving quick access to overall total, total credits and total debits.

Test plan
1) Run the included tests

Signed-off-by: Kyle M Hall 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  8 15:48:50 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 08 Jan 2020 14:48:50 +0000
Subject: [Koha-bugs] [Bug 24252] Add credits, debits,
 credit_offsets and debit_offsets relationships to
 Koha::Account::Line
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24252

Martin Renvoize  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to master
         Version(s)|                            |20.05.00
        released in|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  8 15:48:52 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 08 Jan 2020 14:48:52 +0000
Subject: [Koha-bugs] [Bug 24252] Add credits, debits,
 credit_offsets and debit_offsets relationships to
 Koha::Account::Line
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24252

--- Comment #5 from Martin Renvoize  ---
Nice work everyone!

Pushed to master for 20.05

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  8 15:49:19 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 08 Jan 2020 14:49:19 +0000
Subject: [Koha-bugs] [Bug 24373] Correct basic cataloging editor CSS
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24373

Lucas Gass  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #96960|0                           |1
        is obsolete|                            |

--- Comment #2 from Lucas Gass  ---
Created attachment 96997
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96997&action=edit
Bug 24373: Correct basic cataloging editor CSS

This patch makes minor corrections to the basic MARC editor CSS, fixing
an error caused by Bug 23259.

To test, apply the patch and clear your browser cache if necessary.

Open the basic MARC editor and check the numbered tabs. There should be
no stripe of green background showing below the tabs.

Signed-off-by: Lucas Gass 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  8 15:49:41 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 08 Jan 2020 14:49:41 +0000
Subject: [Koha-bugs] [Bug 24373] Correct basic cataloging editor CSS
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24373

Lucas Gass  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |lucas at bywatersolutions.com
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  8 15:57:51 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 08 Jan 2020 14:57:51 +0000
Subject: [Koha-bugs] [Bug 23893] Add ->new_from_api and ->set_from_api
 methods to Koha::Object
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23893

Tomás Cohen Arazi  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Text to go in the|                            |This development introduces
      release notes|                            |generic methods to deal
                   |                            |with API-to-DB attribute
                   |                            |names translations, and
                   |                            |some data transformations
                   |                            |(dates and booleans).
                   |                            |
                   |                            |With
                   |                            |this design we can overload
                   |                            |this methods to handle
                   |                            |specific cases without
                   |                            |repeating the code as we
                   |                            |did on initial
                   |                            |implementations of API
                   |                            |controllers.
                   |                            |
                   |                            |Testing
                   |                            |becomes easier as well.
         QA Contact|testopia at bugs.koha-communit |kyle at bywatersolutions.com
                   |y.org                       |

--- Comment #48 from Tomás Cohen Arazi  ---
Thanks, Martin.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  8 15:59:25 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 08 Jan 2020 14:59:25 +0000
Subject: [Koha-bugs] [Bug 14759] Replacement for Text::Unaccent
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14759

Martin Renvoize  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|normal                      |critical

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  8 16:01:31 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 08 Jan 2020 15:01:31 +0000
Subject: [Koha-bugs] [Bug 24321] Make objects.search use mappings from
 Koha::Object(s)
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24321

Tomás Cohen Arazi  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Text to go in the|                            |This development takes
      release notes|                            |advantage of the mappings
                   |                            |that have been added to the
                   |                            |Koha::Object level, and
                   |                            |refactors the
                   |                            |objects.search Mojolicious
                   |                            |helper so it uses it
                   |                            |internally.
                   |                            |
                   |                            |This allows us
                   |                            |to remove the 'to_model'
                   |                            |parameter, and makes the
                   |                            |need of any kind of mapping
                   |                            |on the controllers
                   |                            |irrelevant. All the
                   |                            |existing mappings are
                   |                            |removed and the controllers
                   |                            |simplified in this move.
         QA Contact|                            |kyle at bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  8 16:01:59 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 08 Jan 2020 15:01:59 +0000
Subject: [Koha-bugs] [Bug 24255] Add totals methods Koha::Account::Lines
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24255

Tomás Cohen Arazi  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         QA Contact|testopia at bugs.koha-communit |tomascohen at gmail.com
                   |y.org                       |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  8 16:03:11 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 08 Jan 2020 15:03:11 +0000
Subject: [Koha-bugs] [Bug 23473] Allow passwords to be imported/overwritten
 using the patron import tool
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23473

Nick Clemens  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  8 16:03:14 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 08 Jan 2020 15:03:14 +0000
Subject: [Koha-bugs] [Bug 23473] Allow passwords to be imported/overwritten
 using the patron import tool
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23473

Nick Clemens  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #95049|0                           |1
        is obsolete|                            |
  Attachment #95050|0                           |1
        is obsolete|                            |
  Attachment #95051|0                           |1
        is obsolete|                            |
  Attachment #95052|0                           |1
        is obsolete|                            |

--- Comment #18 from Nick Clemens  ---
Created attachment 96998
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96998&action=edit
Bug 23473: Allow overwrite of passwords during import

To test:
 1 - Have some patrons in your system
 2 - Export some of their info via reports
    SELECT cardnumber, userid, surname, firstname, password, branchcode,
categorycode
 3 - Edit the file from above, changing all the password lines
 4 - Import the file with overwrite
 5 - Confirm passwords have not changed (run the report again and confirm the
hashes are the same)
 6 - Apply patch
 7 - Restart all the things
 8 - Check the new box on import screen to overwrite passwrods
 9 - Import file again
10 - Confirm passwords have changed
11 - Signin using new password to verify the hash is the password as supplied
12 - Repeat via commandline import supplying --overwrite_passwords option
13 - Verify works as expected
14 - Prove -v t/db_dependent/Koha/Patrons/Import.t

Sponsored-by: ByWater Solutions

Signed-off-by: Ron Marion 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  8 16:03:17 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 08 Jan 2020 15:03:17 +0000
Subject: [Koha-bugs] [Bug 23473] Allow passwords to be imported/overwritten
 using the patron import tool
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23473

--- Comment #19 from Nick Clemens  ---
Created attachment 96999
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96999&action=edit
Bug 23473: (follow-up) Make passwords 'secure' for tests

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  8 16:03:20 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 08 Jan 2020 15:03:20 +0000
Subject: [Koha-bugs] [Bug 23473] Allow passwords to be imported/overwritten
 using the patron import tool
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23473

--- Comment #20 from Nick Clemens  ---
Created attachment 97000
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97000&action=edit
Bug 23473: (follow-up) check if overwrite_passwords is set

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  8 16:03:23 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 08 Jan 2020 15:03:23 +0000
Subject: [Koha-bugs] [Bug 23473] Allow passwords to be imported/overwritten
 using the patron import tool
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23473

--- Comment #21 from Nick Clemens  ---
Created attachment 97001
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97001&action=edit
Bug 23473: (follow-up) Catch and show password exceptions

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  8 16:03:26 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 08 Jan 2020 15:03:26 +0000
Subject: [Koha-bugs] [Bug 23473] Allow passwords to be imported/overwritten
 using the patron import tool
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23473

--- Comment #22 from Nick Clemens  ---
Created attachment 97002
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97002&action=edit
Bug 23473: Don't allow setting blank passwords via import

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  8 16:03:29 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 08 Jan 2020 15:03:29 +0000
Subject: [Koha-bugs] [Bug 23473] Allow passwords to be imported/overwritten
 using the patron import tool
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23473

--- Comment #23 from Nick Clemens  ---
Created attachment 97003
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97003&action=edit
Bug 23473: Don't allow staff password changes for imports

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  8 16:04:46 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 08 Jan 2020 15:04:46 +0000
Subject: [Koha-bugs] [Bug 23473] Allow passwords to be imported/overwritten
 using the patron import tool
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23473

--- Comment #24 from Nick Clemens  ---
(In reply to Jonathan Druart from comment #17)
> 1. If empty, should not we not update the password?
> 
> I get a "too_weak" error.

Okay, cannot blank passwords now

> 
> 2. You forgot to adjust the CLI script.

I don't think I did:
Bug 23473: Allow overwrite of passwords during import
a/misc/import_patrons.pl (+3 lines)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  8 16:05:44 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 08 Jan 2020 15:05:44 +0000
Subject: [Koha-bugs] [Bug 24228] Add a parameter to recursively embed
 objects in Koha::Object(s)->to_api
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24228

Martin Renvoize  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         QA Contact|testopia at bugs.koha-communit |martin.renvoize at ptfs-europe
                   |y.org                       |.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  8 16:06:45 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 08 Jan 2020 15:06:45 +0000
Subject: [Koha-bugs] [Bug 24228] Add a parameter to recursively embed
 objects in Koha::Object(s)->to_api
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24228

Martin Renvoize  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

--- Comment #17 from Martin Renvoize  ---
The uses here are clear and the code is mostly simple to follow.. Passing QA
and pushing, no doubt there will be refinements down the line but there's
nothing that stands out as introducing regressions or bad practice.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  8 16:07:56 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 08 Jan 2020 15:07:56 +0000
Subject: [Koha-bugs] [Bug 24228] Add a parameter to recursively embed
 objects in Koha::Object(s)->to_api
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24228

Martin Renvoize  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|                            |20.05.00
        released in|                            |
             Status|Passed QA                   |Pushed to master

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  8 16:07:59 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 08 Jan 2020 15:07:59 +0000
Subject: [Koha-bugs] [Bug 24228] Add a parameter to recursively embed
 objects in Koha::Object(s)->to_api
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24228

--- Comment #18 from Martin Renvoize  ---
Nice work everyone!

Pushed to master for 20.05

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  8 16:08:07 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 08 Jan 2020 15:08:07 +0000
Subject: [Koha-bugs] [Bug 14715] Results per page setting for catalog search
 in staff client and OPAC
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14715

Gabriel DeCarufel  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #95038|0                           |1
        is obsolete|                            |

--- Comment #93 from Gabriel DeCarufel  ---
Created attachment 97004
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97004&action=edit
Bug 14715: Results per page dropdown for catalogue search

This patch utilises an unused search facet to handle results shown per
page.

Sponsored-by: Region Halland
Signed-off-by: Gabriel DeCarufel 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  8 16:09:00 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 08 Jan 2020 15:09:00 +0000
Subject: [Koha-bugs] [Bug 24228] Add a parameter to recursively embed
 objects in Koha::Object(s)->to_api
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24228

Martin Renvoize  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |release-notes-needed

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  8 16:11:45 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 08 Jan 2020 15:11:45 +0000
Subject: [Koha-bugs] [Bug 24302] Add a way to specify nested objects to
 embed in OpenAPI
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24302

Martin Renvoize  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |release-notes-needed

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  8 16:12:04 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 08 Jan 2020 15:12:04 +0000
Subject: [Koha-bugs] [Bug 24302] Add a way to specify nested objects to
 embed in OpenAPI
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24302

Martin Renvoize  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

--- Comment #9 from Martin Renvoize  ---
As per bug 24228, Passing QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  8 16:12:41 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 08 Jan 2020 15:12:41 +0000
Subject: [Koha-bugs] [Bug 24257] item-transfer-modal does not initiate
 transfer when 'yes, print slip' is selected
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24257

Tomás Cohen Arazi  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         QA Contact|testopia at bugs.koha-communit |tomascohen at gmail.com
                   |y.org                       |
                 CC|                            |tomascohen at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  8 16:12:44 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 08 Jan 2020 15:12:44 +0000
Subject: [Koha-bugs] [Bug 24302] Add a way to specify nested objects to
 embed in OpenAPI
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24302

Martin Renvoize  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|                            |20.05.00
        released in|                            |
             Status|Passed QA                   |Pushed to master

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  8 16:12:46 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 08 Jan 2020 15:12:46 +0000
Subject: [Koha-bugs] [Bug 24302] Add a way to specify nested objects to
 embed in OpenAPI
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24302

--- Comment #10 from Martin Renvoize  ---
Nice work everyone!

Pushed to master for 20.05

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  8 16:18:50 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 08 Jan 2020 15:18:50 +0000
Subject: [Koha-bugs] [Bug 24373] Correct basic cataloging editor CSS
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24373

Guillaume Paquet  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #96997|0                           |1
        is obsolete|                            |

--- Comment #3 from Guillaume Paquet  ---
Created attachment 97005
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97005&action=edit
Bug 24373: Correct basic cataloging editor CSS

This patch makes minor corrections to the basic MARC editor CSS, fixing
an error caused by Bug 23259.

To test, apply the patch and clear your browser cache if necessary.

Open the basic MARC editor and check the numbered tabs. There should be
no stripe of green background showing below the tabs.

Signed-off-by: Guillaume Paquet 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  8 16:22:34 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 08 Jan 2020 15:22:34 +0000
Subject: [Koha-bugs] [Bug 24228] Add a parameter to recursively embed
 objects in Koha::Object(s)->to_api
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24228

Tomás Cohen Arazi  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Text to go in the|                            |This patch introduces a
      release notes|                            |parameter to the
                   |                            |Koha::Object class
                   |                            |('embed') that should be a
                   |                            |hashref pointing to a data
                   |                            |structure following what's
                   |                            |documented in the code.
                   |                            |This parameter allows the
                   |                            |caller to specify things to
                   |                            |embed recursively in the
                   |                            |API representation of the
                   |                            |object. For example: you
                   |                            |could request a biblio
                   |                            |object with its items
                   |                            |attached, like this:
                   |                            |
                   |                            |
                   |                            |$biblio_json =
                   |                            |$biblio->to_api({ embed =>
                   |                            |{ items => {} } });
                   |                            |
                   |                            |The
                   |                            |main use of this is the
                   |                            |API, as introduced by bug
                   |                            |24302.
                   |                            |
                   |                            |Koha::Objects->to_api is
                   |                            |adjusted to pass its
                   |                            |parameters down to the
                   |                            |Koha::Object.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  8 16:26:18 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 08 Jan 2020 15:26:18 +0000
Subject: [Koha-bugs] [Bug 24228] Add a parameter to recursively embed
 objects in Koha::Object(s)->to_api
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24228

Tomás Cohen Arazi  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Text to go in the|This patch introduces a     |This patch introduces a
      release notes|parameter to the            |parameter to the
                   |Koha::Object class          |Koha::Object class
                   |('embed') that should be a  |('embed') that should be a
                   |hashref pointing to a data  |hashref pointing to a data
                   |structure following what's  |structure following what's
                   |documented in the code.     |documented in the code.
                   |This parameter allows the   |This parameter allows the
                   |caller to specify things to |caller to specify things to
                   |embed recursively in the    |embed recursively in the
                   |API representation of the   |API representation of the
                   |object. For example: you    |object. For example: you
                   |could request a biblio      |could request a biblio
                   |object with its items       |object with its items
                   |attached, like this:
       |attached, like this:
                   |
                           |
                   |                            |
                   |$biblio_json =              |$biblio_json =
                   |$biblio->to_api({ embed =>  |$biblio->to_api({ embed =>
                   |{ items => {} } });
        |{ items => {} } });
                   |
                           |
                   |The                         |The
                   |main use of this is the     |names specified for
                   |API, as introduced by bug   |embedding, are used as
                   |24302.
                     |attribute names on the
                   |                            |resulting JSON object, and
                   |Koha::Objects->to_api is    |are expected to be class
                   |adjusted to pass its        |accessors.
                   |parameters down to the      |
                   |Koha::Object.               |The main use of
                   |                            |this is the API, as
                   |                            |introduced by bug 24302.
                   |                            |
                   |                            |Koha::Objects->to_api is
                   |                            |adjusted to pass its
                   |                            |parameters down to the
                   |                            |Koha::Object.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  8 16:30:53 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 08 Jan 2020 15:30:53 +0000
Subject: [Koha-bugs] [Bug 24302] Add a way to specify nested objects to
 embed in OpenAPI
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24302

Tomás Cohen Arazi  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Text to go in the|                            |This development introduces
      release notes|                            |a way to define embeddable
                   |                            |objects on API routes. On
                   |                            |the path specs, they will
                   |                            |be specified using dot
                   |                            |notation for nested
                   |                            |embeddings:
                   |                            |
                   |                            |"x-koha-embed": [
                   |                            |
                   |                            |'biblio',
                   |                            |
                   |                            |'biblio.items',
                   |                            |    'fund'
                   |                            |]
                   |                            |
                   |                            |The consumer will need
                   |                            |to add a header to the
                   |                            |request, specifying the
                   |                            |things they want to embed
                   |                            |using comma-separated
                   |                            |values like this:
                   |                            |
                   |                            |x-koha-embed: 'biblio,fund'
                   |                            |
                   |                            |This header will be
                   |                            |validated against the
                   |                            |endpoint spec and an error
                   |                            |code will be returned if
                   |                            |the request is not
                   |                            |appropriate.
         QA Contact|                            |martin.renvoize at ptfs-europe
                   |                            |.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  8 16:31:59 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 08 Jan 2020 15:31:59 +0000
Subject: [Koha-bugs] [Bug 3150] Move emails for sending cart and list
 contents into notices tool
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3150

Sally  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |sally.healey at cheshireshared
                   |                            |services.gov.uk

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  8 16:32:01 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 08 Jan 2020 15:32:01 +0000
Subject: [Koha-bugs] [Bug 24255] Add totals methods Koha::Account::Lines
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24255

Tomás Cohen Arazi  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  8 16:32:03 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 08 Jan 2020 15:32:03 +0000
Subject: [Koha-bugs] [Bug 24255] Add totals methods Koha::Account::Lines
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24255

Tomás Cohen Arazi  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #96996|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  8 16:32:36 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 08 Jan 2020 15:32:36 +0000
Subject: [Koha-bugs] [Bug 24255] Add totals methods Koha::Account::Lines
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24255

--- Comment #5 from Tomás Cohen Arazi  ---
Created attachment 97006
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97006&action=edit
Bug 24255: Add summation methods to Koha::Account::Lines

This patch adds a number of summation methods to Koha::Account::Lines
giving quick access to overall total, total credits and total debits.

Test plan
1) Run the included tests

Signed-off-by: Kyle M Hall 
Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  8 16:43:16 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 08 Jan 2020 15:43:16 +0000
Subject: [Koha-bugs] [Bug 24257] item-transfer-modal does not initiate
 transfer when 'yes, print slip' is selected
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24257

Tomás Cohen Arazi  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  8 16:43:18 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 08 Jan 2020 15:43:18 +0000
Subject: [Koha-bugs] [Bug 24257] item-transfer-modal does not initiate
 transfer when 'yes, print slip' is selected
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24257

Tomás Cohen Arazi  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #96422|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  8 16:43:37 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 08 Jan 2020 15:43:37 +0000
Subject: [Koha-bugs] [Bug 24257] item-transfer-modal does not initiate
 transfer when 'yes, print slip' is selected
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24257

--- Comment #5 from Tomás Cohen Arazi  ---
Created attachment 97007
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97007&action=edit
Bug 24257: Fix close of modal on 'Yes, print slip'

When a item-transfer-modal is prompted by returns.tt and the option
"Yes, print slip" is selected the transfer is not initiated and the
modal does not disappear.

The print_slip hidden input must be in the same form as the
submit/button .print, otherwise the browser logs
  this.form.print_slip is undefined

Test plan:
1. set AutomaticItemReturn to "don't"
2. Check out an item and attempt to check it in at a branch it doesn't
belong to.
3. When the popup modal appears select 'Yes, print slip'.
=> Observe that the transfer does initiate and the modal closes

Signed-off-by: Lucas Gass 
Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  8 16:53:07 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 08 Jan 2020 15:53:07 +0000
Subject: [Koha-bugs] [Bug 23442] Add a 'refund' process to accounts
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23442

Kyle M Hall  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  8 16:53:10 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 08 Jan 2020 15:53:10 +0000
Subject: [Koha-bugs] [Bug 23442] Add a 'refund' process to accounts
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23442

Kyle M Hall  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #96414|0                           |1
        is obsolete|                            |
  Attachment #96415|0                           |1
        is obsolete|                            |
  Attachment #96416|0                           |1
        is obsolete|                            |
  Attachment #96417|0                           |1
        is obsolete|                            |

--- Comment #20 from Kyle M Hall  ---
Created attachment 97008
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97008&action=edit
Bug 23442: Add account credit types

Signed-off-by: Kyle M Hall 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  8 16:53:43 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 08 Jan 2020 15:53:43 +0000
Subject: [Koha-bugs] [Bug 23442] Add a 'refund' process to accounts
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23442

--- Comment #21 from Kyle M Hall  ---
Created attachment 97009
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97009&action=edit
Bug 23442: Add 'reduce' method to Koha::Account::Line

This enhancement adds a 'reduce' method to Koha::Account::Line which can
be used to reduce a charge/debit by adding a credit to offset against
the amount outstanding.

It may be used to apply a discount whilst retaining the original debit
amounts or to apply a full or partial refund for example when a lost
item is found and returned.

The created credit will be immediately applied against the debit unless
the debit has already been paid, in which case a 'zero' offset will be
added to maintain a link to the debit but the outstanding credit will be
left so it may be applied to other debts.

Test Plan:
1) Run the included tests and verify they pass.
2) Signoff

Signed-off-by: Kyle M Hall 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  8 16:53:46 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 08 Jan 2020 15:53:46 +0000
Subject: [Koha-bugs] [Bug 23442] Add a 'refund' process to accounts
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23442

--- Comment #22 from Kyle M Hall  ---
Created attachment 97010
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97010&action=edit
Bug 23442: Add refund permission

Add a new subpermission called 'refund' to the 'updatecharges'
permission group which will allow/prevent refund actions to be
performed by staff.

Signed-off-by: Kyle M Hall 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  8 16:53:49 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 08 Jan 2020 15:53:49 +0000
Subject: [Koha-bugs] [Bug 23442] Add a 'refund' process to accounts
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23442

--- Comment #23 from Kyle M Hall  ---
Created attachment 97011
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97011&action=edit
Bug 23442: Add refund option to patron account page

This enhancement adds a refined workflow to allow librarians
to refund payments to patrons and record these refunds on the
patrons account.

The use case is that a patron has paid for something before
then performing an action that may require some level of refund
to be actioned.  Perhaps they are returning a lost and paid for
book.

Test plan:
1) Undertake a series of transactions that result in a debit
   accountline being partially or fully paid off.
2) Note that a new 'Issue refund' button appears next to a
   debit (but only if your user has the refund permission or
   is a superlibrarian)
3) Click the 'Issue refund' button and a modal should appear
   pre-populated with the amount - amountoutstanding.
4) You should be able to edit the amount you wish to refund,
   record the refund or cancel.
5) Signoff

Signed-off-by: Kyle M Hall 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  8 16:53:52 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 08 Jan 2020 15:53:52 +0000
Subject: [Koha-bugs] [Bug 23442] Add a 'refund' process to accounts
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23442

--- Comment #24 from Kyle M Hall  ---
Created attachment 97012
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97012&action=edit
Bug 23442: Add html filter to a couple lines in template

Signed-off-by: Kyle M Hall 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  8 17:08:55 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 08 Jan 2020 16:08:55 +0000
Subject: [Koha-bugs] [Bug 23354] Add a 'Pay' screen to allow anonymous
 payments in a POS fashion
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23354

Kyle M Hall  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #95678|0                           |1
        is obsolete|                            |
  Attachment #95679|0                           |1
        is obsolete|                            |
  Attachment #95680|0                           |1
        is obsolete|                            |
  Attachment #95681|0                           |1
        is obsolete|                            |
  Attachment #95682|0                           |1
        is obsolete|                            |
  Attachment #95683|0                           |1
        is obsolete|                            |
  Attachment #95684|0                           |1
        is obsolete|                            |
  Attachment #95685|0                           |1
        is obsolete|                            |
  Attachment #95686|0                           |1
        is obsolete|                            |
  Attachment #95687|0                           |1
        is obsolete|                            |
  Attachment #95688|0                           |1
        is obsolete|                            |
  Attachment #95689|0                           |1
        is obsolete|                            |
  Attachment #95690|0                           |1
        is obsolete|                            |
  Attachment #95691|0                           |1
        is obsolete|                            |
  Attachment #95692|0                           |1
        is obsolete|                            |
  Attachment #95693|0                           |1
        is obsolete|                            |

--- Comment #86 from Kyle M Hall  ---
Created attachment 97013
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97013&action=edit
Bug 23354: Add a Point Of Sale 'pay' screen

This patch adds a new Point Of Sale module to Koha's staff client front
page. The module button leads directly to a 'Pay' page giving the staff
user the ability to record anonymous payments for items that would not
normally require a patron to be registered at the library.

Test plan:
1) Enable `UseCashRegisters` via the system preferences.
2) Ensure your user has the 'manage_cash_registers' permission.
3) Add a cash register for your current branch.
4) Add at least one 'MANUAL_INV' authorized value.
5) Navigate to the new 'POS' pay page via the main menu.
6) Add an item to the 'sale' by clicking 'add' from the right side of
   the screen.
7) Note that said item was added to the table of items this sale on the
   left.
8) At this point you should be able to 'click to edit' the quantity or
   price of the item in the table on the left.
9) Enter an amount greater than the price of the item into the 'amount
   collected from patron' box.
10) Click 'Confirm'
11) Varify that the same change to give modal from the paycollect pages
    appears here.
12) Click 'Confirm'
13) Payment will have been recorded (check the database) and you will be
    back at a fresh 'Pay' page ready for the next transaction.
14) Signoff

Sponsored-by: PTFS Europe
Sponsored-by: Cheshire Libraries Shared Services

Signed-off-by: Kyle M Hall 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  8 17:09:18 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 08 Jan 2020 16:09:18 +0000
Subject: [Koha-bugs] [Bug 23354] Add a 'Pay' screen to allow anonymous
 payments in a POS fashion
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23354

Kyle M Hall  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #97013|0                           |1
        is obsolete|                            |

--- Comment #87 from Kyle M Hall  ---
Created attachment 97014
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97014&action=edit
Bug 23354: Add a Point Of Sale 'pay' screen

This patch adds a new Point Of Sale module to Koha's staff client front
page. The module button leads directly to a 'Pay' page giving the staff
user the ability to record anonymous payments for items that would not
normally require a patron to be registered at the library.

Test plan:
1) Enable `UseCashRegisters` via the system preferences.
2) Ensure your user has the 'manage_cash_registers' permission.
3) Add a cash register for your current branch.
4) Add at least one 'MANUAL_INV' authorized value.
5) Navigate to the new 'POS' pay page via the main menu.
6) Add an item to the 'sale' by clicking 'add' from the right side of
   the screen.
7) Note that said item was added to the table of items this sale on the
   left.
8) At this point you should be able to 'click to edit' the quantity or
   price of the item in the table on the left.
9) Enter an amount greater than the price of the item into the 'amount
   collected from patron' box.
10) Click 'Confirm'
11) Varify that the same change to give modal from the paycollect pages
    appears here.
12) Click 'Confirm'
13) Payment will have been recorded (check the database) and you will be
    back at a fresh 'Pay' page ready for the next transaction.
14) Signoff

Sponsored-by: PTFS Europe
Sponsored-by: Cheshire Libraries Shared Services

Signed-off-by: Kyle M Hall 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  8 17:09:40 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 08 Jan 2020 16:09:40 +0000
Subject: [Koha-bugs] [Bug 23354] Add a 'Pay' screen to allow anonymous
 payments in a POS fashion
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23354

--- Comment #88 from Kyle M Hall  ---
Created attachment 97015
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97015&action=edit
Bug 23354: Add receipting to Pay page

This patch adds receipt printing to the new Point of Sale pay page.

Test plan:
1) Apply patch and run database update
2) Enable automatic receipt printing via the `` system preference.
3) Make a payment for an item via the new POS pay page.
4) Note that a receipt printing dialogue is shown automatically after
   payment.
5) Note that a new notice is available under tools where you can alter
   the content of the receipt.
6) Signoff

Sponsored-by: PTFS Europe
Sponsored-by: Cheshire Libraries Shared Services

Signed-off-by: Kyle M Hall 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  8 17:09:44 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 08 Jan 2020 16:09:44 +0000
Subject: [Koha-bugs] [Bug 23354] Add a 'Pay' screen to allow anonymous
 payments in a POS fashion
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23354

--- Comment #89 from Kyle M Hall  ---
Created attachment 97016
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97016&action=edit
Bug 23354: Add ability to remove items

This patch adds the ability to remove items from a transactions on the
new Point of Sale pay page.

Test plan:
1) Populate a transaction with at least one item.
2) Note the new button to 'Remove item' on the items table.
3) Click the button and confirm the item is removed
4) Signoff

Sponsored-by: PTFS Europe
Sponsored-by: Cheshire Libraries Shared Services

Signed-off-by: Kyle M Hall 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  8 17:09:48 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 08 Jan 2020 16:09:48 +0000
Subject: [Koha-bugs] [Bug 23354] Add a 'Pay' screen to allow anonymous
 payments in a POS fashion
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23354

--- Comment #90 from Kyle M Hall  ---
Created attachment 97017
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97017&action=edit
Bug 23354: (follow-up) Responses to feedback

This patch impliments a number of refinements requested after the first
round of feedback from the sponsors.

1) Fix padding on pay page
2) Switch 'items to add' from right to left on the page
3) Fix editable columns on pay page
4) Add explanitory text to pay page

Sponsored-by: PTFS Europe
Sponsored-by: Cheshire Libraries Shared Services

Signed-off-by: Kyle M Hall 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  8 17:09:51 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 08 Jan 2020 16:09:51 +0000
Subject: [Koha-bugs] [Bug 23354] Add a 'Pay' screen to allow anonymous
 payments in a POS fashion
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23354

--- Comment #91 from Kyle M Hall  ---
Created attachment 97018
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97018&action=edit
Bug 23354: Add permissions

Sponsored-by: PTFS Europe
Sponsored-by: Cheshire Libraries Shared Services

Signed-off-by: Kyle M Hall 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  8 17:09:55 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 08 Jan 2020 16:09:55 +0000
Subject: [Koha-bugs] [Bug 23354] Add a 'Pay' screen to allow anonymous
 payments in a POS fashion
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23354

--- Comment #92 from Kyle M Hall  ---
Created attachment 97019
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97019&action=edit
Bug 23354: Add tests for Koha::Charges::Sales

Sponsored-by: PTFS Europe
Sponsored-by: Cheshire Libraries Shared Services

Signed-off-by: Kyle M Hall 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  8 17:09:59 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 08 Jan 2020 16:09:59 +0000
Subject: [Koha-bugs] [Bug 23354] Add a 'Pay' screen to allow anonymous
 payments in a POS fashion
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23354

--- Comment #93 from Kyle M Hall  ---
Created attachment 97020
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97020&action=edit
Bug 23354: (follow-up) Input type on jEditable

Update the jEditable plugin to a maintained version and use the new
'number' type to enable increment arrows on click and remap onblur event
to submit.

Sponsored-by: PTFS Europe
Sponsored-by: Cheshire Libraries Shared Services

Signed-off-by: Kyle M Hall 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  8 17:10:02 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 08 Jan 2020 16:10:02 +0000
Subject: [Koha-bugs] [Bug 23354] Add a 'Pay' screen to allow anonymous
 payments in a POS fashion
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23354

--- Comment #94 from Kyle M Hall  ---
Created attachment 97021
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97021&action=edit
Bug 23354: (follow-up) Use 'format_price' for totals

Sponsored-by: PTFS Europe
Sponsored-by: Cheshire Libraries Shared Services

Signed-off-by: Kyle M Hall 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  8 17:10:06 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 08 Jan 2020 16:10:06 +0000
Subject: [Koha-bugs] [Bug 23354] Add a 'Pay' screen to allow anonymous
 payments in a POS fashion
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23354

--- Comment #95 from Kyle M Hall  ---
Created attachment 97022
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97022&action=edit
Bug 23354: Add Icon for POS system

Signed-off-by: Kyle M Hall 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  8 17:10:10 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 08 Jan 2020 16:10:10 +0000
Subject: [Koha-bugs] [Bug 23354] Add a 'Pay' screen to allow anonymous
 payments in a POS fashion
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23354

--- Comment #96 from Kyle M Hall  ---
Created attachment 97023
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97023&action=edit
Bug 23354: Update to account for bug 23049

Signed-off-by: Kyle M Hall 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  8 17:10:15 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 08 Jan 2020 16:10:15 +0000
Subject: [Koha-bugs] [Bug 23354] Add a 'Pay' screen to allow anonymous
 payments in a POS fashion
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23354

--- Comment #97 from Kyle M Hall  ---
Created attachment 97024
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97024&action=edit
Bug 23354: (follow-up) Make display of debit types configurable

This patch adds a the ability to define where a debit type will be
available as a option for use.

Signed-off-by: Kyle M Hall 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  8 17:10:21 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 08 Jan 2020 16:10:21 +0000
Subject: [Koha-bugs] [Bug 23354] Add a 'Pay' screen to allow anonymous
 payments in a POS fashion
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23354

--- Comment #98 from Kyle M Hall  ---
Created attachment 97025
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97025&action=edit
Bug 23354: (follow-up) Ensure 'CASH' payment type is present

Signed-off-by: Kyle M Hall 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  8 17:10:26 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 08 Jan 2020 16:10:26 +0000
Subject: [Koha-bugs] [Bug 23354] Add a 'Pay' screen to allow anonymous
 payments in a POS fashion
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23354

--- Comment #99 from Kyle M Hall  ---
Created attachment 97026
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97026&action=edit
Bug 23354: (follow-up) Update for bugs 23049 and 23805

Remove all mentions of accounttype and replace with debit_type_code and
credit_type_code as appropriate.

Signed-off-by: Kyle M Hall 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  8 17:10:30 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 08 Jan 2020 16:10:30 +0000
Subject: [Koha-bugs] [Bug 23354] Add a 'Pay' screen to allow anonymous
 payments in a POS fashion
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23354

--- Comment #100 from Kyle M Hall  ---
Created attachment 97027
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97027&action=edit
Bug 23354: (follow-up) Fix for sending code instead of description

Signed-off-by: Kyle M Hall 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  8 17:10:35 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 08 Jan 2020 16:10:35 +0000
Subject: [Koha-bugs] [Bug 23354] Add a 'Pay' screen to allow anonymous
 payments in a POS fashion
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23354

--- Comment #101 from Kyle M Hall  ---
Created attachment 97028
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97028&action=edit
Bug 23354: Format price on item add

Signed-off-by: Kyle M Hall 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  8 17:10:39 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 08 Jan 2020 16:10:39 +0000
Subject: [Koha-bugs] [Bug 23354] Add a 'Pay' screen to allow anonymous
 payments in a POS fashion
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23354

--- Comment #102 from Kyle M Hall  ---
Created attachment 97029
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97029&action=edit
Bug 23354: Prevent negatives from being entered

Signed-off-by: Kyle M Hall 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  8 17:12:46 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 08 Jan 2020 16:12:46 +0000
Subject: [Koha-bugs] [Bug 23354] Add a 'Pay' screen to allow anonymous
 payments in a POS fashion
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23354

Kyle M Hall  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |kyle at bywatersolutions.com
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  8 17:14:51 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 08 Jan 2020 16:14:51 +0000
Subject: [Koha-bugs] [Bug 24376] New: Wording of Fine Returned is confusing
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24376

            Bug ID: 24376
           Summary: Wording of Fine Returned is confusing
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Fines and fees
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: kelly at bywatersolutions.com
        QA Contact: testopia at bugs.koha-community.org

With 19.05 Koha Fines were given new descriptions.  We moved away from F and FU
fines to Fines Accruing and Fine Returned. However, libraries find that the
Fine Returned confusing when the item has been renewed and / or lost. 

Example:
If an item has been lost, the fine will stop accruing and therefore get the
description of Fine Returned. However the item is not returned but the fine
has, in essence, stop accruing.  

Or if an item has been overdue, then renewed.  The first fine will have stopped
accruing and be given a Fine Returned when really the item has been renewed and
could potentially get more fines.

Recommendations of the wording could be "Fine Final" instead of "Fine Returned"

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  8 17:19:57 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 08 Jan 2020 16:19:57 +0000
Subject: [Koha-bugs] [Bug 20076] Overdues: remove redundant message when
 patrons don't have email addresses
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20076

Sally  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |sally.healey at cheshireshared
                   |                            |services.gov.uk

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  8 17:20:02 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 08 Jan 2020 16:20:02 +0000
Subject: [Koha-bugs] [Bug 24377] New: Record branch in statistics for
 auto-renewal
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24377

            Bug ID: 24377
           Summary: Record branch in statistics for auto-renewal
 Change sponsored?: ---
           Product: Koha
           Version: 19.05
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: Database
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: andrew at bywatersolutions.com
        QA Contact: testopia at bugs.koha-community.org

As of 19.05, statistics.branch is null when recording a renewal performed by
the auto-renew cron. Prior to 19.05, a branch was recorded (though I'm not
clear if that was the branch whose rules were used or the branch from the
issues table). It looks like this was changed by bug 22600.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  8 17:21:00 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 08 Jan 2020 16:21:00 +0000
Subject: [Koha-bugs] [Bug 24292] Upgrade failed,
 from 19.05 to 19.11 on Ubuntu 19.10: Can't load Unaccent.so
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24292

Colin Campbell  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |colin.campbell at ptfs-europe.
                   |                            |com

--- Comment #5 from Colin Campbell  ---
Ubuntu has a newer version of perl than debian Text::Unaccent cant be build on
perl after 5.26 (and earlier on many environments). You can confirm this is the
problem by installing Text::Unaccent::PurePerl and changing the use
Text::Unaccent in Koha::Patron.pm to use that - the errors should then
disappear

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  8 17:30:13 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 08 Jan 2020 16:30:13 +0000
Subject: [Koha-bugs] [Bug 23488] Line wrapping doesn't always respect word
 order in Patron card creator
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23488

Gabriel DeCarufel  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #92411|0                           |1
        is obsolete|                            |

--- Comment #2 from Gabriel DeCarufel  ---
Created attachment 97030
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97030&action=edit
Bug 23488: Line wrapping doesn't always respect word order in Patron card
creator

When wrapping long lines of text, the line is divided by removing each
word from the end of the line and putting it in a new one until the line
is the right width. When the word to be removed appears multiple time
in the line, it is not the last occurrence that is removed.

This patch changes the regular expression used to remove the part of
the text that is wrapped to a new line, making sure it removes it at
the end of the text.

Signed-off-by: Gabriel DeCarufel 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  8 17:33:23 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 08 Jan 2020 16:33:23 +0000
Subject: [Koha-bugs] [Bug 24376] Wording of Fine Returned is confusing
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24376

karen.fellows at citruslibraries.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |karen.fellows at citruslibrari
                   |                            |es.org

--- Comment #1 from karen.fellows at citruslibraries.org ---
This is confusing for our library staff since we are a library that doesn't
charge fines.  We only bill when an item is lost or damaged.  When we migrated
to Koha, our old bills were brought over as migrated fines from our previous
system and they now have an account type of Fine (Returned) however the items
were not returned--they are all long lost.  We would like the wording changed
as Kelly described.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  8 17:54:15 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 08 Jan 2020 16:54:15 +0000
Subject: [Koha-bugs] [Bug 23355] Add 'cashup' process to the accounts system
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23355

Martin Renvoize  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #92953|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  8 17:54:30 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 08 Jan 2020 16:54:30 +0000
Subject: [Koha-bugs] [Bug 23355] Add 'cashup' process to the accounts system
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23355

Martin Renvoize  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #92952|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  8 17:54:43 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 08 Jan 2020 16:54:43 +0000
Subject: [Koha-bugs] [Bug 23355] Add 'cashup' process to the accounts system
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23355

Martin Renvoize  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #92951|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  8 17:54:57 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 08 Jan 2020 16:54:57 +0000
Subject: [Koha-bugs] [Bug 23355] Add 'cashup' process to the accounts system
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23355

Martin Renvoize  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #92950|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  8 17:55:17 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 08 Jan 2020 16:55:17 +0000
Subject: [Koha-bugs] [Bug 23355] Add 'cashup' process to the accounts system
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23355

Martin Renvoize  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #92949|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  8 17:55:30 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 08 Jan 2020 16:55:30 +0000
Subject: [Koha-bugs] [Bug 23355] Add 'cashup' process to the accounts system
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23355

Martin Renvoize  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #92948|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  8 17:55:44 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 08 Jan 2020 16:55:44 +0000
Subject: [Koha-bugs] [Bug 23355] Add 'cashup' process to the accounts system
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23355

Martin Renvoize  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #92947|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  8 17:55:59 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 08 Jan 2020 16:55:59 +0000
Subject: [Koha-bugs] [Bug 23355] Add 'cashup' process to the accounts system
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23355

Martin Renvoize  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #92946|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  8 17:56:12 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 08 Jan 2020 16:56:12 +0000
Subject: [Koha-bugs] [Bug 23355] Add 'cashup' process to the accounts system
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23355

Martin Renvoize  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #92945|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  8 17:56:24 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 08 Jan 2020 16:56:24 +0000
Subject: [Koha-bugs] [Bug 23355] Add 'cashup' process to the accounts system
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23355

Martin Renvoize  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #92944|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  8 17:56:38 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 08 Jan 2020 16:56:38 +0000
Subject: [Koha-bugs] [Bug 23355] Add 'cashup' process to the accounts system
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23355

Martin Renvoize  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #92943|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  8 17:56:51 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 08 Jan 2020 16:56:51 +0000
Subject: [Koha-bugs] [Bug 23355] Add 'cashup' process to the accounts system
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23355

Martin Renvoize  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #92942|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  8 17:57:05 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 08 Jan 2020 16:57:05 +0000
Subject: [Koha-bugs] [Bug 23355] Add 'cashup' process to the accounts system
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23355

Martin Renvoize  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #92941|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  8 17:57:49 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 08 Jan 2020 16:57:49 +0000
Subject: [Koha-bugs] [Bug 23355] Add 'cashup' process to the accounts system
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23355

--- Comment #14 from Martin Renvoize  ---
Created attachment 97031
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97031&action=edit
Bug 23355: Add cash_register_actions table

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  8 17:57:52 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 08 Jan 2020 16:57:52 +0000
Subject: [Koha-bugs] [Bug 23355] Add 'cashup' process to the accounts system
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23355

--- Comment #15 from Martin Renvoize  ---
Created attachment 97032
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97032&action=edit
Bug 23355: [DO NOT PUSH] DBIC Classes

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  8 17:57:55 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 08 Jan 2020 16:57:55 +0000
Subject: [Koha-bugs] [Bug 23355] Add 'cashup' process to the accounts system
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23355

--- Comment #16 from Martin Renvoize  ---
Created attachment 97033
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97033&action=edit
Bug 23355: Add CASHUP actions

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  8 17:57:57 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 08 Jan 2020 16:57:57 +0000
Subject: [Koha-bugs] [Bug 23355] Add 'cashup' process to the accounts system
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23355

--- Comment #17 from Martin Renvoize  ---
Created attachment 97034
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97034&action=edit
Bug 23355: Add accountline deletion test

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  8 17:58:00 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 08 Jan 2020 16:58:00 +0000
Subject: [Koha-bugs] [Bug 23355] Add 'cashup' process to the accounts system
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23355

--- Comment #18 from Martin Renvoize  ---
Created attachment 97035
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97035&action=edit
Bug 23355: Link cash_register_actions to cash_registers by foreign key

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  8 17:58:04 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 08 Jan 2020 16:58:04 +0000
Subject: [Koha-bugs] [Bug 23355] Add 'cashup' process to the accounts system
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23355

--- Comment #19 from Martin Renvoize  ---
Created attachment 97036
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97036&action=edit
Bug 23355: Split tests for Line vs Lines

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  8 17:58:06 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 08 Jan 2020 16:58:06 +0000
Subject: [Koha-bugs] [Bug 23355] Add 'cashup' process to the accounts system
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23355

--- Comment #20 from Martin Renvoize  ---
Created attachment 97037
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97037&action=edit
Bug 23355: Add register details page

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  8 17:58:09 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 08 Jan 2020 16:58:09 +0000
Subject: [Koha-bugs] [Bug 23355] Add 'cashup' process to the accounts system
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23355

--- Comment #21 from Martin Renvoize  ---
Created attachment 97038
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97038&action=edit
Bug 23355: Add cashup permissions

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  8 17:58:12 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 08 Jan 2020 16:58:12 +0000
Subject: [Koha-bugs] [Bug 23355] Add 'cashup' process to the accounts system
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23355

--- Comment #22 from Martin Renvoize  ---
Created attachment 97039
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97039&action=edit
Bug 23355: Add branch details page

This patch adds a new 'branch details' page to the POS system which
displays a summary of the cash register transactions for a branch
since each register was last cashed up. It also allows for cashing
up individual registers or cashing up all registers at a given branch
in one transaction.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  8 17:58:15 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 08 Jan 2020 16:58:15 +0000
Subject: [Koha-bugs] [Bug 23355] Add 'cashup' process to the accounts system
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23355

--- Comment #23 from Martin Renvoize  ---
Created attachment 97040
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97040&action=edit
Bug 23555: Use rowGroup plugin

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  8 17:58:18 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 08 Jan 2020 16:58:18 +0000
Subject: [Koha-bugs] [Bug 23355] Add 'cashup' process to the accounts system
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23355

--- Comment #24 from Martin Renvoize  ---
Created attachment 97041
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97041&action=edit
Bug 23355: Remove superflous use of AuthoriseValues

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  8 18:04:24 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 08 Jan 2020 17:04:24 +0000
Subject: [Koha-bugs] [Bug 24082] Add a 'refund' option to anonymous payments
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24082

--- Comment #1 from Martin Renvoize  ---
Created attachment 97042
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97042&action=edit
Bug 24082: Add a refund option to POS

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  8 18:25:42 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 08 Jan 2020 17:25:42 +0000
Subject: [Koha-bugs] [Bug 24378] New: Change wording on AUTO_RENEWALS notice
 template
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24378

            Bug ID: 24378
           Summary: Change wording on AUTO_RENEWALS notice template
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: trivial
          Priority: P5 - low
         Component: Notices
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: kelly at bywatersolutions.com
        QA Contact: testopia at bugs.koha-community.org

On the template of AUTO-RENEWALS the wording is grammatically incorrect:

Currently this line states:

[% IF checkout.auto_renew_error == 'too_many' %]
You have reach the maximum of checkouts possible.


This should say
[% IF checkout.auto_renew_error == 'too_many' %]
You have reached the maximum of checkouts possible.



Note:  It should be eb installed.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  8 19:11:03 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 08 Jan 2020 18:11:03 +0000
Subject: [Koha-bugs] [Bug 23355] Add 'cashup' process to the accounts system
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23355

Kyle M Hall  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  8 19:11:06 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 08 Jan 2020 18:11:06 +0000
Subject: [Koha-bugs] [Bug 23355] Add 'cashup' process to the accounts system
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23355

Kyle M Hall  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #97031|0                           |1
        is obsolete|                            |
  Attachment #97032|0                           |1
        is obsolete|                            |
  Attachment #97033|0                           |1
        is obsolete|                            |
  Attachment #97034|0                           |1
        is obsolete|                            |
  Attachment #97035|0                           |1
        is obsolete|                            |
  Attachment #97036|0                           |1
        is obsolete|                            |
  Attachment #97037|0                           |1
        is obsolete|                            |
  Attachment #97038|0                           |1
        is obsolete|                            |
  Attachment #97039|0                           |1
        is obsolete|                            |
  Attachment #97040|0                           |1
        is obsolete|                            |
  Attachment #97041|0                           |1
        is obsolete|                            |

--- Comment #25 from Kyle M Hall  ---
Created attachment 97043
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97043&action=edit
Bug 23355: Add cash_register_actions table

Signed-off-by: Kyle M Hall 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  8 19:11:28 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 08 Jan 2020 18:11:28 +0000
Subject: [Koha-bugs] [Bug 23355] Add 'cashup' process to the accounts system
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23355

Kyle M Hall  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #97043|0                           |1
        is obsolete|                            |

--- Comment #26 from Kyle M Hall  ---
Created attachment 97044
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97044&action=edit
Bug 23355: Add cash_register_actions table

Signed-off-by: Kyle M Hall 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  8 19:12:06 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 08 Jan 2020 18:12:06 +0000
Subject: [Koha-bugs] [Bug 23355] Add 'cashup' process to the accounts system
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23355

--- Comment #27 from Kyle M Hall  ---
Created attachment 97045
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97045&action=edit
Bug 23355: [DO NOT PUSH] DBIC Classes

Signed-off-by: Kyle M Hall 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  8 19:12:10 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 08 Jan 2020 18:12:10 +0000
Subject: [Koha-bugs] [Bug 23355] Add 'cashup' process to the accounts system
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23355

--- Comment #28 from Kyle M Hall  ---
Created attachment 97046
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97046&action=edit
Bug 23355: Add CASHUP actions

Signed-off-by: Kyle M Hall 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  8 19:12:13 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 08 Jan 2020 18:12:13 +0000
Subject: [Koha-bugs] [Bug 23355] Add 'cashup' process to the accounts system
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23355

--- Comment #29 from Kyle M Hall  ---
Created attachment 97047
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97047&action=edit
Bug 23355: Add accountline deletion test

Signed-off-by: Kyle M Hall 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  8 19:12:16 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 08 Jan 2020 18:12:16 +0000
Subject: [Koha-bugs] [Bug 23355] Add 'cashup' process to the accounts system
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23355

--- Comment #30 from Kyle M Hall  ---
Created attachment 97048
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97048&action=edit
Bug 23355: Link cash_register_actions to cash_registers by foreign key

Signed-off-by: Kyle M Hall 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  8 19:12:19 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 08 Jan 2020 18:12:19 +0000
Subject: [Koha-bugs] [Bug 23355] Add 'cashup' process to the accounts system
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23355

--- Comment #31 from Kyle M Hall  ---
Created attachment 97049
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97049&action=edit
Bug 23355: Split tests for Line vs Lines

Signed-off-by: Kyle M Hall 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  8 19:12:22 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 08 Jan 2020 18:12:22 +0000
Subject: [Koha-bugs] [Bug 23355] Add 'cashup' process to the accounts system
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23355

--- Comment #32 from Kyle M Hall  ---
Created attachment 97050
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97050&action=edit
Bug 23355: Add register details page

Signed-off-by: Kyle M Hall 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  8 19:12:25 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 08 Jan 2020 18:12:25 +0000
Subject: [Koha-bugs] [Bug 23355] Add 'cashup' process to the accounts system
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23355

--- Comment #33 from Kyle M Hall  ---
Created attachment 97051
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97051&action=edit
Bug 23355: Add cashup permissions

Signed-off-by: Kyle M Hall 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  8 19:12:29 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 08 Jan 2020 18:12:29 +0000
Subject: [Koha-bugs] [Bug 23355] Add 'cashup' process to the accounts system
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23355

--- Comment #34 from Kyle M Hall  ---
Created attachment 97052
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97052&action=edit
Bug 23355: Add branch details page

This patch adds a new 'branch details' page to the POS system which
displays a summary of the cash register transactions for a branch
since each register was last cashed up. It also allows for cashing
up individual registers or cashing up all registers at a given branch
in one transaction.

Signed-off-by: Kyle M Hall 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  8 19:12:32 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 08 Jan 2020 18:12:32 +0000
Subject: [Koha-bugs] [Bug 23355] Add 'cashup' process to the accounts system
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23355

--- Comment #35 from Kyle M Hall  ---
Created attachment 97053
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97053&action=edit
Bug 23555: Use rowGroup plugin

https://bugs.koha-community.org/show_bug.cgi?id=23355

Signed-off-by: Kyle M Hall 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  8 19:12:35 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 08 Jan 2020 18:12:35 +0000
Subject: [Koha-bugs] [Bug 23355] Add 'cashup' process to the accounts system
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23355

--- Comment #36 from Kyle M Hall  ---
Created attachment 97054
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97054&action=edit
Bug 23355: Remove superflous use of AuthoriseValues

Signed-off-by: Kyle M Hall 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  8 20:44:10 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 08 Jan 2020 19:44:10 +0000
Subject: [Koha-bugs] [Bug 24376] Wording of Fine Returned is confusing
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24376

Katrin Fischer  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de

--- Comment #2 from Katrin Fischer  ---
When changing please keep capitalization rules in mind.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  8 20:48:59 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 08 Jan 2020 19:48:59 +0000
Subject: [Koha-bugs] [Bug 7923] Performance omnibus
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7923
Bug 7923 depends on bug 15105, which changed state.

Bug 15105 Summary: Batch Item Modification Performance Improvement
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15105

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |WONTFIX

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  8 20:48:59 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 08 Jan 2020 19:48:59 +0000
Subject: [Koha-bugs] [Bug 15105] Batch Item Modification Performance
 Improvement
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15105

Katrin Fischer  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |WONTFIX
                 CC|                            |katrin.fischer at bsz-bw.de
             Status|NEW                         |RESOLVED

--- Comment #2 from Katrin Fischer  ---
There has no code been submitted here and the codebase and caching methods have
changed by a lot since this was posted. Closing WONTFIX.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  8 20:50:12 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 08 Jan 2020 19:50:12 +0000
Subject: [Koha-bugs] [Bug 24379] New: Borrowers Login Attempts is NULL
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24379

            Bug ID: 24379
           Summary: Borrowers Login Attempts is NULL
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Database
          Assignee: nick at bywatersolutions.com
          Reporter: kelly at bywatersolutions.com
        QA Contact: testopia at bugs.koha-community.org

When a patron registers for a new account, their loginattempt value is NULL and
not zero.  This is a change since 18.11.

Since this value is NULL, a patron cannot reset their password due to this NULL
value.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  8 20:53:55 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 08 Jan 2020 19:53:55 +0000
Subject: [Koha-bugs] [Bug 15145] Fix hover state on bugzilla theme header so
 it doesn't jump on hover
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15145

Katrin Fischer  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de
          Component|Websites, Mailing Lists,    |bugs.koha-community.org
                   |etc                         |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  8 20:55:47 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 08 Jan 2020 19:55:47 +0000
Subject: [Koha-bugs] [Bug 15145] Fix hover state on bugzilla theme header so
 it doesn't jump on hover
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15145

Katrin Fischer  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #1 from Katrin Fischer  ---
Might be misunderstanding, but appears to be fixed.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  8 21:20:59 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 08 Jan 2020 20:20:59 +0000
Subject: [Koha-bugs] [Bug 24292] Upgrade failed,
 from 19.05 to 19.11 on Ubuntu 19.10: Can't load Unaccent.so
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24292

Katrin Fischer  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |DUPLICATE
             Status|NEW                         |RESOLVED

--- Comment #6 from Katrin Fischer  ---
(In reply to Marcel de Rooy from comment #4)
> (In reply to Katrin Fischer from comment #3)
> > Could the last comment on bug 14759 be related to this?
> > Also linking them with see also.
> 
> Yes, seems to be the same thing.

Marking as duplicate as the ohter has a patch to get rid of the problematic
library.

*** This bug has been marked as a duplicate of bug 14759 ***

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  8 21:20:59 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 08 Jan 2020 20:20:59 +0000
Subject: [Koha-bugs] [Bug 14759] Replacement for Text::Unaccent
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14759

Katrin Fischer  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mjnkml at gmail.com

--- Comment #38 from Katrin Fischer  ---
*** Bug 24292 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  8 21:27:11 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 08 Jan 2020 20:27:11 +0000
Subject: [Koha-bugs] [Bug 22539] Fines charged on back-dated checkin when
 item has been renewed
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22539

Danielle Elder  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |danielle at bywatersolutions.c
                   |                            |om

--- Comment #24 from Danielle Elder  ---
This is still affecting libraries, especially after holiday breaks.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  8 21:27:25 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 08 Jan 2020 20:27:25 +0000
Subject: [Koha-bugs] [Bug 24380] New: Backdated returns do not update fines
 unless CalculateFinesOnReturn is enabled
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24380

            Bug ID: 24380
           Summary: Backdated returns do not update fines unless
                    CalculateFinesOnReturn is enabled
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: Architecture, internals, and plumbing
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: kyle at bywatersolutions.com
        QA Contact: testopia at bugs.koha-community.org

In Koha 18.11 backdating a return triggered a recalculation of the fine. This
was removed in bug 14591, and I believe it was in error. The bug report itself
has no justification for the change in behavior.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  8 21:28:46 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 08 Jan 2020 20:28:46 +0000
Subject: [Koha-bugs] [Bug 24380] Backdated returns do not update fines
 unless CalculateFinesOnReturn is enabled
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24380

Kyle M Hall  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  8 21:28:48 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 08 Jan 2020 20:28:48 +0000
Subject: [Koha-bugs] [Bug 24380] Backdated returns do not update fines
 unless CalculateFinesOnReturn is enabled
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24380

--- Comment #1 from Kyle M Hall  ---
Created attachment 97055
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97055&action=edit
Bug 24380 - Backdated returns do not update fines unless CalculateFinesOnReturn
is enabled

In Koha 18.11 backdating a return triggered a recalculation of the fine. This
was removed in bug 14591, and I believe it was in error. The bug report itself
has no justification for the change in behavior.

Test Plan:
1) Disable CalculateFinesOnReturn
2) Backdate an overdue with fines, note the fine does not change
3) Apply this patch
4) Repeat step 2
5) The fine should be updated!

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  8 21:30:16 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 08 Jan 2020 20:30:16 +0000
Subject: [Koha-bugs] [Bug 24380] Backdated returns do not update fines
 unless CalculateFinesOnReturn is enabled
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24380

Kyle M Hall  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |kyle at bywatersolutions.com
                   |ity.org                     |

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  8 21:47:19 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 08 Jan 2020 20:47:19 +0000
Subject: [Koha-bugs] [Bug 15205] Factor 'SyndeticsEnabled' out of Auth.pm
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15205

Katrin Fischer  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de

--- Comment #1 from Katrin Fischer  ---
Still valid.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  8 21:55:09 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 08 Jan 2020 20:55:09 +0000
Subject: [Koha-bugs] [Bug 15234] Administrative interface timeout
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15234

Katrin Fischer  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |WORKSFORME
             Status|NEW                         |RESOLVED
                 CC|                            |katrin.fischer at bsz-bw.de

--- Comment #2 from Katrin Fischer  ---
There has been no other reports/further information provided for a few years
now - closing WORKSFORME

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  8 22:03:51 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 08 Jan 2020 21:03:51 +0000
Subject: [Koha-bugs] [Bug 15248] Make it possible to configure duplicate
 check on bibliographic records
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15248

Katrin Fischer  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de
            Summary|Improve FindDuplicate       |Make it possible to
                   |                            |configure duplicate check
                   |                            |on bibliographic records

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  8 22:04:48 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 08 Jan 2020 21:04:48 +0000
Subject: [Koha-bugs] [Bug 23789] fr-CA translation of AUTO_RENEWALS notice
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23789

--- Comment #4 from Guillaume Paquet  ---
Created attachment 97056
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97056&action=edit
Rewrote the fr-CA translation of the AUTO_RENEWALS notice

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  8 22:05:43 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 08 Jan 2020 21:05:43 +0000
Subject: [Koha-bugs] [Bug 15249] barcode duplicate warning missing during
 adding multiple copy
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15249

Katrin Fischer  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de

--- Comment #1 from Katrin Fischer  ---
This might be seen as a feature, especially for libraries printing their
barcode labels from Koha.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  8 22:07:46 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 08 Jan 2020 21:07:46 +0000
Subject: [Koha-bugs] [Bug 23789] fr-CA translation of AUTO_RENEWALS notice
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23789

Guillaume Paquet  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Patch doesn't apply         |Needs Signoff
                 CC|                            |guillaume.paquet at inLibro.co
                   |                            |m

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  8 22:10:04 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 08 Jan 2020 21:10:04 +0000
Subject: [Koha-bugs] [Bug 18092] Serial Enumeration (enumchron) truncated to
 2 characters in by label creator
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18092

Courtenay Johnson  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |courtenay.johnson at gmail.com

--- Comment #3 from Courtenay Johnson  ---
Created attachment 97057
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97057&action=edit
screenshot of the layout page.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  8 22:12:10 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 08 Jan 2020 21:12:10 +0000
Subject: [Koha-bugs] [Bug 15259] Formatting spine labels
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15259

Katrin Fischer  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=15260

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  8 22:12:10 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 08 Jan 2020 21:12:10 +0000
Subject: [Koha-bugs] [Bug 15260] Option for extended loan with useDaysMode
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15260

Katrin Fischer  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=15259

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  8 22:12:31 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 08 Jan 2020 21:12:31 +0000
Subject: [Koha-bugs] [Bug 15260] Option for extended loan with useDaysMode
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15260

Katrin Fischer  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de
           See Also|https://bugs.koha-community |
                   |.org/bugzilla3/show_bug.cgi |
                   |?id=15259                   |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  8 22:12:31 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 08 Jan 2020 21:12:31 +0000
Subject: [Koha-bugs] [Bug 15259] Formatting spine labels
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15259

Katrin Fischer  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|https://bugs.koha-community |
                   |.org/bugzilla3/show_bug.cgi |
                   |?id=15260                   |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  8 22:13:24 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 08 Jan 2020 21:13:24 +0000
Subject: [Koha-bugs] [Bug 12316] can't put text on barcode label
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12316

Katrin Fischer  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=15259

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  8 22:13:24 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 08 Jan 2020 21:13:24 +0000
Subject: [Koha-bugs] [Bug 15259] Formatting spine labels
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15259

Katrin Fischer  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=12316

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  8 22:14:04 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 08 Jan 2020 21:14:04 +0000
Subject: [Koha-bugs] [Bug 23039] Hold found modal on checkin screen (
 circulation.pl ) obscures Check in message info
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23039

Lucas Gass  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |lucas at bywatersolutions.com
             Status|Pushed to master            |Pushed to stable

--- Comment #22 from Lucas Gass  ---
missing dependencies for 19.05.x, no backport

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  8 22:15:03 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 08 Jan 2020 21:15:03 +0000
Subject: [Koha-bugs] [Bug 18092] Serial Enumeration (enumchron) truncated to
 2 characters in by label creator
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18092

--- Comment #4 from Courtenay Johnson  ---
I found that many fields, all that I tried except for the callnumber are
truncated to 2 characters in version 18.11 and I export the PDF. Therefore I
consider spine label printing to be broken for my purpose of printing 3 lines
in total on the label, with two of those lines split, (which does work).
I have attacwehed a screenshot of my layour. This is a test case where I picked
many fileds to print and all but one are truncated.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  8 22:24:23 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 08 Jan 2020 21:24:23 +0000
Subject: [Koha-bugs] [Bug 15265] Add Instagram and Pinterest to social media
 links
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15265

Katrin Fischer  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de

--- Comment #5 from Katrin Fischer  ---
There is a setting now to control exactly which social networks will display.
Pinterest and Instagram sill missing.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  8 22:37:09 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 08 Jan 2020 21:37:09 +0000
Subject: [Koha-bugs] [Bug 24381] New: ACCOUNT_DEBIT slip not printing
 information about paid fines/fees
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24381

            Bug ID: 24381
           Summary: ACCOUNT_DEBIT slip not printing information about paid
                    fines/fees
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: major
          Priority: P5 - low
         Component: Fines and fees
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: katrin.fischer at bsz-bw.de
        QA Contact: testopia at bugs.koha-community.org

While the templates suggests it should print the fines/fees paid/changed by the
payment, this doesn't work for me on current master.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  8 22:39:35 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 08 Jan 2020 21:39:35 +0000
Subject: [Koha-bugs] [Bug 24381] ACCOUNT_DEBIT slip not printing information
 about paid fines/fees
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24381

--- Comment #1 from Katrin Fischer  ---
Instead it shows the payment line - I think some variables are not quite right
there. It's different in 19.05 as Caroline verified on IRC.

Fee receipt - list of fines paid (print is on payment line)
Invoice - list of payments made (print is on fine/fee)

It appears turned upside down now.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  8 22:41:39 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 08 Jan 2020 21:41:39 +0000
Subject: [Koha-bugs] [Bug 24379] Borrowers Login Attempts is NULL
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24379

Nick Clemens  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  8 22:41:42 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 08 Jan 2020 21:41:42 +0000
Subject: [Koha-bugs] [Bug 24379] Borrowers Login Attempts is NULL
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24379

--- Comment #1 from Nick Clemens  ---
Created attachment 97058
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97058&action=edit
Bug 24379: Make login_attempts not nullable

While the column defaults to 0 in Koha::Object->store we set to NULL if
NULLABLE

When trying to reset a patrons password we check that the account is not
administratively locked:
login_attempts != -1

This query does not return rows where login_attempts IS NULL. It will return
accounts where login_attempts = 0

Let's default to 0 like we intend

To test:
1 - Create a new patron
2 - Note their login_attempts is NULL
    SELECT login_attempts FROM borrowers ORDER BY borrowernumber DESC LIMIT 1
3 - Enable  OpacResetPassword
4 - Attempt to reset password before logging in, you cannot
5 - Apply patch, updatedatabase, restart_all, update schema
6 - Create another patron
7 - Their login attempts should be 0
8 - Attempt to reset password, it works!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  8 22:42:12 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 08 Jan 2020 21:42:12 +0000
Subject: [Koha-bugs] [Bug 24379] Borrowers Login Attempts is NULL
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24379

--- Comment #2 from Nick Clemens  ---
Tests don't pass, something is missing

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  8 22:48:07 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 08 Jan 2020 21:48:07 +0000
Subject: [Koha-bugs] [Bug 15273] Fines Payment receipt should include all
 account lines selected for this pay
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15273

Katrin Fischer  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #15 from Katrin Fischer  ---
I think this is supposed to work with ACCOUNT_DEBIT and ACCOUNT_CREDIT now, but
I have some trouble testing, see bug 24381

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  8 22:49:36 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 08 Jan 2020 21:49:36 +0000
Subject: [Koha-bugs] [Bug 24382] New: Wrong information showing on detail
 pages for fines/fees and payments
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24382

            Bug ID: 24382
           Summary: Wrong information showing on detail pages for
                    fines/fees and payments
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: Fines and fees
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: katrin.fischer at bsz-bw.de
        QA Contact: testopia at bugs.koha-community.org

At the moment, the _first_ table in a payment details page reads:

Details of payment
Date    Description of charges  Barcode         Due date        Return date    
Note    Amount  Outstanding

This makes no sense - these are the columns for a fine or fee, but they don't
apply well to a payment.

When you compare to the table shown for a fine/fee, I think the table should
actually display with these lines:

Date created    Date updated    Amount  Amount outstanding      Type    Note   
Transacting librarian   Date/time of change     Amount of change        Type of
change

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  8 22:52:14 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 08 Jan 2020 21:52:14 +0000
Subject: [Koha-bugs] [Bug 23488] Line wrapping doesn't always respect word
 order in Patron card creator
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23488

william.frazilien at inlibro.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #97030|0                           |1
        is obsolete|                            |

--- Comment #3 from william.frazilien at inlibro.com ---
Created attachment 97059
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97059&action=edit
Bug 23488: Line wrapping doesn't always respect word order in Patron card
creator

When wrapping long lines of text, the line is divided by removing each
word from the end of the line and putting it in a new one until the line
is the right width. When the word to be removed appears multiple time
in the line, it is not the last occurrence that is removed.

This patch changes the regular expression used to remove the part of
the text that is wrapped to a new line, making sure it removes it at
the end of the text.

Signed-off-by: Gabriel DeCarufel 
Signed-off-by: William Frazilien 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  8 22:52:23 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 08 Jan 2020 21:52:23 +0000
Subject: [Koha-bugs] [Bug 24381] ACCOUNT_DEBIT slip not printing information
 about paid fines/fees
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24381

--- Comment #2 from Katrin Fischer  ---
I think what we should have in the table for each:

ACCOUNT_CREDIT
Fee receipt - list of fines paid (print is on payment line)

ACCOUNT_DEBIT
Invoice - list of payments made (print is on fine/fee)

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  8 22:53:47 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 08 Jan 2020 21:53:47 +0000
Subject: [Koha-bugs] [Bug 24381] ACCOUNT_CREDIT slip not printing
 information about paid fines/fees
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24381

Katrin Fischer  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|ACCOUNT_DEBIT slip not      |ACCOUNT_CREDIT slip not
                   |printing information about  |printing information about
                   |paid fines/fees             |paid fines/fees

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  8 22:56:45 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 08 Jan 2020 21:56:45 +0000
Subject: [Koha-bugs] [Bug 15276] Add documentation for Template Toolkit
 syntax for slips and notices
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15276

Katrin Fischer  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
          Component|Architecture, internals,    |Documentation
                   |and plumbing                |
                 CC|                            |katrin.fischer at bsz-bw.de
           Keywords|                            |Manual

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  8 23:16:05 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 08 Jan 2020 22:16:05 +0000
Subject: [Koha-bugs] [Bug 15331] Sort order breaks at offset=1000 (both OPAC
 and Intranet)
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15331

Katrin Fischer  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |DUPLICATE
                 CC|                            |katrin.fischer at bsz-bw.de
             Status|NEW                         |RESOLVED

--- Comment #5 from Katrin Fischer  ---
Reading through bug 7041 it looks like there is a configuration setting to
change the max records to sort - closing as a duplicate.

*** This bug has been marked as a duplicate of bug 7041 ***

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  8 23:16:05 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 08 Jan 2020 22:16:05 +0000
Subject: [Koha-bugs] [Bug 7041] Sort >1000 search results with sortmax
 parameter in zebra config file
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7041

Katrin Fischer  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |barton at bywatersolutions.com

--- Comment #7 from Katrin Fischer  ---
*** Bug 15331 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  8 23:17:00 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 08 Jan 2020 22:17:00 +0000
Subject: [Koha-bugs] [Bug 15342] Performance 3.22 - Omnibus
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15342

--- Comment #3 from Katrin Fischer  ---
Should we keep this open and/or update the bug title?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  8 23:21:48 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 08 Jan 2020 22:21:48 +0000
Subject: [Koha-bugs] [Bug 15371] Staff vs. OPAC advanced search options are
 different and have different sorting
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15371

Katrin Fischer  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de

--- Comment #1 from Katrin Fischer  ---
I also believe this to be by design:

location 
language
= only work when codes are entered, so this is more an expert feature.

acquisition-date 
= also requires a special format YYYY-MM-DD

Changing some others and adding them to the OPAC might be debatable, but I see
a pointin offering more options to staff users than to OPAC users.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  8 23:23:26 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 08 Jan 2020 22:23:26 +0000
Subject: [Koha-bugs] [Bug 15384] Items search fields: Change pull downs to
 input fields
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15384

Katrin Fischer  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |DUPLICATE

--- Comment #1 from Katrin Fischer  ---


*** This bug has been marked as a duplicate of bug 20689 ***

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  8 23:23:26 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 08 Jan 2020 22:23:26 +0000
Subject: [Koha-bugs] [Bug 20689] Make it possible to add capital letter
 subfields to item search fields
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20689

--- Comment #44 from Katrin Fischer  ---
*** Bug 15384 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  8 23:25:06 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 08 Jan 2020 22:25:06 +0000
Subject: [Koha-bugs] [Bug 15389] List news items by author
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15389

Katrin Fischer  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de
            Summary|News, list by author        |List news items by author

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  8 23:33:54 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 08 Jan 2020 22:33:54 +0000
Subject: [Koha-bugs] [Bug 15439] Current Location incorrect when item in
 transit
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15439

Katrin Fischer  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |DUPLICATE
                 CC|                            |katrin.fischer at bsz-bw.de

--- Comment #2 from Katrin Fischer  ---


*** This bug has been marked as a duplicate of bug 23129 ***

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  8 23:33:54 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 08 Jan 2020 22:33:54 +0000
Subject: [Koha-bugs] [Bug 23129] Items holdingbranch should be set to the
 originating library when generating a transfer
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23129

Katrin Fischer  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |cbrannon at cdalibrary.org

--- Comment #16 from Katrin Fischer  ---
*** Bug 15439 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  8 23:38:53 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 08 Jan 2020 22:38:53 +0000
Subject: [Koha-bugs] [Bug 15461] Add staff equivalent for
 OpacLocationOnDetail
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15461

Katrin Fischer  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Add staff equivalent to     |Add staff equivalent for
                   |OpacLocationBranchToDisplay |OpacLocationOnDetail
                   |Shelving                    |

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  8 23:40:12 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 08 Jan 2020 22:40:12 +0000
Subject: [Koha-bugs] [Bug 15474] Enable to update LDAP entries from Koha
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15474

Katrin Fischer  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de
            Summary|LDAP Integration            |Enable to update LDAP
                   |                            |entries from Koha

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  8 23:45:57 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 08 Jan 2020 22:45:57 +0000
Subject: [Koha-bugs] [Bug 14513] keep track of patron last activity
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14513

Katrin Fischer  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de
         Resolution|---                         |DUPLICATE
             Status|NEW                         |RESOLVED

--- Comment #2 from Katrin Fischer  ---
Choosing newer bug report as it has more comments/CC.

*** This bug has been marked as a duplicate of bug 15504 ***

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  8 23:45:57 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 08 Jan 2020 22:45:57 +0000
Subject: [Koha-bugs] [Bug 15504] Track Patron's Last Activity
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15504

--- Comment #8 from Katrin Fischer  ---
*** Bug 14513 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  8 23:46:56 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 08 Jan 2020 22:46:56 +0000
Subject: [Koha-bugs] [Bug 24255] Add totals methods Koha::Account::Lines
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24255

Michal Denar  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |black23 at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  8 23:47:47 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 08 Jan 2020 22:47:47 +0000
Subject: [Koha-bugs] [Bug 24081] Add a 'discount' process to accounts
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24081

Michal Denar  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |black23 at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  8 23:49:19 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 08 Jan 2020 22:49:19 +0000
Subject: [Koha-bugs] [Bug 15521] Make circulation rules backend more granular
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15521

Katrin Fischer  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de

--- Comment #6 from Katrin Fischer  ---
I wonder how this relates to bug 15522?

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  8 23:50:13 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 08 Jan 2020 22:50:13 +0000
Subject: [Koha-bugs] [Bug 15521] Make circulation rules backend more granular
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15521

--- Comment #7 from Katrin Fischer  ---
(In reply to Katrin Fischer from comment #6)
> I wonder how this relates to bug 15522?

Looking at the graph helps...

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  8 23:58:12 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 08 Jan 2020 22:58:12 +0000
Subject: [Koha-bugs] [Bug 15588] C4::Fonts,
 introduce a package to work with enabled fonts.
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15588

Katrin Fischer  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de

--- Comment #1 from Katrin Fischer  ---
Can this be closed? Missing assignee and desciption...

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  8 23:58:15 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 08 Jan 2020 22:58:15 +0000
Subject: [Koha-bugs] [Bug 14527] UNIMARC: zebra error 114 when searching for
 items added before or after a specific date / 995$5 is not indexed
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14527

--- Comment #33 from David Cook  ---
(In reply to George Veranis from comment #32)
> it is still valid at version 19.05 for unimarc. 
> One way to solve it is to add zebra index for 995$5 or to use the script for
> the maintenance. It would more easy for libraries to added to zebra index
> configuration in my opinion

This is something I've been thinking about more recently:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12366
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15198

If you look at https://software.indexdata.com/zebra/doc/querymodel-zebra.html,
there is a "Zebra Search Attribute Extension" of value 14, which "Specifies
whether un-indexed fields should be ignored. A zero value (default) throws a
diagnostic when an un-indexed field is specified. A non-zero value makes it
return 0 hits."

I wonder sometimes if we should just add that to all Zebra searches.

It's a shame they didn't make that configurable at the server level rather than
the query level. (I suppose one option would be to request that feature from
Indexdata, but that would only help people running newer versions of Zebra.)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan  8 23:59:05 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 08 Jan 2020 22:59:05 +0000
Subject: [Koha-bugs] [Bug 15625] Add CLI tool to enable/disable public z39
 service, for a Koha instance
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15625

Katrin Fischer  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
          Component|Z39.50 / SRU / OpenSearch   |Command-line Utilities
                   |Servers                     |
                 CC|                            |katrin.fischer at bsz-bw.de,
                   |                            |robin at catalyst.net.nz

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan  9 00:00:41 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 08 Jan 2020 23:00:41 +0000
Subject: [Koha-bugs] [Bug 15646] koha qa test tools / Test compliance with
 perlcriticrc
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15646

Katrin Fischer  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de
            Summary|koha qa test tools          |koha qa test tools / Test
                   |                            |compliance with
                   |                            |perlcriticrc

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan  9 00:02:12 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 08 Jan 2020 23:02:12 +0000
Subject: [Koha-bugs] [Bug 15648] creator_batches table uses item_number
 instead of itemnumber
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15648

Katrin Fischer  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=11164

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan  9 00:02:12 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 08 Jan 2020 23:02:12 +0000
Subject: [Koha-bugs] [Bug 11164] creator_batches table uses borrower_number
 not borrowernumber?
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11164

Katrin Fischer  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=15648

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan  9 00:07:18 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 08 Jan 2020 23:07:18 +0000
Subject: [Koha-bugs] [Bug 15659] See total of child accounts
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15659

Katrin Fischer  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|---                         |DUPLICATE

--- Comment #2 from Katrin Fischer  ---


*** This bug has been marked as a duplicate of bug 16126 ***

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan  9 00:07:18 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 08 Jan 2020 23:07:18 +0000
Subject: [Koha-bugs] [Bug 16126] Display base-level amounts on the
 acquisition module home page
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16126

Katrin Fischer  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |nengard at gmail.com

--- Comment #24 from Katrin Fischer  ---
*** Bug 15659 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan  9 00:08:49 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 08 Jan 2020 23:08:49 +0000
Subject: [Koha-bugs] [Bug 23129] Items holdingbranch should be set to the
 originating library when generating a transfer
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23129

--- Comment #17 from Martha Fuerst  ---
Any thoughts on backporting to 19.05?

-Marti
Huntsville-Madison County Public Library

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan  9 00:11:33 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 08 Jan 2020 23:11:33 +0000
Subject: [Koha-bugs] [Bug 15678] Make pickup branch editable on holds tab on
 circulation/patron detail screens
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15678

Katrin Fischer  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
                 CC|                            |katrin.fischer at bsz-bw.de
         Resolution|---                         |WORKSFORME

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan  9 00:13:44 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 08 Jan 2020 23:13:44 +0000
Subject: [Koha-bugs] [Bug 24371] OPAC 'Showing only available items/Show all
 items' is double encoded
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24371

ByWater Sandboxes  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #96953|0                           |1
        is obsolete|                            |

--- Comment #2 from ByWater Sandboxes  ---
Created attachment 97060
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97060&action=edit
Bug 24371: Change URI filter to $raw

Signed-off-by: Rhonda Kuiper 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan  9 00:14:32 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 08 Jan 2020 23:14:32 +0000
Subject: [Koha-bugs] [Bug 24371] OPAC 'Showing only available items/Show all
 items' is double encoded
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24371

rkuiper at roundrocktexas.gov changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off
                 CC|                            |rkuiper at roundrocktexas.gov

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan  9 00:15:10 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 08 Jan 2020 23:15:10 +0000
Subject: [Koha-bugs] [Bug 15686] Rename "item level holds" circ rule column
 to "OPAC item level holds"
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15686

Katrin Fischer  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |Academy

--- Comment #3 from Katrin Fischer  ---
(In reply to delaye from comment #2)
> In the Circulation Rule, "Item level holds" works only in 'All location'..In
> the OPAC don't works in th erule of a location.For me it's logic but for the
> librian, this column in the table is disturbing.
> I prefer before with the systeme preference
> 
> why this change?...

I don't believe this is true (anymore). But it will use the strictest rule if
you have multiple items with different itemtypes on one record, so if you have
one item with an itemtype that forces item level, it will do that. 

I think renaming is a good idea still.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan  9 00:17:30 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 08 Jan 2020 23:17:30 +0000
Subject: [Koha-bugs] [Bug 23129] Items holdingbranch should be set to the
 originating library when generating a transfer
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23129

--- Comment #18 from Christopher Brannon  ---
(In reply to Martha Fuerst from comment #17)
> Any thoughts on backporting to 19.05?
> 
> -Marti
> Huntsville-Madison County Public Library

+1

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan  9 00:19:18 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 08 Jan 2020 23:19:18 +0000
Subject: [Koha-bugs] [Bug 15724] Add possibility to export records in MARC
 format in z39.50 results
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15724

Katrin Fischer  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
            Summary|Add possibility to export   |Add possibility to export
                   |notice in marc format in    |records in MARC format in
                   |z39.50 results              |z39.50 results
             Status|NEW                         |RESOLVED

--- Comment #2 from Katrin Fischer  ---
(In reply to Katrin Fischer from comment #1)
> Hi Marjorie - have you tried the new cataloguing editor? 
> You can do a Z39.50 search, click import and then export it (save to catalog
> pull down - save to xml/iso) without saving it to your catalog.

I believe this fixes the issue, pleas reopen if I am mistaken.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan  9 00:19:40 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 08 Jan 2020 23:19:40 +0000
Subject: [Koha-bugs] [Bug 23731] Display LC call number in OPAC and staff
 detail pages
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23731

Lucas Gass  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to master            |Pushed to stable

--- Comment #10 from Lucas Gass  ---
backported to 19.05.x for 19.05.07

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan  9 00:19:58 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 08 Jan 2020 23:19:58 +0000
Subject: [Koha-bugs] [Bug 23731] Display LC call number in OPAC and staff
 detail pages
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23731

Lucas Gass  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to stable            |Pushed to oldstable

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan  9 00:22:23 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 08 Jan 2020 23:22:23 +0000
Subject: [Koha-bugs] [Bug 15740] Add Ability to Group Item Types in Staff
 Advanced Search
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15740

Katrin Fischer  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de

--- Comment #1 from Katrin Fischer  ---
It would be nice if this could be configured independently (staff and OPAC)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan  9 00:26:38 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 08 Jan 2020 23:26:38 +0000
Subject: [Koha-bugs] [Bug 15767] Add ability to select order of patron cards
 printed
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15767

Katrin Fischer  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de
            Summary|Add ordering capability to  |Add ability to select order
                   |batch                       |of patron cards printed
            Version|3.22                        |master

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan  9 00:28:43 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 08 Jan 2020 23:28:43 +0000
Subject: [Koha-bugs] [Bug 15780] Include inventory number in patron account
 summary print
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15780

Katrin Fischer  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=11340

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan  9 00:28:43 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 08 Jan 2020 23:28:43 +0000
Subject: [Koha-bugs] [Bug 11340] Make the 'print summary' a custom
 slip/notice
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11340

Katrin Fischer  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=15780

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan  9 00:37:45 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 08 Jan 2020 23:37:45 +0000
Subject: [Koha-bugs] [Bug 15857] Add test mode to process_message_queue.pl
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15857

Katrin Fischer  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |DUPLICATE
                 CC|                            |katrin.fischer at bsz-bw.de
             Status|In Discussion               |RESOLVED

--- Comment #8 from Katrin Fischer  ---
I believe that bug 8000 added the test mode intended here.

*** This bug has been marked as a duplicate of bug 8000 ***

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan  9 00:37:45 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 08 Jan 2020 23:37:45 +0000
Subject: [Koha-bugs] [Bug 8000] Test mode for notices
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8000

--- Comment #178 from Katrin Fischer  ---
*** Bug 15857 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan  9 00:40:04 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 08 Jan 2020 23:40:04 +0000
Subject: [Koha-bugs] [Bug 15862] Cataloging editor should gracefully handle
 unknown biblionumbers
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15862

Katrin Fischer  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #1 from Katrin Fischer  ---
Just tested with:

cgi-bin/koha/cataloguing/addbiblio.pl?biblionumber=10000000

Received a nice error:


The record you are trying to edit doesn't exist.
Add a new record or do a catalog search.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan  9 00:42:28 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 08 Jan 2020 23:42:28 +0000
Subject: [Koha-bugs] [Bug 15873] Restrict patron to hold those items which
 already checked-out by them.
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15873

Katrin Fischer  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|---                         |DUPLICATE

--- Comment #5 from Katrin Fischer  ---


*** This bug has been marked as a duplicate of bug 13374 ***

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan  9 00:42:28 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 08 Jan 2020 23:42:28 +0000
Subject: [Koha-bugs] [Bug 13374] AllowHoldsOnPatronsPossessions not working
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13374

--- Comment #11 from Katrin Fischer  ---
*** Bug 15873 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan  9 00:44:53 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 08 Jan 2020 23:44:53 +0000
Subject: [Koha-bugs] [Bug 15892] branchtransfer from branch is set to the
 transferred Item's holding branch,
 not the current loggedinbranch from where the transfer originates
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15892

Katrin Fischer  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |DUPLICATE
             Status|NEW                         |RESOLVED
                 CC|                            |katrin.fischer at bsz-bw.de

--- Comment #1 from Katrin Fischer  ---


*** This bug has been marked as a duplicate of bug 23129 ***

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan  9 00:44:53 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 08 Jan 2020 23:44:53 +0000
Subject: [Koha-bugs] [Bug 23129] Items holdingbranch should be set to the
 originating library when generating a transfer
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23129

Katrin Fischer  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |olli-antti.kivilahti at jns.fi

--- Comment #19 from Katrin Fischer  ---
*** Bug 15892 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan  9 00:48:41 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 08 Jan 2020 23:48:41 +0000
Subject: [Koha-bugs] [Bug 15933] Add cataloguing plugin to search for
 existing vendors in other records
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15933

Katrin Fischer  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Regarding publishercode     |Add cataloguing plugin to
                   |                            |search for existing vendors
                   |                            |in other records

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan  9 00:50:58 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 08 Jan 2020 23:50:58 +0000
Subject: [Koha-bugs] [Bug 15949] Making certain alerts stand out
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15949

Katrin Fischer  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |Academy
                 CC|                            |katrin.fischer at bsz-bw.de

--- Comment #2 from Katrin Fischer  ---
(In reply to Owen Leonard from comment #1)
> I think perhaps a better solution is to make sure that messages like this
> get unique ID atributes so that you can define custom CSS for particular
> messages which are of higher priority to your library. For example:
> 
> [% IF ( errmsgloo.badbarcode ) %]
>     
No item with
> barcode: [% errmsgloo.msg %]

> [% END %]
> 
> That would also allow you to define custom audio alerts for those messages.

+1

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan  9 00:53:14 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 08 Jan 2020 23:53:14 +0000
Subject: [Koha-bugs] [Bug 15976] Test bug for a script we are developing
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15976

Katrin Fischer  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |INVALID

--- Comment #4 from Katrin Fischer  ---
Not used in a few years... closing.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan  9 00:55:28 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 08 Jan 2020 23:55:28 +0000
Subject: [Koha-bugs] [Bug 16002] ALL/MULTI choices in report dropdowns
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16002

--- Comment #2 from Katrin Fischer  ---
ALL is done now by bug 23389

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan  9 01:00:45 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 09 Jan 2020 00:00:45 +0000
Subject: [Koha-bugs] [Bug 19174] No Credits Please
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19174

Katrin Fischer  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de
          Component|Circulation                 |Fines and fees

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan  9 01:04:06 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 09 Jan 2020 00:04:06 +0000
Subject: [Koha-bugs] [Bug 15949] Making certain alerts stand out
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15949

--- Comment #3 from Christopher Brannon  ---
I think, in the interest of keeping things simple, and not having programmers
hate this, it would be better to have either a brief code, or a numeric problem
ID or subclass so people are not having to use #checkin_no_item_with_barcode. 
As someone that uses jQuery a lot, it would annoy me more than keeping a unique
code or number straight.  But, that is my personal opinion and not the opinion
of programmers.

Either way, it would work.

HOWEVER, it would be even BETTER, if there were a page that could be dedicated
to customizations, and would isolate key alerts and such that people could
easily set.  Koha is HIGHLY customizable, but not everyone wants the nitty
gritty of CSS.  Looking things up, possibly mistyping something, trying to
figure out what they did wrong.  Not everyone wants to keep up on CSS.

Keep the ability to customize CSS, but add some basic choices for those who
don't CSS.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan  9 01:05:08 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 09 Jan 2020 00:05:08 +0000
Subject: [Koha-bugs] [Bug 16109] Toolbars wrapping on narrower browsers
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16109

Katrin Fischer  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de

--- Comment #5 from Katrin Fischer  ---
(In reply to Owen Leonard from comment #4)
> I think this may come down to a personal preference, which probably means
> that the proposed change belongs in IntranetUserCSS.
> 
> I don't think it looks beautiful when the toolbar buttons wrap, but I would
> prefer to have them wrap and be easily accessible rather than have to scroll
> horizontally to reach them.
> 
> Perhaps the question should be "Since the buttons wrap at smaller browser
> widths and it doesn't look great, how can we improve the appearance of the
> toolbar when the buttons /do/ wrap?" Solving that would bring us one small
> step closer to having a responsive staff client.

+1

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan  9 01:10:02 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 09 Jan 2020 00:10:02 +0000
Subject: [Koha-bugs] [Bug 16002] MULTI choices in report dropdowns
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16002

Christopher Brannon  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|ALL/MULTI choices in report |MULTI choices in report
                   |dropdowns                   |dropdowns

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan  9 01:12:15 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 09 Jan 2020 00:12:15 +0000
Subject: [Koha-bugs] [Bug 16002] MULTI choices in report dropdowns
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16002

--- Comment #3 from Christopher Brannon  ---
Great!  Half way there.  Now, if we could repeat the process of bug 23389 and
give the option of <> where that would allow you to
select several branches of your choosing, that would be fantastic.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan  9 01:15:31 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 09 Jan 2020 00:15:31 +0000
Subject: [Koha-bugs] [Bug 23560] Manual FAQ doesn't reflect changes to
 accounttype codes
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23560

Katrin Fischer  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de
           Keywords|                            |Manual

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan  9 01:16:41 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 09 Jan 2020 00:16:41 +0000
Subject: [Koha-bugs] [Bug 23554] Display info from MARC21 110 and 111 in
 cart/list emails
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23554

Katrin Fischer  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=3150

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan  9 01:16:41 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 09 Jan 2020 00:16:41 +0000
Subject: [Koha-bugs] [Bug 3150] Move emails for sending cart and list
 contents into notices tool
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3150

Katrin Fischer  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=23554

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan  9 01:59:50 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 09 Jan 2020 00:59:50 +0000
Subject: [Koha-bugs] [Bug 15504] Track Patron's Last Activity
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15504

Agnes Rivers-Moore  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |arm at hanover.ca

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan  9 03:22:11 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 09 Jan 2020 02:22:11 +0000
Subject: [Koha-bugs] [Bug 15504] Track Patron's Last Activity
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15504

--- Comment #9 from Agnes Rivers-Moore  ---
Summary so far - 
A timestamp, updated by checkout / renew / return / SIP2 / OPAC login. (Nicole)
The type of activity needs to be indicated as well as the timestamp.
(Christopher)
SIP2 activity needs to be tracked. (Martha)
Noted "Lastseen" seems to capture OPAC login and authenticated by SIP. This
would be the "updated" timestamp displayed in the patron summary.

My thoughts -
It would help to know more about how people want to use this timestamp. Is it
for reports (inactive patrons for weeding, or activity for statistics), or to
be visible to staff in the patron record, like the "Updated" timestamp? 
We would need clearer labels - "updated" implies but does not actually indicate
when the borrower record was renewed or edited.

Checkout / renew / return (whether through intranet, OPAC or SIP) are one kind
of activity, and are captured already in circulation history. OPAC login and
SIP (e.g. for authentication of outside systems like Overdrive) are another,
and they are also already captured somewhere but not clear to staff. Should
they be handled separately or feed into a single last activity date?

I would also like a way to update that activity timestamp without checking out.
Something like the "statistical borrower" but a "statistical item" that could
be scanned to record library activity not connected to Koha. For example,
people who use computers or sign up for programmes. Maybe there is one I have
missed.

I agree with Martha that tracking SIP2 connections is important, and perhaps
should be addressed in more detail. We use it for self-checkout, computer
booking (in-library activities) and authentication for accessing Overdrive,
RBDigital (external resources).

Some label suggestions - last-login (OPAC or self-checkout), updated (patron
details changed through OPAC or Intranet), last-activity (activity from any
channel including SIP), remote-use (outside resource SIP connections and OPAC
login). 
Just suggestions, for wider discussion.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan  9 07:16:05 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 09 Jan 2020 06:16:05 +0000
Subject: [Koha-bugs] [Bug 12038] Need a provision to search specific
 barcode/accession number
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12038

--- Comment #2 from vimal kumar  ---
This problem can be solve by using "bc:" along with barcode.
Thank you.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan  9 07:59:20 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 09 Jan 2020 06:59:20 +0000
Subject: [Koha-bugs] [Bug 23731] Display LC call number in OPAC and staff
 detail pages
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23731

David Nind  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Text to go in the|                            |This enhancement enables
      release notes|                            |the display of the LOC
                   |                            |classification number in
                   |                            |the OPAC an staff client.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan  9 08:22:56 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 09 Jan 2020 07:22:56 +0000
Subject: [Koha-bugs] [Bug 23442] Add a 'refund' process to accounts
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23442

--- Comment #25 from Josef Moravec  ---
Comment on attachment 97008
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97008
Bug 23442: Add account credit types

Review of attachment 97008:
 --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=23442&attachment=97008)
-----------------------------------------------------------------

::: installer/data/mysql/account_offset_types.sql
@@ +17,5 @@
>  ('OVERDUE'),
>  ('Void Payment'),
>  ('Credit Applied'),
> +('PAYOUT'),
> +('DISOUNT'),

Typo: should be 'DISCOUNT'

::: installer/data/mysql/atomicupdate/bug_23442.perl
@@ +15,5 @@
> +    });
> +
> +    SetVersion($DBversion);
> +    print "Upgrade to $DBversion done (Bug 23442 - Add REFUND and DISCOUNT account_credit_types)\n";
> +    print "Upgrade to $DBversion done (Bug 23442 - Add REFUNDED and DISCOUNTED account_offset_types)\n";

Should be 'REFUND' and 'DISCOUNT' too

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan  9 08:36:23 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 09 Jan 2020 07:36:23 +0000
Subject: [Koha-bugs] [Bug 23442] Add a 'refund' process to accounts
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23442

Josef Moravec  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         QA Contact|testopia at bugs.koha-communit |josef.moravec at gmail.com
                   |y.org                       |
                 CC|                            |josef.moravec at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan  9 08:36:50 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 09 Jan 2020 07:36:50 +0000
Subject: [Koha-bugs] [Bug 24383] New: koha-create doesn't restart / empty
 memcached causing installer fail
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24383

            Bug ID: 24383
           Summary: koha-create doesn't restart / empty memcached causing
                    installer fail
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: minor
          Priority: P5 - low
         Component: Installation and upgrade (command-line installer)
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: joonas.kylmala at helsinki.fi
        QA Contact: testopia at bugs.koha-community.org

If in /etc/koha/koha-sites.conf I have defined USE_MEMCACHED="yes" and then I
run "koha-create --create-db kvkoha" and after that "koha-remove kvkoha" and
then again "koha-create --create-db kvkoha" then when I try to access the web
installer page I get the following error:

> DBIx::Class::Storage::DBI::catch {...} (): DBI Connection failed: Access denied for user 'koha_kvkoha'@'localhost' (using password: YES) at /usr/share/perl5/DBIx/Class/Storage/DBI.pm line 1520. at /usr/share/koha/lib/Koha/Database.pm line 107

This seems to happen because the memcached instance still holds the database
credentials from the first time koha-create was run. The solution is to clear
the memcached cache:

> $ systemctl restart memcached

After this the web installer loads correctly.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan  9 08:58:50 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 09 Jan 2020 07:58:50 +0000
Subject: [Koha-bugs] [Bug 23442] Add a 'refund' process to accounts
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23442

--- Comment #26 from Josef Moravec  ---
Comment on attachment 97011
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97011
Bug 23442: Add refund option to patron account page

Review of attachment 97011:
 --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=23442&attachment=97011)
-----------------------------------------------------------------

::: koha-tmpl/intranet-tmpl/prog/en/modules/members/boraccount.tt
@@ +216,5 @@
> +                                    
>         
>   
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/virtualshelves/downloadshelf.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/virtualshelves/downloadshelf.tt
>index 740fe5d1f0..772ac50ab8 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/virtualshelves/downloadshelf.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/virtualshelves/downloadshelf.tt
>@@ -37,7 +37,7 @@
> 	    
> 	    [% END %]
>         [% FOREACH xsl_export IN xsl_exports %]
>-            
>+            
>         [% END %]
> 	
> 	
>diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/includes/opac-detail-sidebar.inc b/koha-tmpl/opac-tmpl/bootstrap/en/includes/opac-detail-sidebar.inc
>index 4e1ae642c1..7d07e07ed8 100644
>--- a/koha-tmpl/opac-tmpl/bootstrap/en/includes/opac-detail-sidebar.inc
>+++ b/koha-tmpl/opac-tmpl/bootstrap/en/includes/opac-detail-sidebar.inc
>@@ -80,7 +80,7 @@
>                                 
>                                 [% ELSE %]
>                                     [% FOREACH filesOption IN filesOptions %]
>-                                        
  • [% filesOption.filename %]
    • 
>+                                        
  • [% filesOption.filename | html %]
    • 
>                                     [% END %]
>                                 [% END %]
>                             [% END %]
>diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-downloadcart.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-downloadcart.tt
>index 70c3beb1a3..2bd1215ebc 100644
>--- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-downloadcart.tt
>+++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-downloadcart.tt
>@@ -21,7 +21,7 @@
>                                     
>                                 [% END %]
>                                 [% FOREACH xsl_export IN xsl_exports %]
>-                                    
>+                                    
>                                 [% END %]
>                             
>                             
    
>diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-downloadshelf.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-downloadshelf.tt
>index 4881ea7aa9..411168ea29 100644
>--- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-downloadshelf.tt
>+++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-downloadshelf.tt
>@@ -60,7 +60,7 @@
>                                             
>                                             [% END %]
>                                             [% FOREACH xsl_export IN xsl_exports %]
>-                                                
>+                                                
>                                             [% END %]
>                                         
>                                         Required
>diff --git a/t/db_dependent/XSLT.t b/t/db_dependent/XSLT.t
>index 968f7db8ad..3a69b66aab 100644
>--- a/t/db_dependent/XSLT.t
>+++ b/t/db_dependent/XSLT.t
>@@ -1,13 +1,11 @@
> use Modern::Perl;
>-use Test::More tests => 2;
>+use Test::More tests => 1;
> 
> use t::lib::Mocks;
> use C4::XSLT;
>-use Koha::Caches;
> use Koha::Database;
> 
> our $schema = Koha::Database->new->schema;
>-our $cache = Koha::Caches->get_instance;
> 
> # Here we go
> $schema->storage->txn_begin;
>@@ -22,17 +20,4 @@ subtest 'CustomXSLTExportList: Check export options' => sub {
>     $list = C4::XSLT::CustomXSLTExportList(1);
>     is( @$list, 0, 'We expect an empty list now' );
> };
>-
>-subtest  'CustomXSLTExportList: Caching' => sub {
>-    plan tests => 1;
>-    t::lib::Mocks::mock_preference('OpacExportOptions', 'custom');
>-    $cache->clear_from_cache('CustomXSLTExportListOPAC');
>-    my $list = C4::XSLT::CustomXSLTExportList(1);
>-    push @$list, { nonsense => 1 };
>-    $cache->set_in_cache( 'CustomXSLTExportListOPAC', $list );
>-    my $n = @$list;
>-    $list = C4::XSLT::CustomXSLTExportList(1);
>-    is( @$list, $n, 'This list comes from the cache and that is fine' );
>-    $cache->clear_from_cache('CustomXSLTExportListOPAC');
>-};
>-$schema->storage->txn_rollback;
>+$schema->storage->txn_rollback;
>\ No newline at end of file
>-- 
>2.17.1

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan  9 14:52:14 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 09 Jan 2020 13:52:14 +0000
Subject: [Koha-bugs] [Bug 23961] [18.11] Menu "add subcription fields" has
 disappeared
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23961

--- Comment #6 from Corinne Hayet  ---
Thanks everybody. I tested it on my 18.11.11 and it works.

Best regards...and Happy new year ;)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan  9 14:54:19 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 09 Jan 2020 13:54:19 +0000
Subject: [Koha-bugs] [Bug 23355] Add 'cashup' process to the accounts system
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23355

Martin Renvoize  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #97044|0                           |1
        is obsolete|                            |

--- Comment #37 from Martin Renvoize  ---
Created attachment 97077
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97077&action=edit
Bug 23355: Add cash_register_actions table

This patch adds the new cash_register_actions database table to allow
for storing of cash register actions which are not already stored as
accountlines.

Signed-off-by: Kyle M Hall 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan  9 14:54:22 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 09 Jan 2020 13:54:22 +0000
Subject: [Koha-bugs] [Bug 23355] Add 'cashup' process to the accounts system
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23355

Martin Renvoize  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #97045|0                           |1
        is obsolete|                            |

--- Comment #38 from Martin Renvoize  ---
Created attachment 97078
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97078&action=edit
Bug 23355: [DO NOT PUSH] DBIC Classes

Signed-off-by: Kyle M Hall 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan  9 14:54:26 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 09 Jan 2020 13:54:26 +0000
Subject: [Koha-bugs] [Bug 23355] Add 'cashup' process to the accounts system
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23355

Martin Renvoize  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #97046|0                           |1
        is obsolete|                            |

--- Comment #39 from Martin Renvoize  ---
Created attachment 97079
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97079&action=edit
Bug 23355: Add CASHUP actions

This patch adds a methods relating to cashup procedures to the cash
register object to ease adding and querying for cashup actions related
to the register.

Signed-off-by: Kyle M Hall 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan  9 14:54:29 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 09 Jan 2020 13:54:29 +0000
Subject: [Koha-bugs] [Bug 23355] Add 'cashup' process to the accounts system
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23355

Martin Renvoize  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #97047|0                           |1
        is obsolete|                            |

--- Comment #40 from Martin Renvoize  ---
Created attachment 97080
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97080&action=edit
Bug 23355: Add accountline deletion test

Signed-off-by: Kyle M Hall 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan  9 14:54:32 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 09 Jan 2020 13:54:32 +0000
Subject: [Koha-bugs] [Bug 23355] Add 'cashup' process to the accounts system
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23355

Martin Renvoize  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #97048|0                           |1
        is obsolete|                            |

--- Comment #41 from Martin Renvoize  ---
Created attachment 97081
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97081&action=edit
Bug 23355: Link cash_register_actions to cash_registers by foreign key

Signed-off-by: Kyle M Hall 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan  9 14:54:36 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 09 Jan 2020 13:54:36 +0000
Subject: [Koha-bugs] [Bug 23355] Add 'cashup' process to the accounts system
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23355

Martin Renvoize  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #97049|0                           |1
        is obsolete|                            |

--- Comment #42 from Martin Renvoize  ---
Created attachment 97082
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97082&action=edit
Bug 23355: Split tests for Line vs Lines

Signed-off-by: Kyle M Hall 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan  9 14:54:39 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 09 Jan 2020 13:54:39 +0000
Subject: [Koha-bugs] [Bug 23355] Add 'cashup' process to the accounts system
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23355

Martin Renvoize  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #97050|0                           |1
        is obsolete|                            |

--- Comment #43 from Martin Renvoize  ---
Created attachment 97083
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97083&action=edit
Bug 23355: Add register details page

Signed-off-by: Kyle M Hall 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan  9 14:54:42 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 09 Jan 2020 13:54:42 +0000
Subject: [Koha-bugs] [Bug 23355] Add 'cashup' process to the accounts system
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23355

Martin Renvoize  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #97051|0                           |1
        is obsolete|                            |

--- Comment #44 from Martin Renvoize  ---
Created attachment 97084
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97084&action=edit
Bug 23355: Add cashup permissions

Signed-off-by: Kyle M Hall 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan  9 14:54:45 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 09 Jan 2020 13:54:45 +0000
Subject: [Koha-bugs] [Bug 23355] Add 'cashup' process to the accounts system
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23355

Martin Renvoize  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #97052|0                           |1
        is obsolete|                            |

--- Comment #45 from Martin Renvoize  ---
Created attachment 97085
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97085&action=edit
Bug 23355: Add branch details page

This patch adds a new 'branch details' page to the POS system which
displays a summary of the cash register transactions for a branch
since each register was last cashed up. It also allows for cashing
up individual registers or cashing up all registers at a given branch
in one transaction.

Signed-off-by: Kyle M Hall 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan  9 14:54:48 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 09 Jan 2020 13:54:48 +0000
Subject: [Koha-bugs] [Bug 23355] Add 'cashup' process to the accounts system
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23355

Martin Renvoize  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #97053|0                           |1
        is obsolete|                            |

--- Comment #46 from Martin Renvoize  ---
Created attachment 97086
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97086&action=edit
Bug 23555: Use rowGroup plugin

Signed-off-by: Kyle M Hall 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan  9 14:54:51 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 09 Jan 2020 13:54:51 +0000
Subject: [Koha-bugs] [Bug 23355] Add 'cashup' process to the accounts system
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23355

Martin Renvoize  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #97054|0                           |1
        is obsolete|                            |

--- Comment #47 from Martin Renvoize  ---
Created attachment 97087
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97087&action=edit
Bug 23355: Remove superflous use of AuthoriseValues

Signed-off-by: Kyle M Hall 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan  9 14:55:53 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 09 Jan 2020 13:55:53 +0000
Subject: [Koha-bugs] [Bug 23355] Add 'cashup' process to the accounts system
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23355

--- Comment #48 from Martin Renvoize  ---
Created attachment 97088
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97088&action=edit
Bug 23355: Use rowGroup plugin

Signed-off-by: Kyle M Hall 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan  9 14:55:56 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 09 Jan 2020 13:55:56 +0000
Subject: [Koha-bugs] [Bug 23355] Add 'cashup' process to the accounts system
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23355

Martin Renvoize  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #97087|0                           |1
        is obsolete|                            |

--- Comment #49 from Martin Renvoize  ---
Created attachment 97089
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97089&action=edit
Bug 23355: Remove superflous use of AuthoriseValues

Signed-off-by: Kyle M Hall 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan  9 14:56:17 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 09 Jan 2020 13:56:17 +0000
Subject: [Koha-bugs] [Bug 23355] Add 'cashup' process to the accounts system
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23355

Martin Renvoize  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #97086|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan  9 14:56:31 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 09 Jan 2020 13:56:31 +0000
Subject: [Koha-bugs] [Bug 23355] Add 'cashup' process to the accounts system
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23355

--- Comment #50 from Martin Renvoize  ---
Rebased

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan  9 14:58:16 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 09 Jan 2020 13:58:16 +0000
Subject: [Koha-bugs] [Bug 15145] Fix hover state on bugzilla theme header so
 it doesn't jump on hover
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15145

--- Comment #5 from Owen Leonard  ---
Based on the compiled CSS it looks like there is a custom Koha skin at
skins/contrib/koha/bug.css

If that's right, then I suggest adding this to that file:

body {
    font-family: Arial, Helvetica, sans-serif;
}

.links a:hover {
    color: #FFC;
    font-weight: normal;
}

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan  9 15:13:48 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 09 Jan 2020 14:13:48 +0000
Subject: [Koha-bugs] [Bug 23961] [18.11] Menu "add subcription fields" has
 disappeared
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23961

Katrin Fischer  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to oldstable         |RESOLVED
         Resolution|---                         |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan  9 15:16:43 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 09 Jan 2020 14:16:43 +0000
Subject: [Koha-bugs] [Bug 24369] Add ability to set CORS header in Koha
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24369

Tomás Cohen Arazi  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan  9 15:17:26 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 09 Jan 2020 14:17:26 +0000
Subject: [Koha-bugs] [Bug 23618] Make addition SIP2 fields available to self
 service to add cost of items checked out to check out slip
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23618

--- Comment #1 from Colin Campbell  ---
Historically additions to the protocol have been driven by the vendors of
selfcheck routines, have any expressed intrest in implementing this? 
Note CM as a code is already in use for Hold Pickup Date

The note example you give includes data not available, to the unit from the
item.price and item.replacementprice

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan  9 15:22:39 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 09 Jan 2020 14:22:39 +0000
Subject: [Koha-bugs] [Bug 24081] Add a 'discount' process to accounts
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24081

--- Comment #1 from Martin Renvoize  ---
Created attachment 97090
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97090&action=edit
Bug 24081: Add credit_types, offset_types and permissions

This patch adds the credit_type, offset_type and permissions required
for the addition of a discounting workflow in the accounts system.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are on the CC list for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan  9 15:22:43 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 09 Jan 2020 14:22:43 +0000
Subject: [Koha-bugs] [Bug 24081] Add a 'discount' process to accounts
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24081

--- Comment #2 from Martin Renvoize  ---
Created attachment 97091
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97091&action=edit
Bug 24081: Add DISCOUNT to the allowed 'reduce' types

This patch adds the DISCOUNT type to the handled types list in the
reduce method introduced in bug 23442

-- 
You are receiving this mail because:
You are watching all bug changes.
You are on the CC list for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan  9 15:22:54 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 09 Jan 2020 14:22:54 +0000
Subject: [Koha-bugs] [Bug 24369] Add ability to set CORS header in Koha
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24369

--- Comment #2 from Tomás Cohen Arazi  ---
Created attachment 97092
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97092&action=edit
Bug 24369: Add AccessControlAllowOrigin syspref

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan  9 15:22:57 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 09 Jan 2020 14:22:57 +0000
Subject: [Koha-bugs] [Bug 24369] Add ability to set CORS header in Koha
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24369

--- Comment #3 from Tomás Cohen Arazi  ---
Created attachment 97093
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97093&action=edit
Bug 24369: Add CORS support to output_with_http_headers()

This patch adds CORS support to output_with_headers(). It will use the
AccessControlAllowOrigin syspref to pick the value and set the
Access-Control-Allow-Origin header.

To test:
1. Apply this patch
2. Run:
   $ kshell
  k$ prove t/Output.t
SUCCESS: Tests pass!
3. Sign off :-D

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan  9 15:23:01 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 09 Jan 2020 14:23:01 +0000
Subject: [Koha-bugs] [Bug 24369] Add ability to set CORS header in Koha
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24369

--- Comment #4 from Tomás Cohen Arazi  ---
Created attachment 97094
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97094&action=edit
Bug 24369: Add CORS support to the API

This patch adds CORS support for API requests. It uses the
AccessControlAllowOrigin syspref. To test:

1. Apply this patch
2. Run:
   $ kshell
  k$ prove t/db_dependent/api/v1/auth.t
=> SUCCESS: Tests pass!
3. Set the AccessControlAllowOrigin to any string (for example, *)
4. Use any API testing tool (Postman?) to place a request on the API
=> SUCCESS: The response headers include Access-Control-Allow-Origin,
    containing what you set on the syspref
5. Sign off :-D

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan  9 15:23:27 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 09 Jan 2020 14:23:27 +0000
Subject: [Koha-bugs] [Bug 24369] Add ability to set CORS header in Koha
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24369

Tomás Cohen Arazi  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |nick at bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan  9 15:25:06 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 09 Jan 2020 14:25:06 +0000
Subject: [Koha-bugs] [Bug 24369] Add ability to set CORS header in Koha
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24369

Tomás Cohen Arazi  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |benjamin.rokseth at deichman.n
                   |                            |o,
                   |                            |martin.renvoize at ptfs-europe
                   |                            |.com
  Text to go in the|                            |This development adds
      release notes|                            |support for setting the
                   |                            |Access-Control-Allow-Origin
                   |                            |header in Koha. This is
                   |                            |specially useful for
                   |                            |integrating data from the
                   |                            |services provided by Koha
                   |                            |on sites other than Koha
                   |                            |itself.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan  9 15:27:30 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 09 Jan 2020 14:27:30 +0000
Subject: [Koha-bugs] [Bug 24384] New: Add Access-Control-Allow-Origin
 support to reports svc
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24384

            Bug ID: 24384
           Summary: Add Access-Control-Allow-Origin support to reports svc
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Web services
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: tomascohen at gmail.com
        QA Contact: testopia at bugs.koha-community.org

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan  9 15:27:49 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 09 Jan 2020 14:27:49 +0000
Subject: [Koha-bugs] [Bug 24384] Add Access-Control-Allow-Origin support to
 reports svc
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24384

Tomás Cohen Arazi  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
           Assignee|koha-bugs at lists.koha-commun |tomascohen at gmail.com
                   |ity.org                     |
         Depends on|                            |24369


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24369
[Bug 24369] Add ability to set CORS header in Koha
-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan  9 15:27:49 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 09 Jan 2020 14:27:49 +0000
Subject: [Koha-bugs] [Bug 24369] Add ability to set CORS header in Koha
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24369

Tomás Cohen Arazi  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |24384


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24384
[Bug 24384] Add Access-Control-Allow-Origin support to reports svc
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan  9 15:29:00 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 09 Jan 2020 14:29:00 +0000
Subject: [Koha-bugs] [Bug 22359] Improve usability of 'change calculation'
 (bug 11373)
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22359

Martin Renvoize  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |rel_20_05_target,
                   |                            |RM_priority

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan  9 15:31:08 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 09 Jan 2020 14:31:08 +0000
Subject: [Koha-bugs] [Bug 24384] Add Access-Control-Allow-Origin support to
 OPAC reports svc
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24384

Tomás Cohen Arazi  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Add                         |Add
                   |Access-Control-Allow-Origin |Access-Control-Allow-Origin
                   |support to reports svc      |support to OPAC reports svc

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan  9 15:40:53 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 09 Jan 2020 14:40:53 +0000
Subject: [Koha-bugs] [Bug 6759] Use a different account type for account
 renewals than for new accounts
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6759

Martin Renvoize  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to master            |RESOLVED
         Resolution|---                         |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan  9 15:40:54 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 09 Jan 2020 14:40:54 +0000
Subject: [Koha-bugs] [Bug 23321] Add 'cash registers' to the accounts system
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23321
Bug 23321 depends on bug 6759, which changed state.

Bug 6759 Summary: Use a different account type for account renewals than for new accounts
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6759

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to master            |RESOLVED
         Resolution|---                         |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan  9 15:41:24 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 09 Jan 2020 14:41:24 +0000
Subject: [Koha-bugs] [Bug 23321] Add 'cash registers' to the accounts system
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23321

Martin Renvoize  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to master            |RESOLVED
         Resolution|---                         |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan  9 15:41:24 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 09 Jan 2020 14:41:24 +0000
Subject: [Koha-bugs] [Bug 24338] CASH is missing from the default
 payment_types
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24338
Bug 24338 depends on bug 23321, which changed state.

Bug 23321 Summary: Add 'cash registers' to the accounts system
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23321

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to master            |RESOLVED
         Resolution|---                         |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan  9 15:41:24 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 09 Jan 2020 14:41:24 +0000
Subject: [Koha-bugs] [Bug 23049] Replace MANUAL_INV authorised value with a
 dedicated table
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049
Bug 23049 depends on bug 23321, which changed state.

Bug 23321 Summary: Add 'cash registers' to the accounts system
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23321

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to master            |RESOLVED
         Resolution|---                         |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan  9 15:42:45 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 09 Jan 2020 14:42:45 +0000
Subject: [Koha-bugs] [Bug 23805] Add a dedicated credit_types table
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23805

Martin Renvoize  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|Pushed to master            |RESOLVED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan  9 15:42:46 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 09 Jan 2020 14:42:46 +0000
Subject: [Koha-bugs] [Bug 23894] accountlines.payment_type and
 accountlines.credit_type should be merged
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23894
Bug 23894 depends on bug 23805, which changed state.

Bug 23805 Summary: Add a dedicated credit_types table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23805

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to master            |RESOLVED
         Resolution|---                         |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan  9 15:42:46 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 09 Jan 2020 14:42:46 +0000
Subject: [Koha-bugs] [Bug 24080] Add a 'payout' process to accounts
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24080
Bug 24080 depends on bug 23805, which changed state.

Bug 23805 Summary: Add a dedicated credit_types table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23805

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to master            |RESOLVED
         Resolution|---                         |FIXED

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan  9 15:42:46 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 09 Jan 2020 14:42:46 +0000
Subject: [Koha-bugs] [Bug 24177] Internal Server error when clicking cash
 register (Report)
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24177
Bug 24177 depends on bug 23805, which changed state.

Bug 23805 Summary: Add a dedicated credit_types table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23805

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to master            |RESOLVED
         Resolution|---                         |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan  9 15:43:56 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 09 Jan 2020 14:43:56 +0000
Subject: [Koha-bugs] [Bug 24080] Add a 'payout' process to accounts
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24080

Martin Renvoize  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|enhancement                 |new feature

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan  9 15:44:06 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 09 Jan 2020 14:44:06 +0000
Subject: [Koha-bugs] [Bug 24080] Add a 'payout' process to accounts
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24080

Martin Renvoize  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |Manual

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan  9 15:44:22 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 09 Jan 2020 14:44:22 +0000
Subject: [Koha-bugs] [Bug 24080] Add a 'payout' process to accounts
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24080

Martin Renvoize  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |lucy.vaux-harvey at ptfs-europ
                   |                            |e.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan  9 15:45:06 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 09 Jan 2020 14:45:06 +0000
Subject: [Koha-bugs] [Bug 23442] Add a 'refund' process to accounts
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23442

Martin Renvoize  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|enhancement                 |new feature

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan  9 15:45:56 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 09 Jan 2020 14:45:56 +0000
Subject: [Koha-bugs] [Bug 17700] Add columns configuration to fines table
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17700

Martin Renvoize  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|17596                       |
                 CC|                            |martin.renvoize at ptfs-europe
                   |                            |.com


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17596
[Bug 17596] Simplify accounting UI in staff client
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan  9 15:45:56 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 09 Jan 2020 14:45:56 +0000
Subject: [Koha-bugs] [Bug 17596] Simplify accounting UI in staff client
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17596

Martin Renvoize  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|17700                       |


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17700
[Bug 17700] Add columns configuration to fines table
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan  9 15:48:52 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 09 Jan 2020 14:48:52 +0000
Subject: [Koha-bugs] [Bug 23106] Totals are unclear when a credit is
 involved on the 'Pay fines' screen
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23106

Martin Renvoize  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|14825                       |17596


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14825
[Bug 14825] Accounts Rewrite Omnibus
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17596
[Bug 17596] Simplify accounting UI in staff client
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan  9 15:48:52 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 09 Jan 2020 14:48:52 +0000
Subject: [Koha-bugs] [Bug 14825] Accounts Rewrite Omnibus
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14825

Martin Renvoize  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|23106                       |


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23106
[Bug 23106] Totals are unclear when a credit is involved on the 'Pay fines'
screen
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan  9 15:48:52 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 09 Jan 2020 14:48:52 +0000
Subject: [Koha-bugs] [Bug 17596] Simplify accounting UI in staff client
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17596

Martin Renvoize  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |23106


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23106
[Bug 23106] Totals are unclear when a credit is involved on the 'Pay fines'
screen
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan  9 15:49:34 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 09 Jan 2020 14:49:34 +0000
Subject: [Koha-bugs] [Bug 24384] Add Access-Control-Allow-Origin support to
 OPAC reports svc
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24384

--- Comment #1 from Tomás Cohen Arazi  ---
Created attachment 97095
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97095&action=edit
Bug 24384: Add Access-Control-Allow-Origin support to OPAC reports svc

This patch makes the opac/svc/report script use output_with_http_headers
so it sets the Access-Control-Allow-Origin header.

To test:
1. Create a new public report and remember the report id
2. Use your favourite too to fetch the report in JSON by issuing:
   GET http://localhost:8080/cgi-bin/koha/svc/report?id=1
=> FAIL: There is no Access-Control-Allow-Origin header
3. Apply this patch
4. Restart Plack
   $ sudo koha-plack --restart kohadev
5. Set the AccessControlAllowOrigin to anything (for example,
   https://koha-community.org)
6. Repeat 2
=> SUCCESS: On the response headers you find
Access-Control-Allow-Origin: https://koha-community.org
7. Sign off :-D

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan  9 15:50:03 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 09 Jan 2020 14:50:03 +0000
Subject: [Koha-bugs] [Bug 24384] Add Access-Control-Allow-Origin support to
 OPAC reports svc
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24384

Tomás Cohen Arazi  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |kyle at bywatersolutions.com,
                   |                            |nick at bywatersolutions.com
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan  9 15:54:03 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 09 Jan 2020 14:54:03 +0000
Subject: [Koha-bugs] [Bug 24367] With strict enabled, Search.t is too verbose
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24367

Jonathan Druart  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #96911|0                           |1
        is obsolete|                            |

--- Comment #2 from Jonathan Druart  ---
Created attachment 97096
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97096&action=edit
Bug 24367: Remove warning from Search.t

Not done yet.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan  9 15:57:06 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 09 Jan 2020 14:57:06 +0000
Subject: [Koha-bugs] [Bug 24367] With strict enabled, Search.t is too verbose
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24367

--- Comment #3 from Jonathan Druart  ---
Created attachment 97097
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97097&action=edit
Bug 24367: DO NOT PUSH - update MARC records for tests

The idea was to set the itemtype to a valid value (BK instead of BOOK)
The exported_records was generated like:
 * add 942$c=MX when no 942$c exist
 * replace 942$c=BOOK with 942$c=BK

But it did not remove remaining warnings

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan  9 15:57:45 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 09 Jan 2020 14:57:45 +0000
Subject: [Koha-bugs] [Bug 24367] With strict enabled, Search.t is too verbose
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24367

Jonathan Druart  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |m.de.rooy at rijksmuseum.nl,
                   |                            |nick at bywatersolutions.com,
                   |                            |tomascohen at gmail.com

--- Comment #4 from Jonathan Druart  ---
I need help for this one.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan  9 15:58:52 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 09 Jan 2020 14:58:52 +0000
Subject: [Koha-bugs] [Bug 24385] New: Add menu into pages tools and admin
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24385

            Bug ID: 24385
           Summary: Add menu into pages tools and admin
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Templates
          Assignee: oleonard at myacpl.org
          Reporter: stephane.delaye at biblibre.com
        QA Contact: testopia at bugs.koha-community.org

Created attachment 97098
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97098&action=edit
New page administration with a menu

Each new version of Koha offers additional tools and parameters in the tools
and administration pages. While no menu allows you to browse these pages,
therefore such a display is not permanent. The idea would be to add a menu in
these pages in order to target each type of tool or parameter.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan  9 16:12:19 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 09 Jan 2020 15:12:19 +0000
Subject: [Koha-bugs] [Bug 8338] Fines not cleared with dropbox mode
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8338

Martin Renvoize  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |14825


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14825
[Bug 14825] Accounts Rewrite Omnibus
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan  9 16:12:19 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 09 Jan 2020 15:12:19 +0000
Subject: [Koha-bugs] [Bug 14825] Accounts Rewrite Omnibus
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14825

Martin Renvoize  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |8338


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8338
[Bug 8338] Fines not cleared with dropbox mode
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan  9 16:14:28 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 09 Jan 2020 15:14:28 +0000
Subject: [Koha-bugs] [Bug 24385] Add menu into pages tools and admin
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24385

Fridolin SOMERS  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |fridolin.somers at biblibre.co
                   |                            |m

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan  9 16:18:09 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 09 Jan 2020 15:18:09 +0000
Subject: [Koha-bugs] [Bug 14759] Replacement for Text::Unaccent
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14759

Jonathan Druart  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan  9 16:18:13 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 09 Jan 2020 15:18:13 +0000
Subject: [Koha-bugs] [Bug 14759] Replacement for Text::Unaccent
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14759

Jonathan Druart  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #96974|0                           |1
        is obsolete|                            |

--- Comment #40 from Jonathan Druart  ---
Created attachment 97099
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97099&action=edit
Bug 14759: Replace Text::Unaccent with Unicode::Normalize

As shown in the comments on the bug, it appears that Unicode::Normalize
is the most reliable way to strip accents from strings for this use
case.

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan  9 16:18:18 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 09 Jan 2020 15:18:18 +0000
Subject: [Koha-bugs] [Bug 14759] Replacement for Text::Unaccent
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14759

--- Comment #41 from Jonathan Druart  ---
Created attachment 97100
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97100&action=edit
Bug 14759: Add test

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan  9 16:18:53 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 09 Jan 2020 15:18:53 +0000
Subject: [Koha-bugs] [Bug 14759] Replacement for Text::Unaccent
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14759

Jonathan Druart  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org

--- Comment #42 from Jonathan Druart  ---
Martin, I think you forgot to add the new dependency.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan  9 16:24:15 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 09 Jan 2020 15:24:15 +0000
Subject: [Koha-bugs] [Bug 24383] koha-create doesn't restart / empty
 memcached causing installer fail
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24383

Jonathan Druart  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org

--- Comment #2 from Jonathan Druart  ---
FYI bug 20116 will add misc/bin/clear_cache.pl.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan  9 16:37:34 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 09 Jan 2020 15:37:34 +0000
Subject: [Koha-bugs] [Bug 17385] Add custom export formats for bibliographic
 records
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17385

Gabriel DeCarufel  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #86875|0                           |1
        is obsolete|                            |

--- Comment #46 from Gabriel DeCarufel  ---
Created attachment 97101
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97101&action=edit
Bug 17385: Add custom export XSLT

Patch was corrected and rebased after QA feedback. Previous patches where
combined into this one.

- Empty READMEs have been deleted
- Whitespaces changes to unrelated code have been undone
* CustomXSLTExportList now uses LibXML to figure out the title and output
    * The custom export XSLT's title should be an attribute to the root node,
otherwise it will default to filename
- Duplicate $xslFile param was removed from XSLTParse4Display
* Improvment to code structure in XSLTParse4Display
* Some fixes to calls to AddBiblio()

Test case:
  - Apply patch
  - Visit an item's detail page in the OPAC or the staff interface
  - Click save and you found Simple Export.
  - Click Simple Export and you have a file.html, it contain informations
returned by the xslt file.
  - It work correctly in basket and lists.

The patch comes with sample XSLT files
  for Intranet the xsl file is :
koha-tmpl/intranet-tmpl/prog/en/xslt/biblioexport/MARC21_simple_export.xsl
  for opac the xsl file is :
koha-tmpl/opac-tmpl/bootstrap/en/xslt/biblioexport/MARC21_simple_export.xsl

Followed test plan, patch works as described. Also ran QA test tools and
modified files pass

Signed-off-by: Alex Buckley 
Signed-off-by: Cori Lynn Arnold 
https://bugs.koha-community.org/show_bug.cgi?id=17835

Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan  9 16:37:43 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 09 Jan 2020 15:37:43 +0000
Subject: [Koha-bugs] [Bug 17385] Add custom export formats for bibliographic
 records
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17385

Gabriel DeCarufel  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #86876|0                           |1
        is obsolete|                            |

--- Comment #47 from Gabriel DeCarufel  ---
Created attachment 97102
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97102&action=edit
Bug 17385: Add tests for CustomXSLTExportList

+ Added tests for CustomXSLTExportList to C4::XSLT
+ Added an eval block in CustomXSLTExportList to handle invalid XML.

* Removed Opac parameter, but now handle "OPACXSLTCustomExport" as equivalent

+ Added "Custom" option to OPACExportOptions preference.

Tested with invalid XML (not originally on purpose, but...) and then
added a new field to add to the simple export.

Walked through the testing steps.

Question: should this also apply to the cataloging page as an export
option? It doesn't now.

Signed-off-by: Cori Lynn Arnold 

Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan  9 16:37:49 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 09 Jan 2020 15:37:49 +0000
Subject: [Koha-bugs] [Bug 17385] Add custom export formats for bibliographic
 records
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17385

Gabriel DeCarufel  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #86879|0                           |1
        is obsolete|                            |

--- Comment #48 from Gabriel DeCarufel  ---
Created attachment 97103
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97103&action=edit
Bug 17385: (QA follow-up) Do not needlessly scan biblioexport folder

Performance: We need to return an empty list if OpacExportOptions does not
contain Custom.  No need to scan the directory for custom files, if we are not
using them at all.

Note: The test only pertains to OPAC now, since the pref should not control
intranet behavior. We have no intranet counterpart. See further next follow-up.

Test plan:
Run t/db_dependent/XSLT.t

Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan  9 16:37:55 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 09 Jan 2020 15:37:55 +0000
Subject: [Koha-bugs] [Bug 17385] Add custom export formats for bibliographic
 records
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17385

Gabriel DeCarufel  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #86880|0                           |1
        is obsolete|                            |

--- Comment #49 from Gabriel DeCarufel  ---
Created attachment 97104
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97104&action=edit
Bug 17385: (QA follow-up) Add caching

Performance: We should add caching in CustomXSLTExportList.

Note: This resolves the lack of an intranet test in the former patch too.

Test plan:
Run t/db_dependent/XSLT.t

Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan  9 16:38:00 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 09 Jan 2020 15:38:00 +0000
Subject: [Koha-bugs] [Bug 17385] Add custom export formats for bibliographic
 records
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17385

--- Comment #50 from Gabriel DeCarufel  ---
Created attachment 97105
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97105&action=edit
Bug 17385: QA Critics Fixed and added Missing Filters

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan  9 16:39:14 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 09 Jan 2020 15:39:14 +0000
Subject: [Koha-bugs] [Bug 17385] Add custom export formats for bibliographic
 records
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17385

Gabriel DeCarufel  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |gabriel.decarufel at inlibro.c
                   |                            |om
  Attachment #97076|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan  9 16:45:07 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 09 Jan 2020 15:45:07 +0000
Subject: [Koha-bugs] [Bug 17385] Add custom export formats for bibliographic
 records
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17385

Gabriel DeCarufel  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Needs Signoff

--- Comment #51 from Gabriel DeCarufel  ---
Remove merge conflicts.
Fixed qa script failures - missing filters and a critic complaint on XSLT.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan  9 16:49:16 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 09 Jan 2020 15:49:16 +0000
Subject: [Koha-bugs] [Bug 24305] Batch Item modification via item number in
 reports does not work with CONCAT in report
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24305

Holly  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |hc at interleaf.ie

--- Comment #2 from Holly  ---
I tested this and noticed something odd. The examples given in the test plan
worked as expected:

Results from reports using only the CONCAT statement did not produce a link to
to the batch tools.

Reports that did not use the CONCAT statement at all did produce a link to the
batch tools. 

Reports that had the CONCAT statement but also had results that were not
concatenated did produce a link to the batch tools, but only for the results
that were not concatenated. e.g

SELECT itemnumber, CONCAT('', itemnumber,
'' ) AS itemnumber
    FROM items
    LIMIT 10;

produced a link to the batch tools for the first instance of itemnumber.

However, I tried to create a report that used the CONCAT statement for both the
biblionumber and the itemnumber and the results included a button to link to
the batch tools, however it did not have a dropdown menu to select which tool
to go to.

SELECT CONCAT('', biblionumber, '' ) AS biblionumber, CONCAT('', itemnumber,
'' ) AS itemnumber
    FROM items
    LIMIT 10

I don't think the button should appear at all in this instance and it shouldn't
appear if it is not going to link out to anything. 

Best,
Holly

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan  9 16:51:48 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 09 Jan 2020 15:51:48 +0000
Subject: [Koha-bugs] [Bug 24386] New: Prohibit Double Submit to happen when
 adding to a basket
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24386

            Bug ID: 24386
           Summary: Prohibit Double Submit to happen when adding to a
                    basket
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Acquisitions
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: kelly at bywatersolutions.com
        QA Contact: testopia at bugs.koha-community.org

The ability to double submit in Acquisitions causes duplicate biblio records to
be added to a basket.  It would be advisable to add a way to stop a double
submit to happen as this causes errors (duplicate orders).

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan  9 16:53:11 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 09 Jan 2020 15:53:11 +0000
Subject: [Koha-bugs] [Bug 24386] Prohibit Double Submit to happen when
 adding to a basket
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24386

--- Comment #1 from Kelly McElligott  ---
acqui/addorderiso2709.pl

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan  9 16:58:45 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 09 Jan 2020 15:58:45 +0000
Subject: [Koha-bugs] [Bug 18731] Add routes for acquisition orders
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18731

Martin Renvoize  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         QA Contact|josef.moravec at gmail.com     |martin.renvoize at ptfs-europe
                   |                            |.com
                 CC|                            |martin.renvoize at ptfs-europe
                   |                            |.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan  9 16:59:02 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 09 Jan 2020 15:59:02 +0000
Subject: [Koha-bugs] [Bug 24386] Prohibit Double Submit to happen when
 adding to a basket
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24386

Nick Clemens  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Trivial patch
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan  9 16:59:04 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 09 Jan 2020 15:59:04 +0000
Subject: [Koha-bugs] [Bug 24386] Prohibit Double Submit to happen when
 adding to a basket
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24386

--- Comment #2 from Nick Clemens  ---
Created attachment 97106
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97106&action=edit
Bug 24386 - Prevent double form submission on adding orders to basket from a
file

To test:
 1 - Have a marc record file
 2 - Go to Acquisitions, find a vendor, then an open basket
 3 - Add to basket from a new file (if you already have one staged you can
choose that instead)
 4 - Import the file, then add to basket
 5 - On the page where you select the records and set info select a record, set
matching to 'Do not check' fill in the fund for the order
 6 - When ready, click save as many times as you can
 7 - When you go to the basket there are many copies of the order added
 8 - Don't despair, apply the patch
 9 - Repeat above
10 - When ready to add orders, click furiously
11 - The order is only added once!
12 - Success!

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan  9 16:59:27 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 09 Jan 2020 15:59:27 +0000
Subject: [Koha-bugs] [Bug 24386] Prohibit Double Submit to happen when
 adding to a basket
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24386

Nick Clemens  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |nick at bywatersolutions.com
                   |ity.org                     |
                 CC|                            |nick at bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan  9 17:15:02 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 09 Jan 2020 16:15:02 +0000
Subject: [Koha-bugs] [Bug 18731] Add routes for acquisition orders
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18731

Martin Renvoize  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

--- Comment #37 from Martin Renvoize  ---
This is an impressive culmination of work.

There's little chance of introducing regressions here and in my testing
everything appears to work as expected.

Passing QA and Pushing.. lets see if anything drops out of it when we start to
use the endpoints in earnest :)

Well done everyone!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan  9 17:17:31 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 09 Jan 2020 16:17:31 +0000
Subject: [Koha-bugs] [Bug 24387] New: Rename News tool
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24387

            Bug ID: 24387
           Summary: Rename News tool
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Tools
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: caroline.cyr-la-rose at inlibro.com
        QA Contact: testopia at bugs.koha-community.org

Now that the 'News' tool serves a larger purpose than just adding news, we
should rename it.

I suggest 'Content' or 'Custom content'. But it's just a suggestion. Feel free
to change it to something else.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan  9 17:27:32 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 09 Jan 2020 16:27:32 +0000
Subject: [Koha-bugs] [Bug 18731] Add routes for acquisition orders
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18731

Martin Renvoize  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #96961|0                           |1
        is obsolete|                            |

--- Comment #38 from Martin Renvoize  ---
Created attachment 97107
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97107&action=edit
Bug 18731: Make authenticate_api_request stash the embed structure

Signed-off-by: Kyle M Hall 
Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan  9 17:27:35 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 09 Jan 2020 16:27:35 +0000
Subject: [Koha-bugs] [Bug 18731] Add routes for acquisition orders
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18731

Martin Renvoize  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #96962|0                           |1
        is obsolete|                            |

--- Comment #39 from Martin Renvoize  ---
Created attachment 97108
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97108&action=edit
Bug 18731: Unit tests

This patch implements unit tests for the orders endpoint.

Sponsored-by: Camden County
Signed-off-by: Kyle M Hall 
Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan  9 17:27:39 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 09 Jan 2020 16:27:39 +0000
Subject: [Koha-bugs] [Bug 18731] Add routes for acquisition orders
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18731

Martin Renvoize  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #96963|0                           |1
        is obsolete|                            |

--- Comment #40 from Martin Renvoize  ---
Created attachment 97109
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97109&action=edit
Bug 18731: /acquisitions/orders endpoint

This patches implement the /acquisitions/orders endpoint.

The attribute names are consistent with the voted RFC

To test:
1. Apply this patchset
2. Run:
   $ kshell
  k$ prove t/db_dependent/api/v1/acquisitions_orders.t
=> SUCCESS: Tests pass!
3. Test the API with your favourite tool (Postman?)
=> SUCCESS: It works as expected!
4 Sign off :-D

Sponsored-by: Camden County
Signed-off-by: Matthias Meusburger 
Signed-off-by: Kyle M Hall 
Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan  9 17:27:43 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 09 Jan 2020 16:27:43 +0000
Subject: [Koha-bugs] [Bug 18731] Add routes for acquisition orders
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18731

Martin Renvoize  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #96964|0                           |1
        is obsolete|                            |

--- Comment #41 from Martin Renvoize  ---
Created attachment 97110
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97110&action=edit
Bug 18731: Add API mappings to K::A::{Basket,Invoice}

This patch adds to_api_mapping definitions to the following classes:

- Koha::Acquisition::Basket
- Koha::Acquisition::Invoice

They are implemented following the proposed RFCs:
https://wiki.koha-community.org/wiki/Acquisitions_baskets_endpoint_RFC
https://wiki.koha-community.org/wiki/Acquisitions_invoices_endpoint_RFC

Signed-off-by: Kyle M Hall 
Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan  9 17:27:47 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 09 Jan 2020 16:27:47 +0000
Subject: [Koha-bugs] [Bug 18731] Add routes for acquisition orders
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18731

Martin Renvoize  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #96965|0                           |1
        is obsolete|                            |

--- Comment #42 from Martin Renvoize  ---
Created attachment 97111
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97111&action=edit
Bug 18731: Use the stashed koha.embed in objects.search

This patch makes the objects.search helper use the koha.embed structure
that is embedded in the authenticate_api_request step.

This way, any controller using it will benefit from automatic embed
handling.

To test:
1. Apply this patch
2. Run:
   $ kshell
  k$ prove t/db_dependent/Koha/REST/Plugin/Objects.t
=> SUCCESS: Tests pass!
3. Sign off :-D

Signed-off-by: Kyle M Hall 
Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan  9 17:27:50 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 09 Jan 2020 16:27:50 +0000
Subject: [Koha-bugs] [Bug 18731] Add routes for acquisition orders
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18731

Martin Renvoize  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #96966|0                           |1
        is obsolete|                            |

--- Comment #43 from Martin Renvoize  ---
Created attachment 97112
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97112&action=edit
Bug 18731: OpenAPI definitions

This patch introduces the OpenAPI definitions required for the orders
endpoint. It matches the voted RFC.

Sponsored-by: Camden County
Signed-off-by: Matthias Meusburger 
Signed-off-by: Kyle M Hall 
Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan  9 17:27:54 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 09 Jan 2020 16:27:54 +0000
Subject: [Koha-bugs] [Bug 18731] Add routes for acquisition orders
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18731

--- Comment #44 from Martin Renvoize  ---
Created attachment 97113
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97113&action=edit
Bug 18731: (QA follow-up) Spelling and POD corrections

Just a coulpe of very minor tweaks to keep the QA scripts happy

Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan  9 17:28:57 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 09 Jan 2020 16:28:57 +0000
Subject: [Koha-bugs] [Bug 18731] Add routes for acquisition orders
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18731

Martin Renvoize  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|                            |20.05.00
        released in|                            |
             Status|Passed QA                   |Pushed to master

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan  9 17:28:59 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 09 Jan 2020 16:28:59 +0000
Subject: [Koha-bugs] [Bug 18731] Add routes for acquisition orders
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18731

--- Comment #45 from Martin Renvoize  ---
Nice work everyone!

Pushed to master for 20.05

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan  9 17:30:07 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 09 Jan 2020 16:30:07 +0000
Subject: [Koha-bugs] [Bug 18731] Add routes for acquisition orders
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18731

--- Comment #46 from Chris Slone  ---
This is really great to see! Is it able to be backported to 19.05?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan  9 17:31:00 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 09 Jan 2020 16:31:00 +0000
Subject: [Koha-bugs] [Bug 18731] Add routes for acquisition orders
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18731

Martin Renvoize  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |release-notes-needed

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan  9 17:32:15 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 09 Jan 2020 16:32:15 +0000
Subject: [Koha-bugs] [Bug 24161] Late orders improvements - keeping track of
 claims
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24161

Jonathan Druart  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan  9 17:32:19 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 09 Jan 2020 16:32:19 +0000
Subject: [Koha-bugs] [Bug 24161] Late orders improvements - keeping track of
 claims
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24161

--- Comment #1 from Jonathan Druart  ---
Created attachment 97114
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97114&action=edit
Bug 24161: DB changes

Sponsored-by: Cork Institute of Technology

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan  9 17:32:23 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 09 Jan 2020 16:32:23 +0000
Subject: [Koha-bugs] [Bug 24161] Late orders improvements - keeping track of
 claims
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24161

--- Comment #2 from Jonathan Druart  ---
Created attachment 97115
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97115&action=edit
Bug 24161: DBIC changes

Sponsored-by: Cork Institute of Technology

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan  9 17:32:27 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 09 Jan 2020 16:32:27 +0000
Subject: [Koha-bugs] [Bug 24161] Late orders improvements - keeping track of
 claims
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24161

--- Comment #3 from Jonathan Druart  ---
Created attachment 97116
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97116&action=edit
Bug 24161: Add the Koha::Acquisition::Order::Claim[s] classes

Sponsored-by: Cork Institute of Technology

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan  9 17:32:30 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 09 Jan 2020 16:32:30 +0000
Subject: [Koha-bugs] [Bug 24161] Late orders improvements - keeping track of
 claims
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24161

--- Comment #4 from Jonathan Druart  ---
Created attachment 97117
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97117&action=edit
Bug 24161: Keep tracks of late orders claims

So far we only record the number of claims and the date of the last
claim, in the aqorders table.
To keep track of the different claim dates, this patchset is going to
make the following DB changes:
  * Create a new table 'aqorders_claims' (id, ordernumber, claimed_on)
  * Remove the two columns from the aqorders table: claims_count and
  claimed_date

This will allow to display the different claim dates where needed: on
the late orders page, and the basket page.

To avoid additional fetches of Koha::Acquisition::Orders, GetLateOrders
has been moved to Koha::Acquisition::Orders->filter_by_late
That way we are going to add consistency, robustness, and cover the
feature with new tests.

Test plan:
0/ Create a bunch of new orders. Make sure they are from different
vendor (with different delivery time).
1/ Go to the late orders page and claim some orders
2/ Reclaim some of those orders
3/ Confirm that you can see the different claim dates for a given orders
(the history of the late orders claims is kept and displayed)

4/ Bonus point: Regression tests:

a. Modify the closedate of the basket in the database. That
will allow you to make sure the patch set did not introduce regressions.
It would be good to test the different filters on the late orders page:
 * delay
 * Estimated delivery date from/to
 * Vendor

b. Confirm that the subtotal and the total values from the late orders
page is correct.

c. Test the update database entry: do not apply these patches, claims
some orders against master. Apply the patch, execute the update DB entry
then confirm that the number of claims is correct (note that the dates
will not as it is not possible to guess them).

QA note: the branchcode parameter has been removed from filter_by_late.
At first glance it seems that it was not used.

Sponsored-by: Cork Institute of Technology

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan  9 17:32:34 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 09 Jan 2020 16:32:34 +0000
Subject: [Koha-bugs] [Bug 24161] Late orders improvements - keeping track of
 claims
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24161

--- Comment #5 from Jonathan Druart  ---
Created attachment 97118
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97118&action=edit
Bug 24161: Remove GetLateOrders

Sponsored-by: Cork Institute of Technology

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan  9 17:32:38 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 09 Jan 2020 16:32:38 +0000
Subject: [Koha-bugs] [Bug 24161] Late orders improvements - keeping track of
 claims
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24161

--- Comment #6 from Jonathan Druart  ---
Created attachment 97119
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97119&action=edit
Bug 24161: Add tests

Sponsored-by: Cork Institute of Technology

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan  9 17:33:57 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 09 Jan 2020 16:33:57 +0000
Subject: [Koha-bugs] [Bug 24161] Late orders improvements - keeping track of
 claims
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24161

Jonathan Druart  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |12502


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12502
[Bug 12502] Add columns for note, order number and ISBN to late orders page
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan  9 17:33:57 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 09 Jan 2020 16:33:57 +0000
Subject: [Koha-bugs] [Bug 12502] Add columns for note,
 order number and ISBN to late orders page
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12502

Jonathan Druart  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |24161


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24161
[Bug 24161] Late orders improvements - keeping track of claims
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan  9 17:34:05 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 09 Jan 2020 16:34:05 +0000
Subject: [Koha-bugs] [Bug 24255] Add totals methods Koha::Account::Lines
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24255

Martin Renvoize  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|                            |20.05.00
        released in|                            |
             Status|Passed QA                   |Pushed to master

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan  9 17:34:07 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 09 Jan 2020 16:34:07 +0000
Subject: [Koha-bugs] [Bug 24255] Add totals methods Koha::Account::Lines
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24255

--- Comment #6 from Martin Renvoize  ---
Nice work everyone!

Pushed to master for 20.05

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan  9 17:34:09 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 09 Jan 2020 16:34:09 +0000
Subject: [Koha-bugs] [Bug 24257] item-transfer-modal does not initiate
 transfer when 'yes, print slip' is selected
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24257

Martin Renvoize  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to master
         Version(s)|                            |20.05.00
        released in|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan  9 17:34:10 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 09 Jan 2020 16:34:10 +0000
Subject: [Koha-bugs] [Bug 24257] item-transfer-modal does not initiate
 transfer when 'yes, print slip' is selected
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24257

--- Comment #6 from Martin Renvoize  ---
Nice work everyone!

Pushed to master for 20.05

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan  9 17:37:00 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 09 Jan 2020 16:37:00 +0000
Subject: [Koha-bugs] [Bug 24387] Rename News tool
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24387

--- Comment #1 from Owen Leonard  ---
Maybe "News and content" ?

It's technically redundant but I worry that people will wonder where News went.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan  9 17:40:26 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 09 Jan 2020 16:40:26 +0000
Subject: [Koha-bugs] [Bug 23893] Add ->new_from_api and ->set_from_api
 methods to Koha::Object
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23893

Martin Renvoize  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
          Component|Architecture, internals,    |REST API
                   |and plumbing                |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan  9 17:40:39 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 09 Jan 2020 16:40:39 +0000
Subject: [Koha-bugs] [Bug 24228] Add a parameter to recursively embed
 objects in Koha::Object(s)->to_api
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24228

Martin Renvoize  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
          Component|Architecture, internals,    |REST API
                   |and plumbing                |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan  9 17:43:04 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 09 Jan 2020 16:43:04 +0000
Subject: [Koha-bugs] [Bug 24252] Add credits, debits,
 credit_offsets and debit_offsets relationships to
 Koha::Account::Line
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24252

Martin Renvoize  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Text to go in the|                            |This enhancement allows for
      release notes|                            |fetching related credits,
                   |                            |debits and offsets directly
                   |                            |from an existing
                   |                            |Koha::Account::Line object
                   |                            |and includes compatibility
                   |                            |for prefetching of
                   |                            |relations for performance.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan  9 17:46:58 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 09 Jan 2020 16:46:58 +0000
Subject: [Koha-bugs] [Bug 24255] Add totals methods Koha::Account::Lines
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24255

Martin Renvoize  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Text to go in the|                            |This enhancement completes
      release notes|                            |the set of summation
                   |                            |methods available from a
                   |                            |Koha::Account::Lines
                   |                            |resultset object,
                   |                            |complimenting the existing
                   |                            |`total_outstanding` method.
                   |                            |
                   |                            |It introduces the
                   |                            |following methods:
                   |                            |
                   |                            |`total`
                   |                            |- Sum of all `amount`
                   |                            |fields in the accountlines
                   |                            |set.
                   |                            |`credits_total` - Sum
                   |                            |of all `amount` fields for
                   |                            |credits in the accountlines
                   |                            |set.
                   |                            |`debits_total` - Sum
                   |                            |of all `amount` fields for
                   |                            |debits in the accountlines
                   |                            |set.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan  9 17:47:03 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 09 Jan 2020 16:47:03 +0000
Subject: [Koha-bugs] [Bug 24163] Ability to define a CSV profile for late
 orders export
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24163

Jonathan Druart  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan  9 17:47:07 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 09 Jan 2020 16:47:07 +0000
Subject: [Koha-bugs] [Bug 24163] Ability to define a CSV profile for late
 orders export
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24163

--- Comment #1 from Jonathan Druart  ---
Created attachment 97120
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97120&action=edit
Bug 24163: Allow to define CSV profile for late orders export

This new enhancement adds the ability to create a CSV profile for the late
orders export.
Prior to this, the CSV profile was hardcoded in a template and not
editable (unless you modify the .tt file of course).

The main difficulty of the request was to make the multiple claims dates
accessible from the CSV profile. So far we only accept columns from the
database. However we would like to use the Koha::Acquisition::Order
object to make things easier (it had a ->claims method to access the
different claims).
To acchieve this, we are going to accept the TT syntax for that CSV profile.
It means that only CSV profiles created for 'late_orders' will have the
capability to use the TT syntax (can be extended later of course if
needed).
The alternative was to use specific placeholders, like %claims_count%,
%claimed_date%, but it sounded more powerful and flexible to allow the
TT syntax instead.

Note that the former export (template based) still exists and is the
default option.

Test plan:
0. Apply the patches and execute the update database entry
1. Create some orders, close the basket
2. Claim some of the orders
3. Note the new button at the bottom of the table that have several
entries.
=> The first entry will generate a CSV file using the previous method
=> The second entry will generate it using the new CSV profile, note
that the number of claims as well as the different claims date are
displayed.

4. Bonus point: Edit the CSV profile (Home › Tools › CSV export
profiles) that is named "Late orders (csv profile)", or create a new
one, and modify it.
Export the late orders using this CSV profile and confirm that the
generated CSV file is the one you expect.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan  9 17:47:10 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 09 Jan 2020 16:47:10 +0000
Subject: [Koha-bugs] [Bug 24163] Ability to define a CSV profile for late
 orders export
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24163

--- Comment #2 from Jonathan Druart  ---
Created attachment 97121
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97121&action=edit
Bug 24163: Add the csv into the DB - as an example

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan  9 17:49:02 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 09 Jan 2020 16:49:02 +0000
Subject: [Koha-bugs] [Bug 24163] Ability to define a CSV profile for late
 orders export
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24163

Jonathan Druart  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #97120|0                           |1
        is obsolete|                            |
  Attachment #97121|0                           |1
        is obsolete|                            |

--- Comment #3 from Jonathan Druart  ---
Created attachment 97122
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97122&action=edit
Bug 24163: Allow to define CSV profile for late orders export

This new enhancement adds the ability to create a CSV profile for the late
orders export.
Prior to this, the CSV profile was hardcoded in a template and not
editable (unless you modify the .tt file of course).

The main difficulty of the request was to make the multiple claims dates
accessible from the CSV profile. So far we only accept columns from the
database. However we would like to use the Koha::Acquisition::Order
object to make things easier (it had a ->claims method to access the
different claims).
To acchieve this, we are going to accept the TT syntax for that CSV profile.
It means that only CSV profiles created for 'late_orders' will have the
capability to use the TT syntax (can be extended later of course if
needed).
The alternative was to use specific placeholders, like %claims_count%,
%claimed_date%, but it sounded more powerful and flexible to allow the
TT syntax instead.

Note that the former export (template based) still exists and is the
default option.

Test plan:
0. Apply the patches and execute the update database entry
1. Create some orders, close the basket
2. Claim some of the orders
3. Note the new button at the bottom of the table that have several
entries.
=> The first entry will generate a CSV file using the previous method
=> The second entry will generate it using the new CSV profile, note
that the number of claims as well as the different claims date are
displayed.

4. Bonus point: Edit the CSV profile (Home › Tools › CSV export
profiles) that is named "Late orders (csv profile)", or create a new
one, and modify it.
Export the late orders using this CSV profile and confirm that the
generated CSV file is the one you expect.

Sponsored-by: Institute of Technology Tralee

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan  9 17:49:05 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 09 Jan 2020 16:49:05 +0000
Subject: [Koha-bugs] [Bug 24163] Ability to define a CSV profile for late
 orders export
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24163

--- Comment #4 from Jonathan Druart  ---
Created attachment 97123
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97123&action=edit
Bug 24163: Add the csv into the DB - as an example

Sponsored-by: Institute of Technology Tralee

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan  9 17:49:13 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 09 Jan 2020 16:49:13 +0000
Subject: [Koha-bugs] [Bug 24161] Late orders improvements - keeping track of
 claims
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24161

Jonathan Druart  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|24162                       |24163


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24162
[Bug 24162] Late orders improvements - display new columns
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24163
[Bug 24163] Ability to define a CSV profile for late orders export
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan  9 17:49:13 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 09 Jan 2020 16:49:13 +0000
Subject: [Koha-bugs] [Bug 24162] Late orders improvements - display new
 columns
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24162

Jonathan Druart  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|24161                       |


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24161
[Bug 24161] Late orders improvements - keeping track of claims
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan  9 17:49:13 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 09 Jan 2020 16:49:13 +0000
Subject: [Koha-bugs] [Bug 24163] Ability to define a CSV profile for late
 orders export
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24163

Jonathan Druart  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |24161


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24161
[Bug 24161] Late orders improvements - keeping track of claims
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan  9 17:49:26 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 09 Jan 2020 16:49:26 +0000
Subject: [Koha-bugs] [Bug 24163] Ability to define a CSV profile for late
 orders export
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24163

Jonathan Druart  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |24162
         Depends on|24162                       |


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24162
[Bug 24162] Late orders improvements - display new columns
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan  9 17:49:26 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 09 Jan 2020 16:49:26 +0000
Subject: [Koha-bugs] [Bug 24162] Late orders improvements - display new
 columns
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24162

Jonathan Druart  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|24163                       |
         Depends on|                            |24163


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24163
[Bug 24163] Ability to define a CSV profile for late orders export
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan  9 17:50:27 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 09 Jan 2020 16:50:27 +0000
Subject: [Koha-bugs] [Bug 24255] Add totals methods Koha::Account::Lines
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24255

Martin Renvoize  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Text to go in the|This enhancement completes  |This enhancement completes
      release notes|the set of summation        |the set of summation
                   |methods available from a    |methods available from a
                   |Koha::Account::Lines        |Koha::Account::Lines
                   |resultset object,           |resultset object,
                   |complimenting the existing  |complimenting the existing
                   |`total_outstanding` method. |`total_outstanding` method.
                   |
                           |
                   |It introduces the           |It introduces the
                   |following methods:
         |following methods:
                   |
                           |
                   |`total`                     |*
                   |- Sum of all `amount`       |`total` - Sum of all
                   |fields in the accountlines  |`amount` fields in the
                   |set.
                       |accountlines set.
                   |`credits_total` - Sum       |*
                   |of all `amount` fields for  |`credits_total` - Sum of
                   |credits in the accountlines |all `amount` fields for
                   |set.
                       |credits in the accountlines
                   |`debits_total` - Sum        |set.
                   |of all `amount` fields for  |* `debits_total` - Sum
                   |debits in the accountlines  |of all `amount` fields for
                   |set.                        |debits in the accountlines
                   |                            |set.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan  9 17:51:35 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 09 Jan 2020 16:51:35 +0000
Subject: [Koha-bugs] [Bug 24162] Late orders improvements - display new
 columns
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24162

Jonathan Druart  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan  9 17:51:38 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 09 Jan 2020 16:51:38 +0000
Subject: [Koha-bugs] [Bug 24162] Late orders improvements - display new
 columns
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24162

--- Comment #2 from Jonathan Druart  ---
Created attachment 97124
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97124&action=edit
Bug 24162: Add quantity column to the late orders page

This patch add a new column "quantity" to the late orders page

Test plan:
1. Create some orders, close the basket
2. Go to the "Late orders" page
=> You should see a new column "quantity" that contains the number of
items of the order

Sponsored-by: Cork Institute of Technology

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan  9 17:52:58 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 09 Jan 2020 16:52:58 +0000
Subject: [Koha-bugs] [Bug 24388] New: Unless test in acqui/lateorders.tt
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24388

            Bug ID: 24388
           Summary: Unless test in acqui/lateorders.tt
 Change sponsored?: ---
           Product: Koha
           Version: unspecified
          Hardware: All
                OS: All
            Status: ASSIGNED
          Severity: minor
          Priority: P5 - low
         Component: Architecture, internals, and plumbing
          Assignee: jonathan.druart at bugs.koha-community.org
          Reporter: jonathan.druart at bugs.koha-community.org
        QA Contact: testopia at bugs.koha-community.org
        Depends on: 24162

The budget_lock is never set (and has never been):

        [% UNLESS lateorder.budget_lock %]
            
        [% END %]


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24162
[Bug 24162] Late orders improvements - display new columns
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan  9 17:52:58 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 09 Jan 2020 16:52:58 +0000
Subject: [Koha-bugs] [Bug 24162] Late orders improvements - display new
 columns
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24162

Jonathan Druart  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |24388


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24388
[Bug 24388] Unless test in acqui/lateorders.tt
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan  9 17:54:09 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 09 Jan 2020 16:54:09 +0000
Subject: [Koha-bugs] [Bug 24388] Unless test in acqui/lateorders.tt
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24388

Jonathan Druart  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan  9 17:54:12 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 09 Jan 2020 16:54:12 +0000
Subject: [Koha-bugs] [Bug 24388] Unless test in acqui/lateorders.tt
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24388

--- Comment #1 from Jonathan Druart  ---
Created attachment 97125
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97125&action=edit
Bug 24388: Remove uneeded test in lateorders.tt

The budget_lock is never set (and has never been).

Test plan:
For QAer only, make sure this never worked

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan  9 17:56:00 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 09 Jan 2020 16:56:00 +0000
Subject: [Koha-bugs] [Bug 21959] Batch item modification - ability to apply
 regular expression on text fields
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21959

--- Comment #32 from Martin Renvoize  ---
Nice work everyone!

Pushed to master for 20.05

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan  9 18:01:25 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 09 Jan 2020 17:01:25 +0000
Subject: [Koha-bugs] [Bug 24389] New: Claiming an order can display an
 invalid successful message
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24389

            Bug ID: 24389
           Summary: Claiming an order can display an invalid successful
                    message
 Change sponsored?: ---
           Product: Koha
           Version: unspecified
          Hardware: All
                OS: All
            Status: ASSIGNED
          Severity: major
          Priority: P5 - low
         Component: Acquisitions
          Assignee: jonathan.druart at bugs.koha-community.org
          Reporter: jonathan.druart at bugs.koha-community.org
        QA Contact: testopia at bugs.koha-community.org

If the vendor does not have a valid contact (like no email), a successful
message is displayed ("Email has been sent.") whereas nothing was done!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan  9 18:01:46 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 09 Jan 2020 17:01:46 +0000
Subject: [Koha-bugs] [Bug 24388] Useless test in acqui/lateorders.tt
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24388

Jonathan Druart  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Unless test in              |Useless test in
                   |acqui/lateorders.tt         |acqui/lateorders.tt

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan  9 18:02:15 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 09 Jan 2020 17:02:15 +0000
Subject: [Koha-bugs] [Bug 24369] Add ability to set CORS header in Koha
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24369

Martin Renvoize  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |andrew.isherwood at ptfs-europ
                   |                            |e.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan  9 18:06:03 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 09 Jan 2020 17:06:03 +0000
Subject: [Koha-bugs] [Bug 24390] New: Add Item Total to Rotating collections
 (addItems.tt)
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24390

            Bug ID: 24390
           Summary: Add Item Total to Rotating collections (addItems.tt)
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Tools
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: lucas at bywatersolutions.com
        QA Contact: testopia at bugs.koha-community.org

Some librarians would find it handy if they could see the total number of items
in each rotating collection.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan  9 18:06:10 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 09 Jan 2020 17:06:10 +0000
Subject: [Koha-bugs] [Bug 24390] Add Item Total to Rotating collections
 (addItems.tt)
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24390

Lucas Gass  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |lucas at bywatersolutions.com
                   |ity.org                     |

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan  9 18:06:35 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 09 Jan 2020 17:06:35 +0000
Subject: [Koha-bugs] [Bug 24389] Claiming an order can display an invalid
 successful message
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24389

Jonathan Druart  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan  9 18:06:38 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 09 Jan 2020 17:06:38 +0000
Subject: [Koha-bugs] [Bug 24389] Claiming an order can display an invalid
 successful message
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24389

--- Comment #1 from Jonathan Druart  ---
Created attachment 97126
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97126&action=edit
Bug 24389: Better error handle when claiming late orders

A successful message says that the email has been sent and the order has
been claimed, but nothing happened.

Test plan:
0. Do not apply this patch
1. Create a new vendor, does not create a contact
2. Create some orders, close the basket
3. Go to the late orders page and claims some orders
=> You get a successful message, but the claim has not been done!
4. Apply this patch
5. Claim the orders
=> You get an error
6. Set a contact for the vendor
7. Claim the orders
=> Success

In the docker container, you may need to:
% apt install postfix
% postfix start
Edit /etc/hosts
127.0.0.1       localhost localhost.localdomain

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan  9 18:10:50 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 09 Jan 2020 17:10:50 +0000
Subject: [Koha-bugs] [Bug 24390] Add Item Total to Rotating collections
 (addItems.tt)
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24390

Lucas Gass  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan  9 18:10:52 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 09 Jan 2020 17:10:52 +0000
Subject: [Koha-bugs] [Bug 24390] Add Item Total to Rotating collections
 (addItems.tt)
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24390

--- Comment #1 from Lucas Gass  ---
Created attachment 97127
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97127&action=edit
Bug 24390: Add Item Total to Rotating collections

TEST PLAN:
1. Set up some rotating collections and add some items to them.
2. No good way to see how many total items are in a given collection.
3. Apply patch
4. Look at collections again and you should see 'Total Items: X'
5. Make sure it is counting the total number of items correctly.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan  9 18:28:46 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 09 Jan 2020 17:28:46 +0000
Subject: [Koha-bugs] [Bug 24381] ACCOUNT_CREDIT slip not printing
 information about paid fines/fees
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24381

Martin Renvoize  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |martin.renvoize at ptfs-europe
                   |                            |.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan  9 18:31:47 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 09 Jan 2020 17:31:47 +0000
Subject: [Koha-bugs] [Bug 1807] search () give odd results with Zebra and ICU
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1807

Martin Renvoize  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |martin.renvoize at ptfs-europe
                   |                            |.com
            Summary|search () give odd results  |search () give odd results
                   |                            |with Zebra and ICU

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan  9 18:31:54 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 09 Jan 2020 17:31:54 +0000
Subject: [Koha-bugs] [Bug 1807] search () give odd results with Zebra and ICU
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1807

Martin Renvoize  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|major                       |normal

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan  9 18:35:04 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 09 Jan 2020 17:35:04 +0000
Subject: [Koha-bugs] [Bug 24043] ILL module can't show requests from more
 than one backend
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24043

Martin Renvoize  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |martin.renvoize at ptfs-europe
                   |                            |.com

--- Comment #4 from Martin Renvoize  ---
Sounds like this works in master then.. did you work out what fixed it and does
that need backporting Magnus.. or can this one be closed?

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan  9 18:35:23 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 09 Jan 2020 17:35:23 +0000
Subject: [Koha-bugs] [Bug 24043] ILL module can't show requests from more
 than one backend
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24043

Martin Renvoize  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |andrew.isherwood at ptfs-europ
                   |                            |e.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan  9 18:44:58 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 09 Jan 2020 17:44:58 +0000
Subject: [Koha-bugs] [Bug 24391] New: Remove event attributes from patron
 clubs templates
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24391

            Bug ID: 24391
           Summary: Remove event attributes from patron clubs templates
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
               URL: /cgi-bin/koha/clubs/templates-add-modify.pl
                OS: All
            Status: ASSIGNED
          Severity: normal
          Priority: P5 - low
         Component: Templates
          Assignee: oleonard at myacpl.org
          Reporter: oleonard at myacpl.org
        QA Contact: testopia at bugs.koha-community.org
                CC: testopia at bugs.koha-community.org
        Depends on: 18530

The template for adding/editing patron clubs has several instances of
"onclick," in violation of coding guidelines.

https://wiki.koha-community.org/wiki/Coding_Guidelines#JS9:_Avoid_the_use_of_event_attributes_like_.22onclick.22_to_attach_events

They should be removed in favor of defining events in JavaScript instead of
markup.


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18530
[Bug 18530] Remove event attributes from patron clubs templates
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan  9 18:44:58 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 09 Jan 2020 17:44:58 +0000
Subject: [Koha-bugs] [Bug 18530] Remove event attributes from patron clubs
 templates
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18530

Owen Leonard  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |24391


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24391
[Bug 24391] Remove event attributes from patron clubs templates
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan  9 18:54:44 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 09 Jan 2020 17:54:44 +0000
Subject: [Koha-bugs] [Bug 24391] Remove event attributes from patron clubs
 templates
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24391

Owen Leonard  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff
   Patch complexity|---                         |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan  9 18:54:47 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 09 Jan 2020 17:54:47 +0000
Subject: [Koha-bugs] [Bug 24391] Remove event attributes from patron clubs
 templates
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24391

--- Comment #1 from Owen Leonard  ---
Created attachment 97128
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97128&action=edit
Bug 24391: Remove event attributes from patron clubs templates

This patch removes "onclick" attributes from the template for adding and
editing patron club templates.

To test, apply the patch and go to Tools -> Patron clubs -> New club
template.

Test the process of adding and deleting both club and enrollment fields.
Test during the template add process and when editing an existing
template.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan  9 19:14:26 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 09 Jan 2020 18:14:26 +0000
Subject: [Koha-bugs] [Bug 15504] Track Patron's Last Activity
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15504

--- Comment #10 from Christopher Brannon  ---
(In reply to Agnes Rivers-Moore from comment #9)
> Some label suggestions - last-login (OPAC or self-checkout), updated (patron
> details changed through OPAC or Intranet), last-activity (activity from any
> channel including SIP), remote-use (outside resource SIP connections and
> OPAC login). 
> Just suggestions, for wider discussion.

I'm concerned with over complicating the information.  In my opinion, there are
a couple things we want to track here:

* Patron record modification
* Patron activity (login/checkouts through any connection)

Timestamps are generic, and a catch-all.  That is good for logs, but the two
above are more specific.  These are two that need to be recorded in the patron
record, that we don't have to scrounge for in logs that are not necessarily
recorded, or are purged on a regular basis.

I'm not sure about last-activity or remote-use.  Those are a little more
granular and bleed over into the other two mentioned above and might make it
more confusing.  But this is my opinion.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan  9 19:14:52 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 09 Jan 2020 18:14:52 +0000
Subject: [Koha-bugs] [Bug 24391] Remove event attributes from patron clubs
 edit template
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24391

Owen Leonard  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Remove event attributes     |Remove event attributes
                   |from patron clubs templates |from patron clubs edit
                   |                            |template

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan  9 19:31:57 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 09 Jan 2020 18:31:57 +0000
Subject: [Koha-bugs] [Bug 13897] Use YAML files for installer data
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13897

--- Comment #48 from Bernardo Gonzalez Kriegel  ---
(In reply to Jonathan Druart from comment #46)
> From the YAML file:
> +description:
> +  - "Some basic default authorised values for library locations, item lost
> status, etc."
> +  - "You can change these at any time after installation."
> 
> This is what need to be used for translation.

Yes, of course. 
In Bug 24262 I catch those strings so they can be translated.
In Comment #26 Jonathan suggested that txt file content could be moved into the
yaml files, that's what I did
Then I changed Bug 24262 accordingly

C4/Installer.pm it's changed to show the description from the yaml, current
behaviour is preserved.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan  9 19:39:02 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 09 Jan 2020 18:39:02 +0000
Subject: [Koha-bugs] [Bug 15504] Track Patron's Last Activity
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15504

--- Comment #11 from Agnes Rivers-Moore  ---
Agree with Christopher about the library activities - we just want the labels
to clearly describe what activity sets the timestamp.
To clarify - Martha and I definitely want the SIP2 activity to be tracked
separately from checkouts, because SIP2 includes activities that are outside
Koha circulation.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan  9 19:55:00 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 09 Jan 2020 18:55:00 +0000
Subject: [Koha-bugs] [Bug 15504] Track Patron's Last Activity
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15504

--- Comment #12 from Christopher Brannon  ---
So maybe:

* Patron record modification
* Any patron activity (login/checkouts through any connection)
* SIP patron activity (part of previous count)

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan  9 20:00:22 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 09 Jan 2020 19:00:22 +0000
Subject: [Koha-bugs] [Bug 23974] hours_between and days_between lack tests
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23974

Tomás Cohen Arazi  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan  9 20:00:24 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 09 Jan 2020 19:00:24 +0000
Subject: [Koha-bugs] [Bug 23974] hours_between and days_between lack tests
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23974

Tomás Cohen Arazi  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #96778|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan  9 20:00:27 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 09 Jan 2020 19:00:27 +0000
Subject: [Koha-bugs] [Bug 23974] hours_between and days_between lack tests
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23974

Tomás Cohen Arazi  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #96779|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan  9 20:00:29 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 09 Jan 2020 19:00:29 +0000
Subject: [Koha-bugs] [Bug 23974] hours_between and days_between lack tests
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23974

Tomás Cohen Arazi  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #96780|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan  9 20:00:31 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 09 Jan 2020 19:00:31 +0000
Subject: [Koha-bugs] [Bug 23974] hours_between and days_between lack tests
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23974

Tomás Cohen Arazi  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #96781|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan  9 20:00:34 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 09 Jan 2020 19:00:34 +0000
Subject: [Koha-bugs] [Bug 23974] hours_between and days_between lack tests
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23974

Tomás Cohen Arazi  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #96782|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan  9 20:00:36 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 09 Jan 2020 19:00:36 +0000
Subject: [Koha-bugs] [Bug 23974] hours_between and days_between lack tests
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23974

Tomás Cohen Arazi  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #96783|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan  9 20:00:38 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 09 Jan 2020 19:00:38 +0000
Subject: [Koha-bugs] [Bug 23974] hours_between and days_between lack tests
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23974

Tomás Cohen Arazi  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #96784|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan  9 20:00:41 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 09 Jan 2020 19:00:41 +0000
Subject: [Koha-bugs] [Bug 23974] hours_between and days_between lack tests
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23974

Tomás Cohen Arazi  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #96785|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan  9 20:00:43 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 09 Jan 2020 19:00:43 +0000
Subject: [Koha-bugs] [Bug 23974] hours_between and days_between lack tests
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23974

Tomás Cohen Arazi  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #96786|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan  9 20:03:31 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 09 Jan 2020 19:03:31 +0000
Subject: [Koha-bugs] [Bug 24392] New: Leading whitespaces in Marc fields
 cause errors
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24392

            Bug ID: 24392
           Summary: Leading whitespaces in Marc fields cause errors
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: MARC Bibliographic data support
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: cbrannon at cdalibrary.org
        QA Contact: testopia at bugs.koha-community.org

We've discovered that leading whitespaces in at least the 947h field have
caused error messages on bib records (detail.pl), and lists linked to the
record to fail to load (shelves.pl).  Perhaps there should be something in
place to either warn or automatically strip leading/trailing whitespaces on
these fields, or something done to prevent these whitespaces from breaking
things.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan  9 20:04:59 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 09 Jan 2020 19:04:59 +0000
Subject: [Koha-bugs] [Bug 23974] hours_between and days_between lack tests
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23974

--- Comment #36 from Tomás Cohen Arazi  ---
Created attachment 97129
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97129&action=edit
Bug 23974: Improve readability

This patch does not change anything, just a bit of cleaning

Signed-off-by: Martin Renvoize 

Signed-off-by: Katrin Fischer 
Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan  9 20:05:03 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 09 Jan 2020 19:05:03 +0000
Subject: [Koha-bugs] [Bug 23974] hours_between and days_between lack tests
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23974

--- Comment #37 from Tomás Cohen Arazi  ---
Created attachment 97130
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97130&action=edit
Bug 23974: Add new tests for hours_between

Signed-off-by: Martin Renvoize 

Signed-off-by: Katrin Fischer 
Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan  9 20:05:06 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 09 Jan 2020 19:05:06 +0000
Subject: [Koha-bugs] [Bug 23974] hours_between and days_between lack tests
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23974

--- Comment #38 from Tomás Cohen Arazi  ---
Created attachment 97131
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97131&action=edit
Bug 23974: Add tests for days_between

Signed-off-by: Martin Renvoize 

Signed-off-by: Katrin Fischer 
Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan  9 20:05:10 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 09 Jan 2020 19:05:10 +0000
Subject: [Koha-bugs] [Bug 23974] hours_between and days_between lack tests
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23974

--- Comment #39 from Tomás Cohen Arazi  ---
Created attachment 97132
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97132&action=edit
Bug 23974: both methods should have the same logic/construction

Signed-off-by: Martin Renvoize 

Signed-off-by: Katrin Fischer 
Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan  9 20:05:13 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 09 Jan 2020 19:05:13 +0000
Subject: [Koha-bugs] [Bug 23974] hours_between and days_between lack tests
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23974

--- Comment #40 from Tomás Cohen Arazi  ---
Created attachment 97133
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97133&action=edit
Bug 23974: (follow-up) Add same day loan tests

Hourly loans can be short enough to not cross a day boundary and as such
we should test for that scenario in the hour_between tests too.

Signed-off-by: Martin Renvoize 

Signed-off-by: Katrin Fischer 
Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan  9 20:05:17 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 09 Jan 2020 19:05:17 +0000
Subject: [Koha-bugs] [Bug 23974] hours_between and days_between lack tests
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23974

--- Comment #41 from Tomás Cohen Arazi  ---
Created attachment 97134
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97134&action=edit
Bug 23974: Add POD for hours_between

Add a bit of missing POD whilst we're working in here

Signed-off-by: Katrin Fischer 
Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan  9 20:05:21 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 09 Jan 2020 19:05:21 +0000
Subject: [Koha-bugs] [Bug 23974] hours_between and days_between lack tests
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23974

--- Comment #42 from Tomás Cohen Arazi  ---
Created attachment 97135
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97135&action=edit
Bug 23974: Test Notes

Signed-off-by: Katrin Fischer 
Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan  9 20:05:24 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 09 Jan 2020 19:05:24 +0000
Subject: [Koha-bugs] [Bug 23974] hours_between and days_between lack tests
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23974

--- Comment #43 from Tomás Cohen Arazi  ---
Created attachment 97136
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97136&action=edit
Bug 23974: Add tests for issue on closed day

Signed-off-by: Katrin Fischer 
Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan  9 20:05:28 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 09 Jan 2020 19:05:28 +0000
Subject: [Koha-bugs] [Bug 23974] hours_between and days_between lack tests
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23974

--- Comment #44 from Tomás Cohen Arazi  ---
Created attachment 97137
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97137&action=edit
Bug 23974: Add test descriptions

Signed-off-by: Katrin Fischer 
Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan  9 20:05:48 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 09 Jan 2020 19:05:48 +0000
Subject: [Koha-bugs] [Bug 18530] Remove event attributes from patron clubs
 templates
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18530

Owen Leonard  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #83771|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan  9 20:06:15 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 09 Jan 2020 19:06:15 +0000
Subject: [Koha-bugs] [Bug 18530] Remove event attributes from patron clubs
 templates
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18530

Owen Leonard  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |ASSIGNED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan  9 20:08:35 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 09 Jan 2020 19:08:35 +0000
Subject: [Koha-bugs] [Bug 24393] New: Remove event attributes from patron
 clubs list template
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24393

            Bug ID: 24393
           Summary: Remove event attributes from patron clubs list
                    template
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
               URL: /cgi-bin/koha/clubs/clubs.pl
                OS: All
            Status: ASSIGNED
          Severity: normal
          Priority: P5 - low
         Component: Templates
          Assignee: oleonard at myacpl.org
          Reporter: oleonard at myacpl.org
        QA Contact: testopia at bugs.koha-community.org
                CC: testopia at bugs.koha-community.org
        Depends on: 18530

The template for the main list of patron clubs has some instances of "onclick,"
in violation of coding guidelines.

https://wiki.koha-community.org/wiki/Coding_Guidelines#JS9:_Avoid_the_use_of_event_attributes_like_.22onclick.22_to_attach_events

They should be removed in favor of defining events in JavaScript instead of
markup.


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18530
[Bug 18530] Remove event attributes from patron clubs templates
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan  9 20:08:35 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 09 Jan 2020 19:08:35 +0000
Subject: [Koha-bugs] [Bug 18530] Remove event attributes from patron clubs
 templates
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18530

Owen Leonard  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |24393


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24393
[Bug 24393] Remove event attributes from patron clubs list template
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan  9 20:21:21 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 09 Jan 2020 19:21:21 +0000
Subject: [Koha-bugs] [Bug 24123] bulkmarcimport.pl doesn't support UTF-8
 encoded MARCXML records
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24123

Tomás Cohen Arazi  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA
                 CC|                            |tomascohen at gmail.com
   Patch complexity|---                         |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan  9 20:21:23 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 09 Jan 2020 19:21:23 +0000
Subject: [Koha-bugs] [Bug 24123] bulkmarcimport.pl doesn't support UTF-8
 encoded MARCXML records
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24123

Tomás Cohen Arazi  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #96967|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan  9 20:23:19 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 09 Jan 2020 19:23:19 +0000
Subject: [Koha-bugs] [Bug 24123] bulkmarcimport.pl doesn't support UTF-8
 encoded MARCXML records
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24123

Tomás Cohen Arazi  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         QA Contact|                            |tomascohen at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan  9 20:24:25 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 09 Jan 2020 19:24:25 +0000
Subject: [Koha-bugs] [Bug 24123] bulkmarcimport.pl doesn't support UTF-8
 encoded MARCXML records
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24123

--- Comment #5 from Tomás Cohen Arazi  ---
Created attachment 97138
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97138&action=edit
Bug 24123: Fix import of UTF-8 encoded MARC21 MARCXML using bulkmarcimport
(elastic only)

If elastic is used as search engine, the bulkmarcimport.pl will not
handle correctly UTF-8 encoded MARCXML

Koha::SearchEngine::Search->new uses a require statement to load the correct
Search module.
This is done l.257 of bulkmarcimport.pl:
  257 my $searcher = Koha::SearchEngine::Search->new

Koha::SearchEngine::Elasticsearch::Search will `use MARC::File::XML`, and so
resets the arguments set before:
  216     $MARC::File::XML::_load_args{BinaryEncoding} = 'utf-8';

  220     $MARC::File::XML::_load_args{RecordFormat} = $recordformat;

An easy (but dirty) fix could be to move the declaration of my $searcher before
in the script.
The tricky (but correct) fix would be to remove the long standing "ugly hack
follows" comment.

This patch is the easy, and dirty, fix

Test plan:
Use the command line tool to import MARXCML records that contains unicode
characters into Koha

Something like `misc/migration_tools/bulkmarcimport.pl -biblios -file
record.marcxml -m=MARCXML`

Without this patch you will notice that unicode characters will not be
displayed correctly

Signed-off-by: Michal Denar 
Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan  9 20:38:30 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 09 Jan 2020 19:38:30 +0000
Subject: [Koha-bugs] [Bug 24393] Remove event attributes from patron clubs
 list template
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24393

Owen Leonard  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Small patch
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan  9 20:38:33 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 09 Jan 2020 19:38:33 +0000
Subject: [Koha-bugs] [Bug 24393] Remove event attributes from patron clubs
 list template
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24393

--- Comment #1 from Owen Leonard  ---
Created attachment 97139
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97139&action=edit
Bug 24393: Remove event attributes from patron clubs list template

This patch removes some instances of the "onclick" attributes from the
template that lists patron clubs and templates.

To test, apply the patch and go to Tools -> Patron clubs.

 - Test the process of deleting a club template. Clicking the "Delete"
   button should trigger a confirmation. Confirming should delete the
   template.

 - Test the process of deleting a club. In the "Clubs" section of the
   page, click the "Actions" menu next to any club. Clicking the
   "Delete" link should trigger a confirmation. Confirming should delete
   the club.

 - Also in the "Clubs" section of the page, find a club which has
   enrollments. Select "Search to hold" from the "Actions" menu. It
   should take you to the advanced search. On the search results page
   you should have the option to place a hold for the club you selected.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan  9 20:42:20 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 09 Jan 2020 19:42:20 +0000
Subject: [Koha-bugs] [Bug 24391] Remove event attributes from patron clubs
 edit template
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24391

Owen Leonard  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #97128|0                           |1
        is obsolete|                            |

--- Comment #2 from Owen Leonard  ---
Created attachment 97140
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97140&action=edit
Bug 24391: Remove event attributes from patron clubs edit template

This patch removes "onclick" attributes from the template for adding and
editing patron club templates.

To test, apply the patch and go to Tools -> Patron clubs -> New club
template.

Test the process of adding and deleting both club and enrollment fields.
Test during the template add process and when editing an existing
template.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan  9 20:47:02 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 09 Jan 2020 19:47:02 +0000
Subject: [Koha-bugs] [Bug 24394] New: Typo when adding a new cash register
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24394

            Bug ID: 24394
           Summary: Typo when adding a new cash register
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: System Administration
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: caroline.cyr-la-rose at inlibro.com
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com

When adding a new cash register, it says "Add new cash_register" with an
underscore.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan  9 20:55:49 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 09 Jan 2020 19:55:49 +0000
Subject: [Koha-bugs] [Bug 24394] Typo when adding a new cash register
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24394

Caroline Cyr La Rose  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan  9 20:55:51 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 09 Jan 2020 19:55:51 +0000
Subject: [Koha-bugs] [Bug 24394] Typo when adding a new cash register
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24394

--- Comment #1 from Caroline Cyr La Rose  ---
Created attachment 97141
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97141&action=edit
Bug 24394: Typo when adding a new cash register

This patch corrects a typo in the cash register template.

To test:
1) Enable the UseCashRegisters system preference
2) Go to Administration > Cash registers
3) Click on 'New cash register'
4) Notice the title says 'Add new cash_register'
5) Apply patch
6) Refresh and notice it now says 'Add new cash register'

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan  9 20:57:47 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 09 Jan 2020 19:57:47 +0000
Subject: [Koha-bugs] [Bug 24394] Typo when adding a new cash register
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24394

Owen Leonard  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |String patch
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan  9 20:57:50 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 09 Jan 2020 19:57:50 +0000
Subject: [Koha-bugs] [Bug 24394] Typo when adding a new cash register
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24394

Owen Leonard  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #97141|0                           |1
        is obsolete|                            |

--- Comment #2 from Owen Leonard  ---
Created attachment 97142
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97142&action=edit
Bug 24394: Typo when adding a new cash register

This patch corrects a typo in the cash register template.

To test:
1) Go to Administration > Global system preferences
2) Search for UseCashRegisters
3) Enable UseCashRegisters and save
4) Go to Administration > Cash registers
5) Click on 'New cash register'
6) Notice the title says 'Add new cash_register'
7) Apply patch
8) Refresh and notice it now says 'Add new cash register'

Signed-off-by: Owen Leonard 

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan  9 21:17:06 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 09 Jan 2020 20:17:06 +0000
Subject: [Koha-bugs] [Bug 24395] New: Floats in cash registers have 6
 decimals
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24395

            Bug ID: 24395
           Summary: Floats in cash registers have 6 decimals
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: System Administration
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: caroline.cyr-la-rose at inlibro.com
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com

When going to Administration > Cash registers, the floats are displayed with 6
decimals. I think it would be better if it was limited to 2 or however many
your active currency uses.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan  9 22:43:06 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 09 Jan 2020 21:43:06 +0000
Subject: [Koha-bugs] [Bug 24259] Circulation fails if no circ rule defined
 but checkout override confirmed
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24259

Lucas Gass  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |lucas at bywatersolutions.com
             Status|Pushed to stable            |Pushed to oldstable

--- Comment #8 from Lucas Gass  ---
backported to 19.05.x for 19.05.07

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan  9 22:44:32 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 09 Jan 2020 21:44:32 +0000
Subject: [Koha-bugs] [Bug 24169] Advanced editor: icons/buttons for sorting
 the search results are missing
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24169

Lucas Gass  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |lucas at bywatersolutions.com

--- Comment #12 from Lucas Gass  ---
missing dependencies for 19.05.x, no backport

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan  9 23:07:56 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 09 Jan 2020 22:07:56 +0000
Subject: [Koha-bugs] [Bug 23377] bulkmarcimport.pl disables syspref caching
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23377

Michal Denar  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan  9 23:07:59 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 09 Jan 2020 22:07:59 +0000
Subject: [Koha-bugs] [Bug 23377] bulkmarcimport.pl disables syspref caching
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23377

Michal Denar  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #91898|0                           |1
        is obsolete|                            |

--- Comment #2 from Michal Denar  ---
Created attachment 97143
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97143&action=edit
Bug 23377: use ENV syspref override instead of complete disable

In an attempt to save time, bulkmarcimport temporarily sets CataloguingLog
and AuthoritiesLog to 0.  It does this by disabling syspref caching and saving
the changes to the database (then replacing the original values at completion).

Unfortunately, this disables other key sysprefs from being cached, and results
in
a 50% increase in processing time for the script.

This patch instead utilizes the ENV variable override feature of sysprefs,
which
preempts the cache in C4::Context->preference().

To test:
1. Perform a bulkmarcimport with a reasonable number of biblios (~1000 will do)
2. Note the time taken to complete
3. Apply patch
4. Revert the biblio load performed
5. Perform another bulkmarcimport with the same biblios and commandline options
6. Note the time taken to complete
7. Compare times.  The time from step 6 should be about 33% less than the time
from step 2
8. Check Cataloguing and Authorities Logs to verify imported records were not
logged
9. Profit!

Signed-off-by: Michal Denar 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan  9 23:12:48 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 09 Jan 2020 22:12:48 +0000
Subject: [Koha-bugs] [Bug 23274] t/db_dependent/XISBN.t fails with
 Elasticsearch
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23274

Michal Denar  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan  9 23:12:51 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 09 Jan 2020 22:12:51 +0000
Subject: [Koha-bugs] [Bug 23274] t/db_dependent/XISBN.t fails with
 Elasticsearch
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23274

Michal Denar  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #95823|0                           |1
        is obsolete|                            |

--- Comment #4 from Michal Denar  ---
Created attachment 97144
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97144&action=edit
Bug 23274: Mock simple_search_compat to cover both search engines

Signed-off-by: Michal Denar 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan  9 23:13:04 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 09 Jan 2020 22:13:04 +0000
Subject: [Koha-bugs] [Bug 24119] Records indexed into ES during tests are
 not removed by rollback
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24119

Michal Denar  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |black23 at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan  9 23:13:05 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 09 Jan 2020 22:13:05 +0000
Subject: [Koha-bugs] [Bug 24191] Sorting doesn't use to_model
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24191

Hayley Mapley  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to oldstable         |Pushed to oldoldstable
                 CC|                            |hayleymapley at catalyst.net.n
                   |                            |z
         Version(s)|20.05.00, 19.11.01          |20.05.00, 19.11.01,
        released in|                            |18.11.13

--- Comment #14 from Hayley Mapley  ---
Backported to 18.11.x for 18.11.13

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan  9 23:28:43 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 09 Jan 2020 22:28:43 +0000
Subject: [Koha-bugs] [Bug 24018] No need to die "Not logged in"
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24018

Michal Denar  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |black23 at gmail.com
             Status|Needs Signoff               |Patch doesn't apply

--- Comment #2 from Michal Denar  ---
Jonathan, can you rebasi this patch on master?

Thank you.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan  9 23:33:29 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 09 Jan 2020 22:33:29 +0000
Subject: [Koha-bugs] [Bug 23994] AdditionalFields.t is failing randomly (U18)
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23994

Lucas Gass  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |lucas at bywatersolutions.com

--- Comment #3 from Lucas Gass  ---
I cannot make this fail in 19.05.x, do we need it in that version?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan  9 23:38:47 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 09 Jan 2020 22:38:47 +0000
Subject: [Koha-bugs] [Bug 23995] Check constraints are supported differently
 by MySQL and MariaDB so we should remove them for now.
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23995

Lucas Gass  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |lucas at bywatersolutions.com
             Status|Pushed to master            |Pushed to stable

--- Comment #7 from Lucas Gass  ---
backported to 19.05.x for 19.05.07

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan  9 23:38:59 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 09 Jan 2020 22:38:59 +0000
Subject: [Koha-bugs] [Bug 23995] Check constraints are supported differently
 by MySQL and MariaDB so we should remove them for now.
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23995

Lucas Gass  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to stable            |Pushed to oldstable

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan  9 23:43:33 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 09 Jan 2020 22:43:33 +0000
Subject: [Koha-bugs] [Bug 23997] sample_z3950_servers.sql is failing on
 MySQL 8
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23997

Lucas Gass  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to master            |Pushed to stable
                 CC|                            |lucas at bywatersolutions.com

--- Comment #4 from Lucas Gass  ---
backported to 19.05.x for 19.05.07

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan  9 23:43:41 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 09 Jan 2020 22:43:41 +0000
Subject: [Koha-bugs] [Bug 23997] sample_z3950_servers.sql is failing on
 MySQL 8
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23997

Lucas Gass  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to stable            |Pushed to oldstable

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan  9 23:49:33 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 09 Jan 2020 22:49:33 +0000
Subject: [Koha-bugs] [Bug 23949] koha-common.init missing actions for
 koha-z3950-responder
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23949

Lucas Gass  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |lucas at bywatersolutions.com

--- Comment #15 from Lucas Gass  ---
missing dependencies for 19.05.x, no backport

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan  9 23:54:39 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 09 Jan 2020 22:54:39 +0000
Subject: [Koha-bugs] [Bug 24331] Internal server error when placing hold on
 item if itemtype undefined
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24331

Phil Ringnalda  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |phil at chetcolibrary.org

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 10 00:07:06 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 09 Jan 2020 23:07:06 +0000
Subject: [Koha-bugs] [Bug 5365] It should be more clear how to reopen a
 basket in a basket group
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5365

Lucas Gass  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |lucas at bywatersolutions.com
             Status|Pushed to master            |Pushed to stable

--- Comment #15 from Lucas Gass  ---
backported to 19.05.x for 19.05.07

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 10 00:07:15 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 09 Jan 2020 23:07:15 +0000
Subject: [Koha-bugs] [Bug 5365] It should be more clear how to reopen a
 basket in a basket group
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5365

Lucas Gass  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to stable            |Pushed to oldstable

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 10 00:43:32 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 09 Jan 2020 23:43:32 +0000
Subject: [Koha-bugs] [Bug 24364] Display item holding library in opac issues
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24364

Lucas Gass  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #96894|0                           |1
        is obsolete|                            |

--- Comment #2 from Lucas Gass  ---
Created attachment 97145
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97145&action=edit
Nice enchancement, thanks Matts!

Bug 24364: Display item holding library in opac issues

Test plan:

 1) Create a SHOW_LIB patron attribute type, with YES_NO as authorized value
category.
    (Administration -> Patron attribute types -> New patron attribute type)
    Check 'Display in OPAC' and 'Editable in OPAC' if you want users to be able
to
    toggle library display themselves.

 2) Set the SHOW_LIB attribute to yes for a given patron.

 3) Check that the library is displayed in this patron's opac issues.
    ('Your summary' -> 'Checked out' and 'Overdue' tabs)

Signed-off-by: Lucas Gass 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 10 00:43:49 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 09 Jan 2020 23:43:49 +0000
Subject: [Koha-bugs] [Bug 24364] Display item holding library in opac issues
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24364

Lucas Gass  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |lucas at bywatersolutions.com
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 10 01:17:58 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Jan 2020 00:17:58 +0000
Subject: [Koha-bugs] [Bug 24090] Subfield text in red when mandatory in
 record edition
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24090

Hayley Mapley  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |hayleymapley at catalyst.net.n
                   |                            |z
             Status|Pushed to oldstable         |Pushed to oldoldstable
         Version(s)|20.05.00, 19.11.01          |20.05.00, 19.11.01,
        released in|                            |18.11.13

--- Comment #8 from Hayley Mapley  ---
Backported to 18.11.x for 18.11.13

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 10 01:18:48 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Jan 2020 00:18:48 +0000
Subject: [Koha-bugs] [Bug 24230] intranet_js plugin hook is after body end
 tag
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24230

Hayley Mapley  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to oldstable         |Pushed to oldoldstable
                 CC|                            |hayleymapley at catalyst.net.n
                   |                            |z
         Version(s)|20.05.00, 19.11.01          |20.05.00, 19.11.01,
        released in|                            |18.11.13

--- Comment #7 from Hayley Mapley  ---
Backported to 18.11.x for 18.11.13

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 10 01:19:25 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Jan 2020 00:19:25 +0000
Subject: [Koha-bugs] [Bug 13806] No input sanitization where creating
 Reports subgroup
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13806

Hayley Mapley  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to oldstable         |Pushed to oldoldstable
                 CC|                            |hayleymapley at catalyst.net.n
                   |                            |z
         Version(s)|20.05.00, 19.11.01          |20.05.00, 19.11.01,
        released in|                            |18.11.13

--- Comment #8 from Hayley Mapley  ---
Backported to 18.11.x for 18.11.13

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 10 01:31:11 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Jan 2020 00:31:11 +0000
Subject: [Koha-bugs] [Bug 20948] Item-level hold info displayed regardless
 its priority (detail.pl)
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20948

Hayley Mapley  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |hayleymapley at catalyst.net.n
                   |                            |z
         Version(s)|20.05.00, 19.11.02          |20.05.00, 19.11.02,
        released in|                            |18.11.13
             Status|Pushed to oldstable         |Pushed to oldoldstable

--- Comment #30 from Hayley Mapley  ---
Backported to 18.11.x for 18.11.13

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 10 02:05:02 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Jan 2020 01:05:02 +0000
Subject: [Koha-bugs] [Bug 21270] "Not finding what you're looking" display
 needs to be fixed
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21270

Hayley Mapley  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |hayleymapley at catalyst.net.n
                   |                            |z
             Status|Pushed to oldstable         |Pushed to oldoldstable
         Version(s)|20.05.00, 19.11.01          |20.05.00, 19.11.01,
        released in|                            |18.11.13

--- Comment #28 from Hayley Mapley  ---
Backported to 18.11.x for 18.11.13

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 10 02:38:00 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Jan 2020 01:38:00 +0000
Subject: [Koha-bugs] [Bug 24240] List on opac missing close form tag under
 some conditions
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24240

Hayley Mapley  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |hayleymapley at catalyst.net.n
                   |                            |z
         Version(s)|20.05.00, 19.11.02          |20.05.00, 19.11.02,
        released in|                            |18.11.13
             Status|Pushed to oldstable         |Pushed to oldoldstable

--- Comment #7 from Hayley Mapley  ---
Backported to 18.11.x for 18.11.13

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 10 03:08:12 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Jan 2020 02:08:12 +0000
Subject: [Koha-bugs] [Bug 24245] opac-registration-confirmation.tt has
 incorrect HTML body id
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24245

Hayley Mapley  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to oldstable         |Pushed to oldoldstable
                 CC|                            |hayleymapley at catalyst.net.n
                   |                            |z
         Version(s)|20.05.00, 19.11.02          |20.05.00, 19.11.02,
        released in|                            |18.11.13

--- Comment #7 from Hayley Mapley  ---
Backported to 18.11.x for 18.11.13

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 10 03:31:06 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Jan 2020 02:31:06 +0000
Subject: [Koha-bugs] [Bug 23965] Use an external service to provide DVD
 cover images
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23965

Marjorie Barry-Vila  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |marjorie.barry-vila at collect
                   |                            |o.ca

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 10 03:34:05 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Jan 2020 02:34:05 +0000
Subject: [Koha-bugs] [Bug 23731] Display LC call number in OPAC and staff
 detail pages
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23731

Hayley Mapley  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to oldstable         |Pushed to oldoldstable
                 CC|                            |hayleymapley at catalyst.net.n
                   |                            |z
         Version(s)|19.11.00                    |19.11.00, 18.11.13
        released in|                            |

--- Comment #11 from Hayley Mapley  ---
Backported to 18.11.x for 18.11.13

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 10 04:16:05 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Jan 2020 03:16:05 +0000
Subject: [Koha-bugs] [Bug 5365] It should be more clear how to reopen a
 basket in a basket group
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5365

Hayley Mapley  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |hayleymapley at catalyst.net.n
                   |                            |z
         Version(s)|19.11.00                    |19.11.00, 18.11.13
        released in|                            |
             Status|Pushed to oldstable         |Pushed to oldoldstable

--- Comment #16 from Hayley Mapley  ---
Backported to 18.11.x for 18.11.13

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 10 07:43:59 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Jan 2020 06:43:59 +0000
Subject: [Koha-bugs] [Bug 23949] koha-common.init missing actions for
 koha-z3950-responder
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23949

David Nind  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Text to go in the|                            |This patch makes the
      release notes|                            |koha-common script deal
                   |                            |with koha-z3950-responder
                   |                            |in --stop and --restart
                   |                            |actions. Before this only
                   |                            |--start calls the script.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 10 08:04:32 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Jan 2020 07:04:32 +0000
Subject: [Koha-bugs] [Bug 24313] XSLT errors should show in the logs
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24313

Marcel de Rooy  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Trivial patch
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 10 08:04:35 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Jan 2020 07:04:35 +0000
Subject: [Koha-bugs] [Bug 24313] XSLT errors should show in the logs
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24313

Marcel de Rooy  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #96654|0                           |1
        is obsolete|                            |

--- Comment #4 from Marcel de Rooy  ---
Created attachment 97146
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97146&action=edit
Bug 24313: Always display XSLT errors in logs

From
  commit 295ae33800a322facfdf56795f4c02b2fd53432b
  Bug 20272: Replace error numbers by codes in XSLT_Handler

"""
    Make XSLT_Handler a little bit less noisy by defaulting print_warns to
    false unless $ENV{DEBUG} is set. (See also bug 19018).
"""

I think we should warn the errors in the logs. They are not debug messages
here, we should not rely on DEBUG.
If too noisy we should fix the original issues, not hide all the errors (which
make the XSLT debugging super hard)

Test plan:
Break a XSLT, reload the page and confirm that there are useful errors in the
Koha log file

Signed-off-by: Katrin Fischer 
Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 10 08:04:53 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Jan 2020 07:04:53 +0000
Subject: [Koha-bugs] [Bug 24313] XSLT errors should show in the logs
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24313

Marcel de Rooy  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl
                   |y.org                       |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 10 08:39:23 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Jan 2020 07:39:23 +0000
Subject: [Koha-bugs] [Bug 10352] Cataloguing log search mixing
 itemnumber/bibnumber
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10352

Marcel de Rooy  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Small patch
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 10 08:39:27 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Jan 2020 07:39:27 +0000
Subject: [Koha-bugs] [Bug 10352] Cataloguing log search mixing
 itemnumber/bibnumber
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10352

Marcel de Rooy  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #95783|0                           |1
        is obsolete|                            |

--- Comment #28 from Marcel de Rooy  ---
Created attachment 97147
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97147&action=edit
Bug 10352: Display the correct modification logs for bibliographic records

The 'Modification log" link in the cataloguing module returns confusing
results. The 'object' parameter is the biblionumber, but the all log
from itemnumber=biblionumber will be displayed as well.
Since bug 11473 we have the action_logs.info column that is prefixed by
'item ' or 'biblio ' to disociated an item modification from a biblio
modif.
This patch suggests a quick and dirty approach, use this column to make
sure we are searching for the correct logs.
/!\ As bug 11473 did not update the existing rows, we will no longer display
the logs created prior to this change.

Test plan:
Make sure you have at least 2 bibliographic records with some items
Make sure you have the biblionumbers of those records that match
existing itemnumbers
Edit them (no matter what you change)
Go to the bibliographic detail page (staff) and click "Modification log"
You should see the correct changes.

Signed-off-by: hc 

Signed-off-by: Nick Clemens 

Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 10 08:39:32 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Jan 2020 07:39:32 +0000
Subject: [Koha-bugs] [Bug 10352] Cataloguing log search mixing
 itemnumber/bibnumber
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10352

Marcel de Rooy  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #95784|0                           |1
        is obsolete|                            |

--- Comment #29 from Marcel de Rooy  ---
Created attachment 97148
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97148&action=edit
Bug 10352: Use a new object_type parameter instead of the module's name

To dissociate a search on biblio and item, we pass a new "object_type"
parameter to viewlog.pl. If equals 'biblio' we will assume that "object"
contains a biblionumber

Signed-off-by: Nick Clemens 

Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 10 08:39:37 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Jan 2020 07:39:37 +0000
Subject: [Koha-bugs] [Bug 10352] Cataloguing log search mixing
 itemnumber/bibnumber
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10352

Marcel de Rooy  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #95786|0                           |1
        is obsolete|                            |

--- Comment #30 from Marcel de Rooy  ---
Created attachment 97149
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97149&action=edit
Bug 10352: (follow-up) show the biblionumber for items in modification logs

This patch adds a link to the the biblio that shows the biblionumber of the
item. It makes things a little more obvious

To test:
1 - Find a biblio with an item where an itemnumber on another biblio is equal
to that biblionumber
   i.e. In the sample data:
        biblionumber 59 with item with itemnumber 127
        item with itemnumber  59 on biblionumber 23
2 - Edit both items however you wish
3 - On biblionumber 59 click the modification log
4 - You should see "Item 127"
5 - Click "Submit" on the form - this searches as itemnumber
6 - You should see "Item 59"
7 - Apply patch
8 - On biblionumber 59 click the modification log
9 - You should see "Item 127 from Biblio 59"
10 - Click "Submit" on the form - this searches as itemnumber
11 - You should see "Item 59 from Biblio 23"

Signed-off-by: Jonathan Druart 

Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 10 08:39:42 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Jan 2020 07:39:42 +0000
Subject: [Koha-bugs] [Bug 10352] Cataloguing log search mixing
 itemnumber/bibnumber
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10352

Marcel de Rooy  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #96336|0                           |1
        is obsolete|                            |

--- Comment #31 from Marcel de Rooy  ---
Created attachment 97150
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97150&action=edit
Bug 10352: Get add operations too

When an add for biblio or item is recorded there is no space in the info field

Signed-off-by: Jonathan Druart 

Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 10 08:39:59 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Jan 2020 07:39:59 +0000
Subject: [Koha-bugs] [Bug 10352] Cataloguing log search mixing
 itemnumber/bibnumber
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10352

Marcel de Rooy  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         QA Contact|                            |m.de.rooy at rijksmuseum.nl

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 10 08:44:31 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Jan 2020 07:44:31 +0000
Subject: [Koha-bugs] [Bug 23442] Add a 'refund' process to accounts
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23442

Josef Moravec  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 10 08:44:41 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Jan 2020 07:44:41 +0000
Subject: [Koha-bugs] [Bug 23442] Add a 'refund' process to accounts
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23442

Josef Moravec  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #97062|0                           |1
        is obsolete|                            |
  Attachment #97063|0                           |1
        is obsolete|                            |
  Attachment #97064|0                           |1
        is obsolete|                            |
  Attachment #97065|0                           |1
        is obsolete|                            |
  Attachment #97066|0                           |1
        is obsolete|                            |
  Attachment #97067|0                           |1
        is obsolete|                            |

--- Comment #36 from Josef Moravec  ---
Created attachment 97151
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97151&action=edit
Bug 23442: Add account credit types

Signed-off-by: Kyle M Hall 

Signed-off-by: Josef Moravec 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 10 08:44:53 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Jan 2020 07:44:53 +0000
Subject: [Koha-bugs] [Bug 23442] Add a 'refund' process to accounts
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23442

--- Comment #37 from Josef Moravec  ---
Created attachment 97152
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97152&action=edit
Bug 23442: Add 'reduce' method to Koha::Account::Line

This enhancement adds a 'reduce' method to Koha::Account::Line which can
be used to reduce a charge/debit by adding a credit to offset against
the amount outstanding.

It may be used to apply a discount whilst retaining the original debit
amounts or to apply a full or partial refund for example when a lost
item is found and returned.

The created credit will be immediately applied against the debit unless
the debit has already been paid, in which case a 'zero' offset will be
added to maintain a link to the debit but the outstanding credit will be
left so it may be applied to other debts.

Test Plan:
1) Run the included tests and verify they pass.
2) Signoff

Signed-off-by: Kyle M Hall 

Signed-off-by: Josef Moravec 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 10 08:45:18 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Jan 2020 07:45:18 +0000
Subject: [Koha-bugs] [Bug 23442] Add a 'refund' process to accounts
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23442

--- Comment #38 from Josef Moravec  ---
Created attachment 97153
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97153&action=edit
Bug 23442: Add refund permission

Add a new subpermission called 'refund' to the 'updatecharges'
permission group which will allow/prevent refund actions to be
performed by staff.

Signed-off-by: Kyle M Hall 

Signed-off-by: Josef Moravec 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 10 08:45:50 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Jan 2020 07:45:50 +0000
Subject: [Koha-bugs] [Bug 23442] Add a 'refund' process to accounts
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23442

--- Comment #39 from Josef Moravec  ---
Created attachment 97154
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97154&action=edit
Bug 23442: Add refund option to patron account page

This enhancement adds a refined workflow to allow librarians
to refund payments to patrons and record these refunds on the
patrons account.

The use case is that a patron has paid for something before
then performing an action that may require some level of refund
to be actioned.  Perhaps they are returning a lost and paid for
book.

Test plan:
1) Undertake a series of transactions that result in a debit
   accountline being partially or fully paid off.
2) Note that a new 'Issue refund' button appears next to a
   debit (but only if your user has the refund permission or
   is a superlibrarian)
3) Click the 'Issue refund' button and a modal should appear
   pre-populated with the amount - amountoutstanding.
4) You should be able to edit the amount you wish to refund,
   record the refund or cancel.
5) Signoff

Signed-off-by: Kyle M Hall 

Signed-off-by: Josef Moravec 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 10 08:46:03 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Jan 2020 07:46:03 +0000
Subject: [Koha-bugs] [Bug 23442] Add a 'refund' process to accounts
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23442

--- Comment #40 from Josef Moravec  ---
Created attachment 97155
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97155&action=edit
Bug 23442: Add html filter to a couple lines in template

Signed-off-by: Kyle M Hall 

Signed-off-by: Josef Moravec 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 10 08:46:24 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Jan 2020 07:46:24 +0000
Subject: [Koha-bugs] [Bug 23442] Add a 'refund' process to accounts
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23442

--- Comment #41 from Josef Moravec  ---
Created attachment 97156
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97156&action=edit
Bug 23442: Prevent payouts from being reduced

Signed-off-by: Martin Renvoize 

Signed-off-by: Josef Moravec 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 10 08:47:56 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Jan 2020 07:47:56 +0000
Subject: [Koha-bugs] [Bug 23442] Add a 'refund' process to accounts
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23442

--- Comment #42 from Josef Moravec  ---
Thanks Martin for such quick reaction, Passed QA now ;)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 10 08:57:04 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Jan 2020 07:57:04 +0000
Subject: [Koha-bugs] [Bug 8976] Default sequence of subfields in cataloguing
 editor
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8976

Christian Nelson  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |christian.nelson at tritonia.f
                   |                            |i

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 10 09:17:29 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Jan 2020 08:17:29 +0000
Subject: [Koha-bugs] [Bug 24367] With strict enabled, Search.t is too verbose
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24367

--- Comment #5 from Marcel de Rooy  ---
Created attachment 97157
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97157&action=edit
Bug 24367: Resolve warn Argument available is not numeric in delete

Argument "available" isn't numeric in delete at /usr/share/koha/C4/Search.pm
line 1480.
The construction delete array[string] simply does not work.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 10 09:17:34 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Jan 2020 08:17:34 +0000
Subject: [Koha-bugs] [Bug 24367] With strict enabled, Search.t is too verbose
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24367

--- Comment #6 from Marcel de Rooy  ---
Created attachment 97158
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97158&action=edit
Bug 24367: Resolve warn Negative repeat count does nothing

Negative repeat count does nothing at
/usr/share/koha/Koha/QueryParser/Driver/PQF/query_plan.pm line 53.
Negative repeat count does nothing at
/usr/share/koha/Koha/QueryParser/Driver/PQF/query_plan/node.pm line 102.

I am not sure if this statement actually does what the author intended,
but adding the test on node_count/atom_count removes the warn.
Repeating this change on query_plan.pm line 62.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 10 09:18:23 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Jan 2020 08:18:23 +0000
Subject: [Koha-bugs] [Bug 24367] With strict enabled, Search.t is too verbose
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24367

--- Comment #7 from Marcel de Rooy  ---
Had 42 warnings, now 28 left. Still working.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 10 09:27:27 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Jan 2020 08:27:27 +0000
Subject: [Koha-bugs] [Bug 24123] bulkmarcimport.pl doesn't support UTF-8
 encoded MARCXML records
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24123

Martin Renvoize  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |martin.renvoize at ptfs-europe
                   |                            |.com

--- Comment #6 from Martin Renvoize  ---
Happy with this pragmatic approach to a fix..

It has however, bugged me for a long time that we have both bulkmarcimport and
the stage + commit command-line scripts to do the same process in reality.  I'd
love to see that tidied up some time.

Also.. I'm really not sure why we need MARC::Batch at all.. my understanding is
that its intended use case is for multiple files, but we're only loading a
single file using bulkmarcimport aren't we?

Either way, pushing :)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 10 09:30:59 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Jan 2020 08:30:59 +0000
Subject: [Koha-bugs] [Bug 24367] With strict enabled, Search.t is too verbose
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24367

--- Comment #8 from Marcel de Rooy  ---
Created attachment 97159
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97159&action=edit
Bug 24367: Resolve warn Use of uninitialized value within [arrays]

Use of uninitialized value within @operators in string eq at
/usr/share/koha/C4/Search.pm line 1362.
Use of uninitialized value within @indexes in pattern match (m//) at
/usr/share/koha/C4/Search.pm line 1367.

Trivial tests added.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 10 09:32:23 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Jan 2020 08:32:23 +0000
Subject: [Koha-bugs] [Bug 24018] No need to die "Not logged in"
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24018

Jonathan Druart  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Patch doesn't apply         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 10 09:32:26 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Jan 2020 08:32:26 +0000
Subject: [Koha-bugs] [Bug 24018] No need to die "Not logged in"
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24018

Jonathan Druart  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #95328|0                           |1
        is obsolete|                            |

--- Comment #3 from Jonathan Druart  ---
Created attachment 97160
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97160&action=edit
Bug 24018: Remove die "Not logged in"

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 10 09:35:17 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Jan 2020 08:35:17 +0000
Subject: [Koha-bugs] [Bug 23994] AdditionalFields.t is failing randomly (U18)
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23994

Jonathan Druart  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|chris at bigballofwax.co.nz    |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org

--- Comment #4 from Jonathan Druart  ---
(In reply to Lucas Gass from comment #3)
> I cannot make this fail in 19.05.x, do we need it in that version?

Yes, it should fail on U18 as well.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 10 09:37:39 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Jan 2020 08:37:39 +0000
Subject: [Koha-bugs] [Bug 24043] ILL module can't show requests from more
 than one backend
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24043

--- Comment #5 from Magnus Enger  ---
(In reply to Martin Renvoize from comment #4)
> Sounds like this works in master then.. did you work out what fixed it and
> does that need backporting Magnus.. or can this one be closed?

I *think* it can be closed.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 10 09:38:53 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Jan 2020 08:38:53 +0000
Subject: [Koha-bugs] [Bug 10352] Cataloguing log search mixing
 itemnumber/bibnumber
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10352

Martin Renvoize  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|                            |20.05.00
        released in|                            |
             Status|Passed QA                   |Pushed to master

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 10 09:38:56 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Jan 2020 08:38:56 +0000
Subject: [Koha-bugs] [Bug 10352] Cataloguing log search mixing
 itemnumber/bibnumber
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10352

--- Comment #32 from Martin Renvoize  ---
Nice work everyone!

Pushed to master for 20.05

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 10 09:38:58 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Jan 2020 08:38:58 +0000
Subject: [Koha-bugs] [Bug 23974] hours_between and days_between lack tests
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23974

Martin Renvoize  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|                            |20.05.00
        released in|                            |
             Status|Passed QA                   |Pushed to master

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 10 09:39:00 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Jan 2020 08:39:00 +0000
Subject: [Koha-bugs] [Bug 23974] hours_between and days_between lack tests
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23974

--- Comment #45 from Martin Renvoize  ---
Nice work everyone!

Pushed to master for 20.05

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 10 09:39:02 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Jan 2020 08:39:02 +0000
Subject: [Koha-bugs] [Bug 24123] bulkmarcimport.pl doesn't support UTF-8
 encoded MARCXML records
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24123

Martin Renvoize  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to master
         Version(s)|                            |20.05.00
        released in|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 10 09:39:04 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Jan 2020 08:39:04 +0000
Subject: [Koha-bugs] [Bug 24123] bulkmarcimport.pl doesn't support UTF-8
 encoded MARCXML records
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24123

--- Comment #7 from Martin Renvoize  ---
Nice work everyone!

Pushed to master for 20.05

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 10 09:39:06 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Jan 2020 08:39:06 +0000
Subject: [Koha-bugs] [Bug 24313] XSLT errors should show in the logs
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24313

Martin Renvoize  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to master
         Version(s)|                            |20.05.00
        released in|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 10 09:39:08 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Jan 2020 08:39:08 +0000
Subject: [Koha-bugs] [Bug 24313] XSLT errors should show in the logs
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24313

--- Comment #5 from Martin Renvoize  ---
Nice work everyone!

Pushed to master for 20.05

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 10 09:41:48 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Jan 2020 08:41:48 +0000
Subject: [Koha-bugs] [Bug 23442] Add a 'refund' process to accounts
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23442

Martin Renvoize  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|                            |20.05.00
        released in|                            |
             Status|Passed QA                   |Pushed to master

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 10 09:41:50 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Jan 2020 08:41:50 +0000
Subject: [Koha-bugs] [Bug 23442] Add a 'refund' process to accounts
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23442

--- Comment #43 from Martin Renvoize  ---
Nice work everyone!

Pushed to master for 20.05

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 10 09:42:35 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Jan 2020 08:42:35 +0000
Subject: [Koha-bugs] [Bug 24394] Typo when adding a new cash register
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24394

Jonathan Druart  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 10 09:42:38 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Jan 2020 08:42:38 +0000
Subject: [Koha-bugs] [Bug 24394] Typo when adding a new cash register
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24394

Jonathan Druart  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #97142|0                           |1
        is obsolete|                            |

--- Comment #3 from Jonathan Druart  ---
Created attachment 97161
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97161&action=edit
Bug 24394: Typo when adding a new cash register

This patch corrects a typo in the cash register template.

To test:
1) Go to Administration > Global system preferences
2) Search for UseCashRegisters
3) Enable UseCashRegisters and save
4) Go to Administration > Cash registers
5) Click on 'New cash register'
6) Notice the title says 'Add new cash_register'
7) Apply patch
8) Refresh and notice it now says 'Add new cash register'

Signed-off-by: Owen Leonard 

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 10 09:42:54 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Jan 2020 08:42:54 +0000
Subject: [Koha-bugs] [Bug 24394] Typo when adding a new cash register
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24394

Jonathan Druart  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |caroline.cyr-la-rose at inlibr
                   |ity.org                     |o.com
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org
           Severity|enhancement                 |trivial

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 10 09:44:12 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Jan 2020 08:44:12 +0000
Subject: [Koha-bugs] [Bug 24123] bulkmarcimport.pl doesn't support UTF-8
 encoded MARCXML records
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24123

Katrin Fischer  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de

--- Comment #8 from Katrin Fischer  ---
(In reply to Martin Renvoize from comment #6)
> Happy with this pragmatic approach to a fix..
> 
> It has however, bugged me for a long time that we have both bulkmarcimport
> and the stage + commit command-line scripts to do the same process in
> reality.  I'd love to see that tidied up some time.
> 
> Also.. I'm really not sure why we need MARC::Batch at all.. my understanding
> is that its intended use case is for multiple files, but we're only loading
> a single file using bulkmarcimport aren't we?
> 
> Either way, pushing :)

While both import, they do it quite differently. Bulkmarcimport is faster as it
does not use the staging tables, but imports directly into the database.
Matching works differently (not using the matching rules system) and it can't
be undone.

The stage and commit scripts could probably be combined into one thing, but as
they are they match the fact it's also 2 tools in Koha. They use the matching
rules and import tables, which can mean create quite a lot of data db size wise
as everything is stored twice after importing and cleaning the batch I think
doesn't really make the db shrink. But you can undo them and use complex
matching rules. When you want to have 'versioning' for your records, it's also
helpful to keep that data.

We noticed that loading big files via stage/commit created quite a big load on
the servers - I wonder if instead of multiple files a possible use could be to
break up big files and work on them sequentially?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 10 09:45:37 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Jan 2020 08:45:37 +0000
Subject: [Koha-bugs] [Bug 24394] Typo when adding a new cash register
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24394

Martin Renvoize  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to master
         Version(s)|                            |20.05.00
        released in|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 10 09:45:39 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Jan 2020 08:45:39 +0000
Subject: [Koha-bugs] [Bug 24394] Typo when adding a new cash register
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24394

--- Comment #4 from Martin Renvoize  ---
Nice work everyone!

Pushed to master for 20.05

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 10 09:46:42 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Jan 2020 08:46:42 +0000
Subject: [Koha-bugs] [Bug 24373] Correct basic cataloging editor CSS
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24373

Jonathan Druart  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org

--- Comment #4 from Jonathan Druart  ---
Before: https://snipboard.io/FA6Hh5.jpg
After:  https://snipboard.io/dL7Umq.jpg

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 10 09:46:46 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Jan 2020 08:46:46 +0000
Subject: [Koha-bugs] [Bug 24394] Typo when adding a new cash register
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24394

Martin Renvoize  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |martin.renvoize at ptfs-europe
                   |                            |.com
         QA Contact|testopia at bugs.koha-communit |jonathan.druart at bugs.koha-c
                   |y.org                       |ommunity.org

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 10 09:47:53 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Jan 2020 08:47:53 +0000
Subject: [Koha-bugs] [Bug 24373] Correct basic cataloging editor CSS
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24373

Jonathan Druart  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 10 09:47:56 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Jan 2020 08:47:56 +0000
Subject: [Koha-bugs] [Bug 24373] Correct basic cataloging editor CSS
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24373

Jonathan Druart  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #97005|0                           |1
        is obsolete|                            |

--- Comment #5 from Jonathan Druart  ---
Created attachment 97162
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97162&action=edit
Bug 24373: Correct basic cataloging editor CSS

This patch makes minor corrections to the basic MARC editor CSS, fixing
an error caused by Bug 23259.

To test, apply the patch and clear your browser cache if necessary.

Open the basic MARC editor and check the numbered tabs. There should be
no stripe of green background showing below the tabs.

Signed-off-by: Lucas Gass 

Signed-off-by: Guillaume Paquet 

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 10 09:49:11 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Jan 2020 08:49:11 +0000
Subject: [Koha-bugs] [Bug 24294] Creating an order with ACQ framework using
 00x fields doesn't work with default value
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24294

Jonathan Druart  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |jonathan.druart at bugs.koha-c
                   |ity.org                     |ommunity.org

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 10 09:54:39 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Jan 2020 08:54:39 +0000
Subject: [Koha-bugs] [Bug 24367] With strict enabled, Search.t is too verbose
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24367

--- Comment #9 from Marcel de Rooy  ---
Created attachment 97163
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97163&action=edit
Bug 24367: Resolve other uninitialized warns in Search.pm

Use of uninitialized value in hash element at /usr/share/koha/C4/Search.pm line
2074.
Use of uninitialized value in hash element at /usr/share/koha/C4/Search.pm line
2137.
Use of uninitialized value in concatenation (.) or string at
/usr/share/koha/C4/Search.pm line 2189.
Use of uninitialized value in hash element at /usr/share/koha/C4/Search.pm line
2213.
Use of uninitialized value in hash element at /usr/share/koha/C4/Search.pm line
2215.
Use of uninitialized value in hash element at /usr/share/koha/C4/Search.pm line
2225.
Use of uninitialized value in hash element at /usr/share/koha/C4/Search.pm line
2226.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 10 09:56:20 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Jan 2020 08:56:20 +0000
Subject: [Koha-bugs] [Bug 24367] With strict enabled, Search.t is too verbose
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24367

--- Comment #10 from Marcel de Rooy  ---
The last path silences them all but contains a few arguable ones. Should we
silence ones where an itemtype should be filled?

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 10 09:57:05 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Jan 2020 08:57:05 +0000
Subject: [Koha-bugs] [Bug 24371] OPAC 'Showing only available items/Show all
 items' is double encoded
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24371

Jonathan Druart  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 10 09:57:08 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Jan 2020 08:57:08 +0000
Subject: [Koha-bugs] [Bug 24371] OPAC 'Showing only available items/Show all
 items' is double encoded
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24371

Jonathan Druart  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #97060|0                           |1
        is obsolete|                            |

--- Comment #3 from Jonathan Druart  ---
Created attachment 97164
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97164&action=edit
Bug 24371: Fix "Show all items" avaibility link (use $raw filter)

TO TEST:
1. Make an OPAC search with plenty of results.
2. Use the search facets to limit the search in some way, item type, author,
etc.
3. Click on 'Limit to currently available items', everything is still fine.
4. Attempt to return to 'Show all items', there will be no search results.
5. Apply patch
6. Ateempt steps 1-4 again.
7. Should work this time.

Signed-off-by: Rhonda Kuiper 

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 10 09:57:11 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Jan 2020 08:57:11 +0000
Subject: [Koha-bugs] [Bug 24371] OPAC 'Showing only available items/Show all
 items' is double encoded
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24371

--- Comment #4 from Jonathan Druart  ---
Created attachment 97165
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97165&action=edit
Bug 24371: Fix "Show all items" avaibility link (use $raw filter) - intra

Same fix for the intranet side

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 10 09:57:28 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Jan 2020 08:57:28 +0000
Subject: [Koha-bugs] [Bug 24371] OPAC 'Showing only available items/Show all
 items' is double encoded
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24371

Jonathan Druart  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |13618
           Severity|minor                       |normal
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618
[Bug 13618] Add additional template filter methods and a filter presence test
to Koha
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 10 09:57:28 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Jan 2020 08:57:28 +0000
Subject: [Koha-bugs] [Bug 13618] Add additional template filter methods and
 a filter presence test to Koha
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618

Jonathan Druart  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |24371


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24371
[Bug 24371] OPAC 'Showing only available items/Show all items' is double
encoded
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 10 10:02:14 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Jan 2020 09:02:14 +0000
Subject: [Koha-bugs] [Bug 24123] bulkmarcimport.pl doesn't support UTF-8
 encoded MARCXML records
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24123

--- Comment #9 from Jonathan Druart  ---
(In reply to Martin Renvoize from comment #6)
> Also.. I'm really not sure why we need MARC::Batch at all.. my understanding
> is that its intended use case is for multiple files, but we're only loading
> a single file using bulkmarcimport aren't we?

MARC::Batch is used to loop on several MARC records from a given file.
I guess we could replace it with RecordsFromISO2709File and
RecordsFromMARCXMLFile however.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 10 10:03:04 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Jan 2020 09:03:04 +0000
Subject: [Koha-bugs] [Bug 23442] Add a 'refund' process to accounts
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23442

Martin Renvoize  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Text to go in the|                            |This enhancement adds a
      release notes|                            |workflow that allows staff
                   |                            |with the new `refund`
                   |                            |permission to
                   |                            |refund/reimburse patrons
                   |                            |when they have been
                   |                            |incorrectly charged for a
                   |                            |transaction. It records an
                   |                            |audit trail for the
                   |                            |process.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 10 10:07:44 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Jan 2020 09:07:44 +0000
Subject: [Koha-bugs] [Bug 22838] Warning from runreport.pl 'Explicitly
 setting a MIME header field (content-type) is dangerous'
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22838

Arthur Suzuki  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |arthur.suzuki at biblibre.com
                   |ity.org                     |

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 10 10:07:51 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Jan 2020 09:07:51 +0000
Subject: [Koha-bugs] [Bug 22557] Delayed authority merges looses the user in
 the action_logs
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22557

--- Comment #1 from Marcel de Rooy  ---
Is it really a bug? If the merge is delayed, the user did not (technically)
execute the merge so we could argue that he should not be listed as such in the
log.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 10 10:18:09 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Jan 2020 09:18:09 +0000
Subject: [Koha-bugs] [Bug 24323] Advanced editor - Invalid 008 with helper
 silently fails to save
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24323

Jonathan Druart  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 10 10:18:12 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Jan 2020 09:18:12 +0000
Subject: [Koha-bugs] [Bug 24323] Advanced editor - Invalid 008 with helper
 silently fails to save
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24323

Jonathan Druart  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #96771|0                           |1
        is obsolete|                            |

--- Comment #7 from Jonathan Druart  ---
Created attachment 97166
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97166&action=edit
Bug 24323: Advanced editor - Invalid 008 with helper silently fails to save

This patch adds a "else if" to fall through if the error message isn't
one of the previously defined ones ("syntax" and "invalid") and presents
the human with a generic message that "Something went wrong, cannot
save."

Prior to testing:
a/Verify that Advanced Editor is enabled
b/Download the errorrecord.mrc from bug

To test:
1/Apply patch
2/Go to Cataloging->Advanced Editor
3/Click "Import Record" button and navigate to the record saved from
step b/
4/Add an 003 field (as required by the default cataloging config)
5/Hit "Save to catalog"
6/Verify that a message is passed to the user that the file was unable
to be saved

Signed-off-by: Katrin Fischer 

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 10 10:19:48 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Jan 2020 09:19:48 +0000
Subject: [Koha-bugs] [Bug 24323] Advanced editor - Invalid 008 with helper
 silently fails to save
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24323

Jonathan Druart  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #97166|0                           |1
        is obsolete|                            |

--- Comment #8 from Jonathan Druart  ---
Created attachment 97167
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97167&action=edit
Bug 24323: Advanced editor - Display an error message if the record did not
save

Invalid 008 with helper silently fails to save.

This patch adds a "else if" to fall through if the error message isn't
one of the previously defined ones ("syntax" and "invalid") and presents
the human with a generic message that "Something went wrong, cannot
save."

Prior to testing:
a/Verify that Advanced Editor is enabled
b/Download the errorrecord.mrc from bug

To test:
1/Apply patch
2/Go to Cataloging->Advanced Editor
3/Click "Import Record" button and navigate to the record saved from
step b/
4/Add an 003 field (as required by the default cataloging config)
5/Hit "Save to catalog"
6/Verify that a message is passed to the user that the file was unable
to be saved

Signed-off-by: Katrin Fischer 

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 10 10:22:36 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Jan 2020 09:22:36 +0000
Subject: [Koha-bugs] [Bug 23702] New UNIMARC XSLT according to last IFLA
 updates
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23702

Arthur Suzuki  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |arthur.suzuki at biblibre.com
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 10 10:25:09 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Jan 2020 09:25:09 +0000
Subject: [Koha-bugs] [Bug 23274] t/db_dependent/XISBN.t fails with
 Elasticsearch
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23274

Jonathan Druart  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 10 10:25:12 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Jan 2020 09:25:12 +0000
Subject: [Koha-bugs] [Bug 23274] t/db_dependent/XISBN.t fails with
 Elasticsearch
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23274

Jonathan Druart  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #97144|0                           |1
        is obsolete|                            |

--- Comment #5 from Jonathan Druart  ---
Created attachment 97168
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97168&action=edit
Bug 23274: Mock simple_search_compat to cover both search engines

Signed-off-by: Michal Denar 

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 10 10:25:23 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Jan 2020 09:25:23 +0000
Subject: [Koha-bugs] [Bug 23274] t/db_dependent/XISBN.t fails with
 Elasticsearch
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23274

Jonathan Druart  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|chris at bigballofwax.co.nz    |nick at bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 10 10:25:28 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Jan 2020 09:25:28 +0000
Subject: [Koha-bugs] [Bug 23354] Add a 'Pay' screen to allow anonymous
 payments in a POS fashion
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23354

--- Comment #103 from Josef Moravec  ---
Created attachment 97169
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97169&action=edit
Bug 23354: (QA follow-up) Mark boolean columns in schema

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 10 10:25:42 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Jan 2020 09:25:42 +0000
Subject: [Koha-bugs] [Bug 23354] Add a 'Pay' screen to allow anonymous
 payments in a POS fashion
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23354

--- Comment #104 from Josef Moravec  ---
Created attachment 97170
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97170&action=edit
Bug 23354: (QA follow-up) Add missing filters, remove tab chars

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 10 10:27:18 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Jan 2020 09:27:18 +0000
Subject: [Koha-bugs] [Bug 24367] With strict enabled, Search.t is too verbose
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24367

--- Comment #11 from Jonathan Druart  ---
(In reply to Marcel de Rooy from comment #10)
> The last path silences them all but contains a few arguable ones. Should we
> silence ones where an itemtype should be filled?

Even with the patch from comment 3?

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 10 10:29:53 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Jan 2020 09:29:53 +0000
Subject: [Koha-bugs] [Bug 24367] With strict enabled, Search.t is too verbose
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24367

--- Comment #12 from Marcel de Rooy  ---
(In reply to Jonathan Druart from comment #11)
> (In reply to Marcel de Rooy from comment #10)
> > The last path silences them all but contains a few arguable ones. Should we
> > silence ones where an itemtype should be filled?
> 
> Even with the patch from comment 3?

Yes on top of the first. I tested a bit with/without the second.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 10 10:30:50 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Jan 2020 09:30:50 +0000
Subject: [Koha-bugs] [Bug 23354] Add a 'Pay' screen to allow anonymous
 payments in a POS fashion
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23354

--- Comment #105 from Josef Moravec  ---
Comment on attachment 97019
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97019
Bug 23354: Add tests for Koha::Charges::Sales

Review of attachment 97019:
 --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=23354&attachment=97019)
-----------------------------------------------------------------

The file t/db_dependent/Koha/Charges/Sales.pm should be renamed to *.t

::: t/db_dependent/Koha/Charges/Sales.pm
@@ +139,5 @@
> +
> +    my $library2 = $builder->build_object( { class => 'Koha::Libraries' } );
> +    my $av = Koha::AuthorisedValue->new(
> +        {
> +            category         => 'MANUAL_INV',

Should be credit type object, not manual inv auth value

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 10 10:31:05 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Jan 2020 09:31:05 +0000
Subject: [Koha-bugs] [Bug 23354] Add a 'Pay' screen to allow anonymous
 payments in a POS fashion
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23354

Josef Moravec  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         QA Contact|testopia at bugs.koha-communit |josef.moravec at gmail.com
                   |y.org                       |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 10 10:31:32 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Jan 2020 09:31:32 +0000
Subject: [Koha-bugs] [Bug 22557] Delayed authority merges looses the user in
 the action_logs
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22557

Katrin Fischer  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de

--- Comment #2 from Katrin Fischer  ---
But the user did the action that triggered the merge by changing the authority
- I think it makes sense to record those.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 10 10:31:54 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Jan 2020 09:31:54 +0000
Subject: [Koha-bugs] [Bug 22838] Warning from runreport.pl 'Explicitly
 setting a MIME header field (content-type) is dangerous'
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22838

Marcel de Rooy  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |m.de.rooy at rijksmuseum.nl

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 10 10:32:07 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Jan 2020 09:32:07 +0000
Subject: [Koha-bugs] [Bug 22838] Warning from runreport.pl 'Explicitly
 setting a MIME header field (content-type) is dangerous'
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22838

--- Comment #5 from Marcel de Rooy  ---
Looking here

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 10 10:34:12 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Jan 2020 09:34:12 +0000
Subject: [Koha-bugs] [Bug 22557] Delayed authority merges looses the user in
 the action_logs
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22557

--- Comment #3 from Marcel de Rooy  ---
(In reply to Katrin Fischer from comment #2)
> But the user did the action that triggered the merge by changing the
> authority - I think it makes sense to record those.

Yes, but the authority change itself has been recorded as such.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 10 10:36:17 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Jan 2020 09:36:17 +0000
Subject: [Koha-bugs] [Bug 23354] Add a 'Pay' screen to allow anonymous
 payments in a POS fashion
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23354

Josef Moravec  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Failed QA

--- Comment #106 from Josef Moravec  ---
Hi Martin,

looks good, I added to little follow-ups and spotted the problem in test (see
my previous comment)

I have only one concern about printing receipt: I would like to see ability to
print receipt manually (maybe using modal which is implemented to confirm
change return). With current patches it is possible to print receipt only if
automatic printing is enabled. But it also enables automatic printing in
patrons accounting. I do think that there should be possibility to print
receipt from POS manually too.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 10 10:38:32 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Jan 2020 09:38:32 +0000
Subject: [Koha-bugs] [Bug 23354] Add a 'Pay' screen to allow anonymous
 payments in a POS fashion
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23354

--- Comment #107 from Josef Moravec  ---
Created attachment 97171
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97171&action=edit
POS

Also I can see some visual glitches on POS page, see attachment

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 10 10:40:39 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Jan 2020 09:40:39 +0000
Subject: [Koha-bugs] [Bug 24335] Cannot mark checkout notes seen/not seen in
 bulk
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24335

Jonathan Druart  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 10 10:40:42 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Jan 2020 09:40:42 +0000
Subject: [Koha-bugs] [Bug 24335] Cannot mark checkout notes seen/not seen in
 bulk
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24335

Jonathan Druart  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #96800|0                           |1
        is obsolete|                            |

--- Comment #4 from Jonathan Druart  ---
Created attachment 97172
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97172&action=edit
Bug 24335: Cannot mark checkout notes seen/not seen in bulk

This patch changes the way checkbox events are handled on the checkout
notes page so that checking a checkbox enables the batch operation
controls.

Note: The addition of a "markseen" class is a preventative measure to
avoid future problems where using the "btn-small" class might not be
specific enough.

To test you should have multiple checkout notes to work with, both seen
and unseen. Apply the patch and go to "Checkout notes pending" from the
staff client home page.

 - Check any checkbox. The "Mark seen" and "Mark not seen" should go
   from disabled to enabled.
   - Test that the buttons work correctly.
 - Click the "Select all" and "Clear all" controls and confirm that the
   buttons are enabled and disabled correctly.

Signed-off-by: Andrew Fuerste-Henry 

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 10 10:41:02 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Jan 2020 09:41:02 +0000
Subject: [Koha-bugs] [Bug 24337] Checkout note cannot be marked seen if more
 than 20 exist
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24337

Jonathan Druart  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 10 10:41:05 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Jan 2020 09:41:05 +0000
Subject: [Koha-bugs] [Bug 24337] Checkout note cannot be marked seen if more
 than 20 exist
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24337

Jonathan Druart  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #96802|0                           |1
        is obsolete|                            |

--- Comment #7 from Jonathan Druart  ---
Created attachment 97173
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97173&action=edit
Bug 24337: Checkout note cannot be marked seen if more than 20 exist

This patch modifies the event handler on the individual "Mark seen" /
"Mark unseen" buttons in the table of checkout notes. For an event to be
successfully attached to a hidden element it must be given a context.

To test you should have multiple checkout notes to work with, both seen
and unseen. Apply the patch and go to "Checkout notes pending" from the
staff client home page.

 - Navigate to the second "page" of data in the DataTable.
 - Test the functionality of the "Mark seen" and "Mark unseen" buttons.
   They should work correctly.

Signed-off-by: Andrew Fuerste-Henry 

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 10 10:41:21 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Jan 2020 09:41:21 +0000
Subject: [Koha-bugs] [Bug 24335] Cannot mark checkout notes seen/not seen in
 bulk
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24335

Jonathan Druart  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org
           Severity|enhancement                 |normal

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 10 10:48:05 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Jan 2020 09:48:05 +0000
Subject: [Koha-bugs] [Bug 22557] Delayed authority merges looses the user in
 the action_logs
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22557

--- Comment #4 from Katrin Fischer  ---
Yes, but it will not be so easy to see if the change recorded caused a merge
(main heading was changed). I was just saying I see advantages of tracking the
number.

I haven't checked how the merges show up in the logs, but I assume they might
as updates on bibliographic records? (UPDATE?) Or can you see it was a merge
caused update somehow?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 10 10:51:32 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Jan 2020 09:51:32 +0000
Subject: [Koha-bugs] [Bug 22838] Warning from runreport.pl 'Explicitly
 setting a MIME header field (content-type) is dangerous'
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22838

Marcel de Rooy  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Failed QA

--- Comment #6 from Marcel de Rooy  ---
$msg->attr("content-type" => $contenttype);
See first comment. This is not recommended. Normally you use Type in
MIME::Lite.

Furthermore it seems that the same content-type now is applied to both message
and attachment. Obviously, they could be different and should be handled
individually.

This needs some more attention.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 10 10:55:36 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Jan 2020 09:55:36 +0000
Subject: [Koha-bugs] [Bug 22557] Delayed authority merges looses the user in
 the action_logs
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22557

--- Comment #5 from Marcel de Rooy  ---
(In reply to Katrin Fischer from comment #4)
> Yes, but it will not be so easy to see if the change recorded caused a merge
> (main heading was changed). I was just saying I see advantages of tracking
> the number.
> 
> I haven't checked how the merges show up in the logs, but I assume they
> might as updates on bibliographic records? (UPDATE?) Or can you see it was a
> merge caused update somehow?

Differentiating them might be interesting and perhaps another solution
direction?
I am not against passing the user to the automatic merge process, but not
wanting to spend time on something that most people wont care about.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 10 10:58:08 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Jan 2020 09:58:08 +0000
Subject: [Koha-bugs] [Bug 24330] When importing patrons from CSV,
 automatically strip BOM from file if it exists
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24330

Jonathan Druart  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org

--- Comment #4 from Jonathan Druart  ---
The example CSV file works correctly for me without the patch.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 10 10:58:33 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Jan 2020 09:58:33 +0000
Subject: [Koha-bugs] [Bug 24330] When importing patrons from CSV,
 automatically strip BOM from file if it exists
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24330

--- Comment #5 from Jonathan Druart  ---
Do you get an error in the log?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 10 11:00:03 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Jan 2020 10:00:03 +0000
Subject: [Koha-bugs] [Bug 22557] Delayed authority merges looses the user in
 the action_logs
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22557

--- Comment #6 from Katrin Fischer  ---
(In reply to Marcel de Rooy from comment #5)
> (In reply to Katrin Fischer from comment #4)
> > Yes, but it will not be so easy to see if the change recorded caused a merge
> > (main heading was changed). I was just saying I see advantages of tracking
> > the number.
> > 
> > I haven't checked how the merges show up in the logs, but I assume they
> > might as updates on bibliographic records? (UPDATE?) Or can you see it was a
> > merge caused update somehow?
> 
> Differentiating them might be interesting and perhaps another solution
> direction?

I agree, if you know the changes are 'heading merges' that might be enough. You
could then check on the last change of the record that caused it.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 10 11:00:34 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Jan 2020 10:00:34 +0000
Subject: [Koha-bugs] [Bug 24247] Button fixes for OPAC lists pages
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24247

Jonathan Druart  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org
             Status|Signed Off                  |BLOCKED

--- Comment #3 from Jonathan Druart  ---
Blocked by bug 24249 which is not signed off yet.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 10 11:03:04 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Jan 2020 10:03:04 +0000
Subject: [Koha-bugs] [Bug 24127] Remove dropdown option of shelving location
 from advanced search in staff
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24127

Jonathan Druart  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |In Discussion

--- Comment #12 from Jonathan Druart  ---
Not ready for QA yet, switching status to "In Discussion".

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 10 11:04:25 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Jan 2020 10:04:25 +0000
Subject: [Koha-bugs] [Bug 24294] Creating an order with ACQ framework using
 00x fields doesn't work with default value
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24294

Marcel de Rooy  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Failed QA
                 CC|                            |m.de.rooy at rijksmuseum.nl

--- Comment #5 from Marcel de Rooy  ---
            '008' => {
                x => { defaultvalue => 'xxx' },
            },
This works too, telling me that the test does not verify it..

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 10 11:04:33 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Jan 2020 10:04:33 +0000
Subject: [Koha-bugs] [Bug 24294] Creating an order with ACQ framework using
 00x fields doesn't work with default value
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24294

Marcel de Rooy  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl
                   |y.org                       |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 10 11:13:16 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Jan 2020 10:13:16 +0000
Subject: [Koha-bugs] [Bug 14759] Replacement for Text::Unaccent
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14759

Marcel de Rooy  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |m.de.rooy at rijksmuseum.nl

--- Comment #43 from Marcel de Rooy  ---
(In reply to Jonathan Druart from comment #42)
> Martin, I think you forgot to add the new dependency.

C4/Charset.pm:use Unicode::Normalize;
C4/Installer/PerlDependencies.pm:    'Unicode::Normalize' => {
C4/Record.pm:use Unicode::Normalize; # _entity_encode
Koha/Patron.pm:use Unicode::Normalize;
misc/migration_tools/bulkmarcimport.pl:use Unicode::Normalize;

What did you mean?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 10 11:14:02 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Jan 2020 10:14:02 +0000
Subject: [Koha-bugs] [Bug 14759] Replacement for Text::Unaccent
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14759

Marcel de Rooy  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|ketan at carvingit.com         |martin.renvoize at ptfs-europe
                   |                            |.com
         QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl
                   |y.org                       |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 10 11:16:38 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Jan 2020 10:16:38 +0000
Subject: [Koha-bugs] [Bug 24294] Creating an order with ACQ framework using
 00x fields doesn't work with default value
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24294

--- Comment #6 from Jonathan Druart  ---
(In reply to Marcel de Rooy from comment #5)
>             '008' => {
>                 x => { defaultvalue => 'xxx' },
>             },
> This works too, telling me that the test does not verify it..

I do not understand what you mean. The test fails without the change to
FillWithDefaultValues.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 10 11:18:48 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Jan 2020 10:18:48 +0000
Subject: [Koha-bugs] [Bug 24294] Creating an order with ACQ framework using
 00x fields doesn't work with default value
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24294

--- Comment #7 from Jonathan Druart  ---
Ok got it.

Here 008 has a default value, and the record has a 008. So the default value
will not be used.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 10 11:19:15 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Jan 2020 10:19:15 +0000
Subject: [Koha-bugs] [Bug 14759] Replacement for Text::Unaccent
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14759

Marcel de Rooy  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA
   Patch complexity|Medium patch                |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 10 11:19:19 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Jan 2020 10:19:19 +0000
Subject: [Koha-bugs] [Bug 14759] Replacement for Text::Unaccent
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14759

Marcel de Rooy  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #97099|0                           |1
        is obsolete|                            |

--- Comment #44 from Marcel de Rooy  ---
Created attachment 97174
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97174&action=edit
Bug 14759: Replace Text::Unaccent with Unicode::Normalize

As shown in the comments on the bug, it appears that Unicode::Normalize
is the most reliable way to strip accents from strings for this use
case.

Signed-off-by: Jonathan Druart 

Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 10 11:19:24 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Jan 2020 10:19:24 +0000
Subject: [Koha-bugs] [Bug 14759] Replacement for Text::Unaccent
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14759

Marcel de Rooy  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #97100|0                           |1
        is obsolete|                            |

--- Comment #45 from Marcel de Rooy  ---
Created attachment 97175
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97175&action=edit
Bug 14759: Add test

Signed-off-by: Jonathan Druart 

Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 10 11:24:06 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Jan 2020 10:24:06 +0000
Subject: [Koha-bugs] [Bug 14759] Replacement for Text::Unaccent
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14759

--- Comment #46 from Jonathan Druart  ---
(In reply to Marcel de Rooy from comment #43)
> (In reply to Jonathan Druart from comment #42)
> > Martin, I think you forgot to add the new dependency.
> 
> C4/Charset.pm:use Unicode::Normalize;
> C4/Installer/PerlDependencies.pm:    'Unicode::Normalize' => {
> C4/Record.pm:use Unicode::Normalize; # _entity_encode
> Koha/Patron.pm:use Unicode::Normalize;
> misc/migration_tools/bulkmarcimport.pl:use Unicode::Normalize;
> 
> What did you mean?

Indeed, I missed that it was already in our dependency list.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 10 11:30:02 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Jan 2020 10:30:02 +0000
Subject: [Koha-bugs] [Bug 24396] New: Suggestions.t is failing with MySQL 8
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24396

            Bug ID: 24396
           Summary: Suggestions.t is failing with MySQL 8
 Change sponsored?: ---
           Product: Koha
           Version: unspecified
          Hardware: All
                OS: All
            Status: ASSIGNED
          Severity: normal
          Priority: P5 - low
         Component: Test Suite
          Assignee: jonathan.druart at bugs.koha-community.org
          Reporter: jonathan.druart at bugs.koha-community.org
        QA Contact: testopia at bugs.koha-community.org

#   Failed test 'DelSuggestion deletes the correct suggestion'
#   at t/db_dependent/Suggestions.t line 413.
#          got: 'my title 3'
#     expected: 'my deleted title'
t/db_dependent/Suggestions.t .. 112/113 # Looks like you failed 1 test of 113.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 10 11:30:13 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Jan 2020 10:30:13 +0000
Subject: [Koha-bugs] [Bug 23996] MySQL 8 support
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23996

Jonathan Druart  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |24396


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24396
[Bug 24396] Suggestions.t is failing with MySQL 8
-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 10 11:30:13 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Jan 2020 10:30:13 +0000
Subject: [Koha-bugs] [Bug 24396] Suggestions.t is failing with MySQL 8
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24396

Jonathan Druart  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |23996


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23996
[Bug 23996] MySQL 8 support
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 10 11:30:15 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Jan 2020 10:30:15 +0000
Subject: [Koha-bugs] [Bug 23377] bulkmarcimport.pl disables syspref caching
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23377

Marcel de Rooy  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |m.de.rooy at rijksmuseum.nl
             Status|Signed Off                  |BLOCKED

--- Comment #3 from Marcel de Rooy  ---
Looking here

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 10 11:31:55 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Jan 2020 10:31:55 +0000
Subject: [Koha-bugs] [Bug 24396] Suggestions.t is failing with MySQL 8
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24396

Jonathan Druart  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 10 11:31:59 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Jan 2020 10:31:59 +0000
Subject: [Koha-bugs] [Bug 24396] Suggestions.t is failing with MySQL 8
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24396

--- Comment #1 from Jonathan Druart  ---
Created attachment 97176
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97176&action=edit
Bug 24396: Fix Suggestions.t with MySQL 8

#   Failed test 'DelSuggestion deletes the correct suggestion'
 #   at t/db_dependent/Suggestions.t line 413.
 #          got: 'my title 3'
 #     expected: 'my deleted title'
 t/db_dependent/Suggestions.t .. 112/113 # Looks like you failed 1 test of 113.

Suggestions were returned in the reverse order. Adding an ORDER BY clause fixes
the problem.

Test plan:
 % prove t/db_dependent/Suggestions.t
must return green

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 10 11:37:34 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Jan 2020 10:37:34 +0000
Subject: [Koha-bugs] [Bug 15985] Include transacting library in fines
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15985

Martin Renvoize  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #90317|0                           |1
        is obsolete|                            |

--- Comment #24 from Martin Renvoize  ---
Created attachment 97177
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97177&action=edit
Bug 15985: Include transacting library in fines

Some librarians would like to see the library an item was checked out
from in the fines table on the fines payment page.

Test Plan:
1) Apply this patch
2) Find a patron with overdue items that have fines
3) Browse to the pay fines page
4) Note the new "checked out from" column

Signed-off-by: Jason Robb 
Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 10 11:37:38 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Jan 2020 10:37:38 +0000
Subject: [Koha-bugs] [Bug 15985] Include transacting library in fines
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15985

Martin Renvoize  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #90318|0                           |1
        is obsolete|                            |

--- Comment #25 from Martin Renvoize  ---
Created attachment 97178
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97178&action=edit
Bug 15985: Add new method Koha::Account::Line::checkout

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 10 11:37:41 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Jan 2020 10:37:41 +0000
Subject: [Koha-bugs] [Bug 15985] Include transacting library in fines
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15985

Martin Renvoize  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #90478|0                           |1
        is obsolete|                            |

--- Comment #26 from Martin Renvoize  ---
Created attachment 97179
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97179&action=edit
Bug 15985: (QA Follow up) Fix issues found by koha-qa.pl

Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 10 11:37:44 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Jan 2020 10:37:44 +0000
Subject: [Koha-bugs] [Bug 15985] Include transacting library in fines
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15985

--- Comment #27 from Martin Renvoize  ---
Created attachment 97180
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97180&action=edit
Bug 15985: (QA follow-up) Revert to Koha::Object bases

Being pragmatic to try and move this bug on, I've reverted the changed
base class for the Old:: classes and cloned the required code from the
corresponding Object classes.

Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 10 11:38:51 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Jan 2020 10:38:51 +0000
Subject: [Koha-bugs] [Bug 15985] Include transacting library in fines
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15985

Martin Renvoize  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Signed Off

--- Comment #28 from Martin Renvoize  ---
Rebased, Cleaned up for QA complaints and Signed off..

Trying to be pragmatic to get the feature in and then we'll handle the further
cleanup of login in followup bugs.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 10 11:38:58 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Jan 2020 10:38:58 +0000
Subject: [Koha-bugs] [Bug 15985] Include transacting library in fines
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15985

Martin Renvoize  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         QA Contact|josef.moravec at gmail.com     |testopia at bugs.koha-communit
                   |                            |y.org

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 10 11:41:27 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Jan 2020 10:41:27 +0000
Subject: [Koha-bugs] [Bug 24396] Suggestions.t is failing with MySQL 8
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24396

Martin Renvoize  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #97176|0                           |1
        is obsolete|                            |

--- Comment #2 from Martin Renvoize  ---
Created attachment 97181
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97181&action=edit
Bug 24396: Fix Suggestions.t with MySQL 8

 #   Failed test 'DelSuggestion deletes the correct suggestion'
 #   at t/db_dependent/Suggestions.t line 413.
 #          got: 'my title 3'
 #     expected: 'my deleted title'
 t/db_dependent/Suggestions.t .. 112/113 # Looks like you failed 1 test of 113.

Suggestions were returned in the reverse order. Adding an ORDER BY clause fixes
the problem.

Test plan:
 % prove t/db_dependent/Suggestions.t
must return green

Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 10 11:42:03 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Jan 2020 10:42:03 +0000
Subject: [Koha-bugs] [Bug 24396] Suggestions.t is failing with MySQL 8
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24396

Martin Renvoize  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off
                 CC|                            |martin.renvoize at ptfs-europe
                   |                            |.com

--- Comment #3 from Martin Renvoize  ---
Dang, that could be annoying if we have to add order by statements all over the
place to appease mysql8!

Passing QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 10 11:42:08 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Jan 2020 10:42:08 +0000
Subject: [Koha-bugs] [Bug 24396] Suggestions.t is failing with MySQL 8
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24396

Martin Renvoize  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 10 11:44:47 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Jan 2020 10:44:47 +0000
Subject: [Koha-bugs] [Bug 24200] Borrower_PrevCheckout.t failing randomly
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24200

--- Comment #1 from Jonathan Druart  ---
Got it again today on Koha_Master_D9_My8 (run 68)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 10 11:49:09 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Jan 2020 10:49:09 +0000
Subject: [Koha-bugs] [Bug 24200] Borrower_PrevCheckout.t failing randomly
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24200

Jonathan Druart  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 10 11:49:12 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Jan 2020 10:49:12 +0000
Subject: [Koha-bugs] [Bug 24200] Borrower_PrevCheckout.t failing randomly
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24200

--- Comment #2 from Jonathan Druart  ---
Created attachment 97182
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97182&action=edit
Bug 24200: Try to fix random failures from Borrower_PrevCheckout.t

It failed inconsistently, let's try to use build_sample_item and see if
it fixes the random failures.

Test plan:
 % prove t/db_dependent/Patron/Borrower_PrevCheckout.t
must return green

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 10 11:49:33 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Jan 2020 10:49:33 +0000
Subject: [Koha-bugs] [Bug 24200] Borrower_PrevCheckout.t failing randomly
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24200

Jonathan Druart  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|chris at bigballofwax.co.nz    |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org
             Status|Needs Signoff               |Signed Off

--- Comment #3 from Jonathan Druart  ---
Sending to the QA queue.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 10 11:49:46 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Jan 2020 10:49:46 +0000
Subject: [Koha-bugs] [Bug 24200] Borrower_PrevCheckout.t failing randomly
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24200

Jonathan Druart  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|enhancement                 |minor

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 10 11:51:03 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Jan 2020 10:51:03 +0000
Subject: [Koha-bugs] [Bug 14759] Replacement for Text::Unaccent
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14759

Martin Renvoize  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to master
         Version(s)|                            |20.05.00
        released in|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 10 11:51:06 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Jan 2020 10:51:06 +0000
Subject: [Koha-bugs] [Bug 14759] Replacement for Text::Unaccent
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14759

--- Comment #47 from Martin Renvoize  ---
Nice work everyone!

Pushed to master for 20.05

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 10 11:51:08 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Jan 2020 10:51:08 +0000
Subject: [Koha-bugs] [Bug 23274] t/db_dependent/XISBN.t fails with
 Elasticsearch
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23274

Martin Renvoize  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|                            |20.05.00
        released in|                            |
             Status|Passed QA                   |Pushed to master

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 10 11:51:10 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Jan 2020 10:51:10 +0000
Subject: [Koha-bugs] [Bug 23274] t/db_dependent/XISBN.t fails with
 Elasticsearch
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23274

--- Comment #6 from Martin Renvoize  ---
Nice work everyone!

Pushed to master for 20.05

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 10 11:51:12 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Jan 2020 10:51:12 +0000
Subject: [Koha-bugs] [Bug 24323] Advanced editor - Invalid 008 with helper
 silently fails to save
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24323

Martin Renvoize  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|                            |20.05.00
        released in|                            |
             Status|Passed QA                   |Pushed to master

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 10 11:51:14 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Jan 2020 10:51:14 +0000
Subject: [Koha-bugs] [Bug 24323] Advanced editor - Invalid 008 with helper
 silently fails to save
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24323

--- Comment #9 from Martin Renvoize  ---
Nice work everyone!

Pushed to master for 20.05

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 10 11:51:16 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Jan 2020 10:51:16 +0000
Subject: [Koha-bugs] [Bug 24335] Cannot mark checkout notes seen/not seen in
 bulk
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24335

Martin Renvoize  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|                            |20.05.00
        released in|                            |
             Status|Passed QA                   |Pushed to master

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 10 11:51:18 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Jan 2020 10:51:18 +0000
Subject: [Koha-bugs] [Bug 24335] Cannot mark checkout notes seen/not seen in
 bulk
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24335

--- Comment #5 from Martin Renvoize  ---
Nice work everyone!

Pushed to master for 20.05

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 10 11:51:20 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Jan 2020 10:51:20 +0000
Subject: [Koha-bugs] [Bug 24337] Checkout note cannot be marked seen if more
 than 20 exist
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24337

Martin Renvoize  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to master
         Version(s)|                            |20.05.00
        released in|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 10 11:51:22 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Jan 2020 10:51:22 +0000
Subject: [Koha-bugs] [Bug 24337] Checkout note cannot be marked seen if more
 than 20 exist
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24337

--- Comment #8 from Martin Renvoize  ---
Nice work everyone!

Pushed to master for 20.05

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 10 11:51:23 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Jan 2020 10:51:23 +0000
Subject: [Koha-bugs] [Bug 24371] OPAC 'Showing only available items/Show all
 items' is double encoded
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24371

Martin Renvoize  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to master
         Version(s)|                            |20.05.00
        released in|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 10 11:51:26 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Jan 2020 10:51:26 +0000
Subject: [Koha-bugs] [Bug 24371] OPAC 'Showing only available items/Show all
 items' is double encoded
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24371

--- Comment #5 from Martin Renvoize  ---
Nice work everyone!

Pushed to master for 20.05

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 10 11:51:28 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Jan 2020 10:51:28 +0000
Subject: [Koha-bugs] [Bug 24373] Correct basic cataloging editor CSS
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24373

Martin Renvoize  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to master
         Version(s)|                            |20.05.00
        released in|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 10 11:51:30 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Jan 2020 10:51:30 +0000
Subject: [Koha-bugs] [Bug 24373] Correct basic cataloging editor CSS
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24373

--- Comment #6 from Martin Renvoize  ---
Nice work everyone!

Pushed to master for 20.05

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 10 11:53:22 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Jan 2020 10:53:22 +0000
Subject: [Koha-bugs] [Bug 24200] Borrower_PrevCheckout.t failing randomly
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24200

Martin Renvoize  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA
                 CC|                            |martin.renvoize at ptfs-europe
                   |                            |.com

--- Comment #4 from Martin Renvoize  ---
Trivial fix, Passing QA and Pushing

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 10 11:53:37 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Jan 2020 10:53:37 +0000
Subject: [Koha-bugs] [Bug 23377] bulkmarcimport.pl disables syspref caching
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23377

Marcel de Rooy  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|BLOCKED                     |Passed QA
   Patch complexity|---                         |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 10 11:53:39 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Jan 2020 10:53:39 +0000
Subject: [Koha-bugs] [Bug 23377] bulkmarcimport.pl disables syspref caching
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23377

Marcel de Rooy  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #97143|0                           |1
        is obsolete|                            |

--- Comment #4 from Marcel de Rooy  ---
Created attachment 97183
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97183&action=edit
Bug 23377: use ENV syspref override instead of complete disable

In an attempt to save time, bulkmarcimport temporarily sets CataloguingLog
and AuthoritiesLog to 0.  It does this by disabling syspref caching and saving
the changes to the database (then replacing the original values at completion).

Unfortunately, this disables other key sysprefs from being cached, and results
in
a 50% increase in processing time for the script.

This patch instead utilizes the ENV variable override feature of sysprefs,
which
preempts the cache in C4::Context->preference().

To test:
1. Perform a bulkmarcimport with a reasonable number of biblios (~1000 will do)
2. Note the time taken to complete
3. Apply patch
4. Revert the biblio load performed
5. Perform another bulkmarcimport with the same biblios and commandline options
6. Note the time taken to complete
7. Compare times.  The time from step 6 should be about 33% less than the time
from step 2
8. Check Cataloguing and Authorities Logs to verify imported records were not
logged
9. Profit!

Signed-off-by: Michal Denar 

Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 10 11:53:44 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Jan 2020 10:53:44 +0000
Subject: [Koha-bugs] [Bug 23377] bulkmarcimport.pl disables syspref caching
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23377

--- Comment #5 from Marcel de Rooy  ---
Created attachment 97184
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97184&action=edit
Bug 23377: (QA follow-up) Use OVERRIDE_SYSPREF

SYSPREF_OVERRIDE unfortunately is not supported ;)

Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 10 11:54:30 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Jan 2020 10:54:30 +0000
Subject: [Koha-bugs] [Bug 23377] bulkmarcimport.pl disables syspref caching
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23377

--- Comment #6 from Marcel de Rooy  ---
Good to see you back, Ian. Ready to QA again :)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 10 11:54:42 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Jan 2020 10:54:42 +0000
Subject: [Koha-bugs] [Bug 23377] bulkmarcimport.pl disables syspref caching
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23377

Marcel de Rooy  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl
                   |y.org                       |
            Version|18.11                       |master

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 10 11:57:27 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Jan 2020 10:57:27 +0000
Subject: [Koha-bugs] [Bug 23377] bulkmarcimport.pl disables syspref caching
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23377

Martin Renvoize  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to master
         Version(s)|                            |20.05.00
        released in|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 10 11:57:29 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Jan 2020 10:57:29 +0000
Subject: [Koha-bugs] [Bug 23377] bulkmarcimport.pl disables syspref caching
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23377

--- Comment #7 from Martin Renvoize  ---
Nice work everyone!

Pushed to master for 20.05

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 10 11:57:31 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Jan 2020 10:57:31 +0000
Subject: [Koha-bugs] [Bug 24200] Borrower_PrevCheckout.t failing randomly
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24200

Martin Renvoize  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to master
         Version(s)|                            |20.05.00
        released in|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 10 11:57:33 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Jan 2020 10:57:33 +0000
Subject: [Koha-bugs] [Bug 24200] Borrower_PrevCheckout.t failing randomly
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24200

--- Comment #5 from Martin Renvoize  ---
Nice work everyone!

Pushed to master for 20.05

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 10 11:57:43 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Jan 2020 10:57:43 +0000
Subject: [Koha-bugs] [Bug 24396] Suggestions.t is failing with MySQL 8
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24396

Martin Renvoize  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to master
         Version(s)|                            |20.05.00
        released in|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 10 11:57:45 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Jan 2020 10:57:45 +0000
Subject: [Koha-bugs] [Bug 24396] Suggestions.t is failing with MySQL 8
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24396

--- Comment #4 from Martin Renvoize  ---
Nice work everyone!

Pushed to master for 20.05

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 10 11:59:49 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Jan 2020 10:59:49 +0000
Subject: [Koha-bugs] [Bug 15261] Verify if checkouts or reserves requests
 periods overlap with existing reserves
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15261

Laurence Rault  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Patch doesn't apply

--- Comment #78 from Laurence Rault  ---
Applied on sandbox

CONFLICT (content): Merge conflict in t/db_dependent/Circulation.t

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 10 12:01:20 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Jan 2020 11:01:20 +0000
Subject: [Koha-bugs] [Bug 24358] "Bibliographic record does not exist!" is
 not translatable
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24358

Marcel de Rooy  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA
   Patch complexity|---                         |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 10 12:01:23 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Jan 2020 11:01:23 +0000
Subject: [Koha-bugs] [Bug 24358] "Bibliographic record does not exist!" is
 not translatable
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24358

Marcel de Rooy  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #96868|0                           |1
        is obsolete|                            |

--- Comment #3 from Marcel de Rooy  ---
Created attachment 97185
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97185&action=edit
Bug 24358: (bug 21232) Make the alert string translatable

"Bibliographic record does not exist!" was not translatable as it was
defined in the .js file

Test plan:
Repeat test plan from bug 21232

Bonus point: update and install a localized version and confirm that the
message is translatable

Signed-off-by: Lucas Gass 

Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 10 12:01:49 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Jan 2020 11:01:49 +0000
Subject: [Koha-bugs] [Bug 24358] "Bibliographic record does not exist!" is
 not translatable
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24358

Marcel de Rooy  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |m.de.rooy at rijksmuseum.nl
         QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl
                   |y.org                       |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 10 12:04:39 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Jan 2020 11:04:39 +0000
Subject: [Koha-bugs] [Bug 24206] Change URLs for default options in
 OPACSearchForTitleIn
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24206

Jonathan Druart  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 10 12:04:43 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Jan 2020 11:04:43 +0000
Subject: [Koha-bugs] [Bug 24206] Change URLs for default options in
 OPACSearchForTitleIn
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24206

Jonathan Druart  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #96768|0                           |1
        is obsolete|                            |
  Attachment #96769|0                           |1
        is obsolete|                            |

--- Comment #14 from Jonathan Druart  ---
Created attachment 97186
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97186&action=edit
Bug 24206: Update URLs for default options in OPACSearchForTitleIn

- Worldcat: now https
- BookFinder: now https
- OpenLibrary: remove / before search parameters

To test:
- Verify changes to the installer files are correct
- Bonus: run the web installer for en, de-DE and nb-NO and
  verfiy the content of OPACSearchForTitleIn is correct

Signed-off-by: David Nind 

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 10 12:04:46 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Jan 2020 11:04:46 +0000
Subject: [Koha-bugs] [Bug 24206] Change URLs for default options in
 OPACSearchForTitleIn
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24206

--- Comment #15 from Jonathan Druart  ---
Created attachment 97187
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97187&action=edit
Bug 24206: Update content of OpacSearchForTitleIn for existing installations

This includes a database update for existing installations.
Using the REPLACE function it makes the same changes to the URLs
as the previous patch did for new installations:

- Worldcat: now https
- BookFinder: now https
- OpenLibrary: remove / before search parameters

To test:
- Verify the current content of your preference OpacSearchForTitleIn
  (without changes from first patch!)
- Run the database update
- Verify everything still works, but changes have been made

Signed-off-by: David Nind 

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 10 12:29:34 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Jan 2020 11:29:34 +0000
Subject: [Koha-bugs] [Bug 23181] Unable to use payment library in
 ACCOUNT_PAYMENT or ACCOUNT_WRITEOFF notices
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23181

Katrin Fischer  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |hayleymapley at catalyst.net.n
                   |                            |z

--- Comment #14 from Katrin Fischer  ---
Hi Hayley, could you consider this for 18.11 please? I attached a patch that
worked for me for the tests (so second and third should work together for
18.11)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 10 12:33:00 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Jan 2020 11:33:00 +0000
Subject: [Koha-bugs] [Bug 23354] Add a 'Pay' screen to allow anonymous
 payments in a POS fashion
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23354

--- Comment #108 from Martin Renvoize  ---
Thanks for taking a look and the followups Josef :)

Annoyed at myself for missing the filters.. this patchset was initially created
long enough ago that they were not required... I aught to have updated it
though by now :(

As for the display issues, did you run the yarn build step? (I may have
forgotten to include it in the test plan :( ).

Finally, the reciept printing.. I'm not sure I can print it from the change
modal (that doesn't always display depending on whether you actually need to
receive change or not and also the transaction hasn't yet taken place at that
point so we don't have any data to refer to.  I'll try to come up with an
alternative though, as I agree it's not great having it only tied to the
preference as it stands (You do however get the ability to print receipts in
the next patch in the series which adds a 'cashup' page of historical
transactions).

Followups incoming as I fix the receipting UX.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 10 12:40:58 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Jan 2020 11:40:58 +0000
Subject: [Koha-bugs] [Bug 17151] Extended patron attributes not importing
 when using double quotes
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17151

Serhij Dubyk  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |dubyk at ukr.net

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 10 12:48:51 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Jan 2020 11:48:51 +0000
Subject: [Koha-bugs] [Bug 13897] Use YAML files for installer data
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13897

Jonathan Druart  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         QA Contact|testopia at bugs.koha-communit |jonathan.druart at bugs.koha-c
                   |y.org                       |ommunity.org

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 10 12:50:31 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Jan 2020 11:50:31 +0000
Subject: [Koha-bugs] [Bug 23354] Add a 'Pay' screen to allow anonymous
 payments in a POS fashion
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23354

--- Comment #109 from Martin Renvoize  ---
Created attachment 97188
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97188&action=edit
Bug 23354: (QA follow-up) Allow manual receipt printing

This patch adds an alert message that allows receipt printing for
transactions when FinePaymentAutoPopup is not enabled.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 10 12:53:27 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Jan 2020 11:53:27 +0000
Subject: [Koha-bugs] [Bug 23354] Add a 'Pay' screen to allow anonymous
 payments in a POS fashion
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23354

--- Comment #110 from Martin Renvoize  ---
Created attachment 97189
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97189&action=edit
Bug 23354: (QA follow-up) Rename test file

Note to RM: Squash on push

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 10 12:59:38 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Jan 2020 11:59:38 +0000
Subject: [Koha-bugs] [Bug 9156] System preference itemcallnumber not pulling
 more than 2 subfields
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9156

Jonathan Druart  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org
             Status|Signed Off                  |Failed QA

--- Comment #21 from Jonathan Druart  ---
(In reply to Nick Clemens from comment #13)
> (In reply to Andrew Fuerste-Henry from comment #11)
> > After Nick's change, this is misbehaving slightly, not getting the right
> > order in the item record.
> > 
> > My syspref says: 082abmqA
> > 
> > My bib says:
> > 082 $a a
> >     $b b
> >     $m m
> >     $q q
> >     $A A
> > 
> > The item call number generates as: a A b m q
> 
> I cannot recreate this - the code for MARC::Field->as_string should preserve
> the order in the record. Can you share your sample record?

It preserves the order in the record, but not the one from the syspref.

>From the test plan, if I edit the pref and set 082$efab it does not change
anything. Should not we follow the order of the syspref?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 10 13:15:01 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Jan 2020 12:15:01 +0000
Subject: [Koha-bugs] [Bug 9156] System preference itemcallnumber not pulling
 more than 2 subfields
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9156

Nick Clemens  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Signed Off

--- Comment #22 from Nick Clemens  ---
We can't both preserve record order and obey syspref order.

Talking it over with Andrew and the educators we agreed the record order should
be preserved

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 10 13:19:43 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Jan 2020 12:19:43 +0000
Subject: [Koha-bugs] [Bug 9156] System preference itemcallnumber not pulling
 more than 2 subfields
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9156

--- Comment #23 from Katrin Fischer  ---
(In reply to Nick Clemens from comment #22)
> We can't both preserve record order and obey syspref order.
> 
> Talking it over with Andrew and the educators we agreed the record order
> should be preserved

Order in the recod with a clear note on the pref like done here makes sense to
me.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 10 13:21:54 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Jan 2020 12:21:54 +0000
Subject: [Koha-bugs] [Bug 23970] itemsearch - publication date not taken
 into account if not used in the first field
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23970

Katrin Fischer  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |hayleymapley at catalyst.net.n
                   |                            |z

--- Comment #10 from Katrin Fischer  ---
Hi Hayley, not sure where you are in your review, but could you consider ths
for 18.11 please? My coworker originally found it testing in 18.11 - so the bug
is there :)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 10 13:28:05 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Jan 2020 12:28:05 +0000
Subject: [Koha-bugs] [Bug 9156] System preference itemcallnumber not pulling
 more than 2 subfields
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9156

Jonathan Druart  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 10 13:28:09 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Jan 2020 12:28:09 +0000
Subject: [Koha-bugs] [Bug 9156] System preference itemcallnumber not pulling
 more than 2 subfields
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9156

Jonathan Druart  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #96486|0                           |1
        is obsolete|                            |
  Attachment #96766|0                           |1
        is obsolete|                            |
  Attachment #96792|0                           |1
        is obsolete|                            |

--- Comment #24 from Jonathan Druart  ---
Created attachment 97190
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97190&action=edit
Bug 9156: itemcallnumber not pulling more than 2 subfields

When the itemcallnumber system preference is defined, the item add form
pulls data from the specified tag and subfield(s) to pre-populate the
call number field. This update makes it possible to build the
prepopulated callnumber from more than just the first two subfields.

To test, apply the patch and update the itemcallnumber system preference
so that it includes more than two subfields. For instance, "092abef"

 - Edit a bibliographic record and populate the specified subfields.
   e.g. subfield a -> "One", b-> "Two", e-> "Three", f-> "Four".
 - Save the record and go to the add/edit items screen.
 - The call number field should contain a string which contains each of
   the subfields you populated, concatenated with spaces: "One Two Three
   Four."
 - Test with other numbers of subfields.
 - Test with an empty itemcallnumber preference.

Signed-off-by: Andrew Fuerste-Henry 

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 10 13:28:13 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Jan 2020 12:28:13 +0000
Subject: [Koha-bugs] [Bug 9156] System preference itemcallnumber not pulling
 more than 2 subfields
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9156

--- Comment #25 from Jonathan Druart  ---
Created attachment 97191
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97191&action=edit
Bug 9156: (follow-up) Simpliy code

The MARC::Field as_string method can join multiple subfield using a delimiter,
this simplifies the code here

Signed-off-by: Andrew Fuerste-Henry 

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 10 13:28:17 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Jan 2020 12:28:17 +0000
Subject: [Koha-bugs] [Bug 9156] System preference itemcallnumber not pulling
 more than 2 subfields
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9156

--- Comment #26 from Jonathan Druart  ---
Created attachment 97192
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97192&action=edit
Bug 9156: Clarify order in the syspref

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 10 13:39:24 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Jan 2020 12:39:24 +0000
Subject: [Koha-bugs] [Bug 20278] Cancel Hold alert in OPAC provides
 confusing options
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20278

Owen Leonard  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |DUPLICATE
             Status|ASSIGNED                    |RESOLVED

--- Comment #8 from Owen Leonard  ---
I'm marking this as a duplicate of Bug 21870. If anyone objects please re-open
and provide more details.

*** This bug has been marked as a duplicate of bug 21870 ***

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 10 13:39:24 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Jan 2020 12:39:24 +0000
Subject: [Koha-bugs] [Bug 21870] Convert browser alerts to modals: OPAC user
 summary
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21870

Owen Leonard  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |hughr at brimbank.vic.gov.au

--- Comment #7 from Owen Leonard  ---
*** Bug 20278 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 10 13:50:07 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Jan 2020 12:50:07 +0000
Subject: [Koha-bugs] [Bug 24367] With strict enabled, Search.t is too verbose
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24367

Jonathan Druart  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

--- Comment #13 from Jonathan Druart  ---
This is ready for testing.

Test plan:
Confirm that Search.t does not output warnings
Eyeball the patch and try to catch possible regressions

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 10 13:52:10 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Jan 2020 12:52:10 +0000
Subject: [Koha-bugs] [Bug 22284] Groups of pickup locations for holds
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284

--- Comment #290 from Jonathan Druart  ---
Another one (Koha_Master_D9 run 1061):

koha_1       |     #   Failed test 'item1, patron1, holdallowed: homebranch,
hold_fulfillment_policy: any should return 3 but returns 4'
koha_1       |     #   at t/db_dependent/Koha/Item.t line 308.
koha_1       | 
koha_1       |     #   Failed test 'item1, patron1, holdallowed: any,
hold_fulfillment_policy: any should return 3 but returns 4'
koha_1       |     #   at t/db_dependent/Koha/Item.t line 308.
koha_1       | 
koha_1       |     #   Failed test 'item1, patron1, holdallowed: holdgroup,
hold_fulfillment_policy: any should return 3 but returns 4'
koha_1       |     #   at t/db_dependent/Koha/Item.t line 308.
koha_1       | 
koha_1       |     #   Failed test 'item1, patron4, holdallowed: any,
hold_fulfillment_policy: any should return 3 but returns 4'
koha_1       |     #   at t/db_dependent/Koha/Item.t line 308.
koha_1       | 
koha_1       |     #   Failed test 'item3, patron1, holdallowed: any,
hold_fulfillment_policy: any should return 3 but returns 4'
koha_1       |     #   at t/db_dependent/Koha/Item.t line 308.
koha_1       | 
koha_1       |     #   Failed test 'item3, patron4, holdallowed: any,
hold_fulfillment_policy: any should return 3 but returns 4'
koha_1       |     #   at t/db_dependent/Koha/Item.t line 308.
koha_1       | 
koha_1       |     #   Failed test 'item3, patron4, holdallowed: holdgroup,
hold_fulfillment_policy: any should return 3 but returns 4'
koha_1       |     #   at t/db_dependent/Koha/Item.t line 308.
koha_1       |     # Looks like you planned 114 tests but ran 121.
koha_1       |     # Looks like you failed 7 tests of 121 run.
koha_1       | 
koha_1       | #   Failed test 'pickup_locations'
koha_1       | #   at t/db_dependent/Koha/Item.t line 332.
koha_1       | # Looks like you failed 1 test of 4.
koha_1       | [12:19:06] t/db_dependent/Koha/Item.t
..............................................

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 10 13:58:56 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Jan 2020 12:58:56 +0000
Subject: [Koha-bugs] [Bug 15142] Titles facet does not work in UNIMARC
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15142

Jonathan Druart  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 10 13:59:00 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Jan 2020 12:59:00 +0000
Subject: [Koha-bugs] [Bug 15142] Titles facet does not work in UNIMARC
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15142

Jonathan Druart  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #96696|0                           |1
        is obsolete|                            |
  Attachment #96697|0                           |1
        is obsolete|                            |
  Attachment #96698|0                           |1
        is obsolete|                            |

--- Comment #13 from Jonathan Druart  ---
Created attachment 97193
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97193&action=edit
Bug 15142: Remove titles facet for UNIMARC

There is a facet using 500$a, 501$a and 503$a and Subject index.
In UNIMARC 500$a, 501$a and 503$a are not indexed as Subject.
I propose to remove this facet for UNIMARC, looks like it does not make
sens.

Test plan:
1) Install UNIMARC database
2) Edit some records to have 500$a
3) Perform a search to find those records
4) Check you dont see the titles facet

Signed-off-by: Katrin Fischer 

Signed-off-by: Katrin Fischer 

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 10 13:59:04 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Jan 2020 12:59:04 +0000
Subject: [Koha-bugs] [Bug 15142] Titles facet does not work in UNIMARC
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15142

--- Comment #14 from Jonathan Druart  ---
Created attachment 97194
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97194&action=edit
Bug 15142: (follow-up) remove from Zebra UNIMARC config files

Signed-off-by: Katrin Fischer 

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 10 13:59:08 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Jan 2020 12:59:08 +0000
Subject: [Koha-bugs] [Bug 15142] Titles facet does not work in UNIMARC
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15142

--- Comment #15 from Jonathan Druart  ---
Created attachment 97195
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97195&action=edit
Bug 15142: (follow-up) Remove facet configuration from .xsl file

Removes last remaining bit of configuration for the Titles facet
configuration.

Signed-off-by: Katrin Fischer 

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 10 14:05:34 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Jan 2020 13:05:34 +0000
Subject: [Koha-bugs] [Bug 23934] Item level holds not checked for
 LocalHoldsPriority in Holds Queue
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23934

Jonathan Druart  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 10 14:05:38 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Jan 2020 13:05:38 +0000
Subject: [Koha-bugs] [Bug 23934] Item level holds not checked for
 LocalHoldsPriority in Holds Queue
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23934

Jonathan Druart  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #94929|0                           |1
        is obsolete|                            |
  Attachment #96163|0                           |1
        is obsolete|                            |

--- Comment #9 from Jonathan Druart  ---
Created attachment 97196
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97196&action=edit
Bug 23934: Unit test

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 10 14:05:42 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Jan 2020 13:05:42 +0000
Subject: [Koha-bugs] [Bug 23934] Item level holds not checked for
 LocalHoldsPriority in Holds Queue
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23934

--- Comment #10 from Jonathan Druart  ---
Created attachment 97197
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97197&action=edit
Bug 23934: Item level holds not checked for LocalHoldsPriority in Holds Queue

Test plan:
- Set LocalHoldsPriority to "Give priority for filling holds to patrons
whose pickup library matches the item's holding library"
- set yourself at Library A
- find at item at Library A
- place an item-level hold (Hold 1) for item for pickup at Library B
- set an item-level hold (Hold 2) for item for pickup at Library A
- Confirm Hold 1 shows priority=1
- Check in item
- confirm item would be captured for Hold 2, ignore hold
- run holds queue
- check item in
- confirm item is captured for Hold 2

Signed-off-by: Andrew Fuerste-Henry 

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 10 14:13:08 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Jan 2020 13:13:08 +0000
Subject: [Koha-bugs] [Bug 17885]
 Koha::SearchEngine::Elasticsearch->reset_elasticsearch_mappings throws
 DBD::mysql Duplicate entry exceptions
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17885

Jonathan Druart  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 10 14:13:13 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Jan 2020 13:13:13 +0000
Subject: [Koha-bugs] [Bug 17885]
 Koha::SearchEngine::Elasticsearch->reset_elasticsearch_mappings throws
 DBD::mysql Duplicate entry exceptions
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17885

Jonathan Druart  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #91308|0                           |1
        is obsolete|                            |

--- Comment #16 from Jonathan Druart  ---
Created attachment 97198
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97198&action=edit
Bug 17885: Koha::SearchEngine::Elasticsearch->reset_elasticsearch_mappings
throws DBD::mysql Duplicate entry exceptions

When executing
Koha::SearchEngine::Elasticsearch->reset_elasticsearch_mappings()
against populated search engine mappings tables, one gets this
exception:

DBD::mysql::st execute failed: Duplicate entry '388-73' for key
'PRIMARY' [for Statement \"INSERT INTO `search_marc_to_field` ( `facet`,
`search_field_id`, `search_marc_map_id`, `sort`, `suggestible`) VALUES (
?, ?, ?, ?, ? )\" with ParamValues: 0='', 1='73', 2='388', 3=undef,
4=''] at /usr/share/perl5/DBIx/Class/Storage/DBI.pm line
1834.\nDBIx::Class::Storage::DBI::_dbh_execute(): Duplicate entry
'388-73' for key 'PRIMARY' at /home/koha/Koha/Koha/SearchField.pm line
38"

This patch fixes this, by first deleting all entries, then adding the
default ones.

If a subroutine says reset_elasticsearch_mappings(), I expect it to
reset the elasticsearch mappings without errors.  When writing tests it
is better to call that one subroutine reset_elasticsearch_mappings
instead of the bunch of code in
admin/searchengine/elasticsearch/mappings.pl?op=reset_confirmed
Also this promotes code reuse.

TEST PLAN:

a. perl -e 'use Koha::SearchEngine::Elasticsearch;
Koha::SearchEngine::Elasticsearch->reset_elasticsearch_mappings'
b. Run misc/devel/populate_db.pl on an already populated DB and you eventually
face this problem.

After this patch, step a. works.

This patch is adapted from the original patch made by Olli-Antti
Kivilahti .

Signed-off-by: Johanna Raisa 

Signed-off-by: Jonathan Druart 
Test plan is wrong, but changes make sense

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 10 14:16:50 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Jan 2020 13:16:50 +0000
Subject: [Koha-bugs] [Bug 24397] New: populate_db.pl is out of sync and must
 be removed
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24397

            Bug ID: 24397
           Summary: populate_db.pl is out of sync and must be removed
 Change sponsored?: ---
           Product: Koha
           Version: unspecified
          Hardware: All
                OS: All
            Status: ASSIGNED
          Severity: minor
          Priority: P5 - low
         Component: Command-line Utilities
          Assignee: jonathan.druart at bugs.koha-community.org
          Reporter: jonathan.druart at bugs.koha-community.org
        QA Contact: testopia at bugs.koha-community.org
                CC: robin at catalyst.net.nz
        Depends on: 10337

populate_db.pl from koha-misc4dev must be used instead.
This script existed before the creation of koha-misc4dev, it does no longer
make sense to have it in Koha.


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10337
[Bug 10337] Add a script to insert all sample data automatically
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 10 14:16:50 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Jan 2020 13:16:50 +0000
Subject: [Koha-bugs] [Bug 10337] Add a script to insert all sample data
 automatically
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10337

Jonathan Druart  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |24397


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24397
[Bug 24397] populate_db.pl is out of sync and must be removed
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 10 14:17:45 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Jan 2020 13:17:45 +0000
Subject: [Koha-bugs] [Bug 24397] populate_db.pl is out of sync and must be
 removed
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24397

Jonathan Druart  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 10 14:17:48 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Jan 2020 13:17:48 +0000
Subject: [Koha-bugs] [Bug 24397] populate_db.pl is out of sync and must be
 removed
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24397

--- Comment #1 from Jonathan Druart  ---
Created attachment 97199
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97199&action=edit
Bug 24397: Remove out of sync script populate_db.pl

populate_db.pl from koha-misc4dev must be used instead.
This script existed before the creation of koha-misc4dev, it does no
longer make sense to have it in Koha.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 10 14:23:51 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Jan 2020 13:23:51 +0000
Subject: [Koha-bugs] [Bug 21633] Did finesMode = test ever send email?
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21633

Jonathan Druart  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org

--- Comment #8 from Jonathan Druart  ---
We have a problem with the update DB, Hea says that "test" is the most used
option, and moving test to off will introduce changes in behavior:

 97 my $overduecharges = (C4::Context->preference('finesMode') &&
C4::Context->preference('finesMode') ne 'off');

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 10 14:24:56 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Jan 2020 13:24:56 +0000
Subject: [Koha-bugs] [Bug 21633] Did finesMode = test ever send email?
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21633

Jonathan Druart  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |nick at bywatersolutions.com
                   |ity.org                     |

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 10 14:26:04 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Jan 2020 13:26:04 +0000
Subject: [Koha-bugs] [Bug 21633] Did finesMode = test ever send email?
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21633

--- Comment #9 from Jonathan Druart  ---
Also there are 2 NULL and 136 "", maybe we should deal with them here.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 10 14:41:59 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Jan 2020 13:41:59 +0000
Subject: [Koha-bugs] [Bug 23354] Add a 'Pay' screen to allow anonymous
 payments in a POS fashion
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23354

Martin Renvoize  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #97014|0                           |1
        is obsolete|                            |

--- Comment #111 from Martin Renvoize  ---
Created attachment 97200
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97200&action=edit
Bug 23354: Add a Point Of Sale 'pay' screen

This patch adds a new Point Of Sale module to Koha's staff client front
page. The module button leads directly to a 'Pay' page giving the staff
user the ability to record anonymous payments for items that would not
normally require a patron to be registered at the library.

Test plan:
1) Enable `UseCashRegisters` via the system preferences.
2) Ensure your user has the 'manage_cash_registers' permission.
3) Add a cash register for your current branch.
4) Add at least one 'MANUAL_INV' authorized value.
5) Navigate to the new 'POS' pay page via the main menu.
6) Add an item to the 'sale' by clicking 'add' from the right side of
   the screen.
7) Note that said item was added to the table of items this sale on the
   left.
8) At this point you should be able to 'click to edit' the quantity or
   price of the item in the table on the left.
9) Enter an amount greater than the price of the item into the 'amount
   collected from patron' box.
10) Click 'Confirm'
11) Varify that the same change to give modal from the paycollect pages
    appears here.
12) Click 'Confirm'
13) Payment will have been recorded (check the database) and you will be
    back at a fresh 'Pay' page ready for the next transaction.
14) Signoff

Sponsored-by: PTFS Europe
Sponsored-by: Cheshire Libraries Shared Services

Signed-off-by: Kyle M Hall 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 10 14:42:03 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Jan 2020 13:42:03 +0000
Subject: [Koha-bugs] [Bug 23354] Add a 'Pay' screen to allow anonymous
 payments in a POS fashion
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23354

Martin Renvoize  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #97015|0                           |1
        is obsolete|                            |

--- Comment #112 from Martin Renvoize  ---
Created attachment 97201
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97201&action=edit
Bug 23354: Add receipting to Pay page

This patch adds receipt printing to the new Point of Sale pay page.

Test plan:
1) Apply patch and run database update
2) Enable automatic receipt printing via the `` system preference.
3) Make a payment for an item via the new POS pay page.
4) Note that a receipt printing dialogue is shown automatically after
   payment.
5) Note that a new notice is available under tools where you can alter
   the content of the receipt.
6) Signoff

Sponsored-by: PTFS Europe
Sponsored-by: Cheshire Libraries Shared Services

Signed-off-by: Kyle M Hall 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 10 14:42:07 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Jan 2020 13:42:07 +0000
Subject: [Koha-bugs] [Bug 23354] Add a 'Pay' screen to allow anonymous
 payments in a POS fashion
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23354

Martin Renvoize  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #97016|0                           |1
        is obsolete|                            |

--- Comment #113 from Martin Renvoize  ---
Created attachment 97202
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97202&action=edit
Bug 23354: Add ability to remove items

This patch adds the ability to remove items from a transactions on the
new Point of Sale pay page.

Test plan:
1) Populate a transaction with at least one item.
2) Note the new button to 'Remove item' on the items table.
3) Click the button and confirm the item is removed
4) Signoff

Sponsored-by: PTFS Europe
Sponsored-by: Cheshire Libraries Shared Services

Signed-off-by: Kyle M Hall 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 10 14:42:11 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Jan 2020 13:42:11 +0000
Subject: [Koha-bugs] [Bug 23354] Add a 'Pay' screen to allow anonymous
 payments in a POS fashion
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23354

Martin Renvoize  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #97017|0                           |1
        is obsolete|                            |

--- Comment #114 from Martin Renvoize  ---
Created attachment 97203
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97203&action=edit
Bug 23354: (follow-up) Responses to feedback

This patch impliments a number of refinements requested after the first
round of feedback from the sponsors.

1) Fix padding on pay page
2) Switch 'items to add' from right to left on the page
3) Fix editable columns on pay page
4) Add explanitory text to pay page

Sponsored-by: PTFS Europe
Sponsored-by: Cheshire Libraries Shared Services

Signed-off-by: Kyle M Hall 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 10 14:42:15 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Jan 2020 13:42:15 +0000
Subject: [Koha-bugs] [Bug 23354] Add a 'Pay' screen to allow anonymous
 payments in a POS fashion
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23354

Martin Renvoize  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #97018|0                           |1
        is obsolete|                            |

--- Comment #115 from Martin Renvoize  ---
Created attachment 97204
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97204&action=edit
Bug 23354: Add permissions

Sponsored-by: PTFS Europe
Sponsored-by: Cheshire Libraries Shared Services

Signed-off-by: Kyle M Hall 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 10 14:42:19 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Jan 2020 13:42:19 +0000
Subject: [Koha-bugs] [Bug 23354] Add a 'Pay' screen to allow anonymous
 payments in a POS fashion
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23354

Martin Renvoize  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #97019|0                           |1
        is obsolete|                            |

--- Comment #116 from Martin Renvoize  ---
Created attachment 97205
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97205&action=edit
Bug 23354: Add tests for Koha::Charges::Sales

Sponsored-by: PTFS Europe
Sponsored-by: Cheshire Libraries Shared Services

Signed-off-by: Kyle M Hall 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 10 14:42:23 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Jan 2020 13:42:23 +0000
Subject: [Koha-bugs] [Bug 23354] Add a 'Pay' screen to allow anonymous
 payments in a POS fashion
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23354

Martin Renvoize  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #97020|0                           |1
        is obsolete|                            |

--- Comment #117 from Martin Renvoize  ---
Created attachment 97206
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97206&action=edit
Bug 23354: (follow-up) Input type on jEditable

Update the jEditable plugin to a maintained version and use the new
'number' type to enable increment arrows on click and remap onblur event
to submit.

Sponsored-by: PTFS Europe
Sponsored-by: Cheshire Libraries Shared Services

Signed-off-by: Kyle M Hall 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 10 14:42:27 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Jan 2020 13:42:27 +0000
Subject: [Koha-bugs] [Bug 23354] Add a 'Pay' screen to allow anonymous
 payments in a POS fashion
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23354

Martin Renvoize  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #97021|0                           |1
        is obsolete|                            |

--- Comment #118 from Martin Renvoize  ---
Created attachment 97207
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97207&action=edit
Bug 23354: (follow-up) Use 'format_price' for totals

Sponsored-by: PTFS Europe
Sponsored-by: Cheshire Libraries Shared Services

Signed-off-by: Kyle M Hall 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 10 14:42:31 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Jan 2020 13:42:31 +0000
Subject: [Koha-bugs] [Bug 23354] Add a 'Pay' screen to allow anonymous
 payments in a POS fashion
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23354

Martin Renvoize  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #97022|0                           |1
        is obsolete|                            |

--- Comment #119 from Martin Renvoize  ---
Created attachment 97208
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97208&action=edit
Bug 23354: Add Icon for POS system

Signed-off-by: Kyle M Hall 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 10 14:42:35 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Jan 2020 13:42:35 +0000
Subject: [Koha-bugs] [Bug 23354] Add a 'Pay' screen to allow anonymous
 payments in a POS fashion
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23354

Martin Renvoize  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #97023|0                           |1
        is obsolete|                            |

--- Comment #120 from Martin Renvoize  ---
Created attachment 97209
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97209&action=edit
Bug 23354: Update to account for bug 23049

Signed-off-by: Kyle M Hall 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 10 14:42:39 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Jan 2020 13:42:39 +0000
Subject: [Koha-bugs] [Bug 23354] Add a 'Pay' screen to allow anonymous
 payments in a POS fashion
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23354

Martin Renvoize  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #97024|0                           |1
        is obsolete|                            |

--- Comment #121 from Martin Renvoize  ---
Created attachment 97210
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97210&action=edit
Bug 23354: (follow-up) Make display of debit types configurable

This patch adds a the ability to define where a debit type will be
available as a option for use.

Signed-off-by: Kyle M Hall 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 10 14:42:43 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Jan 2020 13:42:43 +0000
Subject: [Koha-bugs] [Bug 23354] Add a 'Pay' screen to allow anonymous
 payments in a POS fashion
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23354

Martin Renvoize  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #97025|0                           |1
        is obsolete|                            |

--- Comment #122 from Martin Renvoize  ---
Created attachment 97211
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97211&action=edit
Bug 23354: (follow-up) Ensure 'CASH' payment type is present

Signed-off-by: Kyle M Hall 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 10 14:42:48 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Jan 2020 13:42:48 +0000
Subject: [Koha-bugs] [Bug 23354] Add a 'Pay' screen to allow anonymous
 payments in a POS fashion
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23354

Martin Renvoize  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #97026|0                           |1
        is obsolete|                            |

--- Comment #123 from Martin Renvoize  ---
Created attachment 97212
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97212&action=edit
Bug 23354: (follow-up) Update for bugs 23049 and 23805

Remove all mentions of accounttype and replace with debit_type_code and
credit_type_code as appropriate.

Signed-off-by: Kyle M Hall 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 10 14:42:52 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Jan 2020 13:42:52 +0000
Subject: [Koha-bugs] [Bug 23354] Add a 'Pay' screen to allow anonymous
 payments in a POS fashion
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23354

Martin Renvoize  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #97027|0                           |1
        is obsolete|                            |

--- Comment #124 from Martin Renvoize  ---
Created attachment 97213
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97213&action=edit
Bug 23354: (follow-up) Fix for sending code instead of description

Signed-off-by: Kyle M Hall 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 10 14:42:56 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Jan 2020 13:42:56 +0000
Subject: [Koha-bugs] [Bug 23354] Add a 'Pay' screen to allow anonymous
 payments in a POS fashion
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23354

Martin Renvoize  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #97028|0                           |1
        is obsolete|                            |

--- Comment #125 from Martin Renvoize  ---
Created attachment 97214
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97214&action=edit
Bug 23354: Format price on item add

Signed-off-by: Kyle M Hall 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 10 14:43:00 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Jan 2020 13:43:00 +0000
Subject: [Koha-bugs] [Bug 23354] Add a 'Pay' screen to allow anonymous
 payments in a POS fashion
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23354

Martin Renvoize  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #97029|0                           |1
        is obsolete|                            |

--- Comment #126 from Martin Renvoize  ---
Created attachment 97215
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97215&action=edit
Bug 23354: Prevent negatives from being entered

Signed-off-by: Kyle M Hall 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 10 14:43:04 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Jan 2020 13:43:04 +0000
Subject: [Koha-bugs] [Bug 23354] Add a 'Pay' screen to allow anonymous
 payments in a POS fashion
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23354

Martin Renvoize  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #97169|0                           |1
        is obsolete|                            |

--- Comment #127 from Martin Renvoize  ---
Created attachment 97216
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97216&action=edit
Bug 23354: (QA follow-up) Mark boolean columns in schema

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 10 14:43:08 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Jan 2020 13:43:08 +0000
Subject: [Koha-bugs] [Bug 23354] Add a 'Pay' screen to allow anonymous
 payments in a POS fashion
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23354

Martin Renvoize  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #97170|0                           |1
        is obsolete|                            |

--- Comment #128 from Martin Renvoize  ---
Created attachment 97217
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97217&action=edit
Bug 23354: (QA follow-up) Add missing filters, remove tab chars

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 10 14:43:12 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Jan 2020 13:43:12 +0000
Subject: [Koha-bugs] [Bug 23354] Add a 'Pay' screen to allow anonymous
 payments in a POS fashion
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23354

Martin Renvoize  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #97188|0                           |1
        is obsolete|                            |

--- Comment #129 from Martin Renvoize  ---
Created attachment 97218
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97218&action=edit
Bug 23354: (QA follow-up) Allow manual receipt printing

This patch adds an alert message that allows receipt printing for
transactions when FinePaymentAutoPopup is not enabled.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 10 14:43:16 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Jan 2020 13:43:16 +0000
Subject: [Koha-bugs] [Bug 23354] Add a 'Pay' screen to allow anonymous
 payments in a POS fashion
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23354

Martin Renvoize  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #97189|0                           |1
        is obsolete|                            |

--- Comment #130 from Martin Renvoize  ---
Created attachment 97219
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97219&action=edit
Bug 23354: (QA follow-up) Rename test file

Note to RM: Squash on push

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 10 14:45:12 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Jan 2020 13:45:12 +0000
Subject: [Koha-bugs] [Bug 23354] Add a 'Pay' screen to allow anonymous
 payments in a POS fashion
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23354

Martin Renvoize  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Signed Off

--- Comment #131 from Martin Renvoize  ---
Ready for a second QA round now, hopefully, that's everything fixed. :)

Remember to `yarn build` to get the display issues corrected.

Thanks Josef :)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 10 14:46:33 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Jan 2020 13:46:33 +0000
Subject: [Koha-bugs] [Bug 23676] Elasticsearch - 0 is not a valid boolean
 for suppress
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23676

Jonathan Druart  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org

--- Comment #9 from Jonathan Druart  ---
I am using 6.8.3 and OpacSuppression breaks the OPAC search, nothing in the
log. This patch fixes the problem!

Also it correctly hides the record.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 10 14:47:00 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Jan 2020 13:47:00 +0000
Subject: [Koha-bugs] [Bug 23676] Elasticsearch - 0 is not a valid boolean
 for suppress
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23676

Jonathan Druart  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 10 14:47:04 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Jan 2020 13:47:04 +0000
Subject: [Koha-bugs] [Bug 23676] Elasticsearch - 0 is not a valid boolean
 for suppress
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23676

Jonathan Druart  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #96695|0                           |1
        is obsolete|                            |

--- Comment #10 from Jonathan Druart  ---
Created attachment 97220
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97220&action=edit
Bug 23676: Use 'false' for opac suppression

To test:
 1 - Enable ES
 2 - Enable OpacSuppression
 3 - Suppress a bib in staff client
     Edit 942n to be 1
 4 - Search the opac for anything
 5 - Tail the plack logs and note a deprecation warning
 6 - Apply patch
 7 - Restart all the things
 8 - Repeat search on opac
 9 - No error/warn in logs
10 - Record is correctly suppressed

Signed-off-by: Myka Kennedy Stephens 

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 10 14:47:16 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Jan 2020 13:47:16 +0000
Subject: [Koha-bugs] [Bug 23676] Elasticsearch - 0 is not a valid boolean
 for suppress
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23676

Jonathan Druart  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|normal                      |major

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 10 14:47:32 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Jan 2020 13:47:32 +0000
Subject: [Koha-bugs] [Bug 24352] OpacItemLocation is buggy
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24352

Owen Leonard  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 10 14:47:39 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Jan 2020 13:47:39 +0000
Subject: [Koha-bugs] [Bug 24352] OpacItemLocation is buggy
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24352

Owen Leonard  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|enhancement                 |normal

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 10 14:48:21 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Jan 2020 13:48:21 +0000
Subject: [Koha-bugs] [Bug 23470] Elasticsearch - OpacSuppression not
 implemented in search result
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23470

Jonathan Druart  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org
         Resolution|---                         |DUPLICATE

--- Comment #15 from Jonathan Druart  ---


*** This bug has been marked as a duplicate of bug 23676 ***

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 10 14:48:21 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Jan 2020 13:48:21 +0000
Subject: [Koha-bugs] [Bug 23676] Elasticsearch - 0 is not a valid boolean
 for suppress
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23676

--- Comment #11 from Jonathan Druart  ---
*** Bug 23470 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 10 14:58:10 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Jan 2020 13:58:10 +0000
Subject: [Koha-bugs] [Bug 24352] OpacItemLocation is buggy
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24352

--- Comment #1 from Owen Leonard  ---
Created attachment 97221
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97221&action=edit
Screenshot of modified template

Does this look correct?

The screenshot shows the results from the three different OpacItemLocation
settings:

 - Call number
 - Location
 - Collection

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 10 15:06:34 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Jan 2020 14:06:34 +0000
Subject: [Koha-bugs] [Bug 22359] Improve usability of 'change calculation'
 (bug 11373)
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22359

Jonathan Druart  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Patch doesn't apply
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org
         QA Contact|testopia at bugs.koha-communit |katrin.fischer at bsz-bw.de
                   |y.org                       |

--- Comment #12 from Jonathan Druart  ---
CONFLICT (content): Merge conflict in
koha-tmpl/intranet-tmpl/prog/en/modules/members/paycollect.tt

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 10 15:07:27 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Jan 2020 14:07:27 +0000
Subject: [Koha-bugs] [Bug 22426] Elasticsearch - Index location is missing
 in advanced search
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22426

Jonathan Druart  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=24109

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 10 15:07:27 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Jan 2020 14:07:27 +0000
Subject: [Koha-bugs] [Bug 24109] Elasticsearch - Advanced search limit by
 shelving location is not converted to correct index
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24109

Jonathan Druart  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=22426

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 10 15:09:48 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Jan 2020 14:09:48 +0000
Subject: [Koha-bugs] [Bug 19482] Elasticsearch - prevent removal / editing
 of required indexes
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19482

Jonathan Druart  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Patch doesn't apply

--- Comment #35 from Jonathan Druart  ---
CONFLICT (content): Merge conflict in installer/data/mysql/kohastructure.sql

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 10 15:13:57 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Jan 2020 14:13:57 +0000
Subject: [Koha-bugs] [Bug 24109] Elasticsearch - Advanced search limit by
 shelving location is not converted to correct index
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24109

Nick Clemens  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |RESOLVED
         Resolution|---                         |DUPLICATE

--- Comment #4 from Nick Clemens  ---
Same issue as on 22426

*** This bug has been marked as a duplicate of bug 22426 ***

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 10 15:13:57 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Jan 2020 14:13:57 +0000
Subject: [Koha-bugs] [Bug 22426] Elasticsearch - Index location is missing
 in advanced search
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22426

Nick Clemens  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mkstephens at lancasterseminar
                   |                            |y.edu

--- Comment #13 from Nick Clemens  ---
*** Bug 24109 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 10 15:14:54 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Jan 2020 14:14:54 +0000
Subject: [Koha-bugs] [Bug 22426] Elasticsearch - Index location is missing
 in advanced search
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22426

Nick Clemens  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |nick at bywatersolutions.com

--- Comment #14 from Nick Clemens  ---
The alternate patch would be my preference - the first treats mc-loc as a
special case, I think it fits more to add it to the map like other mc-fields
are

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 10 15:14:58 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Jan 2020 14:14:58 +0000
Subject: [Koha-bugs] [Bug 23790] fr-CA translation of ACCOUNT_DEBIT and
 ACCOUNT_CREDIT notices
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23790

Jonathan Druart  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 10 15:15:02 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Jan 2020 14:15:02 +0000
Subject: [Koha-bugs] [Bug 23790] fr-CA translation of ACCOUNT_DEBIT and
 ACCOUNT_CREDIT notices
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23790

Jonathan Druart  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #96667|0                           |1
        is obsolete|                            |

--- Comment #3 from Jonathan Druart  ---
Created attachment 97222
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97222&action=edit
Bug 23790: fr-CA translation of ACCOUNT_DEBIT and ACCOUNT_CREDIT notices

This patch provides the fr-CA translation of the ACCOUNT_DEBIT and
ACCOUNT_CREDIT notices.

Signed-off-by: Bernardo Gonzalez Kriegel 
Tested deleting from letter table, then loading the file.
File loads without problem, no errors.

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 10 15:15:39 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Jan 2020 14:15:39 +0000
Subject: [Koha-bugs] [Bug 23790] fr-CA translation of ACCOUNT_DEBIT and
 ACCOUNT_CREDIT notices
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23790

Jonathan Druart  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org

--- Comment #4 from Jonathan Druart  ---
I amended patch's author to match usual Caroline's info.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 10 15:17:28 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Jan 2020 14:17:28 +0000
Subject: [Koha-bugs] [Bug 22426] Elasticsearch - Index location is missing
 in advanced search
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22426

Jonathan Druart  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #93397|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 10 15:17:42 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Jan 2020 14:17:42 +0000
Subject: [Koha-bugs] [Bug 22426] Elasticsearch - Index location is missing
 in advanced search
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22426

Jonathan Druart  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|bouzid.fergani at inlibro.com  |fridolin.somers at biblibre.co
                   |                            |m

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 10 15:19:33 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Jan 2020 14:19:33 +0000
Subject: [Koha-bugs] [Bug 22426] Elasticsearch - Index location is missing
 in advanced search
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22426

Jonathan Druart  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 10 15:19:37 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Jan 2020 14:19:37 +0000
Subject: [Koha-bugs] [Bug 22426] Elasticsearch - Index location is missing
 in advanced search
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22426

Jonathan Druart  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #93398|0                           |1
        is obsolete|                            |

--- Comment #15 from Jonathan Druart  ---
Created attachment 97223
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97223&action=edit
Bug 22426: (alternate) Elasticsearch fix location limit in advanced search

A search made on Shelving location tab in advanced search gives 0 result.

Test plan :
Without patch:
    - in advanced search, choose a location in shelving location tab and start
search
(opac-search.pl?idx=kw&op=and&idx=kw&op=and&idx=kw&do=Search&limit=mc-loc)
    - 0 result
    - check that location exist by doing a simple search and filtering on the  
 location facet
    - have some results
With patch:
    - in advanced search, choose a location in shelving location tab and start
search
(opac-search.pl?idx=kw&op=and&idx=kw&op=and&idx=kw&do=Search&limit=mc-loc)
    - found results

Signed-off-by: Séverine QUEUNE 
Signed-off-by: Séverine QUEUNE 

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 10 15:20:25 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Jan 2020 14:20:25 +0000
Subject: [Koha-bugs] [Bug 22426] Elasticsearch - Index location is missing
 in advanced search
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22426

Jonathan Druart  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #97223|0                           |1
        is obsolete|                            |

--- Comment #16 from Jonathan Druart  ---
Created attachment 97224
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97224&action=edit
Bug 22426: Map 'loc' to 'location' when building ES queries

A search made on Shelving location tab in advanced search gives 0 result.

Test plan :
Without patch:
    - in advanced search, choose a location in shelving location tab and start
search
(opac-search.pl?idx=kw&op=and&idx=kw&op=and&idx=kw&do=Search&limit=mc-loc)
    - 0 result
    - check that location exist by doing a simple search and filtering on the  
 location facet
    - have some results
With patch:
    - in advanced search, choose a location in shelving location tab and start
search
(opac-search.pl?idx=kw&op=and&idx=kw&op=and&idx=kw&do=Search&limit=mc-loc)
    - found results

Signed-off-by: Séverine QUEUNE 
Signed-off-by: Séverine QUEUNE 

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 10 15:21:53 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Jan 2020 14:21:53 +0000
Subject: [Koha-bugs] [Bug 24352] OpacItemLocation is buggy
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24352

Owen Leonard  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff
   Patch complexity|---                         |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 10 15:21:56 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Jan 2020 14:21:56 +0000
Subject: [Koha-bugs] [Bug 24352] OpacItemLocation is buggy
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24352

--- Comment #2 from Owen Leonard  ---
Created attachment 97225
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97225&action=edit
Bug 24352: OpacItemLocation is buggy

This patch modifies the OPAC's MARC21 search results XSLT so that the
OpacItemLocation preference correctly controls what information
displays. Previously the code for distinguishing between the 'location'
and 'collection' settings was combined.

To test, apply the patch and set the OPACXSLTResultsDisplay system
preference to 'default.'

Set the OpacItemLocation preference to 'call number only.'
 - On the OPAC search results page, each result with items should show
   information in this format:
   - "Availability: Items available for loan: {library} [Call number:
     {call number} ]

  With the OpacItemLocation preference set to 'collection code,'
   - "Availability: Items available for loan: {library}
      Collection(s): {collection description} [{ call number }]"

  With the OpacItemLocation preference set to 'location,'
   - "Availability: Items available for loan: {library}
      Location(s): {shelving location} [{ call number }]"

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 10 15:50:07 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Jan 2020 14:50:07 +0000
Subject: [Koha-bugs] [Bug 19482] Elasticsearch - prevent removal / editing
 of required indexes
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19482

Nick Clemens  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Patch doesn't apply         |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 10 15:50:10 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Jan 2020 14:50:10 +0000
Subject: [Koha-bugs] [Bug 19482] Elasticsearch - prevent removal / editing
 of required indexes
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19482

Nick Clemens  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #93371|0                           |1
        is obsolete|                            |
  Attachment #93372|0                           |1
        is obsolete|                            |
  Attachment #93373|0                           |1
        is obsolete|                            |

--- Comment #36 from Nick Clemens  ---
Created attachment 97226
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97226&action=edit
Bug 19482 - DB changes

Signed-off-by: Nicolas Legrand 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 10 15:50:14 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Jan 2020 14:50:14 +0000
Subject: [Koha-bugs] [Bug 19482] Elasticsearch - prevent removal / editing
 of required indexes
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19482

--- Comment #37 from Nick Clemens  ---
Created attachment 97227
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97227&action=edit
Bug 19482 - Add support for defining 'mandatory' mappings

To test:
1 - Apply patch
2 - ./installer/data/mysql/updatedatabase.pl
3 - Reset ES mapping: Administration->Search engine configuration , button at
bottom of page
4 - 'issues' and 'title' mapping under 'search fields' should be mandatory and
not editable
5 - On 'Bibliographic records' tab you should not be able to delete the single
entry for issues
6 - You should be able to delete 'title' mappings, however, at the final one
you should be stopped by javascript
7 - Bonus: force remove the last mapping from the page using developer tools -
attempt to save and should be warned of missing mandatory mapping

Signed-off-by: Nicolas Legrand 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 10 15:50:18 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Jan 2020 14:50:18 +0000
Subject: [Koha-bugs] [Bug 19482] Elasticsearch - prevent removal / editing
 of required indexes
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19482

--- Comment #38 from Nick Clemens  ---
Created attachment 97228
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97228&action=edit
Bug 19482: SCHEMA CHANGES _ DO NOT PUSH

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 10 15:59:14 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Jan 2020 14:59:14 +0000
Subject: [Koha-bugs] [Bug 24350] Can't place holds
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24350

Andrew Fuerste-Henry  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |andrew at bywatersolutions.com

--- Comment #9 from Andrew Fuerste-Henry  ---
I'm getting a slightly different error when trying to place a hold now:
Template process failed: undef error - Can't call method "unblessed" on
unblessed reference at /kohadevbox/koha/Koha/Template/Plugin/Branches.pm line
93.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 10 16:00:15 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Jan 2020 15:00:15 +0000
Subject: [Koha-bugs] [Bug 24398] New: Error when viewing single news item
 and NewsAuthorDisplay pref set to OPAC
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24398

            Bug ID: 24398
           Summary: Error when viewing single news item and
                    NewsAuthorDisplay pref set to OPAC
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: major
          Priority: P5 - low
         Component: OPAC
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: oleonard at myacpl.org
        QA Contact: testopia at bugs.koha-community.org

Steps to reproduce:

 - Set the NewsAuthorDisplay preference to 'OPAC' or 'Both OPAC and staff
client.'
 - Open the OPAC main page and click on an individual news item

The page for that single news item shows an error:

Template process failed: undef error - The method Koha::NewsItem->author_title
is not covered by tests!

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 10 16:02:04 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Jan 2020 15:02:04 +0000
Subject: [Koha-bugs] [Bug 22359] Improve usability of 'change calculation'
 (bug 11373)
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22359

Martin Renvoize  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #96394|0                           |1
        is obsolete|                            |

--- Comment #13 from Martin Renvoize  ---
Created attachment 97229
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97229&action=edit
Bug 22359: Improvements to payment collection inputs

This patch attempts to clarify the uses of the various input fields on
the paycollect screens.

It does this by adding validation to the form such that entering a
'collected' value that is lower than the 'paid' value is now forbidden.

Signed-off-by: Michal Denar 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 10 16:02:22 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Jan 2020 15:02:22 +0000
Subject: [Koha-bugs] [Bug 22359] Improve usability of 'change calculation'
 (bug 11373)
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22359

Martin Renvoize  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Patch doesn't apply         |Signed Off

--- Comment #14 from Martin Renvoize  ---
That was a 'fun' rebase...

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 10 16:02:37 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Jan 2020 15:02:37 +0000
Subject: [Koha-bugs] [Bug 21633] Did finesMode = test ever send email?
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21633

--- Comment #10 from Nick Clemens  ---
(In reply to Jonathan Druart from comment #8)
> We have a problem with the update DB, Hea says that "test" is the most used
> option, and moving test to off will introduce changes in behavior:
> 
>  97 my $overduecharges = (C4::Context->preference('finesMode') &&
> C4::Context->preference('finesMode') ne 'off');

This just controls whether 'Forgive overdue charges' checkbox is displayed - if
'test' it had not effect, removing it should not change behaviour

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 10 16:15:40 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Jan 2020 15:15:40 +0000
Subject: [Koha-bugs] [Bug 20930] Validate and cache parsed YAML/JSON type
 system preferences
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20930

Jonathan Druart  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Failed QA
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org

--- Comment #29 from Jonathan Druart  ---
QA comments:
1. You remove the validation from GetHiddenItemnumbers and so assume that the
data in the pref is correct, but maybe wrong data exist in the DB prior to this
patch.
(Also, use YAML in C4::Items that is no longer needed)

2. I do not think we should not use YAML to convert the syspref's value to perl
struct.
For instance, "field: [value1, value2]" does not work, ie. the
ref($syspref_val) return an empty string (means it's a scalar):
To recreate, edit OpacHiddenItems with "field: [value1, value2]"
Apply:
diff --git a/C4/Items.pm b/C4/Items.pm
index 519ce41991..283def5e4c 100644
--- a/C4/Items.pm
+++ b/C4/Items.pm
@@ -1202,6 +1202,8 @@ sub GetHiddenItemnumbers {
     my @resultitems;

     my $hidingrules = C4::Context->preference('OpacHiddenItems');
+    warn $hidingrules;
+    warn ref($hidingrules);
     return () if !$hidingrules or ref($hidingrules) ne 'HASH';
     my $dbh = C4::Context->dbh;

Finally run:
use Koha::Items;                                                                
use C4::Items;                                                                  
my $items = Koha::Items->search->unblessed;                                     
C4::Items::GetHiddenItemnumbers({items => $items}); 

It displays:
field: [value1, value2] at /kohadevbox/koha/C4/Items.pm line 1205.
Warning: something's wrong at /kohadevbox/koha/C4/Items.pm line 1206.

3. "Error: your data might not have been saved", it is what I get when I
generate an invalid yaml, I do not get info about the line, or what the error
is.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 10 16:16:00 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Jan 2020 15:16:00 +0000
Subject: [Koha-bugs] [Bug 23995] Check constraints are supported differently
 by MySQL and MariaDB so we should remove them for now.
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23995

--- Comment #8 from Martin Renvoize  ---
Created attachment 97230
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97230&action=edit
Bug 23995: (19.05.x follow-up) Corrections for backport error

Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 10 16:18:22 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Jan 2020 15:18:22 +0000
Subject: [Koha-bugs] [Bug 20930] Validate and cache parsed YAML/JSON type
 system preferences
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20930

--- Comment #30 from Jonathan Druart  ---
4. Update DB entry needed to prevent regression if syspref contains only \s

-    my $opachiddenitems = $opac
-      && ( C4::Context->preference('OpacHiddenItems') !~ /^\s*$/ );
-
+    my $opachiddenitems = $opac && (
C4::Context->preference('OpacHiddenItems') );

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 10 16:35:30 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Jan 2020 15:35:30 +0000
Subject: [Koha-bugs] [Bug 24151] Add a pseudonymization process for patrons
 and transactions
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24151

Jonathan Druart  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |ASSIGNED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 10 16:38:08 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Jan 2020 15:38:08 +0000
Subject: [Koha-bugs] [Bug 24350] Can't place holds
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24350

--- Comment #10 from Nick Clemens  ---
Created attachment 97231
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97231&action=edit
Bug 24350: follow-up - unbless each library, not the array

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 10 16:55:48 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Jan 2020 15:55:48 +0000
Subject: [Koha-bugs] [Bug 24350] Can't place holds
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24350

--- Comment #11 from Martin Renvoize  ---
Followup pushed, though I'm slightly sceptical.. it'll be interesting to see if
anything falls out in the Jenkins run.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 10 17:20:17 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Jan 2020 16:20:17 +0000
Subject: [Koha-bugs] [Bug 24018] No need to die "Not logged in"
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24018

Michal Denar  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 10 17:20:21 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Jan 2020 16:20:21 +0000
Subject: [Koha-bugs] [Bug 24018] No need to die "Not logged in"
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24018

Michal Denar  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #97160|0                           |1
        is obsolete|                            |

--- Comment #4 from Michal Denar  ---
Created attachment 97232
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97232&action=edit
Bug 24018: Remove die "Not logged in"

Signed-off-by: Michal Denar 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 10 17:23:12 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Jan 2020 16:23:12 +0000
Subject: [Koha-bugs] [Bug 9156] System preference itemcallnumber not pulling
 more than 2 subfields
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9156

Martin Renvoize  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|                            |20.05.00
        released in|                            |
             Status|Passed QA                   |Pushed to master

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 10 17:23:17 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Jan 2020 16:23:17 +0000
Subject: [Koha-bugs] [Bug 15142] Titles facet does not work in UNIMARC
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15142

Martin Renvoize  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|                            |20.05.00
        released in|                            |
             Status|Passed QA                   |Pushed to master

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 10 17:23:19 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Jan 2020 16:23:19 +0000
Subject: [Koha-bugs] [Bug 15142] Titles facet does not work in UNIMARC
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15142

--- Comment #16 from Martin Renvoize  ---
Nice work everyone!

Pushed to master for 20.05

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 10 17:23:21 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Jan 2020 16:23:21 +0000
Subject: [Koha-bugs] [Bug 17885]
 Koha::SearchEngine::Elasticsearch->reset_elasticsearch_mappings throws
 DBD::mysql Duplicate entry exceptions
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17885

Martin Renvoize  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to master
         Version(s)|                            |20.05.00
        released in|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 10 17:23:14 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Jan 2020 16:23:14 +0000
Subject: [Koha-bugs] [Bug 9156] System preference itemcallnumber not pulling
 more than 2 subfields
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9156

--- Comment #27 from Martin Renvoize  ---
Nice work everyone!

Pushed to master for 20.05

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 10 17:23:23 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Jan 2020 16:23:23 +0000
Subject: [Koha-bugs] [Bug 17885]
 Koha::SearchEngine::Elasticsearch->reset_elasticsearch_mappings throws
 DBD::mysql Duplicate entry exceptions
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17885

--- Comment #17 from Martin Renvoize  ---
Nice work everyone!

Pushed to master for 20.05

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 10 17:23:25 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Jan 2020 16:23:25 +0000
Subject: [Koha-bugs] [Bug 22426] Elasticsearch - Index location is missing
 in advanced search
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22426

Martin Renvoize  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to master
         Version(s)|                            |20.05.00
        released in|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 10 17:23:28 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Jan 2020 16:23:28 +0000
Subject: [Koha-bugs] [Bug 22426] Elasticsearch - Index location is missing
 in advanced search
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22426

--- Comment #17 from Martin Renvoize  ---
Nice work everyone!

Pushed to master for 20.05

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 10 17:23:30 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Jan 2020 16:23:30 +0000
Subject: [Koha-bugs] [Bug 23676] Elasticsearch - 0 is not a valid boolean
 for suppress
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23676

Martin Renvoize  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to master
         Version(s)|                            |20.05.00
        released in|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 10 17:23:32 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Jan 2020 16:23:32 +0000
Subject: [Koha-bugs] [Bug 23676] Elasticsearch - 0 is not a valid boolean
 for suppress
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23676

--- Comment #12 from Martin Renvoize  ---
Nice work everyone!

Pushed to master for 20.05

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 10 17:23:34 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Jan 2020 16:23:34 +0000
Subject: [Koha-bugs] [Bug 23934] Item level holds not checked for
 LocalHoldsPriority in Holds Queue
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23934

Martin Renvoize  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|                            |20.05.00
        released in|                            |
             Status|Passed QA                   |Pushed to master

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 10 17:23:36 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Jan 2020 16:23:36 +0000
Subject: [Koha-bugs] [Bug 23934] Item level holds not checked for
 LocalHoldsPriority in Holds Queue
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23934

--- Comment #11 from Martin Renvoize  ---
Nice work everyone!

Pushed to master for 20.05

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 10 17:23:38 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Jan 2020 16:23:38 +0000
Subject: [Koha-bugs] [Bug 24206] Change URLs for default options in
 OPACSearchForTitleIn
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24206

Martin Renvoize  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|                            |20.05.00
        released in|                            |
             Status|Passed QA                   |Pushed to master

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 10 17:23:40 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Jan 2020 16:23:40 +0000
Subject: [Koha-bugs] [Bug 24206] Change URLs for default options in
 OPACSearchForTitleIn
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24206

--- Comment #16 from Martin Renvoize  ---
Nice work everyone!

Pushed to master for 20.05

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 10 17:23:42 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Jan 2020 16:23:42 +0000
Subject: [Koha-bugs] [Bug 24358] "Bibliographic record does not exist!" is
 not translatable
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24358

Martin Renvoize  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|                            |20.05.00
        released in|                            |
             Status|Passed QA                   |Pushed to master

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 10 17:23:43 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Jan 2020 16:23:43 +0000
Subject: [Koha-bugs] [Bug 24358] "Bibliographic record does not exist!" is
 not translatable
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24358

--- Comment #4 from Martin Renvoize  ---
Nice work everyone!

Pushed to master for 20.05

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 10 17:58:29 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Jan 2020 16:58:29 +0000
Subject: [Koha-bugs] [Bug 19876] Koha::Account->pay() does not exit specific
 fine loop when balance is used up
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19876

Martin Renvoize  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |14825
                 CC|                            |martin.renvoize at ptfs-europe
                   |                            |.com


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14825
[Bug 14825] Accounts Rewrite Omnibus
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 10 17:58:29 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Jan 2020 16:58:29 +0000
Subject: [Koha-bugs] [Bug 14825] Accounts Rewrite Omnibus
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14825

Martin Renvoize  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |19876


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19876
[Bug 19876] Koha::Account->pay() does not exit specific fine loop when balance
is used up
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 10 17:58:43 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Jan 2020 16:58:43 +0000
Subject: [Koha-bugs] [Bug 19876] Koha::Account->pay() does not exit specific
 fine loop when balance is used up
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19876

Martin Renvoize  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|tomascohen at gmail.com        |martin.renvoize at ptfs-europe
                   |                            |.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 10 18:00:36 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Jan 2020 17:00:36 +0000
Subject: [Koha-bugs] [Bug 19876] Koha::Account->pay() does not exit specific
 fine loop when balance is used up
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19876

--- Comment #6 from Martin Renvoize  ---
UX question.. currently, we just work through the selected items in the order
they're sent to the routine I believe.. should there be a precedence for what
types of charges are paid off first?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 10 18:04:38 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Jan 2020 17:04:38 +0000
Subject: [Koha-bugs] [Bug 10756] Carousel Display of New Titles on OPAC home
 page
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10756

Christopher Brannon  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |cbrannon at cdalibrary.org

--- Comment #29 from Christopher Brannon  ---
If you need an example of some tweaks we've made, go to
https://catalog.cin.bywatersolutions.com/.  We limit the carousel to 20 items,
but add links on a few to expand the search.  We also used the tab layout for
multiple groups, and have added an animated loading message that looks sharp.

I love the fact that you can currently use reports or lists for this feature.

Would love it if this would use any/all of the same cover resources setup in
Koha, and not just Amazon covers.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 10 18:07:26 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Jan 2020 17:07:26 +0000
Subject: [Koha-bugs] [Bug 10756] Carousel Display of New Titles on OPAC home
 page
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10756

--- Comment #30 from Christopher Brannon  ---
On of my biggest concerns right now is lack of control over the width of the
title.  Some titles are huge, and spread the covers apart more.  It would be
great if there were a definable confined space for the title, which could
include the ability to wrap, shrink to a minimum, etc.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 10 18:18:12 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Jan 2020 17:18:12 +0000
Subject: [Koha-bugs] [Bug 22199] Planning Budget does not retain values
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22199

anne-cecile.bories at iepg.fr changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |anne-cecile.bories at iepg.fr

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 10 18:21:37 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Jan 2020 17:21:37 +0000
Subject: [Koha-bugs] [Bug 19419] 008 Material type reverts Book
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19419

Donna  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|enhancement                 |minor
                 CC|                            |bwsdonna at gmail.com

--- Comment #2 from Donna  ---
Confirming this is still an issue being reported by users, and causes a lot of
confusion and unnecessary repeated saving of a record. I agree this is not an
enhancement and have changed the  importance to reflect that.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 10 18:42:08 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Jan 2020 17:42:08 +0000
Subject: [Koha-bugs] [Bug 24099] Capitalization: Copier Fees
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24099

--- Comment #1 from Lisette Scheer  ---
Created attachment 97233
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97233&action=edit
Screenshot of manual debit page

Cait, 
On master (19.12.00.006)Copier fees doesn't show as a manual debit type. 
I wonder if when they moved it into this table they removed it since it would
be easy for someone to add if they wanted it?

Lisette

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 10 19:10:03 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Jan 2020 18:10:03 +0000
Subject: [Koha-bugs] [Bug 10417] Add table to keep deleted authorities
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10417

Vitor Fernandes  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |vitorfernandes87 at gmail.com

--- Comment #1 from Vitor Fernandes  ---
+1
Excellent idea.
This way we could recover authorities inadvertently deleted.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 10 19:36:48 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Jan 2020 18:36:48 +0000
Subject: [Koha-bugs] [Bug 24399] New: New permission to edit "system-level"
 news items
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24399

            Bug ID: 24399
           Summary: New permission to edit "system-level" news items
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Tools
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: oleonard at myacpl.org
        QA Contact: testopia at bugs.koha-community.org
        Depends on: 22318

Since we now have "news" items which serve the same purpose as system
preferences there really ought to be a separate permission for adding and
editing those items.


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22318
[Bug 22318] Extend Koha news feature to include other content areas
-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 10 19:36:48 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Jan 2020 18:36:48 +0000
Subject: [Koha-bugs] [Bug 22318] Extend Koha news feature to include other
 content areas
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22318

Owen Leonard  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |24399


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24399
[Bug 24399] New permission to edit "system-level" news items
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 10 21:05:23 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Jan 2020 20:05:23 +0000
Subject: [Koha-bugs] [Bug 22868] Separate Permissions for "Manage Purchase
 Suggestions" and "Enter Purchase Suggestions"
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22868

Marie-Luce Laflamme  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |marie-luce.laflamme at inlibro
                   |                            |.com

--- Comment #4 from Marie-Luce Laflamme  ---
Circulation staff do create purchase suggestions on patron's behalf regularly,
and they do need the "managing purchase suggestions" permission to create these
suggestions.

After upgrading to 19.05, we have noticed that if you allow the "managing
purchase suggestions" permission (without other acquisition permissions), you
can access the budget and see what was ordered. So, if you are a circulation
staff, you can access the budget. This is not an ideal situation.

I do agree with the others, it would be great to have a separate permission
called "enter purchase suggestions" for staff.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 10 21:10:30 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Jan 2020 20:10:30 +0000
Subject: [Koha-bugs] [Bug 24206] Change URLs for default options in
 OPACSearchForTitleIn
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24206

David Nind  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Text to go in the|                            |Updates URLs for the
      release notes|                            |default entries (sites now
                   |                            |use https, and an update to
                   |                            |the Open Library's URL
                   |                            |search pattern).

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 10 21:26:13 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Jan 2020 20:26:13 +0000
Subject: [Koha-bugs] [Bug 19382] Add ability to block guarantees based on
 fees owed by guarantor and other guarantees
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19382

Kyle M Hall  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 10 21:26:16 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Jan 2020 20:26:16 +0000
Subject: [Koha-bugs] [Bug 19382] Add ability to block guarantees based on
 fees owed by guarantor and other guarantees
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19382

--- Comment #1 from Kyle M Hall  ---
Created attachment 97234
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97234&action=edit
Bug 19382: Add ability to block guarantees based on fees owed by guarantor and
other guarantees

Some libraries would like to not only block the circulation of a guarantor
based on fines owed by guarantees, but would also like to block circulation for
all guarantees as well. Basically, if a family as a whole reaches a certain
threshold of fines, the entire family will be blocked from checking out items.

Test Plan:
1) Apply this patch
2) Set NoIssuesChargeGuarantorsWithGuarantees to $14
3) Create a family of four ( 2 guarantors, 2 guarantees ) where the parents
guarantee both children
4) Give 3 of the 4 a $5 fine
5) None of them should be able to check out items

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 10 21:31:57 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Jan 2020 20:31:57 +0000
Subject: [Koha-bugs] [Bug 19382] Add ability to block guarantees based on
 fees owed by guarantor and other guarantees
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19382

Kyle M Hall  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #97234|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 10 21:32:02 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Jan 2020 20:32:02 +0000
Subject: [Koha-bugs] [Bug 19382] Add ability to block guarantees based on
 fees owed by guarantor and other guarantees
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19382

Kyle M Hall  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |ASSIGNED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 10 21:34:36 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Jan 2020 20:34:36 +0000
Subject: [Koha-bugs] [Bug 19382] Add ability to block guarantees based on
 fees owed by guarantor and other guarantees
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19382

--- Comment #2 from Kyle M Hall  ---
Created attachment 97235
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97235&action=edit
Bug 19382: Add ability to block guarantees based on fees owed by guarantor and
other guarantees

Some libraries would like to not only block the circulation of a guarantor
based on fines owed by guarantees, but would also like to block circulation for
all guarantees as well. Basically, if a family as a whole reaches a certain
threshold of fines, the entire family will be blocked from checking out items.

Test Plan:
1) Apply this patch
2) Set NoIssuesChargeGuarantorsWithGuarantees to $14
3) Create a family of four ( 2 guarantors, 2 guarantees ) where the parents
guarantee both children
4) Give 3 of the 4 a $5 fine
5) None of them should be able to check out items

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 10 21:51:43 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Jan 2020 20:51:43 +0000
Subject: [Koha-bugs] [Bug 14419] Expanding facets (Show more) performs a new
 search
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14419

Lucas Gass  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |lucas at bywatersolutions.com

--- Comment #19 from Lucas Gass  ---
backported the 19.05.x patchset for 19.05.07

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 10 22:15:03 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Jan 2020 21:15:03 +0000
Subject: [Koha-bugs] [Bug 19014] Patrons should not get an 'on_reserve'
 notification if the due date is far into the future
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19014

--- Comment #56 from Andrew Fuerste-Henry  ---
Stalling out on signing this off while holds are broken, but reading your test
plan for the 100th time. In steps 19-21 we have an item due in 2 days and no
renewal before set to 1 day. If our goal is to not send a notice outside of the
no renewal before period, shouldn't our patrons *not* get a notice in this
situation?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 10 22:19:52 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Jan 2020 21:19:52 +0000
Subject: [Koha-bugs] [Bug 22868] Separate Permissions for "Manage Purchase
 Suggestions" and "Enter Purchase Suggestions"
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22868

Christopher Brannon  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|normal                      |critical

--- Comment #5 from Christopher Brannon  ---
Oh my gosh!  This is not good at all!  We need this fixed ASAP.  I can only do
so much to work around this without crippling our circulation staff.  Someone
please fix.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 10 22:29:25 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Jan 2020 21:29:25 +0000
Subject: [Koha-bugs] [Bug 15326] Add CMS feature
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15326

--- Comment #116 from Owen Leonard  ---
Shouldn't hitting an unpublished page return a 404 error?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 10 23:31:38 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Jan 2020 22:31:38 +0000
Subject: [Koha-bugs] [Bug 24400] New: REST API: Checkout
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24400

            Bug ID: 24400
           Summary: REST API: Checkout
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: new feature
          Priority: P5 - low
         Component: REST API
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: lari.taskula at hypernova.fi

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 10 23:33:37 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Jan 2020 22:33:37 +0000
Subject: [Koha-bugs] [Bug 24401] New: REST API: Check-in
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24401

            Bug ID: 24401
           Summary: REST API: Check-in
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: new feature
          Priority: P5 - low
         Component: REST API
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: lari.taskula at hypernova.fi

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 10 23:35:38 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Jan 2020 22:35:38 +0000
Subject: [Koha-bugs] [Bug 22868] Separate Permissions for "Manage Purchase
 Suggestions" and "Enter Purchase Suggestions"
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22868

--- Comment #6 from Marie-Luce Laflamme  ---
Staff account with limited access issues.

For example: circulation staff will require the "managing purchase suggestion"
permission to allow them to enter a purchase suggestion on a patron's behalf
(on the staff interface). Unfortunately, this permission will also unlock the
access to the budget.


Test plan

1) Create a staff account with the following permissions: "Checkout/checkin",
"Add, modify and view patron info", "Staff access, allow viewing of
catalogue..." and "Manage purchase suggestions" (without other acquisition
permissions)

2) Logout and Login to the staff interface with this new account.
3) Access the Acquisition module and notice the budget

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jan 11 00:33:01 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Jan 2020 23:33:01 +0000
Subject: [Koha-bugs] [Bug 17084] Automatic debian/control updates (master)
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17084

--- Comment #44 from Nightly Build Bot  ---
Created attachment 97236
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97236&action=edit
Bug 17084- Automatic debian/control updates (unstable/master)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jan 11 00:38:16 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Jan 2020 23:38:16 +0000
Subject: [Koha-bugs] [Bug 15326] Add CMS feature
In-Reply-To: 
References: 
Message-ID: 

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15326

--- Comment #117 from Owen Leonard  ---
Created attachment 97237
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97237&action=edit
Bug 15326: (follow-up) Template tweaks

This patch makes some tweaks to the staff-side template:

 - Fix some indentation
 - Add some markup comments
 - Fix some HTML validation errors: Eliminate duplicate id attributes
 - Expand the descriptiveness of , breadcrumbs, and form legend
 - Increase size of link and title fields; Add maxlength attribute to
   title field.
 - Move title and link fields to the second column of the table -- more
   consistent with other tables where the main link is in the first
   column.
 - Link parent page information to corresponding edit page
 - Correct incorrectly filtered action links
 - Correct default table sort
 - Fix TinyMCE configuration - I copied some configuration code from
   another page which was updated more recently.

 To test, apply the patch and test the process of adding, editing, and
 deleting pages. Test all the options in the "Actions" menu.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jan 11 00:39:33 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 10 Jan 2020 23:39:33 +0000
Subject: [Koha-bugs] [Bug 15326] Add CMS feature
In-Reply-To: <bug-15326-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15326-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15326-70-xZw9MDkHTK@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15326

--- Comment #118 from Owen Leonard <oleonard at myacpl.org> ---
These patches still apply, so it's a great time for more testing and fixes!

(In reply to Nick Clemens from comment #115)
> 1 - The content field is hidden when I try to make a new page

I think my patch fixes this issue.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jan 11 01:54:32 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 11 Jan 2020 00:54:32 +0000
Subject: [Koha-bugs] [Bug 24352] OpacItemLocation is buggy
In-Reply-To: <bug-24352-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24352-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24352-70-AmzZ9e3c86@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24352

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |david at davidnind.com

--- Comment #3 from David Nind <david at davidnind.com> ---
These are the results for me from changing OpacItemLocation after applying the
patch (searching for cat on koha-testing-docker):

call number only - doesn't show the call number:
Availability: Items available for loan: Fairview (2), Midway (1).

collection code:
Availability: Items available for loan: Fairview (2), Midway (1).
Collection(s): GEN , GEN .

location:
Availability: Items available for loan: Fairview (2), Midway (1).
Location(s): General Stacks , General Stacks .

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jan 11 05:11:40 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 11 Jan 2020 04:11:40 +0000
Subject: [Koha-bugs] [Bug 23799] Mojolicious::Plugin::OpenAPI missing in
 Debian 10
In-Reply-To: <bug-23799-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23799-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23799-70-2CmVlML0Jy@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23799

Mason James <mtj at kohaaloha.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mtj at kohaaloha.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jan 11 10:01:13 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 11 Jan 2020 09:01:13 +0000
Subject: [Koha-bugs] [Bug 24397] populate_db.pl is out of sync and must be
 removed
In-Reply-To: <bug-24397-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24397-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24397-70-U6XeuSgzPV@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24397

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jan 11 10:01:17 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 11 Jan 2020 09:01:17 +0000
Subject: [Koha-bugs] [Bug 24397] populate_db.pl is out of sync and must be
 removed
In-Reply-To: <bug-24397-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24397-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24397-70-yfeMq2ym0e@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24397

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #97199|0                           |1
        is obsolete|                            |

--- Comment #2 from David Nind <david at davidnind.com> ---
Created attachment 97238
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97238&action=edit
Bug 24397: Remove out of sync script populate_db.pl

populate_db.pl from koha-misc4dev must be used instead.
This script existed before the creation of koha-misc4dev, it does no
longer make sense to have it in Koha.

Signed-off-by: David Nind <david at davidnind.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jan 11 12:09:11 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 11 Jan 2020 11:09:11 +0000
Subject: [Koha-bugs] [Bug 16137] Simplify patron deletion error handling
In-Reply-To: <bug-16137-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16137-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16137-70-SPUWgSNPrL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16137

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de

--- Comment #1 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Hi Owen, can you tell if this is the case? Not sure what to exactly test here.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jan 11 12:10:10 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 11 Jan 2020 11:10:10 +0000
Subject: [Koha-bugs] [Bug 16140] Only clear L1 cache when needed
In-Reply-To: <bug-16140-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16140-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16140-70-HUhArIVuH4@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16140

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de

--- Comment #33 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
(In reply to David Cook from comment #32)
> Sounds like this one might be worth closing

Should we close?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jan 11 12:13:44 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 11 Jan 2020 11:13:44 +0000
Subject: [Koha-bugs] [Bug 24352] OpacItemLocation is buggy
In-Reply-To: <bug-24352-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24352-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24352-70-RHYRiVPFU6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24352

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=16147

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jan 11 12:13:44 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 11 Jan 2020 11:13:44 +0000
Subject: [Koha-bugs] [Bug 16147] OpacItemLocation and not for circulation
 Item types
In-Reply-To: <bug-16147-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16147-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16147-70-sCqgQrYVq9@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16147

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=24352
                 CC|                            |katrin.fischer at bsz-bw.de,
                   |                            |oleonard at myacpl.org

--- Comment #1 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
I am not sure what the described issue here is. Linking to a more recent
OpacItemLocation bug. Owen, do you have an idea?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jan 11 12:15:48 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 11 Jan 2020 11:15:48 +0000
Subject: [Koha-bugs] [Bug 16181] Limit number of tags loaded initially for
 tag cloud
In-Reply-To: <bug-16181-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16181-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16181-70-dqP5Oaa5rl@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16181

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de

--- Comment #5 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Nick, is this still something we should work on?

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jan 11 12:22:10 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 11 Jan 2020 11:22:10 +0000
Subject: [Koha-bugs] [Bug 16247] Attaching PDFs to New Patron E-mail
In-Reply-To: <bug-16247-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16247-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16247-70-Dfa3N16r6j@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16247

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |WONTFIX
             Status|NEW                         |RESOLVED

--- Comment #4 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
I think this was solved with including a link for now - I think this will work
well unless you want to send a PDF with content generated specifically for a
transaction/patron. Moving WONTFIX for now.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jan 11 12:23:52 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 11 Jan 2020 11:23:52 +0000
Subject: [Koha-bugs] [Bug 16260] Have AllowHoldsOnPatronsPossessions check
 for multiple holds allowed on a record
In-Reply-To: <bug-16260-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16260-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16260-70-D1xEHQzduR@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16260

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de
            Summary|Moderate the impact of      |Have
                   |AllowHoldsOnPatronsPossessi |AllowHoldsOnPatronsPossessi
                   |ons                         |ons check for multiple
                   |                            |holds allowed on a record

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jan 11 12:27:06 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 11 Jan 2020 11:27:06 +0000
Subject: [Koha-bugs] [Bug 16291] koha-remove --purge should also delete
 '/etc/koha/sites/$instance' dir
In-Reply-To: <bug-16291-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16291-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16291-70-WVJD5ukQMc@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16291

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de,
                   |                            |mirko at abunchofthings.net
          Component|Tools                       |Packaging

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jan 11 12:28:15 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 11 Jan 2020 11:28:15 +0000
Subject: [Koha-bugs] [Bug 16294] Add items to list via OPAC search
 occasionally repeats previous selections
In-Reply-To: <bug-16294-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16294-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16294-70-6wj2U4slLL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16294

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de

--- Comment #1 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Hi Nick, do you want to keep this open or should we assume it fixed in current
versions?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jan 11 12:29:36 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 11 Jan 2020 11:29:36 +0000
Subject: [Koha-bugs] [Bug 16140] Only clear L1 cache when needed
In-Reply-To: <bug-16140-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16140-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16140-70-tdanCVQCUg@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16140

--- Comment #34 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
I do not think so, there are interesting ideas that could be reused.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jan 11 12:29:55 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 11 Jan 2020 11:29:55 +0000
Subject: [Koha-bugs] [Bug 16304] Koha::Logger,
 lazy load loggers so environment has time to get set
In-Reply-To: <bug-16304-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16304-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16304-70-pqUgSRQxls@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16304

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|BLOCKED                     |NEW

--- Comment #6 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
(In reply to Katrin Fischer from comment #5)
> Depends on bug 16312 which is Failed QA. Marking BLOCKED until dependency
> can be resolved.

Depeneny is set to NEW now, removing blocked in favor of new here as well.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jan 11 12:30:56 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 11 Jan 2020 11:30:56 +0000
Subject: [Koha-bugs] [Bug 16306] C4::Context->setCommandlineEnvironment()
 convenience function
In-Reply-To: <bug-16306-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16306-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16306-70-ZZiBZhy9fI@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16306

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de
             Status|Patch doesn't apply         |Failed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jan 11 12:37:28 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 11 Jan 2020 11:37:28 +0000
Subject: [Koha-bugs] [Bug 16335] Refactor OpacHiddenItems
In-Reply-To: <bug-16335-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16335-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16335-70-wAw2nB1Mco@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16335

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de

--- Comment #5 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Hi Mark, are you still working in this?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jan 11 12:41:36 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 11 Jan 2020 11:41:36 +0000
Subject: [Koha-bugs] [Bug 24402] New: Some roles missing from about page
Message-ID: <bug-24402-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24402

            Bug ID: 24402
           Summary: Some roles missing from about page
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: About
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: katrin.fischer at bsz-bw.de
        QA Contact: testopia at bugs.koha-community.org

When checking the about page, some roles are missing from the current
maintenance team listing:


Current maintenance team

    This is the team who are responsible for the next release of Koha and the
ongoing maintenance of your currently installed Koha version. They will be in
these roles up until 22.05.2020, when the next team will be elected.
    Release maintainer:
    Quality assurance manager: Katrin Fischer
    Quality assurance team:
        Jonathan Druart
        Marcel de Rooy
        Joonas Kylmälä
        Josef Moravec
        Tomás Cohen Arazi
        Nick Clemens
        Kyle Hall
    Documentation manager:
    Documentation team:
        Donna Bachowski
        Lucy Vaux-Harvey
        Sugandha Bajaj
    Packaging manager:
    Jenkins maintainers:
        Tomás Cohen Arazi
        Jonathan Druart
        Martin Renvoize 
    Bug wranglers:
        Michal Denár
        Cori Lynn Arnold
        Lisette Scheer
        Amit Gupta
    Release manager: Martin Renvoize
    Release manager assistants:
        Tomás Cohen Arazi
        Jonathan Druart


Missing: Documentation manager, Release maintainers, Packaging manager

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Sat Jan 11 12:50:51 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 11 Jan 2020 11:50:51 +0000
Subject: [Koha-bugs] [Bug 16349] Indicate what branches of Koha are supported
In-Reply-To: <bug-16349-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16349-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16349-70-Z59ngwFitl@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16349

--- Comment #8 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
I think having a list of supported versions could still be nice, we could also
use it to display an update recommendation for people running 'end of life'
versions.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Sat Jan 11 12:51:10 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 11 Jan 2020 11:51:10 +0000
Subject: [Koha-bugs] [Bug 16349] Indicate what branches of Koha are supported
In-Reply-To: <bug-16349-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16349-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16349-70-9xlQC4l5c7@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16349

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|In Discussion               |Patch doesn't apply

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Sat Jan 11 13:00:27 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 11 Jan 2020 12:00:27 +0000
Subject: [Koha-bugs] [Bug 16371] Quote of the Day (QOTD) for the staff
 interface
In-Reply-To: <bug-16371-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16371-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16371-70-t4TVyzNVj1@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16371

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de
            Summary|Quote of the Day (QOTD) -   |Quote of the Day (QOTD) for
                   |Display in different        |the staff interface
                   |interfaces                  |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jan 11 13:01:07 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 11 Jan 2020 12:01:07 +0000
Subject: [Koha-bugs] [Bug 16374] Support cataloging fanzines
In-Reply-To: <bug-16374-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16374-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16374-70-YGMaRFNUuL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16374

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |WORKSFORME

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jan 11 13:02:51 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 11 Jan 2020 12:02:51 +0000
Subject: [Koha-bugs] [Bug 16375] Add arg to 'koha-upgrade-schema' to run on
 a specific 'updatedb.pl' file
In-Reply-To: <bug-16375-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16375-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16375-70-0BEGv8pXrs@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16375

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de

--- Comment #1 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Hi Mason, what would that be used for?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jan 11 13:06:28 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 11 Jan 2020 12:06:28 +0000
Subject: [Koha-bugs] [Bug 16379] Add more tests for Statistics.pm
In-Reply-To: <bug-16379-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16379-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16379-70-QcfkKgiq3V@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16379

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Add tests for Statistics.pm |Add more tests for
                   |                            |Statistics.pm
          Component|Architecture, internals,    |Test Suite
                   |and plumbing                |
                 CC|                            |katrin.fischer at bsz-bw.de

--- Comment #1 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
There are 2 tests now - but probably could be more!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jan 11 13:10:07 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 11 Jan 2020 12:10:07 +0000
Subject: [Koha-bugs] [Bug 16392] Tips & Tricks?
In-Reply-To: <bug-16392-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16392-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16392-70-p5BFI1GLmo@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16392

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |WONTFIX
                 CC|                            |katrin.fischer at bsz-bw.de
             Status|In Discussion               |RESOLVED

--- Comment #5 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
I am not sure if this is a bug report still - we have the tips and tricks
category in the newsletter and google finds it... 

https://koha-community.org/category/koha-tips-tricks/

Recruiting people to write community blog posts is probably out of scope of
bugzilla :)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jan 11 13:10:16 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 11 Jan 2020 12:10:16 +0000
Subject: [Koha-bugs] [Bug 16392] Tips & Tricks?
In-Reply-To: <bug-16392-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16392-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16392-70-l15FDmrxGn@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16392

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|WONTFIX                     |WORKSFORME

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jan 11 13:11:50 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 11 Jan 2020 12:11:50 +0000
Subject: [Koha-bugs] [Bug 16409] Remove redundant
 'koha-tmpl/opac-tmpl/lib/famfamfam' dir
In-Reply-To: <bug-16409-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16409-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16409-70-MmXjfKtLNQ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16409

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |WORKSFORME
             Status|NEW                         |RESOLVED
                 CC|                            |katrin.fischer at bsz-bw.de

--- Comment #1 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
The famfamfam icons have been cleaned up quite a bit and includes only the
icons currently in use now. Looks all ok to me.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jan 11 13:14:18 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 11 Jan 2020 12:14:18 +0000
Subject: [Koha-bugs] [Bug 16413] Prototype for GetLatestAutoRenewDate and
 GetSoonestRenewDate should be changed
In-Reply-To: <bug-16413-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16413-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16413-70-5AmlItNon2@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16413

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de

--- Comment #17 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Jonathan, do you want to keep this one open or should we close it MOVED as it
should be fixed within the Koha namespace?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jan 11 13:17:19 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 11 Jan 2020 12:17:19 +0000
Subject: [Koha-bugs] [Bug 16422] Show warning if lost status is changed on a
 checked out item
In-Reply-To: <bug-16422-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16422-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16422-70-XSvifpzC4T@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16422

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|moremember.pl should show   |Show warning if lost status
                   |warning if lost status is   |is changed on a checked out
                   |changed on a checked out    |item
                   |item.                       |
                 CC|                            |katrin.fischer at bsz-bw.de

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Sat Jan 11 13:18:44 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 11 Jan 2020 12:18:44 +0000
Subject: [Koha-bugs] [Bug 16425] Advanced editor should be able to search,
 link and add authority records
In-Reply-To: <bug-16425-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16425-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16425-70-iLO2bMRZFN@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16425

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|NEW                         |RESOLVED

--- Comment #1 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
This has been fixed in current versions - it's now possible to link authorities
using a keyboard shortcut and a plugin like the one for the standard
cataloguing module.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jan 11 13:20:34 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 11 Jan 2020 12:20:34 +0000
Subject: [Koha-bugs] [Bug 16349] Indicate what branches of Koha are supported
In-Reply-To: <bug-16349-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16349-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16349-70-prN4HCjQbb@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16349

--- Comment #9 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
I think we should update this patch to use the dates and versions listed in the
yaml files shipped with the code. I don't see a reason to scrape externally for
it and add load to the website.

I'll have a go at putting something together if no-one beats me to it.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jan 11 13:20:45 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 11 Jan 2020 12:20:45 +0000
Subject: [Koha-bugs] [Bug 16349] Indicate what branches of Koha are supported
In-Reply-To: <bug-16349-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16349-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16349-70-mU3k8PQV8O@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16349

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |martin.renvoize at ptfs-europe
                   |ity.org                     |.com

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jan 11 13:35:04 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 11 Jan 2020 12:35:04 +0000
Subject: [Koha-bugs] [Bug 16446] Allow librarians to add borrowers to patron
 lists by borrowernumber
In-Reply-To: <bug-16446-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16446-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16446-70-cWnjpXZrPg@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16446

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
          Component|Lists                       |Tools
            Version|3.22                        |master
            Summary|Allow librarians to add     |Allow librarians to add
                   |borrowers to lists by       |borrowers to patron lists
                   |borrowernumber or           |by borrowernumber
                   |cardnumber                  |

--- Comment #3 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
There is an option to enter cardnumbers now, but no option for borrowernumbers.
Changing the bug title slightly.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jan 11 13:38:08 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 11 Jan 2020 12:38:08 +0000
Subject: [Koha-bugs] [Bug 16461] Add barcode and item type in fine
 description for overdue
In-Reply-To: <bug-16461-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16461-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16461-70-gPgj95L1wG@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16461

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Patch doesn't apply         |ASSIGNED
            Summary|Add some information        |Add barcode and item type
                   |(branch and barcode) in     |in fine description for
                   |fine description for        |overdue
                   |overdue                     |

--- Comment #13 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Updated to reflect changes on master and comments. Setting back to NEW for now,
as I think this will require a different/new approach than the existing patch.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jan 11 13:38:15 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 11 Jan 2020 12:38:15 +0000
Subject: [Koha-bugs] [Bug 16461] Add barcode and item type in fine
 description for overdue
In-Reply-To: <bug-16461-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16461-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16461-70-TLfrQSgnwA@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16461

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |NEW

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jan 11 13:41:07 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 11 Jan 2020 12:41:07 +0000
Subject: [Koha-bugs] [Bug 16466] Patron discharge page should show pending
 requests
In-Reply-To: <bug-16466-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16466-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16466-70-waMpSQIXf9@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16466

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de

--- Comment #1 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Still valid!
I think we should show a note on the checkouts (and details?) pages +
definitely options on the discharges tab.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Sat Jan 11 13:42:13 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 11 Jan 2020 12:42:13 +0000
Subject: [Koha-bugs] [Bug 16467] Discharge requests pending count should
 appear on patrons home page
In-Reply-To: <bug-16467-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16467-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16467-70-eLwETzlQVn@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16467

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=16466

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jan 11 13:42:13 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 11 Jan 2020 12:42:13 +0000
Subject: [Koha-bugs] [Bug 16466] Patron discharge page should show pending
 requests
In-Reply-To: <bug-16466-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16466-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16466-70-0ijBK0tFft@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16466

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=16467

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jan 11 13:43:54 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 11 Jan 2020 12:43:54 +0000
Subject: [Koha-bugs] [Bug 16482] Check-in page: Display can be broken in
 translations
In-Reply-To: <bug-16482-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16482-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16482-70-1tpPcCjVgU@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16482

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
                 CC|                            |katrin.fischer at bsz-bw.de
         Resolution|---                         |FIXED

--- Comment #1 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
The layout here has changes and the checkin options now display below the main
checkin form. This makes this invalid, but similar problems might appear in
other places - German words tend to be long and as there are no spaces, the
browsers can't break them on multiple lines.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jan 11 13:46:04 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 11 Jan 2020 12:46:04 +0000
Subject: [Koha-bugs] [Bug 16483] Ampersand breaks search for analytics
In-Reply-To: <bug-16483-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16483-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16483-70-1fofLBMex1@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16483

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de
         Resolution|---                         |FIXED
             Status|NEW                         |RESOLVED

--- Comment #1 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
I believe this to be fixed with the use of str:encode-uri in the XSLT files
now.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Sat Jan 11 13:47:55 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 11 Jan 2020 12:47:55 +0000
Subject: [Koha-bugs] [Bug 16486] Display the TIME a fine was
 collected/written off
In-Reply-To: <bug-16486-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16486-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16486-70-4dwWhYB44U@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16486

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
          Component|Circulation                 |Fines and fees

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jan 11 13:55:39 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 11 Jan 2020 12:55:39 +0000
Subject: [Koha-bugs] [Bug 16512] Route to library alert missing when item is
 checked in from checkouts list
In-Reply-To: <bug-16512-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16512-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16512-70-mkeUsdEXzl@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16512

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Version|3.22                        |master
            Summary|Route to library alert      |Route to library alert
                   |missing                     |missing when item is
                   |                            |checked in from checkouts
                   |                            |list
                 CC|                            |katrin.fischer at bsz-bw.de

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jan 11 13:57:19 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 11 Jan 2020 12:57:19 +0000
Subject: [Koha-bugs] [Bug 16522] Add 773 (Host item entry) to the cart
 display and e-mail
In-Reply-To: <bug-16522-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16522-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16522-70-Ft8oJ0kX2I@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16522

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=3150

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jan 11 13:57:19 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 11 Jan 2020 12:57:19 +0000
Subject: [Koha-bugs] [Bug 3150] Move emails for sending cart and list
 contents into notices tool
In-Reply-To: <bug-3150-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-3150-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-3150-70-C7Sk3fuMHx@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3150

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=16522

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jan 11 13:58:22 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 11 Jan 2020 12:58:22 +0000
Subject: [Koha-bugs] [Bug 16523] Ability to choose NONE for the libraries
 limitation in authorised values
In-Reply-To: <bug-16523-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16523-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16523-70-FhG81136Rv@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16523

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Patch doesn't apply         |ASSIGNED
                 CC|                            |katrin.fischer at bsz-bw.de

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jan 11 13:58:27 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 11 Jan 2020 12:58:27 +0000
Subject: [Koha-bugs] [Bug 16523] Ability to choose NONE for the libraries
 limitation in authorised values
In-Reply-To: <bug-16523-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16523-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16523-70-g0Mar9RLlA@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16523

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |NEW

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jan 11 14:01:53 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 11 Jan 2020 13:01:53 +0000
Subject: [Koha-bugs] [Bug 23571] fines.pl may block server
In-Reply-To: <bug-23571-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23571-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23571-70-iPEVfECJsu@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23571

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=16528
                 CC|                            |katrin.fischer at bsz-bw.de

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jan 11 14:01:53 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 11 Jan 2020 13:01:53 +0000
Subject: [Koha-bugs] [Bug 16528] Add ability to parallel process fines to
 fines.pl
In-Reply-To: <bug-16528-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16528-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16528-70-MLt8fOhiUE@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16528

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=23571

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jan 11 14:07:46 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 11 Jan 2020 13:07:46 +0000
Subject: [Koha-bugs] [Bug 16547] Can't place item level hold directly from
 search results screen
In-Reply-To: <bug-16547-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16547-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16547-70-Dk0HpcF1MV@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16547

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de

--- Comment #3 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Maybe we could send the user to the normal holds page if only one record was
selected?

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Sat Jan 11 14:12:31 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 11 Jan 2020 13:12:31 +0000
Subject: [Koha-bugs] [Bug 16559] [%% ... %%] should not be picked for
 translation
In-Reply-To: <bug-16559-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16559-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16559-70-HjGf1SP89l@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16559

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de

--- Comment #7 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
We still have some strange constructions in the po files, although it's not
that many. If you search for [%% you get 76 hits over all current translation
files:

", "dt_sortby": %s"Verfasser"%s"Jahr"%s"Signatur"%s"Titel"%s, "dt_created_on":
"%s", "dt_modification_time": "%s", "dt_action": "%s" }%s,%s %s ] } %s %s %s %s
[%%~ action_block = '

[%% SET countries = [ "Afghanistan", "Albanien", "Algerien", "Andorra",
"Angola", "Antigua & Barbuda", "Argentinien", "Armenien", "Australien",
"Österreich", "Aserbaidschan", "Bahamas", "Bahrain", "Bangladesch", "Barbados",
"Weißrussland", "Belgien", "Belize", "Benin", "Bhutan", "Bolivien", "Bosnien
Herzegowina", "Botswana", "Brasilien", "Brunei", "Bulgarien", "Burkina",
"Burundi", "Kambodscha", "Kamerun", "Kanada", "Cap Verde", "Zentralafrikanische
Republik", "Tschad", "Chile", "China", "Kolumbien", "Komoren", "Kongo", "Costa
Rica", "Kroatien", "Kuba", "Zypern", "Tschechische Republik", "Dänemark",
"Dschibuti", "Dominica", "Dominikanische Republik", "Osttimor", "Ecuador",
"Ägypten", "El Salvador", "Äquatorialguinea", "Eritrea", "Estland",
"Äthiopien", "Fidschi", "Finnland", "Frankreich", "Gabun", "Gambia",
"Georgien", "Deutschland", "Ghana", "Griechenland", "Grenada", "Guatemala",
"Guinea", "Guinea-Bissau", "Guyana", "Haiti", "Honduras", "Ungarn", "Island",
"Indien", "Indonesien", "Iran", "Irak", "Irland", "Israel", "Italien",
"Elfenbeinküste", "Jamaika", "Japan", "Jordanien", "Kasachstan", "Kenia",
"Kiribati", "Nordkorea", "Südkorea", "Kosovo", "Kuwait", "Kirgisistan", "Laos",
"Lettland", "Libanon", "Lesotho", "Liberia", "Libyen", "Liechtenstein",
"Litauen", "Luxemburg", "Mazedonien", "Madagaskar", "Malawi", "Malaysia",
"Malediven", "Mali", "Malta", "Marshallinseln", "Mauretanien", "Mauritius",
"Mexiko", "Mikronesien", "Moldavien", "Monaco", "Mongolei", "Montenegro",
"Morokko", "Mosambik", "Myanmar", "Namibia", "Nauru", "Nepal", "Niederlande",
"Neuseeland", "Nicaragua", "Niger", "Nigeria", "Norwegen", "Oman", "Pakistan",
"Palau", "Panama", "Papua Neuguinea", "Paraguay", "Peru", "Philippinen",
"Polen", "Portugal", "Qatar", "Rumänien", "Russische Föderation", "Ruanda", "St
Kitts & Nevis", "St. Lucia", "St. Vincent", "Samoa", "San Marino", "São Tomé",
"Saudiarabien", "Senegal", "Serbien", "Seychellen", "Sierra Leone", "Singapur",
"Slowakei", "Slowenien", "Solomoninseln", "Somalia", "Südafrika", "Spanien",
"Sri Lanka", "Sudan", "Surinam", "Swasiland", "Schweden", "Schweiz", "Syrien",
"Taiwan", "Tadschikistan", "Tansania", "Thailand", "Togo", "Tonga", "Trinidad &
Tobago", "Tunesien", "Türkei", "Turkmenistan", "Tuvalu", "Uganda", "Ukraine",
"Vereinigte Arabische Emirate", "Vereinigtes Königreich", "Vereinigte Staaten
von Amerika", "Uruguay", "Usbekistan", "Vanuatu", "Vatikan", "Venezuela",
"Vietnam", "Jemen", "Sambia", "Simbabwe", ] %%]

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Sat Jan 11 14:15:37 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 11 Jan 2020 13:15:37 +0000
Subject: [Koha-bugs] [Bug 16581] ICU tokenization bug in idzebra-2.0 2.0.59-1
In-Reply-To: <bug-16581-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16581-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16581-70-hzra7gCEmN@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16581

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
          Component|Searching                   |Packaging

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jan 11 14:16:37 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 11 Jan 2020 13:16:37 +0000
Subject: [Koha-bugs] [Bug 16604] Break down patron modification requests for
 approval/give reasons for denials/allow corrections
In-Reply-To: <bug-16604-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16604-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16604-70-bZA4dWbv5W@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16604

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Version|3.22                        |master
                 CC|                            |katrin.fischer at bsz-bw.de,
                   |                            |kyle.m.hall at gmail.com
          Component|Staff Client                |Patrons

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Sat Jan 11 14:17:50 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 11 Jan 2020 13:17:50 +0000
Subject: [Koha-bugs] [Bug 16605] All notices should give the ability to
 unsubscribe or flag account for a wrong email address used
In-Reply-To: <bug-16605-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16605-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16605-70-whv9CO4R8d@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16605

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|All notices should give the |All notices should give the
                   |ability to unsubscribe or   |ability to unsubscribe or
                   |flag account                |flag account for a wrong
                   |                            |email address used
                 CC|                            |katrin.fischer at bsz-bw.de
            Version|3.22                        |master

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jan 11 14:19:13 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 11 Jan 2020 13:19:13 +0000
Subject: [Koha-bugs] [Bug 16606] Checkout settings dropdown should have a
 preference to stay open all the time
In-Reply-To: <bug-16606-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16606-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16606-70-phjXyhEEQb@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16606

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Version|3.22                        |master

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jan 11 14:20:35 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 11 Jan 2020 13:20:35 +0000
Subject: [Koha-bugs] [Bug 16623] Limit patron discharge management by library
In-Reply-To: <bug-16623-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16623-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16623-70-bw7u1Kb00t@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16623

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jan 11 14:22:17 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 11 Jan 2020 13:22:17 +0000
Subject: [Koha-bugs] [Bug 24293] Schema needs 19.11 and 20.05 added
In-Reply-To: <bug-24293-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24293-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24293-70-l2pGqbHadm@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24293

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Schema needs 19.11 added    |Schema needs 19.11 and
                   |                            |20.05 added

--- Comment #1 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Same now for 20.05

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jan 11 14:26:44 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 11 Jan 2020 13:26:44 +0000
Subject: [Koha-bugs] [Bug 16629] SpineLabelFormat should be able to use
 fields/subfields from the record like the other label tools
In-Reply-To: <bug-16629-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16629-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16629-70-IbrgrwNuqi@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16629

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de
            Summary|Fields available for        |SpineLabelFormat should be
                   |printing are inconsistent   |able to use
                   |between label layouts and   |fields/subfields from the
                   |SpineLablFormat system      |record like the other label
                   |preference                  |tools

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jan 11 14:31:26 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 11 Jan 2020 13:31:26 +0000
Subject: [Koha-bugs] [Bug 16639] Split item data from description in Fines
 tab into separate columns
In-Reply-To: <bug-16639-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16639-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16639-70-bR14DKkuaX@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16639

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
          Component|Circulation                 |Fines and fees
                 CC|                            |katrin.fischer at bsz-bw.de
         Resolution|---                         |DUPLICATE
             Status|NEW                         |RESOLVED

--- Comment #4 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---


*** This bug has been marked as a duplicate of bug 16461 ***

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jan 11 14:31:26 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 11 Jan 2020 13:31:26 +0000
Subject: [Koha-bugs] [Bug 16461] Add barcode and item type in fine
 description for overdue
In-Reply-To: <bug-16461-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16461-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16461-70-hbS47fREVR@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16461

--- Comment #14 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
*** Bug 16639 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jan 11 14:39:46 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 11 Jan 2020 13:39:46 +0000
Subject: [Koha-bugs] [Bug 16656] Add option to send patron search results to
 bath patron modification without using patron lists
In-Reply-To: <bug-16656-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16656-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16656-70-WKVcLwthSD@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16656

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED
            Summary|Allow selecting patrons by  |Add option to send patron
                   |category option on batch    |search results to bath
                   |patron modification         |patron modification without
                   |                            |using patron lists

--- Comment #2 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
I think it might be a nice addition to send results to patron batch mod without
the detour using patron lists - that could be a good compromise here and avoid
for us to have to duplicate the full patron search for the tool over time.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jan 11 14:40:18 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 11 Jan 2020 13:40:18 +0000
Subject: [Koha-bugs] [Bug 16656] Add option to send patron search results to
 bath patron modification without using patron lists
In-Reply-To: <bug-16656-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16656-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16656-70-891fd1mbNZ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16656

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |REOPENED
         Resolution|FIXED                       |---

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jan 11 14:40:23 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 11 Jan 2020 13:40:23 +0000
Subject: [Koha-bugs] [Bug 16656] Add option to send patron search results to
 bath patron modification without using patron lists
In-Reply-To: <bug-16656-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16656-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16656-70-sYqNC9H078@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16656

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|REOPENED                    |NEW

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jan 11 14:44:42 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 11 Jan 2020 13:44:42 +0000
Subject: [Koha-bugs] [Bug 16679] Translatability problems in system
 preferences
In-Reply-To: <bug-16679-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16679-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16679-70-VfIDo9YnDt@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16679

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de

--- Comment #2 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
I disagree with the solution - I think this brings us straight back to the
previous system preferences editor (not a lot might remember). I think the
ideal solution would be to be able to tanslate the whole pref values in one go
instead of splitting them up in the translation tools. Having something like

[Allow|Dont'allow] staff patrons to do x.

With the option to move around the first bit within the sentence.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Sat Jan 11 14:50:27 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 11 Jan 2020 13:50:27 +0000
Subject: [Koha-bugs] [Bug 16698] Prefs like UpdateItemLocationOnCheckin need
 a GUI editor
In-Reply-To: <bug-16698-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16698-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16698-70-1sHQJfkUEG@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16698

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de
            Summary|UpdateItemLocationOnCheckin |Prefs like
                   |preference needs a gui      |UpdateItemLocationOnCheckin
                   |editor                      |need a GUI editor

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jan 11 14:54:09 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 11 Jan 2020 13:54:09 +0000
Subject: [Koha-bugs] [Bug 16721] Add table configuration to serial claims
 table
In-Reply-To: <bug-16721-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16721-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16721-70-lIKUKDFggh@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16721

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Serial claims table too     |Add table configuration to
                   |wide                        |serial claims table

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jan 11 15:01:20 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 11 Jan 2020 14:01:20 +0000
Subject: [Koha-bugs] [Bug 16771] Use TT Price plugin to display monetary
 amounts formatted
In-Reply-To: <bug-16771-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16771-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16771-70-6hZddvaWax@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16771

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |MOVED

--- Comment #1 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
This was supposed to be an omnibus bug, but I think by now we have separate
bugs for remaining issues and they got quite rare. Closing.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jan 11 15:04:01 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 11 Jan 2020 14:04:01 +0000
Subject: [Koha-bugs] [Bug 16783] MARC 008 Material Type change back to CR
In-Reply-To: <bug-16783-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16783-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16783-70-9z8Yi3Drcp@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16783

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
                 CC|                            |katrin.fischer at bsz-bw.de
         Resolution|---                         |DUPLICATE

--- Comment #2 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---


*** This bug has been marked as a duplicate of bug 19419 ***

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jan 11 15:04:01 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 11 Jan 2020 14:04:01 +0000
Subject: [Koha-bugs] [Bug 19419] 008 Material type reverts Book
In-Reply-To: <bug-19419-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19419-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19419-70-gGWxfUpnEV@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19419

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |iming at rosewoodfarm.com.au

--- Comment #3 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
*** Bug 16783 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Sat Jan 11 15:05:42 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 11 Jan 2020 14:05:42 +0000
Subject: [Koha-bugs] [Bug 16784] Add table configuration on suggestions table
In-Reply-To: <bug-16784-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16784-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16784-70-QJduENxgBZ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16784

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Export suggestions from     |Add table configuration on
                   |OPAC as CSV                 |suggestions table
                 CC|                            |katrin.fischer at bsz-bw.de

--- Comment #4 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Maybe we could add the table configuration with the new export options to the
suggestions table. That could solve multiple issues at once.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jan 11 15:08:45 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 11 Jan 2020 14:08:45 +0000
Subject: [Koha-bugs] [Bug 16791] Explanation of callnumber.pl plugin
In-Reply-To: <bug-16791-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16791-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16791-70-9Gst8TXuau@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16791

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Version|3.22                        |master
           Keywords|                            |Manual

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jan 11 15:10:42 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 11 Jan 2020 14:10:42 +0000
Subject: [Koha-bugs] [Bug 16797] errors in UNIMARC complet sample authorities
In-Reply-To: <bug-16797-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16797-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16797-70-axkUhYXT52@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16797

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=18309
                 CC|                            |katrin.fischer at bsz-bw.de

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jan 11 15:10:42 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 11 Jan 2020 14:10:42 +0000
Subject: [Koha-bugs] [Bug 18309] UNIMARC update from IFLA for new Koha
 installations
In-Reply-To: <bug-18309-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18309-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18309-70-eKgK7QsMFK@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18309

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=16797

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jan 11 15:13:54 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 11 Jan 2020 14:13:54 +0000
Subject: [Koha-bugs] [Bug 16799] Header search in staff doesn't wrap nicley
 whenIntranetCatalogSearchPulldown is used
In-Reply-To: <bug-16799-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16799-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16799-70-l7hr8l1vmk@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16799

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|header_search is too wide   |Header search in staff
                   |when                        |doesn't wrap nicley
                   |IntranetCatalogSearchPulldo |whenIntranetCatalogSearchPu
                   |wn is enabled.              |lldown is used
                 CC|                            |katrin.fischer at bsz-bw.de

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jan 11 15:16:55 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 11 Jan 2020 14:16:55 +0000
Subject: [Koha-bugs] [Bug 16804] Searching can be broken by search terms
 containing semicolons in XSLT
In-Reply-To: <bug-16804-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16804-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16804-70-DM8Tjxb6Eb@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16804

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|In Discussion               |RESOLVED
         Resolution|---                         |DUPLICATE

--- Comment #18 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Marking resolved fixed as the url-encoding with the exslt function now solves
this nicely.

*** This bug has been marked as a duplicate of bug 14716 ***

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jan 11 15:16:55 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 11 Jan 2020 14:16:55 +0000
Subject: [Koha-bugs] [Bug 14716] Correctly URI-encode URLs in XSLT result
 lists and detail pages
In-Reply-To: <bug-14716-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14716-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14716-70-1WLK9xmqFQ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14716

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |kyle at bywatersolutions.com

--- Comment #76 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
*** Bug 16804 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jan 11 15:17:35 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 11 Jan 2020 14:17:35 +0000
Subject: [Koha-bugs] [Bug 16820] Add possibility to edit fines
In-Reply-To: <bug-16820-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16820-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16820-70-N59SofaIUF@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16820

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
          Component|Circulation                 |Fines and fees

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jan 11 15:19:07 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 11 Jan 2020 14:19:07 +0000
Subject: [Koha-bugs] [Bug 16821] Display complete facets for home libraries,
 locations, item types
In-Reply-To: <bug-16821-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16821-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16821-70-KFs7MKpmZY@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16821

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Facets: home libraries,     |Display complete facets for
                   |locations, item types       |home libraries, locations,
                   |                            |item types

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jan 11 15:20:03 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 11 Jan 2020 14:20:03 +0000
Subject: [Koha-bugs] [Bug 16824] No branchcode argument passed to
 Koha::Calendar->new at /usr/share/koha/lib/C4/Circulation.pm line 3423.
In-Reply-To: <bug-16824-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16824-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16824-70-tD8cs86lCz@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16824

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
                 CC|                            |katrin.fischer at bsz-bw.de
         Resolution|---                         |INVALID

--- Comment #1 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
This was reported against a very old version and contains not enough
information to test/fix. Closing invalid.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jan 11 15:22:56 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 11 Jan 2020 14:22:56 +0000
Subject: [Koha-bugs] [Bug 16827] Remove "by" before primary access point.
In-Reply-To: <bug-16827-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16827-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16827-70-tzjNvybR5n@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16827

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de
         Resolution|---                         |FIXED
             Status|NEW                         |RESOLVED

--- Comment #1 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
The by has its own CSS class an can be easily removed from the display using
the OPACUserCSS and IntranetUserCSS preferences now:

.byAuthor { display:none; }

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jan 11 15:27:33 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 11 Jan 2020 14:27:33 +0000
Subject: [Koha-bugs] [Bug 16839] Sort Title (A-Z) doesn't work with some
 non-latin alphabets
In-Reply-To: <bug-16839-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16839-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16839-70-eGlHE5OaUe@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16839

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de

--- Comment #1 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
I believe both ICU and chr use the same Zebra sort file. Which file is used is
determined on installation time, as we have different versions for different
language code. The default en file doesn't include sorting for cyrillig or
greek, others do. Maybe we should try and create a more complete standard file.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jan 11 15:36:17 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 11 Jan 2020 14:36:17 +0000
Subject: [Koha-bugs] [Bug 16137] Simplify patron deletion error handling
In-Reply-To: <bug-16137-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16137-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16137-70-mwYC7PToQQ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16137

--- Comment #2 from Owen Leonard <oleonard at myacpl.org> ---
Patron deletion errors/warnings handled by deletemem.pl:

 - Warning when you try to delete a patron with holds
 - Warning when you try to delete a patron with checkouts
 - Warning when you try to delete a patron with guarantees

Patron deletion errors/warnings handled by moremember.pl:

 - Unable to delete staff user
 - Not allowed to delete own account
 - Unable to delete patrons from other libraries with current settings
 - Unable to delete patron: Insufficient privileges

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jan 11 15:40:16 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 11 Jan 2020 14:40:16 +0000
Subject: [Koha-bugs] [Bug 16930] Search returns no results if "and" appears
 before a colon
In-Reply-To: <bug-16930-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16930-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16930-70-wcHEmeotJ3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16930

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         QA Contact|testopia at bugs.koha-communit |
                   |y.org                       |
                 CC|                            |katrin.fischer at bsz-bw.de
          Component|Searching                   |Searching - Zebra

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jan 11 15:40:57 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 11 Jan 2020 14:40:57 +0000
Subject: [Koha-bugs] [Bug 24352] OpacItemLocation is buggy
In-Reply-To: <bug-24352-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24352-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24352-70-jiP6cPy6st@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24352

--- Comment #4 from Owen Leonard <oleonard at myacpl.org> ---
David, it sounds like you're seeing what Katrin was seeing, but I don't know
what might be different about our setup/data to cause it--assuming you're
looking at records which have call numbers?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jan 11 15:43:00 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 11 Jan 2020 14:43:00 +0000
Subject: [Koha-bugs] [Bug 16147] OpacItemLocation and not for circulation
 Item types
In-Reply-To: <bug-16147-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16147-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16147-70-hoMhm9LSt5@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16147

--- Comment #2 from Owen Leonard <oleonard at myacpl.org> ---
Assuming you see the call number at all (see Bug 24352), I think this is the
display that is intended by the design of the preference. I agree however that
it probably isn't the best way to display the information.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jan 11 15:43:16 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 11 Jan 2020 14:43:16 +0000
Subject: [Koha-bugs] [Bug 16147] OpacItemLocation and not for circulation
 Item types
In-Reply-To: <bug-16147-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16147-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16147-70-n0HweE1ysK@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16147

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Version|3.22                        |master

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jan 11 15:44:43 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 11 Jan 2020 14:44:43 +0000
Subject: [Koha-bugs] [Bug 16943] OverduesBlockCheckout repeatedly asks for
 confirmation
In-Reply-To: <bug-16943-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16943-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16943-70-IKuD8kJ2Gv@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16943

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |DUPLICATE
             Status|NEW                         |RESOLVED
                 CC|                            |katrin.fischer at bsz-bw.de

--- Comment #3 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---


*** This bug has been marked as a duplicate of bug 14787 ***

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Sat Jan 11 15:44:43 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 11 Jan 2020 14:44:43 +0000
Subject: [Koha-bugs] [Bug 14787] Allow confirm/continue option to circ
 warnings at checkout
In-Reply-To: <bug-14787-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14787-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14787-70-zOYhM1DI5O@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14787

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |arm at hanover.ca

--- Comment #2 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
*** Bug 16943 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jan 11 15:46:18 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 11 Jan 2020 14:46:18 +0000
Subject: [Koha-bugs] [Bug 16959] E-mail alerts for saved searches
In-Reply-To: <bug-16959-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16959-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16959-70-JAufslkVKt@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16959

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|enhancement                 |new feature

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jan 11 15:48:03 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 11 Jan 2020 14:48:03 +0000
Subject: [Koha-bugs] [Bug 16979] Search for barcode containing parentheses
 fails
In-Reply-To: <bug-16979-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16979-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16979-70-VoJFiU1K8S@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16979

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
          Component|Searching                   |Searching - Zebra
         QA Contact|testopia at bugs.koha-communit |
                   |y.org                       |
                 CC|                            |katrin.fischer at bsz-bw.de

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jan 11 15:53:37 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 11 Jan 2020 14:53:37 +0000
Subject: [Koha-bugs] [Bug 17093] JavaScript error on patron entry page if
 toolbar is not displayed
In-Reply-To: <bug-17093-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17093-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17093-70-HF1qKms0Rz@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17093

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de

--- Comment #1 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
It feels like this could only happen if you work with the db user and have
managed to not create the values in the installer (onboardig) somehow - should
we mark WONTFIX?

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Sat Jan 11 15:56:24 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 11 Jan 2020 14:56:24 +0000
Subject: [Koha-bugs] [Bug 17113] Unable to search multi-domain Active
 Directory forest due LDAP required base
In-Reply-To: <bug-17113-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17113-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17113-70-g8pBqxWQM4@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17113

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de
            Version|3.22                        |master

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jan 11 16:01:55 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 11 Jan 2020 15:01:55 +0000
Subject: [Koha-bugs] [Bug 17145] Cannot upload .mrc file for staging Marc
 records
In-Reply-To: <bug-17145-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17145-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17145-70-PSFQbeMz3X@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17145

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |INVALID
             Status|NEW                         |RESOLVED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jan 11 16:02:59 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 11 Jan 2020 15:02:59 +0000
Subject: [Koha-bugs] [Bug 17150] Enhance cancelling holds over process
 [OMNIBUS]
In-Reply-To: <bug-17150-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17150-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17150-70-aJE1kmn2wj@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17150

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de
            Summary|Cancelling holds over       |Enhance cancelling holds
                   |process needs improvement   |over process [OMNIBUS]

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jan 11 16:06:18 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 11 Jan 2020 15:06:18 +0000
Subject: [Koha-bugs] [Bug 17198] KOha database resotre
In-Reply-To: <bug-17198-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17198-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17198-70-eVbhwab1dx@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17198

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |INVALID
                 CC|                            |katrin.fischer at bsz-bw.de
             Status|NEW                         |RESOLVED

--- Comment #1 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
This is more of a support request and more than 3 years old -- closing.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jan 11 16:08:00 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 11 Jan 2020 15:08:00 +0000
Subject: [Koha-bugs] [Bug 17207] Cannot access the website from China
In-Reply-To: <bug-17207-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17207-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17207-70-AFg9InE10m@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17207

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de

--- Comment #2 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
I believe this is nothing that can be solved on our side. Should we close?

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jan 11 16:13:55 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 11 Jan 2020 15:13:55 +0000
Subject: [Koha-bugs] [Bug 17259] Allow batch removal of restrictions
In-Reply-To: <bug-17259-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17259-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17259-70-VP5oCBZwI1@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17259

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
                 CC|                            |katrin.fischer at bsz-bw.de
         Resolution|---                         |DUPLICATE

--- Comment #2 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---


*** This bug has been marked as a duplicate of bug 13552 ***

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Sat Jan 11 16:13:55 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 11 Jan 2020 15:13:55 +0000
Subject: [Koha-bugs] [Bug 13552] Add debar option to batch patron
 modification
In-Reply-To: <bug-13552-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13552-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13552-70-c3gwquRCpl@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13552

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |nick at bywatersolutions.com

--- Comment #16 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
*** Bug 17259 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jan 11 16:19:35 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 11 Jan 2020 15:19:35 +0000
Subject: [Koha-bugs] [Bug 17306] Update scripts fail with Mysql 5.7
In-Reply-To: <bug-17306-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17306-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17306-70-SOkSeHLzlz@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17306

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de
             Blocks|                            |17258


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17258
[Bug 17258] [OMNIBUS] MySQL 5.7
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jan 11 16:19:35 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 11 Jan 2020 15:19:35 +0000
Subject: [Koha-bugs] [Bug 17258] [OMNIBUS] MySQL 5.7
In-Reply-To: <bug-17258-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17258-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17258-70-H1Tpw0Yd3a@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17258

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |17306


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17306
[Bug 17306] Update scripts fail with Mysql 5.7
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jan 11 16:22:03 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 11 Jan 2020 15:22:03 +0000
Subject: [Koha-bugs] [Bug 17279] Edifact::Line quantity should ensure its
 returning invoiced quantity
In-Reply-To: <bug-17279-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17279-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17279-70-wSKLGp2g2t@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17279

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de

--- Comment #4 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Should this be FAILED QA?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jan 11 16:28:06 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 11 Jan 2020 15:28:06 +0000
Subject: [Koha-bugs] [Bug 17360] Test the installer process
In-Reply-To: <bug-17360-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17360-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17360-70-bHaT41U9HJ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17360

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de

--- Comment #2 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
After the recent problem with broken installers, could this be something we
could do on Jenkins? (Make sure all the translated sample files install
correctly)?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jan 11 16:34:07 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 11 Jan 2020 15:34:07 +0000
Subject: [Koha-bugs] [Bug 17406] Simplify pay.pl interface buttons
In-Reply-To: <bug-17406-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17406-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17406-70-R2d0ZP3slg@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17406

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
          Component|Circulation                 |Fines and fees
                 CC|                            |katrin.fischer at bsz-bw.de

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Sat Jan 11 16:34:44 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 11 Jan 2020 15:34:44 +0000
Subject: [Koha-bugs] [Bug 17408] paycollect.pl should show more information
In-Reply-To: <bug-17408-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17408-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17408-70-3tEohdzWli@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17408

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de
          Component|Circulation                 |Fines and fees

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jan 11 16:35:19 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 11 Jan 2020 15:35:19 +0000
Subject: [Koha-bugs] [Bug 17409] Remove redundant note fields for payments
 on pay.pl
In-Reply-To: <bug-17409-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17409-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17409-70-F2XiEGqbS6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17409

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
          Component|Circulation                 |Fines and fees
                 CC|                            |katrin.fischer at bsz-bw.de

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Sat Jan 11 16:36:05 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 11 Jan 2020 15:36:05 +0000
Subject: [Koha-bugs] [Bug 17412] Circulation rule for "not for loan" items
In-Reply-To: <bug-17412-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17412-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17412-70-ppGW4foxrK@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17412

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de
             Status|BLOCKED                     |NEW
            Version|16.05                       |master

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jan 11 16:37:43 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 11 Jan 2020 15:37:43 +0000
Subject: [Koha-bugs] [Bug 17413] Translatability: Rental fee,
 Renewal of Rental Item etc. are hard coded
In-Reply-To: <bug-17413-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17413-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17413-70-LxGKD1rDEG@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17413

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED
                 CC|                            |katrin.fischer at bsz-bw.de

--- Comment #1 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
I believe these were fixed in the Accounts work done in the last few versions.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Sat Jan 11 16:39:21 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 11 Jan 2020 15:39:21 +0000
Subject: [Koha-bugs] [Bug 17421] Missing dependency on CGI::Emulate::PSGI
In-Reply-To: <bug-17421-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17421-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17421-70-aKIBOTy4XE@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17421

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de,
                   |                            |mirko at abunchofthings.net
          Component|Installation and upgrade    |Packaging
                   |(command-line installer)    |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jan 11 16:40:03 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 11 Jan 2020 15:40:03 +0000
Subject: [Koha-bugs] [Bug 17429] Document the --plack option for koha-list
In-Reply-To: <bug-17429-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17429-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17429-70-cpQs3kGyxZ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17429

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |Academy
                 CC|                            |katrin.fischer at bsz-bw.de

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jan 11 16:46:01 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 11 Jan 2020 15:46:01 +0000
Subject: [Koha-bugs] [Bug 17454] [OMNIBUS] POD Cleanup
In-Reply-To: <bug-17454-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17454-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17454-70-NCCPCfHMcb@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17454

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Omnibus POD Cleanup         |[OMNIBUS] POD Cleanup
                 CC|                            |katrin.fischer at bsz-bw.de

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jan 11 16:46:29 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 11 Jan 2020 15:46:29 +0000
Subject: [Koha-bugs] [Bug 23443] Paying off a lost fee will return the item,
 even if it is checked out to a different patron
In-Reply-To: <bug-23443-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23443-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23443-70-L4v2KmPrIw@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23443

Andrew Fuerste-Henry <andrew at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|normal                      |major

--- Comment #1 from Andrew Fuerste-Henry <andrew at bywatersolutions.com> ---
Bumping up the severity on this bug as it's pretty messy and I just ran into it
with another library.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Sat Jan 11 16:49:07 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 11 Jan 2020 15:49:07 +0000
Subject: [Koha-bugs] [Bug 17464] Order deny,
 allow / Deny from all was deprecated in Apache 2.4 and is now a
 hard error
In-Reply-To: <bug-17464-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17464-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17464-70-rX4yACvfOV@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17464

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de

--- Comment #1 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
I still can find to "Deny from all" doing a git grep on the current codebase.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jan 11 16:52:21 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 11 Jan 2020 15:52:21 +0000
Subject: [Koha-bugs] [Bug 17483] Forgiving charge should apply to item's
 last fine.
In-Reply-To: <bug-17483-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17483-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17483-70-wGbutnnJBp@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17483

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de
          Component|Circulation                 |Fines and fees

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jan 11 16:53:29 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 11 Jan 2020 15:53:29 +0000
Subject: [Koha-bugs] [Bug 17489] Allow Koha plugins to have translations
In-Reply-To: <bug-17489-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17489-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17489-70-BuAv3aeTgj@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17489

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |tomascohen at gmail.com

--- Comment #5 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Tomas, I believe you had found a solution to this?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jan 11 16:54:52 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 11 Jan 2020 15:54:52 +0000
Subject: [Koha-bugs] [Bug 17360] Test the installer process
In-Reply-To: <bug-17360-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17360-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17360-70-6oCLrAx3If@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17360

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |DUPLICATE

--- Comment #3 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---


*** This bug has been marked as a duplicate of bug 19185 ***

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jan 11 16:54:52 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 11 Jan 2020 15:54:52 +0000
Subject: [Koha-bugs] [Bug 19185] Web installer and onboarding tool selenium
 test
In-Reply-To: <bug-19185-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19185-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19185-70-5zK3ghM0Ss@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19185

--- Comment #26 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
*** Bug 17360 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jan 11 16:55:52 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 11 Jan 2020 15:55:52 +0000
Subject: [Koha-bugs] [Bug 17506] Offline circ needs to be logged
In-Reply-To: <bug-17506-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17506-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17506-70-dP7G1Ef3aO@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17506

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |22794
                 CC|                            |katrin.fischer at bsz-bw.de


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22794
[Bug 22794] Omnibus: Improve and extend logging in Koha
-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jan 11 16:55:52 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 11 Jan 2020 15:55:52 +0000
Subject: [Koha-bugs] [Bug 22794] Omnibus: Improve and extend logging in Koha
In-Reply-To: <bug-22794-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22794-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22794-70-w9oUGyq2du@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22794

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |17506


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17506
[Bug 17506] Offline circ needs to be logged
-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jan 11 16:57:23 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 11 Jan 2020 15:57:23 +0000
Subject: [Koha-bugs] [Bug 23443] Paying off a lost fee will return the item,
 even if it is checked out to a different patron
In-Reply-To: <bug-23443-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23443-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23443-70-59I3TvFkv0@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23443

J. Evans <jennie.evans at flower-mound.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jennie.evans at flower-mound.c
                   |                            |om

--- Comment #2 from J. Evans <jennie.evans at flower-mound.com> ---
We're one of the libraries affected by this. We have discovered that it will
check the item in even if the item is currently checked out to another patron.
That's not good!

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Sat Jan 11 16:57:34 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 11 Jan 2020 15:57:34 +0000
Subject: [Koha-bugs] [Bug 17510] MARC modification templates ignore subfield
 $0
In-Reply-To: <bug-17510-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17510-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17510-70-82dsl41yK9@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17510

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Version|16.11                       |master
                 CC|                            |katrin.fischer at bsz-bw.de
            Summary|marc modification templates |MARC modification templates
                   |ignore subfield $0          |ignore subfield $0

--- Comment #3 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Haven't confirmed in newer version yet.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jan 11 16:59:05 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 11 Jan 2020 15:59:05 +0000
Subject: [Koha-bugs] [Bug 17514] Record details page uses incorrect class
 "results_summary"
In-Reply-To: <bug-17514-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17514-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17514-70-3KRUnaMiAP@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17514

--- Comment #5 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Kyle, would you agree to make this WONTFIX? (see last comments)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jan 11 17:01:35 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 11 Jan 2020 16:01:35 +0000
Subject: [Koha-bugs] [Bug 17541] Add ability to log all barcodes scanned at
 checkin
In-Reply-To: <bug-17541-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17541-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17541-70-6H5YoYfSVx@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17541

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |22794
                 CC|                            |katrin.fischer at bsz-bw.de


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22794
[Bug 22794] Omnibus: Improve and extend logging in Koha
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jan 11 17:01:35 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 11 Jan 2020 16:01:35 +0000
Subject: [Koha-bugs] [Bug 22794] Omnibus: Improve and extend logging in Koha
In-Reply-To: <bug-22794-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22794-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22794-70-OQbIu0Ejyr@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22794

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |17541


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17541
[Bug 17541] Add ability to log all barcodes scanned at checkin
-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jan 11 17:04:51 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 11 Jan 2020 16:04:51 +0000
Subject: [Koha-bugs] [Bug 17596] Simplify accounting UI in staff client
 [OMNIBUS]
In-Reply-To: <bug-17596-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17596-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17596-70-P6Ek5FK0em@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17596

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
          Component|Circulation                 |Fines and fees
            Summary|Simplify accounting UI in   |Simplify accounting UI in
                   |staff client                |staff client [OMNIBUS]
                 CC|                            |katrin.fischer at bsz-bw.de

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jan 11 17:09:37 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 11 Jan 2020 16:09:37 +0000
Subject: [Koha-bugs] [Bug 17620] Fix format of date/data-times in Swagger
 definition
In-Reply-To: <bug-17620-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17620-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17620-70-SRDopgTu5V@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17620

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de

--- Comment #3 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Still valid?

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jan 11 17:11:36 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 11 Jan 2020 16:11:36 +0000
Subject: [Koha-bugs] [Bug 17705] Payments with cards through payment terminal
In-Reply-To: <bug-17705-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17705-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17705-70-IBLk5rrlAl@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17705

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de
          Component|Circulation                 |Fines and fees

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jan 11 17:12:06 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 11 Jan 2020 16:12:06 +0000
Subject: [Koha-bugs] [Bug 17734] Make possible to pay and writeoff from
 boraccount page and make action buttons split button
In-Reply-To: <bug-17734-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17734-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17734-70-iYDz8sysNr@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17734

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de
          Component|Circulation                 |Fines and fees

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jan 11 17:17:53 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 11 Jan 2020 16:17:53 +0000
Subject: [Koha-bugs] [Bug 17868] Improve display of authors in cart and list
 emails
In-Reply-To: <bug-17868-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17868-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17868-70-mzAO70FrQG@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17868

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=3150

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jan 11 17:17:53 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 11 Jan 2020 16:17:53 +0000
Subject: [Koha-bugs] [Bug 3150] Move emails for sending cart and list
 contents into notices tool
In-Reply-To: <bug-3150-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-3150-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-3150-70-wrc9532eTE@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3150

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=17868

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jan 11 17:19:48 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 11 Jan 2020 16:19:48 +0000
Subject: [Koha-bugs] [Bug 17858] [OMNIBUS] Move staff client JavaScript to
 the footer
In-Reply-To: <bug-17858-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17858-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17858-70-NkfAiCtYtM@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17858

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de
            Summary|Omnibus: Move staff client  |[OMNIBUS] Move staff client
                   |JavaScript to the footer    |JavaScript to the footer

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jan 11 17:23:21 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 11 Jan 2020 16:23:21 +0000
Subject: [Koha-bugs] [Bug 24350] Can't place holds
In-Reply-To: <bug-24350-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24350-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24350-70-zuZ0mtXMt9@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24350

--- Comment #12 from Owen Leonard <oleonard at myacpl.org> ---
Still getting this error when placing a hold:

Template process failed: undef error - Not an ARRAY reference at
/home/vagrant/kohaclone/Koha/Template/Plugin/Branches.pm line 95.
 at /home/vagrant/kohaclone/C4/Templates.pm line 122

A new bug, or this one is still broken?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jan 11 17:28:52 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 11 Jan 2020 16:28:52 +0000
Subject: [Koha-bugs] [Bug 17787] Hidden items included in count of search
 results
In-Reply-To: <bug-17787-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17787-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17787-70-ObPG2RJkUA@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17787

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Suppressed items included   |Hidden items included in
                   |in count of search results  |count of search results

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Sat Jan 11 17:33:03 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 11 Jan 2020 16:33:03 +0000
Subject: [Koha-bugs] [Bug 17623] Two different fine amount for same record
In-Reply-To: <bug-17623-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17623-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17623-70-b9fT2xFmow@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17623

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |INVALID
             Status|NEW                         |RESOLVED
                 CC|                            |katrin.fischer at bsz-bw.de

--- Comment #3 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
This bug was reported against a now very old version of Koha and the provided
links to screenshots are broken now. There is not enough information to test or
fix this if still required. Marking INVALID now, please reopen with upated
information if still required!

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Sat Jan 11 17:33:52 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 11 Jan 2020 16:33:52 +0000
Subject: [Koha-bugs] [Bug 17628] Move bibliographic related code to
 Koha::Biblio
In-Reply-To: <bug-17628-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17628-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17628-70-1659zJeXq7@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17628

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de

--- Comment #11 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
All depending bugs have been closed by now, can we close this as well?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jan 11 17:34:51 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 11 Jan 2020 16:34:51 +0000
Subject: [Koha-bugs] [Bug 17632] Branch facets in opac do not respect
 OPAC_SEARCH_LIMIT.
In-Reply-To: <bug-17632-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17632-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17632-70-XTkD8lEft4@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17632

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |DUPLICATE
                 CC|                            |katrin.fischer at bsz-bw.de
             Status|NEW                         |RESOLVED

--- Comment #2 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---


*** This bug has been marked as a duplicate of bug 12848 ***

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jan 11 17:34:51 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 11 Jan 2020 16:34:51 +0000
Subject: [Koha-bugs] [Bug 12848] Hotlinked searches from detailed record
 does not respect OPAC_SEARCH_LIMIT
In-Reply-To: <bug-12848-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-12848-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12848-70-SNGTK5qBWp@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12848

--- Comment #2 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
*** Bug 17632 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jan 11 17:38:00 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 11 Jan 2020 16:38:00 +0000
Subject: [Koha-bugs] [Bug 14787] Allow confirm/continue option to circ
 warnings at checkout (i.e. OverduesBlockCheckout)
In-Reply-To: <bug-14787-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14787-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14787-70-cLjX3Tqr6N@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14787

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Allow confirm/continue      |Allow confirm/continue
                   |option to circ warnings at  |option to circ warnings at
                   |checkout                    |checkout (i.e.
                   |                            |OverduesBlockCheckout)
                 CC|                            |katrin.fischer at bsz-bw.de

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Sat Jan 11 17:40:11 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 11 Jan 2020 16:40:11 +0000
Subject: [Koha-bugs] [Bug 16766] Merging two records withholds for the same
 patron creates two holds on one record
In-Reply-To: <bug-16766-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16766-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16766-70-szwHFp2uOa@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16766

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de
            Summary|Merging two records with    |Merging two records
                   |title level holds for the   |withholds for the same
                   |same patron creates two     |patron creates two holds on
                   |holds on one record         |one record

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Sat Jan 11 17:40:20 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 11 Jan 2020 16:40:20 +0000
Subject: [Koha-bugs] [Bug 17662] Patron can have more than one hold when
 records are merged
In-Reply-To: <bug-17662-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17662-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17662-70-4xSEeStYUj@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17662

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |DUPLICATE
                 CC|                            |katrin.fischer at bsz-bw.de
             Status|NEW                         |RESOLVED

--- Comment #2 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---


*** This bug has been marked as a duplicate of bug 16766 ***

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jan 11 17:40:20 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 11 Jan 2020 16:40:20 +0000
Subject: [Koha-bugs] [Bug 16766] Merging two records withholds for the same
 patron creates two holds on one record
In-Reply-To: <bug-16766-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16766-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16766-70-PoMynETbNs@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16766

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |cbrannon at cdalibrary.org

--- Comment #1 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
*** Bug 17662 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jan 11 17:40:42 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 11 Jan 2020 16:40:42 +0000
Subject: [Koha-bugs] [Bug 24149] Add new Koha::Statistic[s] classes
In-Reply-To: <bug-24149-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24149-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24149-70-GvH0Z1HdUp@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24149

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #95958|0                           |1
        is obsolete|                            |

--- Comment #5 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 97239
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97239&action=edit
Bug 24149: Add tests

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jan 11 17:43:46 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 11 Jan 2020 16:43:46 +0000
Subject: [Koha-bugs] [Bug 17702] Create configuration for account types
In-Reply-To: <bug-17702-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17702-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17702-70-XMJNbAZX7i@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17702

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de
          Component|Circulation                 |Fines and fees

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jan 11 17:50:15 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 11 Jan 2020 16:50:15 +0000
Subject: [Koha-bugs] [Bug 17763] Exact punctuation and word order is needed
 for matching author and dealer names in acqui/histsearch.pl
In-Reply-To: <bug-17763-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17763-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17763-70-3tUKHy8mPp@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17763

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Version|3.22                        |master

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Sat Jan 11 18:38:00 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 11 Jan 2020 17:38:00 +0000
Subject: [Koha-bugs] [Bug 24350] Can't place holds
In-Reply-To: <bug-24350-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24350-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24350-70-fSHmKLGFRN@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24350

--- Comment #13 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Still this one.. Agustin is working of fixes I believe... Jonathan and Nick
just flip flopped the issue with their patches unfortunately.. it needs fixing
further up the stack.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jan 11 18:41:31 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 11 Jan 2020 17:41:31 +0000
Subject: [Koha-bugs] [Bug 24350] Can't place holds
In-Reply-To: <bug-24350-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24350-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24350-70-ou74AOGOa3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24350

--- Comment #14 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
On Friday I worked on refactoring the template methods to work in a different
way.

I think we should 'do it right' and think a bit about this.

Agustín is back from vacation and will step in

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jan 11 18:59:19 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 11 Jan 2020 17:59:19 +0000
Subject: [Koha-bugs] [Bug 17620] Fix format of date/data-times in Swagger
 definition
In-Reply-To: <bug-17620-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17620-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17620-70-AEVF07uVFy@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17620

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
           Assignee|koha-bugs at lists.koha-commun |tomascohen at gmail.com
                   |ity.org                     |

--- Comment #4 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
I think I fixed then all in several reviews. Specially when we introduced the
RFC process for all endpoints, existing and new. But let me re-check.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jan 11 19:04:15 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 11 Jan 2020 18:04:15 +0000
Subject: [Koha-bugs] [Bug 24403] New: [OMNIBUS] OpacHiddenItems should hide
 items everywhere in the OPAC
Message-ID: <bug-24403-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24403

            Bug ID: 24403
           Summary: [OMNIBUS] OpacHiddenItems should hide items everywhere
                    in the OPAC
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: OPAC
          Assignee: oleonard at myacpl.org
          Reporter: katrin.fischer at bsz-bw.de
        QA Contact: testopia at bugs.koha-community.org

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jan 11 19:04:49 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 11 Jan 2020 18:04:49 +0000
Subject: [Koha-bugs] [Bug 17921] Shelf Browser does not take OpacSuppression
 or OpacHiddenItems into consideration
In-Reply-To: <bug-17921-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17921-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17921-70-8uLCHzPgG8@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17921

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de
             Blocks|                            |24403


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24403
[Bug 24403] [OMNIBUS] OpacHiddenItems should hide items everywhere in the OPAC
-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jan 11 19:04:49 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 11 Jan 2020 18:04:49 +0000
Subject: [Koha-bugs] [Bug 24403] [OMNIBUS] OpacHiddenItems should hide items
 everywhere in the OPAC
In-Reply-To: <bug-24403-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24403-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24403-70-5KjDWaOUPy@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24403

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |17921


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17921
[Bug 17921] Shelf Browser does not take OpacSuppression or OpacHiddenItems into
consideration
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jan 11 19:08:18 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 11 Jan 2020 18:08:18 +0000
Subject: [Koha-bugs] [Bug 23793] Add an EmbedItems RecordProcessor filter
 for MARC::Record objects
In-Reply-To: <bug-23793-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23793-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23793-70-1tIEhlq03f@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23793

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=24403

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jan 11 19:08:18 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 11 Jan 2020 18:08:18 +0000
Subject: [Koha-bugs] [Bug 24403] [OMNIBUS] OpacHiddenItems should hide items
 everywhere in the OPAC
In-Reply-To: <bug-24403-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24403-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24403-70-3ksbOTRxo1@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24403

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=23793

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jan 11 19:10:26 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 11 Jan 2020 18:10:26 +0000
Subject: [Koha-bugs] [Bug 22286] When OpacHiddenItems are checked out,
 link in list of checkouts leads to 404
In-Reply-To: <bug-22286-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22286-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22286-70-5bBm1scCH5@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22286

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|ILL, OpacHiddenItems and    |When OpacHiddenItems are
                   |404                         |checked out, link in list
                   |                            |of checkouts leads to 404
                 CC|                            |katrin.fischer at bsz-bw.de
             Blocks|                            |24403


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24403
[Bug 24403] [OMNIBUS] OpacHiddenItems should hide items everywhere in the OPAC
-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Sat Jan 11 19:10:26 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 11 Jan 2020 18:10:26 +0000
Subject: [Koha-bugs] [Bug 24403] [OMNIBUS] OpacHiddenItems should hide items
 everywhere in the OPAC
In-Reply-To: <bug-24403-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24403-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24403-70-JHYzqEStDy@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24403

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |22286


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22286
[Bug 22286] When OpacHiddenItems are checked out, link in list of checkouts
leads to 404
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jan 11 19:10:54 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 11 Jan 2020 18:10:54 +0000
Subject: [Koha-bugs] [Bug 21261] OpacResults XSLT does not honor
 OpacHiddenItems
In-Reply-To: <bug-21261-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21261-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21261-70-fToKeuvp5V@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21261

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |24403
            Summary|OpacResults XSLT does not   |OpacResults XSLT does not
                   |honor opachiddenitems       |honor OpacHiddenItems
                 CC|                            |katrin.fischer at bsz-bw.de


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24403
[Bug 24403] [OMNIBUS] OpacHiddenItems should hide items everywhere in the OPAC
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jan 11 19:10:54 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 11 Jan 2020 18:10:54 +0000
Subject: [Koha-bugs] [Bug 24403] [OMNIBUS] OpacHiddenItems should hide items
 everywhere in the OPAC
In-Reply-To: <bug-24403-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24403-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24403-70-kxR3OTg9za@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24403

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |21261


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21261
[Bug 21261] OpacResults XSLT does not honor OpacHiddenItems
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jan 11 19:12:04 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 11 Jan 2020 18:12:04 +0000
Subject: [Koha-bugs] [Bug 21261] OpacResults XSLT does not honor
 OpacHiddenItems
In-Reply-To: <bug-21261-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21261-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21261-70-UI86THXO91@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21261

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|24403                       |
             Status|NEW                         |RESOLVED
         Resolution|---                         |DUPLICATE

--- Comment #2 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---


*** This bug has been marked as a duplicate of bug 21014 ***


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24403
[Bug 24403] [OMNIBUS] OpacHiddenItems should hide items everywhere in the OPAC
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jan 11 19:12:04 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 11 Jan 2020 18:12:04 +0000
Subject: [Koha-bugs] [Bug 21014] Availability of hidden items showing in OPAC
In-Reply-To: <bug-21014-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21014-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21014-70-yvB2YUNjPi@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21014

--- Comment #7 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
*** Bug 21261 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Sat Jan 11 19:12:04 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 11 Jan 2020 18:12:04 +0000
Subject: [Koha-bugs] [Bug 24403] [OMNIBUS] OpacHiddenItems should hide items
 everywhere in the OPAC
In-Reply-To: <bug-24403-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24403-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24403-70-Im6schk0ba@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24403

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|21261                       |


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21261
[Bug 21261] OpacResults XSLT does not honor OpacHiddenItems
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jan 11 19:12:41 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 11 Jan 2020 18:12:41 +0000
Subject: [Koha-bugs] [Bug 24151] Add a pseudonymization process for patrons
 and transactions
In-Reply-To: <bug-24151-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24151-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24151-70-D7CaL2gOwt@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24151

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jan 11 19:12:45 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 11 Jan 2020 18:12:45 +0000
Subject: [Koha-bugs] [Bug 24151] Add a pseudonymization process for patrons
 and transactions
In-Reply-To: <bug-24151-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24151-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24151-70-s0w0P6gGd6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24151

--- Comment #20 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 97240
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97240&action=edit
Bug 24151: DB changes

1 new table:
 * pseudonymized_transactions

3 new sysprefs:
 * Pseudonymization
 * PseudonymizationPatronFields
 * PseudonymizationTransactionFields

Sponsored-by: Association KohaLa - https://koha-fr.org/

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jan 11 19:12:49 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 11 Jan 2020 18:12:49 +0000
Subject: [Koha-bugs] [Bug 24151] Add a pseudonymization process for patrons
 and transactions
In-Reply-To: <bug-24151-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24151-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24151-70-XCMEESgdrx@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24151

--- Comment #21 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 97241
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97241&action=edit
Bug 24151: DBIC changes

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jan 11 19:12:55 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 11 Jan 2020 18:12:55 +0000
Subject: [Koha-bugs] [Bug 24151] Add a pseudonymization process for patrons
 and transactions
In-Reply-To: <bug-24151-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24151-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24151-70-NAll8yEcxr@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24151

--- Comment #22 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 97242
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97242&action=edit
Bug 24151: Copy info to the pseudonymized table when a transaction is done

This is the commit where you will find useful information about this
development.

The goal of this new feature is to add a way to pseudonymize patron's
data, in a way they could not be personally identifiable.
https://en.wikipedia.org/wiki/Pseudonymization

There are different existing way to anonymize patron's information in
Koha, but we loose the ability to make useful report.
This development proposes to have 2 different tables:
  * 1 for transactions and patrons data (pseudonymized_transactions)
  * 1 for patrons' attributes (pseudonymized_borrower_attributes)
Entries to pseudonymized_transactions are added when a new transaction
(checkout, checkin, renew, on-site checkout) is done.
Also, anonymized_borrower_attributes is populated if patron's attributes are
marked as "keep for pseudonymization".

To make those informations not identifiable to a patron, we are having a
hashed_borrowernumber column in pseudonymized_transactions. This hash will be
generated (Blowfish-based crypt) using a key stored in the Koha
configuration.

To make things configurable, we are adding 3 sysprefs and 1 new DB
column:
  * syspref Pseudonymization to turn on/off the whole feature
  * syspref PseudonymizationPatronFields to list the informations of the
  patrons to sync
  * syspref PseudonymizationTransactionFields to list the informations
  of the transactions to copy
  * DB column borrower_attribute_types.keep_for_pseudonymization that is a
  boolean to enable/disable the copy of a given patron's attribute type.

Test plan:
1/ Turn on Pseudonymization
2/ Define in PseudonymizationPatronFields and
PseudonymizationTransactionFields the different fields you want to copy
3/ Go to the about page
=> You will see a warning about a missing config entry
4/ You need to generate a key and put it in the koha-conf.xml file. The
following command will generate one:
  % htpasswd -bnBC 10 "" password | tr -d ':\n' | sed 's/$2y/$2a/'
Then edit $KOHA_CONF and add it before of the end of the config section
(</config)
  it should be something like:
    <key>$2a$10$PfdrEBdRcL2MZlEtKueyLegxI6zg735jD07GRnc1bt.N/ZYMvBAB2</key>
5/ Restart memcached then plack (alias restart_all)
=> Everything is setup!
6/ Create a new transaction (checkin for instance)
=> Confirm that a new entry has been added to pseudonymized_transaction with
the data
you expect to be copied
7/ Edit some patron attribute types and tick "Keep for pseudonymization"
8/ Create a new transaction
=> Confirm that new entries have been added to
pseudonymized_borrower_attributes
11/ Delete the patrons
=> Confirm that the entries still exist in the pseudonymized_* tables
12/ Purge the patrons (ie. use cleanup_database.pl to remove them from
the deleted_borrowers table)
=> Confirm that the entries still exist in the pseudonymized_* tables

See bug 24152 to remove data from the anonymized_* tables

Sponsored-by: Association KohaLa - https://koha-fr.org/

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jan 11 19:12:58 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 11 Jan 2020 18:12:58 +0000
Subject: [Koha-bugs] [Bug 24151] Add a pseudonymization process for patrons
 and transactions
In-Reply-To: <bug-24151-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24151-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24151-70-UXsjTYI9jZ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24151

--- Comment #23 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 97243
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97243&action=edit
Bug 24151: Add tests

Sponsored-by: Association KohaLa - https://koha-fr.org/

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jan 11 19:13:02 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 11 Jan 2020 18:13:02 +0000
Subject: [Koha-bugs] [Bug 24151] Add a pseudonymization process for patrons
 and transactions
In-Reply-To: <bug-24151-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24151-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24151-70-CkTpwf2Sbz@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24151

--- Comment #24 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 97244
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97244&action=edit
Bug 24151: Add tests - if config does not exist

Sponsored-by: Association KohaLa - https://koha-fr.org/

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jan 11 19:13:03 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 11 Jan 2020 18:13:03 +0000
Subject: [Koha-bugs] [Bug 21014] Availability of hidden items showing in
 OPAC results
In-Reply-To: <bug-21014-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21014-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21014-70-kkTXjkI7EX@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21014

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |24403
                 CC|                            |katrin.fischer at bsz-bw.de
            Summary|Availability of hidden      |Availability of hidden
                   |items showing in OPAC       |items showing in OPAC
                   |                            |results


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24403
[Bug 24403] [OMNIBUS] OpacHiddenItems should hide items everywhere in the OPAC
-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jan 11 19:13:03 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 11 Jan 2020 18:13:03 +0000
Subject: [Koha-bugs] [Bug 24403] [OMNIBUS] OpacHiddenItems should hide items
 everywhere in the OPAC
In-Reply-To: <bug-24403-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24403-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24403-70-QuWLlXqhN7@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24403

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |21014


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21014
[Bug 21014] Availability of hidden items showing in OPAC results
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jan 11 19:13:07 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 11 Jan 2020 18:13:07 +0000
Subject: [Koha-bugs] [Bug 24151] Add a pseudonymization process for patrons
 and transactions
In-Reply-To: <bug-24151-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24151-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24151-70-MJ6nRnNJj1@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24151

--- Comment #25 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 97245
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97245&action=edit
Bug 24151: Add warning to the about page if key is missing in the config

Sponsored-by: Association KohaLa - https://koha-fr.org/

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jan 11 19:13:11 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 11 Jan 2020 18:13:11 +0000
Subject: [Koha-bugs] [Bug 24151] Add a pseudonymization process for patrons
 and transactions
In-Reply-To: <bug-24151-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24151-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24151-70-OV7Zg5BWgT@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24151

--- Comment #26 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 97246
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97246&action=edit
Bug 24151: Add key to the config

Sponsored-by: Association KohaLa - https://koha-fr.org/

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jan 11 19:13:15 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 11 Jan 2020 18:13:15 +0000
Subject: [Koha-bugs] [Bug 24151] Add a pseudonymization process for patrons
 and transactions
In-Reply-To: <bug-24151-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24151-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24151-70-BXA2etA5hY@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24151

--- Comment #27 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 97247
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97247&action=edit
Bug 24151: DB changes - pseudonymized_borrower_attributes

Add a new DB table pseudonymized_borrower_attributes

Sponsored-by: Association KohaLa - https://koha-fr.org/

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jan 11 19:13:19 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 11 Jan 2020 18:13:19 +0000
Subject: [Koha-bugs] [Bug 24151] Add a pseudonymization process for patrons
 and transactions
In-Reply-To: <bug-24151-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24151-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24151-70-Ph01cFBgPj@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24151

--- Comment #28 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 97248
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97248&action=edit
Bug 24151: Add new column borrower_attribute_types.keep_for_pseudonymization

Sponsored-by: Association KohaLa - https://koha-fr.org/

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jan 11 19:13:23 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 11 Jan 2020 18:13:23 +0000
Subject: [Koha-bugs] [Bug 24151] Add a pseudonymization process for patrons
 and transactions
In-Reply-To: <bug-24151-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24151-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24151-70-Xb32Wisbfi@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24151

--- Comment #29 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 97249
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97249&action=edit
Bug 24151: Adding keep_for_anonymized to the UI

Sponsored-by: Association KohaLa - https://koha-fr.org/

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jan 11 19:13:28 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 11 Jan 2020 18:13:28 +0000
Subject: [Koha-bugs] [Bug 24151] Add a pseudonymization process for patrons
 and transactions
In-Reply-To: <bug-24151-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24151-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24151-70-Ym36dgDyg3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24151

--- Comment #30 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 97250
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97250&action=edit
Bug 24151: Sync patron's attributes

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jan 11 19:13:32 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 11 Jan 2020 18:13:32 +0000
Subject: [Koha-bugs] [Bug 24151] Add a pseudonymization process for patrons
 and transactions
In-Reply-To: <bug-24151-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24151-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24151-70-p8TdkHJvQt@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24151

--- Comment #31 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 97251
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97251&action=edit
Bug 24151: DBIC changes

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jan 11 19:13:36 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 11 Jan 2020 18:13:36 +0000
Subject: [Koha-bugs] [Bug 24151] Add a pseudonymization process for patrons
 and transactions
In-Reply-To: <bug-24151-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24151-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24151-70-fAACPv3tJ1@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24151

--- Comment #32 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 97252
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97252&action=edit
Bug 24151: Add boolean flag for has_cardnumber

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jan 11 19:14:10 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 11 Jan 2020 18:14:10 +0000
Subject: [Koha-bugs] [Bug 24152] Add the ability to purge pseudonymized data
In-Reply-To: <bug-24152-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24152-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24152-70-Mib7wMhLxS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24152

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #95977|0                           |1
        is obsolete|                            |

--- Comment #5 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 97253
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97253&action=edit
Bug 24152: Add method Koha::Objects->filter_by_last_update

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jan 11 19:14:13 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 11 Jan 2020 18:14:13 +0000
Subject: [Koha-bugs] [Bug 24152] Add the ability to purge pseudonymized data
In-Reply-To: <bug-24152-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24152-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24152-70-b4miyOVli0@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24152

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #95978|0                           |1
        is obsolete|                            |

--- Comment #6 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 97254
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97254&action=edit
Bug 24152: Add a warning about the delete of statistics's table entries

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jan 11 19:14:16 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 11 Jan 2020 18:14:16 +0000
Subject: [Koha-bugs] [Bug 24152] Add the ability to purge pseudonymized data
In-Reply-To: <bug-24152-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24152-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24152-70-lHk18w4sjc@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24152

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #95979|0                           |1
        is obsolete|                            |

--- Comment #7 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 97255
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97255&action=edit
Bug 24152: Add the ability to purge pseudonymized tables

anonymized_* tables have been added by bug 24151, this patch adds the
usual way to purge data from them.

The cleanup_database.pl script has been adjusted to take new parameters
that will help to delete pseudonymized data.

Test plan:
Call the scrip with the new parameter to remove pseudonymized data
* --pseudo-transactions DAYS will remove entries from
pseudonymized_transactions older
than DAYS day
* --pseudo-transactions can be used without the parameter DAYS but with
-- pseudo-transactions-from and/or --pseudo-transactions-to instead, to provide
a
range of date

You can use the patch from bug 24153 to make the tests easier, data will
not be deleted if the new --confirm flag is not passed.

Sponsored-by: Association KohaLa - https://koha-fr.org/

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jan 11 19:14:48 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 11 Jan 2020 18:14:48 +0000
Subject: [Koha-bugs] [Bug 19704] OPACs most popular feature includes titles
 hidden by OpacHiddenItems
In-Reply-To: <bug-19704-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19704-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19704-70-vhzlLrn1nN@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19704

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Version|17.05                       |master
                 CC|                            |katrin.fischer at bsz-bw.de
            Summary|OPACs most popular feature  |OPACs most popular feature
                   |is displaying links to      |includes titles hidden by
                   |items set to be hidden in   |OpacHiddenItems
                   |the opachiddenitems syspref |
                   |which gives 404 errors when |
                   |links are clicked           |
             Blocks|                            |24403


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24403
[Bug 24403] [OMNIBUS] OpacHiddenItems should hide items everywhere in the OPAC
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jan 11 19:14:48 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 11 Jan 2020 18:14:48 +0000
Subject: [Koha-bugs] [Bug 24403] [OMNIBUS] OpacHiddenItems should hide items
 everywhere in the OPAC
In-Reply-To: <bug-24403-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24403-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24403-70-hKlgpRRNNY@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24403

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |19704


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19704
[Bug 19704] OPACs most popular feature includes titles hidden by
OpacHiddenItems
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jan 11 19:15:05 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 11 Jan 2020 18:15:05 +0000
Subject: [Koha-bugs] [Bug 24153] Add a confirm flag to the
 cleanup_database.pl cronjob
In-Reply-To: <bug-24153-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24153-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24153-70-5KxmqjGioT@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24153

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #95980|0                           |1
        is obsolete|                            |

--- Comment #2 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 97256
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97256&action=edit
Bug 24153: Add a confirm flag to cleanup_database

How handy this will be, right?

This patch will change the behavior of this script as the --confirm flag
will now be required for effective changes.
Without --confirm and with --verbose you will see what could have done
the script in non dry-run mode.

Test plan:
Use different options of the script without the --confirm flag and have
a look at the output. It now tells you what would have been deleted if
the flag was passed.
Now use the --confirm flag and confirm that the changes are now
effective.

Sponsored-by: Association KohaLa - https://koha-fr.org/

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jan 11 19:17:30 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 11 Jan 2020 18:17:30 +0000
Subject: [Koha-bugs] [Bug 19688] OpacHiddenItems itype problems
In-Reply-To: <bug-19688-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19688-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19688-70-8QEE3mXzgd@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19688

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de
         Resolution|---                         |DUPLICATE
             Status|NEW                         |RESOLVED

--- Comment #1 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
>From the description this sounds like a duplicate to bug 23923 - search looks
like there are no results, because of OpacHiddenItems hiding the first page.
Please reopen if am mistaken.

*** This bug has been marked as a duplicate of bug 23923 ***

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jan 11 19:17:30 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 11 Jan 2020 18:17:30 +0000
Subject: [Koha-bugs] [Bug 23923] OpacHiddenItems displays incorrect 'No
 results found' when all results on first page are hidden
In-Reply-To: <bug-23923-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23923-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23923-70-nW3DG2lB8m@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23923

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |kohadevinim at devinim.com.tr

--- Comment #1 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
*** Bug 19688 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Sat Jan 11 19:17:54 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 11 Jan 2020 18:17:54 +0000
Subject: [Koha-bugs] [Bug 23923] OpacHiddenItems displays incorrect 'No
 results found' when all results on first page are hidden
In-Reply-To: <bug-23923-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23923-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23923-70-xODd38iOYb@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23923

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |24403
                 CC|                            |katrin.fischer at bsz-bw.de


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24403
[Bug 24403] [OMNIBUS] OpacHiddenItems should hide items everywhere in the OPAC
-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Sat Jan 11 19:17:54 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 11 Jan 2020 18:17:54 +0000
Subject: [Koha-bugs] [Bug 24403] [OMNIBUS] OpacHiddenItems should hide items
 everywhere in the OPAC
In-Reply-To: <bug-24403-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24403-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24403-70-Etr5PJUz79@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24403

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |23923


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23923
[Bug 23923] OpacHiddenItems displays incorrect 'No results found'  when all
results on first page are hidden
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jan 11 19:18:29 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 11 Jan 2020 18:18:29 +0000
Subject: [Koha-bugs] [Bug 18989] Allow displaying biblios with all items
 hidden by OpacHiddenItems
In-Reply-To: <bug-18989-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18989-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18989-70-B5REGKZgPG@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18989

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=24403

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jan 11 19:18:29 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 11 Jan 2020 18:18:29 +0000
Subject: [Koha-bugs] [Bug 24403] [OMNIBUS] OpacHiddenItems should hide items
 everywhere in the OPAC
In-Reply-To: <bug-24403-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24403-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24403-70-hjtkuslPvJ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24403

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=18989

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jan 11 19:18:49 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 11 Jan 2020 18:18:49 +0000
Subject: [Koha-bugs] [Bug 19064] OAI-PMH Records appearing in OAI that can't
 be found in OPAC
In-Reply-To: <bug-19064-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19064-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19064-70-yUqDYdCoqI@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19064

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |24403
                 CC|                            |katrin.fischer at bsz-bw.de


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24403
[Bug 24403] [OMNIBUS] OpacHiddenItems should hide items everywhere in the OPAC
-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jan 11 19:18:49 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 11 Jan 2020 18:18:49 +0000
Subject: [Koha-bugs] [Bug 24403] [OMNIBUS] OpacHiddenItems should hide items
 everywhere in the OPAC
In-Reply-To: <bug-24403-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24403-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24403-70-9CWn37T4KH@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24403

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |19064


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19064
[Bug 19064] OAI-PMH Records appearing in OAI that can't be found in OPAC
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jan 11 19:20:07 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 11 Jan 2020 18:20:07 +0000
Subject: [Koha-bugs] [Bug 17787] Hidden items included in count of search
 results
In-Reply-To: <bug-17787-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17787-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17787-70-t8x5wFJYsJ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17787

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |24403


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24403
[Bug 24403] [OMNIBUS] OpacHiddenItems should hide items everywhere in the OPAC
-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jan 11 19:20:07 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 11 Jan 2020 18:20:07 +0000
Subject: [Koha-bugs] [Bug 24403] [OMNIBUS] OpacHiddenItems should hide items
 everywhere in the OPAC
In-Reply-To: <bug-24403-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24403-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24403-70-62uX1mKDKW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24403

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |17787


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17787
[Bug 17787] Hidden items included in count of search results
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jan 11 19:20:29 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 11 Jan 2020 18:20:29 +0000
Subject: [Koha-bugs] [Bug 14007] Item Types for items hidden by
 OpacHiddenItems turn up in facet results
In-Reply-To: <bug-14007-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14007-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14007-70-aK3JtTBORY@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14007

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de
             Blocks|                            |24403


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24403
[Bug 24403] [OMNIBUS] OpacHiddenItems should hide items everywhere in the OPAC
-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jan 11 19:20:29 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 11 Jan 2020 18:20:29 +0000
Subject: [Koha-bugs] [Bug 24403] [OMNIBUS] OpacHiddenItems should hide items
 everywhere in the OPAC
In-Reply-To: <bug-24403-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24403-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24403-70-cPXjmREOzB@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24403

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |14007


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14007
[Bug 14007] Item Types for items hidden by OpacHiddenItems turn up in facet
results
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jan 11 19:21:20 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 11 Jan 2020 18:21:20 +0000
Subject: [Koha-bugs] [Bug 18167] Suppressed items revealed when holding
 specific items
In-Reply-To: <bug-18167-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18167-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18167-70-F50J2J3TeP@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18167

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de
             Status|NEW                         |RESOLVED
         Resolution|---                         |DUPLICATE

--- Comment #2 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---


*** This bug has been marked as a duplicate of bug 15448 ***

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Sat Jan 11 19:21:20 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 11 Jan 2020 18:21:20 +0000
Subject: [Koha-bugs] [Bug 15448] OPACHiddenItems show in OPAC when patron
 places a hold on a specific item
In-Reply-To: <bug-15448-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15448-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15448-70-gQx6bkW9bL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15448

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |cbrannon at cdalibrary.org

--- Comment #10 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
*** Bug 18167 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jan 11 19:21:40 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 11 Jan 2020 18:21:40 +0000
Subject: [Koha-bugs] [Bug 15448] OPACHiddenItems show in OPAC when patron
 places a hold on a specific item
In-Reply-To: <bug-15448-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15448-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15448-70-OUpiZIOIlt@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15448

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |24403


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24403
[Bug 24403] [OMNIBUS] OpacHiddenItems should hide items everywhere in the OPAC
-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Sat Jan 11 19:21:40 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 11 Jan 2020 18:21:40 +0000
Subject: [Koha-bugs] [Bug 24403] [OMNIBUS] OpacHiddenItems should hide items
 everywhere in the OPAC
In-Reply-To: <bug-24403-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24403-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24403-70-Swj5TRzZbF@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24403

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |15448


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15448
[Bug 15448] OPACHiddenItems show in OPAC when patron places a hold on a
specific item
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jan 11 19:27:00 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 11 Jan 2020 18:27:00 +0000
Subject: [Koha-bugs] [Bug 17928] Updating sounds for circulation
In-Reply-To: <bug-17928-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17928-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17928-70-Kmi1hCyeYq@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17928

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|In Discussion               |RESOLVED
         Resolution|---                         |WONTFIX

--- Comment #8 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Marking this WONTFIX for now, as we didn't get an answer about the source of
the sound files the existing patches cannot be fixed right now. Please reopen
if you have new info!

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Sat Jan 11 19:29:22 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 11 Jan 2020 18:29:22 +0000
Subject: [Koha-bugs] [Bug 17937] Adding item description to Twitter Summary
In-Reply-To: <bug-17937-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17937-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17937-70-3K96EFeNIE@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17937

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=9855

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jan 11 19:29:22 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 11 Jan 2020 18:29:22 +0000
Subject: [Koha-bugs] [Bug 9855] Add OpenGraph (Facebook preview) tags to
 pages
In-Reply-To: <bug-9855-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-9855-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9855-70-fPT3ALbE73@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9855

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=17937

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jan 11 19:31:48 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 11 Jan 2020 18:31:48 +0000
Subject: [Koha-bugs] [Bug 17939] Local Cover Images options not available as
 Coce Cover images cache options appear instead (non en only)
In-Reply-To: <bug-17939-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17939-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17939-70-kegtTBP0yu@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17939

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |WORKSFORME
             Status|NEW                         |RESOLVED

--- Comment #2 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Suspecting an issue with the language installation here, closing WORKSFORME.
Please reopen if you still experience the problem.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Sat Jan 11 19:33:53 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 11 Jan 2020 18:33:53 +0000
Subject: [Koha-bugs] [Bug 17954] Remove the sql code from the smart-rules.pl
 administrative script
In-Reply-To: <bug-17954-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17954-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17954-70-CWtAA6Z9CR@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17954

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=15522
                 CC|                            |katrin.fischer at bsz-bw.de

--- Comment #2 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
This might get obsoleted by the work on the new circulation rules (bug 15522)

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jan 11 19:33:53 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 11 Jan 2020 18:33:53 +0000
Subject: [Koha-bugs] [Bug 15522] New interface for revamped circulation rules
In-Reply-To: <bug-15522-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15522-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15522-70-wvrh7H2PAz@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15522

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=17954

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jan 11 19:34:45 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 11 Jan 2020 18:34:45 +0000
Subject: [Koha-bugs] [Bug 17976] TT syntax for notices - Add an equivalence
 for items.fine
In-Reply-To: <bug-17976-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17976-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17976-70-ZN9fZbEHdk@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17976

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de
         Depends on|                            |14757


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14757
[Bug 14757] Allow the use of Template Toolkit syntax for slips and notices
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jan 11 19:34:45 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 11 Jan 2020 18:34:45 +0000
Subject: [Koha-bugs] [Bug 14757] Allow the use of Template Toolkit syntax
 for slips and notices
In-Reply-To: <bug-14757-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14757-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14757-70-Aup3hjPvnD@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14757

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |17976


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17976
[Bug 17976] TT syntax for notices - Add an equivalence for items.fine
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jan 11 19:36:21 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 11 Jan 2020 18:36:21 +0000
Subject: [Koha-bugs] [Bug 17983] Add minutes loan to DiscreteCalendar
In-Reply-To: <bug-17983-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17983-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17983-70-Tfjzqoaxuq@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17983

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de
             Status|Needs Signoff               |BLOCKED

--- Comment #23 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Marking as BLOCKED because dependency is FQA.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jan 11 19:37:52 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 11 Jan 2020 18:37:52 +0000
Subject: [Koha-bugs] [Bug 17984] Warn catalogers if item type doesn't match
 942c
In-Reply-To: <bug-17984-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17984-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17984-70-vlQkJtzLJM@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17984

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de

--- Comment #1 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Hi Christopher, not sure I understand the problem here - 942$c is usually a
pull down, so it should always match an existing itemtype?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jan 11 19:42:07 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 11 Jan 2020 18:42:07 +0000
Subject: [Koha-bugs] [Bug 17994] OAI-PMH: ListSets logs a warning
In-Reply-To: <bug-17994-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17994-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17994-70-ThTD8Bc0lY@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17994

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de

--- Comment #1 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Still valid.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Sat Jan 11 19:44:24 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 11 Jan 2020 18:44:24 +0000
Subject: [Koha-bugs] [Bug 17997] Staff client -- print cart stalls when cart
 is sorted by item.
In-Reply-To: <bug-17997-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17997-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17997-70-7JVHgnXoS3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17997

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |WORKSFORME
             Status|NEW                         |RESOLVED
                 CC|                            |katrin.fischer at bsz-bw.de

--- Comment #1 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
I believe the print dialog changed since this was filed - can't get print to
break :)

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Sat Jan 11 19:46:17 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 11 Jan 2020 18:46:17 +0000
Subject: [Koha-bugs] [Bug 17999] batch item modifications disregards MARC
 framework
In-Reply-To: <bug-17999-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17999-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17999-70-VeOiaO5aH1@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17999

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de

--- Comment #1 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
I think this is because the items can be from records with different frameworks
set. So the default framework is used as least common denominator. It matches
in what we do in other places.
What would you suggest?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jan 11 19:50:33 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 11 Jan 2020 18:50:33 +0000
Subject: [Koha-bugs] [Bug 18016] C4::Auth_with_ldap::ldap_entry_2_hash
 inserts 0000-00-00 for invalid dateofbirth
In-Reply-To: <bug-18016-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18016-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18016-70-ho89y7uX3n@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18016

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de,
                   |                            |martin.renvoize at ptfs-europe
                   |                            |.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jan 11 19:52:02 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 11 Jan 2020 18:52:02 +0000
Subject: [Koha-bugs] [Bug 18020] Self-Checkout
In-Reply-To: <bug-18020-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18020-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18020-70-NBteWTD0VU@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18020

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |WORKSFORME
                 CC|                            |katrin.fischer at bsz-bw.de
             Status|NEW                         |RESOLVED

--- Comment #3 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Marking WORKSFORME as per Magnus' last comment.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jan 11 19:53:09 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 11 Jan 2020 18:53:09 +0000
Subject: [Koha-bugs] [Bug 18021] Confirming each loan when going beyond the
 limit of loans
In-Reply-To: <bug-18021-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18021-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18021-70-HIHGVacDJI@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18021

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
                 CC|                            |katrin.fischer at bsz-bw.de
         Resolution|---                         |DUPLICATE

--- Comment #4 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---


*** This bug has been marked as a duplicate of bug 14787 ***

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jan 11 19:53:09 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 11 Jan 2020 18:53:09 +0000
Subject: [Koha-bugs] [Bug 14787] Allow confirm/continue option to circ
 warnings at checkout (i.e. OverduesBlockCheckout)
In-Reply-To: <bug-14787-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14787-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14787-70-CLshJeN4hD@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14787

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |alexandre.breton at ccsr.qc.ca

--- Comment #3 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
*** Bug 18021 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jan 11 19:54:54 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 11 Jan 2020 18:54:54 +0000
Subject: [Koha-bugs] [Bug 18024] Adding a "genres/ form term" search in
 Authorities module
In-Reply-To: <bug-18024-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18024-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18024-70-EPgrV2MEGA@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18024

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de
            Summary|Adding a "genres and kinds" |Adding a "genres/ form
                   |search in Authorities       |term" search in Authorities
                   |module                      |module

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jan 11 19:55:27 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 11 Jan 2020 18:55:27 +0000
Subject: [Koha-bugs] [Bug 18029] Use templates for generating pagination in
 opac
In-Reply-To: <bug-18029-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18029-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18029-70-Cy3E3oRSrj@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18029

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de

--- Comment #1 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Hi Josef, can you add a bit more information on this one?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jan 11 19:56:10 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 11 Jan 2020 18:56:10 +0000
Subject: [Koha-bugs] [Bug 18030] Get rid of pagination_bar sub in C4::Output
In-Reply-To: <bug-18030-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18030-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18030-70-LPy5RQn1zN@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18030

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de

--- Comment #1 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Hi Josef, can you add a bit more information here?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jan 11 19:57:33 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 11 Jan 2020 18:57:33 +0000
Subject: [Koha-bugs] [Bug 18038] Generate fees per month for all patrons
 with a particular category
In-Reply-To: <bug-18038-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18038-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18038-70-N06n57WPdl@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18038

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de
         Resolution|---                         |DUPLICATE
             Status|NEW                         |RESOLVED

--- Comment #1 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---


*** This bug has been marked as a duplicate of bug 13651 ***

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Sat Jan 11 19:57:33 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 11 Jan 2020 18:57:33 +0000
Subject: [Koha-bugs] [Bug 13651] Provision for monthly library fee
In-Reply-To: <bug-13651-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13651-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13651-70-TEXuoKO1fr@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13651

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |ing.lucianac at hotmail.com

--- Comment #8 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
*** Bug 18038 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Sat Jan 11 20:06:19 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 11 Jan 2020 19:06:19 +0000
Subject: [Koha-bugs] [Bug 20454] Suspend Holds if patron wouldn't be able to
 check items out
In-Reply-To: <bug-20454-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20454-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20454-70-oCIrm5AJlk@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20454

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de

--- Comment #1 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Maybe this should be optional. One could also argue that the holds incoming
would be an extra incentive to pay the fines.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jan 11 20:09:39 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 11 Jan 2020 19:09:39 +0000
Subject: [Koha-bugs] [Bug 19889] LocalHoldsPriority needs exclusions
In-Reply-To: <bug-19889-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19889-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19889-70-OJfgYnUvsH@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19889

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de
            Summary|localholdspriority needs    |LocalHoldsPriority needs
                   |exclusions                  |exclusions

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jan 11 20:16:09 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 11 Jan 2020 19:16:09 +0000
Subject: [Koha-bugs] [Bug 19853] REPORT_GROUP and REPORT_SUBGROUP branch
 limits don't hide reports on 'Saved reports' page.
In-Reply-To: <bug-19853-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19853-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19853-70-ORyAT5HAjH@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19853

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Version|17.05                       |master
                 CC|                            |katrin.fischer at bsz-bw.de
            Summary|Limiting branch under       |REPORT_GROUP and
                   |authorized value categories |REPORT_SUBGROUP branch
                   |REPORT_GROUP and            |limits don't hide reports
                   |REPORT_SUBGROUP does not    |on 'Saved reports' page.
                   |hide reports on 'Saved      |
                   |Reports' page.              |
           Severity|normal                      |enhancement

--- Comment #1 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
I believe this only works for location and collection at the moment, so
treating as an enhancement.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jan 11 20:19:16 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 11 Jan 2020 19:19:16 +0000
Subject: [Koha-bugs] [Bug 19829] Don't include lost items when limiting on
 available items
In-Reply-To: <bug-19829-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19829-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19829-70-hFIXAWmaGm@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19829

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de
            Summary|OPAC Search Limit by Branch |Don't include lost items
                   |bringing up records where   |when limiting on available
                   |the home library only has a |items
                   |missing copy                |

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jan 11 20:22:21 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 11 Jan 2020 19:22:21 +0000
Subject: [Koha-bugs] [Bug 19810] ILL: 404 error when activating ILL on a
 package installation
In-Reply-To: <bug-19810-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19810-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19810-70-0ecyJrnj0S@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19810

--- Comment #3 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
I belive this has been fixed since.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jan 11 20:22:31 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 11 Jan 2020 19:22:31 +0000
Subject: [Koha-bugs] [Bug 19810] ILL: 404 error when activating ILL on a
 package installation
In-Reply-To: <bug-19810-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19810-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19810-70-EKuju3Lwbd@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19810

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |INVALID

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Sat Jan 11 20:28:13 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 11 Jan 2020 19:28:13 +0000
Subject: [Koha-bugs] [Bug 19780] Actual price is not updated after it has
 been amended post receiving an order
In-Reply-To: <bug-19780-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19780-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19780-70-8PfnwNi9sk@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19780

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|enhancement                 |normal

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jan 11 20:31:13 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 11 Jan 2020 19:31:13 +0000
Subject: [Koha-bugs] [Bug 19762] Add option for PREDUE notices to take
 calendar into account
In-Reply-To: <bug-19762-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19762-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19762-70-xsOmid31QT@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19762

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
          Component|Tools                       |Notices

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Sat Jan 11 20:33:55 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 11 Jan 2020 19:33:55 +0000
Subject: [Koha-bugs] [Bug 19733] Allow navigating callnumbers for all items
 in cn_browser.pl
In-Reply-To: <bug-19733-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19733-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19733-70-PJWWf6v2T2@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19733

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Navigation in the pages     |Allow navigating
                   |result with cn_browser.pl   |callnumbers for all items
                   |is setting in a field       |in cn_browser.pl
                 CC|                            |katrin.fischer at bsz-bw.de

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Sat Jan 11 20:41:28 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 11 Jan 2020 19:41:28 +0000
Subject: [Koha-bugs] [Bug 19652] REST API: Log request and response content
In-Reply-To: <bug-19652-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19652-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19652-70-zZfoKiWUze@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19652

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |BLOCKED
                 CC|                            |katrin.fischer at bsz-bw.de

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jan 11 20:49:24 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 11 Jan 2020 19:49:24 +0000
Subject: [Koha-bugs] [Bug 19632] String reappears as fuzzy with every
 translation update
In-Reply-To: <bug-19632-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19632-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19632-70-FEmjtdtbCK@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19632

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|NEW                         |RESOLVED

--- Comment #2 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Haven't seen the string in question in a while - appears to have been fixed!

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jan 11 20:53:25 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 11 Jan 2020 19:53:25 +0000
Subject: [Koha-bugs] [Bug 19606] 773$g is not showing if 773$0 -
 MARC21slim2OPACDetail.xsl
In-Reply-To: <bug-19606-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19606-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19606-70-fUGdNT1jDa@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19606

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |DUPLICATE

--- Comment #2 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---


*** This bug has been marked as a duplicate of bug 17867 ***

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jan 11 20:53:25 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 11 Jan 2020 19:53:25 +0000
Subject: [Koha-bugs] [Bug 17867] Improve display of source (MARC21 773) in
 result list
In-Reply-To: <bug-17867-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17867-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17867-70-okiEihkbB0@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17867

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |hagud at orex.es

--- Comment #9 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
*** Bug 19606 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Sat Jan 11 21:00:19 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 11 Jan 2020 20:00:19 +0000
Subject: [Koha-bugs] [Bug 19558] Link 130 uniform title authority record to
 240 tag
In-Reply-To: <bug-19558-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19558-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19558-70-745rCFQNZH@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19558

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de

--- Comment #1 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Hi Jess, can you explain a bit more about the link? Where should the link
display and where should it link to?

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jan 11 21:11:18 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 11 Jan 2020 20:11:18 +0000
Subject: [Koha-bugs] [Bug 21421] checking in a lost item which is not
 currently checked out gives refund messsage.
In-Reply-To: <bug-21421-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21421-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21421-70-ajSEx9K5Vl@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21421

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de
             Status|NEW                         |RESOLVED
         Resolution|---                         |DUPLICATE

--- Comment #1 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---


*** This bug has been marked as a duplicate of bug 19508 ***

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jan 11 21:11:18 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 11 Jan 2020 20:11:18 +0000
Subject: [Koha-bugs] [Bug 19508] When returning a lost item,
 Koha claim to have applied a refund when it has not
In-Reply-To: <bug-19508-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19508-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19508-70-0KBoEg13Bt@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19508

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |barton at bywatersolutions.com

--- Comment #2 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
*** Bug 21421 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jan 11 21:15:15 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 11 Jan 2020 20:15:15 +0000
Subject: [Koha-bugs] [Bug 19499] Notice update fails on SQL UPDATE
In-Reply-To: <bug-19499-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19499-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19499-70-h4tZOzMdel@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19499

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |WORKSFORME
             Status|ASSIGNED                    |RESOLVED
                 CC|                            |katrin.fischer at bsz-bw.de

--- Comment #1 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Would be really bad if noone had noticed htat in almost 3 years :)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jan 11 21:18:03 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 11 Jan 2020 20:18:03 +0000
Subject: [Koha-bugs] [Bug 19486] When cancelling a waiting hold via
 circulation the patron is charged the ExpireReservesMaxPickUpDelayCharge
In-Reply-To: <bug-19486-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19486-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19486-70-uwZOVPLdwu@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19486

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de

--- Comment #4 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Is the bug here that cancelling the hold in the OPAC doesn't charge or is the
bug that the fee is charged? The checkbox Jonathan decribes in comment#2 seems
to cover that case.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jan 11 21:23:24 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 11 Jan 2020 20:23:24 +0000
Subject: [Koha-bugs] [Bug 19473] Tag 008 position 06 always generate be "b"
 and position 7-10 and 7-14 are blank
In-Reply-To: <bug-19473-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19473-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19473-70-quckM0Wyd0@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19473

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |WORKSFORME
                 CC|                            |katrin.fischer at bsz-bw.de
             Status|NEW                         |RESOLVED

--- Comment #2 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
I've just tested this and 008 pos. 6 can be changed using the plugin. On
editing again the correct value is shown etc. No problems found.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jan 11 21:28:03 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 11 Jan 2020 20:28:03 +0000
Subject: [Koha-bugs] [Bug 19442] Add patron attributes into the patron card
 creator
In-Reply-To: <bug-19442-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19442-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19442-70-XnV35v3R1K@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19442

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
          Component|Tools                       |Label/patron card printing
            Summary|add patron attributes into  |Add patron attributes into
                   |the patron card creator     |the patron card creator
           Assignee|koha-bugs at lists.koha-commun |cnighswonger at foundations.ed
                   |ity.org                     |u
                 CC|                            |katrin.fischer at bsz-bw.de

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jan 11 21:32:00 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 11 Jan 2020 20:32:00 +0000
Subject: [Koha-bugs] [Bug 19406] REST API: Add route for checkins
In-Reply-To: <bug-19406-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19406-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19406-70-qzDVXlgsRQ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19406

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de
         Resolution|---                         |DUPLICATE
             Status|NEW                         |RESOLVED

--- Comment #1 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---


*** This bug has been marked as a duplicate of bug 24401 ***

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Sat Jan 11 21:32:00 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 11 Jan 2020 20:32:00 +0000
Subject: [Koha-bugs] [Bug 24401] REST API: Check-in
In-Reply-To: <bug-24401-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24401-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24401-70-gPy2KgoOhs@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24401

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |dcook at prosentient.com.au

--- Comment #1 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
*** Bug 19406 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jan 11 21:33:29 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 11 Jan 2020 20:33:29 +0000
Subject: [Koha-bugs] [Bug 19399] Show reports screen should not display
 query in textarea
In-Reply-To: <bug-19399-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19399-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19399-70-l5irk8jYRt@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19399

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Show reports screen should  |Show reports screen should
                   |not display query in        |not display query in
                   |textarea.                   |textarea
                 CC|                            |katrin.fischer at bsz-bw.de

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Sat Jan 11 21:35:38 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 11 Jan 2020 20:35:38 +0000
Subject: [Koha-bugs] [Bug 19382] Add ability to block guarantees based on
 fees owed by guarantor and other guarantees
In-Reply-To: <bug-19382-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19382-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19382-70-QxA1Ompahk@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19382

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de

--- Comment #3 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Should this be NSO?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jan 11 21:44:18 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 11 Jan 2020 20:44:18 +0000
Subject: [Koha-bugs] [Bug 19322] Typo in UNIMARC field 140 plugin
In-Reply-To: <bug-19322-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19322-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19322-70-37m3jvOkIY@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19322

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |Academy
                 CC|                            |katrin.fischer at bsz-bw.de

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Sat Jan 11 21:44:44 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 11 Jan 2020 20:44:44 +0000
Subject: [Koha-bugs] [Bug 19327] Typo in UNIMARC field 128a plugin
In-Reply-To: <bug-19327-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19327-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19327-70-od3OZpbmoE@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19327

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de
           Keywords|                            |Academy

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Sat Jan 11 21:46:34 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 11 Jan 2020 20:46:34 +0000
Subject: [Koha-bugs] [Bug 19313] Typo in UNIMARC field 130 plugin
In-Reply-To: <bug-19313-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19313-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19313-70-LhLQHv6Juf@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19313

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de
           Keywords|                            |Academy

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jan 11 21:47:17 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 11 Jan 2020 20:47:17 +0000
Subject: [Koha-bugs] [Bug 19312] Typo in UNIMARC field 121a plugin
In-Reply-To: <bug-19312-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19312-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19312-70-ut8Inc0KGh@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19312

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de
           Keywords|                            |Academy

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jan 11 21:53:24 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 11 Jan 2020 20:53:24 +0000
Subject: [Koha-bugs] [Bug 19270] Advanced Editor - Rancor - Add ability to
 search batches on arbitrary marc fields
In-Reply-To: <bug-19270-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19270-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19270-70-l0r5TPjred@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19270

--- Comment #6 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Is ASSIGNED the correct status here?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jan 11 21:55:15 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 11 Jan 2020 20:55:15 +0000
Subject: [Koha-bugs] [Bug 17454] [OMNIBUS] POD Cleanup
In-Reply-To: <bug-17454-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17454-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17454-70-dJjFjstUWc@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17454

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |19264


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19264
[Bug 19264] Patron card creator: Add descriptions to PODs in Patroncard.pm
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jan 11 21:55:15 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 11 Jan 2020 20:55:15 +0000
Subject: [Koha-bugs] [Bug 19264] Patron card creator: Add descriptions to
 PODs in Patroncard.pm
In-Reply-To: <bug-19264-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19264-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19264-70-haMUWpgyrT@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19264

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |17454


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17454
[Bug 17454] [OMNIBUS] POD Cleanup
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jan 11 21:57:00 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 11 Jan 2020 20:57:00 +0000
Subject: [Koha-bugs] [Bug 17454] [OMNIBUS] POD Cleanup
In-Reply-To: <bug-17454-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17454-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17454-70-VNXgalQXzK@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17454

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |24066, 13513


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13513
[Bug 13513] Improve POD of C4::Circulation AnonymiseIssueHistory
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24066
[Bug 24066] Koha::Patron->has_permission has no POD
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jan 11 21:57:00 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 11 Jan 2020 20:57:00 +0000
Subject: [Koha-bugs] [Bug 13513] Improve POD of C4::Circulation
 AnonymiseIssueHistory
In-Reply-To: <bug-13513-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13513-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13513-70-9fMKCyPcqT@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13513

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |17454


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17454
[Bug 17454] [OMNIBUS] POD Cleanup
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jan 11 21:57:00 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 11 Jan 2020 20:57:00 +0000
Subject: [Koha-bugs] [Bug 24066] Koha::Patron->has_permission has no POD
In-Reply-To: <bug-24066-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24066-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24066-70-Zvm2eoGg4B@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24066

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |17454


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17454
[Bug 17454] [OMNIBUS] POD Cleanup
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jan 11 22:00:07 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 11 Jan 2020 21:00:07 +0000
Subject: [Koha-bugs] [Bug 19237] PERSO_NAME authority file ignores first
 indicator value of new headings saved
In-Reply-To: <bug-19237-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19237-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19237-70-wuJU0gRYSi@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19237

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|REOPENED                    |NEW

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jan 11 22:03:55 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 11 Jan 2020 21:03:55 +0000
Subject: [Koha-bugs] [Bug 19192] Update default DUEDGST and PREDUEDGST
 notices
In-Reply-To: <bug-19192-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19192-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19192-70-nuYwCv39nF@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19192

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de
           Keywords|                            |Academy

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jan 11 22:10:51 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 11 Jan 2020 21:10:51 +0000
Subject: [Koha-bugs] [Bug 19084] Spine label with BN_IN UTF8 data rendered
 incorrectly
In-Reply-To: <bug-19084-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19084-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19084-70-id3Bzhejcz@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19084

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de
                URL|                            |https://rt.cpan.org/Ticket/
                   |                            |Display.html?id=122778

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jan 11 22:12:34 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 11 Jan 2020 21:12:34 +0000
Subject: [Koha-bugs] [Bug 19060] Patrons should not get a max fines block
 auto-renewal notification for items due in the future.
In-Reply-To: <bug-19060-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19060-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19060-70-sR2YZv3ZKa@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19060

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=19014
                 CC|                            |katrin.fischer at bsz-bw.de

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Sat Jan 11 22:12:34 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 11 Jan 2020 21:12:34 +0000
Subject: [Koha-bugs] [Bug 19014] Patrons should not get an 'on_reserve'
 notification if the due date is far into the future
In-Reply-To: <bug-19014-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19014-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19014-70-pu54M91fXe@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19014

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=19060

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jan 11 22:13:34 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 11 Jan 2020 21:13:34 +0000
Subject: [Koha-bugs] [Bug 19036] Number payment receipts / payment slips
In-Reply-To: <bug-19036-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19036-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19036-70-xqVNnYa4Dg@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19036

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
          Component|Patrons                     |Fines and fees

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jan 11 22:20:01 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 11 Jan 2020 21:20:01 +0000
Subject: [Koha-bugs] [Bug 18983] koha-create does not default to --create-db
In-Reply-To: <bug-18983-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18983-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18983-70-CXBttiWusF@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18983

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de,
                   |                            |robin at catalyst.net.nz
          Component|Installation and upgrade    |Command-line Utilities
                   |(command-line installer)    |

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Sat Jan 11 22:22:35 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 11 Jan 2020 21:22:35 +0000
Subject: [Koha-bugs] [Bug 18962] Including valid system requirements in Koha
 manual
In-Reply-To: <bug-18962-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18962-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18962-70-gnRjl8ZGxj@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18962

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de
           Keywords|                            |Manual
          Component|Circulation                 |Documentation

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Sat Jan 11 22:25:03 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 11 Jan 2020 21:25:03 +0000
Subject: [Koha-bugs] [Bug 18945] UseQueryParser system preference breaks
 subject searches
In-Reply-To: <bug-18945-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18945-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18945-70-OibEwwIIf5@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18945

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de
             Blocks|                            |12742


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12742
[Bug 12742] Omnibus: QueryParser
-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jan 11 22:25:03 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 11 Jan 2020 21:25:03 +0000
Subject: [Koha-bugs] [Bug 12742] Omnibus: QueryParser
In-Reply-To: <bug-12742-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-12742-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12742-70-MkzoZBi8Zp@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12742

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |18945


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18945
[Bug 18945] UseQueryParser system preference breaks subject searches
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jan 11 22:31:00 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 11 Jan 2020 21:31:00 +0000
Subject: [Koha-bugs] [Bug 19561] Add "preferred language" to OPAC Personal
 Details opac-memberentry.pl
In-Reply-To: <bug-19561-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19561-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19561-70-jHQi8xbJsC@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19561

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
                 CC|                            |katrin.fischer at bsz-bw.de
         Resolution|---                         |DUPLICATE

--- Comment #2 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---


*** This bug has been marked as a duplicate of bug 18911 ***

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jan 11 22:31:00 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 11 Jan 2020 21:31:00 +0000
Subject: [Koha-bugs] [Bug 18911] Option to set preferred language in OPAC
In-Reply-To: <bug-18911-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18911-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18911-70-0e7dIoAZRQ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18911

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jzairo at bywatersolutions.com

--- Comment #3 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
*** Bug 19561 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jan 11 22:34:49 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 11 Jan 2020 21:34:49 +0000
Subject: [Koha-bugs] [Bug 18892] RDA fields not searchable as Publisher
In-Reply-To: <bug-18892-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18892-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18892-70-WmGfZZL4oV@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18892

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |DUPLICATE
                 CC|                            |katrin.fischer at bsz-bw.de

--- Comment #1 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---


*** This bug has been marked as a duplicate of bug 15704 ***

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jan 11 22:34:49 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 11 Jan 2020 21:34:49 +0000
Subject: [Koha-bugs] [Bug 15704] The 264 index should be split by subfield
 to match how 260 is indexed
In-Reply-To: <bug-15704-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15704-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15704-70-Wq2vu9GDuD@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15704

--- Comment #15 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
*** Bug 18892 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jan 11 22:38:08 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 11 Jan 2020 21:38:08 +0000
Subject: [Koha-bugs] [Bug 18883] koha-http.conf designed for Apache 2.2
In-Reply-To: <bug-18883-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18883-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18883-70-WlBzSPxcjr@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18883

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |DUPLICATE
                 CC|                            |katrin.fischer at bsz-bw.de

--- Comment #1 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---


*** This bug has been marked as a duplicate of bug 17464 ***

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jan 11 22:38:08 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 11 Jan 2020 21:38:08 +0000
Subject: [Koha-bugs] [Bug 17464] Order deny,
 allow / Deny from all was deprecated in Apache 2.4 and is now a
 hard error
In-Reply-To: <bug-17464-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17464-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17464-70-t1MtwcgSn9@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17464

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |dcook at prosentient.com.au

--- Comment #2 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
*** Bug 18883 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jan 11 22:38:42 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 11 Jan 2020 21:38:42 +0000
Subject: [Koha-bugs] [Bug 18879] Sending notices via Facebook messenger
In-Reply-To: <bug-18879-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18879-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18879-70-EQaWhkh4JS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18879

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de
           Severity|enhancement                 |new feature

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Sat Jan 11 22:40:49 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 11 Jan 2020 21:40:49 +0000
Subject: [Koha-bugs] [Bug 18872] Clicking "Place hold" on
 catalogue/detail.pl triggers software error if any items have NULL
 homebranch
In-Reply-To: <bug-18872-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18872-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18872-70-4zRunHFwNs@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18872

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |WONTFIX

--- Comment #2 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
(In reply to Katrin Fischer from comment #1)
> I think it was agreed to not fix these kind of errors. The problem is the
> data - items always need to have an itemtype, homebranch and holdingbranch.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Sat Jan 11 22:54:17 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 11 Jan 2020 21:54:17 +0000
Subject: [Koha-bugs] [Bug 18711] No longer possible have a blank value for
 Classification Sources in the Administration Module
In-Reply-To: <bug-18711-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18711-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18711-70-w5c3xxqX8l@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18711

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=13246

--- Comment #3 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
This sounds similar as bug 13246.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jan 11 22:54:17 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 11 Jan 2020 21:54:17 +0000
Subject: [Koha-bugs] [Bug 13246] Item edit doesn't respect cn_source if not
 defined
In-Reply-To: <bug-13246-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13246-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13246-70-wVHq6nvLjy@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13246

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=18711

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jan 11 22:56:51 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 11 Jan 2020 21:56:51 +0000
Subject: [Koha-bugs] [Bug 18698] Get rid of [%% in translation for
 shelves-result.tt
In-Reply-To: <bug-18698-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18698-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18698-70-m0mRBURV5R@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18698

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=16559

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jan 11 22:56:51 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 11 Jan 2020 21:56:51 +0000
Subject: [Koha-bugs] [Bug 16559] [%% ... %%] should not be picked for
 translation
In-Reply-To: <bug-16559-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16559-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16559-70-YqFHxZLncA@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16559

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=18698

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jan 11 22:59:30 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 11 Jan 2020 21:59:30 +0000
Subject: [Koha-bugs] [Bug 18676] Optionally delete fast add items and
 records on return
In-Reply-To: <bug-18676-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18676-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18676-70-eDW829S4MY@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18676

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|enhancement                 |new feature

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jan 11 23:04:20 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 11 Jan 2020 22:04:20 +0000
Subject: [Koha-bugs] [Bug 18623] Send notification on creation of manual
 invoice
In-Reply-To: <bug-18623-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18623-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18623-70-AdMgDZkAbc@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18623

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de
           Severity|enhancement                 |new feature

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Sat Jan 11 23:14:59 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 11 Jan 2020 22:14:59 +0000
Subject: [Koha-bugs] [Bug 18546] Unhide the 'Hide window' link in OPAC cart
In-Reply-To: <bug-18546-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18546-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18546-70-MlVqNHO4rV@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18546

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de
             Status|BLOCKED                     |Patch doesn't apply

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jan 11 23:21:01 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 11 Jan 2020 22:21:01 +0000
Subject: [Koha-bugs] [Bug 18520] special_holidays should be unique by date
 and branch code
In-Reply-To: <bug-18520-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18520-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18520-70-jlzZ002qp2@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18520

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |DUPLICATE
                 CC|                            |katrin.fischer at bsz-bw.de
             Status|NEW                         |RESOLVED

--- Comment #1 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---


*** This bug has been marked as a duplicate of bug 18874 ***

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jan 11 23:21:01 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 11 Jan 2020 22:21:01 +0000
Subject: [Koha-bugs] [Bug 18874] Add unique constraint to
 repeatable_holidays and special_holidays
In-Reply-To: <bug-18874-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18874-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18874-70-SpFCnQhi1E@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18874

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |barton at bywatersolutions.com

--- Comment #8 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
*** Bug 18520 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jan 11 23:23:02 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 11 Jan 2020 22:23:02 +0000
Subject: [Koha-bugs] [Bug 18516] Add possibility to import text from file
 based help system as news based help system item
In-Reply-To: <bug-18516-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18516-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18516-70-ayNemDjgot@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18516

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de
             Status|NEW                         |BLOCKED

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Sat Jan 11 23:23:33 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 11 Jan 2020 22:23:33 +0000
Subject: [Koha-bugs] [Bug 18515] Use news based help system for OPAC
In-Reply-To: <bug-18515-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18515-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18515-70-mKJd9shMwb@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18515

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de
             Status|NEW                         |BLOCKED

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Sat Jan 11 23:25:10 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 11 Jan 2020 22:25:10 +0000
Subject: [Koha-bugs] [Bug 18513] Add test to detect errors in sysprefs.sql
In-Reply-To: <bug-18513-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18513-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18513-70-SAzgTfcvAd@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18513

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |INVALID
                 CC|                            |katrin.fischer at bsz-bw.de
             Status|NEW                         |RESOLVED

--- Comment #1 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
This doesn't specify which errors to look for - and we already got a test in
the QA tools for the alphabetic order in sysprefs.sql. Closing INVALID, please
reopen if you can add more info!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jan 11 23:28:57 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 11 Jan 2020 22:28:57 +0000
Subject: [Koha-bugs] [Bug 18496] Membership renewal fee
In-Reply-To: <bug-18496-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18496-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18496-70-8XE62M27UU@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18496

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=6812

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jan 11 23:28:57 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 11 Jan 2020 22:28:57 +0000
Subject: [Koha-bugs] [Bug 6812] Configure enrollment, renewal, duplicate card,
 hold fees by branch and patron category
In-Reply-To: <bug-6812-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-6812-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-6812-70-ldBm8ARcEc@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6812

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=18496

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jan 11 23:33:54 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 11 Jan 2020 22:33:54 +0000
Subject: [Koha-bugs] [Bug 18475] Table 'Place a hold on a specific item'
 needs a tidy up
In-Reply-To: <bug-18475-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18475-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18475-70-YZcMTWO6yW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18475

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |INVALID
                 CC|                            |katrin.fischer at bsz-bw.de
             Status|NEW                         |RESOLVED

--- Comment #1 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
I feel this bug doesn't have enough information for a fix at the moment. Please
reopen if you can add some more information.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jan 11 23:36:20 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 11 Jan 2020 22:36:20 +0000
Subject: [Koha-bugs] [Bug 18446] Test to ensure a system preference in .pref
 file also exists in sysprefs.sql
In-Reply-To: <bug-18446-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18446-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18446-70-4mNQy0gGgV@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18446

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=18513

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jan 11 23:36:20 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 11 Jan 2020 22:36:20 +0000
Subject: [Koha-bugs] [Bug 18513] Add test to detect errors in sysprefs.sql
In-Reply-To: <bug-18513-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18513-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18513-70-BJjQRROxzP@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18513

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=18446

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jan 11 23:38:32 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 11 Jan 2020 22:38:32 +0000
Subject: [Koha-bugs] [Bug 18454] Holds to pull timestamp
In-Reply-To: <bug-18454-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18454-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18454-70-fpXRkbd0GY@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18454

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |DUPLICATE
                 CC|                            |katrin.fischer at bsz-bw.de
             Status|NEW                         |RESOLVED

--- Comment #1 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---


*** This bug has been marked as a duplicate of bug 18440 ***

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jan 11 23:38:32 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 11 Jan 2020 22:38:32 +0000
Subject: [Koha-bugs] [Bug 18440] tmp_holdsqueue should have a timestamp
In-Reply-To: <bug-18440-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18440-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18440-70-hrN1amaSMH@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18440

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |black23 at gmail.com

--- Comment #1 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
*** Bug 18454 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Sat Jan 11 23:56:50 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 11 Jan 2020 22:56:50 +0000
Subject: [Koha-bugs] [Bug 18365] Appendix D. Notice & Slips Guides is out of
 date
In-Reply-To: <bug-18365-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18365-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18365-70-glM8mt24Ot@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18365

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de
           Keywords|                            |Manual

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jan 11 23:59:28 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 11 Jan 2020 22:59:28 +0000
Subject: [Koha-bugs] [Bug 18360] Allow deletion of cancelled order lines
In-Reply-To: <bug-18360-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18360-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18360-70-8QOkMQpIA5@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18360

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |nengard at gmail.com

--- Comment #3 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
*** Bug 14091 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jan 11 23:59:28 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 11 Jan 2020 22:59:28 +0000
Subject: [Koha-bugs] [Bug 14091] Allow to delete a cancelled order line
In-Reply-To: <bug-14091-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14091-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14091-70-fyJg6jibLg@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14091

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |DUPLICATE

--- Comment #2 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---


*** This bug has been marked as a duplicate of bug 18360 ***

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Jan 12 00:05:21 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 11 Jan 2020 23:05:21 +0000
Subject: [Koha-bugs] [Bug 18317] Allow check out of already checked out
 items through SIP
In-Reply-To: <bug-18317-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18317-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18317-70-58oV7SOJC3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18317

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Allow check out of already  |Allow check out of already
                   |checked out items trough    |checked out items through
                   |sip                         |SIP
          Component|Circulation                 |SIP2
                 CC|                            |katrin.fischer at bsz-bw.de

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Jan 12 00:09:30 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 11 Jan 2020 23:09:30 +0000
Subject: [Koha-bugs] [Bug 18293] REST API tests. fix dateformat change
 regression in tests
In-Reply-To: <bug-18293-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18293-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18293-70-tcyw7DiUtH@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18293

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de,
                   |                            |tomascohen at gmail.com

--- Comment #2 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Can this be closed?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Jan 12 00:12:34 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 11 Jan 2020 23:12:34 +0000
Subject: [Koha-bugs] [Bug 18261] Select item type not available when staff
 overrides hold policy
In-Reply-To: <bug-18261-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18261-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18261-70-R0HGjkmzWU@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18261

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |WORKSFORME

--- Comment #2 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
(In reply to Katrin Fischer from comment #1)
> Hi Andreas,
> 
> I've just tested on master and it works for me - As soon as the override is
> set in the system preferences the itemtype pull down is correct.
> 
> Do you still see problems? 
> 
> The relevant bit of code appears to be this:
> http://git.koha-community.org/gitweb/?p=koha.git;a=blob;f=reserve/request.pl;
> h=91b6ffdd959ff2bb96c01e2d13fbfd8a9b05a7fb;
> hb=df611b17d12b63bb2f14909969ff8e8f67a332d0#l481

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Jan 12 00:14:12 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 11 Jan 2020 23:14:12 +0000
Subject: [Koha-bugs] [Bug 24352] OpacItemLocation is buggy
In-Reply-To: <bug-24352-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24352-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24352-70-ECg03SF3CT@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24352

--- Comment #5 from David Nind <david at davidnind.com> ---
Face palm - records didn't have call numbers!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Jan 12 00:15:26 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 11 Jan 2020 23:15:26 +0000
Subject: [Koha-bugs] [Bug 24352] OpacItemLocation is buggy
In-Reply-To: <bug-24352-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24352-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24352-70-qXkz3ovncb@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24352

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Jan 12 00:16:10 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 11 Jan 2020 23:16:10 +0000
Subject: [Koha-bugs] [Bug 24352] OpacItemLocation is buggy
In-Reply-To: <bug-24352-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24352-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24352-70-GbbaQ5ss97@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24352

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #97225|0                           |1
        is obsolete|                            |

--- Comment #6 from David Nind <david at davidnind.com> ---
Created attachment 97257
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97257&action=edit
Bug 24352: OpacItemLocation is buggy

This patch modifies the OPAC's MARC21 search results XSLT so that the
OpacItemLocation preference correctly controls what information
displays. Previously the code for distinguishing between the 'location'
and 'collection' settings was combined.

To test, apply the patch and set the OPACXSLTResultsDisplay system
preference to 'default.'

Set the OpacItemLocation preference to 'call number only.'
 - On the OPAC search results page, each result with items should show
   information in this format:
   - "Availability: Items available for loan: {library} [Call number:
     {call number} ]

  With the OpacItemLocation preference set to 'collection code,'
   - "Availability: Items available for loan: {library}
      Collection(s): {collection description} [{ call number }]"

  With the OpacItemLocation preference set to 'location,'
   - "Availability: Items available for loan: {library}
      Location(s): {shelving location} [{ call number }]"

Signed-off-by: David Nind <david at davidnind.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Jan 12 00:16:12 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 11 Jan 2020 23:16:12 +0000
Subject: [Koha-bugs] [Bug 18232] Koha::Cache::flush - Simply flush all caches
In-Reply-To: <bug-18232-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18232-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18232-70-O1FVsxUUMk@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18232

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |BLOCKED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Jan 12 00:20:02 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 11 Jan 2020 23:20:02 +0000
Subject: [Koha-bugs] [Bug 18218] Contact information (borrower, branch,
 acquisitions), should be centralized into a single table
In-Reply-To: <bug-18218-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18218-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18218-70-IJy434sdZn@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18218

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
                 CC|                            |katrin.fischer at bsz-bw.de
         Resolution|---                         |DUPLICATE

--- Comment #1 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---


*** This bug has been marked as a duplicate of bug 17230 ***

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Jan 12 00:20:02 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 11 Jan 2020 23:20:02 +0000
Subject: [Koha-bugs] [Bug 17230] borrowers table should be better normalized
In-Reply-To: <bug-17230-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17230-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17230-70-1LxGP6UkvO@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17230

--- Comment #3 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
*** Bug 18218 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Jan 12 00:20:36 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 11 Jan 2020 23:20:36 +0000
Subject: [Koha-bugs] [Bug 17230] borrowers table should be better normalized
In-Reply-To: <bug-17230-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17230-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17230-70-XGc8UJXUWt@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17230

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de

--- Comment #4 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Bug 18218 suggested to remodel the aqcontacts table for this.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Jan 12 00:22:38 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 11 Jan 2020 23:22:38 +0000
Subject: [Koha-bugs] [Bug 18216] Apache2.4 403 errors for Gitified or git
 clone installs
In-Reply-To: <bug-18216-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18216-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18216-70-zLHXfDcEFU@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18216

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=17464

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Jan 12 00:22:38 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 11 Jan 2020 23:22:38 +0000
Subject: [Koha-bugs] [Bug 17464] Order deny,
 allow / Deny from all was deprecated in Apache 2.4 and is now a
 hard error
In-Reply-To: <bug-17464-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17464-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17464-70-OXrKAM1V1R@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17464

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=18216

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Jan 12 00:24:55 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 11 Jan 2020 23:24:55 +0000
Subject: [Koha-bugs] [Bug 18210] Allow API to update/ merge bibliographic
 records & not just replace
In-Reply-To: <bug-18210-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18210-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18210-70-51dATrJ0Mo@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18210

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
                 CC|                            |katrin.fischer at bsz-bw.de
         Resolution|---                         |DUPLICATE

--- Comment #2 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---


*** This bug has been marked as a duplicate of bug 14957 ***

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Jan 12 00:24:55 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 11 Jan 2020 23:24:55 +0000
Subject: [Koha-bugs] [Bug 14957] Write protecting MARC fields based on
 source of import
In-Reply-To: <bug-14957-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14957-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14957-70-p4LismeFha@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |bibliwho at gmail.com

--- Comment #189 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
*** Bug 18210 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Jan 12 00:25:42 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 11 Jan 2020 23:25:42 +0000
Subject: [Koha-bugs] [Bug 18207] smart-rules.pl should validate that all
 branches / patron categories / item types are covered by circ rules.
In-Reply-To: <bug-18207-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18207-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18207-70-gtpa04oiZe@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18207

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=15521
                 CC|                            |katrin.fischer at bsz-bw.de

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Jan 12 00:25:42 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 11 Jan 2020 23:25:42 +0000
Subject: [Koha-bugs] [Bug 15521] Make circulation rules backend more granular
In-Reply-To: <bug-15521-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15521-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15521-70-4tVuNbFxsU@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15521

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=18207

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Jan 12 00:27:04 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 11 Jan 2020 23:27:04 +0000
Subject: [Koha-bugs] [Bug 18203] Add per borrower category restrictions on
 ILL placement.
In-Reply-To: <bug-18203-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18203-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18203-70-7cGwcqoArX@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18203

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         QA Contact|testopia at bugs.koha-communit |
                   |y.org                       |
          Component|Circulation                 |ILL
                 CC|                            |katrin.fischer at bsz-bw.de

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Jan 12 00:28:36 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 11 Jan 2020 23:28:36 +0000
Subject: [Koha-bugs] [Bug 18197] Make borrowers-force-messaging-defaults a
 bit more standard
In-Reply-To: <bug-18197-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18197-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18197-70-pN5TGitVfD@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18197

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |Manual
                 CC|                            |katrin.fischer at bsz-bw.de

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Jan 12 00:30:37 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 11 Jan 2020 23:30:37 +0000
Subject: [Koha-bugs] [Bug 18193] Elasticsearch - adding new records from
 Z39.50 results in 'internal server error'
In-Reply-To: <bug-18193-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18193-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18193-70-9NdIVnXCBX@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18193

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|enhancement                 |minor
                 CC|                            |katrin.fischer at bsz-bw.de

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Jan 12 00:34:03 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 11 Jan 2020 23:34:03 +0000
Subject: [Koha-bugs] [Bug 18188] Should we rename items.booksellerid to
 items.acqsource ?
In-Reply-To: <bug-18188-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18188-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18188-70-DelcFQqN0x@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18188

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
          Component|Architecture, internals,    |Database
                   |and plumbing                |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Jan 12 00:34:30 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 11 Jan 2020 23:34:30 +0000
Subject: [Koha-bugs] [Bug 18186] Plack config: Amounts with decimal comma
 instead of decimal dot breaking payments
In-Reply-To: <bug-18186-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18186-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18186-70-qZF6gYxmqh@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18186

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Version|3.22                        |unspecified

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Jan 12 00:35:49 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 11 Jan 2020 23:35:49 +0000
Subject: [Koha-bugs] [Bug 18176] aqbooksellers.listprice and
 aqbooksellers.invoiceprice need to be renamed for currencies
In-Reply-To: <bug-18176-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18176-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18176-70-GFql6XxsYH@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18176

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
          Component|Acquisitions                |Database
                 CC|                            |katrin.fischer at bsz-bw.de
            Summary|aqbookesellers.listprice    |aqbooksellers.listprice and
                   |and                         |aqbooksellers.invoiceprice
                   |aqbookesellers.invoiceprice |need to be renamed for
                   |need to be renamed for      |currencies
                   |currencies                  |

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Sun Jan 12 00:43:33 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 11 Jan 2020 23:43:33 +0000
Subject: [Koha-bugs] [Bug 18140] Print Full MARC bib record from Advance
 Editor
In-Reply-To: <bug-18140-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18140-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18140-70-gxE2WqzUdh@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18140

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
          Component|Staff Client                |Cataloging
                 CC|                            |katrin.fischer at bsz-bw.de,
                   |                            |m.de.rooy at rijksmuseum.nl

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Jan 12 00:47:02 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 11 Jan 2020 23:47:02 +0000
Subject: [Koha-bugs] [Bug 18129] Adding staging user to staged batches,
 for better filtering
In-Reply-To: <bug-18129-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18129-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18129-70-oY7hYNLnPe@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18129

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de

--- Comment #6 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Should this have been Needs Signoff?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Jan 12 00:48:20 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 11 Jan 2020 23:48:20 +0000
Subject: [Koha-bugs] [Bug 18127] Add batch modified records to an existing
 list
In-Reply-To: <bug-18127-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18127-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18127-70-BQogpl2Gvu@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18127

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|BLOCKED                     |Patch doesn't apply
                 CC|                            |katrin.fischer at bsz-bw.de

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Jan 12 00:50:07 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 11 Jan 2020 23:50:07 +0000
Subject: [Koha-bugs] [Bug 18126] error message koha-common packages with
 unmet dependencies
In-Reply-To: <bug-18126-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18126-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18126-70-NPcOUisi7N@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18126

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
                 CC|                            |katrin.fischer at bsz-bw.de
         Resolution|---                         |INVALID

--- Comment #1 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
This was more of a support request (installation problem) - closing.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Jan 12 00:55:38 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 11 Jan 2020 23:55:38 +0000
Subject: [Koha-bugs] [Bug 18092] Serial Enumeration (enumchron) truncated to
 2 characters in by label creator
In-Reply-To: <bug-18092-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18092-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18092-70-cGjTD4SfOy@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18092

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=21504
                 CC|                            |katrin.fischer at bsz-bw.de

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Jan 12 00:55:38 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 11 Jan 2020 23:55:38 +0000
Subject: [Koha-bugs] [Bug 21504] enumchron (volume number) shows as 0 (when
 set to anything) in pdf in label creator
In-Reply-To: <bug-21504-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21504-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21504-70-gPDCK8D2rE@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21504

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=18092

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Jan 12 01:01:38 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 12 Jan 2020 00:01:38 +0000
Subject: [Koha-bugs] [Bug 18057] koha-restore should stop koha-indexer
 before deleting files
In-Reply-To: <bug-18057-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18057-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18057-70-gScAO6W2LK@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18057

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de

--- Comment #2 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
(In reply to Rudolf Byker from comment #1)

> koha-restore does not delete files...

Should we mark this INVALID then?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Jan 12 05:16:32 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 12 Jan 2020 04:16:32 +0000
Subject: [Koha-bugs] [Bug 24350] Can't place holds
In-Reply-To: <bug-24350-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24350-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24350-70-38AkcXCNaa@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24350

--- Comment #15 from Agustín Moyano <agustinmoyano at theke.io> ---
Created attachment 97258
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97258&action=edit
Bug 24350: (follow-up) Clear Koha::Libraries->pickup_locations() and move logic
to Koha::Template::Plugin::Branches->pickup_locations().

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Jan 12 06:44:58 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 12 Jan 2020 05:44:58 +0000
Subject: [Koha-bugs] [Bug 24350] Can't place holds
In-Reply-To: <bug-24350-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24350-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24350-70-f64lNcecKz@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24350

Agustín Moyano <agustinmoyano at theke.io> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #97258|0                           |1
        is obsolete|                            |

--- Comment #16 from Agustín Moyano <agustinmoyano at theke.io> ---
Created attachment 97259
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97259&action=edit
Bug 24350: (follow-up) Clear Koha::Libraries->pickup_locations() and move logic
to Koha::Template::Plugin::Branches->pickup_locations().

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Jan 12 06:55:43 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 12 Jan 2020 05:55:43 +0000
Subject: [Koha-bugs] [Bug 24350] Can't place holds
In-Reply-To: <bug-24350-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24350-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24350-70-1ZmI1jgF4H@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24350

Agustín Moyano <agustinmoyano at theke.io> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #97259|0                           |1
        is obsolete|                            |

--- Comment #17 from Agustín Moyano <agustinmoyano at theke.io> ---
Created attachment 97260
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97260&action=edit
Bug 24350: (follow-up) Clear Koha::Libraries->pickup_locations() and move logic
to Koha::Template::Plugin::Branches->pickup_locations().

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Jan 12 07:13:24 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 12 Jan 2020 06:13:24 +0000
Subject: [Koha-bugs] [Bug 24350] Can't place holds
In-Reply-To: <bug-24350-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24350-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24350-70-jOkJLf0gG7@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24350

--- Comment #18 from Agustín Moyano <agustinmoyano at theke.io> ---
Created attachment 97261
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97261&action=edit
Bug 24350: (follow-up) Fix pickup_location test in
t/db_dependent/Template/Plugin/Branches.t

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Jan 12 10:19:05 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 12 Jan 2020 09:19:05 +0000
Subject: [Koha-bugs] [Bug 17611] Searching for orders uses misleading column
 name "Pending order"
In-Reply-To: <bug-17611-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17611-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17611-70-IkLdyARNwP@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17611

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff
   Patch complexity|---                         |String patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Jan 12 10:19:09 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 12 Jan 2020 09:19:09 +0000
Subject: [Koha-bugs] [Bug 17611] Searching for orders uses misleading column
 name "Pending order"
In-Reply-To: <bug-17611-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17611-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17611-70-jhWeCuCMCe@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17611

--- Comment #4 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 97262
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97262&action=edit
Bug 17611: Change 'Pending order' to 'Quantity ordered'

Picking Quantity ordered as it seems more in line with
other pages in Koha where we show information. We always
show the quantity, so it makes sense to also have this
label on the 'order search' and 'copy existing order'.

Order search
1) Make sure you have some orders in your acq module
2) Go to the top and do an empty orders search
3) Review the column headings of the search results
4) Find "Pending order"

Order from existing order (copy)
1) Create or choose an existing open basket
2) 'Add to basket' - 'From existing orders'
3) Search to find some of your orders
4) Look at the column headings, find 'Pending order'
5) Pick some orders and fill out order information, save
6) Summary: Find 'Pending order' in the table again

x) Apply the patch and make sure all 'Pending' orders
above have been changed to 'Quantity ordered'.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Jan 12 10:19:21 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 12 Jan 2020 09:19:21 +0000
Subject: [Koha-bugs] [Bug 17611] Searching for orders uses misleading column
 name "Pending order"
In-Reply-To: <bug-17611-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17611-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17611-70-uUVI4UUJ87@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17611

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de
           Assignee|rbit at rbit.cz                |katrin.fischer at bsz-bw.de

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Jan 12 10:21:46 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 12 Jan 2020 09:21:46 +0000
Subject: [Koha-bugs] [Bug 17611] Searching for orders uses misleading column
 name "Pending order"
In-Reply-To: <bug-17611-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17611-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17611-70-5QUUNnrZB7@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17611

--- Comment #5 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Don't be mad at me, but after reviewing other pages in the acquisition module
and testing the partial receive process, I've decided to use the 'Quantity
ordered' instead of changing the content of the column. It feels more in line
with the other pages in the acquisition module for now.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Jan 12 10:31:41 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 12 Jan 2020 09:31:41 +0000
Subject: [Koha-bugs] [Bug 24404] New: Add missing space on invoices page
Message-ID: <bug-24404-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24404

            Bug ID: 24404
           Summary: Add missing space on invoices page
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: ASSIGNED
          Severity: trivial
          Priority: P5 - low
         Component: Acquisitions
          Assignee: katrin.fischer at bsz-bw.de
          Reporter: katrin.fischer at bsz-bw.de
        QA Contact: testopia at bugs.koha-community.org

There is a space missing after "Adjustments plus shipping:" showing the amount
directly after the text.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Jan 12 10:36:40 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 12 Jan 2020 09:36:40 +0000
Subject: [Koha-bugs] [Bug 24404] Add missing space on invoices page
In-Reply-To: <bug-24404-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24404-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24404-70-HxytL2MhqG@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24404

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |String patch
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Jan 12 10:36:43 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 12 Jan 2020 09:36:43 +0000
Subject: [Koha-bugs] [Bug 24404] Add missing space on invoices page
In-Reply-To: <bug-24404-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24404-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24404-70-ehIVCEcEgx@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24404

--- Comment #1 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 97263
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97263&action=edit
Bug 24404: Add missing space on invoices page / remove . from status

On the bottom of the invoices page the summary of adjustments and
shipping shows as:

Adjustments plus shipping:2.00

The patch adds the missing space between text and amount.

To test:
- 'Receive shipment' from a result in your vendor search
- Start a new invoice by entering an invoice number, amount
  for shipping cost and fund.
- Finish receive (you don't need to receive anything)
- You should now be on invoice.pl
- Verify Status is 'Open.' and in 'Invoice details' we
  have the amount with the missing space.
- Apply patch, reload the page.
- Verify the missing space is there and the . is gone.
- Close invoice, no . there either.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Jan 12 10:38:16 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 12 Jan 2020 09:38:16 +0000
Subject: [Koha-bugs] [Bug 17542] Altering an invoice throws error unless
 shipment date and billing date both defined or both undefined
In-Reply-To: <bug-17542-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17542-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17542-70-ENt6NAgQ7n@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17542

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de
         Resolution|---                         |WORKSFORME
             Status|NEW                         |RESOLVED

--- Comment #1 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
I can't replicate this bug on current master. I've tried several things on the
'receive shipment' and on the 'invoice' pages, but weren't able to make Koha
explode.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Jan 12 10:44:17 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 12 Jan 2020 09:44:17 +0000
Subject: [Koha-bugs] [Bug 24405] New: Links in facets are styled differently
 than other links on the results page in OPAC
Message-ID: <bug-24405-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24405

            Bug ID: 24405
           Summary: Links in facets are styled differently than other
                    links on the results page in OPAC
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: OPAC
          Assignee: oleonard at myacpl.org
          Reporter: katrin.fischer at bsz-bw.de
        QA Contact: testopia at bugs.koha-community.org

A small thing I've been wondering about:
The links in the facets are shown underlined, but other links, like the links
on each search result (title, place holds etc.) or navigation bar are not.

Why are some links underlined and others not?

There is a specific style causing this:

#search-facets a {
    font-weight: 400;
    text-decoration: underline;
}

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Jan 12 10:51:34 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 12 Jan 2020 09:51:34 +0000
Subject: [Koha-bugs] [Bug 24206] Change URLs for default options in
 OPACSearchForTitleIn
In-Reply-To: <bug-24206-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24206-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24206-70-g3sEXsd5Lp@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24206

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|Academy                     |additional_work_needed

--- Comment #17 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Needs a small follow-up, bug number in updatedatabase is missing:

Upgrade to 19.12.00.008 done (Bug XXXXX - Update OpacSearchForTitleIn system
preference)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Jan 12 10:53:26 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 12 Jan 2020 09:53:26 +0000
Subject: [Koha-bugs] [Bug 17661] Differences in field ending (whitespace,
 punctuation) cause duplicate facets
In-Reply-To: <bug-17661-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17661-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17661-70-t2cYRdLV8X@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17661

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff
                 CC|                            |katrin.fischer at bsz-bw.de

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Jan 12 11:02:15 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 12 Jan 2020 10:02:15 +0000
Subject: [Koha-bugs] [Bug 17661] Differences in field ending (whitespace,
 punctuation) cause duplicate facets
In-Reply-To: <bug-17661-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17661-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17661-70-yrixF98Xox@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17661

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Failed QA

--- Comment #9 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Hi Nick,

I thouhgt it would be very nice to revive this bug and looked at your WIP
patch. I think you were on the right track there, but I'd like to suggest some
changes to the regex.

You got:
$data =~ s/[.\-,]$//; 

I've tested with authors and made some changes on my data:

Without patch:

Aristophanes,
Aristophanes.
Beckett, Samuel,
Celan, Paul.
Date, C. J. 

With patch:

Aristophanes.
Beckett Samuel,
Celan Paul.
Date C. J. 

1) Your regex always removes the first occurence, but we need the last.
2) . is not removed as it's not escaped in the regex (I think).
2) In case of "Date, C. J." we don't want the last, when it's preceded by a
capital letter (very likely to be an initial).

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Jan 12 11:06:56 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 12 Jan 2020 10:06:56 +0000
Subject: [Koha-bugs] [Bug 24206] Change URLs for default options in
 OPACSearchForTitleIn
In-Reply-To: <bug-24206-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24206-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24206-70-sZPZPPvGw7@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24206

--- Comment #18 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 97264
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97264&action=edit
Bug 24206: Add correct bug reference to update message in udpatedatabase

Fixes a small oversight by changing XXXX to 24206.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Jan 12 11:17:04 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 12 Jan 2020 10:17:04 +0000
Subject: [Koha-bugs] [Bug 17697] Improve NotesBlacklist system preference
 description to make clear where it will apply
In-Reply-To: <bug-17697-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17697-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17697-70-QvloSQbHVT@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17697

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|oleonard at myacpl.org         |katrin.fischer at bsz-bw.de
            Summary|Notes Blacklist only        |Improve NotesBlacklist
                   |blacklists fields on the    |system preference
                   |OPAC main detail view (not  |description to make clear
                   |the OPAC MARC display)      |where it will apply

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Jan 12 11:23:07 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 12 Jan 2020 10:23:07 +0000
Subject: [Koha-bugs] [Bug 24206] Change URLs for default options in
 OPACSearchForTitleIn
In-Reply-To: <bug-24206-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24206-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24206-70-dbTguu3BkR@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24206

--- Comment #19 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 97265
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97265&action=edit
k

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Jan 12 11:24:28 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 12 Jan 2020 10:24:28 +0000
Subject: [Koha-bugs] [Bug 24206] Change URLs for default options in
 OPACSearchForTitleIn
In-Reply-To: <bug-24206-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24206-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24206-70-DCSuscHu9s@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24206

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #97265|0                           |1
        is obsolete|                            |

--- Comment #20 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Comment on attachment 97265
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97265
k

Wrong bug number!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Jan 12 11:25:34 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 12 Jan 2020 10:25:34 +0000
Subject: [Koha-bugs] [Bug 17697] Improve NotesBlacklist system preference
 description to make clear where it will apply
In-Reply-To: <bug-17697-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17697-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17697-70-5P0p1vQK2o@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17697

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |String patch
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Jan 12 11:25:37 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 12 Jan 2020 10:25:37 +0000
Subject: [Koha-bugs] [Bug 17697] Improve NotesBlacklist system preference
 description to make clear where it will apply
In-Reply-To: <bug-17697-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17697-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17697-70-7cd0syNBVe@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17697

--- Comment #2 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 97266
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97266&action=edit
Bug 17697: Improve NotesBlacklist system preference description

- Switched 'separator' for more common 'tab' and rephrased sentence
- Added examples
- Added note to use hidden settings for hiding in other spots.

To test:
- Search for NotesBlacklist system preference and read the description
- Apply patch
- Refresh and read again
- If improved, sign off.

https://bugs.koha-community.org/show_bug.cgi?id=24206

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Jan 12 11:58:54 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 12 Jan 2020 10:58:54 +0000
Subject: [Koha-bugs] [Bug 17221] Orphan comma in shelf browser
In-Reply-To: <bug-17221-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17221-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17221-70-eMRtmLjYgQ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17221

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|ephetteplace at cca.edu        |katrin.fischer at bsz-bw.de
            Summary|orphan comma in shelf       |Orphan comma in shelf
                   |browser                     |browser

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Jan 12 12:07:54 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 12 Jan 2020 11:07:54 +0000
Subject: [Koha-bugs] [Bug 17221] Orphan comma in shelf browser
In-Reply-To: <bug-17221-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17221-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17221-70-blCqBKsm3E@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17221

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Jan 12 12:07:57 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 12 Jan 2020 11:07:57 +0000
Subject: [Koha-bugs] [Bug 17221] Orphan comma in shelf browser
In-Reply-To: <bug-17221-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17221-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17221-70-f7iqb9suo5@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17221

--- Comment #5 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 97267
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97267&action=edit
Bug 17221: Remove orphan commas in shelf browser

This patch adds more conditions to the shelf browser template
such that the displayed text reads as a proper list no matter
what combination of system preferences are utilized

Sponsored-by: California College of the Arts

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Jan 12 12:08:00 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 12 Jan 2020 11:08:00 +0000
Subject: [Koha-bugs] [Bug 17221] Orphan comma in shelf browser
In-Reply-To: <bug-17221-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17221-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17221-70-iaV1yXPKUA@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17221

--- Comment #6 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 97268
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97268&action=edit
Bug 17221: (follow-up) Orphan comma in shelf browser

This further improves the display if no location or no
collection has been set. Example output:

Browsing Centerville shelves, Collection: Non-fiction

Also changes 'Collection code' to 'collection' and takes
care of additional spaces before the comma.

To test:
- Make sure your OpacShelfBrowser pref is set to "Show"
- Search for a record with items and callnumbers in your OPAC
- "Browse shelf"
- Navigate back and forth, verify the information showing on
  top of the list is correctly formatted
- Try different combinations for the following prefs:
  - ShelfBrowserUsesCcode
  - ShelfBrowserUsesHomeBranch
  - ShelfBrowserUsesLocation
- Verify the display is always nicely formatted

Note: fixing capitalization here is tricky, as it also
depends on what was displayed before. If you have no
homebranch, you would want "Shelving...", if you have one
we'd like "shelving...". Left as I found it for now.

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Jan 12 12:08:40 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 12 Jan 2020 11:08:40 +0000
Subject: [Koha-bugs] [Bug 17221] Orphan comma in shelf browser
In-Reply-To: <bug-17221-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17221-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17221-70-FGCHWt6dKO@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17221

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #54998|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Jan 12 12:30:43 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 12 Jan 2020 11:30:43 +0000
Subject: [Koha-bugs] [Bug 23560] Manual FAQ doesn't reflect changes to
 accounttype codes
In-Reply-To: <bug-23560-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23560-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23560-70-9K1EmjorG1@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23560

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |katrin.fischer at bsz-bw.de
                   |ity.org                     |
         Resolution|---                         |FIXED
             Status|NEW                         |RESOLVED

--- Comment #1 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Submitted a patch to the manual:

https://gitlab.com/koha-community/koha-manual/merge_requests/322

Please also see this change already done for newer manuals:
https://gitlab.com/kfischer1/koha-manual/commit/296559cdb5b251a269f0e74e2ef8bb1e31a0212b

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Jan 12 12:33:29 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 12 Jan 2020 11:33:29 +0000
Subject: [Koha-bugs] [Bug 7573] Show basket number linked on fund search
In-Reply-To: <bug-7573-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-7573-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7573-70-pfglW28IFT@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7573

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
                 CC|                            |katrin.fischer at bsz-bw.de
         Resolution|---                         |FIXED

--- Comment #1 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
This is fixed, but also depending on permissions.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Sun Jan 12 12:41:09 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 12 Jan 2020 11:41:09 +0000
Subject: [Koha-bugs] [Bug 11161] Relabel 'child fund' to 'sub fund'
In-Reply-To: <bug-11161-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-11161-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11161-70-wfJkXAL8zt@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11161

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |katrin.fischer at bsz-bw.de
                   |ity.org                     |
                 CC|                            |katrin.fischer at bsz-bw.de
            Summary|relabel child fund to 'sub  |Relabel 'child fund' to
                   |fund'                       |'sub fund'

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Sun Jan 12 12:44:53 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 12 Jan 2020 11:44:53 +0000
Subject: [Koha-bugs] [Bug 11161] Relabel 'child fund' to 'sub fund'
In-Reply-To: <bug-11161-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-11161-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11161-70-MxFMIEJxmQ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11161

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |String patch
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Jan 12 12:44:56 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 12 Jan 2020 11:44:56 +0000
Subject: [Koha-bugs] [Bug 11161] Relabel 'child fund' to 'sub fund'
In-Reply-To: <bug-11161-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-11161-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11161-70-5GFaP3cTg6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11161

--- Comment #1 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 97269
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97269&action=edit
Bug 11161: Relabel 'child fund' to 'sub fund' in staff interface

It was noted, that 'sub fund' might be a better term to use than
'child fund'. So this patch changes it.

To test, check with and without patch:

- Add a budget in acquisitions
- Add a fund in acquisitions
- Add a sub/child fund to your fund (label of menu item #1)
- Edit your first fund, check option to update owners of
  sub/child funds (#2)
- Try to delete your 'parent' fund (tooltip #3)
- Click on the greyed out entry (alert ÃÃ#4)

If you like the chane, please sign-off. If you think otherwise,
please comment on the bug report.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Jan 12 12:45:38 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 12 Jan 2020 11:45:38 +0000
Subject: [Koha-bugs] [Bug 11161] Relabel 'child fund' to 'sub fund'
In-Reply-To: <bug-11161-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-11161-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11161-70-s7y7NBN9e9@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11161

--- Comment #2 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
This was a quick change actually, so putting the patch up and see what people
think :)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Jan 12 12:49:40 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 12 Jan 2020 11:49:40 +0000
Subject: [Koha-bugs] [Bug 11728] Offline circ shows weird amount of decimals
 in fine amount
In-Reply-To: <bug-11728-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-11728-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11728-70-3ZXYaREa4z@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11728

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de

--- Comment #1 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
There appears to be bigger problems in the interface now:

- item types and branches show undefined
- fines don't show, although I have some on my account

:(

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Sun Jan 12 12:54:34 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 12 Jan 2020 11:54:34 +0000
Subject: [Koha-bugs] [Bug 24406] New: Remove patron category category type
 codes from patron search results
Message-ID: <bug-24406-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24406

            Bug ID: 24406
           Summary: Remove patron category category type codes from patron
                    search results
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Patrons
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: katrin.fischer at bsz-bw.de
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com

In the patron search, the category type of a patron will show after the patron
category description. Example: Student (A)

This is confusing as those codes (A = Adult) show nowhere else in the staff
interface and can't be easily translated by people using the English templates,
but have even less meaning for people using translated templates. 

I suggest to remove them as I always end up explaining this in training and
it's not really useful information.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Jan 12 12:54:44 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 12 Jan 2020 11:54:44 +0000
Subject: [Koha-bugs] [Bug 24406] Remove patron category category type codes
 from patron search results
In-Reply-To: <bug-24406-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24406-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24406-70-ejfgwR6FRo@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24406

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
           Assignee|koha-bugs at lists.koha-commun |katrin.fischer at bsz-bw.de
                   |ity.org                     |

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Jan 12 17:21:30 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 12 Jan 2020 16:21:30 +0000
Subject: [Koha-bugs] [Bug 16784] Add table configuration on suggestions table
In-Reply-To: <bug-16784-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16784-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16784-70-Cr9E0EJmbf@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16784

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |oleonard at myacpl.org
                   |ity.org                     |
             Status|NEW                         |ASSIGNED

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Jan 12 19:29:10 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 12 Jan 2020 18:29:10 +0000
Subject: [Koha-bugs] [Bug 24391] Remove event attributes from patron clubs
 edit template
In-Reply-To: <bug-24391-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24391-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24391-70-EH4UUYHNMQ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24391

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Jan 12 19:29:14 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 12 Jan 2020 18:29:14 +0000
Subject: [Koha-bugs] [Bug 24391] Remove event attributes from patron clubs
 edit template
In-Reply-To: <bug-24391-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24391-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24391-70-BZGdDk60wQ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24391

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #97140|0                           |1
        is obsolete|                            |

--- Comment #3 from David Nind <david at davidnind.com> ---
Created attachment 97270
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97270&action=edit
Bug 24391: Remove event attributes from patron clubs edit template

This patch removes "onclick" attributes from the template for adding and
editing patron club templates.

To test, apply the patch and go to Tools -> Patron clubs -> New club
template.

Test the process of adding and deleting both club and enrollment fields.
Test during the template add process and when editing an existing
template.

Signed-off-by: David Nind <david at davidnind.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Jan 12 19:43:35 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 12 Jan 2020 18:43:35 +0000
Subject: [Koha-bugs] [Bug 19465] Allow choosing Elasticsearch server on
 instance creation
In-Reply-To: <bug-19465-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19465-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19465-70-hiaIMb4AXD@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19465

Joy Nelson <joy at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |joy at bywatersolutions.com
             Status|Pushed to master            |Pushed to stable
         Version(s)|20.05.00                    |20.05.00, 19.11.02
        released in|                            |

--- Comment #13 from Joy Nelson <joy at bywatersolutions.com> ---
Pushed to 19.11.x branch for 19.11.02

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Jan 12 19:46:09 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 12 Jan 2020 18:46:09 +0000
Subject: [Koha-bugs] [Bug 24046] 'Activate filters' untranslatable
In-Reply-To: <bug-24046-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24046-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24046-70-cmuEQGIq1U@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24046

Joy Nelson <joy at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|20.05.00                    |20.05.00, 19.11.02
        released in|                            |
                 CC|                            |joy at bywatersolutions.com
             Status|Pushed to master            |Pushed to stable

--- Comment #8 from Joy Nelson <joy at bywatersolutions.com> ---
Pushed to 19.11.x branch for 19.11.02

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Jan 12 19:46:48 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 12 Jan 2020 18:46:48 +0000
Subject: [Koha-bugs] [Bug 24242] Funds with no library assigned do not
 appear on edit suggestions page
In-Reply-To: <bug-24242-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24242-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24242-70-mYBuQojwl0@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24242

Joy Nelson <joy at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |joy at bywatersolutions.com
             Status|Pushed to master            |Pushed to stable
         Version(s)|20.05.00                    |20.05.00, 19.11.02
        released in|                            |

--- Comment #6 from Joy Nelson <joy at bywatersolutions.com> ---
Pushed to 19.11.x branch for 19.11.02

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Jan 12 19:47:16 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 12 Jan 2020 18:47:16 +0000
Subject: [Koha-bugs] [Bug 24358] "Bibliographic record does not exist!" is
 not translatable
In-Reply-To: <bug-24358-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24358-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24358-70-vqy1AFiUZj@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24358

Joy Nelson <joy at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to master            |Pushed to stable
         Version(s)|20.05.00                    |20.05.00, 19.11.02
        released in|                            |
                 CC|                            |joy at bywatersolutions.com

--- Comment #5 from Joy Nelson <joy at bywatersolutions.com> ---
Pushed to 19.11.x branch for 19.11.02

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Jan 12 20:02:36 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 12 Jan 2020 19:02:36 +0000
Subject: [Koha-bugs] [Bug 24121] Item types icons in intra search results
 are requesting icons from opac images path
In-Reply-To: <bug-24121-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24121-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24121-70-DzuZu1TLJJ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24121

Joy Nelson <joy at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|20.05.00                    |20.05.00, 19.11.02
        released in|                            |
                 CC|                            |joy at bywatersolutions.com
             Status|Pushed to master            |Pushed to stable

--- Comment #13 from Joy Nelson <joy at bywatersolutions.com> ---
Pushed to 19.11.x branch for 19.11.02

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Jan 12 20:02:59 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 12 Jan 2020 19:02:59 +0000
Subject: [Koha-bugs] [Bug 18688] Warnings about UTF-8 charset when creating
 a new language
In-Reply-To: <bug-18688-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18688-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18688-70-CvArFzYraf@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18688

Joy Nelson <joy at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |joy at bywatersolutions.com
         Version(s)|20.05.00                    |20.05.00, 19.11.02
        released in|                            |
             Status|Pushed to master            |Pushed to stable

--- Comment #5 from Joy Nelson <joy at bywatersolutions.com> ---
Pushed to 19.11.x branch for 19.11.02

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Jan 12 20:03:22 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 12 Jan 2020 19:03:22 +0000
Subject: [Koha-bugs] [Bug 24283] Missing close parens and closing strong tag
 in course reserves
In-Reply-To: <bug-24283-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24283-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24283-70-hUOey2Ssuw@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24283

Joy Nelson <joy at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |joy at bywatersolutions.com
         Version(s)|20.05.00                    |20.05.00, 19.11.02
        released in|                            |
             Status|Pushed to master            |Pushed to stable

--- Comment #4 from Joy Nelson <joy at bywatersolutions.com> ---
Pushed to 19.11.x branch for 19.11.02

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Jan 12 20:03:47 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 12 Jan 2020 19:03:47 +0000
Subject: [Koha-bugs] [Bug 24281] Fix the list of types of visual materials
In-Reply-To: <bug-24281-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24281-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24281-70-9S7LtA2PwF@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24281

Joy Nelson <joy at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|20.05.00                    |20.05.00, 19.11.02
        released in|                            |
                 CC|                            |joy at bywatersolutions.com
             Status|Pushed to master            |Pushed to stable

--- Comment #4 from Joy Nelson <joy at bywatersolutions.com> ---
Pushed to 19.11.x branch for 19.11.02

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Jan 12 20:04:12 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 12 Jan 2020 19:04:12 +0000
Subject: [Koha-bugs] [Bug 24274] New installations should not contain field
 01e Coded field error (RLIN)
In-Reply-To: <bug-24274-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24274-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24274-70-3PUivx1gaV@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24274

Joy Nelson <joy at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to master            |Pushed to stable
         Version(s)|20.05.00                    |20.05.00, 19.11.02
        released in|                            |
                 CC|                            |joy at bywatersolutions.com

--- Comment #6 from Joy Nelson <joy at bywatersolutions.com> ---
Pushed to 19.11.x branch for 19.11.02

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Jan 12 20:11:10 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 12 Jan 2020 19:11:10 +0000
Subject: [Koha-bugs] [Bug 24308] Suggestions table on suggestions.pl should
 have separate columns for dates
In-Reply-To: <bug-24308-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24308-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24308-70-MpHxgSfMiC@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24308

Joy Nelson <joy at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |joy at bywatersolutions.com
         Version(s)|20.05.00                    |20.05.00, 19.11.02
        released in|                            |
             Status|Pushed to master            |Pushed to stable

--- Comment #9 from Joy Nelson <joy at bywatersolutions.com> ---
Pushed to 19.11.x branch for 19.11.02

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Jan 12 20:13:16 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 12 Jan 2020 19:13:16 +0000
Subject: [Koha-bugs] [Bug 24335] Cannot mark checkout notes seen/not seen in
 bulk
In-Reply-To: <bug-24335-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24335-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24335-70-bl3chpUZC2@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24335

Joy Nelson <joy at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|20.05.00                    |20.05.00, 19.11.02
        released in|                            |
             Status|Pushed to master            |Pushed to stable
                 CC|                            |joy at bywatersolutions.com

--- Comment #6 from Joy Nelson <joy at bywatersolutions.com> ---
Pushed to 19.11.x branch for 19.11.02

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Jan 12 20:13:51 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 12 Jan 2020 19:13:51 +0000
Subject: [Koha-bugs] [Bug 24337] Checkout note cannot be marked seen if more
 than 20 exist
In-Reply-To: <bug-24337-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24337-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24337-70-ozCnruKM1V@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24337

Joy Nelson <joy at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|20.05.00                    |20.05.00, 19.11.02
        released in|                            |
                 CC|                            |joy at bywatersolutions.com
             Status|Pushed to master            |Pushed to stable

--- Comment #9 from Joy Nelson <joy at bywatersolutions.com> ---
Pushed to 19.11.x branch for 19.11.02

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Jan 12 20:14:48 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 12 Jan 2020 19:14:48 +0000
Subject: [Koha-bugs] [Bug 24257] item-transfer-modal does not initiate
 transfer when 'yes, print slip' is selected
In-Reply-To: <bug-24257-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24257-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24257-70-cva7sQ3Hiq@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24257

Joy Nelson <joy at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|20.05.00                    |20.05.00, 19.11.02
        released in|                            |
             Status|Pushed to master            |Pushed to stable
                 CC|                            |joy at bywatersolutions.com

--- Comment #7 from Joy Nelson <joy at bywatersolutions.com> ---
Pushed to 19.11.x branch for 19.11.02

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Jan 12 20:21:48 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 12 Jan 2020 19:21:48 +0000
Subject: [Koha-bugs] [Bug 24166] Barcode removal breaks
 circulation.pl/moremember.pl
In-Reply-To: <bug-24166-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24166-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24166-70-zKuZ2Kb9HR@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24166

Joy Nelson <joy at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to master            |Pushed to stable
                 CC|                            |joy at bywatersolutions.com
         Version(s)|20.05.00                    |20.05.00, 19.11.02
        released in|                            |

--- Comment #5 from Joy Nelson <joy at bywatersolutions.com> ---
Pushed to 19.11.x branch for 19.11.02

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Jan 12 20:32:13 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 12 Jan 2020 19:32:13 +0000
Subject: [Koha-bugs] [Bug 7047] Renewing serials note not visible
In-Reply-To: <bug-7047-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-7047-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7047-70-gWgN8VWU9s@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7047

Joy Nelson <joy at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|Pushed to master            |RESOLVED
                 CC|                            |joy at bywatersolutions.com

--- Comment #28 from Joy Nelson <joy at bywatersolutions.com> ---
Does not apply to 19.11.x branch.  Not backported.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Jan 12 21:02:30 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 12 Jan 2020 20:02:30 +0000
Subject: [Koha-bugs] [Bug 24393] Remove event attributes from patron clubs
 list template
In-Reply-To: <bug-24393-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24393-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24393-70-pYooyPl5Ug@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24393

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |david at davidnind.com

--- Comment #2 from David Nind <david at davidnind.com> ---
Something in master has broken "Search to hold" - getting this error message
when trying to add a hold (just the start of the error message):

> Template process failed: undef error - Not an ARRAY reference at /kohadevbox/koha/Koha/Template/Plugin/Branches.pm line 95.
>  at /kohadevbox/koha/C4/Templates.pm line 122
> 
>     in C4::Templates::output at /kohadevbox/koha/C4/Templates.pm line 122
> 
>       119: 
>       120:     my $data;
>       121:     binmode( STDOUT, ":utf8" );
>       122:     $template->process( $self->filename, $vars, \$data )
>       123:       || die "Template process failed: ", $template->error();
>       124:     return $data;
>       125: }
> 
>     Show function arguments

Placing a hold works fine on 19.11.x.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Jan 12 21:03:32 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 12 Jan 2020 20:03:32 +0000
Subject: [Koha-bugs] [Bug 23354] Add a 'Pay' screen to allow anonymous
 payments in a POS fashion
In-Reply-To: <bug-23354-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23354-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23354-70-B97ewW6X6g@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23354

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Jan 12 21:03:36 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 12 Jan 2020 20:03:36 +0000
Subject: [Koha-bugs] [Bug 23354] Add a 'Pay' screen to allow anonymous
 payments in a POS fashion
In-Reply-To: <bug-23354-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23354-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23354-70-eqsS8wWK2g@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23354

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #97200|0                           |1
        is obsolete|                            |
  Attachment #97201|0                           |1
        is obsolete|                            |
  Attachment #97202|0                           |1
        is obsolete|                            |
  Attachment #97203|0                           |1
        is obsolete|                            |
  Attachment #97204|0                           |1
        is obsolete|                            |
  Attachment #97205|0                           |1
        is obsolete|                            |
  Attachment #97206|0                           |1
        is obsolete|                            |
  Attachment #97207|0                           |1
        is obsolete|                            |
  Attachment #97208|0                           |1
        is obsolete|                            |
  Attachment #97209|0                           |1
        is obsolete|                            |
  Attachment #97210|0                           |1
        is obsolete|                            |
  Attachment #97211|0                           |1
        is obsolete|                            |
  Attachment #97212|0                           |1
        is obsolete|                            |
  Attachment #97213|0                           |1
        is obsolete|                            |
  Attachment #97214|0                           |1
        is obsolete|                            |
  Attachment #97215|0                           |1
        is obsolete|                            |
  Attachment #97216|0                           |1
        is obsolete|                            |
  Attachment #97217|0                           |1
        is obsolete|                            |
  Attachment #97218|0                           |1
        is obsolete|                            |
  Attachment #97219|0                           |1
        is obsolete|                            |

--- Comment #132 from Josef Moravec <josef.moravec at gmail.com> ---
Created attachment 97271
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97271&action=edit
Bug 23354: Add a Point Of Sale 'pay' screen

This patch adds a new Point Of Sale module to Koha's staff client front
page. The module button leads directly to a 'Pay' page giving the staff
user the ability to record anonymous payments for items that would not
normally require a patron to be registered at the library.

Test plan:
1) Enable `UseCashRegisters` via the system preferences.
2) Ensure your user has the 'manage_cash_registers' permission.
3) Add a cash register for your current branch.
4) Add at least one 'MANUAL_INV' authorized value.
5) Navigate to the new 'POS' pay page via the main menu.
6) Add an item to the 'sale' by clicking 'add' from the right side of
   the screen.
7) Note that said item was added to the table of items this sale on the
   left.
8) At this point you should be able to 'click to edit' the quantity or
   price of the item in the table on the left.
9) Enter an amount greater than the price of the item into the 'amount
   collected from patron' box.
10) Click 'Confirm'
11) Varify that the same change to give modal from the paycollect pages
    appears here.
12) Click 'Confirm'
13) Payment will have been recorded (check the database) and you will be
    back at a fresh 'Pay' page ready for the next transaction.
14) Signoff

Sponsored-by: PTFS Europe
Sponsored-by: Cheshire Libraries Shared Services

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

Signed-off-by: Josef Moravec <josef.moravec at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Jan 12 21:03:43 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 12 Jan 2020 20:03:43 +0000
Subject: [Koha-bugs] [Bug 23354] Add a 'Pay' screen to allow anonymous
 payments in a POS fashion
In-Reply-To: <bug-23354-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23354-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23354-70-IDwboP3Q9Z@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23354

--- Comment #133 from Josef Moravec <josef.moravec at gmail.com> ---
Created attachment 97272
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97272&action=edit
Bug 23354: Add receipting to Pay page

This patch adds receipt printing to the new Point of Sale pay page.

Test plan:
1) Apply patch and run database update
2) Enable automatic receipt printing via the `` system preference.
3) Make a payment for an item via the new POS pay page.
4) Note that a receipt printing dialogue is shown automatically after
   payment.
5) Note that a new notice is available under tools where you can alter
   the content of the receipt.
6) Signoff

Sponsored-by: PTFS Europe
Sponsored-by: Cheshire Libraries Shared Services

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

Signed-off-by: Josef Moravec <josef.moravec at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Jan 12 21:03:49 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 12 Jan 2020 20:03:49 +0000
Subject: [Koha-bugs] [Bug 23354] Add a 'Pay' screen to allow anonymous
 payments in a POS fashion
In-Reply-To: <bug-23354-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23354-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23354-70-RHFwOIK6hb@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23354

--- Comment #134 from Josef Moravec <josef.moravec at gmail.com> ---
Created attachment 97273
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97273&action=edit
Bug 23354: Add ability to remove items

This patch adds the ability to remove items from a transactions on the
new Point of Sale pay page.

Test plan:
1) Populate a transaction with at least one item.
2) Note the new button to 'Remove item' on the items table.
3) Click the button and confirm the item is removed
4) Signoff

Sponsored-by: PTFS Europe
Sponsored-by: Cheshire Libraries Shared Services

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

Signed-off-by: Josef Moravec <josef.moravec at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Jan 12 21:03:54 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 12 Jan 2020 20:03:54 +0000
Subject: [Koha-bugs] [Bug 23354] Add a 'Pay' screen to allow anonymous
 payments in a POS fashion
In-Reply-To: <bug-23354-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23354-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23354-70-If7UQk9W2G@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23354

--- Comment #135 from Josef Moravec <josef.moravec at gmail.com> ---
Created attachment 97274
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97274&action=edit
Bug 23354: (follow-up) Responses to feedback

This patch impliments a number of refinements requested after the first
round of feedback from the sponsors.

1) Fix padding on pay page
2) Switch 'items to add' from right to left on the page
3) Fix editable columns on pay page
4) Add explanitory text to pay page

Sponsored-by: PTFS Europe
Sponsored-by: Cheshire Libraries Shared Services

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

Signed-off-by: Josef Moravec <josef.moravec at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Jan 12 21:04:00 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 12 Jan 2020 20:04:00 +0000
Subject: [Koha-bugs] [Bug 23354] Add a 'Pay' screen to allow anonymous
 payments in a POS fashion
In-Reply-To: <bug-23354-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23354-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23354-70-lbX4LTOD3G@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23354

--- Comment #136 from Josef Moravec <josef.moravec at gmail.com> ---
Created attachment 97275
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97275&action=edit
Bug 23354: Add permissions

Sponsored-by: PTFS Europe
Sponsored-by: Cheshire Libraries Shared Services

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

Signed-off-by: Josef Moravec <josef.moravec at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Jan 12 21:04:07 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 12 Jan 2020 20:04:07 +0000
Subject: [Koha-bugs] [Bug 23354] Add a 'Pay' screen to allow anonymous
 payments in a POS fashion
In-Reply-To: <bug-23354-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23354-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23354-70-NlAe7o2ijW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23354

--- Comment #137 from Josef Moravec <josef.moravec at gmail.com> ---
Created attachment 97276
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97276&action=edit
Bug 23354: Add tests for Koha::Charges::Sales

Sponsored-by: PTFS Europe
Sponsored-by: Cheshire Libraries Shared Services

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

Signed-off-by: Josef Moravec <josef.moravec at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Jan 12 21:04:14 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 12 Jan 2020 20:04:14 +0000
Subject: [Koha-bugs] [Bug 23354] Add a 'Pay' screen to allow anonymous
 payments in a POS fashion
In-Reply-To: <bug-23354-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23354-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23354-70-zZLFScKpwq@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23354

--- Comment #138 from Josef Moravec <josef.moravec at gmail.com> ---
Created attachment 97277
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97277&action=edit
Bug 23354: (follow-up) Input type on jEditable

Update the jEditable plugin to a maintained version and use the new
'number' type to enable increment arrows on click and remap onblur event
to submit.

Sponsored-by: PTFS Europe
Sponsored-by: Cheshire Libraries Shared Services

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

Signed-off-by: Josef Moravec <josef.moravec at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Jan 12 21:04:23 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 12 Jan 2020 20:04:23 +0000
Subject: [Koha-bugs] [Bug 23354] Add a 'Pay' screen to allow anonymous
 payments in a POS fashion
In-Reply-To: <bug-23354-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23354-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23354-70-O0sEbuERAD@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23354

--- Comment #139 from Josef Moravec <josef.moravec at gmail.com> ---
Created attachment 97278
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97278&action=edit
Bug 23354: (follow-up) Use 'format_price' for totals

Sponsored-by: PTFS Europe
Sponsored-by: Cheshire Libraries Shared Services

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

Signed-off-by: Josef Moravec <josef.moravec at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Jan 12 21:04:31 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 12 Jan 2020 20:04:31 +0000
Subject: [Koha-bugs] [Bug 23354] Add a 'Pay' screen to allow anonymous
 payments in a POS fashion
In-Reply-To: <bug-23354-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23354-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23354-70-RXZPLgloZs@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23354

--- Comment #140 from Josef Moravec <josef.moravec at gmail.com> ---
Created attachment 97279
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97279&action=edit
Bug 23354: Add Icon for POS system

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

Signed-off-by: Josef Moravec <josef.moravec at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Jan 12 21:04:38 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 12 Jan 2020 20:04:38 +0000
Subject: [Koha-bugs] [Bug 23354] Add a 'Pay' screen to allow anonymous
 payments in a POS fashion
In-Reply-To: <bug-23354-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23354-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23354-70-1xDqiDn25t@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23354

--- Comment #141 from Josef Moravec <josef.moravec at gmail.com> ---
Created attachment 97280
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97280&action=edit
Bug 23354: Update to account for bug 23049

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

Signed-off-by: Josef Moravec <josef.moravec at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Jan 12 21:04:45 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 12 Jan 2020 20:04:45 +0000
Subject: [Koha-bugs] [Bug 23354] Add a 'Pay' screen to allow anonymous
 payments in a POS fashion
In-Reply-To: <bug-23354-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23354-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23354-70-R9XejIWGLY@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23354

--- Comment #142 from Josef Moravec <josef.moravec at gmail.com> ---
Created attachment 97281
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97281&action=edit
Bug 23354: (follow-up) Make display of debit types configurable

This patch adds a the ability to define where a debit type will be
available as a option for use.

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

Signed-off-by: Josef Moravec <josef.moravec at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Jan 12 21:04:57 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 12 Jan 2020 20:04:57 +0000
Subject: [Koha-bugs] [Bug 23354] Add a 'Pay' screen to allow anonymous
 payments in a POS fashion
In-Reply-To: <bug-23354-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23354-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23354-70-ht3zvxYnFC@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23354

--- Comment #143 from Josef Moravec <josef.moravec at gmail.com> ---
Created attachment 97282
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97282&action=edit
Bug 23354: (follow-up) Ensure 'CASH' payment type is present

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

Signed-off-by: Josef Moravec <josef.moravec at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Jan 12 21:05:19 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 12 Jan 2020 20:05:19 +0000
Subject: [Koha-bugs] [Bug 23354] Add a 'Pay' screen to allow anonymous
 payments in a POS fashion
In-Reply-To: <bug-23354-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23354-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23354-70-Ph8Il0bQtu@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23354

--- Comment #144 from Josef Moravec <josef.moravec at gmail.com> ---
Created attachment 97283
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97283&action=edit
Bug 23354: (follow-up) Update for bugs 23049 and 23805

Remove all mentions of accounttype and replace with debit_type_code and
credit_type_code as appropriate.

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

Signed-off-by: Josef Moravec <josef.moravec at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Jan 12 21:05:30 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 12 Jan 2020 20:05:30 +0000
Subject: [Koha-bugs] [Bug 23354] Add a 'Pay' screen to allow anonymous
 payments in a POS fashion
In-Reply-To: <bug-23354-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23354-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23354-70-Sp1o0ncbWb@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23354

--- Comment #145 from Josef Moravec <josef.moravec at gmail.com> ---
Created attachment 97284
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97284&action=edit
Bug 23354: (follow-up) Fix for sending code instead of description

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

Signed-off-by: Josef Moravec <josef.moravec at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Jan 12 21:05:37 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 12 Jan 2020 20:05:37 +0000
Subject: [Koha-bugs] [Bug 23354] Add a 'Pay' screen to allow anonymous
 payments in a POS fashion
In-Reply-To: <bug-23354-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23354-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23354-70-nx3MvmTTbO@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23354

--- Comment #146 from Josef Moravec <josef.moravec at gmail.com> ---
Created attachment 97285
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97285&action=edit
Bug 23354: Format price on item add

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

Signed-off-by: Josef Moravec <josef.moravec at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Jan 12 21:05:45 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 12 Jan 2020 20:05:45 +0000
Subject: [Koha-bugs] [Bug 23354] Add a 'Pay' screen to allow anonymous
 payments in a POS fashion
In-Reply-To: <bug-23354-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23354-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23354-70-C5RLCJIlzP@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23354

--- Comment #147 from Josef Moravec <josef.moravec at gmail.com> ---
Created attachment 97286
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97286&action=edit
Bug 23354: Prevent negatives from being entered

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

Signed-off-by: Josef Moravec <josef.moravec at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Jan 12 21:05:57 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 12 Jan 2020 20:05:57 +0000
Subject: [Koha-bugs] [Bug 23354] Add a 'Pay' screen to allow anonymous
 payments in a POS fashion
In-Reply-To: <bug-23354-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23354-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23354-70-deiauWnYpH@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23354

--- Comment #148 from Josef Moravec <josef.moravec at gmail.com> ---
Created attachment 97287
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97287&action=edit
Bug 23354: (QA follow-up) Mark boolean columns in schema

Signed-off-by: Josef Moravec <josef.moravec at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Jan 12 21:06:05 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 12 Jan 2020 20:06:05 +0000
Subject: [Koha-bugs] [Bug 23354] Add a 'Pay' screen to allow anonymous
 payments in a POS fashion
In-Reply-To: <bug-23354-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23354-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23354-70-dL0Oel6W9b@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23354

--- Comment #149 from Josef Moravec <josef.moravec at gmail.com> ---
Created attachment 97288
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97288&action=edit
Bug 23354: (QA follow-up) Add missing filters, remove tab chars

Signed-off-by: Josef Moravec <josef.moravec at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Jan 12 21:06:13 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 12 Jan 2020 20:06:13 +0000
Subject: [Koha-bugs] [Bug 23354] Add a 'Pay' screen to allow anonymous
 payments in a POS fashion
In-Reply-To: <bug-23354-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23354-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23354-70-X4KKltJ5te@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23354

--- Comment #150 from Josef Moravec <josef.moravec at gmail.com> ---
Created attachment 97289
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97289&action=edit
Bug 23354: (QA follow-up) Allow manual receipt printing

This patch adds an alert message that allows receipt printing for
transactions when FinePaymentAutoPopup is not enabled.

Signed-off-by: Josef Moravec <josef.moravec at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Jan 12 21:06:29 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 12 Jan 2020 20:06:29 +0000
Subject: [Koha-bugs] [Bug 23354] Add a 'Pay' screen to allow anonymous
 payments in a POS fashion
In-Reply-To: <bug-23354-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23354-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23354-70-mFNkHtuJmy@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23354

--- Comment #151 from Josef Moravec <josef.moravec at gmail.com> ---
Created attachment 97290
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97290&action=edit
Bug 23354: (QA follow-up) Rename test file

Note to RM: Squash on push

Signed-off-by: Josef Moravec <josef.moravec at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Jan 12 21:06:36 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 12 Jan 2020 20:06:36 +0000
Subject: [Koha-bugs] [Bug 23354] Add a 'Pay' screen to allow anonymous
 payments in a POS fashion
In-Reply-To: <bug-23354-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23354-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23354-70-QgJ7rnacMz@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23354

--- Comment #152 from Josef Moravec <josef.moravec at gmail.com> ---
Created attachment 97291
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97291&action=edit
Bug 23354: (QA follow-up) Make db update idempotent

Signed-off-by: Josef Moravec <josef.moravec at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Jan 12 21:06:50 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 12 Jan 2020 20:06:50 +0000
Subject: [Koha-bugs] [Bug 23354] Add a 'Pay' screen to allow anonymous
 payments in a POS fashion
In-Reply-To: <bug-23354-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23354-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23354-70-CrZxoCYwsF@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23354

--- Comment #153 from Josef Moravec <josef.moravec at gmail.com> ---
Created attachment 97292
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97292&action=edit
Bug 23354: (QA follow-up) Fix spelling in templates

Signed-off-by: Josef Moravec <josef.moravec at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Jan 12 21:09:27 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 12 Jan 2020 20:09:27 +0000
Subject: [Koha-bugs] [Bug 23354] Add a 'Pay' screen to allow anonymous
 payments in a POS fashion
In-Reply-To: <bug-23354-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23354-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23354-70-g3xbocGR1z@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23354

--- Comment #154 from Josef Moravec <josef.moravec at gmail.com> ---
(In reply to Martin Renvoize from comment #131)
> Ready for a second QA round now, hopefully, that's everything fixed. :)
> 
> Remember to `yarn build` to get the display issues corrected.
> 
> Thanks Josef :)


I thought I did run 'yarn build', but maybe not...

Anyway I just added two more small follow-ups and passed QA, great job!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Jan 12 21:34:25 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 12 Jan 2020 20:34:25 +0000
Subject: [Koha-bugs] [Bug 24393] Remove event attributes from patron clubs
 list template
In-Reply-To: <bug-24393-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24393-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24393-70-SR93L21473@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24393

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de

--- Comment #3 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
(In reply to David Nind from comment #2)
> Something in master has broken "Search to hold" - getting this error message
> when trying to add a hold (just the start of the error message):
> 
> > Template process failed: undef error - Not an ARRAY reference at /kohadevbox/koha/Koha/Template/Plugin/Branches.pm line 95.
> >  at /kohadevbox/koha/C4/Templates.pm line 122
> > 

Hi David, this is probably bug 24350 - hopefully to be fixed soon.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Jan 12 21:46:35 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 12 Jan 2020 20:46:35 +0000
Subject: [Koha-bugs] [Bug 24208] Remove change calculation for writeoffs
In-Reply-To: <bug-24208-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24208-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24208-70-6wmb27krso@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24208

Joy Nelson <joy at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|20.05.00                    |20.05.00, 19.11.02
        released in|                            |
             Status|Pushed to master            |Pushed to stable
                 CC|                            |joy at bywatersolutions.com

--- Comment #10 from Joy Nelson <joy at bywatersolutions.com> ---
Pushed to 19.11.x branch for 19.11.02

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Jan 12 22:08:28 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 12 Jan 2020 21:08:28 +0000
Subject: [Koha-bugs] [Bug 14963] Add the ability to suggest purchase from
 existing titles
In-Reply-To: <bug-14963-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14963-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14963-70-IenkSXBmHa@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14963

Joy Nelson <joy at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|Pushed to master            |RESOLVED
                 CC|                            |joy at bywatersolutions.com

--- Comment #30 from Joy Nelson <joy at bywatersolutions.com> ---
New feature.  Not backported to 19.11.x

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Jan 12 22:08:28 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 12 Jan 2020 21:08:28 +0000
Subject: [Koha-bugs] [Bug 23590] Allow to modify the manager of a suggestion
In-Reply-To: <bug-23590-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23590-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23590-70-pYaSV52BAY@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23590
Bug 23590 depends on bug 14963, which changed state.

Bug 14963 Summary: Add the ability to suggest purchase from existing titles
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14963

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to master            |RESOLVED
         Resolution|---                         |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Jan 12 22:08:29 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 12 Jan 2020 21:08:29 +0000
Subject: [Koha-bugs] [Bug 24344] Modify OPAC link to suggest existing record
 for purchase
In-Reply-To: <bug-24344-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24344-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24344-70-hG6WuXRkOj@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24344
Bug 24344 depends on bug 14963, which changed state.

Bug 14963 Summary: Add the ability to suggest purchase from existing titles
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14963

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to master            |RESOLVED
         Resolution|---                         |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Jan 12 22:08:29 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 12 Jan 2020 21:08:29 +0000
Subject: [Koha-bugs] [Bug 24345] Fix process of suggesting purchase of
 existing title for non-logged-in users
In-Reply-To: <bug-24345-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24345-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24345-70-gsWi240gLc@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24345
Bug 24345 depends on bug 14963, which changed state.

Bug 14963 Summary: Add the ability to suggest purchase from existing titles
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14963

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to master            |RESOLVED
         Resolution|---                         |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Jan 12 22:09:03 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 12 Jan 2020 21:09:03 +0000
Subject: [Koha-bugs] [Bug 14973] Add an alert during purchase suggestion
 submissions to warn the user when an existing biblio appears to satisfy the
 request
In-Reply-To: <bug-14973-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14973-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14973-70-WLhWIVppSl@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14973

Joy Nelson <joy at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to master            |RESOLVED
         Resolution|---                         |FIXED
                 CC|                            |joy at bywatersolutions.com

--- Comment #63 from Joy Nelson <joy at bywatersolutions.com> ---
New feature.  not backported to 19.11.x

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Jan 12 22:09:04 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 12 Jan 2020 21:09:04 +0000
Subject: [Koha-bugs] [Bug 14963] Add the ability to suggest purchase from
 existing titles
In-Reply-To: <bug-14963-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14963-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14963-70-UVFgP8Zwy1@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14963
Bug 14963 depends on bug 14973, which changed state.

Bug 14973 Summary: Add an alert during purchase suggestion submissions to warn the user when an existing biblio appears to satisfy the request
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14973

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to master            |RESOLVED
         Resolution|---                         |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Jan 12 22:20:52 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 12 Jan 2020 21:20:52 +0000
Subject: [Koha-bugs] [Bug 23889] Improve style of menu header in advanced
 cataloging editor
In-Reply-To: <bug-23889-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23889-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23889-70-HhZdvXiKfo@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23889

Joy Nelson <joy at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |joy at bywatersolutions.com
             Status|Pushed to master            |Pushed to stable
         Version(s)|20.05.00                    |20.05.00, 19.11.02
        released in|                            |

--- Comment #9 from Joy Nelson <joy at bywatersolutions.com> ---
Pushed to 19.11.x branch for 19.11.02

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Jan 12 22:22:02 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 12 Jan 2020 21:22:02 +0000
Subject: [Koha-bugs] [Bug 24267] C4::Breeding::ImportBreedingAuth is
 ineffective
In-Reply-To: <bug-24267-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24267-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24267-70-POl9g01yTc@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24267

Joy Nelson <joy at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |joy at bywatersolutions.com
         Version(s)|20.05.00                    |20.05.00, 19.11.02
        released in|                            |
             Status|Pushed to master            |Pushed to stable

--- Comment #16 from Joy Nelson <joy at bywatersolutions.com> ---
Pushed to 19.11.x branch for 19.11.02

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Jan 12 22:22:41 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 12 Jan 2020 21:22:41 +0000
Subject: [Koha-bugs] [Bug 24316] Fix non-English web installers by removing
 obsolete authorised value MANUAL_INV
In-Reply-To: <bug-24316-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24316-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24316-70-ttO7NQk0KO@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24316

Joy Nelson <joy at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to master            |Pushed to stable
                 CC|                            |joy at bywatersolutions.com
         Version(s)|20.05.00                    |20.05.00, 19.11.02
        released in|                            |

--- Comment #12 from Joy Nelson <joy at bywatersolutions.com> ---
Pushed to 19.11.x branch for 19.11.02

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Jan 12 22:33:55 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 12 Jan 2020 21:33:55 +0000
Subject: [Koha-bugs] [Bug 23915] Replace OPAC list sort menu with Bootstrap
 menu button
In-Reply-To: <bug-23915-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23915-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23915-70-njBBW2HLxM@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23915
Bug 23915 depends on bug 23913, which changed state.

Bug 23913 Summary: Use a single menu to sort lists in the OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23913

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to master            |RESOLVED
         Resolution|---                         |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Jan 12 22:33:55 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 12 Jan 2020 21:33:55 +0000
Subject: [Koha-bugs] [Bug 23913] Use a single menu to sort lists in the OPAC
In-Reply-To: <bug-23913-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23913-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23913-70-UypE5cV3fq@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23913

Joy Nelson <joy at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to master            |RESOLVED
         Resolution|---                         |FIXED
                 CC|                            |joy at bywatersolutions.com

--- Comment #5 from Joy Nelson <joy at bywatersolutions.com> ---
Not backported to 19.11.x

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Jan 12 22:36:43 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 12 Jan 2020 21:36:43 +0000
Subject: [Koha-bugs] [Bug 23261] RecordedBooks - notify patron of need to
 login / register to see availability
In-Reply-To: <bug-23261-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23261-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23261-70-aeUqbhuh6I@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23261

Joy Nelson <joy at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|20.05.00                    |20.05.00, 19.11.02
        released in|                            |
             Status|Pushed to master            |Pushed to stable
                 CC|                            |joy at bywatersolutions.com

--- Comment #10 from Joy Nelson <joy at bywatersolutions.com> ---
Pushed to 19.11.x branch for 19.11.02

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 13 00:31:14 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 12 Jan 2020 23:31:14 +0000
Subject: [Koha-bugs] [Bug 23181] Unable to use payment library in
 ACCOUNT_PAYMENT or ACCOUNT_WRITEOFF notices
In-Reply-To: <bug-23181-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23181-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23181-70-BJEz6GM1c8@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23181

Hayley Mapley <hayleymapley at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to stable            |Pushed to oldstable
         Version(s)|19.11.00,19.05.05           |19.11.00,19.05.05, 18.11.13
        released in|                            |

--- Comment #15 from Hayley Mapley <hayleymapley at catalyst.net.nz> ---
Backported to 18.11.x for 18.1.13

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 13 00:31:27 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 12 Jan 2020 23:31:27 +0000
Subject: [Koha-bugs] [Bug 23181] Unable to use payment library in
 ACCOUNT_PAYMENT or ACCOUNT_WRITEOFF notices
In-Reply-To: <bug-23181-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23181-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23181-70-NJnAfUuo4o@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23181

Hayley Mapley <hayleymapley at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to oldstable         |Pushed to oldoldstable

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 13 01:40:21 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 13 Jan 2020 00:40:21 +0000
Subject: [Koha-bugs] [Bug 16784] Add table configuration on suggestions table
In-Reply-To: <bug-16784-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16784-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16784-70-aZJUYmlc0O@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16784

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Small patch
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 13 01:40:25 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 13 Jan 2020 00:40:25 +0000
Subject: [Koha-bugs] [Bug 16784] Add table configuration on suggestions table
In-Reply-To: <bug-16784-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16784-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16784-70-vsduuXZebq@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16784

--- Comment #5 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 97293
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97293&action=edit
Bug 16784: Add table configuration on suggestions table

This patch adds DataTables column configuration and export options to
the suggestions management tables in the staff interface.

The columns settings made via the administrative interface will affect
tables under each tab in the interface whether it be organized by
status, library, etc. However because of the way the KohaTable function
is currently written, changes made via the "Columns" button will only
affect the visible table.

To test, apply the patch and go to Acquisitions -> Suggestions.

 - Under each tab, the table of suggestions should have a DataTables
   toolbar with export and columns buttons. These controls should work
   correctly:
   - Showing and hiding columns should work as expected
   - Exports should work, excluding the first and last columns
 - Test the tables when using the various "Organize by" settings.
 - Test changing the settings in Administration -> Columns settings.
   - Verify that the changes you make to that configuration are
     reflected in the suggestions tables.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 13 02:09:38 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 13 Jan 2020 01:09:38 +0000
Subject: [Koha-bugs] [Bug 23970] itemsearch - publication date not taken
 into account if not used in the first field
In-Reply-To: <bug-23970-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23970-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23970-70-f7YROA8t9A@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23970

Hayley Mapley <hayleymapley at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|20.05.00, 19.11.01          |20.05.00, 19.11.01,
        released in|                            |18.11.13
             Status|Pushed to oldstable         |Pushed to oldoldstable

--- Comment #11 from Hayley Mapley <hayleymapley at catalyst.net.nz> ---
Backported to 18.11.x for 18.11.13

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 13 06:27:40 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 13 Jan 2020 05:27:40 +0000
Subject: [Koha-bugs] [Bug 15331] Sort order breaks at offset=1000 (both OPAC
 and Intranet)
In-Reply-To: <bug-15331-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15331-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15331-70-4w1xC4dtvc@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15331

--- Comment #8 from David Cook <dcook at prosentient.com.au> ---
(In reply to Katrin Fischer from comment #7)
> I fear the performance hit would be too big to justify a change to a high
> number by default. What we could do is document this option/behaviour
> better, so libraries can choose to take the hit.

I agree with Katrin. Koha is used by libraries big and small, so I think it's a
better idea to be more conservative by default. (That said, it would be
interesting if someone did some benchmarks on this one. Perhaps 1000 is an
arbitrary number. We don't have numbers on the actual performance degradation
at present I think.)

I am also curious about the scenarios where people are getting search results
higher than 1000. Back at university, as a student, I think librarians and
professors would've told us that our searches were too broad if we were
returning that many results. (That said, maybe you are doing a search for all
science fiction and want to search through the results alphabetically, as you
can't quite remember exactly what you're looking for. That seems reasonable
too.)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 13 06:34:08 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 13 Jan 2020 05:34:08 +0000
Subject: [Koha-bugs] [Bug 16140] Only clear L1 cache when needed
In-Reply-To: <bug-16140-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16140-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16140-70-Io92yiBBBG@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16140

--- Comment #35 from David Cook <dcook at prosentient.com.au> ---
(In reply to Jonathan Druart from comment #34)
> I do not think so, there are interesting ideas that could be reused.

Perhaps those should be spun off into their own specific bug reports? 

I just re-read the comments, and I don't think it's clear what's being
discussed here entirely?

I am interested in L1 cache issues, which I think is what brought me here, but
not sure what's the actual issue in this report? Maybe it just need to be
renamed?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 13 06:39:56 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 13 Jan 2020 05:39:56 +0000
Subject: [Koha-bugs] [Bug 24401] REST API: Check-in
In-Reply-To: <bug-24401-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24401-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24401-70-x1pf5URaHF@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24401

--- Comment #2 from David Cook <dcook at prosentient.com.au> ---
Would love to see work done on this one :).

Not really a priority for me, so I'm not planning to develop a solution, but
would be interested in testing it.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 13 06:40:58 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 13 Jan 2020 05:40:58 +0000
Subject: [Koha-bugs] [Bug 19060] Patrons should not get a max fines block
 auto-renewal notification for items due in the future.
In-Reply-To: <bug-19060-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19060-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19060-70-kqMm7CrZ8Y@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19060

David Cook <dcook at prosentient.com.au> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |dcook at prosentient.com.au

--- Comment #1 from David Cook <dcook at prosentient.com.au> ---
100% agreed and it is definitely related

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 13 07:01:12 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 13 Jan 2020 06:01:12 +0000
Subject: [Koha-bugs] [Bug 17464] Order deny,
 allow / Deny from all was deprecated in Apache 2.4 and is now a
 hard error
In-Reply-To: <bug-17464-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17464-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17464-70-WJEudUWZb8@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17464

--- Comment #3 from David Cook <dcook at prosentient.com.au> ---
Still a problem in 2020. I was just setting up Koha 19.11 from source and
etc/koha-httpd.conf is still set up for Apache 2.2.

(I may as well take a minute to write a patch for this now.)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 13 07:06:13 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 13 Jan 2020 06:06:13 +0000
Subject: [Koha-bugs] [Bug 17464] Order deny,
 allow / Deny from all was deprecated in Apache 2.4 and is now a
 hard error
In-Reply-To: <bug-17464-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17464-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17464-70-XwyMpfocoG@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17464

David Cook <dcook at prosentient.com.au> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|gmcharlt at gmail.com          |dcook at prosentient.com.au

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 13 07:11:23 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 13 Jan 2020 06:11:23 +0000
Subject: [Koha-bugs] [Bug 17464] Order deny,
 allow / Deny from all was deprecated in Apache 2.4 and is now a
 hard error
In-Reply-To: <bug-17464-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17464-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17464-70-6of2jSFg91@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17464

David Cook <dcook at prosentient.com.au> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Small patch
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 13 07:11:26 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 13 Jan 2020 06:11:26 +0000
Subject: [Koha-bugs] [Bug 17464] Order deny,
 allow / Deny from all was deprecated in Apache 2.4 and is now a
 hard error
In-Reply-To: <bug-17464-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17464-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17464-70-W6SM1CJeXO@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17464

--- Comment #4 from David Cook <dcook at prosentient.com.au> ---
Created attachment 97294
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97294&action=edit
Bug 17464: Order deny,allow / Deny from all was deprecated in Apache 2.4 and is
now a hard error

Patch change Apache access control from 2.2 to 2.4 directives.

Test plan:
0. Apply patch
1. Build Koha from source
2. Copy or symlink koha-dev/etc/koha-httpd.conf into your relevant
Apache directory.
3. Reload Apache
4. Note a lack of syntax errors regarding the "Order" directive

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 13 07:12:13 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 13 Jan 2020 06:12:13 +0000
Subject: [Koha-bugs] [Bug 17464] Order deny,
 allow / Deny from all was deprecated in Apache 2.4 and is now a
 hard error
In-Reply-To: <bug-17464-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17464-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17464-70-mfTunxD2Tg@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17464

--- Comment #5 from David Cook <dcook at prosentient.com.au> ---
Note that I'm only fixing the existing access control issue. I haven't added a
patch regarding potentially missing Directory directives.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 13 07:21:22 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 13 Jan 2020 06:21:22 +0000
Subject: [Koha-bugs] [Bug 18057] koha-restore should stop koha-indexer
 before deleting files
In-Reply-To: <bug-18057-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18057-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18057-70-2qg6whbxwO@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18057

--- Comment #3 from Rudolf Byker <rudolfbyker at gmail.com> ---
I think we need more info from the bug reporter.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 13 07:21:54 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 13 Jan 2020 06:21:54 +0000
Subject: [Koha-bugs] [Bug 14091] Allow to delete a cancelled order line
In-Reply-To: <bug-14091-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14091-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14091-70-ox2wJqLARc@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14091

Suzanne Fayle <sfayle at roseman.edu> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|sfayle at roseman.edu          |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 13 09:37:37 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 13 Jan 2020 08:37:37 +0000
Subject: [Koha-bugs] [Bug 24393] Remove event attributes from patron clubs
 list template
In-Reply-To: <bug-24393-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24393-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24393-70-E8MFZUEnMe@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24393

--- Comment #4 from David Nind <david at davidnind.com> ---
Thanks Katrin! Will keep an eye out and retest once it's resolved...

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 13 09:48:56 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 13 Jan 2020 08:48:56 +0000
Subject: [Koha-bugs] [Bug 24043] ILL module can't show requests from more
 than one backend
In-Reply-To: <bug-24043-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24043-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24043-70-8gU1aTsqsV@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24043

--- Comment #6 from Andrew Isherwood <andrew.isherwood at ptfs-europe.com> ---
I'm just taking a look at this now to ensure it's not a problem

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 13 10:01:21 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 13 Jan 2020 09:01:21 +0000
Subject: [Koha-bugs] [Bug 16784] Add table configuration on suggestions table
In-Reply-To: <bug-16784-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16784-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16784-70-Trn7BV524q@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16784

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 13 10:01:24 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 13 Jan 2020 09:01:24 +0000
Subject: [Koha-bugs] [Bug 16784] Add table configuration on suggestions table
In-Reply-To: <bug-16784-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16784-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16784-70-6FkENpKclm@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16784

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #97293|0                           |1
        is obsolete|                            |

--- Comment #6 from David Nind <david at davidnind.com> ---
Created attachment 97295
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97295&action=edit
Bug 16784: Add table configuration on suggestions table

This patch adds DataTables column configuration and export options to
the suggestions management tables in the staff interface.

The columns settings made via the administrative interface will affect
tables under each tab in the interface whether it be organized by
status, library, etc. However because of the way the KohaTable function
is currently written, changes made via the "Columns" button will only
affect the visible table.

To test, apply the patch and go to Acquisitions -> Suggestions.

 - Under each tab, the table of suggestions should have a DataTables
   toolbar with export and columns buttons. These controls should work
   correctly:
   - Showing and hiding columns should work as expected
   - Exports should work, excluding the first and last columns
 - Test the tables when using the various "Organize by" settings.
 - Test changing the settings in Administration -> Columns settings.
   - Verify that the changes you make to that configuration are
     reflected in the suggestions tables.

Signed-off-by: David Nind <david at davidnind.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 13 10:29:44 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 13 Jan 2020 09:29:44 +0000
Subject: [Koha-bugs] [Bug 24043] ILL module can't show requests from more
 than one backend
In-Reply-To: <bug-24043-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24043-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24043-70-urfdLVouz8@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24043

--- Comment #7 from Andrew Isherwood <andrew.isherwood at ptfs-europe.com> ---
This is a problem. It's a bug and I can't believe I've never come across it
before. It occurs when a request has a status that is unique to that request's
backend (so *not* something like "NEW") *and* the request's backend is not the
same as the backend used by the first request in the array. Looking at the code
I don't think it can ever have worked since it's fundamentally flawed.

I'll create a fix for master. Thanks for highlighting it Magnus!

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 13 11:05:46 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 13 Jan 2020 10:05:46 +0000
Subject: [Koha-bugs] [Bug 24350] Can't place holds
In-Reply-To: <bug-24350-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24350-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24350-70-e8SmduJ3BA@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24350

--- Comment #19 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Followups pushed, thanks Agustin :)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 13 11:16:46 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 13 Jan 2020 10:16:46 +0000
Subject: [Koha-bugs] [Bug 19618] Add 'Club Holds' feature
In-Reply-To: <bug-19618-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19618-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19618-70-C9DUXzr3HX@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19618

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org

--- Comment #26 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
-                    <form action="placerequest.pl" method="post" name="form"
id="hold-request-form">
+                    <form action="/api/v1/holds" method="post" name="form"
id="hold-request-form">


Was this change expected?

Either it was and we should remove placerequest.pl as it was the only
occurrence, or we should restore the call.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 13 11:22:30 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 13 Jan 2020 10:22:30 +0000
Subject: [Koha-bugs] [Bug 19618] Add 'Club Holds' feature
In-Reply-To: <bug-19618-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19618-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19618-70-G3SejYcfGm@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19618

--- Comment #27 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
At first glance I'd say there is a item_type (expected by
Koha::REST::V1::Holds) vs itemtype (sent by request.tt) issue
Also reserve_date vs hold_date

Either I am missing something or this patchset was not ready to be pushed.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 13 11:24:16 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 13 Jan 2020 10:24:16 +0000
Subject: [Koha-bugs] [Bug 16547] Can't place item level hold directly from
 search results screen
In-Reply-To: <bug-16547-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16547-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16547-70-iPHhcswNW0@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16547

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 13 11:24:19 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 13 Jan 2020 10:24:19 +0000
Subject: [Koha-bugs] [Bug 16547] Can't place item level hold directly from
 search results screen
In-Reply-To: <bug-16547-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16547-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16547-70-VCf0GViKDU@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16547

--- Comment #4 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 97296
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97296&action=edit
Bug 16547: Do not display "multi holds" view if only one is selected

If a hold is selected from the result list, we should let the ability to
select an item-level hold.

Test plan:
I. Detail page
1/ Go to a bibliographic record detail page
2/ Click "Place hold"
3/ Select a patron
=> No change expected, you can select an item

II. Search result, multiple holds
1/ Search for an item with more than one search result
2/ Select several items, click 'Place hold'
3/ Enter a patron card number
=> No change expected, item level holds are not available.

III. Search result, single hold
1/ Search for an item with more than one search result
2/ Select only one item, click 'Place hold'
3/ Enter a patron card number
=> With this patch applied, item level hold is available. The screen is the
same
as when you place a hold from the bibliographic record detail page
=> Without this patch you cannot place an item-level hold

QA notes: We could go a bit further and remove the 2 biblionumbers and
biblionumber from hold script, as well as remove the checkMultiHold in
request.tt. We should not have a biblionumbers param that contain a list
of biblionumber separated by '/' but several biblionumber parameters
instead.

QA notes 2: About placerequest.pl, see bug 19618 comment 27.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 13 11:25:06 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 13 Jan 2020 10:25:06 +0000
Subject: [Koha-bugs] [Bug 24043] ILL module can't show requests from more
 than one backend
In-Reply-To: <bug-24043-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24043-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24043-70-lRGWyRKTWf@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24043

Andrew Isherwood <andrew.isherwood at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 13 11:25:09 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 13 Jan 2020 10:25:09 +0000
Subject: [Koha-bugs] [Bug 24043] ILL module can't show requests from more
 than one backend
In-Reply-To: <bug-24043-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24043-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24043-70-7MvijUmFSL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24043

--- Comment #8 from Andrew Isherwood <andrew.isherwood at ptfs-europe.com> ---
Created attachment 97297
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97297&action=edit
Bug 24043: Fix retrieval of of status name

This patch modifies the way in which a request's status name is
retrieved. I think the previous way it was done (which can never have
worked properly) must have come from a time when we weren't embedding
the request's backend capabilities in each request. So now we can just use
the current row.

Test plan:

1. *Before applying the patch*:
2. Ensure you have at least two requests, from two different backends.
One of the backends you are using must have a possible status that
doesn't exist in the other. For example, the BLDSS backend has a status
of STAT, that doesn't not exist in any other backends.
3. Ensure that the request who's backend has the unique status is *not*
the first request in the returned list.
4. Load the "View ILL requests" page
5. Observe that the page JS fails with a "Cannot read property 'name' of
undefined" error
6. Apply the patch
7. Reload the page (maybe doing a hard reload to ensure the JS is not
cached)
8. TEST: Observe that the error no longer occurs and the requests all
have their statuses displayed correctly.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 13 11:26:39 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 13 Jan 2020 10:26:39 +0000
Subject: [Koha-bugs] [Bug 24043] ILL module can't show requests from more
 than one backend
In-Reply-To: <bug-24043-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24043-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24043-70-2PA9bTnEtd@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24043

Andrew Isherwood <andrew.isherwood at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Version|18.11                       |master

--- Comment #9 from Andrew Isherwood <andrew.isherwood at ptfs-europe.com> ---
Note: Despite this bug being originally reported on 18.11, it exists in master,
this patch was created on master

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 13 11:39:18 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 13 Jan 2020 10:39:18 +0000
Subject: [Koha-bugs] [Bug 24369] Add ability to set CORS header in Koha
In-Reply-To: <bug-24369-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24369-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24369-70-EEkQ245cBi@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24369

Andrew Isherwood <andrew.isherwood at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 13 11:39:21 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 13 Jan 2020 10:39:21 +0000
Subject: [Koha-bugs] [Bug 24369] Add ability to set CORS header in Koha
In-Reply-To: <bug-24369-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24369-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24369-70-IIRc3S8w2t@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24369

Andrew Isherwood <andrew.isherwood at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #97092|0                           |1
        is obsolete|                            |

--- Comment #5 from Andrew Isherwood <andrew.isherwood at ptfs-europe.com> ---
Created attachment 97298
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97298&action=edit
Bug 24369: Add AccessControlAllowOrigin syspref

Signed-off-by: Andrew Isherwood <andrew.isherwood at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 13 11:39:23 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 13 Jan 2020 10:39:23 +0000
Subject: [Koha-bugs] [Bug 24369] Add ability to set CORS header in Koha
In-Reply-To: <bug-24369-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24369-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24369-70-w4Bg69t9bS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24369

Andrew Isherwood <andrew.isherwood at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #97093|0                           |1
        is obsolete|                            |

--- Comment #6 from Andrew Isherwood <andrew.isherwood at ptfs-europe.com> ---
Created attachment 97299
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97299&action=edit
Bug 24369: Add CORS support to output_with_http_headers()

This patch adds CORS support to output_with_headers(). It will use the
AccessControlAllowOrigin syspref to pick the value and set the
Access-Control-Allow-Origin header.

To test:
1. Apply this patch
2. Run:
   $ kshell
  k$ prove t/Output.t
SUCCESS: Tests pass!
3. Sign off :-D

Signed-off-by: Andrew Isherwood <andrew.isherwood at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 13 11:39:27 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 13 Jan 2020 10:39:27 +0000
Subject: [Koha-bugs] [Bug 24369] Add ability to set CORS header in Koha
In-Reply-To: <bug-24369-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24369-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24369-70-d5nycizmwG@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24369

Andrew Isherwood <andrew.isherwood at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #97094|0                           |1
        is obsolete|                            |

--- Comment #7 from Andrew Isherwood <andrew.isherwood at ptfs-europe.com> ---
Created attachment 97300
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97300&action=edit
Bug 24369: Add CORS support to the API

This patch adds CORS support for API requests. It uses the
AccessControlAllowOrigin syspref. To test:

1. Apply this patch
2. Run:
   $ kshell
  k$ prove t/db_dependent/api/v1/auth.t
=> SUCCESS: Tests pass!
3. Set the AccessControlAllowOrigin to any string (for example, *)
4. Use any API testing tool (Postman?) to place a request on the API
=> SUCCESS: The response headers include Access-Control-Allow-Origin,
    containing what you set on the syspref
5. Sign off :-D

Signed-off-by: Andrew Isherwood <andrew.isherwood at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 13 12:07:29 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 13 Jan 2020 11:07:29 +0000
Subject: [Koha-bugs] [Bug 23031] Improve UX of buttons on order search page
In-Reply-To: <bug-23031-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23031-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23031-70-PwQ3kGdnai@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23031

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 13 12:07:32 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 13 Jan 2020 11:07:32 +0000
Subject: [Koha-bugs] [Bug 23031] Improve UX of buttons on order search page
In-Reply-To: <bug-23031-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23031-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23031-70-6nP8dbldf4@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23031

--- Comment #3 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 97301
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97301&action=edit
Bug 23031: Make 'add to basket' accessible in one click (fix regression)

Since bug 21364 we have 'view' then 'add to basket' that is accessible
in 2 clicks. We should have it directly accessible.

Test plan:
Create a new basket
Add a new order to the basket (note that the link is directly
accessible)
When a new order is added you can close the basket from the basket list
view
Note that the dropdown button displays correctly

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 13 12:07:40 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 13 Jan 2020 11:07:40 +0000
Subject: [Koha-bugs] [Bug 23031] Improve UX of buttons on order search page
In-Reply-To: <bug-23031-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23031-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23031-70-JxmsJ3PLQl@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23031

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |jonathan.druart at bugs.koha-c
                   |ity.org                     |ommunity.org
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 13 12:16:52 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 13 Jan 2020 11:16:52 +0000
Subject: [Koha-bugs] [Bug 24305] Batch Item modification via item number in
 reports does not work with CONCAT in report
In-Reply-To: <bug-24305-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24305-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24305-70-tliZUbkNpi@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24305

--- Comment #3 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Thanks for testing Holly. This patch should fixes the issue you reported!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 13 12:18:47 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 13 Jan 2020 11:18:47 +0000
Subject: [Koha-bugs] [Bug 24363] Datepicker calendar is not sexy on
 additem.pl
In-Reply-To: <bug-24363-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24363-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24363-70-RaqHz6dxIE@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24363

--- Comment #6 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
On the hold list view: https://snipboard.io/iLdfAg.jpg

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 13 12:22:00 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 13 Jan 2020 11:22:00 +0000
Subject: [Koha-bugs] [Bug 24305] Batch Item modification via item number in
 reports does not work with CONCAT in report
In-Reply-To: <bug-24305-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24305-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24305-70-tydVJucs7f@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24305

--- Comment #4 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 97302
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97302&action=edit
Bug 24305: Remove previous declaration of batch_biblionumbers

We should not init batch_biblionumbers before.
Also this patch deals with batch_cardnumbers.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 13 12:28:39 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 13 Jan 2020 11:28:39 +0000
Subject: [Koha-bugs] [Bug 24363] Datepicker calendar is not sexy on
 additem.pl
In-Reply-To: <bug-24363-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24363-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24363-70-zC617TL0Xo@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24363

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de

--- Comment #7 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
I was encountering quite a bit of broken displays yesterday - feel we might
need to revert this for hte moment.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 13 12:37:34 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 13 Jan 2020 11:37:34 +0000
Subject: [Koha-bugs] [Bug 17628] Move bibliographic related code to
 Koha::Biblio
In-Reply-To: <bug-17628-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17628-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17628-70-OdsFIx8FR1@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17628

--- Comment #12 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
(In reply to Katrin Fischer from comment #11)
> All depending bugs have been closed by now, can we close this as well?

Same as previous comment, a lot is still missing.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 13 12:38:14 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 13 Jan 2020 11:38:14 +0000
Subject: [Koha-bugs] [Bug 17611] Searching for orders uses misleading column
 name "Pending order"
In-Reply-To: <bug-17611-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17611-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17611-70-fsmiQ7zhlI@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17611

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|enhancement                 |trivial

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 13 12:41:25 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 13 Jan 2020 11:41:25 +0000
Subject: [Koha-bugs] [Bug 16413] Prototype for GetLatestAutoRenewDate and
 GetSoonestRenewDate should be changed
In-Reply-To: <bug-16413-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16413-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16413-70-EWDptsGsn7@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16413

--- Comment #18 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
I will take care of this when it will be possible, when svc/checkouts
and opac-user.pl will use Koha::Checkout objects.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 13 12:42:25 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 13 Jan 2020 11:42:25 +0000
Subject: [Koha-bugs] [Bug 19382] Add ability to block guarantees based on
 fees owed by guarantor and other guarantees
In-Reply-To: <bug-19382-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19382-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19382-70-gXBw3je8cO@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19382

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 13 12:42:28 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 13 Jan 2020 11:42:28 +0000
Subject: [Koha-bugs] [Bug 19382] Add ability to block guarantees based on
 fees owed by guarantor and other guarantees
In-Reply-To: <bug-19382-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19382-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19382-70-5F7AZDu0BG@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19382

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #97235|0                           |1
        is obsolete|                            |

--- Comment #4 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 97303
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97303&action=edit
Bug 19382: Add ability to block guarantees based on fees owed by guarantor and
other guarantees

Some libraries would like to not only block the circulation of a guarantor
based on fines owed by guarantees, but would also like to block circulation for
all guarantees as well. Basically, if a family as a whole reaches a certain
threshold of fines, the entire family will be blocked from checking out items.

Test Plan:
1) Apply this patch
2) Set NoIssuesChargeGuarantorsWithGuarantees to $14
3) Create a family of four ( 2 guarantors, 2 guarantees ) where the parents
guarantee both children
4) Give 3 of the 4 a $5 fine
5) None of them should be able to check out items

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 13 12:43:55 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 13 Jan 2020 11:43:55 +0000
Subject: [Koha-bugs] [Bug 24350] Can't place holds
In-Reply-To: <bug-24350-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24350-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24350-70-yTOZFLAUxF@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24350

--- Comment #20 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Tests are failing:

t/db_dependent/Koha/Libraries.t .. 4/9             # Looks like you planned 11
tests but ran 2.

        #   Failed test 'Given BranchTransferLimitsType = itemtype and
item-level_itypes = ON'
        #   at t/db_dependent/Koha/Libraries.t line 258.
        # Looks like you planned 4 tests but ran 2.
        # Looks like you failed 1 test of 2 run.

    #   Failed test 'UseBranchTransferLimits = ON'
    #   at t/db_dependent/Koha/Libraries.t line 422.
    # Looks like you failed 1 test of 2.

#   Failed test 'pickup_locations'
#   at t/db_dependent/Koha/Libraries.t line 423.
Can't call method "branchcode" on unblessed reference at
t/db_dependent/Koha/Libraries.t line 195.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 13 12:47:11 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 13 Jan 2020 11:47:11 +0000
Subject: [Koha-bugs] [Bug 14491] Noisy warns at reserve/request.pl
In-Reply-To: <bug-14491-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14491-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14491-70-mmzGuz6KzH@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14491

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org
           Severity|enhancement                 |minor

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 13 12:50:08 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 13 Jan 2020 11:50:08 +0000
Subject: [Koha-bugs] [Bug 18293] REST API tests. fix dateformat change
 regression in tests
In-Reply-To: <bug-18293-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18293-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18293-70-4cuwEhhqlW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18293

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |DUPLICATE

--- Comment #3 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
When we introduced Koha::Object(s)::TO_JSON, Lari added date handling there as
well, on bug 18330. So I think this is a solved.

*** This bug has been marked as a duplicate of bug 18330 ***

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 13 12:50:08 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 13 Jan 2020 11:50:08 +0000
Subject: [Koha-bugs] [Bug 18330] REST API: Date-time handling
In-Reply-To: <bug-18330-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18330-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18330-70-dSSi8OM88M@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18330

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |olli-antti.kivilahti at jns.fi

--- Comment #18 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
*** Bug 18293 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 13 12:56:56 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 13 Jan 2020 11:56:56 +0000
Subject: [Koha-bugs] [Bug 24363] Datepicker calendar is not sexy on
 additem.pl
In-Reply-To: <bug-24363-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24363-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24363-70-iSmT3Iv1iE@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24363

--- Comment #8 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
(In reply to Katrin Fischer from comment #7)
> I was encountering quite a bit of broken displays yesterday - feel we might
> need to revert this for hte moment.

I do not think we should revert it, it only impacts master. Also the fix should
be quite small (fix all issues with a few CSS lines).
Just need to find the correct fix :)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 13 12:58:05 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 13 Jan 2020 11:58:05 +0000
Subject: [Koha-bugs] [Bug 24146] Paying Accruing Fines prior to return
 causes another accruing fine when returned
In-Reply-To: <bug-24146-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24146-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24146-70-W3ZBb1TgMu@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24146

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 13 12:58:09 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 13 Jan 2020 11:58:09 +0000
Subject: [Koha-bugs] [Bug 24146] Paying Accruing Fines prior to return
 causes another accruing fine when returned
In-Reply-To: <bug-24146-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24146-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24146-70-7g2x5Rmtyl@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24146

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #96069|0                           |1
        is obsolete|                            |

--- Comment #17 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 97304
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97304&action=edit
Bug 24146: Add test cases

This patch adds test cases for both checking amountoutstanding values
are handled correctly and also that the paid down accruing fines do not
add additional fines on increment.

Test plan:
Read the changeset and asses whether the changes/additional tests are
correct as per the expected behaviour.

Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 13 12:58:12 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 13 Jan 2020 11:58:12 +0000
Subject: [Koha-bugs] [Bug 24146] Paying Accruing Fines prior to return
 causes another accruing fine when returned
In-Reply-To: <bug-24146-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24146-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24146-70-dT2A2dA7iJ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24146

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #96070|0                           |1
        is obsolete|                            |

--- Comment #18 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 97305
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97305&action=edit
Bug 24146: Increment existing fine

We should increment an existing fine even if it has been fully paid off
whilst it is still incrementing and not create a new fine.

Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 13 12:58:16 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 13 Jan 2020 11:58:16 +0000
Subject: [Koha-bugs] [Bug 24146] Paying Accruing Fines prior to return
 causes another accruing fine when returned
In-Reply-To: <bug-24146-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24146-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24146-70-yWQQ8irtcR@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24146

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #96071|0                           |1
        is obsolete|                            |

--- Comment #19 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 97306
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97306&action=edit
Bug 24146: Corrections to UpdateFine logic concerning maxFine

The `maxFine` system preference actually refers to the amount of
outsanding debt (in fines) a patron may have at a given time. This patch
corrects the functionality of UpdateFine such that it properly respects
that counter given the payment of accruing fines scenario.

Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 13 12:58:20 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 13 Jan 2020 11:58:20 +0000
Subject: [Koha-bugs] [Bug 24146] Paying Accruing Fines prior to return
 causes another accruing fine when returned
In-Reply-To: <bug-24146-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24146-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24146-70-1nBf4JuVgT@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24146

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #96072|0                           |1
        is obsolete|                            |

--- Comment #20 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 97307
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97307&action=edit
Bug 24146: Illustrate increasing and decreasing fine

Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 13 13:02:26 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 13 Jan 2020 12:02:26 +0000
Subject: [Koha-bugs] [Bug 19618] Add 'Club Holds' feature
In-Reply-To: <bug-19618-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19618-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19618-70-y3cw3GwUy1@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19618

--- Comment #28 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
(In reply to Jonathan Druart from comment #27)
> At first glance I'd say there is a item_type (expected by
> Koha::REST::V1::Holds) vs itemtype (sent by request.tt) issue
> Also reserve_date vs hold_date
> 
> Either I am missing something or this patchset was not ready to be pushed.

Can you file a bug for that?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 13 13:07:30 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 13 Jan 2020 12:07:30 +0000
Subject: [Koha-bugs] [Bug 19618] Add 'Club Holds' feature
In-Reply-To: <bug-19618-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19618-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19618-70-eZ73icdyOo@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19618

--- Comment #29 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
(In reply to Tomás Cohen Arazi from comment #28)
> (In reply to Jonathan Druart from comment #27)
> > At first glance I'd say there is a item_type (expected by
> > Koha::REST::V1::Holds) vs itemtype (sent by request.tt) issue
> > Also reserve_date vs hold_date
> > 
> > Either I am missing something or this patchset was not ready to be pushed.
> 
> Can you file a bug for that?

We need to restore the call to placerequest.pl

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 13 13:19:44 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 13 Jan 2020 12:19:44 +0000
Subject: [Koha-bugs] [Bug 17355] Authorised value categories cannot be
 deleted
In-Reply-To: <bug-17355-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17355-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17355-70-NATIqZgASt@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17355

Sally <sally.healey at cheshiresharedservices.gov.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |sally.healey at cheshireshared
                   |                            |services.gov.uk

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 13 13:23:08 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 13 Jan 2020 12:23:08 +0000
Subject: [Koha-bugs] [Bug 24407] New: AuthDisplayHierarchies ignores new
 nodes and needs protection against cyclic relations
Message-ID: <bug-24407-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24407

            Bug ID: 24407
           Summary: AuthDisplayHierarchies ignores new nodes and needs
                    protection against cyclic relations
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: MARC Authority data support
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: m.de.rooy at rijksmuseum.nl
        QA Contact: testopia at bugs.koha-community.org

Suppose I have term A with children B and C where the children have a 550 tag
with broader indication to A.
If I go to record A, the tree is built showing B and C.
If I add a child D to A, the tree for A is not rebuilt but still showing the
old situation.

A related problem:
If I change term A setting it to a be child of B with a 550 (which it obviously
not is), this cyclic relation will trigger deep recursion. Resulting in a
gateway timeout and a process eating up resources..

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 13 13:23:54 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 13 Jan 2020 12:23:54 +0000
Subject: [Koha-bugs] [Bug 24407] AuthDisplayHierarchies ignores new nodes
 and needs protection against cyclic relations
In-Reply-To: <bug-24407-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24407-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24407-70-gWbaU4hNIm@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24407

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de

--- Comment #1 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Katrin,
If I am not mistaken, you are using it? Could you comment on this?

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 13 13:30:08 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 13 Jan 2020 12:30:08 +0000
Subject: [Koha-bugs] [Bug 24408] New: Comparing floats in tests should not
 care about precision
Message-ID: <bug-24408-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24408

            Bug ID: 24408
           Summary: Comparing floats in tests should not care about
                    precision
 Change sponsored?: ---
           Product: Koha
           Version: unspecified
          Hardware: All
                OS: All
            Status: ASSIGNED
          Severity: normal
          Priority: P5 - low
         Component: Test Suite
          Assignee: jonathan.druart at bugs.koha-community.org
          Reporter: jonathan.druart at bugs.koha-community.org
        QA Contact: testopia at bugs.koha-community.org

We should not compare floating precision in tests.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 13 13:30:15 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 13 Jan 2020 12:30:15 +0000
Subject: [Koha-bugs] [Bug 24408] Comparing floats in tests should not care
 about precision
In-Reply-To: <bug-24408-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24408-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24408-70-MwGz3sK1eV@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24408

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |24146


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24146
[Bug 24146] Paying Accruing Fines prior to return causes another accruing fine
when returned
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 13 13:30:15 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 13 Jan 2020 12:30:15 +0000
Subject: [Koha-bugs] [Bug 24146] Paying Accruing Fines prior to return
 causes another accruing fine when returned
In-Reply-To: <bug-24146-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24146-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24146-70-m0YmrZucJ2@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24146

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |24408


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24408
[Bug 24408] Comparing floats in tests should not care about precision
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 13 13:31:10 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 13 Jan 2020 12:31:10 +0000
Subject: [Koha-bugs] [Bug 24408] Comparing floats in tests should not care
 about precision
In-Reply-To: <bug-24408-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24408-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24408-70-PXxxZkiVrd@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24408

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 13 13:31:13 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 13 Jan 2020 12:31:13 +0000
Subject: [Koha-bugs] [Bug 24408] Comparing floats in tests should not care
 about precision
In-Reply-To: <bug-24408-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24408-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24408-70-0CQVbBKj7P@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24408

--- Comment #1 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 97308
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97308&action=edit
Bug 24408: Do not compare floats with precision in tests

We should not compare floating precision in tests.

Test plan:
Confirm that the tests still pass after this patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 13 13:35:44 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 13 Jan 2020 12:35:44 +0000
Subject: [Koha-bugs] [Bug 24408] Comparing floats in tests should not care
 about precision
In-Reply-To: <bug-24408-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24408-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24408-70-dhYLrMXEp1@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24408

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #97308|0                           |1
        is obsolete|                            |

--- Comment #2 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 97309
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97309&action=edit
Bug 24408: Do not compare floats with precision in tests

We should not compare floating precision in tests.

Test plan:
Confirm that the tests still pass after this patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 13 13:42:41 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 13 Jan 2020 12:42:41 +0000
Subject: [Koha-bugs] [Bug 24408] Comparing floats in tests should not care
 about precision
In-Reply-To: <bug-24408-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24408-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24408-70-dvB55X9Wwj@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24408

--- Comment #3 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
PR for QA script:
https://gitlab.com/koha-community/qa-test-tools/commits/issue_21
Will be merged if this bugfix is accepted.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 13 13:46:11 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 13 Jan 2020 12:46:11 +0000
Subject: [Koha-bugs] [Bug 20567] "Holds per record (count)" limit is not
 enforced after item is captured for hold
In-Reply-To: <bug-20567-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20567-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20567-70-AhvhxEXEl5@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20567

Hans Pålsson <hans.palsson at hkr.se> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |hans.palsson at hkr.se

--- Comment #3 from Hans Pålsson <hans.palsson at hkr.se> ---
(In reply to Jonathan Druart from comment #2)
> It seems that it is the expected behavior.
> 
> C4/Circulation.pm, in CanItemBeReserved:
>  394             found          => undef, # Found holds don't count against
> a patron's holds limit
> 
> Should not it be?

No, a patron should only be allowed 1 hold per biblio, also after that hold is
filled. It translates to patrons should not be able to place holds on biblios
for which they have checked out items or already placed a hold. The current
behaviour becomes a loophole.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 13 13:50:18 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 13 Jan 2020 12:50:18 +0000
Subject: [Koha-bugs] [Bug 19618] Add 'Club Holds' feature
In-Reply-To: <bug-19618-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19618-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19618-70-ah7m5NxQD8@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19618

--- Comment #30 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
I still do not manage to find regression, and found:

1043                 if($('.datepickerfrom_hidden').length)
1044                     data.hold_date =
$('.datepickerfrom_hidden').val()||null;
1045                 if($('input[name="itemtype"]').length) {
1046                     data.item_type =
$('input[name="itemtype"]').val()||null;
1047                 }

Are we safe?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 13 13:56:55 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 13 Jan 2020 12:56:55 +0000
Subject: [Koha-bugs] [Bug 24409] New: admin/authorised_values.pl?op=add_form
 : Add New Category is vulnerable for CSRF attacks
Message-ID: <bug-24409-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24409

            Bug ID: 24409
           Summary: admin/authorised_values.pl?op=add_form : Add New
                    Category is vulnerable for CSRF attacks
 Change sponsored?: ---
           Product: Koha
           Version: 19.11
          Hardware: All
                OS: Linux
            Status: NEW
          Severity: major
          Priority: P5 - low
         Component: System Administration
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: aman.mishra77 at gmail.com
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 13 13:59:25 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 13 Jan 2020 12:59:25 +0000
Subject: [Koha-bugs] [Bug 24409] admin/authorised_values.pl?op=add_form :
 Add New Category is vulnerable for CSRF attacks
In-Reply-To: <bug-24409-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24409-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24409-70-rzMKQ1IZIT@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24409

--- Comment #1 from Aman Mishra <aman.mishra77 at gmail.com> ---
When we use this script it is allow to create new category
<html> 
<body> 
<script>history.pushState('', '', '/')</script> 
<form
action="http://library-staff.totalit.com/cgi-bin/koha/admin/authorised_values.pl"
method="POST">
<input type="hidden" name="category" value="AMAN8" />
<input type="hidden" name="op" value="add_category" />
<input type="hidden" name="id" value="" />
<input type="submit" value="Submit request" />
</form>
</body>
</html>

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 13 14:00:26 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 13 Jan 2020 13:00:26 +0000
Subject: [Koha-bugs] [Bug 16413] Prototype for GetLatestAutoRenewDate and
 GetSoonestRenewDate should be changed
In-Reply-To: <bug-16413-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16413-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16413-70-jK0cgMWhLw@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16413

--- Comment #19 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
(In reply to Jonathan Druart from comment #18)
> I will take care of this when it will be possible, when svc/checkouts
> and opac-user.pl will use Koha::Checkout objects.

That's what I was thinking - because we will probably kill those off anyway :)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 13 14:12:53 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 13 Jan 2020 13:12:53 +0000
Subject: [Koha-bugs] [Bug 24409] admin/authorised_values.pl?op=add_form :
 Add New Category is vulnerable for CSRF attacks
In-Reply-To: <bug-24409-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24409-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24409-70-oqSJ9lTakF@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24409

--- Comment #2 from Aman Mishra <aman.mishra77 at gmail.com> ---
I resolved this please chek and update this is right way or not?


Add CSRF token in /usr/share/koha/intranet/cgi-bin/admin/authorised_values.pl
+ after line 32
  +use Koha::Token;

+ after line 172
  +my $TokenCheck =  Koha::Token->new->check_csrf({
            session_id => scalar $input->cookie('CGISESSID'),
            token  => scalar $input->param('csrf_token'),
        });

+ after line 180
  +if( $TokenCheck ){

+ after line 204
  +    }
    else {
        push @messages, {type => 'error', code => 'wrong_csrf_token' };
    }

+ after line 81
  +    $template->param(
        csrf_token => Koha::Token->new->generate_csrf({
            session_id => scalar $input->cookie('CGISESSID'),
        }),
    );


Add CSRF in
/usr/share/koha/intranet/htdocs/intranet-tmpl/prog/en/modules/admin/authorised_values.tt

+ after line 63
  +<input type="hidden" name="csrf_token" value="[% csrf_token | html %]" />

+ after line 184
  + [% CASE 'wrong_csrf_token' %]
        <div class="dialog message">The form submission failed (Wrong CSRF
token). Try to come back, refresh the page, then try again.</div>    



Now test your application.

Thanks
Aman Mishra
Sr. Software Engineer 
Total IT Software Solutions Pvt. Ltd.
India

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 13 14:14:06 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 13 Jan 2020 13:14:06 +0000
Subject: [Koha-bugs] [Bug 24409] admin/authorised_values.pl?op=add_form :
 Add New Category is vulnerable for CSRF attacks
In-Reply-To: <bug-24409-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24409-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24409-70-idNcrqOlBm@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24409

Aman Mishra <aman.mishra77 at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |aman.mishra77 at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 13 14:14:52 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 13 Jan 2020 13:14:52 +0000
Subject: [Koha-bugs] [Bug 19618] Add 'Club Holds' feature
In-Reply-To: <bug-19618-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19618-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19618-70-Oyler8PRWh@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19618

--- Comment #31 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
(In reply to Jonathan Druart from comment #30)
> I still do not manage to find regression, and found:
> 
> 1043                 if($('.datepickerfrom_hidden').length)
> 1044                     data.hold_date =
> $('.datepickerfrom_hidden').val()||null;
> 1045                 if($('input[name="itemtype"]').length) {
> 1046                     data.item_type =
> $('input[name="itemtype"]').val()||null;
> 1047                 }
> 
> Are we safe?

My only concern is not about attribute mappings, but on the multi_hold use
case.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 13 14:15:42 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 13 Jan 2020 13:15:42 +0000
Subject: [Koha-bugs] [Bug 24407] AuthDisplayHierarchies ignores new nodes
 and needs protection against cyclic relations
In-Reply-To: <bug-24407-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24407-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24407-70-pRATBZSdwS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24407

--- Comment #2 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
(In reply to Marcel de Rooy from comment #1)
> Katrin,
> If I am not mistaken, you are using it? Could you comment on this?

Sadly not at the moment, see major bug 23190 - I can't get it to work at the
moment.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 13 14:24:05 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 13 Jan 2020 13:24:05 +0000
Subject: [Koha-bugs] [Bug 24408] Comparing floats in tests should not care
 about precision
In-Reply-To: <bug-24408-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24408-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24408-70-J3E4iBfyQ6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24408

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         QA Contact|testopia at bugs.koha-communit |martin.renvoize at ptfs-europe
                   |y.org                       |.com
                 CC|                            |martin.renvoize at ptfs-europe
                   |                            |.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 13 14:29:30 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 13 Jan 2020 13:29:30 +0000
Subject: [Koha-bugs] [Bug 24410] New: Multi holds broken
Message-ID: <bug-24410-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24410

            Bug ID: 24410
           Summary: Multi holds broken
 Change sponsored?: ---
           Product: Koha
           Version: unspecified
          Hardware: All
                OS: All
            Status: ASSIGNED
          Severity: major
          Priority: P5 - low
         Component: Hold requests
          Assignee: jonathan.druart at bugs.koha-community.org
          Reporter: jonathan.druart at bugs.koha-community.org
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com
        Depends on: 19618

Bug 19618 replaces the call to placerequest.pl with a REST API /holds
That is wrong as it does not support multi holds.


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19618
[Bug 19618] Add 'Club Holds' feature
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 13 14:29:30 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 13 Jan 2020 13:29:30 +0000
Subject: [Koha-bugs] [Bug 19618] Add 'Club Holds' feature
In-Reply-To: <bug-19618-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19618-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19618-70-rpUuZ15vyf@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19618

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |24410


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24410
[Bug 24410] Multi holds broken
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 13 14:31:37 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 13 Jan 2020 13:31:37 +0000
Subject: [Koha-bugs] [Bug 24410] Multi holds broken
In-Reply-To: <bug-24410-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24410-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24410-70-QcQF5X8Pdh@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24410

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 13 14:31:40 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 13 Jan 2020 13:31:40 +0000
Subject: [Koha-bugs] [Bug 24410] Multi holds broken
In-Reply-To: <bug-24410-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24410-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24410-70-aPy3eV6m9j@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24410

--- Comment #1 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 97310
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97310&action=edit
Bug 24410: Fix multi holds

Bug 19618 replaces the call to placerequest.pl with a REST API /holds
That is wrong as it does not support multi holds.

Test plan:
Confirm that prior to this patch you are not able to place a hold on
several records at once, and that this patch fixes it

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 13 14:36:40 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 13 Jan 2020 13:36:40 +0000
Subject: [Koha-bugs] [Bug 19618] Add 'Club Holds' feature
In-Reply-To: <bug-19618-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19618-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19618-70-l4ODd2So9s@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19618

--- Comment #32 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
See bug 24410.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 13 14:41:06 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 13 Jan 2020 13:41:06 +0000
Subject: [Koha-bugs] [Bug 24146] Paying Accruing Fines prior to return
 causes another accruing fine when returned
In-Reply-To: <bug-24146-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24146-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24146-70-96n283Meys@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24146

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to master
         Version(s)|                            |20.05.00
        released in|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 13 14:41:08 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 13 Jan 2020 13:41:08 +0000
Subject: [Koha-bugs] [Bug 24146] Paying Accruing Fines prior to return
 causes another accruing fine when returned
In-Reply-To: <bug-24146-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24146-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24146-70-gg4gs6Zhe9@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24146

--- Comment #21 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Nice work everyone!

Pushed to master for 20.05

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 13 14:43:46 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 13 Jan 2020 13:43:46 +0000
Subject: [Koha-bugs] [Bug 24408] Comparing floats in tests should not care
 about precision
In-Reply-To: <bug-24408-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24408-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24408-70-mzBWgE4eSI@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24408

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 13 14:44:13 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 13 Jan 2020 13:44:13 +0000
Subject: [Koha-bugs] [Bug 24408] Comparing floats in tests should not care
 about precision
In-Reply-To: <bug-24408-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24408-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24408-70-b0oHKjPATx@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24408

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

--- Comment #4 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Fast passing QA.. a sensible fix and discussed with Jonathan.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 13 14:44:58 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 13 Jan 2020 13:44:58 +0000
Subject: [Koha-bugs] [Bug 24408] Comparing floats in tests should not care
 about precision
In-Reply-To: <bug-24408-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24408-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24408-70-hDpONVIkxE@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24408

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|                            |20.05.00
        released in|                            |
             Status|Passed QA                   |Pushed to master

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 13 14:45:00 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 13 Jan 2020 13:45:00 +0000
Subject: [Koha-bugs] [Bug 24408] Comparing floats in tests should not care
 about precision
In-Reply-To: <bug-24408-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24408-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24408-70-n3XtAurY24@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24408

--- Comment #5 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Nice work everyone!

Pushed to master for 20.05

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 13 14:46:39 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 13 Jan 2020 13:46:39 +0000
Subject: [Koha-bugs] [Bug 14787] Allow confirm/continue option to circ
 warnings at checkout (i.e. OverduesBlockCheckout)
In-Reply-To: <bug-14787-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14787-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14787-70-tyG8j4Xago@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14787

Marjorie Barry-Vila <marjorie.barry-vila at collecto.ca> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |marjorie.barry-vila at collect
                   |                            |o.ca

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 13 14:47:03 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 13 Jan 2020 13:47:03 +0000
Subject: [Koha-bugs] [Bug 21466] Data inconsistencies - koha fields linked
 to AV cat values must have a corresponding authorised value
In-Reply-To: <bug-21466-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21466-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21466-70-CY1SRckOv3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21466

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|enhancement                 |normal

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 13 14:56:02 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 13 Jan 2020 13:56:02 +0000
Subject: [Koha-bugs] [Bug 21466] Data inconsistencies - koha fields linked
 to AV cat values must have a corresponding authorised value
In-Reply-To: <bug-21466-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21466-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21466-70-VhkiYz04rX@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21466

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

--- Comment #10 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
This has languished long enough.. Passing QA.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 13 14:58:47 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 13 Jan 2020 13:58:47 +0000
Subject: [Koha-bugs] [Bug 18355] Add 'permanent location' alongside
 'shelving location' when located on cart
In-Reply-To: <bug-18355-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18355-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18355-70-r6s4NIYTSW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18355

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|                            |20.05.00
        released in|                            |
             Status|Passed QA                   |Pushed to master

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 13 14:58:49 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 13 Jan 2020 13:58:49 +0000
Subject: [Koha-bugs] [Bug 18355] Add 'permanent location' alongside
 'shelving location' when located on cart
In-Reply-To: <bug-18355-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18355-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18355-70-Qtz6cGMlxr@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18355

--- Comment #47 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Nice work everyone!

Pushed to master for 20.05

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 13 14:58:52 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 13 Jan 2020 13:58:52 +0000
Subject: [Koha-bugs] [Bug 21466] Data inconsistencies - koha fields linked
 to AV cat values must have a corresponding authorised value
In-Reply-To: <bug-21466-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21466-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21466-70-u4MqvscKUp@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21466

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to master
         Version(s)|                            |20.05.00
        released in|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 13 14:58:54 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 13 Jan 2020 13:58:54 +0000
Subject: [Koha-bugs] [Bug 21466] Data inconsistencies - koha fields linked
 to AV cat values must have a corresponding authorised value
In-Reply-To: <bug-21466-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21466-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21466-70-YrHHx86kAR@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21466

--- Comment #11 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Nice work everyone!

Pushed to master for 20.05

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 13 15:06:30 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 13 Jan 2020 14:06:30 +0000
Subject: [Koha-bugs] [Bug 24410] Multi holds broken
In-Reply-To: <bug-24410-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24410-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24410-70-VZsRVAg8of@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24410

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |tomascohen at gmail.com

--- Comment #2 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
I tested the multi_hold flow and it calls request.pl or modrequest.pl (when you
update the multi hold).

I belive we are safe without this patch.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 13 15:07:08 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 13 Jan 2020 14:07:08 +0000
Subject: [Koha-bugs] [Bug 23354] Add a 'Pay' screen to allow anonymous
 payments in a POS fashion
In-Reply-To: <bug-23354-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23354-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23354-70-GsWHwMqWhM@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23354

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to master
         Version(s)|                            |20.05.00
        released in|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 13 15:07:10 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 13 Jan 2020 14:07:10 +0000
Subject: [Koha-bugs] [Bug 23354] Add a 'Pay' screen to allow anonymous
 payments in a POS fashion
In-Reply-To: <bug-23354-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23354-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23354-70-8mW0IDT01e@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23354

--- Comment #155 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Nice work everyone!

Pushed to master for 20.05

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 13 15:07:12 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 13 Jan 2020 14:07:12 +0000
Subject: [Koha-bugs] [Bug 23790] fr-CA translation of ACCOUNT_DEBIT and
 ACCOUNT_CREDIT notices
In-Reply-To: <bug-23790-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23790-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23790-70-N5vwUR6jrU@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23790

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to master
         Version(s)|                            |20.05.00
        released in|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 13 15:07:14 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 13 Jan 2020 14:07:14 +0000
Subject: [Koha-bugs] [Bug 23790] fr-CA translation of ACCOUNT_DEBIT and
 ACCOUNT_CREDIT notices
In-Reply-To: <bug-23790-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23790-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23790-70-8HEbedawmN@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23790

--- Comment #5 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Nice work everyone!

Pushed to master for 20.05

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 13 15:13:00 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 13 Jan 2020 14:13:00 +0000
Subject: [Koha-bugs] [Bug 24143] buildQuery should disable Query* on
 identifier search
In-Reply-To: <bug-24143-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24143-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24143-70-ruWkC5rTc9@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24143

Matthias Meusburger <matthias.meusburger at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #95927|0                           |1
        is obsolete|                            |

--- Comment #2 from Matthias Meusburger <matthias.meusburger at biblibre.com> ---
Created attachment 97311
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97311&action=edit
Bug 24143: Disable QueryXXX when searching on a identifier.

Using the ident or identifier-standard index should not involve
any of the following features:

 - QueryAutoTruncate
 - QueryFuzzy
 - QueryStemming
 - QueryWeightFields

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 13 15:16:41 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 13 Jan 2020 14:16:41 +0000
Subject: [Koha-bugs] [Bug 24366] Merging biblioitems should happen in
 Koha::Biblio->to_api
In-Reply-To: <bug-24366-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24366-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24366-70-TmRqIbNS81@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24366

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 13 15:16:44 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 13 Jan 2020 14:16:44 +0000
Subject: [Koha-bugs] [Bug 24366] Merging biblioitems should happen in
 Koha::Biblio->to_api
In-Reply-To: <bug-24366-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24366-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24366-70-GPpfqelKRt@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24366

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #96958|0                           |1
        is obsolete|                            |
  Attachment #96959|0                           |1
        is obsolete|                            |

--- Comment #5 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 97312
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97312&action=edit
Bug 24366: Unit tests

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 13 15:16:47 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 13 Jan 2020 14:16:47 +0000
Subject: [Koha-bugs] [Bug 24366] Merging biblioitems should happen in
 Koha::Biblio->to_api
In-Reply-To: <bug-24366-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24366-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24366-70-x4cLFT6LiB@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24366

--- Comment #6 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 97313
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97313&action=edit
Bug 24366: Merge biblioitem in Koha::Biblio->to_api

This patch moves the bilbioitem object merge into the
Koha::Biblio->to_api method, as opposed to doing it in the controller.
This is an inevitable change as other endpoints might require to embed
biblio objects, and they need to carry the biblioitem information.

Also, if we merge the tables, the transition will be straightforward
(remove the tests this patch introduces, and merge the mappings from
Koha::Biblioitem into Koha::Biblio).

To test:
1. Apply this patches
2. Run:
   $ kshell
  k$ prove t/db_dependent/Koha/Biblio.t \
           t/db_dependent/api/v1/biblios.t
=> SUCCESS: Tests pass! i.e. the new to_api method is tested, and the
API tests don't expect any behavior change.
3. Sign off :-D

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 13 15:16:51 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 13 Jan 2020 14:16:51 +0000
Subject: [Koha-bugs] [Bug 24366] Merging biblioitems should happen in
 Koha::Biblio->to_api
In-Reply-To: <bug-24366-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24366-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24366-70-M1B6R5ilax@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24366

--- Comment #7 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 97314
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97314&action=edit
Bug 24366: Improve hashref construction

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 13 15:27:49 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 13 Jan 2020 14:27:49 +0000
Subject: [Koha-bugs] [Bug 24407] AuthDisplayHierarchies ignores new nodes
 and needs protection against cyclic relations
In-Reply-To: <bug-24407-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24407-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24407-70-Bro7seGlR3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24407

--- Comment #3 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
(In reply to Katrin Fischer from comment #2)
> (In reply to Marcel de Rooy from comment #1)
> > Katrin,
> > If I am not mistaken, you are using it? Could you comment on this?
> 
> Sadly not at the moment, see major bug 23190 - I can't get it to work at the
> moment.

Could it be related to the first thing mentioned here?

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 13 15:36:42 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 13 Jan 2020 14:36:42 +0000
Subject: [Koha-bugs] [Bug 24361] Fix warnings (or failing tests) from bug
 24217
In-Reply-To: <bug-24361-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24361-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24361-70-eI1YX1TU25@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24361

--- Comment #6 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 97315
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97315&action=edit
Bug 24361: Remove warning from GetAgeRestriction

Use of uninitialized value $record_restrictions in uc at
/kohadevbox/koha/C4/Circulation.pm line 3981

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 13 15:43:14 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 13 Jan 2020 14:43:14 +0000
Subject: [Koha-bugs] [Bug 22987] Add biblioimages.timestamp
In-Reply-To: <bug-22987-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22987-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22987-70-gXapY87XHw@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22987

--- Comment #1 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 97316
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97316&action=edit
Bug 22987: Add biblioimages.timestamp

This patch adds the timestamp column to the biblioimages table.
To test:
1. Apply this patch
2. Run:
   $ updatedatabase
   $ koha-mysql kohadev
   > SHOW CREATE TABLE biblioimages;
=> SUCCESS: Notice the new column is there with the right settings
3. Sign off :-D

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 13 15:43:24 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 13 Jan 2020 14:43:24 +0000
Subject: [Koha-bugs] [Bug 22987] Add biblioimages.timestamp
In-Reply-To: <bug-22987-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22987-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22987-70-JPt1JFsSa7@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22987

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |tomascohen at gmail.com
             Status|NEW                         |Needs Signoff
           Assignee|koha-bugs at lists.koha-commun |tomascohen at gmail.com
                   |ity.org                     |

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 13 15:43:40 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 13 Jan 2020 14:43:40 +0000
Subject: [Koha-bugs] [Bug 24392] Leading whitespaces in Marc fields cause
 errors
In-Reply-To: <bug-24392-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24392-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24392-70-oTXwMmvRTJ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24392

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org

--- Comment #1 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
All good for me. Which Koha versions? Which errors in the koha logs? In the JS
console? Can you attach the record to this bug report?

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 13 15:49:26 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 13 Jan 2020 14:49:26 +0000
Subject: [Koha-bugs] [Bug 24361] Fix warnings (or failing tests) from bug
 24217
In-Reply-To: <bug-24361-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24361-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24361-70-bbE0C7yFYG@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24361

--- Comment #7 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
 Bug 24361: Remove warning from GetAgeRestriction - Pushed to master

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 13 15:52:27 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 13 Jan 2020 14:52:27 +0000
Subject: [Koha-bugs] [Bug 20212] Slowness in Receiving in Acquisitions
In-Reply-To: <bug-20212-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20212-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20212-70-5rNfM432Hq@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20212

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|jesse at bywatersolutions.com  |tomascohen at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 13 15:52:44 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 13 Jan 2020 14:52:44 +0000
Subject: [Koha-bugs] [Bug 20212] Slowness in Receiving in Acquisitions
In-Reply-To: <bug-20212-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20212-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20212-70-ib0IIYrQ07@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20212

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED

--- Comment #6 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Time to finish this as all dependencies are in master \o/

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 13 15:53:50 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 13 Jan 2020 14:53:50 +0000
Subject: [Koha-bugs] [Bug 23702] New UNIMARC XSLT according to last IFLA
 updates
In-Reply-To: <bug-23702-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23702-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23702-70-L8GJ99VoQT@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23702

Fridolin SOMERS <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |fridolin.somers at biblibre.co
                   |                            |m
  Attachment #95949|1                           |0
           is patch|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 13 15:57:57 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 13 Jan 2020 14:57:57 +0000
Subject: [Koha-bugs] [Bug 24361] Fix warnings (or failing tests) from bug
 24217
In-Reply-To: <bug-24361-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24361-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24361-70-W3SZDH4MnH@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24361

--- Comment #8 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
(In reply to Jonathan Druart from comment #5)
> Created attachment 96969 [details] [review]
> Bug 24361: (follow-up) Fix CalcFine.t
> 
> I mixed up 2 possible solutions, the "not defined" is handled by the "!
> defined $item->{replacementprice}" part
> 
> t/db_dependent/Circulation/CalcFine.t .. 1/3
>     #   Failed test 'Amount is calculated correctly'
>     #   at t/db_dependent/Circulation/CalcFine.t line 167.
>     #          got: '29'
>     #     expected: '6'
>     # Looks like you failed 1 test of 2.

This has been pushed too, different title however "Bug 24361: (RM follow-up)
Restore 0 handling in CalcFine"

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 13 15:58:01 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 13 Jan 2020 14:58:01 +0000
Subject: [Koha-bugs] [Bug 24361] Fix warnings (or failing tests) from bug
 24217
In-Reply-To: <bug-24361-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24361-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24361-70-c6mE9oMJhJ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24361

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|additional_work_needed      |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 13 16:00:49 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 13 Jan 2020 15:00:49 +0000
Subject: [Koha-bugs] [Bug 24409] admin/authorised_values.pl?op=add_form :
 Add New Category is vulnerable for CSRF attacks
In-Reply-To: <bug-24409-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24409-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24409-70-uXoz1WkoE6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24409

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=22990
            Version|19.11                       |unspecified
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org

--- Comment #3 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Yes, that may work. However we are going to fix them globally, see bug 22990
for more information.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 13 16:05:01 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 13 Jan 2020 15:05:01 +0000
Subject: [Koha-bugs] [Bug 24353] privacy_guarantor_checkouts incorrectly
 shows No on moremember.pl
In-Reply-To: <bug-24353-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24353-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24353-70-2YY53zPaTG@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24353

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org

--- Comment #1 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
This is ok on master.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 13 16:06:55 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 13 Jan 2020 15:06:55 +0000
Subject: [Koha-bugs] [Bug 24349] Debit types table only shows 2 entries,
 but says there are 15
In-Reply-To: <bug-24349-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24349-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24349-70-3mraMLfcFU@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24349

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |INVALID
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org

--- Comment #1 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
There is a "Show all debit types" link at the top of the table:
https://snipboard.io/CdE4To.jpg

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 13 16:11:41 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 13 Jan 2020 15:11:41 +0000
Subject: [Koha-bugs] [Bug 17667] Standing orders - cancelling a receipt
 increase the original quantity
In-Reply-To: <bug-17667-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17667-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17667-70-E1ifMEF7lt@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17667

ByWater Sandboxes <bws.sandboxes at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #96663|0                           |1
        is obsolete|                            |

--- Comment #8 from ByWater Sandboxes <bws.sandboxes at gmail.com> ---
Created attachment 97317
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97317&action=edit
Bug 17667: Do not modify quantity of the original standing order when a receipt
is cancelled

When cancelling a receipt, the quantity of the original order is
increased.

Test plan:
Create a basket, mark is as "standing orders"
Create an order
receive it
cancel the receipt
=> Without this patch the quantity of the original order is 2
=> With this patch applied the quantity it always 1

Signed-off-by: Kelly McElligott <kelly at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 13 16:11:43 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 13 Jan 2020 15:11:43 +0000
Subject: [Koha-bugs] [Bug 17667] Standing orders - cancelling a receipt
 increase the original quantity
In-Reply-To: <bug-17667-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17667-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17667-70-4Guz0swT9V@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17667

ByWater Sandboxes <bws.sandboxes at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #96664|0                           |1
        is obsolete|                            |

--- Comment #9 from ByWater Sandboxes <bws.sandboxes at gmail.com> ---
Created attachment 97318
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97318&action=edit
Bug 17667: Add tests

Signed-off-by: Kelly McElligott <kelly at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 13 16:12:36 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 13 Jan 2020 15:12:36 +0000
Subject: [Koha-bugs] [Bug 17667] Standing orders - cancelling a receipt
 increase the original quantity
In-Reply-To: <bug-17667-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17667-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17667-70-aGLqNxyCkj@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17667

Kelly McElligott <kelly at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off
                 CC|                            |kelly at bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 13 16:27:55 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 13 Jan 2020 15:27:55 +0000
Subject: [Koha-bugs] [Bug 18038] Generate fees per month for all patrons
 with a particular category
In-Reply-To: <bug-18038-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18038-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18038-70-gRWFrZph76@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18038

Agnes Rivers-Moore <arm at hanover.ca> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|arm at hanover.ca              |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 13 16:29:00 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 13 Jan 2020 15:29:00 +0000
Subject: [Koha-bugs] [Bug 21520] More complex OAI sets mappings
In-Reply-To: <bug-21520-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21520-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21520-70-iA2IZ3cy0R@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21520

--- Comment #11 from Matthias Meusburger <matthias.meusburger at biblibre.com> ---
Created attachment 97319
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97319&action=edit
Bug 21520: (QA follow-up): Updatedatabase

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 13 16:30:28 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 13 Jan 2020 15:30:28 +0000
Subject: [Koha-bugs] [Bug 21520] More complex OAI sets mappings
In-Reply-To: <bug-21520-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21520-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21520-70-HbYNjYDNsZ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21520

--- Comment #12 from Matthias Meusburger <matthias.meusburger at biblibre.com> ---
rule_order is now set and the first rule_operator of each mapping is set to
null.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 13 16:32:34 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 13 Jan 2020 15:32:34 +0000
Subject: [Koha-bugs] [Bug 22868] Separate Permissions for "Manage Purchase
 Suggestions" and "Enter Purchase Suggestions"
In-Reply-To: <bug-22868-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22868-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22868-70-6XpfeCOvTy@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22868

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org

--- Comment #7 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Can you confirm that the problematic information is on the Acquisition home
page (acqui/acqui-home.pl) and is the fund list?

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 13 16:35:41 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 13 Jan 2020 15:35:41 +0000
Subject: [Koha-bugs] [Bug 24403] [OMNIBUS] OpacHiddenItems should hide items
 everywhere in the OPAC
In-Reply-To: <bug-24403-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24403-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24403-70-zH7bye2z0p@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24403

Ray Delahunty <r.delahunty at arts.ac.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |r.delahunty at arts.ac.uk

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 13 16:35:52 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 13 Jan 2020 15:35:52 +0000
Subject: [Koha-bugs] [Bug 22868] Separate Permissions for "Manage Purchase
 Suggestions" and "Enter Purchase Suggestions"
In-Reply-To: <bug-22868-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22868-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22868-70-ai2ZVlkinb@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22868

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |11911

--- Comment #8 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
acqui/acqui-home.pl:        flagsrequired   => { acquisition => '*' },
acqui/booksellers.pl:        flagsrequired   => { acquisition => '*' },
acqui/histsearch.pl:        flagsrequired   => { acquisition => '*' },
acqui/invoice-files.pl:        flagsrequired   => { 'acquisition' => '*' },
acqui/invoice.pl:        flagsrequired   => { 'acquisition' => '*' },
acqui/invoices.pl:        flagsrequired   => { 'acquisition' => '*' },
acqui/modordernotes.pl:    flagsrequired   => { 'acquisition' => '*' },
acqui/ordered.pl:        flagsrequired   => { acquisition => '*' },
acqui/showorder.pl:    flagsrequired   => { acquisition => '*' },
acqui/spent.pl:        flagsrequired   => { acquisition => '*' },
acqui/supplier.pl:        flagsrequired   => { acquisition => '*' },
services/itemrecorddisplay.pl:    flagsrequired   => {acquisition => '*'},


I would suggest to move acquisition.suggestions_manage to a new permission
"namespace", suggestions.suggestions_manage.
Would it work?


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11911
[Bug 11911] Add separate permission for managing suggestions
-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 13 16:35:52 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 13 Jan 2020 15:35:52 +0000
Subject: [Koha-bugs] [Bug 11911] Add separate permission for managing
 suggestions
In-Reply-To: <bug-11911-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-11911-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11911-70-wed3Btb3vS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11911

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |22868


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22868
[Bug 22868] Separate Permissions for "Manage Purchase Suggestions" and "Enter
Purchase Suggestions"
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 13 16:41:29 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 13 Jan 2020 15:41:29 +0000
Subject: [Koha-bugs] [Bug 21466] Data inconsistencies - koha fields linked
 to AV cat values must have a corresponding authorised value
In-Reply-To: <bug-21466-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21466-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21466-70-2HsPjjyNDA@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21466

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|rel_20_05_target,           |
                   |RM_priority                 |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 13 16:46:05 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 13 Jan 2020 15:46:05 +0000
Subject: [Koha-bugs] [Bug 21520] More complex OAI sets mappings
In-Reply-To: <bug-21520-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21520-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21520-70-p82IyUl53C@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21520

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 13 16:46:09 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 13 Jan 2020 15:46:09 +0000
Subject: [Koha-bugs] [Bug 21520] More complex OAI sets mappings
In-Reply-To: <bug-21520-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21520-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21520-70-aEVfbLymi1@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21520

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #96052|0                           |1
        is obsolete|                            |
  Attachment #96790|0                           |1
        is obsolete|                            |
  Attachment #97319|0                           |1
        is obsolete|                            |

--- Comment #13 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 97320
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97320&action=edit
Bug 21520: More complex OAI sets mappings

Currently, the rules used to create OAI sets are processed with the 'or'
boolean operator between each rule.

This patch allows to use 'or' or 'and' between the rules.

The evaluation of the rules is done according to the boolean operators
precedence: AND has a higher precedence than OR.

For example:

A and B or C and D

will be evaluated as follow:

(A and B) or (C and D)

Test plan:

 - Apply the patch
 - Apply the atomicupdate
 - Prove t/db_dependant/OAI/AndSets.t
 - Check that existing mappings still work
 - Try modifying existing mappings
 - Try creating new mappings
 - Check that the boolean operators precedence is correctly taken into account

Signed-off-by: Michal Denar <black23 at gmail.com>

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 13 16:46:13 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 13 Jan 2020 15:46:13 +0000
Subject: [Koha-bugs] [Bug 21520] More complex OAI sets mappings
In-Reply-To: <bug-21520-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21520-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21520-70-kThUFccuJW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21520

--- Comment #14 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 97321
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97321&action=edit
Bug 21520: QA Follow-up: do not build html tags with TT conditions

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 13 16:46:17 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 13 Jan 2020 15:46:17 +0000
Subject: [Koha-bugs] [Bug 21520] More complex OAI sets mappings
In-Reply-To: <bug-21520-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21520-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21520-70-hds5AzXIDD@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21520

--- Comment #15 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 97322
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97322&action=edit
Bug 21520: (QA follow-up): Updatedatabase

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 13 16:49:17 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 13 Jan 2020 15:49:17 +0000
Subject: [Koha-bugs] [Bug 22868] Separate Permissions for "Manage Purchase
 Suggestions" and "Enter Purchase Suggestions"
In-Reply-To: <bug-22868-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22868-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22868-70-WdxaSYx9ck@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22868

--- Comment #9 from Marie-Luce Laflamme <marie-luce.laflamme at inlibro.com> ---
It would be a good thing to separate permissions:
1 - "Enter purchase suggestions"
2 - "Manage purchase suggestions"

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 13 16:50:21 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 13 Jan 2020 15:50:21 +0000
Subject: [Koha-bugs] [Bug 22868] Separate Permissions for "Manage Purchase
 Suggestions" and "Enter Purchase Suggestions"
In-Reply-To: <bug-22868-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22868-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22868-70-fS6e01qGzI@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22868

--- Comment #10 from Marie-Luce Laflamme <marie-luce.laflamme at inlibro.com> ---
Yes it's on (acqui/acqui-home.pl) page.

It would be a good thing to separate permissions:
1 - "Enter purchase suggestions"
2 - "Manage purchase suggestions"

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 13 16:53:39 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 13 Jan 2020 15:53:39 +0000
Subject: [Koha-bugs] [Bug 10758] Show bibliographic information of deleted
 records in acquisitions
In-Reply-To: <bug-10758-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-10758-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10758-70-GZqc6fJkXa@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10758

--- Comment #69 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
(In reply to Katrin Fischer from comment #68)
> (In reply to Jonathan Druart from comment #67)
> > That should be done on top of bug 20271.
> 
> We could do it in a different way too - I know that we got some logic in a
> table now where 2 biblionumbers are stored in different columns - that way
> FK can be set. Martin did it, I just fail to remember the bug report and
> table.

Yes, but it is adding more stuffs to unravel for bug 20271.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 13 16:57:15 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 13 Jan 2020 15:57:15 +0000
Subject: [Koha-bugs] [Bug 24411] New: Offline circulation should require
 login
Message-ID: <bug-24411-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24411

            Bug ID: 24411
           Summary: Offline circulation should require login
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Circulation
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: cbrannon at cdalibrary.org
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com

Currently, regular circulation tracks who checked in/out what.  Offline Circ
does not track this information.  Instead, when offline circ info is uploaded,
it is recorded as the person doing the upload.

I would suggest that offline circ require a quasi login - the Koha username
should be asked for.  Obviously, there is no way to authenticate if Koha is
down, but this would give us something.

Then, when the information is uploaded, Koha should confirm the id, and if it
is an actual patron, show (and optionally confirm) that is the correct person. 
If it can't confirm the staff member (keyed in wrong), we should have a pref
that would either ask you if you want to proceed uploading, recording the staff
member as you (the uploader), or display what was entered and select the staff
member who you think was circing at the time.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 13 16:57:17 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 13 Jan 2020 15:57:17 +0000
Subject: [Koha-bugs] [Bug 23354] Add a 'Pay' screen to allow anonymous
 payments in a POS fashion
In-Reply-To: <bug-23354-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23354-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23354-70-98RKSDQ1yS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23354

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org

--- Comment #156 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Notice templates are missing in .sql files

xt/sample_notices.t .. 1/?
#   Failed test 'No sample notice to add'
#   at xt/sample_notices.t line 83.
# Sample notices to add in fr-FR/1-Obligatoire/sample_notices.sql: RECEIPT

#   Failed test 'No sample notice to add'
#   at xt/sample_notices.t line 83.
# Sample notices to add in fr-CA/obligatoire/sample_notices.sql: RECEIPT

#   Failed test 'No sample notice to add'
#   at xt/sample_notices.t line 83.
# Sample notices to add in de-DE/mandatory/sample_notices.sql: RECEIPT

#   Failed test 'No sample notice to add'
#   at xt/sample_notices.t line 83.
# Sample notices to add in es-ES/mandatory/sample_notices.sql: RECEIPT

#   Failed test 'No sample notice to add'
#   at xt/sample_notices.t line 83.
# Sample notices to add in it-IT/necessari/notices.sql: RECEIPT

#   Failed test 'No sample notice to add'
#   at xt/sample_notices.t line 83.
# Sample notices to add in nb-NO/1-Obligatorisk/sample_notices.sql: RECEIPT

#   Failed test 'No sample notice to add'
#   at xt/sample_notices.t line 83.
# Sample notices to add in pl-PL/mandatory/sample_notices.sql: RECEIPT

#   Failed test 'No sample notice to add'
#   at xt/sample_notices.t line 83.
# Sample notices to add in ru-RU/mandatory/sample_notices.sql: RECEIPT

#   Failed test 'No sample notice to add'
#   at xt/sample_notices.t line 83.
# Sample notices to add in uk-UA/mandatory/sample_notices.sql: RECEIPT
# Looks like you failed 9 tests of 38.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 13 16:57:57 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 13 Jan 2020 15:57:57 +0000
Subject: [Koha-bugs] [Bug 16766] Merging two records with holds for the same
 patron creates two holds on one record
In-Reply-To: <bug-16766-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16766-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16766-70-YCsQgTLk0H@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16766

Christopher Brannon <cbrannon at cdalibrary.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Merging two records         |Merging two records with
                   |withholds for the same      |holds for the same patron
                   |patron creates two holds on |creates two holds on one
                   |one record                  |record

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 13 16:58:06 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 13 Jan 2020 15:58:06 +0000
Subject: [Koha-bugs] [Bug 23354] Add a 'Pay' screen to allow anonymous
 payments in a POS fashion
In-Reply-To: <bug-23354-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23354-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23354-70-c7qb5Tw8Bq@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23354

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |additional_work_needed

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 13 17:02:04 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 13 Jan 2020 16:02:04 +0000
Subject: [Koha-bugs] [Bug 23091] Restore Forgiven Overdue Fines When Lost
 Item Returned
In-Reply-To: <bug-23091-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23091-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23091-70-kmLTC63Xed@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23091

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 13 17:02:17 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 13 Jan 2020 16:02:17 +0000
Subject: [Koha-bugs] [Bug 23091] Restore Forgiven Overdue Fines When Lost
 Item Returned
In-Reply-To: <bug-23091-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23091-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23091-70-9BVrlsJTZi@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23091

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Version|18.11                       |master

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 13 17:02:49 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 13 Jan 2020 16:02:49 +0000
Subject: [Koha-bugs] [Bug 23354] Add a 'Pay' screen to allow anonymous
 payments in a POS fashion
In-Reply-To: <bug-23354-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23354-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23354-70-NtZlnBJdB9@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23354

--- Comment #157 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
account_debit_types.can_be_added_manually

-  `can_be_added_manually` tinyint(4) NOT NULL DEFAULT 1,

Is that expected?

Test is failing because of that:
t/db_dependent/Koha/Account/DebitType.t .. DBIx::Class::Row::store_column(): No
such column 'can_be_added_manually' on Koha::Schema::Result::AccountDebitType
at /kohadevbox/koha/Koha/Object.pm line 77

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 13 17:03:21 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 13 Jan 2020 16:03:21 +0000
Subject: [Koha-bugs] [Bug 17984] Warn catalogers if item type doesn't match
 942c
In-Reply-To: <bug-17984-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17984-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17984-70-H0r8IjcJre@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17984

--- Comment #2 from Christopher Brannon <cbrannon at cdalibrary.org> ---
(In reply to Katrin Fischer from comment #1)
> Hi Christopher, not sure I understand the problem here - 942$c is usually a
> pull down, so it should always match an existing itemtype?

942c is a bib level item type.  Item type is also recorded on the item record. 
Sometimes these two types do not match, and causes problems between item level
holds and first available holds.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 13 17:05:45 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 13 Jan 2020 16:05:45 +0000
Subject: [Koha-bugs] [Bug 22868] Separate Permissions for "Manage Purchase
 Suggestions" and "Enter Purchase Suggestions"
In-Reply-To: <bug-22868-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22868-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22868-70-voQ3atxFPk@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22868

--- Comment #11 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
(In reply to Marie-Luce Laflamme from comment #10)
> Yes it's on (acqui/acqui-home.pl) page.
> 
> It would be a good thing to separate permissions:
> 1 - "Enter purchase suggestions"
> 2 - "Manage purchase suggestions"

It will not fix the problem.
The issue here is that script are checking for acquisition => '*' permission,
which means "whichever permission is ok for access".
Splitting the permission will not block the access to these pages.

That's why I suggestion to move the manage_suggestions out of the
"acquisition". We could split the permission later if still needed.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 13 17:07:12 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 13 Jan 2020 16:07:12 +0000
Subject: [Koha-bugs] [Bug 23354] Add a 'Pay' screen to allow anonymous
 payments in a POS fashion
In-Reply-To: <bug-23354-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23354-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23354-70-3nQkhFsloU@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23354

--- Comment #158 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
The column account_debit_types.can_be_added_manually has been removed:

-  `can_be_added_manually` tinyint(4) NOT NULL DEFAULT 1,

Is that expected?

Test is failing because of that:
t/db_dependent/Koha/Account/DebitType.t .. DBIx::Class::Row::store_column(): No
such column 'can_be_added_manually' on Koha::Schema::Result::AccountDebitType
at /kohadevbox/koha/Koha/Object.pm line 77

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 13 17:10:02 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 13 Jan 2020 16:10:02 +0000
Subject: [Koha-bugs] [Bug 24143] buildQuery should disable Query* on
 identifier search
In-Reply-To: <bug-24143-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24143-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24143-70-85B8LSa8El@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24143

Matthias Meusburger <matthias.meusburger at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #97311|0                           |1
        is obsolete|                            |

--- Comment #3 from Matthias Meusburger <matthias.meusburger at biblibre.com> ---
Created attachment 97323
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97323&action=edit
Bug 24143: Disable QueryXXX when searching on a identifier.

Using the ident or identifier-standard index should not involve
any of the following features:

 - QueryAutoTruncate
 - QueryFuzzy
 - QueryStemming
 - QueryWeightFields

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 13 17:10:57 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 13 Jan 2020 16:10:57 +0000
Subject: [Koha-bugs] [Bug 24392] Leading whitespaces in Marc fields cause
 errors
In-Reply-To: <bug-24392-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24392-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24392-70-fEJrLF8z5W@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24392

--- Comment #2 from Christopher Brannon <cbrannon at cdalibrary.org> ---
(In reply to Jonathan Druart from comment #1)
> All good for me. Which Koha versions? Which errors in the koha logs? In the
> JS console? Can you attach the record to this bug report?

Right now we are seeing this in 19.05.  I don't know about earlier versions. 
The records were repaired, so I don't have an example at the moment.  I will
see if I can recreate this manually.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 13 17:11:25 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 13 Jan 2020 16:11:25 +0000
Subject: [Koha-bugs] [Bug 18731] Add routes for acquisition orders
In-Reply-To: <bug-18731-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18731-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18731-70-kmTXynPM9w@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18731

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org

--- Comment #47 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
The new test is failing (randomly?)

t/db_dependent/Koha/REST/Plugin/Objects.t .. 1/3
    #   Failed test 'exact match for JSON Pointer "/0"'
    #   at t/db_dependent/Koha/REST/Plugin/Objects.t line 174.
    #     Structures begin differing at:
    #          $got->{fund}{budget_id} = '534289848'
    #     $expected->{fund}{budget_id} = Does not exist

Koha_Master_D9_My8 run 76

It's not related to My8, I recreate locally with MariaDB latest.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 13 17:12:25 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 13 Jan 2020 16:12:25 +0000
Subject: [Koha-bugs] [Bug 18731] Add routes for acquisition orders
In-Reply-To: <bug-18731-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18731-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18731-70-LdSH3VnAPj@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18731

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |additional_work_needed

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 13 17:14:37 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 13 Jan 2020 16:14:37 +0000
Subject: [Koha-bugs] [Bug 23493] jquery.dataTables.rowGrouping.js is no
 longer maintained,
 but there is an official DataTables version we could switch to
In-Reply-To: <bug-23493-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23493-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23493-70-s2cuZhjxDp@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23493

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |23355


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23355
[Bug 23355] Add 'cashup' process to the accounts system
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 13 17:14:37 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 13 Jan 2020 16:14:37 +0000
Subject: [Koha-bugs] [Bug 23355] Add 'cashup' process to the accounts system
In-Reply-To: <bug-23355-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23355-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23355-70-F1WILArFRv@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23355

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |23493


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23493
[Bug 23493] jquery.dataTables.rowGrouping.js is no longer maintained, but there
is an official DataTables version we could switch to
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 13 17:14:58 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 13 Jan 2020 16:14:58 +0000
Subject: [Koha-bugs] [Bug 24410] Multi holds broken
In-Reply-To: <bug-24410-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24410-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24410-70-X4LvdvDB4v@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24410

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|jonathan.druart at bugs.koha-c |tomascohen at gmail.com
                   |ommunity.org                |
             Status|Needs Signoff               |ASSIGNED

--- Comment #3 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
This seems to work ok. Assigning to Tomas for the next steps (ie. more work is
needed if placerequest can be removed).

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 13 17:22:24 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 13 Jan 2020 16:22:24 +0000
Subject: [Koha-bugs] [Bug 23493] jquery.dataTables.rowGrouping.js is no
 longer maintained,
 but there is an official DataTables version we could switch to
In-Reply-To: <bug-23493-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23493-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23493-70-XCNJ5b8Rye@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23493

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #92444|0                           |1
        is obsolete|                            |

--- Comment #6 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 97324
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97324&action=edit
Bug 23493: Replace rowGrouping with rowGroup

This is an initial attempt to get some feedback.

Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 13 17:23:12 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 13 Jan 2020 16:23:12 +0000
Subject: [Koha-bugs] [Bug 23493] jquery.dataTables.rowGrouping.js is no
 longer maintained,
 but there is an official DataTables version we could switch to
In-Reply-To: <bug-23493-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23493-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23493-70-RVbfzxDJdK@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23493

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 13 17:24:55 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 13 Jan 2020 16:24:55 +0000
Subject: [Koha-bugs] [Bug 24340] We ought to be able to disable SIP using
 koha-sip
In-Reply-To: <bug-24340-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24340-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24340-70-ZI9ZNEF2EN@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24340

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |liz at catalyst.net.nz
                   |ity.org                     |
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org

--- Comment #7 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
209         echo "Warning: SIP server disabled for ${name}"

Do we really want to display a warning if what has been asked has been done
successfully?

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 13 17:34:22 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 13 Jan 2020 16:34:22 +0000
Subject: [Koha-bugs] [Bug 24364] Display item holding library in opac issues
In-Reply-To: <bug-24364-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24364-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24364-70-2Rov7TK3a6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24364

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org

--- Comment #3 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Should not this be added to the .sql installer files?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 13 17:35:01 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 13 Jan 2020 16:35:01 +0000
Subject: [Koha-bugs] [Bug 22868] Separate Permissions for "Manage Purchase
 Suggestions" and "Enter Purchase Suggestions"
In-Reply-To: <bug-22868-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22868-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22868-70-QTUBuLNSJd@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22868

--- Comment #12 from Marie-Luce Laflamme <marie-luce.laflamme at inlibro.com> ---
It may not fix the problem, but we should definitely find a better way to
handle purchase suggestions.

As mentioned earlier, circulation staff required the "managing purchase
suggestions" permission to create purchase suggestions on a patron's behalf. 

However, you do not want circulation staff to decide if a purchase suggestion
should be ordered nor access to the budget. Only librarians should manage
suggestions.

There are 2 problems:

- access to the budget without permission
- the need of 2 separate permissions (" enter" vs "manage" purchase
suggestions)

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 13 17:38:57 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 13 Jan 2020 16:38:57 +0000
Subject: [Koha-bugs] [Bug 24392] Leading whitespaces in Marc fields cause
 errors
In-Reply-To: <bug-24392-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24392-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24392-70-EorckDqpwj@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24392

--- Comment #3 from Christopher Brannon <cbrannon at cdalibrary.org> ---
(In reply to Jonathan Druart from comment #1)
> All good for me. Which Koha versions? Which errors in the koha logs? In the
> JS console? Can you attach the record to this bug report?

I can't manually recreate this, but I am checking with Bywater to see if they
can.

I am suspecting the whitespace was transferred through a downloaded record,
since I can't manually create the error.  Wonder if there needs to be something
in place to strip leading whitespace on downloaded records?

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 13 17:44:42 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 13 Jan 2020 16:44:42 +0000
Subject: [Koha-bugs] [Bug 8643] Add important constraint to MARC tags and
 subfields
In-Reply-To: <bug-8643-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-8643-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8643-70-ig1kTgvlGd@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8643

Maryse Simard <maryse.simard at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #96627|0                           |1
        is obsolete|                            |

--- Comment #91 from Maryse Simard <maryse.simard at inlibro.com> ---
Created attachment 97325
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97325&action=edit
Bug 8643: Add important constraint to marc subfields

This fix permits to add an "Important" option to the marc structure pages.

Testing:

1) Apply the patch
2) Run updatedatabase.pl
3) Regenerate CSS
4) Define 100 as an "important" field ( Administration » MARC bibliographic
framework » MARC structure ( Default Frameword) » Edit )
5) Define 100$a as an "important" subfield (Administration » MARC bibliographic
framework » MARC structure (Default Frameword) » Subfield » Onglet a)
6) Edit a record to clear the field 100 (subfields are all blank)
7) Save the record.
8) Validate the following message:

A few important fields are not filled:

    * tag 100 subfield a Nom de personne in tab
    * Field 100 is important, at least one of its subfields should be filled.

Are you sure you want to save?

Sponsored by the CCSR ( http://www.ccsr.qc.ca )

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>
Tested on update and new install, works as described.
No errors.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 13 17:44:47 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 13 Jan 2020 16:44:47 +0000
Subject: [Koha-bugs] [Bug 8643] Add important constraint to MARC tags and
 subfields
In-Reply-To: <bug-8643-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-8643-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8643-70-lBzusK3OQm@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8643

--- Comment #92 from Maryse Simard <maryse.simard at inlibro.com> ---
Created attachment 97326
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97326&action=edit
Bug 8643: code cleanup

Merges "AreMandatoriesNotOk" and new "AreImportantsNotOk" into one
function "AreFieldsNotOk". It can search for mandatory or important
fields depending on the value of it's boolean "mandatory"
parameter.

To test:
This patch should not change current behavior.
Follow the test plan from previous patch and check that saving is
still prevented for unfilled mandatory fields.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 13 17:45:16 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 13 Jan 2020 16:45:16 +0000
Subject: [Koha-bugs] [Bug 8643] Add important constraint to MARC tags and
 subfields
In-Reply-To: <bug-8643-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-8643-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8643-70-6brS4thOFD@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8643

Maryse Simard <maryse.simard at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Needs Signoff

--- Comment #93 from Maryse Simard <maryse.simard at inlibro.com> ---
(In reply to Jonathan Druart from comment #88)
> 1. Who is the original author of this patch? Bernardo? Regarding the history
> I do not think so.

The author was lost when the patches were squashed. I changed it back to
simith.

> 2. Not blocker but, when a code is not nice, better refactore and improve it
> than duplicate it ;)
> I am referring to the JS code to test if a mandatory field is filled, it
> would have been easier to make the function accepts an argument to check for
> mandatories or importants.

It's true this duplication is not very nice. I added a patch to try and reuse
the current function instead of duplicating it. I followed your suggestion and
used an argument to indicate whether we want a mandatory or important check.

I've also set the bug back to Needs Signoff because of this change.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 13 17:47:14 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 13 Jan 2020 16:47:14 +0000
Subject: [Koha-bugs] [Bug 23354] Add a 'Pay' screen to allow anonymous
 payments in a POS fashion
In-Reply-To: <bug-23354-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23354-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23354-70-losCPTulxM@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23354

--- Comment #159 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Two followups pushed

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 13 17:47:23 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 13 Jan 2020 16:47:23 +0000
Subject: [Koha-bugs] [Bug 23354] Add a 'Pay' screen to allow anonymous
 payments in a POS fashion
In-Reply-To: <bug-23354-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23354-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23354-70-Vn0wtF7k7S@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23354

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|additional_work_needed      |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 13 17:47:29 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 13 Jan 2020 16:47:29 +0000
Subject: [Koha-bugs] [Bug 24201] Attach desk to intranet session
In-Reply-To: <bug-24201-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24201-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24201-70-biyDFljWwZ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24201

Nicolas Legrand <nicolas.legrand at bulac.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |24412


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24412
[Bug 24412] Attach waiting reserve to desk
-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 13 17:47:29 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 13 Jan 2020 16:47:29 +0000
Subject: [Koha-bugs] [Bug 24412] New: Attach waiting reserve to desk
Message-ID: <bug-24412-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24412

            Bug ID: 24412
           Summary: Attach waiting reserve to desk
 Change sponsored?: Sponsored
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Circulation
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: nicolas.legrand at bulac.fr
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com,
                    severine.queune at bulac.fr
        Depends on: 24201

When an item is checked in and marked 'Waiting' or already 'Waiting' and there
is a desk attached to the session, the item is marked waiting at the current
desk of the current library.

The information is displayed on the OPAC and on the intranet. The patron can
then know at which desk he can retrieve his document.


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24201
[Bug 24201] Attach desk to intranet session
-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 13 17:47:58 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 13 Jan 2020 16:47:58 +0000
Subject: [Koha-bugs] [Bug 23493] jquery.dataTables.rowGrouping.js is no
 longer maintained,
 but there is an official DataTables version we could switch to
In-Reply-To: <bug-23493-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23493-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23493-70-u1Tj9qpAge@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23493

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 13 17:49:39 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 13 Jan 2020 16:49:39 +0000
Subject: [Koha-bugs] [Bug 24392] Leading whitespaces in Marc fields cause
 errors
In-Reply-To: <bug-24392-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24392-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24392-70-BbVyTdJe41@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24392

--- Comment #4 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
No, edit a record, add trailing/leading whitespaces, save, edit again
=> Whitespaces are still there.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 13 17:53:47 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 13 Jan 2020 16:53:47 +0000
Subject: [Koha-bugs] [Bug 24413] New: MarkLostItemsAsReturned functionality
 does not lift restrictions caused by long overdues
Message-ID: <bug-24413-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24413

            Bug ID: 24413
           Summary: MarkLostItemsAsReturned functionality does not lift
                    restrictions caused by long overdues
 Change sponsored?: ---
           Product: Koha
           Version: 19.05
          Hardware: All
                OS: All
            Status: NEW
          Severity: minor
          Priority: P5 - low
         Component: Circulation
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: jrobb at sekls.org
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com

If an account has been restricted by the long overdue process, and the item
causing the restriction is returned by marking it lost (via
MarkLostItemsAsReturned), the restriction is not lifted despite
'AutoRemoveOverduesRestriction' being marked to 'Do'.

To replicate:
1. Set MarkLostItemsAsReturned to 'from items tab of the catalog module'
2. Set AutoRemoveOverduesRestrictions to 'Do'
3. Set up an overdues restriction in the notice triggers
4. Check out an item and let the overdues process restrict the account
5. Navigate to the moredetail.pl page (items tab) for the overdue item
6. Mark the item lost
7. Return to the account in question - notice the item has been returned, but
the restriction remains

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 13 17:54:34 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 13 Jan 2020 16:54:34 +0000
Subject: [Koha-bugs] [Bug 22868] Separate Permissions for "Manage Purchase
 Suggestions" and "Enter Purchase Suggestions"
In-Reply-To: <bug-22868-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22868-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22868-70-8ki380jT59@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22868

--- Comment #13 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
(In reply to Marie-Luce Laflamme from comment #12)
> It may not fix the problem, but we should definitely find a better way to
> handle purchase suggestions.
> 
> As mentioned earlier, circulation staff required the "managing purchase
> suggestions" permission to create purchase suggestions on a patron's behalf. 
> 
> However, you do not want circulation staff to decide if a purchase
> suggestion should be ordered nor access to the budget. Only librarians
> should manage suggestions.
> 
> There are 2 problems:
> 
> - access to the budget without permission
> - the need of 2 separate permissions (" enter" vs "manage" purchase
> suggestions)

Yes, I agree with the 2 permissions but it's an enhancement request, not a
"critical" bug (also not a regression).

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 13 17:55:28 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 13 Jan 2020 16:55:28 +0000
Subject: [Koha-bugs] [Bug 24206] Change URLs for default options in
 OPACSearchForTitleIn
In-Reply-To: <bug-24206-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24206-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24206-70-2wntWJdrgh@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24206

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |martin.renvoize at ptfs-europe
                   |                            |.com

--- Comment #21 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Already pushed a followup :)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 13 17:55:34 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 13 Jan 2020 16:55:34 +0000
Subject: [Koha-bugs] [Bug 24206] Change URLs for default options in
 OPACSearchForTitleIn
In-Reply-To: <bug-24206-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24206-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24206-70-3qgFGQ3FiN@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24206

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|additional_work_needed      |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 13 17:58:26 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 13 Jan 2020 16:58:26 +0000
Subject: [Koha-bugs] [Bug 22868] Separate Permissions for "Manage Purchase
 Suggestions" and "Enter Purchase Suggestions"
In-Reply-To: <bug-22868-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22868-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22868-70-5nhzzcoa1A@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22868

--- Comment #14 from Christopher Brannon <cbrannon at cdalibrary.org> ---
(In reply to Jonathan Druart from comment #13)

> 
> Yes, I agree with the 2 permissions but it's an enhancement request, not a
> "critical" bug (also not a regression).

Not sure why you would call this an enhancement.  This is a bug.  And I don't
recall this behavior on past versions.  At some point this changed, and is not
a desired effect.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 13 17:59:59 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 13 Jan 2020 16:59:59 +0000
Subject: [Koha-bugs] [Bug 24392] Leading whitespaces in Marc fields cause
 errors
In-Reply-To: <bug-24392-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24392-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24392-70-mlNfkgjlHS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24392

--- Comment #5 from Christopher Brannon <cbrannon at cdalibrary.org> ---
(In reply to Jonathan Druart from comment #4)
> No, edit a record, add trailing/leading whitespaces, save, edit again
> => Whitespaces are still there.

This isn't a matter of manually adding whitespace.  I can do that.  It just
isn't creating the same effect.  So, there is something more specific about the
whitespace that I don't know about.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 13 18:05:00 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 13 Jan 2020 17:05:00 +0000
Subject: [Koha-bugs] [Bug 22868] Separate Permissions for "Manage Purchase
 Suggestions" and "Enter Purchase Suggestions"
In-Reply-To: <bug-22868-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22868-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22868-70-psM3zpVxKF@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22868

--- Comment #15 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
(In reply to Christopher Brannon from comment #14)
> (In reply to Jonathan Druart from comment #13)
> 
> > 
> > Yes, I agree with the 2 permissions but it's an enhancement request, not a
> > "critical" bug (also not a regression).
> 
> Not sure why you would call this an enhancement.  This is a bug.  And I
> don't recall this behavior on past versions.  At some point this changed,
> and is not a desired effect.

I did not try but I think that prior to bug 11911, when you were able to create
a new suggestion, you also were able to edit it. That is why we need 2
permissions. That must be fixed on a separated bug report, it's an enhancement
request.

The "critical" bit here is that you can now access acquisition screens if you
have the acquisition.manage_suggestions permission. That must be fixed here,
it's a regression.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 13 18:22:59 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 13 Jan 2020 17:22:59 +0000
Subject: [Koha-bugs] [Bug 10532] koha-run-backups option --output doesn't
 work
In-Reply-To: <bug-10532-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-10532-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10532-70-ha8vzNn6qH@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10532

Bohdan <b.pastern4k at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |b.pastern4k at gmail.com

--- Comment #6 from Bohdan <b.pastern4k at gmail.com> ---
Still a problem on 19.05 and 19.11.
Output option does not create directories named as instances in the backup
folder. The following error occurs
ls: cannot access /path: No such file or directory 

And even after these folders are created, script still ignores everything and
simply creates files inside /var/spool/koha.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 13 18:26:12 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 13 Jan 2020 17:26:12 +0000
Subject: [Koha-bugs] [Bug 24412] Attach waiting reserve to desk
In-Reply-To: <bug-24412-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24412-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24412-70-zeNyCHt3hK@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24412

Nicolas Legrand <nicolas.legrand at bulac.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 13 18:26:15 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 13 Jan 2020 17:26:15 +0000
Subject: [Koha-bugs] [Bug 24412] Attach waiting reserve to desk
In-Reply-To: <bug-24412-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24412-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24412-70-VlWElrx2PK@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24412

--- Comment #1 from Nicolas Legrand <nicolas.legrand at bulac.fr> ---
Created attachment 97328
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97328&action=edit
Bug 24412: Schema file DO NOT PUSH!

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 13 18:26:18 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 13 Jan 2020 17:26:18 +0000
Subject: [Koha-bugs] [Bug 24412] Attach waiting reserve to desk
In-Reply-To: <bug-24412-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24412-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24412-70-0irFmOm6az@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24412

--- Comment #2 from Nicolas Legrand <nicolas.legrand at bulac.fr> ---
Created attachment 97329
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97329&action=edit
Bug 24412: kohastructure and atomic update

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 13 18:26:21 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 13 Jan 2020 17:26:21 +0000
Subject: [Koha-bugs] [Bug 24412] Attach waiting reserve to desk
In-Reply-To: <bug-24412-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24412-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24412-70-T9VJuPu49f@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24412

--- Comment #3 from Nicolas Legrand <nicolas.legrand at bulac.fr> ---
Created attachment 97330
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97330&action=edit
Bug 24412: Attach waiting reserve to desk

When an item is checked in and marked 'Waiting' or already 'Waiting'
and there is a desk attached to the session, the item is marked
waiting at the current desk of the current library.

The information is displayed on the OPAC and on the intranet. The
patron can then know at which desk he can retrieve his document.

Desk Management (Bug 13881) is now useful.

Test plan :

1. apply Bug 13881 and then Bug 24201
2. $KOHA_PATH/installer/data/mysql/updatedatabase.pl
3. Check out some document to someone
4. make another one reserve this document
5. check in the document
6. you can see the document is attach to the current library
7. create some desks and attach one to your session (see Bug 13881 and
Bug 24201)
8. cancel the preceding reserve and redo steps 3 to 5
9. you should see the document is waiting at the current library and
current desk on:
  a. the intranet document request page
  b. the intranet borrower holds tab
  c. the item list where the document is listed on the bibliographic
    details
  d. the borrower's OPAC holds tab.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 13 18:28:00 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 13 Jan 2020 17:28:00 +0000
Subject: [Koha-bugs] [Bug 24414] New: Can't add/delete funds with only
 budget_add_del permission
Message-ID: <bug-24414-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24414

            Bug ID: 24414
           Summary: Can't add/delete funds with only budget_add_del
                    permission
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Acquisitions
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: caroline.cyr-la-rose at inlibro.com
        QA Contact: testopia at bugs.koha-community.org

This is very minor, but I was trying out all the permissions to better document
them in the manual and I found something weird.

There are several permissions granting access to funds.
- budget_add_del described as 'Add and delete funds (but can't modify funds)'
- budget_manage described as 'Manage funds'
- budget_manage_all described as 'Manage all funds'
- budget_modify described as 'Modify funds (can't create lines but can modify
existing ones)'

If I only have budget_add_del, I can't create or delete funds. I have to have
budget_manage to access the funds administration page. Which is ok, I can
simply add a note in the manual that budget_add_del requires budget_manage.

If I have budget_add_del and budget_manage, I have access to the funds
administration page, but not the 'New fund' button nor the 'Actions' button to
delete an existing fund. So in reality, I can't add nor delete funds...

If I have budget_manage and budget_modify (but not budget_add_del), I can't add
new funds I can't edit existing ones, but I can delete them.

To test :
1) Create a patron and give them the catalogue permission and the
budget_add_del permission
2) Log in with this patron (I use a private window to be able to go back and
change their permissions later without logging out again)
3) Go to the Acquisitions page
4) Notice you can see the budget, but you can't click on the fund code and you
don't have the 'Funds' link in the left menu
5) Go back to edit the user's permissions and grant them budget_manage; save
6) Go back to the  Acquisition page with the limited patron (refresh if needed)
7) Notice that you can now click on the fund code and you have a 'Funds' link
on the left side of the screen
8) Click on the fund code
9) Click on 'New' and choose 'Add fund for xx'; add the new fund
10) Notice there is no 'Actions' button from which you can delete this fund
11) Go back to edit the user's permissions and remove the budget_add_del
permission and add the budget_modify; save
12) Go back to the  Acquisition page with the limited patron (refresh if
needed)
13) Click on the 'Actions' button and choose 'Edit'; the page refreshes, but
nothing happens
14) Click on the 'Actions' button and choose 'Delete' and confirm; the fund is
deleted

I have trouble imagining a situation where we would want staff to be able to
add and delete funds but not modify them, so that's why I said I think this is
minor. I think in most cases, the staff member will have at least all three
(budget_add_del, budget_manage and budget_modify). But I still wanted to record
the weirdness somewhere.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 13 19:14:58 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 13 Jan 2020 18:14:58 +0000
Subject: [Koha-bugs] [Bug 24395] Floats in cash registers have 6 decimals
In-Reply-To: <bug-24395-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24395-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24395-70-tEqJhKEgsi@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24395

Sally <sally.healey at cheshiresharedservices.gov.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |sally.healey at cheshireshared
                   |                            |services.gov.uk

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 13 19:18:33 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 13 Jan 2020 18:18:33 +0000
Subject: [Koha-bugs] [Bug 24381] ACCOUNT_CREDIT slip not printing
 information about paid fines/fees
In-Reply-To: <bug-24381-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24381-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24381-70-fKFAZvcq6M@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24381

Sally <sally.healey at cheshiresharedservices.gov.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |sally.healey at cheshireshared
                   |                            |services.gov.uk

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 13 19:20:42 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 13 Jan 2020 18:20:42 +0000
Subject: [Koha-bugs] [Bug 18731] Add routes for acquisition orders
In-Reply-To: <bug-18731-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18731-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18731-70-EmU7FBXLp7@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18731

--- Comment #48 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
(In reply to Jonathan Druart from comment #47)
> The new test is failing (randomly?)
> 
> t/db_dependent/Koha/REST/Plugin/Objects.t .. 1/3
>     #   Failed test 'exact match for JSON Pointer "/0"'
>     #   at t/db_dependent/Koha/REST/Plugin/Objects.t line 174.
>     #     Structures begin differing at:
>     #          $got->{fund}{budget_id} = '534289848'
>     #     $expected->{fund}{budget_id} = Does not exist
> 
> Koha_Master_D9_My8 run 76
> 
> It's not related to My8, I recreate locally with MariaDB latest.

I really like it when tests serve the purpose :-D

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 13 19:46:45 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 13 Jan 2020 18:46:45 +0000
Subject: [Koha-bugs] [Bug 18731] Add routes for acquisition orders
In-Reply-To: <bug-18731-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18731-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18731-70-nhjo20tb7Q@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18731

--- Comment #49 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 97331
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97331&action=edit
Bug 18731: Overload K::A::Fund->to_api to avoid conflict

This patch overloads the to_api methods on the Fund class, so
conflicting (on mapping) attribute names are not a problem.

To test:
1. Apply this patch
2. Run:
   $ kshell
  k$ prove t/db_dependent/Koha/Acquisition/Fund.t \
           t/db_dependent/Koha/REST/Plugin/Objects.t
=> SUCCESS: Tests pass!
3. Sign off :-D

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 13 19:49:13 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 13 Jan 2020 18:49:13 +0000
Subject: [Koha-bugs] [Bug 18731] Add routes for acquisition orders
In-Reply-To: <bug-18731-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18731-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18731-70-2lYXe99Qjv@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18731

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Text to go in the|                            |This development adds API
      release notes|                            |routes to perform CRUD
                   |                            |operation on acquisition
                   |                            |order lines.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 13 19:54:22 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 13 Jan 2020 18:54:22 +0000
Subject: [Koha-bugs] [Bug 17510] MARC modification templates ignore subfield
 $0
In-Reply-To: <bug-17510-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17510-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17510-70-mwXRjg8ADn@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17510

--- Comment #4 from Sarah Cornell <sbcornell at cityofportsmouth.com> ---
Confirmed still an issue in 19.05.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 13 19:54:23 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 13 Jan 2020 18:54:23 +0000
Subject: [Koha-bugs] [Bug 23194] Public notes items in the OPAC should allow
 for HTML tags
In-Reply-To: <bug-23194-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23194-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23194-70-iksEQdoxsQ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23194

Marjorie Barry-Vila <marjorie.barry-vila at collecto.ca> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |marjorie.barry-vila at collect
                   |                            |o.ca

--- Comment #18 from Marjorie Barry-Vila <marjorie.barry-vila at collecto.ca> ---
(In reply to Christopher Brannon from comment #16)
> Is there a version of this that works for the staff interface?  Links are
> just turned into static text.

Hi Christopher,

Did you file a new bug for that?

I see static text in checkout table (circ/circulation.pl)

Regards,
Marjorie

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 13 20:03:38 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 13 Jan 2020 19:03:38 +0000
Subject: [Koha-bugs] [Bug 24415] New: UX enhancement - Improve access to tabs
Message-ID: <bug-24415-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24415

            Bug ID: 24415
           Summary: UX enhancement - Improve access to tabs
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: MARC Authority data support
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: marjorie.barry-vila at collecto.ca
        QA Contact: testopia at bugs.koha-community.org

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 13 20:05:48 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 13 Jan 2020 19:05:48 +0000
Subject: [Koha-bugs] [Bug 24415] Authority enhancement - Improve access to
 tabs
In-Reply-To: <bug-24415-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24415-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24415-70-5nlUOAUFHh@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24415

Marjorie Barry-Vila <marjorie.barry-vila at collecto.ca> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|UX enhancement - Improve    |Authority enhancement -
                   |access to tabs              |Improve access to tabs
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=22045

--- Comment #1 from Marjorie Barry-Vila <marjorie.barry-vila at collecto.ca> ---
Hi,

It would be nice to have the same enhancement of 22045 for authorities module.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22045

Regards,
Marjorie

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 13 20:05:48 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 13 Jan 2020 19:05:48 +0000
Subject: [Koha-bugs] [Bug 22045] Cataloging UX enhancement - Improve access
 to tabs
In-Reply-To: <bug-22045-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22045-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22045-70-Lvz27wMtJm@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22045

Marjorie Barry-Vila <marjorie.barry-vila at collecto.ca> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=24415

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 13 20:14:10 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 13 Jan 2020 19:14:10 +0000
Subject: [Koha-bugs] [Bug 17510] MARC modification templates ignore subfield
 $0
In-Reply-To: <bug-17510-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17510-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17510-70-TWIg06Iqwy@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17510

--- Comment #5 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
(In reply to Sarah Cornell from comment #4)
> Confirmed still an issue in 19.05.

Thx, Sarah!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 13 20:15:40 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 13 Jan 2020 19:15:40 +0000
Subject: [Koha-bugs] [Bug 17984] Warn catalogers if item type doesn't match
 942c
In-Reply-To: <bug-17984-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17984-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17984-70-l7MvBxX3ut@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17984

--- Comment #3 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Actually, they often don't match by purpose in our academic libraries. There
often is one item 'for reference' with a different item type than others. This
warning should be optional then - Koha supports different itemtypes on a
record.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 13 20:48:22 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 13 Jan 2020 19:48:22 +0000
Subject: [Koha-bugs] [Bug 24366] Merging biblioitems should happen in
 Koha::Biblio->to_api
In-Reply-To: <bug-24366-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24366-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24366-70-kO2wJ0530A@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24366

--- Comment #8 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 97332
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97332&action=edit
Bug 24366: Make sure accessors are used on the right object

This patch makes the Koha::Biblio->to_api method try the accessors on
$self first, and fallback to $self->biblioitem on those he can't.

This way it won't happen that (for example) ->holds will be tried
against ->biblioitem.

To test:
1. Apply this patch
2. Run:
   $ kshell
  k$ prove t/db_dependent/Koha/Biblio.t
=> SUCCESS: Tests pass!
3. Sign off :-D

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 13 22:00:20 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 13 Jan 2020 21:00:20 +0000
Subject: [Koha-bugs] [Bug 24377] Record branch in statistics for auto-renewal
In-Reply-To: <bug-24377-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24377-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24377-70-9i1b9zkWnQ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24377

Ed Veal <eveal at mckinneytexas.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |eveal at mckinneytexas.org

--- Comment #1 from Ed Veal <eveal at mckinneytexas.org> ---
This causes significant statistical differences in circulation numbers post
upgrade. I think this is a regression and should be addressed.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 13 22:33:36 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 13 Jan 2020 21:33:36 +0000
Subject: [Koha-bugs] [Bug 15377] Remove 'checked out' items from course
 reserves
In-Reply-To: <bug-15377-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15377-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15377-70-AHhm4ULjEn@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15377

Rogan Hamby <rogan.hamby at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |rogan.hamby at gmail.com

--- Comment #2 from Rogan Hamby <rogan.hamby at gmail.com> ---
Removing the check for a circulation preventing the removal is fairly
straightforward.  Should we add a confirmation dialogue or some visual
indicator that the item is currently checked out?

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 13 22:33:49 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 13 Jan 2020 21:33:49 +0000
Subject: [Koha-bugs] [Bug 15377] Remove 'checked out' items from course
 reserves
In-Reply-To: <bug-15377-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15377-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15377-70-Tdae8JLxTl@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15377

--- Comment #3 from Rogan Hamby <rogan.hamby at gmail.com> ---
Removing the check for a circulation preventing the removal is fairly
straightforward.  Should we add a confirmation dialogue or some visual
indicator that the item is currently checked out?

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 13 22:34:13 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 13 Jan 2020 21:34:13 +0000
Subject: [Koha-bugs] [Bug 21729] When reverting a hold the expirationdate
 should be reset
In-Reply-To: <bug-21729-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21729-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21729-70-8UVECtBO2v@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21729

Peggy Thrasher <p.thrasher at dover.nh.gov> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |p.thrasher at dover.nh.gov

--- Comment #5 from Peggy Thrasher <p.thrasher at dover.nh.gov> ---
This is causing a lot of confusing in my library.  It would be great to have
this fixed.
Thanks!
Peggy - Dover Public Library NH

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 13 22:45:26 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 13 Jan 2020 21:45:26 +0000
Subject: [Koha-bugs] [Bug 21729] When reverting a hold the expirationdate
 should be reset
In-Reply-To: <bug-21729-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21729-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21729-70-NOdFAXoHKn@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21729

--- Comment #6 from Christopher Brannon <cbrannon at cdalibrary.org> ---
(In reply to Katrin Fischer from comment #4)
> Bug 21032 among others has suggested that we have a separate database field
> for the expiration date or the waiting date - I agree this is the right fix.

I agree.  There should be separate fields.  Having a double use of the same
field was a mistake, in my opinion.  These dates need to be retained
separately.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 13 23:13:42 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 13 Jan 2020 22:13:42 +0000
Subject: [Koha-bugs] [Bug 24232] Deleting a bib record after attaching the
 last item to another bib
In-Reply-To: <bug-24232-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24232-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24232-70-valAGP68Jj@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24232

Lucas Gass <lucas at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to stable            |Pushed to oldstable
                 CC|                            |lucas at bywatersolutions.com

--- Comment #22 from Lucas Gass <lucas at bywatersolutions.com> ---
backported to 19.05.x for 19.05.07

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 13 23:13:58 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 13 Jan 2020 22:13:58 +0000
Subject: [Koha-bugs] [Bug 24358] "Bibliographic record does not exist!" is
 not translatable
In-Reply-To: <bug-24358-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24358-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24358-70-fh8fcZQuVe@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24358

Lucas Gass <lucas at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to stable            |Pushed to oldstable
                 CC|                            |lucas at bywatersolutions.com

--- Comment #6 from Lucas Gass <lucas at bywatersolutions.com> ---
backported to 19.05.x for 19.05.07

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 13 23:18:24 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 13 Jan 2020 22:18:24 +0000
Subject: [Koha-bugs] [Bug 24242] Funds with no library assigned do not
 appear on edit suggestions page
In-Reply-To: <bug-24242-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24242-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24242-70-ksjFvBhBb4@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24242

Lucas Gass <lucas at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to stable            |Pushed to oldstable
                 CC|                            |lucas at bywatersolutions.com

--- Comment #7 from Lucas Gass <lucas at bywatersolutions.com> ---
backported to 19.05.x for 19.05.07

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 13 23:26:52 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 13 Jan 2020 22:26:52 +0000
Subject: [Koha-bugs] [Bug 24046] 'Activate filters' untranslatable
In-Reply-To: <bug-24046-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24046-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24046-70-RzSxAXVIpZ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24046

Lucas Gass <lucas at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to stable            |Pushed to oldstable
                 CC|                            |lucas at bywatersolutions.com

--- Comment #9 from Lucas Gass <lucas at bywatersolutions.com> ---
backported to 19.05.x for 19.05.07

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 13 23:30:54 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 13 Jan 2020 22:30:54 +0000
Subject: [Koha-bugs] [Bug 15377] Remove 'checked out' items from course
 reserves
In-Reply-To: <bug-15377-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15377-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15377-70-2hUGqFIWKY@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15377

--- Comment #4 from Hannah Olsen <holsen at duncanville.com> ---
Yes, I think some sort of indicator of checked out status would be needed.
Right now the status shows by default in the course reserve view, and it is
italicized when the item is checked out. I think that is tied to the "can't do
anything" part, but something similar could still be used to draw attention to
it?

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 13 23:36:16 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 13 Jan 2020 22:36:16 +0000
Subject: [Koha-bugs] [Bug 19465] Allow choosing Elasticsearch server on
 instance creation
In-Reply-To: <bug-19465-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19465-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19465-70-vhytOuZIhu@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19465

Lucas Gass <lucas at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |lucas at bywatersolutions.com
             Status|Pushed to stable            |Pushed to oldstable

--- Comment #14 from Lucas Gass <lucas at bywatersolutions.com> ---
backported to 19.05.x for 19.05.07

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 13 23:38:35 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 13 Jan 2020 22:38:35 +0000
Subject: [Koha-bugs] [Bug 11500] Use dateformat syspref and datepicker on
 additems.pl (and other item cataloguing pages)
In-Reply-To: <bug-11500-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-11500-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11500-70-srKNRRRo0N@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11500

Lucas Gass <lucas at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |lucas at bywatersolutions.com
             Status|Pushed to master            |Pushed to stable

--- Comment #7 from Lucas Gass <lucas at bywatersolutions.com> ---
backported to 19.11.x for 19.11.02

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 13 23:46:22 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 13 Jan 2020 22:46:22 +0000
Subject: [Koha-bugs] [Bug 11500] Use dateformat syspref and datepicker on
 additems.pl (and other item cataloguing pages)
In-Reply-To: <bug-11500-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-11500-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11500-70-JC0QESKfQA@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11500

Lucas Gass <lucas at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to stable            |Pushed to oldstable

--- Comment #8 from Lucas Gass <lucas at bywatersolutions.com> ---
backported to 19.05.x for 19.05.07

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 13 23:50:59 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 13 Jan 2020 22:50:59 +0000
Subject: [Koha-bugs] [Bug 18688] Warnings about UTF-8 charset when creating
 a new language
In-Reply-To: <bug-18688-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18688-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18688-70-G8axZTkr0Q@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18688

Lucas Gass <lucas at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to stable            |Pushed to oldstable
                 CC|                            |lucas at bywatersolutions.com

--- Comment #6 from Lucas Gass <lucas at bywatersolutions.com> ---
backported to 19.05.x for 19.05.07

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 13 23:58:13 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 13 Jan 2020 22:58:13 +0000
Subject: [Koha-bugs] [Bug 24283] Missing close parens and closing strong tag
 in course reserves
In-Reply-To: <bug-24283-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24283-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24283-70-pIsySuBVJU@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24283

Lucas Gass <lucas at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to stable            |Pushed to oldstable
                 CC|                            |lucas at bywatersolutions.com

--- Comment #5 from Lucas Gass <lucas at bywatersolutions.com> ---
backported to 19.05.x for 19.05.07

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 14 00:10:28 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 13 Jan 2020 23:10:28 +0000
Subject: [Koha-bugs] [Bug 24281] Fix the list of types of visual materials
In-Reply-To: <bug-24281-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24281-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24281-70-1lWVlGH89o@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24281

Lucas Gass <lucas at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |lucas at bywatersolutions.com
             Status|Pushed to stable            |Pushed to oldstable

--- Comment #5 from Lucas Gass <lucas at bywatersolutions.com> ---
backported to 19.05.x for 19.05.07

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 14 00:16:28 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 13 Jan 2020 23:16:28 +0000
Subject: [Koha-bugs] [Bug 24274] New installations should not contain field
 01e Coded field error (RLIN)
In-Reply-To: <bug-24274-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24274-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24274-70-jZHKZ4ua57@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24274

Lucas Gass <lucas at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to stable            |Pushed to oldstable
                 CC|                            |lucas at bywatersolutions.com

--- Comment #7 from Lucas Gass <lucas at bywatersolutions.com> ---
backported to 19.05.x for 19.05.07

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 14 00:21:53 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 13 Jan 2020 23:21:53 +0000
Subject: [Koha-bugs] [Bug 24121] Item types icons in intra search results
 are requesting icons from opac images path
In-Reply-To: <bug-24121-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24121-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24121-70-7osefJhoRs@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24121

Lucas Gass <lucas at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to stable            |Pushed to oldstable
                 CC|                            |lucas at bywatersolutions.com

--- Comment #14 from Lucas Gass <lucas at bywatersolutions.com> ---
backported to 19.05.x for 19.05.07

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 14 00:25:46 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 13 Jan 2020 23:25:46 +0000
Subject: [Koha-bugs] [Bug 24308] Suggestions table on suggestions.pl should
 have separate columns for dates
In-Reply-To: <bug-24308-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24308-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24308-70-JiwWhZrIn6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24308

Lucas Gass <lucas at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to stable            |Pushed to oldstable

--- Comment #10 from Lucas Gass <lucas at bywatersolutions.com> ---
backported to 19.05.x for 19.05.07

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 14 00:31:40 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 13 Jan 2020 23:31:40 +0000
Subject: [Koha-bugs] [Bug 24335] Cannot mark checkout notes seen/not seen in
 bulk
In-Reply-To: <bug-24335-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24335-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24335-70-2qadQsX8iI@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24335

Lucas Gass <lucas at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to stable            |Pushed to oldstable
                 CC|                            |lucas at bywatersolutions.com

--- Comment #7 from Lucas Gass <lucas at bywatersolutions.com> ---
backported to 19.05.x for 19.05.07

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 14 00:34:36 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 13 Jan 2020 23:34:36 +0000
Subject: [Koha-bugs] [Bug 24337] Checkout note cannot be marked seen if more
 than 20 exist
In-Reply-To: <bug-24337-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24337-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24337-70-APzoyi2He0@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24337

Lucas Gass <lucas at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |lucas at bywatersolutions.com
             Status|Pushed to stable            |Pushed to oldstable

--- Comment #10 from Lucas Gass <lucas at bywatersolutions.com> ---
backported to 19.05.x for 19.05.07

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 14 01:13:32 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 14 Jan 2020 00:13:32 +0000
Subject: [Koha-bugs] [Bug 24350] Can't place holds
In-Reply-To: <bug-24350-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24350-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24350-70-3Un4wo7Uol@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24350
Bug 24350 depends on bug 22284, which changed state.

Bug 22284 Summary: Groups of pickup locations for holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to master            |RESOLVED
         Resolution|---                         |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 14 01:13:31 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 14 Jan 2020 00:13:31 +0000
Subject: [Koha-bugs] [Bug 22284] Groups of pickup locations for holds
In-Reply-To: <bug-22284-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22284-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22284-70-gymCL7m5bQ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284

Joy Nelson <joy at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to master            |RESOLVED
         Resolution|---                         |FIXED
                 CC|                            |joy at bywatersolutions.com

--- Comment #291 from Joy Nelson <joy at bywatersolutions.com> ---
Not backported to 19.11.x

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 14 01:16:19 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 14 Jan 2020 00:16:19 +0000
Subject: [Koha-bugs] [Bug 24350] Can't place holds
In-Reply-To: <bug-24350-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24350-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24350-70-eODgXNOmY6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24350

Joy Nelson <joy at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
                 CC|                            |joy at bywatersolutions.com
             Status|Pushed to master            |RESOLVED

--- Comment #21 from Joy Nelson <joy at bywatersolutions.com> ---
Not backported to 19.11.x due to dependencies

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 14 01:16:19 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 14 Jan 2020 00:16:19 +0000
Subject: [Koha-bugs] [Bug 24368] Koha::Libraries->pickup_locations needs
 refactoring/ratifying
In-Reply-To: <bug-24368-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24368-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24368-70-xzSxuqIi5K@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24368
Bug 24368 depends on bug 24350, which changed state.

Bug 24350 Summary: Can't place holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24350

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to master            |RESOLVED
         Resolution|---                         |FIXED

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 14 01:17:12 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 14 Jan 2020 00:17:12 +0000
Subject: [Koha-bugs] [Bug 23354] Add a 'Pay' screen to allow anonymous
 payments in a POS fashion
In-Reply-To: <bug-23354-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23354-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23354-70-Uf6Ate2WuF@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23354

Joy Nelson <joy at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to master            |RESOLVED
         Resolution|---                         |FIXED
                 CC|                            |joy at bywatersolutions.com

--- Comment #160 from Joy Nelson <joy at bywatersolutions.com> ---
Not backported to 19.11.x

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 14 01:17:13 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 14 Jan 2020 00:17:13 +0000
Subject: [Koha-bugs] [Bug 23355] Add 'cashup' process to the accounts system
In-Reply-To: <bug-23355-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23355-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23355-70-Sq4Fi0fFXD@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23355
Bug 23355 depends on bug 23354, which changed state.

Bug 23354 Summary: Add a 'Pay' screen to allow anonymous payments in a POS fashion
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23354

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to master            |RESOLVED
         Resolution|---                         |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 14 01:21:32 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 14 Jan 2020 00:21:32 +0000
Subject: [Koha-bugs] [Bug 23956] Replace famfamfam calendar icon in staff
 client with CSS data-url
In-Reply-To: <bug-23956-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23956-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23956-70-JpTMy0Fwa4@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23956

Joy Nelson <joy at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to master            |Pushed to stable
                 CC|                            |joy at bywatersolutions.com
         Version(s)|20.05.00                    |20.05.00, 19.11.02
        released in|                            |

--- Comment #4 from Joy Nelson <joy at bywatersolutions.com> ---
Pushed to 19.11.x branch for 19.11.02

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 14 01:26:03 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 14 Jan 2020 00:26:03 +0000
Subject: [Koha-bugs] [Bug 23957] Remove button style with famfamfam icon
 background and replace with Font Awesome
In-Reply-To: <bug-23957-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23957-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23957-70-gzSOedjqIC@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23957

Joy Nelson <joy at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|20.05.00                    |20.05.00, 19.11.02
        released in|                            |
             Status|Pushed to master            |Pushed to stable
                 CC|                            |joy at bywatersolutions.com

--- Comment #11 from Joy Nelson <joy at bywatersolutions.com> ---
Pushed to 19.11.x branch for 19.11.02

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 14 01:26:55 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 14 Jan 2020 00:26:55 +0000
Subject: [Koha-bugs] [Bug 24089] Upgrade jQuery Validate plugin in the staff
 client
In-Reply-To: <bug-24089-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24089-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24089-70-gb4fUbWlv3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24089

Joy Nelson <joy at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |joy at bywatersolutions.com
             Status|Pushed to master            |RESOLVED
         Resolution|---                         |FIXED

--- Comment #5 from Joy Nelson <joy at bywatersolutions.com> ---
Not backported to 19.11.x

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 14 01:31:31 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 14 Jan 2020 00:31:31 +0000
Subject: [Koha-bugs] [Bug 23442] Add a 'refund' process to accounts
In-Reply-To: <bug-23442-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23442-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23442-70-6rBLM9ngTQ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23442

Joy Nelson <joy at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to master            |RESOLVED
         Resolution|---                         |FIXED
                 CC|                            |joy at bywatersolutions.com

--- Comment #44 from Joy Nelson <joy at bywatersolutions.com> ---
Not backported to 19.11.x

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 14 01:31:32 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 14 Jan 2020 00:31:32 +0000
Subject: [Koha-bugs] [Bug 24081] Add a 'discount' process to accounts
In-Reply-To: <bug-24081-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24081-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24081-70-bkqL6nqhxf@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24081
Bug 24081 depends on bug 23442, which changed state.

Bug 23442 Summary: Add a 'refund' process to accounts
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23442

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to master            |RESOLVED
         Resolution|---                         |FIXED

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 14 01:31:32 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 14 Jan 2020 00:31:32 +0000
Subject: [Koha-bugs] [Bug 23354] Add a 'Pay' screen to allow anonymous
 payments in a POS fashion
In-Reply-To: <bug-23354-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23354-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23354-70-A58TpAqlDx@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23354
Bug 23354 depends on bug 23442, which changed state.

Bug 23442 Summary: Add a 'refund' process to accounts
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23442

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to master            |RESOLVED
         Resolution|---                         |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 14 01:40:11 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 14 Jan 2020 00:40:11 +0000
Subject: [Koha-bugs] [Bug 24181] Make our datepicker inputs sexy
In-Reply-To: <bug-24181-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24181-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24181-70-DyBjAdxKfx@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24181

Joy Nelson <joy at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |joy at bywatersolutions.com
         Version(s)|20.05.00                    |20.05.00, 19.11.02
        released in|                            |
             Status|Pushed to master            |Pushed to stable

--- Comment #17 from Joy Nelson <joy at bywatersolutions.com> ---
Pushed to 19.11.x branch for 19.11.02

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 14 01:41:31 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 14 Jan 2020 00:41:31 +0000
Subject: [Koha-bugs] [Bug 24063] Add Sami language characters to Zebra
In-Reply-To: <bug-24063-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24063-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24063-70-DOMpHm6flM@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24063

Joy Nelson <joy at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|20.05.00                    |20.05.00, 19.11.02
        released in|                            |
                 CC|                            |joy at bywatersolutions.com
             Status|Pushed to master            |Pushed to stable

--- Comment #5 from Joy Nelson <joy at bywatersolutions.com> ---
Pushed to 19.11.x for 19.11.02

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 14 01:43:09 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 14 Jan 2020 00:43:09 +0000
Subject: [Koha-bugs] [Bug 24212] OPAC send list dialog opens too small in IE
In-Reply-To: <bug-24212-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24212-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24212-70-dBwtcE37o8@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24212

Joy Nelson <joy at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |joy at bywatersolutions.com
             Status|Pushed to master            |Pushed to stable
         Version(s)|20.05.00                    |20.05.00, 19.11.02
        released in|                            |

--- Comment #8 from Joy Nelson <joy at bywatersolutions.com> ---
Pushed to 19.11.x branch for 19.11.02

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 14 01:44:37 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 14 Jan 2020 00:44:37 +0000
Subject: [Koha-bugs] [Bug 24059] Remove unused Greybox assets from detail.tt
In-Reply-To: <bug-24059-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24059-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24059-70-nz4Z9P2hVW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24059

Joy Nelson <joy at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to master            |RESOLVED
         Resolution|---                         |FIXED
                 CC|                            |joy at bywatersolutions.com

--- Comment #6 from Joy Nelson <joy at bywatersolutions.com> ---
not backported to 19.11.x

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 14 01:44:38 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 14 Jan 2020 00:44:38 +0000
Subject: [Koha-bugs] [Bug 8290] Replace usage of Greybox modals with
 Bootstrap modals
In-Reply-To: <bug-8290-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-8290-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8290-70-zFnCJ6iL7F@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8290
Bug 8290 depends on bug 24059, which changed state.

Bug 24059 Summary: Remove unused Greybox assets from detail.tt
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24059

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to master            |RESOLVED
         Resolution|---                         |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 14 01:51:29 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 14 Jan 2020 00:51:29 +0000
Subject: [Koha-bugs] [Bug 24173] Advanced Editor: Show subtitle & published
 date on the search page
In-Reply-To: <bug-24173-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24173-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24173-70-Ph7j0WowD6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24173

Joy Nelson <joy at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |joy at bywatersolutions.com
         Version(s)|20.05.00                    |20.05.00, 19.11.02
        released in|                            |
             Status|Pushed to master            |Pushed to stable

--- Comment #6 from Joy Nelson <joy at bywatersolutions.com> ---
Pushed to 19.11.x branch for 19.11.02

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 14 01:53:11 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 14 Jan 2020 00:53:11 +0000
Subject: [Koha-bugs] [Bug 7882] Add ability to move and reorder fields in
 MARC editor
In-Reply-To: <bug-7882-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-7882-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7882-70-pegvDcgtRJ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7882

Joy Nelson <joy at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|Pushed to master            |RESOLVED
                 CC|                            |joy at bywatersolutions.com

--- Comment #66 from Joy Nelson <joy at bywatersolutions.com> ---
not backported to 19.11.x

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 14 01:56:46 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 14 Jan 2020 00:56:46 +0000
Subject: [Koha-bugs] [Bug 10469] Display more when editing subfields in
 frameworks
In-Reply-To: <bug-10469-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-10469-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10469-70-4jEA1X6ezy@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10469

Joy Nelson <joy at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |joy at bywatersolutions.com
         Version(s)|20.05.00                    |20.05.00, 19.11.02
        released in|                            |
             Status|Pushed to master            |Pushed to stable

--- Comment #8 from Joy Nelson <joy at bywatersolutions.com> ---
Pushed to 19.11.x branch for 19.11.02

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 14 01:57:11 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 14 Jan 2020 00:57:11 +0000
Subject: [Koha-bugs] [Bug 24080] Add a 'payout' process to accounts
In-Reply-To: <bug-24080-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24080-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24080-70-rQQvKv5IDT@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24080

Joy Nelson <joy at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
                 CC|                            |joy at bywatersolutions.com
             Status|Pushed to master            |RESOLVED

--- Comment #45 from Joy Nelson <joy at bywatersolutions.com> ---
not backported to 19.11.x

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 14 01:57:12 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 14 Jan 2020 00:57:12 +0000
Subject: [Koha-bugs] [Bug 24252] Add credits, debits,
 credit_offsets and debit_offsets relationships to
 Koha::Account::Line
In-Reply-To: <bug-24252-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24252-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24252-70-GDrG7RBa8J@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24252
Bug 24252 depends on bug 24080, which changed state.

Bug 24080 Summary: Add a 'payout' process to accounts
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24080

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to master            |RESOLVED
         Resolution|---                         |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 14 01:57:12 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 14 Jan 2020 00:57:12 +0000
Subject: [Koha-bugs] [Bug 24300] Add a 'payout amount' option to accounts
In-Reply-To: <bug-24300-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24300-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24300-70-7Jx34Hmuw7@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24300
Bug 24300 depends on bug 24080, which changed state.

Bug 24080 Summary: Add a 'payout' process to accounts
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24080

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to master            |RESOLVED
         Resolution|---                         |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 14 02:04:16 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 14 Jan 2020 01:04:16 +0000
Subject: [Koha-bugs] [Bug 24217] use strict for all modules
In-Reply-To: <bug-24217-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24217-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24217-70-u4MMhDJz3a@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24217

Joy Nelson <joy at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|Pushed to master            |RESOLVED
                 CC|                            |joy at bywatersolutions.com

--- Comment #12 from Joy Nelson <joy at bywatersolutions.com> ---
not backported to 19.11.x

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 14 02:04:17 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 14 Jan 2020 01:04:17 +0000
Subject: [Koha-bugs] [Bug 2505] Omnibus: Enable Perl warnings in all modules
 and scripts
In-Reply-To: <bug-2505-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-2505-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-2505-70-MvXWYDFwsw@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2505
Bug 2505 depends on bug 24217, which changed state.

Bug 24217 Summary: use strict for all modules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24217

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to master            |RESOLVED
         Resolution|---                         |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 14 02:04:17 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 14 Jan 2020 01:04:17 +0000
Subject: [Koha-bugs] [Bug 24218] We should consistently `use Modern::Perl`
 in all modules
In-Reply-To: <bug-24218-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24218-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24218-70-N5nsgqZ0bG@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24218
Bug 24218 depends on bug 24217, which changed state.

Bug 24217 Summary: use strict for all modules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24217

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to master            |RESOLVED
         Resolution|---                         |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 14 02:04:17 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 14 Jan 2020 01:04:17 +0000
Subject: [Koha-bugs] [Bug 24361] Fix warnings (or failing tests) from bug
 24217
In-Reply-To: <bug-24361-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24361-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24361-70-5DJbflS6lC@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24361
Bug 24361 depends on bug 24217, which changed state.

Bug 24217 Summary: use strict for all modules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24217

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to master            |RESOLVED
         Resolution|---                         |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 14 02:04:18 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 14 Jan 2020 01:04:18 +0000
Subject: [Koha-bugs] [Bug 24365] Using strict from TmplTokenizer.pm broke
 the translator script
In-Reply-To: <bug-24365-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24365-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24365-70-q2TP79RMaT@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24365
Bug 24365 depends on bug 24217, which changed state.

Bug 24217 Summary: use strict for all modules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24217

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to master            |RESOLVED
         Resolution|---                         |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 14 02:04:18 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 14 Jan 2020 01:04:18 +0000
Subject: [Koha-bugs] [Bug 24367] With strict enabled, Search.t is too verbose
In-Reply-To: <bug-24367-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24367-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24367-70-8Ihe2XfGoU@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24367
Bug 24367 depends on bug 24217, which changed state.

Bug 24217 Summary: use strict for all modules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24217

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to master            |RESOLVED
         Resolution|---                         |FIXED

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 14 02:04:40 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 14 Jan 2020 01:04:40 +0000
Subject: [Koha-bugs] [Bug 24361] Fix warnings (or failing tests) from bug
 24217
In-Reply-To: <bug-24361-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24361-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24361-70-F41d5pd1jg@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24361

Joy Nelson <joy at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to master            |RESOLVED
                 CC|                            |joy at bywatersolutions.com
         Resolution|---                         |FIXED

--- Comment #9 from Joy Nelson <joy at bywatersolutions.com> ---
not backported to 19.11.x

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 14 02:05:06 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 14 Jan 2020 01:05:06 +0000
Subject: [Koha-bugs] [Bug 24365] Using strict from TmplTokenizer.pm broke
 the translator script
In-Reply-To: <bug-24365-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24365-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24365-70-ov3ii6m7aE@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24365

Joy Nelson <joy at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|Pushed to master            |RESOLVED
                 CC|                            |joy at bywatersolutions.com

--- Comment #4 from Joy Nelson <joy at bywatersolutions.com> ---
not backported to 19.11.x

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 14 02:09:30 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 14 Jan 2020 01:09:30 +0000
Subject: [Koha-bugs] [Bug 24312] Update MARC21 frameworks to Updates 28+29
 (May and November 2019)
In-Reply-To: <bug-24312-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24312-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24312-70-3kpIFi4I8K@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24312

Joy Nelson <joy at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|20.05.00                    |20.05.00, 19.11.02
        released in|                            |
                 CC|                            |joy at bywatersolutions.com
             Status|Pushed to master            |Pushed to stable

--- Comment #10 from Joy Nelson <joy at bywatersolutions.com> ---
pushed to 19.11.x branch for 19.11.02

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 14 02:09:53 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 14 Jan 2020 01:09:53 +0000
Subject: [Koha-bugs] [Bug 24328] Bibliographic frameworks fail to install
In-Reply-To: <bug-24328-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24328-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24328-70-KCARYb4P8A@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24328

Joy Nelson <joy at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |joy at bywatersolutions.com
             Status|Pushed to master            |Pushed to stable
         Version(s)|20.05.00                    |20.05.00, 19.11.02
        released in|                            |

--- Comment #6 from Joy Nelson <joy at bywatersolutions.com> ---
Pushed to 19.11.x branch for 19.11.02

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 14 02:10:16 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 14 Jan 2020 01:10:16 +0000
Subject: [Koha-bugs] [Bug 24314] Update de-DE MARC21 frameworks for updates
 28+29 (May and November 2019)
In-Reply-To: <bug-24314-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24314-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24314-70-x4s3Ou4LMq@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24314

Joy Nelson <joy at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to master            |Pushed to stable
         Version(s)|20.05.00                    |20.05.00, 19.11.02
        released in|                            |
                 CC|                            |joy at bywatersolutions.com

--- Comment #11 from Joy Nelson <joy at bywatersolutions.com> ---
Pushed to 19.11.x branch for 19.11.02

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 14 02:16:34 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 14 Jan 2020 01:16:34 +0000
Subject: [Koha-bugs] [Bug 24104] Item search - dropdown buttons overflow
In-Reply-To: <bug-24104-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24104-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24104-70-ZzRxExkiQw@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24104

Joy Nelson <joy at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to master            |Pushed to stable
                 CC|                            |joy at bywatersolutions.com
         Version(s)|20.05.00                    |20.05.00, 19.11.02
        released in|                            |

--- Comment #6 from Joy Nelson <joy at bywatersolutions.com> ---
Pushed to 19.11.x branch for 19.11.02

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 14 02:18:21 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 14 Jan 2020 01:18:21 +0000
Subject: [Koha-bugs] [Bug 24054] Typo in ClaimReturnedWarningThreshold
 system preference
In-Reply-To: <bug-24054-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24054-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24054-70-V0pSbabj9h@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24054

Joy Nelson <joy at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to master            |Pushed to stable
         Version(s)|20.05.00                    |20.05.00, 19.11.02
        released in|                            |
                 CC|                            |joy at bywatersolutions.com

--- Comment #4 from Joy Nelson <joy at bywatersolutions.com> ---
Pushed to 19.11.x branch for 19.11.02

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 14 02:22:24 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 14 Jan 2020 01:22:24 +0000
Subject: [Koha-bugs] [Bug 24327] Anonymous suggestions should not be allowed
 if AnonymousPatron misconfigured
In-Reply-To: <bug-24327-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24327-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24327-70-d9lRhmLASg@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24327

Joy Nelson <joy at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to master            |Pushed to stable
                 CC|                            |joy at bywatersolutions.com
         Version(s)|20.05.00                    |20.05.00, 19.11.02
        released in|                            |

--- Comment #11 from Joy Nelson <joy at bywatersolutions.com> ---
Pushed to 19.11.x branch for 19.11.02

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 14 05:01:36 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 14 Jan 2020 04:01:36 +0000
Subject: [Koha-bugs] [Bug 21232] Problems when linking a subscription to a
 non-existing biblionumber
In-Reply-To: <bug-21232-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21232-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21232-70-NRESYg0q09@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21232

Hayley Mapley <hayleymapley at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |hayleymapley at catalyst.net.n
                   |                            |z

--- Comment #18 from Hayley Mapley <hayleymapley at catalyst.net.nz> ---
Is this a candidate to be backported to 18.11.x?

I am testing this at the moment, and each existing biblionumber I put in the
Record field I get the 'This bibliographic record does not exist' message and
and blocked from going to the next page.

Can anyone think of any reason the API call would be failing for me? I may be
missing something.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 14 07:48:47 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 14 Jan 2020 06:48:47 +0000
Subject: [Koha-bugs] [Bug 24181] Make our datepicker inputs sexy
In-Reply-To: <bug-24181-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24181-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24181-70-lBEQepOMz2@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24181

--- Comment #18 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
(In reply to Joy Nelson from comment #17)
> Pushed to 19.11.x branch for 19.11.02

Hi Joy, there is a lot of issues with this one still - I think it's not fit for
stable yet.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 14 08:15:49 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 14 Jan 2020 07:15:49 +0000
Subject: [Koha-bugs] [Bug 24349] Debit types table only shows 2 entries,
 but says there are 15
In-Reply-To: <bug-24349-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24349-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24349-70-5BJFjZsRB5@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24349

--- Comment #2 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Argh, thx Jonathan!

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 14 08:17:22 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 14 Jan 2020 07:17:22 +0000
Subject: [Koha-bugs] [Bug 24358] "Bibliographic record does not exist!" is
 not translatable
In-Reply-To: <bug-24358-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24358-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24358-70-7yj3g1QO6I@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24358

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de

--- Comment #7 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
(In reply to Lucas Gass from comment #6)
> backported to 19.05.x for 19.05.07

Hi Lucas, there as no note on the dependency bug here for 19.05 - can you
check?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 14 08:20:02 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 14 Jan 2020 07:20:02 +0000
Subject: [Koha-bugs] [Bug 24364] Display item holding library in opac issues
In-Reply-To: <bug-24364-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24364-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24364-70-qpBAV79v41@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24364

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de

--- Comment #4 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
I wonder if this should really be a per patron setting or not be using column
configuration on the table that the library can decide on? Adding this might
make it harder to convert later.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 14 08:23:02 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 14 Jan 2020 07:23:02 +0000
Subject: [Koha-bugs] [Bug 24392] Leading whitespaces in Marc fields cause
 errors
In-Reply-To: <bug-24392-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24392-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24392-70-POI3ucB825@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24392

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de

--- Comment #6 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
(In reply to Christopher Brannon from comment #5)
> (In reply to Jonathan Druart from comment #4)
> > No, edit a record, add trailing/leading whitespaces, save, edit again
> > => Whitespaces are still there.
> 
> This isn't a matter of manually adding whitespace.  I can do that.  It just
> isn't creating the same effect.  So, there is something more specific about
> the whitespace that I don't know about.

Maybe it was not whitespace but some other non-printable characters that got in
fro copy&pasting?

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 14 08:23:41 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 14 Jan 2020 07:23:41 +0000
Subject: [Koha-bugs] [Bug 24395] Floats in cash registers have 6 decimals
In-Reply-To: <bug-24395-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24395-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24395-70-SRjbgDraDU@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24395

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de

--- Comment #1 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Probably should be using the TT Price template?

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 14 08:25:33 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 14 Jan 2020 07:25:33 +0000
Subject: [Koha-bugs] [Bug 24407] AuthDisplayHierarchies ignores new nodes
 and needs protection against cyclic relations
In-Reply-To: <bug-24407-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24407-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24407-70-dm4QiMcoED@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24407

--- Comment #4 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
I am not sure - could you try my cataloging example on the other bug or tell me
if it looks right to you? Really confused by this one.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 14 08:31:59 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 14 Jan 2020 07:31:59 +0000
Subject: [Koha-bugs] [Bug 11500] Use dateformat syspref and datepicker on
 additems.pl (and other item cataloguing pages)
In-Reply-To: <bug-11500-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-11500-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11500-70-rs8IyhVXF4@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11500

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de

--- Comment #9 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
I wonder if this will not cause some trouble in late stables for the change in
the cataloging workflow.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 14 08:37:19 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 14 Jan 2020 07:37:19 +0000
Subject: [Koha-bugs] [Bug 22868] Separate Permissions for "Manage Purchase
 Suggestions" and "Enter Purchase Suggestions"
In-Reply-To: <bug-22868-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22868-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22868-70-GZlyvZAdxs@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22868

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de

--- Comment #16 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
As I am the one to blame here I can say something about previous behaviour.
Before the new permission was added, there was 'no permission' needed for
making suggestions and managing them in Koha. If you had the link to the
suggestions page, you could do it. Koha was just hiding the link to the
acquisition module from display.

So I introduced a new permission to remedy that... but that caused the problem
we see now: we have other pages that require very lax permissions (any acq
permission).

I think what Jonathan suggests, moving this out of acq will be a nice fix for
the bug. It will go back to where we were before, but we will have a permission
to turn it on and off.

Then the next step we should discuss how to split it up for editing etc.

Note: I am not a fan of splitting CRUD wise, because this means that you can
enter a suggestion with a silly typo (add), but you won't be able to fix it
(update) or delete it, if the patron no longer wants it.

I think it's better to think about use cases here. Like: allow to change
status, allow to enter acq information or similar.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 14 08:39:54 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 14 Jan 2020 07:39:54 +0000
Subject: [Koha-bugs] [Bug 22868] Separate Permissions for "Manage Purchase
 Suggestions" and "Enter Purchase Suggestions"
In-Reply-To: <bug-22868-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22868-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22868-70-EI5yXMB8RV@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22868

--- Comment #17 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Note: moving it out of acq will also make it way easier to add those
sub-permissions!

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 14 09:22:20 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 14 Jan 2020 08:22:20 +0000
Subject: [Koha-bugs] [Bug 20567] "Holds per record (count)" limit is not
 enforced after item is captured for hold
In-Reply-To: <bug-20567-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20567-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20567-70-F1teEN6wxb@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20567

--- Comment #4 from Hans Pålsson <hans.palsson at hkr.se> ---
(In reply to Jonathan Druart from comment #2)
> C4/Circulation.pm, in CanItemBeReserved:
>  394             found          => undef, # Found holds don't count against
> a patron's holds limit

I think it is C4/Reserves.pm.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 14 09:33:50 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 14 Jan 2020 08:33:50 +0000
Subject: [Koha-bugs] [Bug 21232] Problems when linking a subscription to a
 non-existing biblionumber
In-Reply-To: <bug-21232-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21232-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21232-70-DcyBEEjJjm@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21232

--- Comment #19 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
(In reply to Hayley Mapley from comment #18)
> Is this a candidate to be backported to 18.11.x?
> 
> I am testing this at the moment, and each existing biblionumber I put in the
> Record field I get the 'This bibliographic record does not exist' message
> and and blocked from going to the next page.
> 
> Can anyone think of any reason the API call would be failing for me? I may
> be missing something.

Hi Hayley, the API routes for biblios do not exist in 18.11 (added by bug
23677).

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 14 10:07:46 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 14 Jan 2020 09:07:46 +0000
Subject: [Koha-bugs] [Bug 22868] Separate Permissions for "Manage Purchase
 Suggestions" and "Enter Purchase Suggestions"
In-Reply-To: <bug-22868-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22868-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22868-70-UUjNX08Y30@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22868

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |jonathan.druart at bugs.koha-c
                   |ity.org                     |ommunity.org
             Status|NEW                         |ASSIGNED

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 14 10:12:39 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 14 Jan 2020 09:12:39 +0000
Subject: [Koha-bugs] [Bug 22868] Separate Permissions for "Manage Purchase
 Suggestions" and "Enter Purchase Suggestions"
In-Reply-To: <bug-22868-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22868-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22868-70-C6zo4NUWyc@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22868

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 14 10:12:42 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 14 Jan 2020 09:12:42 +0000
Subject: [Koha-bugs] [Bug 22868] Separate Permissions for "Manage Purchase
 Suggestions" and "Enter Purchase Suggestions"
In-Reply-To: <bug-22868-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22868-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22868-70-VYiqqEeZ8Q@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22868

--- Comment #18 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 97334
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97334&action=edit
Bug 22868: Move suggestions_manage subperm out of acquisition perm

Bug 11911 replaced the permission of suggestions.pl (create a purchase
suggestion) from catalogue => 1 to acquisition => 'suggestions_manage'.
However we have a lot of acquisition scripts that have lax permissions
(acquisition => '*' which means any sub permissions of acquisition is
enough).

That causes problem when a circulation staff can create purchase
suggestions but not access acquisition information.

One solution is to move the suggestions_manage subpermission out of the
acquisition permission and create a new suggestion permission.

Test plan:
0. Setup
* Create a patron with several permission (and full acquisition
permission)
* Create another patron with several permission, and suggestions_manage
permission
* Create another patron without the suggestions_manage permission
1. Apply the patch and execute the update database entry
2. Note that the third patron you create still does not have
suggestions_manage
3. Confirm that you can create a purchase suggestion if you have
suggestions_manage, but cannot access acquisition pages if you do not
have any subpermissions of the acquisition permission

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 14 10:13:28 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 14 Jan 2020 09:13:28 +0000
Subject: [Koha-bugs] [Bug 19793] Add a field for email in batch patron
 modification
In-Reply-To: <bug-19793-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19793-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19793-70-cAtlC6EhY2@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19793

--- Comment #9 from David Roberts <david.roberts at ptfs-europe.com> ---
Created attachment 97335
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97335&action=edit
Bug 19793 - Add a field for email in batch patron modification

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 14 10:16:49 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 14 Jan 2020 09:16:49 +0000
Subject: [Koha-bugs] [Bug 22868] Circulation staff can with
 suggestions_manage can have access to acquisition data
In-Reply-To: <bug-22868-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22868-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22868-70-QUUELYiwuB@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22868

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Separate Permissions for    |Circulation staff can with
                   |"Manage Purchase            |suggestions_manage can have
                   |Suggestions" and "Enter     |access to acquisition data
                   |Purchase Suggestions"       |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 14 10:16:57 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 14 Jan 2020 09:16:57 +0000
Subject: [Koha-bugs] [Bug 22868] Circulation staff with suggestions_manage
 can have access to acquisition data
In-Reply-To: <bug-22868-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22868-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22868-70-BGNXGoEChp@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22868

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Circulation staff can with  |Circulation staff with
                   |suggestions_manage can have |suggestions_manage can have
                   |access to acquisition data  |access to acquisition data

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 14 10:18:52 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 14 Jan 2020 09:18:52 +0000
Subject: [Koha-bugs] [Bug 24146] Paying Accruing Fines prior to return
 causes another accruing fine when returned
In-Reply-To: <bug-24146-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24146-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24146-70-VLvOWGRPff@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24146

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|rel_20_05_target            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 14 10:24:58 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 14 Jan 2020 09:24:58 +0000
Subject: [Koha-bugs] [Bug 18731] Add routes for acquisition orders
In-Reply-To: <bug-18731-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18731-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18731-70-nd8bLumAkk@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18731

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|additional_work_needed      |

--- Comment #50 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Followup pushed, thanks Tomas

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 14 10:25:11 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 14 Jan 2020 09:25:11 +0000
Subject: [Koha-bugs] [Bug 18731] Add routes for acquisition orders
In-Reply-To: <bug-18731-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18731-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18731-70-neaiS9OO2o@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18731

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|release-notes-needed        |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 14 10:25:57 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 14 Jan 2020 09:25:57 +0000
Subject: [Koha-bugs] [Bug 20567] "Holds per record (count)" limit is not
 enforced after item is captured for hold
In-Reply-To: <bug-20567-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20567-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20567-70-I7khU1Tycq@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20567

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de

--- Comment #5 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
I understand why you would NOT want to count the waiting holds, but I wonder if
we are missing a use case here if we change that too quickly. 

Maybe we coudl compare to how other hold counts, like the daily limit, work
here?

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 14 10:36:13 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 14 Jan 2020 09:36:13 +0000
Subject: [Koha-bugs] [Bug 20567] "Holds per record (count)" limit is not
 enforced after item is captured for hold
In-Reply-To: <bug-20567-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20567-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20567-70-cGllqImyvu@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20567

--- Comment #6 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 97336
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97336&action=edit
Bug 20567: Add tests

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 14 10:36:17 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 14 Jan 2020 09:36:17 +0000
Subject: [Koha-bugs] [Bug 20567] "Holds per record (count)" limit is not
 enforced after item is captured for hold
In-Reply-To: <bug-20567-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20567-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20567-70-OfestQREoJ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20567

--- Comment #7 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 97337
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97337&action=edit
Bug 20567: Count found holds for holds limit

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 14 10:38:02 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 14 Jan 2020 09:38:02 +0000
Subject: [Koha-bugs] [Bug 20567] "Holds per record (count)" limit is not
 enforced after item is captured for hold
In-Reply-To: <bug-20567-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20567-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20567-70-LjMRnjbyKv@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20567

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |kyle at bywatersolutions.com

--- Comment #8 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Same as Katrin here, I submitted a patch that should modify the behavior as you
expect, but I am not sure it's correct (side effects).
That would be good to get Kyle's opinion on this, as he wrote that bit of code
(the comment on the line I remove especially).

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 14 10:42:48 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 14 Jan 2020 09:42:48 +0000
Subject: [Koha-bugs] [Bug 23261] RecordedBooks - notify patron of need to
 login / register to see availability
In-Reply-To: <bug-23261-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23261-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23261-70-gjNLqTAwL8@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23261

--- Comment #11 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
(In reply to Joy Nelson from comment #10)
> Pushed to 19.11.x branch for 19.11.02

Hi Joy, there was a RM follow-up that was not attach to this bug report:
  commit 42d40e372e25cc4790290dcd0bb31c50f237f5fe
  Bug 23261: (RM follow-up) Add missing uri filter
It will fix the failure for xt/find-missing-filters.t on 19.11

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 14 10:47:36 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 14 Jan 2020 09:47:36 +0000
Subject: [Koha-bugs] [Bug 24417] New: Charges/Fees.t is failing randomly
Message-ID: <bug-24417-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24417

            Bug ID: 24417
           Summary: Charges/Fees.t is failing randomly
 Change sponsored?: ---
           Product: Koha
           Version: unspecified
          Hardware: All
                OS: All
            Status: NEW
          Severity: minor
          Priority: P5 - low
         Component: Test Suite
          Assignee: chris at bigballofwax.co.nz
          Reporter: jonathan.druart at bugs.koha-community.org
        QA Contact: testopia at bugs.koha-community.org

I cannot recreate locally, but Jenkins has a failing test on Koha_19.11_U18,
run 29:

koha_1       |     #   Failed test 'Daily rental charge calculated correctly
with finesCalendar = noFinesWhenClosed and closed Monday'
koha_1       |     #   at t/db_dependent/Koha/Charges/Fees.t line 362.
koha_1       |     #          got: '6'
koha_1       |     #     expected: '5'
koha_1       | 
koha_1       |     #   Failed test 'Hourly rental charge calculated correctly
with finesCalendar = noFinesWhenClosed and closed Monday (96h - 24h * 0.25u)'
koha_1       |     #   at t/db_dependent/Koha/Charges/Fees.t line 396.
koha_1       |     #          got: '24'
koha_1       |     #     expected: '18'
koha_1       |     # Looks like you failed 2 tests of 7.
koha_1       | 
koha_1       | #   Failed test 'accumulate_rentalcharge tests'
koha_1       | #   at t/db_dependent/Koha/Charges/Fees.t line 403.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 14 10:49:05 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 14 Jan 2020 09:49:05 +0000
Subject: [Koha-bugs] [Bug 20086] AddRenewal is not executed as a transaction
 and can results in partial success and doubled fines
In-Reply-To: <bug-20086-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20086-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20086-70-Ce6j4AhJ2h@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20086

Maria <mbugz2 at yahoo.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mbugz2 at yahoo.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 14 10:51:09 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 14 Jan 2020 09:51:09 +0000
Subject: [Koha-bugs] [Bug 20086] AddRenewal is not executed as a transaction
 and can results in partial success and doubled fines
In-Reply-To: <bug-20086-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20086-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20086-70-ErkV57iJon@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20086

Björn Nylén <bjorn.nylen at ub.lu.se> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |bjorn.nylen at ub.lu.se

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 14 11:09:53 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 14 Jan 2020 10:09:53 +0000
Subject: [Koha-bugs] [Bug 21946] Group circulation by item type
In-Reply-To: <bug-21946-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21946-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21946-70-pmzp2MEM67@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21946

--- Comment #90 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Looks like this dev will conflict with bug 15522.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 14 11:12:21 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 14 Jan 2020 10:12:21 +0000
Subject: [Koha-bugs] [Bug 24364] Display item holding library in opac issues
In-Reply-To: <bug-24364-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24364-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24364-70-aKKKQ18pQx@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24364

--- Comment #5 from Matthias Meusburger <matthias.meusburger at biblibre.com> ---
This development uses SHOW_LIB in the same manner that Bug 4157 uses
SHOW_BCODE.

So I think SHOW_LIB should be added in patron_attributes.sql and
patron_attributes.txt but not in installer.sql
What is your opinion on this Jonathan ?

Katrin, I made this dev in a way that is consistant with a similar setting,
that is SHOW_BCODE from Bug 4157, but I'm open-minded about how it should be
configured.
When you say "[..] using column configuration on the table", can you be more
explicit? What are you exactly referring to? Are there other settings already
using what you are referring to?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 14 11:15:39 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 14 Jan 2020 10:15:39 +0000
Subject: [Koha-bugs] [Bug 19793] Add a field for email in batch patron
 modification
In-Reply-To: <bug-19793-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19793-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19793-70-pMTBc3Qqk0@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19793

David Roberts <david.roberts at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

--- Comment #10 from David Roberts <david.roberts at ptfs-europe.com> ---
To test:

1) Install patch
2) Open Batch Patron Modification tool, and input a borrowernumber to edit
3) Add some data (e.g. test at foobar.com) into the Email address field, and click
Save
4) The Primary Email address in the user record should now contain your email
address
5) Test that running the tool again with the option to delete the data clears
the field correctly
6) Repeat steps 1-5 with a file of user borrowernumbers

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 14 11:16:27 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 14 Jan 2020 10:16:27 +0000
Subject: [Koha-bugs] [Bug 24275] Inventory table should be sortable by title
 without leading articles (allow for title sort with anti-the)
In-Reply-To: <bug-24275-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24275-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24275-70-F0qa4Vtvzk@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24275

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 14 11:16:30 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 14 Jan 2020 10:16:30 +0000
Subject: [Koha-bugs] [Bug 24275] Inventory table should be sortable by title
 without leading articles (allow for title sort with anti-the)
In-Reply-To: <bug-24275-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24275-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24275-70-MAexCAdfeC@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24275

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #96890|0                           |1
        is obsolete|                            |

--- Comment #4 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 97338
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97338&action=edit
Bug 24275: Apply anti-the to title column in inventory table

To test:
1 - Go to Tools->Inventory
2 - Click submit (or add options to get a subset of titles)
3 - Try sorting by title, note that titles with leading articles sort including
the articles
4 - Apply patch
5 - Reload the page
6 - Note that leading articles are ignored for sorting

Signed-off-by: Deb <dstephen at dubuque.lib.ia.us>

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 14 11:19:39 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 14 Jan 2020 10:19:39 +0000
Subject: [Koha-bugs] [Bug 20567] "Holds per record (count)" limit is not
 enforced after item is captured for hold
In-Reply-To: <bug-20567-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20567-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20567-70-HghmepqGfS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20567

--- Comment #9 from Hans Pålsson <hans.palsson at hkr.se> ---
The problem is on item level more than on biblio level. If a library only
allows 1 item to be reserved per biblio, then the current code creates the
loophole. That is the problem we have and the same as reported in this bug.
If the amount of holds placed should count towards a patrons total amount of
holds placed on different biblios, then the current code makes sense. I
think...

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 14 11:26:36 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 14 Jan 2020 10:26:36 +0000
Subject: [Koha-bugs] [Bug 22831] Elasticsearch - add a maintenance script
 for checking DB vs index counts
In-Reply-To: <bug-22831-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22831-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22831-70-CDHfEVfGP1@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22831

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 14 11:26:39 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 14 Jan 2020 10:26:39 +0000
Subject: [Koha-bugs] [Bug 22831] Elasticsearch - add a maintenance script
 for checking DB vs index counts
In-Reply-To: <bug-22831-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22831-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22831-70-iouQcHop51@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22831

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #96804|0                           |1
        is obsolete|                            |

--- Comment #22 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 97339
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97339&action=edit
Bug 22831: Elasticsearch - add a maintenance script for checking DB vs index
counts

This script uses Array::Utils and adds a dependency

To test:
 1 - Have Koha with ES running
 2 - Delete some records from ES
     curl -X DELETE "es:9200/koha_kohadev_biblios/data/5"
     curl -X DELETE "es:9200/koha_kohadev_authorities/data/5"
 3 - perl misc/maintenance/compare_es_to_db.pl
 4 - Note you are notified of problems in both indexes
 5 - perl misc/search_tools/rebuild_elastic_search.pl  -a
 6 - perl misc/maintenance/compare_es_to_db.pl
 7 - Note you are only notified about problems in biblios (assuming you don't
have other issues)
 8 - perl misc/search_tools/rebuild_elasticsearch.pl  -b
 9 - perl misc/maintenance/compare_es_to_db.pl
10 - Both counts match, no problems

Signed-off-by: Ere Maijala <ere.maijala at helsinki.fi>
Signed-off-by: Bouzid Fergani <bouzid.fergani at inlibro.com>

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 14 11:26:44 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 14 Jan 2020 10:26:44 +0000
Subject: [Koha-bugs] [Bug 22831] Elasticsearch - add a maintenance script
 for checking DB vs index counts
In-Reply-To: <bug-22831-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22831-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22831-70-9mvDzClitN@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22831

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #96805|0                           |1
        is obsolete|                            |

--- Comment #23 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 97340
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97340&action=edit
Bug 22831: (follow-up) Determine where the record is missing and provide link,
show counter

Signed-off-by: Ere Maijala <ere.maijala at helsinki.fi>
Signed-off-by: Bouzid Fergani <bouzid.fergani at inlibro.com>

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 14 11:26:47 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 14 Jan 2020 10:26:47 +0000
Subject: [Koha-bugs] [Bug 22831] Elasticsearch - add a maintenance script
 for checking DB vs index counts
In-Reply-To: <bug-22831-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22831-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22831-70-URBdF4vYUh@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22831

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #96806|0                           |1
        is obsolete|                            |

--- Comment #24 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 97341
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97341&action=edit
Bug 22831: (follow-up) Sort results, group by db

Signed-off-by: Bouzid Fergani <bouzid.fergani at inlibro.com>

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 14 11:27:23 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 14 Jan 2020 10:27:23 +0000
Subject: [Koha-bugs] [Bug 22831] Elasticsearch - add a maintenance script
 for checking DB vs index counts
In-Reply-To: <bug-22831-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22831-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22831-70-IBTGdQLSLH@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22831

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         QA Contact|tomascohen at gmail.com        |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org

--- Comment #25 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
I would have preferred to not add the new deps, but not blocker.

Thanks for the follow-up Nick!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 14 11:28:52 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 14 Jan 2020 10:28:52 +0000
Subject: [Koha-bugs] [Bug 22828] Elasticsearch - display errors encountered
 during indexing on the command line
In-Reply-To: <bug-22828-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22828-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22828-70-NPCP7CyWDF@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22828

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org
           Assignee|koha-bugs at lists.koha-commun |nick at bywatersolutions.com
                   |ity.org                     |

--- Comment #9 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Do we really want to continue without adding tests?

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 14 11:29:58 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 14 Jan 2020 10:29:58 +0000
Subject: [Koha-bugs] [Bug 24364] Display item holding library in opac issues
In-Reply-To: <bug-24364-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24364-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24364-70-gC3gdw9pOE@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24364

--- Comment #6 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
(In reply to Matthias Meusburger from comment #5)
> This development uses SHOW_LIB in the same manner that Bug 4157 uses
> SHOW_BCODE.
> 
> So I think SHOW_LIB should be added in patron_attributes.sql and
> patron_attributes.txt but not in installer.sql
> What is your opinion on this Jonathan ?
> 
> Katrin, I made this dev in a way that is consistant with a similar setting,
> that is SHOW_BCODE from Bug 4157, but I'm open-minded about how it should be
> configured.
> When you say "[..] using column configuration on the table", can you be more
> explicit? What are you exactly referring to? Are there other settings
> already using what you are referring to?

Hi Matthias, I know about SHOW_BCODE, but always get the impression that it's
confusing to people and not so helpful. For example you can't really set a
default for patron attributes, so you'd have to turn it on for every single
one, if a library wants this as a general default. I don't think putting it on
the patron is ideal and they won't expect it on the details page. When
SHOW_BCODE was added, it was not even possible yet for a patron to change these
settings in the OPAC. It feels like these features are not well suited to work
on top of the patron attributes system. It feels a bit hacky.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 14 11:37:01 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 14 Jan 2020 10:37:01 +0000
Subject: [Koha-bugs] [Bug 22828] Elasticsearch - display errors encountered
 during indexing on the command line
In-Reply-To: <bug-22828-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22828-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22828-70-7qbu8lRDYA@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22828

--- Comment #10 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
(In reply to Nick Clemens from comment #0)
> Currently any records that do not index simply fail silently
> 
> To recreate:
> 1 - Use the Koha sample data, or insert a blank 245$b into a record (easiest
> way is using advanced cataloging editor
> 2 - Reindex elasticsearch
> 3 - Check the ES count on the about page
> 4 - Check the count in the DB (SELECT count(*) FROM biblio)
> 5 - They don't match!

They match for me. Which record is supposed to be wrong in the sample data?
I added a blank 245$b but the reindex is ok.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 14 11:42:22 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 14 Jan 2020 10:42:22 +0000
Subject: [Koha-bugs] [Bug 24364] Display item holding library in opac issues
In-Reply-To: <bug-24364-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24364-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24364-70-FZCM0CvxlY@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24364

--- Comment #7 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
As we have bug 18348, I think Katrin is correct.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 14 11:49:48 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 14 Jan 2020 10:49:48 +0000
Subject: [Koha-bugs] [Bug 22284] Groups of pickup locations for holds
In-Reply-To: <bug-22284-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22284-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22284-70-NuvnpmzYB6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284

--- Comment #292 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
We still have failing tests related to these patches:

t/db_dependent/Koha/Libraries.t .. 1/9             # Looks like you planned 11
tests but ran 2.

        #   Failed test 'Given BranchTransferLimitsType = itemtype and
item-level_itypes = ON'
        #   at t/db_dependent/Koha/Libraries.t line 258.
        # Looks like you planned 4 tests but ran 2.
        # Looks like you failed 1 test of 2 run.

    #   Failed test 'UseBranchTransferLimits = ON'
    #   at t/db_dependent/Koha/Libraries.t line 422.
    # Looks like you failed 1 test of 2.
t/db_dependent/Koha/Libraries.t .. 6/9 
#   Failed test 'pickup_locations'
#   at t/db_dependent/Koha/Libraries.t line 423.
Can't call method "branchcode" on unblessed reference at
t/db_dependent/Koha/Libraries.t line 195.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 14 11:52:03 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 14 Jan 2020 10:52:03 +0000
Subject: [Koha-bugs] [Bug 18348] SHOW_BCODE should be a column of the
 borrowers table
In-Reply-To: <bug-18348-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18348-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18348-70-qcKTiYwjCX@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18348

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de

--- Comment #1 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Or maybe it should be deprecated in favor of settings on the category type or a
column configuration setting? Not sure hwo granular display stuff like this
needs to be.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 14 12:07:24 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 14 Jan 2020 11:07:24 +0000
Subject: [Koha-bugs] [Bug 22284] Groups of pickup locations for holds
In-Reply-To: <bug-22284-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22284-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22284-70-I1A2B5DoCo@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284

--- Comment #293 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
(In reply to Jonathan Druart from comment #292)
> We still have failing tests related to these patches:
> 
> t/db_dependent/Koha/Libraries.t .. 1/9             # Looks like you planned
> 11 tests but ran 2.
> 
>         #   Failed test 'Given BranchTransferLimitsType = itemtype and
> item-level_itypes = ON'
>         #   at t/db_dependent/Koha/Libraries.t line 258.
>         # Looks like you planned 4 tests but ran 2.
>         # Looks like you failed 1 test of 2 run.
> 
>     #   Failed test 'UseBranchTransferLimits = ON'
>     #   at t/db_dependent/Koha/Libraries.t line 422.
>     # Looks like you failed 1 test of 2.
> t/db_dependent/Koha/Libraries.t .. 6/9 
> #   Failed test 'pickup_locations'
> #   at t/db_dependent/Koha/Libraries.t line 423.
> Can't call method "branchcode" on unblessed reference at
> t/db_dependent/Koha/Libraries.t line 195.

I'll be working on it this morning

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 14 12:11:04 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 14 Jan 2020 11:11:04 +0000
Subject: [Koha-bugs] [Bug 20567] "Holds per record (count)" limit is not
 enforced after item is captured for hold
In-Reply-To: <bug-20567-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20567-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20567-70-8CwhJZ9ymM@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20567

--- Comment #10 from Kyle M Hall <kyle at bywatersolutions.com> ---
(In reply to Jonathan Druart from comment #8)
> Same as Katrin here, I submitted a patch that should modify the behavior as
> you expect, but I am not sure it's correct (side effects).
> That would be good to get Kyle's opinion on this, as he wrote that bit of
> code (the comment on the line I remove especially).

I'm researching the issue to see if the original development funder(s) had this
behavior as a requirement or not. In any case it would be trivial to syspref
this to satisfy both those who want the existing behavior and those who do not.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 14 12:13:54 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 14 Jan 2020 11:13:54 +0000
Subject: [Koha-bugs] [Bug 20847] Add more fields to the Batch Patron
 Modification tool
In-Reply-To: <bug-20847-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20847-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20847-70-VSiGrHQO7e@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20847

David Roberts <david.roberts at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |david.roberts at ptfs-europe.c
                   |ity.org                     |om
                 CC|                            |david.roberts at ptfs-europe.c
                   |                            |om

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 14 12:17:06 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 14 Jan 2020 11:17:06 +0000
Subject: [Koha-bugs] [Bug 24381] ACCOUNT_CREDIT slip not printing
 information about paid fines/fees
In-Reply-To: <bug-24381-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24381-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24381-70-7MZjYiZuiQ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24381

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org

--- Comment #3 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
I do not understand, can you explain a bit more please? Or maybe attach a
screenshot?

I see the Print button for each line, the letter displays only 1 line. Do you
expect all the lines to be displayed? In that case the button should be moved
somewhere else?

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 14 12:41:30 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 14 Jan 2020 11:41:30 +0000
Subject: [Koha-bugs] [Bug 23443] Paying off a lost fee will return the item,
 even if it is checked out to a different patron
In-Reply-To: <bug-23443-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23443-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23443-70-apKVhzzBei@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23443

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 14 12:41:33 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 14 Jan 2020 11:41:33 +0000
Subject: [Koha-bugs] [Bug 23443] Paying off a lost fee will return the item,
 even if it is checked out to a different patron
In-Reply-To: <bug-23443-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23443-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23443-70-G901D9mWLJ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23443

--- Comment #3 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 97342
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97342&action=edit
Bug 23443: Add tests

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 14 12:41:36 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 14 Jan 2020 11:41:36 +0000
Subject: [Koha-bugs] [Bug 23443] Paying off a lost fee will return the item,
 even if it is checked out to a different patron
In-Reply-To: <bug-23443-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23443-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23443-70-xyIfRQrcIO@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23443

--- Comment #4 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 97343
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97343&action=edit
Bug 23443: Do not checkin an item if checked out to another patron when lost
fee is paid

Test plan:
0 - Do not apply this patch
1 - Check out an item to a patron
2 - Make sure a fee will be charged when lost
3 - Mark the item lost
4 - Make sure the fee will not be refunded on return of the item
5 - Return the item
6 - Check it out to a new patron
7 - Write off the fine for the original patron
=> The item is now checked in
8 - Apply this patch and repeat 1 to 7
=> The item is still checked out

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 14 12:41:57 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 14 Jan 2020 11:41:57 +0000
Subject: [Koha-bugs] [Bug 23443] Paying off a lost fee will return the item,
 even if it is checked out to a different patron
In-Reply-To: <bug-23443-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23443-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23443-70-ecHlU1sreD@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23443

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |jonathan.druart at bugs.koha-c
                   |ity.org                     |ommunity.org
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 14 12:44:50 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 14 Jan 2020 11:44:50 +0000
Subject: [Koha-bugs] [Bug 20443] Move C4::Members::Attributes to Koha
 namespace
In-Reply-To: <bug-20443-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20443-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20443-70-7WWm8TrFTi@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20443

--- Comment #18 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Remote branch rebased against master.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 14 12:48:20 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 14 Jan 2020 11:48:20 +0000
Subject: [Koha-bugs] [Bug 24381] ACCOUNT_CREDIT slip not printing
 information about paid fines/fees
In-Reply-To: <bug-24381-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24381-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24381-70-2KUHQZXBgx@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24381

--- Comment #4 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
It might get clearer if we start with the payment receipts printed from a
'payment' line.

At the moment, it will have:

- a table with the column heading: Description of charges
- Below always 1 line only with "Payment"
- And of course... there is not much to total

What I think we should have, and we can already see this in the 'details' for
the payment and in the sample notice for PAYMENT notices:

- a table with the column heading: Description of charges
- A list of the fines the payment paid off, so something like:
  - Rental fee X
  - Fine for ...
- The total of the payment

I've tried to use the TT syntax from the payment emails, but couldn't get it to
work.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 14 12:54:38 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 14 Jan 2020 11:54:38 +0000
Subject: [Koha-bugs] [Bug 23493] jquery.dataTables.rowGrouping.js is no
 longer maintained,
 but there is an official DataTables version we could switch to
In-Reply-To: <bug-23493-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23493-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23493-70-Be4nSnje6J@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23493

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #97324|0                           |1
        is obsolete|                            |

--- Comment #7 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 97344
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97344&action=edit
Bug 23493: Replace rowGrouping with rowGroup

This is an initial attempt to get some feedback.

Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 14 12:56:32 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 14 Jan 2020 11:56:32 +0000
Subject: [Koha-bugs] [Bug 23493] jquery.dataTables.rowGrouping.js is no
 longer maintained,
 but there is an official DataTables version we could switch to
In-Reply-To: <bug-23493-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23493-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23493-70-2VhZFZWvHk@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23493

--- Comment #8 from Kyle M Hall <kyle at bywatersolutions.com> ---
Looks great to me! I also find the styling to be a bit improved.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 14 12:56:48 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 14 Jan 2020 11:56:48 +0000
Subject: [Koha-bugs] [Bug 24043] ILL module can't show requests from more
 than one backend
In-Reply-To: <bug-24043-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24043-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24043-70-s2Idz7GODt@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24043

--- Comment #10 from Magnus Enger <magnus at libriotech.no> ---
(In reply to Andrew Isherwood from comment #9)
> Note: Despite this bug being originally reported on 18.11, it exists in
> master, this patch was created on master

Hm, I can't seem to be able to reproduce this any longer, on master. Are you
sure you have all the steps necessary to reproduce? It might be a problem with
e.g. my data, from earlier testing, though.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 14 13:07:46 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 14 Jan 2020 12:07:46 +0000
Subject: [Koha-bugs] [Bug 21156] Internationalization: plural forms, context,
 and more for JS files
In-Reply-To: <bug-21156-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21156-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21156-70-8Lyi9hsJ7W@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21156

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #91976|0                           |1
        is obsolete|                            |

--- Comment #6 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 97345
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97345&action=edit
Bug 21156: Add plural translation capabilities to JS files

It adds Javascript equivalent of Koha::I18N's exported subroutines, and
they are used the same way.

String extraction is done only on *.js files and require gettext 0.19
(available in Debian jessie, and also in wheezy-backports)

It adds Javascript library Gettext.js for handling translation and a
Perl script po2json to transform PO file into JSON.

Gettext.js and po2json both come from Locale::Simple.
There are several tools named po2json. It's simpler to integrate this
one into Koha than to check if the good one is installed on the system.
Locale::Simple is not needed.

To avoid polluting the global namespace too much, this patch also
introduce a global JS object named Koha and add some stuff in Koha.i18n

Test plan:
1. Add a translatable string in a JS file. For example, add this:
     alert(__nx("There is one item", "There are {count} items", 3,
     {count: 3}));
   to staff-global.js
2. cd misc/translator && ./translate update fr-FR
3. Open misc/translator/po/fr-FR-messages-js.po, verify that your
   string is present, and translate it
4. cd misc/translator && ./translate install fr-FR
5. (Optional) Verify that
   koha-tmpl/intranet-tmpl/prog/fr-FR/js/locale_data.js exists and
   contains your translation
6. Open your browser on the staff main page, change language and verify
   that the message is translated
7. Repeat 1-6 on OPAC side

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 14 13:08:46 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 14 Jan 2020 12:08:46 +0000
Subject: [Koha-bugs] [Bug 21156] Internationalization: plural forms, context,
 and more for JS files
In-Reply-To: <bug-21156-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21156-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21156-70-AS7UFMMSmG@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21156

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org

--- Comment #7 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Last rebase (from comment 4) contains a wrong conflict resolution.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 14 13:16:38 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 14 Jan 2020 12:16:38 +0000
Subject: [Koha-bugs] [Bug 21156] Internationalization: plural forms, context,
 and more for JS files
In-Reply-To: <bug-21156-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21156-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21156-70-3Xr5pUbXS7@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21156

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #97345|0                           |1
        is obsolete|                            |

--- Comment #8 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 97346
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97346&action=edit
Bug 21156: Add plural translation capabilities to JS files

It adds Javascript equivalent of Koha::I18N's exported subroutines, and
they are used the same way.

String extraction is done only on *.js files and require gettext 0.19
(available in Debian jessie, and also in wheezy-backports)

It adds Javascript library Gettext.js for handling translation and a
Perl script po2json to transform PO file into JSON.

Gettext.js and po2json both come from Locale::Simple.
There are several tools named po2json. It's simpler to integrate this
one into Koha than to check if the good one is installed on the system.
Locale::Simple is not needed.

To avoid polluting the global namespace too much, this patch also
introduce a global JS object named Koha and add some stuff in Koha.i18n

Test plan:
1. Add a translatable string in a JS file. For example, add this:
     alert(__nx("There is one item", "There are {count} items", 3,
     {count: 3}));
   to staff-global.js
2. cd misc/translator && ./translate update fr-FR
3. Open misc/translator/po/fr-FR-messages-js.po, verify that your
   string is present, and translate it
4. cd misc/translator && ./translate install fr-FR
5. (Optional) Verify that
   koha-tmpl/intranet-tmpl/prog/fr-FR/js/locale_data.js exists and
   contains your translation
6. Open your browser on the staff main page, change language and verify
   that the message is translated
7. Repeat 1-6 on OPAC side

Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 14 13:17:24 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 14 Jan 2020 12:17:24 +0000
Subject: [Koha-bugs] [Bug 21156] Internationalization: plural forms, context,
 and more for JS files
In-Reply-To: <bug-21156-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21156-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21156-70-nNjMIbnyl6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21156

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |martin.renvoize at ptfs-europe
                   |                            |.com
             Status|Needs Signoff               |Signed Off

--- Comment #9 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Looks good, and passes a few quick tests.. I'm going to give it an SO stamp,
but would love to see someone more familiar with the translations process give
it a once over. :)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 14 13:17:45 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 14 Jan 2020 12:17:45 +0000
Subject: [Koha-bugs] [Bug 21156] Internationalization: plural forms, context,
 and more for JS files
In-Reply-To: <bug-21156-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21156-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21156-70-kHotqmMQwC@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21156

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |bgkriegel at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 14 13:20:45 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 14 Jan 2020 12:20:45 +0000
Subject: [Koha-bugs] [Bug 19793] Add a field for email in batch patron
 modification
In-Reply-To: <bug-19793-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19793-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19793-70-l4sX8LQLUY@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19793

ByWater Sandboxes <bws.sandboxes at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #97335|0                           |1
        is obsolete|                            |

--- Comment #11 from ByWater Sandboxes <bws.sandboxes at gmail.com> ---
Created attachment 97347
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97347&action=edit
Bug 19793 - Add a field for email in batch patron modification

Signed-off-by: Sal <sally.healey at cheshiresharedservices.gov.uk>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 14 13:21:09 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 14 Jan 2020 12:21:09 +0000
Subject: [Koha-bugs] [Bug 19793] Add a field for email in batch patron
 modification
In-Reply-To: <bug-19793-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19793-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19793-70-TmM4tLZ7xF@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19793

Sally <sally.healey at cheshiresharedservices.gov.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 14 13:32:52 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 14 Jan 2020 12:32:52 +0000
Subject: [Koha-bugs] [Bug 24043] ILL module can't show requests from more
 than one backend
In-Reply-To: <bug-24043-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24043-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24043-70-8T4o8T2Im2@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24043

--- Comment #11 from Andrew Isherwood <andrew.isherwood at ptfs-europe.com> ---
Yes, it's pretty tricky to reproduce, the required conditions are detailed in
the test plan above. It would be interesting to see if you can replicate it by
meeting the conditions listed

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 14 13:40:14 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 14 Jan 2020 12:40:14 +0000
Subject: [Koha-bugs] [Bug 17093] JavaScript error on patron entry page if
 toolbar is not displayed
In-Reply-To: <bug-17093-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17093-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17093-70-lUNvaRaBep@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17093

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|NEW                         |RESOLVED

--- Comment #2 from Owen Leonard <oleonard at myacpl.org> ---
This turns out to have been fixed by the switch to the hc-sticky library for
floating the toolbar. It doesn't throw an error when the toolbar doesn't exist.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 14 13:41:06 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 14 Jan 2020 12:41:06 +0000
Subject: [Koha-bugs] [Bug 17207] Cannot access the website from China
In-Reply-To: <bug-17207-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17207-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17207-70-Al2Xpv0KnV@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17207

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|In Discussion               |RESOLVED
         Resolution|---                         |INVALID

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 14 13:43:27 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 14 Jan 2020 12:43:27 +0000
Subject: [Koha-bugs] [Bug 24403] [OMNIBUS] OpacHiddenItems should hide items
 everywhere in the OPAC
In-Reply-To: <bug-24403-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24403-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24403-70-XmLCm1mGkG@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24403

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|oleonard at myacpl.org         |koha-bugs at lists.koha-commun
                   |                            |ity.org
           Severity|enhancement                 |normal

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 14 13:48:31 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 14 Jan 2020 12:48:31 +0000
Subject: [Koha-bugs] [Bug 19399] Show reports screen should not display
 query in textarea
In-Reply-To: <bug-19399-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19399-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19399-70-E9R7RYHQ4t@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19399

--- Comment #1 from Owen Leonard <oleonard at myacpl.org> ---
I wonder if this is improved by the switch to CodeMirror for viewing and
editing SQL?

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 14 14:01:02 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 14 Jan 2020 13:01:02 +0000
Subject: [Koha-bugs] [Bug 24404] Add missing space on invoices page
In-Reply-To: <bug-24404-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24404-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24404-70-EdsFdzrHWW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24404

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 14 14:01:04 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 14 Jan 2020 13:01:04 +0000
Subject: [Koha-bugs] [Bug 24404] Add missing space on invoices page
In-Reply-To: <bug-24404-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24404-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24404-70-zJH0GIhMgs@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24404

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #97263|0                           |1
        is obsolete|                            |

--- Comment #2 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 97348
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97348&action=edit
Bug 24404: Add missing space on invoices page / remove . from status

On the bottom of the invoices page the summary of adjustments and
shipping shows as:

Adjustments plus shipping:2.00

The patch adds the missing space between text and amount.

To test:
- 'Receive shipment' from a result in your vendor search
- Start a new invoice by entering an invoice number, amount
  for shipping cost and fund.
- Finish receive (you don't need to receive anything)
- You should now be on invoice.pl
- Verify Status is 'Open.' and in 'Invoice details' we
  have the amount with the missing space.
- Apply patch, reload the page.
- Verify the missing space is there and the . is gone.
- Close invoice, no . there either.

Signed-off-by: Owen Leonard <oleonard at myacpl.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 14 14:04:14 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 14 Jan 2020 13:04:14 +0000
Subject: [Koha-bugs] [Bug 24418] New: Add Koha::Biblio->suggestions
Message-ID: <bug-24418-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24418

            Bug ID: 24418
           Summary: Add Koha::Biblio->suggestions
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Architecture, internals, and plumbing
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: tomascohen at gmail.com
        QA Contact: testopia at bugs.koha-community.org

We need an accessor for the related suggestions.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 14 14:05:58 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 14 Jan 2020 13:05:58 +0000
Subject: [Koha-bugs] [Bug 24418] Add Koha::Biblio->suggestions
In-Reply-To: <bug-24418-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24418-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24418-70-kbVWio71zw@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24418

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
             Blocks|                            |20212
           Assignee|koha-bugs at lists.koha-commun |tomascohen at gmail.com
                   |ity.org                     |


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20212
[Bug 20212] Slowness in Receiving in Acquisitions
-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 14 14:05:58 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 14 Jan 2020 13:05:58 +0000
Subject: [Koha-bugs] [Bug 20212] Slowness in Receiving in Acquisitions
In-Reply-To: <bug-20212-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20212-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20212-70-HdQdIZnM2B@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20212

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |24418


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24418
[Bug 24418] Add Koha::Biblio->suggestions
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 14 14:11:21 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 14 Jan 2020 13:11:21 +0000
Subject: [Koha-bugs] [Bug 24418] Add Koha::Biblio->suggestions
In-Reply-To: <bug-24418-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24418-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24418-70-R5W8FRzvdI@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24418

--- Comment #1 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 97349
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97349&action=edit
Bug 24418: Unit tests

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 14 14:11:24 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 14 Jan 2020 13:11:24 +0000
Subject: [Koha-bugs] [Bug 24418] Add Koha::Biblio->suggestions
In-Reply-To: <bug-24418-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24418-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24418-70-qx8VV1NwjU@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24418

--- Comment #2 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 97350
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97350&action=edit
Bug 24418: Add Koha::Biblio->suggestions

This patch adds the mentioned accessor. To test:

1. Apply this patch
2. Run:
   $ kshell
  k$ prove t/db_dependent/Koha/Biblio.t
=> SUCCESS: Tests pass
3. Sign off :-D

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 14 14:11:27 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 14 Jan 2020 13:11:27 +0000
Subject: [Koha-bugs] [Bug 24418] Add Koha::Biblio->suggestions
In-Reply-To: <bug-24418-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24418-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24418-70-eu5ZENlCAO@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24418

--- Comment #3 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 97351
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97351&action=edit
Bug 24418: Add koha_object(s)_class methods to Suggestion

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 14 14:12:29 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 14 Jan 2020 13:12:29 +0000
Subject: [Koha-bugs] [Bug 24418] Add Koha::Biblio->suggestions
In-Reply-To: <bug-24418-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24418-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24418-70-HX3WTd9DeL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24418

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Trivial patch
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 14 14:23:03 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 14 Jan 2020 13:23:03 +0000
Subject: [Koha-bugs] [Bug 23990] Move C4::Suggestions code to the Koha
 namespace
In-Reply-To: <bug-23990-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23990-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23990-70-Y73oDdjnQB@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23990

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |24418


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24418
[Bug 24418] Add Koha::Biblio->suggestions
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 14 14:23:03 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 14 Jan 2020 13:23:03 +0000
Subject: [Koha-bugs] [Bug 24418] Add Koha::Biblio->suggestions
In-Reply-To: <bug-24418-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24418-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24418-70-r9krSGTNsI@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24418

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |23990


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23990
[Bug 23990] Move C4::Suggestions code to the Koha namespace
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 14 14:27:35 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 14 Jan 2020 13:27:35 +0000
Subject: [Koha-bugs] [Bug 20567] "Holds per record (count)" limit is not
 enforced after item is captured for hold
In-Reply-To: <bug-20567-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20567-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20567-70-djfuYGZh1u@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20567

Hans Pålsson <hans.palsson at hkr.se> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|In Discussion               |Signed Off

--- Comment #11 from Hans Pålsson <hans.palsson at hkr.se> ---
Signing of because patch solves initial problem.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 14 14:29:12 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 14 Jan 2020 13:29:12 +0000
Subject: [Koha-bugs] [Bug 24350] Can't place holds
In-Reply-To: <bug-24350-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24350-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24350-70-tdr1y3Ndf8@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24350

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |additional_work_needed

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 14 14:30:07 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 14 Jan 2020 13:30:07 +0000
Subject: [Koha-bugs] [Bug 24350] Can't place holds
In-Reply-To: <bug-24350-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24350-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24350-70-qH01boAehp@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24350

--- Comment #22 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 97352
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97352&action=edit
Bug 24350: ->pickup_locations returns unblessed objects

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 14 14:33:07 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 14 Jan 2020 13:33:07 +0000
Subject: [Koha-bugs] [Bug 24418] Add Koha::Biblio->suggestions
In-Reply-To: <bug-24418-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24418-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24418-70-nsSpkVkHDd@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24418

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |tomascohen at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 14 14:33:08 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 14 Jan 2020 13:33:08 +0000
Subject: [Koha-bugs] [Bug 24418] Add Koha::Biblio->suggestions
In-Reply-To: <bug-24418-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24418-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24418-70-XFqRQTRxLO@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24418

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #97349|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 14 14:34:10 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 14 Jan 2020 13:34:10 +0000
Subject: [Koha-bugs] [Bug 24418] Add Koha::Biblio->suggestions
In-Reply-To: <bug-24418-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24418-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24418-70-cdnlMHqPxU@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24418

--- Comment #4 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 97353
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97353&action=edit
Bug 24418: Unit tests

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 14 14:38:16 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 14 Jan 2020 13:38:16 +0000
Subject: [Koha-bugs] [Bug 24350] Can't place holds
In-Reply-To: <bug-24350-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24350-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24350-70-xnokDBOKzO@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24350

--- Comment #23 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Followup pushed, thanks Tomas.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 14 14:56:57 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 14 Jan 2020 13:56:57 +0000
Subject: [Koha-bugs] [Bug 24415] Authority enhancement - Improve access to
 tabs
In-Reply-To: <bug-24415-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24415-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24415-70-orfnrGDkT1@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24415

Patrick Robitaille <patrick.robitaille at collecto.ca> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |patrick.robitaille at collecto
                   |                            |.ca

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 14 15:13:15 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 14 Jan 2020 14:13:15 +0000
Subject: [Koha-bugs] [Bug 24366] Merging biblioitems should happen in
 Koha::Biblio->to_api
In-Reply-To: <bug-24366-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24366-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24366-70-7VOIwLvJPl@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24366

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to master
         Version(s)|                            |20.05.00
        released in|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 14 15:13:17 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 14 Jan 2020 14:13:17 +0000
Subject: [Koha-bugs] [Bug 24366] Merging biblioitems should happen in
 Koha::Biblio->to_api
In-Reply-To: <bug-24366-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24366-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24366-70-TuBXaXxL6N@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24366

--- Comment #9 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Nice work everyone!

Pushed to master for 20.05

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 14 15:27:53 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 14 Jan 2020 14:27:53 +0000
Subject: [Koha-bugs] [Bug 23261] RecordedBooks - notify patron of need to
 login / register to see availability
In-Reply-To: <bug-23261-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23261-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23261-70-bhfZuyZvOh@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23261

--- Comment #12 from Joy Nelson <joy at bywatersolutions.com> ---
Thanks Jonathan.  Last commit pushed to 19.11.x branch for 19.11.02


(In reply to Jonathan Druart from comment #11)
> (In reply to Joy Nelson from comment #10)
> > Pushed to 19.11.x branch for 19.11.02
> 
> Hi Joy, there was a RM follow-up that was not attach to this bug report:
>   commit 42d40e372e25cc4790290dcd0bb31c50f237f5fe
>   Bug 23261: (RM follow-up) Add missing uri filter
> It will fix the failure for xt/find-missing-filters.t on 19.11

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 14 15:40:45 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 14 Jan 2020 14:40:45 +0000
Subject: [Koha-bugs] [Bug 10517] koha-restore fails to create
 mysqluser@mysql_hostname so zebra update fails
In-Reply-To: <bug-10517-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-10517-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10517-70-QfbgUuDhBf@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10517

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |martin.renvoize at ptfs-europe
                   |                            |.com

--- Comment #16 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Sorry, I meant to get to this earlier.

I'm afraid we cannot yet use the 'IF EXISTS' syntax here as we are maintaining
support for Jessie up to the end of it's LTS date (2020-06-30). I intend to
drop support for that Debian version at the release of 20.05 (at which time I
believe we should also drop support for it from 19.11  at 19.11.06 and 19.05 at
19.05.12).

However, even once we have dropped such support, unless I am mistaken, stretch
is still stuck at MySQL 5.5 (though it recommends MariaDB instead.  As such,
we'll need a clear deprecation of mysql 5.5 support outlined and publicised
before we can make this change.

I am, however, pretty keen to take such an approach and drop 5.5 support with
this release and so this patch is 'on hold' for now.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 14 15:44:20 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 14 Jan 2020 14:44:20 +0000
Subject: [Koha-bugs] [Bug 24364] Display item holding library in opac issues
In-Reply-To: <bug-24364-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24364-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24364-70-XDJcYl9tZr@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24364

--- Comment #8 from Matthias Meusburger <matthias.meusburger at biblibre.com> ---
So you're suggesting a proper column in the borrowers table and in the
categories table, in order for this setting to be editable at both
category-level and user-level, is that right?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 14 15:52:42 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 14 Jan 2020 14:52:42 +0000
Subject: [Koha-bugs] [Bug 24381] ACCOUNT_CREDIT slip not printing
 information about paid fines/fees
In-Reply-To: <bug-24381-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24381-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24381-70-9DxQtljWup@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24381

--- Comment #5 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
I'm sure this used to work...

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 14 15:52:57 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 14 Jan 2020 14:52:57 +0000
Subject: [Koha-bugs] [Bug 24381] ACCOUNT_CREDIT slip not printing
 information about paid fines/fees
In-Reply-To: <bug-24381-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24381-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24381-70-JPFUzC9Ehk@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24381

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |kyle at bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 14 15:54:48 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 14 Jan 2020 14:54:48 +0000
Subject: [Koha-bugs] [Bug 24381] ACCOUNT_CREDIT slip not printing
 information about paid fines/fees
In-Reply-To: <bug-24381-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24381-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24381-70-mocInYJsJ8@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24381

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |22761, 22809


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22761
[Bug 22761] Move "Fee receipt" from template to a slip
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22809
[Bug 22809] Move "INVOICE" from template to a slip
-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 14 15:54:48 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 14 Jan 2020 14:54:48 +0000
Subject: [Koha-bugs] [Bug 22761] Move "Fee receipt" from template to a slip
In-Reply-To: <bug-22761-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22761-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22761-70-fAaP0YLTKL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22761

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |24381


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24381
[Bug 24381] ACCOUNT_CREDIT slip not printing information about paid fines/fees
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 14 15:54:48 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 14 Jan 2020 14:54:48 +0000
Subject: [Koha-bugs] [Bug 22809] Move "INVOICE" from template to a slip
In-Reply-To: <bug-22809-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22809-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22809-70-cy0XE2EvoJ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22809

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |24381


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24381
[Bug 24381] ACCOUNT_CREDIT slip not printing information about paid fines/fees
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 14 16:14:30 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 14 Jan 2020 15:14:30 +0000
Subject: [Koha-bugs] [Bug 24381] ACCOUNT_CREDIT slip not printing
 information about paid fines/fees
In-Reply-To: <bug-24381-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24381-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24381-70-w8IfN7j4Du@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24381

--- Comment #6 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Right.. I think I know what you guys want... but I'm pretty confident it wasn't
different in 18.11 unless I'm missing a bug somewhere.. the conversion from
hard coded to a notices template did not change the output going back to my
notes..

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 14 16:17:45 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 14 Jan 2020 15:17:45 +0000
Subject: [Koha-bugs] [Bug 24381] ACCOUNT_CREDIT slip not printing
 information about paid fines/fees
In-Reply-To: <bug-24381-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24381-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24381-70-iYJzqGZVnh@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24381

--- Comment #7 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Now that bug 23354 has been pushed to master, could you take a look at the
template included for a RECEIPT slipt for the Point Of Sale receipts and
confirm that would conform to the data you're looking for in the default slip
here too..

If so, I can create a patch to correct that for new installs.. I think the
reason we didn't add such a slip during the change to slips was to preserve
existing receipt look and feel during upgrades.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 14 16:18:37 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 14 Jan 2020 15:18:37 +0000
Subject: [Koha-bugs] [Bug 23929] Invoice adjustments should filter inactive
 funds
In-Reply-To: <bug-23929-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23929-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23929-70-BEezqRvt0j@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23929

Koha Team University Lyon 3 <koha at univ-lyon3.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |koha at univ-lyon3.fr

--- Comment #2 from Koha Team University Lyon 3 <koha at univ-lyon3.fr> ---
Created attachment 97354
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97354&action=edit
Bug 23929 : Invoice adjustments should filter inactive funds

Test plan :
Go to details of an invoice.
In the adjustments block, click on Add an adjustment and click again on Fund
select list.
If you have been using Koha for some years, you risk to see many funds with
same name listed successively (inactive funds from past years).

Install the patch.
click again the Fund select list in ajustment block : now, you have only active
funds. 

Olivier Crouzet

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 14 16:19:44 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 14 Jan 2020 15:19:44 +0000
Subject: [Koha-bugs] [Bug 23929] Invoice adjustments should filter inactive
 funds
In-Reply-To: <bug-23929-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23929-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23929-70-Qm6byaWWr9@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23929

Koha Team University Lyon 3 <koha at univ-lyon3.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|enhancement                 |normal
             Status|NEW                         |Needs Signoff
           Priority|P5 - low                    |P3

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 14 16:22:25 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 14 Jan 2020 15:22:25 +0000
Subject: [Koha-bugs] [Bug 24381] ACCOUNT_CREDIT slip not printing
 information about paid fines/fees
In-Reply-To: <bug-24381-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24381-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24381-70-711V4N1aSu@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24381

--- Comment #8 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Whilst we're here.. can someone explain to me why we need 4 distinct notices
for this?

ACCOUNT_CREDIT - printfeercpt
ACCOUNT_DEBIT - printinvoice
ACCOUNT_PAYMENT - What is this for?
ACCOUNT_WRITEOFF - What is this for?

RECEIPT - pos/printreceipt

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 14 16:23:09 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 14 Jan 2020 15:23:09 +0000
Subject: [Koha-bugs] [Bug 24419] New: Add Koha::Suggestion->suggestor
 accessor
Message-ID: <bug-24419-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24419

            Bug ID: 24419
           Summary: Add Koha::Suggestion->suggestor accessor
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Architecture, internals, and plumbing
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: tomascohen at gmail.com
        QA Contact: testopia at bugs.koha-community.org

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 14 16:29:47 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 14 Jan 2020 15:29:47 +0000
Subject: [Koha-bugs] [Bug 19793] Add a field for email in batch patron
 modification
In-Reply-To: <bug-19793-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19793-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19793-70-2k90moaLmX@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19793

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Change sponsored?|---                         |Sponsored
                 CC|                            |martin.renvoize at ptfs-europe
                   |                            |.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 14 16:30:00 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 14 Jan 2020 15:30:00 +0000
Subject: [Koha-bugs] [Bug 19793] Add a field for email in batch patron
 modification
In-Reply-To: <bug-19793-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19793-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19793-70-3MkUe2Zabw@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19793

--- Comment #12 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Sponsored by PTFS-Europe

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 14 16:31:14 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 14 Jan 2020 15:31:14 +0000
Subject: [Koha-bugs] [Bug 24381] ACCOUNT_CREDIT slip not printing
 information about paid fines/fees
In-Reply-To: <bug-24381-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24381-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24381-70-Rv3pwRGO4u@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24381

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |13985


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13985
[Bug 13985] Cash Management - Koha as 'Point of Sale'
-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 14 16:31:14 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 14 Jan 2020 15:31:14 +0000
Subject: [Koha-bugs] [Bug 13985] Cash Management - Koha as 'Point of Sale'
In-Reply-To: <bug-13985-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13985-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13985-70-WgKrnVDl0Y@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13985

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |24381


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24381
[Bug 24381] ACCOUNT_CREDIT slip not printing information about paid fines/fees
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 14 16:38:51 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 14 Jan 2020 15:38:51 +0000
Subject: [Koha-bugs] [Bug 24420] New: Cataloging search results Location
 column should account for waiting on hold items
Message-ID: <bug-24420-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24420

            Bug ID: 24420
           Summary: Cataloging search results Location column should
                    account for waiting on hold items
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Cataloging
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: lucas at bywatersolutions.com
        QA Contact: testopia at bugs.koha-community.org
                CC: m.de.rooy at rijksmuseum.nl

In the cataloging search if you perform a search for an item that is waiting on
hold the Location column will be empty.

To Recreate:
1. Place a hold on an item and trigger it.
2  Do a cataloging search that would include this record.
3. Notice that the 'Location' column does not account for this onhold item.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 14 16:42:44 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 14 Jan 2020 15:42:44 +0000
Subject: [Koha-bugs] [Bug 24420] Cataloging search results Location column
 should account for waiting on hold items
In-Reply-To: <bug-24420-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24420-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24420-70-CyLxVhwLJi@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24420

Lucas Gass <lucas at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 14 16:42:46 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 14 Jan 2020 15:42:46 +0000
Subject: [Koha-bugs] [Bug 24420] Cataloging search results Location column
 should account for waiting on hold items
In-Reply-To: <bug-24420-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24420-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24420-70-M8Ycw6twHP@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24420

--- Comment #1 from Lucas Gass <lucas at bywatersolutions.com> ---
Created attachment 97355
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97355&action=edit
Bug 24420: Cataloging search results Location column should account for waiting
on hold items

To Test:
1. Place a hold on an item and trigger it.
2  Do a cataloging search that would include this record.
3. Notice that the 'Location' column does not account for this onhold item.
4. Apply patch and look at catalog results again.
5. You should see information display about the item being on hold.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 14 16:44:10 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 14 Jan 2020 15:44:10 +0000
Subject: [Koha-bugs] [Bug 24420] Cataloging search results Location column
 should account for waiting on hold items
In-Reply-To: <bug-24420-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24420-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24420-70-vQLWg0ACq8@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24420

Lucas Gass <lucas at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|enhancement                 |minor

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 14 16:50:39 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 14 Jan 2020 15:50:39 +0000
Subject: [Koha-bugs] [Bug 20212] Slowness in Receiving in Acquisitions
In-Reply-To: <bug-20212-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20212-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20212-70-Nk9b9ieWPq@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20212

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |24419


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24419
[Bug 24419] Add Koha::Suggestion->suggestor accessor
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 14 16:50:39 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 14 Jan 2020 15:50:39 +0000
Subject: [Koha-bugs] [Bug 24419] Add Koha::Suggestion->suggestor accessor
In-Reply-To: <bug-24419-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24419-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24419-70-uOCOh6ia5X@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24419

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |20212


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20212
[Bug 20212] Slowness in Receiving in Acquisitions
-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 14 16:51:01 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 14 Jan 2020 15:51:01 +0000
Subject: [Koha-bugs] [Bug 24419] Add Koha::Suggestion->suggestor accessor
In-Reply-To: <bug-24419-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24419-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24419-70-PzynEKwIys@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24419

--- Comment #1 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 97356
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97356&action=edit
Bug 24419: Add Koha::Suggestion->suggestor accessor

This patch adds a ->suggestor accessor to the Koha::Suggestion class. It
will return undef if no suggestor, and a Koha::Patron object otherwise.

To test:
1. Apply this patch
2. Run:
   $ kshell
  k$ prove t/db_dependent/Koha/Suggestion.t
=> SUCCESS: Tests pass!
3. Sign off :-D

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 14 16:51:32 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 14 Jan 2020 15:51:32 +0000
Subject: [Koha-bugs] [Bug 24419] Add Koha::Suggestion->suggestor accessor
In-Reply-To: <bug-24419-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24419-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24419-70-ovqYXWoAoR@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24419

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |tomascohen at gmail.com
                   |ity.org                     |
         Depends on|                            |24418
             Status|NEW                         |Needs Signoff


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24418
[Bug 24418] Add Koha::Biblio->suggestions
-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 14 16:51:32 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 14 Jan 2020 15:51:32 +0000
Subject: [Koha-bugs] [Bug 24418] Add Koha::Biblio->suggestions
In-Reply-To: <bug-24418-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24418-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24418-70-w30jtrnV5l@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24418

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |24419


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24419
[Bug 24419] Add Koha::Suggestion->suggestor accessor
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 14 16:52:31 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 14 Jan 2020 15:52:31 +0000
Subject: [Koha-bugs] [Bug 21232] Problems when linking a subscription to a
 non-existing biblionumber
In-Reply-To: <bug-21232-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21232-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21232-70-tQ6cDapU8e@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21232

Lucas Gass <lucas at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to stable            |Pushed to oldstable
                 CC|                            |lucas at bywatersolutions.com

--- Comment #20 from Lucas Gass <lucas at bywatersolutions.com> ---
backported to 19.05.x for 19.05.07

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 14 16:53:31 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 14 Jan 2020 15:53:31 +0000
Subject: [Koha-bugs] [Bug 24358] "Bibliographic record does not exist!" is
 not translatable
In-Reply-To: <bug-24358-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24358-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24358-70-yiYCKPRyLo@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24358

--- Comment #8 from Lucas Gass <lucas at bywatersolutions.com> ---
(In reply to Katrin Fischer from comment #7)
> (In reply to Lucas Gass from comment #6)
> > backported to 19.05.x for 19.05.07
> 
> Hi Lucas, there as no note on the dependency bug here for 19.05 - can you
> check?

Kait, sorry I forgot to update the bug. 21232 was backported to 19.05.x for
19.05.07.


Thanks for checking.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 14 16:57:36 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 14 Jan 2020 15:57:36 +0000
Subject: [Koha-bugs] [Bug 24419] Add Koha::Suggestion->suggestor accessor
In-Reply-To: <bug-24419-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24419-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24419-70-pMxVx2SzKu@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24419

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org,
                   |                            |kyle at bywatersolutions.com,
                   |                            |martin.renvoize at ptfs-europe
                   |                            |.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 14 16:58:19 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 14 Jan 2020 15:58:19 +0000
Subject: [Koha-bugs] [Bug 24269] Authority matching in Elasticsearch is
 broken when authority has subdivisions
In-Reply-To: <bug-24269-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24269-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24269-70-bDwOgEf0Ob@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24269

--- Comment #1 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 97357
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97357&action=edit
Bug 24269: Adjust C4::Heading to generate headings from auth tags

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 14 17:07:43 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 14 Jan 2020 16:07:43 +0000
Subject: [Koha-bugs] [Bug 24421] New: Generated authorities are missing
 subfields
Message-ID: <bug-24421-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24421

            Bug ID: 24421
           Summary: Generated authorities are missing subfields
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: major
          Priority: P5 - low
         Component: MARC Authority data support
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: nick at bywatersolutions.com
        QA Contact: testopia at bugs.koha-community.org

In bug 21826 the intent was to only add allowed subfields to generated
authorities, however, the code uses the authority tag instead of the biblio tag
- there is no mapping for these, so correct subfields are ignored

To recreate:
1 - Enable the sysprefs
     AutoCreateAuthorities 
     BiblioAddsAuthorities
     CatalogModuleRelink
2 - Open a record with a subject heading with a subdivision and add a new
subfield, or add a new unauthroized heading to a record and save it
    e.g. 650$aChess$xOpenings$vFiction.
3 - Save the record, note the created authority and that field is linked
4 - Save the record again and note the authority number changes
5 - Find and view the authority linked to the record
6 - The record is for 'Chess', not Chess openings'
7 - Search authorities for 'Chess' - note duplicated records

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 14 17:07:58 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 14 Jan 2020 16:07:58 +0000
Subject: [Koha-bugs] [Bug 24421] Generated authorities are missing subfields
In-Reply-To: <bug-24421-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24421-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24421-70-Sc0sQo625f@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24421

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |21826
           Assignee|koha-bugs at lists.koha-commun |nick at bywatersolutions.com
                   |ity.org                     |


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21826
[Bug 21826] Automatic authority record generation improvements
-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 14 17:07:58 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 14 Jan 2020 16:07:58 +0000
Subject: [Koha-bugs] [Bug 21826] Automatic authority record generation
 improvements
In-Reply-To: <bug-21826-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21826-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21826-70-o4igpOrJF0@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21826

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |24421


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24421
[Bug 24421] Generated authorities are missing subfields
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 14 17:13:56 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 14 Jan 2020 16:13:56 +0000
Subject: [Koha-bugs] [Bug 22898] Selenium tests for placing holds from the
 staff interface
In-Reply-To: <bug-22898-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22898-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22898-70-u6ZzxPdGUl@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22898

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Failed QA

--- Comment #10 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
This needs updating for current master.. the tests currently fail.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 14 17:16:34 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 14 Jan 2020 16:16:34 +0000
Subject: [Koha-bugs] [Bug 24421] Generated authorities are missing subfields
In-Reply-To: <bug-24421-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24421-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24421-70-k6ZKwSNsoS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24421

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 14 17:16:36 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 14 Jan 2020 16:16:36 +0000
Subject: [Koha-bugs] [Bug 24421] Generated authorities are missing subfields
In-Reply-To: <bug-24421-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24421-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24421-70-A1pdf1kV1K@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24421

--- Comment #1 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 97358
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97358&action=edit
Bug 24421: Check if subfields are valid using the biblio tag

To test:
 1 - Enable the sysprefs
     AutoCreateAuthorities
     BiblioAddsAuthorities
     CatalogModuleRelink
 2 - Open a record with a subject heading with a subdivision and add a new
subfield, or add a new unauthroized heading to a record and save it
    e.g. 650$aChess$xOpenings$vFiction.
 3 - Save the record, note the created authority and that field is linked
 4 - Save the record again and note the authority number changes
 5 - Find and view the authority linked to the record
 6 - The record is for 'Chess', not Chess openings'
 7 - Search authorities for 'Chess' - note duplicated records
 8 - Apply patch, restart all
 9 - Save the record, auth number increases again, we shoudl create the correct
record this time
10 - Save again, auth number should not change
11 - Search authorities and confirm the generated authority has the correct
subfields

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 14 17:17:57 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 14 Jan 2020 16:17:57 +0000
Subject: [Koha-bugs] [Bug 24421] Generated authorities are missing subfields
In-Reply-To: <bug-24421-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24421-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24421-70-4rw4ZeGq0h@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24421

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|major                       |critical

--- Comment #2 from Nick Clemens <nick at bywatersolutions.com> ---
In certain instances this can cause nearly the entire catalog to be relinked to
new authorities and generate many duplicated records - marking as critical

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 14 17:54:02 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 14 Jan 2020 16:54:02 +0000
Subject: [Koha-bugs] [Bug 15686] Rename "item level holds" circ rule column
 to "OPAC item level holds"
In-Reply-To: <bug-15686-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15686-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15686-70-cHp1dgURGq@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15686

Lisette Scheer <lisetteslatah at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |String patch
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 14 17:54:05 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 14 Jan 2020 16:54:05 +0000
Subject: [Koha-bugs] [Bug 15686] Rename "item level holds" circ rule column
 to "OPAC item level holds"
In-Reply-To: <bug-15686-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15686-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15686-70-QB9FJGX892@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15686

--- Comment #4 from Lisette Scheer <lisetteslatah at gmail.com> ---
Created attachment 97359
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97359&action=edit
Bug 15686 - Rename "item level holds" circ rule column to "OPAC item level
holds"

This patch changes the column heading on smart-rules.pl to indicate that it
only effects item level holds on the OPAC side, rather than the intranet. 
To test: 
1. Go to Administration, circulation and fine rules. 
2. Observe incorrect heading on both the top and bottom of the table. 
3. Apply the patch. 
4. Repeat step 1. 
5. Observe new headings.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 14 17:54:31 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 14 Jan 2020 16:54:31 +0000
Subject: [Koha-bugs] [Bug 15686] Rename "item level holds" circ rule column
 to "OPAC item level holds"
In-Reply-To: <bug-15686-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15686-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15686-70-wDVhMKOceA@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15686

Lisette Scheer <lisetteslatah at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |lisetteslatah at gmail.com
           Assignee|koha-bugs at lists.koha-commun |lisetteslatah at gmail.com
                   |ity.org                     |

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 14 18:08:42 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 14 Jan 2020 17:08:42 +0000
Subject: [Koha-bugs] [Bug 24340] We ought to be able to disable SIP using
 koha-sip
In-Reply-To: <bug-24340-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24340-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24340-70-snWxDCrzlT@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24340

--- Comment #8 from Liz Rea <wizzyrea at gmail.com> ---
Created attachment 97360
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97360&action=edit
Bug 24340 (follow-up): Warning -> Information

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 14 18:13:53 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 14 Jan 2020 17:13:53 +0000
Subject: [Koha-bugs] [Bug 24340] We ought to be able to disable SIP using
 koha-sip
In-Reply-To: <bug-24340-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24340-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24340-70-mC8mENPL7a@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24340

--- Comment #9 from Liz Rea <wizzyrea at gmail.com> ---
Created attachment 97361
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97361&action=edit
Bug 24340 (follow-up): Add documentation to debian/docs/koha-sip.xml

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 14 18:14:29 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 14 Jan 2020 17:14:29 +0000
Subject: [Koha-bugs] [Bug 23443] Paying off a lost fee will return the item,
 even if it is checked out to a different patron
In-Reply-To: <bug-23443-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23443-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23443-70-PMTXVl65QJ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23443

ByWater Sandboxes <bws.sandboxes at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #97342|0                           |1
        is obsolete|                            |

--- Comment #5 from ByWater Sandboxes <bws.sandboxes at gmail.com> ---
Created attachment 97362
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97362&action=edit
Bug 23443: Add tests

Signed-off-by: Andrew Fuerste-Henry <andrew at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 14 18:14:31 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 14 Jan 2020 17:14:31 +0000
Subject: [Koha-bugs] [Bug 23443] Paying off a lost fee will return the item,
 even if it is checked out to a different patron
In-Reply-To: <bug-23443-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23443-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23443-70-UdYILlrOCv@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23443

ByWater Sandboxes <bws.sandboxes at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #97343|0                           |1
        is obsolete|                            |

--- Comment #6 from ByWater Sandboxes <bws.sandboxes at gmail.com> ---
Created attachment 97363
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97363&action=edit
Bug 23443: Do not checkin an item if checked out to another patron when lost
fee is paid

Test plan:
0 - Do not apply this patch
1 - Check out an item to a patron
2 - Make sure a fee will be charged when lost
3 - Mark the item lost
4 - Make sure the fee will not be refunded on return of the item
5 - Return the item
6 - Check it out to a new patron
7 - Write off the fine for the original patron
=> The item is now checked in
8 - Apply this patch and repeat 1 to 7
=> The item is still checked out

Signed-off-by: Andrew Fuerste-Henry <andrew at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 14 18:15:14 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 14 Jan 2020 17:15:14 +0000
Subject: [Koha-bugs] [Bug 23443] Paying off a lost fee will return the item,
 even if it is checked out to a different patron
In-Reply-To: <bug-23443-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23443-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23443-70-fFHLzxbmK3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23443

Andrew Fuerste-Henry <andrew at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

--- Comment #7 from Andrew Fuerste-Henry <andrew at bywatersolutions.com> ---
Works great, thanks! Also tested with paying the fee rather than writing it
off.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 14 18:24:41 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 14 Jan 2020 17:24:41 +0000
Subject: [Koha-bugs] [Bug 15686] Rename "item level holds" circ rule column
 to "OPAC item level holds"
In-Reply-To: <bug-15686-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15686-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15686-70-0Q8fddUiHz@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15686

Liz Rea <wizzyrea at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 14 18:24:44 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 14 Jan 2020 17:24:44 +0000
Subject: [Koha-bugs] [Bug 15686] Rename "item level holds" circ rule column
 to "OPAC item level holds"
In-Reply-To: <bug-15686-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15686-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15686-70-Vn4V2O4eir@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15686

Liz Rea <wizzyrea at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #97359|0                           |1
        is obsolete|                            |

--- Comment #5 from Liz Rea <wizzyrea at gmail.com> ---
Created attachment 97364
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97364&action=edit
Bug 15686 - Rename "item level holds" circ rule column to "OPAC item level
holds"

This patch changes the column heading on smart-rules.pl to indicate that it
only effects item level holds on the OPAC side, rather than the intranet.
To test:
1. Go to Administration, circulation and fine rules.
2. Observe incorrect heading on both the top and bottom of the table.
3. Apply the patch.
4. Repeat step 1.
5. Observe new headings.

Signed-off-by: Liz Rea <wizzyrea at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 14 19:09:56 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 14 Jan 2020 18:09:56 +0000
Subject: [Koha-bugs] [Bug 24418] Add Koha::Biblio->suggestions
In-Reply-To: <bug-24418-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24418-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24418-70-noJfPTtqCi@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24418

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 14 19:09:59 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 14 Jan 2020 18:09:59 +0000
Subject: [Koha-bugs] [Bug 24418] Add Koha::Biblio->suggestions
In-Reply-To: <bug-24418-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24418-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24418-70-F10iQW9vxc@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24418

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #97350|0                           |1
        is obsolete|                            |
  Attachment #97351|0                           |1
        is obsolete|                            |
  Attachment #97353|0                           |1
        is obsolete|                            |

--- Comment #5 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 97365
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97365&action=edit
Bug 24418: Add Koha::Biblio->suggestions

This patch adds the mentioned accessor. To test:

1. Apply this patch
2. Run:
   $ kshell
  k$ prove t/db_dependent/Koha/Biblio.t
=> SUCCESS: Tests pass
3. Sign off :-D

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 14 19:10:11 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 14 Jan 2020 18:10:11 +0000
Subject: [Koha-bugs] [Bug 24418] Add Koha::Biblio->suggestions
In-Reply-To: <bug-24418-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24418-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24418-70-3Dv43prtXu@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24418

--- Comment #6 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 97366
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97366&action=edit
Bug 24418: Add koha_object(s)_class methods to Suggestion

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 14 19:10:13 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 14 Jan 2020 18:10:13 +0000
Subject: [Koha-bugs] [Bug 24418] Add Koha::Biblio->suggestions
In-Reply-To: <bug-24418-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24418-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24418-70-kUt3Gy0nrl@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24418

--- Comment #7 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 97367
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97367&action=edit
Bug 24418: Unit tests

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 14 19:12:26 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 14 Jan 2020 18:12:26 +0000
Subject: [Koha-bugs] [Bug 24419] Add Koha::Suggestion->suggestor accessor
In-Reply-To: <bug-24419-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24419-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24419-70-B15lav3Syr@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24419

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 14 19:12:29 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 14 Jan 2020 18:12:29 +0000
Subject: [Koha-bugs] [Bug 24419] Add Koha::Suggestion->suggestor accessor
In-Reply-To: <bug-24419-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24419-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24419-70-HrXrXFQs4j@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24419

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #97356|0                           |1
        is obsolete|                            |

--- Comment #2 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 97368
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97368&action=edit
Bug 24419: Add Koha::Suggestion->suggestor accessor

This patch adds a ->suggestor accessor to the Koha::Suggestion class. It
will return undef if no suggestor, and a Koha::Patron object otherwise.

To test:
1. Apply this patch
2. Run:
   $ kshell
  k$ prove t/db_dependent/Koha/Suggestion.t
=> SUCCESS: Tests pass!
3. Sign off :-D

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 14 19:58:14 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 14 Jan 2020 18:58:14 +0000
Subject: [Koha-bugs] [Bug 19014] Patrons should not get an 'on_reserve'
 notification if the due date is far into the future
In-Reply-To: <bug-19014-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19014-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19014-70-XagEWqqSDi@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19014

Andrew Fuerste-Henry <andrew at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Failed QA

--- Comment #57 from Andrew Fuerste-Henry <andrew at bywatersolutions.com> ---
With this patch applied renewal is not blocked by a hold.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 14 20:42:08 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 14 Jan 2020 19:42:08 +0000
Subject: [Koha-bugs] [Bug 15377] Remove 'checked out' items from course
 reserves
In-Reply-To: <bug-15377-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15377-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15377-70-KIKuZ1Ti3C@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15377

--- Comment #5 from Rogan Hamby <rogan.hamby at gmail.com> ---
Created attachment 97369
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97369&action=edit
small patch to allow removal on course reserve items

I considered a confirmation dialogue that alerted the user to the fact that
there was a circulation but realized the original intent was to put that
information in front of the user immediately.  Thus this patch simply moves the
old criteria for restricting removal of a reserve item to information in the
grid.  So, the patch does two things

1) removes the restriction of not allowing a reserve to be removed if it is
onloan 
2) adds a column to the display that says with the item is checked out or
available based on the onloan flag

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 14 20:54:27 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 14 Jan 2020 19:54:27 +0000
Subject: [Koha-bugs] [Bug 20567] "Holds per record (count)" limit is not
 enforced after item is captured for hold
In-Reply-To: <bug-20567-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20567-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20567-70-S3w3jFEMFO@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20567

Benjamin Daeuber <bdaeuber at cityoffargo.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |bdaeuber at cityoffargo.com

--- Comment #12 from Benjamin Daeuber <bdaeuber at cityoffargo.com> ---
We are the sponsoring library Kyle refers to. While we hadn't noticed this, I
guess I would agree with the opinion here, a hold in waiting status is still a
hold. 

That said, if someone wants a syspref, that's fine, but I guess everyone here
seems to agree waiting hold and pending holds ought to be counted together.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 14 21:16:33 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 14 Jan 2020 20:16:33 +0000
Subject: [Koha-bugs] [Bug 19399] Show reports screen should not display
 query in textarea
In-Reply-To: <bug-19399-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19399-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19399-70-4WflYxcGbK@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19399

--- Comment #2 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
(In reply to Owen Leonard from comment #1)
> I wonder if this is improved by the switch to CodeMirror for viewing and
> editing SQL?

I think it's still valid, if you go to:
http://localhost:8081/cgi-bin/koha/reports/guided_reports.pl?reports=1&phase=Show%20SQL

It does look like the edit screen and you can put your cursor into it, even if
you cannot type. Not sure if there is a 'just display' mode for codemirror?

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 14 21:17:29 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 14 Jan 2020 20:17:29 +0000
Subject: [Koha-bugs] [Bug 20567] "Holds per record (count)" limit is not
 enforced after item is captured for hold
In-Reply-To: <bug-20567-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20567-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20567-70-9uKgCDauJd@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20567

--- Comment #13 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
(In reply to Benjamin Daeuber from comment #12)
> We are the sponsoring library Kyle refers to. While we hadn't noticed this,
> I guess I would agree with the opinion here, a hold in waiting status is
> still a hold. 
> 
> That said, if someone wants a syspref, that's fine, but I guess everyone
> here seems to agree waiting hold and pending holds ought to be counted
> together.

Thx Benjamin for commenting!

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 14 21:26:11 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 14 Jan 2020 20:26:11 +0000
Subject: [Koha-bugs] [Bug 21232] Problems when linking a subscription to a
 non-existing biblionumber
In-Reply-To: <bug-21232-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21232-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21232-70-CL9j4YMS7W@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21232

--- Comment #21 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
(In reply to Lucas Gass from comment #20)
> backported to 19.05.x for 19.05.07

Hi Luke, it looks like the dependency is not in 19.05 - did you test if this
works?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 14 21:26:37 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 14 Jan 2020 20:26:37 +0000
Subject: [Koha-bugs] [Bug 21232] Problems when linking a subscription to a
 non-existing biblionumber
In-Reply-To: <bug-21232-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21232-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21232-70-HVXx7vfNZa@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21232

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |23677


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23677
[Bug 23677] Add API route to get a bibliographic record
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 14 21:26:37 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 14 Jan 2020 20:26:37 +0000
Subject: [Koha-bugs] [Bug 23677] Add API route to get a bibliographic record
In-Reply-To: <bug-23677-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23677-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23677-70-VmkvC94oZc@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23677

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |21232


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21232
[Bug 21232] Problems when linking a subscription to a non-existing biblionumber
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 14 21:41:46 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 14 Jan 2020 20:41:46 +0000
Subject: [Koha-bugs] [Bug 24046] 'Activate filters' untranslatable
In-Reply-To: <bug-24046-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24046-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24046-70-huBVneR1AN@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24046

Hayley Mapley <hayleymapley at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |hayleymapley at catalyst.net.n
                   |                            |z
             Status|Pushed to oldstable         |Pushed to oldoldstable

--- Comment #10 from Hayley Mapley <hayleymapley at catalyst.net.nz> ---
Backported to 18.11.x for 18.11.13

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 14 21:41:58 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 14 Jan 2020 20:41:58 +0000
Subject: [Koha-bugs] [Bug 24046] 'Activate filters' untranslatable
In-Reply-To: <bug-24046-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24046-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24046-70-V9C9Tl1NbQ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24046

Hayley Mapley <hayleymapley at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|20.05.00, 19.11.02          |20.05.00, 19.11.02,
        released in|                            |18.11.13

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 14 21:46:48 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 14 Jan 2020 20:46:48 +0000
Subject: [Koha-bugs] [Bug 21232] Problems when linking a subscription to a
 non-existing biblionumber
In-Reply-To: <bug-21232-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21232-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21232-70-xuIq3Xn2YY@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21232

--- Comment #22 from Hayley Mapley <hayleymapley at catalyst.net.nz> ---
Thanks Jonathan :)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 14 21:53:59 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 14 Jan 2020 20:53:59 +0000
Subject: [Koha-bugs] [Bug 24046] 'Activate filters' untranslatable
In-Reply-To: <bug-24046-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24046-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24046-70-UdgPQSlZVh@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24046

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|20.05.00, 19.11.02,         |20.05.00, 19.11.02,
        released in|18.11.13                    |19.05.07, 18.11.13

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 14 21:57:15 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 14 Jan 2020 20:57:15 +0000
Subject: [Koha-bugs] [Bug 24358] "Bibliographic record does not exist!" is
 not translatable
In-Reply-To: <bug-24358-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24358-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24358-70-lgkpb8zqdc@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24358

--- Comment #9 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
(In reply to Lucas Gass from comment #8)
> (In reply to Katrin Fischer from comment #7)
> > (In reply to Lucas Gass from comment #6)
> > > backported to 19.05.x for 19.05.07
> > 
> > Hi Lucas, there as no note on the dependency bug here for 19.05 - can you
> > check?
> 
> Kait, sorry I forgot to update the bug. 21232 was backported to 19.05.x for
> 19.05.07.
> 
> 
> Thanks for checking.

Great, thx!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 14 21:59:48 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 14 Jan 2020 20:59:48 +0000
Subject: [Koha-bugs] [Bug 21232] Problems when linking a subscription to a
 non-existing biblionumber
In-Reply-To: <bug-21232-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21232-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21232-70-TNJv065j6Q@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21232

--- Comment #23 from Lucas Gass <lucas at bywatersolutions.com> ---
Kait, 

Im sorry, I am missing that dependency. I have reverted this patch set. This is
NOT in 19.05.x

Sorry for the confusion.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 14 22:00:59 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 14 Jan 2020 21:00:59 +0000
Subject: [Koha-bugs] [Bug 24358] "Bibliographic record does not exist!" is
 not translatable
In-Reply-To: <bug-24358-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24358-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24358-70-xhmzttKjm6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24358

--- Comment #10 from Lucas Gass <lucas at bywatersolutions.com> ---
This bugfix has been reverted in 19.05.x and will NOT appear in that series.


Sorry for the confusion.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 14 22:06:29 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 14 Jan 2020 21:06:29 +0000
Subject: [Koha-bugs] [Bug 24364] Display item holding library in opac issues
In-Reply-To: <bug-24364-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24364-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24364-70-pcLb9C7Byg@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24364

--- Comment #9 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Actually my suggesting would be to check if this is needed on patron level or
could be a global setting - and then throw a colvis table configuration at that
table :)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 14 22:12:58 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 14 Jan 2020 21:12:58 +0000
Subject: [Koha-bugs] [Bug 24381] ACCOUNT_CREDIT slip not printing
 information about paid fines/fees
In-Reply-To: <bug-24381-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24381-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24381-70-oN48o0Ivxz@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24381

--- Comment #9 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
(In reply to Martin Renvoize from comment #8)
> Whilst we're here.. can someone explain to me why we need 4 distinct notices
> for this?

Interesting question!

> ACCOUNT_CREDIT - printfeercpt
> ACCOUNT_DEBIT - printinvoice

These are for the slips. I have to say I keep confusing debit and credit, but i
think:

CREDIT = Payment
DEBIT = Invoice

> ACCOUNT_PAYMENT - What is this for? 
> ACCOUNT_WRITEOFF - What is this for?

Sending emails to the patron, similar to checkout/checkin slips. It was a major
step forward as at that time the slips were still not customizable. - see
UseEmailReceipts system preference.

> RECEIPT - pos/printreceipt

I think there is a good precedence to have different templates for printed
slips, so that makes sense to me. Also while we could probably combine payment,
writeoff notice and invoice notice are different things.

I have not idea about RECEIPT yet - but this one you should know about ;)

We have tested ACCOUNT_ emails and they do what we need on the slips. I'd
prefere if they all shared the same names for objects/variables or this will be
really messy to train and explain.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 14 22:25:43 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 14 Jan 2020 21:25:43 +0000
Subject: [Koha-bugs] [Bug 20567] "Holds per record (count)" limit is not
 enforced after item is captured for hold
In-Reply-To: <bug-20567-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20567-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20567-70-TO2Opb6nwd@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20567

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |jonathan.druart at bugs.koha-c
                   |ity.org                     |ommunity.org

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 14 22:31:14 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 14 Jan 2020 21:31:14 +0000
Subject: [Koha-bugs] [Bug 15686] Rename "item level holds" circ rule column
 to "OPAC item level holds"
In-Reply-To: <bug-15686-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15686-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15686-70-Xs0Z3bxZ7H@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15686

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 14 22:31:18 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 14 Jan 2020 21:31:18 +0000
Subject: [Koha-bugs] [Bug 15686] Rename "item level holds" circ rule column
 to "OPAC item level holds"
In-Reply-To: <bug-15686-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15686-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15686-70-6G8dypr30Y@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15686

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #97364|0                           |1
        is obsolete|                            |

--- Comment #6 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 97370
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97370&action=edit
Bug 15686 - Rename "item level holds" circ rule column to "OPAC item level
holds"

This patch changes the column heading on smart-rules.pl to indicate that it
only effects item level holds on the OPAC side, rather than the intranet.
To test:
1. Go to Administration, circulation and fine rules.
2. Observe incorrect heading on both the top and bottom of the table.
3. Apply the patch.
4. Repeat step 1.
5. Observe new headings.

Signed-off-by: Liz Rea <wizzyrea at gmail.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 14 22:35:45 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 14 Jan 2020 21:35:45 +0000
Subject: [Koha-bugs] [Bug 16784] Add table configuration on suggestions table
In-Reply-To: <bug-16784-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16784-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16784-70-EaFdHDAu0z@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16784

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Failed QA

--- Comment #7 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Hi Owen,

can you check this fail from the QA tools please?

 FAIL   koha-tmpl/intranet-tmpl/prog/en/modules/suggestion/suggestion.tt
   FAIL   filters
                missing_filter at line 841 (                       
KohaTable("[% suggestion.suggestiontype %]t", {)

I am not friendly with the datatables yet, so didn't want to break things.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 14 22:36:22 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 14 Jan 2020 21:36:22 +0000
Subject: [Koha-bugs] [Bug 24422] New: Advanced search shelving locations are
 restricted to the same restrictions as cataloging
Message-ID: <bug-24422-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24422

            Bug ID: 24422
           Summary: Advanced search shelving locations are restricted to
                    the same restrictions as cataloging
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Searching
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: cbrannon at cdalibrary.org
        QA Contact: testopia at bugs.koha-community.org

Shelving locations that are setup in the LOC category allow libraries to
include a location or not, based on whether they use the location in
cataloging.  This makes sense.  What cataloger wants to sift through a bunch of
shelving locations they are never going to use?

However, if you allow advanced searching to use shelving locations as a limiter
(AdvancedSearchTypes), if you are on the staff client in advance search, you
have the same locations restricted imposed on search.pl, which is not what one
would want.  Staff will never be able to limit to a shelving location used at
another library.

I don't think that the library limitations in LOC should apply to search.pl.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 14 22:38:07 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 14 Jan 2020 21:38:07 +0000
Subject: [Koha-bugs] [Bug 24336] Ask for confirmation before deleting a
 suggestion in the OPAC
In-Reply-To: <bug-24336-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24336-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24336-70-yt8eAcGztH@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24336

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |BLOCKED
                 CC|                            |katrin.fischer at bsz-bw.de

--- Comment #5 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
We'll need a sign-off on the dependency bug - Maryse, as you have tested both
together, could you have a look?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 14 22:49:44 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 14 Jan 2020 21:49:44 +0000
Subject: [Koha-bugs] [Bug 11500] Use dateformat syspref and datepicker on
 additems.pl (and other item cataloguing pages)
In-Reply-To: <bug-11500-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-11500-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11500-70-jfcIFwug6Q@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11500

Hayley Mapley <hayleymapley at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |hayleymapley at catalyst.net.n
                   |                            |z

--- Comment #10 from Hayley Mapley <hayleymapley at catalyst.net.nz> ---
If it is decided that this should be backported to 18.11 (oldoldstable) can a
patch please be added for 18.11 as there are merge conflicts. if it should not
be added, that is fine

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 14 22:59:05 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 14 Jan 2020 21:59:05 +0000
Subject: [Koha-bugs] [Bug 24352] OpacItemLocation is buggy
In-Reply-To: <bug-24352-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24352-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24352-70-Cm1HnGvGRS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24352

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Failed QA

--- Comment #7 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
I sorry Owen, not having a good run on your patches tonight :(

In my setup this doesn't work when there are no collections set on any of the
items on the record:

Collection(s): . 

Could you have another look please?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 14 23:02:09 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 14 Jan 2020 22:02:09 +0000
Subject: [Koha-bugs] [Bug 24344] Modify OPAC link to suggest existing record
 for purchase
In-Reply-To: <bug-24344-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24344-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24344-70-qOLA9CvFVC@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24344

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 14 23:02:12 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 14 Jan 2020 22:02:12 +0000
Subject: [Koha-bugs] [Bug 24344] Modify OPAC link to suggest existing record
 for purchase
In-Reply-To: <bug-24344-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24344-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24344-70-p9tZNCXlR3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24344

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #96828|0                           |1
        is obsolete|                            |

--- Comment #3 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 97371
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97371&action=edit
Bug 24344: Modify OPAC link to suggest existing record for purchase

This patch modifies the link to suggest purchase of an existing record
from the OPAC. The icon is changed to "gift" and the text shortened to
"Suggest for purchase."

To test, apply the patch and view the detail page of any record in the
OPAC. Confirm that the modifications look good.

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 14 23:26:35 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 14 Jan 2020 22:26:35 +0000
Subject: [Koha-bugs] [Bug 24343] Show subtitle,
 number and parts in course reserves list of titles in staff client
In-Reply-To: <bug-24343-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24343-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24343-70-WTWZcDDvwM@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24343

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 14 23:26:39 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 14 Jan 2020 22:26:39 +0000
Subject: [Koha-bugs] [Bug 24343] Show subtitle,
 number and parts in course reserves list of titles in staff client
In-Reply-To: <bug-24343-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24343-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24343-70-mri9jChcxo@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24343

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #96836|0                           |1
        is obsolete|                            |

--- Comment #4 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 97372
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97372&action=edit
Bug 24343: Show subtitle, number and parts in course reserves list of titles in
staff client

Adapted from Bug 23784: At the moment only the title will display in the
course reserves details, but not the information from other title
fields. For series with multiple volumes that can lead to confusing
display. The patch makes use of the new include to display 245$abnp.

To test:
- Add mulitple records to a course reserve course
  Make sure you have titles with different combinations of 245$b$n$p
  - Look at the course details in the staff client
  - Verify only $a displays
  - Apply patch
  - Reload
  - Verify now the full information displays

  Depending on your installation, you might want ot check that the 245
  are correctly mapped and save the record once so the database
  fields are correctly filled.

Signed-off-by: Andrew Fuerste-Henry <andrew at bywatersolutions.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 14 23:28:20 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 14 Jan 2020 22:28:20 +0000
Subject: [Koha-bugs] [Bug 24423] New: Broken link to return to record after
 batch item modification
Message-ID: <bug-24423-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24423

            Bug ID: 24423
           Summary: Broken link to return to record after batch item
                    modification
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: Cataloging
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: andrew at bywatersolutions.com
        QA Contact: testopia at bugs.koha-community.org
                CC: m.de.rooy at rijksmuseum.nl

To test:
- Find/create a bib with at least one item
- From detail.pl, use the checkboxes in the holdings table to select one or
more items
- click the "Modify Selected Items" link just above the holdings table to take
your item(s) to batch modification
- Change something and click save
- Observe that the Return to the Record link points to a url without a
biblionumber: "/cgi-bin/koha/catalogue/detail.pl?biblionumber="

This link is not broken if you get from detail.pl to batchMod.pl using the
"Edit items in batch" link from the Edit button.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 14 23:28:41 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 14 Jan 2020 22:28:41 +0000
Subject: [Koha-bugs] [Bug 24391] Remove event attributes from patron clubs
 edit template
In-Reply-To: <bug-24391-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24391-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24391-70-1FjyJwWNcO@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24391

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de

--- Comment #4 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Hi Owen, is the dependency correct here? It looks like there were patches on
bug 18530 once, but there aren't now.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 14 23:34:04 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 14 Jan 2020 22:34:04 +0000
Subject: [Koha-bugs] [Bug 24391] Remove event attributes from patron clubs
 edit template
In-Reply-To: <bug-24391-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24391-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24391-70-XfYvy8tw3U@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24391

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 14 23:34:08 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 14 Jan 2020 22:34:08 +0000
Subject: [Koha-bugs] [Bug 24391] Remove event attributes from patron clubs
 edit template
In-Reply-To: <bug-24391-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24391-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24391-70-sYsZ1dkeHI@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24391

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #97270|0                           |1
        is obsolete|                            |

--- Comment #5 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 97373
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97373&action=edit
Bug 24391: Remove event attributes from patron clubs edit template

This patch removes "onclick" attributes from the template for adding and
editing patron club templates.

To test, apply the patch and go to Tools -> Patron clubs -> New club
template.

Test the process of adding and deleting both club and enrollment fields.
Test during the template add process and when editing an existing
template.

Signed-off-by: David Nind <david at davidnind.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 15 00:09:18 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 14 Jan 2020 23:09:18 +0000
Subject: [Koha-bugs] [Bug 18688] Warnings about UTF-8 charset when creating
 a new language
In-Reply-To: <bug-18688-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18688-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18688-70-gEk7sEMAF5@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18688

Hayley Mapley <hayleymapley at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|20.05.00, 19.11.02          |20.05.00, 19.11.02,
        released in|                            |18.11.13
                 CC|                            |hayleymapley at catalyst.net.n
                   |                            |z
             Status|Pushed to oldstable         |Pushed to oldoldstable

--- Comment #7 from Hayley Mapley <hayleymapley at catalyst.net.nz> ---
Backported to 18.11.x for 18.11.13

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 15 00:09:39 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 14 Jan 2020 23:09:39 +0000
Subject: [Koha-bugs] [Bug 18688] Warnings about UTF-8 charset when creating
 a new language
In-Reply-To: <bug-18688-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18688-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18688-70-uw55BLUexs@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18688

Hayley Mapley <hayleymapley at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|20.05.00, 19.11.02,         |20.05.00, 19.11.02,
        released in|18.11.13                    |19.05.07, 18.11.13

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 15 00:31:57 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 14 Jan 2020 23:31:57 +0000
Subject: [Koha-bugs] [Bug 24424] New: Advanced editor - interface hangs as
 "Loading" when given an invalid bib number
Message-ID: <bug-24424-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24424

            Bug ID: 24424
           Summary: Advanced editor - interface hangs as "Loading" when
                    given an invalid bib number
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Cataloging
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: carnold at dgiinc.com
        QA Contact: testopia at bugs.koha-community.org
                CC: m.de.rooy at rijksmuseum.nl

The Advanced Editor hangs with "Loading, please wait" message when given an
invalid bib number /cgi-bin/koha/cataloguing/editor.pl#catalog/55555

https://paste.pics/e7c7e4956dfa888b13b54332472df066

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 15 00:57:53 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 14 Jan 2020 23:57:53 +0000
Subject: [Koha-bugs] [Bug 24425] New: Remove utf8 as an export option
Message-ID: <bug-24425-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24425

            Bug ID: 24425
           Summary: Remove utf8 as an export option
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Cataloging
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: aleisha at catalyst.net.nz
        QA Contact: testopia at bugs.koha-community.org
                CC: m.de.rooy at rijksmuseum.nl

it's a character encoding, not a file type. Doesn't really makes sense.

Option exists for both bibliographic records and authority records.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 15 00:58:05 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 14 Jan 2020 23:58:05 +0000
Subject: [Koha-bugs] [Bug 24425] Remove utf8 as an export option
In-Reply-To: <bug-24425-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24425-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24425-70-L9mTe0Gnm4@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24425

Aleisha Amohia <aleisha at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |Academy

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 15 01:20:11 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 15 Jan 2020 00:20:11 +0000
Subject: [Koha-bugs] [Bug 23233] AllowItemsOnHoldCheckout is misnamed and
 should only work for for SIP-based checkouts
In-Reply-To: <bug-23233-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23233-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23233-70-kVSkjx5EOz@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23233

Joy Nelson <joy at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |joy at bywatersolutions.com
         Version(s)|20.05.00                    |20.05.00,, 19.11.02
        released in|                            |
             Status|Pushed to master            |Pushed to stable

--- Comment #40 from Joy Nelson <joy at bywatersolutions.com> ---
Pushed to 19.11.x branch for 19.11.02

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 15 01:35:04 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 15 Jan 2020 00:35:04 +0000
Subject: [Koha-bugs] [Bug 24308] Suggestions table on suggestions.pl should
 have separate columns for dates
In-Reply-To: <bug-24308-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24308-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24308-70-PQPFc2ntKB@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24308

Hayley Mapley <hayleymapley at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |hayleymapley at catalyst.net.n
                   |                            |z

--- Comment #11 from Hayley Mapley <hayleymapley at catalyst.net.nz> ---
Enhancement will not be backported to 18.11.x series

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 15 01:49:20 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 15 Jan 2020 00:49:20 +0000
Subject: [Koha-bugs] [Bug 24236] Using quotes in a cataloging search,
 resulting in multiple pages, will not allow you to advance page
In-Reply-To: <bug-24236-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24236-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24236-70-YR5ue8dlcY@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24236

Myka Kennedy Stephens <mkstephens at lancasterseminary.edu> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Failed QA
                 CC|                            |mkstephens at lancasterseminar
                   |                            |y.edu

--- Comment #3 from Myka Kennedy Stephens <mkstephens at lancasterseminary.edu> ---
I cannot replicate the problem. Please provide further direction for testing.

Testing system = koha-testing-docker
Versions tested = master, 19.11.x, 19.05.x
Search engine = Zebra
Search query = cat >> can page through results
Search query = "cat" >> can page through results

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 15 01:55:03 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 15 Jan 2020 00:55:03 +0000
Subject: [Koha-bugs] [Bug 24391] Remove event attributes from patron clubs
 edit template
In-Reply-To: <bug-24391-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24391-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24391-70-vrvTZzZXVu@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24391

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |18530
         Depends on|18530                       |

--- Comment #6 from Owen Leonard <oleonard at myacpl.org> ---
(In reply to Katrin Fischer from comment #4)
> Hi Owen, is the dependency correct here?

Sorry, it should block, not depend on, 18530


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18530
[Bug 18530] Remove event attributes from patron clubs templates
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 15 01:55:03 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 15 Jan 2020 00:55:03 +0000
Subject: [Koha-bugs] [Bug 18530] Remove event attributes from patron clubs
 templates
In-Reply-To: <bug-18530-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18530-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18530-70-1EY7jqYUnJ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18530

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|24391                       |
         Depends on|                            |24391


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24391
[Bug 24391] Remove event attributes from patron clubs edit template
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 15 02:30:43 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 15 Jan 2020 01:30:43 +0000
Subject: [Koha-bugs] [Bug 24121] Item types icons in intra search results
 are requesting icons from opac images path
In-Reply-To: <bug-24121-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24121-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24121-70-eSl69ZwBPW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24121

Hayley Mapley <hayleymapley at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |hayleymapley at catalyst.net.n
                   |                            |z
         Version(s)|20.05.00, 19.11.02          |20.05.00, 19.11.02,
        released in|                            |19.05.07, 18.11.13
             Status|Pushed to oldstable         |Pushed to oldoldstable

--- Comment #15 from Hayley Mapley <hayleymapley at catalyst.net.nz> ---
Backported to 18.11.x for 18.11.13

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 15 03:07:49 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 15 Jan 2020 02:07:49 +0000
Subject: [Koha-bugs] [Bug 19014] Patrons should not get an 'on_reserve'
 notification if the due date is far into the future
In-Reply-To: <bug-19014-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19014-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19014-70-vCSKp7Zgw5@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19014

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 15 03:07:54 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 15 Jan 2020 02:07:54 +0000
Subject: [Koha-bugs] [Bug 19014] Patrons should not get an 'on_reserve'
 notification if the due date is far into the future
In-Reply-To: <bug-19014-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19014-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19014-70-zcme40d2Kh@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19014

--- Comment #58 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 97374
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97374&action=edit
Bug 19014: on_reserve blocks auto_renew

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 15 03:28:37 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 15 Jan 2020 02:28:37 +0000
Subject: [Koha-bugs] [Bug 24426] New: Frameworks does not support two
 different sets of indicators for each subfield for one tag.
Message-ID: <bug-24426-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24426

            Bug ID: 24426
           Summary: Frameworks does not support two different sets of
                    indicators for each subfield for one tag.
 Change sponsored?: ---
           Product: Koha
           Version: 18.11
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: Cataloging
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: courtenay.johnson at gmail.com
        QA Contact: testopia at bugs.koha-community.org
                CC: m.de.rooy at rijksmuseum.nl

Frameworks configuration silently ignores having two different sets of
indicators for one field.
It appears that you can't control the indicator value for each subcode within
one tag.
I wish to use two framework entries in the Marc tag 024. These are:
024 10 $a, and 024 30 $a for UPC and EAN bar codes respectively.
I can set the first one for UPC but when I create the 2nd subcode entry in
Frameworks,
it is silently ignored. I have not noticed any error entry in the log.
The first one that I enter is visible, but there is no sign of the 2nd
subfield.
There is no issue if a MARC record is imported with either or both of these
coombination
of tag, indicators and subfields.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 15 05:24:12 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 15 Jan 2020 04:24:12 +0000
Subject: [Koha-bugs] [Bug 24427] New: Add Sort1 and Sort2 to Patrons with
 the most checkouts report
Message-ID: <bug-24427-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24427

            Bug ID: 24427
           Summary: Add Sort1 and Sort2 to Patrons with the most checkouts
                    report
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: Linux
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Reports
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: vimalibre at gmail.com
        QA Contact: testopia at bugs.koha-community.org

I would like to suggest to add Sort1 and Sort2 to Reports › Patrons with the
most checkouts.

This addition will be helpful for libraries using Sort1 and Sort2 for extra
patron characteristics. For example, many school libraries enter division/class
to Sort1 or sort2. Such libraries can easily create report of Patrons with most
checkouts based on classes and distribute prizes.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 15 05:25:12 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 15 Jan 2020 04:25:12 +0000
Subject: [Koha-bugs] [Bug 24427] Add Sort1 and Sort2 to Patrons with the
 most checkouts report
In-Reply-To: <bug-24427-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24427-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24427-70-xZIBNWlYkM@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24427

vimal kumar <vimalibre at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |vimalibre at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 15 07:44:38 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 15 Jan 2020 06:44:38 +0000
Subject: [Koha-bugs] [Bug 24292] Upgrade failed,
 from 19.05 to 19.11 on Ubuntu 19.10: Can't load Unaccent.so
In-Reply-To: <bug-24292-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24292-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24292-70-VSPdZzpgsh@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24292

Rudolf Byker <rudolfbyker at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |rudolfbyker at gmail.com

--- Comment #7 from Rudolf Byker <rudolfbyker at gmail.com> ---
I just ran into the same thing today. Is there a way to recover from the failed
update?

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 15 07:53:39 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 15 Jan 2020 06:53:39 +0000
Subject: [Koha-bugs] [Bug 24292] Upgrade failed,
 from 19.05 to 19.11 on Ubuntu 19.10: Can't load Unaccent.so
In-Reply-To: <bug-24292-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24292-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24292-70-g04bs6ojmP@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24292

--- Comment #8 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
(In reply to Rudolf Byker from comment #7)
> I just ran into the same thing today. Is there a way to recover from the
> failed update?

Hi Rudolf, this has been marked as a duplicate of bug 14759 which has the fix
we have been working on. Not sure where your update failed - if it was the
dependency check on the web installer you can probably apply the patch and it
will work from there as no database update has been run yet.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 15 08:00:10 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 15 Jan 2020 07:00:10 +0000
Subject: [Koha-bugs] [Bug 24292] Upgrade failed,
 from 19.05 to 19.11 on Ubuntu 19.10: Can't load Unaccent.so
In-Reply-To: <bug-24292-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24292-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24292-70-ayq0xbUHxM@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24292

--- Comment #9 from Rudolf Byker <rudolfbyker at gmail.com> ---
It failed suring "sudo apt upgrade" on a Debian system. That's how I always
update Koha (and everything else):

Setting up koha-common (19.11.01-1) ...
Installing new version of config file /etc/init.d/koha-common ...
Installing new version of config file /etc/koha/koha-conf-site.xml.in ...
Installing new version of config file /etc/koha/plack.psgi ...
Upgrading database schema for rsc
Upgrade to 19.06.00.000 done (Wingardium Leviosa!)
Upgrade to 19.06.00.001 done (Bug 22960: Fix typo in syspref description)
Upgrade to 19.06.00.002 done (Bug 10215: Increase the size of opacnote and
librariannote for table subscriptionhistory)
Upgrade to 19.06.00.003 done (Bug 22867: UniqueItemFields preference value
should be pipe-delimited)
Upgrade to 19.06.00.004 done (Bug 22770: Fix typo in language description for
el in German)
Upgrade to 19.06.00.005 done (Bug  9834: Add the reserves.item_level_hold
column)
Can't load
'/usr/lib/x86_64-linux-gnu/perl5/5.28/auto/Text/Unaccent/Unaccent.so' for
module Text::Unaccent:
/usr/lib/x86_64-linux-gnu/perl5/5.28/auto/Text/Unaccent/Unaccent.so: undefined
symbol: unac_debug_callback at
/usr/lib/x86_64-linux-gnu/perl/5.28/DynaLoader.pm line 187.
 at /usr/share/koha/lib/Koha/Patron.pm line 26.
Compilation failed in require at /usr/share/koha/lib/Koha/Patron.pm line 26.
BEGIN failed--compilation aborted at /usr/share/koha/lib/Koha/Patron.pm line
26.
Compilation failed in require at /usr/share/koha/lib/Koha/Patrons.pm line 30.
BEGIN failed--compilation aborted at /usr/share/koha/lib/Koha/Patrons.pm line
30.
Compilation failed in require at
/usr/share/koha/lib/Koha/Checkouts/ReturnClaim.pm line 27.
BEGIN failed--compilation aborted at
/usr/share/koha/lib/Koha/Checkouts/ReturnClaim.pm line 27.
Compilation failed in require at
/usr/share/koha/lib/Koha/Checkouts/ReturnClaims.pm line 26.
BEGIN failed--compilation aborted at
/usr/share/koha/lib/Koha/Checkouts/ReturnClaims.pm line 26.
Compilation failed in require at /usr/share/koha/lib/Koha/Checkout.pm line 27.
BEGIN failed--compilation aborted at /usr/share/koha/lib/Koha/Checkout.pm line
27.
Compilation failed in require at /usr/share/koha/lib/Koha/Checkouts.pm line 25.
BEGIN failed--compilation aborted at /usr/share/koha/lib/Koha/Checkouts.pm line
25.
Compilation failed in require at /usr/share/koha/lib/C4/Auth.pm line 37.
BEGIN failed--compilation aborted at /usr/share/koha/lib/C4/Auth.pm line 37.
Compilation failed in require at /usr/share/koha/lib/C4/Output.pm line 34.
BEGIN failed--compilation aborted at /usr/share/koha/lib/C4/Output.pm line 34.
Compilation failed in require at /usr/share/koha/lib/Koha/Plugins.pm line 29.
BEGIN failed--compilation aborted at /usr/share/koha/lib/Koha/Plugins.pm line
29.
Compilation failed in require at
/usr/share/koha/intranet/cgi-bin/installer/data/mysql/updatedatabase.pl line
18792.
dpkg: error processing package koha-common (--configure):
 installed koha-common package post-installation script subprocess returned
error exit status 2
Processing triggers for man-db (2.8.5-2) ...
Processing triggers for systemd (241-7~deb10u2) ...
Errors were encountered while processing:
 koha-common
E: Sub-process /usr/bin/dpkg returned an error code (1)

So some DB updates have definitely already run. But, I think I figured out how
to salvage it.

As root:

# Install the module
cpan Text::Unaccent::PurePerl
# Edit the perl source, replacing 'Text::Unaccent' with
'Text::Unaccent::PurePerl'
nano /usr/share/koha/lib/Koha/Patron.pm
# Reconfigure failed packages
dpkg --configure --pending

One of the DB updates said: "misc/batchRebuildBiblioTables.pl should be run to
populate the fields introduced in bug 11529. It may take some time for larger
databases." I'm not sure if this should be run manually, but I tried anyway,
without success.

My production DB seems to be working again. I hope this helps someone.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 15 08:22:38 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 15 Jan 2020 07:22:38 +0000
Subject: [Koha-bugs] [Bug 24185] 'If all unavailable' state for 'on shelf
 holds' makes holds page very slow if there's a lot of items
In-Reply-To: <bug-24185-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24185-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24185-70-1wlerw4rL1@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24185

Andrew Nugged <nugged at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |String patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 15 08:22:41 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 15 Jan 2020 07:22:41 +0000
Subject: [Koha-bugs] [Bug 24185] 'If all unavailable' state for 'on shelf
 holds' makes holds page very slow if there's a lot of items
In-Reply-To: <bug-24185-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24185-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24185-70-pV6UyuFrZK@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24185

Andrew Nugged <nugged at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #96491|0                           |1
        is obsolete|                            |
  Attachment #96492|0                           |1
        is obsolete|                            |
  Attachment #96500|0                           |1
        is obsolete|                            |

--- Comment #14 from Andrew Nugged <nugged at gmail.com> ---
Created attachment 97375
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97375&action=edit
Bug 24185: Make holds page faster - improved "if"

`$can_item_be_reserved eq 'OK'` moved in `&&` before
`IsAvailableForItemLevelRequest`
to cut away with static known values before calling to more resource consuming
subroutine.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 15 08:23:18 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 15 Jan 2020 07:23:18 +0000
Subject: [Koha-bugs] [Bug 24185] 'If all unavailable' state for 'on shelf
 holds' makes holds page very slow if there's a lot of items
In-Reply-To: <bug-24185-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24185-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24185-70-3p3ybUeoCv@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24185

--- Comment #15 from Andrew Nugged <nugged at gmail.com> ---
Created attachment 97376
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97376&action=edit
Bug 24185: Make holds page faster - call to subroutine moved below "if"

`$on_shelf_holds` was assigned before "return .. if" but not used in that code
piece,
so sometimes it was useless. Moved assignment after "return .. if".

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 15 08:24:24 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 15 Jan 2020 07:24:24 +0000
Subject: [Koha-bugs] [Bug 24185] 'If all unavailable' state for 'on shelf
 holds' makes holds page very slow if there's a lot of items
In-Reply-To: <bug-24185-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24185-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24185-70-vNlKmgakQi@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24185

Andrew Nugged <nugged at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|String patch                |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 15 08:24:27 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 15 Jan 2020 07:24:27 +0000
Subject: [Koha-bugs] [Bug 24185] 'If all unavailable' state for 'on shelf
 holds' makes holds page very slow if there's a lot of items
In-Reply-To: <bug-24185-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24185-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24185-70-R5j0oPZhg4@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24185

--- Comment #16 from Andrew Nugged <nugged at gmail.com> ---
Created attachment 97377
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97377&action=edit
Bug 24185: Make holds page faster: preparatory refactoring

This is just refactoring. extracting logically independent code
to separate sub + tests update. No logic change yet.

Searching for "any_available" item among all biblionumber items was done
inside of "elsif on_shelf_holds == 2", and it is logically very independent
piece of code (this "@items" loop), it needs just biblionumber and patron
as parameters so it can be extracted into separate subroutine, and
later also called/reused from somewhere else.

This ability to call from another place also made for future patch
to remove O(n^2) problem with nested loops.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 15 08:26:25 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 15 Jan 2020 07:26:25 +0000
Subject: [Koha-bugs] [Bug 24185] 'If all unavailable' state for 'on shelf
 holds' makes holds page very slow if there's a lot of items
In-Reply-To: <bug-24185-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24185-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24185-70-uqgPuhI0sH@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24185

--- Comment #17 from Andrew Nugged <nugged at gmail.com> ---
Created attachment 97378
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97378&action=edit
Bug 24185: Make holds page fast when 'on shelf holds' set to 'If all
unavailable'

When "reserve/request.pl -> C4/Reserves.pm::IsAvailableForItemLevelRequest"
called many times with hundred of items and "on shelf holds" parameter set to
"If all unavailable" for these items + patron, it goes slow.

It happens because in subloop it is checking if all items available so it is
O(n^2) and it re-checks each time the same info for each item with repeating
DB/data requests.

Fix:
The inner loop 1:1 picked out into separate subroutine and called outside of
the loop, saving data in 'items_any_available' variable once, this variable
passed to IsAvailableForItemLevelRequest to be used inside as the precalculated
result.

This made algorithm O(n) instead of O(n^2) so there is noticeable speed
increase.

How to reproduce:

1) on freshly installed kohadevbox create/import one book,
remember that biblionumber for later use it in down below,

2) add 100 items for that book for some library,

3) find some patron, that patron's card number we will
use as a borrower down below to open holds page,

4) check for the rule or set up a single circulation rule
in admin "/cgi-bin/koha/admin/smart-rules.pl",
that rule should match above book items/library/patron,
check that rule to have a non-zero number of holds (total, daily, count)
allowed,
and, IMPORTANT: set up "On shelf holds allowed" to "If all unavailable",
("item level holds" doesn't matter).

5) open "Home > Catalog > THAT_BOOK > Place a hold on THAT_BOOK" page
("holds" tab), and enter patron code in the search field,
or you can create a direct link by yourself, for example, in my case it was:
/cgi-bin/koha/reserve/request.pl?biblionumber=4&findborrower=23529000686353

6) it should be pretty long page generation time on old code, densely
increasing for every hundred items added. In the case of this solution, it's
fast, and time increases a little only, linear.

I tested on my computer in VirtualBox for page generation times,
did 3-5 runs for same case to check if results are stable, and got such values:

(old code):
  100 items:    50 seconds
  200 items:   3.2 minutes
  300 items:   7.3 minutes

(version with fix):
  100 items:   4.4 seconds
  200 items:   7.5 seconds
  300 items:  10.4 seconds

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 15 08:28:32 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 15 Jan 2020 07:28:32 +0000
Subject: [Koha-bugs] [Bug 24426] Frameworks does not support two different
 sets of indicators for each subfield for one tag.
In-Reply-To: <bug-24426-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24426-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24426-70-T1EBkWO7aK@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24426

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de

--- Comment #1 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Hi Courtenay, I am not sure I understand your report yet. Were you trying to
add 2 024 $a configurations to your framework?
At the moment it's not possible to set up repeated tags with defaults - but not
only the indicators, you can't start out with 2 $a in your framework form.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 15 08:36:09 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 15 Jan 2020 07:36:09 +0000
Subject: [Koha-bugs] [Bug 23425] Search explodes with "invalid data,
 cannot decode object"
In-Reply-To: <bug-23425-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23425-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23425-70-OGPtvznSTW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23425

--- Comment #14 from Rudolf Byker <rudolfbyker at gmail.com> ---
Some feedback from my side after upgrading to 19.11:

There is an error with this bibliographic record, the view may be degraded.
Error: Invalid data, cannot decode object (id=32057, format=marcxml,
schema=MARC21, decoding_error=':27: parser error : PCDATA invalid Char value 27
<subfield code="a">Kp3s�benhavn :</subfield> ^ :27: parser error : PCDATA
invalid Char value 27 <subfield code="a">Kp3s�benhavn :</subfield> ^') 

So it looks like it has to do with how the ø in København is encoded. The book
is from Denmark.

Running "SELECT metadata FROM `biblio_metadata` where biblionumber=39335"
reveals a MARC record that says it's encoded in UTF-8, but $260a is definitely
in something other than UTF-8.

With Koha 19.11, I could simply click "Edit" and re-type the problematic field,
and everything works well from there. Thanks.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 15 08:56:32 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 15 Jan 2020 07:56:32 +0000
Subject: [Koha-bugs] [Bug 16123] Display budget hierarchy in the budget
 dropdown menu used when placing a new order
In-Reply-To: <bug-16123-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16123-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16123-70-k2fkhiXlWU@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16123

Kanittha Tanthong <jibkanittah at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jibkanittah at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 15 09:22:58 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 15 Jan 2020 08:22:58 +0000
Subject: [Koha-bugs] [Bug 20150] Acquisitions wizard falsely uses list price
 for calculating amounts spent
In-Reply-To: <bug-20150-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20150-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20150-70-09su9gWl0E@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20150

Maura Stephens <maura.stephens at gmit.ie> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |maura.stephens at gmit.ie

--- Comment #1 from Maura Stephens <maura.stephens at gmit.ie> ---
Katrin,
It is vital that this bug is resolved asap, and those running end of year stats
need to be aware of it. Acquisitions financial data integrity is key. I will
have had issued statistics for 2017, 2018 and 2019 without being aware of this
problem. It is by pure chance that I noticed something for 2019 that brought
this bug to my attention.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 15 09:31:12 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 15 Jan 2020 08:31:12 +0000
Subject: [Koha-bugs] [Bug 24340] We ought to be able to disable SIP using
 koha-sip
In-Reply-To: <bug-24340-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24340-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24340-70-0cVoECIes5@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24340

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #96813|0                           |1
        is obsolete|                            |

--- Comment #10 from David Nind <david at davidnind.com> ---
Created attachment 97379
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97379&action=edit
Bug 24340: allow koha-sip --disable inst

To test:

- Enable sip for your testing instance
 sudo koha-sip --enable inst
- Start sip for your testing instance
 sudo koha-sip --start inst
- Verify it is running
 ps ax |grep sip -> you should see processes
- Disable sip for your testing intance
 sudo koha-sip --disable inst
- Verify that the following has happened:
 * the SIPconfig.xml file has been moved to SIPconfig.xml.bak
 * SIP is no longer running for your instance - no SIP processes
 * SIP Cannot be started for the instance because of no config.

Signed-off-by: David Nind <david at davidnind.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 15 09:31:16 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 15 Jan 2020 08:31:16 +0000
Subject: [Koha-bugs] [Bug 24340] We ought to be able to disable SIP using
 koha-sip
In-Reply-To: <bug-24340-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24340-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24340-70-fMeBSDQW17@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24340

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #97360|0                           |1
        is obsolete|                            |

--- Comment #11 from David Nind <david at davidnind.com> ---
Created attachment 97380
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97380&action=edit
Bug 24340 (follow-up): Warning -> Information

Signed-off-by: David Nind <david at davidnind.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 15 09:31:20 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 15 Jan 2020 08:31:20 +0000
Subject: [Koha-bugs] [Bug 24340] We ought to be able to disable SIP using
 koha-sip
In-Reply-To: <bug-24340-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24340-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24340-70-B0g4eYSO05@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24340

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #97361|0                           |1
        is obsolete|                            |

--- Comment #12 from David Nind <david at davidnind.com> ---
Created attachment 97381
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97381&action=edit
Bug 24340 (follow-up): Add documentation to debian/docs/koha-sip.xml

Signed-off-by: David Nind <david at davidnind.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 15 09:36:17 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 15 Jan 2020 08:36:17 +0000
Subject: [Koha-bugs] [Bug 24418] Add Koha::Biblio->suggestions
In-Reply-To: <bug-24418-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24418-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24418-70-oX4OQ08AC9@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24418

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #97365|0                           |1
        is obsolete|                            |

--- Comment #8 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 97382
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97382&action=edit
Bug 24418: Add Koha::Biblio->suggestions

This patch adds the mentioned accessor. To test:

1. Apply this patch
2. Run:
   $ kshell
  k$ prove t/db_dependent/Koha/Biblio.t
=> SUCCESS: Tests pass
3. Sign off :-D

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 15 09:36:20 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 15 Jan 2020 08:36:20 +0000
Subject: [Koha-bugs] [Bug 24418] Add Koha::Biblio->suggestions
In-Reply-To: <bug-24418-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24418-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24418-70-VAVtQVYIyr@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24418

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #97366|0                           |1
        is obsolete|                            |

--- Comment #9 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 97383
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97383&action=edit
Bug 24418: Add koha_object(s)_class methods to Suggestion

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 15 09:36:24 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 15 Jan 2020 08:36:24 +0000
Subject: [Koha-bugs] [Bug 24418] Add Koha::Biblio->suggestions
In-Reply-To: <bug-24418-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24418-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24418-70-iHKpNyZhoj@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24418

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #97367|0                           |1
        is obsolete|                            |

--- Comment #10 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 97384
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97384&action=edit
Bug 24418: Unit tests

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 15 09:36:51 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 15 Jan 2020 08:36:51 +0000
Subject: [Koha-bugs] [Bug 24418] Add Koha::Biblio->suggestions
In-Reply-To: <bug-24418-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24418-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24418-70-Fk2USA5UI8@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24418

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |martin.renvoize at ptfs-europe
                   |                            |.com
             Status|Signed Off                  |Passed QA

--- Comment #11 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Simple clear code and passes qa scripts.. Passing QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 15 09:39:08 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 15 Jan 2020 08:39:08 +0000
Subject: [Koha-bugs] [Bug 24419] Add Koha::Suggestion->suggestor accessor
In-Reply-To: <bug-24419-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24419-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24419-70-jNAtUQDusr@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24419

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #97368|0                           |1
        is obsolete|                            |

--- Comment #3 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 97385
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97385&action=edit
Bug 24419: Add Koha::Suggestion->suggestor accessor

This patch adds a ->suggestor accessor to the Koha::Suggestion class. It
will return undef if no suggestor, and a Koha::Patron object otherwise.

To test:
1. Apply this patch
2. Run:
   $ kshell
  k$ prove t/db_dependent/Koha/Suggestion.t
=> SUCCESS: Tests pass!
3. Sign off :-D

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 15 09:39:50 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 15 Jan 2020 08:39:50 +0000
Subject: [Koha-bugs] [Bug 24419] Add Koha::Suggestion->suggestor accessor
In-Reply-To: <bug-24419-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24419-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24419-70-YPm6jxp5sB@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24419

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

--- Comment #4 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
All works as expected, passes qa test scripts.. Passing QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 15 09:41:35 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 15 Jan 2020 08:41:35 +0000
Subject: [Koha-bugs] [Bug 20150] Acquisitions wizard falsely uses list price
 for calculating amounts spent
In-Reply-To: <bug-20150-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20150-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20150-70-wiZmYHAX16@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20150

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|normal                      |major

--- Comment #2 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Hi Maura, I'd love to see this fixed, but probably won't have the time tow ork
on it myself. I reported this, as one of our libraries brought it to my
attention - but it didn't get any attention so far. I am updating the severity
a bit.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 15 09:45:10 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 15 Jan 2020 08:45:10 +0000
Subject: [Koha-bugs] [Bug 24292] Upgrade failed,
 from 19.05 to 19.11 on Ubuntu 19.10: Can't load Unaccent.so
In-Reply-To: <bug-24292-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24292-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24292-70-kfApQacBst@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24292

--- Comment #10 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
I would suggest the best approach is to wait for the release of 19.11.02 in a
few days in which this bug is resolved by the removal of the faulty library.

Beware, Koha is not yet officially supported on Debian 10 (Which is what I'm
guessing you are using here), there are some security issues and other
dependancy problems which are not highlighted as obviously as this one.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 15 09:51:20 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 15 Jan 2020 08:51:20 +0000
Subject: [Koha-bugs] [Bug 24292] Upgrade failed,
 from 19.05 to 19.11 on Ubuntu 19.10: Can't load Unaccent.so
In-Reply-To: <bug-24292-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24292-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24292-70-NtpvII4qqs@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24292

--- Comment #11 from Rudolf Byker <rudolfbyker at gmail.com> ---
Unfortunately, waiting was not an option. I have an office full of people
waiting to catalog new books on Koha :)

Is Debian 10 not supported yet? That is what I'm using, yes.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 15 10:11:11 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 15 Jan 2020 09:11:11 +0000
Subject: [Koha-bugs] [Bug 20150] Acquisitions wizard falsely uses list price
 for calculating amounts spent
In-Reply-To: <bug-20150-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20150-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20150-70-pdcfWC1j1Z@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20150

--- Comment #3 from Maura Stephens <maura.stephens at gmit.ie> ---
Thanks Katrin,
I've emailed some colleagues in the hope of getting a few more votes also. This
is quite major for our libraries as we only use Koha Acquisitions for our full
budget, and rely completely on it for accurate stats.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 15 10:26:22 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 15 Jan 2020 09:26:22 +0000
Subject: [Koha-bugs] [Bug 24391] Remove event attributes from patron clubs
 edit template
In-Reply-To: <bug-24391-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24391-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24391-70-0FNUDn29Lk@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24391

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|                            |20.05.00
        released in|                            |
             Status|Passed QA                   |Pushed to master

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 15 10:26:25 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 15 Jan 2020 09:26:25 +0000
Subject: [Koha-bugs] [Bug 24391] Remove event attributes from patron clubs
 edit template
In-Reply-To: <bug-24391-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24391-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24391-70-4d5YMRiL88@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24391

--- Comment #7 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Nice work everyone!

Pushed to master for 20.05

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 15 10:46:17 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 15 Jan 2020 09:46:17 +0000
Subject: [Koha-bugs] [Bug 24215] Warnings about guarantor relationships show
 ARRAY errors
In-Reply-To: <bug-24215-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24215-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24215-70-Yv0jUGEOoK@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24215

Rudolf Byker <rudolfbyker at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |rudolfbyker at gmail.com

--- Comment #15 from Rudolf Byker <rudolfbyker at gmail.com> ---
Sorry to rain on your parade, but after installing 19.11, with no relationships
in use whatsoever, I still get this on the about page:

=====

The following values have been used for guarantee/guarantor relationships, but
do not exist in the 'borrowerRelationship' system preference:

[Bullet point with no content]

If the relationship is one you want, please add it to the
'borrowerRelationship' system preference, otherwise have your system's
administrator correct the values in borrowers.relationship and/or
borrower_relationships.relationship in the database.

=====

Here is some info about my DB:

=====

select relationship, count(*) from borrowers group by
relationship;

relationship  count(*)  
NULL          6

=====

The borrower_relationships table is empty.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 15 10:50:48 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 15 Jan 2020 09:50:48 +0000
Subject: [Koha-bugs] [Bug 6759] Use a different account type for account
 renewals than for new accounts
In-Reply-To: <bug-6759-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-6759-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-6759-70-EdVhLddePG@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6759

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|RM_priority                 |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 15 10:51:33 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 15 Jan 2020 09:51:33 +0000
Subject: [Koha-bugs] [Bug 24339] SIP codes are missing from the default
 payment_types on installation
In-Reply-To: <bug-24339-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24339-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24339-70-9zCTFj39k0@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24339

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |colin.campbell at ptfs-europe.
                   |                            |com,
                   |                            |josef.moravec at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 15 11:00:52 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 15 Jan 2020 10:00:52 +0000
Subject: [Koha-bugs] [Bug 24082] Add a 'refund' option to anonymous payments
In-Reply-To: <bug-24082-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24082-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24082-70-GDUiSCNOPA@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24082

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |martin.renvoize at ptfs-europe
                   |ity.org                     |.com

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 15 12:29:52 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 15 Jan 2020 11:29:52 +0000
Subject: [Koha-bugs] [Bug 20567] "Holds per record (count)" limit is not
 enforced after item is captured for hold
In-Reply-To: <bug-20567-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20567-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20567-70-158fkOvh5v@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20567

--- Comment #14 from Kyle M Hall <kyle at bywatersolutions.com> ---
Based on Ben's response, my opinion is that this change in behavior does not
need to be syspref'ed at this time!

(In reply to Katrin Fischer from comment #13)
> (In reply to Benjamin Daeuber from comment #12)
> > We are the sponsoring library Kyle refers to. While we hadn't noticed this,
> > I guess I would agree with the opinion here, a hold in waiting status is
> > still a hold. 
> > 
> > That said, if someone wants a syspref, that's fine, but I guess everyone
> > here seems to agree waiting hold and pending holds ought to be counted
> > together.
> 
> Thx Benjamin for commenting!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 15 12:38:41 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 15 Jan 2020 11:38:41 +0000
Subject: [Koha-bugs] [Bug 20567] "Holds per record (count)" limit is not
 enforced after item is captured for hold
In-Reply-To: <bug-20567-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20567-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20567-70-fIFJ6CqGNt@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20567

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 15 12:38:44 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 15 Jan 2020 11:38:44 +0000
Subject: [Koha-bugs] [Bug 20567] "Holds per record (count)" limit is not
 enforced after item is captured for hold
In-Reply-To: <bug-20567-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20567-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20567-70-i6FGMEtXeE@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20567

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #97336|0                           |1
        is obsolete|                            |
  Attachment #97337|0                           |1
        is obsolete|                            |

--- Comment #15 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 97386
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97386&action=edit
Bug 20567: Add tests

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 15 12:39:03 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 15 Jan 2020 11:39:03 +0000
Subject: [Koha-bugs] [Bug 20567] "Holds per record (count)" limit is not
 enforced after item is captured for hold
In-Reply-To: <bug-20567-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20567-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20567-70-KlzFbeZ1Lf@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20567

--- Comment #16 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 97387
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97387&action=edit
Bug 20567: Count found holds for holds limit

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 15 12:44:30 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 15 Jan 2020 11:44:30 +0000
Subject: [Koha-bugs] [Bug 20567] "Holds per record (count)" limit is not
 enforced after item is captured for hold
In-Reply-To: <bug-20567-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20567-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20567-70-CV8Vay4fze@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20567

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #97386|0                           |1
        is obsolete|                            |
  Attachment #97387|0                           |1
        is obsolete|                            |

--- Comment #17 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 97388
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97388&action=edit
Bug 20567: Add tests

Signed-off-by: Hans Palsson <hans.palsson at hkr.se>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 15 12:44:38 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 15 Jan 2020 11:44:38 +0000
Subject: [Koha-bugs] [Bug 20567] "Holds per record (count)" limit is not
 enforced after item is captured for hold
In-Reply-To: <bug-20567-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20567-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20567-70-HdHsMVv9H9@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20567

--- Comment #18 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 97389
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97389&action=edit
Bug 20567: Count found holds for holds limit

Signed-off-by: Hans Palsson <hans.palsson at hkr.se>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 15 12:51:13 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 15 Jan 2020 11:51:13 +0000
Subject: [Koha-bugs] [Bug 21507] Decimal separators issues in patrons
 payments/fines, simplified
In-Reply-To: <bug-21507-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21507-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21507-70-qNaH1xdJBw@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21507

--- Comment #8 from Victor Grousset/tuxayo <victor at tuxayo.net> ---
The criticality came from bug 12310 .

I guess having fines truncated or multiplied by x100 was the cause of that
level ^^"

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 15 13:29:02 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 15 Jan 2020 12:29:02 +0000
Subject: [Koha-bugs] [Bug 24193] Add CodeMirror linting of JavaScript, CSS,
 HTML, and YAML system preferences
In-Reply-To: <bug-24193-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24193-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24193-70-6Krw2thUUf@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24193

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |oleonard at myacpl.org
                   |ity.org                     |

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 15 13:30:39 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 15 Jan 2020 12:30:39 +0000
Subject: [Koha-bugs] [Bug 18936] Convert issuingrules fields to
 circulation_rules
In-Reply-To: <bug-18936-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18936-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18936-70-nrFRQu22WH@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18936

Joonas Kylmälä <joonas.kylmala at helsinki.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Failed QA
                 CC|                            |joonas.kylmala at helsinki.fi

--- Comment #91 from Joonas Kylmälä <joonas.kylmala at helsinki.fi> ---
Hi Jonathan,

failing the patches "Bug 18936: More fixes", "Bug 18936: Fix Circulation.t",
"Bug 18936: Fix several issues" and "Bug 18936: Fix Update DB entry" since they
miss description of the changes so there is no way to know what is the intended
change here therefore testing will be super difficult. Also with "Bug 18936:
Fix several issues" it would be more logical to have then several commits for
those.

So I will take a look again once the descriptions of changes are added, ok?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 15 13:35:12 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 15 Jan 2020 12:35:12 +0000
Subject: [Koha-bugs] [Bug 17611] Searching for orders uses misleading column
 name "Pending order"
In-Reply-To: <bug-17611-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17611-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17611-70-3hxPeiy3vu@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17611

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 15 13:35:15 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 15 Jan 2020 12:35:15 +0000
Subject: [Koha-bugs] [Bug 17611] Searching for orders uses misleading column
 name "Pending order"
In-Reply-To: <bug-17611-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17611-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17611-70-SVhMz0Debr@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17611

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #97262|0                           |1
        is obsolete|                            |

--- Comment #6 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 97390
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97390&action=edit
Bug 17611: Change 'Pending order' to 'Quantity ordered'

Picking Quantity ordered as it seems more in line with
other pages in Koha where we show information. We always
show the quantity, so it makes sense to also have this
label on the 'order search' and 'copy existing order'.

Order search
1) Make sure you have some orders in your acq module
2) Go to the top and do an empty orders search
3) Review the column headings of the search results
4) Find "Pending order"

Order from existing order (copy)
1) Create or choose an existing open basket
2) 'Add to basket' - 'From existing orders'
3) Search to find some of your orders
4) Look at the column headings, find 'Pending order'
5) Pick some orders and fill out order information, save
6) Summary: Find 'Pending order' in the table again

x) Apply the patch and make sure all 'Pending' orders
above have been changed to 'Quantity ordered'.

Signed-off-by: Owen Leonard <oleonard at myacpl.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 15 13:45:23 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 15 Jan 2020 12:45:23 +0000
Subject: [Koha-bugs] [Bug 24415] Authority enhancement - Improve access to
 tabs
In-Reply-To: <bug-24415-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24415-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24415-70-Yn57hq6XNp@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24415

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
          Component|MARC Authority data support |Templates
           Assignee|koha-bugs at lists.koha-commun |oleonard at myacpl.org
                   |ity.org                     |

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 15 13:55:37 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 15 Jan 2020 12:55:37 +0000
Subject: [Koha-bugs] [Bug 23893] Add ->new_from_api and ->set_from_api
 methods to Koha::Object
In-Reply-To: <bug-23893-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23893-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23893-70-odwslKC0FO@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23893

--- Comment #49 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 97391
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97391&action=edit
Bug 23893: Special care for booleans

This patch acknowledges the fact that in D8 the Mojo::JSON->true and
Mojo::JSON->false values don't translate into integers when passed to
DBIC. It works correctly on D9 onwards, but we haven't formally
deprecated Jessie. This is adding back this translation, in the right
place now that all mappings code has been integrated into
Koha::Object(s) directly.

To test:
1. Apply this patch
2. Run:
   $ kshell
  k$ prove t/db_dependent/Koha/Object.t
=> SUCCESS: Tests pass!
3. Sign off :-D

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 15 14:27:44 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 15 Jan 2020 13:27:44 +0000
Subject: [Koha-bugs] [Bug 22569] Stock rotation: 'Transfers to send' report
In-Reply-To: <bug-22569-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22569-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22569-70-25iX2dnFzx@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22569

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |11529


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11529
[Bug 11529] Add subtitle, medium and part fields to biblio table
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 15 14:27:44 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 15 Jan 2020 13:27:44 +0000
Subject: [Koha-bugs] [Bug 11529] Add subtitle,
 medium and part fields to biblio table
In-Reply-To: <bug-11529-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-11529-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11529-70-RZkALWci5g@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11529

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |22569


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22569
[Bug 22569] Stock rotation: 'Transfers to send' report
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 15 14:33:20 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 15 Jan 2020 13:33:20 +0000
Subject: [Koha-bugs] [Bug 24364] Display item holding library in opac issues
In-Reply-To: <bug-24364-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24364-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24364-70-Fi8de1XuwD@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24364

--- Comment #10 from Owen Leonard <oleonard at myacpl.org> ---
(In reply to Katrin Fischer from comment #9)
> or could be a global setting - and then throw a colvis table configuration
> at that table :)

I agree that this change could be made without any patron-level limitations. I
don't even think the column configuration is necessary.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 15 14:34:51 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 15 Jan 2020 13:34:51 +0000
Subject: [Koha-bugs] [Bug 22569] Stock rotation: 'Transfers to send' report
In-Reply-To: <bug-22569-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22569-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22569-70-wwNO8WSpXA@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22569

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #96516|0                           |1
        is obsolete|                            |

--- Comment #23 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 97392
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97392&action=edit
Bug 22569: Add a 'Transfers to send' report

This patch adds a 'Transfers to send' report to the circulation page
which displays items which have been triggered for transfer by the stock
rotation subsystem.

Caveats:
1) It is currently limited to transfers prompted by stockrotation
2) There is no way to differentiate between a transfer that has been
   requested and a transfer than has been actually sent. (but we do
   filter out transfers that have been marked as received)
3) Both 'Advance' and 'Repatriate' actions will be listed and the
   'Advance' listings should have the option to set the item as 'In
   demand' at the current branch and thus cancel the transfer and
   make the item wait an additional stage period before being
   automatically set to transfer again.

   I believe we should enhance the transfers system as a whole to
   allow this report to be more meaningful and include transfer
   initiated via other means (along with appropriate actions to be
   taken upon them)

Test plan
1) Setup a rotation plan and add some items to it as per the
   manual
2) Run the stockrotation cronjob with the --execute flag
3) Check that the expected items appears in the new 'Transfers
   to send' page.

It does not yet catch items that are due for transfer by any other means
as at this time we do not store that sort of detail for other mechanisms.
See bug 23092 for one proposed resolution to that.

Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 15 14:34:55 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 15 Jan 2020 13:34:55 +0000
Subject: [Koha-bugs] [Bug 22569] Stock rotation: 'Transfers to send' report
In-Reply-To: <bug-22569-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22569-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22569-70-5IxQjHdozT@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22569

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #96517|0                           |1
        is obsolete|                            |

--- Comment #24 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 97393
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97393&action=edit
Bug 22569: Add Unit Tests

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 15 14:35:28 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 15 Jan 2020 13:35:28 +0000
Subject: [Koha-bugs] [Bug 24236] Using quotes in a cataloging search,
 resulting in multiple pages, will not allow you to advance page
In-Reply-To: <bug-24236-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24236-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24236-70-xdjNeRSFi0@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24236

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Needs Signoff

--- Comment #4 from Nick Clemens <nick at bywatersolutions.com> ---
(In reply to Myka Kennedy Stephens from comment #3)
> I cannot replicate the problem. Please provide further direction for testing.
> 
> Testing system = koha-testing-docker
> Versions tested = master, 19.11.x, 19.05.x
> Search engine = Zebra
> Search query = cat >> can page through results
> Search query = "cat" >> can page through results

I I try  search for "a" I end up at this URL:
http://localhost:8081/cgi-bin/koha/cataloguing/addbooks.pl?q=%22a%22

I cannot page forward from there, I get blank pages

If i hit:
http://localhost:8081/cgi-bin/koha/cataloguing/addbooks.pl?q=a

then I can page

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 15 14:36:35 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 15 Jan 2020 13:36:35 +0000
Subject: [Koha-bugs] [Bug 23893] Add ->new_from_api and ->set_from_api
 methods to Koha::Object
In-Reply-To: <bug-23893-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23893-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23893-70-ZX4va1pwWZ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23893

--- Comment #50 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Followup pushed

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 15 14:50:33 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 15 Jan 2020 13:50:33 +0000
Subject: [Koha-bugs] [Bug 21520] More complex OAI sets mappings
In-Reply-To: <bug-21520-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21520-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21520-70-AyXGbtUmGA@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21520

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |Manual,
                   |                            |release-notes-needed
                 CC|                            |martin.renvoize at ptfs-europe
                   |                            |.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 15 14:52:34 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 15 Jan 2020 13:52:34 +0000
Subject: [Koha-bugs] [Bug 21520] More complex OAI sets mappings
In-Reply-To: <bug-21520-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21520-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21520-70-0n2uzJHx6w@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21520

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Text to go in the|                            |Prior to this patchset, the
      release notes|                            |rules used to create OAI
                   |                            |sets are processed with the
                   |                            |'or'
                   |                            |boolean operator
                   |                            |between each rule.
                   |                            |
                   |                            |This
                   |                            |patch allows to use 'or' or
                   |                            |'and' between the rules.
                   |                            |
                   |                            |The evaluation of the rules
                   |                            |is done according to the
                   |                            |boolean operators
                   |                            |precedence: AND has a
                   |                            |higher precedence than OR.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 15 14:54:32 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 15 Jan 2020 13:54:32 +0000
Subject: [Koha-bugs] [Bug 24275] Inventory table should be sortable by title
 without leading articles (allow for title sort with anti-the)
In-Reply-To: <bug-24275-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24275-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24275-70-ZCHGpPwohW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24275

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|enhancement                 |trivial
                 CC|                            |martin.renvoize at ptfs-europe
                   |                            |.com

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 15 14:56:50 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 15 Jan 2020 13:56:50 +0000
Subject: [Koha-bugs] [Bug 20567] "Holds per record (count)" limit is not
 enforced after item is captured for hold
In-Reply-To: <bug-20567-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20567-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20567-70-D2qv9zjkgZ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20567

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|                            |20.05.00
        released in|                            |
             Status|Passed QA                   |Pushed to master

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 15 14:56:52 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 15 Jan 2020 13:56:52 +0000
Subject: [Koha-bugs] [Bug 20567] "Holds per record (count)" limit is not
 enforced after item is captured for hold
In-Reply-To: <bug-20567-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20567-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20567-70-RHp9hKiFjh@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20567

--- Comment #19 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Nice work everyone!

Pushed to master for 20.05

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 15 14:56:54 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 15 Jan 2020 13:56:54 +0000
Subject: [Koha-bugs] [Bug 21520] More complex OAI sets mappings
In-Reply-To: <bug-21520-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21520-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21520-70-dAQa5IJrVZ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21520

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to master
         Version(s)|                            |20.05.00
        released in|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 15 14:56:56 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 15 Jan 2020 13:56:56 +0000
Subject: [Koha-bugs] [Bug 21520] More complex OAI sets mappings
In-Reply-To: <bug-21520-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21520-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21520-70-UGGVpCHjRK@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21520

--- Comment #16 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Nice work everyone!

Pushed to master for 20.05

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 15 14:56:59 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 15 Jan 2020 13:56:59 +0000
Subject: [Koha-bugs] [Bug 24275] Inventory table should be sortable by title
 without leading articles (allow for title sort with anti-the)
In-Reply-To: <bug-24275-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24275-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24275-70-VnTjTuPP87@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24275

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|                            |20.05.00
        released in|                            |
             Status|Passed QA                   |Pushed to master

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 15 14:57:00 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 15 Jan 2020 13:57:00 +0000
Subject: [Koha-bugs] [Bug 24275] Inventory table should be sortable by title
 without leading articles (allow for title sort with anti-the)
In-Reply-To: <bug-24275-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24275-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24275-70-2VKaF0mtUc@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24275

--- Comment #5 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Nice work everyone!

Pushed to master for 20.05

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 15 15:00:21 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 15 Jan 2020 14:00:21 +0000
Subject: [Koha-bugs] [Bug 6473] Test bug for Git-bz
In-Reply-To: <bug-6473-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-6473-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-6473-70-PHQnc6V8d9@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6473

--- Comment #228 from ByWater Sandboxes <bws.sandboxes at gmail.com> ---
Created attachment 97394
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97394&action=edit
Bug 15686 - Rename "item level holds" circ rule column to "OPAC item level
holds"

This patch changes the column heading on smart-rules.pl to indicate that it
only effects item level holds on the OPAC side, rather than the intranet.
To test:
1. Go to Administration, circulation and fine rules.
2. Observe incorrect heading on both the top and bottom of the table.
3. Apply the patch.
4. Repeat step 1.
5. Observe new headings.

Signed-off-by: Liz Rea <wizzyrea at gmail.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 15 15:01:00 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 15 Jan 2020 14:01:00 +0000
Subject: [Koha-bugs] [Bug 6473] Test bug for Git-bz
In-Reply-To: <bug-6473-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-6473-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-6473-70-PZKaqYw32e@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6473

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |nick at bywatersolutions.com
  Attachment #97394|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 15 15:08:11 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 15 Jan 2020 14:08:11 +0000
Subject: [Koha-bugs] [Bug 24364] Display item holding library in opac issues
In-Reply-To: <bug-24364-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24364-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24364-70-IKXE14dbHd@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24364

--- Comment #11 from Matthias Meusburger <matthias.meusburger at biblibre.com> ---
Okay, I'll submit an update with an on-off syspref then. Thanks for the
feedback.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 15 15:26:36 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 15 Jan 2020 14:26:36 +0000
Subject: [Koha-bugs] [Bug 20567] "Holds per record (count)" limit is not
 enforced after item is captured for hold
In-Reply-To: <bug-20567-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20567-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20567-70-11li3toDIX@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20567

--- Comment #20 from Hans Pålsson <hans.palsson at hkr.se> ---
(In reply to Martin Renvoize from comment #19)
> Nice work everyone!
> 
> Pushed to master for 20.05

:-)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 15 15:46:36 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 15 Jan 2020 14:46:36 +0000
Subject: [Koha-bugs] [Bug 24215] Warnings about guarantor relationships show
 ARRAY errors
In-Reply-To: <bug-24215-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24215-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24215-70-QrkaAkDile@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24215

--- Comment #16 from Joy Nelson <joy at bywatersolutions.com> ---
This patch will not be in Koha until the 19.11.02 release which is scheduled
for next week.  It would not be in 19.11.00 or 19.11.01


(In reply to Rudolf Byker from comment #15)
> Sorry to rain on your parade, but after installing 19.11, with no
> relationships in use whatsoever, I still get this on the about page:
> 
> =====
> 
> The following values have been used for guarantee/guarantor relationships,
> but do not exist in the 'borrowerRelationship' system preference:
> 
> [Bullet point with no content]
> 
> If the relationship is one you want, please add it to the
> 'borrowerRelationship' system preference, otherwise have your system's
> administrator correct the values in borrowers.relationship and/or
> borrower_relationships.relationship in the database.
> 
> =====
> 
> Here is some info about my DB:
> 
> =====
> 
> select relationship, count(*) from borrowers group by
> relationship;
> 
> relationship  count(*) 	
> NULL          6
> 
> =====
> 
> The borrower_relationships table is empty.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 15 15:48:29 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 15 Jan 2020 14:48:29 +0000
Subject: [Koha-bugs] [Bug 24215] Warnings about guarantor relationships show
 ARRAY errors
In-Reply-To: <bug-24215-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24215-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24215-70-Ae6siLisw8@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24215

--- Comment #17 from Joy Nelson <joy at bywatersolutions.com> ---
Also, it seems like you are looking for this fix:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24263 which has not
yet been pushed to the 19.11.x branch.

joy

(In reply to Joy Nelson from comment #16)
> This patch will not be in Koha until the 19.11.02 release which is scheduled
> for next week.  It would not be in 19.11.00 or 19.11.01
> 
> 
> (In reply to Rudolf Byker from comment #15)
> > Sorry to rain on your parade, but after installing 19.11, with no
> > relationships in use whatsoever, I still get this on the about page:
> > 
> > =====
> > 
> > The following values have been used for guarantee/guarantor relationships,
> > but do not exist in the 'borrowerRelationship' system preference:
> > 
> > [Bullet point with no content]
> > 
> > If the relationship is one you want, please add it to the
> > 'borrowerRelationship' system preference, otherwise have your system's
> > administrator correct the values in borrowers.relationship and/or
> > borrower_relationships.relationship in the database.
> > 
> > =====
> > 
> > Here is some info about my DB:
> > 
> > =====
> > 
> > select relationship, count(*) from borrowers group by
> > relationship;
> > 
> > relationship  count(*) 	
> > NULL          6
> > 
> > =====
> > 
> > The borrower_relationships table is empty.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 15 15:50:16 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 15 Jan 2020 14:50:16 +0000
Subject: [Koha-bugs] [Bug 19014] Patrons should not get an 'on_reserve'
 notification if the due date is far into the future
In-Reply-To: <bug-19014-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19014-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19014-70-5VsIJYFlQa@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19014

ByWater Sandboxes <bws.sandboxes at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #96688|0                           |1
        is obsolete|                            |

--- Comment #59 from ByWater Sandboxes <bws.sandboxes at gmail.com> ---
Created attachment 97395
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97395&action=edit
Bug 19014: Unit tests

Signed-off-by: Andrew Fuerste-Henry <andrew at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 15 15:50:19 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 15 Jan 2020 14:50:19 +0000
Subject: [Koha-bugs] [Bug 19014] Patrons should not get an 'on_reserve'
 notification if the due date is far into the future
In-Reply-To: <bug-19014-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19014-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19014-70-KTpmOcfyVq@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19014

ByWater Sandboxes <bws.sandboxes at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #96689|0                           |1
        is obsolete|                            |

--- Comment #60 from ByWater Sandboxes <bws.sandboxes at gmail.com> ---
Created attachment 97396
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97396&action=edit
Bug 19014: Return auto_too_soon before on_reserve

When calling CanBookBeRenewed we do check for 'too_soon', however, a reserve
makes the return 'on_reserve' before other statuses. It seems the patron
specific reasons
should be returned first. This patch places the 'on_reserve' check after
too_soon and others

To test:
 1 - Checkout an item to a patron with a due date 2 days in the future and 'No
renewal before' unset
 2 - Place a hold on that item
 3 - Define an AUTO_RENEWALS circulation notice with below at a minimum
     [% checkout.auto_renew_error %]
 4 - perl misc/cronjobs/automatic_renewals.pl --send-notices
 5 - Patron is not notified
 6 - Set 'No renewal before' to 1
 7 - run cronjob
 8 - Patron is notified with error 'on_reserve'
 9 - Set 'No renewal before' to 3
10 - UPDATE issues SET auto_renew_error = NULL;
11 - run cronjob
12 - Patron is notified with error 'on_reserve'
13 - APPLY PATCH
14 - Unset 'No renewal before'
15 - UPDATE issues SET auto_renew_error = NULL;
16 - run cronjob
17 - Patron is not notified
18 - UPDATE issues SET auto_renew_error = NULL;
19 - Set 'No renewal before' to 1
20 - run cronjob
21 - Patron is notified with error 'on_reserve'
22 - Set 'No renewal before' to 3
23 - UPDATE issues SET auto_renew_error = NULL;
24 - run cronjob
25 - Patron is not notified

Signed-off-by: Andrew Fuerste-Henry <andrew at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 15 15:50:23 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 15 Jan 2020 14:50:23 +0000
Subject: [Koha-bugs] [Bug 19014] Patrons should not get an 'on_reserve'
 notification if the due date is far into the future
In-Reply-To: <bug-19014-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19014-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19014-70-DVI9jzTGQ9@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19014

ByWater Sandboxes <bws.sandboxes at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #97374|0                           |1
        is obsolete|                            |

--- Comment #61 from ByWater Sandboxes <bws.sandboxes at gmail.com> ---
Created attachment 97397
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97397&action=edit
Bug 19014: on_reserve blocks auto_renew

Signed-off-by: Andrew Fuerste-Henry <andrew at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 15 15:53:11 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 15 Jan 2020 14:53:11 +0000
Subject: [Koha-bugs] [Bug 19014] Patrons should not get an 'on_reserve'
 notification if the due date is far into the future
In-Reply-To: <bug-19014-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19014-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19014-70-LvreGe1rWb@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19014

Andrew Fuerste-Henry <andrew at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

--- Comment #62 from Andrew Fuerste-Henry <andrew at bywatersolutions.com> ---
Modified test plan:

 1 - Checkout an item to a patron with a due date 2 days in the future and 'No
renewal before' unset
 2 - Place a hold on that item
 3 - Define an AUTO_RENEWALS circulation notice with below at a minimum
     [% checkout.auto_renew_error %]
 4 - perl misc/cronjobs/automatic_renewals.pl --send-notices
 5 - Patron is not notified
 6 - Set 'No renewal before' to 1
 7 - run cronjob
 8 - Patron is notified with error 'on_reserve'
 9 - Set 'No renewal before' to 3
10 - UPDATE issues SET auto_renew_error = NULL;
11 - run cronjob
12 - Patron is notified with error 'on_reserve'
13 - APPLY PATCH
14 - Unset 'No renewal before'
15 - UPDATE issues SET auto_renew_error = NULL;
16 - run cronjob
17 - Patron is not notified
18 - UPDATE issues SET auto_renew_error = NULL;
19 - Set 'No renewal before' to 2
20 - run cronjob
21 - Patron is notified with error 'on_reserve'
22 - Set 'No renewal before' to 3
23 - UPDATE issues SET auto_renew_error = NULL;
24 - run cronjob
25 - Patron is notified with error 'on_reserve'

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 15 15:57:37 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 15 Jan 2020 14:57:37 +0000
Subject: [Koha-bugs] [Bug 24428] New: Elastic search index does not contain
 consistent item information
Message-ID: <bug-24428-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24428

            Bug ID: 24428
           Summary: Elastic search index does not contain consistent item
                    information
 Change sponsored?: ---
           Product: Koha
           Version: 18.11
          Hardware: PC
                OS: Linux
            Status: NEW
          Severity: critical
          Priority: P5 - low
         Component: Searching - Elasticsearch
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: david.holoshka at ub.lu.se

Probably when catmandu was removed from the indexing process the item
information organization was lost.  

For example whenever there is more than a one copy of an item any item's
missing information is just omitted from the es array - no place holder is
used.  Previously the 3rd item's information was always found in the 3 position
in the items fields now this can no longer be assumed because if item 1 or 2 is
missing data for this field then the 3rd item's information is placed in either
position 1 or 2. 

This means that es can not be used to extract item information extra database
look ups are required.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 15 16:05:37 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 15 Jan 2020 15:05:37 +0000
Subject: [Koha-bugs] [Bug 24428] Elastic search index does not contain
 consistent item information
In-Reply-To: <bug-24428-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24428-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24428-70-O3el73PWW3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24428

--- Comment #1 from david holoshka <david.holoshka at ub.lu.se> ---
also the local-classification for a single item is stored using multiple array
positions in elastic search instead of a single array element.  This breaks
with the previous structure of storage.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 15 16:34:46 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 15 Jan 2020 15:34:46 +0000
Subject: [Koha-bugs] [Bug 23929] Invoice adjustments should filter inactive
 funds
In-Reply-To: <bug-23929-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23929-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23929-70-p15XmNdngx@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23929

Marjorie Barry-Vila <marjorie.barry-vila at collecto.ca> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |marjorie.barry-vila at collect
                   |                            |o.ca

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 15 16:37:14 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 15 Jan 2020 15:37:14 +0000
Subject: [Koha-bugs] [Bug 23929] Invoice adjustments should filter inactive
 funds
In-Reply-To: <bug-23929-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23929-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23929-70-PIIVWfYGgo@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23929

Patrick Robitaille <patrick.robitaille at collecto.ca> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |patrick.robitaille at collecto
                   |                            |.ca

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 15 16:38:37 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 15 Jan 2020 15:38:37 +0000
Subject: [Koha-bugs] [Bug 24423] Broken link to return to record after batch
 item modification
In-Reply-To: <bug-24423-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24423-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24423-70-cppKjXGtJ7@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24423

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 15 16:38:39 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 15 Jan 2020 15:38:39 +0000
Subject: [Koha-bugs] [Bug 24423] Broken link to return to record after batch
 item modification
In-Reply-To: <bug-24423-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24423-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24423-70-H3sXnBq0nZ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24423

--- Comment #1 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 97398
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97398&action=edit
Bug 24423: Add biblionumber to modify items link

To test:
- Find/create a bib with at least one item
- From detail.pl, use the checkboxes in the holdings table to select one or
more items
- click the "Modify Selected Items" link just above the holdings table to take
your item(s) to batch modification
- Change something and click save
- Observe that the Return to the Record link points to a url without a
biblionumber: "/cgi-bin/koha/catalogue/detail.pl?biblionumber="
- Apply patch
- Repeat
- The link now works!

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 15 16:48:20 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 15 Jan 2020 15:48:20 +0000
Subject: [Koha-bugs] [Bug 15377] Remove 'checked out' items from course
 reserves
In-Reply-To: <bug-15377-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15377-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15377-70-xxaj0kMWHe@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15377

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #97369|application/mbox            |text/plain
          mime type|                            |
  Attachment #97369|0                           |1
           is patch|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 15 16:49:29 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 15 Jan 2020 15:49:29 +0000
Subject: [Koha-bugs] [Bug 15377] Remove 'checked out' items from course
 reserves
In-Reply-To: <bug-15377-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15377-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15377-70-tTF16RDjT0@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15377

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 15 16:54:11 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 15 Jan 2020 15:54:11 +0000
Subject: [Koha-bugs] [Bug 23929] Invoice adjustments should filter inactive
 funds
In-Reply-To: <bug-23929-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23929-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23929-70-QFAeQBLDSt@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23929

sandboxes at biblibre.com <sandboxes at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |sandboxes at biblibre.com
             Status|Needs Signoff               |Signed Off

--- Comment #3 from sandboxes at biblibre.com <sandboxes at biblibre.com> ---
Patch tested with a sandbox, by Marjorie Barry-Vila
<marjorie.barry-vila at collecto.ca>

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 15 16:54:28 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 15 Jan 2020 15:54:28 +0000
Subject: [Koha-bugs] [Bug 23929] Invoice adjustments should filter inactive
 funds
In-Reply-To: <bug-23929-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23929-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23929-70-OTztsDnHLf@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23929

sandboxes at biblibre.com <sandboxes at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #97354|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 15 16:54:36 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 15 Jan 2020 15:54:36 +0000
Subject: [Koha-bugs] [Bug 23929] Invoice adjustments should filter inactive
 funds
In-Reply-To: <bug-23929-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23929-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23929-70-H7FlGaMoxZ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23929

--- Comment #4 from sandboxes at biblibre.com <sandboxes at biblibre.com> ---
Created attachment 97399
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97399&action=edit
Bug 23929 - Invoice adjustments should filter inactive funds

Signed-off-by: Marjorie Barry-Vila <marjorie.barry-vila at collecto.ca>

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 15 17:21:34 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 15 Jan 2020 16:21:34 +0000
Subject: [Koha-bugs] [Bug 21520] More complex OAI sets mappings
In-Reply-To: <bug-21520-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21520-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21520-70-OaZ7zKG21G@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21520

--- Comment #17 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
OK, I added the kohastructure update inline during push.. and made the DB
update idempotent

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 15 17:22:42 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 15 Jan 2020 16:22:42 +0000
Subject: [Koha-bugs] [Bug 24423] Broken link to return to record after batch
 item modification
In-Reply-To: <bug-24423-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24423-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24423-70-wmByfXvVyp@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24423

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |nick at bywatersolutions.com
           Assignee|koha-bugs at lists.koha-commun |nick at bywatersolutions.com
                   |ity.org                     |

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 15 17:23:13 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 15 Jan 2020 16:23:13 +0000
Subject: [Koha-bugs] [Bug 24429] New: Advanced editor - Add ability to
 generate an export file as cataloger saves
Message-ID: <bug-24429-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24429

            Bug ID: 24429
           Summary: Advanced editor - Add ability to generate an export
                    file as cataloger saves
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Cataloging
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: carnold at dgiinc.com
        QA Contact: testopia at bugs.koha-community.org
                CC: m.de.rooy at rijksmuseum.nl

Catalogers here are looking for a way to generate an export file (to send to
clients) as they are copy cataloging and saving a records. This feature should
be similar to OCLC's "local files" and ITS's "Save to... Export File" feature.
In other words, once the cataloger has set up to Save to an export file all
future saves are saved to that export file until the feature is turned off.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 15 17:33:13 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 15 Jan 2020 16:33:13 +0000
Subject: [Koha-bugs] [Bug 24420] Cataloging search results Location column
 should account for waiting on hold items
In-Reply-To: <bug-24420-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24420-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24420-70-gw6bXu73Hn@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24420

Lucas Gass <lucas at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |lucas at bywatersolutions.com
                   |ity.org                     |

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 15 17:36:54 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 15 Jan 2020 16:36:54 +0000
Subject: [Koha-bugs] [Bug 24008] Attempting to delete a patron with
 outstanding credits should warn and block the deletion
In-Reply-To: <bug-24008-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24008-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24008-70-i7cDTibQeb@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24008

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #95924|0                           |1
        is obsolete|                            |

--- Comment #10 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 97400
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97400&action=edit
Bug 24008: Display a warning message when deleting a patron with outstanding
credits

So far nothing is displayed if a librarian removes patron with
outstanding credits.
Note that outstanding debits blocks the deletion.

Test plan:
- Create a patron with outstanding credit
- Create a patron with outstanding debits
- Delete the 2 patrons
=> With credit - You get a warning but do not block the deletion
=> With debits - You get a warning message that blocks the deletion

Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 15 17:36:57 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 15 Jan 2020 16:36:57 +0000
Subject: [Koha-bugs] [Bug 24008] Attempting to delete a patron with
 outstanding credits should warn and block the deletion
In-Reply-To: <bug-24008-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24008-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24008-70-ubzotSVDer@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24008

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #96142|0                           |1
        is obsolete|                            |

--- Comment #11 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 97401
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97401&action=edit
Bug 24008: Display warnings in a list

Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 15 17:37:00 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 15 Jan 2020 16:37:00 +0000
Subject: [Koha-bugs] [Bug 24008] Attempting to delete a patron with
 outstanding credits should warn and block the deletion
In-Reply-To: <bug-24008-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24008-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24008-70-c3OwcQl6pg@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24008

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #96604|0                           |1
        is obsolete|                            |

--- Comment #12 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 97402
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97402&action=edit
Bug 24008: Remove minus sign when displaying credit value

Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 15 17:37:39 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 15 Jan 2020 16:37:39 +0000
Subject: [Koha-bugs] [Bug 24008] Attempting to delete a patron with
 outstanding credits should warn and block the deletion
In-Reply-To: <bug-24008-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24008-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24008-70-9XOqNV15nC@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24008

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

--- Comment #13 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Works well, signing off.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 15 17:43:28 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 15 Jan 2020 16:43:28 +0000
Subject: [Koha-bugs] [Bug 24009] Koha::Account->outstanding_debits should
 support inline filtering
In-Reply-To: <bug-24009-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24009-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24009-70-BkMhdLtFf5@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24009

--- Comment #7 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Good catch... we've hardly settled on a pattern yet but I think your right,
that's the closest we got so far.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 15 17:55:29 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 15 Jan 2020 16:55:29 +0000
Subject: [Koha-bugs] [Bug 19419] 008 Material type reverts Book
In-Reply-To: <bug-19419-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19419-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19419-70-mTi64qcmHa@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19419

Heather <heather_hernandez at nps.gov> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |heather_hernandez at nps.gov

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 15 18:01:17 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 15 Jan 2020 17:01:17 +0000
Subject: [Koha-bugs] [Bug 16787] 'Too many holds' message appears
 inappropriately and is missing data
In-Reply-To: <bug-16787-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16787-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16787-70-dKaWOenKUL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16787

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #96152|0                           |1
        is obsolete|                            |

--- Comment #21 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 97403
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97403&action=edit
Bug 16787: 'Too many holds' message appears inappropriately and is missing data

This patch alters C4/Reserves.pm to pass back 'noReservesAllowed' when
allowedreserves=0. This allows passing to the user an appropriate
message about the availability of items for holds

This patch also fixes a FIXME about using effective_itemtype to fetch item
rules

To test:
1 - Set one itemtype to allow no holds
2 - Set 'Holds per record' to 0 for another itemtype/patron combination
3 - Create or find 2 records, each with items only of the itemtypes above
3 - Attempt to place a hold for a patron on each record above
4 - The message will be 'Too many holds'
5 - Apply patch and repeat
6 - Message should be "No holds allowed: [Firstname Surname] cannot
place holds on any of these items"
7 - Try placing a multihold with either record above and a holdable record,
  message should end "...cannot place holds on some of these titles'
  items"
8 - prove -v t/db_dependent/Holds.t

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 15 18:08:08 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 15 Jan 2020 17:08:08 +0000
Subject: [Koha-bugs] [Bug 24422] Advanced search shelving locations are
 restricted to the same restrictions as cataloging
In-Reply-To: <bug-24422-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24422-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24422-70-GNEG3B7eCD@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24422

George Williams (NEKLS) <george at nekls.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |george at nekls.org

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 15 18:10:52 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 15 Jan 2020 17:10:52 +0000
Subject: [Koha-bugs] [Bug 14007] Item Types for items hidden by
 OpacHiddenItems turn up in facet results
In-Reply-To: <bug-14007-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14007-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14007-70-pTvSvpvYwJ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14007

George Williams (NEKLS) <george at nekls.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |bugzilla at koha-us.org,
                   |                            |george at nekls.org

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 15 18:11:44 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 15 Jan 2020 17:11:44 +0000
Subject: [Koha-bugs] [Bug 24422] Advanced search shelving locations are
 restricted to the same restrictions as cataloging
In-Reply-To: <bug-24422-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24422-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24422-70-w5VTw01fuh@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24422

George Williams (NEKLS) <george at nekls.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |bugzilla at koha-us.org

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 15 18:12:15 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 15 Jan 2020 17:12:15 +0000
Subject: [Koha-bugs] [Bug 24371] OPAC 'Showing only available items/Show all
 items' is double encoded
In-Reply-To: <bug-24371-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24371-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24371-70-K714hS9oYq@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24371

George Williams (NEKLS) <george at nekls.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |bugzilla at koha-us.org,
                   |                            |george at nekls.org

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 15 18:12:36 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 15 Jan 2020 17:12:36 +0000
Subject: [Koha-bugs] [Bug 18986] High Hold Items with Decreased Loan Period
 Can't Be Checked-Out with Self-Check
In-Reply-To: <bug-18986-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18986-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18986-70-yGb4zG66KU@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18986

George Williams (NEKLS) <george at nekls.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |bugzilla at koha-us.org,
                   |                            |george at nekls.org

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 15 18:14:09 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 15 Jan 2020 17:14:09 +0000
Subject: [Koha-bugs] [Bug 24364] Display item holding library in opac issues
In-Reply-To: <bug-24364-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24364-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24364-70-7qP3bTFVbf@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24364

--- Comment #12 from Owen Leonard <oleonard at myacpl.org> ---
(In reply to Matthias Meusburger from comment #11)
> Okay, I'll submit an update with an on-off syspref then. Thanks for the
> feedback.

I don't even think this needs a syspref. In my opinion it's relevant
information to show.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 15 18:26:47 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 15 Jan 2020 17:26:47 +0000
Subject: [Koha-bugs] [Bug 24377] Record branch in statistics for auto-renewal
In-Reply-To: <bug-24377-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24377-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24377-70-GAaMSrXhBK@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24377

Daniel Gaghan <daniel.gaghan at pueblolibrary.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |daniel.gaghan at pueblolibrary
                   |                            |.org

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 15 18:44:04 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 15 Jan 2020 17:44:04 +0000
Subject: [Koha-bugs] [Bug 24352] OpacItemLocation is buggy
In-Reply-To: <bug-24352-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24352-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24352-70-iueh4m7mdX@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24352

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Signed Off

--- Comment #8 from Owen Leonard <oleonard at myacpl.org> ---
(In reply to Katrin Fischer from comment #7)
> Collection(s): . 

It still sounds to me like the item must not have a call number. Even if the
items have no location, for instance, the call numbers show up for me:

https://zivotdesign.com/p/view.php?p=15791100203899

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 15 18:56:17 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 15 Jan 2020 17:56:17 +0000
Subject: [Koha-bugs] [Bug 24429] Advanced editor - Add ability to generate
 an export file as cataloger saves
In-Reply-To: <bug-24429-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24429-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24429-70-Ut5kC0Gqfq@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24429

Cori Lynn Arnold <carnold at dgiinc.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |carnold at dgiinc.com
                   |ity.org                     |

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 15 18:58:07 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 15 Jan 2020 17:58:07 +0000
Subject: [Koha-bugs] [Bug 24166] Barcode removal breaks
 circulation.pl/moremember.pl
In-Reply-To: <bug-24166-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24166-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24166-70-EjklfLAiXY@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24166

Lucas Gass <lucas at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to stable            |Pushed to oldstable
                 CC|                            |lucas at bywatersolutions.com

--- Comment #6 from Lucas Gass <lucas at bywatersolutions.com> ---
backported to 19.05.x for 19.05.07

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 15 18:59:49 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 15 Jan 2020 17:59:49 +0000
Subject: [Koha-bugs] [Bug 15686] Rename "item level holds" circ rule column
 to "OPAC item level holds"
In-Reply-To: <bug-15686-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15686-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15686-70-J93l8AFanJ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15686

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |nick at bywatersolutions.com
         QA Contact|testopia at bugs.koha-communit |katrin.fischer at bsz-bw.de
                   |y.org                       |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 15 19:10:12 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 15 Jan 2020 18:10:12 +0000
Subject: [Koha-bugs] [Bug 24429] Advanced editor - Add ability to generate
 an export file as cataloger saves
In-Reply-To: <bug-24429-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24429-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24429-70-y3gw65J6Fu@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24429

Cori Lynn Arnold <carnold at dgiinc.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff
   Patch complexity|---                         |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 15 19:10:15 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 15 Jan 2020 18:10:15 +0000
Subject: [Koha-bugs] [Bug 24429] Advanced editor - Add ability to generate
 an export file as cataloger saves
In-Reply-To: <bug-24429-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24429-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24429-70-QwPTwp9Scs@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24429

--- Comment #1 from Cori Lynn Arnold <carnold at dgiinc.com> ---
Created attachment 97404
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97404&action=edit
Bug 24429: Advanced editor - Add ability to generate an export file as
cataloger saves

Adds the ability for catalogers to *automatically* save a list of bibs to
export as they
are cataloging.

To test, apply patch:
0/Verify that the advanced editor is enabled by going to
"Administration" and searching for "EnableAdvancedCatalogingEditor"
1/Set it to "Enable" if it isn't already.
2/Go to "Cataloging", click on "Advanced editor"
3/Click on "Export" button (verify a modal window comes up)
4/Click on the link for "New Export File", name the export file
5/Close the modal window
6/Search for a record by entering "specious" in the keyword box and
hitting enter
7/Click "import" on a record
8/Make some changes and hit "Save", note the bib number
9/Repeat steps 6-8 for several records
10/Click on "Export" button
11/Click on the link for the name you created in step 4
12/Verify the bib numbers from step 8 are in the Export Files Editor
13/Click "Generate Export File"
14/Verify that all the records for every bib listed is in the file
generated
15/Repeat steps with different file names / records

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 15 19:14:49 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 15 Jan 2020 18:14:49 +0000
Subject: [Koha-bugs] [Bug 24423] Broken link to return to record after batch
 item modification
In-Reply-To: <bug-24423-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24423-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24423-70-eqUXSzK0SM@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24423

ByWater Sandboxes <bws.sandboxes at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #97398|0                           |1
        is obsolete|                            |

--- Comment #2 from ByWater Sandboxes <bws.sandboxes at gmail.com> ---
Created attachment 97405
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97405&action=edit
Bug 24423: Add biblionumber to modify items link

To test:
- Find/create a bib with at least one item
- From detail.pl, use the checkboxes in the holdings table to select one or
more items
- click the "Modify Selected Items" link just above the holdings table to take
your item(s) to batch modification
- Change something and click save
- Observe that the Return to the Record link points to a url without a
biblionumber: "/cgi-bin/koha/catalogue/detail.pl?biblionumber="
- Apply patch
- Repeat
- The link now works!

Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 15 19:17:22 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 15 Jan 2020 18:17:22 +0000
Subject: [Koha-bugs] [Bug 24423] Broken link to return to record after batch
 item modification
In-Reply-To: <bug-24423-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24423-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24423-70-4Ti49jHCuS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24423

--- Comment #3 from ByWater Sandboxes <bws.sandboxes at gmail.com> ---
Created attachment 97406
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97406&action=edit
Bug 24236: Fix pagination to use query_cgi

This is still wrong, we should use page-numbers.inc, but that is a larger
refactoring
This patch fixes non-QueryParser searches by simple getting an using the
escaped query (query_cgi)

For QueryParser, we do what the QP code does, just uri escape the query - the
way that SimpleSearch does the query parsing instead of the usual buildQuery
suggest to me that we should probably switch all of this to use the general
Zebra search.

The issues with reservoir should be their own bug

To test:
1 - Search for cat in cataloging search
2 - Get results and see you can paginate
3 - Search for "cat"
4 - Get results but subsequent pages empty
5 - Apply patch
6 - Repeat search for "cat"
7 - You can paginate
8 - Enable UseQueryParser syspref (don't worry about installing)
9 - Confirm can still search with quotes and paginate

Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 15 19:19:13 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 15 Jan 2020 18:19:13 +0000
Subject: [Koha-bugs] [Bug 24208] Remove change calculation for writeoffs
In-Reply-To: <bug-24208-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24208-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24208-70-8LcyQzaugY@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24208

Lucas Gass <lucas at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |lucas at bywatersolutions.com

--- Comment #11 from Lucas Gass <lucas at bywatersolutions.com> ---
patchset doesn't clean apply to 19.05.x, please rebase if needed

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 15 19:20:35 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 15 Jan 2020 18:20:35 +0000
Subject: [Koha-bugs] [Bug 24423] Broken link to return to record after batch
 item modification
In-Reply-To: <bug-24423-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24423-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24423-70-OmRG0BDEiC@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24423

Lisette Scheer <lisetteslatah at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |lisetteslatah at gmail.com
  Attachment #97406|0                           |1
        is obsolete|                            |

--- Comment #4 from Lisette Scheer <lisetteslatah at gmail.com> ---
Comment on attachment 97406
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97406
Bug 24236: Fix pagination to use query_cgi

This was incorrectly signed off to the wrong patch during a sandbox webinar.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 15 19:21:24 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 15 Jan 2020 18:21:24 +0000
Subject: [Koha-bugs] [Bug 24317] Sample patron data not loading for
 non-English installations
In-Reply-To: <bug-24317-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24317-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24317-70-uXJ8k0waxF@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24317

Lucas Gass <lucas at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |lucas at bywatersolutions.com

--- Comment #6 from Lucas Gass <lucas at bywatersolutions.com> ---
missing dependencies for 19.05.x, no backport

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 15 19:21:34 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 15 Jan 2020 18:21:34 +0000
Subject: [Koha-bugs] [Bug 24317] Sample patron data not loading for
 non-English installations
In-Reply-To: <bug-24317-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24317-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24317-70-pLDVIpapLW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24317

Lucas Gass <lucas at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to master            |RESOLVED
         Resolution|---                         |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 15 19:23:11 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 15 Jan 2020 18:23:11 +0000
Subject: [Koha-bugs] [Bug 24244] Cannot create suggestion with branch set to
 'Any'
In-Reply-To: <bug-24244-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24244-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24244-70-QXdpvcm7ig@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24244

Lucas Gass <lucas at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to master            |Pushed to stable
                 CC|                            |lucas at bywatersolutions.com

--- Comment #15 from Lucas Gass <lucas at bywatersolutions.com> ---
pushed to 19.11.x for 19.11.02

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 15 19:26:59 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 15 Jan 2020 18:26:59 +0000
Subject: [Koha-bugs] [Bug 24244] Cannot create suggestion with branch set to
 'Any'
In-Reply-To: <bug-24244-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24244-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24244-70-Imh3X62JkG@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24244

Lucas Gass <lucas at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to stable            |Pushed to oldstable

--- Comment #16 from Lucas Gass <lucas at bywatersolutions.com> ---
backported to 19.05.x for 19.05.07

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 15 19:37:36 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 15 Jan 2020 18:37:36 +0000
Subject: [Koha-bugs] [Bug 24282] SCSS conversion broke style in search
 results item status
In-Reply-To: <bug-24282-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24282-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24282-70-CtoYOdeqPD@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24282

Lucas Gass <lucas at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to master            |Pushed to stable

--- Comment #6 from Lucas Gass <lucas at bywatersolutions.com> ---
backported to 19.05.x for 19.05.07

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 15 19:37:46 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 15 Jan 2020 18:37:46 +0000
Subject: [Koha-bugs] [Bug 24282] SCSS conversion broke style in search
 results item status
In-Reply-To: <bug-24282-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24282-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24282-70-EtyvUb4BIh@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24282

Lucas Gass <lucas at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to stable            |Pushed to oldstable

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 15 19:39:29 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 15 Jan 2020 18:39:29 +0000
Subject: [Koha-bugs] [Bug 23783] Add display of languages from MARC21 field
 041 to the OPAC
In-Reply-To: <bug-23783-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23783-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23783-70-ahgxdfDAoJ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23783

Lucas Gass <lucas at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to master            |Pushed to stable
                 CC|                            |lucas at bywatersolutions.com

--- Comment #6 from Lucas Gass <lucas at bywatersolutions.com> ---
backported to 19.11.x for 19.11.02

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 15 19:39:51 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 15 Jan 2020 18:39:51 +0000
Subject: [Koha-bugs] [Bug 23783] Add display of languages from MARC21 field
 041 to the OPAC
In-Reply-To: <bug-23783-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23783-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23783-70-w81U4lSltn@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23783

Lucas Gass <lucas at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to stable            |RESOLVED
         Resolution|---                         |FIXED

--- Comment #7 from Lucas Gass <lucas at bywatersolutions.com> ---
missing dependencies for 19.05.x, no backport

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 15 19:42:28 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 15 Jan 2020 18:42:28 +0000
Subject: [Koha-bugs] [Bug 24316] Fix non-English web installers by removing
 obsolete authorised value MANUAL_INV
In-Reply-To: <bug-24316-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24316-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24316-70-kxycVsGSCK@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24316

Lucas Gass <lucas at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |lucas at bywatersolutions.com

--- Comment #13 from Lucas Gass <lucas at bywatersolutions.com> ---
missing dependencies for 19.05.x, no backport

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 15 19:42:37 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 15 Jan 2020 18:42:37 +0000
Subject: [Koha-bugs] [Bug 24316] Fix non-English web installers by removing
 obsolete authorised value MANUAL_INV
In-Reply-To: <bug-24316-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24316-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24316-70-D9m4KNuYMZ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24316

Lucas Gass <lucas at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to stable            |RESOLVED
         Resolution|---                         |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 15 19:43:24 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 15 Jan 2020 18:43:24 +0000
Subject: [Koha-bugs] [Bug 24236] Using quotes in a cataloging search,
 resulting in multiple pages, will not allow you to advance page
In-Reply-To: <bug-24236-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24236-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24236-70-ECU2z87GOR@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24236

ByWater Sandboxes <bws.sandboxes at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #96264|0                           |1
        is obsolete|                            |

--- Comment #5 from ByWater Sandboxes <bws.sandboxes at gmail.com> ---
Created attachment 97407
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97407&action=edit
Bug 24236: Fix pagination to use query_cgi

This is still wrong, we should use page-numbers.inc, but that is a larger
refactoring
This patch fixes non-QueryParser searches by simple getting an using the
escaped query (query_cgi)

For QueryParser, we do what the QP code does, just uri escape the query - the
way that SimpleSearch does the query parsing instead of the usual buildQuery
suggest to me that we should probably switch all of this to use the general
Zebra search.

The issues with reservoir should be their own bug

To test:
1 - Search for cat in cataloging search
2 - Get results and see you can paginate
3 - Search for "cat"
4 - Get results but subsequent pages empty
5 - Apply patch
6 - Repeat search for "cat"
7 - You can paginate
8 - Enable UseQueryParser syspref (don't worry about installing)
9 - Confirm can still search with quotes and paginate

Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 15 19:45:51 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 15 Jan 2020 18:45:51 +0000
Subject: [Koha-bugs] [Bug 16784] Add table configuration on suggestions table
In-Reply-To: <bug-16784-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16784-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16784-70-tiMIhiXZlI@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16784

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 15 19:45:54 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 15 Jan 2020 18:45:54 +0000
Subject: [Koha-bugs] [Bug 16784] Add table configuration on suggestions table
In-Reply-To: <bug-16784-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16784-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16784-70-EoPh5wRcWQ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16784

--- Comment #8 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 97408
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97408&action=edit
Bug 16784: (follow-up) Add missing filter

This follow-up adds a missing template filter quiet qa tool warning.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 15 19:49:36 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 15 Jan 2020 18:49:36 +0000
Subject: [Koha-bugs] [Bug 21674] Data integrity not enforced for library
 groups
In-Reply-To: <bug-21674-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21674-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21674-70-HkXBQ5CJcr@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21674

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Failed QA
                 CC|                            |nick at bywatersolutions.com

--- Comment #3 from Nick Clemens <nick at bywatersolutions.com> ---
Tested on a sandbox, did not work

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 15 19:50:15 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 15 Jan 2020 18:50:15 +0000
Subject: [Koha-bugs] [Bug 18546] Unhide the 'Hide window' link in OPAC cart
In-Reply-To: <bug-18546-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18546-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18546-70-OEzJTB4BvE@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18546

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|Patch doesn't apply         |RESOLVED

--- Comment #12 from Owen Leonard <oleonard at myacpl.org> ---
This looks to me to be fixed now.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 15 19:50:56 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 15 Jan 2020 18:50:56 +0000
Subject: [Koha-bugs] [Bug 16959] E-mail alerts for saved searches
In-Reply-To: <bug-16959-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16959-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16959-70-SVXUNcOvNm@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16959

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|oleonard at myacpl.org         |koha-bugs at lists.koha-commun
                   |                            |ity.org

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 15 19:51:09 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 15 Jan 2020 18:51:09 +0000
Subject: [Koha-bugs] [Bug 24267] C4::Breeding::ImportBreedingAuth is
 ineffective
In-Reply-To: <bug-24267-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24267-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24267-70-DrtVgAFMdv@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24267

Lucas Gass <lucas at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |lucas at bywatersolutions.com
             Status|Pushed to stable            |Pushed to oldstable

--- Comment #17 from Lucas Gass <lucas at bywatersolutions.com> ---
backported to 19.05.x for 19.05.07

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 15 19:55:40 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 15 Jan 2020 18:55:40 +0000
Subject: [Koha-bugs] [Bug 23031] Improve UX of buttons on order search page
In-Reply-To: <bug-23031-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23031-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23031-70-TvEWwohxlO@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23031

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off
   Patch complexity|---                         |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 15 19:55:43 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 15 Jan 2020 18:55:43 +0000
Subject: [Koha-bugs] [Bug 23031] Improve UX of buttons on order search page
In-Reply-To: <bug-23031-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23031-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23031-70-ZAuxsHe6My@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23031

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #97301|0                           |1
        is obsolete|                            |

--- Comment #4 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 97409
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97409&action=edit
Bug 23031: Make 'add to basket' accessible in one click (fix regression)

Since bug 21364 we have 'view' then 'add to basket' that is accessible
in 2 clicks. We should have it directly accessible.

Test plan:
Create a new basket
Add a new order to the basket (note that the link is directly
accessible)
When a new order is added you can close the basket from the basket list
view
Note that the dropdown button displays correctly

Signed-off-by: Owen Leonard <oleonard at myacpl.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 15 20:08:47 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 15 Jan 2020 19:08:47 +0000
Subject: [Koha-bugs] [Bug 24430] New: Remove C4::Biblio::CountBiblioInOrders
Message-ID: <bug-24430-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24430

            Bug ID: 24430
           Summary: Remove C4::Biblio::CountBiblioInOrders
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Architecture, internals, and plumbing
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: tomascohen at gmail.com
        QA Contact: testopia at bugs.koha-community.org

Using the DBIC relationship with aqorders and count, we can get rid of it.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 15 20:08:55 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 15 Jan 2020 19:08:55 +0000
Subject: [Koha-bugs] [Bug 24430] Remove C4::Biblio::CountBiblioInOrders
In-Reply-To: <bug-24430-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24430-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24430-70-0aNqBp8IKv@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24430

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |tomascohen at gmail.com
                   |ity.org                     |

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 15 20:21:49 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 15 Jan 2020 19:21:49 +0000
Subject: [Koha-bugs] [Bug 24289] Deleting branch will not delete entry in
 special holidays
In-Reply-To: <bug-24289-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24289-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24289-70-rpMpARcX5G@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24289

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off
   Patch complexity|---                         |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 15 20:21:51 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 15 Jan 2020 19:21:51 +0000
Subject: [Koha-bugs] [Bug 24289] Deleting branch will not delete entry in
 special holidays
In-Reply-To: <bug-24289-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24289-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24289-70-qM7Sa60cjP@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24289

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #96630|0                           |1
        is obsolete|                            |
  Attachment #96631|0                           |1
        is obsolete|                            |
  Attachment #96632|0                           |1
        is obsolete|                            |

--- Comment #4 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 97410
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97410&action=edit
Bug 24289: Add foreign keys on *_holidays.branchcode tables

Those are missing foreign keys, it will also clean the holidays tables
and automatically remove the holidays when a library is removed.

Test plan:
0. Do not apply this patch
1. Create a new library
2. Create special and repeatable holiday for this library
3. Remove the library
=> Notice that the holidays still exist in DB
4. Apply this patch
5. Execute the update database entry
=> Notice that the holidays for this library have been removed from the DB
6. Repeat 1-3
=> Notice that the holidays have been removed along with the library

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 15 20:21:54 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 15 Jan 2020 19:21:54 +0000
Subject: [Koha-bugs] [Bug 24289] Deleting branch will not delete entry in
 special holidays
In-Reply-To: <bug-24289-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24289-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24289-70-CgEu9gehNn@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24289

--- Comment #5 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 97411
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97411&action=edit
Bug 24289: DBIC changes

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 15 20:21:56 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 15 Jan 2020 19:21:56 +0000
Subject: [Koha-bugs] [Bug 24289] Deleting branch will not delete entry in
 special holidays
In-Reply-To: <bug-24289-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24289-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24289-70-QzhbL6YJuh@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24289

--- Comment #6 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 97412
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97412&action=edit
Bug 24289: Make sure sample_holidays will load after sample_libraries

They are inserted depending on their alpha order, and sample_holidays
will fail because of missing branchcode.
This patch suggests a simple fix: rename sample_holidays to
sample_libraries_holidays, to make sure it will be loaded after
sample_libraries

Test plan:
Start a fresh installation and select all sample data

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 15 20:23:44 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 15 Jan 2020 19:23:44 +0000
Subject: [Koha-bugs] [Bug 24236] Using quotes in a cataloging search,
 resulting in multiple pages, will not allow you to advance page
In-Reply-To: <bug-24236-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24236-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24236-70-qD684dFE3C@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24236

ByWater Sandboxes <bws.sandboxes at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #97407|0                           |1
        is obsolete|                            |

--- Comment #6 from ByWater Sandboxes <bws.sandboxes at gmail.com> ---
Created attachment 97413
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97413&action=edit
Bug 24236: Fix pagination to use query_cgi

This is still wrong, we should use page-numbers.inc, but that is a larger
refactoring
This patch fixes non-QueryParser searches by simple getting an using the
escaped query (query_cgi)

For QueryParser, we do what the QP code does, just uri escape the query - the
way that SimpleSearch does the query parsing instead of the usual buildQuery
suggest to me that we should probably switch all of this to use the general
Zebra search.

The issues with reservoir should be their own bug

To test:
1 - Search for cat in cataloging search
2 - Get results and see you can paginate
3 - Search for "cat"
4 - Get results but subsequent pages empty
5 - Apply patch
6 - Repeat search for "cat"
7 - You can paginate
8 - Enable UseQueryParser syspref (don't worry about installing)
9 - Confirm can still search with quotes and paginate

Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

Signed-off-by: George Williams <george at nekls.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 15 20:23:59 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 15 Jan 2020 19:23:59 +0000
Subject: [Koha-bugs] [Bug 24236] Using quotes in a cataloging search,
 resulting in multiple pages, will not allow you to advance page
In-Reply-To: <bug-24236-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24236-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24236-70-H3ZjGPzdDR@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24236

George Williams (NEKLS) <george at nekls.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |george at nekls.org
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 15 20:30:12 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 15 Jan 2020 19:30:12 +0000
Subject: [Koha-bugs] [Bug 24430] Remove C4::Biblio::CountBiblioInOrders
In-Reply-To: <bug-24430-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24430-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24430-70-C8P9qvaWSw@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24430

--- Comment #1 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 97414
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97414&action=edit
Bug 24430: Unit tests

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 15 20:30:15 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 15 Jan 2020 19:30:15 +0000
Subject: [Koha-bugs] [Bug 24430] Remove C4::Biblio::CountBiblioInOrders
In-Reply-To: <bug-24430-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24430-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24430-70-otaBUezGvX@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24430

--- Comment #2 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 97415
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97415&action=edit
Bug 24430: Add ->orders and ->orders_count to Koha::Biblio

This patch introduces an accessor to the related orders, and a method
that returns the orders count. The target usage for the count is the
API. In the rest of the codebase, we would just call:

    $biblio->orders->count

To test:
1. Apply this patches
2. Run:
   $ kshell
  k$ prove t/db_dependent/Koha/Biblio.t
=> SUCCESS: Tests pass!
3. Sign off :-D

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 15 20:30:18 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 15 Jan 2020 19:30:18 +0000
Subject: [Koha-bugs] [Bug 24430] Remove C4::Biblio::CountBiblioInOrders
In-Reply-To: <bug-24430-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24430-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24430-70-K6cVxq1tpz@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24430

--- Comment #3 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 97416
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97416&action=edit
Bug 24430: Remove CountBiblioInOrders and its traces

This patch replaces the only uses of CountBiblioInOrders and makes that
code use $biblio->orders->count instead.

Test nothing breaks in basket.pl and parcel.pl

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 15 20:32:15 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 15 Jan 2020 19:32:15 +0000
Subject: [Koha-bugs] [Bug 24430] Remove C4::Biblio::CountBiblioInOrders
In-Reply-To: <bug-24430-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24430-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24430-70-NKsAjUvpxY@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24430

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |17628, 20212
             Status|NEW                         |Needs Signoff
                 CC|                            |kyle at bywatersolutions.com,
                   |                            |liz at bywatersolutions.com,
                   |                            |martin.renvoize at ptfs-europe
                   |                            |.com,
                   |                            |nick at bywatersolutions.com


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17628
[Bug 17628] Move bibliographic related code to Koha::Biblio
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20212
[Bug 20212] Slowness in Receiving in Acquisitions
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 15 20:32:15 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 15 Jan 2020 19:32:15 +0000
Subject: [Koha-bugs] [Bug 17628] Move bibliographic related code to
 Koha::Biblio
In-Reply-To: <bug-17628-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17628-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17628-70-OfDJTaCMQQ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17628

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |24430


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24430
[Bug 24430] Remove C4::Biblio::CountBiblioInOrders
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 15 20:32:15 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 15 Jan 2020 19:32:15 +0000
Subject: [Koha-bugs] [Bug 20212] Slowness in Receiving in Acquisitions
In-Reply-To: <bug-20212-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20212-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20212-70-opoJjELhTx@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20212

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |24430


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24430
[Bug 24430] Remove C4::Biblio::CountBiblioInOrders
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 15 20:42:30 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 15 Jan 2020 19:42:30 +0000
Subject: [Koha-bugs] [Bug 21674] Data integrity not enforced for library
 groups
In-Reply-To: <bug-21674-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21674-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21674-70-HKbiDFahtS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21674

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Patch doesn't apply

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 15 20:53:02 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 15 Jan 2020 19:53:02 +0000
Subject: [Koha-bugs] [Bug 7468] Add label to batch by barcode range
In-Reply-To: <bug-7468-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-7468-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7468-70-Q1vitWWwpQ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7468

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Failed QA

--- Comment #31 from Owen Leonard <oleonard at myacpl.org> ---
This is looking good--still applies! I see one very minor thing: When you click
the "Print range" button the window which pops up says "0 batches to export."
Technically true since it's not a batch in the sense of other label batches,
but probably confusing.

There are also some warnings about commit messages:

Processing additional checks

        * Commit title does not start with 'Bug XXXXX: ' - e72dcde082d
        * Commit title does not start with 'Bug XXXXX: ' - f8f861abdd7
        * Commit title does not start with 'Bug XXXXX: ' - 20d7bc7c535
        * Commit title does not start with 'Bug XXXXX: ' - fc83b5fd01e
        * Commit title does not start with 'Bug XXXXX: ' - c48815db50e

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 15 20:54:58 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 15 Jan 2020 19:54:58 +0000
Subject: [Koha-bugs] [Bug 24431] New: Convert overpayment on accruing fines
 into credits
Message-ID: <bug-24431-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24431

            Bug ID: 24431
           Summary: Convert overpayment on accruing fines into credits
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: Fines and fees
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: andrew at bywatersolutions.com
        QA Contact: testopia at bugs.koha-community.org

See Kyle's proposal on Bug 13044.

To recreate issue:
- find/create a checkout with an accruing fine
- pay off accruing fine in full
- check item in backdated so the final fine is less than the amount paid
- fine is retained on patron account with a negative amount due
- because this is a negative fine rather than a true credit, it cannot be
reconciled


To fix this, we should set the amountoutstanding of the fine to 0 and generate
a credit for the overpaid amount.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 15 20:55:25 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 15 Jan 2020 19:55:25 +0000
Subject: [Koha-bugs] [Bug 22868] Circulation staff with suggestions_manage
 can have access to acquisition data
In-Reply-To: <bug-22868-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22868-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22868-70-IGW3riWUXo@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22868

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |martin.renvoize at ptfs-europe
                   |                            |.com
           Severity|critical                    |enhancement

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 15 20:55:29 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 15 Jan 2020 19:55:29 +0000
Subject: [Koha-bugs] [Bug 24431] Convert overpayment on accruing fines into
 credits
In-Reply-To: <bug-24431-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24431-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24431-70-skSkHfmOnV@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24431

Andrew Fuerste-Henry <andrew at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |kyle at bywatersolutions.com
                   |ity.org                     |

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 15 21:54:23 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 15 Jan 2020 20:54:23 +0000
Subject: [Koha-bugs] [Bug 14792] Fix visibility check for 'place holds' link
 in OPAC result list
In-Reply-To: <bug-14792-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14792-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14792-70-xOlZe8cL6D@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14792

--- Comment #3 from Marjorie Barry-Vila <marjorie.barry-vila at collecto.ca> ---
Hi,

Link "Place hold" do not appear in OPAC result list according to the parameters
chosen in the circulation rules in the "On shelf holds allowed" column.

I am testing on version 19.05:

- If any unavailable : link do not appears
- If all unavailable : link appears
- Yes : link appears

For exemple, with "If any unavailable", if i have 2 items on a notice and one
of them is checked out, "Place hold" link should appear in the result list.

It's the same if it's a notice with a single item.  



Regards,

Marjorie

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 15 22:15:37 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 15 Jan 2020 21:15:37 +0000
Subject: [Koha-bugs] [Bug 23889] Improve style of menu header in advanced
 cataloging editor
In-Reply-To: <bug-23889-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23889-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23889-70-dynEbt1aig@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23889

Lucas Gass <lucas at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to stable            |Pushed to oldstable
                 CC|                            |lucas at bywatersolutions.com

--- Comment #10 from Lucas Gass <lucas at bywatersolutions.com> ---
backported to 19.05.x. for 19.05.07

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 15 22:17:06 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 15 Jan 2020 21:17:06 +0000
Subject: [Koha-bugs] [Bug 23261] RecordedBooks - notify patron of need to
 login / register to see availability
In-Reply-To: <bug-23261-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23261-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23261-70-gZXnGrB29P@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23261

Lucas Gass <lucas at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |lucas at bywatersolutions.com

--- Comment #13 from Lucas Gass <lucas at bywatersolutions.com> ---
enhancement will not be backported to 19.05.x series

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 15 22:19:31 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 15 Jan 2020 21:19:31 +0000
Subject: [Koha-bugs] [Bug 24420] Cataloging search results Location column
 should account for waiting on hold items
In-Reply-To: <bug-24420-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24420-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24420-70-Wl6xi2QcdK@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24420

ByWater Sandboxes <bws.sandboxes at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #97355|0                           |1
        is obsolete|                            |

--- Comment #2 from ByWater Sandboxes <bws.sandboxes at gmail.com> ---
Created attachment 97417
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97417&action=edit
Bug 24420: Cataloging search results Location column should account for waiting
on hold items

Signed-off-by: Barbara Johnson <barbara.johnson at bedfordtx.gov>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 15 22:19:45 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 15 Jan 2020 21:19:45 +0000
Subject: [Koha-bugs] [Bug 24420] Cataloging search results Location column
 should account for waiting on hold items
In-Reply-To: <bug-24420-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24420-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24420-70-pUhbfAP4Mr@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24420

Barbara Johnson <barbara.johnson at bedfordtx.gov> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |barbara.johnson at bedfordtx.g
                   |                            |ov

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 15 22:24:05 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 15 Jan 2020 21:24:05 +0000
Subject: [Koha-bugs] [Bug 21944] Fix waiting holds at wrong location bug
In-Reply-To: <bug-21944-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21944-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21944-70-QQ0TBJNc52@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21944

Lisette Scheer <lisetteslatah at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Failed QA

--- Comment #33 from Lisette Scheer <lisetteslatah at gmail.com> ---
With the patches appled, at step 4 in the test plan when I confirm the
transfer, I get this: 

Can't call method "biblio" on an undefined value at
/kohadevbox/koha/circ/returns.pl line 158 


It does seem to set the item back to a record level hold but the expiration
date persists and it doesn't set it into transit, just sets the current
location to be the branch it was scanned into most recently. 

Lisette

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 15 22:29:04 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 15 Jan 2020 21:29:04 +0000
Subject: [Koha-bugs] [Bug 23956] Replace famfamfam calendar icon in staff
 client with CSS data-url
In-Reply-To: <bug-23956-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23956-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23956-70-fqWwZ6Ql42@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23956

Lucas Gass <lucas at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |lucas at bywatersolutions.com
             Status|Pushed to stable            |Pushed to oldstable

--- Comment #5 from Lucas Gass <lucas at bywatersolutions.com> ---
backported to 19.05.x for 19.05.07

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 15 22:39:06 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 15 Jan 2020 21:39:06 +0000
Subject: [Koha-bugs] [Bug 24432] New: Request an endpoint with a date column
 in order by throws bad parameter exception
Message-ID: <bug-24432-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24432

            Bug ID: 24432
           Summary: Request an endpoint with a date column in order by
                    throws bad parameter exception
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: blocker
          Priority: P5 - low
         Component: REST API
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: agustinmoyano at theke.io
                CC: tomascohen at gmail.com
        Depends on: 23893
            Blocks: 20936

When you request an endpoint in the API with a date as orderby, it throws
Koha::Exceptions::BadParameter.

Koha::REST::Plugin::Query in _build_order_atom, in order to get the model
parameter for the order by, it requests 

{instance of Koha::Objects}->attributes_from_api({ <api parameter name> => 1
});

to get that hash translated, and use the resulting key as the model column to
do the order by.

This works ok for all datatypes except date types, because it's trying to
transate the value of "1" as a date, throwig the mentioned exception.

In my opinion, _build_order_atom should not use attributes_from_api, but should
use the mapping in Koha::Object to get the column name.


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20936
[Bug 20936] Holds History for patrons in OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23893
[Bug 23893] Add ->new_from_api and ->set_from_api methods to Koha::Object
-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 15 22:39:06 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 15 Jan 2020 21:39:06 +0000
Subject: [Koha-bugs] [Bug 23893] Add ->new_from_api and ->set_from_api
 methods to Koha::Object
In-Reply-To: <bug-23893-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23893-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23893-70-rvXu8UUCFO@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23893

Agustín Moyano <agustinmoyano at theke.io> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |24432


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24432
[Bug 24432] Request an endpoint with a date column in order by throws bad
parameter exception
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 15 22:39:06 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 15 Jan 2020 21:39:06 +0000
Subject: [Koha-bugs] [Bug 20936] Holds History for patrons in OPAC
In-Reply-To: <bug-20936-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20936-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20936-70-fzDgJ2fqyn@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20936

Agustín Moyano <agustinmoyano at theke.io> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |24432


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24432
[Bug 24432] Request an endpoint with a date column in order by throws bad
parameter exception
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 15 22:40:20 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 15 Jan 2020 21:40:20 +0000
Subject: [Koha-bugs] [Bug 24432] Request an endpoint with a date column in
 order by throws bad parameter exception
In-Reply-To: <bug-24432-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24432-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24432-70-NlmTE23zoU@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24432

Agustín Moyano <agustinmoyano at theke.io> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |agustinmoyano at theke.io
                   |ity.org                     |

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 15 22:42:08 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 15 Jan 2020 21:42:08 +0000
Subject: [Koha-bugs] [Bug 24428] Elastic search index does not contain
 consistent item information
In-Reply-To: <bug-24428-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24428-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24428-70-NtYBxHReh8@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24428

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |ere.maijala at helsinki.fi,
                   |                            |katrin.fischer at bsz-bw.de,
                   |                            |nick at bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 15 22:43:56 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 15 Jan 2020 21:43:56 +0000
Subject: [Koha-bugs] [Bug 23957] Remove button style with famfamfam icon
 background and replace with Font Awesome
In-Reply-To: <bug-23957-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23957-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23957-70-GjpyKPpfiJ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23957

Lucas Gass <lucas at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |lucas at bywatersolutions.com

--- Comment #12 from Lucas Gass <lucas at bywatersolutions.com> ---
there is many merge conflicts when applying this to 19.05.x, I am going to skip
backporting it.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 15 22:45:45 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 15 Jan 2020 21:45:45 +0000
Subject: [Koha-bugs] [Bug 24181] Make our datepicker inputs sexy
In-Reply-To: <bug-24181-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24181-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24181-70-ko7iFkF0Cw@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24181

--- Comment #19 from Lucas Gass <lucas at bywatersolutions.com> ---
Choosing to skip this enhancement in 19.05.x, no backport

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 15 22:50:15 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 15 Jan 2020 21:50:15 +0000
Subject: [Koha-bugs] [Bug 24267] C4::Breeding::ImportBreedingAuth is
 ineffective
In-Reply-To: <bug-24267-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24267-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24267-70-QTYiom6GYI@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24267

Hayley Mapley <hayleymapley at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |hayleymapley at catalyst.net.n
                   |                            |z

--- Comment #18 from Hayley Mapley <hayleymapley at catalyst.net.nz> ---
Enhancement will not be backported to 18.11.x series.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 15 22:54:26 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 15 Jan 2020 21:54:26 +0000
Subject: [Koha-bugs] [Bug 24063] Add Sami language characters to Zebra
In-Reply-To: <bug-24063-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24063-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24063-70-PvVvfSlc8V@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24063

Lucas Gass <lucas at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to stable            |Pushed to oldstable
                 CC|                            |lucas at bywatersolutions.com

--- Comment #6 from Lucas Gass <lucas at bywatersolutions.com> ---
simple enhancement, choosing to backport to 19.05.x series for 19.05.07

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 15 22:55:14 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 15 Jan 2020 21:55:14 +0000
Subject: [Koha-bugs] [Bug 23483] When writing off a fine,
 the title of the patron is shown as description
In-Reply-To: <bug-23483-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23483-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23483-70-YuIdarj90V@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23483

Hayley Mapley <hayleymapley at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|19.11.00, 18.11.12          |19.11.00, 19.05.06,
        released in|                            |18.11.12

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 15 22:55:48 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 15 Jan 2020 21:55:48 +0000
Subject: [Koha-bugs] [Bug 24120] Search terms in search dropdown must be URI
 filtered
In-Reply-To: <bug-24120-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24120-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24120-70-kuR4tJCLpE@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24120

Hayley Mapley <hayleymapley at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|19.11.00, 18.11.12          |19.11.00, 19.05.06,
        released in|                            |18.11.12

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 15 22:56:15 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 15 Jan 2020 21:56:15 +0000
Subject: [Koha-bugs] [Bug 24145] Auth.t is failing because of wrong mocked
 ->param
In-Reply-To: <bug-24145-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24145-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24145-70-73ncYLCAir@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24145

Hayley Mapley <hayleymapley at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|20.05.00, 19.11.01,         |20.05.00, 19.11.01,
        released in|18.11.12                    |19.05.06, 18.11.12

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 15 22:56:35 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 15 Jan 2020 21:56:35 +0000
Subject: [Koha-bugs] [Bug 24199] t/Auth_with_shibboleth.t is failing randomly
In-Reply-To: <bug-24199-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24199-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24199-70-XEjtCNNd6Z@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24199

Hayley Mapley <hayleymapley at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|20.05.00, 19.11.01,         |20.05.00, 19.11.01,
        released in|18.11.12                    |19.05.06, 18.11.12

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 15 22:56:55 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 15 Jan 2020 21:56:55 +0000
Subject: [Koha-bugs] [Bug 21939] Permission for holds history tab is too
 strict
In-Reply-To: <bug-21939-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21939-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21939-70-VD9HnTwiNt@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21939

Hayley Mapley <hayleymapley at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|19.11.00, 18.11.12          |19.11.00, 19.05.06,
        released in|                            |18.11.12

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 15 22:57:35 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 15 Jan 2020 21:57:35 +0000
Subject: [Koha-bugs] [Bug 23506] Sound material type displays wrong icon in
 OPAC/Staff details
In-Reply-To: <bug-23506-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23506-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23506-70-bHQenKBrDs@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23506

Hayley Mapley <hayleymapley at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|19.11.00, 18.11.12          |19.11.00, 19.05.06,
        released in|                            |18.11.12

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 15 22:57:55 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 15 Jan 2020 21:57:55 +0000
Subject: [Koha-bugs] [Bug 23952] Fix body id on OPAC course details page
In-Reply-To: <bug-23952-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23952-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23952-70-O2fBiXjaj8@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23952

Hayley Mapley <hayleymapley at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|19.11.00, 18.11.12          |19.11.00, 19.05.06,
        released in|                            |18.11.12

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 15 22:59:24 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 15 Jan 2020 21:59:24 +0000
Subject: [Koha-bugs] [Bug 23954] Format notes in suggestion management
In-Reply-To: <bug-23954-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23954-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23954-70-t2OAaMBLOk@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23954

Hayley Mapley <hayleymapley at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|19.11.00, 18.11.12          |19.11.00, 19.05.06,
        released in|                            |18.11.12

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 15 22:59:42 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 15 Jan 2020 21:59:42 +0000
Subject: [Koha-bugs] [Bug 13749] On loading holds in patron account
 'processing' is not translatable
In-Reply-To: <bug-13749-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13749-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13749-70-zO9i1uAWLj@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13749

Hayley Mapley <hayleymapley at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|19.11.00, 18.11.12          |19.11.00, 19.05.06,
        released in|                            |18.11.12

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 15 23:00:09 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 15 Jan 2020 22:00:09 +0000
Subject: [Koha-bugs] [Bug 23768] ISBN search in IntranetCatalogPulldown
 searches nothing if passed an invalid ISBN and using
 SearchWithISBNVariations
In-Reply-To: <bug-23768-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23768-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23768-70-QpAOibOlFL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23768

Hayley Mapley <hayleymapley at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|19.11.00, 18.11.12          |19.11.00, 19.05.06,
        released in|                            |18.11.12

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 15 23:00:43 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 15 Jan 2020 22:00:43 +0000
Subject: [Koha-bugs] [Bug 23089] Elasticsearch - cannot sort on non-text
 fields
In-Reply-To: <bug-23089-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23089-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23089-70-loeAY7eRCC@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23089

Hayley Mapley <hayleymapley at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|19.11.00, 18.11.12          |19.11.00, 19.05.06,
        released in|                            |18.11.12

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 15 23:01:17 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 15 Jan 2020 22:01:17 +0000
Subject: [Koha-bugs] [Bug 23389] Add 'All' option to report value dropdowns
In-Reply-To: <bug-23389-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23389-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23389-70-plAwqsmeBK@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23389

Hayley Mapley <hayleymapley at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|19.11.00, 18.11.12          |19.11.00, 19.05.06,
        released in|                            |18.11.12

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 15 23:02:04 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 15 Jan 2020 22:02:04 +0000
Subject: [Koha-bugs] [Bug 24191] Sorting doesn't use to_model
In-Reply-To: <bug-24191-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24191-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24191-70-Kl1cWlCugy@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24191

Hayley Mapley <hayleymapley at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|20.05.00, 19.11.01,         |20.05.00, 19.11.01,
        released in|18.11.13                    |19.05.07, 18.11.13

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 15 23:02:32 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 15 Jan 2020 22:02:32 +0000
Subject: [Koha-bugs] [Bug 24090] Subfield text in red when mandatory in
 record edition
In-Reply-To: <bug-24090-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24090-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24090-70-zlFRygSgT2@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24090

Hayley Mapley <hayleymapley at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|20.05.00, 19.11.01,         |20.05.00, 19.11.01,
        released in|18.11.13                    |19.05.07, 18.11.13

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 15 23:03:01 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 15 Jan 2020 22:03:01 +0000
Subject: [Koha-bugs] [Bug 24230] intranet_js plugin hook is after body end
 tag
In-Reply-To: <bug-24230-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24230-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24230-70-iWnm92FksB@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24230

Hayley Mapley <hayleymapley at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|20.05.00, 19.11.01,         |20.05.00, 19.11.01,
        released in|18.11.13                    |19.05.07, 18.11.13

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 15 23:03:21 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 15 Jan 2020 22:03:21 +0000
Subject: [Koha-bugs] [Bug 13806] No input sanitization where creating
 Reports subgroup
In-Reply-To: <bug-13806-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13806-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13806-70-nDAxP5w7nM@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13806

Hayley Mapley <hayleymapley at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|20.05.00, 19.11.01,         |20.05.00, 19.11.01,
        released in|18.11.13                    |19.05.07, 18.11.13

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 15 23:03:40 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 15 Jan 2020 22:03:40 +0000
Subject: [Koha-bugs] [Bug 20948] Item-level hold info displayed regardless
 its priority (detail.pl)
In-Reply-To: <bug-20948-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20948-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20948-70-81hOHDhagG@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20948

Hayley Mapley <hayleymapley at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|20.05.00, 19.11.02,         |20.05.00, 19.11.02,
        released in|18.11.13                    |19.05.07, 18.11.13

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 15 23:04:06 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 15 Jan 2020 22:04:06 +0000
Subject: [Koha-bugs] [Bug 21270] "Not finding what you're looking" display
 needs to be fixed
In-Reply-To: <bug-21270-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21270-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21270-70-532eHHuDu3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21270

Hayley Mapley <hayleymapley at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|20.05.00, 19.11.01,         |20.05.00, 19.11.01,
        released in|18.11.13                    |19.05.07, 18.11.13

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 15 23:04:26 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 15 Jan 2020 22:04:26 +0000
Subject: [Koha-bugs] [Bug 24240] List on opac missing close form tag under
 some conditions
In-Reply-To: <bug-24240-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24240-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24240-70-4qqurfDhbr@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24240

Hayley Mapley <hayleymapley at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|20.05.00, 19.11.02,         |20.05.00, 19.11.02,
        released in|18.11.13                    |19.05.07, 18.11.13

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 15 23:04:46 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 15 Jan 2020 22:04:46 +0000
Subject: [Koha-bugs] [Bug 24245] opac-registration-confirmation.tt has
 incorrect HTML body id
In-Reply-To: <bug-24245-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24245-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24245-70-ZjupNuSxqb@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24245

Hayley Mapley <hayleymapley at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|20.05.00, 19.11.02,         |20.05.00, 19.11.02,
        released in|18.11.13                    |19.05.07, 18.11.13

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 15 23:05:16 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 15 Jan 2020 22:05:16 +0000
Subject: [Koha-bugs] [Bug 23731] Display LC call number in OPAC and staff
 detail pages
In-Reply-To: <bug-23731-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23731-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23731-70-aGMdZuBUZ1@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23731

Hayley Mapley <hayleymapley at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|19.11.00, 18.11.13          |19.11.00, 19.05.07,
        released in|                            |18.11.13

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 15 23:05:36 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 15 Jan 2020 22:05:36 +0000
Subject: [Koha-bugs] [Bug 5365] It should be more clear how to reopen a
 basket in a basket group
In-Reply-To: <bug-5365-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-5365-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-5365-70-2l7wfjaXeW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5365

Hayley Mapley <hayleymapley at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|19.11.00, 18.11.13          |19.11.00, 19.05.07,
        released in|                            |18.11.13

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 15 23:06:22 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 15 Jan 2020 22:06:22 +0000
Subject: [Koha-bugs] [Bug 23970] itemsearch - publication date not taken
 into account if not used in the first field
In-Reply-To: <bug-23970-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23970-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23970-70-WtedBjmv6z@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23970

Hayley Mapley <hayleymapley at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|20.05.00, 19.11.01,         |20.05.00, 19.11.01,
        released in|18.11.13                    |19.05.06, 18.11.13

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 15 23:07:48 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 15 Jan 2020 22:07:48 +0000
Subject: [Koha-bugs] [Bug 16784] Add table configuration on suggestions table
In-Reply-To: <bug-16784-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16784-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16784-70-4WwdxRdDJB@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16784

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 15 23:07:52 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 15 Jan 2020 22:07:52 +0000
Subject: [Koha-bugs] [Bug 16784] Add table configuration on suggestions table
In-Reply-To: <bug-16784-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16784-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16784-70-FS8DAeOpEU@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16784

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #97295|0                           |1
        is obsolete|                            |

--- Comment #9 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 97418
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97418&action=edit
Bug 16784: Add table configuration on suggestions table

This patch adds DataTables column configuration and export options to
the suggestions management tables in the staff interface.

The columns settings made via the administrative interface will affect
tables under each tab in the interface whether it be organized by
status, library, etc. However because of the way the KohaTable function
is currently written, changes made via the "Columns" button will only
affect the visible table.

To test, apply the patch and go to Acquisitions -> Suggestions.

 - Under each tab, the table of suggestions should have a DataTables
   toolbar with export and columns buttons. These controls should work
   correctly:
   - Showing and hiding columns should work as expected
   - Exports should work, excluding the first and last columns
 - Test the tables when using the various "Organize by" settings.
 - Test changing the settings in Administration -> Columns settings.
   - Verify that the changes you make to that configuration are
     reflected in the suggestions tables.

Signed-off-by: David Nind <david at davidnind.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 15 23:07:55 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 15 Jan 2020 22:07:55 +0000
Subject: [Koha-bugs] [Bug 16784] Add table configuration on suggestions table
In-Reply-To: <bug-16784-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16784-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16784-70-tAIDAvT8zC@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16784

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #97408|0                           |1
        is obsolete|                            |

--- Comment #10 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 97419
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97419&action=edit
Bug 16784: (follow-up) Add missing filter

This follow-up adds a missing template filter quiet qa tool warning.

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 15 23:08:24 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 15 Jan 2020 22:08:24 +0000
Subject: [Koha-bugs] [Bug 24282] SCSS conversion broke style in search
 results item status
In-Reply-To: <bug-24282-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24282-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24282-70-FxoVVCnICd@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24282

Hayley Mapley <hayleymapley at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |hayleymapley at catalyst.net.n
                   |                            |z
         Version(s)|20.05.00                    |20.05.00, 19.05.07
        released in|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 15 23:10:24 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 15 Jan 2020 22:10:24 +0000
Subject: [Koha-bugs] [Bug 14543] Order lines updated that have a tax rate
 not in gist will have tax rate set to 0!
In-Reply-To: <bug-14543-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14543-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14543-70-EQQoeh5nZq@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14543

Lisette Scheer <lisetteslatah at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |lisetteslatah at gmail.com
             Status|Needs Signoff               |Failed QA

--- Comment #5 from Lisette Scheer <lisetteslatah at gmail.com> ---
It doesn't warn, but it does keep the old GST even once it has been removed
from the gist sys pref. 
I tested in a sandbox.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 15 23:10:26 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 15 Jan 2020 22:10:26 +0000
Subject: [Koha-bugs] [Bug 23889] Improve style of menu header in advanced
 cataloging editor
In-Reply-To: <bug-23889-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23889-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23889-70-RhBftNmPEg@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23889

Hayley Mapley <hayleymapley at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |hayleymapley at catalyst.net.n
                   |                            |z

--- Comment #11 from Hayley Mapley <hayleymapley at catalyst.net.nz> ---
Enhancement will not be backported to 18.11.x series.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 15 23:11:08 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 15 Jan 2020 22:11:08 +0000
Subject: [Koha-bugs] [Bug 23956] Replace famfamfam calendar icon in staff
 client with CSS data-url
In-Reply-To: <bug-23956-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23956-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23956-70-X7OH44lDlQ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23956

Hayley Mapley <hayleymapley at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |hayleymapley at catalyst.net.n
                   |                            |z

--- Comment #6 from Hayley Mapley <hayleymapley at catalyst.net.nz> ---
Enhancement will not be backported to 18.11.x series.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 15 23:13:23 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 15 Jan 2020 22:13:23 +0000
Subject: [Koha-bugs] [Bug 24063] Add Sami language characters to Zebra
In-Reply-To: <bug-24063-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24063-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24063-70-K4IgHrE6HT@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24063

Hayley Mapley <hayleymapley at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |hayleymapley at catalyst.net.n
                   |                            |z

--- Comment #7 from Hayley Mapley <hayleymapley at catalyst.net.nz> ---
Enhancement will not be backported to 18.11.x series.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 15 23:16:20 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 15 Jan 2020 22:16:20 +0000
Subject: [Koha-bugs] [Bug 24352] OpacItemLocation is buggy
In-Reply-To: <bug-24352-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24352-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24352-70-8McV0B8aG2@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24352

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Failed QA

--- Comment #9 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Hi Owen, you were right, but still struggling a bit with these patches, can you
help?

These are my items:
Books   Centerville Fiction     Non-fiction     782.42166092 B (Browse shelf)  
Available       
Books   Centerville New Materials Shelf         Non-fiction     782.42166092 B
(Browse shelf)   Pending hold    
Books   Union Fiction   Reference       782.42166092 B (Browse shelf)  
Available

So all 3 have locations, one is a pending hold, 2 are available. In the result
list, only reference shows:

Availability: Items available for loan: Centerville (2). Pending hold (1).
Collection(s): Reference [782.42166092 B]. 

Can you tell why the collection Non-fiction doesn't show?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 15 23:17:19 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 15 Jan 2020 22:17:19 +0000
Subject: [Koha-bugs] [Bug 24166] Barcode removal breaks
 circulation.pl/moremember.pl
In-Reply-To: <bug-24166-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24166-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24166-70-lmyXywmhuB@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24166

Hayley Mapley <hayleymapley at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |hayleymapley at catalyst.net.n
                   |                            |z
             Status|Pushed to oldstable         |Pushed to oldoldstable
         Version(s)|20.05.00, 19.11.02          |20.05.00, 19.11.02,
        released in|                            |19.05.07, 18.11.13

--- Comment #7 from Hayley Mapley <hayleymapley at catalyst.net.nz> ---
Backported to 18.11.x for 18.11.13

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 15 23:19:39 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 15 Jan 2020 22:19:39 +0000
Subject: [Koha-bugs] [Bug 20414] Remove COinSinOPACResults system preference
 and make it always on
In-Reply-To: <bug-20414-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20414-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20414-70-DvqSgS5cwc@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20414

Liz Rea <wizzyrea at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |wizzyrea at gmail.com

--- Comment #4 from Liz Rea <wizzyrea at gmail.com> ---
It's a really good thing we haven't removed this, there's a bad bug in the OPAC
where turning off coins alleviates the problem. It's already on by default but
it's really nice to be able to turn it off when we need to.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 15 23:22:09 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 15 Jan 2020 22:22:09 +0000
Subject: [Koha-bugs] [Bug 24212] OPAC send list dialog opens too small in IE
In-Reply-To: <bug-24212-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24212-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24212-70-ZtcYa3InCn@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24212

Lucas Gass <lucas at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|20.05.00, 19.11.02          |20.05.00, 19.11.02,
        released in|                            |19.05.07
             Status|Pushed to stable            |Pushed to oldstable
                 CC|                            |lucas at bywatersolutions.com

--- Comment #9 from Lucas Gass <lucas at bywatersolutions.com> ---
backported to 19.05.x for 19.05.07

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 15 23:29:37 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 15 Jan 2020 22:29:37 +0000
Subject: [Koha-bugs] [Bug 24341] Allow for more complex markup in OPAC
 confirmation dialogs
In-Reply-To: <bug-24341-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24341-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24341-70-EE35w52pCk@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24341

Maryse Simard <maryse.simard at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #96796|0                           |1
        is obsolete|                            |

--- Comment #2 from Maryse Simard <maryse.simard at inlibro.com> ---
Created attachment 97420
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97420&action=edit
Bug 24341: Allow for more complex markup in OPAC confirmation dialogs

This patch changes the globally-available confirmModal() function in the
OPAC so that it uses jQuery's html() function for adding information to
the confirmation modal's body. This will allow for more than just plain
text to be added.

This patch also removes some obsolete lines from the JavaScript in
opac-user.tt and renames some variable for clarity.

To test, apply the patch log in to the OPAC as a user who has holds and
article requests.

 - Test the following interactions, both the confirmation and cancel
   options for each:
     - Cancel a hold
     - Suspend all holds
     - Resume all holds
     - Cancel an article request

Signed-off-by: Maryse Simard <maryse.simard at inlibro.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 15 23:29:47 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 15 Jan 2020 22:29:47 +0000
Subject: [Koha-bugs] [Bug 24341] Allow for more complex markup in OPAC
 confirmation dialogs
In-Reply-To: <bug-24341-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24341-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24341-70-iSsZqgZ6C0@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24341

Maryse Simard <maryse.simard at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off
                 CC|                            |maryse.simard at inlibro.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 15 23:33:31 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 15 Jan 2020 22:33:31 +0000
Subject: [Koha-bugs] [Bug 24336] Ask for confirmation before deleting a
 suggestion in the OPAC
In-Reply-To: <bug-24336-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24336-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24336-70-bd2XFT6x8X@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24336

--- Comment #6 from Maryse Simard <maryse.simard at inlibro.com> ---
I was sure I had signed the dependency while testing... sorry for that. I just
did now.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 15 23:33:57 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 15 Jan 2020 22:33:57 +0000
Subject: [Koha-bugs] [Bug 24336] Ask for confirmation before deleting a
 suggestion in the OPAC
In-Reply-To: <bug-24336-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24336-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24336-70-ONQZWGrDj5@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24336

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|BLOCKED                     |Signed Off

--- Comment #7 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
(In reply to Maryse Simard from comment #6)
> I was sure I had signed the dependency while testing... sorry for that. I
> just did now.

Great, thank you!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 15 23:38:42 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 15 Jan 2020 22:38:42 +0000
Subject: [Koha-bugs] [Bug 24341] Allow for more complex markup in OPAC
 confirmation dialogs
In-Reply-To: <bug-24341-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24341-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24341-70-7g0MWLKA0K@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24341

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Failed QA
                 CC|                            |katrin.fischer at bsz-bw.de

--- Comment #3 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Cancelling a hold in the OPAC doesn't ask for confirmation in my testing - can
you pleas check?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 15 23:49:02 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 15 Jan 2020 22:49:02 +0000
Subject: [Koha-bugs] [Bug 24173] Advanced Editor: Show subtitle & published
 date on the search page
In-Reply-To: <bug-24173-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24173-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24173-70-b5tR8JMARw@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24173

Lucas Gass <lucas at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |lucas at bywatersolutions.com
             Status|Pushed to stable            |Pushed to oldstable
         Version(s)|20.05.00, 19.11.02          |20.05.00, 19.11.02,
        released in|                            |19.05.07

--- Comment #7 from Lucas Gass <lucas at bywatersolutions.com> ---
backported to 19.05.x for 19.05.07

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 15 23:54:25 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 15 Jan 2020 22:54:25 +0000
Subject: [Koha-bugs] [Bug 24432] Request an endpoint with a date column in
 order by throws bad parameter exception
In-Reply-To: <bug-24432-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24432-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24432-70-UMSwe8WHSK@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24432

--- Comment #1 from Agustín Moyano <agustinmoyano at theke.io> ---
Created attachment 97421
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97421&action=edit
Bug 24432: Regresion test

To test:
1. apply this patch
2. prove t/Koha/REST/Plugin/Query.t

Test should fail at this point.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 15 23:55:02 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 15 Jan 2020 22:55:02 +0000
Subject: [Koha-bugs] [Bug 10469] Display more when editing subfields in
 frameworks
In-Reply-To: <bug-10469-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-10469-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10469-70-3bmJq5zs1h@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10469

Lucas Gass <lucas at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |lucas at bywatersolutions.com
             Status|Pushed to stable            |Pushed to oldstable
         Version(s)|20.05.00, 19.11.02          |20.05.00, 19.11.02,
        released in|                            |19.05.07

--- Comment #9 from Lucas Gass <lucas at bywatersolutions.com> ---
backported to 19.05.x for 19.05.07

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 15 23:55:50 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 15 Jan 2020 22:55:50 +0000
Subject: [Koha-bugs] [Bug 24212] OPAC send list dialog opens too small in IE
In-Reply-To: <bug-24212-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24212-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24212-70-AtUZRX3elm@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24212

Hayley Mapley <hayleymapley at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |hayleymapley at catalyst.net.n
                   |                            |z

--- Comment #10 from Hayley Mapley <hayleymapley at catalyst.net.nz> ---
Enhancement will not be backported to 18.11.x series.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 15 23:56:53 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 15 Jan 2020 22:56:53 +0000
Subject: [Koha-bugs] [Bug 24173] Advanced Editor: Show subtitle & published
 date on the search page
In-Reply-To: <bug-24173-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24173-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24173-70-KITSwqEwvN@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24173

Hayley Mapley <hayleymapley at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |hayleymapley at catalyst.net.n
                   |                            |z

--- Comment #8 from Hayley Mapley <hayleymapley at catalyst.net.nz> ---
Enhancement will not be backported to 18.11.x series.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 15 23:57:17 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 15 Jan 2020 22:57:17 +0000
Subject: [Koha-bugs] [Bug 22569] Stock rotation: 'Transfers to send' report
In-Reply-To: <bug-22569-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22569-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22569-70-HwdttDogBD@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22569

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Failed QA

--- Comment #25 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
This has a dependency on bug 23092 that doesn't seem right. 

We are also failing the QA script:

 FAIL   koha-tmpl/intranet-tmpl/prog/en/modules/circ/transferstosend.tt
   FAIL   filters
                wrong_html_filter at line 59 (                        <a
href="/cgi-bin/koha/catalogue/stockrotation.pl?op=toggle_in_demand&stage_id=4&item_id=[%
transfer.itemnumber %]&biblionumber=[% transfer.item.biblionumber %]"
class="btn btn-default btn-xs"><i class="fa fa-fire"></i> Mark "In demand"</a>)
                wrong_html_filter at line 59 (                        <a
href="/cgi-bin/koha/catalogue/stockrotation.pl?op=toggle_in_demand&stage_id=4&item_id=[%
transfer.itemnumber %]&biblionumber=[% transfer.item.biblionumber %]"
class="btn btn-default btn-xs"><i class="fa fa-fire"></i> Mark "In demand"</a>)
                missing_filter at line 59 (                        <a
href="/cgi-bin/koha/catalogue/stockrotation.pl?op=toggle_in_demand&stage_id=4&item_id=[%
transfer.itemnumber %]&biblionumber=[% transfer.item.biblionumber %]"
class="btn btn-default btn-xs"><i class="fa fa-fire"></i> Mark "In demand"</a>)
                missing_filter at line 59 (                        <a
href="/cgi-bin/koha/catalogue/stockrotation.pl?op=toggle_in_demand&stage_id=4&item_id=[%
transfer.itemnumber %]&biblionumber=[% transfer.item.biblionumber %]"
class="btn btn-default btn-xs"><i class="fa fa-fire"></i> Mark "In demand"</a>)
   FAIL   forbidden patterns
                forbidden pattern: tab char (line 31)


And the tests are not passing for me?

Please fix!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 15 23:59:57 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 15 Jan 2020 22:59:57 +0000
Subject: [Koha-bugs] [Bug 24312] Update MARC21 frameworks to Updates 28+29
 (May and November 2019)
In-Reply-To: <bug-24312-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24312-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24312-70-E8PgQfIS4T@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24312

Lucas Gass <lucas at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to stable            |Pushed to oldstable
         Version(s)|20.05.00, 19.11.02          |20.05.00, 19.11.02,
        released in|                            |19.05.07
                 CC|                            |lucas at bywatersolutions.com

--- Comment #11 from Lucas Gass <lucas at bywatersolutions.com> ---
backported to 19.05.x for 19.05.07

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 16 00:01:06 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 15 Jan 2020 23:01:06 +0000
Subject: [Koha-bugs] [Bug 24339] SIP codes are missing from the default
 payment_types on installation
In-Reply-To: <bug-24339-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24339-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24339-70-z1mnVbCwJ0@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24339

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Failed QA

--- Comment #4 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Hi Martin, can yo help me with the test plan? Where do we define the SIP
payment types?

Also... this is failing QA tests rather spectacularly:

FAIL    koha-tmpl/intranet-tmpl/prog/en/modules/members/paycollect.tt
   OK     filters
   OK     forbidden patterns
   OK     git manipulation
   OK     js_in_body
   OK     spelling
   OK     tt_valid
   FAIL   valid_template
                The method Koha::AuthorisedValue->size is not covered by tests!

Trace begun at /home/vagrant/kohaclone/Koha/Object.pm line 670
Koha::Object::AUTOLOAD('Koha::AuthorisedValue=HASH(0x56078bb1a4c0)') called at
/home/vagrant/kohaclone/koha-tmpl/intranet-tmpl/prog/en/modules/members/paycollect.tt
line 273
eval {...} at
/home/vagrant/kohaclone/koha-tmpl/intranet-tmpl/prog/en/modules/members/paycollect.tt
line 273
eval {...} at
/home/vagrant/kohaclone/koha-tmpl/intranet-tmpl/prog/en/modules/members/paycollect.tt
line 7
Template::Document::__ANON__('Template::Context=HASH(0x56078c113160)') called
at /usr/lib/x86_64-linux-gnu/perl5/5.24/Template/Document.pm line 163
eval {...} at /usr/lib/x86_64-linux-gnu/perl5/5.24/Template/Document.pm line
161
Template::Document::process('Template::Document=HASH(0x56078bb2c0e0)',
'Template::Context=HASH(0x56078c113160)') called at
/usr/lib/x86_64-linux-gnu/perl5/5.24/Template/Context.pm line 351
eval {...} at /usr/lib/x86_64-linux-gnu/perl5/5.24/Template/Context.pm line 321
Template::Context::process('Template::Context=HASH(0x56078c113160)',
'Template::Document=HASH(0x56078bb2c0e0)') called at
/usr/lib/x86_64-linux-gnu/perl5/5.24/Template/Service.pm line 94
eval {...} at /usr/lib/x86_64-linux-gnu/perl5/5.24/Template/Service.pm line 91
Template::Service::process('Template::Service=HASH(0x56078bfa9478)',
'/home/vagrant/kohaclone/koha-tmpl/intranet-tmpl/prog/en/modules/members/paycollect.tt',
'HASH(0x56078c03e178)') called at
/usr/lib/x86_64-linux-gnu/perl5/5.24/Template.pm line 66
Template::process('Template=HASH(0x56078bf1d2f0)',
'/home/vagrant/kohaclone/koha-tmpl/intranet-tmpl/prog/en/modules/members/paycollect.tt',
'HASH(0x56078c03e178)', 'SCALAR(0x560783ebf940)') called at
/home/vagrant/qa-test-tools/QohA/File/Template.pm line 94
QohA::File::Template::check_valid_template('QohA::File::Template=HASH(0x560781181158)')
called at /home/vagrant/qa-test-tools/QohA/File/Template.pm line 23
QohA::File::Template::run_checks('QohA::File::Template=HASH(0x560781181158)',
2) called at /home/vagrant/qa-test-tools/koha-qa.pl line 99
eval {...} at /home/vagrant/qa-test-tools/koha-qa.pl line 67

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 16 00:03:05 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 15 Jan 2020 23:03:05 +0000
Subject: [Koha-bugs] [Bug 24314] Update de-DE MARC21 frameworks for updates
 28+29 (May and November 2019)
In-Reply-To: <bug-24314-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24314-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24314-70-B2cP2mGeLT@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24314

Lucas Gass <lucas at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to stable            |Pushed to oldstable
                 CC|                            |lucas at bywatersolutions.com
         Version(s)|20.05.00, 19.11.02          |20.05.00, 19.11.02,
        released in|                            |19.05.07

--- Comment #12 from Lucas Gass <lucas at bywatersolutions.com> ---
backported to 19.05.x for 19.05.07

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 16 00:04:11 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 15 Jan 2020 23:04:11 +0000
Subject: [Koha-bugs] [Bug 23493] jquery.dataTables.rowGrouping.js is no
 longer maintained,
 but there is an official DataTables version we could switch to
In-Reply-To: <bug-23493-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23493-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23493-70-G2zP6gC4b7@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23493

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off
                 CC|                            |katrin.fischer at bsz-bw.de

--- Comment #9 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
I think this should be signed off - changing status.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 16 00:08:33 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 15 Jan 2020 23:08:33 +0000
Subject: [Koha-bugs] [Bug 24328] Bibliographic frameworks fail to install
In-Reply-To: <bug-24328-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24328-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24328-70-YiUjhVOK6z@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24328

Lucas Gass <lucas at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|20.05.00, 19.11.02          |20.05.00, 19.11.02,
        released in|                            |19.05.07
             Status|Pushed to stable            |Pushed to oldstable
                 CC|                            |lucas at bywatersolutions.com

--- Comment #7 from Lucas Gass <lucas at bywatersolutions.com> ---
backported to 19.05.x for 19.05.07

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 16 00:14:03 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 15 Jan 2020 23:14:03 +0000
Subject: [Koha-bugs] [Bug 24395] Floats in cash registers have 6 decimals
In-Reply-To: <bug-24395-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24395-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24395-70-VVburzqBSw@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24395

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff
   Patch complexity|---                         |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 16 00:14:06 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 15 Jan 2020 23:14:06 +0000
Subject: [Koha-bugs] [Bug 24395] Floats in cash registers have 6 decimals
In-Reply-To: <bug-24395-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24395-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24395-70-d3KMBQV8L7@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24395

--- Comment #2 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 97422
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97422&action=edit
Bug 24395: Show initial float using the Price TT plugin on summary page

For displaying monetary amounts, we should be using the Price TT
plugin everywhere. This adds it to the cash register summary page.

To test:
- Create a cash register
- Check the cash register table for "Initial float"
- Verify the amount shows with more than 2 decimals
- Edit cash register - verify the same display there
- Apply patch
- Check again - it should display now with only 2 decimals

Note: This doesn't fix

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 16 00:14:22 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 15 Jan 2020 23:14:22 +0000
Subject: [Koha-bugs] [Bug 24104] Item search - dropdown buttons overflow
In-Reply-To: <bug-24104-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24104-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24104-70-HrpGhiYBQD@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24104

Lucas Gass <lucas at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|20.05.00, 19.11.02          |20.05.00, 19.11.02,
        released in|                            |19.05.07
             Status|Pushed to stable            |Pushed to oldstable
                 CC|                            |lucas at bywatersolutions.com

--- Comment #7 from Lucas Gass <lucas at bywatersolutions.com> ---
backported to 19.05.x for 19.05.07

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 16 00:14:25 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 15 Jan 2020 23:14:25 +0000
Subject: [Koha-bugs] [Bug 24395] Floats in cash registers have 6 decimals
In-Reply-To: <bug-24395-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24395-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24395-70-C2S71XJbi0@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24395

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|enhancement                 |minor
           Assignee|koha-bugs at lists.koha-commun |katrin.fischer at bsz-bw.de
                   |ity.org                     |

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 16 00:15:30 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 15 Jan 2020 23:15:30 +0000
Subject: [Koha-bugs] [Bug 24395] Floats in cash registers have 6 decimals
In-Reply-To: <bug-24395-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24395-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24395-70-BYCapM9ThG@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24395

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #97422|0                           |1
        is obsolete|                            |

--- Comment #3 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 97423
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97423&action=edit
Bug 24395: Show initial float using the Price TT plugin on summary page

For displaying monetary amounts, we should be using the Price TT
plugin everywhere. This adds it to the cash register summary page.

To test:
- Create a cash register
- Check the cash register table for "Initial float"
- Verify the amount shows with more than 2 decimals
- Edit cash register - verify the same display there
- Apply patch
- Check again - it should display now with only 2 decimals

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 16 00:16:31 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 15 Jan 2020 23:16:31 +0000
Subject: [Koha-bugs] [Bug 24232] Fix permissions for deleting a bib record
 after attaching the last item to another bib
In-Reply-To: <bug-24232-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24232-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24232-70-17l74dBlzc@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24232

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de
            Summary|Deleting a bib record after |Fix permissions for
                   |attaching the last item to  |deleting a bib record after
                   |another bib                 |attaching the last item to
                   |                            |another bib

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 16 00:18:32 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 15 Jan 2020 23:18:32 +0000
Subject: [Koha-bugs] [Bug 24432] Request an endpoint with a date column in
 order by throws bad parameter exception
In-Reply-To: <bug-24432-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24432-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24432-70-OozoRwZWvs@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24432

Agustín Moyano <agustinmoyano at theke.io> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Small patch
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 16 00:18:35 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 15 Jan 2020 23:18:35 +0000
Subject: [Koha-bugs] [Bug 24432] Request an endpoint with a date column in
 order by throws bad parameter exception
In-Reply-To: <bug-24432-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24432-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24432-70-a6Nydcj1AB@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24432

Agustín Moyano <agustinmoyano at theke.io> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #97421|0                           |1
        is obsolete|                            |

--- Comment #2 from Agustín Moyano <agustinmoyano at theke.io> ---
Created attachment 97424
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97424&action=edit
Bug 24432: Regresion test

To test:
1. apply this patch
2. prove t/Koha/REST/Plugin/Query.t

Test should fail at this point.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 16 00:18:38 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 15 Jan 2020 23:18:38 +0000
Subject: [Koha-bugs] [Bug 24432] Request an endpoint with a date column in
 order by throws bad parameter exception
In-Reply-To: <bug-24432-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24432-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24432-70-DeexfUhUHz@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24432

--- Comment #3 from Agustín Moyano <agustinmoyano at theke.io> ---
Created attachment 97425
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97425&action=edit
Bug 24432: add Koha::Objects->from_api_mapping

This patch adds from_api_mapping to Koha::Objects, in order to be able to get
the mapping from a result set.

To test:
1. apply this patch
2. prove t/db_dependent/Koha/Objects.t
3. sign off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 16 00:18:39 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 15 Jan 2020 23:18:39 +0000
Subject: [Koha-bugs] [Bug 18057] koha-restore should stop koha-indexer
 before deleting files
In-Reply-To: <bug-18057-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18057-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18057-70-0bHj7QGtFl@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18057

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|NEW                         |RESOLVED

--- Comment #4 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Closing INVALID for now, please reopen if this is still an issue.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 16 00:18:42 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 15 Jan 2020 23:18:42 +0000
Subject: [Koha-bugs] [Bug 24432] Request an endpoint with a date column in
 order by throws bad parameter exception
In-Reply-To: <bug-24432-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24432-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24432-70-fbT3MJzWZE@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24432

--- Comment #4 from Agustín Moyano <agustinmoyano at theke.io> ---
Created attachment 97426
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97426&action=edit
Bug 24432: Use Koha::Objects->from_api_mapping instead of attributes_from_api
to get the column name in Koha::REST::Plugins::Query->_build_order_atom

Use the mapping instead of building a fake hash only to get the key name.

To test:
1. apply this patch
2. prove t/Koha/REST/Plugin/Query.t
3. sign off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 16 00:22:02 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 15 Jan 2020 23:22:02 +0000
Subject: [Koha-bugs] [Bug 24099] Capitalization: Copier Fees
In-Reply-To: <bug-24099-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24099-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24099-70-oC6gwFSaXj@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24099

--- Comment #2 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Hi Lisette, you are right - it doesn't appear in new installations, but it will
for updated installations if there are a bit older - there is an update in
updatedatabase adding it:

$dbh->do("INSERT INTO authorised_values (category,authorised_value,lib) VALUES
('MANUAL_INV','Copier Fees','.25')");


I wonder if it's worth changing that?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 16 00:52:29 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 15 Jan 2020 23:52:29 +0000
Subject: [Koha-bugs] [Bug 10469] Display more when editing subfields in
 frameworks
In-Reply-To: <bug-10469-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-10469-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10469-70-e5mdsEqcJt@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10469

Hayley Mapley <hayleymapley at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |hayleymapley at catalyst.net.n
                   |                            |z

--- Comment #10 from Hayley Mapley <hayleymapley at catalyst.net.nz> ---
Enhancement will not be backported to 18.11.x series.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 16 00:56:54 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 15 Jan 2020 23:56:54 +0000
Subject: [Koha-bugs] [Bug 24312] Update MARC21 frameworks to Updates 28+29
 (May and November 2019)
In-Reply-To: <bug-24312-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24312-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24312-70-NeMz2OwejG@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24312

Hayley Mapley <hayleymapley at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |hayleymapley at catalyst.net.n
                   |                            |z

--- Comment #12 from Hayley Mapley <hayleymapley at catalyst.net.nz> ---
Enhancement will not be backported to 18.11.x series.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 16 00:57:21 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 15 Jan 2020 23:57:21 +0000
Subject: [Koha-bugs] [Bug 24314] Update de-DE MARC21 frameworks for updates
 28+29 (May and November 2019)
In-Reply-To: <bug-24314-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24314-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24314-70-epWyyHxuyc@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24314

Hayley Mapley <hayleymapley at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |hayleymapley at catalyst.net.n
                   |                            |z

--- Comment #13 from Hayley Mapley <hayleymapley at catalyst.net.nz> ---
Enhancement will not be backported to 18.11.x series.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 16 01:52:28 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 16 Jan 2020 00:52:28 +0000
Subject: [Koha-bugs] [Bug 24432] order_by broken for date columns
In-Reply-To: <bug-24432-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24432-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24432-70-oOk8xJ96UP@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24432

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Request an endpoint with a  |order_by broken for date
                   |date column in order by     |columns
                   |throws bad parameter        |
                   |exception                   |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 16 02:23:25 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 16 Jan 2020 01:23:25 +0000
Subject: [Koha-bugs] [Bug 24104] Item search - dropdown buttons overflow
In-Reply-To: <bug-24104-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24104-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24104-70-ncqdR4XL3e@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24104

Hayley Mapley <hayleymapley at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|20.05.00, 19.11.02,         |20.05.00, 19.11.02,
        released in|19.05.07                    |19.05.07, 18.11.13
                 CC|                            |hayleymapley at catalyst.net.n
                   |                            |z
             Status|Pushed to oldstable         |Pushed to oldoldstable

--- Comment #8 from Hayley Mapley <hayleymapley at catalyst.net.nz> ---
Backported to 18.11.x for 18.11.13

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 16 02:54:34 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 16 Jan 2020 01:54:34 +0000
Subject: [Koha-bugs] [Bug 24420] Cataloging search results Location column
 should account for waiting on hold items
In-Reply-To: <bug-24420-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24420-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24420-70-FT8ADEhyPS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24420

Barbara Johnson <barbara.johnson at bedfordtx.gov> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 16 07:23:17 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 16 Jan 2020 06:23:17 +0000
Subject: [Koha-bugs] [Bug 24215] Warnings about guarantor relationships show
 ARRAY errors
In-Reply-To: <bug-24215-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24215-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24215-70-JpATY0olDW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24215

--- Comment #18 from Rudolf Byker <rudolfbyker at gmail.com> ---
Sorry, I misread the third part of the version number! :)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 16 08:20:00 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 16 Jan 2020 07:20:00 +0000
Subject: [Koha-bugs] [Bug 12502] Add columns for note,
 order number and ISBN to late orders page
In-Reply-To: <bug-12502-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-12502-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12502-70-aHOOj3gyxu@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12502

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA
   Patch complexity|---                         |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 16 08:20:05 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 16 Jan 2020 07:20:05 +0000
Subject: [Koha-bugs] [Bug 12502] Add columns for note,
 order number and ISBN to late orders page
In-Reply-To: <bug-12502-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-12502-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12502-70-45Sy7sTVoR@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12502

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #95438|0                           |1
        is obsolete|                            |

--- Comment #46 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 97427
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97427&action=edit
Bug 12502: Add vendor note, internal note, ordernumber and isbn to late orders
page

Test plan:

0) Make sure you have a late order
    a) Create a test vendor unless you have one
    b) Create a test basket unless you have one
    c) Close the basket to mark the order as late
1) Go to the late orders table
Before patch : Orderno, ISBN, vendor notes, internal notes are absent
After patch: fields are present

2) Edit the vendor note and/or the internal note
3) Press the save notes button
4) Refresh page and cache (CTRL+F5), if notes have been correctly saved, your
modifications should be displayed.

Signed-off-by: Alex Buckley <alexbuckley at catalyst.net.nz>
Signed-off-by: Séverine QUEUNE <severine.queune at bulac.fr>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 16 08:20:10 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 16 Jan 2020 07:20:10 +0000
Subject: [Koha-bugs] [Bug 12502] Add columns for note,
 order number and ISBN to late orders page
In-Reply-To: <bug-12502-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-12502-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12502-70-qdedKr99c6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12502

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #95439|0                           |1
        is obsolete|                            |

--- Comment #47 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 97428
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97428&action=edit
Bug 12502: (follow-up) Use modal to add/edit order notes

Replace inputs to edit notes by a link opening a modal, similar
to the basket summary page. This makes it possible for the notes
to appear in the datatable exports.

Also fix exporting with the export as csv button at the bottom
of the page to export notes.

Test plan :
1) In the late orders table (acqui/lateorders.pl), a link should
appear in both the internal and vendor note column, following the
current value if it exist.
    -> This link should read "Add ..." if there is no existing note
    or "Edit ..." if there is.
2) Click on the link. A modal should appear. Confirm that saving a
note works as expected.
3) Try exporting to any format using either the button at the top
of the table or the one at the bottom of the page.
    -> The three new columns and their values should appear in the
    export.

Signed-off-by: Séverine QUEUNE <severine.queune at bulac.fr>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 16 08:20:14 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 16 Jan 2020 07:20:14 +0000
Subject: [Koha-bugs] [Bug 12502] Add columns for note,
 order number and ISBN to late orders page
In-Reply-To: <bug-12502-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-12502-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12502-70-pJ7Qs0rwvn@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12502

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #95440|0                           |1
        is obsolete|                            |

--- Comment #48 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 97429
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97429&action=edit
Bug 12502: (QA follow-up) Remove the Save button

Signed-off-by: Séverine QUEUNE <severine.queune at bulac.fr>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 16 08:20:19 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 16 Jan 2020 07:20:19 +0000
Subject: [Koha-bugs] [Bug 12502] Add columns for note,
 order number and ISBN to late orders page
In-Reply-To: <bug-12502-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-12502-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12502-70-42YtbLDmmg@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12502

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #95441|0                           |1
        is obsolete|                            |

--- Comment #49 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 97430
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97430&action=edit
Bug 12502: (follow-up) Adds formatting for datatables export

Add a format option to the datatables export that remove .noExport
elements present in a data cell, just as .noExport columns are
not exported.

To test:
1. For late orders (which uses .noExport elements in data cells) :
    Export data in any format using the export button at the top
    of the datatable.
        => data should exclude "Add/Edit note" label, but
        otherwise look the same as before the patch.
2. Try exporting data in other datatables in Koha and make sure
exported data is the same before and after applying the patch.

Signed-off-by: Séverine QUEUNE <severine.queune at bulac.fr>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 16 08:20:49 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 16 Jan 2020 07:20:49 +0000
Subject: [Koha-bugs] [Bug 12502] Add columns for note,
 order number and ISBN to late orders page
In-Reply-To: <bug-12502-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-12502-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12502-70-WN1HF075HM@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12502

--- Comment #50 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Thx a lot for your patience with this one - I feel it works really nicely now!

Also passes prove t/db_dependent/Acquisition.t.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 16 08:21:43 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 16 Jan 2020 07:21:43 +0000
Subject: [Koha-bugs] [Bug 24161] Late orders improvements - keeping track of
 claims
In-Reply-To: <bug-24161-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24161-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24161-70-aUWfzzzjh5@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24161

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         QA Contact|testopia at bugs.koha-communit |katrin.fischer at bsz-bw.de
                   |y.org                       |
            Version|unspecified                 |master
                 CC|                            |katrin.fischer at bsz-bw.de

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 16 08:22:52 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 16 Jan 2020 07:22:52 +0000
Subject: [Koha-bugs] [Bug 24161] Late orders improvements - keeping track of
 claims
In-Reply-To: <bug-24161-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24161-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24161-70-91etsoMcp9@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24161

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Patch doesn't apply

--- Comment #7 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Hi Jonathan, working on this tree - can you please do a quick rebase/check?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 16 08:26:26 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 16 Jan 2020 07:26:26 +0000
Subject: [Koha-bugs] [Bug 23929] Invoice adjustments should filter inactive
 funds
In-Reply-To: <bug-23929-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23929-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23929-70-3pczHUu0Su@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23929

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |koha at univ-lyon3.fr
                   |ity.org                     |

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 16 09:28:32 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 16 Jan 2020 08:28:32 +0000
Subject: [Koha-bugs] [Bug 24364] Display item holding library in opac issues
In-Reply-To: <bug-24364-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24364-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24364-70-dBkCcVpEov@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24364

--- Comment #13 from Matthias Meusburger <matthias.meusburger at biblibre.com> ---
Created attachment 97431
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97431&action=edit
Bug 24364: Display item holding library in opac issues

Test plan:

 Check that the library is displayed in patrons opac issues.
 ('Your summary' -> 'Checked out' and 'Overdue' tabs)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 16 09:47:47 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 16 Jan 2020 08:47:47 +0000
Subject: [Koha-bugs] [Bug 24395] Floats in cash registers have 6 decimals
In-Reply-To: <bug-24395-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24395-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24395-70-n6PUg70uX3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24395

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 16 09:47:50 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 16 Jan 2020 08:47:50 +0000
Subject: [Koha-bugs] [Bug 24395] Floats in cash registers have 6 decimals
In-Reply-To: <bug-24395-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24395-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24395-70-I2VylB17Ql@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24395

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #97423|0                           |1
        is obsolete|                            |

--- Comment #4 from David Nind <david at davidnind.com> ---
Created attachment 97432
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97432&action=edit
Bug 24395: Show initial float using the Price TT plugin on summary page

For displaying monetary amounts, we should be using the Price TT
plugin everywhere. This adds it to the cash register summary page.

To test:
- Enable the cash register feature (set UseCashRegisters to 'Use')
- Go to More > Administration > Accounting > Cash registers
- Create a cash register
- Check the cash register table for "Initial float"
- Verify the amount shows with more than 2 decimals
- Edit cash register - verify the same display there
- Apply patch
- Check again - it should display now with only 2 decimals

Signed-off-by: David Nind <david at davidnind.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 16 10:03:14 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 16 Jan 2020 09:03:14 +0000
Subject: [Koha-bugs] [Bug 24296] Move stock rotation transfer triggers from
 `comments` to `trigger`
In-Reply-To: <bug-24296-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24296-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24296-70-iX7pTgO6In@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24296

--- Comment #1 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 97433
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97433&action=edit
Bug 24296: Update stockrotation process to use branchtransfers.trigger

This patch updates all occurences of stockrotation related lookups of
branchtransfers status from using the 'comments' field to using the new
'trigger' field.

Test plan:
1) Work through the process of creating a stock rotation plan and adding
   items to the plan.. no errors should be encoutered during this process.
2) Run the stockrotation cronjob to move some items on.. no errors
   should be encountered.
3) Navigate to the transferstosend page in the circulation area of the
   staff client.. no errors should be encountered.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 16 10:03:17 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 16 Jan 2020 09:03:17 +0000
Subject: [Koha-bugs] [Bug 24296] Move stock rotation transfer triggers from
 `comments` to `trigger`
In-Reply-To: <bug-24296-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24296-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24296-70-UgQgMjPXou@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24296

--- Comment #2 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 97434
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97434&action=edit
Bug 24296: Update existing data in the database

This DB udpate adds the stockration states to the trigger enum in the
branchtransfers table and then populates it with any such data currently
contained within the comments field.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 16 10:16:44 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 16 Jan 2020 09:16:44 +0000
Subject: [Koha-bugs] [Bug 24296] Move stock rotation transfer triggers from
 `comments` to `trigger`
In-Reply-To: <bug-24296-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24296-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24296-70-kQC6TlHXka@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24296

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 16 10:16:48 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 16 Jan 2020 09:16:48 +0000
Subject: [Koha-bugs] [Bug 24296] Move stock rotation transfer triggers from
 `comments` to `trigger`
In-Reply-To: <bug-24296-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24296-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24296-70-bvhbyHagci@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24296

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |martin.renvoize at ptfs-europe
                   |ity.org                     |.com

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 16 10:16:57 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 16 Jan 2020 09:16:57 +0000
Subject: [Koha-bugs] [Bug 24296] Move stock rotation transfer triggers from
 `comments` to `trigger`
In-Reply-To: <bug-24296-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24296-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24296-70-h9Ma9ldLg2@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24296

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |nick at bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 16 10:19:19 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 16 Jan 2020 09:19:19 +0000
Subject: [Koha-bugs] [Bug 24298] Record if a transfer was triggered by
 'return to homebranch'
In-Reply-To: <bug-24298-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24298-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24298-70-NdrsLxWa1E@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24298

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|24287                       |24296


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24287
[Bug 24287] Transfers should record how they were triggered.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24296
[Bug 24296] Move stock rotation transfer triggers from `comments` to `trigger`
-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 16 10:19:19 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 16 Jan 2020 09:19:19 +0000
Subject: [Koha-bugs] [Bug 24287] Transfers should record how they were
 triggered.
In-Reply-To: <bug-24287-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24287-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24287-70-6kJoNEanyu@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24287

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|24298                       |


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24298
[Bug 24298] Record if a transfer was triggered by 'return to homebranch'
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 16 10:19:19 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 16 Jan 2020 09:19:19 +0000
Subject: [Koha-bugs] [Bug 24296] Move stock rotation transfer triggers from
 `comments` to `trigger`
In-Reply-To: <bug-24296-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24296-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24296-70-0K8skmS357@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24296

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |24298


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24298
[Bug 24298] Record if a transfer was triggered by 'return to homebranch'
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 16 10:20:47 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 16 Jan 2020 09:20:47 +0000
Subject: [Koha-bugs] [Bug 24299] Record if a transfer was triggered by
 'rotating collections'
In-Reply-To: <bug-24299-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24299-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24299-70-55o5XfsjlI@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24299

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|24287                       |24298


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24287
[Bug 24287] Transfers should record how they were triggered.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24298
[Bug 24298] Record if a transfer was triggered by 'return to homebranch'
-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 16 10:20:47 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 16 Jan 2020 09:20:47 +0000
Subject: [Koha-bugs] [Bug 24287] Transfers should record how they were
 triggered.
In-Reply-To: <bug-24287-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24287-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24287-70-W0WUZqAAdg@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24287

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|24299                       |


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24299
[Bug 24299] Record if a transfer was triggered by 'rotating collections'
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 16 10:20:47 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 16 Jan 2020 09:20:47 +0000
Subject: [Koha-bugs] [Bug 24298] Record if a transfer was triggered by
 'return to homebranch'
In-Reply-To: <bug-24298-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24298-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24298-70-JCEV5u9LHn@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24298

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |24299


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24299
[Bug 24299] Record if a transfer was triggered by 'rotating collections'
-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 16 10:21:22 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 16 Jan 2020 09:21:22 +0000
Subject: [Koha-bugs] [Bug 24298] Record if a transfer was triggered by
 'return to homebranch'
In-Reply-To: <bug-24298-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24298-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24298-70-V4Baun3xsU@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24298

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|4234                        |


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4234
[Bug 4234] Automatic transfer shouldn't take precedence over a hold transit
-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 16 10:21:22 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 16 Jan 2020 09:21:22 +0000
Subject: [Koha-bugs] [Bug 4234] Automatic transfer shouldn't take precedence
 over a hold transit
In-Reply-To: <bug-4234-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-4234-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-4234-70-2mztwRO9aO@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4234

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|24298                       |


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24298
[Bug 24298] Record if a transfer was triggered by 'return to homebranch'
-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 16 10:21:48 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 16 Jan 2020 09:21:48 +0000
Subject: [Koha-bugs] [Bug 24297] Record if a transfer was triggered
 'manually'
In-Reply-To: <bug-24297-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24297-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24297-70-dTBw8X3VZy@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24297

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|24287                       |24299


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24287
[Bug 24287] Transfers should record how they were triggered.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24299
[Bug 24299] Record if a transfer was triggered by 'rotating collections'
-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 16 10:21:48 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 16 Jan 2020 09:21:48 +0000
Subject: [Koha-bugs] [Bug 24287] Transfers should record how they were
 triggered.
In-Reply-To: <bug-24287-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24287-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24287-70-wPgwWS4xDl@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24287

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|24297                       |


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24297
[Bug 24297] Record if a transfer was triggered 'manually'
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 16 10:21:48 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 16 Jan 2020 09:21:48 +0000
Subject: [Koha-bugs] [Bug 24299] Record if a transfer was triggered by
 'rotating collections'
In-Reply-To: <bug-24299-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24299-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24299-70-FfZRXs2UE3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24299

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |24297


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24297
[Bug 24297] Record if a transfer was triggered 'manually'
-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 16 10:22:30 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 16 Jan 2020 09:22:30 +0000
Subject: [Koha-bugs] [Bug 24298] Record if a transfer was triggered by
 'return to homebranch'
In-Reply-To: <bug-24298-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24298-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24298-70-gvpk0dhjzU@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24298

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |4234


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4234
[Bug 4234] Automatic transfer shouldn't take precedence over a hold transit
-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 16 10:22:30 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 16 Jan 2020 09:22:30 +0000
Subject: [Koha-bugs] [Bug 4234] Automatic transfer shouldn't take precedence
 over a hold transit
In-Reply-To: <bug-4234-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-4234-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-4234-70-4myYOFVb1E@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4234

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |24298


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24298
[Bug 24298] Record if a transfer was triggered by 'return to homebranch'
-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 16 10:23:02 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 16 Jan 2020 09:23:02 +0000
Subject: [Koha-bugs] [Bug 24296] Move stock rotation transfer triggers from
 `comments` to `trigger`
In-Reply-To: <bug-24296-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24296-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24296-70-wQbyflJ249@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24296

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|4234                        |


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4234
[Bug 4234] Automatic transfer shouldn't take precedence over a hold transit
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 16 10:23:02 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 16 Jan 2020 09:23:02 +0000
Subject: [Koha-bugs] [Bug 4234] Automatic transfer shouldn't take precedence
 over a hold transit
In-Reply-To: <bug-4234-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-4234-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-4234-70-4oSAJxsB0W@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4234

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|24296                       |


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24296
[Bug 24296] Move stock rotation transfer triggers from `comments` to `trigger`
-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 16 10:23:08 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 16 Jan 2020 09:23:08 +0000
Subject: [Koha-bugs] [Bug 24298] Record if a transfer was triggered by
 'return to homebranch'
In-Reply-To: <bug-24298-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24298-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24298-70-xZGQTAjmKU@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24298

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|4234                        |


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4234
[Bug 4234] Automatic transfer shouldn't take precedence over a hold transit
-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 16 10:23:08 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 16 Jan 2020 09:23:08 +0000
Subject: [Koha-bugs] [Bug 4234] Automatic transfer shouldn't take precedence
 over a hold transit
In-Reply-To: <bug-4234-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-4234-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-4234-70-sxduBsoMhy@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4234

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|24298                       |


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24298
[Bug 24298] Record if a transfer was triggered by 'return to homebranch'
-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 16 10:23:19 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 16 Jan 2020 09:23:19 +0000
Subject: [Koha-bugs] [Bug 24299] Record if a transfer was triggered by
 'rotating collections'
In-Reply-To: <bug-24299-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24299-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24299-70-dwkpwIc32a@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24299

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|4234                        |


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4234
[Bug 4234] Automatic transfer shouldn't take precedence over a hold transit
-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 16 10:23:19 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 16 Jan 2020 09:23:19 +0000
Subject: [Koha-bugs] [Bug 4234] Automatic transfer shouldn't take precedence
 over a hold transit
In-Reply-To: <bug-4234-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-4234-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-4234-70-WS7FFGHFGM@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4234

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|24299                       |


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24299
[Bug 24299] Record if a transfer was triggered by 'rotating collections'
-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 16 10:32:10 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 16 Jan 2020 09:32:10 +0000
Subject: [Koha-bugs] [Bug 24423] Broken link to return to record after batch
 item modification
In-Reply-To: <bug-24423-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24423-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24423-70-kdejNMrWg5@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24423

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 16 10:32:14 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 16 Jan 2020 09:32:14 +0000
Subject: [Koha-bugs] [Bug 24423] Broken link to return to record after batch
 item modification
In-Reply-To: <bug-24423-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24423-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24423-70-LVDsnnVeNr@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24423

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #97405|0                           |1
        is obsolete|                            |

--- Comment #5 from David Nind <david at davidnind.com> ---
Created attachment 97435
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97435&action=edit
Bug 24423: Add biblionumber to modify items link

To test:
- Find/create a bib with at least one item
- From detail.pl, use the checkboxes in the holdings table to select one or
more items
- Click the "Modify Selected Items" link just above the holdings table to take
your item(s) to batch modification
- Change something and click save
- Observe that the Return to the Record link points to a url without a
biblionumber: "/cgi-bin/koha/catalogue/detail.pl?biblionumber="
- Apply patch
- Repeat
- The link now works!

Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

Signed-off-by: David Nind <david at davidnind.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 16 10:59:22 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 16 Jan 2020 09:59:22 +0000
Subject: [Koha-bugs] [Bug 22569] Stock rotation: 'Transfers to send' report
In-Reply-To: <bug-22569-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22569-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22569-70-Ov151S1Sr2@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22569

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|24287                       |
         Depends on|                            |24296


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24287
[Bug 24287] Transfers should record how they were triggered.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24296
[Bug 24296] Move stock rotation transfer triggers from `comments` to `trigger`
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 16 10:59:22 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 16 Jan 2020 09:59:22 +0000
Subject: [Koha-bugs] [Bug 24287] Transfers should record how they were
 triggered.
In-Reply-To: <bug-24287-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24287-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24287-70-JdsfxQF4b3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24287

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|22569                       |


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22569
[Bug 22569] Stock rotation: 'Transfers to send' report
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 16 10:59:22 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 16 Jan 2020 09:59:22 +0000
Subject: [Koha-bugs] [Bug 24296] Move stock rotation transfer triggers from
 `comments` to `trigger`
In-Reply-To: <bug-24296-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24296-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24296-70-KhRhIOzRU3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24296

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |22569


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22569
[Bug 22569] Stock rotation: 'Transfers to send' report
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 16 11:00:59 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 16 Jan 2020 10:00:59 +0000
Subject: [Koha-bugs] [Bug 23432] Stock rotation: cancelled transfer result
 in stockrotation failures
In-Reply-To: <bug-23432-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23432-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23432-70-76dDlAIJlm@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23432

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|22569                       |


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22569
[Bug 22569] Stock rotation: 'Transfers to send' report
-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 16 11:00:59 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 16 Jan 2020 10:00:59 +0000
Subject: [Koha-bugs] [Bug 22569] Stock rotation: 'Transfers to send' report
In-Reply-To: <bug-22569-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22569-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22569-70-31dLMklVMX@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22569

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|23432                       |


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23432
[Bug 23432] Stock rotation: cancelled transfer result in stockrotation failures
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 16 11:02:39 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 16 Jan 2020 10:02:39 +0000
Subject: [Koha-bugs] [Bug 22569] Stock rotation: 'Transfers to send' report
In-Reply-To: <bug-22569-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22569-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22569-70-gy3Nu8vPPP@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22569

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|24296                       |24297


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24296
[Bug 24296] Move stock rotation transfer triggers from `comments` to `trigger`
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24297
[Bug 24297] Record if a transfer was triggered 'manually'
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 16 11:02:39 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 16 Jan 2020 10:02:39 +0000
Subject: [Koha-bugs] [Bug 24296] Move stock rotation transfer triggers from
 `comments` to `trigger`
In-Reply-To: <bug-24296-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24296-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24296-70-QISNPZFemt@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24296

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|22569                       |


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22569
[Bug 22569] Stock rotation: 'Transfers to send' report
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 16 11:02:39 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 16 Jan 2020 10:02:39 +0000
Subject: [Koha-bugs] [Bug 24297] Record if a transfer was triggered
 'manually'
In-Reply-To: <bug-24297-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24297-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24297-70-3i1IsNXePy@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24297

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |22569


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22569
[Bug 22569] Stock rotation: 'Transfers to send' report
-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 16 11:03:30 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 16 Jan 2020 10:03:30 +0000
Subject: [Koha-bugs] [Bug 22569] Stock rotation: 'Transfers to send' report
In-Reply-To: <bug-22569-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22569-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22569-70-dEaWI3hiZo@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22569

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |22160


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22160
[Bug 22160] OMNIBUS: Transfers enhancements
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 16 11:03:30 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 16 Jan 2020 10:03:30 +0000
Subject: [Koha-bugs] [Bug 22160] OMNIBUS: Transfers enhancements
In-Reply-To: <bug-22160-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22160-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22160-70-PI5lGYPEyi@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22160

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |22569


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22569
[Bug 22569] Stock rotation: 'Transfers to send' report
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 16 12:24:27 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 16 Jan 2020 11:24:27 +0000
Subject: [Koha-bugs] [Bug 24340] We ought to be able to disable SIP using
 koha-sip
In-Reply-To: <bug-24340-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24340-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24340-70-7jXgHHXcA5@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24340

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |tomascohen at gmail.com

--- Comment #13 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
My feeling is we should go the koha-email-enable/disable way, and have a file
in /var/lib/koha/<instance>/sip.enabled instead of relaying on the
SIPConfig.xml file for making the decision. Touching the config file looks
overkill to me. I agree it could be part of enabling, if there is no config.
Probably with --force-create-config or similar.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 16 12:31:06 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 16 Jan 2020 11:31:06 +0000
Subject: [Koha-bugs] [Bug 24423] Broken link to return to record after batch
 item modification
In-Reply-To: <bug-24423-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24423-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24423-70-EcMjjMafYv@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24423

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |23987


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23987
[Bug 23987] batchMod.pl provides a link back to the record after the record is
deleted
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 16 12:31:06 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 16 Jan 2020 11:31:06 +0000
Subject: [Koha-bugs] [Bug 23987] batchMod.pl provides a link back to the
 record after the record is deleted
In-Reply-To: <bug-23987-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23987-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23987-70-JKDa5od34q@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23987

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |24423


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24423
[Bug 24423] Broken link to return to record after batch item modification
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 16 12:36:46 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 16 Jan 2020 11:36:46 +0000
Subject: [Koha-bugs] [Bug 24429] Advanced editor - Add ability to generate
 an export file as cataloger saves
In-Reply-To: <bug-24429-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24429-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24429-70-mTI210vCg4@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24429

--- Comment #2 from Cori Lynn Arnold <carnold at dgiinc.com> ---
Created attachment 97436
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97436&action=edit
Bug 21250: DBRev 19.12.00.010

Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 16 12:39:29 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 16 Jan 2020 11:39:29 +0000
Subject: [Koha-bugs] [Bug 24423] Broken link to return to record after batch
 item modification
In-Reply-To: <bug-24423-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24423-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24423-70-HJyOMEayFv@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24423

--- Comment #6 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 97437
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97437&action=edit
Bug 24423: Fix for deletion - cleanup accidental debug inclusiopm

To test:
Repeat prior test plan with 'Delete selected'

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 16 12:43:37 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 16 Jan 2020 11:43:37 +0000
Subject: [Koha-bugs] [Bug 23089] Elasticsearch - cannot sort on non-text
 fields
In-Reply-To: <bug-23089-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23089-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23089-70-U2JOZasidB@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23089

--- Comment #24 from Nick Clemens <nick at bywatersolutions.com> ---
Note that sites receiving this patch will need to rebuild their ES indexes due
to the change to field_config

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 16 12:44:59 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 16 Jan 2020 11:44:59 +0000
Subject: [Koha-bugs] [Bug 24429] Advanced editor - Add ability to generate
 an export file as cataloger saves
In-Reply-To: <bug-24429-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24429-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24429-70-cViGILjNTA@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24429

Cori Lynn Arnold <carnold at dgiinc.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #97436|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 16 14:06:59 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 16 Jan 2020 13:06:59 +0000
Subject: [Koha-bugs] [Bug 22405] Funds from inactive budgets appear in
 'Funds' dropdown on acqui/orderreceive.pl
In-Reply-To: <bug-22405-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22405-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22405-70-sV3R18RoK2@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22405

Karen <karen.mccormack at cit.ie> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |karen.mccormack at cit.ie

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 16 14:13:55 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 16 Jan 2020 13:13:55 +0000
Subject: [Koha-bugs] [Bug 24377] Record branch in statistics for auto-renewal
In-Reply-To: <bug-24377-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24377-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24377-70-qcopEMUeeL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24377

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 16 14:13:58 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 16 Jan 2020 13:13:58 +0000
Subject: [Koha-bugs] [Bug 24377] Record branch in statistics for auto-renewal
In-Reply-To: <bug-24377-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24377-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24377-70-7cmHb2R3Ev@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24377

--- Comment #2 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 97438
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97438&action=edit
Bug 24377: Unit test

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 16 14:14:01 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 16 Jan 2020 13:14:01 +0000
Subject: [Koha-bugs] [Bug 24377] Record branch in statistics for auto-renewal
In-Reply-To: <bug-24377-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24377-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24377-70-GUxAxdnoYm@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24377

--- Comment #3 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 97439
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97439&action=edit
Bug 24377: Record passed branch if renewing via cron

To test:
1 - Checkout an item with auto renewal set and eligible for auto renew
2 - Set no renewal before in the circ rules to 99 (something greater than the
checkout period)
3 - perl misc/cronjobs/automatic_renewals.pl
4 - Check the statistics table, note the branch for renewal is null
    SELECT * FROM statistics WHERE itemnumber={itemnumber} AND type='RENEWAL'
5 - Apply patch
6 - Repeat 1-4
7 - Note the branch is set to the issuing branch

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 16 14:14:29 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 16 Jan 2020 13:14:29 +0000
Subject: [Koha-bugs] [Bug 24377] Record branch in statistics for auto-renewal
In-Reply-To: <bug-24377-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24377-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24377-70-Y9tC2k9O9I@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24377

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |nick at bywatersolutions.com
                   |ity.org                     |
                 CC|                            |nick at bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 16 14:14:34 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 16 Jan 2020 13:14:34 +0000
Subject: [Koha-bugs] [Bug 24364] Display item holding library in opac issues
In-Reply-To: <bug-24364-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24364-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24364-70-7c5RyVAbHy@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24364

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 16 14:14:37 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 16 Jan 2020 13:14:37 +0000
Subject: [Koha-bugs] [Bug 24364] Display item holding library in opac issues
In-Reply-To: <bug-24364-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24364-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24364-70-TfIlOggwY4@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24364

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #97145|0                           |1
        is obsolete|                            |
  Attachment #97431|0                           |1
        is obsolete|                            |

--- Comment #14 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 97440
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97440&action=edit
Bug 24364: Display item holding library in opac issues

Test plan:

 Check that the library is displayed in patrons opac issues.
 ('Your summary' -> 'Checked out' and 'Overdue' tabs)


Current status: Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 16 14:14:40 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 16 Jan 2020 13:14:40 +0000
Subject: [Koha-bugs] [Bug 24377] Record branch in statistics for auto-renewal
In-Reply-To: <bug-24377-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24377-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24377-70-C6K2ZOwNq6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24377

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |22600


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22600
[Bug 22600] We should add an 'interface' field to accountlines
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 16 14:14:40 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 16 Jan 2020 13:14:40 +0000
Subject: [Koha-bugs] [Bug 22600] We should add an 'interface' field to
 accountlines
In-Reply-To: <bug-22600-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22600-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22600-70-gyObT8YAdJ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22600

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |24377


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24377
[Bug 24377] Record branch in statistics for auto-renewal
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 16 14:46:54 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 16 Jan 2020 13:46:54 +0000
Subject: [Koha-bugs] [Bug 24377] Record branch in statistics for auto-renewal
In-Reply-To: <bug-24377-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24377-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24377-70-AlI2TllJHa@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24377

ByWater Sandboxes <bws.sandboxes at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #97438|0                           |1
        is obsolete|                            |

--- Comment #4 from ByWater Sandboxes <bws.sandboxes at gmail.com> ---
Created attachment 97441
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97441&action=edit
Bug 24377: Unit test

Signed-off-by: Andrew Fuerste-Henry <andrew at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 16 14:46:56 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 16 Jan 2020 13:46:56 +0000
Subject: [Koha-bugs] [Bug 24377] Record branch in statistics for auto-renewal
In-Reply-To: <bug-24377-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24377-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24377-70-jIPYl118Co@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24377

ByWater Sandboxes <bws.sandboxes at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #97439|0                           |1
        is obsolete|                            |

--- Comment #5 from ByWater Sandboxes <bws.sandboxes at gmail.com> ---
Created attachment 97442
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97442&action=edit
Bug 24377: Record passed branch if renewing via cron

To test:
1 - Checkout an item with auto renewal set and eligible for auto renew
2 - Set no renewal before in the circ rules to 99 (something greater than the
checkout period)
3 - perl misc/cronjobs/automatic_renewals.pl
4 - Check the statistics table, note the branch for renewal is null
    SELECT * FROM statistics WHERE itemnumber={itemnumber} AND type='RENEWAL'
5 - Apply patch
6 - Repeat 1-4
7 - Note the branch is set to the issuing branch

Signed-off-by: Andrew Fuerste-Henry <andrew at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 16 15:00:09 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 16 Jan 2020 14:00:09 +0000
Subject: [Koha-bugs] [Bug 14792] Fix visibility check for 'place holds' link
 in OPAC result list
In-Reply-To: <bug-14792-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14792-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14792-70-koN42hZ7tH@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14792

Patrick Robitaille <patrick.robitaille at collecto.ca> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |patrick.robitaille at collecto
                   |                            |.ca

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 16 15:15:15 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 16 Jan 2020 14:15:15 +0000
Subject: [Koha-bugs] [Bug 24341] Allow for more complex markup in OPAC
 confirmation dialogs
In-Reply-To: <bug-24341-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24341-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24341-70-hD124bQFxV@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24341

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |24433


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24433
[Bug 24433] OPAC account page no longer asks for confirmation before deleting
hold
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 16 15:15:15 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 16 Jan 2020 14:15:15 +0000
Subject: [Koha-bugs] [Bug 21772] Add holds and account information tab to
 the SCO module
In-Reply-To: <bug-21772-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21772-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21772-70-UpVg2rvt9d@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21772

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |24433


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24433
[Bug 24433] OPAC account page no longer asks for confirmation before deleting
hold
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 16 15:15:15 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 16 Jan 2020 14:15:15 +0000
Subject: [Koha-bugs] [Bug 24433] New: OPAC account page no longer asks for
 confirmation before deleting hold
Message-ID: <bug-24433-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24433

            Bug ID: 24433
           Summary: OPAC account page no longer asks for confirmation
                    before deleting hold
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: ASSIGNED
          Severity: normal
          Priority: P5 - low
         Component: Templates
          Assignee: oleonard at myacpl.org
          Reporter: oleonard at myacpl.org
        QA Contact: testopia at bugs.koha-community.org
                CC: katrin.fischer at bsz-bw.de,
                    testopia at bugs.koha-community.org
        Depends on: 24341, 21772

Bug 21772, when adding holds-table.inc, used an older version of opac-detail.tt
to create the include. This broke the hold confirmation modal.


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21772
[Bug 21772] Add holds and account information tab to the SCO module
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24341
[Bug 24341] Allow for more complex markup in OPAC confirmation dialogs
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 16 15:15:48 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 16 Jan 2020 14:15:48 +0000
Subject: [Koha-bugs] [Bug 24341] Allow for more complex markup in OPAC
 confirmation dialogs
In-Reply-To: <bug-24341-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24341-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24341-70-f5xAOe81BI@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24341

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Signed Off

--- Comment #4 from Owen Leonard <oleonard at myacpl.org> ---
(In reply to Katrin Fischer from comment #3)
> Cancelling a hold in the OPAC doesn't ask for confirmation in my testing -
> can you pleas check?

This is true in master too. I've created Bug 24433

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 16 15:30:40 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 16 Jan 2020 14:30:40 +0000
Subject: [Koha-bugs] [Bug 24273] Add  IIIF compatibility
In-Reply-To: <bug-24273-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24273-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24273-70-kwHi8h17rF@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24273

--- Comment #2 from Pedro Urra <urrape at gmail.com> ---
(In reply to Katrin Fischer from comment #1)
> Hi Pedro, can you explain a bit more which features would have to be added
> to Koha?

1. Include openseadragon like client side viewer to see IIIF objects in Koha
OPAC. In a similar way that you can see today images located in outside
servers.
That will permits the interoperability with IIIF collections. 
Drupal for example, created a iiif field to show this kind of resources.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 16 15:37:52 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 16 Jan 2020 14:37:52 +0000
Subject: [Koha-bugs] [Bug 24430] Remove C4::Biblio::CountBiblioInOrders
In-Reply-To: <bug-24430-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24430-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24430-70-v5rNbyObt4@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24430

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #97416|0                           |1
        is obsolete|                            |

--- Comment #4 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 97443
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97443&action=edit
Bug 24430: Remove CountBiblioInOrders and its traces

This patch replaces the only uses of CountBiblioInOrders and makes that
code use $biblio->orders->count instead.

Test nothing breaks in basket.pl and parcel.pl

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 16 15:43:32 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 16 Jan 2020 14:43:32 +0000
Subject: [Koha-bugs] [Bug 22220] Error in ReWriteRule for 'bib' in
 apache-shared-intranet.conf
In-Reply-To: <bug-22220-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22220-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22220-70-wsIXti8d1U@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22220

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff
   Patch complexity|---                         |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 16 15:43:35 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 16 Jan 2020 14:43:35 +0000
Subject: [Koha-bugs] [Bug 22220] Error in ReWriteRule for 'bib' in
 apache-shared-intranet.conf
In-Reply-To: <bug-22220-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22220-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22220-70-DWDPLp70MY@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22220

--- Comment #1 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 97444
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97444&action=edit
Bug 22220: Fix bib Apache rewrite rule for intranet

Trivial change. Speaks for itself.
Since koha/detail.pl does not exist, we cannot break things ;)

Test plan:
[1] Copy the change in apache-shared-intranet.conf to your actual
    apache configuration. Probably in /etc/koha/.
[2] Restart Apache.
[3] Try a biblionumber say 123 on intranet with [your_staff_client]/bib/123.
    Does the detail page come up?

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 16 15:44:06 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 16 Jan 2020 14:44:06 +0000
Subject: [Koha-bugs] [Bug 22220] Error in ReWriteRule for 'bib' in
 apache-shared-intranet.conf
In-Reply-To: <bug-22220-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22220-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22220-70-EvjpY1sq4U@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22220

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off
           Assignee|koha-bugs at lists.koha-commun |m.de.rooy at rijksmuseum.nl
                   |ity.org                     |
                 CC|                            |m.de.rooy at rijksmuseum.nl

--- Comment #2 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Trivial patch, promoting to SO.
Nick: could you test/QA ?

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 16 15:58:19 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 16 Jan 2020 14:58:19 +0000
Subject: [Koha-bugs] [Bug 24433] OPAC account page no longer asks for
 confirmation before deleting hold
In-Reply-To: <bug-24433-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24433-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24433-70-SkyLTXnMLi@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24433

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Small patch
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 16 15:58:22 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 16 Jan 2020 14:58:22 +0000
Subject: [Koha-bugs] [Bug 24433] OPAC account page no longer asks for
 confirmation before deleting hold
In-Reply-To: <bug-24433-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24433-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24433-70-h7IyumUnXO@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24433

--- Comment #1 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 97445
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97445&action=edit
Bug 24433: OPAC account page no longer asks for confirmation before deleting
hold

This patch restores markup added by Bug 21870 and subsequently removed
accidentally by Bug 21772. This allows the OPAC user summary page to
display a confirmation dialog before deleting a hold.

To test, apply the patch and  log in to the OPAC as a user with holds.

 - On the "Your summary" page, click the "Holds" tab.
 - Click the "Cancel" button next to any hold.
 - You should see a modal dialog asking for confirmation, showing the
   correct title.
 - Test both the "Yes" and "No" actions.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 16 16:15:21 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 16 Jan 2020 15:15:21 +0000
Subject: [Koha-bugs] [Bug 19306] Adding hooks to the plugin system
In-Reply-To: <bug-19306-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19306-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19306-70-KoW6G2vdg0@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19306

Arthur Suzuki <arthur.suzuki at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |arthur.suzuki at biblibre.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 16 16:17:54 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 16 Jan 2020 15:17:54 +0000
Subject: [Koha-bugs] [Bug 24434] New: C4::Circulation::updateWrongTransfer
 is never called and should be removed
Message-ID: <bug-24434-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24434

            Bug ID: 24434
           Summary: C4::Circulation::updateWrongTransfer is never called
                    and should be removed
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Architecture, internals, and plumbing
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: martin.renvoize at ptfs-europe.com
        QA Contact: testopia at bugs.koha-community.org

As far as I can tell, the only place that used to call updateWrongTransfer was
circ/returns.pl, but the corresponding template no longer passes the parameter
used to trigger the call ever.

I think we can safely remove the call and corresponding method.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 16 16:18:15 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 16 Jan 2020 15:18:15 +0000
Subject: [Koha-bugs] [Bug 24434] C4::Circulation::updateWrongTransfer is
 never called and should be removed
In-Reply-To: <bug-24434-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24434-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24434-70-mbdeN39qRX@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24434

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |martin.renvoize at ptfs-europe
                   |ity.org                     |.com

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 16 16:18:37 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 16 Jan 2020 15:18:37 +0000
Subject: [Koha-bugs] [Bug 24434] C4::Circulation::updateWrongTransfer is
 never called and should be removed
In-Reply-To: <bug-24434-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24434-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24434-70-MX51OPNuqs@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24434

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |24298


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24298
[Bug 24298] Record if a transfer was triggered by 'return to homebranch'
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 16 16:18:37 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 16 Jan 2020 15:18:37 +0000
Subject: [Koha-bugs] [Bug 24298] Record if a transfer was triggered by
 'return to homebranch'
In-Reply-To: <bug-24298-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24298-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24298-70-gAlrVNyo9L@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24298

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |24434


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24434
[Bug 24434] C4::Circulation::updateWrongTransfer is never called and should be
removed
-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 16 16:32:18 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 16 Jan 2020 15:32:18 +0000
Subject: [Koha-bugs] [Bug 24430] Remove C4::Biblio::CountBiblioInOrders
In-Reply-To: <bug-24430-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24430-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24430-70-VnT15V3GXD@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24430

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |tomascohen at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 16 16:32:19 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 16 Jan 2020 15:32:19 +0000
Subject: [Koha-bugs] [Bug 24430] Remove C4::Biblio::CountBiblioInOrders
In-Reply-To: <bug-24430-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24430-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24430-70-reQjrf8wAu@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24430

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #97443|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 16 16:32:21 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 16 Jan 2020 15:32:21 +0000
Subject: [Koha-bugs] [Bug 24430] Remove C4::Biblio::CountBiblioInOrders
In-Reply-To: <bug-24430-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24430-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24430-70-PDBLoupL3g@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24430

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #97414|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 16 16:32:23 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 16 Jan 2020 15:32:23 +0000
Subject: [Koha-bugs] [Bug 24430] Remove C4::Biblio::CountBiblioInOrders
In-Reply-To: <bug-24430-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24430-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24430-70-BwTnwUA4qf@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24430

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #97415|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 16 16:33:14 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 16 Jan 2020 15:33:14 +0000
Subject: [Koha-bugs] [Bug 24430] Remove C4::Biblio::CountBiblioInOrders
In-Reply-To: <bug-24430-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24430-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24430-70-FoJI0mI6iR@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24430

--- Comment #5 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 97446
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97446&action=edit
Bug 24430: Unit tests

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 16 16:33:17 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 16 Jan 2020 15:33:17 +0000
Subject: [Koha-bugs] [Bug 24430] Remove C4::Biblio::CountBiblioInOrders
In-Reply-To: <bug-24430-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24430-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24430-70-KdFEromZKl@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24430

--- Comment #6 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 97447
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97447&action=edit
Bug 24430: Add ->orders and ->active_orders_count to Koha::Biblio

This patch introduces an accessor to the related orders, and a method
that returns the active orders count. The target usage for the count is the
API. In the rest of the codebase, we would just call:

    $biblio->orders->count

To test:
1. Apply this patches
2. Run:
   $ kshell
  k$ prove t/db_dependent/Koha/Biblio.t
=> SUCCESS: Tests pass!
3. Sign off :-D

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 16 16:33:21 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 16 Jan 2020 15:33:21 +0000
Subject: [Koha-bugs] [Bug 24430] Remove C4::Biblio::CountBiblioInOrders
In-Reply-To: <bug-24430-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24430-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24430-70-6zFdwIDONs@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24430

--- Comment #7 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 97448
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97448&action=edit
Bug 24430: Remove CountBiblioInOrders and its traces

This patch replaces the only uses of CountBiblioInOrders and makes that
code use $biblio->orders->count instead.

Test nothing breaks in basket.pl and parcel.pl

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 16 16:33:40 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 16 Jan 2020 15:33:40 +0000
Subject: [Koha-bugs] [Bug 24434] C4::Circulation::updateWrongTransfer is
 never called and should be removed
In-Reply-To: <bug-24434-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24434-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24434-70-uzVIi4LmuT@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24434

--- Comment #1 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 97449
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97449&action=edit
Bug 24434: Remove updateWrongTransfer

This patch simply removes the unused updateWrongTransfer method from
C4::Circulation.

Test plan: Read code and varify that the method would never actually be
triggered.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 16 16:33:53 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 16 Jan 2020 15:33:53 +0000
Subject: [Koha-bugs] [Bug 24434] C4::Circulation::updateWrongTransfer is
 never called and should be removed
In-Reply-To: <bug-24434-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24434-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24434-70-WF9j24JrQu@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24434

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 16 16:34:21 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 16 Jan 2020 15:34:21 +0000
Subject: [Koha-bugs] [Bug 24434] C4::Circulation::updateWrongTransfer is
 never called and should be removed
In-Reply-To: <bug-24434-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24434-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24434-70-HjGDmEnVii@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24434

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org,
                   |                            |kyle at bywatersolutions.com,
                   |                            |nick at bywatersolutions.com,
                   |                            |tomascohen at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 16 16:34:26 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 16 Jan 2020 15:34:26 +0000
Subject: [Koha-bugs] [Bug 24434] C4::Circulation::updateWrongTransfer is
 never called and should be removed
In-Reply-To: <bug-24434-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24434-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24434-70-0OU6TIsisz@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24434

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 16 16:37:09 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 16 Jan 2020 15:37:09 +0000
Subject: [Koha-bugs] [Bug 24298] Record if a transfer was triggered by
 'return to homebranch'
In-Reply-To: <bug-24298-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24298-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24298-70-dDhBVtXE10@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24298

--- Comment #1 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 97450
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97450&action=edit
Bug 24298: Add return enums to branchstransfer triggers

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 16 16:37:12 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 16 Jan 2020 15:37:12 +0000
Subject: [Koha-bugs] [Bug 24298] Record if a transfer was triggered by
 'return to homebranch'
In-Reply-To: <bug-24298-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24298-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24298-70-taHVuw7Ga1@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24298

--- Comment #2 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 97451
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97451&action=edit
Bug 24298: Record transfer triggers for returns

This patch adds handling to catch transfers that may have been triggered
on item return.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 16 16:37:24 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 16 Jan 2020 15:37:24 +0000
Subject: [Koha-bugs] [Bug 24298] Record if a transfer was triggered by
 'return to homebranch'
In-Reply-To: <bug-24298-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24298-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24298-70-1iscB3cGuI@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24298

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 16 16:37:45 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 16 Jan 2020 15:37:45 +0000
Subject: [Koha-bugs] [Bug 24298] Record if a transfer was triggered by
 'return to homebranch'
In-Reply-To: <bug-24298-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24298-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24298-70-E2oljCVHXX@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24298

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org,
                   |                            |tomascohen at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 16 16:41:23 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 16 Jan 2020 15:41:23 +0000
Subject: [Koha-bugs] [Bug 22220] Error in ReWriteRule for 'bib' in
 apache-shared-intranet.conf
In-Reply-To: <bug-22220-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22220-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22220-70-aWHwVqBlbc@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22220

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 16 16:41:25 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 16 Jan 2020 15:41:25 +0000
Subject: [Koha-bugs] [Bug 22220] Error in ReWriteRule for 'bib' in
 apache-shared-intranet.conf
In-Reply-To: <bug-22220-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22220-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22220-70-KjXHwBe6uC@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22220

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #97444|0                           |1
        is obsolete|                            |

--- Comment #3 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 97452
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97452&action=edit
Bug 22220: Fix bib Apache rewrite rule for intranet

Trivial change. Speaks for itself.
Since koha/detail.pl does not exist, we cannot break things ;)

Test plan:
[1] Copy the change in apache-shared-intranet.conf to your actual
    apache configuration. Probably in /etc/koha/.
[2] Restart Apache.
[3] Try a biblionumber say 123 on intranet with [your_staff_client]/bib/123.
    Does the detail page come up?

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 16 16:42:23 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 16 Jan 2020 15:42:23 +0000
Subject: [Koha-bugs] [Bug 22220] Error in ReWriteRule for 'bib' in
 apache-shared-intranet.conf
In-Reply-To: <bug-22220-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22220-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22220-70-OTIU8qu33z@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22220

--- Comment #4 from Nick Clemens <nick at bywatersolutions.com> ---
Worked beautifully, once i figured out how to test in a gitified install ;-)

Hint: Copy the changed line to:
/etc/koha/apache-shared-intranet-git.conf

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 16 16:53:19 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 16 Jan 2020 15:53:19 +0000
Subject: [Koha-bugs] [Bug 24273] Add  IIIF compatibility
In-Reply-To: <bug-24273-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24273-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24273-70-YpDqvtLmgF@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24273

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|oleonard at myacpl.org         |koha-bugs at lists.koha-commun
                   |                            |ity.org

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 16 16:53:23 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 16 Jan 2020 15:53:23 +0000
Subject: [Koha-bugs] [Bug 24377] Record branch in statistics for auto-renewal
In-Reply-To: <bug-24377-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24377-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24377-70-rk7DFQR8BM@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24377

ByWater Sandboxes <bws.sandboxes at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #97442|0                           |1
        is obsolete|                            |

--- Comment #6 from ByWater Sandboxes <bws.sandboxes at gmail.com> ---
Created attachment 97453
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97453&action=edit
Bug 24377: Record passed branch if renewing via cron

To test:
1 - Checkout an item with auto renewal set and eligible for auto renew
2 - Set no renewal before in the circ rules to 99 (something greater than the
checkout period)
3 - perl misc/cronjobs/automatic_renewals.pl
4 - Check the statistics table, note the branch for renewal is null
    SELECT * FROM statistics WHERE itemnumber={itemnumber} AND type='RENEWAL'
5 - Apply patch
6 - Repeat 1-4
7 - Note the branch is set to the issuing branch

Signed-off-by: Andrew Fuerste-Henry <andrew at bywatersolutions.com>

Signed-off-by: Ed Veal <eveal at mckinneytexas.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 16 16:56:24 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 16 Jan 2020 15:56:24 +0000
Subject: [Koha-bugs] [Bug 7468] Add label to batch by barcode range
In-Reply-To: <bug-7468-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-7468-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7468-70-uOHP8ppJrX@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7468

--- Comment #32 from Maryse Simard <maryse.simard at inlibro.com> ---
Created attachment 97454
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97454&action=edit
Bug 7468: Print barcodes by range

Adds an option to the label creator to print a range of barcodes.
Only allows printing to PDF.

C4/Label.pm had to get minor changes to override database-based barcode
generation. Same with labels/label-create-pdf.pl. By default, the
barcode is fetched from the database using the itemnumber, but when
printing ranges, you might not have a corresponding  database entry.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 16 16:56:28 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 16 Jan 2020 15:56:28 +0000
Subject: [Koha-bugs] [Bug 7468] Add label to batch by barcode range
In-Reply-To: <bug-7468-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-7468-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7468-70-ylZNwYbG2j@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7468

--- Comment #33 from Maryse Simard <maryse.simard at inlibro.com> ---
Created attachment 97455
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97455&action=edit
Bug 7468: Fix 'false' message on Firefox

It seems I was using an href to a javascript function in the 'Print Range'
button, which Chrome didn't mind, but Firefox did understand.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 16 16:56:31 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 16 Jan 2020 15:56:31 +0000
Subject: [Koha-bugs] [Bug 7468] Add label to batch by barcode range
In-Reply-To: <bug-7468-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-7468-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7468-70-VF52q3uLpw@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7468

--- Comment #34 from Maryse Simard <maryse.simard at inlibro.com> ---
Created attachment 97456
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97456&action=edit
Bug 7468: Add warning when range has non-existent barcodes

+ Added a warning when the user selects a range with some non-existent
barcodes, and a layout without barcodes.
This allows the user to print barcodes of items not in the database if he so
desires, but will warn him if he tries to print only biblios (which results in
missing entries or a blank page).

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 16 16:56:35 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 16 Jan 2020 15:56:35 +0000
Subject: [Koha-bugs] [Bug 7468] Add label to batch by barcode range
In-Reply-To: <bug-7468-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-7468-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7468-70-W4WhyCwe0X@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7468

--- Comment #35 from Maryse Simard <maryse.simard at inlibro.com> ---
Created attachment 97457
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97457&action=edit
Bug 7468: Showing the error message according to the community interface
patterns, fixing a javascript condition

TEST PLAN++

1) Apply all the patches
2) Connect to the intranet with an account with permissions to visit the
"Tools" page
3) Go to /cgi-bin/koha/labels/label-home.pl
    . Either by entering the URL directly
    . OR, from the front page, by clicking "Tools", followed by the hyperlink
"Label creator" under the "Catalog" section
4) Under the "+ New" button, a new option should be available: "Barcode range"
5) Fill the "From:" and the "To:" fields of the "Print barcode range" form
    . Keeping both fields at "0" should trigger a warning beside the first
field: "*Cannot be smaller than 1"
    . If the value "From:" is greater the "To:" value, a warning should appear
beside the second field: "*Cannot be smaller than the starting value"
    . Make sure the form doesn't let you enter non-numerical values
    . For a casual test, use "From: 1000" and "To: 1100"
6) After pressing the "Print Range" button, choose a template, a layout, and a
starting position
    . The "DEFAULT TEMPLATE 01" has a page height of 5pt and a page width of
0pt, don't use it
    . All the default layouts should look alike, since we're only printing a
barcode over a number, and not bibliographic information
    . Using a layout not defined as 'Barcode' will show a warning message
7) Clicking the "Export" button should lead to a second dialog window with a
"Download as PDF" hyperlink. Clicking the link should prop up a download dialog
box
8) Save the PDF locally, or simply open it, and make sure the options you used
were taken into account

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 16 16:56:39 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 16 Jan 2020 15:56:39 +0000
Subject: [Koha-bugs] [Bug 7468] Add label to batch by barcode range
In-Reply-To: <bug-7468-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-7468-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7468-70-xfIXK3cyL3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7468

--- Comment #36 from Maryse Simard <maryse.simard at inlibro.com> ---
Created attachment 97458
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97458&action=edit
Bug 7468: (follow-up) Make sure only integers are accepted as from/to values

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 16 16:56:46 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 16 Jan 2020 15:56:46 +0000
Subject: [Koha-bugs] [Bug 7468] Add label to batch by barcode range
In-Reply-To: <bug-7468-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-7468-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7468-70-jRhGZG3WFx@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7468

Maryse Simard <maryse.simard at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #91569|0                           |1
        is obsolete|                            |

--- Comment #37 from Maryse Simard <maryse.simard at inlibro.com> ---
Created attachment 97459
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97459&action=edit
Bug 7468: (follow-up) fix label-edit-range template

Edit the labels/label-edit-range.tt template to follow current
standards :
    - Use footer javascript
    - Use bootstrap grid
    - Use jQuery Validation plugin for validation

Also fixes breadcrumbs to be more specific.

To test:
Make sure the page looks correct and still works as expected.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 16 16:56:52 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 16 Jan 2020 15:56:52 +0000
Subject: [Koha-bugs] [Bug 7468] Add label to batch by barcode range
In-Reply-To: <bug-7468-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-7468-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7468-70-JDBvXIghFq@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7468

Maryse Simard <maryse.simard at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #91570|0                           |1
        is obsolete|                            |

--- Comment #38 from Maryse Simard <maryse.simard at inlibro.com> ---
Created attachment 97460
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97460&action=edit
Bug 7468: (follow-up) Add missing filters

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 16 16:56:57 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 16 Jan 2020 15:56:57 +0000
Subject: [Koha-bugs] [Bug 7468] Add label to batch by barcode range
In-Reply-To: <bug-7468-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-7468-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7468-70-AieXU0aO2g@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7468

--- Comment #39 from Maryse Simard <maryse.simard at inlibro.com> ---
Created attachment 97461
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97461&action=edit
Bug 7468: fix the export labels popup header

When exporting a barcode range, the export popup should display "1 batch
to export" instead of "0 batches to export". In this context, it can be
considered a label batch and should be counted as such.

To test:
When clicking the "Print range" button, the popup should show "1 batch
to export".

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 16 16:59:57 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 16 Jan 2020 15:59:57 +0000
Subject: [Koha-bugs] [Bug 7468] Add label to batch by barcode range
In-Reply-To: <bug-7468-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-7468-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7468-70-obEOAKVkg3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7468

Maryse Simard <maryse.simard at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Needs Signoff

--- Comment #40 from Maryse Simard <maryse.simard at inlibro.com> ---
I've reattached the commits with corrected message titles. I also added a new
patch to correct the popup message, it should now show "1 batch to export" when
exporting a barcode range.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 16 17:31:41 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 16 Jan 2020 16:31:41 +0000
Subject: [Koha-bugs] [Bug 24435] New: Add Koha::Biblio->items_count
Message-ID: <bug-24435-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24435

            Bug ID: 24435
           Summary: Add Koha::Biblio->items_count
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Architecture, internals, and plumbing
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: tomascohen at gmail.com
        QA Contact: testopia at bugs.koha-community.org

This simple method can be used in several places. For example for embedding
counts on related API objects.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 16 17:36:44 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 16 Jan 2020 16:36:44 +0000
Subject: [Koha-bugs] [Bug 24435] Add Koha::Biblio->items_count
In-Reply-To: <bug-24435-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24435-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24435-70-WzxMf9XZqQ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24435

--- Comment #1 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 97462
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97462&action=edit
Bug 24435: Unit tests

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 16 17:36:47 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 16 Jan 2020 16:36:47 +0000
Subject: [Koha-bugs] [Bug 24435] Add Koha::Biblio->items_count
In-Reply-To: <bug-24435-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24435-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24435-70-eyNiyyosFa@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24435

--- Comment #2 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 97463
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97463&action=edit
Bug 24435: Add Koha::Biblio->items_count

This patch introduces a handy shortcut to get the items count for a
biblio. So instead of calling:

  $count = $biblio->items->count;
you can call:
  $count = $biblio->items_count;

The use case for this, is when we want to embed information on objects
to be sent as API responses. In that case, calling ->items->count needs
to be done manually on the controller script, with interesting added
complexity. With this kind of method, we can just require it to be
embedded automagically by calling the following on the API:

   $biblio->to_api({ embed => { items_count => {} } });

If there are several nested layers of objects, doing manually can get
really tricky and error prone.

To test:
1. Apply this patches
2. Run:
   $ kshell
  k$ prove t/db_dependent/Koha/Biblio.t
=> SUCCESS: Tests pass!
3. Sign off :-D

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 16 17:44:05 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 16 Jan 2020 16:44:05 +0000
Subject: [Koha-bugs] [Bug 24299] Record if a transfer was triggered by
 'rotating collections'
In-Reply-To: <bug-24299-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24299-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24299-70-mOTgah4vz6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24299

--- Comment #1 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 97464
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97464&action=edit
Bug 24299: Add 'RotatingCollection' branchtransfer trigger

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 16 17:44:08 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 16 Jan 2020 16:44:08 +0000
Subject: [Koha-bugs] [Bug 24299] Record if a transfer was triggered by
 'rotating collections'
In-Reply-To: <bug-24299-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24299-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24299-70-hW9G9ZrsSI@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24299

--- Comment #2 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 97465
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97465&action=edit
Bug 24299: Record 'RotatingCollection' as a transfer trigger

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 16 17:44:48 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 16 Jan 2020 16:44:48 +0000
Subject: [Koha-bugs] [Bug 24299] Record if a transfer was triggered by
 'rotating collections'
In-Reply-To: <bug-24299-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24299-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24299-70-nrCLSYHuDs@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24299

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 16 17:46:11 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 16 Jan 2020 16:46:11 +0000
Subject: [Koha-bugs] [Bug 23092] Transfers should record 'requested' as well
 as 'sent' and 'arrived' dates.
In-Reply-To: <bug-23092-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23092-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23092-70-l6WzaR61I0@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23092

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |24297


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24297
[Bug 24297] Record if a transfer was triggered 'manually'
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 16 17:46:11 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 16 Jan 2020 16:46:11 +0000
Subject: [Koha-bugs] [Bug 24297] Record if a transfer was triggered
 'manually'
In-Reply-To: <bug-24297-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24297-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24297-70-fln8TuVd0k@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24297

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |23092


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23092
[Bug 23092] Transfers should record 'requested' as well as  'sent' and
'arrived' dates.
-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 16 17:46:55 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 16 Jan 2020 16:46:55 +0000
Subject: [Koha-bugs] [Bug 22569] Stock rotation: 'Transfers to send' report
In-Reply-To: <bug-22569-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22569-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22569-70-JimoT5m70W@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22569

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|24297                       |


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24297
[Bug 24297] Record if a transfer was triggered 'manually'
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 16 17:46:55 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 16 Jan 2020 16:46:55 +0000
Subject: [Koha-bugs] [Bug 24297] Record if a transfer was triggered
 'manually'
In-Reply-To: <bug-24297-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24297-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24297-70-IAYKrKMslR@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24297

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|22569                       |


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22569
[Bug 22569] Stock rotation: 'Transfers to send' report
-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 16 17:48:56 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 16 Jan 2020 16:48:56 +0000
Subject: [Koha-bugs] [Bug 24436] New: Record if a transfer was triggered by
 a 'reserve'
Message-ID: <bug-24436-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24436

            Bug ID: 24436
           Summary: Record if a transfer was triggered by a 'reserve'
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Circulation
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: martin.renvoize at ptfs-europe.com
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com,
                    koha-bugs at lists.koha-community.org,
                    kyle.m.hall at gmail.com,
                    testopia at bugs.koha-community.org
        Depends on: 24297, 24299
            Blocks: 4234, 23092

Using the new 'trigger' field in branchtransfers to record if a transfer was
added by a reserve.


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4234
[Bug 4234] Automatic transfer shouldn't take precedence over a hold transit
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23092
[Bug 23092] Transfers should record 'requested' as well as  'sent' and
'arrived' dates.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24297
[Bug 24297] Record if a transfer was triggered 'manually'
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24299
[Bug 24299] Record if a transfer was triggered by 'rotating collections'
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 16 17:48:56 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 16 Jan 2020 16:48:56 +0000
Subject: [Koha-bugs] [Bug 24297] Record if a transfer was triggered
 'manually'
In-Reply-To: <bug-24297-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24297-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24297-70-SjwRb0axWX@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24297

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |24436


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24436
[Bug 24436] Record if a transfer was triggered by a 'reserve'
-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 16 17:48:56 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 16 Jan 2020 16:48:56 +0000
Subject: [Koha-bugs] [Bug 24299] Record if a transfer was triggered by
 'rotating collections'
In-Reply-To: <bug-24299-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24299-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24299-70-QSv9DWKm1W@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24299

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |24436


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24436
[Bug 24436] Record if a transfer was triggered by a 'reserve'
-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 16 17:48:56 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 16 Jan 2020 16:48:56 +0000
Subject: [Koha-bugs] [Bug 4234] Automatic transfer shouldn't take precedence
 over a hold transit
In-Reply-To: <bug-4234-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-4234-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-4234-70-xUyU74qdYf@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4234

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |24436


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24436
[Bug 24436] Record if a transfer was triggered by a 'reserve'
-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 16 17:48:56 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 16 Jan 2020 16:48:56 +0000
Subject: [Koha-bugs] [Bug 23092] Transfers should record 'requested' as well
 as 'sent' and 'arrived' dates.
In-Reply-To: <bug-23092-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23092-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23092-70-7rKYzmAamf@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23092

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |24436


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24436
[Bug 24436] Record if a transfer was triggered by a 'reserve'
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 16 17:49:01 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 16 Jan 2020 16:49:01 +0000
Subject: [Koha-bugs] [Bug 24437] New: Circulation Rules are not Respecting
 Correct Rule if Library is Using Hard Due Dates
Message-ID: <bug-24437-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24437

            Bug ID: 24437
           Summary: Circulation Rules are not Respecting Correct Rule if
                    Library is Using Hard Due Dates
 Change sponsored?: ---
           Product: Koha
           Version: 19.05
          Hardware: All
                OS: All
            Status: NEW
          Severity: critical
          Priority: P5 - low
         Component: Circulation
          Assignee: nick at bywatersolutions.com
          Reporter: kelly at bywatersolutions.com
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com

If a library has a circulation rule specific to their library and contains a
Hard Due Date and also a circulation rule with a hard due date (set in the
past) in the "Standard" set of rules, Koha is calling the standard rule first
and then when prompted with a Yellow Box to enter a due date, if hit "Yes",
Koha will then call the right rule (library-specific rule).

Test:
1. Have a rule set up in a library-specific branch set with Hard Due Before
Date in Future
2. Have the same rule set up in the standard set of rules with a Hard Due date
set in the past.
3. Check out a book in the library that there is a library-specific rule.
4. Koha will call the standard set of rules, will be unable to assign a due
date since it is in the past and present a library with a yellow box to enter a
date.
5. If library hits YES without setting a date, Koha will call the due date
using the correct (library-specific rules).

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 16 17:49:50 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 16 Jan 2020 16:49:50 +0000
Subject: [Koha-bugs] [Bug 24436] Record if a transfer was triggered by a
 'reserve'
In-Reply-To: <bug-24436-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24436-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24436-70-ZDcGCHzR2A@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24436

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|24297                       |
             Blocks|                            |24297


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24297
[Bug 24297] Record if a transfer was triggered 'manually'
-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 16 17:49:50 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 16 Jan 2020 16:49:50 +0000
Subject: [Koha-bugs] [Bug 24297] Record if a transfer was triggered
 'manually'
In-Reply-To: <bug-24297-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24297-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24297-70-EQvIF7RtUS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24297

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|24436                       |
         Depends on|                            |24436


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24436
[Bug 24436] Record if a transfer was triggered by a 'reserve'
-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 16 17:50:46 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 16 Jan 2020 16:50:46 +0000
Subject: [Koha-bugs] [Bug 24297] Record if a transfer was triggered
 'manually'
In-Reply-To: <bug-24297-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24297-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24297-70-vLkkSWr8Jv@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24297

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|24299                       |


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24299
[Bug 24299] Record if a transfer was triggered by 'rotating collections'
-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 16 17:50:46 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 16 Jan 2020 16:50:46 +0000
Subject: [Koha-bugs] [Bug 24299] Record if a transfer was triggered by
 'rotating collections'
In-Reply-To: <bug-24299-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24299-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24299-70-uGg56M7bvK@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24299

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|24297                       |


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24297
[Bug 24297] Record if a transfer was triggered 'manually'
-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 16 17:51:38 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 16 Jan 2020 16:51:38 +0000
Subject: [Koha-bugs] [Bug 24436] Record if a transfer was triggered by a
 'reserve'
In-Reply-To: <bug-24436-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24436-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24436-70-PTWqrDKNXE@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24436

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|4234, 23092                 |


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4234
[Bug 4234] Automatic transfer shouldn't take precedence over a hold transit
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23092
[Bug 23092] Transfers should record 'requested' as well as  'sent' and
'arrived' dates.
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 16 17:51:38 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 16 Jan 2020 16:51:38 +0000
Subject: [Koha-bugs] [Bug 4234] Automatic transfer shouldn't take precedence
 over a hold transit
In-Reply-To: <bug-4234-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-4234-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-4234-70-EKYbaMSJZG@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4234

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|24436                       |


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24436
[Bug 24436] Record if a transfer was triggered by a 'reserve'
-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 16 17:51:38 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 16 Jan 2020 16:51:38 +0000
Subject: [Koha-bugs] [Bug 23092] Transfers should record 'requested' as well
 as 'sent' and 'arrived' dates.
In-Reply-To: <bug-23092-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23092-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23092-70-QnmkgofHng@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23092

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|24436                       |


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24436
[Bug 24436] Record if a transfer was triggered by a 'reserve'
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 16 17:52:06 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 16 Jan 2020 16:52:06 +0000
Subject: [Koha-bugs] [Bug 24299] Record if a transfer was triggered by
 'rotating collections'
In-Reply-To: <bug-24299-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24299-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24299-70-lssjkykD3N@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24299

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |martin.renvoize at ptfs-europe
                   |ity.org                     |.com

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 16 18:41:09 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 16 Jan 2020 17:41:09 +0000
Subject: [Koha-bugs] [Bug 24363] Datepicker calendar is not sexy on
 additem.pl
In-Reply-To: <bug-24363-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24363-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24363-70-ycSb0tnFwH@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24363

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Needs Signoff
   Patch complexity|---                         |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 16 18:41:11 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 16 Jan 2020 17:41:11 +0000
Subject: [Koha-bugs] [Bug 24363] Datepicker calendar is not sexy on
 additem.pl
In-Reply-To: <bug-24363-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24363-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24363-70-eC5CkFu5Te@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24363

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #96899|0                           |1
        is obsolete|                            |

--- Comment #9 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 97466
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97466&action=edit
Bug 24363: Datepicker calendar is not sexy on additem.pl

This patch is essentially an alternative to Bug 24181. Instead of trying
to make the datepicker inputs match default fields, it defines a default
style for text inputs, selects, and textareas. This new default style
borrows some from Bootstrap's input styling and some from the Select2
plugin's style. This makes forms like the one on the add item page have
unified styling for all fields.

To test, apply the patch and rebuild the staff client CSS
(https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client).

Test as many pages as you can to look for consistent styling of form
fields: Patron entry, cataloging (basic and advanced), reports,
batch item modification, system preferences, etc.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 16 18:49:35 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 16 Jan 2020 17:49:35 +0000
Subject: [Koha-bugs] [Bug 24437] Circulation Rules are not Respecting
 Correct Rule if Library is Using Hard Due Dates
In-Reply-To: <bug-24437-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24437-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24437-70-wq1y7CO3np@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24437

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=23382

--- Comment #1 from Nick Clemens <nick at bywatersolutions.com> ---
Issue here is fixed in bug 23382 - either it shoudl eb backported or we should
cherry pick from commit f8e2c489cb668aab9e7484c2dd67c1c05f37b2a5

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 16 18:49:35 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 16 Jan 2020 17:49:35 +0000
Subject: [Koha-bugs] [Bug 23382] Issuing rules failing after bug 20912
In-Reply-To: <bug-23382-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23382-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23382-70-2ctom9Ln8p@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23382

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=24437

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 16 19:14:46 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 16 Jan 2020 18:14:46 +0000
Subject: [Koha-bugs] [Bug 24438] New: index can fail on timeout
Message-ID: <bug-24438-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24438

            Bug ID: 24438
           Summary: index can fail on timeout
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: Searching - Elasticsearch
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: nick at bywatersolutions.com

We have seen occasional timeouts when indexing elasticsearch, these cause the
indexing to stop and fail.

We should handle the response as the code indicates:
102 sub update_index {
103     my ($self, $biblionums, $records) = @_;
104 
105     my $conf = $self->get_elasticsearch_params();
106     my $elasticsearch = $self->get_elasticsearch();
107     my $documents = $self->marc_records_to_documents($records);
108     my @body;
109 
110     for (my $i=0; $i < scalar @$biblionums; $i++) {
111         my $id = $biblionums->[$i];
112         my $document = $documents->[$i];
113         push @body, {
114             index => {
115                 _id => $id
116             }
117         };
118         push @body, $document;
119     }
120     if (@body) {
121         my $response = $elasticsearch->bulk(
122             index => $conf->{index_name},
123             type => 'data', # is just hard coded in Indexer.pm?
124             body => \@body
125         );
126     }
127     # TODO: handle response
128     return 1;
129 }

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 16 19:15:01 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 16 Jan 2020 18:15:01 +0000
Subject: [Koha-bugs] [Bug 24438] index can fail on timeout
In-Reply-To: <bug-24438-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24438-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24438-70-bIumiH6XXf@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24438

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |alex.arnaud at biblibre.com,
                   |                            |ere.maijala at helsinki.fi

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 16 19:40:36 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 16 Jan 2020 18:40:36 +0000
Subject: [Koha-bugs] [Bug 24439] New: Bulkmarcimport.pl Update documentation
 for -match option
Message-ID: <bug-24439-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24439

            Bug ID: 24439
           Summary: Bulkmarcimport.pl Update documentation for -match
                    option
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Documentation
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: carnold at dgiinc.com
        QA Contact: testopia at bugs.koha-community.org

The -match option for bulkmarcimport says:

-match=<FIELD>
FIELD matchindex,fieldtomatch matchpoint to use to deduplicate fieldtomatch can
be either 001 to 999 or field and list of subfields as such 100abcde

This seems to indicate that you put a number in the FIELD parameter, but really
you are putting the "Koha Search Index" text a comma and then the MARC field:

-match=<KohaIndex,FIELD> or -match=Control-number,001

I was only able to figure this out because someone else was confused:

http://koha.1045719.n5.nabble.com/bulkmarcimport-pl-AND-match-fails-when-trying-to-import-bibliographic-records-td5969334.html

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 16 19:51:29 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 16 Jan 2020 18:51:29 +0000
Subject: [Koha-bugs] [Bug 24435] Add Koha::Biblio->items_count
In-Reply-To: <bug-24435-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24435-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24435-70-OdklO1EevF@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24435

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |tomascohen at gmail.com
                   |ity.org                     |
             Blocks|                            |20212


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20212
[Bug 20212] Slowness in Receiving in Acquisitions
-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 16 19:51:29 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 16 Jan 2020 18:51:29 +0000
Subject: [Koha-bugs] [Bug 20212] Slowness in Receiving in Acquisitions
In-Reply-To: <bug-20212-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20212-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20212-70-zW79dOlIOr@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20212

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |24435


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24435
[Bug 24435] Add Koha::Biblio->items_count
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 16 19:52:19 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 16 Jan 2020 18:52:19 +0000
Subject: [Koha-bugs] [Bug 24440] New: Add ->holds and ->holds_count to
 Koha::Acquisition::Order
Message-ID: <bug-24440-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24440

            Bug ID: 24440
           Summary: Add ->holds and ->holds_count to
                    Koha::Acquisition::Order
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Architecture, internals, and plumbing
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: tomascohen at gmail.com
        QA Contact: testopia at bugs.koha-community.org

We need such accessors

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 16 19:52:27 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 16 Jan 2020 18:52:27 +0000
Subject: [Koha-bugs] [Bug 24440] Add ->holds and ->holds_count to
 Koha::Acquisition::Order
In-Reply-To: <bug-24440-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24440-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24440-70-4SEOnrh0dS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24440

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |20212
           Assignee|koha-bugs at lists.koha-commun |tomascohen at gmail.com
                   |ity.org                     |


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20212
[Bug 20212] Slowness in Receiving in Acquisitions
-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 16 19:52:27 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 16 Jan 2020 18:52:27 +0000
Subject: [Koha-bugs] [Bug 20212] Slowness in Receiving in Acquisitions
In-Reply-To: <bug-20212-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20212-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20212-70-rozc8zTmsQ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20212

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |24440


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24440
[Bug 24440] Add ->holds and ->holds_count to Koha::Acquisition::Order
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 16 19:57:50 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 16 Jan 2020 18:57:50 +0000
Subject: [Koha-bugs] [Bug 24440] Add ->holds and ->holds_count to
 Koha::Acquisition::Order
In-Reply-To: <bug-24440-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24440-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24440-70-pyECQUDYH8@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24440

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |kyle at bywatersolutions.com,
                   |                            |liz at bywatersolutions.com,
                   |                            |martin.renvoize at ptfs-europe
                   |                            |.com,
                   |                            |nick at bywatersolutions.com
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 16 20:01:39 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 16 Jan 2020 19:01:39 +0000
Subject: [Koha-bugs] [Bug 24440] Add ->holds and ->holds_count to
 Koha::Acquisition::Order
In-Reply-To: <bug-24440-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24440-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24440-70-luR6onahh6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24440

--- Comment #1 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 97467
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97467&action=edit
Bug 24440: Unit tests

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 16 20:01:43 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 16 Jan 2020 19:01:43 +0000
Subject: [Koha-bugs] [Bug 24440] Add ->holds and ->holds_count to
 Koha::Acquisition::Order
In-Reply-To: <bug-24440-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24440-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24440-70-cQxEeZWjkM@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24440

--- Comment #2 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 97468
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97468&action=edit
Bug 24440: Add ->holds and ->holds_count to Koha::Acquisition::Order

This patch introduces a method to fetch the holds associated with the
items associated to an order line. It also adds a method to get that
holds count, which will be handy on the API for embedding such
information on request.

To test:
1. Apply this patches
2. Run:
   $ kshell
  k$ prove t/db_dependent/Koha/Acquisition/Order.t
=> SUCCESS: Tests pass!
3. Sign off :-D

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 16 20:02:28 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 16 Jan 2020 19:02:28 +0000
Subject: [Koha-bugs] [Bug 24440] Add ->holds and ->holds_count to
 Koha::Acquisition::Order
In-Reply-To: <bug-24440-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24440-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24440-70-JiP1gYD7I3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24440

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |agustinmoyano at theke.io

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 16 20:03:25 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 16 Jan 2020 19:03:25 +0000
Subject: [Koha-bugs] [Bug 24435] Add Koha::Biblio->items_count
In-Reply-To: <bug-24435-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24435-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24435-70-BWD78bRzUg@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24435

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |agustinmoyano at theke.io,
                   |                            |kyle at bywatersolutions.com,
                   |                            |liz at bywatersolutions.com,
                   |                            |martin.renvoize at ptfs-europe
                   |                            |.com,
                   |                            |nick at bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 16 20:03:32 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 16 Jan 2020 19:03:32 +0000
Subject: [Koha-bugs] [Bug 24435] Add Koha::Biblio->items_count
In-Reply-To: <bug-24435-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24435-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24435-70-bFebnmDyWx@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24435

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 16 20:10:04 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 16 Jan 2020 19:10:04 +0000
Subject: [Koha-bugs] [Bug 24441] New: Error when checking in an item with
 BranchTansferLimitsType set to itemtype
Message-ID: <bug-24441-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24441

            Bug ID: 24441
           Summary: Error when checking in an item with
                    BranchTansferLimitsType set to itemtype
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: major
          Priority: P5 - low
         Component: Circulation
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: kyle at bywatersolutions.com
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com

It appears that the transition to using Koha::Item in AddReturn has introduced
a bug. Previously $item was a hashref with the key 'itemtype', now that it's an
object, it has no itemtype method and so triggers an error with the message
"The method Koha::Item->itemtype is not covered by tests!".

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 16 20:11:57 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 16 Jan 2020 19:11:57 +0000
Subject: [Koha-bugs] [Bug 24441] Error when checking in an item with
 BranchTansferLimitsType set to itemtype
In-Reply-To: <bug-24441-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24441-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24441-70-rqDy1rgkUd@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24441

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff
   Patch complexity|---                         |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 16 20:11:59 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 16 Jan 2020 19:11:59 +0000
Subject: [Koha-bugs] [Bug 24441] Error when checking in an item with
 BranchTansferLimitsType set to itemtype
In-Reply-To: <bug-24441-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24441-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24441-70-iQLnoHChQg@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24441

--- Comment #1 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 97469
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97469&action=edit
Bug 24441: Error when checking in an item with BranchTansferLimitsType set to
itemtype

It appears that the transition to using Koha::Item in AddReturn has introduced
a bug. Previously $item was a hashref with the key 'itemtype', now that it's an
object, it has no itemtype method and so triggers an error with the message
"The method Koha::Item->itemtype is not covered by tests!".

Test Plan:
1) Enable Branch Transfer Limits via itemtype
2) Check in an item
3) Note the error
4) Apply this patch
5) Restart all the things!
6) Check in an item
7) No error!

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 16 20:12:07 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 16 Jan 2020 19:12:07 +0000
Subject: [Koha-bugs] [Bug 24441] Error when checking in an item with
 BranchTansferLimitsType set to itemtype
In-Reply-To: <bug-24441-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24441-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24441-70-2Wx5Sez8ML@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24441

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |kyle at bywatersolutions.com
                   |ity.org                     |

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 16 20:12:14 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 16 Jan 2020 19:12:14 +0000
Subject: [Koha-bugs] [Bug 24441] Error when checking in an item with
 BranchTansferLimitsType set to itemtype
In-Reply-To: <bug-24441-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24441-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24441-70-HMnnzz3LYy@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24441

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |kyle at bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 16 21:58:58 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 16 Jan 2020 20:58:58 +0000
Subject: [Koha-bugs] [Bug 24161] Late orders improvements - keeping track of
 claims
In-Reply-To: <bug-24161-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24161-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24161-70-kWUh340swR@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24161

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Patch doesn't apply         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 16 21:59:02 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 16 Jan 2020 20:59:02 +0000
Subject: [Koha-bugs] [Bug 24161] Late orders improvements - keeping track of
 claims
In-Reply-To: <bug-24161-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24161-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24161-70-Re6U2xXSFS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24161

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #97117|0                           |1
        is obsolete|                            |
  Attachment #97118|0                           |1
        is obsolete|                            |
  Attachment #97119|0                           |1
        is obsolete|                            |

--- Comment #8 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 97470
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97470&action=edit
Bug 24161: Keep tracks of late orders claims

So far we only record the number of claims and the date of the last
claim, in the aqorders table.
To keep track of the different claim dates, this patchset is going to
make the following DB changes:
  * Create a new table 'aqorders_claims' (id, ordernumber, claimed_on)
  * Remove the two columns from the aqorders table: claims_count and
  claimed_date

This will allow to display the different claim dates where needed: on
the late orders page, and the basket page.

To avoid additional fetches of Koha::Acquisition::Orders, GetLateOrders
has been moved to Koha::Acquisition::Orders->filter_by_late
That way we are going to add consistency, robustness, and cover the
feature with new tests.

Test plan:
0/ Create a bunch of new orders. Make sure they are from different
vendor (with different delivery time).
1/ Go to the late orders page and claim some orders
2/ Reclaim some of those orders
3/ Confirm that you can see the different claim dates for a given orders
(the history of the late orders claims is kept and displayed)

4/ Bonus point: Regression tests:

a. Modify the closedate of the basket in the database. That
will allow you to make sure the patch set did not introduce regressions.
It would be good to test the different filters on the late orders page:
 * delay
 * Estimated delivery date from/to
 * Vendor

b. Confirm that the subtotal and the total values from the late orders
page is correct.

c. Test the update database entry: do not apply these patches, claims
some orders against master. Apply the patch, execute the update DB entry
then confirm that the number of claims is correct (note that the dates
will not as it is not possible to guess them).

QA note: the branchcode parameter has been removed from filter_by_late.
At first glance it seems that it was not used.

Sponsored-by: Cork Institute of Technology

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 16 21:59:06 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 16 Jan 2020 20:59:06 +0000
Subject: [Koha-bugs] [Bug 24161] Late orders improvements - keeping track of
 claims
In-Reply-To: <bug-24161-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24161-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24161-70-W0tf7mpnao@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24161

--- Comment #9 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 97471
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97471&action=edit
Bug 24161: Remove GetLateOrders

Sponsored-by: Cork Institute of Technology

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 16 21:59:09 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 16 Jan 2020 20:59:09 +0000
Subject: [Koha-bugs] [Bug 24161] Late orders improvements - keeping track of
 claims
In-Reply-To: <bug-24161-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24161-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24161-70-CoTwDJXzls@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24161

--- Comment #10 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 97472
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97472&action=edit
Bug 24161: Add tests

Sponsored-by: Cork Institute of Technology

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 16 22:34:04 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 16 Jan 2020 21:34:04 +0000
Subject: [Koha-bugs] [Bug 24395] Floats in cash registers have 6 decimals
In-Reply-To: <bug-24395-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24395-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24395-70-Q6PXMAz1iu@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24395

Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #97432|0                           |1
        is obsolete|                            |

--- Comment #5 from Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com> ---
Created attachment 97473
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97473&action=edit
Bug 24395: Show initial float using the Price TT plugin on summary page

For displaying monetary amounts, we should be using the Price TT
plugin everywhere. This adds it to the cash register summary page.

To test:
- Create a cash register
- Check the cash register table for "Initial float"
- Verify the amount shows with more than 2 decimals
- Edit cash register - verify the same display there
- Apply patch
- Check again - it should display now with only 2 decimals

Signed-off-by: David Nind <david at davidnind.com>
Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 17 00:28:42 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 16 Jan 2020 23:28:42 +0000
Subject: [Koha-bugs] [Bug 15265] Add Instagram and Pinterest to social media
 links
In-Reply-To: <bug-15265-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15265-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15265-70-j3WGtwRD2X@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15265

--- Comment #6 from Owen Leonard <oleonard at myacpl.org> ---
Instagram doesn't have sharing tools as far as I can tell. I'm not sure how
that would even work.

Pinterest is so image-oriented that I'm not sure how useful it would be in
cases where there weren't a cover image

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 17 07:29:42 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 17 Jan 2020 06:29:42 +0000
Subject: [Koha-bugs] [Bug 22220] Error in ReWriteRule for 'bib' in
 apache-shared-intranet.conf
In-Reply-To: <bug-22220-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22220-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22220-70-6ORGLRQ580@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22220

--- Comment #5 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
(In reply to Nick Clemens from comment #4)
> Worked beautifully, once i figured out how to test in a gitified install ;-)
> 
> Hint: Copy the changed line to:
> /etc/koha/apache-shared-intranet-git.conf

Thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 17 08:01:28 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 17 Jan 2020 07:01:28 +0000
Subject: [Koha-bugs] [Bug 24436] Record if a transfer was triggered by a
 'hold'
In-Reply-To: <bug-24436-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24436-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24436-70-xCTuCxyLtU@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24436

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Record if a transfer was    |Record if a transfer was
                   |triggered by a 'reserve'    |triggered by a 'hold'
                 CC|                            |katrin.fischer at bsz-bw.de

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
You are on the CC list for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 17 08:04:08 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 17 Jan 2020 07:04:08 +0000
Subject: [Koha-bugs] [Bug 24395] Floats in cash registers have 6 decimals
In-Reply-To: <bug-24395-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24395-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24395-70-hxZHE3MGn2@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24395

--- Comment #6 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Thx Caroline and David!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 17 08:05:33 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 17 Jan 2020 07:05:33 +0000
Subject: [Koha-bugs] [Bug 24419] Add Koha::Suggestion->suggestor accessor
In-Reply-To: <bug-24419-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24419-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24419-70-n0rjGhcP2Z@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24419

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Failed QA

--- Comment #5 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Martin,
I asked you when I wrote bug 23991 and I think we agreed it was suggester, not
suggestor.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 17 08:12:12 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 17 Jan 2020 07:12:12 +0000
Subject: [Koha-bugs] [Bug 15265] Add Instagram and Pinterest to social media
 links
In-Reply-To: <bug-15265-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15265-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15265-70-8XNQyDba92@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15265

--- Comment #7 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
(In reply to Owen Leonard from comment #6)
> Instagram doesn't have sharing tools as far as I can tell. I'm not sure how
> that would even work.
> 
> Pinterest is so image-oriented that I'm not sure how useful it would be in
> cases where there weren't a cover image

Hm, I wonder if we should close this WONTFIX for now - I am not sure if there
could be a legal problem using the cover images even?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 17 08:17:31 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 17 Jan 2020 07:17:31 +0000
Subject: [Koha-bugs] [Bug 24395] Floats in cash registers have 6 decimals
In-Reply-To: <bug-24395-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24395-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24395-70-4O9jt7xNLB@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24395

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 17 08:17:34 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 17 Jan 2020 07:17:34 +0000
Subject: [Koha-bugs] [Bug 24395] Floats in cash registers have 6 decimals
In-Reply-To: <bug-24395-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24395-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24395-70-MVcplKhYXe@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24395

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #97473|0                           |1
        is obsolete|                            |

--- Comment #7 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 97474
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97474&action=edit
Bug 24395: Show initial float using the Price TT plugin on summary page

For displaying monetary amounts, we should be using the Price TT
plugin everywhere. This adds it to the cash register summary page.

To test:
- Create a cash register
- Check the cash register table for "Initial float"
- Verify the amount shows with more than 2 decimals
- Edit cash register - verify the same display there
- Apply patch
- Check again - it should display now with only 2 decimals

Signed-off-by: David Nind <david at davidnind.com>
Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com>

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 17 08:17:50 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 17 Jan 2020 07:17:50 +0000
Subject: [Koha-bugs] [Bug 24395] Floats in cash registers have 6 decimals
In-Reply-To: <bug-24395-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24395-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24395-70-idaoxoWRul@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24395

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl
                   |y.org                       |
                 CC|                            |m.de.rooy at rijksmuseum.nl

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 17 08:34:15 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 17 Jan 2020 07:34:15 +0000
Subject: [Koha-bugs] [Bug 24442] New: Setup Database fails: Cannot delete or
 update parent row: foreign key constraint fails
Message-ID: <bug-24442-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24442

            Bug ID: 24442
           Summary: Setup Database fails: Cannot delete or update parent
                    row: foreign key constraint fails
 Change sponsored?: ---
           Product: Koha
           Version: 19.11
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Installation and upgrade (web-based installer)
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: seemaalbal at gmail.com
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com

I have the SQL server on Google Cloud which is a remote DB. The setup succeeded
and I got the web installer running. In the web installer, the setup of
database fails. 
On checking the db, there are some 52 tables that are created in the database. 

The setup fails because ISAM engine is disabled. Found that Cloud SQL has
disabled ISAM and only uses InnoDB.

Is there a workaround to setup Koha on Google Cloud?

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 17 08:34:48 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 17 Jan 2020 07:34:48 +0000
Subject: [Koha-bugs] [Bug 24423] Broken link to return to record after batch
 item modification
In-Reply-To: <bug-24423-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24423-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24423-70-7BGJVRaU3v@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24423

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |BLOCKED

--- Comment #7 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Looking here

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 17 08:41:24 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 17 Jan 2020 07:41:24 +0000
Subject: [Koha-bugs] [Bug 24423] Broken link to return to record after batch
 item modification
In-Reply-To: <bug-24423-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24423-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24423-70-338r1VI8Ws@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24423

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Small patch
             Status|BLOCKED                     |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 17 08:41:27 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 17 Jan 2020 07:41:27 +0000
Subject: [Koha-bugs] [Bug 24423] Broken link to return to record after batch
 item modification
In-Reply-To: <bug-24423-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24423-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24423-70-iLgpjZk7mw@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24423

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #97435|0                           |1
        is obsolete|                            |

--- Comment #8 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 97475
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97475&action=edit
Bug 24423: Add biblionumber to modify items link

To test:
- Find/create a bib with at least one item
- From detail.pl, use the checkboxes in the holdings table to select one or
more items
- click the "Modify Selected Items" link just above the holdings table to take
your item(s) to batch modification
- Change something and click save
- Observe that the Return to the Record link points to a url without a
biblionumber: "/cgi-bin/koha/catalogue/detail.pl?biblionumber="
- Apply patch
- Repeat
- The link now works!

Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

Signed-off-by: David Nind <david at davidnind.com>

Bug 24423: Fix for deletion - cleanup accidental debug inclusiopm

To test:
Repeat prior test plan with 'Delete selected'

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 17 08:41:53 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 17 Jan 2020 07:41:53 +0000
Subject: [Koha-bugs] [Bug 24423] Broken link to return to record after batch
 item modification
In-Reply-To: <bug-24423-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24423-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24423-70-gnPOYSv5lm@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24423

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #97437|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 17 08:43:04 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 17 Jan 2020 07:43:04 +0000
Subject: [Koha-bugs] [Bug 24423] Broken link to return to record after batch
 item modification
In-Reply-To: <bug-24423-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24423-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24423-70-Ocr92iyVx8@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24423

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl
                   |y.org                       |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 17 09:02:47 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 17 Jan 2020 08:02:47 +0000
Subject: [Koha-bugs] [Bug 24428] Elastic search index does not contain
 consistent item information
In-Reply-To: <bug-24428-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24428-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24428-70-BrShxR3AF3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24428

--- Comment #2 from Ere Maijala <ere.maijala at helsinki.fi> ---
I don't think you can ever rely on the field order being correct. In
Elasticsearch the documents are JSON objects, and a JSON object is by
definition "an unordered set of name/value pairs".

The way around this would be to either include item information in MARC or
index each item as a subdocument. This should probably be optional.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 17 09:06:18 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 17 Jan 2020 08:06:18 +0000
Subject: [Koha-bugs] [Bug 24018] No need to die "Not logged in"
In-Reply-To: <bug-24018-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24018-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24018-70-K6ICYhdEJM@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24018

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Small patch
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 17 09:06:21 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 17 Jan 2020 08:06:21 +0000
Subject: [Koha-bugs] [Bug 24018] No need to die "Not logged in"
In-Reply-To: <bug-24018-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24018-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24018-70-vMIuARNu7I@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24018

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #97232|0                           |1
        is obsolete|                            |

--- Comment #5 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 97476
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97476&action=edit
Bug 24018: Remove die "Not logged in"

Signed-off-by: Michal Denar <black23 at gmail.com>

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 17 09:06:39 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 17 Jan 2020 08:06:39 +0000
Subject: [Koha-bugs] [Bug 24018] No need to die "Not logged in"
In-Reply-To: <bug-24018-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24018-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24018-70-zBng47K1n2@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24018

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |m.de.rooy at rijksmuseum.nl
         QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl
                   |y.org                       |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 17 09:09:12 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 17 Jan 2020 08:09:12 +0000
Subject: [Koha-bugs] [Bug 24018] No need to die "Not logged in"
In-Reply-To: <bug-24018-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24018-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24018-70-UfCmQSpiLB@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24018

--- Comment #6 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Note: I checked a number of edits to see which call was preceding the find or
die statement. In the very most cases it is a get_template_and_user. In
members/mod_debarment.pl it was a checkauth call. I saw it twice. This should
be fine especially since a flagsrequired is passed too.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 17 09:22:26 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 17 Jan 2020 08:22:26 +0000
Subject: [Koha-bugs] [Bug 16156] Do not ensure the dbh is connected all the
 time
In-Reply-To: <bug-16156-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16156-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16156-70-7C0IGdSu1S@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16156

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |m.de.rooy at rijksmuseum.nl

--- Comment #7 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
As we want to minimize ensure_connected, we probably should not add a connected
test to Koha::Database like bug 20089#c2 suggested?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 17 09:22:55 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 17 Jan 2020 08:22:55 +0000
Subject: [Koha-bugs] [Bug 16156] Do not ensure the dbh is connected all the
 time
In-Reply-To: <bug-16156-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16156-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16156-70-rTBTSl1B6E@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16156

--- Comment #8 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
(In reply to Marcel de Rooy from comment #7)
> As we want to minimize ensure_connected, we probably should not add a
> connected test to Koha::Database like bug 20089#c2 suggested?

c2 => c1

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 17 09:53:21 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 17 Jan 2020 08:53:21 +0000
Subject: [Koha-bugs] [Bug 24345] Fix process of suggesting purchase of
 existing title for non-logged-in users
In-Reply-To: <bug-24345-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24345-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24345-70-H1hrUy9BUi@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24345

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl
                   |y.org                       |
                 CC|                            |m.de.rooy at rijksmuseum.nl
             Status|Signed Off                  |Failed QA

--- Comment #3 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
This change has side effects.
It seems to break viewing other purchase suggestions anonymously (enable
OPACViewOthersSuggestions). Might be possible that we only should add the
op=else parameter in the masthead link, but it needs more checking.

The script is a bit messy in the handling of $op..

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 17 10:19:36 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 17 Jan 2020 09:19:36 +0000
Subject: [Koha-bugs] [Bug 24397] populate_db.pl is out of sync and must be
 removed
In-Reply-To: <bug-24397-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24397-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24397-70-C04QQN7KIh@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24397

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl
                   |y.org                       |
             Status|Signed Off                  |In Discussion
                 CC|                            |katrin.fischer at bsz-bw.de,
                   |                            |m.de.rooy at rijksmuseum.nl,
                   |                            |martin.renvoize at ptfs-europe
                   |                            |.com

--- Comment #3 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Removing it is easy and I understand the argument. But we could discuss if the
statement "koha-misc4dev must be used instead" has full consensus.

How do we make sure that it is in sync and that it meets our coding guidelines
etc? It is easier to grep one git repo than two?

The reason for putting it outside Koha probably relates to the tedious process
of getting things signed off and pushed in Koha mainstream. Somehow we do not
manage as community to get that more smoothly. But I still think we should
address that and not just move code somewhere else.

As an alternative approach, should we copy this script (or even more) at
release time into the codebase? Formulate some procedure to sync them?

Any opinions?
@Katrin: could you include this in the weekly QA mail?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 17 10:22:03 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 17 Jan 2020 09:22:03 +0000
Subject: [Koha-bugs] [Bug 24404] Add missing space on invoices page
In-Reply-To: <bug-24404-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24404-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24404-70-lGqUglHksV@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24404

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 17 10:22:05 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 17 Jan 2020 09:22:05 +0000
Subject: [Koha-bugs] [Bug 24404] Add missing space on invoices page
In-Reply-To: <bug-24404-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24404-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24404-70-47tjoxTodm@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24404

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #97348|0                           |1
        is obsolete|                            |

--- Comment #3 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 97478
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97478&action=edit
Bug 24404: Add missing space on invoices page / remove . from status

On the bottom of the invoices page the summary of adjustments and
shipping shows as:

Adjustments plus shipping:2.00

The patch adds the missing space between text and amount.

To test:
- 'Receive shipment' from a result in your vendor search
- Start a new invoice by entering an invoice number, amount
  for shipping cost and fund.
- Finish receive (you don't need to receive anything)
- You should now be on invoice.pl
- Verify Status is 'Open.' and in 'Invoice details' we
  have the amount with the missing space.
- Apply patch, reload the page.
- Verify the missing space is there and the . is gone.
- Close invoice, no . there either.

Signed-off-by: Owen Leonard <oleonard at myacpl.org>

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 17 10:22:23 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 17 Jan 2020 09:22:23 +0000
Subject: [Koha-bugs] [Bug 24404] Add missing space on invoices page
In-Reply-To: <bug-24404-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24404-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24404-70-hoe0anYzRX@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24404

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |m.de.rooy at rijksmuseum.nl
         QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl
                   |y.org                       |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 17 10:24:38 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 17 Jan 2020 09:24:38 +0000
Subject: [Koha-bugs] [Bug 24443] New: Consider NULL as 0 for issues in items
 search
Message-ID: <bug-24443-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24443

            Bug ID: 24443
           Summary: Consider NULL as 0 for issues in items search
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Searching
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: fridolin.somers at biblibre.com
        QA Contact: testopia at bugs.koha-community.org

In items search, we can filter by items issues count, data coming from
items.issues.
Most of the time, for an item with no issues this column contains NULL.
This enhancement proposes to consider NULL as 0 to allow searching items with
no issues.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 17 10:24:47 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 17 Jan 2020 09:24:47 +0000
Subject: [Koha-bugs] [Bug 24443] Consider NULL as 0 for issues in items
 search
In-Reply-To: <bug-24443-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24443-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24443-70-JZTJqHkaxN@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24443

Fridolin SOMERS <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |fridolin.somers at biblibre.co
                   |ity.org                     |m
             Status|NEW                         |ASSIGNED

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 17 10:29:31 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 17 Jan 2020 09:29:31 +0000
Subject: [Koha-bugs] [Bug 18433] Allow to select results to export in item
 search
In-Reply-To: <bug-18433-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18433-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18433-70-5GyMLKm9Rq@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18433

--- Comment #34 from Julian Maurice <julian.maurice at biblibre.com> ---
Created attachment 97479
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97479&action=edit
Bug 18433: Remember item search results selected rows in session storage

Session storage is not shared between browser tabs, and is cleared when
a tab is closed, so it seems like a good fit for storing selected rows

Test plan:
1. Go to item search (intranet) and submit the form
2. Select some rows on the first page by clicking on checkboxes
3. Go to another page of results
4. Select more rows
5. Go back to the first page
6. Selected rows should still be checked
7. Play with sorting and filtering, and see that selected rows are
   always checked
8. Export as CSV and as a barcodes file, verify that the export contains
   all selected rows
9. Click on 'Clear selection', it should deselect all rows from all
   pages
10. Select some rows again
11. Click on 'Edit search' and submit the same search
12. No row should be selected
13. Select some rows again
14. Refresh the page and submit again the same search
15. No row should be selected

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 17 10:30:24 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 17 Jan 2020 09:30:24 +0000
Subject: [Koha-bugs] [Bug 18433] Allow to select results to export in item
 search
In-Reply-To: <bug-18433-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18433-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18433-70-gxlTXIcRGL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18433

Julian Maurice <julian.maurice at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 17 10:30:57 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 17 Jan 2020 09:30:57 +0000
Subject: [Koha-bugs] [Bug 24443] Consider NULL as 0 for issues in items
 search
In-Reply-To: <bug-24443-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24443-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24443-70-EqR829h9s9@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24443

Fridolin SOMERS <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff
   Patch complexity|---                         |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 17 10:31:00 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 17 Jan 2020 09:31:00 +0000
Subject: [Koha-bugs] [Bug 24443] Consider NULL as 0 for issues in items
 search
In-Reply-To: <bug-24443-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24443-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24443-70-OZKtZJlCZG@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24443

--- Comment #1 from Fridolin SOMERS <fridolin.somers at biblibre.com> ---
Created attachment 97480
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97480&action=edit
Bug 24443: Consider NULL as 0 for issues in items search

In items search, we can filter by items issues count, data coming from
items.issues.
Most of the time, for an item with no issues this column contains NULL.
This enhancement proposes to consider NULL as 0 to allow searching items with
no issues.

Test plan:
1) Use SQL to count items with items.issues = NULL :
   select count(*) from items where issues is null;
2) Go to items search
3) Perform search with filter "Checkout count" = 0
4) Check you get the same number of results as SQL query

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 17 10:31:51 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 17 Jan 2020 09:31:51 +0000
Subject: [Koha-bugs] [Bug 18433] Allow to select results to export in item
 search
In-Reply-To: <bug-18433-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18433-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18433-70-qajnMbaFSd@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18433

--- Comment #35 from Julian Maurice <julian.maurice at biblibre.com> ---
(In reply to Jonathan Druart from comment #33)
> This is still valid.

Not anymore ;)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 17 10:41:56 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 17 Jan 2020 09:41:56 +0000
Subject: [Koha-bugs] [Bug 24444] New: Enfore mutual exclusivity in
 Stockrotation and Rotating Collections
Message-ID: <bug-24444-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24444

            Bug ID: 24444
           Summary: Enfore mutual exclusivity in Stockrotation and
                    Rotating Collections
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Circulation
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: martin.renvoize at ptfs-europe.com
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com

An item should not be able to belong to both a rotating collection and a stock
rotation rota at the same time. We should enforce this by warning and
preventing the end user from taking such action.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 17 10:42:04 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 17 Jan 2020 09:42:04 +0000
Subject: [Koha-bugs] [Bug 24444] Enfore mutual exclusivity in Stockrotation
 and Rotating Collections
In-Reply-To: <bug-24444-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24444-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24444-70-wCKEMeQtWr@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24444

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |martin.renvoize at ptfs-europe
                   |ity.org                     |.com

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 17 10:42:17 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 17 Jan 2020 09:42:17 +0000
Subject: [Koha-bugs] [Bug 24444] Enfore mutual exclusivity in Stockrotation
 and Rotating Collections
In-Reply-To: <bug-24444-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24444-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24444-70-PKDZm24hBm@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24444

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
          Component|Circulation                 |Tools

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 17 10:42:20 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 17 Jan 2020 09:42:20 +0000
Subject: [Koha-bugs] [Bug 24442] Setup Database fails: Cannot delete or
 update parent row: foreign key constraint fails
In-Reply-To: <bug-24442-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24442-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24442-70-RmVMfbk35E@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24442

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |INVALID
                 CC|                            |katrin.fischer at bsz-bw.de

--- Comment #1 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Hi Seema, 

as this is more of an installation issue/setup question, please ask your
question on the mailing list
(https://koha-community.org/support/koha-mailing-lists/) instead - many more
people will be reading you there and be able to help out with their experience.
If it's determined to be a bug, we can reopen this one later. Only bugs and
enhancement requests should be reported on bugzilla.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 17 10:44:19 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 17 Jan 2020 09:44:19 +0000
Subject: [Koha-bugs] [Bug 24428] Elastic search index does not contain
 consistent item information
In-Reply-To: <bug-24428-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24428-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24428-70-fFLvMFQBe7@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24428

--- Comment #3 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
This is a problem we currently have with Zebra, repeated 952 fields are indexed
as without keeping the information separate per item. So you can't search for
something like 'item of itemtype X in library B'. The search will also bring up
all results where one item is in library B and antoher item has itemtype X.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 17 10:44:43 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 17 Jan 2020 09:44:43 +0000
Subject: [Koha-bugs] [Bug 24428] Elastic search index does not contain
 consistent item information
In-Reply-To: <bug-24428-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24428-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24428-70-KQi3kkhO76@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24428

--- Comment #4 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Saying: it would be really great to fix this with Elastic.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 17 10:46:56 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 17 Jan 2020 09:46:56 +0000
Subject: [Koha-bugs] [Bug 23432] Stock rotation: cancelled transfer result
 in stockrotation failures
In-Reply-To: <bug-23432-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23432-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23432-70-xfWjBrERNF@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23432

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |11897


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11897
[Bug 11897] Stock Rotation for Koha
-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 17 10:46:56 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 17 Jan 2020 09:46:56 +0000
Subject: [Koha-bugs] [Bug 11897] Stock Rotation for Koha
In-Reply-To: <bug-11897-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-11897-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11897-70-RWTIOxl4Vo@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11897

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |23432


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23432
[Bug 23432] Stock rotation: cancelled transfer result in stockrotation failures
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 17 10:47:08 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 17 Jan 2020 09:47:08 +0000
Subject: [Koha-bugs] [Bug 24444] Enfore mutual exclusivity in Stockrotation
 and Rotating Collections
In-Reply-To: <bug-24444-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24444-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24444-70-pAIdzLaCQh@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24444

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |11897


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11897
[Bug 11897] Stock Rotation for Koha
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 17 10:47:08 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 17 Jan 2020 09:47:08 +0000
Subject: [Koha-bugs] [Bug 11897] Stock Rotation for Koha
In-Reply-To: <bug-11897-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-11897-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11897-70-QBS6vzGGLy@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11897

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |24444


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24444
[Bug 24444] Enfore mutual exclusivity in Stockrotation and Rotating Collections
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 17 10:49:12 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 17 Jan 2020 09:49:12 +0000
Subject: [Koha-bugs] [Bug 24443] Consider NULL as 0 for issues in items
 search
In-Reply-To: <bug-24443-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24443-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24443-70-8uNyAP2kpy@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24443

--- Comment #2 from Fridolin SOMERS <fridolin.somers at biblibre.com> ---
Created attachment 97481
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97481&action=edit
Bug 24443: Unit test

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 17 10:56:14 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 17 Jan 2020 09:56:14 +0000
Subject: [Koha-bugs] [Bug 24443] Consider NULL as 0 for issues in items
 search
In-Reply-To: <bug-24443-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24443-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24443-70-sj4PJP8xRY@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24443

Fridolin SOMERS <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #97480|0                           |1
        is obsolete|                            |

--- Comment #3 from Fridolin SOMERS <fridolin.somers at biblibre.com> ---
Created attachment 97482
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97482&action=edit
Bug 24443: Consider NULL as 0 for issues in items search

In items search, we can filter by items issues count, data coming from
items.issues.
Most of the time, for an item with no issues this column contains NULL.
This enhancement proposes to consider NULL as 0 to allow searching items with
no issues.

Test plan:
1) Use SQL to count items with items.issues = NULL :
   select count(*) from items where issues is null;
2) Go to items search
3) Perform search with filter "Checkout count" = 0
4) Check you get the same number of results as SQL query

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 17 10:56:24 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 17 Jan 2020 09:56:24 +0000
Subject: [Koha-bugs] [Bug 24443] Consider NULL as 0 for issues in items
 search
In-Reply-To: <bug-24443-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24443-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24443-70-5V0tTB4E7r@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24443

Fridolin SOMERS <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #97481|0                           |1
        is obsolete|                            |

--- Comment #4 from Fridolin SOMERS <fridolin.somers at biblibre.com> ---
Created attachment 97483
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97483&action=edit
Bug 24443: Unit test

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 17 11:03:40 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 17 Jan 2020 10:03:40 +0000
Subject: [Koha-bugs] [Bug 24419] Add Koha::Suggestion->suggestor accessor
In-Reply-To: <bug-24419-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24419-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24419-70-rHRSn7MT4S@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24419

--- Comment #6 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Curse my bad spelling!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 17 11:04:56 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 17 Jan 2020 10:04:56 +0000
Subject: [Koha-bugs] [Bug 19735] Move Perl deps definitions into a cpanfile
In-Reply-To: <bug-19735-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19735-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19735-70-O84DjEdVPV@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19735

Julian Maurice <julian.maurice at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #73837|0                           |1
        is obsolete|                            |

--- Comment #19 from Julian Maurice <julian.maurice at biblibre.com> ---
Created attachment 97484
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97484&action=edit
Bug 19735: Script to generate cpanfile (DO NOT PUSH)

For testing purposes only

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 17 11:05:00 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 17 Jan 2020 10:05:00 +0000
Subject: [Koha-bugs] [Bug 19735] Move Perl deps definitions into a cpanfile
In-Reply-To: <bug-19735-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19735-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19735-70-N0Sd0mVYaw@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19735

Julian Maurice <julian.maurice at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #81612|0                           |1
        is obsolete|                            |

--- Comment #20 from Julian Maurice <julian.maurice at biblibre.com> ---
Created attachment 97485
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97485&action=edit
Bug 19735: Move Perl deps definitions into a cpanfile

cpanfile is a format for describing CPAN dependencies for Perl
applications.
It is more concise - thus easier to read and maintain - than
C4::Installer::PerlDependencies, and allows to describe requirements
more accurately (using version ranges or features for instance)
Additionally it can be read by tools such as cpanm or carton for an
easy way to install dependencies on non-Debian-based systems.

For more information on cpanfile, see
http://search.cpan.org/~miyagawa/Module-CPANfile-1.1002/lib/cpanfile.pod

This patch replace C4::Installer::PerlDependencies by an equivalent
cpanfile and update all scripts/modules that were using PerlDependencies
It also removes dead code from C4::Installer::PerlModules (some
subroutines were not used at all, except in unit tests)

Added dependencies:
 - Module::CPANfile
 - CPAN::Meta (dependency of Module::CPANfile, but we need a more recent
   version than the one Module::CPANfile requires)

Test plan:
  1. Go to About page, tab Perl modules and keep this browser tab open
  2. Apply patch
  3. Install Module::CPANfile and CPAN::Meta
    a. On Debian-based systems:
       # will install libcpan-meta-perl as a dependency
       sudo apt install libmodule-cpanfile-perl
    b. Others:
       # will install CPAN::Meta as a dependency
       sudo cpanm Module::CPANfile
  4. In a new browser tab, go to About page, tab Perl modules and compare
     the table with the one in the previous browser tab
     They should be identical, except for newly added dependencies
     (Module::CPANfile and CPAN::Meta)
  5. Do a 'standard' install
    a. perl Makefile.PL (select 'standard')
    b. make
    c. sudo make install
    d. Configure your database, web server, ... and go through the web
       install process
  6. Verify that the cpanfile got copied into PERL_MODULE_DIR (which
     should be /usr/share/koha/lib)
  7. Go to the about page of this fresh install and compare it with your
     dev install
  8. Verify that debian/list-deps still works
     This takes a lot of time and it may not be necessary to wait until
     the end. If you see some Debian package names that correspond to
     modules in cpanfile, it means it still works
     (you need apt-file for this script to work)
  9. Verify that koha_perl_deps.pl still works
 10. prove t/Installer_pm.t t/Installer_PerlModules.t

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 17 11:05:15 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 17 Jan 2020 10:05:15 +0000
Subject: [Koha-bugs] [Bug 19735] Move Perl deps definitions into a cpanfile
In-Reply-To: <bug-19735-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19735-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19735-70-ld1y62fdLf@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19735

--- Comment #21 from Julian Maurice <julian.maurice at biblibre.com> ---
Patches rebased on master

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 17 11:07:54 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 17 Jan 2020 10:07:54 +0000
Subject: [Koha-bugs] [Bug 24443] Consider NULL as 0 for issues in items
 search
In-Reply-To: <bug-24443-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24443-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24443-70-MFqCsGgJiX@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24443

Fridolin SOMERS <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #97483|0                           |1
        is obsolete|                            |

--- Comment #5 from Fridolin SOMERS <fridolin.somers at biblibre.com> ---
Created attachment 97486
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97486&action=edit
Bug 24443: Unit test

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 17 11:10:06 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 17 Jan 2020 10:10:06 +0000
Subject: [Koha-bugs] [Bug 24443] Consider NULL as 0 for issues in items
 search
In-Reply-To: <bug-24443-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24443-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24443-70-1jtSG2fjJF@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24443

Fridolin SOMERS <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #97486|0                           |1
        is obsolete|                            |

--- Comment #6 from Fridolin SOMERS <fridolin.somers at biblibre.com> ---
Created attachment 97487
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97487&action=edit
Bug 24443: Unit test

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 17 11:13:24 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 17 Jan 2020 10:13:24 +0000
Subject: [Koha-bugs] [Bug 24443] Consider NULL as 0 for issues in items
 search
In-Reply-To: <bug-24443-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24443-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24443-70-WCh9BhejEJ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24443

Fridolin SOMERS <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #97487|0                           |1
        is obsolete|                            |

--- Comment #7 from Fridolin SOMERS <fridolin.somers at biblibre.com> ---
Created attachment 97488
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97488&action=edit
Bug 24443: Unit test

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 17 11:31:09 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 17 Jan 2020 10:31:09 +0000
Subject: [Koha-bugs] [Bug 24435] Add Koha::Biblio->items_count
In-Reply-To: <bug-24435-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24435-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24435-70-IVJzppLnbP@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24435

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 17 11:31:13 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 17 Jan 2020 10:31:13 +0000
Subject: [Koha-bugs] [Bug 24435] Add Koha::Biblio->items_count
In-Reply-To: <bug-24435-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24435-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24435-70-nex3mem79s@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24435

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #97462|0                           |1
        is obsolete|                            |

--- Comment #3 from David Nind <david at davidnind.com> ---
Created attachment 97489
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97489&action=edit
Bug 24435: Unit tests

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

Signed-off-by: David Nind <david at davidnind.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 17 11:31:16 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 17 Jan 2020 10:31:16 +0000
Subject: [Koha-bugs] [Bug 24435] Add Koha::Biblio->items_count
In-Reply-To: <bug-24435-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24435-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24435-70-V7FMn3HiGT@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24435

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #97463|0                           |1
        is obsolete|                            |

--- Comment #4 from David Nind <david at davidnind.com> ---
Created attachment 97490
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97490&action=edit
Bug 24435: Add Koha::Biblio->items_count

This patch introduces a handy shortcut to get the items count for a
biblio. So instead of calling:

  $count = $biblio->items->count;
you can call:
  $count = $biblio->items_count;

The use case for this, is when we want to embed information on objects
to be sent as API responses. In that case, calling ->items->count needs
to be done manually on the controller script, with interesting added
complexity. With this kind of method, we can just require it to be
embedded automagically by calling the following on the API:

   $biblio->to_api({ embed => { items_count => {} } });

If there are several nested layers of objects, doing manually can get
really tricky and error prone.

To test:
1. Apply this patches
2. Run:
   $ kshell
  k$ prove t/db_dependent/Koha/Biblio.t
=> SUCCESS: Tests pass!
3. Sign off :-D

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

Signed-off-by: David Nind <david at davidnind.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 17 11:34:11 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 17 Jan 2020 10:34:11 +0000
Subject: [Koha-bugs] [Bug 24313] XSLT errors should show in the logs
In-Reply-To: <bug-24313-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24313-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24313-70-KP9hnE3Zry@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24313

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=23290

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 17 11:35:40 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 17 Jan 2020 10:35:40 +0000
Subject: [Koha-bugs] [Bug 24440] Add ->holds and ->holds_count to
 Koha::Acquisition::Order
In-Reply-To: <bug-24440-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24440-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24440-70-ZAQLPiZrW1@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24440

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 17 11:35:44 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 17 Jan 2020 10:35:44 +0000
Subject: [Koha-bugs] [Bug 24440] Add ->holds and ->holds_count to
 Koha::Acquisition::Order
In-Reply-To: <bug-24440-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24440-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24440-70-FMqUQmDhHp@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24440

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #97467|0                           |1
        is obsolete|                            |

--- Comment #3 from David Nind <david at davidnind.com> ---
Created attachment 97491
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97491&action=edit
Bug 24440: Unit tests

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

Signed-off-by: David Nind <david at davidnind.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 17 11:35:47 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 17 Jan 2020 10:35:47 +0000
Subject: [Koha-bugs] [Bug 24440] Add ->holds and ->holds_count to
 Koha::Acquisition::Order
In-Reply-To: <bug-24440-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24440-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24440-70-YW27TAnfPH@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24440

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #97468|0                           |1
        is obsolete|                            |

--- Comment #4 from David Nind <david at davidnind.com> ---
Created attachment 97492
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97492&action=edit
Bug 24440: Add ->holds and ->holds_count to Koha::Acquisition::Order

This patch introduces a method to fetch the holds associated with the
items associated to an order line. It also adds a method to get that
holds count, which will be handy on the API for embedding such
information on request.

To test:
1. Apply this patches
2. Run:
   $ kshell
  k$ prove t/db_dependent/Koha/Acquisition/Order.t
=> SUCCESS: Tests pass!
3. Sign off :-D

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

Signed-off-by: David Nind <david at davidnind.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 17 11:46:42 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 17 Jan 2020 10:46:42 +0000
Subject: [Koha-bugs] [Bug 24443] Consider NULL as 0 for issues in items
 search
In-Reply-To: <bug-24443-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24443-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24443-70-dXCtS684xq@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24443

Fridolin SOMERS <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #97488|0                           |1
        is obsolete|                            |

--- Comment #8 from Fridolin SOMERS <fridolin.somers at biblibre.com> ---
Created attachment 97493
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97493&action=edit
Bug 24443: Unit test

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 17 11:48:44 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 17 Jan 2020 10:48:44 +0000
Subject: [Koha-bugs] [Bug 24445] New: Add missing Z3950 updates to
 Makefile.PL
Message-ID: <bug-24445-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24445

            Bug ID: 24445
           Summary: Add missing Z3950 updates to Makefile.PL
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: critical
          Priority: P5 - low
         Component: Installation and upgrade (command-line installer)
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: mtj at kohaaloha.com
        QA Contact: testopia at bugs.koha-community.org

Add missing Z3950 updates to Makefile.PL, so tar file will build ok

this bug was introduced in BZ 13937


to test...
 1/ attempt to build koha tar, observe failure
 2/ apply patch 
 3/ attempt to build koha tar, observe success!

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 17 11:50:55 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 17 Jan 2020 10:50:55 +0000
Subject: [Koha-bugs] [Bug 24445] Add missing Z3950 updates to Makefile.PL
In-Reply-To: <bug-24445-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24445-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24445-70-SOxKxm5tCo@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24445

--- Comment #1 from Mason James <mtj at kohaaloha.com> ---
Created attachment 97494
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97494&action=edit
Bug 13937: add z3950 to makefile

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 17 11:53:54 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 17 Jan 2020 10:53:54 +0000
Subject: [Koha-bugs] [Bug 24445] Add missing Z3950 updates to Makefile.PL
In-Reply-To: <bug-24445-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24445-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24445-70-9dQnnHaj04@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24445

Mason James <mtj at kohaaloha.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #97494|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 17 11:55:45 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 17 Jan 2020 10:55:45 +0000
Subject: [Koha-bugs] [Bug 24445] Add missing Z3950 updates to Makefile.PL
In-Reply-To: <bug-24445-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24445-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24445-70-A59rjYUjbd@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24445

--- Comment #2 from Mason James <mtj at kohaaloha.com> ---
Created attachment 97495
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97495&action=edit
Add missing Z3950 updates to Makefile.PL, so tar file will build ok

this bug was introduced in BZ 13937


to test...
 1/ attempt to build koha tar, observe failure
 2/ apply patch 
 3/ attempt to build koha tar, observe success!

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 17 11:56:09 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 17 Jan 2020 10:56:09 +0000
Subject: [Koha-bugs] [Bug 24445] Add missing Z3950 updates to Makefile.PL
In-Reply-To: <bug-24445-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24445-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24445-70-o00QhDJegl@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24445

Mason James <mtj at kohaaloha.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=13937
         Depends on|                            |13937


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13937
[Bug 13937] Add an Elasticsearch-compatible Z39.50/SRU daemon
-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 17 11:56:09 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 17 Jan 2020 10:56:09 +0000
Subject: [Koha-bugs] [Bug 13937] Add an Elasticsearch-compatible Z39.50/SRU
 daemon
In-Reply-To: <bug-13937-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13937-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13937-70-dBXa6KriVE@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13937

Mason James <mtj at kohaaloha.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |24445
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=24445


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24445
[Bug 24445] Add missing Z3950 updates to Makefile.PL
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 17 11:57:21 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 17 Jan 2020 10:57:21 +0000
Subject: [Koha-bugs] [Bug 24443] Consider NULL as 0 for issues in items
 search
In-Reply-To: <bug-24443-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24443-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24443-70-rhoU0BGgrv@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24443

Fridolin SOMERS <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #97493|0                           |1
        is obsolete|                            |

--- Comment #9 from Fridolin SOMERS <fridolin.somers at biblibre.com> ---
Created attachment 97496
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97496&action=edit
Bug 24443: Unit test

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 17 11:57:35 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 17 Jan 2020 10:57:35 +0000
Subject: [Koha-bugs] [Bug 24445] Add missing Z3950 updates to Makefile.PL
In-Reply-To: <bug-24445-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24445-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24445-70-blQSK71nmC@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24445

Mason James <mtj at kohaaloha.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 17 12:00:47 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 17 Jan 2020 11:00:47 +0000
Subject: [Koha-bugs] [Bug 24445] Add missing Z3950 updates to Makefile.PL
In-Reply-To: <bug-24445-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24445-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24445-70-ur5vD2eZRn@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24445

Mason James <mtj at kohaaloha.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Priority|P5 - low                    |P1 - high

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 17 12:01:14 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 17 Jan 2020 11:01:14 +0000
Subject: [Koha-bugs] [Bug 24445] Add missing Z3950 updates to Makefile.PL
In-Reply-To: <bug-24445-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24445-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24445-70-QdCUISaGBg@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24445

Mason James <mtj at kohaaloha.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |martin.renvoize at ptfs-europe
                   |                            |.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 17 12:05:51 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 17 Jan 2020 11:05:51 +0000
Subject: [Koha-bugs] [Bug 24445] Add missing Z3950 updates to Makefile.PL
In-Reply-To: <bug-24445-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24445-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24445-70-ulKHpB8ief@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24445

Mason James <mtj at kohaaloha.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |joy at bywatersolutions.com

--- Comment #3 from Mason James <mtj at kohaaloha.com> ---
(In reply to Mason James from comment #2)
> Created attachment 97495 [details] [review]
> Add missing Z3950 updates to Makefile.PL, so tar file will build ok
> 
> this bug was introduced in BZ 13937

hi Joy, needs to be backported to 19.11.x branch too :0)

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 17 12:06:05 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 17 Jan 2020 11:06:05 +0000
Subject: [Koha-bugs] [Bug 24443] Consider NULL as 0 for issues in items
 search
In-Reply-To: <bug-24443-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24443-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24443-70-y82x9ajnfb@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24443

Arthur Suzuki <arthur.suzuki at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |arthur.suzuki at biblibre.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 17 12:09:07 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 17 Jan 2020 11:09:07 +0000
Subject: [Koha-bugs] [Bug 24445] Add missing Z3950 updates to Makefile.PL
In-Reply-To: <bug-24445-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24445-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24445-70-nsrveiFGLO@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24445

--- Comment #4 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 97497
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97497&action=edit
Bug 24445: Add z3950 to makefile (bug 13937 follow-up)

Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 17 12:10:04 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 17 Jan 2020 11:10:04 +0000
Subject: [Koha-bugs] [Bug 24445] Add missing Z3950 updates to Makefile.PL
In-Reply-To: <bug-24445-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24445-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24445-70-8lTVTCNQVg@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24445

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #97495|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 17 12:10:10 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 17 Jan 2020 11:10:10 +0000
Subject: [Koha-bugs] [Bug 24445] Add missing Z3950 updates to Makefile.PL
In-Reply-To: <bug-24445-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24445-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24445-70-6dj1K7yvC2@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24445

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 17 12:10:28 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 17 Jan 2020 11:10:28 +0000
Subject: [Koha-bugs] [Bug 24445] Add missing Z3950 updates to Makefile.PL
In-Reply-To: <bug-24445-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24445-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24445-70-qaoqjDQqZ2@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24445

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

--- Comment #5 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Trivial correction, Passing QA.. Thanks Mason

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 17 12:12:41 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 17 Jan 2020 11:12:41 +0000
Subject: [Koha-bugs] [Bug 24445] Add missing Z3950 updates to Makefile.PL
In-Reply-To: <bug-24445-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24445-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24445-70-ZewtZkSE8S@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24445

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to master
         Version(s)|                            |20.05.00
        released in|                            |

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 17 12:12:43 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 17 Jan 2020 11:12:43 +0000
Subject: [Koha-bugs] [Bug 24445] Add missing Z3950 updates to Makefile.PL
In-Reply-To: <bug-24445-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24445-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24445-70-lXMyDnfcVw@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24445

--- Comment #6 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Nice work everyone!

Pushed to master for 20.05

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 17 12:21:41 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 17 Jan 2020 11:21:41 +0000
Subject: [Koha-bugs] [Bug 24436] Record if a transfer was triggered by a
 'hold'
In-Reply-To: <bug-24436-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24436-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24436-70-Cx5kT7rmvc@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24436

--- Comment #1 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 97498
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97498&action=edit
Bug 24436: Add 'Reserve' options to branchtransfers trigger

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
You are on the CC list for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 17 12:21:44 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 17 Jan 2020 11:21:44 +0000
Subject: [Koha-bugs] [Bug 24436] Record if a transfer was triggered by a
 'hold'
In-Reply-To: <bug-24436-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24436-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24436-70-C0aCrd0W2X@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24436

--- Comment #2 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 97499
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97499&action=edit
Bug 24436: Add handling for reserve transfer triggers

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 17 12:22:12 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 17 Jan 2020 11:22:12 +0000
Subject: [Koha-bugs] [Bug 24436] Record if a transfer was triggered by a
 'hold'
In-Reply-To: <bug-24436-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24436-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24436-70-2OnZawB5eQ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24436

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |martin.renvoize at ptfs-europe
                   |ity.org                     |.com

-- 
You are receiving this mail because:
You are watching all bug changes.
You are on the CC list for the bug.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 17 12:22:22 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 17 Jan 2020 11:22:22 +0000
Subject: [Koha-bugs] [Bug 24436] Record if a transfer was triggered by a
 'hold'
In-Reply-To: <bug-24436-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24436-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24436-70-w6AUuFaikH@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24436

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
You are on the CC list for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 17 12:26:46 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 17 Jan 2020 11:26:46 +0000
Subject: [Koha-bugs] [Bug 24297] Record if a transfer was triggered
 'manually'
In-Reply-To: <bug-24297-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24297-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24297-70-cpxA3KGvXN@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24297

--- Comment #1 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 97500
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97500&action=edit
Bug 24297: Record 'Manual' trigger transfers

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 17 12:27:01 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 17 Jan 2020 11:27:01 +0000
Subject: [Koha-bugs] [Bug 24297] Record if a transfer was triggered
 'manually'
In-Reply-To: <bug-24297-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24297-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24297-70-egXAeeWYdl@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24297

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |martin.renvoize at ptfs-europe
                   |ity.org                     |.com
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 17 12:36:55 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 17 Jan 2020 11:36:55 +0000
Subject: [Koha-bugs] [Bug 24287] Transfers should record how they were
 triggered.
In-Reply-To: <bug-24287-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24287-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24287-70-0Z2OWiUbvY@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24287

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #96594|0                           |1
        is obsolete|                            |

--- Comment #2 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 97501
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97501&action=edit
Bug 24287: Add `trigger` to `branchtransfers`

This patch adds the `trigger` field to the `branchtransfers` table to
record what triggered a transfer.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 17 12:37:52 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 17 Jan 2020 11:37:52 +0000
Subject: [Koha-bugs] [Bug 24287] Transfers should record how they were
 triggered.
In-Reply-To: <bug-24287-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24287-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24287-70-NqCdseMvmi@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24287

--- Comment #3 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Test plan:  Apply patch, run updatedatabase. Varify the new 'trigger' field is
added to the database. (Bonus points, check that a fresh install does the same)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 17 12:40:40 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 17 Jan 2020 11:40:40 +0000
Subject: [Koha-bugs] [Bug 24292] Upgrade failed,
 from 19.05 to 19.11 on Ubuntu 19.10: Can't load Unaccent.so
In-Reply-To: <bug-24292-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24292-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24292-70-zD7zJcXmbQ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24292

--- Comment #12 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 97502
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97502&action=edit
Bug 24296: Update existing data in the database

This DB udpate adds the stockration states to the trigger enum in the
branchtransfers table and then populates it with any such data currently
contained within the comments field.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 17 12:40:44 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 17 Jan 2020 11:40:44 +0000
Subject: [Koha-bugs] [Bug 24292] Upgrade failed,
 from 19.05 to 19.11 on Ubuntu 19.10: Can't load Unaccent.so
In-Reply-To: <bug-24292-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24292-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24292-70-fiI1E4BqrU@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24292

--- Comment #13 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 97503
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97503&action=edit
Bug 24296: Update stockrotation process to use branchtransfers.trigger

This patch updates all occurences of stockrotation related lookups of
branchtransfers status from using the 'comments' field to using the new
'trigger' field.

Test plan:
1) Work through the process of creating a stock rotation plan and adding
   items to the plan.. no errors should be encoutered during this process.
2) Run the stockrotation cronjob to move some items on.. no errors
   should be encountered.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 17 12:41:49 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 17 Jan 2020 11:41:49 +0000
Subject: [Koha-bugs] [Bug 24292] Upgrade failed,
 from 19.05 to 19.11 on Ubuntu 19.10: Can't load Unaccent.so
In-Reply-To: <bug-24292-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24292-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24292-70-aWZmbqwoyC@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24292

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #97502|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 17 12:41:56 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 17 Jan 2020 11:41:56 +0000
Subject: [Koha-bugs] [Bug 24292] Upgrade failed,
 from 19.05 to 19.11 on Ubuntu 19.10: Can't load Unaccent.so
In-Reply-To: <bug-24292-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24292-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24292-70-sTFxseEDLd@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24292

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #97503|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 17 12:42:22 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 17 Jan 2020 11:42:22 +0000
Subject: [Koha-bugs] [Bug 24296] Move stock rotation transfer triggers from
 `comments` to `trigger`
In-Reply-To: <bug-24296-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24296-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24296-70-nyPNoCn7Hk@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24296

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #97434|0                           |1
        is obsolete|                            |

--- Comment #3 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 97504
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97504&action=edit
Bug 24296: Update existing data in the database

This DB udpate adds the stockration states to the trigger enum in the
branchtransfers table and then populates it with any such data currently
contained within the comments field.

https://bugs.koha-community.org/show_bug.cgi?id=24292

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 17 12:42:25 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 17 Jan 2020 11:42:25 +0000
Subject: [Koha-bugs] [Bug 24296] Move stock rotation transfer triggers from
 `comments` to `trigger`
In-Reply-To: <bug-24296-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24296-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24296-70-tFv3c1g7M1@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24296

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #97433|0                           |1
        is obsolete|                            |

--- Comment #4 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 97505
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97505&action=edit
Bug 24296: Update stockrotation process to use branchtransfers.trigger

This patch updates all occurences of stockrotation related lookups of
branchtransfers status from using the 'comments' field to using the new
'trigger' field.

Test plan:
1) Work through the process of creating a stock rotation plan and adding
   items to the plan.. no errors should be encoutered during this process.
2) Run the stockrotation cronjob to move some items on.. no errors
   should be encountered.

https://bugs.koha-community.org/show_bug.cgi?id=24292

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 17 12:44:56 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 17 Jan 2020 11:44:56 +0000
Subject: [Koha-bugs] [Bug 24298] Record if a transfer was triggered by
 'return to homebranch'
In-Reply-To: <bug-24298-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24298-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24298-70-TN6qnuoCAa@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24298

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #97450|0                           |1
        is obsolete|                            |

--- Comment #3 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 97506
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97506&action=edit
Bug 24298: Add return enums to branchstransfer triggers

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 17 12:44:59 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 17 Jan 2020 11:44:59 +0000
Subject: [Koha-bugs] [Bug 24298] Record if a transfer was triggered by
 'return to homebranch'
In-Reply-To: <bug-24298-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24298-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24298-70-awovzB3opI@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24298

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #97451|0                           |1
        is obsolete|                            |

--- Comment #4 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 97507
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97507&action=edit
Bug 24298: Record transfer triggers for returns

This patch adds handling to catch transfers that may have been triggered
on item return.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 17 12:47:19 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 17 Jan 2020 11:47:19 +0000
Subject: [Koha-bugs] [Bug 24298] Record if a transfer was triggered by
 'return to homebranch'
In-Reply-To: <bug-24298-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24298-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24298-70-8qCFg7cYwa@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24298

--- Comment #5 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Test Plan:

1) Enable AutoItemReturn and accompanying system preference
2) Return an item to the wrong branch and note the transfer
3) Check the database for the new trigger value

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 17 12:47:23 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 17 Jan 2020 11:47:23 +0000
Subject: [Koha-bugs] [Bug 24298] Record if a transfer was triggered by
 'return to homebranch'
In-Reply-To: <bug-24298-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24298-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24298-70-iIPFuT8GHh@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24298

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 17 12:47:33 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 17 Jan 2020 11:47:33 +0000
Subject: [Koha-bugs] [Bug 24296] Move stock rotation transfer triggers from
 `comments` to `trigger`
In-Reply-To: <bug-24296-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24296-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24296-70-o6sLNj8J2V@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24296

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 17 12:47:42 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 17 Jan 2020 11:47:42 +0000
Subject: [Koha-bugs] [Bug 24287] Transfers should record how they were
 triggered.
In-Reply-To: <bug-24287-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24287-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24287-70-qswCdcs0Ef@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24287

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 17 12:50:20 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 17 Jan 2020 11:50:20 +0000
Subject: [Koha-bugs] [Bug 24299] Record if a transfer was triggered by
 'rotating collections'
In-Reply-To: <bug-24299-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24299-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24299-70-Q677HkRCQZ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24299

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #97464|0                           |1
        is obsolete|                            |

--- Comment #3 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 97508
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97508&action=edit
Bug 24299: Add 'RotatingCollection' branchtransfer trigger

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 17 12:50:23 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 17 Jan 2020 11:50:23 +0000
Subject: [Koha-bugs] [Bug 24299] Record if a transfer was triggered by
 'rotating collections'
In-Reply-To: <bug-24299-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24299-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24299-70-iYFZAXxRim@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24299

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #97465|0                           |1
        is obsolete|                            |

--- Comment #4 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 97509
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97509&action=edit
Bug 24299: Record 'RotatingCollection' as a transfer trigger

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 17 12:50:34 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 17 Jan 2020 11:50:34 +0000
Subject: [Koha-bugs] [Bug 24299] Record if a transfer was triggered by
 'rotating collections'
In-Reply-To: <bug-24299-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24299-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24299-70-ZMU66SNdRC@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24299

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 17 12:52:15 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 17 Jan 2020 11:52:15 +0000
Subject: [Koha-bugs] [Bug 24436] Record if a transfer was triggered by a
 'hold'
In-Reply-To: <bug-24436-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24436-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24436-70-h8yVzhouwA@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24436

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #97498|0                           |1
        is obsolete|                            |

--- Comment #3 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 97510
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97510&action=edit
Bug 24436: Add 'Reserve' options to branchtransfers trigger

-- 
You are receiving this mail because:
You are watching all bug changes.
You are on the CC list for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 17 12:52:18 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 17 Jan 2020 11:52:18 +0000
Subject: [Koha-bugs] [Bug 24436] Record if a transfer was triggered by a
 'hold'
In-Reply-To: <bug-24436-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24436-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24436-70-7391F8tuKq@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24436

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #97499|0                           |1
        is obsolete|                            |

--- Comment #4 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 97511
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97511&action=edit
Bug 24436: Add handling for reserve transfer triggers

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 17 13:03:46 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 17 Jan 2020 12:03:46 +0000
Subject: [Koha-bugs] [Bug 7468] Add label to batch by barcode range
In-Reply-To: <bug-7468-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-7468-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7468-70-ViCqHVjdvS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7468

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |david at davidnind.com
             Status|Needs Signoff               |Patch doesn't apply

--- Comment #41 from David Nind <david at davidnind.com> ---
I can't seem to apply the patches on the latest master (testing using
koha-testing-docker). Here is what I get:

Apply? [(y)es, (n)o, (i)nteractive] y
Applying: Bug 7468 - Print barcodes by range
Applying: Bug 7468 - Fix 'false' message on Firefox
Applying: Bug 7468 - Add warning when range has non-existent barcodes
Applying: Bug 7468 - Showing the error message according to the community
interface patterns, fixing a javascript condition
Applying: Bug 7468 - (follow-up) Make sure only integers are accepted as
from/to values
Applying: Bug 7468: Print barcodes by range
Using index info to reconstruct a base tree...
M       C4/Labels/Label.pm
M       koha-tmpl/intranet-tmpl/prog/en/includes/labels-toolbar.inc
M       koha-tmpl/intranet-tmpl/prog/en/modules/labels/label-print.tt
M       labels/label-create-pdf.pl
M       labels/label-print.pl
Falling back to patching base and 3-way merge...
Auto-merging labels/label-print.pl
CONFLICT (content): Merge conflict in labels/label-print.pl
Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/labels/label-edit-range.tt
CONFLICT (add/add): Merge conflict in
koha-tmpl/intranet-tmpl/prog/en/modules/labels/label-edit-range.tt
error: Failed to merge in the changes.
Patch failed at 0001 Bug 7468: Print barcodes by range
The copy of the patch that failed is found in: .git/rebase-apply/patch
When you have resolved this problem run "git bz apply --continue".
If you would prefer to skip this patch, instead run "git bz apply --skip".
To restore the original branch and stop patching run "git bz apply --abort".
Patch left in /tmp/Bug-7468-Print-barcodes-by-range-ZVR8Tv.patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 17 13:06:28 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 17 Jan 2020 12:06:28 +0000
Subject: [Koha-bugs] [Bug 23092] Transfers should record 'requested' as well
 as 'sent' and 'arrived' dates.
In-Reply-To: <bug-23092-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23092-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23092-70-WQ7NiHmeMP@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23092

--- Comment #1 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 97512
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97512&action=edit
Bug 23092: Add 'daterequested' to branchtransfers table

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 17 13:08:09 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 17 Jan 2020 12:08:09 +0000
Subject: [Koha-bugs] [Bug 23092] Transfers should record 'requested' as well
 as 'sent' and 'arrived' dates.
In-Reply-To: <bug-23092-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23092-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23092-70-btFykgRSmO@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23092

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

--- Comment #2 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
This patch simply adds the field and sets it's to default to current timestamp
on row creation.

As such it does not yet affect any functionality so the test plan is simply to
check the field was created in the database.

Updating transfers to use this functionality will be done in dependant bugs.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 17 13:08:15 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 17 Jan 2020 12:08:15 +0000
Subject: [Koha-bugs] [Bug 23092] Transfers should record 'requested' as well
 as 'sent' and 'arrived' dates.
In-Reply-To: <bug-23092-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23092-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23092-70-HTHFSu85Ef@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23092

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 17 13:08:59 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 17 Jan 2020 12:08:59 +0000
Subject: [Koha-bugs] [Bug 24441] Error when checking in an item with
 BranchTansferLimitsType set to itemtype
In-Reply-To: <bug-24441-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24441-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24441-70-5K6IbOKxep@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24441

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 17 13:09:02 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 17 Jan 2020 12:09:02 +0000
Subject: [Koha-bugs] [Bug 24441] Error when checking in an item with
 BranchTansferLimitsType set to itemtype
In-Reply-To: <bug-24441-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24441-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24441-70-bKe8CpeSEl@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24441

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #97469|0                           |1
        is obsolete|                            |

--- Comment #2 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 97513
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97513&action=edit
Bug 24441: Error when checking in an item with BranchTansferLimitsType set to
itemtype

It appears that the transition to using Koha::Item in AddReturn has introduced
a bug. Previously $item was a hashref with the key 'itemtype', now that it's an
object, it has no itemtype method and so triggers an error with the message
"The method Koha::Item->itemtype is not covered by tests!".

Test Plan:
1) Enable Branch Transfer Limits via itemtype
2) Check in an item
3) Note the error
4) Apply this patch
5) Restart all the things!
6) Check in an item
7) No error!

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

Signed-off-by: Maribeth (Turner) Shafer - Central Kansas Library System CKLS
<mshafer at ckls.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 17 13:12:09 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 17 Jan 2020 12:12:09 +0000
Subject: [Koha-bugs] [Bug 24446] New: Stockrotation: Update to use
 daterequested in branchtransfers
Message-ID: <bug-24446-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24446

            Bug ID: 24446
           Summary: Stockrotation: Update to use daterequested in
                    branchtransfers
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Tools
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: martin.renvoize at ptfs-europe.com
        QA Contact: testopia at bugs.koha-community.org

Bug 23092 adds a daterequested field to the branchtransfers table which better
reflects how stockrotation utilises the existing datesent field.

This patchset will update stockrotation to take advantage of the new field and
in doing so rectify some of the rotation logic.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 17 13:12:15 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 17 Jan 2020 12:12:15 +0000
Subject: [Koha-bugs] [Bug 24446] Stockrotation: Update to use daterequested
 in branchtransfers
In-Reply-To: <bug-24446-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24446-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24446-70-Rf2E3lAgWz@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24446

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |martin.renvoize at ptfs-europe
                   |ity.org                     |.com

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 17 13:12:38 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 17 Jan 2020 12:12:38 +0000
Subject: [Koha-bugs] [Bug 24446] Stockrotation: Update to use daterequested
 in branchtransfers
In-Reply-To: <bug-24446-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24446-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24446-70-Y5Pu2ULXcG@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24446

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |23092, 22566


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22566
[Bug 22566] Stock rotation cronjob reporting has issues
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23092
[Bug 23092] Transfers should record 'requested' as well as  'sent' and
'arrived' dates.
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 17 13:12:38 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 17 Jan 2020 12:12:38 +0000
Subject: [Koha-bugs] [Bug 22566] Stock rotation cronjob reporting has issues
In-Reply-To: <bug-22566-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22566-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22566-70-6hxit9O6JH@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22566

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |24446


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24446
[Bug 24446] Stockrotation: Update to use daterequested in branchtransfers
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 17 13:12:38 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 17 Jan 2020 12:12:38 +0000
Subject: [Koha-bugs] [Bug 23092] Transfers should record 'requested' as well
 as 'sent' and 'arrived' dates.
In-Reply-To: <bug-23092-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23092-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23092-70-MRcGu7F5Lv@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23092

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |24446


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24446
[Bug 24446] Stockrotation: Update to use daterequested in branchtransfers
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 17 13:13:12 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 17 Jan 2020 12:13:12 +0000
Subject: [Koha-bugs] [Bug 24446] Stockrotation: Update to use daterequested
 in branchtransfers
In-Reply-To: <bug-24446-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24446-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24446-70-sZR81s9b02@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24446

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |22569


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22569
[Bug 22569] Stock rotation: 'Transfers to send' report
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 17 13:13:12 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 17 Jan 2020 12:13:12 +0000
Subject: [Koha-bugs] [Bug 22569] Stock rotation: 'Transfers to send' report
In-Reply-To: <bug-22569-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22569-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22569-70-le0GslRPuu@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22569

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |24446


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24446
[Bug 24446] Stockrotation: Update to use daterequested in branchtransfers
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 17 13:13:35 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 17 Jan 2020 12:13:35 +0000
Subject: [Koha-bugs] [Bug 22569] Stock rotation: 'Transfers to send' report
In-Reply-To: <bug-22569-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22569-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22569-70-QMU0fvFvvH@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22569

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|22566                       |


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22566
[Bug 22566] Stock rotation cronjob reporting has issues
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 17 13:13:35 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 17 Jan 2020 12:13:35 +0000
Subject: [Koha-bugs] [Bug 22566] Stock rotation cronjob reporting has issues
In-Reply-To: <bug-22566-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22566-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22566-70-emTWd0yHPR@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22566

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|22569                       |


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22569
[Bug 22569] Stock rotation: 'Transfers to send' report
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 17 13:15:54 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 17 Jan 2020 12:15:54 +0000
Subject: [Koha-bugs] [Bug 24264] Elasticsearch - Cannot search for
 genre/form authorities
In-Reply-To: <bug-24264-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24264-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24264-70-sq5t3IdKtr@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24264

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |rel_19_05_candidate

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 17 13:17:43 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 17 Jan 2020 12:17:43 +0000
Subject: [Koha-bugs] [Bug 24393] Remove event attributes from patron clubs
 list template
In-Reply-To: <bug-24393-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24393-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24393-70-Hf4jg9LlEH@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24393

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 17 13:17:47 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 17 Jan 2020 12:17:47 +0000
Subject: [Koha-bugs] [Bug 24393] Remove event attributes from patron clubs
 list template
In-Reply-To: <bug-24393-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24393-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24393-70-4BkBz1JHPt@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24393

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #97139|0                           |1
        is obsolete|                            |

--- Comment #5 from David Nind <david at davidnind.com> ---
Created attachment 97514
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97514&action=edit
Bug 24393: Remove event attributes from patron clubs list template

This patch removes some instances of the "onclick" attributes from the
template that lists patron clubs and templates.

To test, apply the patch and go to Tools -> Patron clubs.

 - Test the process of deleting a club template. Clicking the "Delete"
   button should trigger a confirmation. Confirming should delete the
   template.

 - Test the process of deleting a club. In the "Clubs" section of the
   page, click the "Actions" menu next to any club. Clicking the
   "Delete" link should trigger a confirmation. Confirming should delete
   the club.

 - Also in the "Clubs" section of the page, find a club which has
   enrollments. Select "Search to hold" from the "Actions" menu. It
   should take you to the advanced search. On the search results page
   you should have the option to place a hold for the club you selected.

Signed-off-by: David Nind <david at davidnind.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 17 13:22:52 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 17 Jan 2020 12:22:52 +0000
Subject: [Koha-bugs] [Bug 24447] New: POD of
 C4::Members::Messaging::GetMessagingPreferences() is misleading
Message-ID: <bug-24447-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24447

            Bug ID: 24447
           Summary: POD of
                    C4::Members::Messaging::GetMessagingPreferences() is
                    misleading
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Keywords: Academy
          Severity: minor
          Priority: P5 - low
         Component: Notices
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: magnus at libriotech.no
        QA Contact: testopia at bugs.koha-community.org

Part of the POD for this subroutine looks like this:

  42   my $preferences = C4::Members::Messaging::GetMessagingPreferences( {
borrowernumber => $borrower->{'borrowernumber'},
  43                                                                       
message_name   => 'DUE' } );
  44 
  45   my $preferences = C4::Members::Messaging::GetMessagingPreferences( {
categorycode => 'LIBRARY',
  46                                                                       
message_name   => 'DUE' } );

It looks like the value for message_name should be a value from letter.code,
but it should be a name from message_attributes.message_name:

  75 AND    message_transports.is_digest =
borrower_message_preferences.wants_digest
  76 WHERE  message_attributes.message_name = ?
  77 END_SQL
  78 
  79     my @bind_params = ( $params->{'message_name'} );

Note: This subroutine is set to be renamed and moved by Bug 18595, but the POD
seems to be untouched there.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 17 13:22:52 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 17 Jan 2020 12:22:52 +0000
Subject: [Koha-bugs] [Bug 18595] Move C4::Members::Messaging to Koha
 namespace
In-Reply-To: <bug-18595-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18595-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18595-70-MBGBCL3c1R@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18595

Magnus Enger <magnus at libriotech.no> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=24447

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 17 13:35:39 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 17 Jan 2020 12:35:39 +0000
Subject: [Koha-bugs] [Bug 17371] Add routes for biblios
In-Reply-To: <bug-17371-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17371-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17371-70-pEA7pQMJNT@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17371

Ere Maijala <ere.maijala at helsinki.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |ere.maijala at helsinki.fi

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 17 14:17:04 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 17 Jan 2020 13:17:04 +0000
Subject: [Koha-bugs] [Bug 7468] Add label to batch by barcode range
In-Reply-To: <bug-7468-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-7468-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7468-70-qqerdBMk6z@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7468

Maryse Simard <maryse.simard at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #81071|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 17 14:17:36 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 17 Jan 2020 13:17:36 +0000
Subject: [Koha-bugs] [Bug 7468] Add label to batch by barcode range
In-Reply-To: <bug-7468-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-7468-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7468-70-pIGJWl90Qr@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7468

Maryse Simard <maryse.simard at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #81072|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 17 14:17:49 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 17 Jan 2020 13:17:49 +0000
Subject: [Koha-bugs] [Bug 7468] Add label to batch by barcode range
In-Reply-To: <bug-7468-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-7468-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7468-70-cEVRwLg5HQ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7468

Maryse Simard <maryse.simard at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #81073|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 17 14:18:01 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 17 Jan 2020 13:18:01 +0000
Subject: [Koha-bugs] [Bug 7468] Add label to batch by barcode range
In-Reply-To: <bug-7468-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-7468-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7468-70-yJGmfPziNM@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7468

Maryse Simard <maryse.simard at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #81074|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 17 14:18:11 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 17 Jan 2020 13:18:11 +0000
Subject: [Koha-bugs] [Bug 7468] Add label to batch by barcode range
In-Reply-To: <bug-7468-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-7468-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7468-70-Kg0Ww3wyV0@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7468

Maryse Simard <maryse.simard at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #81075|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 17 14:20:16 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 17 Jan 2020 13:20:16 +0000
Subject: [Koha-bugs] [Bug 7468] Add label to batch by barcode range
In-Reply-To: <bug-7468-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-7468-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7468-70-D3cg0yahCh@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7468

Maryse Simard <maryse.simard at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Patch doesn't apply         |Needs Signoff

--- Comment #42 from Maryse Simard <maryse.simard at inlibro.com> ---
Sorry! I forgot to obsolete the patches for which I changed the title,
therefore it didn't apply. You can test again now, it should work.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 17 14:23:43 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 17 Jan 2020 13:23:43 +0000
Subject: [Koha-bugs] [Bug 7468] Add label to batch by barcode range
In-Reply-To: <bug-7468-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-7468-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7468-70-MFJwBsI8pu@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7468

Michael Kuhn <mik at adminkuhn.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|mik at adminkuhn.ch            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 17 14:32:09 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 17 Jan 2020 13:32:09 +0000
Subject: [Koha-bugs] [Bug 24419] Add Koha::Suggestion->suggestor accessor
In-Reply-To: <bug-24419-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24419-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24419-70-cD9aZIPN22@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24419

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Needs Signoff
                 CC|                            |tomascohen at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 17 14:32:11 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 17 Jan 2020 13:32:11 +0000
Subject: [Koha-bugs] [Bug 24419] Add Koha::Suggestion->suggestor accessor
In-Reply-To: <bug-24419-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24419-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24419-70-ITAo4SOjhn@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24419

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #97385|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 17 14:32:24 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 17 Jan 2020 13:32:24 +0000
Subject: [Koha-bugs] [Bug 24419] Add Koha::Suggestion->suggestor accessor
In-Reply-To: <bug-24419-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24419-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24419-70-BB8XiPTIAs@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24419

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 17 14:32:38 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 17 Jan 2020 13:32:38 +0000
Subject: [Koha-bugs] [Bug 24419] Add Koha::Suggestion->suggestor accessor
In-Reply-To: <bug-24419-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24419-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24419-70-sHoWHDB90X@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24419

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 17 14:33:00 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 17 Jan 2020 13:33:00 +0000
Subject: [Koha-bugs] [Bug 24419] Add Koha::Suggestion->suggestor accessor
In-Reply-To: <bug-24419-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24419-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24419-70-7JVqiH4k20@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24419

--- Comment #7 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 97515
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97515&action=edit
Bug 24419: Add Koha::Suggestion->suggester accessor

This patch adds a ->suggester accessor to the Koha::Suggestion class. It
will return undef if no suggester, and a Koha::Patron object otherwise.

To test:
1. Apply this patch
2. Run:
   $ kshell
  k$ prove t/db_dependent/Koha/Suggestion.t
=> SUCCESS: Tests pass!
3. Sign off :-D

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 17 14:33:15 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 17 Jan 2020 13:33:15 +0000
Subject: [Koha-bugs] [Bug 24419] Add Koha::Suggestion->suggester accessor
In-Reply-To: <bug-24419-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24419-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24419-70-wVFhvh3w8c@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24419

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Add                         |Add
                   |Koha::Suggestion->suggestor |Koha::Suggestion->suggester
                   |accessor                    |accessor

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 17 14:49:54 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 17 Jan 2020 13:49:54 +0000
Subject: [Koha-bugs] [Bug 23352] Set serial issue default values when
 creating a subscription in serials/subscription-add.pl
In-Reply-To: <bug-23352-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23352-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23352-70-7rM7qWdHPo@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23352

Andreas Jonsson <andreas.jonsson at kreablo.se> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |andreas.jonsson at kreablo.se

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 17 14:51:00 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 17 Jan 2020 13:51:00 +0000
Subject: [Koha-bugs] [Bug 23092] Transfers should record 'requested' as well
 as 'sent' and 'arrived' dates.
In-Reply-To: <bug-23092-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23092-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23092-70-IVqqH2zzh2@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23092

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|22569                       |


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22569
[Bug 22569] Stock rotation: 'Transfers to send' report
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 17 14:51:00 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 17 Jan 2020 13:51:00 +0000
Subject: [Koha-bugs] [Bug 22569] Stock rotation: 'Transfers to send' report
In-Reply-To: <bug-22569-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22569-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22569-70-qYgVs8yK0d@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22569

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|23092                       |


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23092
[Bug 23092] Transfers should record 'requested' as well as  'sent' and
'arrived' dates.
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 17 14:53:14 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 17 Jan 2020 13:53:14 +0000
Subject: [Koha-bugs] [Bug 15219] Server-side processing and pagination on
 checkouts tables
In-Reply-To: <bug-15219-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15219-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15219-70-3LnBueKtrY@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15219

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |In Discussion
                 CC|                            |tomascohen at gmail.com

--- Comment #57 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Julian, take a look here:

https://gitlab.com/thekesolutions/Koha/commits/bug_20212_slowness_acq

we already have an API for checkouts, so you should just use it. I'm submitting
the code for acquisitions soon, and you will be able to reuse the datatables
extension to use the API (native API pagination included).

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 17 14:56:22 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 17 Jan 2020 13:56:22 +0000
Subject: [Koha-bugs] [Bug 24445] Add missing Z3950 updates to Makefile.PL
In-Reply-To: <bug-24445-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24445-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24445-70-MkXcNmlFJf@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24445

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |tomascohen at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 17 14:59:21 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 17 Jan 2020 13:59:21 +0000
Subject: [Koha-bugs] [Bug 24287] Transfers should record how they were
 triggered.
In-Reply-To: <bug-24287-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24287-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24287-70-4rBPBccSVr@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24287

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 17 14:59:24 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 17 Jan 2020 13:59:24 +0000
Subject: [Koha-bugs] [Bug 24287] Transfers should record how they were
 triggered.
In-Reply-To: <bug-24287-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24287-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24287-70-IzaXZktwsz@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24287

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #97501|0                           |1
        is obsolete|                            |

--- Comment #4 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 97516
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97516&action=edit
Bug 24287: Add `trigger` to `branchtransfers`

This patch adds the `trigger` field to the `branchtransfers` table to
record what triggered a transfer.

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 17 15:02:14 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 17 Jan 2020 14:02:14 +0000
Subject: [Koha-bugs] [Bug 24296] Move stock rotation transfer triggers from
 `comments` to `trigger`
In-Reply-To: <bug-24296-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24296-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24296-70-bivGGB5RA5@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24296

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 17 15:02:17 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 17 Jan 2020 14:02:17 +0000
Subject: [Koha-bugs] [Bug 24296] Move stock rotation transfer triggers from
 `comments` to `trigger`
In-Reply-To: <bug-24296-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24296-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24296-70-53dkfUrS8l@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24296

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #97504|0                           |1
        is obsolete|                            |
  Attachment #97505|0                           |1
        is obsolete|                            |

--- Comment #5 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 97517
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97517&action=edit
Bug 24296: Update existing data in the database

This DB udpate adds the stockration states to the trigger enum in the
branchtransfers table and then populates it with any such data currently
contained within the comments field.

https://bugs.koha-community.org/show_bug.cgi?id=24292

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 17 15:02:31 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 17 Jan 2020 14:02:31 +0000
Subject: [Koha-bugs] [Bug 24296] Move stock rotation transfer triggers from
 `comments` to `trigger`
In-Reply-To: <bug-24296-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24296-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24296-70-yI5S6fTLAt@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24296

--- Comment #6 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 97518
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97518&action=edit
Bug 24296: Update stockrotation process to use branchtransfers.trigger

This patch updates all occurences of stockrotation related lookups of
branchtransfers status from using the 'comments' field to using the new
'trigger' field.

Test plan:
1) Work through the process of creating a stock rotation plan and adding
   items to the plan.. no errors should be encoutered during this process.
2) Run the stockrotation cronjob to move some items on.. no errors
   should be encountered.

https://bugs.koha-community.org/show_bug.cgi?id=24292

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 17 15:09:20 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 17 Jan 2020 14:09:20 +0000
Subject: [Koha-bugs] [Bug 15219] Server-side processing and pagination on
 checkouts tables
In-Reply-To: <bug-15219-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15219-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15219-70-pNorTBus3g@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15219

--- Comment #58 from Julian Maurice <julian.maurice at biblibre.com> ---
(In reply to Tomás Cohen Arazi from comment #57)
> Julian, take a look here:
> 
> https://gitlab.com/thekesolutions/Koha/commits/bug_20212_slowness_acq
> 
> we already have an API for checkouts, so you should just use it. I'm
> submitting the code for acquisitions soon, and you will be able to reuse the
> datatables extension to use the API (native API pagination included).

Is the REST API for checkouts also capable of handling datatable filtering (for
bug 15235) ?
What about the grouping of "today's checkouts" vs "previous checkouts" ? I
think that this feature would be complicated to make using the REST API.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 17 15:10:30 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 17 Jan 2020 14:10:30 +0000
Subject: [Koha-bugs] [Bug 7957] Routing lists: manage several routing list
 for each subscription, and export them as CSV
In-Reply-To: <bug-7957-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-7957-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7957-70-ddt8fEegQp@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7957

Julian Maurice <julian.maurice at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #50226|0                           |1
        is obsolete|                            |

--- Comment #83 from Julian Maurice <julian.maurice at biblibre.com> ---
Created attachment 97519
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97519&action=edit
Bug 7957: Routing lists enhancements

- Manage several routing list per subscription
- Export a routing list as CSV

Test plan:

Run the updatedatabase.pl script
Existing routing lists should have been imported in a routing list named
'import'

>From the serials-home.pl page:
  1 Make a search, in the results list you have a column 'Actions' that
    should contain a "New/Edit routing list" link" (if not, consider
    setting RoutingSerials syspref). If the subscription doesn't have a
    routing list, you should have a 'New routing list' link. Otherwise
    you have an 'Edit routing lists (X)' link, where X is the number of
    routing lists.
  2 Choose a subscription which have no routing lists and click on 'New
    routing list'
  3 You are on the routing list creation page. Enter a title for the
    routing list and click on 'Save'.
  4 The routing list has been created and now you are on the routing
    list modification page. The behaviour of this page is quite the same
    as before. A sensible change is that reordering borrowers doesn't
    reload the page each time you make a change.
  5 Click on 'Save' to finish routing list modifications.
  6 Now you are on the routing lists management page. You can edit a
    routing list by clicking on its title, preview it, export it, and
    delete it by clicking on the corresponding link.
  7 Click on 'Preview'.
  8 You will be asked to choose a serial. Pick the one you want to print
    the routing list for and click on 'Continue'.
  9 If RoutingListAddReserves is OFF, the routing list is displayed and
    you just have to click on 'Print'. If the syspref is ON, you will
    have to click on 'Confirm and print', an alert will show telling you
    that holds will be placed on the serial you chose. Click 'OK' and
    you will be able to print the slip. Now check if the holds have been
    placed. (It works only if an item is attached to this serial).
 10 Go back to the routing lists management page (routinglists.pl) and
    click on 'Export'. Download the CSV and check that it contains
    correct data.

>From serials-collection.pl page:
 11 In the serials list, click on 'Print list'.
 12 You will be asked to choose a routing list. Pick one and click on
    'Continue'.
 13 ... (same behaviour as above)

Try to add and delete routing lists to show if links are correctly
updated in serials-home.pl, serials-collection.pl and
subscription-detail.pl

Signed-off-by: Paola Rossi <paola.rossi at cineca.it>
Signed-off-by: Aleisha <aleishaamohia at hotmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 17 15:10:43 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 17 Jan 2020 14:10:43 +0000
Subject: [Koha-bugs] [Bug 7957] Routing lists: manage several routing list
 for each subscription, and export them as CSV
In-Reply-To: <bug-7957-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-7957-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7957-70-U0XnncdBfr@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7957

--- Comment #84 from Julian Maurice <julian.maurice at biblibre.com> ---
Created attachment 97520
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97520&action=edit
Bug 7957: Change name routing list created by updatedb

'import' -> '1'

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 17 15:10:49 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 17 Jan 2020 14:10:49 +0000
Subject: [Koha-bugs] [Bug 7957] Routing lists: manage several routing list
 for each subscription, and export them as CSV
In-Reply-To: <bug-7957-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-7957-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7957-70-HtrmtlweCq@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7957

--- Comment #85 from Julian Maurice <julian.maurice at biblibre.com> ---
Created attachment 97521
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97521&action=edit
Bug 7957: Fix date format in routing-preview-slip.pl

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 17 15:10:58 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 17 Jan 2020 14:10:58 +0000
Subject: [Koha-bugs] [Bug 7957] Routing lists: manage several routing list
 for each subscription, and export them as CSV
In-Reply-To: <bug-7957-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-7957-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7957-70-pG7qz5Y2dg@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7957

--- Comment #86 from Julian Maurice <julian.maurice at biblibre.com> ---
Created attachment 97522
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97522&action=edit
Bug 7957: Do not require 'routing' permission for preview

Anyone one with at least one serials permission should be able to see
the routing list preview

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 17 15:11:04 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 17 Jan 2020 14:11:04 +0000
Subject: [Koha-bugs] [Bug 7957] Routing lists: manage several routing list
 for each subscription, and export them as CSV
In-Reply-To: <bug-7957-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-7957-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7957-70-dLAw6DHWZ0@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7957

--- Comment #87 from Julian Maurice <julian.maurice at biblibre.com> ---
Created attachment 97523
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97523&action=edit
Bug 7957: Skip the routing list selection screen if not necessary

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 17 15:11:12 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 17 Jan 2020 14:11:12 +0000
Subject: [Koha-bugs] [Bug 7957] Routing lists: manage several routing list
 for each subscription, and export them as CSV
In-Reply-To: <bug-7957-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-7957-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7957-70-kMtpFayuep@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7957

--- Comment #88 from Julian Maurice <julian.maurice at biblibre.com> ---
Created attachment 97524
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97524&action=edit
Bug 7957: Reword 'borrowers' to 'patrons'

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 17 15:11:44 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 17 Jan 2020 14:11:44 +0000
Subject: [Koha-bugs] [Bug 7957] Routing lists: manage several routing list
 for each subscription, and export them as CSV
In-Reply-To: <bug-7957-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-7957-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7957-70-cZSqLrFcvB@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7957

Julian Maurice <julian.maurice at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #50227|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 17 15:11:48 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 17 Jan 2020 14:11:48 +0000
Subject: [Koha-bugs] [Bug 7957] Routing lists: manage several routing list
 for each subscription, and export them as CSV
In-Reply-To: <bug-7957-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-7957-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7957-70-uZqVgxNbr5@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7957

Julian Maurice <julian.maurice at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #50228|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 17 15:11:52 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 17 Jan 2020 14:11:52 +0000
Subject: [Koha-bugs] [Bug 7957] Routing lists: manage several routing list
 for each subscription, and export them as CSV
In-Reply-To: <bug-7957-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-7957-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7957-70-twbbug9nfp@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7957

Julian Maurice <julian.maurice at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #50265|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 17 15:11:57 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 17 Jan 2020 14:11:57 +0000
Subject: [Koha-bugs] [Bug 7957] Routing lists: manage several routing list
 for each subscription, and export them as CSV
In-Reply-To: <bug-7957-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-7957-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7957-70-GT31LpUqxk@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7957

Julian Maurice <julian.maurice at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #50266|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 17 15:12:02 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 17 Jan 2020 14:12:02 +0000
Subject: [Koha-bugs] [Bug 7957] Routing lists: manage several routing list
 for each subscription, and export them as CSV
In-Reply-To: <bug-7957-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-7957-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7957-70-VmK1WtKesm@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7957

Julian Maurice <julian.maurice at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #50270|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 17 15:12:07 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 17 Jan 2020 14:12:07 +0000
Subject: [Koha-bugs] [Bug 7957] Routing lists: manage several routing list
 for each subscription, and export them as CSV
In-Reply-To: <bug-7957-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-7957-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7957-70-Ti3UvEy7uM@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7957

Julian Maurice <julian.maurice at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #50273|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 17 15:13:53 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 17 Jan 2020 14:13:53 +0000
Subject: [Koha-bugs] [Bug 7957] Routing lists: manage several routing list
 for each subscription, and export them as CSV
In-Reply-To: <bug-7957-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-7957-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7957-70-j9z8PAJ3pB@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7957

Julian Maurice <julian.maurice at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Needs Signoff

--- Comment #89 from Julian Maurice <julian.maurice at biblibre.com> ---
Rebased/Squashed all patches on master + added small patches for the last QA
comments.
Patches were quite old, so I think this bug should go back to 'Needs signoff'
status.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 17 15:17:18 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 17 Jan 2020 14:17:18 +0000
Subject: [Koha-bugs] [Bug 24448] New: Add Koha::Biblio->subscriptions_count
Message-ID: <bug-24448-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24448

            Bug ID: 24448
           Summary: Add Koha::Biblio->subscriptions_count
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Architecture, internals, and plumbing
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: tomascohen at gmail.com
        QA Contact: testopia at bugs.koha-community.org

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 17 15:25:07 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 17 Jan 2020 14:25:07 +0000
Subject: [Koha-bugs] [Bug 24448] Add Koha::Biblio->subscriptions_count
In-Reply-To: <bug-24448-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24448-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24448-70-ZYXSI5cvkp@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24448

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
           Assignee|koha-bugs at lists.koha-commun |tomascohen at gmail.com
                   |ity.org                     |
             Blocks|                            |20212
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org,
                   |                            |josef.moravec at gmail.com,
                   |                            |kyle at bywatersolutions.com,
                   |                            |liz at bywatersolutions.com,
                   |                            |martin.renvoize at ptfs-europe
                   |                            |.com,
                   |                            |nick at bywatersolutions.com,
                   |                            |tomascohen at gmail.com


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20212
[Bug 20212] Slowness in Receiving in Acquisitions
-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 17 15:25:07 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 17 Jan 2020 14:25:07 +0000
Subject: [Koha-bugs] [Bug 20212] Slowness in Receiving in Acquisitions
In-Reply-To: <bug-20212-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20212-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20212-70-1wyUU8FSY8@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20212

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |24448


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24448
[Bug 24448] Add Koha::Biblio->subscriptions_count
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 17 15:25:25 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 17 Jan 2020 14:25:25 +0000
Subject: [Koha-bugs] [Bug 24448] Add Koha::Biblio->subscriptions_count
In-Reply-To: <bug-24448-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24448-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24448-70-fYwHec0s3E@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24448

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 17 15:25:56 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 17 Jan 2020 14:25:56 +0000
Subject: [Koha-bugs] [Bug 24448] Add Koha::Biblio->subscriptions_count
In-Reply-To: <bug-24448-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24448-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24448-70-O56HyWTV4g@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24448

--- Comment #1 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 97525
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97525&action=edit
Bug 24448: Unit tests

This patch adds tests for the new method to be introduced. It also moves
the tests for Koha::Biblio->subscriptions to the Biblio.t where it
really belongs.

To test, run this tests along with the patch implementing the new
method.

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 17 15:25:59 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 17 Jan 2020 14:25:59 +0000
Subject: [Koha-bugs] [Bug 24448] Add Koha::Biblio->subscriptions_count
In-Reply-To: <bug-24448-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24448-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24448-70-yNINaoZPhY@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24448

--- Comment #2 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 97526
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97526&action=edit
Bug 24448: Add Koha::Biblio->subscriptions_count

This patch adds the handy subscriptions_count method to the Koha::Biblio
class. It is intended to be used as a shortcut for

    $biblio->subscriptions->count

in places like the API where we can embed the output of a method.

To test:
1. Apply this patches
2. Run:
   $ kshell
  k$ prove t/db_dependent/Koha/Biblio.t \
           t/db_dependent/Koha/Biblios.t
=> SUCCESS: Tests pass! i.e. Biblios.t still passes, and the tests for
the new method in Biblio.t pass as well.
3. Sign off :-D

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 17 15:28:56 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 17 Jan 2020 14:28:56 +0000
Subject: [Koha-bugs] [Bug 24448] Add Koha::Biblio->subscriptions_count
In-Reply-To: <bug-24448-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24448-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24448-70-Z7I1UBIdPw@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24448

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |agustinmoyano at theke.io

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 17 15:29:33 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 17 Jan 2020 14:29:33 +0000
Subject: [Koha-bugs] [Bug 24449] New: SIP2 - too_many_overdue flag is not
 implemented
Message-ID: <bug-24449-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24449

            Bug ID: 24449
           Summary: SIP2 - too_many_overdue flag is not implemented
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: SIP2
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: nick at bywatersolutions.com
        QA Contact: testopia at bugs.koha-community.org
                CC: colin.campbell at ptfs-europe.com

While the field is in the SIP patron object, it is never populated.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 17 15:31:42 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 17 Jan 2020 14:31:42 +0000
Subject: [Koha-bugs] [Bug 24432] order_by broken for date columns
In-Reply-To: <bug-24432-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24432-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24432-70-yBD7mjf2wa@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24432

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |joonas.kylmala at helsinki.fi,
                   |                            |josef.moravec at gmail.com,
                   |                            |julian.maurice at biblibre.com
                   |                            |,
                   |                            |kyle at bywatersolutions.com,
                   |                            |martin.renvoize at ptfs-europe
                   |                            |.com

--- Comment #5 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Great catch!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 17 15:35:28 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 17 Jan 2020 14:35:28 +0000
Subject: [Koha-bugs] [Bug 24449] SIP2 - too_many_overdue flag is not
 implemented
In-Reply-To: <bug-24449-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24449-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24449-70-nLvlT1Wfyr@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24449

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 17 15:35:30 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 17 Jan 2020 14:35:30 +0000
Subject: [Koha-bugs] [Bug 24449] SIP2 - too_many_overdue flag is not
 implemented
In-Reply-To: <bug-24449-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24449-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24449-70-u7q3Bhfxm4@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24449

--- Comment #1 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 97527
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97527&action=edit
Bug 24449: Add too_many_overdue to patron status for SIP

To test:
1 - Have sip running and use the cli to get info for a patron
    example: perl misc/sip_cli_emulator.pl  -a localhost -p 6001 -su koha -sp
koha -l CPL -m patron_status_request --patron koha
2 - Checkout an item to the patron, backdated so it is overdue
3 - Set syspref 'OverduesBlockCirc' to anything but "Don't Block"
4 - Get the patron status via SIP, note circ blocked flag is set, but
too_many_overdue is not
5 - Apply patch
6 - Restart all the things
7 - Get the patron status via SIP
8 - Note the too_many_overdue flag is now triggered and there is a message
    example: READ: 24Y     Y       00120200117    142716AEEdna
Acosta|AA23529001000463|BLY|CQN|BV0.25|AFGreetings from Koha.  -- Patron has
overdues -- Patron owes 0.25|AOCPL|

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 17 15:35:59 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 17 Jan 2020 14:35:59 +0000
Subject: [Koha-bugs] [Bug 24450] New: Clarify wording when unable to cancel
 order and delete record
Message-ID: <bug-24450-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24450

            Bug ID: 24450
           Summary: Clarify wording when unable to cancel order and delete
                    record
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: Acquisitions
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: andrew at bywatersolutions.com
        QA Contact: testopia at bugs.koha-community.org

On basket.pl, when looking at an order line for a bib that has been used in
more than one uncanceled order we get the message "Can't cancel order and
delete catalog record
X order(s) left" This message doesn't do a very good job of conveying what's
being counted.

X here is the count of uncanceled orders for this bib, minus 1. In other words,
how many orders other than the one you're currently looking at use this bib. 

I'd suggest changing "X order(s) left" to "Used in X other order(s)."

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 17 15:36:38 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 17 Jan 2020 14:36:38 +0000
Subject: [Koha-bugs] [Bug 24432] order_by broken for date columns
In-Reply-To: <bug-24432-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24432-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24432-70-hSsrcPRg3B@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24432

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 17 15:36:40 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 17 Jan 2020 14:36:40 +0000
Subject: [Koha-bugs] [Bug 24432] order_by broken for date columns
In-Reply-To: <bug-24432-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24432-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24432-70-JUndzQeZxk@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24432

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #97424|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 17 15:36:42 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 17 Jan 2020 14:36:42 +0000
Subject: [Koha-bugs] [Bug 24432] order_by broken for date columns
In-Reply-To: <bug-24432-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24432-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24432-70-Ze69hUnqlz@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24432

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #97425|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 17 15:36:44 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 17 Jan 2020 14:36:44 +0000
Subject: [Koha-bugs] [Bug 24432] order_by broken for date columns
In-Reply-To: <bug-24432-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24432-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24432-70-R45xSSi2o7@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24432

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #97426|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 17 15:37:03 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 17 Jan 2020 14:37:03 +0000
Subject: [Koha-bugs] [Bug 24432] order_by broken for date columns
In-Reply-To: <bug-24432-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24432-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24432-70-XTTiDISTX7@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24432

--- Comment #6 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 97528
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97528&action=edit
Bug 24432: Regresion test

To test:
1. apply this patch
2. prove t/Koha/REST/Plugin/Query.t

Test should fail at this point.

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 17 15:37:07 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 17 Jan 2020 14:37:07 +0000
Subject: [Koha-bugs] [Bug 24432] order_by broken for date columns
In-Reply-To: <bug-24432-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24432-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24432-70-mrbWC8xZjk@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24432

--- Comment #7 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 97529
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97529&action=edit
Bug 24432: add Koha::Objects->from_api_mapping

This patch adds from_api_mapping to Koha::Objects, in order to be able to get
the mapping from a result set.

To test:
1. apply this patch
2. prove t/db_dependent/Koha/Objects.t
3. sign off

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 17 15:37:10 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 17 Jan 2020 14:37:10 +0000
Subject: [Koha-bugs] [Bug 24432] order_by broken for date columns
In-Reply-To: <bug-24432-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24432-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24432-70-2OEPQdFkk3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24432

--- Comment #8 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 97530
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97530&action=edit
Bug 24432: Use from_api_mapping to translate column name in _build_order_atom

Use the mapping instead of building a fake hash only to get the key name.

To test:
1. apply this patch
2. prove t/Koha/REST/Plugin/Query.t
3. sign off

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 17 15:47:03 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 17 Jan 2020 14:47:03 +0000
Subject: [Koha-bugs] [Bug 24264] Elasticsearch - Cannot search for
 genre/form authorities
In-Reply-To: <bug-24264-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24264-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24264-70-9gTyI7bakw@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24264

Lucas Gass <lucas at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to oldstable
         Version(s)|                            |19.05.07
        released in|                            |

--- Comment #8 from Lucas Gass <lucas at bywatersolutions.com> ---
backported to 19.05.x for 19.05.07

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 17 15:47:33 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 17 Jan 2020 14:47:33 +0000
Subject: [Koha-bugs] [Bug 24449] SIP2 - too_many_overdue flag is not
 implemented
In-Reply-To: <bug-24449-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24449-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24449-70-Cn8jtKhTKf@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24449

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |nick at bywatersolutions.com
                   |ity.org                     |

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 17 15:57:03 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 17 Jan 2020 14:57:03 +0000
Subject: [Koha-bugs] [Bug 24451] New: Clarify wording when deleting a bib
 attached to orders
Message-ID: <bug-24451-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24451

            Bug ID: 24451
           Summary: Clarify wording when deleting a bib attached to orders
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: Cataloging
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: andrew at bywatersolutions.com
        QA Contact: testopia at bugs.koha-community.org
                CC: m.de.rooy at rijksmuseum.nl

>From detail.pl, when attempting to delete a bib that is connected to any
uncanceled orders in acquisitions, we receive the message: "Warning: This
record is used in X order(s). Deleting it could cause serious issues on
acquisition module. Are you sure you want to delete this record?"

This message would be more helpful if it distinguished between open and closed
orders. Deleting a bib connected to an open order will cause serious issues.
Deleting a bib connected to closed orders will not.

I see three possible fixes:
- Change the message to specify "This record is used in X open order(s) and Y
closed order(s). Deleting a record used in open orders could cause serious
issues ..."
- Change the message to only appear if the bib is used in orders connected to
an active budget and give a count of only orders connected to an active budget.
- Complete bug 16872 to entirely block the deletion of bibs in open orders,
then remove this warning. If we're not allowing the deletion of bibs from open
orders, then it's not a big deal.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 17 15:59:10 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 17 Jan 2020 14:59:10 +0000
Subject: [Koha-bugs] [Bug 24452] New: Advanced editor - show multiple spaces
 visually
Message-ID: <bug-24452-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24452

            Bug ID: 24452
           Summary: Advanced editor - show multiple spaces visually
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Cataloging
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: carnold at dgiinc.com
        QA Contact: testopia at bugs.koha-community.org
                CC: m.de.rooy at rijksmuseum.nl

Currently end of the line spaces are shown by highlighting them. Catalogers
would like to see where there are duplicate spaces in a line so they can remove
them.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 17 15:59:40 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 17 Jan 2020 14:59:40 +0000
Subject: [Koha-bugs] [Bug 24452] Advanced editor - show multiple spaces
 visually
In-Reply-To: <bug-24452-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24452-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24452-70-nc3E9VgDKI@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24452

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
           Assignee|koha-bugs at lists.koha-commun |oleonard at myacpl.org
                   |ity.org                     |

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 17 16:07:05 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 17 Jan 2020 15:07:05 +0000
Subject: [Koha-bugs] [Bug 24452] Advanced editor - show multiple spaces
 visually
In-Reply-To: <bug-24452-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24452-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24452-70-p0rEfaUZHZ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24452

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff
   Patch complexity|---                         |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 17 16:07:07 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 17 Jan 2020 15:07:07 +0000
Subject: [Koha-bugs] [Bug 24452] Advanced editor - show multiple spaces
 visually
In-Reply-To: <bug-24452-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24452-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24452-70-NdXEfe2cQo@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24452

--- Comment #1 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 97531
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97531&action=edit
Bug 24452: Advanced editor - show multiple spaces visually

This patch updates the JavaScript and CSS for the advanced MARC editor
so that multiple consecutive spaces within a line will be detected and
highlighted.

To test the EnableAdvancedCatalogingEditor system preference should be
enabled. Apply the patch and clear your browser cache if necessary.

 - Go to Cataloging -> Advanced editor.
 - On any text entry line (e.g. 245), enter some words with one, two,
   and more spaces in between them. When there are two or more spaces
   between words the spaces between the words should have a dotted red
   underline.
 - Remove the extra spaces and confirm that the dotted line disappears.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 17 16:39:19 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 17 Jan 2020 15:39:19 +0000
Subject: [Koha-bugs] [Bug 19809] Koha::Objects::find calls do not need to be
 forbidden in list context
In-Reply-To: <bug-19809-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19809-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19809-70-ki0LbrlZpQ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19809

Julian Maurice <julian.maurice at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Signed Off

--- Comment #26 from Julian Maurice <julian.maurice at biblibre.com> ---
Forgot to change the status. Back to "signed off"

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 17 16:44:26 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 17 Jan 2020 15:44:26 +0000
Subject: [Koha-bugs] [Bug 14476] Improving opac-search performances
In-Reply-To: <bug-14476-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14476-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14476-70-K2qliiJIGm@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14476

--- Comment #12 from Julian Maurice <julian.maurice at biblibre.com> ---
Since caching the XSLT result is not desirable, should we close this bug ?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 17 16:59:41 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 17 Jan 2020 15:59:41 +0000
Subject: [Koha-bugs] [Bug 24287] Transfers should record how they were
 triggered.
In-Reply-To: <bug-24287-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24287-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24287-70-xVbOAlgzrO@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24287

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #97516|0                           |1
        is obsolete|                            |

--- Comment #5 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 97532
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97532&action=edit
Bug 24287: Add `trigger` to `branchtransfers`

This patch adds the `trigger` field to the `branchtransfers` table to
record what triggered a transfer.

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 17 17:00:14 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 17 Jan 2020 16:00:14 +0000
Subject: [Koha-bugs] [Bug 24296] Move stock rotation transfer triggers from
 `comments` to `trigger`
In-Reply-To: <bug-24296-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24296-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24296-70-sLutbwTEbC@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24296

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #97517|0                           |1
        is obsolete|                            |

--- Comment #7 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 97533
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97533&action=edit
Bug 24296: Update existing data in the database

This DB udpate adds the stockration states to the trigger enum in the
branchtransfers table and then populates it with any such data currently
contained within the comments field.

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 17 17:00:17 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 17 Jan 2020 16:00:17 +0000
Subject: [Koha-bugs] [Bug 24296] Move stock rotation transfer triggers from
 `comments` to `trigger`
In-Reply-To: <bug-24296-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24296-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24296-70-7BsW51Lukf@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24296

--- Comment #8 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 97534
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97534&action=edit
Bug 24296: Update stockrotation process to use branchtransfers.reason

This patch updates all occurences of stockrotation related lookups of
branchtransfers status from using the 'comments' field to using the new
'reason' field.

Test plan:
1) Work through the process of creating a stock rotation plan and adding
   items to the plan.. no errors should be encoutered during this process.
2) Run the stockrotation cronjob to move some items on.. no errors
   should be encountered.

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 17 17:00:54 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 17 Jan 2020 16:00:54 +0000
Subject: [Koha-bugs] [Bug 24298] Record if a transfer was triggered by
 'return to homebranch'
In-Reply-To: <bug-24298-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24298-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24298-70-sCj1WTtoab@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24298

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #97506|0                           |1
        is obsolete|                            |

--- Comment #6 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 97535
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97535&action=edit
Bug 24298: Add return enums to branchstransfer triggers

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 17 17:00:57 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 17 Jan 2020 16:00:57 +0000
Subject: [Koha-bugs] [Bug 24298] Record if a transfer was triggered by
 'return to homebranch'
In-Reply-To: <bug-24298-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24298-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24298-70-pSUE0MsTcP@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24298

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #97507|0                           |1
        is obsolete|                            |

--- Comment #7 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 97536
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97536&action=edit
Bug 24298: Record transfer triggers for returns

This patch adds handling to catch transfers that may have been triggered
on item return.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 17 17:01:46 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 17 Jan 2020 16:01:46 +0000
Subject: [Koha-bugs] [Bug 24299] Record if a transfer was triggered by
 'rotating collections'
In-Reply-To: <bug-24299-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24299-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24299-70-quaX97fMig@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24299

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #97508|0                           |1
        is obsolete|                            |

--- Comment #5 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 97537
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97537&action=edit
Bug 24299: Add 'RotatingCollection' branchtransfer trigger

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 17 17:01:48 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 17 Jan 2020 16:01:48 +0000
Subject: [Koha-bugs] [Bug 24299] Record if a transfer was triggered by
 'rotating collections'
In-Reply-To: <bug-24299-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24299-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24299-70-P5SbszvUNp@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24299

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #97509|0                           |1
        is obsolete|                            |

--- Comment #6 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 97538
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97538&action=edit
Bug 24299: Record 'RotatingCollection' as a transfer trigger

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 17 17:02:18 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 17 Jan 2020 16:02:18 +0000
Subject: [Koha-bugs] [Bug 24436] Record if a transfer was triggered by a
 'hold'
In-Reply-To: <bug-24436-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24436-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24436-70-3xdPus5MtS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24436

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #97510|0                           |1
        is obsolete|                            |

--- Comment #5 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 97539
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97539&action=edit
Bug 24436: Add 'Reserve' options to branchtransfers trigger

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 17 17:02:21 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 17 Jan 2020 16:02:21 +0000
Subject: [Koha-bugs] [Bug 24436] Record if a transfer was triggered by a
 'hold'
In-Reply-To: <bug-24436-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24436-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24436-70-oMvYrraB9Q@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24436

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #97511|0                           |1
        is obsolete|                            |

--- Comment #6 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 97540
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97540&action=edit
Bug 24436: Add handling for reserve transfer triggers

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 17 17:02:54 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 17 Jan 2020 16:02:54 +0000
Subject: [Koha-bugs] [Bug 24297] Record if a transfer was triggered
 'manually'
In-Reply-To: <bug-24297-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24297-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24297-70-hJMvVzGl7r@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24297

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #97500|0                           |1
        is obsolete|                            |

--- Comment #2 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 97541
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97541&action=edit
Bug 24297: Record 'Manual' trigger transfers

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 17 17:03:23 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 17 Jan 2020 16:03:23 +0000
Subject: [Koha-bugs] [Bug 23092] Transfers should record 'requested' as well
 as 'sent' and 'arrived' dates.
In-Reply-To: <bug-23092-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23092-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23092-70-0rJL3CJnw7@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23092

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #97512|0                           |1
        is obsolete|                            |

--- Comment #3 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 97542
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97542&action=edit
Bug 23092: Add 'daterequested' to branchtransfers table

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 17 17:06:10 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 17 Jan 2020 16:06:10 +0000
Subject: [Koha-bugs] [Bug 24286] FindDuplicateAuthority does not escape
 forward slash in 'GENRE/FORM'
In-Reply-To: <bug-24286-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24286-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24286-70-DJg2DGVMwa@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24286

ByWater Sandboxes <bws.sandboxes at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #96765|0                           |1
        is obsolete|                            |

--- Comment #4 from ByWater Sandboxes <bws.sandboxes at gmail.com> ---
Created attachment 97543
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97543&action=edit
Bug 24286: Escape forward slash in GENRE/FORM (and any authtype)

Note that bug 24267 will fix the issue during Z39 searching for new auth, but
the duplicate check at saving will still fail

To test:
 0 - Set SearchEngine to Elasticsearch,  QueryRegexEscapeOptions  to 'Don't
Escape'
 1 - Browse to Authorities
 2 - Select New->New from Z3950
 3 - Search for subject 'Short stories'
 4 - Auth search explodes
 5 - Apply patch
 6 - Repeat and confirm the search results return
 7 - Import and save the GENRE/FORM record for Short stories
 8 - Repeat the search and import the same record
 9 - Confirm that upon save you are notified of duplicate, don't save
10 - set  QueryRegexEscapeOptions to 'Escape' and confirm Z39 searching works
and importing/save notifies of duplicate
11 - set SearchEngine to Zebra and confirm Z39 searching works and
importing/save notifies of duplicate

Signed-off-by: Kelly McElligott <kelly at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 17 17:06:59 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 17 Jan 2020 16:06:59 +0000
Subject: [Koha-bugs] [Bug 24380] Backdated returns do not update fines
 unless CalculateFinesOnReturn is enabled
In-Reply-To: <bug-24380-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24380-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24380-70-ZnxdNkhM58@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24380

ByWater Sandboxes <bws.sandboxes at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #97055|0                           |1
        is obsolete|                            |

--- Comment #2 from ByWater Sandboxes <bws.sandboxes at gmail.com> ---
Created attachment 97544
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97544&action=edit
Bug 24380 - Backdated returns do not update fines unless CalculateFinesOnReturn
is enabled

In Koha 18.11 backdating a return triggered a recalculation of the fine. This
was removed in bug 14591, and I believe it was in error. The bug report itself
has no justification for the change in behavior.

Test Plan:
1) Disable CalculateFinesOnReturn
2) Backdate an overdue with fines, note the fine does not change
3) Apply this patch
4) Repeat step 2
5) The fine should be updated!

Signed-off-by: Kelly McElligott <kelly at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 17 17:07:19 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 17 Jan 2020 16:07:19 +0000
Subject: [Koha-bugs] [Bug 24286] FindDuplicateAuthority does not escape
 forward slash in 'GENRE/FORM'
In-Reply-To: <bug-24286-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24286-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24286-70-v7r9f8CYUu@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24286

Kelly McElligott <kelly at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off
                 CC|                            |kelly at bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 17 17:07:31 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 17 Jan 2020 16:07:31 +0000
Subject: [Koha-bugs] [Bug 24380] Backdated returns do not update fines
 unless CalculateFinesOnReturn is enabled
In-Reply-To: <bug-24380-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24380-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24380-70-3ZYOYAZu8S@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24380

Kelly McElligott <kelly at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |kelly at bywatersolutions.com
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 17 17:07:59 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 17 Jan 2020 16:07:59 +0000
Subject: [Koha-bugs] [Bug 20212] Slowness in Receiving in Acquisitions
In-Reply-To: <bug-20212-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20212-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20212-70-b4tVYr2zyv@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20212

--- Comment #7 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 97545
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97545&action=edit
Bug 20212: Extend datatables for API interaction

This patch introduces an .api method

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 17 17:08:02 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 17 Jan 2020 16:08:02 +0000
Subject: [Koha-bugs] [Bug 20212] Slowness in Receiving in Acquisitions
In-Reply-To: <bug-20212-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20212-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20212-70-oS8WEuwMSV@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20212

--- Comment #8 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 97546
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97546&action=edit
Bug 20212: Add more embeddable objects to orders

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 17 17:08:06 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 17 Jan 2020 16:08:06 +0000
Subject: [Koha-bugs] [Bug 20212] Slowness in Receiving in Acquisitions
In-Reply-To: <bug-20212-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20212-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20212-70-zUsWHQa4YH@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20212

--- Comment #9 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 97547
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97547&action=edit
[WIP] Bug 20212: Use the API to render orders

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 17 17:09:03 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 17 Jan 2020 16:09:03 +0000
Subject: [Koha-bugs] [Bug 20212] Slowness in Receiving in Acquisitions
In-Reply-To: <bug-20212-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20212-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20212-70-53eASxwZPi@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20212

--- Comment #10 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
I submit an unfinished implementation that renders both the original table, and
the new one (generated through the API). The aim is to get people to review it,
and suggest changes.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 17 17:09:40 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 17 Jan 2020 16:09:40 +0000
Subject: [Koha-bugs] [Bug 23382] Issuing rules failing after bug 20912
In-Reply-To: <bug-23382-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23382-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23382-70-LYgYavUk6T@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23382

Lucas Gass <lucas at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|19.11.00                    |19.11.00, 19.05.07
        released in|                            |
             Status|Pushed to master            |Pushed to stable
                 CC|                            |lucas at bywatersolutions.com

--- Comment #75 from Lucas Gass <lucas at bywatersolutions.com> ---
backported to 19.05.x for 19.05.07

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 17 17:09:56 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 17 Jan 2020 16:09:56 +0000
Subject: [Koha-bugs] [Bug 23382] Issuing rules failing after bug 20912
In-Reply-To: <bug-23382-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23382-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23382-70-4T2b1ilTD8@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23382

Lucas Gass <lucas at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to stable            |Pushed to oldstable

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 17 17:21:54 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 17 Jan 2020 16:21:54 +0000
Subject: [Koha-bugs] [Bug 24430] Remove C4::Biblio::CountBiblioInOrders
In-Reply-To: <bug-24430-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24430-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24430-70-BaaDoInkMc@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24430

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |24418


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24418
[Bug 24418] Add Koha::Biblio->suggestions
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 17 17:21:54 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 17 Jan 2020 16:21:54 +0000
Subject: [Koha-bugs] [Bug 24418] Add Koha::Biblio->suggestions
In-Reply-To: <bug-24418-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24418-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24418-70-5zxb2hMhfP@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24418

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |24430


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24430
[Bug 24430] Remove C4::Biblio::CountBiblioInOrders
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 17 17:22:12 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 17 Jan 2020 16:22:12 +0000
Subject: [Koha-bugs] [Bug 24430] Remove C4::Biblio::CountBiblioInOrders
In-Reply-To: <bug-24430-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24430-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24430-70-jrdlMYAClX@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24430

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |24435


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24435
[Bug 24435] Add Koha::Biblio->items_count
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 17 17:22:12 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 17 Jan 2020 16:22:12 +0000
Subject: [Koha-bugs] [Bug 24435] Add Koha::Biblio->items_count
In-Reply-To: <bug-24435-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24435-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24435-70-ZfLkJx8k7P@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24435

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |24430


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24430
[Bug 24430] Remove C4::Biblio::CountBiblioInOrders
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 17 17:41:45 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 17 Jan 2020 16:41:45 +0000
Subject: [Koha-bugs] [Bug 23767] Spent and Ordered total values don't
 include child funds on acqui-home
In-Reply-To: <bug-23767-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23767-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23767-70-fjpvnnD84I@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23767

Barbara Johnson <barbara.johnson at bedfordtx.gov> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |barbara.johnson at bedfordtx.g
                   |                            |ov

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 17 18:12:03 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 17 Jan 2020 17:12:03 +0000
Subject: [Koha-bugs] [Bug 23282] Show all columns in Batch Item Modification
 and Batch Item Deletion
In-Reply-To: <bug-23282-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23282-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23282-70-Qb249ULTNb@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23282

Andrew Fuerste-Henry <andrew at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |andrew at bywatersolutions.com
             Status|In Discussion               |ASSIGNED

--- Comment #4 from Andrew Fuerste-Henry <andrew at bywatersolutions.com> ---
Removing In Discussion flag as Jonathan opened a new bug for his question.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 17 18:12:38 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 17 Jan 2020 17:12:38 +0000
Subject: [Koha-bugs] [Bug 23282] Show all columns in Batch Item Modification
 and Batch Item Deletion
In-Reply-To: <bug-23282-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23282-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23282-70-XYwkVGv3hN@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23282

Andrew Fuerste-Henry <andrew at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |NEW

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 17 18:12:39 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 17 Jan 2020 17:12:39 +0000
Subject: [Koha-bugs] [Bug 24452] Advanced editor - show multiple spaces
 visually
In-Reply-To: <bug-24452-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24452-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24452-70-0q6cxf2V4G@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24452

ByWater Sandboxes <bws.sandboxes at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #97531|0                           |1
        is obsolete|                            |

--- Comment #2 from ByWater Sandboxes <bws.sandboxes at gmail.com> ---
Created attachment 97548
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97548&action=edit
Bug 24452: Advanced editor - show multiple spaces visually

This patch updates the JavaScript and CSS for the advanced MARC editor
so that multiple consecutive spaces within a line will be detected and
highlighted.

To test the EnableAdvancedCatalogingEditor system preference should be
enabled. Apply the patch and clear your browser cache if necessary.

 - Go to Cataloging -> Advanced editor.
 - On any text entry line (e.g. 245), enter some words with one, two,
   and more spaces in between them. When there are two or more spaces
   between words the spaces between the words should have a dotted red
   underline.
 - Remove the extra spaces and confirm that the dotted line disappears.

Signed-off-by: Cori Lynn Arnold <carnold at dgiinc.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 17 18:13:12 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 17 Jan 2020 17:13:12 +0000
Subject: [Koha-bugs] [Bug 24452] Advanced editor - show multiple spaces
 visually
In-Reply-To: <bug-24452-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24452-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24452-70-91VzTsk0P3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24452

Cori Lynn Arnold <carnold at dgiinc.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

--- Comment #3 from Cori Lynn Arnold <carnold at dgiinc.com> ---
Absolutely fantastic! Thank you!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 17 18:24:38 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 17 Jan 2020 17:24:38 +0000
Subject: [Koha-bugs] [Bug 23618] Make addition SIP2 fields available to self
 service to add cost of items checked out to check out slip
In-Reply-To: <bug-23618-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23618-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23618-70-yqRFTATgiS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23618

--- Comment #2 from Niamh <niamh.walker-headon at it-tallaght.ie> ---
I have seen this done on check out receipts from other systems. 
I am looking for the additional fields to be added that will create the
message. It doesn't have to be the ones that I've mentioned previously, so long
as the outcome is the desired one.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 17 19:09:45 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 17 Jan 2020 18:09:45 +0000
Subject: [Koha-bugs] [Bug 24453] New: Framework configuration,
 silently fails with no "Text for librarian"
Message-ID: <bug-24453-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24453

            Bug ID: 24453
           Summary: Framework configuration, silently fails with no "Text
                    for librarian"
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Cataloging
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: carnold at dgiinc.com
        QA Contact: testopia at bugs.koha-community.org
                CC: m.de.rooy at rijksmuseum.nl

When creating a new subfield for a framework, the subfield will silently not
save if the "Text for librarian" field isn't populated.

Reproduce issue:

1. Go to Administration->MARC bibliographic framework
2. Edit the Default framework by clicking the "Action" button and selecting
"Marc Framework"
3. Search for tag 500
4. Click on the "Action" button and select "Edit subfields"
5. Click on the "New" tab
6. Enter 9 into the subfield code and leave the rest default
7. Hit "Save changes" button

RESULT:
List of all the subfields is shown with no subfield 9

Expected:
List to include subfield 9

Repeating the same processes but adding "Some Text" to the "Text for librarian"
field results in a proper save.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 17 19:10:15 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 17 Jan 2020 18:10:15 +0000
Subject: [Koha-bugs] [Bug 24454] New: currency formatting from JS
Message-ID: <bug-24454-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24454

            Bug ID: 24454
           Summary: currency formatting from JS
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: OPAC
          Assignee: agustinmoyano at theke.io
          Reporter: agustinmoyano at theke.io
        QA Contact: testopia at bugs.koha-community.org
                CC: tomascohen at gmail.com

API calls in OPAC brings raw JSON.

We need a way to format data into the configured currency from JS.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 17 19:10:41 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 17 Jan 2020 18:10:41 +0000
Subject: [Koha-bugs] [Bug 16683] Help links to fields 59X in cataloguing
 form are broken
In-Reply-To: <bug-16683-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16683-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16683-70-GzdEqEYVu6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16683

ByWater Sandboxes <bws.sandboxes at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #95694|0                           |1
        is obsolete|                            |

--- Comment #2 from ByWater Sandboxes <bws.sandboxes at gmail.com> ---
Created attachment 97549
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97549&action=edit
Bug 16683: Help links to fields 59X in cataloguing form are broken

This patch adds more specificity to handling of MARC21 documentation
links in the basic MARC editor.

To test, apply the patch and make sure the "advancedMARCeditor" system
preference is set to "Display."

You may need to edit a bibliographic framework so that 09x, 59x, and 69x
tags will display in the editor.

Edit or create a bibliographic record using that framework. Next to each
tag label in the editor should be a "?" link. Clicking this link should
open a new window with the correct Library of Congress documentation
page.

Check the links for 09x, 59x, and 69x tags as well as others to confirm
they open the correct pages.

Signed-off-by: Cori Lynn Arnold <carnold at dgiinc.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 17 19:11:20 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 17 Jan 2020 18:11:20 +0000
Subject: [Koha-bugs] [Bug 16683] Help links to fields 59X in cataloguing
 form are broken
In-Reply-To: <bug-16683-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16683-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16683-70-bBvLk9Npo7@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16683

Cori Lynn Arnold <carnold at dgiinc.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |carnold at dgiinc.com
             Status|Needs Signoff               |Signed Off

--- Comment #3 from Cori Lynn Arnold <carnold at dgiinc.com> ---
Exactly as described.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 17 19:12:44 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 17 Jan 2020 18:12:44 +0000
Subject: [Koha-bugs] [Bug 24455] New: date formatting from JS
Message-ID: <bug-24455-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24455

            Bug ID: 24455
           Summary: date formatting from JS
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: OPAC
          Assignee: agustinmoyano at theke.io
          Reporter: agustinmoyano at theke.io
        QA Contact: testopia at bugs.koha-community.org
                CC: tomascohen at gmail.com

API calls in OPAC brings raw JSON.

We need a way to format data into the configured date from JS.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 17 19:21:02 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 17 Jan 2020 18:21:02 +0000
Subject: [Koha-bugs] [Bug 24434] C4::Circulation::updateWrongTransfer is
 never called and should be removed
In-Reply-To: <bug-24434-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24434-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24434-70-u0uyyRxtE4@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24434

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 17 19:21:05 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 17 Jan 2020 18:21:05 +0000
Subject: [Koha-bugs] [Bug 24434] C4::Circulation::updateWrongTransfer is
 never called and should be removed
In-Reply-To: <bug-24434-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24434-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24434-70-9APuLhtslt@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24434

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #97449|0                           |1
        is obsolete|                            |

--- Comment #2 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 97550
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97550&action=edit
Bug 24434: Remove updateWrongTransfer

This patch simply removes the unused updateWrongTransfer method from
C4::Circulation.

Test plan: Read code and varify that the method would never actually be
triggered.

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 17 19:56:59 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 17 Jan 2020 18:56:59 +0000
Subject: [Koha-bugs] [Bug 7468] Add label to batch by barcode range
In-Reply-To: <bug-7468-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-7468-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7468-70-XkBbq4DY65@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7468

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 17 19:57:04 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 17 Jan 2020 18:57:04 +0000
Subject: [Koha-bugs] [Bug 7468] Add label to batch by barcode range
In-Reply-To: <bug-7468-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-7468-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7468-70-vilK5Lm5TO@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7468

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #97454|0                           |1
        is obsolete|                            |

--- Comment #43 from David Nind <david at davidnind.com> ---
Created attachment 97551
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97551&action=edit
Bug 7468: Print barcodes by range

Adds an option to the label creator to print a range of barcodes.
Only allows printing to PDF.

C4/Label.pm had to get minor changes to override database-based barcode
generation. Same with labels/label-create-pdf.pl. By default, the
barcode is fetched from the database using the itemnumber, but when
printing ranges, you might not have a corresponding  database entry.

Signed-off-by: David Nind <david at davidnind.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 17 19:57:08 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 17 Jan 2020 18:57:08 +0000
Subject: [Koha-bugs] [Bug 7468] Add label to batch by barcode range
In-Reply-To: <bug-7468-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-7468-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7468-70-sYSMkTSqb2@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7468

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #97455|0                           |1
        is obsolete|                            |

--- Comment #44 from David Nind <david at davidnind.com> ---
Created attachment 97552
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97552&action=edit
Bug 7468: Fix 'false' message on Firefox

It seems I was using an href to a javascript function in the 'Print Range'
button, which Chrome didn't mind, but Firefox did understand.

Signed-off-by: David Nind <david at davidnind.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 17 19:57:13 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 17 Jan 2020 18:57:13 +0000
Subject: [Koha-bugs] [Bug 7468] Add label to batch by barcode range
In-Reply-To: <bug-7468-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-7468-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7468-70-9lsKrXbmJ1@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7468

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #97456|0                           |1
        is obsolete|                            |

--- Comment #45 from David Nind <david at davidnind.com> ---
Created attachment 97553
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97553&action=edit
Bug 7468: Add warning when range has non-existent barcodes

+ Added a warning when the user selects a range with some non-existent
barcodes, and a layout without barcodes.
This allows the user to print barcodes of items not in the database if he so
desires, but will warn him if he tries to print only biblios (which results in
missing entries or a blank page).

Signed-off-by: David Nind <david at davidnind.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 17 19:57:18 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 17 Jan 2020 18:57:18 +0000
Subject: [Koha-bugs] [Bug 7468] Add label to batch by barcode range
In-Reply-To: <bug-7468-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-7468-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7468-70-YAJtCzEXoy@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7468

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #97457|0                           |1
        is obsolete|                            |

--- Comment #46 from David Nind <david at davidnind.com> ---
Created attachment 97554
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97554&action=edit
Bug 7468: Showing the error message according to the community interface
patterns, fixing a javascript condition

TEST PLAN++

1) Apply all the patches
2) Connect to the intranet with an account with permissions to visit the
"Tools" page
3) Go to /cgi-bin/koha/labels/label-home.pl
    . Either by entering the URL directly
    . OR, from the front page, by clicking "Tools", followed by the hyperlink
"Label creator" under the "Catalog" section
4) Under the "+ New" button, a new option should be available: "Barcode range"
5) Fill the "From:" and the "To:" fields of the "Print barcode range" form
    . Keeping both fields at "0" should trigger a warning beside the first
field: "*Cannot be smaller than 1"
    . If the value "From:" is greater the "To:" value, a warning should appear
beside the second field: "*Cannot be smaller than the starting value"
    . Make sure the form doesn't let you enter non-numerical values
    . For a casual test, use "From: 1000" and "To: 1100"
6) After pressing the "Print Range" button, choose a template, a layout, and a
starting position
    . The "DEFAULT TEMPLATE 01" has a page height of 5pt and a page width of
0pt, don't use it
    . All the default layouts should look alike, since we're only printing a
barcode over a number, and not bibliographic information
    . Using a layout not defined as 'Barcode' will show a warning message
7) Clicking the "Export" button should lead to a second dialog window with a
"Download as PDF" hyperlink. Clicking the link should prop up a download dialog
box
8) Save the PDF locally, or simply open it, and make sure the options you used
were taken into account

Signed-off-by: David Nind <david at davidnind.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 17 19:57:25 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 17 Jan 2020 18:57:25 +0000
Subject: [Koha-bugs] [Bug 7468] Add label to batch by barcode range
In-Reply-To: <bug-7468-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-7468-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7468-70-EunpNq8rmZ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7468

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #97458|0                           |1
        is obsolete|                            |

--- Comment #47 from David Nind <david at davidnind.com> ---
Created attachment 97555
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97555&action=edit
Bug 7468: (follow-up) Make sure only integers are accepted as from/to values

Signed-off-by: David Nind <david at davidnind.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 17 19:57:30 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 17 Jan 2020 18:57:30 +0000
Subject: [Koha-bugs] [Bug 7468] Add label to batch by barcode range
In-Reply-To: <bug-7468-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-7468-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7468-70-26wQ29DKcZ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7468

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #97459|0                           |1
        is obsolete|                            |

--- Comment #48 from David Nind <david at davidnind.com> ---
Created attachment 97556
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97556&action=edit
Bug 7468: (follow-up) fix label-edit-range template

Edit the labels/label-edit-range.tt template to follow current
standards :
    - Use footer javascript
    - Use bootstrap grid
    - Use jQuery Validation plugin for validation

Also fixes breadcrumbs to be more specific.

To test:
Make sure the page looks correct and still works as expected.

Signed-off-by: David Nind <david at davidnind.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 17 19:57:35 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 17 Jan 2020 18:57:35 +0000
Subject: [Koha-bugs] [Bug 7468] Add label to batch by barcode range
In-Reply-To: <bug-7468-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-7468-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7468-70-RLXICrykE8@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7468

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #97460|0                           |1
        is obsolete|                            |

--- Comment #49 from David Nind <david at davidnind.com> ---
Created attachment 97557
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97557&action=edit
Bug 7468: (follow-up) Add missing filters

Signed-off-by: David Nind <david at davidnind.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 17 19:57:40 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 17 Jan 2020 18:57:40 +0000
Subject: [Koha-bugs] [Bug 7468] Add label to batch by barcode range
In-Reply-To: <bug-7468-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-7468-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7468-70-9LmD1ByyA2@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7468

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #97461|0                           |1
        is obsolete|                            |

--- Comment #50 from David Nind <david at davidnind.com> ---
Created attachment 97558
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97558&action=edit
Bug 7468: fix the export labels popup header

When exporting a barcode range, the export popup should display "1 batch
to export" instead of "0 batches to export". In this context, it can be
considered a label batch and should be counted as such.

To test:
When clicking the "Print range" button, the popup should show "1 batch
to export".

Signed-off-by: David Nind <david at davidnind.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 17 20:40:18 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 17 Jan 2020 19:40:18 +0000
Subject: [Koha-bugs] [Bug 24429] Advanced editor - Add ability to generate
 an export file as cataloger saves
In-Reply-To: <bug-24429-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24429-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24429-70-RxC1kliCYO@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24429

Cori Lynn Arnold <carnold at dgiinc.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Failed QA

--- Comment #3 from Cori Lynn Arnold <carnold at dgiinc.com> ---
Found a couple issues, pulling this back.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 17 20:53:34 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 17 Jan 2020 19:53:34 +0000
Subject: [Koha-bugs] [Bug 24443] Consider NULL as 0 for issues in items
 search
In-Reply-To: <bug-24443-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24443-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24443-70-8FFgQaLmIf@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24443

Maryse Simard <maryse.simard at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #97482|0                           |1
        is obsolete|                            |

--- Comment #10 from Maryse Simard <maryse.simard at inlibro.com> ---
Created attachment 97559
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97559&action=edit
Bug 24443: Consider NULL as 0 for issues in items search

In items search, we can filter by items issues count, data coming from
items.issues.
Most of the time, for an item with no issues this column contains NULL.
This enhancement proposes to consider NULL as 0 to allow searching items with
no issues.

Test plan:
1) Use SQL to count items with items.issues = NULL :
   select count(*) from items where issues is null;
2) Go to items search
3) Perform search with filter "Checkout count" = 0
4) Check you get the same number of results as SQL query

Signed-off-by: Maryse Simard <maryse.simard at inlibro.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 17 20:53:37 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 17 Jan 2020 19:53:37 +0000
Subject: [Koha-bugs] [Bug 24443] Consider NULL as 0 for issues in items
 search
In-Reply-To: <bug-24443-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24443-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24443-70-8IsNbTsk9A@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24443

Maryse Simard <maryse.simard at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #97496|0                           |1
        is obsolete|                            |

--- Comment #11 from Maryse Simard <maryse.simard at inlibro.com> ---
Created attachment 97560
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97560&action=edit
Bug 24443: Unit test

Signed-off-by: Maryse Simard <maryse.simard at inlibro.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 17 20:53:50 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 17 Jan 2020 19:53:50 +0000
Subject: [Koha-bugs] [Bug 24443] Consider NULL as 0 for issues in items
 search
In-Reply-To: <bug-24443-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24443-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24443-70-uasTiVjez5@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24443

Maryse Simard <maryse.simard at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off
                 CC|                            |maryse.simard at inlibro.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 17 21:11:36 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 17 Jan 2020 20:11:36 +0000
Subject: [Koha-bugs] [Bug 24435] Add Koha::Biblio->items_count
In-Reply-To: <bug-24435-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24435-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24435-70-MfjGJEZMm6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24435

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 17 21:11:39 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 17 Jan 2020 20:11:39 +0000
Subject: [Koha-bugs] [Bug 24435] Add Koha::Biblio->items_count
In-Reply-To: <bug-24435-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24435-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24435-70-rvl2on2ygT@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24435

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #97489|0                           |1
        is obsolete|                            |
  Attachment #97490|0                           |1
        is obsolete|                            |

--- Comment #5 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 97561
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97561&action=edit
Bug 24435: Unit tests

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

Signed-off-by: David Nind <david at davidnind.com>

Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 17 21:11:42 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 17 Jan 2020 20:11:42 +0000
Subject: [Koha-bugs] [Bug 24435] Add Koha::Biblio->items_count
In-Reply-To: <bug-24435-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24435-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24435-70-mUwm6fAIjM@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24435

--- Comment #6 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 97562
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97562&action=edit
Bug 24435: Add Koha::Biblio->items_count

This patch introduces a handy shortcut to get the items count for a
biblio. So instead of calling:

  $count = $biblio->items->count;
you can call:
  $count = $biblio->items_count;

The use case for this, is when we want to embed information on objects
to be sent as API responses. In that case, calling ->items->count needs
to be done manually on the controller script, with interesting added
complexity. With this kind of method, we can just require it to be
embedded automagically by calling the following on the API:

   $biblio->to_api({ embed => { items_count => {} } });

If there are several nested layers of objects, doing manually can get
really tricky and error prone.

To test:
1. Apply this patches
2. Run:
   $ kshell
  k$ prove t/db_dependent/Koha/Biblio.t
=> SUCCESS: Tests pass!
3. Sign off :-D

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

Signed-off-by: David Nind <david at davidnind.com>

Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 17 21:12:17 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 17 Jan 2020 20:12:17 +0000
Subject: [Koha-bugs] [Bug 24430] Remove C4::Biblio::CountBiblioInOrders
In-Reply-To: <bug-24430-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24430-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24430-70-vhSeWLZjwJ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24430

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 17 21:12:20 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 17 Jan 2020 20:12:20 +0000
Subject: [Koha-bugs] [Bug 24430] Remove C4::Biblio::CountBiblioInOrders
In-Reply-To: <bug-24430-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24430-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24430-70-AOHfei8yNC@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24430

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #97446|0                           |1
        is obsolete|                            |
  Attachment #97447|0                           |1
        is obsolete|                            |
  Attachment #97448|0                           |1
        is obsolete|                            |

--- Comment #8 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 97563
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97563&action=edit
Bug 24430: Unit tests

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 17 21:12:22 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 17 Jan 2020 20:12:22 +0000
Subject: [Koha-bugs] [Bug 24430] Remove C4::Biblio::CountBiblioInOrders
In-Reply-To: <bug-24430-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24430-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24430-70-07GCmkIwGX@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24430

--- Comment #9 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 97564
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97564&action=edit
Bug 24430: Add ->orders and ->active_orders_count to Koha::Biblio

This patch introduces an accessor to the related orders, and a method
that returns the active orders count. The target usage for the count is the
API. In the rest of the codebase, we would just call:

    $biblio->orders->count

To test:
1. Apply this patches
2. Run:
   $ kshell
  k$ prove t/db_dependent/Koha/Biblio.t
=> SUCCESS: Tests pass!
3. Sign off :-D

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 17 21:12:25 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 17 Jan 2020 20:12:25 +0000
Subject: [Koha-bugs] [Bug 24430] Remove C4::Biblio::CountBiblioInOrders
In-Reply-To: <bug-24430-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24430-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24430-70-TgyqsXSsDM@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24430

--- Comment #10 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 97565
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97565&action=edit
Bug 24430: Remove CountBiblioInOrders and its traces

This patch replaces the only uses of CountBiblioInOrders and makes that
code use $biblio->orders->count instead.

Test nothing breaks in basket.pl and parcel.pl

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 17 21:18:31 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 17 Jan 2020 20:18:31 +0000
Subject: [Koha-bugs] [Bug 24455] date formatting from JS
In-Reply-To: <bug-24455-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24455-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24455-70-b6ZGzHgLQW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24455

Agustín Moyano <agustinmoyano at theke.io> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |20936


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20936
[Bug 20936] Holds History for patrons in OPAC
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 17 21:18:31 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 17 Jan 2020 20:18:31 +0000
Subject: [Koha-bugs] [Bug 20936] Holds History for patrons in OPAC
In-Reply-To: <bug-20936-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20936-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20936-70-VZX2uZgOwG@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20936

Agustín Moyano <agustinmoyano at theke.io> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |24455


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24455
[Bug 24455] date formatting from JS
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 17 21:18:56 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 17 Jan 2020 20:18:56 +0000
Subject: [Koha-bugs] [Bug 24429] Advanced editor - Add ability to generate
 an export file as cataloger saves
In-Reply-To: <bug-24429-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24429-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24429-70-6fMdYL9XNv@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24429

Cori Lynn Arnold <carnold at dgiinc.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 17 21:18:58 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 17 Jan 2020 20:18:58 +0000
Subject: [Koha-bugs] [Bug 24429] Advanced editor - Add ability to generate
 an export file as cataloger saves
In-Reply-To: <bug-24429-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24429-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24429-70-mhno7Hy2zI@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24429

Cori Lynn Arnold <carnold at dgiinc.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #97404|0                           |1
        is obsolete|                            |

--- Comment #4 from Cori Lynn Arnold <carnold at dgiinc.com> ---
Created attachment 97566
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97566&action=edit
Bug 24429: Advanced editor - Add ability to generate an export file as
cataloger saves

Adds the ability for catalogers to *automatically* save a list of bibs
to export as they
are cataloging.

To test, apply patch:
0/Verify that the advanced editor is enabled by going to
"Administration" and searching for "EnableAdvancedCatalogingEditor"
1/Set it to "Enable" if it isn't already.
2/Go to "Cataloging", click on "Advanced editor"
3/Click on "Export" button (verify a modal window comes up)
4/Click on the link for "New Export File", name the export file
5/Close the modal window
6/Search for a record by entering "specious" in the keyword box and
hitting enter
7/Click "import" on a record
8/Make some changes and hit "Save", note the bib number
9/Repeat steps 6-8 for several records, getting records from the catalog
and importing through the "import" button in the UI
10/Click on "Export..." button
11/Click on the link for the name you created in step 4
12/Verify the bib numbers from step 8 are in the Export Files Editor
13/Click "Generate Export File"
14/Verify that all the records for every bib listed is in the file
generated
15/Repeat steps with different file names / records

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 17 21:20:27 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 17 Jan 2020 20:20:27 +0000
Subject: [Koha-bugs] [Bug 24455] date formatting from JS
In-Reply-To: <bug-24455-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24455-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24455-70-13LpsZibkI@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24455

Agustín Moyano <agustinmoyano at theke.io> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Small patch
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 17 21:20:31 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 17 Jan 2020 20:20:31 +0000
Subject: [Koha-bugs] [Bug 24455] date formatting from JS
In-Reply-To: <bug-24455-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24455-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24455-70-O26e9093zc@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24455

--- Comment #1 from Agustín Moyano <agustinmoyano at theke.io> ---
Created attachment 97567
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97567&action=edit
Bug 24455: Add moment library in opac

This patch adds koha-tmpl/opac-tmpl/bootstrap/lib/moment.min.js in order to use
the moment library (https://momentjs.com/)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 17 21:20:36 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 17 Jan 2020 20:20:36 +0000
Subject: [Koha-bugs] [Bug 24455] date formatting from JS
In-Reply-To: <bug-24455-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24455-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24455-70-3YTpKSa0ze@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24455

--- Comment #2 from Agustín Moyano <agustinmoyano at theke.io> ---
Created attachment 97568
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97568&action=edit
Bug 24455: Add moment-timezone library in opac

This patch adds
koha-tmpl/opac-tmpl/bootstrap/lib/moment-timezone-with-data-10-year-range.min.js
in order to use the moment library with timezones
(https://momentjs.com/timezone/)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 17 21:20:39 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 17 Jan 2020 20:20:39 +0000
Subject: [Koha-bugs] [Bug 24455] date formatting from JS
In-Reply-To: <bug-24455-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24455-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24455-70-xKKPAqXcx2@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24455

--- Comment #3 from Agustín Moyano <agustinmoyano at theke.io> ---
Created attachment 97569
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97569&action=edit
Bug 24455: Add JS functions to format date and datetime strings

This patch adds the
koha-tmpl/opac-tmpl/bootstrap/en/includes/js-date-format.inc file
(date-format.inc whas not available as name)

When you include that file in your TT, you'll get the following functions
available:

1. $date(raw_date_string, options)

   This function parses a date string, as produced by an api call, and returns
the corresponding date formatted according to 'dateformat' and 'TimeFormat'
parameters.

   For example:

   // dateformat: us
   // timeformat: 12hr
   // Timezone: UTC

   $date('2020-03-23T15:00:00+01:00') // You will get '03/23/2020'

   $date('2020-03-23T15:00:00+01:00', {withtime: true}) // You will get
'03/23/2020 14:00'

   $date('2020-03-23T15:00:00+01:00', {withtime: true, tz: 'Europe/Paris'}) //
You will get '03/23/2020 15:00+01:00'

   Options:

   * dateformat: override date format as configured in staff interface (accepts
also 'rfc3339')

   * timeformat: override time format as configured in staff client (available
options are '12hr' and '24hr')

   * withtime: also print the time part (default false)

   * tz: set the timezone

2. $datetime(raw_date_string, option)

   The same as $date but sets withtime to true

3. $time(raw_date_string, option)

   The same as $datetime but shows only the time part

To test you must implement and test bug 20936, where it will be used

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 17 21:22:42 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 17 Jan 2020 20:22:42 +0000
Subject: [Koha-bugs] [Bug 24433] OPAC account page no longer asks for
 confirmation before deleting hold
In-Reply-To: <bug-24433-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24433-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24433-70-GneBDc0Aoh@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24433

Maryse Simard <maryse.simard at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #97445|0                           |1
        is obsolete|                            |

--- Comment #2 from Maryse Simard <maryse.simard at inlibro.com> ---
Created attachment 97570
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97570&action=edit
Bug 24433: OPAC account page no longer asks for confirmation before deleting
hold

This patch restores markup added by Bug 21870 and subsequently removed
accidentally by Bug 21772. This allows the OPAC user summary page to
display a confirmation dialog before deleting a hold.

To test, apply the patch and  log in to the OPAC as a user with holds.

 - On the "Your summary" page, click the "Holds" tab.
 - Click the "Cancel" button next to any hold.
 - You should see a modal dialog asking for confirmation, showing the
   correct title.
 - Test both the "Yes" and "No" actions.

Signed-off-by: Maryse Simard <maryse.simard at inlibro.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 17 21:22:52 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 17 Jan 2020 20:22:52 +0000
Subject: [Koha-bugs] [Bug 24433] OPAC account page no longer asks for
 confirmation before deleting hold
In-Reply-To: <bug-24433-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24433-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24433-70-mvvfGBUeqT@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24433

Maryse Simard <maryse.simard at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off
                 CC|                            |maryse.simard at inlibro.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 17 21:28:08 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 17 Jan 2020 20:28:08 +0000
Subject: [Koha-bugs] [Bug 24448] Add Koha::Biblio->subscriptions_count
In-Reply-To: <bug-24448-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24448-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24448-70-aPDjBXFrT1@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24448

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 17 21:28:11 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 17 Jan 2020 20:28:11 +0000
Subject: [Koha-bugs] [Bug 24448] Add Koha::Biblio->subscriptions_count
In-Reply-To: <bug-24448-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24448-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24448-70-XNBMLZHdQ9@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24448

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #97525|0                           |1
        is obsolete|                            |
  Attachment #97526|0                           |1
        is obsolete|                            |

--- Comment #3 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 97571
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97571&action=edit
Bug 24448: Unit tests

This patch adds tests for the new method to be introduced. It also moves
the tests for Koha::Biblio->subscriptions to the Biblio.t where it
really belongs.

To test, run this tests along with the patch implementing the new
method.

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 17 21:28:14 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 17 Jan 2020 20:28:14 +0000
Subject: [Koha-bugs] [Bug 24448] Add Koha::Biblio->subscriptions_count
In-Reply-To: <bug-24448-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24448-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24448-70-20ucV1wNjO@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24448

--- Comment #4 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 97572
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97572&action=edit
Bug 24448: Add Koha::Biblio->subscriptions_count

This patch adds the handy subscriptions_count method to the Koha::Biblio
class. It is intended to be used as a shortcut for

    $biblio->subscriptions->count

in places like the API where we can embed the output of a method.

To test:
1. Apply this patches
2. Run:
   $ kshell
  k$ prove t/db_dependent/Koha/Biblio.t \
           t/db_dependent/Koha/Biblios.t
=> SUCCESS: Tests pass! i.e. Biblios.t still passes, and the tests for
the new method in Biblio.t pass as well.
3. Sign off :-D

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 17 21:33:43 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 17 Jan 2020 20:33:43 +0000
Subject: [Koha-bugs] [Bug 24437] Circulation Rules are not Respecting
 Correct Rule if Library is Using Hard Due Dates
In-Reply-To: <bug-24437-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24437-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24437-70-rbyt1NXweq@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24437

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |DUPLICATE

--- Comment #2 from Nick Clemens <nick at bywatersolutions.com> ---


*** This bug has been marked as a duplicate of bug 23382 ***

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 17 21:33:43 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 17 Jan 2020 20:33:43 +0000
Subject: [Koha-bugs] [Bug 23382] Issuing rules failing after bug 20912
In-Reply-To: <bug-23382-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23382-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23382-70-9BInTslbnq@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23382

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |kelly at bywatersolutions.com

--- Comment #76 from Nick Clemens <nick at bywatersolutions.com> ---
*** Bug 24437 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 17 21:55:19 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 17 Jan 2020 20:55:19 +0000
Subject: [Koha-bugs] [Bug 24454] currency formatting from JS
In-Reply-To: <bug-24454-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24454-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24454-70-t0cpkK2BId@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24454

Agustín Moyano <agustinmoyano at theke.io> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff
   Patch complexity|---                         |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 17 21:55:22 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 17 Jan 2020 20:55:22 +0000
Subject: [Koha-bugs] [Bug 24454] currency formatting from JS
In-Reply-To: <bug-24454-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24454-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24454-70-Uwwa68GDqO@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24454

--- Comment #1 from Agustín Moyano <agustinmoyano at theke.io> ---
Created attachment 97573
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97573&action=edit
Bug 24454: Add Currencies.pm template plugin and currency.inc files

This patch adds a new TT plugin called Currencies which retrieves information
about the active currency.

It also adds a currency.inc file in both opac and intranet, which if included
in your TT, you will have the $currency function available in JS.

The $currency function formats numbers into the configured active currency
format.

For example:

$currency(12322.4532) //Returns '$12,322.45' if currency format is 'US' and
active currency has '$' symbol and no space separation.

To test you must implement and test bug 20212, where it will be used

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 17 22:09:42 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 17 Jan 2020 21:09:42 +0000
Subject: [Koha-bugs] [Bug 24455] date formatting from JS
In-Reply-To: <bug-24455-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24455-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24455-70-jeZ4ZGSmAS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24455

Agustín Moyano <agustinmoyano at theke.io> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #97567|0                           |1
        is obsolete|                            |
  Attachment #97568|0                           |1
        is obsolete|                            |
  Attachment #97569|0                           |1
        is obsolete|                            |

--- Comment #4 from Agustín Moyano <agustinmoyano at theke.io> ---
Created attachment 97574
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97574&action=edit
Bug 24455: Add moment library in opac

This patch adds koha-tmpl/opac-tmpl/bootstrap/lib/moment.min.js in order to use
the moment library (https://momentjs.com/)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 17 22:09:46 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 17 Jan 2020 21:09:46 +0000
Subject: [Koha-bugs] [Bug 24455] date formatting from JS
In-Reply-To: <bug-24455-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24455-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24455-70-OxUlR6y9z1@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24455

--- Comment #5 from Agustín Moyano <agustinmoyano at theke.io> ---
Created attachment 97575
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97575&action=edit
Bug 24455: Add moment library in staff

This patch adds koha-tmpl/intranet-tmpl/lib/moment/moment.min.js in order to
use the moment library (https://momentjs.com/)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 17 22:09:50 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 17 Jan 2020 21:09:50 +0000
Subject: [Koha-bugs] [Bug 24455] date formatting from JS
In-Reply-To: <bug-24455-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24455-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24455-70-Lb4m0Ur39D@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24455

--- Comment #6 from Agustín Moyano <agustinmoyano at theke.io> ---
Created attachment 97576
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97576&action=edit
Bug 24455: Add moment-timezone library in opac

This patch adds
koha-tmpl/opac-tmpl/bootstrap/lib/moment-timezone-with-data-10-year-range.min.js
in order to use the moment library with timezones
(https://momentjs.com/timezone/)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 17 22:09:55 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 17 Jan 2020 21:09:55 +0000
Subject: [Koha-bugs] [Bug 24455] date formatting from JS
In-Reply-To: <bug-24455-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24455-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24455-70-F851G6G8mT@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24455

--- Comment #7 from Agustín Moyano <agustinmoyano at theke.io> ---
Created attachment 97577
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97577&action=edit
Bug 24455: Add moment-timezone library in staff

This patch adds
koha-tmpl/intranet-tmpl/lib/moment/moment-timezone-with-data-10-year-range.min.js
in order to use the moment library with timezones
(https://momentjs.com/timezone/)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 17 22:09:58 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 17 Jan 2020 21:09:58 +0000
Subject: [Koha-bugs] [Bug 24455] date formatting from JS
In-Reply-To: <bug-24455-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24455-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24455-70-S5V0nepSTZ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24455

--- Comment #8 from Agustín Moyano <agustinmoyano at theke.io> ---
Created attachment 97578
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97578&action=edit
Bug 24455: Add JS functions to format date and datetime strings

This patch adds the a js-date-format.inc file on each opac and staff interface
(date-format.inc whas not available as name)

When you include that file in your TT, you'll get the following functions
available:

1. $date(raw_date_string, options)

   This function parses a date string, as produced by an api call, and returns
the corresponding date formatted according to 'dateformat' and 'TimeFormat'
parameters.

   For example:

   // dateformat: us
   // timeformat: 12hr
   // Timezone: UTC

   $date('2020-03-23T15:00:00+01:00') // You will get '03/23/2020'

   $date('2020-03-23T15:00:00+01:00', {withtime: true}) // You will get
'03/23/2020 14:00'

   $date('2020-03-23T15:00:00+01:00', {withtime: true, tz: 'Europe/Paris'}) //
You will get '03/23/2020 15:00+01:00'

   Options:

   * dateformat: override date format as configured in staff interface (accepts
also 'rfc3339')

   * timeformat: override time format as configured in staff client (available
options are '12hr' and '24hr')

   * withtime: also print the time part (default false)

   * tz: set the timezone

2. $datetime(raw_date_string, option)

   The same as $date but sets withtime to true

3. $time(raw_date_string, option)

   The same as $datetime but shows only the time part

To test you must implement and test bug 20936, where it will be used

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 17 22:37:15 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 17 Jan 2020 21:37:15 +0000
Subject: [Koha-bugs] [Bug 21296] suspend hold ignores system preference on
 intranet
In-Reply-To: <bug-21296-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21296-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21296-70-mBDEJwzVs6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21296

ByWater Sandboxes <bws.sandboxes at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #95624|0                           |1
        is obsolete|                            |

--- Comment #2 from ByWater Sandboxes <bws.sandboxes at gmail.com> ---
Created attachment 97579
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97579&action=edit
Bug 21296: suspend hold ignores system preference on intranet

This patch modifies the DataTable configuration for the table of holds
which displays under the "Holds" tab on the patron's checkout and
details pages. A variable is now defined in the JavaScript with the
value of the "SuspendHoldsIntranet" system preference. This variable is
passed to the DataTable configuration to determine whether the column is
visible or not.

One of the changes made in this patch moves a <script> block so that it
appears before some of the JS includes on the page. This helps keep the
string-defining JS together in one block.

To test, apply the patch and set the "SuspendHoldsIntranet" system
preference to "Allow."

 - Open the checkout page for a patron with one or more holds.
 - Under the "Holds" tab, the table of holds should have a "Suspend"
   column with controls for suspending or resuming holds.
 - Check that the same is true on the patron detail page.
 - Set the "SuspendHoldsIntranet" system preference to "Don't allow."
 - Test the checkout and detail pages again and confirm that the
   "Suspend" column does not appear.

Signed-off-by: Kelly McElligott <kelly at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 17 22:37:54 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 17 Jan 2020 21:37:54 +0000
Subject: [Koha-bugs] [Bug 21296] suspend hold ignores system preference on
 intranet
In-Reply-To: <bug-21296-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21296-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21296-70-EIBgl46xsX@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21296

Kelly McElligott <kelly at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |kelly at bywatersolutions.com
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 17 22:49:19 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 17 Jan 2020 21:49:19 +0000
Subject: [Koha-bugs] [Bug 24456] New: previousIssuesDefaultSortOrder and
 todaysIssuesDefaultSortOrder
Message-ID: <bug-24456-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24456

            Bug ID: 24456
           Summary: previousIssuesDefaultSortOrder and
                    todaysIssuesDefaultSortOrder
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Circulation
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: lucas at bywatersolutions.com
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com

previousIssuesDefaultSortOrder and todaysIssuesDefaultSortOrder are backwards.
If you choose 'earliest to latest' it sorts 'latest to earliest' and vise
versa.

Also the wording of todaysIssuesDefaultSortOrder is wrong. It says      
"Sort today's checkouts on the circulation page from {X} due date." With
today's checkouts it does not sort by date due but by timestamp.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 17 22:49:30 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 17 Jan 2020 21:49:30 +0000
Subject: [Koha-bugs] [Bug 24456] previousIssuesDefaultSortOrder and
 todaysIssuesDefaultSortOrder
In-Reply-To: <bug-24456-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24456-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24456-70-Ze1WPqe8qX@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24456

Lucas Gass <lucas at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|enhancement                 |normal

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 17 23:13:59 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 17 Jan 2020 22:13:59 +0000
Subject: [Koha-bugs] [Bug 24456] previousIssuesDefaultSortOrder and
 todaysIssuesDefaultSortOrder
In-Reply-To: <bug-24456-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24456-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24456-70-9RSZ3DVzqL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24456

Lucas Gass <lucas at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 17 23:14:02 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 17 Jan 2020 22:14:02 +0000
Subject: [Koha-bugs] [Bug 24456] previousIssuesDefaultSortOrder and
 todaysIssuesDefaultSortOrder
In-Reply-To: <bug-24456-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24456-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24456-70-BGjSLFjEka@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24456

--- Comment #1 from Lucas Gass <lucas at bywatersolutions.com> ---
Created attachment 97580
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97580&action=edit
Bug 24456: change default sort orders/make wording clearer

TEST PLAN:
1. Apply patch
2. Have some checkout from today and some from multiple previous days.   
3. Set  todaysIssuesDefaultSortOrder &  previousIssuesDefaultSortOrder to
'earliest to latest' and confirm it sorts correctly.  
4. Reverse the 2 system preferences and see that it is now sorting the opposite
way.
5. Also look at the wording of each system prefence and make sure it makes
sense

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 17 23:39:58 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 17 Jan 2020 22:39:58 +0000
Subject: [Koha-bugs] [Bug 23355] Add 'cashup' process to the accounts system
In-Reply-To: <bug-23355-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23355-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23355-70-4JWRCA5WZd@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23355

Michal Denar <black23 at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |black23 at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 17 23:56:10 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 17 Jan 2020 22:56:10 +0000
Subject: [Koha-bugs] [Bug 24456] previousIssuesDefaultSortOrder and
 todaysIssuesDefaultSortOrder
In-Reply-To: <bug-24456-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24456-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24456-70-huKhtqnNDa@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24456

Lucas Gass <lucas at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |lucas at bywatersolutions.com
                   |ity.org                     |

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Sat Jan 18 00:18:49 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 17 Jan 2020 23:18:49 +0000
Subject: [Koha-bugs] [Bug 24456] previousIssuesDefaultSortOrder and
 todaysIssuesDefaultSortOrder sort incorrectly
In-Reply-To: <bug-24456-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24456-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24456-70-ikvdZmz3qW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24456

Lucas Gass <lucas at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|previousIssuesDefaultSortOr |previousIssuesDefaultSortOr
                   |der and                     |der and
                   |todaysIssuesDefaultSortOrde |todaysIssuesDefaultSortOrde
                   |r                           |r sort incorrectly

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jan 18 15:50:37 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 18 Jan 2020 14:50:37 +0000
Subject: [Koha-bugs] [Bug 24445] Add missing Z3950 updates to Makefile.PL
In-Reply-To: <bug-24445-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24445-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24445-70-fPjX74L5TS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24445

Joy Nelson <joy at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to master            |Pushed to stable
         Version(s)|20.05.00                    |20.05.00, 19.11.02
        released in|                            |

--- Comment #7 from Joy Nelson <joy at bywatersolutions.com> ---
Pushed to 19.11.x branch for 19.11.02

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jan 18 15:58:02 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 18 Jan 2020 14:58:02 +0000
Subject: [Koha-bugs] [Bug 24016] manager_id in Koha::Patron::Message->store
 should not depend on userenv alone
In-Reply-To: <bug-24016-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24016-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24016-70-aKZzoTsB5u@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24016

Joy Nelson <joy at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|20.05.00                    |20.05.00, 19.11.02
        released in|                            |
             Status|Pushed to master            |Pushed to stable
                 CC|                            |joy at bywatersolutions.com

--- Comment #15 from Joy Nelson <joy at bywatersolutions.com> ---
Pushed to 19.11.x branch for 19.11.02

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jan 18 16:08:28 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 18 Jan 2020 15:08:28 +0000
Subject: [Koha-bugs] [Bug 24150] Add missing Koha::Old::*[s] classes
In-Reply-To: <bug-24150-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24150-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24150-70-XTcoLNi9yr@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24150

Joy Nelson <joy at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|Pushed to master            |RESOLVED
                 CC|                            |joy at bywatersolutions.com

--- Comment #17 from Joy Nelson <joy at bywatersolutions.com> ---
Not backported to 19.11.x

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jan 18 16:08:28 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 18 Jan 2020 15:08:28 +0000
Subject: [Koha-bugs] [Bug 21684] Koha::Object[s]->delete methods must behave
 identically as the corresponding DBIx::Class ones
In-Reply-To: <bug-21684-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21684-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21684-70-QIVPu2BAq9@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21684
Bug 21684 depends on bug 24150, which changed state.

Bug 24150 Summary: Add missing Koha::Old::*[s] classes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24150

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to master            |RESOLVED
         Resolution|---                         |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jan 18 16:08:28 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 18 Jan 2020 15:08:28 +0000
Subject: [Koha-bugs] [Bug 24151] Add a pseudonymization process for patrons
 and transactions
In-Reply-To: <bug-24151-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24151-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24151-70-0T70HrwDxi@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24151
Bug 24151 depends on bug 24150, which changed state.

Bug 24150 Summary: Add missing Koha::Old::*[s] classes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24150

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to master            |RESOLVED
         Resolution|---                         |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jan 18 16:09:42 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 18 Jan 2020 15:09:42 +0000
Subject: [Koha-bugs] [Bug 21684] Koha::Object[s]->delete methods must behave
 identically as the corresponding DBIx::Class ones
In-Reply-To: <bug-21684-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21684-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21684-70-wyB3NQdCpF@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21684

Joy Nelson <joy at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to master            |RESOLVED
         Resolution|---                         |FIXED
                 CC|                            |joy at bywatersolutions.com

--- Comment #41 from Joy Nelson <joy at bywatersolutions.com> ---
Not backported to 19.11.x because 24150 cannot be backported.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jan 18 16:32:05 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 18 Jan 2020 15:32:05 +0000
Subject: [Koha-bugs] [Bug 24329] Patron cardnumber change times are lost
 during upgrade for bug 3820
In-Reply-To: <bug-24329-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24329-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24329-70-eI31W4UXFZ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24329

Joy Nelson <joy at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|20.05.00                    |20.05.00, 19.11.02
        released in|                            |
                 CC|                            |joy at bywatersolutions.com
             Status|Pushed to master            |Pushed to stable

--- Comment #10 from Joy Nelson <joy at bywatersolutions.com> ---
Pushed to 19.11.x branch for 19.11.02

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jan 18 16:42:55 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 18 Jan 2020 15:42:55 +0000
Subject: [Koha-bugs] [Bug 24263] borrowers.relationship should not contain
 an empty string
In-Reply-To: <bug-24263-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24263-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24263-70-DVnENtkqpC@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24263

Joy Nelson <joy at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|20.05.00                    |20.05.00, 19.11.02
        released in|                            |
             Status|Pushed to master            |Pushed to stable
                 CC|                            |joy at bywatersolutions.com

--- Comment #18 from Joy Nelson <joy at bywatersolutions.com> ---
Pushed to 19.11.x branch for 19.11.02

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jan 18 16:53:57 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 18 Jan 2020 15:53:57 +0000
Subject: [Koha-bugs] [Bug 21959] Batch item modification - ability to apply
 regular expression on text fields
In-Reply-To: <bug-21959-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21959-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21959-70-wmS7H0ZSWU@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21959

Joy Nelson <joy at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |joy at bywatersolutions.com
             Status|Pushed to master            |RESOLVED
         Resolution|---                         |FIXED

--- Comment #33 from Joy Nelson <joy at bywatersolutions.com> ---
Enhancement not backported to 19.11.x branch.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jan 18 16:55:36 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 18 Jan 2020 15:55:36 +0000
Subject: [Koha-bugs] [Bug 24277] Date Received in acquisitions cannot be
 changed
In-Reply-To: <bug-24277-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24277-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24277-70-cw79BJGVfX@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24277

Joy Nelson <joy at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|20.05.00                    |20.05.00, 19.11.02
        released in|                            |
                 CC|                            |joy at bywatersolutions.com
             Status|Pushed to master            |Pushed to stable

--- Comment #12 from Joy Nelson <joy at bywatersolutions.com> ---
Pushed to 19.11.x branch for 19.11.02

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jan 18 17:03:26 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 18 Jan 2020 16:03:26 +0000
Subject: [Koha-bugs] [Bug 23893] Add ->new_from_api and ->set_from_api
 methods to Koha::Object
In-Reply-To: <bug-23893-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23893-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23893-70-AfOZQsW1wi@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23893

Joy Nelson <joy at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to master            |Pushed to stable
                 CC|                            |joy at bywatersolutions.com
         Version(s)|20.05.00                    |20.05.00, 19.11.02
        released in|                            |

--- Comment #51 from Joy Nelson <joy at bywatersolutions.com> ---
Pushed to 19.11.x branch for 19.11.02

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jan 18 17:15:09 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 18 Jan 2020 16:15:09 +0000
Subject: [Koha-bugs] [Bug 24321] Make objects.search use mappings from
 Koha::Object(s)
In-Reply-To: <bug-24321-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24321-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24321-70-kcSP13BkP1@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24321

Joy Nelson <joy at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |joy at bywatersolutions.com

--- Comment #66 from Joy Nelson <joy at bywatersolutions.com> ---
Tomas this would not apply to the 19.11.x branch.  Can you assist me if you
need this backported?

error: could not apply fabcedca05... Bug 24321: Add
Koha::Objects->attributes_from_api
hint: after resolving the conflicts, mark the corrected paths
hint: with 'git add <paths>' or 'git rm <paths>'
hint: and commit the result with 'git commit'

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jan 18 17:20:16 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 18 Jan 2020 16:20:16 +0000
Subject: [Koha-bugs] [Bug 24252] Add credits, debits,
 credit_offsets and debit_offsets relationships to
 Koha::Account::Line
In-Reply-To: <bug-24252-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24252-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24252-70-qQNqhHifyL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24252

Joy Nelson <joy at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |joy at bywatersolutions.com

--- Comment #6 from Joy Nelson <joy at bywatersolutions.com> ---
Enhancement not backported to 19.11.x

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jan 18 17:25:26 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 18 Jan 2020 16:25:26 +0000
Subject: [Koha-bugs] [Bug 24302] Add a way to specify nested objects to
 embed in OpenAPI
In-Reply-To: <bug-24302-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24302-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24302-70-gLUOELBCX0@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24302

Joy Nelson <joy at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |joy at bywatersolutions.com

--- Comment #11 from Joy Nelson <joy at bywatersolutions.com> ---
Does not apply to 19.11.x.  Tomas if you need this in 19.11.x I'll need help
getting to it to apply.  Thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jan 18 17:26:13 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 18 Jan 2020 16:26:13 +0000
Subject: [Koha-bugs] [Bug 24228] Add a parameter to recursively embed
 objects in Koha::Object(s)->to_api
In-Reply-To: <bug-24228-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24228-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24228-70-uFCeucZuPG@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24228

Joy Nelson <joy at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |joy at bywatersolutions.com
         Version(s)|20.05.00                    |20.05.00, 19.11.02
        released in|                            |
             Status|Pushed to master            |Pushed to stable

--- Comment #19 from Joy Nelson <joy at bywatersolutions.com> ---
Pushed to 19.11.x branch for 19.11.02

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jan 18 17:27:11 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 18 Jan 2020 16:27:11 +0000
Subject: [Koha-bugs] [Bug 24255] Add totals methods Koha::Account::Lines
In-Reply-To: <bug-24255-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24255-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24255-70-qfiRnU3N6s@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24255

Joy Nelson <joy at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |joy at bywatersolutions.com

--- Comment #7 from Joy Nelson <joy at bywatersolutions.com> ---
Enhancement Not backported to 19.11.x branch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jan 18 21:15:25 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 18 Jan 2020 20:15:25 +0000
Subject: [Koha-bugs] [Bug 15265] Add Instagram and Pinterest to social media
 links
In-Reply-To: <bug-15265-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15265-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15265-70-3fAc1Mouet@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15265

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |WONTFIX
             Status|NEW                         |RESOLVED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jan 18 21:27:01 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 18 Jan 2020 20:27:01 +0000
Subject: [Koha-bugs] [Bug 23102] 404 errors on page causes SCI user to be
 logged out
In-Reply-To: <bug-23102-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23102-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23102-70-EDJCPyAxDX@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23102

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jan 18 21:27:04 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 18 Jan 2020 20:27:04 +0000
Subject: [Koha-bugs] [Bug 23102] 404 errors on page causes SCI user to be
 logged out
In-Reply-To: <bug-23102-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23102-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23102-70-kQNUSuwpR5@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23102

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #90528|0                           |1
        is obsolete|                            |

--- Comment #5 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 97581
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97581&action=edit
Bug 23102: 404 errors on page causes SCI user to be logged out

To test:
 1 - Have something on the SCO page that won't load
 2 - Add the self_checkin_module and self_checkout_module permissions to the
AutoSelfCheck user
 3 - Access the selfcheckout module
https://yoursite.org/cgi-bin/koha/sco/sco-main.pl
 4 - Sign in
 5 - Click 'Finish'
 6 - Yes to print a receipt
 7 - You are asked to sign in again
 8 - Repeat with the SCI module
 9 - Apply patch
10 - Repeat, but this time the slip can be printed

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jan 18 21:27:29 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 18 Jan 2020 20:27:29 +0000
Subject: [Koha-bugs] [Bug 23102] 404 errors on page causes SCI user to be
 logged out
In-Reply-To: <bug-23102-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23102-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23102-70-sheyu477pq@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23102

--- Comment #6 from Owen Leonard <oleonard at myacpl.org> ---
(In reply to Jonathan Druart from comment #4)
> It would be great to have a regression selenium test here, do not you think?

This works for me, but should it be 'Failed QA' because of the missing test?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jan 18 21:58:31 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 18 Jan 2020 20:58:31 +0000
Subject: [Koha-bugs] [Bug 1918] Minify JavaScript and CSS
In-Reply-To: <bug-1918-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-1918-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-1918-70-rEOO3bJoND@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1918

--- Comment #7 from Owen Leonard <oleonard at myacpl.org> ---
We have moved towards having a build process for client-side assets with the
introduction of SCSS, so I'm inclined to mark this "WONTFIX."

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jan 18 22:00:10 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 18 Jan 2020 21:00:10 +0000
Subject: [Koha-bugs] [Bug 13326] Add possibilty to edit purchase suggestion
 on opac
In-Reply-To: <bug-13326-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13326-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13326-70-8ne6BrOB0E@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13326

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|oleonard at myacpl.org         |koha-bugs at lists.koha-commun
                   |                            |ity.org

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jan 18 22:00:35 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 18 Jan 2020 21:00:35 +0000
Subject: [Koha-bugs] [Bug 15060] Change standard ISBD view for 245/242/246
 in MARC21
In-Reply-To: <bug-15060-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15060-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15060-70-JBH78r6jux@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15060

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
          Component|OPAC                        |MARC Bibliographic data
                   |                            |support
           Assignee|oleonard at myacpl.org         |koha-bugs at lists.koha-commun
                   |                            |ity.org

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jan 18 22:01:11 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 18 Jan 2020 21:01:11 +0000
Subject: [Koha-bugs] [Bug 11154] Collapsable results - simple view of search
 results
In-Reply-To: <bug-11154-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-11154-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11154-70-kA4XeIyLoR@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11154

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |WONTFIX
             Status|NEW                         |RESOLVED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jan 18 22:04:58 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 18 Jan 2020 21:04:58 +0000
Subject: [Koha-bugs] [Bug 24286] FindDuplicateAuthority does not escape
 forward slash in 'GENRE/FORM'
In-Reply-To: <bug-24286-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24286-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24286-70-mEHzUtTTmz@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24286

Myka Kennedy Stephens <mkstephens at lancasterseminary.edu> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #97543|0                           |1
        is obsolete|                            |

--- Comment #5 from Myka Kennedy Stephens <mkstephens at lancasterseminary.edu> ---
Created attachment 97582
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97582&action=edit
Bug 24286: Escape forward slash in GENRE/FORM (and any authtype)

Note that bug 24267 will fix the issue during Z39 searching for new auth, but
the duplicate check at saving will still fail

To test:
 0 - Set SearchEngine to Elasticsearch,  QueryRegexEscapeOptions  to 'Don't
Escape'
 1 - Browse to Authorities
 2 - Select New->New from Z3950
 3 - Search for subject 'Short stories'
 4 - Auth search explodes
 5 - Apply patch
 6 - Repeat and confirm the search results return
 7 - Import and save the GENRE/FORM record for Short stories
 8 - Repeat the search and import the same record
 9 - Confirm that upon save you are notified of duplicate, don't save
10 - set  QueryRegexEscapeOptions to 'Escape' and confirm Z39 searching works
and importing/save notifies of duplicate
11 - set SearchEngine to Zebra and confirm Z39 searching works and
importing/save notifies of duplicate

Signed-off-by: Kelly McElligott <kelly at bywatersolutions.com>
Signed-off-by: Myka Kennedy Stephens <mkstephens at lancasterseminary.edu>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jan 18 22:05:50 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 18 Jan 2020 21:05:50 +0000
Subject: [Koha-bugs] [Bug 24286] FindDuplicateAuthority does not escape
 forward slash in 'GENRE/FORM'
In-Reply-To: <bug-24286-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24286-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24286-70-aDZHK73mle@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24286

Myka Kennedy Stephens <mkstephens at lancasterseminary.edu> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mkstephens at lancasterseminar
                   |                            |y.edu

--- Comment #6 from Myka Kennedy Stephens <mkstephens at lancasterseminary.edu> ---
Patch works as expected. Thank you!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jan 18 22:57:10 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 18 Jan 2020 21:57:10 +0000
Subject: [Koha-bugs] [Bug 24151] Add a pseudonymization process for patrons
 and transactions
In-Reply-To: <bug-24151-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24151-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24151-70-tm6Cd48gM0@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24151

Michal Denar <black23 at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

--- Comment #33 from Michal Denar <black23 at gmail.com> ---
Nice work, Jonathan.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jan 18 22:58:09 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 18 Jan 2020 21:58:09 +0000
Subject: [Koha-bugs] [Bug 24149] Add new Koha::Statistic[s] classes
In-Reply-To: <bug-24149-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24149-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24149-70-4tiEiWGAPQ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24149

Michal Denar <black23 at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off
                 CC|                            |black23 at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jan 18 23:03:46 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 18 Jan 2020 22:03:46 +0000
Subject: [Koha-bugs] [Bug 11281] Printing holds awaiting pickup prints both
 tabs
In-Reply-To: <bug-11281-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-11281-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11281-70-v3v78anDLZ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11281

Michal Denar <black23 at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |black23 at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jan 18 23:56:42 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 18 Jan 2020 22:56:42 +0000
Subject: [Koha-bugs] [Bug 24421] Generated authorities are missing subfields
In-Reply-To: <bug-24421-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24421-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24421-70-uIEGElZDlA@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24421

Myka Kennedy Stephens <mkstephens at lancasterseminary.edu> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jan 18 23:56:45 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 18 Jan 2020 22:56:45 +0000
Subject: [Koha-bugs] [Bug 24421] Generated authorities are missing subfields
In-Reply-To: <bug-24421-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24421-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24421-70-0f1u0GYaLH@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24421

Myka Kennedy Stephens <mkstephens at lancasterseminary.edu> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #97358|0                           |1
        is obsolete|                            |

--- Comment #3 from Myka Kennedy Stephens <mkstephens at lancasterseminary.edu> ---
Created attachment 97583
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97583&action=edit
Bug 24421: Check if subfields are valid using the biblio tag

To test:
 1 - Enable the sysprefs
     AutoCreateAuthorities
     BiblioAddsAuthorities
     CatalogModuleRelink
 2 - Open a record with a subject heading with a subdivision and add a new
subfield, or add a new unauthroized heading to a record and save it
    e.g. 650$aChess$xOpenings$vFiction.
 3 - Save the record, note the created authority and that field is linked
 4 - Save the record again and note the authority number changes
 5 - Find and view the authority linked to the record
 6 - The record is for 'Chess', not Chess openings'
 7 - Search authorities for 'Chess' - note duplicated records
 8 - Apply patch, restart all
 9 - Save the record, auth number increases again, we shoudl create the correct
record this time
10 - Save again, auth number should not change
11 - Search authorities and confirm the generated authority has the correct
subfields

Signed-off-by: Myka Kennedy Stephens <mkstephens at lancasterseminary.edu>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jan 18 23:57:13 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 18 Jan 2020 22:57:13 +0000
Subject: [Koha-bugs] [Bug 24421] Generated authorities are missing subfields
In-Reply-To: <bug-24421-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24421-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24421-70-fnsoEQ6IEY@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24421

Myka Kennedy Stephens <mkstephens at lancasterseminary.edu> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mkstephens at lancasterseminar
                   |                            |y.edu

--- Comment #4 from Myka Kennedy Stephens <mkstephens at lancasterseminary.edu> ---
Patch works as expected. Thank you!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Jan 19 00:53:07 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 18 Jan 2020 23:53:07 +0000
Subject: [Koha-bugs] [Bug 24331] Internal server error when placing hold on
 item if itemtype undefined
In-Reply-To: <bug-24331-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24331-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24331-70-3ZuoqBjRfI@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24331

Myka Kennedy Stephens <mkstephens at lancasterseminary.edu> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Jan 19 00:53:10 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 18 Jan 2020 23:53:10 +0000
Subject: [Koha-bugs] [Bug 24331] Internal server error when placing hold on
 item if itemtype undefined
In-Reply-To: <bug-24331-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24331-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24331-70-nFR03Y0VNC@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24331

Myka Kennedy Stephens <mkstephens at lancasterseminary.edu> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #96793|0                           |1
        is obsolete|                            |

--- Comment #2 from Myka Kennedy Stephens <mkstephens at lancasterseminary.edu> ---
Created attachment 97584
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97584&action=edit
Bug 24331: Don't die on items with no type

To test:
1 - Find or create an item with no itemtype set
2 - Attempt to place a hold
3 - INternal server error
4 - Apply patch
5 - Repeat
6 - No error
7 - Set the items itemtype to an itemtype marked not for loan
8 - Set circ rules to allow holds on this itemtype
9 - Attempt to place hold, item is not holdable
10 - Remove not for loan from itemtype
11 - Item is holdable

Signed-off-by: Myka Kennedy Stephens <mkstephens at lancasterseminary.edu>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Jan 19 00:53:45 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 18 Jan 2020 23:53:45 +0000
Subject: [Koha-bugs] [Bug 24331] Internal server error when placing hold on
 item if itemtype undefined
In-Reply-To: <bug-24331-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24331-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24331-70-wXAbdYvXtF@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24331

Myka Kennedy Stephens <mkstephens at lancasterseminary.edu> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mkstephens at lancasterseminar
                   |                            |y.edu

--- Comment #3 from Myka Kennedy Stephens <mkstephens at lancasterseminary.edu> ---
Patch works as described in test plan. Thank you!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Jan 19 01:36:57 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 19 Jan 2020 00:36:57 +0000
Subject: [Koha-bugs] [Bug 24103] Add option to dump built search query to
 templates
In-Reply-To: <bug-24103-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24103-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24103-70-0oBuVBfm2K@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24103

Myka Kennedy Stephens <mkstephens at lancasterseminary.edu> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mkstephens at lancasterseminar
                   |                            |y.edu
             Status|Needs Signoff               |Failed QA

--- Comment #2 from Myka Kennedy Stephens <mkstephens at lancasterseminary.edu> ---
(In reply to Nick Clemens from comment #1)
> Created attachment 95792 [details] [review]
> Bug 24103: Add option to dump search query to templates
> 
> To test:
> 1 - Apply patch, update database
> 2 - Note new syspref 'DumpSearchQueryTemplate'
> 3 - Leave it off
> 4 - Enable DumpTemplateVariablesOpac and Staff
> 5 - Search on staff and opac
> 6 - View the source
> 7 - Search for 'search_query' - you shouldn't find it
> 8 - Enable the new pref
> 9 - Repeat, but you should find the query
> 10 - Test staff/opac search and advanced search, cataloguing search,
> authority search, authfinder search, adding to a basket form a new biblio
> 11 - All should work and show the query
> 12 - This will work under both ES and Zebra

This is very, very close but needs one more thing: it doesn't apply to OPAC
authority searches.

Test results:
1. Applied patch, updatedatabase, restart_all
2. Noted new syspref 'DumpSearchQueryTemplate'
3. Didn't turn it on
4. Enabled 'DumpTemplateVarsIntranet' and 'DumpTemplateVarsOpac'
5. Searched on staff/intranet, searched on OPAC
6. Viewed the source
7. Searched staff/intranet and OPAC source for 'search_query' - did not find it
8. Enabled 'DumpSearchQueryTemplate'
9. Repeated searches, viewed source, searched source for 'search_query' and
found in both staff/intranet source and OPAC source
10-11. Subsequent test searches:
    a. OPAC advanced search - Yes
    b. OPAC authority search - NO
    c. Staff advanced search - Yes
    d. Cataloguing search - Yes
    e. Staff authority search - Yes
    d. Auth_finder search (when editing a biblio) - Yes
    e. Adding to basket from existing record - Yes
12. Tested with ES only. Plan to retest with both ES and Zebra if patch can be
updated to include OPAC authority search.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Jan 19 02:21:14 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 19 Jan 2020 01:21:14 +0000
Subject: [Koha-bugs] [Bug 23844] Noisy warns in addbiblio.pl when importing
 from Z3950
In-Reply-To: <bug-23844-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23844-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23844-70-mADqk0Wwuo@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23844

Myka Kennedy Stephens <mkstephens at lancasterseminary.edu> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Jan 19 02:21:16 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 19 Jan 2020 01:21:16 +0000
Subject: [Koha-bugs] [Bug 23844] Noisy warns in addbiblio.pl when importing
 from Z3950
In-Reply-To: <bug-23844-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23844-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23844-70-0Nz4aR0lSk@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23844

Myka Kennedy Stephens <mkstephens at lancasterseminary.edu> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #94416|0                           |1
        is obsolete|                            |

--- Comment #2 from Myka Kennedy Stephens <mkstephens at lancasterseminary.edu> ---
Created attachment 97585
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97585&action=edit
Bug 23844: Check if field defined in framework and specify 'Default' for
framework

To test:
1 - Go to Cataloguing
2 - New from Z3950
3 - Find an import a record
4 - Check the plack logs:
Use of uninitialized value in string ne at
/kohadevbox/koha/cataloguing/addbiblio.pl line 565.
Use of uninitialized value in string ne at
/kohadevbox/koha/cataloguing/addbiblio.pl line 580.
Use of uninitialized value $frameworkcode in string eq at
/kohadevbox/koha/cataloguing/addbiblio.pl line 711.
Use of uninitialized value $frameworkcode in string eq at
/kohadevbox/koha/cataloguing/addbiblio.pl line 715.
Use of uninitialized value $frameworkcode in string eq at
/kohadevbox/koha/cataloguing/addbiblio.pl line 734.
5 - Apply patch
6 - Repeat
7 - No new errors
8 - Confirm selecting 'Default' from 'New from Z3950' dropdown also generates
no errors

Signed-off-by: Myka Kennedy Stephens <mkstephens at lancasterseminary.edu>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Jan 19 02:28:46 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 19 Jan 2020 01:28:46 +0000
Subject: [Koha-bugs] [Bug 23844] Noisy warns in addbiblio.pl when importing
 from Z3950
In-Reply-To: <bug-23844-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23844-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23844-70-CPna6wyv0U@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23844

Myka Kennedy Stephens <mkstephens at lancasterseminary.edu> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mkstephens at lancasterseminar
                   |                            |y.edu

--- Comment #3 from Myka Kennedy Stephens <mkstephens at lancasterseminary.edu> ---
Patch works as described for Cataloging > New from Z39.50 and Cataloging > New
from Z39.50 > Default framework.

I would like to point out that the $frameworkcode errors do still appear with
this patch applied when adding records using Catloging > New Record > Default
framework > Z39.50 search and also when using the New > New Record (then click
Z39.50 search button) option from within an existing record.

My plack logs showed the $frameworkcode errors on lines 708, 712, and 731, and
I'm seeing a lot more "uninitialized value in string ne" errors than in the
example provided.
I'm also seeing the following error regardless of method for adding records:
"Use of uninitialized value $searchid in concatenation (.) or string at
/kohadevbox/koha/cataloguing/addbiblio.pl line 860."

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Jan 19 06:05:13 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 19 Jan 2020 05:05:13 +0000
Subject: [Koha-bugs] [Bug 24457] New: K::A::Basket->to_api is not passing
 the parameters to the parent class implementation
Message-ID: <bug-24457-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24457

            Bug ID: 24457
           Summary: K::A::Basket->to_api is not passing the parameters to
                    the parent class implementation
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: Architecture, internals, and plumbing
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: tomascohen at gmail.com
        QA Contact: testopia at bugs.koha-community.org

it calls $self->SUPER::to_api but misses to pass the parameers. This makes
embedding related objects fail to work.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Jan 19 06:05:22 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 19 Jan 2020 05:05:22 +0000
Subject: [Koha-bugs] [Bug 24457] K::A::Basket->to_api is not passing the
 parameters to the parent class implementation
In-Reply-To: <bug-24457-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24457-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24457-70-kyp03t0TRY@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24457

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |tomascohen at gmail.com
                   |ity.org                     |
         Depends on|                            |18731


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18731
[Bug 18731] Add routes for acquisition orders
-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Sun Jan 19 06:05:22 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 19 Jan 2020 05:05:22 +0000
Subject: [Koha-bugs] [Bug 18731] Add routes for acquisition orders
In-Reply-To: <bug-18731-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18731-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18731-70-7hge376pD6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18731

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |24457


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24457
[Bug 24457] K::A::Basket->to_api is not passing the parameters to the parent
class implementation
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Jan 19 06:08:47 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 19 Jan 2020 05:08:47 +0000
Subject: [Koha-bugs] [Bug 24457] K::A::Basket->to_api is not passing the
 parameters to the parent class implementation
In-Reply-To: <bug-24457-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24457-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24457-70-lL7qsAWfO2@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24457

--- Comment #1 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 97586
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97586&action=edit
Bug 24457: Regression tests

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Jan 19 06:08:50 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 19 Jan 2020 05:08:50 +0000
Subject: [Koha-bugs] [Bug 24457] K::A::Basket->to_api is not passing the
 parameters to the parent class implementation
In-Reply-To: <bug-24457-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24457-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24457-70-FjY1SQdzab@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24457

--- Comment #2 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 97587
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97587&action=edit
Bug 24457: Make overloaded ->to_api pass the params to parent method

This patch makes the overloaded to_api method for baskets care about the
remaining parameters, and pass them to SUPER::to_api.

To test:
1. Apply the regression tests
2. Run:
   $ kshell
  k$ prove t/db_dependent/Koha/Acquisition/Basket.t
=> FAIL: Tests fail! No embedded bookseller!
3. Apply this patch
4. Repeat 2
=> SUCCESS: Tests pass!
5. Sign off :-D

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Jan 19 06:09:22 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 19 Jan 2020 05:09:22 +0000
Subject: [Koha-bugs] [Bug 24457] K::A::Basket->to_api is not passing the
 parameters to the parent class implementation
In-Reply-To: <bug-24457-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24457-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24457-70-jtapXWsxFp@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24457

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |20212


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20212
[Bug 20212] Slowness in Receiving in Acquisitions
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Jan 19 06:09:22 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 19 Jan 2020 05:09:22 +0000
Subject: [Koha-bugs] [Bug 20212] Slowness in Receiving in Acquisitions
In-Reply-To: <bug-20212-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20212-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20212-70-NauUJawmKG@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20212

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |24457


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24457
[Bug 24457] K::A::Basket->to_api is not passing the parameters to the parent
class implementation
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Jan 19 06:09:31 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 19 Jan 2020 05:09:31 +0000
Subject: [Koha-bugs] [Bug 24457] K::A::Basket->to_api is not passing the
 parameters to the parent class implementation
In-Reply-To: <bug-24457-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24457-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24457-70-pbprXTl4wP@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24457

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Jan 19 11:26:02 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 19 Jan 2020 10:26:02 +0000
Subject: [Koha-bugs] [Bug 1918] Minify JavaScript and CSS
In-Reply-To: <bug-1918-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-1918-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-1918-70-S2EtXprvsU@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1918

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de

--- Comment #8 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
(In reply to Owen Leonard from comment #7)
> We have moved towards having a build process for client-side assets with the
> introduction of SCSS, so I'm inclined to mark this "WONTFIX."

+1

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Jan 19 16:19:19 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 19 Jan 2020 15:19:19 +0000
Subject: [Koha-bugs] [Bug 23702] New UNIMARC XSLT according to last IFLA
 updates
In-Reply-To: <bug-23702-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23702-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23702-70-kym8sN5lF5@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23702

Koha Team University Lyon 3 <koha at univ-lyon3.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #95581|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Jan 19 16:20:56 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 19 Jan 2020 15:20:56 +0000
Subject: [Koha-bugs] [Bug 23702] New UNIMARC XSLT according to last IFLA
 updates
In-Reply-To: <bug-23702-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23702-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23702-70-fZh39bfjY6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23702

Koha Team University Lyon 3 <koha at univ-lyon3.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #93867|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Jan 19 16:55:14 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 19 Jan 2020 15:55:14 +0000
Subject: [Koha-bugs] [Bug 23702] New UNIMARC XSLT according to last IFLA
 updates
In-Reply-To: <bug-23702-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23702-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23702-70-yfEMPqzE6w@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23702

Koha Team University Lyon 3 <koha at univ-lyon3.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #93870|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Jan 19 16:59:54 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 19 Jan 2020 15:59:54 +0000
Subject: [Koha-bugs] [Bug 23702] New UNIMARC XSLT according to last IFLA
 updates
In-Reply-To: <bug-23702-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23702-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23702-70-sqP6KJmibs@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23702

Koha Team University Lyon 3 <koha at univ-lyon3.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |ASSIGNED

--- Comment #21 from Koha Team University Lyon 3 <koha at univ-lyon3.fr> ---
Thanks Stéphane for the new file UNIMARCslim2intranetResults.xsl.
But according to Julian's comment (comment 19
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23702#c19), there's
also a problem on the file
koha-tmpl/opac-tmpl/bootstrap/en/xslt/UNIMARCslimUtils.xsl

I change the previous one to put it "obsolete".

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Jan 19 17:29:50 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 19 Jan 2020 16:29:50 +0000
Subject: [Koha-bugs] [Bug 23002] OPAC doesn't retain search filters in
 results pages
In-Reply-To: <bug-23002-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23002-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23002-70-i6rAhYuTpO@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23002

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |WORKSFORME

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Jan 19 20:23:10 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 19 Jan 2020 19:23:10 +0000
Subject: [Koha-bugs] [Bug 24251] Patron modification logs should be ordered
 most recent first
In-Reply-To: <bug-24251-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24251-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24251-70-ll77iM8NtR@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24251

Michal Denar <black23 at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |black23 at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Jan 19 22:13:15 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 19 Jan 2020 21:13:15 +0000
Subject: [Koha-bugs] [Bug 24457] K::A::Basket->to_api is not passing the
 parameters to the parent class implementation
In-Reply-To: <bug-24457-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24457-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24457-70-BBkdW8XxKc@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24457

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Jan 19 22:13:36 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 19 Jan 2020 21:13:36 +0000
Subject: [Koha-bugs] [Bug 24457] K::A::Basket->to_api is not passing the
 parameters to the parent class implementation
In-Reply-To: <bug-24457-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24457-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24457-70-kXikNjTfpu@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24457

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #97586|0                           |1
        is obsolete|                            |

--- Comment #3 from David Nind <david at davidnind.com> ---
Created attachment 97588
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97588&action=edit
Bug 24457: Regression tests

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

Signed-off-by: David Nind <david at davidnind.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Jan 19 22:13:40 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 19 Jan 2020 21:13:40 +0000
Subject: [Koha-bugs] [Bug 24457] K::A::Basket->to_api is not passing the
 parameters to the parent class implementation
In-Reply-To: <bug-24457-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24457-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24457-70-WtNJT6IDQ0@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24457

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #97587|0                           |1
        is obsolete|                            |

--- Comment #4 from David Nind <david at davidnind.com> ---
Created attachment 97589
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97589&action=edit
Bug 24457: Make overloaded ->to_api pass the params to parent method

This patch makes the overloaded to_api method for baskets care about the
remaining parameters, and pass them to SUPER::to_api.

To test:
1. Apply the regression tests
2. Run:
   $ kshell
  k$ prove t/db_dependent/Koha/Acquisition/Basket.t
=> FAIL: Tests fail! No embedded bookseller!
3. Apply this patch
4. Repeat 2
=> SUCCESS: Tests pass!
5. Sign off :-D

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

Signed-off-by: David Nind <david at davidnind.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Jan 19 22:38:02 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 19 Jan 2020 21:38:02 +0000
Subject: [Koha-bugs] [Bug 21296] Suspend hold ignores system preference on
 intranet
In-Reply-To: <bug-21296-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21296-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21296-70-BZJhaUq7aN@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21296

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|suspend hold ignores system |Suspend hold ignores system
                   |preference on intranet      |preference on intranet
                 CC|                            |katrin.fischer at bsz-bw.de

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Jan 19 22:41:29 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 19 Jan 2020 21:41:29 +0000
Subject: [Koha-bugs] [Bug 21296] Suspend hold ignores system preference on
 intranet
In-Reply-To: <bug-21296-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21296-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21296-70-4mC1aJ0ect@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21296

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Jan 19 22:41:32 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 19 Jan 2020 21:41:32 +0000
Subject: [Koha-bugs] [Bug 21296] Suspend hold ignores system preference on
 intranet
In-Reply-To: <bug-21296-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21296-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21296-70-TwLg0yYter@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21296

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #97579|0                           |1
        is obsolete|                            |

--- Comment #3 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 97590
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97590&action=edit
Bug 21296: suspend hold ignores system preference on intranet

This patch modifies the DataTable configuration for the table of holds
which displays under the "Holds" tab on the patron's checkout and
details pages. A variable is now defined in the JavaScript with the
value of the "SuspendHoldsIntranet" system preference. This variable is
passed to the DataTable configuration to determine whether the column is
visible or not.

One of the changes made in this patch moves a <script> block so that it
appears before some of the JS includes on the page. This helps keep the
string-defining JS together in one block.

To test, apply the patch and set the "SuspendHoldsIntranet" system
preference to "Allow."

 - Open the checkout page for a patron with one or more holds.
 - Under the "Holds" tab, the table of holds should have a "Suspend"
   column with controls for suspending or resuming holds.
 - Check that the same is true on the patron detail page.
 - Set the "SuspendHoldsIntranet" system preference to "Don't allow."
 - Test the checkout and detail pages again and confirm that the
   "Suspend" column does not appear.

Signed-off-by: Kelly McElligott <kelly at bywatersolutions.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Jan 19 22:42:28 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 19 Jan 2020 21:42:28 +0000
Subject: [Koha-bugs] [Bug 24341] Allow for more complex markup in OPAC
 confirmation dialogs
In-Reply-To: <bug-24341-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24341-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24341-70-3eUnmfTFlv@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24341

--- Comment #5 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
(In reply to Owen Leonard from comment #4)
> (In reply to Katrin Fischer from comment #3)
> > Cancelling a hold in the OPAC doesn't ask for confirmation in my testing -
> > can you pleas check?
> 
> This is true in master too. I've created Bug 24433

Thx Owen!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Jan 19 22:44:19 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 19 Jan 2020 21:44:19 +0000
Subject: [Koha-bugs] [Bug 24341] Allow for more complex markup in OPAC
 confirmation dialogs
In-Reply-To: <bug-24341-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24341-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24341-70-sPmsnRMX31@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24341

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Jan 19 22:44:22 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 19 Jan 2020 21:44:22 +0000
Subject: [Koha-bugs] [Bug 24341] Allow for more complex markup in OPAC
 confirmation dialogs
In-Reply-To: <bug-24341-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24341-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24341-70-Oo5Y2jGpQ7@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24341

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #97420|0                           |1
        is obsolete|                            |

--- Comment #6 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 97591
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97591&action=edit
Bug 24341: Allow for more complex markup in OPAC confirmation dialogs

This patch changes the globally-available confirmModal() function in the
OPAC so that it uses jQuery's html() function for adding information to
the confirmation modal's body. This will allow for more than just plain
text to be added.

This patch also removes some obsolete lines from the JavaScript in
opac-user.tt and renames some variable for clarity.

To test, apply the patch log in to the OPAC as a user who has holds and
article requests.

 - Test the following interactions, both the confirmation and cancel
   options for each:
     - Cancel a hold
     - Suspend all holds
     - Resume all holds
     - Cancel an article request

Signed-off-by: Maryse Simard <maryse.simard at inlibro.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Jan 19 22:50:27 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 19 Jan 2020 21:50:27 +0000
Subject: [Koha-bugs] [Bug 24433] OPAC account page no longer asks for
 confirmation before deleting hold
In-Reply-To: <bug-24433-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24433-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24433-70-8JlEC7Me9V@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24433

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Jan 19 22:50:30 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 19 Jan 2020 21:50:30 +0000
Subject: [Koha-bugs] [Bug 24433] OPAC account page no longer asks for
 confirmation before deleting hold
In-Reply-To: <bug-24433-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24433-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24433-70-MmdqiScK2i@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24433

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #97570|0                           |1
        is obsolete|                            |

--- Comment #3 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 97592
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97592&action=edit
Bug 24433: OPAC account page no longer asks for confirmation before deleting
hold

This patch restores markup added by Bug 21870 and subsequently removed
accidentally by Bug 21772. This allows the OPAC user summary page to
display a confirmation dialog before deleting a hold.

To test, apply the patch and  log in to the OPAC as a user with holds.

 - On the "Your summary" page, click the "Holds" tab.
 - Click the "Cancel" button next to any hold.
 - You should see a modal dialog asking for confirmation, showing the
   correct title.
 - Test both the "Yes" and "No" actions.

Signed-off-by: Maryse Simard <maryse.simard at inlibro.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

https://bugs.koha-community.org/show_bug.cgi?id=24341

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Jan 19 22:53:02 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 19 Jan 2020 21:53:02 +0000
Subject: [Koha-bugs] [Bug 24364] Display item holding library in opac issues
In-Reply-To: <bug-24364-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24364-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24364-70-o9CUV2Fqtn@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24364

--- Comment #15 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
(In reply to Owen Leonard from comment #14)
> Created attachment 97440 [details] [review]
> Bug 24364: Display item holding library in opac issues
> 
> Test plan:
> 
>  Check that the library is displayed in patrons opac issues.
>  ('Your summary' -> 'Checked out' and 'Overdue' tabs)
> 
> 
> Current status: Signed Off

Hi Owen, the patch is missing your sign-off line - did something go wrong here?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Jan 19 22:54:50 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 19 Jan 2020 21:54:50 +0000
Subject: [Koha-bugs] [Bug 16147] OpacItemLocation and not for circulation
 Item types
In-Reply-To: <bug-16147-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16147-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16147-70-I8j8WVlLgu@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16147

--- Comment #3 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
(In reply to Owen Leonard from comment #2)
> Assuming you see the call number at all (see Bug 24352), I think this is the
> display that is intended by the design of the preference. I agree however
> that it probably isn't the best way to display the information.

Shoudl we close?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Jan 19 23:01:32 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 19 Jan 2020 22:01:32 +0000
Subject: [Koha-bugs] [Bug 17667] Standing orders - cancelling a receipt
 increase the original quantity
In-Reply-To: <bug-17667-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17667-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17667-70-wtKIB0F065@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17667

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Small patch
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Jan 19 23:01:35 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 19 Jan 2020 22:01:35 +0000
Subject: [Koha-bugs] [Bug 17667] Standing orders - cancelling a receipt
 increase the original quantity
In-Reply-To: <bug-17667-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17667-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17667-70-z9s12J2utx@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17667

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #97317|0                           |1
        is obsolete|                            |

--- Comment #10 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 97593
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97593&action=edit
Bug 17667: Do not modify quantity of the original standing order when a receipt
is cancelled

When cancelling a receipt, the quantity of the original order is
increased.

Test plan:
Create a basket, mark is as "standing orders"
Create an order
receive it
cancel the receipt
=> Without this patch the quantity of the original order is 2
=> With this patch applied the quantity it always 1

Signed-off-by: Kelly McElligott <kelly at bywatersolutions.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Jan 19 23:01:39 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 19 Jan 2020 22:01:39 +0000
Subject: [Koha-bugs] [Bug 17667] Standing orders - cancelling a receipt
 increase the original quantity
In-Reply-To: <bug-17667-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17667-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17667-70-kCBjAcERzD@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17667

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #97318|0                           |1
        is obsolete|                            |

--- Comment #11 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 97594
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97594&action=edit
Bug 17667: Add tests

Signed-off-by: Kelly McElligott <kelly at bywatersolutions.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Jan 19 23:03:23 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 19 Jan 2020 22:03:23 +0000
Subject: [Koha-bugs] [Bug 22868] Circulation staff with suggestions_manage
 can have access to acquisition data
In-Reply-To: <bug-22868-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22868-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22868-70-Awv7jpGMGM@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22868

--- Comment #19 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Marie-Luce or Christopher, could one of you sign-off on this? It should work on
on the sandboxes.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 20 00:11:30 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 19 Jan 2020 23:11:30 +0000
Subject: [Koha-bugs] [Bug 24451] Clarify wording when deleting a bib
 attached to orders
In-Reply-To: <bug-24451-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24451-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24451-70-xbedYxmhmH@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24451

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de

--- Comment #1 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
(In reply to Andrew Fuerste-Henry from comment #0)
> From detail.pl, when attempting to delete a bib that is connected to any
> uncanceled orders in acquisitions, we receive the message: "Warning: This
> record is used in X order(s). Deleting it could cause serious issues on
> acquisition module. Are you sure you want to delete this record?"
> 
> This message would be more helpful if it distinguished between open and
> closed orders. Deleting a bib connected to an open order will cause serious
> issues. Deleting a bib connected to closed orders will not.
> 
> I see three possible fixes:
> - Change the message to specify "This record is used in X open order(s) and
> Y closed order(s). Deleting a record used in open orders could cause serious
> issues ..."
> - Change the message to only appear if the bib is used in orders connected
> to an active budget and give a count of only orders connected to an active
> budget.
> - Complete bug 16872 to entirely block the deletion of bibs in open orders,
> then remove this warning. If we're not allowing the deletion of bibs from
> open orders, then it's not a big deal.

I am ok with the first and last suggestion, but in doubt about the 'only in
active budgets'. Sometimes libraries may mark a budget form last year inactive
and change the budget on receiving the item. I think differentiating between
open and closed would work well enough.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 20 00:12:55 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 19 Jan 2020 23:12:55 +0000
Subject: [Koha-bugs] [Bug 24450] Clarify wording when unable to cancel order
 and delete record
In-Reply-To: <bug-24450-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24450-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24450-70-skDZqplSrX@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24450

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de
           Keywords|                            |Academy

--- Comment #1 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
When this is changed, please keep in mind that the same text shows on receiving
orders as you can also cancel from there.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 20 00:16:26 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 19 Jan 2020 23:16:26 +0000
Subject: [Koha-bugs] [Bug 24397] populate_db.pl is out of sync and must be
 removed
In-Reply-To: <bug-24397-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24397-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24397-70-DutkKl8jTz@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24397

--- Comment #4 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
> Any opinions?
> @Katrin: could you include this in the weekly QA mail?

Will do.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 20 00:19:46 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 19 Jan 2020 23:19:46 +0000
Subject: [Koha-bugs] [Bug 24249] OPAC lists page should require login for
 login-dependent operations
In-Reply-To: <bug-24249-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24249-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24249-70-JSoyRTehGI@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24249

--- Comment #3 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
(In reply to Katrin Fischer from comment #2)
> Hi Owen, I am not sure what the difference here is between before and after.
> I haven't been able to find a link to the 'add list' form, but only 'log in'
> links. Can you explain the change a bit more?

ping?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 20 03:06:23 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 20 Jan 2020 02:06:23 +0000
Subject: [Koha-bugs] [Bug 24449] SIP2 - too_many_overdue flag is not
 implemented
In-Reply-To: <bug-24449-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24449-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24449-70-WNrDtRKtI3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24449

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 20 03:06:30 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 20 Jan 2020 02:06:30 +0000
Subject: [Koha-bugs] [Bug 24449] SIP2 - too_many_overdue flag is not
 implemented
In-Reply-To: <bug-24449-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24449-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24449-70-JZg2AOrom7@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24449

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #97527|0                           |1
        is obsolete|                            |

--- Comment #2 from David Nind <david at davidnind.com> ---
Created attachment 97595
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97595&action=edit
Bug 24449: Add too_many_overdue to patron status for SIP

To test:
1 - Have sip running and use the cli to get info for a patron
    example: perl misc/sip_cli_emulator.pl  -a localhost -p 6001 -su koha -sp
koha -l CPL -m patron_status_request --patron koha
2 - Checkout an item to the patron, backdated so it is overdue
3 - Set syspref 'OverduesBlockCirc' to anything but "Don't Block"
4 - Get the patron status via SIP, note circ blocked flag is set (BLN to BLY),
but too_many_overdue is not
5 - Apply patch
6 - Restart all the things
7 - Get the patron status via SIP
8 - Note the too_many_overdue flag is now triggered and there is a message
    example: READ: 24Y     Y       00120200117    142716AEEdna
Acosta|AA23529001000463|BLY|CQN|BV0.25|AFGreetings from Koha.  -- Patron has
overdues -- Patron owes 0.25|AOCPL|

Signed-off-by: David Nind <david at davidnind.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 20 07:11:35 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 20 Jan 2020 06:11:35 +0000
Subject: [Koha-bugs] [Bug 24458] New: OPAC search results don't use
 Koha::Filter::MARC::ViewPolicy
Message-ID: <bug-24458-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24458

            Bug ID: 24458
           Summary: OPAC search results don't use
                    Koha::Filter::MARC::ViewPolicy
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: minor
          Priority: P5 - low
         Component: Searching
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: dcook at prosentient.com.au
        QA Contact: testopia at bugs.koha-community.org

With https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15870, we
started enforcing the bibliographic framework visibility in the OPAC. 

However, we're not using this for search results, which means that hidden
fields could come through very visibly.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 20 07:11:47 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 20 Jan 2020 06:11:47 +0000
Subject: [Koha-bugs] [Bug 15870] Add Filter for MARC to respect visibility
 settings
In-Reply-To: <bug-15870-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15870-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15870-70-XvuaiEqnFE@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15870

David Cook <dcook at prosentient.com.au> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |dcook at prosentient.com.au

--- Comment #31 from David Cook <dcook at prosentient.com.au> ---
I just noticed that we're not using this functionality for OPAC search results,
which means we're not fully respecting the bibliographic frameworks for the
OPAC.

I've opened up https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24458
in regards to this.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 20 07:11:56 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 20 Jan 2020 06:11:56 +0000
Subject: [Koha-bugs] [Bug 24458] OPAC search results don't use
 Koha::Filter::MARC::ViewPolicy
In-Reply-To: <bug-24458-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24458-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24458-70-LRV4BFLNjm@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24458

David Cook <dcook at prosentient.com.au> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |15870


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15870
[Bug 15870] Add Filter for MARC to respect visibility settings
-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 20 07:11:56 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 20 Jan 2020 06:11:56 +0000
Subject: [Koha-bugs] [Bug 15870] Add Filter for MARC to respect visibility
 settings
In-Reply-To: <bug-15870-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15870-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15870-70-9gpdJ0TGNV@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15870

David Cook <dcook at prosentient.com.au> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |24458


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24458
[Bug 24458] OPAC search results don't use Koha::Filter::MARC::ViewPolicy
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 20 07:46:20 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 20 Jan 2020 06:46:20 +0000
Subject: [Koha-bugs] [Bug 16683] Help links to fields 59X in cataloguing
 form are broken
In-Reply-To: <bug-16683-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16683-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16683-70-hKD4FOGqrw@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16683

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 20 07:46:23 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 20 Jan 2020 06:46:23 +0000
Subject: [Koha-bugs] [Bug 16683] Help links to fields 59X in cataloguing
 form are broken
In-Reply-To: <bug-16683-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16683-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16683-70-z60wsPBRjK@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16683

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #97549|0                           |1
        is obsolete|                            |

--- Comment #4 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 97596
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97596&action=edit
Bug 16683: Help links to fields 59X in cataloguing form are broken

This patch adds more specificity to handling of MARC21 documentation
links in the basic MARC editor.

To test, apply the patch and make sure the "advancedMARCeditor" system
preference is set to "Display."

You may need to edit a bibliographic framework so that 09x, 59x, and 69x
tags will display in the editor.

Edit or create a bibliographic record using that framework. Next to each
tag label in the editor should be a "?" link. Clicking this link should
open a new window with the correct Library of Congress documentation
page.

Check the links for 09x, 59x, and 69x tags as well as others to confirm
they open the correct pages.

Signed-off-by: Cori Lynn Arnold <carnold at dgiinc.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 20 07:52:21 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 20 Jan 2020 06:52:21 +0000
Subject: [Koha-bugs] [Bug 24061] Print List (opac-shelves.pl) broken in
 Chrome
In-Reply-To: <bug-24061-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24061-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24061-70-bYNm8IAoHX@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24061

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Small patch
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 20 07:52:25 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 20 Jan 2020 06:52:25 +0000
Subject: [Koha-bugs] [Bug 24061] Print List (opac-shelves.pl) broken in
 Chrome
In-Reply-To: <bug-24061-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24061-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24061-70-P7d4PIktu1@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24061

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #95664|0                           |1
        is obsolete|                            |
  Attachment #96971|0                           |1
        is obsolete|                            |

--- Comment #30 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 97597
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97597&action=edit
Bug 24061: Close the window after the page has been printed

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 20 07:52:29 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 20 Jan 2020 06:52:29 +0000
Subject: [Koha-bugs] [Bug 24061] Print List (opac-shelves.pl) broken in
 Chrome
In-Reply-To: <bug-24061-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24061-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24061-70-7Rq7MF1v2w@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24061

--- Comment #31 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 97598
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97598&action=edit
Bug 24061: Close after timeout if onafterprint no supported

Not supported on Chrome < 63
https://www.w3schools.com/tags/ev_onafterprint.asp

Signed-off-by: Gabriel DeCarufel <gabriel at inlibro.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 20 07:53:44 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 20 Jan 2020 06:53:44 +0000
Subject: [Koha-bugs] [Bug 24061] Print List (opac-shelves.pl) broken in
 Chrome
In-Reply-To: <bug-24061-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24061-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24061-70-lTC8c6jM6f@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24061

--- Comment #32 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Reported in November... moving forward as this works ok for me in all tested
browsers (Chrome, Chromium, Firefox).

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 20 07:57:14 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 20 Jan 2020 06:57:14 +0000
Subject: [Koha-bugs] [Bug 24393] Remove event attributes from patron clubs
 list template
In-Reply-To: <bug-24393-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24393-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24393-70-xLcRF5kbpP@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24393

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 20 07:57:18 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 20 Jan 2020 06:57:18 +0000
Subject: [Koha-bugs] [Bug 24393] Remove event attributes from patron clubs
 list template
In-Reply-To: <bug-24393-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24393-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24393-70-XpCnxOCF44@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24393

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #97514|0                           |1
        is obsolete|                            |

--- Comment #6 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 97599
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97599&action=edit
Bug 24393: Remove event attributes from patron clubs list template

This patch removes some instances of the "onclick" attributes from the
template that lists patron clubs and templates.

To test, apply the patch and go to Tools -> Patron clubs.

 - Test the process of deleting a club template. Clicking the "Delete"
   button should trigger a confirmation. Confirming should delete the
   template.

 - Test the process of deleting a club. In the "Clubs" section of the
   page, click the "Actions" menu next to any club. Clicking the
   "Delete" link should trigger a confirmation. Confirming should delete
   the club.

 - Also in the "Clubs" section of the page, find a club which has
   enrollments. Select "Search to hold" from the "Actions" menu. It
   should take you to the advanced search. On the search results page
   you should have the option to place a hold for the club you selected.

Signed-off-by: David Nind <david at davidnind.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 20 08:02:55 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 20 Jan 2020 07:02:55 +0000
Subject: [Koha-bugs] [Bug 18874] Add unique constraint to
 repeatable_holidays and special_holidays
In-Reply-To: <bug-18874-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18874-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18874-70-sTMX8NtryM@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18874

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de
             Status|Failed QA                   |RESOLVED
         Resolution|---                         |DUPLICATE

--- Comment #9 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---


*** This bug has been marked as a duplicate of bug 24289 ***

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 20 08:02:55 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 20 Jan 2020 07:02:55 +0000
Subject: [Koha-bugs] [Bug 24289] Deleting branch will not delete entry in
 special holidays
In-Reply-To: <bug-24289-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24289-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24289-70-8MLUiH2NZc@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24289

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |baptiste.wojtkowski at biblibr
                   |                            |e.com

--- Comment #7 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
*** Bug 18874 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 20 08:04:02 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 20 Jan 2020 07:04:02 +0000
Subject: [Koha-bugs] [Bug 24289] Deleting branch will not delete entry in
 special or repeatable holidays
In-Reply-To: <bug-24289-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24289-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24289-70-CcuWpaxrvL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24289

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Deleting branch will not    |Deleting branch will not
                   |delete entry in special     |delete entry in special or
                   |holidays                    |repeatable holidays
                 CC|                            |katrin.fischer at bsz-bw.de

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 20 08:06:16 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 20 Jan 2020 07:06:16 +0000
Subject: [Koha-bugs] [Bug 24289] Deleting branch will not delete entry in
 special or repeatable holidays
In-Reply-To: <bug-24289-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24289-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24289-70-oCfkVkqWur@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24289

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 20 08:06:20 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 20 Jan 2020 07:06:20 +0000
Subject: [Koha-bugs] [Bug 24289] Deleting branch will not delete entry in
 special or repeatable holidays
In-Reply-To: <bug-24289-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24289-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24289-70-LmJB5iF8IJ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24289

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #97410|0                           |1
        is obsolete|                            |

--- Comment #8 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 97600
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97600&action=edit
Bug 24289: Add foreign keys on *_holidays.branchcode tables

Those are missing foreign keys, it will also clean the holidays tables
and automatically remove the holidays when a library is removed.

Test plan:
0. Do not apply this patch
1. Create a new library
2. Create special and repeatable holiday for this library
3. Remove the library
=> Notice that the holidays still exist in DB
4. Apply this patch
5. Execute the update database entry
=> Notice that the holidays for this library have been removed from the DB
6. Repeat 1-3
=> Notice that the holidays have been removed along with the library

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 20 08:06:23 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 20 Jan 2020 07:06:23 +0000
Subject: [Koha-bugs] [Bug 24289] Deleting branch will not delete entry in
 special or repeatable holidays
In-Reply-To: <bug-24289-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24289-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24289-70-8bmi1uLNM6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24289

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #97411|0                           |1
        is obsolete|                            |

--- Comment #9 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 97601
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97601&action=edit
Bug 24289: DBIC changes

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 20 08:06:27 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 20 Jan 2020 07:06:27 +0000
Subject: [Koha-bugs] [Bug 24289] Deleting branch will not delete entry in
 special or repeatable holidays
In-Reply-To: <bug-24289-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24289-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24289-70-54C0y2YOkY@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24289

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #97412|0                           |1
        is obsolete|                            |

--- Comment #10 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 97602
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97602&action=edit
Bug 24289: Make sure sample_holidays will load after sample_libraries

They are inserted depending on their alpha order, and sample_holidays
will fail because of missing branchcode.
This patch suggests a simple fix: rename sample_holidays to
sample_libraries_holidays, to make sure it will be loaded after
sample_libraries

Test plan:
Start a fresh installation and select all sample data

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 20 08:06:41 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 20 Jan 2020 07:06:41 +0000
Subject: [Koha-bugs] [Bug 24289] Deleting branch will not delete entry in
 special or repeatable holidays
In-Reply-To: <bug-24289-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24289-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24289-70-qe7x6zwCne@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24289

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|Small patch                 |Medium patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 20 08:07:18 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 20 Jan 2020 07:07:18 +0000
Subject: [Koha-bugs] [Bug 24214] Due date displayed in ISO format (when
 sticky)
In-Reply-To: <bug-24214-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24214-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24214-70-VeNdFN0KWd@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24214

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

--- Comment #3 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Tiny template change - PQA.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 20 08:11:53 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 20 Jan 2020 07:11:53 +0000
Subject: [Koha-bugs] [Bug 24008] Attempting to delete a patron with
 outstanding credits should warn and block the deletion
In-Reply-To: <bug-24008-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24008-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24008-70-Lx9B5Tpzda@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24008

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Small patch
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 20 08:11:57 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 20 Jan 2020 07:11:57 +0000
Subject: [Koha-bugs] [Bug 24008] Attempting to delete a patron with
 outstanding credits should warn and block the deletion
In-Reply-To: <bug-24008-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24008-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24008-70-tuLVU64iu1@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24008

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #97400|0                           |1
        is obsolete|                            |

--- Comment #14 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 97603
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97603&action=edit
Bug 24008: Display a warning message when deleting a patron with outstanding
credits

So far nothing is displayed if a librarian removes patron with
outstanding credits.
Note that outstanding debits blocks the deletion.

Test plan:
- Create a patron with outstanding credit
- Create a patron with outstanding debits
- Delete the 2 patrons
=> With credit - You get a warning but do not block the deletion
=> With debits - You get a warning message that blocks the deletion

Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 20 08:12:01 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 20 Jan 2020 07:12:01 +0000
Subject: [Koha-bugs] [Bug 24008] Attempting to delete a patron with
 outstanding credits should warn and block the deletion
In-Reply-To: <bug-24008-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24008-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24008-70-gv9jBc0bX2@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24008

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #97401|0                           |1
        is obsolete|                            |

--- Comment #15 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 97604
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97604&action=edit
Bug 24008: Display warnings in a list

Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 20 08:12:04 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 20 Jan 2020 07:12:04 +0000
Subject: [Koha-bugs] [Bug 24008] Attempting to delete a patron with
 outstanding credits should warn and block the deletion
In-Reply-To: <bug-24008-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24008-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24008-70-YelGPyNBm7@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24008

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #97402|0                           |1
        is obsolete|                            |

--- Comment #16 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 97605
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97605&action=edit
Bug 24008: Remove minus sign when displaying credit value

Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 20 08:12:31 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 20 Jan 2020 07:12:31 +0000
Subject: [Koha-bugs] [Bug 24008] Attempting to delete a patron with
 outstanding credits should warn and block the deletion
In-Reply-To: <bug-24008-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24008-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24008-70-Xzh1aIZrOE@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24008

--- Comment #17 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
I feel styling could be a little improved for the message in general, but
that's outside of scope here. Works well.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 20 12:09:27 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 20 Jan 2020 11:09:27 +0000
Subject: [Koha-bugs] [Bug 23007] Make dialogs in returns.pl optionally modal
In-Reply-To: <bug-23007-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23007-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23007-70-f0XTWKSjys@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23007

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |Manual
                 CC|                            |martin.renvoize at ptfs-europe
                   |                            |.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 20 13:28:03 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 20 Jan 2020 12:28:03 +0000
Subject: [Koha-bugs] [Bug 24459] New: Overloaded ->to_api needs to pass
 $params through
Message-ID: <bug-24459-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24459

            Bug ID: 24459
           Summary: Overloaded ->to_api needs to pass $params through
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: Architecture, internals, and plumbing
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: tomascohen at gmail.com
        QA Contact: testopia at bugs.koha-community.org

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 20 13:28:48 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 20 Jan 2020 12:28:48 +0000
Subject: [Koha-bugs] [Bug 24460] New: Modifying item's lost state returns
 issued item without it being logged
Message-ID: <bug-24460-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24460

            Bug ID: 24460
           Summary: Modifying item's lost state returns issued item
                    without it being logged
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: minor
          Priority: P5 - low
         Component: Cataloging
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: joonas.kylmala at helsinki.fi
        QA Contact: testopia at bugs.koha-community.org
                CC: m.de.rooy at rijksmuseum.nl

If the sub MarkIssueReturned is called it returns checked-in item without
logging it to action_logs table:

>        # And finally delete the issue
>        $issue->delete;

Elsewhere in the codebase returns are logged:

>        logaction("CIRCULATION", "RETURN", $borrowernumber, $item->itemnumber)
>            if C4::Context->preference("ReturnLog");

MarkIssueReturned should also log the return to action log so that if any
mistakes are made when changing the item status to lost or not lost they can be
tracked by the librarians.

MarkIssueReturned() gets called by the web page catalogue/updateitem.pl if the
lost status is changed.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 20 13:28:55 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 20 Jan 2020 12:28:55 +0000
Subject: [Koha-bugs] [Bug 24459] Overloaded ->to_api needs to pass $params
 through
In-Reply-To: <bug-24459-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24459-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24459-70-2106RZW0YM@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24459

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=24457
             Status|NEW                         |ASSIGNED

--- Comment #1 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
There are previously defined ->to_api methods in the Koha::* namespace that are
missing  parameters handling. See bug 24457

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 20 13:28:55 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 20 Jan 2020 12:28:55 +0000
Subject: [Koha-bugs] [Bug 24457] K::A::Basket->to_api is not passing the
 parameters to the parent class implementation
In-Reply-To: <bug-24457-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24457-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24457-70-e7xI6o5g3r@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24457

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=24459

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 20 13:51:13 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 20 Jan 2020 12:51:13 +0000
Subject: [Koha-bugs] [Bug 24459] Overloaded ->to_api needs to pass $params
 through
In-Reply-To: <bug-24459-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24459-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24459-70-8UeOpwViiC@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24459

--- Comment #2 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 97621
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97621&action=edit
Bug 24459: Regression tests

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 20 13:51:17 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 20 Jan 2020 12:51:17 +0000
Subject: [Koha-bugs] [Bug 24459] Overloaded ->to_api needs to pass $params
 through
In-Reply-To: <bug-24459-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24459-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24459-70-rx0nuhEMhL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24459

--- Comment #3 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 97622
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97622&action=edit
Bug 24459: Make ->to_api pass $params through

This patch makes the to_api method in Koha::Acquisition::Inovice and
Koha::Patron pass the passed parameters to the base class to_api method.
This is required for things like embedding related objects.

To test:
1. Apply the regression tests patch
2. Run:
   $ kshell
  k$ prove t/db_dependent/Koha/Patron.t \
           t/db_dependent/Koha/Acquisition/Invoice.t
=> FAIL: Tests fail!
3. Apply this patch
4. Repeat 2
=> SUCCESS: Tests pass!
5. Sign off :-D

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 20 13:51:27 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 20 Jan 2020 12:51:27 +0000
Subject: [Koha-bugs] [Bug 24459] Overloaded ->to_api needs to pass $params
 through
In-Reply-To: <bug-24459-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24459-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24459-70-GGYdYXzFpX@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24459

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |tomascohen at gmail.com
                   |ity.org                     |
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 20 13:57:00 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 20 Jan 2020 12:57:00 +0000
Subject: [Koha-bugs] [Bug 24459] Overloaded ->to_api needs to pass $params
 through
In-Reply-To: <bug-24459-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24459-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24459-70-aHAYy9cU0s@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24459

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |18731


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18731
[Bug 18731] Add routes for acquisition orders
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 20 13:57:00 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 20 Jan 2020 12:57:00 +0000
Subject: [Koha-bugs] [Bug 18731] Add routes for acquisition orders
In-Reply-To: <bug-18731-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18731-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18731-70-nllmWLugNA@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18731

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |24459


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24459
[Bug 24459] Overloaded ->to_api needs to pass $params through
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 20 14:12:54 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 20 Jan 2020 13:12:54 +0000
Subject: [Koha-bugs] [Bug 20388] Elasticsearch - Ability to add search
 fields from UI
In-Reply-To: <bug-20388-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20388-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20388-70-gS3TZAklAU@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20388

anne-cecile.bories at iepg.fr changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |anne-cecile.bories at iepg.fr

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 20 14:27:54 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 20 Jan 2020 13:27:54 +0000
Subject: [Koha-bugs] [Bug 24350] Can't place holds
In-Reply-To: <bug-24350-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24350-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24350-70-QnvFhC4cil@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24350

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|additional_work_needed      |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 20 14:59:25 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 20 Jan 2020 13:59:25 +0000
Subject: [Koha-bugs] [Bug 24008] Attempting to delete a patron with
 outstanding credits should warn and block the deletion
In-Reply-To: <bug-24008-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24008-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24008-70-9MmQJ3MSYf@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24008

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|normal                      |enhancement

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 20 15:00:07 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 20 Jan 2020 14:00:07 +0000
Subject: [Koha-bugs] [Bug 24008] Attempting to delete a patron with
 outstanding credits should warn and block the deletion
In-Reply-To: <bug-24008-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24008-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24008-70-CPyexYP3An@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24008

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|rel_20_05_target            |Manual,
                   |                            |release-notes-needed

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 20 15:01:43 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 20 Jan 2020 14:01:43 +0000
Subject: [Koha-bugs] [Bug 16683] Help links to fields 59X in cataloguing
 form are broken
In-Reply-To: <bug-16683-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16683-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16683-70-0O8LW4ycDe@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16683

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|                            |20.05.00
        released in|                            |
             Status|Passed QA                   |Pushed to master

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 20 15:01:45 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 20 Jan 2020 14:01:45 +0000
Subject: [Koha-bugs] [Bug 16683] Help links to fields 59X in cataloguing
 form are broken
In-Reply-To: <bug-16683-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16683-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16683-70-H9ZKYWVmAW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16683

--- Comment #5 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Nice work everyone!

Pushed to master for 20.05

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 20 15:01:47 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 20 Jan 2020 14:01:47 +0000
Subject: [Koha-bugs] [Bug 17667] Standing orders - cancelling a receipt
 increase the original quantity
In-Reply-To: <bug-17667-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17667-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17667-70-kXXsbNIxVm@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17667

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to master
         Version(s)|                            |20.05.00
        released in|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 20 15:01:49 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 20 Jan 2020 14:01:49 +0000
Subject: [Koha-bugs] [Bug 17667] Standing orders - cancelling a receipt
 increase the original quantity
In-Reply-To: <bug-17667-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17667-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17667-70-l0tpYIXH4E@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17667

--- Comment #12 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Nice work everyone!

Pushed to master for 20.05

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 20 15:02:44 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 20 Jan 2020 14:02:44 +0000
Subject: [Koha-bugs] [Bug 24461] New: Add to_api_mapping to
 Koha::Acquisition::BasketGroup
Message-ID: <bug-24461-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24461

            Bug ID: 24461
           Summary: Add to_api_mapping to Koha::Acquisition::BasketGroup
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: REST API
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: tomascohen at gmail.com

We need those mappings for the API.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 20 15:04:08 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 20 Jan 2020 14:04:08 +0000
Subject: [Koha-bugs] [Bug 16683] Help links to fields 59X in cataloguing
 form are broken
In-Reply-To: <bug-16683-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16683-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16683-70-hnCQRogWhW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16683

--- Comment #6 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Nice work everyone!

Pushed to master for 20.05

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 20 15:04:08 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 20 Jan 2020 14:04:08 +0000
Subject: [Koha-bugs] [Bug 20212] Slowness in Receiving in Acquisitions
In-Reply-To: <bug-20212-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20212-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20212-70-DEan2EYeDb@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20212

Nicolas Legrand <nicolas.legrand at bulac.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |nicolas.legrand at bulac.fr

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 20 15:04:11 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 20 Jan 2020 14:04:11 +0000
Subject: [Koha-bugs] [Bug 17667] Standing orders - cancelling a receipt
 increase the original quantity
In-Reply-To: <bug-17667-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17667-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17667-70-hOnefb8zRi@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17667

--- Comment #13 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Nice work everyone!

Pushed to master for 20.05

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 20 15:04:13 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 20 Jan 2020 14:04:13 +0000
Subject: [Koha-bugs] [Bug 21296] Suspend hold ignores system preference on
 intranet
In-Reply-To: <bug-21296-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21296-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21296-70-TUwkOt5jNf@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21296

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to master
         Version(s)|                            |20.05.00
        released in|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 20 15:04:15 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 20 Jan 2020 14:04:15 +0000
Subject: [Koha-bugs] [Bug 21296] Suspend hold ignores system preference on
 intranet
In-Reply-To: <bug-21296-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21296-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21296-70-EY53K2Dqtx@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21296

--- Comment #4 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Nice work everyone!

Pushed to master for 20.05

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 20 15:04:18 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 20 Jan 2020 14:04:18 +0000
Subject: [Koha-bugs] [Bug 21520] More complex OAI sets mappings
In-Reply-To: <bug-21520-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21520-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21520-70-pbF708k9CP@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21520

--- Comment #18 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Nice work everyone!

Pushed to master for 20.05

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 20 15:04:20 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 20 Jan 2020 14:04:20 +0000
Subject: [Koha-bugs] [Bug 22220] Error in ReWriteRule for 'bib' in
 apache-shared-intranet.conf
In-Reply-To: <bug-22220-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22220-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22220-70-L8PiZljETr@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22220

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to master
         Version(s)|                            |20.05.00
        released in|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 20 15:04:22 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 20 Jan 2020 14:04:22 +0000
Subject: [Koha-bugs] [Bug 22220] Error in ReWriteRule for 'bib' in
 apache-shared-intranet.conf
In-Reply-To: <bug-22220-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22220-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22220-70-GozVesEw52@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22220

--- Comment #6 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Nice work everyone!

Pushed to master for 20.05

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 20 15:04:24 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 20 Jan 2020 14:04:24 +0000
Subject: [Koha-bugs] [Bug 24008] Attempting to delete a patron with
 outstanding credits should warn and block the deletion
In-Reply-To: <bug-24008-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24008-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24008-70-j63xSGlpRQ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24008

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|                            |20.05.00
        released in|                            |
             Status|Passed QA                   |Pushed to master

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 20 15:04:26 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 20 Jan 2020 14:04:26 +0000
Subject: [Koha-bugs] [Bug 24008] Attempting to delete a patron with
 outstanding credits should warn and block the deletion
In-Reply-To: <bug-24008-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24008-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24008-70-O17caDAwd6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24008

--- Comment #18 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Nice work everyone!

Pushed to master for 20.05

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 20 15:04:28 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 20 Jan 2020 14:04:28 +0000
Subject: [Koha-bugs] [Bug 24018] No need to die "Not logged in"
In-Reply-To: <bug-24018-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24018-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24018-70-XIasBM8i7c@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24018

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|                            |20.05.00
        released in|                            |
             Status|Passed QA                   |Pushed to master

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 20 15:04:30 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 20 Jan 2020 14:04:30 +0000
Subject: [Koha-bugs] [Bug 24018] No need to die "Not logged in"
In-Reply-To: <bug-24018-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24018-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24018-70-MuFjVricxB@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24018

--- Comment #7 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Nice work everyone!

Pushed to master for 20.05

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 20 15:04:32 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 20 Jan 2020 14:04:32 +0000
Subject: [Koha-bugs] [Bug 24061] Print List (opac-shelves.pl) broken in
 Chrome
In-Reply-To: <bug-24061-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24061-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24061-70-kZgeq0t1x2@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24061

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to master
         Version(s)|                            |20.05.00
        released in|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 20 15:04:33 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 20 Jan 2020 14:04:33 +0000
Subject: [Koha-bugs] [Bug 24061] Print List (opac-shelves.pl) broken in
 Chrome
In-Reply-To: <bug-24061-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24061-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24061-70-xZwYc8qziT@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24061

--- Comment #33 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Nice work everyone!

Pushed to master for 20.05

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 20 15:04:35 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 20 Jan 2020 14:04:35 +0000
Subject: [Koha-bugs] [Bug 24214] Due date displayed in ISO format (when
 sticky)
In-Reply-To: <bug-24214-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24214-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24214-70-ARcFdozWaw@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24214

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to master
         Version(s)|                            |20.05.00
        released in|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 20 15:04:37 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 20 Jan 2020 14:04:37 +0000
Subject: [Koha-bugs] [Bug 24214] Due date displayed in ISO format (when
 sticky)
In-Reply-To: <bug-24214-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24214-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24214-70-FZilQ4mCg2@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24214

--- Comment #4 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Nice work everyone!

Pushed to master for 20.05

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 20 15:04:39 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 20 Jan 2020 14:04:39 +0000
Subject: [Koha-bugs] [Bug 24289] Deleting branch will not delete entry in
 special or repeatable holidays
In-Reply-To: <bug-24289-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24289-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24289-70-vOwQ4I0S5v@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24289

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to master
         Version(s)|                            |20.05.00
        released in|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 20 15:04:41 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 20 Jan 2020 14:04:41 +0000
Subject: [Koha-bugs] [Bug 24289] Deleting branch will not delete entry in
 special or repeatable holidays
In-Reply-To: <bug-24289-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24289-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24289-70-clulgQZL9x@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24289

--- Comment #11 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Nice work everyone!

Pushed to master for 20.05

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 20 15:04:47 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 20 Jan 2020 14:04:47 +0000
Subject: [Koha-bugs] [Bug 24341] Allow for more complex markup in OPAC
 confirmation dialogs
In-Reply-To: <bug-24341-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24341-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24341-70-boCS5Ss9rt@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24341

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to master
         Version(s)|                            |20.05.00
        released in|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 20 15:04:49 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 20 Jan 2020 14:04:49 +0000
Subject: [Koha-bugs] [Bug 24341] Allow for more complex markup in OPAC
 confirmation dialogs
In-Reply-To: <bug-24341-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24341-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24341-70-fwKXlO48aB@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24341

--- Comment #7 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Nice work everyone!

Pushed to master for 20.05

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 20 15:04:50 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 20 Jan 2020 14:04:50 +0000
Subject: [Koha-bugs] [Bug 24393] Remove event attributes from patron clubs
 list template
In-Reply-To: <bug-24393-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24393-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24393-70-n3HoSMzTA0@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24393

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to master
         Version(s)|                            |20.05.00
        released in|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 20 15:04:52 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 20 Jan 2020 14:04:52 +0000
Subject: [Koha-bugs] [Bug 24393] Remove event attributes from patron clubs
 list template
In-Reply-To: <bug-24393-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24393-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24393-70-EU7tmzg4X0@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24393

--- Comment #7 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Nice work everyone!

Pushed to master for 20.05

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 20 15:04:54 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 20 Jan 2020 14:04:54 +0000
Subject: [Koha-bugs] [Bug 24395] Floats in cash registers have 6 decimals
In-Reply-To: <bug-24395-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24395-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24395-70-os2C0FE5t4@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24395

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to master
         Version(s)|                            |20.05.00
        released in|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 20 15:04:56 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 20 Jan 2020 14:04:56 +0000
Subject: [Koha-bugs] [Bug 24395] Floats in cash registers have 6 decimals
In-Reply-To: <bug-24395-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24395-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24395-70-022istMRKF@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24395

--- Comment #8 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Nice work everyone!

Pushed to master for 20.05

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 20 15:04:58 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 20 Jan 2020 14:04:58 +0000
Subject: [Koha-bugs] [Bug 24404] Add missing space on invoices page
In-Reply-To: <bug-24404-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24404-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24404-70-k4xKu8lmV5@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24404

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to master
         Version(s)|                            |20.05.00
        released in|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 20 15:05:00 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 20 Jan 2020 14:05:00 +0000
Subject: [Koha-bugs] [Bug 24404] Add missing space on invoices page
In-Reply-To: <bug-24404-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24404-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24404-70-3t07e6vZQI@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24404

--- Comment #4 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Nice work everyone!

Pushed to master for 20.05

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 20 15:05:01 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 20 Jan 2020 14:05:01 +0000
Subject: [Koha-bugs] [Bug 24423] Broken link to return to record after batch
 item modification
In-Reply-To: <bug-24423-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24423-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24423-70-CK3FLy5oWx@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24423

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|                            |20.05.00
        released in|                            |
             Status|Passed QA                   |Pushed to master

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 20 15:05:03 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 20 Jan 2020 14:05:03 +0000
Subject: [Koha-bugs] [Bug 24423] Broken link to return to record after batch
 item modification
In-Reply-To: <bug-24423-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24423-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24423-70-nI4zjHjGRH@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24423

--- Comment #9 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Nice work everyone!

Pushed to master for 20.05

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 20 15:05:05 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 20 Jan 2020 14:05:05 +0000
Subject: [Koha-bugs] [Bug 24433] OPAC account page no longer asks for
 confirmation before deleting hold
In-Reply-To: <bug-24433-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24433-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24433-70-EK5qVbxaBe@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24433

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|                            |20.05.00
        released in|                            |
             Status|Passed QA                   |Pushed to master

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 20 15:05:07 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 20 Jan 2020 14:05:07 +0000
Subject: [Koha-bugs] [Bug 24433] OPAC account page no longer asks for
 confirmation before deleting hold
In-Reply-To: <bug-24433-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24433-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24433-70-4DBmOaaAuF@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24433

--- Comment #4 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Nice work everyone!

Pushed to master for 20.05

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 20 15:06:16 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 20 Jan 2020 14:06:16 +0000
Subject: [Koha-bugs] [Bug 24461] Add to_api_mapping to
 Koha::Acquisition::BasketGroup
In-Reply-To: <bug-24461-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24461-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24461-70-AXCyyxHf6D@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24461

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |tomascohen at gmail.com
                   |ity.org                     |
             Blocks|                            |20212


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20212
[Bug 20212] Slowness in Receiving in Acquisitions
-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 20 15:06:16 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 20 Jan 2020 14:06:16 +0000
Subject: [Koha-bugs] [Bug 20212] Slowness in Receiving in Acquisitions
In-Reply-To: <bug-20212-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20212-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20212-70-uuwk7gwfIM@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20212

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |24461


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24461
[Bug 24461] Add to_api_mapping to Koha::Acquisition::BasketGroup
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 20 15:09:48 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 20 Jan 2020 14:09:48 +0000
Subject: [Koha-bugs] [Bug 24461] Add to_api_mapping to
 Koha::Acquisition::BasketGroup
In-Reply-To: <bug-24461-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24461-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24461-70-QKEbPEqFcf@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24461

--- Comment #1 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 97623
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97623&action=edit
Bug 24461: Add to_api_mapping to Koha::Acquisition::BasketGroup

This patch adds to_api_mapping to the Koha::Acquistion::BasketGroup
class.

To test:
1. Compare the mapping with the one on the RFC
=> SUCCESS: They match
2. Sigh off :-D

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 20 15:11:46 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 20 Jan 2020 14:11:46 +0000
Subject: [Koha-bugs] [Bug 24461] Add to_api_mapping to
 Koha::Acquisition::BasketGroup
In-Reply-To: <bug-24461-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24461-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24461-70-IDurN7Q95f@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24461

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Trivial patch
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 20 15:15:57 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 20 Jan 2020 14:15:57 +0000
Subject: [Koha-bugs] [Bug 24461] Add to_api_mapping to
 Koha::Acquisition::BasketGroup
In-Reply-To: <bug-24461-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24461-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24461-70-aT5FecjFaa@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24461

Nicolas Legrand <nicolas.legrand at bulac.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |nicolas.legrand at bulac.fr

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 20 15:16:02 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 20 Jan 2020 14:16:02 +0000
Subject: [Koha-bugs] [Bug 24448] Add Koha::Biblio->subscriptions_count
In-Reply-To: <bug-24448-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24448-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24448-70-QkXlzs1XxQ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24448

Nicolas Legrand <nicolas.legrand at bulac.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |nicolas.legrand at bulac.fr

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 20 15:16:07 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 20 Jan 2020 14:16:07 +0000
Subject: [Koha-bugs] [Bug 24440] Add ->holds and ->holds_count to
 Koha::Acquisition::Order
In-Reply-To: <bug-24440-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24440-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24440-70-FLDF3DV2Xe@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24440

Nicolas Legrand <nicolas.legrand at bulac.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |nicolas.legrand at bulac.fr

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 20 15:16:13 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 20 Jan 2020 14:16:13 +0000
Subject: [Koha-bugs] [Bug 24457] K::A::Basket->to_api is not passing the
 parameters to the parent class implementation
In-Reply-To: <bug-24457-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24457-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24457-70-VYgYc5omMo@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24457

Nicolas Legrand <nicolas.legrand at bulac.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |nicolas.legrand at bulac.fr

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 20 15:16:20 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 20 Jan 2020 14:16:20 +0000
Subject: [Koha-bugs] [Bug 24430] Remove C4::Biblio::CountBiblioInOrders
In-Reply-To: <bug-24430-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24430-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24430-70-DbwjcbRdk3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24430

Nicolas Legrand <nicolas.legrand at bulac.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |nicolas.legrand at bulac.fr

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 20 15:28:11 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 20 Jan 2020 14:28:11 +0000
Subject: [Koha-bugs] [Bug 24462] New: Adjust K::A::Invoice API mapping to
 voted RFC
Message-ID: <bug-24462-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24462

            Bug ID: 24462
           Summary: Adjust K::A::Invoice API mapping to voted RFC
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: REST API
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: tomascohen at gmail.com

Now it has been voted, it needs to be adjusted.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 20 15:28:46 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 20 Jan 2020 14:28:46 +0000
Subject: [Koha-bugs] [Bug 24462] Adjust K::A::Invoice API mapping to voted
 RFC
In-Reply-To: <bug-24462-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24462-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24462-70-lLPwCqkWMx@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24462

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Trivial patch
         Depends on|                            |18731
           Assignee|koha-bugs at lists.koha-commun |tomascohen at gmail.com
                   |ity.org                     |
                URL|                            |https://wiki.koha-community
                   |                            |.org/wiki/Acquisitions_invo
                   |                            |ices_endpoint_RFC
             Status|NEW                         |Needs Signoff
             Blocks|                            |20212


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18731
[Bug 18731] Add routes for acquisition orders
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20212
[Bug 20212] Slowness in Receiving in Acquisitions
-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 20 15:28:46 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 20 Jan 2020 14:28:46 +0000
Subject: [Koha-bugs] [Bug 18731] Add routes for acquisition orders
In-Reply-To: <bug-18731-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18731-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18731-70-Wi9NgJosll@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18731

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |24462


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24462
[Bug 24462] Adjust K::A::Invoice API mapping to voted RFC
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 20 15:28:46 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 20 Jan 2020 14:28:46 +0000
Subject: [Koha-bugs] [Bug 20212] Slowness in Receiving in Acquisitions
In-Reply-To: <bug-20212-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20212-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20212-70-fwLWHTcCGI@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20212

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |24462


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24462
[Bug 24462] Adjust K::A::Invoice API mapping to voted RFC
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 20 15:30:33 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 20 Jan 2020 14:30:33 +0000
Subject: [Koha-bugs] [Bug 24462] Adjust K::A::Invoice API mapping to voted
 RFC
In-Reply-To: <bug-24462-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24462-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24462-70-qtgArPCwDG@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24462

--- Comment #1 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 97624
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97624&action=edit
Bug 24462: Adapt mapping to voted RFC (Invoices)

This trivial patch changes the attribute names for API reprensentation
of Koha::Acquisition::Invoice objects.

To test:
1. Open https://wiki.koha-community.org/wiki/Acquisitions_invoices_endpoint_RFC
2. Check the mappings are correct
=> SUCCESS: The patch makes the right changes to the mappings
3. Sign off :-D

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 20 15:30:41 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 20 Jan 2020 14:30:41 +0000
Subject: [Koha-bugs] [Bug 23702] New UNIMARC XSLT according to last IFLA
 updates
In-Reply-To: <bug-23702-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23702-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23702-70-xgWQrLySe5@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23702

--- Comment #22 from delaye <stephane.delaye at biblibre.com> ---
Created attachment 97625
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97625&action=edit
OPAX -xslt utils

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 20 15:30:58 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 20 Jan 2020 14:30:58 +0000
Subject: [Koha-bugs] [Bug 24462] Adjust K::A::Invoice API mapping to voted
 RFC
In-Reply-To: <bug-24462-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24462-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24462-70-5tSQCegJuR@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24462

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de,
                   |                            |td-koha-bugs at agogme.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 20 15:31:12 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 20 Jan 2020 14:31:12 +0000
Subject: [Koha-bugs] [Bug 24462] Adjust K::A::Invoice API mapping to voted
 RFC
In-Reply-To: <bug-24462-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24462-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24462-70-w6YDbGFqlU@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24462

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |martin.renvoize at ptfs-europe
                   |                            |.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 20 15:46:39 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 20 Jan 2020 14:46:39 +0000
Subject: [Koha-bugs] [Bug 24462] Adjust K::A::Invoice API mapping to voted
 RFC
In-Reply-To: <bug-24462-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24462-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24462-70-fTf4UyAshF@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24462

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |nicolas.legrand at bulac.fr

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 20 15:46:49 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 20 Jan 2020 14:46:49 +0000
Subject: [Koha-bugs] [Bug 20888] Allow use of boolean operator 'not' in item
 search
In-Reply-To: <bug-20888-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20888-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20888-70-BSOfKQf0Ql@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20888

--- Comment #22 from Matthias Meusburger <matthias.meusburger at biblibre.com> ---
Created attachment 97626
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97626&action=edit
Bug 20888: Follow-up: 'is not' operator behaves as 'not like'

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 20 15:48:02 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 20 Jan 2020 14:48:02 +0000
Subject: [Koha-bugs] [Bug 20888] Allow use of boolean operator 'not' in item
 search
In-Reply-To: <bug-20888-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20888-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20888-70-954FW8yNbS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20888

--- Comment #23 from Matthias Meusburger <matthias.meusburger at biblibre.com> ---
Katrin, here's the modification you asked for: 'is not' now behaves like 'not
like' (just like 'is' behaves like 'like')

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 20 15:48:30 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 20 Jan 2020 14:48:30 +0000
Subject: [Koha-bugs] [Bug 20888] Allow use of boolean operator 'not' in item
 search
In-Reply-To: <bug-20888-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20888-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20888-70-LOpIyHmSo8@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20888

--- Comment #24 from Matthias Meusburger <matthias.meusburger at biblibre.com> ---
Created attachment 97627
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97627&action=edit
Bug 20888: Follow-up: revert unecessary change on jquery selector

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 20 15:49:15 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 20 Jan 2020 14:49:15 +0000
Subject: [Koha-bugs] [Bug 20888] Allow use of boolean operator 'not' in item
 search
In-Reply-To: <bug-20888-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20888-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20888-70-FT6b6G20Tb@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20888

--- Comment #25 from Matthias Meusburger <matthias.meusburger at biblibre.com> ---
Frido, you were right, this change was unnecessary and has been reverted.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 20 15:49:33 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 20 Jan 2020 14:49:33 +0000
Subject: [Koha-bugs] [Bug 20888] Allow use of boolean operator 'not' in item
 search
In-Reply-To: <bug-20888-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20888-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20888-70-oomrRTNLjJ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20888

Matthias Meusburger <matthias.meusburger at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 20 15:53:41 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 20 Jan 2020 14:53:41 +0000
Subject: [Koha-bugs] [Bug 24463] New: Consistent accessor-relationship
 naming for basket_group in Basket.pm
Message-ID: <bug-24463-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24463

            Bug ID: 24463
           Summary: Consistent accessor-relationship naming for
                    basket_group in Basket.pm
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Architecture, internals, and plumbing
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: tomascohen at gmail.com
        QA Contact: testopia at bugs.koha-community.org

We agreed there needs to be consistency. This will be a blocker for dealing
with related data from the API (prefetching, filternig, etC).

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 20 15:54:40 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 20 Jan 2020 14:54:40 +0000
Subject: [Koha-bugs] [Bug 24463] Consistent accessor-relationship naming for
 basket_group in Basket.pm
In-Reply-To: <bug-24463-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24463-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24463-70-vbhS4zwuvm@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24463

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Trivial patch
             Status|NEW                         |ASSIGNED
           Assignee|koha-bugs at lists.koha-commun |tomascohen at gmail.com
                   |ity.org                     |

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 20 15:58:22 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 20 Jan 2020 14:58:22 +0000
Subject: [Koha-bugs] [Bug 24463] Consistent accessor-relationship naming for
 basket_group in Basket.pm
In-Reply-To: <bug-24463-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24463-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24463-70-lKvsxeurV9@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24463

--- Comment #1 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 97628
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97628&action=edit
Bug 24463: Add a basket_group relationship for baskets

This patch aims to bring consistency between the accessor name and the
underlying relationship to ease things when using it from the API.

To test:
1. Apply this patch
2. Run:
   $ kshell
  k$ prove t/db_dependent/Koha/Acquisition/Basket.t
=> SUCCESS: Tests pass! No behavior change!
3. Sign off :-D

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 20 15:58:48 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 20 Jan 2020 14:58:48 +0000
Subject: [Koha-bugs] [Bug 24463] Consistent accessor-relationship naming for
 basket_group in Basket.pm
In-Reply-To: <bug-24463-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24463-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24463-70-HDWqNjfG4t@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24463

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 20 16:52:24 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 20 Jan 2020 15:52:24 +0000
Subject: [Koha-bugs] [Bug 20212] Slowness in Receiving in Acquisitions
In-Reply-To: <bug-20212-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20212-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20212-70-h6asb5deXY@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20212

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #97546|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 20 16:52:27 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 20 Jan 2020 15:52:27 +0000
Subject: [Koha-bugs] [Bug 20212] Slowness in Receiving in Acquisitions
In-Reply-To: <bug-20212-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20212-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20212-70-sTXHYqNoXP@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20212

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #97547|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 20 16:52:48 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 20 Jan 2020 15:52:48 +0000
Subject: [Koha-bugs] [Bug 20212] Slowness in Receiving in Acquisitions
In-Reply-To: <bug-20212-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20212-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20212-70-Gck6w4OKin@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20212

--- Comment #11 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 97629
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97629&action=edit
Bug 20212: Add more embeddable objects to orders

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 20 16:52:52 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 20 Jan 2020 15:52:52 +0000
Subject: [Koha-bugs] [Bug 20212] Slowness in Receiving in Acquisitions
In-Reply-To: <bug-20212-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20212-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20212-70-ts17lC4bHf@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20212

--- Comment #12 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 97630
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97630&action=edit
[WIP] Bug 20212: Use the API to render orders

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 20 16:54:19 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 20 Jan 2020 15:54:19 +0000
Subject: [Koha-bugs] [Bug 20212] Slowness in Receiving in Acquisitions
In-Reply-To: <bug-20212-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20212-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20212-70-gdeHk1HZvR@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20212

--- Comment #13 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Ok, this last version of the patchset completely implements the table. It is
only missing the search boxes which are not trivial to implement. More on that
soon.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 20 17:12:09 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 20 Jan 2020 16:12:09 +0000
Subject: [Koha-bugs] [Bug 23753] Background job JavaScript should not try to
 call humanMsg library
In-Reply-To: <bug-23753-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23753-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23753-70-etOkJsaS7P@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23753

Cori Lynn Arnold <carnold at dgiinc.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |carnold at dgiinc.com
             Status|Needs Signoff               |Failed QA

--- Comment #2 from Cori Lynn Arnold <carnold at dgiinc.com> ---

I tested these and they worked as expected with the alert:

Tools -> Batch record modification
Tools -> Batch item modification
Tools -> Stage MARC records for import
Tools -> Staged MARC record management

I did *not* get an alert for the following interfaces:

Tools -> Upload local cover image
Circulation -> Upload offline circulation data (but I wasn't giving it a real
file... if it needs a real-ish file, can you provide a test one that I can
manipulate?)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 20 17:24:56 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 20 Jan 2020 16:24:56 +0000
Subject: [Koha-bugs] [Bug 22831] Elasticsearch - add a maintenance script
 for checking DB vs index counts
In-Reply-To: <bug-22831-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22831-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22831-70-VbaiRP5Jl3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22831

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |martin.renvoize at ptfs-europe
                   |                            |.com

--- Comment #26 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Haha, I agree.. I would have preferred not to add a new dependancy...
especially as it doesn't appear to be packaged for Jessie (having said that..
we are dropping supoprt for Jessie with 20.05 and this is an enhancement so
that shouldn't be a problem).

However.. I am wondering a little about the code having had a little read.

You seem to do an array_diff and then two more iterations to catch where the
diffs came from.. couldn't you have just done two array_minus calls (from the
same module) to directly get the two different types of problem and saved
yourself a loop and a few lines of code?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 20 17:34:09 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 20 Jan 2020 16:34:09 +0000
Subject: [Koha-bugs] [Bug 12502] Add columns for note,
 order number and ISBN to late orders page
In-Reply-To: <bug-12502-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-12502-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12502-70-LoM7PeaAOp@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12502

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|                            |20.05.00
        released in|                            |
             Status|Passed QA                   |Pushed to master

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 20 17:34:11 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 20 Jan 2020 16:34:11 +0000
Subject: [Koha-bugs] [Bug 12502] Add columns for note,
 order number and ISBN to late orders page
In-Reply-To: <bug-12502-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-12502-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12502-70-8eYjGUXy5V@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12502

--- Comment #51 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Nice work everyone!

Pushed to master for 20.05

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 20 17:34:14 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 20 Jan 2020 16:34:14 +0000
Subject: [Koha-bugs] [Bug 15686] Rename "item level holds" circ rule column
 to "OPAC item level holds"
In-Reply-To: <bug-15686-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15686-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15686-70-oe4Bu0Q8DK@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15686

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to master
         Version(s)|                            |20.05.00
        released in|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 20 17:34:16 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 20 Jan 2020 16:34:16 +0000
Subject: [Koha-bugs] [Bug 15686] Rename "item level holds" circ rule column
 to "OPAC item level holds"
In-Reply-To: <bug-15686-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15686-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15686-70-sXJzRu4F4Z@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15686

--- Comment #7 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Nice work everyone!

Pushed to master for 20.05

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 20 17:34:17 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 20 Jan 2020 16:34:17 +0000
Subject: [Koha-bugs] [Bug 16784] Add table configuration on suggestions table
In-Reply-To: <bug-16784-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16784-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16784-70-Kn6EhVijvL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16784

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to master
         Version(s)|                            |20.05.00
        released in|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 20 17:34:19 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 20 Jan 2020 16:34:19 +0000
Subject: [Koha-bugs] [Bug 16784] Add table configuration on suggestions table
In-Reply-To: <bug-16784-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16784-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16784-70-zgLJLseSpR@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16784

--- Comment #11 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Nice work everyone!

Pushed to master for 20.05

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 20 17:34:21 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 20 Jan 2020 16:34:21 +0000
Subject: [Koha-bugs] [Bug 24343] Show subtitle,
 number and parts in course reserves list of titles in staff client
In-Reply-To: <bug-24343-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24343-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24343-70-kvlHkSONsx@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24343

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to master
         Version(s)|                            |20.05.00
        released in|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 20 17:34:23 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 20 Jan 2020 16:34:23 +0000
Subject: [Koha-bugs] [Bug 24343] Show subtitle,
 number and parts in course reserves list of titles in staff client
In-Reply-To: <bug-24343-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24343-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24343-70-vk2Eo9f9fn@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24343

--- Comment #5 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Nice work everyone!

Pushed to master for 20.05

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 20 17:34:25 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 20 Jan 2020 16:34:25 +0000
Subject: [Koha-bugs] [Bug 24344] Modify OPAC link to suggest existing record
 for purchase
In-Reply-To: <bug-24344-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24344-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24344-70-jOJX6ZspoT@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24344

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to master
         Version(s)|                            |20.05.00
        released in|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 20 17:34:26 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 20 Jan 2020 16:34:26 +0000
Subject: [Koha-bugs] [Bug 24344] Modify OPAC link to suggest existing record
 for purchase
In-Reply-To: <bug-24344-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24344-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24344-70-hUaWIq2cEy@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24344

--- Comment #4 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Nice work everyone!

Pushed to master for 20.05

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 20 17:34:28 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 20 Jan 2020 16:34:28 +0000
Subject: [Koha-bugs] [Bug 24418] Add Koha::Biblio->suggestions
In-Reply-To: <bug-24418-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24418-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24418-70-ygkQw0wEUe@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24418

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to master
         Version(s)|                            |20.05.00
        released in|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 20 17:34:29 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 20 Jan 2020 16:34:29 +0000
Subject: [Koha-bugs] [Bug 24418] Add Koha::Biblio->suggestions
In-Reply-To: <bug-24418-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24418-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24418-70-1OxiYQI6cz@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24418

--- Comment #12 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Nice work everyone!

Pushed to master for 20.05

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 20 17:34:31 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 20 Jan 2020 16:34:31 +0000
Subject: [Koha-bugs] [Bug 24419] Add Koha::Suggestion->suggester accessor
In-Reply-To: <bug-24419-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24419-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24419-70-XXkAz7krn4@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24419

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|                            |20.05.00
        released in|                            |
             Status|Passed QA                   |Pushed to master

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 20 17:34:33 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 20 Jan 2020 16:34:33 +0000
Subject: [Koha-bugs] [Bug 24419] Add Koha::Suggestion->suggester accessor
In-Reply-To: <bug-24419-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24419-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24419-70-kXUzx4afLT@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24419

--- Comment #8 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Nice work everyone!

Pushed to master for 20.05

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 20 19:58:51 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 20 Jan 2020 18:58:51 +0000
Subject: [Koha-bugs] [Bug 24464] New: Add K::A::Basket->creator
Message-ID: <bug-24464-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24464

            Bug ID: 24464
           Summary: Add K::A::Basket->creator
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: REST API
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: tomascohen at gmail.com

We need an accessor to fetch the Koha::Patron for the basket creator (a.k.a.
authorisedby on the DB).

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 20 19:59:30 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 20 Jan 2020 18:59:30 +0000
Subject: [Koha-bugs] [Bug 24464] Add K::A::Basket->creator
In-Reply-To: <bug-24464-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24464-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24464-70-C4vC3xKWGh@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24464

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff
           Assignee|koha-bugs at lists.koha-commun |tomascohen at gmail.com
                   |ity.org                     |
         Depends on|                            |24463
             Blocks|                            |20212


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20212
[Bug 20212] Slowness in Receiving in Acquisitions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24463
[Bug 24463] Consistent accessor-relationship naming for basket_group in
Basket.pm
-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 20 19:59:30 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 20 Jan 2020 18:59:30 +0000
Subject: [Koha-bugs] [Bug 20212] Slowness in Receiving in Acquisitions
In-Reply-To: <bug-20212-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20212-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20212-70-E3m8uH9JF5@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20212

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |24464


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24464
[Bug 24464] Add K::A::Basket->creator
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 20 19:59:30 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 20 Jan 2020 18:59:30 +0000
Subject: [Koha-bugs] [Bug 24463] Consistent accessor-relationship naming for
 basket_group in Basket.pm
In-Reply-To: <bug-24463-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24463-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24463-70-G6PA762nOu@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24463

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |24464


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24464
[Bug 24464] Add K::A::Basket->creator
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 20 20:03:22 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 20 Jan 2020 19:03:22 +0000
Subject: [Koha-bugs] [Bug 24464] Add K::A::Basket->creator
In-Reply-To: <bug-24464-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24464-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24464-70-uZ1uJfgE7D@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24464

--- Comment #1 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 97631
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97631&action=edit
Bug 24464: Unit tests

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 20 20:03:25 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 20 Jan 2020 19:03:25 +0000
Subject: [Koha-bugs] [Bug 24464] Add K::A::Basket->creator
In-Reply-To: <bug-24464-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24464-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24464-70-w1NW54XFqX@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24464

--- Comment #2 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 97632
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97632&action=edit
Bug 24464: Add K::A::Basket->creator

This patch adds a ->creator method to Koha::Acquisition::Basket to
retrieve the related Koha::Patron object.

Note: this should be re-done once 22658 is pushed, but at the time
being, there's not patch submitted, and it is not a trivial task because
of the column type missmatch. That said, the implementation of ->creator
in this class is simple enough to just rewrite it once 22658 is
submitted, and the tests will reflect the expected/unchanged behavior.

To test:
1. Apply this patches
2. Run:
   $ kshell
  k$ prove t/db_dependent/Koha/Acquisition/Basket.t
=> SUCCESS: Tests pass!
3. Sign off :-D

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 20 20:19:18 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 20 Jan 2020 19:19:18 +0000
Subject: [Koha-bugs] [Bug 20212] Slowness in Receiving in Acquisitions
In-Reply-To: <bug-20212-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20212-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20212-70-uTOjfrEsuU@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20212

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #97629|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 20 20:19:20 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 20 Jan 2020 19:19:20 +0000
Subject: [Koha-bugs] [Bug 20212] Slowness in Receiving in Acquisitions
In-Reply-To: <bug-20212-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20212-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20212-70-QbsguBqAJB@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20212

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #97630|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 20 20:20:09 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 20 Jan 2020 19:20:09 +0000
Subject: [Koha-bugs] [Bug 20212] Slowness in Receiving in Acquisitions
In-Reply-To: <bug-20212-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20212-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20212-70-aMVPHoqOQh@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20212

--- Comment #14 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 97633
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97633&action=edit
Bug 20212: Add more embeddable objects to orders

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 20 20:20:14 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 20 Jan 2020 19:20:14 +0000
Subject: [Koha-bugs] [Bug 20212] Slowness in Receiving in Acquisitions
In-Reply-To: <bug-20212-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20212-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20212-70-7GfJn4AsZm@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20212

--- Comment #15 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 97634
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97634&action=edit
[WIP] Bug 20212: Use the API to render orders

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 20 20:23:54 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 20 Jan 2020 19:23:54 +0000
Subject: [Koha-bugs] [Bug 22658] aqbasket.authorisedby is missing a foreign
 key constraint
In-Reply-To: <bug-22658-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22658-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22658-70-JGRF6nOMSx@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22658

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |tomascohen at gmail.com

--- Comment #1 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
I propose we create a new column: creator_id INT(11) NULL DEFAULT NULL, with FK
constraint on the borrowers table, and we move/copy there the values of
authorisedby that look like a number. If there's no remaining value on
authorisedby, then drop the column. Otherwise, just leave it and print a
noticeable message about manually removing the column once inconsistencies are
solved.

I haven't found references to the column in contexts in which it is not tested
against the borrowers.borrowernumber column, but there might be old/legacy data
there, or I'm sure Jonathan will find that spot I missed.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 20 20:27:09 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 20 Jan 2020 19:27:09 +0000
Subject: [Koha-bugs] [Bug 22658] aqbasket.authorisedby is missing a foreign
 key constraint
In-Reply-To: <bug-22658-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22658-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22658-70-wCKBLstVtA@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22658

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org,
                   |                            |kyle.m.hall at gmail.com,
                   |                            |nick at bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 20 21:01:10 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 20 Jan 2020 20:01:10 +0000
Subject: [Koha-bugs] [Bug 20212] Slowness in Receiving in Acquisitions
In-Reply-To: <bug-20212-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20212-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20212-70-D9xwFxjtY7@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20212

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #97634|0                           |1
        is obsolete|                            |

--- Comment #16 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 97635
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97635&action=edit
[WIP] Bug 20212: Use the API to render orders

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 20 22:01:13 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 20 Jan 2020 21:01:13 +0000
Subject: [Koha-bugs] [Bug 3426] Change itemcallnumber system preference to
 allow multiple tags
In-Reply-To: <bug-3426-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-3426-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-3426-70-wRhNNrsrqt@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3426

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 20 22:01:17 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 20 Jan 2020 21:01:17 +0000
Subject: [Koha-bugs] [Bug 3426] Change itemcallnumber system preference to
 allow multiple tags
In-Reply-To: <bug-3426-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-3426-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-3426-70-ND0cvC6OPU@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3426

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #96559|0                           |1
        is obsolete|                            |

--- Comment #15 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 97636
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97636&action=edit
Bug 3426: Allow for multiple fields in itemcallnumber syspref

Note that we change both cataloguing/additem.pl and
C4/Items->PrepareItemrecordfordisplay

I can find no code that uses callnumber from the C4/Items sub, except for the
itemrecorddisplay script
which is not called with an itemnumber from Koha and should be deprecated for
REST or ILSDI or OAI (imho)

To test:
 1 - Define itemcallnumber syspref as "082ab,092ab,9520,245a"
 2 - Find a record with no items
 3 - Ensure it has no 082 field, but an 092 field
 4 - Go to add an item - itemcallnumber is empty
 5 - Apply patch
 6 - Go to add item, itemcallnumber should be the 092ab fields
 7 - Delete the 092 field
 8 - Go to add item, itemcallnumber should be the 245a
 9 - Edit the callnumber to be "testing" and save item
10 - For should now show itemcallnumber="testing" as default
11 - Browse to
http://localhost:8081/cgi-bin/koha/services/itemrecorddisplay.pl?itemnumber=##
subbing the correct itemnumber
12 - Ensure the callnumber is defaulting to testing
13 - delete the item you created
14 - browse to URL above - callnumber should now be 245 again
15 - Add an 092 field to record and ensure it is now default callnumber
16 - Add an 082 field, it should now be default

Signed-off-by: Andrew Fuerste-Henry <andrew at bywatersolutions.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 20 22:01:23 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 20 Jan 2020 21:01:23 +0000
Subject: [Koha-bugs] [Bug 3426] Change itemcallnumber system preference to
 allow multiple tags
In-Reply-To: <bug-3426-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-3426-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-3426-70-CTZXoPWEdk@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3426

--- Comment #16 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 97637
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97637&action=edit
Bug 3426: Keep note about sequence of subfields

Bug 9156 changed the wording of the pref slightly to make it
clear that the subfield sequence of the record will be used,
not the sequence of the subfields defined in the pref.

This just reinstates the note:
The order of the subfields in the record will be preserved.

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 20 22:31:16 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 20 Jan 2020 21:31:16 +0000
Subject: [Koha-bugs] [Bug 24465] New: Label creator requires catalogue
 permission instead of label_creator permission from tools
Message-ID: <bug-24465-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24465

            Bug ID: 24465
           Summary: Label creator requires catalogue permission instead of
                    label_creator permission from tools
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: Tools
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: katrin.fischer at bsz-bw.de
        QA Contact: testopia at bugs.koha-community.org

Checking bug 7468 I noticed that all the templates in labels use the catalogue
permission instead of the expected tools->label_creator permission.

The permission description manages creating labels from patron and catalog
data, so it seems it should be used for the label creator?

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 20 22:35:06 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 20 Jan 2020 21:35:06 +0000
Subject: [Koha-bugs] [Bug 7468] Add label to batch by barcode range
In-Reply-To: <bug-7468-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-7468-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7468-70-aQHIVWV2Hg@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7468

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Small patch
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 20 22:35:11 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 20 Jan 2020 21:35:11 +0000
Subject: [Koha-bugs] [Bug 7468] Add label to batch by barcode range
In-Reply-To: <bug-7468-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-7468-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7468-70-K9YroKmKga@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7468

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #97551|0                           |1
        is obsolete|                            |

--- Comment #51 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 97638
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97638&action=edit
Bug 7468: Print barcodes by range

Adds an option to the label creator to print a range of barcodes.
Only allows printing to PDF.

C4/Label.pm had to get minor changes to override database-based barcode
generation. Same with labels/label-create-pdf.pl. By default, the
barcode is fetched from the database using the itemnumber, but when
printing ranges, you might not have a corresponding  database entry.

Signed-off-by: David Nind <david at davidnind.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 20 22:35:16 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 20 Jan 2020 21:35:16 +0000
Subject: [Koha-bugs] [Bug 7468] Add label to batch by barcode range
In-Reply-To: <bug-7468-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-7468-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7468-70-jbnMhZThou@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7468

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #97552|0                           |1
        is obsolete|                            |

--- Comment #52 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 97639
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97639&action=edit
Bug 7468: Fix 'false' message on Firefox

It seems I was using an href to a javascript function in the 'Print Range'
button, which Chrome didn't mind, but Firefox did understand.

Signed-off-by: David Nind <david at davidnind.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 20 22:35:21 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 20 Jan 2020 21:35:21 +0000
Subject: [Koha-bugs] [Bug 7468] Add label to batch by barcode range
In-Reply-To: <bug-7468-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-7468-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7468-70-nVtZ56abeZ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7468

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #97553|0                           |1
        is obsolete|                            |

--- Comment #53 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 97640
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97640&action=edit
Bug 7468: Add warning when range has non-existent barcodes

+ Added a warning when the user selects a range with some non-existent
barcodes, and a layout without barcodes.
This allows the user to print barcodes of items not in the database if he so
desires, but will warn him if he tries to print only biblios (which results in
missing entries or a blank page).

Signed-off-by: David Nind <david at davidnind.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 20 22:35:26 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 20 Jan 2020 21:35:26 +0000
Subject: [Koha-bugs] [Bug 7468] Add label to batch by barcode range
In-Reply-To: <bug-7468-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-7468-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7468-70-ThR41vZcQt@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7468

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #97554|0                           |1
        is obsolete|                            |

--- Comment #54 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 97641
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97641&action=edit
Bug 7468: Showing the error message according to the community interface
patterns, fixing a javascript condition

TEST PLAN++

1) Apply all the patches
2) Connect to the intranet with an account with permissions to visit the
"Tools" page
3) Go to /cgi-bin/koha/labels/label-home.pl
    . Either by entering the URL directly
    . OR, from the front page, by clicking "Tools", followed by the hyperlink
"Label creator" under the "Catalog" section
4) Under the "+ New" button, a new option should be available: "Barcode range"
5) Fill the "From:" and the "To:" fields of the "Print barcode range" form
    . Keeping both fields at "0" should trigger a warning beside the first
field: "*Cannot be smaller than 1"
    . If the value "From:" is greater the "To:" value, a warning should appear
beside the second field: "*Cannot be smaller than the starting value"
    . Make sure the form doesn't let you enter non-numerical values
    . For a casual test, use "From: 1000" and "To: 1100"
6) After pressing the "Print Range" button, choose a template, a layout, and a
starting position
    . The "DEFAULT TEMPLATE 01" has a page height of 5pt and a page width of
0pt, don't use it
    . All the default layouts should look alike, since we're only printing a
barcode over a number, and not bibliographic information
    . Using a layout not defined as 'Barcode' will show a warning message
7) Clicking the "Export" button should lead to a second dialog window with a
"Download as PDF" hyperlink. Clicking the link should prop up a download dialog
box
8) Save the PDF locally, or simply open it, and make sure the options you used
were taken into account

Signed-off-by: David Nind <david at davidnind.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 20 22:35:31 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 20 Jan 2020 21:35:31 +0000
Subject: [Koha-bugs] [Bug 7468] Add label to batch by barcode range
In-Reply-To: <bug-7468-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-7468-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7468-70-1W3Ex7Dxub@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7468

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #97555|0                           |1
        is obsolete|                            |

--- Comment #55 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 97642
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97642&action=edit
Bug 7468: (follow-up) Make sure only integers are accepted as from/to values

Signed-off-by: David Nind <david at davidnind.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 20 22:35:36 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 20 Jan 2020 21:35:36 +0000
Subject: [Koha-bugs] [Bug 7468] Add label to batch by barcode range
In-Reply-To: <bug-7468-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-7468-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7468-70-mtbCIkvplC@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7468

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #97556|0                           |1
        is obsolete|                            |

--- Comment #56 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 97643
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97643&action=edit
Bug 7468: (follow-up) fix label-edit-range template

Edit the labels/label-edit-range.tt template to follow current
standards :
    - Use footer javascript
    - Use bootstrap grid
    - Use jQuery Validation plugin for validation

Also fixes breadcrumbs to be more specific.

To test:
Make sure the page looks correct and still works as expected.

Signed-off-by: David Nind <david at davidnind.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 20 22:35:41 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 20 Jan 2020 21:35:41 +0000
Subject: [Koha-bugs] [Bug 7468] Add label to batch by barcode range
In-Reply-To: <bug-7468-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-7468-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7468-70-5wKP4txT3j@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7468

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #97557|0                           |1
        is obsolete|                            |

--- Comment #57 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 97644
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97644&action=edit
Bug 7468: (follow-up) Add missing filters

Signed-off-by: David Nind <david at davidnind.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 20 22:35:46 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 20 Jan 2020 21:35:46 +0000
Subject: [Koha-bugs] [Bug 7468] Add label to batch by barcode range
In-Reply-To: <bug-7468-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-7468-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7468-70-unheoHVG55@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7468

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #97558|0                           |1
        is obsolete|                            |

--- Comment #58 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 97645
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97645&action=edit
Bug 7468: fix the export labels popup header

When exporting a barcode range, the export popup should display "1 batch
to export" instead of "0 batches to export". In this context, it can be
considered a label batch and should be counted as such.

To test:
When clicking the "Print range" button, the popup should show "1 batch
to export".

Signed-off-by: David Nind <david at davidnind.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 20 22:35:50 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 20 Jan 2020 21:35:50 +0000
Subject: [Koha-bugs] [Bug 7468] Add label to batch by barcode range
In-Reply-To: <bug-7468-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-7468-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7468-70-q72bE9ISd7@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7468

--- Comment #59 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 97646
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97646&action=edit
Bug 7468: Use Modern::Perl

Just a tiny coding guidelines fix.

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 20 22:38:06 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 20 Jan 2020 21:38:06 +0000
Subject: [Koha-bugs] [Bug 19793] Add a field for email in batch patron
 modification
In-Reply-To: <bug-19793-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19793-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19793-70-li46p99Uly@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19793

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Version|unspecified                 |master

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 20 22:41:48 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 20 Jan 2020 21:41:48 +0000
Subject: [Koha-bugs] [Bug 19793] Add a field for email in batch patron
 modification
In-Reply-To: <bug-19793-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19793-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19793-70-FJsGQqY7xv@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19793

--- Comment #13 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Hi Patrick, there are some small things that I've fixed in the patch for you:

1) Please make sure your editor uses 4 spaces instead of tabs, tabs are
forbidden :)

 FAIL   tools/modborrowers.pl
   OK     critic
   FAIL   forbidden patterns
                forbidden pattern: tab char (line 267)
                forbidden pattern: tab char (line 268)
                forbidden pattern: tab char (line 269)
                forbidden pattern: tab char (line 270)
                forbidden pattern: tab char (line 271)
                forbidden pattern: tab char (line 272)

2) Make sure you include the test plan in your commit message.

3) Make sure you start the first line of your commit message with Bug XXXX:
(not - as in bugzilla).

I'll continue testing and upload the patch later.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 20 22:50:06 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 20 Jan 2020 21:50:06 +0000
Subject: [Koha-bugs] [Bug 19793] Add a field for email in batch patron
 modification
In-Reply-To: <bug-19793-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19793-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19793-70-9FEMijmClF@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19793

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 20 22:50:09 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 20 Jan 2020 21:50:09 +0000
Subject: [Koha-bugs] [Bug 19793] Add a field for email in batch patron
 modification
In-Reply-To: <bug-19793-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19793-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19793-70-DGT1Gz51xX@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19793

--- Comment #14 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 97647
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97647&action=edit
Bug 19793: Add a field for email in batch patron modification

This adds the email field to the patron batch modification tool.

To test:

1) Install patch
2) Open Batch Patron Modification tool, and input a borrowernumber to edit
3) Add some data (e.g. test at foobar.com) into the Email address field, and click
Save
4) The Primary Email address in the user record should now contain your email
address
5) Test that running the tool again with the option to delete the data clears
the field correctly
6) Repeat steps 1-5 with a file of user borrowernumbers

Signed-off-by: Sal <sally.healey at cheshiresharedservices.gov.uk>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 20 22:50:13 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 20 Jan 2020 21:50:13 +0000
Subject: [Koha-bugs] [Bug 19793] Add a field for email in batch patron
 modification
In-Reply-To: <bug-19793-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19793-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19793-70-U8JGWXnc6n@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19793

--- Comment #15 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 97648
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97648&action=edit
Bug 19793: Change label to match patron record: Primary email

As we have multiple email fields in the patron record, we should
be clear which one can be changed from the batch mod now. Easiest
is to use the same label.

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 20 22:52:13 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 20 Jan 2020 21:52:13 +0000
Subject: [Koha-bugs] [Bug 23594] Batch modification for itemtypes on
 suggestions page
In-Reply-To: <bug-23594-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23594-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23594-70-xLB8l4CpLC@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23594

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Patch doesn't apply
                 CC|                            |katrin.fischer at bsz-bw.de

--- Comment #10 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Hi Jonathan, can you please rebase?

Apply? [(y)es, (n)o, (i)nteractive] y
Applying: Bug 23594: Batch modification for itemtypes on suggestions page
.git/rebase-apply/patch:345: trailing whitespace.
}  
warning: 1 line adds whitespace errors.
Using index info to reconstruct a base tree...
M       koha-tmpl/intranet-tmpl/prog/en/modules/suggestion/suggestion.tt
M       suggestion/suggestion.pl
.git/rebase-apply/patch:345: trailing whitespace.
}  
warning: 1 line adds whitespace errors.
Falling back to patching base and 3-way merge...
Auto-merging suggestion/suggestion.pl
Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/suggestion/suggestion.tt
CONFLICT (content): Merge conflict in
koha-tmpl/intranet-tmpl/prog/en/modules/suggestion/suggestion.tt
error: Failed to merge in the changes.
Patch failed at 0001 Bug 23594: Batch modification for itemtypes on suggestions
page
The copy of the patch that failed is found in: .git/rebase-apply/patch
When you have resolved this problem run "git bz apply --continue".
If you would prefer to skip this patch, instead run "git bz apply --skip".
To restore the original branch and stop patching run "git bz apply --abort".
Patch left in
/tmp/Bug-23594-Batch-modification-for-itemtypes-on-sugg-BKdhvf.patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 20 23:09:39 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 20 Jan 2020 22:09:39 +0000
Subject: [Koha-bugs] [Bug 19793] Add a field for email in batch patron
 modification
In-Reply-To: <bug-19793-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19793-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19793-70-x9dreuBIN7@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19793

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 20 23:09:55 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 20 Jan 2020 22:09:55 +0000
Subject: [Koha-bugs] [Bug 19793] Add a field for email in batch patron
 modification
In-Reply-To: <bug-19793-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19793-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19793-70-FWR2p3jOHo@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19793

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #97347|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 20 23:16:43 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 20 Jan 2020 22:16:43 +0000
Subject: [Koha-bugs] [Bug 24336] Ask for confirmation before deleting a
 suggestion in the OPAC
In-Reply-To: <bug-24336-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24336-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24336-70-OjX4pOuPhZ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24336

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 20 23:16:47 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 20 Jan 2020 22:16:47 +0000
Subject: [Koha-bugs] [Bug 24336] Ask for confirmation before deleting a
 suggestion in the OPAC
In-Reply-To: <bug-24336-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24336-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24336-70-lBo0plP7Cs@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24336

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #96809|0                           |1
        is obsolete|                            |

--- Comment #8 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 97649
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97649&action=edit
Bug 24336: Ask for confirmation before deleting a suggestion in the OPAC

This patch modifies the OPAC suggestions interface so that patrons will
be asked for confirmation before deleting suggestions.

The patch also makes some minor markup changes to improve consistency
between this interface and others in the OPAC.

To test, apply the patch and log in to the OPAC as a user who has
submitted multiple suggestions.

 - From the list of your suggestions, confirm that the "New purchase
   suggestion" and "Delete" links have Font Awesome icons.
 - Check the checkbox corresponding to one of your suggestions. You can
   also now click the title of the suggestions to control the checkbox.
 - When you check a box the "Delete" link at the top of the page should
   activate.
 - Clicking the delete link should trigger a confirmation modal showing
   the title(s) you selected.
   - The message and button labels should reflect whether one or
     multiple titles are being deleted.
   - Test that the confirm and cancel controls work correctly.
 - Also test this process via the delete button at the bottom of the
   table of suggestions.

Signed-off-by: Maryse Simard <maryse.simard at inlibro.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 20 23:52:44 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 20 Jan 2020 22:52:44 +0000
Subject: [Koha-bugs] [Bug 19793] Add a field for email in batch patron
 modification
In-Reply-To: <bug-19793-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19793-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19793-70-is1JQ63hiJ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19793

--- Comment #16 from David Roberts <david.roberts at ptfs-europe.com> ---
Thanks Katrin, I didn't know that. I'll try to do that in future! Thanks for
QA'ing the patch and for your changes.

David (apparently AKA Patrick! :-D )


(In reply to Katrin Fischer from comment #13)
> Hi Patrick, there are some small things that I've fixed in the patch for you:
> 
> 1) Please make sure your editor uses 4 spaces instead of tabs, tabs are
> forbidden :)
> 
>  FAIL	tools/modborrowers.pl
>    OK	  critic
>    FAIL	  forbidden patterns
> 		forbidden pattern: tab char (line 267)
> 		forbidden pattern: tab char (line 268)
> 		forbidden pattern: tab char (line 269)
> 		forbidden pattern: tab char (line 270)
> 		forbidden pattern: tab char (line 271)
> 		forbidden pattern: tab char (line 272)
> 
> 2) Make sure you include the test plan in your commit message.
> 
> 3) Make sure you start the first line of your commit message with Bug XXXX:
> (not - as in bugzilla).
> 
> I'll continue testing and upload the patch later.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 21 07:56:08 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 21 Jan 2020 06:56:08 +0000
Subject: [Koha-bugs] [Bug 19793] Add a field for email in batch patron
 modification
In-Reply-To: <bug-19793-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19793-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19793-70-lDuNKjtlyR@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19793

--- Comment #17 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
(In reply to David Roberts from comment #16)
> Thanks Katrin, I didn't know that. I'll try to do that in future! Thanks for
> QA'ing the patch and for your changes.
> 
> David (apparently AKA Patrick! :-D )

Sorry for that, apparently I was looking at the wrong comments :(

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 21 08:00:08 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 21 Jan 2020 07:00:08 +0000
Subject: [Koha-bugs] [Bug 21586] Add generic OpenIDConnect client
 implementation
In-Reply-To: <bug-21586-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21586-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21586-70-owcT6TiAlg@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21586

--- Comment #8 from David Cook <dcook at prosentient.com.au> ---
This code is out of date, and has a few known problems. However, I have a newer
version, which I actually have working with the Keycloak OpenID Connect
Identity Provider.

For testing purposes, I very easily ran up an instance in Docker
(https://hub.docker.com/r/jboss/keycloak/), and after resolving a bug in my
code, I was able to successfully authenticate and auto-add a patron to Koha. 

It's worth noting that I have used Keycloak for other projects for a while now,
so the server configuration was trivial for me, but it might not be obvious at
a glance. There is lots of documentation though. 

Might also be worth noting that Keycloak is sponsored by Red Hat and forms the
core of RH-SSO, which Red Hat actually uses for all its own AuthN purposes. 

Note that even though I have a new version of the code that works, I'd actually
like to redo my code for this one.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 21 08:07:32 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 21 Jan 2020 07:07:32 +0000
Subject: [Koha-bugs] [Bug 20888] Allow use of boolean operator 'not' in item
 search
In-Reply-To: <bug-20888-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20888-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20888-70-MHNGj6hxpz@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20888

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Failed QA

--- Comment #26 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Hi Matts, have been testing:

+        <select name="op" class="form-field-not">
+           <option value="like">is</option>
+            [% IF params.op == 'not like' %]
+               <option value="not like" selected="selected">is not</option>
+            [% ELSE %]
+               <option value="not like">is not</option>
+            [% END 

IF = not like... else = not like?

I tested with a custom item search option for "Withdrawn" linked to the
WITHDRAWN authorised value. If I pick "is not" Withdrawn I get the only
withdrawn item. If I pick 'is' withdrawn... I get all the other items. It works
ok on master for the 'is' case.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 21 08:11:50 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 21 Jan 2020 07:11:50 +0000
Subject: [Koha-bugs] [Bug 21586] Add generic OpenIDConnect client
 implementation
In-Reply-To: <bug-21586-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21586-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21586-70-DckPhYtm0s@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21586

--- Comment #9 from David Cook <dcook at prosentient.com.au> ---
Actually, this one would be great to add as an "Authentication Plugin" for
Koha. 

Looking at my code, the only part of it which doesn't lend itself to a plugin
architecture are the changes to Auth.pm and opac-auth.tt. 

However, we could probably remove the necessity for opac-auth.tt changes.

And we could add hooks into Auth.pm for login and logout. Looking at my code,
those shouldn't be that hard to add. 

--

One of the interesting things with this work was setting up multiple OpenID
Connect providers. I'm not sure how often that would actually be a requirement
(as I think people sometimes use another IdP to federate others together) but
it was originally a requirement for my work, and it's something I've seen other
people ask for online. 

--

Really we should be able to use OpenID Connect against Google and any other
compliant IdP (like Keycloak).

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 21 08:12:47 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 21 Jan 2020 07:12:47 +0000
Subject: [Koha-bugs] [Bug 21586] Add generic OpenIDConnect client
 implementation
In-Reply-To: <bug-21586-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21586-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21586-70-c4awTax0qQ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21586

--- Comment #10 from David Cook <dcook at prosentient.com.au> ---
I don't have plans to work on this at present, but it is an interest of mine,
so if I find myself with spare time, I would work on it (although the OAI-PMH
harvester is a competing albeit much more complex interest).

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 21 08:15:53 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 21 Jan 2020 07:15:53 +0000
Subject: [Koha-bugs] [Bug 24161] Late orders improvements - keeping track of
 claims
In-Reply-To: <bug-24161-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24161-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24161-70-q3OlFduDpF@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24161

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         QA Contact|katrin.fischer at bsz-bw.de    |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 21 09:04:53 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 21 Jan 2020 08:04:53 +0000
Subject: [Koha-bugs] [Bug 23702] New UNIMARC XSLT according to last IFLA
 updates
In-Reply-To: <bug-23702-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23702-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23702-70-kxqXKaglt5@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23702

delaye <stephane.delaye at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 21 09:14:03 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 21 Jan 2020 08:14:03 +0000
Subject: [Koha-bugs] [Bug 13305] Fix tab order in cataloguing/item editor
In-Reply-To: <bug-13305-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13305-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13305-70-Lx1rUP8AmH@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13305

--- Comment #6 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
(In reply to Owen Leonard from comment #2)
> Is there any valid reason for having a tabindex value attached to any of
> these fields? I would prefer a solution which removed 'tabindex="1"' from
> the generated code rather than one which adds it.

I have taken the time to think deeply on that and came to appreciate it :)
Patch forthcoming finally.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 21 09:15:41 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 21 Jan 2020 08:15:41 +0000
Subject: [Koha-bugs] [Bug 13305] Fix tab order in cataloguing/item editor
In-Reply-To: <bug-13305-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13305-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13305-70-0Mto0zxveI@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13305

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 21 09:15:43 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 21 Jan 2020 08:15:43 +0000
Subject: [Koha-bugs] [Bug 13305] Fix tab order in cataloguing/item editor
In-Reply-To: <bug-13305-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13305-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13305-70-pj9x95Xt8x@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13305

--- Comment #7 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 97650
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97650&action=edit
Bug 13305: Remove tabindex from PrepareItemsRecordDisplay

Test plan:
Check the tab order of the item block on additem.pl (item editor),
Acquisition (neworderempty or addiso2709), serials-edit.pl.
You could also check services/itemrecorddisplay.pl and pass a
biblionumber; this script is used in additem.js for cataloguing and
acquisition.

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 21 09:59:10 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 21 Jan 2020 08:59:10 +0000
Subject: [Koha-bugs] [Bug 23190] Authority hierarchy display appears to be
 broken
In-Reply-To: <bug-23190-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23190-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23190-70-f8sAfHh9xQ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23190

--- Comment #3 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
The feature needs an authid in $9.
The editor in authorities does not (or no longer) enforce the use of the
connected authority plugin (for some reason). Allowing you to enter a name
manually but if you do that, you won't have the link in $9 (and the tree cannot
be built).
In master the icon of the authority plugin [three dots] has been moved. Very
hard to see too. They are on the same line as the a for subfield and the field
label Geographic name.

I would say: The feature is not broken, but the authority editor needs some
attention at least.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 21 10:00:30 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 21 Jan 2020 09:00:30 +0000
Subject: [Koha-bugs] [Bug 24407] AuthDisplayHierarchies ignores new nodes
 and needs protection against cyclic relations
In-Reply-To: <bug-24407-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24407-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24407-70-6okTXYkQNP@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24407

--- Comment #5 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
(In reply to Marcel de Rooy from comment #3)
> (In reply to Katrin Fischer from comment #2)
> > (In reply to Marcel de Rooy from comment #1)
> > > Katrin,
> > > If I am not mistaken, you are using it? Could you comment on this?
> > 
> > Sadly not at the moment, see major bug 23190 - I can't get it to work at the
> > moment.
> 
> Could it be related to the first thing mentioned here?

A closer look tells me that they are not the same.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 21 10:10:28 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 21 Jan 2020 09:10:28 +0000
Subject: [Koha-bugs] [Bug 23190] Authority hierarchy display appears to be
 broken
In-Reply-To: <bug-23190-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23190-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23190-70-TCoW5Rhkq7@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23190

--- Comment #4 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Thx Marcel, I will try to give it another go.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 21 10:12:46 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 21 Jan 2020 09:12:46 +0000
Subject: [Koha-bugs] [Bug 24407] AuthDisplayHierarchies ignores new nodes
 and needs protection against cyclic relations
In-Reply-To: <bug-24407-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24407-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24407-70-VmNyJqRxXq@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24407

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=23190

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 21 10:12:46 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 21 Jan 2020 09:12:46 +0000
Subject: [Koha-bugs] [Bug 23190] Authority hierarchy display appears to be
 broken
In-Reply-To: <bug-23190-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23190-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23190-70-myX5AYFrtu@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23190

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=24407

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 21 10:14:23 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 21 Jan 2020 09:14:23 +0000
Subject: [Koha-bugs] [Bug 18936] Convert issuingrules fields to
 circulation_rules
In-Reply-To: <bug-18936-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18936-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18936-70-b319ubFzkO@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18936

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Needs Signoff

--- Comment #92 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
(In reply to Joonas Kylmälä from comment #91)
> Hi Jonathan,
> 
> failing the patches "Bug 18936: More fixes", "Bug 18936: Fix Circulation.t",
> "Bug 18936: Fix several issues" and "Bug 18936: Fix Update DB entry" since
> they miss description of the changes so there is no way to know what is the
> intended change here therefore testing will be super difficult. Also with
> "Bug 18936: Fix several issues" it would be more logical to have then
> several commits for those.
> 
> So I will take a look again once the descriptions of changes are added, ok?

Hi Joonas,
Those patches are follow-up sI submitted when I retested the feature after a
feature. I can understand they do not make sense in the git log, but they do
for me (as I am rebasing this for 2 years now). I would suggest to squash the
patches when reviewing them, and you will see that the changes make sense.

Fix Circulation.t: Make the tests Circulation.t pass (maxissueqty was missing
when the rule was created)

Fix several issues: branchcode, categorycode and itemtype are no longer
mandatory to create a new rule

Fix Update DB entry: Some rules were missing (or added when they should not).
Also branchcode, categorycode and itemtype must not be '*' but NULL, otherwise
the FK constraint will not be satisfied.

We are at Signoff step, that should not block testers to test this feature.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 21 10:27:22 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 21 Jan 2020 09:27:22 +0000
Subject: [Koha-bugs] [Bug 24345] Fix process of suggesting purchase of
 existing title for non-logged-in users
In-Reply-To: <bug-24345-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24345-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24345-70-3EBOiCDb8n@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24345

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 21 10:27:26 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 21 Jan 2020 09:27:26 +0000
Subject: [Koha-bugs] [Bug 24345] Fix process of suggesting purchase of
 existing title for non-logged-in users
In-Reply-To: <bug-24345-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24345-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24345-70-sn1uOKtRvw@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24345

--- Comment #4 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 97651
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97651&action=edit
Bug 24345: Fix OPACViewOthersSuggestions

Default value for $op needs to be set before the get_template_and_user lines as
it's tested for OPACViewOthersSuggestions.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 21 10:27:46 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 21 Jan 2020 09:27:46 +0000
Subject: [Koha-bugs] [Bug 24345] Fix process of suggesting purchase of
 existing title for non-logged-in users
In-Reply-To: <bug-24345-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24345-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24345-70-h1rIX9dQw0@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24345

--- Comment #5 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
(In reply to Marcel de Rooy from comment #3)
> This change has side effects.
> It seems to break viewing other purchase suggestions anonymously (enable
> OPACViewOthersSuggestions). Might be possible that we only should add the
> op=else parameter in the masthead link, but it needs more checking.
> 
> The script is a bit messy in the handling of $op..

Ha! Thanks Marcel!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 21 10:38:57 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 21 Jan 2020 09:38:57 +0000
Subject: [Koha-bugs] [Bug 24448] Add Koha::Biblio->subscriptions_count
In-Reply-To: <bug-24448-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24448-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24448-70-pT0kYgTmuV@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24448

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Failed QA

--- Comment #5 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
IMO we should not have ->subscriptions_count, but callers should
->subscriptions->count instead. What's the point of this?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 21 10:40:42 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 21 Jan 2020 09:40:42 +0000
Subject: [Koha-bugs] [Bug 24448] Add Koha::Biblio->subscriptions_count
In-Reply-To: <bug-24448-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24448-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24448-70-iCoJxlyXtE@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24448

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de

--- Comment #6 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
(In reply to Jonathan Druart from comment #5)
> IMO we should not have ->subscriptions_count, but callers should
> ->subscriptions->count instead. What's the point of this?

I have to admit I was a bit confused by this too - can you explain Tomas?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 21 10:42:10 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 21 Jan 2020 09:42:10 +0000
Subject: [Koha-bugs] [Bug 7957] Routing lists: manage several routing list
 for each subscription, and export them as CSV
In-Reply-To: <bug-7957-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-7957-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7957-70-JKOpvK7Zmg@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7957

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         QA Contact|koha.sekjal at gmail.com       |testopia at bugs.koha-communit
                   |                            |y.org

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 21 11:11:03 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 21 Jan 2020 10:11:03 +0000
Subject: [Koha-bugs] [Bug 24397] populate_db.pl is out of sync and must be
 removed
In-Reply-To: <bug-24397-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24397-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24397-70-E3rqbUpITt@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24397

--- Comment #5 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
(In reply to Marcel de Rooy from comment #3)
> Removing it is easy and I understand the argument. But we could discuss if
> the statement "koha-misc4dev must be used instead" has full consensus.

Maybe a bit of history was needed. I submitted koha:populate_db.pl to have an
handy script, but then realized that our process (SO+QA+push) was too slow to
get things pushed quickly. So I created misc4dev and copied the script there,
along with a lot of other stuffs for Koha devs.
The things is that koha-misc4dev is now used by the sandbox and jenkins
(koha-testing-docker), and so we need a super fast reactivity when something is
broken there, and we now it's broken as the CI is failing in that case.
I am the one who usually fix it

https://gitlab.com/koha-community/koha-misc4dev/commits/master

Most of the time the change is minor and trivial.

> How do we make sure that it is in sync and that it meets our coding
> guidelines etc? It is easier to grep one git repo than two?

Those scripts cannot be part of Koha, as I said previously we need a fast push
and cannot wait for review. I ask for review when I am adding new enhancements
(and in that cases it usually takes several weeks).

> The reason for putting it outside Koha probably relates to the tedious
> process of getting things signed off and pushed in Koha mainstream. Somehow
> we do not manage as community to get that more smoothly. But I still think
> we should address that and not just move code somewhere else.

How? :)

> As an alternative approach, should we copy this script (or even more) at
> release time into the codebase? Formulate some procedure to sync them?

Nope, the script will be broken during the release cycle, and so the script
will become obsolete.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 21 11:14:54 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 21 Jan 2020 10:14:54 +0000
Subject: [Koha-bugs] [Bug 22868] Circulation staff with suggestions_manage
 can have access to acquisition data
In-Reply-To: <bug-22868-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22868-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22868-70-kMH64WIS4g@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22868

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|enhancement                 |critical

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 21 11:17:24 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 21 Jan 2020 10:17:24 +0000
Subject: [Koha-bugs] [Bug 24397] populate_db.pl is out of sync and must be
 removed
In-Reply-To: <bug-24397-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24397-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24397-70-TBTOwExbwI@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24397

--- Comment #6 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
As this is intended for developers and dev scripts tend to be able to do
'dangeorus things' I am fully ok with keeping them separate from the scripts in
the release.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 21 11:25:43 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 21 Jan 2020 10:25:43 +0000
Subject: [Koha-bugs] [Bug 22658] aqbasket.authorisedby is missing a foreign
 key constraint
In-Reply-To: <bug-22658-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22658-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22658-70-2TF8HSxVPF@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22658

--- Comment #2 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
I would not care that much about authorisedby, it must contain an integer.
However it can contain borrowernumber that do not longer exist in borrowers.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 21 11:36:36 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 21 Jan 2020 10:36:36 +0000
Subject: [Koha-bugs] [Bug 24363] Datepicker calendar is not sexy on
 additem.pl
In-Reply-To: <bug-24363-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24363-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24363-70-y6uGv9zwo1@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24363

--- Comment #10 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
I see it wider than other inputs: https://snipboard.io/pemyLA.jpg

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 21 11:41:02 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 21 Jan 2020 10:41:02 +0000
Subject: [Koha-bugs] [Bug 24363] Datepicker calendar is not sexy on
 additem.pl
In-Reply-To: <bug-24363-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24363-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24363-70-rmr6bEY12y@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24363

--- Comment #11 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Looks ok without padding-right: 18px;

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 21 12:04:18 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 21 Jan 2020 11:04:18 +0000
Subject: [Koha-bugs] [Bug 24448] Add Koha::Biblio->subscriptions_count
In-Reply-To: <bug-24448-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24448-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24448-70-cwoE0S0nvu@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24448

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Signed Off

--- Comment #7 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
The short explanation is that we developed a way to embed things from the API
using HTTP headers, and it can embed methods output. Take a look at this
branch:

https://gitlab.com/thekesolutions/Koha/tree/bug_20212_slowness_acq

We could develop a way to specify we want to count things from the HTTP
headers, but it is kind of overkill only for the sake of avoiding this simple
method.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 21 12:05:28 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 21 Jan 2020 11:05:28 +0000
Subject: [Koha-bugs] [Bug 24363] Datepicker calendar is not always sexy
In-Reply-To: <bug-24363-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24363-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24363-70-S2PrnLvT95@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24363

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Datepicker calendar is not  |Datepicker calendar is not
                   |sexy on additem.pl          |always sexy

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 21 12:12:27 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 21 Jan 2020 11:12:27 +0000
Subject: [Koha-bugs] [Bug 20443] Move C4::Members::Attributes to Koha
 namespace
In-Reply-To: <bug-20443-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20443-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20443-70-QmxObiKywT@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20443

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Failed QA

--- Comment #19 from Josef Moravec <josef.moravec at gmail.com> ---
Hello Jonathan, thanks to rebasing this again.

Firstly, there are some trivials found by qa tools:

 FAIL   Koha/Patron/Attribute.pm
   FAIL   pod
                *** ERROR: 
                empty =head3

                 in file Koha/Patron/Attribute.pm

                *** ERROR: 
                empty =head3

                 in file Koha/Patron/Attribute.pm

 FAIL   Koha/Patron/Attributes.pm
   FAIL   pod
                *** ERROR: 
                empty =head3

                 in file Koha/Patron/Attributes.pm

   FAIL   pod coverage
                POD is missing for merge_with
                POD is missing for object_class


 FAIL   Koha/Patrons.pm
   FAIL   spelling
                 paramter  ==> parameter


Otherwise it looks nice.



Note for QA: this is false positive:
 FAIL   Koha/Patron/Attribute.pm
   FAIL   forbidden patterns
                forbidden pattern: Warning: The 'sub type' may be wrong is
declared in a Koha::* package (see bug 15446) (line 63)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 21 12:21:02 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 21 Jan 2020 11:21:02 +0000
Subject: [Koha-bugs] [Bug 18989] Allow displaying biblios with all items
 hidden by OpacHiddenItems
In-Reply-To: <bug-18989-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18989-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18989-70-vOyTasFeRb@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18989

--- Comment #5 from Fridolin SOMERS <fridolin.somers at biblibre.com> ---
Still valid.
We have to patch to comment code for some of our libraries.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 21 12:23:14 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 21 Jan 2020 11:23:14 +0000
Subject: [Koha-bugs] [Bug 24430] Remove C4::Biblio::CountBiblioInOrders
In-Reply-To: <bug-24430-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24430-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24430-70-QMXxdFtwGW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24430

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #97563|0                           |1
        is obsolete|                            |

--- Comment #11 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 97652
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97652&action=edit
Bug 24430: Unit tests

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 21 12:23:18 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 21 Jan 2020 11:23:18 +0000
Subject: [Koha-bugs] [Bug 24430] Remove C4::Biblio::CountBiblioInOrders
In-Reply-To: <bug-24430-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24430-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24430-70-JVYyK5JFLY@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24430

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #97564|0                           |1
        is obsolete|                            |

--- Comment #12 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 97653
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97653&action=edit
Bug 24430: Add ->orders and ->active_orders_count to Koha::Biblio

This patch introduces an accessor to the related orders, and a method
that returns the active orders count. The target usage for the count is the
API. In the rest of the codebase, we would just call:

    $biblio->orders->count

To test:
1. Apply this patches
2. Run:
   $ kshell
  k$ prove t/db_dependent/Koha/Biblio.t
=> SUCCESS: Tests pass!
3. Sign off :-D

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 21 12:23:21 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 21 Jan 2020 11:23:21 +0000
Subject: [Koha-bugs] [Bug 24430] Remove C4::Biblio::CountBiblioInOrders
In-Reply-To: <bug-24430-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24430-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24430-70-4M9WTVQDqW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24430

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #97565|0                           |1
        is obsolete|                            |

--- Comment #13 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 97654
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97654&action=edit
Bug 24430: Remove CountBiblioInOrders and its traces

This patch replaces the only uses of CountBiblioInOrders and makes that
code use $biblio->orders->count instead.

Test nothing breaks in basket.pl and parcel.pl

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 21 12:24:08 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 21 Jan 2020 11:24:08 +0000
Subject: [Koha-bugs] [Bug 24430] Remove C4::Biblio::CountBiblioInOrders
In-Reply-To: <bug-24430-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24430-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24430-70-SDY7kiwpOg@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24430

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

--- Comment #14 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Trivial improvements that simplify code.. Passing QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 21 12:27:19 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 21 Jan 2020 11:27:19 +0000
Subject: [Koha-bugs] [Bug 3426] Change itemcallnumber system preference to
 allow multiple tags
In-Reply-To: <bug-3426-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-3426-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-3426-70-3Vt4lACGYQ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3426

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |martin.renvoize at ptfs-europe
                   |                            |.com

--- Comment #17 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Love seeing these golden oldies getting some attention!

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 21 12:28:06 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 21 Jan 2020 11:28:06 +0000
Subject: [Koha-bugs] [Bug 22204] Leading spaces in barcode should not
 allowed in cataloguing
In-Reply-To: <bug-22204-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22204-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22204-70-VnUY6h0OLT@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22204

--- Comment #2 from Fridolin SOMERS <fridolin.somers at biblibre.com> ---
(In reply to Jonathan Druart from comment #1)
> Hi Frido, do you plan to provide a patch?

I'm not sure when I can find time, feel free to propose patches.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 21 12:29:32 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 21 Jan 2020 11:29:32 +0000
Subject: [Koha-bugs] [Bug 23204] Script for exporting Elasticsearch mappings
 to YAML
In-Reply-To: <bug-23204-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23204-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23204-70-IS0sDylW2G@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23204

--- Comment #13 from Fridolin SOMERS <fridolin.somers at biblibre.com> ---
(In reply to Nick Clemens from comment #12)
> Question: Should we only load/export the mappings for the marc_type of the
> instance? Including the normarc and unimarc for marc21 makes the file harder
> to read. Same the other way round to :-)

There is the --type arg in the script to export only one marc flavour.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 21 12:32:03 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 21 Jan 2020 11:32:03 +0000
Subject: [Koha-bugs] [Bug 7468] Add label to batch by barcode range
In-Reply-To: <bug-7468-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-7468-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7468-70-9qGuubrij1@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7468

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |martin.renvoize at ptfs-europe
                   |                            |.com

--- Comment #60 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
It would have been nice to have a test for the functional change in Letter.pm..
but as this is a very old bug I'm willing to let that slide this time.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 21 12:36:32 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 21 Jan 2020 11:36:32 +0000
Subject: [Koha-bugs] [Bug 3426] Change itemcallnumber system preference to
 allow multiple tags
In-Reply-To: <bug-3426-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-3426-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-3426-70-OhKN5oEJaL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3426

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to master
         Version(s)|                            |20.05.00
        released in|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 21 12:36:35 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 21 Jan 2020 11:36:35 +0000
Subject: [Koha-bugs] [Bug 3426] Change itemcallnumber system preference to
 allow multiple tags
In-Reply-To: <bug-3426-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-3426-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-3426-70-19joPzytI5@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3426

--- Comment #18 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Nice work everyone!

Pushed to master for 20.05

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 21 12:36:37 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 21 Jan 2020 11:36:37 +0000
Subject: [Koha-bugs] [Bug 7468] Add label to batch by barcode range
In-Reply-To: <bug-7468-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-7468-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7468-70-cO0r8Ngm3e@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7468

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to master
         Version(s)|                            |20.05.00
        released in|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 21 12:36:39 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 21 Jan 2020 11:36:39 +0000
Subject: [Koha-bugs] [Bug 7468] Add label to batch by barcode range
In-Reply-To: <bug-7468-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-7468-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7468-70-93xJdZpdFz@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7468

--- Comment #61 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Nice work everyone!

Pushed to master for 20.05

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 21 12:36:42 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 21 Jan 2020 11:36:42 +0000
Subject: [Koha-bugs] [Bug 19793] Add a field for email in batch patron
 modification
In-Reply-To: <bug-19793-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19793-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19793-70-AvjdREq7IW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19793

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to master
         Version(s)|                            |20.05.00
        released in|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 21 12:36:44 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 21 Jan 2020 11:36:44 +0000
Subject: [Koha-bugs] [Bug 19793] Add a field for email in batch patron
 modification
In-Reply-To: <bug-19793-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19793-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19793-70-mt5FQSIeBj@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19793

--- Comment #18 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Nice work everyone!

Pushed to master for 20.05

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 21 12:36:46 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 21 Jan 2020 11:36:46 +0000
Subject: [Koha-bugs] [Bug 24336] Ask for confirmation before deleting a
 suggestion in the OPAC
In-Reply-To: <bug-24336-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24336-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24336-70-keBKVqx0ae@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24336

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to master
         Version(s)|                            |20.05.00
        released in|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 21 12:36:48 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 21 Jan 2020 11:36:48 +0000
Subject: [Koha-bugs] [Bug 24336] Ask for confirmation before deleting a
 suggestion in the OPAC
In-Reply-To: <bug-24336-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24336-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24336-70-j34cw2EaON@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24336

--- Comment #9 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Nice work everyone!

Pushed to master for 20.05

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 21 12:36:50 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 21 Jan 2020 11:36:50 +0000
Subject: [Koha-bugs] [Bug 24430] Remove C4::Biblio::CountBiblioInOrders
In-Reply-To: <bug-24430-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24430-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24430-70-epeRtyoTJi@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24430

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|                            |20.05.00
        released in|                            |
             Status|Passed QA                   |Pushed to master

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 21 12:36:52 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 21 Jan 2020 11:36:52 +0000
Subject: [Koha-bugs] [Bug 24430] Remove C4::Biblio::CountBiblioInOrders
In-Reply-To: <bug-24430-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24430-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24430-70-1OukqxVmg9@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24430

--- Comment #15 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Nice work everyone!

Pushed to master for 20.05

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 21 12:36:54 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 21 Jan 2020 11:36:54 +0000
Subject: [Koha-bugs] [Bug 24435] Add Koha::Biblio->items_count
In-Reply-To: <bug-24435-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24435-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24435-70-UaNeKzXJ3p@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24435

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|                            |20.05.00
        released in|                            |
             Status|Passed QA                   |Pushed to master

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 21 12:36:56 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 21 Jan 2020 11:36:56 +0000
Subject: [Koha-bugs] [Bug 24435] Add Koha::Biblio->items_count
In-Reply-To: <bug-24435-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24435-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24435-70-AJ9Pk1tZLp@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24435

--- Comment #7 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Nice work everyone!

Pushed to master for 20.05

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 21 12:46:49 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 21 Jan 2020 11:46:49 +0000
Subject: [Koha-bugs] [Bug 24435] Add Koha::Biblio->items_count
In-Reply-To: <bug-24435-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24435-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24435-70-vtEEPkbe1z@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24435

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=24448
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 21 12:46:49 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 21 Jan 2020 11:46:49 +0000
Subject: [Koha-bugs] [Bug 24448] Add Koha::Biblio->subscriptions_count
In-Reply-To: <bug-24448-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24448-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24448-70-mMiz0M26HC@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24448

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=24435

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 21 12:58:34 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 21 Jan 2020 11:58:34 +0000
Subject: [Koha-bugs] [Bug 22898] Selenium tests for placing holds from the
 staff interface
In-Reply-To: <bug-22898-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22898-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22898-70-E8ujBlfp86@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22898

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 21 12:58:37 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 21 Jan 2020 11:58:37 +0000
Subject: [Koha-bugs] [Bug 22898] Selenium tests for placing holds from the
 staff interface
In-Reply-To: <bug-22898-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22898-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22898-70-ip5p2tCZPd@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22898

--- Comment #11 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 97655
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97655&action=edit
Bug 22898: Since bug 23957, submit element is now a button (no longer input)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 21 12:58:41 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 21 Jan 2020 11:58:41 +0000
Subject: [Koha-bugs] [Bug 22898] Selenium tests for placing holds from the
 staff interface
In-Reply-To: <bug-22898-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22898-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22898-70-7WraenXVob@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22898

--- Comment #12 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 97656
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97656&action=edit
Bug 22898: Fix failure since bug 19618

See comment in the code, this is not the correct fix, but cannot find
something better for now.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 21 13:05:38 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 21 Jan 2020 12:05:38 +0000
Subject: [Koha-bugs] [Bug 20443] Move C4::Members::Attributes to Koha
 namespace
In-Reply-To: <bug-20443-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20443-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20443-70-TceXfuhOIS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20443

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Needs Signoff

--- Comment #20 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Fixed, Josef!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 21 13:21:24 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 21 Jan 2020 12:21:24 +0000
Subject: [Koha-bugs] [Bug 22658] aqbasket.authorisedby is missing a foreign
 key constraint
In-Reply-To: <bug-22658-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22658-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22658-70-we4OuUh6JT@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22658

--- Comment #3 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
(In reply to Jonathan Druart from comment #2)
> I would not care that much about authorisedby, it must contain an integer.
> However it can contain borrowernumber that do not longer exist in borrowers.

Do you say we should set to NULL if it doesn't exist in borrowers?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 21 13:22:45 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 21 Jan 2020 12:22:45 +0000
Subject: [Koha-bugs] [Bug 24236] Using quotes in a cataloging search,
 resulting in multiple pages, will not allow you to advance page
In-Reply-To: <bug-24236-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24236-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24236-70-ClnWMU24mU@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24236

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 21 13:22:48 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 21 Jan 2020 12:22:48 +0000
Subject: [Koha-bugs] [Bug 24236] Using quotes in a cataloging search,
 resulting in multiple pages, will not allow you to advance page
In-Reply-To: <bug-24236-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24236-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24236-70-lM3ak7Zpxw@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24236

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #97413|0                           |1
        is obsolete|                            |

--- Comment #7 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 97657
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97657&action=edit
Bug 24236: Fix pagination to use query_cgi

This is still wrong, we should use page-numbers.inc, but that is a larger
refactoring
This patch fixes non-QueryParser searches by simple getting an using the
escaped query (query_cgi)

For QueryParser, we do what the QP code does, just uri escape the query - the
way that SimpleSearch does the query parsing instead of the usual buildQuery
suggest to me that we should probably switch all of this to use the general
Zebra search.

The issues with reservoir should be their own bug

To test:
1 - Search for cat in cataloging search
2 - Get results and see you can paginate
3 - Search for "cat"
4 - Get results but subsequent pages empty
5 - Apply patch
6 - Repeat search for "cat"
7 - You can paginate
8 - Enable UseQueryParser syspref (don't worry about installing)
9 - Confirm can still search with quotes and paginate

Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

Signed-off-by: George Williams <george at nekls.org>

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 21 13:25:33 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 21 Jan 2020 12:25:33 +0000
Subject: [Koha-bugs] [Bug 21674] Data integrity not enforced for library
 groups
In-Reply-To: <bug-21674-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21674-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21674-70-43ETzabEcL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21674

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Patch doesn't apply         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 21 13:25:37 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 21 Jan 2020 12:25:37 +0000
Subject: [Koha-bugs] [Bug 21674] Data integrity not enforced for library
 groups
In-Reply-To: <bug-21674-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21674-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21674-70-eD31ZhDBDq@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21674

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #96200|0                           |1
        is obsolete|                            |

--- Comment #4 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 97658
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97658&action=edit
Bug 21674: Prevent to insert twice the same library in a group

You can create hierarchical groups of libraries you are not allowed to add
several times the same library to a given group/subgroup. The libraries
that are part of the group is not displayed on the interface, to prevent
the user to select it.

However this restriction is only done template-side, the controller and
module does not handle it.

To prevent that this patchset enforces the constraint at DB level, and
display a message to the end user.

Test plan:
- Go to Home › Administration › Library groups
- Add a group
- Add a library
- reload the page several times
=> Without this patch the same library appears several times in the group
=> With this patch applied you will see a friendly error message

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 21 13:25:55 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 21 Jan 2020 12:25:55 +0000
Subject: [Koha-bugs] [Bug 21674] Data integrity not enforced for library
 groups
In-Reply-To: <bug-21674-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21674-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21674-70-LmnkQeGQBZ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21674

--- Comment #5 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
(In reply to Nick Clemens from comment #3)
> Tested on a sandbox, did not work

Works for me, please try again with this rebased patch.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 21 13:27:18 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 21 Jan 2020 12:27:18 +0000
Subject: [Koha-bugs] [Bug 22658] aqbasket.authorisedby is missing a foreign
 key constraint
In-Reply-To: <bug-22658-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22658-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22658-70-wGVsyRQnQu@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22658

--- Comment #4 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
(In reply to Tomás Cohen Arazi from comment #3)
> (In reply to Jonathan Druart from comment #2)
> > I would not care that much about authorisedby, it must contain an integer.
> > However it can contain borrowernumber that do not longer exist in borrowers.
> 
> Do you say we should set to NULL if it doesn't exist in borrowers?

Yes

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 21 13:32:59 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 21 Jan 2020 12:32:59 +0000
Subject: [Koha-bugs] [Bug 22658] aqbasket.authorisedby is missing a foreign
 key constraint
In-Reply-To: <bug-22658-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22658-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22658-70-fjdnhdTXbz@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22658

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de

--- Comment #5 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
(In reply to Jonathan Druart from comment #4)
> (In reply to Tomás Cohen Arazi from comment #3)
> > (In reply to Jonathan Druart from comment #2)
> > > I would not care that much about authorisedby, it must contain an integer.
> > > However it can contain borrowernumber that do not longer exist in borrowers.
> > 
> > Do you say we should set to NULL if it doesn't exist in borrowers?
> 
> Yes

This might be a tricky one. I think we control visibility of baskets by their
creator (AcqViewBaskets, independentbranches, permissions etc.). We don't want
baskets to appear suddenly for libraries/staff who should not be able to see
then. Not sure what the best fix here is, just saying it could lead to unwanted
consequences.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 21 13:43:40 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 21 Jan 2020 12:43:40 +0000
Subject: [Koha-bugs] [Bug 7468] Add label to batch by barcode range
In-Reply-To: <bug-7468-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-7468-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7468-70-GVYvkyTha2@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7468

--- Comment #62 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
(In reply to Martin Renvoize from comment #60)
> It would have been nice to have a test for the functional change in
> Letter.pm.. but as this is a very old bug I'm willing to let that slide this
> time.

Are you really meaning Letter.pm?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 21 13:45:50 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 21 Jan 2020 12:45:50 +0000
Subject: [Koha-bugs] [Bug 18989] Allow displaying biblios with all items
 hidden by OpacHiddenItems
In-Reply-To: <bug-18989-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18989-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18989-70-X3smXHAIEf@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18989

--- Comment #6 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Why not write a patch to make this a configuration option instead?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 21 13:48:12 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 21 Jan 2020 12:48:12 +0000
Subject: [Koha-bugs] [Bug 24448] Add Koha::Biblio->subscriptions_count
In-Reply-To: <bug-24448-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24448-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24448-70-HK7kJFID3b@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24448

--- Comment #8 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
(In reply to Tomás Cohen Arazi from comment #7)
> The short explanation is that we developed a way to embed things from the
> API using HTTP headers, and it can embed methods output. Take a look at this
> branch:
> 
> https://gitlab.com/thekesolutions/Koha/tree/bug_20212_slowness_acq
> 
> We could develop a way to specify we want to count things from the HTTP
> headers, but it is kind of overkill only for the sake of avoiding this
> simple method.

Sorry, not understanding it yet :(

What's the difference between 

subscriptions->count 
subscriptions->subscription_count

in terms of the API? The first looks more standardized to me?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 21 13:52:31 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 21 Jan 2020 12:52:31 +0000
Subject: [Koha-bugs] [Bug 21674] Data integrity not enforced for library
 groups
In-Reply-To: <bug-21674-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21674-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21674-70-BfKxSg9SMX@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21674

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Failed QA

--- Comment #6 from Nick Clemens <nick at bywatersolutions.com> ---
If a library is duplicated in the group before this patch then the DB update
fails - we need to cleanup before adding the constraint

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 21 14:04:10 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 21 Jan 2020 13:04:10 +0000
Subject: [Koha-bugs] [Bug 20443] Move C4::Members::Attributes to Koha
 namespace
In-Reply-To: <bug-20443-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20443-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20443-70-1S6XqajARH@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20443

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

--- Comment #21 from Josef Moravec <josef.moravec at gmail.com> ---
(In reply to Jonathan Druart from comment #20)
> Fixed, Josef!

Thanks Jonathan

Signed off!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 21 14:09:09 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 21 Jan 2020 13:09:09 +0000
Subject: [Koha-bugs] [Bug 24448] Add Koha::Biblio->subscriptions_count
In-Reply-To: <bug-24448-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24448-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24448-70-DKMri8in01@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24448

--- Comment #9 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
> 
> What's the difference between 
> 
> subscriptions->count 
> subscriptions->subscription_count
> 
> in terms of the API? The first looks more standardized to me?

Oh!.... this is a method in Biblio - that makes more sense now!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 21 14:10:03 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 21 Jan 2020 13:10:03 +0000
Subject: [Koha-bugs] [Bug 24448] Add Koha::Biblio->subscriptions_count
In-Reply-To: <bug-24448-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24448-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24448-70-MgsFcDpvIS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24448

--- Comment #10 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
I will comment on koha-devel.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 21 14:15:59 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 21 Jan 2020 13:15:59 +0000
Subject: [Koha-bugs] [Bug 24466] New: AllowHoldsOnPatronsPossessions and the
 REST API
Message-ID: <bug-24466-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24466

            Bug ID: 24466
           Summary: AllowHoldsOnPatronsPossessions and the REST API
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: Hold requests
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: magnus at libriotech.no
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com

A library in Sweden has reported the following problem: 

AllowHoldsOnPatronsPossessions = Do not allow. 

A patron borroes a book. A hold on the same book is then placed, for the same
patron, through the REST API:

curl --location --request POST 'https://{baseurl}/api/v1/holds/' \
--header 'Content-Type: text/plain' \
--header 'Authorization: Basic {base64-encoded user pwd}' \
--data-raw '{
"patron_id": {patronid},
"pickup_library_id": "{library}",
"biblio_id": {biblioid}
}'

And voila, the patron has a hold on a record from which they already have an
item on loan, contrary to the setting of the AllowHoldsOnPatronsPossessions
syspref. 

(I have not tested this, but do trust that the report from the library is
accurate.)

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 21 14:16:56 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 21 Jan 2020 13:16:56 +0000
Subject: [Koha-bugs] [Bug 23884] Merge strings.inc and browser-strings.inc
In-Reply-To: <bug-23884-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23884-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23884-70-KWdgPJVFM1@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23884

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #94615|0                           |1
        is obsolete|                            |

--- Comment #2 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 97659
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97659&action=edit
Bug 23884: Merge strings.inc and browser-strings.inc

This patch take the contents of the JavaScript in browser-strings.inc
and puts it in strings.inc. browser-strings.inc is deleted.

To test, apply the patch and perform a catalog search in the staff
client.

 - View any result. In the left-hand sidebar there should be a search
   results browser box with "previous" and "next" arrows and a link back
   to search results.
 - Click on each different "view" tab and confirm that the search
   results navigation box persists: Normal, MARC, Labeled MARC, ISBD,
   Items.
 - From any of these views select Edit -> Edit items. The same
   navigation box should appear.

Note: addbiblio.tt and stockrotation.tt are modified but feature doesn't
currently work on those pages.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 21 14:17:23 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 21 Jan 2020 13:17:23 +0000
Subject: [Koha-bugs] [Bug 23884] Merge strings.inc and browser-strings.inc
In-Reply-To: <bug-23884-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23884-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23884-70-L5FS2xY6cV@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23884

--- Comment #3 from Owen Leonard <oleonard at myacpl.org> ---
Rebased.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 21 14:21:49 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 21 Jan 2020 13:21:49 +0000
Subject: [Koha-bugs] [Bug 24432] order_by broken for date columns
In-Reply-To: <bug-24432-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24432-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24432-70-vrEXU1fWah@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24432

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 21 14:21:52 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 21 Jan 2020 13:21:52 +0000
Subject: [Koha-bugs] [Bug 24432] order_by broken for date columns
In-Reply-To: <bug-24432-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24432-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24432-70-q6rGfM8e23@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24432

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #97528|0                           |1
        is obsolete|                            |
  Attachment #97529|0                           |1
        is obsolete|                            |
  Attachment #97530|0                           |1
        is obsolete|                            |

--- Comment #9 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 97660
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97660&action=edit
Bug 24432: Regresion test

To test:
1. apply this patch
2. prove t/Koha/REST/Plugin/Query.t

Test should fail at this point.

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 21 14:21:56 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 21 Jan 2020 13:21:56 +0000
Subject: [Koha-bugs] [Bug 24432] order_by broken for date columns
In-Reply-To: <bug-24432-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24432-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24432-70-z77cR2qEW4@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24432

--- Comment #10 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 97661
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97661&action=edit
Bug 24432: add Koha::Objects->from_api_mapping

This patch adds from_api_mapping to Koha::Objects, in order to be able to get
the mapping from a result set.

To test:
1. apply this patch
2. prove t/db_dependent/Koha/Objects.t
3. sign off

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 21 14:22:00 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 21 Jan 2020 13:22:00 +0000
Subject: [Koha-bugs] [Bug 24432] order_by broken for date columns
In-Reply-To: <bug-24432-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24432-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24432-70-U2nBZhfE8s@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24432

--- Comment #11 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 97662
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97662&action=edit
Bug 24432: Use from_api_mapping to translate column name in _build_order_atom

Use the mapping instead of building a fake hash only to get the key name.

To test:
1. apply this patch
2. prove t/Koha/REST/Plugin/Query.t
3. sign off

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 21 14:22:39 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 21 Jan 2020 13:22:39 +0000
Subject: [Koha-bugs] [Bug 23594] Batch modification for itemtypes on
 suggestions page
In-Reply-To: <bug-23594-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23594-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23594-70-ifkcNWHgHO@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23594

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Patch doesn't apply         |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 21 14:22:43 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 21 Jan 2020 13:22:43 +0000
Subject: [Koha-bugs] [Bug 23594] Batch modification for itemtypes on
 suggestions page
In-Reply-To: <bug-23594-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23594-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23594-70-irlKfSaGhe@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23594

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #94834|0                           |1
        is obsolete|                            |
  Attachment #94835|0                           |1
        is obsolete|                            |
  Attachment #94836|0                           |1
        is obsolete|                            |

--- Comment #11 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 97663
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97663&action=edit
Bug 23594: Batch modification for itemtypes on suggestions page

This new enhancement adds the ability to update the item types for
selected suggestions on the suggestions management page
(suggestion/suggestion.pl)

To achieve this goal we needed to refresh a bit the template, in order
to get rid of weird code. To not recreate the previous coding awkwardness
some code has been rewritten (mainly the removal of suggestiontype)

Test plan:
- Create some suggestions
- On the suggestions management page, select some of them and a new item
types.
- Submit the form and confirm that the itemtype of the suggestions has
been updated

- Also you should confirm that the "delete" and "change status" still
work as before

Sponsored-by: BULAC - http://www.bulac.fr/

Signed-off-by: Séverine QUEUNE <severine.queune at bulac.fr>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 21 14:22:48 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 21 Jan 2020 13:22:48 +0000
Subject: [Koha-bugs] [Bug 23594] Batch modification for itemtypes on
 suggestions page
In-Reply-To: <bug-23594-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23594-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23594-70-fb2UrF1f9D@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23594

--- Comment #12 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 97664
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97664&action=edit
Bug 23594: Fix [un]checkall links

Sponsored-by: BULAC - http://www.bulac.fr/

Signed-off-by: Séverine QUEUNE <severine.queune at bulac.fr>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 21 14:22:52 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 21 Jan 2020 13:22:52 +0000
Subject: [Koha-bugs] [Bug 23594] Batch modification for itemtypes on
 suggestions page
In-Reply-To: <bug-23594-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23594-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23594-70-EHoHDbPu89@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23594

--- Comment #13 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 97665
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97665&action=edit
Bug 23594: Restore previous view after delete or update itemtype

We want to restore the previous view when suggestions are deleted or
their itemtypes are updated.
To avoid c/p the code is moved to a new subroutine.

Sponsored-by: BULAC - http://www.bulac.fr/

Signed-off-by: Séverine QUEUNE <severine.queune at bulac.fr>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 21 14:23:22 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 21 Jan 2020 13:23:22 +0000
Subject: [Koha-bugs] [Bug 23594] Batch modification for itemtypes on
 suggestions page
In-Reply-To: <bug-23594-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23594-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23594-70-fOUGlkuG3p@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23594

--- Comment #14 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Conflict with bug 16784 fixed.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 21 14:23:34 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 21 Jan 2020 13:23:34 +0000
Subject: [Koha-bugs] [Bug 24095] Missing MSG_CONFIRM_DELETE_HOLD variable on
 the OPAC user account page
In-Reply-To: <bug-24095-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24095-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24095-70-aycwgptGft@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24095

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |DUPLICATE
             Status|Needs Signoff               |RESOLVED

--- Comment #3 from Owen Leonard <oleonard at myacpl.org> ---
I duped my own patch!

*** This bug has been marked as a duplicate of bug 24433 ***

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 21 14:23:34 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 21 Jan 2020 13:23:34 +0000
Subject: [Koha-bugs] [Bug 24433] OPAC account page no longer asks for
 confirmation before deleting hold
In-Reply-To: <bug-24433-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24433-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24433-70-pjq4KpC87K@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24433

--- Comment #5 from Owen Leonard <oleonard at myacpl.org> ---
*** Bug 24095 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 21 14:43:55 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 21 Jan 2020 13:43:55 +0000
Subject: [Koha-bugs] [Bug 22868] Circulation staff with suggestions_manage
 can have access to acquisition data
In-Reply-To: <bug-22868-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22868-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22868-70-by7X4dO1Bn@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22868

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #97334|0                           |1
        is obsolete|                            |

--- Comment #20 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 97666
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97666&action=edit
Bug 22868: Move suggestions_manage subperm out of acquisition perm

Bug 11911 replaced the permission of suggestions.pl (create a purchase
suggestion) from catalogue => 1 to acquisition => 'suggestions_manage'.
However we have a lot of acquisition scripts that have lax permissions
(acquisition => '*' which means any sub permissions of acquisition is
enough).

That causes problem when a circulation staff can create purchase
suggestions but not access acquisition information.

One solution is to move the suggestions_manage subpermission out of the
acquisition permission and create a new suggestion permission.

Test plan:
0. Setup
* Create a patron with several permission (and full acquisition
permission)
* Create another patron with several permission, and suggestions_manage
permission
* Create another patron without the suggestions_manage permission
1. Apply the patch and execute the update database entry
2. Note that the third patron you create still does not have
suggestions_manage
3. Confirm that you can create a purchase suggestion if you have
suggestions_manage, but cannot access acquisition pages if you do not
have any subpermissions of the acquisition permission

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 21 15:03:19 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 21 Jan 2020 14:03:19 +0000
Subject: [Koha-bugs] [Bug 21674] Data integrity not enforced for library
 groups
In-Reply-To: <bug-21674-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21674-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21674-70-vPFSLRCgfo@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21674

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 21 15:03:23 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 21 Jan 2020 14:03:23 +0000
Subject: [Koha-bugs] [Bug 21674] Data integrity not enforced for library
 groups
In-Reply-To: <bug-21674-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21674-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21674-70-AHDmcNJMF4@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21674

--- Comment #7 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 97667
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97667&action=edit
Bug 21674: Remove duplicates from library_groups before adding the uniq
constraint

To avoid to make it fails if duplicates existed prior to this change

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 21 15:04:46 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 21 Jan 2020 14:04:46 +0000
Subject: [Koha-bugs] [Bug 21674] Data integrity not enforced for library
 groups
In-Reply-To: <bug-21674-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21674-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21674-70-uLv9QjCLT0@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21674

--- Comment #8 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
(In reply to Jonathan Druart from comment #7)
> Created attachment 97667 [details] [review]
> Bug 21674: Remove duplicates from library_groups before adding the uniq
> constraint
> 
> To avoid to make it fails if duplicates existed prior to this change

There is certainly a more efficient (SQL) way to do that.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 21 15:10:36 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 21 Jan 2020 14:10:36 +0000
Subject: [Koha-bugs] [Bug 23753] Background job JavaScript should not try to
 call humanMsg library
In-Reply-To: <bug-23753-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23753-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23753-70-bM16KPB2tP@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23753

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |nick at bywatersolutions.com
         Depends on|                            |19417


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19417
[Bug 19417] Improve display of errors from background job during stage for
import
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 21 15:10:36 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 21 Jan 2020 14:10:36 +0000
Subject: [Koha-bugs] [Bug 19417] Improve display of errors from background
 job during stage for import
In-Reply-To: <bug-19417-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19417-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19417-70-nhfBnphcpW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19417

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |23753


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23753
[Bug 23753] Background job JavaScript should not try to call humanMsg library
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 21 15:13:25 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 21 Jan 2020 14:13:25 +0000
Subject: [Koha-bugs] [Bug 24467] New: *_count methods should be avoided
Message-ID: <bug-24467-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24467

            Bug ID: 24467
           Summary: *_count methods should be avoided
 Change sponsored?: ---
           Product: Koha
           Version: unspecified
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: Architecture, internals, and plumbing
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: jonathan.druart at bugs.koha-community.org
        QA Contact: testopia at bugs.koha-community.org

Several new methods have been added recently to retrieve the number of elements
returned (items_count, subscriptions_count, etc.)
We should find a way to avoid that, as the callers can call ->count easily.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 21 15:14:12 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 21 Jan 2020 14:14:12 +0000
Subject: [Koha-bugs] [Bug 24467] *_count methods should be avoided
In-Reply-To: <bug-24467-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24467-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24467-70-51cuC3tVRt@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24467

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |24435


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24435
[Bug 24435] Add Koha::Biblio->items_count
-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 21 15:14:12 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 21 Jan 2020 14:14:12 +0000
Subject: [Koha-bugs] [Bug 24435] Add Koha::Biblio->items_count
In-Reply-To: <bug-24435-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24435-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24435-70-n9qaGdWJiW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24435

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |24467


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24467
[Bug 24467] *_count methods should be avoided
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 21 15:15:53 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 21 Jan 2020 14:15:53 +0000
Subject: [Koha-bugs] [Bug 24467] *_count methods should be avoided
In-Reply-To: <bug-24467-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24467-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24467-70-YM5hSCI7eA@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24467

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |24430, 24448


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24430
[Bug 24430] Remove C4::Biblio::CountBiblioInOrders
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24448
[Bug 24448] Add Koha::Biblio->subscriptions_count
-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 21 15:15:53 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 21 Jan 2020 14:15:53 +0000
Subject: [Koha-bugs] [Bug 24430] Remove C4::Biblio::CountBiblioInOrders
In-Reply-To: <bug-24430-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24430-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24430-70-EQuvRfl8pq@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24430

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |24467


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24467
[Bug 24467] *_count methods should be avoided
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 21 15:15:53 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 21 Jan 2020 14:15:53 +0000
Subject: [Koha-bugs] [Bug 24448] Add Koha::Biblio->subscriptions_count
In-Reply-To: <bug-24448-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24448-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24448-70-vtIKxLZF5F@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24448

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |24467


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24467
[Bug 24467] *_count methods should be avoided
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 21 15:16:04 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 21 Jan 2020 14:16:04 +0000
Subject: [Koha-bugs] [Bug 24467] *_count methods should be avoided
In-Reply-To: <bug-24467-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24467-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24467-70-sI8vxl2G9k@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24467

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |tomascohen at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 21 15:32:07 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 21 Jan 2020 14:32:07 +0000
Subject: [Koha-bugs] [Bug 24467] Add a syntax for specifying counts on
 x-koha-embed
In-Reply-To: <bug-24467-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24467-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24467-70-ym20uFB6Xw@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24467

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |agustinmoyano at theke.io,
                   |                            |martin.renvoize at ptfs-europe
                   |                            |.com
            Summary|*_count methods should be   |Add a syntax for specifying
                   |avoided                     |counts on x-koha-embed
          Component|Architecture, internals,    |REST API
                   |and plumbing                |
            Version|unspecified                 |master
         Depends on|24430, 24448                |
         QA Contact|testopia at bugs.koha-communit |
                   |y.org                       |
           Assignee|koha-bugs at lists.koha-commun |tomascohen at gmail.com
                   |ity.org                     |
             Status|NEW                         |ASSIGNED

--- Comment #1 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Removing the introduced *_count methods will be a follow-up for this new
feature if that's ok with you, Jonathan. I mean part of this bug.


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24430
[Bug 24430] Remove C4::Biblio::CountBiblioInOrders
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24448
[Bug 24448] Add Koha::Biblio->subscriptions_count
-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 21 15:32:07 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 21 Jan 2020 14:32:07 +0000
Subject: [Koha-bugs] [Bug 24430] Remove C4::Biblio::CountBiblioInOrders
In-Reply-To: <bug-24430-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24430-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24430-70-zkKfSjry7q@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24430

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|24467                       |


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24467
[Bug 24467] Add a syntax for specifying counts on x-koha-embed
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 21 15:32:07 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 21 Jan 2020 14:32:07 +0000
Subject: [Koha-bugs] [Bug 24448] Add Koha::Biblio->subscriptions_count
In-Reply-To: <bug-24448-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24448-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24448-70-ngJOxFL5Om@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24448

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|24467                       |


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24467
[Bug 24467] Add a syntax for specifying counts on x-koha-embed
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 21 15:33:34 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 21 Jan 2020 14:33:34 +0000
Subject: [Koha-bugs] [Bug 24467] Add a syntax for specifying counts on
 x-koha-embed
In-Reply-To: <bug-24467-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24467-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24467-70-DjgIdOvcg8@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24467

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|normal                      |enhancement

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 21 15:34:30 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 21 Jan 2020 14:34:30 +0000
Subject: [Koha-bugs] [Bug 21633] Did finesMode = test ever send email?
In-Reply-To: <bug-21633-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21633-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21633-70-9AUhSkxtq5@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21633

--- Comment #11 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
(In reply to Jonathan Druart from comment #9)
> Also there are 2 NULL and 136 "", maybe we should deal with them here.

Dealing with that here or somewhere else?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 21 15:47:27 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 21 Jan 2020 14:47:27 +0000
Subject: [Koha-bugs] [Bug 23929] Invoice adjustments should filter inactive
 funds
In-Reply-To: <bug-23929-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23929-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23929-70-oojQPt4QXV@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23929

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org

--- Comment #5 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
We usually have a "Show inactive" checkbox right after the dropdown list.
Should not we implement that here as well?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 21 15:49:17 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 21 Jan 2020 14:49:17 +0000
Subject: [Koha-bugs] [Bug 24441] Error when checking in an item with
 BranchTansferLimitsType set to itemtype
In-Reply-To: <bug-24441-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24441-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24441-70-c9rgpmF1mV@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24441

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |21206
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21206
[Bug 21206] C4::Items - Remove GetItem
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 21 15:49:17 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 21 Jan 2020 14:49:17 +0000
Subject: [Koha-bugs] [Bug 21206] C4::Items - Remove GetItem
In-Reply-To: <bug-21206-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21206-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21206-70-xnfMkwm7rF@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21206

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |24441


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24441
[Bug 24441] Error when checking in an item with BranchTansferLimitsType set to
itemtype
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 21 15:51:05 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 21 Jan 2020 14:51:05 +0000
Subject: [Koha-bugs] [Bug 24468] New: C4::Reserves::_get_itype is no longer
 used
Message-ID: <bug-24468-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24468

            Bug ID: 24468
           Summary: C4::Reserves::_get_itype is no longer used
 Change sponsored?: ---
           Product: Koha
           Version: unspecified
          Hardware: All
                OS: All
            Status: ASSIGNED
          Severity: enhancement
          Priority: P5 - low
         Component: Architecture, internals, and plumbing
          Assignee: jonathan.druart at bugs.koha-community.org
          Reporter: jonathan.druart at bugs.koha-community.org
        QA Contact: testopia at bugs.koha-community.org
        Depends on: 21206

Since bug 21206, C4::Reserves::_get_itype is not longer used and should be
removed.

  commit 31c29fd31f557306233e6a2936148a5bb10b89a1
  Bug 21206: Replace C4::Items::GetItem


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21206
[Bug 21206] C4::Items - Remove GetItem
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 21 15:51:05 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 21 Jan 2020 14:51:05 +0000
Subject: [Koha-bugs] [Bug 21206] C4::Items - Remove GetItem
In-Reply-To: <bug-21206-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21206-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21206-70-Vzn5V8zsWb@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21206

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |24468


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24468
[Bug 24468] C4::Reserves::_get_itype is no longer used
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 21 15:52:47 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 21 Jan 2020 14:52:47 +0000
Subject: [Koha-bugs] [Bug 24468] C4::Reserves::_get_itype is no longer used
In-Reply-To: <bug-24468-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24468-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24468-70-z2RIBfLuaa@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24468

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 21 15:52:50 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 21 Jan 2020 14:52:50 +0000
Subject: [Koha-bugs] [Bug 24468] C4::Reserves::_get_itype is no longer used
In-Reply-To: <bug-24468-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24468-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24468-70-MYtVGmZRxY@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24468

--- Comment #1 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 97668
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97668&action=edit
Bug 24468: Remove unused C4::Reserves::_get_itype subroutine

Since bug 21206, C4::Reserves::_get_itype is not longer used and should
be removed.

  commit 31c29fd31f557306233e6a2936148a5bb10b89a1
  Bug 21206: Replace C4::Items::GetItem

Test plan:
  % git grep _get_itype
must not return any occurrences.

If one needs it, Koha::Item->effective_itemtype must be used instead.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 21 15:54:18 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 21 Jan 2020 14:54:18 +0000
Subject: [Koha-bugs] [Bug 20847] Add more fields to the Batch Patron
 Modification tool
In-Reply-To: <bug-20847-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20847-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20847-70-ByK6bCm6z0@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20847

--- Comment #4 from David Roberts <david.roberts at ptfs-europe.com> ---
The primary email address can now be edited after Bug 19793 has been pushed.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 21 15:58:44 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 21 Jan 2020 14:58:44 +0000
Subject: [Koha-bugs] [Bug 24467] *_count methods should be avoided
In-Reply-To: <bug-24467-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24467-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24467-70-5mp8ooXUkp@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24467

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         QA Contact|                            |testopia at bugs.koha-communit
                   |                            |y.org
          Component|REST API                    |Architecture, internals,
                   |                            |and plumbing
         Depends on|                            |24430, 24448
           Assignee|tomascohen at gmail.com        |koha-bugs at lists.koha-commun
                   |                            |ity.org
            Summary|Add a syntax for specifying |*_count methods should be
                   |counts on x-koha-embed      |avoided


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24430
[Bug 24430] Remove C4::Biblio::CountBiblioInOrders
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24448
[Bug 24448] Add Koha::Biblio->subscriptions_count
-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 21 15:58:44 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 21 Jan 2020 14:58:44 +0000
Subject: [Koha-bugs] [Bug 24430] Remove C4::Biblio::CountBiblioInOrders
In-Reply-To: <bug-24430-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24430-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24430-70-T8nwZf4Gk6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24430

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |24467


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24467
[Bug 24467] *_count methods should be avoided
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 21 15:58:44 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 21 Jan 2020 14:58:44 +0000
Subject: [Koha-bugs] [Bug 24448] Add Koha::Biblio->subscriptions_count
In-Reply-To: <bug-24448-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24448-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24448-70-XW9EVKoV0T@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24448

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |24467


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24467
[Bug 24467] *_count methods should be avoided
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 21 15:58:53 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 21 Jan 2020 14:58:53 +0000
Subject: [Koha-bugs] [Bug 24467] *_count methods should be avoided
In-Reply-To: <bug-24467-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24467-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24467-70-vWjBZAU8g0@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24467

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |NEW

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 21 16:02:12 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 21 Jan 2020 15:02:12 +0000
Subject: [Koha-bugs] [Bug 24467] *_count methods should be avoided
In-Reply-To: <bug-24467-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24467-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24467-70-DhJPigkQcM@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24467

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |josef.moravec at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 21 16:08:48 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 21 Jan 2020 15:08:48 +0000
Subject: [Koha-bugs] [Bug 24441] Error when checking in an item with
 BranchTansferLimitsType set to itemtype
In-Reply-To: <bug-24441-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24441-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24441-70-SM3fcnaenr@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24441

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 21 16:08:51 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 21 Jan 2020 15:08:51 +0000
Subject: [Koha-bugs] [Bug 24441] Error when checking in an item with
 BranchTansferLimitsType set to itemtype
In-Reply-To: <bug-24441-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24441-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24441-70-7MSH8xu7Zm@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24441

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #97513|0                           |1
        is obsolete|                            |

--- Comment #3 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 97669
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97669&action=edit
Bug 24441: Add tests

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 21 16:08:56 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 21 Jan 2020 15:08:56 +0000
Subject: [Koha-bugs] [Bug 24441] Error when checking in an item with
 BranchTansferLimitsType set to itemtype
In-Reply-To: <bug-24441-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24441-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24441-70-EYMvL0Wdyn@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24441

--- Comment #4 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 97670
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97670&action=edit
Bug 24441: Error when checking in an item with BranchTansferLimitsType set to
itemtype

It appears that the transition to using Koha::Item in AddReturn has introduced
a bug. Previously $item was a hashref with the key 'itemtype', now that it's an
object, it has no itemtype method and so triggers an error with the message
"The method Koha::Item->itemtype is not covered by tests!".

Test Plan:
1) Enable Branch Transfer Limits via itemtype
2) Check in an item
3) Note the error
4) Apply this patch
5) Restart all the things!
6) Check in an item
7) No error!

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

Signed-off-by: Maribeth (Turner) Shafer - Central Kansas Library System CKLS
<mshafer at ckls.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 21 16:10:58 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 21 Jan 2020 15:10:58 +0000
Subject: [Koha-bugs] [Bug 24380] Backdated returns do not update fines
 unless CalculateFinesOnReturn is enabled
In-Reply-To: <bug-24380-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24380-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24380-70-aUaQ3089O8@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24380

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |14591
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14591
[Bug 14591] book drop / drop box mode incorrectly decrements accrued overdue
fines
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 21 16:10:58 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 21 Jan 2020 15:10:58 +0000
Subject: [Koha-bugs] [Bug 14591] book drop / drop box mode incorrectly
 decrements accrued overdue fines
In-Reply-To: <bug-14591-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14591-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14591-70-aIP1gwuVs4@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14591

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |24380


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24380
[Bug 24380] Backdated returns do not update fines unless CalculateFinesOnReturn
is enabled
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 21 16:11:39 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 21 Jan 2020 15:11:39 +0000
Subject: [Koha-bugs] [Bug 13897] Use YAML files for installer data
In-Reply-To: <bug-13897-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13897-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13897-70-yXdgJc7Ff5@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13897

--- Comment #49 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Does this get your final PQA stamp now Jonathan?  It looks like between the two
bugs we have all that is required to me.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 21 16:13:49 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 21 Jan 2020 15:13:49 +0000
Subject: [Koha-bugs] [Bug 24380] Backdated returns do not update fines
 unless CalculateFinesOnReturn is enabled
In-Reply-To: <bug-24380-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24380-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24380-70-iY8NATU3rs@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24380

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Failed QA

--- Comment #3 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Kyle, can you provide tests please?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 21 16:19:43 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 21 Jan 2020 15:19:43 +0000
Subject: [Koha-bugs] [Bug 24286] FindDuplicateAuthority does not escape
 forward slash in 'GENRE/FORM'
In-Reply-To: <bug-24286-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24286-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24286-70-BtsfydYKpv@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24286

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 21 16:19:47 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 21 Jan 2020 15:19:47 +0000
Subject: [Koha-bugs] [Bug 24286] FindDuplicateAuthority does not escape
 forward slash in 'GENRE/FORM'
In-Reply-To: <bug-24286-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24286-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24286-70-5MIQh7JvhL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24286

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #97582|0                           |1
        is obsolete|                            |

--- Comment #7 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 97671
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97671&action=edit
Bug 24286: Escape forward slash in GENRE/FORM (and any authtype)

Note that bug 24267 will fix the issue during Z39 searching for new auth, but
the duplicate check at saving will still fail

To test:
 0 - Set SearchEngine to Elasticsearch,  QueryRegexEscapeOptions  to 'Don't
Escape'
 1 - Browse to Authorities
 2 - Select New->New from Z3950
 3 - Search for subject 'Short stories'
 4 - Auth search explodes
 5 - Apply patch
 6 - Repeat and confirm the search results return
 7 - Import and save the GENRE/FORM record for Short stories
 8 - Repeat the search and import the same record
 9 - Confirm that upon save you are notified of duplicate, don't save
10 - set  QueryRegexEscapeOptions to 'Escape' and confirm Z39 searching works
and importing/save notifies of duplicate
11 - set SearchEngine to Zebra and confirm Z39 searching works and
importing/save notifies of duplicate

Signed-off-by: Kelly McElligott <kelly at bywatersolutions.com>
Signed-off-by: Myka Kennedy Stephens <mkstephens at lancasterseminary.edu>

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 21 16:21:59 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 21 Jan 2020 15:21:59 +0000
Subject: [Koha-bugs] [Bug 24421] Generated authorities are missing subfields
In-Reply-To: <bug-24421-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24421-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24421-70-YjYcEtHt4w@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24421

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Failed QA
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org

--- Comment #5 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Nick, can you cover the change with tests please?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 21 16:24:31 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 21 Jan 2020 15:24:31 +0000
Subject: [Koha-bugs] [Bug 24331] Internal server error when placing hold on
 item if itemtype undefined
In-Reply-To: <bug-24331-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24331-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24331-70-e2JweexDNG@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24331

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org

--- Comment #4 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Nick, did not we (more or less) agree that we should not test if items had
valid item type?
See bug 21842.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 21 16:24:36 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 21 Jan 2020 15:24:36 +0000
Subject: [Koha-bugs] [Bug 24331] Internal server error when placing hold on
 item if itemtype undefined
In-Reply-To: <bug-24331-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24331-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24331-70-1LvPvvU5EO@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24331

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=21842

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 21 16:24:36 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 21 Jan 2020 15:24:36 +0000
Subject: [Koha-bugs] [Bug 21842] always test Koha::ItemType in defined
In-Reply-To: <bug-21842-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21842-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21842-70-IaedLi5aXs@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21842

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=24331

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 21 16:31:03 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 21 Jan 2020 15:31:03 +0000
Subject: [Koha-bugs] [Bug 24469] New: Record biblionumber in import_biblio
 when adding to basket via file
Message-ID: <bug-24469-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24469

            Bug ID: 24469
           Summary: Record biblionumber in import_biblio when adding to
                    basket via file
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: Acquisitions
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: andrew at bywatersolutions.com
        QA Contact: testopia at bugs.koha-community.org

When we stage and then import a file through tools, the biblionumber of the
created record gets recorded in import_biblios.matched_biblionumber.

When we stage a file and then use it to populate a basket in acquisitions,
import_biblio.matched_biblionumber does not get populated. We see the same
behavior whether the basket is populated using "From a staged file" or "From a
new file."

To Test:
- Create a basket
- Add to basket From a New File
- Select a marc file and stage without checking for duplicates
- Add titles to your basket
- Confirm from acquisitions that new bibs were created
- Go to manage-marc-import.pl and find your file
- Confirm that the Record column is empty

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 21 16:33:55 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 21 Jan 2020 15:33:55 +0000
Subject: [Koha-bugs] [Bug 24397] populate_db.pl is out of sync and must be
 removed
In-Reply-To: <bug-24397-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24397-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24397-70-kQtepbCKBT@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24397

--- Comment #7 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
It really is a Dev only script so I feel it indeed belongs in its own place.

Happy for it to be removed from Koha's core repo.

I think the Dev tools do get enough exposure living in misc4dev

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 21 16:37:02 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 21 Jan 2020 15:37:02 +0000
Subject: [Koha-bugs] [Bug 24470] New: Set import_status when file used to
 populate basket in acquisitions
Message-ID: <bug-24470-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24470

            Bug ID: 24470
           Summary: Set import_status when file used to populate basket in
                    acquisitions
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: Acquisitions
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: andrew at bywatersolutions.com
        QA Contact: testopia at bugs.koha-community.org

When a staged MARC file is used to populate a basket in acquisitions,
import_batches.import_status remains set to "staged" even though those records
have been imported.

To test:
- Create a basket
- Add to basket From a New File
- Select a marc file and stage without checking for duplicates
- Add titles to your basket
- Confirm from acquisitions that new bibs were created
- Go to manage-marc-import.pl and find your file
- Confirm that you are still given an "Import this batch into the catalog"
button
- Query import_batches.import_status and confirm it shows "staged"

We could set the status to the existing value of "imported" or could create a
new status unique to acquisitions.

See also bug 24469 about import_biblios.matched_biblionumber.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 21 16:37:22 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 21 Jan 2020 15:37:22 +0000
Subject: [Koha-bugs] [Bug 24470] Set import_status when file used to
 populate basket in acquisitions
In-Reply-To: <bug-24470-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24470-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24470-70-0jeyU1XE4T@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24470

Andrew Fuerste-Henry <andrew at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=24469

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 21 16:37:22 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 21 Jan 2020 15:37:22 +0000
Subject: [Koha-bugs] [Bug 24469] Record biblionumber in import_biblio when
 adding to basket via file
In-Reply-To: <bug-24469-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24469-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24469-70-5c7Ejfhv2t@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24469

Andrew Fuerste-Henry <andrew at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=24470

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 21 16:52:25 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 21 Jan 2020 15:52:25 +0000
Subject: [Koha-bugs] [Bug 23844] Noisy warns in addbiblio.pl when importing
 from Z3950
In-Reply-To: <bug-23844-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23844-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23844-70-1EixDClPWu@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23844

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org

--- Comment #4 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Nick, I only get those:

Use of uninitialized value $frameworkcode in string eq at
/kohadevbox/koha/cataloguing/addbiblio.pl line 708.
Use of uninitialized value $frameworkcode in string eq at
/kohadevbox/koha/cataloguing/addbiblio.pl line 712.
Use of uninitialized value $frameworkcode in string eq at
/kohadevbox/koha/cataloguing/addbiblio.pl line 731.


Who did you end up with tab that is NULL?

I get:
MariaDB [koha_kohadev]> select distinct(tab) from marc_subfield_structure;
+------+
| tab  |
+------+
|   -1 |
|    0 |
|    1 |
|    2 |
|    3 |
|    4 |
|    5 |
|    6 |
|    7 |
|    8 |
|    9 |
|   10 |
+------+
12 rows in set (0.03 sec)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 21 16:59:03 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 21 Jan 2020 15:59:03 +0000
Subject: [Koha-bugs] [Bug 24457] K::A::Basket->to_api is not passing the
 parameters to the parent class implementation
In-Reply-To: <bug-24457-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24457-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24457-70-cxE2iQXHCK@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24457

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org

--- Comment #5 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
What about Koha/Acquisition/Invoice.pm and Koha/Patron.pm?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 21 16:59:41 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 21 Jan 2020 15:59:41 +0000
Subject: [Koha-bugs] [Bug 24457] K::A::Basket->to_api is not passing the
 parameters to the parent class implementation
In-Reply-To: <bug-24457-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24457-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24457-70-vo4wy3t8hu@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24457

--- Comment #6 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
(In reply to Jonathan Druart from comment #5)
> What about Koha/Acquisition/Invoice.pm and Koha/Patron.pm?

On bug 24459 I guess...

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 21 17:03:50 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 21 Jan 2020 16:03:50 +0000
Subject: [Koha-bugs] [Bug 24457] K::A::Basket->to_api is not passing the
 parameters to the parent class implementation
In-Reply-To: <bug-24457-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24457-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24457-70-L6O4pOsCTR@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24457

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 21 17:03:55 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 21 Jan 2020 16:03:55 +0000
Subject: [Koha-bugs] [Bug 24457] K::A::Basket->to_api is not passing the
 parameters to the parent class implementation
In-Reply-To: <bug-24457-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24457-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24457-70-rBbqBYNCkQ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24457

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #97588|0                           |1
        is obsolete|                            |
  Attachment #97589|0                           |1
        is obsolete|                            |

--- Comment #7 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 97672
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97672&action=edit
Bug 24457: Regression tests

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

Signed-off-by: David Nind <david at davidnind.com>

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 21 17:03:59 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 21 Jan 2020 16:03:59 +0000
Subject: [Koha-bugs] [Bug 24457] K::A::Basket->to_api is not passing the
 parameters to the parent class implementation
In-Reply-To: <bug-24457-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24457-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24457-70-GMH0axGfvI@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24457

--- Comment #8 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 97673
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97673&action=edit
Bug 24457: Make overloaded ->to_api pass the params to parent method

This patch makes the overloaded to_api method for baskets care about the
remaining parameters, and pass them to SUPER::to_api.

To test:
1. Apply the regression tests
2. Run:
   $ kshell
  k$ prove t/db_dependent/Koha/Acquisition/Basket.t
=> FAIL: Tests fail! No embedded bookseller!
3. Apply this patch
4. Repeat 2
=> SUCCESS: Tests pass!
5. Sign off :-D

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

Signed-off-by: David Nind <david at davidnind.com>

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 21 17:04:34 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 21 Jan 2020 16:04:34 +0000
Subject: [Koha-bugs] [Bug 24459] Overloaded ->to_api needs to pass $params
 through
In-Reply-To: <bug-24459-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24459-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24459-70-eFPgV67xC0@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24459

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 21 17:04:38 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 21 Jan 2020 16:04:38 +0000
Subject: [Koha-bugs] [Bug 24459] Overloaded ->to_api needs to pass $params
 through
In-Reply-To: <bug-24459-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24459-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24459-70-zfeSvYQZ5D@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24459

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #97621|0                           |1
        is obsolete|                            |
  Attachment #97622|0                           |1
        is obsolete|                            |

--- Comment #4 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 97674
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97674&action=edit
Bug 24459: Regression tests

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 21 17:04:42 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 21 Jan 2020 16:04:42 +0000
Subject: [Koha-bugs] [Bug 24459] Overloaded ->to_api needs to pass $params
 through
In-Reply-To: <bug-24459-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24459-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24459-70-g5W1CNkww7@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24459

--- Comment #5 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 97675
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97675&action=edit
Bug 24459: Make ->to_api pass $params through

This patch makes the to_api method in Koha::Acquisition::Inovice and
Koha::Patron pass the passed parameters to the base class to_api method.
This is required for things like embedding related objects.

To test:
1. Apply the regression tests patch
2. Run:
   $ kshell
  k$ prove t/db_dependent/Koha/Patron.t \
           t/db_dependent/Koha/Acquisition/Invoice.t
=> FAIL: Tests fail!
3. Apply this patch
4. Repeat 2
=> SUCCESS: Tests pass!
5. Sign off :-D

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 21 17:05:09 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 21 Jan 2020 16:05:09 +0000
Subject: [Koha-bugs] [Bug 24459] Overloaded ->to_api needs to pass $params
 through
In-Reply-To: <bug-24459-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24459-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24459-70-Od2mzHHDfV@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24459

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org
             Status|Signed Off                  |Passed QA

--- Comment #6 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Trivial, same as bug 24457, skipping QA.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 21 17:10:08 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 21 Jan 2020 16:10:08 +0000
Subject: [Koha-bugs] [Bug 24339] SIP codes are missing from the default
 payment_types on installation
In-Reply-To: <bug-24339-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24339-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24339-70-hPL06evEYt@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24339

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Signed Off

--- Comment #5 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Regarding test plan, the Payments types are just Authorized Values as they have
been for years.. this patch just ensures they are present for installs
(currently they're just populated during upgrades).

Hmm, I can't replicate your test failure either :(

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 21 17:10:44 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 21 Jan 2020 16:10:44 +0000
Subject: [Koha-bugs] [Bug 24339] SIP codes are missing from the default
 payment_types on installation
In-Reply-To: <bug-24339-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24339-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24339-70-fSYxAKFSDq@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24339

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #96976|0                           |1
        is obsolete|                            |

--- Comment #6 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 97676
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97676&action=edit
Bug 24339: Add SIP2 payment types for installation

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 21 17:10:47 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 21 Jan 2020 16:10:47 +0000
Subject: [Koha-bugs] [Bug 24339] SIP codes are missing from the default
 payment_types on installation
In-Reply-To: <bug-24339-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24339-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24339-70-LjjbV4VbHW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24339

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #96988|0                           |1
        is obsolete|                            |

--- Comment #7 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 97677
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97677&action=edit
Bug 24339: Remove SIP payment types from staff pay screens

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 21 17:16:22 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 21 Jan 2020 16:16:22 +0000
Subject: [Koha-bugs] [Bug 24471] New: Rename ILL method handle_commit_maybe
Message-ID: <bug-24471-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24471

            Bug ID: 24471
           Summary: Rename ILL method handle_commit_maybe
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: ILL
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: andrew.isherwood at ptfs-europe.com

The naming of “handle_commit_maybe” is very misleading. As far as I can see
from comments and old commits, it was intended to do more at some point but all
it does, and has ever done, is redirect the user based on some conditions. A
better name would be something simpler like “redirect_user”

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 21 17:16:58 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 21 Jan 2020 16:16:58 +0000
Subject: [Koha-bugs] [Bug 24471] Rename ILL method handle_commit_maybe
In-Reply-To: <bug-24471-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24471-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24471-70-FXFbSO0cMw@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24471

Andrew Isherwood <andrew.isherwood at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |andrew.isherwood at ptfs-europ
                   |ity.org                     |e.com
             Status|NEW                         |ASSIGNED

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 21 17:20:07 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 21 Jan 2020 16:20:07 +0000
Subject: [Koha-bugs] [Bug 24471] Rename ILL method handle_commit_maybe
In-Reply-To: <bug-24471-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24471-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24471-70-ZBWdiw6S3D@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24471

Andrew Isherwood <andrew.isherwood at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 21 17:20:10 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 21 Jan 2020 16:20:10 +0000
Subject: [Koha-bugs] [Bug 24471] Rename ILL method handle_commit_maybe
In-Reply-To: <bug-24471-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24471-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24471-70-9pQLFLw1K9@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24471

--- Comment #1 from Andrew Isherwood <andrew.isherwood at ptfs-europe.com> ---
Created attachment 97678
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97678&action=edit
Bug 24471: handle_commit_maybe => redirect_user

This patch renames all occurrences of handle_commit_maybe to
redirect_user

Test plan:

- Navigate around ILL and check redirections from one action/stage to
another are happening correctly

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 21 17:23:04 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 21 Jan 2020 16:23:04 +0000
Subject: [Koha-bugs] [Bug 24472] New: Add ability to log changes to hold
 suspensions to action logs
Message-ID: <bug-24472-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24472

            Bug ID: 24472
           Summary: Add ability to log changes to hold suspensions to
                    action logs
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Circulation
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: kyle at bywatersolutions.com
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 21 17:39:24 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 21 Jan 2020 16:39:24 +0000
Subject: [Koha-bugs] [Bug 19809] Koha::Objects::find calls do not need to be
 forbidden in list context
In-Reply-To: <bug-19809-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19809-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19809-70-pZiL11jWmA@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19809

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |rel_20_05_target

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 21 17:40:49 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 21 Jan 2020 16:40:49 +0000
Subject: [Koha-bugs] [Bug 19809] Koha::Objects::find calls do not need to be
 forbidden in list context
In-Reply-To: <bug-19809-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19809-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19809-70-iOQEjrQlwO@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19809

--- Comment #27 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Personally, I'm pretty onboard with this.. moving us closer to DBIx::Class
seems reasonable and productive.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 21 17:52:10 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 21 Jan 2020 16:52:10 +0000
Subject: [Koha-bugs] [Bug 7468] Add label to batch by barcode range
In-Reply-To: <bug-7468-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-7468-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7468-70-qJagOhVvIM@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7468

--- Comment #63 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Label.pm of course.. I was never good at multi-tasking ;)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 21 18:01:41 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 21 Jan 2020 17:01:41 +0000
Subject: [Koha-bugs] [Bug 19735] Move Perl deps definitions into a cpanfile
In-Reply-To: <bug-19735-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19735-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19735-70-CvnxwqfmyH@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19735

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mirko at abunchofthings.net,
                   |                            |mtj at kohaaloha.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 21 18:03:29 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 21 Jan 2020 17:03:29 +0000
Subject: [Koha-bugs] [Bug 19735] Move Perl deps definitions into a cpanfile
In-Reply-To: <bug-19735-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19735-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19735-70-oLwaQ7kBeJ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19735

--- Comment #22 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
I like the idea of moving to cpanfile as it means moving away from koha
specific code and toward well maintained wider community code..

This patchset all looks solid to me, but I'm not a packaging expert so I'm not
sure how that side of things would be affected by this.. calling Mason and
Mirko for comment.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 21 18:06:20 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 21 Jan 2020 17:06:20 +0000
Subject: [Koha-bugs] [Bug 23237] Add support for [% INCLUDE %] in plugin
 templates
In-Reply-To: <bug-23237-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23237-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23237-70-4e1wNq5LPh@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23237

--- Comment #11 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Any further thoughts regarding Tomas's comment Frederic?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 21 18:06:43 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 21 Jan 2020 17:06:43 +0000
Subject: [Koha-bugs] [Bug 23237] Add support for [% INCLUDE %] in plugin
 templates
In-Reply-To: <bug-23237-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23237-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23237-70-J6U1qd01hI@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23237

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |additional_work_needed

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 21 18:09:37 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 21 Jan 2020 17:09:37 +0000
Subject: [Koha-bugs] [Bug 22658] aqbasket.authorisedby is missing a foreign
 key constraint
In-Reply-To: <bug-22658-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22658-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22658-70-L6gXcp4DPu@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22658

--- Comment #6 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Looking forward to seeing this one.. did you want me to have a bash at it Tomas
or were you intended to adopt it?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 21 18:19:53 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 21 Jan 2020 17:19:53 +0000
Subject: [Koha-bugs] [Bug 22658] aqbasket.authorisedby is missing a foreign
 key constraint
In-Reply-To: <bug-22658-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22658-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22658-70-DXG0l6phR3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22658

--- Comment #7 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
(In reply to Martin Renvoize from comment #6)
> Looking forward to seeing this one.. did you want me to have a bash at it
> Tomas or were you intended to adopt it?

I prefer to finish my works first. If it is not done yet, I'll pick it.
I intended to use it for bug 24464, but can adapt it once the relationship is
done.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 21 18:32:38 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 21 Jan 2020 17:32:38 +0000
Subject: [Koha-bugs] [Bug 8179] Receiving multiple order lines at once
In-Reply-To: <bug-8179-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-8179-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8179-70-E6dlfzw8CU@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8179

Barbara Johnson <barbara.johnson at bedfordtx.gov> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |barbara.johnson at bedfordtx.g
                   |                            |ov

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 21 18:32:47 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 21 Jan 2020 17:32:47 +0000
Subject: [Koha-bugs] [Bug 11161] Relabel 'child fund' to 'sub fund'
In-Reply-To: <bug-11161-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-11161-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11161-70-TeowQuzto0@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11161

David Roberts <david.roberts at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |david.roberts at ptfs-europe.c
                   |                            |om

--- Comment #3 from David Roberts <david.roberts at ptfs-europe.com> ---
I tried signing this off on the PTFS Sandbox, but it doesn't seem to apply
correctly.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 21 18:32:47 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 21 Jan 2020 17:32:47 +0000
Subject: [Koha-bugs] [Bug 8179] Receiving multiple order lines at once
In-Reply-To: <bug-8179-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-8179-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8179-70-4RqvEBPAXQ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8179

Aly <arattler at nwacc.edu> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |arattler at nwacc.edu

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 21 18:33:18 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 21 Jan 2020 17:33:18 +0000
Subject: [Koha-bugs] [Bug 8179] Receiving multiple order lines at once
In-Reply-To: <bug-8179-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-8179-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8179-70-boHVTuByGa@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8179

Christopher Kellermeyer <ckellermeyer at altadenalibrary.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |ckellermeyer at altadenalibrar
                   |                            |y.org

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 21 18:37:59 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 21 Jan 2020 17:37:59 +0000
Subject: [Koha-bugs] [Bug 13325] Add logs for budgets and funds
In-Reply-To: <bug-13325-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13325-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13325-70-7TVt5t5JYK@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13325

Marci <mchen at mckinneytexas.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mchen at mckinneytexas.org

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 21 18:38:39 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 21 Jan 2020 17:38:39 +0000
Subject: [Koha-bugs] [Bug 24473] New: Syndetics content should be $raw
 filtered on opac-detail.tt
Message-ID: <bug-24473-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24473

            Bug ID: 24473
           Summary: Syndetics content should be $raw filtered on
                    opac-detail.tt
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: minor
          Priority: P5 - low
         Component: OPAC
          Assignee: oleonard at myacpl.org
          Reporter: lucas at bywatersolutions.com
        QA Contact: testopia at bugs.koha-community.org

Syndetics offers enhanced content in the OPAC under the tabs 'Title Notes',
'Excerpt', 'About the author', 'Editions'. They provide this info as HTML
therefore we should filter it as $raw so the content shows up without the
markup.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 21 18:39:31 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 21 Jan 2020 17:39:31 +0000
Subject: [Koha-bugs] [Bug 24473] Syndetics content should be $raw filtered
 on opac-detail.tt
In-Reply-To: <bug-24473-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24473-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24473-70-1V71bnp9nJ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24473

Lucas Gass <lucas at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|oleonard at myacpl.org         |lucas at bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 21 18:53:34 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 21 Jan 2020 17:53:34 +0000
Subject: [Koha-bugs] [Bug 13371] Add filters to the supplier list view
In-Reply-To: <bug-13371-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13371-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13371-70-2uXDI6rgqP@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13371

Marci <mchen at mckinneytexas.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mchen at mckinneytexas.org

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 21 18:56:51 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 21 Jan 2020 17:56:51 +0000
Subject: [Koha-bugs] [Bug 24356] objects.search prefetch
In-Reply-To: <bug-24356-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24356-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24356-70-nOreFzJYOS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24356

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |agustinmoyano at theke.io
                   |ity.org                     |

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 21 19:00:09 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 21 Jan 2020 18:00:09 +0000
Subject: [Koha-bugs] [Bug 24473] Syndetics content should be $raw filtered
 on opac-detail.tt
In-Reply-To: <bug-24473-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24473-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24473-70-FeHrNAldx3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24473

Lucas Gass <lucas at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 21 19:00:11 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 21 Jan 2020 18:00:11 +0000
Subject: [Koha-bugs] [Bug 24473] Syndetics content should be $raw filtered
 on opac-detail.tt
In-Reply-To: <bug-24473-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24473-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24473-70-PbyRKF13SI@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24473

--- Comment #1 from Lucas Gass <lucas at bywatersolutions.com> ---
Created attachment 97679
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97679&action=edit
Bug 24473: Add $raw filter for Syndetics content

TEST PLAN:
1. have a Syndetics account set up and turn on the Syndetics system
preferences.
2. Find title(s) with Syndetics content for 'Title Notes', 'About The Author',
'Excerpt' and 'Reviews'.
3. Notice that any HTML markup displays literally.
4. Apply patch and restart_all.
5. Notice that HTML should display correctly.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 21 19:00:25 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 21 Jan 2020 18:00:25 +0000
Subject: [Koha-bugs] [Bug 24363] Datepicker calendar is not always sexy
In-Reply-To: <bug-24363-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24363-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24363-70-dLmGECntrT@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24363

--- Comment #12 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
I'll add some more problem pages:

* Reports: /cgi-bin/koha/reports/issues_stats.pl

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 21 19:01:13 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 21 Jan 2020 18:01:13 +0000
Subject: [Koha-bugs] [Bug 24105] Longoverdue gives error message when
 --itemtypes are specified
In-Reply-To: <bug-24105-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24105-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24105-70-yqwnkgzZUo@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24105

David Roberts <david.roberts at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |david.roberts at ptfs-europe.c
                   |                            |om

--- Comment #2 from David Roberts <david.roberts at ptfs-europe.com> ---
Seems to work OK in my dev environment according to the test plan. Signing off.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 21 19:01:21 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 21 Jan 2020 18:01:21 +0000
Subject: [Koha-bugs] [Bug 24276] Acquisition: Apply ACQ framework mandatory
 defaults to records from external sources
In-Reply-To: <bug-24276-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24276-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24276-70-hfU4PCGVCp@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24276

David Roberts <david.roberts at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off
                 CC|                            |david.roberts at ptfs-europe.c
                   |                            |om

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 21 19:02:21 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 21 Jan 2020 18:02:21 +0000
Subject: [Koha-bugs] [Bug 24105] Longoverdue gives error message when
 --itemtypes are specified
In-Reply-To: <bug-24105-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24105-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24105-70-mFxWjpW2HJ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24105

David Roberts <david.roberts at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 21 19:04:10 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 21 Jan 2020 18:04:10 +0000
Subject: [Koha-bugs] [Bug 16147] OpacItemLocation and not for circulation
 Item types
In-Reply-To: <bug-16147-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16147-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16147-70-y1D61hUUhx@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16147

--- Comment #4 from Ed Veal <eveal at mckinneytexas.org> ---
I am ok with this bug being closed. I think it is an old issue that has evolved
since my original submission is not a big deal. 

Ed

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 21 19:07:48 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 21 Jan 2020 18:07:48 +0000
Subject: [Koha-bugs] [Bug 24276] Acquisition: Apply ACQ framework mandatory
 defaults to records from external sources
In-Reply-To: <bug-24276-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24276-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24276-70-1w3Lvp84me@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24276

David Roberts <david.roberts at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|david.roberts at ptfs-europe.c |
                   |om                          |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 21 19:09:38 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 21 Jan 2020 18:09:38 +0000
Subject: [Koha-bugs] [Bug 7468] Add label to batch by barcode range
In-Reply-To: <bug-7468-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-7468-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7468-70-xUWqkjLOG1@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7468

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Text to go in the|                            |This enhancement to the
      release notes|                            |label creator tool adds an
                   |                            |option to let you generate
                   |                            |a range of barcode numbers
                   |                            |(for example, from 05000 to
                   |                            |05500) and save these as a
                   |                            |PDF, ready for printing.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 21 19:18:58 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 21 Jan 2020 18:18:58 +0000
Subject: [Koha-bugs] [Bug 22868] Circulation staff with suggestions_manage
 can have access to acquisition data
In-Reply-To: <bug-22868-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22868-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22868-70-Lra1XsWZOE@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22868

--- Comment #21 from Marie-Luce Laflamme <marie-luce.laflamme at inlibro.com> ---
I've tested the patch and here are my results...

- a patron with a super librarian permission can manage and add suggestion
- a patron without "suggestion management" permission cannot add suggestion



There is a tiny issue with the 3rd type of patron account...

- patron with several permissions (including "suggestion management") can add
suggestion, but it also has the ability to "manage suggestions" (accept or
reject suggestions) when you click on "Back to suggestion."


To reproduce:
Create a patron with "suggestion management" permission (see previous comment
for details)
Apply the patch
Login with a patron who has the "suggestion management" permission
Find a patron account.
Click on "Purchase suggestion" and Add a suggestion.
After submitting the suggestion, click on the title of the suggestion to assess
the request.
At the bottom of the suggestion form, click on "Back to suggestion"

After clicking on "Back to suggestion", you are sent to the "Suggestion
Management" page (Acquisition > Suggestion), where you can accept or reject
suggestions.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 21 19:22:37 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 21 Jan 2020 18:22:37 +0000
Subject: [Koha-bugs] [Bug 13325] Add logs for budgets and funds
In-Reply-To: <bug-13325-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13325-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13325-70-4SDNGn3aAe@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13325

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |nick at bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 21 19:36:59 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 21 Jan 2020 18:36:59 +0000
Subject: [Koha-bugs] [Bug 12502] Add columns for note,
 order number and ISBN to late orders page
In-Reply-To: <bug-12502-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-12502-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12502-70-0LgTyQVMQP@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12502

Joy Nelson <joy at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |joy at bywatersolutions.com

--- Comment #52 from Joy Nelson <joy at bywatersolutions.com> ---
Enhancement not backported to 19.11.x branch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 21 19:40:34 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 21 Jan 2020 18:40:34 +0000
Subject: [Koha-bugs] [Bug 24417] Charges/Fees.t is failing randomly
In-Reply-To: <bug-24417-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24417-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24417-70-ViHWV48iVS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24417

Joy Nelson <joy at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |joy at bywatersolutions.com

--- Comment #1 from Joy Nelson <joy at bywatersolutions.com> ---
Let me know if something needs doing on 19.11.x branch.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 21 19:46:07 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 21 Jan 2020 18:46:07 +0000
Subject: [Koha-bugs] [Bug 13325] Add logs for budgets and funds
In-Reply-To: <bug-13325-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13325-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13325-70-yJUbwdpBwl@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13325

Barbara Johnson <barbara.johnson at bedfordtx.gov> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |barbara.johnson at bedfordtx.g
                   |                            |ov

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 21 19:47:46 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 21 Jan 2020 18:47:46 +0000
Subject: [Koha-bugs] [Bug 24276] Acquisition: Apply ACQ framework mandatory
 defaults to records from external sources
In-Reply-To: <bug-24276-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24276-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24276-70-JHVbNXwKVJ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24276

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Needs Signoff
                 CC|                            |martin.renvoize at ptfs-europe
                   |                            |.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 21 19:51:25 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 21 Jan 2020 18:51:25 +0000
Subject: [Koha-bugs] [Bug 24356] objects.search prefetch
In-Reply-To: <bug-24356-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24356-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24356-70-uLEtModVtU@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24356

--- Comment #1 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 97680
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97680&action=edit
Bug 24356: prefetch_whitelist tests

This patch adds tests for the introduced methods.

To test:
1. Run the tests :-D
=> SUCCESS: They pass!
2. Sign off :-D

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 21 19:51:29 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 21 Jan 2020 18:51:29 +0000
Subject: [Koha-bugs] [Bug 24356] objects.search prefetch
In-Reply-To: <bug-24356-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24356-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24356-70-oC8ElIhiZG@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24356

--- Comment #2 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 97681
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97681&action=edit
Bug 24356: Make objects.search prefetch embedded relations

This patch makes the Koha::Object(s) derived classes expose information
about prefetch-able relations. This is then used by a new helper to
generate the prefetch information for the DBIC query.

To test:
1. Apply this patch
2. Run:
   $ kshell
  k$ prove t/db_dependent/Koha/Object* \
           t/db_dependent/Koha/REST/Plugin/Objects.t \
           t/db_dependent/Koha/REST/Plugin/Query.t
=> SUCCESS: Tests pass!
3. Sign off :-D

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 21 19:53:18 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 21 Jan 2020 18:53:18 +0000
Subject: [Koha-bugs] [Bug 24356] objects.search prefetch
In-Reply-To: <bug-24356-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24356-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24356-70-EChm91rHbq@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24356

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED

--- Comment #3 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
This is missing tests for the helpers.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 21 19:56:42 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 21 Jan 2020 18:56:42 +0000
Subject: [Koha-bugs] [Bug 23884] Merge strings.inc and browser-strings.inc
In-Reply-To: <bug-23884-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23884-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23884-70-Xz8iZXIWd9@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23884

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 21 19:56:46 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 21 Jan 2020 18:56:46 +0000
Subject: [Koha-bugs] [Bug 23884] Merge strings.inc and browser-strings.inc
In-Reply-To: <bug-23884-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23884-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23884-70-8PA58VnEPP@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23884

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #97659|0                           |1
        is obsolete|                            |

--- Comment #4 from David Nind <david at davidnind.com> ---
Created attachment 97682
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97682&action=edit
Bug 23884: Merge strings.inc and browser-strings.inc

This patch take the contents of the JavaScript in browser-strings.inc
and puts it in strings.inc. browser-strings.inc is deleted.

To test, apply the patch and perform a catalog search in the staff
client.

 - View any result. In the left-hand sidebar there should be a search
   results browser box with "previous" and "next" arrows and a link back
   to search results.
 - Click on each different "view" tab and confirm that the search
   results navigation box persists: Normal, MARC, Labeled MARC, ISBD,
   Items.
 - From any of these views select Edit -> Edit items. The same
   navigation box should appear.

Note: addbiblio.tt and stockrotation.tt are modified but feature doesn't
currently work on those pages.

Signed-off-by: David Nind <david at davidnind.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 21 20:40:31 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 21 Jan 2020 19:40:31 +0000
Subject: [Koha-bugs] [Bug 24249] OPAC lists page should require login for
 login-dependent operations
In-Reply-To: <bug-24249-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24249-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24249-70-B2meshGEjY@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24249

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #96350|0                           |1
        is obsolete|                            |

--- Comment #4 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 97683
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97683&action=edit
Bug 24249: OPAC lists page should require login for login-dependent operations

This patch modifies opac-shelves.pl so that login is required if the
requested operation is anything but "view" and "list."

The patch also modifies a couple of "Log in to create a new list" links
so that they point to the list creation form instead of opac-user.pl.

To test, apply the patch and go to the main lists page (the list of
lists) in the OPAC while not logged in.

 - Click the "Log in to create a new list" link.
 - Log in.
 - You should be taken to the "Create a new list" form.
 - Also test the "New list" link shown in the toolbar when you're
   viewing the contents of a list.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 21 21:03:21 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 21 Jan 2020 20:03:21 +0000
Subject: [Koha-bugs] [Bug 22982] Paying lost fee does not always remove lost
 item from checkouts
In-Reply-To: <bug-22982-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22982-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22982-70-kfhSyO6fPs@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22982

Aleisha Amohia <aleisha at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |aleisha at catalyst.net.nz

--- Comment #21 from Aleisha Amohia <aleisha at catalyst.net.nz> ---
Hey all, this patch is causing problems for some of our libraries because it's
been assumed that lost items with no attached charge should automatically be
returned. 

This is not always the desired behaviour - we have one case where the library
wants to keep lost items on a patron's record, and another case where a checked
out lost item will be renewed, but the amount outstanding is zero, so the item
gets returned.

These are edge cases, but the assumptions in this patch do not consider them,
and are causing problems. Is there a workaround? Or perhaps a better way of
doing this patch that can allow for the cases of 'renewing a lost item' or
'wanting to keep a lost item on the checkouts record'? A solution that avoids
doing circulation actions in the accounts modules as this patch does would be
ideal.

Aleisha

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 21 21:04:41 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 21 Jan 2020 20:04:41 +0000
Subject: [Koha-bugs] [Bug 24474] New: Lost items that are checked out are
 always returned
Message-ID: <bug-24474-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24474

            Bug ID: 24474
           Summary: Lost items that are checked out are always returned
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: major
          Priority: P5 - low
         Component: Circulation
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: aleisha at catalyst.net.nz
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com

This was a bug introduced by Bug 22982.

"Hey all, this patch is causing problems for some of our libraries because it's
been assumed that lost items with no attached charge should automatically be
returned. 

This is not always the desired behaviour - we have one case where the library
wants to keep lost items on a patron's record, and another case where a checked
out lost item will be renewed, but the amount outstanding is zero, so the item
gets returned.

These are edge cases, but the assumptions in this patch do not consider them,
and are causing problems. Is there a workaround? Or perhaps a better way of
doing this patch that can allow for the cases of 'renewing a lost item' or
'wanting to keep a lost item on the checkouts record'? A solution that avoids
doing circulation actions in the accounts modules as this patch does would be
ideal."

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 21 21:04:54 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 21 Jan 2020 20:04:54 +0000
Subject: [Koha-bugs] [Bug 24474] Lost items that are checked out are always
 returned
In-Reply-To: <bug-24474-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24474-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24474-70-XdYFhuyTNd@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24474

Aleisha Amohia <aleisha at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |22982
           Assignee|koha-bugs at lists.koha-commun |aleisha at catalyst.net.nz
                   |ity.org                     |


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22982
[Bug 22982] Paying lost fee does not always remove lost item from checkouts
-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 21 21:04:54 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 21 Jan 2020 20:04:54 +0000
Subject: [Koha-bugs] [Bug 22982] Paying lost fee does not always remove lost
 item from checkouts
In-Reply-To: <bug-22982-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22982-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22982-70-IOGtxJi17d@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22982

Aleisha Amohia <aleisha at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |24474


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24474
[Bug 24474] Lost items that are checked out are always returned
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 21 21:06:27 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 21 Jan 2020 20:06:27 +0000
Subject: [Koha-bugs] [Bug 22982] Paying lost fee does not always remove lost
 item from checkouts
In-Reply-To: <bug-22982-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22982-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22982-70-TJeHnol7O5@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22982

--- Comment #22 from Aleisha Amohia <aleisha at catalyst.net.nz> ---
I have opened Bug 24474 depending on this one to fix the bug that this has
caused.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 21 21:07:51 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 21 Jan 2020 20:07:51 +0000
Subject: [Koha-bugs] [Bug 24181] Make our datepicker inputs sexy
In-Reply-To: <bug-24181-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24181-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24181-70-wymHcohYOv@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24181

Joy Nelson <joy at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|20.05.00, 19.11.02          |20.05.00
        released in|                            |
             Status|Pushed to stable            |ASSIGNED

--- Comment #20 from Joy Nelson <joy at bywatersolutions.com> ---
Reverted from 19.11.x branch until more fixes available.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 21 21:09:35 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 21 Jan 2020 20:09:35 +0000
Subject: [Koha-bugs] [Bug 24474] Lost items that are checked out are always
 returned
In-Reply-To: <bug-24474-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24474-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24474-70-W6Ume3DRE0@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24474

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de
           Severity|major                       |critical

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 21 21:11:31 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 21 Jan 2020 20:11:31 +0000
Subject: [Koha-bugs] [Bug 24474] Lost items that are checked out are always
 returned, even when attempting to renew them
In-Reply-To: <bug-24474-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24474-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24474-70-acg5k1bvpZ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24474

Chris Cormack <chris at bigballofwax.co.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Lost items that are checked |Lost items that are checked
                   |out are always returned     |out are always returned,
                   |                            |even when attempting to
                   |                            |renew them
                 CC|                            |chris at bigballofwax.co.nz

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 21 21:26:12 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 21 Jan 2020 20:26:12 +0000
Subject: [Koha-bugs] [Bug 24054] Typo in ClaimReturnedWarningThreshold
 system preference
In-Reply-To: <bug-24054-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24054-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24054-70-nfHc3kFfof@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24054

Lucas Gass <lucas at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|20.05.00, 19.11.02          |20.05.00, 19.11.02.
        released in|                            |19.05.07
             Status|Pushed to stable            |Pushed to oldstable
                 CC|                            |lucas at bywatersolutions.com

--- Comment #5 from Lucas Gass <lucas at bywatersolutions.com> ---
backported to 19.05.x for 19.05.07

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 21 22:26:53 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 21 Jan 2020 21:26:53 +0000
Subject: [Koha-bugs] [Bug 24054] Typo in ClaimReturnedWarningThreshold
 system preference
In-Reply-To: <bug-24054-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24054-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24054-70-wkTL7auouc@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24054

Hayley Mapley <hayleymapley at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |hayleymapley at catalyst.net.n
                   |                            |z
             Status|Pushed to oldstable         |Pushed to oldoldstable
         Version(s)|20.05.00, 19.11.02.         |20.05.00, 19.11.02.
        released in|19.05.07                    |19.05.07, 18.11.14

--- Comment #6 from Hayley Mapley <hayleymapley at catalyst.net.nz> ---
Backported to 18.11.x for 18.11.14

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 21 23:49:28 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 21 Jan 2020 22:49:28 +0000
Subject: [Koha-bugs] [Bug 24363] Datepicker calendar is not always sexy
In-Reply-To: <bug-24363-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24363-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24363-70-uaUvzZG98W@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24363

Lucas Gass <lucas at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|lucas at bywatersolutions.com  |oleonard at myacpl.org

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 22 00:27:53 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 21 Jan 2020 23:27:53 +0000
Subject: [Koha-bugs] [Bug 24475] New: Reword FinesMode system preference
Message-ID: <bug-24475-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24475

            Bug ID: 24475
           Summary: Reword FinesMode system preference
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: System Administration
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: andrew at bywatersolutions.com
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com

The text for FinesMode reads:

(Don't Calculate / Calculate and Charge / Calculate but only for mailing to the
admin)
 fines (when misc/cronjobs/fines.pl is being run).
NOTE: Fines can also be charged by the CalculateFinesOnReturn system
preference.
NOTE: This system preference requires the misc/cronjobs/fines.pl cronjob. Ask
your system administrator to schedule it.


This gives the impression that CalculateFinesOnReturn is an alternative to
FinesMode -- that one could set FinesMode to "Don't calculate" and turn on
CalculateFinesOnReturn in order to only calculate fines when an item is checked
in.

However, CalculateFinesOnReturn only works when FinesMode is set to "Calculate
and charge." CalculateFinesOnReturn is an alternative to the fines cron, not to
FinesMode.

I'll think on better wording here and get back to this.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 22 00:28:19 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 21 Jan 2020 23:28:19 +0000
Subject: [Koha-bugs] [Bug 24475] Reword FinesMode system preference
In-Reply-To: <bug-24475-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24475-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24475-70-YM0dB5gU13@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24475

Andrew Fuerste-Henry <andrew at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |bwsdonna at gmail.com,
                   |                            |kelly at bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 22 00:28:31 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 21 Jan 2020 23:28:31 +0000
Subject: [Koha-bugs] [Bug 24475] Reword FinesMode system preference
In-Reply-To: <bug-24475-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24475-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24475-70-TSrwm6pPi8@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24475

Andrew Fuerste-Henry <andrew at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jzairo at bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 22 01:21:17 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 22 Jan 2020 00:21:17 +0000
Subject: [Koha-bugs] [Bug 19704] OPACs most popular feature includes titles
 hidden by OpacHiddenItems
In-Reply-To: <bug-19704-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19704-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19704-70-oL90GFvBOE@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19704

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|oleonard at myacpl.org         |koha-bugs at lists.koha-commun
                   |                            |ity.org

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 22 01:22:11 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 22 Jan 2020 00:22:11 +0000
Subject: [Koha-bugs] [Bug 24385] Add menu into pages tools and admin
In-Reply-To: <bug-24385-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24385-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24385-70-1wfcQXKdkp@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24385

--- Comment #1 from Owen Leonard <oleonard at myacpl.org> ---
Could we have some more details about this?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 22 01:25:38 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 22 Jan 2020 00:25:38 +0000
Subject: [Koha-bugs] [Bug 16421] Move hold edit actions into dropdown menu
In-Reply-To: <bug-16421-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16421-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16421-70-zpXmDnjZml@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16421

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Patch doesn't apply         |RESOLVED
         Resolution|---                         |WONTFIX

--- Comment #13 from Owen Leonard <oleonard at myacpl.org> ---
This interface still needs work but it's going to end up being quite different
after Bug 23501 so I think this should be closed.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 22 01:27:35 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 22 Jan 2020 00:27:35 +0000
Subject: [Koha-bugs] [Bug 23794] Convert OpacMainUserBlock system preference
 to news block
In-Reply-To: <bug-23794-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23794-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23794-70-w113o7TtSL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23794

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |NEW

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 22 01:28:25 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 22 Jan 2020 00:28:25 +0000
Subject: [Koha-bugs] [Bug 22572] Garbled content of MARC control fields in
 MARC view
In-Reply-To: <bug-22572-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22572-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22572-70-fcm9dZpEUM@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22572

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|oleonard at myacpl.org         |koha-bugs at lists.koha-commun
                   |                            |ity.org

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 22 01:31:21 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 22 Jan 2020 00:31:21 +0000
Subject: [Koha-bugs] [Bug 16721] Add table configuration to serial claims
 table
In-Reply-To: <bug-16721-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16721-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16721-70-L6iA5wtzF1@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16721

--- Comment #1 from Owen Leonard <oleonard at myacpl.org> ---
This bug faces the same obstacle Bug 23565 does: The
jquery.dataTables.columnFilter.js plugin doesn't play well with columns
configuration. I wonder if it would be an acceptable alternative to move the
filter fields into the sidebar?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 22 01:33:39 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 22 Jan 2020 00:33:39 +0000
Subject: [Koha-bugs] [Bug 15726] Add columns configuration and export
 options to circulation and fine rules
In-Reply-To: <bug-15726-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15726-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15726-70-LpR1jKLf1c@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15726

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #90452|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 22 01:33:56 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 22 Jan 2020 00:33:56 +0000
Subject: [Koha-bugs] [Bug 15726] Add columns configuration and export
 options to circulation and fine rules
In-Reply-To: <bug-15726-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15726-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15726-70-4DUjHeBjvS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15726

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |ASSIGNED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 22 01:34:08 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 22 Jan 2020 00:34:08 +0000
Subject: [Koha-bugs] [Bug 15726] Add columns configuration and export
 options to circulation and fine rules
In-Reply-To: <bug-15726-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15726-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15726-70-BQB733gxtG@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15726

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |NEW

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 22 01:53:50 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 22 Jan 2020 00:53:50 +0000
Subject: [Koha-bugs] [Bug 24476] New: Allow patrons to opt-out of
 Auto-renewal
Message-ID: <bug-24476-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24476

            Bug ID: 24476
           Summary: Allow patrons to opt-out of Auto-renewal
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Patrons
          Assignee: nick at bywatersolutions.com
          Reporter: nick at bywatersolutions.com
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com

Some patrons prefer to renew their books on their own. This development will
allow a patron to opt-out of auto-renewals -the cron will ignore these
checkouts and items will be renewable both via the staff and opac.

Patrons will be able to set this flag themselves, staff will also be able to.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 22 02:27:00 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 22 Jan 2020 01:27:00 +0000
Subject: [Koha-bugs] [Bug 21586] Add generic OpenIDConnect client
 implementation
In-Reply-To: <bug-21586-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21586-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21586-70-LcCfyZACA3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21586

--- Comment #11 from David Cook <dcook at prosentient.com.au> ---
Created attachment 97684
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97684&action=edit
Local login plus external login

Example of local login plus external logins.

The links/buttons are for URLs like this:

https://gitlab.com/users/auth/google_oauth2
https://gitlab.com/users/auth/twitter

It would be interesting to have plugins so that we could do things like:

https://koha/users/auth/google
https://koha/users/auth/custom_idp1
https://koha/users/auth/custom_idp2

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 22 02:41:01 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 22 Jan 2020 01:41:01 +0000
Subject: [Koha-bugs] [Bug 19735] Move Perl deps definitions into a cpanfile
In-Reply-To: <bug-19735-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19735-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19735-70-3XbUiwaK1K@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19735

--- Comment #23 from David Cook <dcook at prosentient.com.au> ---
I'm really interested in this issue, but juggling a few things at the moment,
so not going to do the full test.

However, I do want to say the following:

1. koha_perl_deps.pl is working great with this change
2. prove t/Installer_pm.t t/Installer_PerlModules.t passed its tests, although
they spat out a bunch of Test::MockTime warnings on my non-Debian system
running Perl 5.26.1. I imagine that's unrelated though.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 22 03:32:56 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 22 Jan 2020 02:32:56 +0000
Subject: [Koha-bugs] [Bug 23064] Cannot edit subscription with strict SQL
 modes turned on
In-Reply-To: <bug-23064-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23064-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23064-70-gg3h0vjaJY@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23064

Hayley Mapley <hayleymapley at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |hayleymapley at catalyst.net.n
                   |                            |z

--- Comment #8 from Hayley Mapley <hayleymapley at catalyst.net.nz> ---
Hi Jonathan,

I am unable to reproduce this bug on master.

Steps I have taken:
1) Define a budget, active fund, and vendor
2) Create new subscription
3) Edit that subscription
4) Put 'f' in the 'Number of issues to display to staff' field
(I also tried putting 'f' in the Subscription length field, which saves with no
errors and is NULLed)
5) Kept an eye on the plack-error.log and the intranet-error.log during the
testing, did not see any error.

Would you please tell me what I have missed here?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 22 04:35:00 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 22 Jan 2020 03:35:00 +0000
Subject: [Koha-bugs] [Bug 23777] Text converted to html entity codes in
 cataloguing edit form
In-Reply-To: <bug-23777-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23777-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23777-70-xelgmF6WkA@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23777

Hayley Mapley <hayleymapley at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #95275|0                           |1
        is obsolete|                            |

--- Comment #17 from Hayley Mapley <hayleymapley at catalyst.net.nz> ---
Created attachment 97685
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97685&action=edit
Bug 23777: Fix auth finder escaping

Signed-off-by: Hayley Mapley <hayleymapley at catalyst.net.nz>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 22 04:35:31 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 22 Jan 2020 03:35:31 +0000
Subject: [Koha-bugs] [Bug 23777] Text converted to html entity codes in
 cataloguing edit form
In-Reply-To: <bug-23777-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23777-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23777-70-2gXqJhxGWa@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23777

Hayley Mapley <hayleymapley at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #95279|0                           |1
        is obsolete|                            |

--- Comment #18 from Hayley Mapley <hayleymapley at catalyst.net.nz> ---
Created attachment 97686
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97686&action=edit
Bug 23777: Fix for the advanced editor

Signed-off-by: Hayley Mapley <hayleymapley at catalyst.net.nz>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 22 04:35:59 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 22 Jan 2020 03:35:59 +0000
Subject: [Koha-bugs] [Bug 23777] Text converted to html entity codes in
 cataloguing edit form
In-Reply-To: <bug-23777-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23777-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23777-70-HuSZD6FLgI@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23777

Hayley Mapley <hayleymapley at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #95280|0                           |1
        is obsolete|                            |

--- Comment #19 from Hayley Mapley <hayleymapley at catalyst.net.nz> ---
Created attachment 97687
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97687&action=edit
Bug 23777: Use To.json in preferences.tt

Test plan:
Search for "foo bar" (with double quotes) in the sysprefs

Signed-off-by: Hayley Mapley <hayleymapley at catalyst.net.nz>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 22 04:36:46 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 22 Jan 2020 03:36:46 +0000
Subject: [Koha-bugs] [Bug 23777] Text converted to html entity codes in
 cataloguing edit form
In-Reply-To: <bug-23777-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23777-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23777-70-mfl8kmwhi9@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23777

Hayley Mapley <hayleymapley at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #95281|0                           |1
        is obsolete|                            |

--- Comment #20 from Hayley Mapley <hayleymapley at catalyst.net.nz> ---
Created attachment 97688
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97688&action=edit
Bug 23777: Use To.json in authorities.tt

No fix here.

Test plan:
Edit GENRE/FORM 040$a
With text: Original catalo'"ging age"'ncy
Save, you get the alert

Signed-off-by: Hayley Mapley <hayleymapley at catalyst.net.nz>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 22 04:37:57 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 22 Jan 2020 03:37:57 +0000
Subject: [Koha-bugs] [Bug 23777] Text converted to html entity codes in
 cataloguing edit form
In-Reply-To: <bug-23777-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23777-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23777-70-fPDIB8GYvB@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23777

Hayley Mapley <hayleymapley at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #95282|0                           |1
        is obsolete|                            |

--- Comment #21 from Hayley Mapley <hayleymapley at catalyst.net.nz> ---
Created attachment 97689
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97689&action=edit
Bug 23777: Use To.json in results.tt

Test plan:
Search for a string with quote and confirm that it is correctly
highlighted in the result list.

Signed-off-by: Hayley Mapley <hayleymapley at catalyst.net.nz>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 22 04:39:46 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 22 Jan 2020 03:39:46 +0000
Subject: [Koha-bugs] [Bug 23777] Text converted to html entity codes in
 cataloguing edit form
In-Reply-To: <bug-23777-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23777-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23777-70-QWul33WqBj@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23777

Hayley Mapley <hayleymapley at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #95283|0                           |1
        is obsolete|                            |

--- Comment #22 from Hayley Mapley <hayleymapley at catalyst.net.nz> ---
Created attachment 97690
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97690&action=edit
Bug 23777: Use TO.json in value_builder/unimarc_field_4XX.tt

No idea how to test this but, as other fixes work, this one should,
right?

Signed-off-by: Hayley Mapley <hayleymapley at catalyst.net.nz>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 22 04:40:43 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 22 Jan 2020 03:40:43 +0000
Subject: [Koha-bugs] [Bug 23777] Text converted to html entity codes in
 cataloguing edit form
In-Reply-To: <bug-23777-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23777-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23777-70-uG8qFFi65z@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23777

Hayley Mapley <hayleymapley at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #95284|0                           |1
        is obsolete|                            |

--- Comment #23 from Hayley Mapley <hayleymapley at catalyst.net.nz> ---
Created attachment 97691
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97691&action=edit
Bug 23777: Use To.json in request.tt

Test plan:
Use quotes in a library's name, then place an item on hold for a patron
that cannot do it.
If you are allowed to overwrite this restriction you will get a warning:
"This item normally cannot be put on hold except for patrons from
BRANCHNAME"
The library's name should be correcty displayed

Signed-off-by: Hayley Mapley <hayleymapley at catalyst.net.nz>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 22 04:41:40 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 22 Jan 2020 03:41:40 +0000
Subject: [Koha-bugs] [Bug 23777] Text converted to html entity codes in
 cataloguing edit form
In-Reply-To: <bug-23777-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23777-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23777-70-0zWNWhQW4L@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23777

Hayley Mapley <hayleymapley at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |hayleymapley at catalyst.net.n
                   |                            |z
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 22 04:50:27 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 22 Jan 2020 03:50:27 +0000
Subject: [Koha-bugs] [Bug 24454] currency formatting from JS
In-Reply-To: <bug-24454-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24454-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24454-70-VxXp7zL3Rs@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24454

Hayley Mapley <hayleymapley at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |hayleymapley at catalyst.net.n
                   |                            |z
         Depends on|                            |20212


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20212
[Bug 20212] Slowness in Receiving in Acquisitions
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 22 04:50:27 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 22 Jan 2020 03:50:27 +0000
Subject: [Koha-bugs] [Bug 20212] Slowness in Receiving in Acquisitions
In-Reply-To: <bug-20212-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20212-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20212-70-ChE27gdIUh@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20212

Hayley Mapley <hayleymapley at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |24454


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24454
[Bug 24454] currency formatting from JS
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 22 07:49:26 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 22 Jan 2020 06:49:26 +0000
Subject: [Koha-bugs] [Bug 16721] Add table configuration to serial claims
 table
In-Reply-To: <bug-16721-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16721-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16721-70-bMyUmjaVyp@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16721

--- Comment #2 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
(In reply to Owen Leonard from comment #1)
> This bug faces the same obstacle Bug 23565 does: The
> jquery.dataTables.columnFilter.js plugin doesn't play well with columns
> configuration. I wonder if it would be an acceptable alternative to move the
> filter fields into the sidebar?

I am not a fan of the filters on the columns as the 'sample text' inside often
is squashed, especially after translation. We often have filters on the side -
I think that could work. We also have the additional fields on subscriptions
showing up in the side filters - so maybe similar here?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 22 08:04:12 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 22 Jan 2020 07:04:12 +0000
Subject: [Koha-bugs] [Bug 24161] Late orders improvements - keeping track of
 claims
In-Reply-To: <bug-24161-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24161-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24161-70-7djvdhGlKs@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24161

--- Comment #11 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
I had already started here yesterday, so trying to clean up my notes:

+=head3 authorizer

Wonder if we should make this 'creator', as we have discussed for the API
endpoint.

Missing description in the updatedatabase:
+    print "Upgrade to $DBversion done (Bug XXXXX - description)\n";


Both not blocking further testing!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 22 08:07:46 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 22 Jan 2020 07:07:46 +0000
Subject: [Koha-bugs] [Bug 23594] Batch modification for itemtypes on
 suggestions page
In-Reply-To: <bug-23594-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23594-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23594-70-ugHwI4d1sM@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23594

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         QA Contact|testopia at bugs.koha-communit |katrin.fischer at bsz-bw.de
                   |y.org                       |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 22 08:09:07 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 22 Jan 2020 07:09:07 +0000
Subject: [Koha-bugs] [Bug 23594] Batch modification for itemtypes on
 suggestions page
In-Reply-To: <bug-23594-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23594-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23594-70-ezYre8upw0@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23594

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Failed QA

--- Comment #15 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Sorry Joubu, some fails on the QA test tools:

 FAIL   koha-tmpl/intranet-tmpl/prog/en/modules/suggestion/suggestion.tt
   FAIL   filters
                wrong_html_filter at line 473 (            <a href="#tab_[%
loop.count %]">)
                missing_filter at line 473 (            <a href="#tab_[%
loop.count %]">)
                missing_filter at line 497 (<div id="tab_[% loop.count %]">)
                missing_filter at line 498 (<form class="update_suggestions"
name="f" method="post" action="/cgi-bin/koha/suggestion/suggestion.pl#tab_[%
loop.count %]">)
                missing_filter at line 502 (    <table id="table_[% loop.count
%]" class="sorted">)
                missing_filter at line 648 (                    <label
for="delete_[% loop.count %]">Delete selected</label>)
   FAIL   forbidden patterns
                forbidden pattern: Attribute type should not be used for script
tags (bug 20053) (line 840)
   OK     git manipulation
   OK     js_in_body
   OK     spelling
   OK     tt_valid
   OK     valid_template

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 22 08:15:11 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 22 Jan 2020 07:15:11 +0000
Subject: [Koha-bugs] [Bug 24452] Advanced editor - show multiple spaces
 visually
In-Reply-To: <bug-24452-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24452-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24452-70-ugKGFwFEXd@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24452

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 22 08:15:15 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 22 Jan 2020 07:15:15 +0000
Subject: [Koha-bugs] [Bug 24452] Advanced editor - show multiple spaces
 visually
In-Reply-To: <bug-24452-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24452-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24452-70-wHs08X4BQy@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24452

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #97548|0                           |1
        is obsolete|                            |

--- Comment #4 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 97692
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97692&action=edit
Bug 24452: Advanced editor - show multiple spaces visually

This patch updates the JavaScript and CSS for the advanced MARC editor
so that multiple consecutive spaces within a line will be detected and
highlighted.

To test the EnableAdvancedCatalogingEditor system preference should be
enabled. Apply the patch and clear your browser cache if necessary.

 - Go to Cataloging -> Advanced editor.
 - On any text entry line (e.g. 245), enter some words with one, two,
   and more spaces in between them. When there are two or more spaces
   between words the spaces between the words should have a dotted red
   underline.
 - Remove the extra spaces and confirm that the dotted line disappears.

Signed-off-by: Cori Lynn Arnold <carnold at dgiinc.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 22 08:16:21 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 22 Jan 2020 07:16:21 +0000
Subject: [Koha-bugs] [Bug 24452] Advanced editor - show multiple spaces
 visually
In-Reply-To: <bug-24452-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24452-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24452-70-7tG44n6Hjq@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24452

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de

--- Comment #5 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Note: With the helpers on 00x deactivated it will also show the wanted
whitespace there.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 22 08:23:08 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 22 Jan 2020 07:23:08 +0000
Subject: [Koha-bugs] [Bug 24477] New: No permissions check for POS feature
Message-ID: <bug-24477-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24477

            Bug ID: 24477
           Summary: No permissions check for POS feature
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: critical
          Priority: P5 - low
         Component: Fines and fees
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: katrin.fischer at bsz-bw.de
        QA Contact: testopia at bugs.koha-community.org

At the moment it appears that POS can be used without any permission - This
means a patron with no permissions can access the page!

my ( $template, $loggedinuser, $cookie, $user_flags ) = get_template_and_user(
    {
        template_name   => 'pos/pay.tt',
        query           => $q,
        type            => 'intranet',
        authnotrequired => 0,
    }
);

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 22 08:24:50 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 22 Jan 2020 07:24:50 +0000
Subject: [Koha-bugs] [Bug 24477] No permissions check for POS feature
In-Reply-To: <bug-24477-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24477-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24477-70-Di91ClsZmf@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24477

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |23354


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23354
[Bug 23354] Add a 'Pay' screen to allow anonymous payments in a POS fashion
-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 22 08:24:50 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 22 Jan 2020 07:24:50 +0000
Subject: [Koha-bugs] [Bug 23354] Add a 'Pay' screen to allow anonymous
 payments in a POS fashion
In-Reply-To: <bug-23354-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23354-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23354-70-5hwh9ub1yO@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23354

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |24477


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24477
[Bug 24477] No permissions check for POS feature
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 22 08:28:01 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 22 Jan 2020 07:28:01 +0000
Subject: [Koha-bugs] [Bug 24478] New: Make it possible to deactivate point
 of sale
Message-ID: <bug-24478-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24478

            Bug ID: 24478
           Summary: Make it possible to deactivate point of sale
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Fines and fees
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: katrin.fischer at bsz-bw.de
        QA Contact: testopia at bugs.koha-community.org
        Depends on: 23354

It would be nice if the new POS module could be deactivated for libraries not
using it.

A common demand from smaller libraries is to hide all functionality they don't
use to make things less confusing and less error prone. As the new POS feature
shows up as a new module on the start page it's prominently placed and it would
be nice if there was a pref to turn off this functionality separate from fines
permissions.


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23354
[Bug 23354] Add a 'Pay' screen to allow anonymous payments in a POS fashion
-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 22 08:28:01 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 22 Jan 2020 07:28:01 +0000
Subject: [Koha-bugs] [Bug 23354] Add a 'Pay' screen to allow anonymous
 payments in a POS fashion
In-Reply-To: <bug-23354-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23354-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23354-70-D2psv1KFQQ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23354

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |24478


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24478
[Bug 24478] Make it possible to deactivate point of sale
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 22 08:31:50 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 22 Jan 2020 07:31:50 +0000
Subject: [Koha-bugs] [Bug 24479] New: New POS doesn't follow CurrencyFormat
Message-ID: <bug-24479-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24479

            Bug ID: 24479
           Summary: New POS doesn't follow CurrencyFormat
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Fines and fees
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: katrin.fischer at bsz-bw.de
        QA Contact: testopia at bugs.koha-community.org
        Depends on: 23354

There is some hardcoded stuff in the new POS feature that is wrong when another
CurrencyFormat tha US is used:

<p>The change to give is <b><span id="modal_change">0.00</span></b>.</p>
<span id="change">0.00</span>
<input type="hidden" name="change" value="0.00"/>

This needs a thorough check and fix.


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23354
[Bug 23354] Add a 'Pay' screen to allow anonymous payments in a POS fashion
-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 22 08:31:50 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 22 Jan 2020 07:31:50 +0000
Subject: [Koha-bugs] [Bug 23354] Add a 'Pay' screen to allow anonymous
 payments in a POS fashion
In-Reply-To: <bug-23354-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23354-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23354-70-3UjhrPHWqT@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23354

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |24479


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24479
[Bug 24479] New POS doesn't follow CurrencyFormat
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 22 09:55:37 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 22 Jan 2020 08:55:37 +0000
Subject: [Koha-bugs] [Bug 22868] Circulation staff with suggestions_manage
 can have access to acquisition data
In-Reply-To: <bug-22868-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22868-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22868-70-l5q0NleR2A@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22868

--- Comment #22 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
(In reply to Marie-Luce Laflamme from comment #21)
> There is a tiny issue with the 3rd type of patron account...
> 
> - patron with several permissions (including "suggestion management") can
> add suggestion, but it also has the ability to "manage suggestions" (accept
> or reject suggestions) when you click on "Back to suggestion."

Yes, it is the expected behavior.
With suggestions_manage you can manage suggestions :) Which means you can
add/edit/delete purchase suggestions.

On this bug report we are dealing with acquisition access, a librarian with
suggestions_manage but no acquisition permission cannot access budgets/funds
information.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 22 10:00:49 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 22 Jan 2020 09:00:49 +0000
Subject: [Koha-bugs] [Bug 23064] Cannot edit subscription with strict SQL
 modes turned on
In-Reply-To: <bug-23064-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23064-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23064-70-fX9a3YmALd@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23064

--- Comment #9 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Hi Hayley,
Did you turn the strict_sql_modes config flag on?
- edit $KOHA_CONF
- make sure you have <strict_sql_modes>1</strict_sql_modes> in the config
section
- restart all the things

Then try again.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 22 10:06:20 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 22 Jan 2020 09:06:20 +0000
Subject: [Koha-bugs] [Bug 23594] Batch modification for itemtypes on
 suggestions page
In-Reply-To: <bug-23594-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23594-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23594-70-fci8jP2gBZ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23594

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 22 10:06:24 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 22 Jan 2020 09:06:24 +0000
Subject: [Koha-bugs] [Bug 23594] Batch modification for itemtypes on
 suggestions page
In-Reply-To: <bug-23594-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23594-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23594-70-TkjQZ9DuJS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23594

--- Comment #16 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 97693
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97693&action=edit
Bug 23594: Add missing html filters

Also fixes the following QA failure:
forbidden pattern: Attribute type should not be used for script tags (bug
20053) (line 840)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 22 10:17:58 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 22 Jan 2020 09:17:58 +0000
Subject: [Koha-bugs] [Bug 24480] New: Fields added with Marc modifications
 templates are not added in an ordered way
Message-ID: <bug-24480-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24480

            Bug ID: 24480
           Summary: Fields added with Marc modifications templates are not
                    added in an ordered way
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Tools
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: arthur.suzuki at biblibre.com
        QA Contact: testopia at bugs.koha-community.org

they are instead appended to the end of the record.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 22 10:18:05 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 22 Jan 2020 09:18:05 +0000
Subject: [Koha-bugs] [Bug 24480] Fields added with Marc modifications
 templates are not added in an ordered way
In-Reply-To: <bug-24480-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24480-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24480-70-VxYWJzJCvl@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24480

Arthur Suzuki <arthur.suzuki at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |arthur.suzuki at biblibre.com
                   |ity.org                     |

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 22 10:20:24 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 22 Jan 2020 09:20:24 +0000
Subject: [Koha-bugs] [Bug 23493] jquery.dataTables.rowGrouping.js is no
 longer maintained,
 but there is an official DataTables version we could switch to
In-Reply-To: <bug-23493-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23493-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23493-70-zCOlNK477U@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23493

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #97344|0                           |1
        is obsolete|                            |

--- Comment #10 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 97694
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97694&action=edit
Bug 23493: Replace rowGrouping with rowGroup

This patch replaces the unmaintained third party rowGrouping datatables
plugin with the supported core rowGroup replacement.

Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 22 10:20:38 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 22 Jan 2020 09:20:38 +0000
Subject: [Koha-bugs] [Bug 24249] OPAC lists page should require login for
 login-dependent operations
In-Reply-To: <bug-24249-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24249-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24249-70-UJDrf0UAQr@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24249

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |david at davidnind.com
             Status|Needs Signoff               |Failed QA

--- Comment #5 from David Nind <david at davidnind.com> ---
This works when you go 'Lists > Your lists > Log in to create a new list' (you
end up at /cgi-bin/koha/opac-shelves.pl?op=add_form).

However, when you go 'Lists > Log in to create your own lists' it goes to the
your summary page (/cgi-bin/koha/opac-user.pl?has-search-query=).

Also, logging in the via 'Lists > Your lists > Log in to create your own lists'
comes up with a modal for your username and password, the other way it is an
inline form. This is how it works now, but seems a little inconsistent.
Probably another bug though...

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 22 10:20:45 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 22 Jan 2020 09:20:45 +0000
Subject: [Koha-bugs] [Bug 23493] jquery.dataTables.rowGrouping.js is no
 longer maintained,
 but there is an official DataTables version we could switch to
In-Reply-To: <bug-23493-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23493-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23493-70-KDuS0nOFeZ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23493

--- Comment #11 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Simple rebase performed.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 22 10:20:50 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 22 Jan 2020 09:20:50 +0000
Subject: [Koha-bugs] [Bug 23493] jquery.dataTables.rowGrouping.js is no
 longer maintained,
 but there is an official DataTables version we could switch to
In-Reply-To: <bug-23493-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23493-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23493-70-yDj0OZ61eE@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23493

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|oleonard at myacpl.org         |martin.renvoize at ptfs-europe
                   |                            |.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 22 10:21:04 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 22 Jan 2020 09:21:04 +0000
Subject: [Koha-bugs] [Bug 23493] jquery.dataTables.rowGrouping.js is no
 longer maintained,
 but there is an official DataTables version we could switch to
In-Reply-To: <bug-23493-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23493-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23493-70-Ke2OiMzWo0@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23493

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |oleonard at myacpl.org
         QA Contact|testopia at bugs.koha-communit |
                   |y.org                       |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 22 10:36:20 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 22 Jan 2020 09:36:20 +0000
Subject: [Koha-bugs] [Bug 23493] jquery.dataTables.rowGrouping.js is no
 longer maintained,
 but there is an official DataTables version we could switch to
In-Reply-To: <bug-23493-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23493-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23493-70-qXbNZvRZ69@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23493

--- Comment #12 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
I am expecting this bug report to add the rowGroup plugin, not bug 23355.
It seems easy to make the dependency the other way around.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 22 10:42:11 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 22 Jan 2020 09:42:11 +0000
Subject: [Koha-bugs] [Bug 24249] OPAC lists page should require login for
 login-dependent operations
In-Reply-To: <bug-24249-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24249-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24249-70-6U3VJFbnl4@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24249

--- Comment #6 from David Nind <david at davidnind.com> ---
I looked at the code and for 'Log in to create your own lists' is in
koha-tmpl/opac-tmpl/bootstrap/en/includes/masthead.inc, lines 73 and 75.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 22 10:49:41 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 22 Jan 2020 09:49:41 +0000
Subject: [Koha-bugs] [Bug 23354] Add a 'Pay' screen to allow anonymous
 payments in a POS fashion
In-Reply-To: <bug-23354-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23354-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23354-70-DpdqUZqDbF@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23354

--- Comment #161 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
my $q         = CGI->new();

We already have $input and $cgi :)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 22 10:54:26 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 22 Jan 2020 09:54:26 +0000
Subject: [Koha-bugs] [Bug 24480] Fields added with Marc modifications
 templates are not added in an ordered way
In-Reply-To: <bug-24480-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24480-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24480-70-iN6cLSLnxQ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24480

--- Comment #1 from Arthur Suzuki <arthur.suzuki at biblibre.com> ---
Created attachment 97695
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97695&action=edit
Bug 24480: Fix insert_fields_ordered instead of append_fields in SimpleMARC

Test plan :
 - create a marc modification template which add a new field to a record
 - apply that template to some records
 - verify that the new field is always appended at the bottom of the record,
even if some fields are higher.
 - apply patch
 - apply template to another set of records
 - verify the added field is now ordered within the already existing fields in
the records

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 22 10:54:51 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 22 Jan 2020 09:54:51 +0000
Subject: [Koha-bugs] [Bug 24480] Fields added with Marc modifications
 templates are not added in an ordered way
In-Reply-To: <bug-24480-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24480-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24480-70-uL5xe1l4q1@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24480

Arthur Suzuki <arthur.suzuki at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 22 10:55:45 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 22 Jan 2020 09:55:45 +0000
Subject: [Koha-bugs] [Bug 24339] SIP codes are missing from the default
 payment_types on installation
In-Reply-To: <bug-24339-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24339-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24339-70-Bn6r559OPF@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24339

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org

--- Comment #8 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
[% SET excluded = ['SIP00', 'SIP01', 'SIP02'] %]
[% IF payment_types > 3 %]

I do not think it's regression free (maybe SIP* have been removed from the AV?)

I would say we should test if payment_types - excluded > 0

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 22 10:59:35 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 22 Jan 2020 09:59:35 +0000
Subject: [Koha-bugs] [Bug 22690] Merging records with many items too slow
 (Elasticsearch)
In-Reply-To: <bug-22690-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22690-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22690-70-Z5E4NonrjJ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22690

Ere Maijala <ere.maijala at helsinki.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Patch doesn't apply         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 22 10:59:39 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 22 Jan 2020 09:59:39 +0000
Subject: [Koha-bugs] [Bug 22690] Merging records with many items too slow
 (Elasticsearch)
In-Reply-To: <bug-22690-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22690-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22690-70-S32D8DFn5V@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22690

Ere Maijala <ere.maijala at helsinki.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #94505|0                           |1
        is obsolete|                            |

--- Comment #13 from Ere Maijala <ere.maijala at helsinki.fi> ---
Created attachment 97696
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97696&action=edit
Bug 22690: Refactor merging of records to improve performance (Elasticsearch)

This patch allows merging of records with many items without the web server
timing out.

Test plan:

Without the patch:

- Create 2 records (one with e.g. 1000 items).
- Do a cataloguing search that displays both records, select them and click
"Merge selected".
- Choose the record with many items as the one to be eliminated.
- Start the merging.
- After a while the web server should give you a timeout error (the merging
process may still continue)

With the patch:
- Do the same as above
- This time verify that the records are merged without timeout
- Create a new biblio with an item
- Add with the item:
  * acquisition order
  * hold (reserve)
- Merge the biblio to another one
- Verify that the item and its related data was moved
- Verify that tests pass:
  prove -v t/db_dependent/Koha/Item.t
  prove -v t/db_dependent/Items/MoveItemFromBiblio.t

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 22 11:00:00 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 22 Jan 2020 10:00:00 +0000
Subject: [Koha-bugs] [Bug 22690] Merging records with many items too slow
 (Elasticsearch)
In-Reply-To: <bug-22690-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22690-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22690-70-tGXo8sCI9k@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22690

--- Comment #14 from Ere Maijala <ere.maijala at helsinki.fi> ---
Rebased.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 22 11:04:09 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 22 Jan 2020 10:04:09 +0000
Subject: [Koha-bugs] [Bug 20888] Allow use of boolean operator 'not' in item
 search
In-Reply-To: <bug-20888-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20888-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20888-70-z1GphYOM7C@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20888

--- Comment #27 from Matthias Meusburger <matthias.meusburger at biblibre.com> ---
IF = not like... else = not like?

=> Yes, this is made for "not like" to be selected if needed when going back to
the search. The "is" option is just above.


I tested with a custom item search option for "Withdrawn" linked to the
WITHDRAWN authorised value. If I pick "is not" Withdrawn I get the only
withdrawn item. If I pick 'is' withdrawn... I get all the other items. It works
ok on master for the 'is' case.

=> I tested again, with the following configurations:

Unimarc : custom withdrawn search field => OK
Marc21  : custom withdrawn search field => OK
Marc21  : default withdrawn search field => OK

Could you possibly give it another go, Cait?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 22 11:06:37 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 22 Jan 2020 10:06:37 +0000
Subject: [Koha-bugs] [Bug 24466] AllowHoldsOnPatronsPossessions and the REST
 API
In-Reply-To: <bug-24466-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24466-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24466-70-JxwH8DpTxq@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24466

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org

--- Comment #1 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
I guess we need to move that block from request.pl to CanBookBeReserved:

347         { # alreadypossession
348             # Check to see if patron is allowed to place holds on records
where the
349             # patron already has an item from that record checked out
350             if ( !C4::Context->preference('AllowHoldsOnPatronsPossessions')
351                 && CheckIfIssuedToPatron( $patron->borrowernumber,
$biblionumber ) )
352             {
353                 $template->param( alreadypossession => 1, );
354             }
355         }

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 22 11:11:59 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 22 Jan 2020 10:11:59 +0000
Subject: [Koha-bugs] [Bug 24466] AllowHoldsOnPatronsPossessions and the REST
 API
In-Reply-To: <bug-24466-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24466-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24466-70-FgoS19gN7h@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24466

--- Comment #2 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Maybe also get_opacitemholds_policy can be bypassed

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 22 11:28:00 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 22 Jan 2020 10:28:00 +0000
Subject: [Koha-bugs] [Bug 24477] No permissions check for POS feature
In-Reply-To: <bug-24477-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24477-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24477-70-fv7IMAdpN9@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24477

--- Comment #1 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 97697
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97697&action=edit
Bug 24477: Require `takepayment` permission in pos/pay.pl

When adding the point of sale take payment page in bug 23354 we missed
the permission check script side along with adding the permission at
install time (update was caught).

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 22 11:28:18 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 22 Jan 2020 10:28:18 +0000
Subject: [Koha-bugs] [Bug 24477] No permissions check for POS feature
In-Reply-To: <bug-24477-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24477-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24477-70-0EQtnq4b8m@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24477

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |martin.renvoize at ptfs-europe
                   |                            |.com
           Assignee|koha-bugs at lists.koha-commun |martin.renvoize at ptfs-europe
                   |ity.org                     |.com

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 22 11:28:22 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 22 Jan 2020 10:28:22 +0000
Subject: [Koha-bugs] [Bug 24477] No permissions check for POS feature
In-Reply-To: <bug-24477-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24477-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24477-70-BHKkI1pghD@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24477

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 22 11:29:38 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 22 Jan 2020 10:29:38 +0000
Subject: [Koha-bugs] [Bug 12133] Guarantor requirements when registering a
 patron
In-Reply-To: <bug-12133-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-12133-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12133-70-VPpyNsbkrK@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12133

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Failed QA

--- Comment #14 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
I think this new restriction needs to be enforced at module level, when the
patron is added/updated (Koha::Patron->store), with changes covered by tests.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 22 11:30:17 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 22 Jan 2020 10:30:17 +0000
Subject: [Koha-bugs] [Bug 24478] Make it possible to deactivate point of sale
In-Reply-To: <bug-24478-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24478-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24478-70-o3oJUEqW19@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24478

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |martin.renvoize at ptfs-europe
                   |                            |.com
           Assignee|koha-bugs at lists.koha-commun |martin.renvoize at ptfs-europe
                   |ity.org                     |.com

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 22 11:37:03 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 22 Jan 2020 10:37:03 +0000
Subject: [Koha-bugs] [Bug 20447] Add support for MARC holdings records
In-Reply-To: <bug-20447-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20447-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20447-70-06Zpbb3I22@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org

--- Comment #153 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
browser-strings.inc will be removed by bug 23884.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 22 11:38:40 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 22 Jan 2020 10:38:40 +0000
Subject: [Koha-bugs] [Bug 23884] Merge strings.inc and browser-strings.inc
In-Reply-To: <bug-23884-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23884-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23884-70-DaplI7V45R@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23884

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 22 11:38:43 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 22 Jan 2020 10:38:43 +0000
Subject: [Koha-bugs] [Bug 23884] Merge strings.inc and browser-strings.inc
In-Reply-To: <bug-23884-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23884-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23884-70-klkja6fBq4@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23884

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #97682|0                           |1
        is obsolete|                            |

--- Comment #5 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 97698
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97698&action=edit
Bug 23884: Merge strings.inc and browser-strings.inc

This patch take the contents of the JavaScript in browser-strings.inc
and puts it in strings.inc. browser-strings.inc is deleted.

To test, apply the patch and perform a catalog search in the staff
client.

 - View any result. In the left-hand sidebar there should be a search
   results browser box with "previous" and "next" arrows and a link back
   to search results.
 - Click on each different "view" tab and confirm that the search
   results navigation box persists: Normal, MARC, Labeled MARC, ISBD,
   Items.
 - From any of these views select Edit -> Edit items. The same
   navigation box should appear.

Note: addbiblio.tt and stockrotation.tt are modified but feature doesn't
currently work on those pages.

Signed-off-by: David Nind <david at davidnind.com>

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 22 11:44:02 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 22 Jan 2020 10:44:02 +0000
Subject: [Koha-bugs] [Bug 24105] Longoverdue gives error message when
 --itemtypes are specified
In-Reply-To: <bug-24105-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24105-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24105-70-mSUvTr9N6e@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24105

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 22 11:44:05 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 22 Jan 2020 10:44:05 +0000
Subject: [Koha-bugs] [Bug 24105] Longoverdue gives error message when
 --itemtypes are specified
In-Reply-To: <bug-24105-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24105-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24105-70-2Ch6kKCC8F@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24105

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #95799|0                           |1
        is obsolete|                            |

--- Comment #3 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 97699
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97699&action=edit
Bug 24105: Fix error when running longoverdue.pl with --itemtypes

To test:

Run Longoverdue.pl as koha-shell with both 1 and several --itemtypes specified
notice that it has an error
apply this patch
run longoverdue.pl as koha-shell with both 1 and several --itemtypes specified
notice there isn't an error anymore!

Signed-off-by: David Roberts <david.roberts at ptfs-europe.com>

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 22 11:44:18 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 22 Jan 2020 10:44:18 +0000
Subject: [Koha-bugs] [Bug 24105] Longoverdue gives error message when
 --itemtypes are specified
In-Reply-To: <bug-24105-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24105-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24105-70-zK4pkDdPPF@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24105

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Version|19.05                       |master
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org
         Depends on|                            |20436


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20436
[Bug 20436] Add ability to specify itemtypes for longoverdue.pl
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 22 11:44:18 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 22 Jan 2020 10:44:18 +0000
Subject: [Koha-bugs] [Bug 20436] Add ability to specify itemtypes for
 longoverdue.pl
In-Reply-To: <bug-20436-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20436-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20436-70-lI5IDbArHq@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20436

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |24105


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24105
[Bug 24105] Longoverdue gives error message when --itemtypes are specified
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 22 11:51:28 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 22 Jan 2020 10:51:28 +0000
Subject: [Koha-bugs] [Bug 19809] Koha::Objects::find calls do not need to be
 forbidden in list context
In-Reply-To: <bug-19809-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19809-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19809-70-C9c8MLtLLy@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19809

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 22 11:51:31 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 22 Jan 2020 10:51:31 +0000
Subject: [Koha-bugs] [Bug 19809] Koha::Objects::find calls do not need to be
 forbidden in list context
In-Reply-To: <bug-19809-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19809-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19809-70-XiNMkUbc4m@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19809

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #95115|0                           |1
        is obsolete|                            |

--- Comment #28 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 97700
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97700&action=edit
Bug 19809: Re-allow to call Koha::Objects::find in list context

and remove 'scalar' keyword in calls where it's not needed.

Signed-off-by: Brendan Gallagher <brendan at bywatersolutions.com>

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 22 11:51:35 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 22 Jan 2020 10:51:35 +0000
Subject: [Koha-bugs] [Bug 19809] Koha::Objects::find calls do not need to be
 forbidden in list context
In-Reply-To: <bug-19809-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19809-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19809-70-SS0shxk9Kd@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19809

--- Comment #29 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 97701
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97701&action=edit
Bug 19809: Remove some new occurrences

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 22 11:51:48 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 22 Jan 2020 10:51:48 +0000
Subject: [Koha-bugs] [Bug 19809] Koha::Objects::find calls do not need to be
 forbidden in list context
In-Reply-To: <bug-19809-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19809-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19809-70-hb1Jcr3ow0@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19809

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         QA Contact|m.de.rooy at rijksmuseum.nl    |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 22 11:55:30 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 22 Jan 2020 10:55:30 +0000
Subject: [Koha-bugs] [Bug 24478] Make it possible to deactivate point of sale
In-Reply-To: <bug-24478-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24478-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24478-70-XttGMmb931@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24478

--- Comment #1 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 97702
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97702&action=edit
Bug 24478: Add `EnablePointOfSale` system preference

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 22 11:55:33 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 22 Jan 2020 10:55:33 +0000
Subject: [Koha-bugs] [Bug 24478] Make it possible to deactivate point of sale
In-Reply-To: <bug-24478-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24478-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24478-70-dyiisbR6mA@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24478

--- Comment #2 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 97703
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97703&action=edit
Bug 24478: Use `EnablePointOfSale` preference

This patch adds the `EnablePointOfSale` preference to the accounting tab
on the preferences editor and ties the display of the Point of Sale
module to it.

Test plan:
1) Enable both `UseCashRegisters` and `EnablePointOfSale` preferences.
2) Ensure you are a superuser or your user has the
   takepayment permission.
3) The Point of Sale module should be present on your staff home page
   with the above configuration, otherwhise it should not.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 22 11:55:48 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 22 Jan 2020 10:55:48 +0000
Subject: [Koha-bugs] [Bug 24478] Make it possible to deactivate point of sale
In-Reply-To: <bug-24478-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24478-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24478-70-fAIJSbwYK2@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24478

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 22 11:57:37 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 22 Jan 2020 10:57:37 +0000
Subject: [Koha-bugs] [Bug 24479] New POS doesn't follow CurrencyFormat
In-Reply-To: <bug-24479-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24479-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24479-70-VZCMDogE5W@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24479

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |martin.renvoize at ptfs-europe
                   |                            |.com
           Assignee|koha-bugs at lists.koha-commun |martin.renvoize at ptfs-europe
                   |ity.org                     |.com

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 22 11:58:54 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 22 Jan 2020 10:58:54 +0000
Subject: [Koha-bugs] [Bug 23884] Merge strings.inc and browser-strings.inc
In-Reply-To: <bug-23884-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23884-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23884-70-yGcfWzhpn0@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23884

Ere Maijala <ere.maijala at helsinki.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |ere.maijala at helsinki.fi

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 22 12:04:32 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 22 Jan 2020 11:04:32 +0000
Subject: [Koha-bugs] [Bug 21507] Decimal separators issues in patrons
 payments/fines, simplified
In-Reply-To: <bug-21507-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21507-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21507-70-sRItXV6zwU@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21507

Arthur Suzuki <arthur.suzuki at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|victor at tuxayo.net           |arthur.suzuki at biblibre.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 22 12:19:27 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 22 Jan 2020 11:19:27 +0000
Subject: [Koha-bugs] [Bug 23402] Item search doesn't work with screen
 selected
In-Reply-To: <bug-23402-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23402-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23402-70-a6mUF83P51@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23402

Michael Kuhn <mik at adminkuhn.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mik at adminkuhn.ch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 22 12:19:57 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 22 Jan 2020 11:19:57 +0000
Subject: [Koha-bugs] [Bug 24479] New POS doesn't follow CurrencyFormat
In-Reply-To: <bug-24479-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24479-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24479-70-9QV5vzXfMT@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24479

--- Comment #1 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
The points you've made apply equally to the change feature elsewhere and should
be fixed there at the same time.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 22 12:20:28 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 22 Jan 2020 11:20:28 +0000
Subject: [Koha-bugs] [Bug 24479] New POS doesn't follow CurrencyFormat
In-Reply-To: <bug-24479-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24479-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24479-70-f4Tt5VLOIQ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24479

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |22359


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22359
[Bug 22359] Improve usability of 'change calculation' (bug 11373)
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 22 12:20:28 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 22 Jan 2020 11:20:28 +0000
Subject: [Koha-bugs] [Bug 22359] Improve usability of 'change calculation'
 (bug 11373)
In-Reply-To: <bug-22359-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22359-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22359-70-4luuYR09Fq@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22359

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |24479


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24479
[Bug 24479] New POS doesn't follow CurrencyFormat
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 22 12:21:21 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 22 Jan 2020 11:21:21 +0000
Subject: [Koha-bugs] [Bug 24479] New POS doesn't follow CurrencyFormat
In-Reply-To: <bug-24479-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24479-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24479-70-Jp21DV3PYV@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24479

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|martin.renvoize at ptfs-europe |koha-bugs at lists.koha-commun
                   |.com                        |ity.org

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 22 12:23:35 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 22 Jan 2020 11:23:35 +0000
Subject: [Koha-bugs] [Bug 21507] Decimal separators issues in patrons
 payments/fines, simplified
In-Reply-To: <bug-21507-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21507-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21507-70-AMiRt3Mc3c@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21507

--- Comment #9 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
I still think inputmasks are the way to go personally..
https://github.com/RobinHerbots/Inputmask

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 22 12:24:08 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 22 Jan 2020 11:24:08 +0000
Subject: [Koha-bugs] [Bug 23354] Add a 'Pay' screen to allow anonymous
 payments in a POS fashion
In-Reply-To: <bug-23354-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23354-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23354-70-7irMH7dLi1@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23354

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|rel_20_05_target            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 22 12:31:56 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 22 Jan 2020 11:31:56 +0000
Subject: [Koha-bugs] [Bug 24167] We should support installation on Debian 10
In-Reply-To: <bug-24167-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24167-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24167-70-nHa8cCRBOX@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24167

Magnus Enger <magnus at libriotech.no> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |magnus at libriotech.no

--- Comment #1 from Magnus Enger <magnus at libriotech.no> ---
What are the known problems? Just the one in bug 23799?

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 22 12:55:51 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 22 Jan 2020 11:55:51 +0000
Subject: [Koha-bugs] [Bug 24339] SIP codes are missing from the default
 payment_types on installation
In-Reply-To: <bug-24339-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24339-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24339-70-eYPzprxGSR@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24339

--- Comment #9 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
If we set it to >0 it'll be a regression in so much as we will now always show
the 'Payment type' dropdown even if only system types are defined.

I'm not sure how we can reduce the payment_types list to not include the SIP
types in the first place in those templates.. that would be the better
solution.

This is really only meant as a stop gap solution.. I hope to merge the
payment_types authorized value into the debit_types table and expose more
clearly defined options relating to the types in bug 23894

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 22 13:16:01 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 22 Jan 2020 12:16:01 +0000
Subject: [Koha-bugs] [Bug 23354] Add a 'Pay' screen to allow anonymous
 payments in a POS fashion
In-Reply-To: <bug-23354-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23354-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23354-70-cROdFNtRGL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23354

--- Comment #162 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
(In reply to Jonathan Druart from comment #161)
> my $q         = CGI->new();
> 
> We already have $input and $cgi :)

Fixed in RM followup.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 22 13:34:51 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 22 Jan 2020 12:34:51 +0000
Subject: [Koha-bugs] [Bug 24474] Lost items that are checked out are always
 returned, even when attempting to renew them
In-Reply-To: <bug-24474-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24474-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24474-70-XKeFwg3I7M@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24474

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |nick at bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 22 13:36:02 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 22 Jan 2020 12:36:02 +0000
Subject: [Koha-bugs] [Bug 23493] jquery.dataTables.rowGrouping.js is no
 longer maintained,
 but there is an official DataTables version we could switch to
In-Reply-To: <bug-23493-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23493-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23493-70-Bi2ivMH05T@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23493

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #97694|0                           |1
        is obsolete|                            |

--- Comment #13 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 97704
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97704&action=edit
Bug 23493: Replace rowGrouping with rowGroup

This patch replaces the unmaintained third party rowGrouping datatables
plugin with the supported core rowGroup replacement.

Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 22 13:36:28 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 22 Jan 2020 12:36:28 +0000
Subject: [Koha-bugs] [Bug 23493] jquery.dataTables.rowGrouping.js is no
 longer maintained,
 but there is an official DataTables version we could switch to
In-Reply-To: <bug-23493-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23493-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23493-70-JujeSNBOxt@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23493

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|23355                       |
             Blocks|                            |23355


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23355
[Bug 23355] Add 'cashup' process to the accounts system
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 22 13:36:28 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 22 Jan 2020 12:36:28 +0000
Subject: [Koha-bugs] [Bug 23355] Add 'cashup' process to the accounts system
In-Reply-To: <bug-23355-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23355-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23355-70-8TJoJyIaAm@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23355

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|23493                       |
         Depends on|                            |23493


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23493
[Bug 23493] jquery.dataTables.rowGrouping.js is no longer maintained, but there
is an official DataTables version we could switch to
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 22 13:37:22 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 22 Jan 2020 12:37:22 +0000
Subject: [Koha-bugs] [Bug 23493] jquery.dataTables.rowGrouping.js is no
 longer maintained,
 but there is an official DataTables version we could switch to
In-Reply-To: <bug-23493-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23493-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23493-70-GfLZrnRq3R@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23493

--- Comment #14 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Dependency re-ordered as requested and suitable re-base undertaken.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 22 13:40:39 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 22 Jan 2020 12:40:39 +0000
Subject: [Koha-bugs] [Bug 24397] populate_db.pl is out of sync and must be
 removed
In-Reply-To: <bug-24397-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24397-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24397-70-wleo4Xo1h7@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24397

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|In Discussion               |Passed QA
   Patch complexity|---                         |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 22 13:40:42 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 22 Jan 2020 12:40:42 +0000
Subject: [Koha-bugs] [Bug 24397] populate_db.pl is out of sync and must be
 removed
In-Reply-To: <bug-24397-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24397-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24397-70-sDeyCzlZY9@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24397

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #97238|0                           |1
        is obsolete|                            |

--- Comment #8 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 97705
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97705&action=edit
Bug 24397: Remove out of sync script populate_db.pl

populate_db.pl from koha-misc4dev must be used instead.
This script existed before the creation of koha-misc4dev, it does no
longer make sense to have it in Koha.

Signed-off-by: David Nind <david at davidnind.com>

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 22 13:44:39 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 22 Jan 2020 12:44:39 +0000
Subject: [Koha-bugs] [Bug 15260] Option for extended loan with useDaysMode
In-Reply-To: <bug-15260-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15260-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15260-70-0RRQSuXufZ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15260

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org

--- Comment #46 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
+my $dayweek_categorycode = 'C';
+my $dayweek_itemtype = 'MX';
+my $dayweek_branchcode = 'FPL';


That must not be hardcoded.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 22 13:45:49 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 22 Jan 2020 12:45:49 +0000
Subject: [Koha-bugs] [Bug 23355] Add 'cashup' process to the accounts system
In-Reply-To: <bug-23355-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23355-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23355-70-QeTpVOEUXH@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23355

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #97077|0                           |1
        is obsolete|                            |

--- Comment #51 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 97706
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97706&action=edit
Bug 23355: Add cash_register_actions table

This patch adds the new cash_register_actions database table to allow
for storing of cash register actions which are not already stored as
accountlines.

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 22 13:45:52 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 22 Jan 2020 12:45:52 +0000
Subject: [Koha-bugs] [Bug 23355] Add 'cashup' process to the accounts system
In-Reply-To: <bug-23355-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23355-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23355-70-ssBmV8O8Au@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23355

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #97078|0                           |1
        is obsolete|                            |

--- Comment #52 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 97707
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97707&action=edit
Bug 23355: [DO NOT PUSH] DBIC Classes

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 22 13:45:55 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 22 Jan 2020 12:45:55 +0000
Subject: [Koha-bugs] [Bug 23355] Add 'cashup' process to the accounts system
In-Reply-To: <bug-23355-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23355-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23355-70-rzoVbYI6qc@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23355

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #97079|0                           |1
        is obsolete|                            |

--- Comment #53 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 97708
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97708&action=edit
Bug 23355: Add CASHUP actions

This patch adds a methods relating to cashup procedures to the cash
register object to ease adding and querying for cashup actions related
to the register.

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 22 13:45:59 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 22 Jan 2020 12:45:59 +0000
Subject: [Koha-bugs] [Bug 23355] Add 'cashup' process to the accounts system
In-Reply-To: <bug-23355-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23355-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23355-70-Ap8FuJ8hm7@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23355

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #97080|0                           |1
        is obsolete|                            |

--- Comment #54 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 97709
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97709&action=edit
Bug 23355: Add accountline deletion test

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 22 13:46:03 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 22 Jan 2020 12:46:03 +0000
Subject: [Koha-bugs] [Bug 23355] Add 'cashup' process to the accounts system
In-Reply-To: <bug-23355-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23355-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23355-70-xycMJFiZPO@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23355

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #97081|0                           |1
        is obsolete|                            |

--- Comment #55 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 97710
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97710&action=edit
Bug 23355: Link cash_register_actions to cash_registers by foreign key

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 22 13:46:06 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 22 Jan 2020 12:46:06 +0000
Subject: [Koha-bugs] [Bug 23355] Add 'cashup' process to the accounts system
In-Reply-To: <bug-23355-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23355-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23355-70-ocdXCqE3cO@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23355

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #97082|0                           |1
        is obsolete|                            |

--- Comment #56 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 97711
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97711&action=edit
Bug 23355: Split tests for Line vs Lines

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 22 13:46:09 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 22 Jan 2020 12:46:09 +0000
Subject: [Koha-bugs] [Bug 23355] Add 'cashup' process to the accounts system
In-Reply-To: <bug-23355-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23355-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23355-70-vYC6meAlCP@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23355

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #97083|0                           |1
        is obsolete|                            |

--- Comment #57 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 97712
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97712&action=edit
Bug 23355: Add register details page

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 22 13:46:13 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 22 Jan 2020 12:46:13 +0000
Subject: [Koha-bugs] [Bug 23355] Add 'cashup' process to the accounts system
In-Reply-To: <bug-23355-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23355-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23355-70-2EpebYZeHy@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23355

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #97084|0                           |1
        is obsolete|                            |

--- Comment #58 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 97713
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97713&action=edit
Bug 23355: Add cashup permissions

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 22 13:46:16 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 22 Jan 2020 12:46:16 +0000
Subject: [Koha-bugs] [Bug 23355] Add 'cashup' process to the accounts system
In-Reply-To: <bug-23355-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23355-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23355-70-N1g4JgN4Ac@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23355

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #97085|0                           |1
        is obsolete|                            |

--- Comment #59 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 97714
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97714&action=edit
Bug 23355: Add branch details page

This patch adds a new 'branch details' page to the POS system which
displays a summary of the cash register transactions for a branch
since each register was last cashed up. It also allows for cashing
up individual registers or cashing up all registers at a given branch
in one transaction.

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 22 13:46:20 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 22 Jan 2020 12:46:20 +0000
Subject: [Koha-bugs] [Bug 23355] Add 'cashup' process to the accounts system
In-Reply-To: <bug-23355-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23355-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23355-70-XBxpUV5N4N@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23355

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #97088|0                           |1
        is obsolete|                            |

--- Comment #60 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 97715
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97715&action=edit
Bug 23355: Use rowGroup plugin

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 22 13:46:23 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 22 Jan 2020 12:46:23 +0000
Subject: [Koha-bugs] [Bug 23355] Add 'cashup' process to the accounts system
In-Reply-To: <bug-23355-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23355-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23355-70-dSOdXnhZXJ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23355

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #97089|0                           |1
        is obsolete|                            |

--- Comment #61 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 97716
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97716&action=edit
Bug 23355: Remove superflous use of AuthoriseValues

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 22 13:46:41 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 22 Jan 2020 12:46:41 +0000
Subject: [Koha-bugs] [Bug 23355] Add 'cashup' process to the accounts system
In-Reply-To: <bug-23355-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23355-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23355-70-1axUe1ssxT@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23355

--- Comment #62 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Rebased for dependancy order change.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 22 13:47:17 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 22 Jan 2020 12:47:17 +0000
Subject: [Koha-bugs] [Bug 24345] Fix process of suggesting purchase of
 existing title for non-logged-in users
In-Reply-To: <bug-24345-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24345-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24345-70-zakDQatrND@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24345

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 22 13:47:19 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 22 Jan 2020 12:47:19 +0000
Subject: [Koha-bugs] [Bug 24345] Fix process of suggesting purchase of
 existing title for non-logged-in users
In-Reply-To: <bug-24345-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24345-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24345-70-pEaYXX62ro@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24345

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #96830|0                           |1
        is obsolete|                            |

--- Comment #6 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 97717
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97717&action=edit
Bug 24345: Fix process of suggesting purchase of existing title for
non-logged-in users

The 'op' parameter is removed from the CGI object ($input) before
get_template_and_user is called. When the user is redirected to the
login form (from checkauth, called from get_template_and_user), the
op is lost.

Moving down the deletion fixes the problem.

Test plan:
Logout at the OPAC
Go the detail page of a bibliographic record
Click the "Suggest for purchase" link
Fill the login form
=> Without this patch you will see your suggestion list
=> With this patch applied the new suggestion form will be displayed,
prefilled with the biblio's info

Signed-off-by: Owen Leonard <oleonard at myacpl.org>

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 22 13:47:24 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 22 Jan 2020 12:47:24 +0000
Subject: [Koha-bugs] [Bug 24345] Fix process of suggesting purchase of
 existing title for non-logged-in users
In-Reply-To: <bug-24345-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24345-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24345-70-v7CLY5TBCs@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24345

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #97651|0                           |1
        is obsolete|                            |

--- Comment #7 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 97718
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97718&action=edit
Bug 24345: Fix OPACViewOthersSuggestions

Default value for $op needs to be set before the get_template_and_user lines as
it's tested for OPACViewOthersSuggestions.

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 22 13:58:00 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 22 Jan 2020 12:58:00 +0000
Subject: [Koha-bugs] [Bug 15260] Option for extended loan with useDaysMode
In-Reply-To: <bug-15260-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15260-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15260-70-d0PB51n9b1@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15260

--- Comment #47 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
(In reply to Jonathan Druart from comment #46)
> +my $dayweek_categorycode = 'C';
> +my $dayweek_itemtype = 'MX';
> +my $dayweek_branchcode = 'FPL';
> 
> 
> That must not be hardcoded.

I only see it hardcoded in a test.. can you explain what issue you perceive?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 22 14:15:41 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 22 Jan 2020 13:15:41 +0000
Subject: [Koha-bugs] [Bug 24167] We should support installation on Debian 10
In-Reply-To: <bug-24167-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24167-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24167-70-RpaG98gnDC@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24167

--- Comment #2 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
I think this bug is meant to serve as a collector.. right now the packaging is
the biggest issue and Mason has been working on that for us..

Once we have packages that build at all, we can run the test suit against it
more thorough and find other possible issues..

I'm envisaging a few DB issues as newer Debian comes with newer MariaDB and
perhaps some other dependency problems.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 22 14:15:48 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 22 Jan 2020 13:15:48 +0000
Subject: [Koha-bugs] [Bug 24167] We should support installation on Debian 10
In-Reply-To: <bug-24167-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24167-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24167-70-xun6QvNquF@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24167

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |22522

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 22 14:16:49 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 22 Jan 2020 13:16:49 +0000
Subject: [Koha-bugs] [Bug 24167] We should support installation on Debian 10
In-Reply-To: <bug-24167-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24167-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24167-70-vCmH5axpIp@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24167

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |14759


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14759
[Bug 14759] Replacement for Text::Unaccent
-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 22 14:16:49 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 22 Jan 2020 13:16:49 +0000
Subject: [Koha-bugs] [Bug 14759] Replacement for Text::Unaccent
In-Reply-To: <bug-14759-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14759-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14759-70-gSWH3o77dF@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14759

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |24167


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24167
[Bug 24167] We should support installation on Debian 10
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 22 14:17:52 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 22 Jan 2020 13:17:52 +0000
Subject: [Koha-bugs] [Bug 24479] New POS doesn't follow CurrencyFormat
In-Reply-To: <bug-24479-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24479-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24479-70-UoOinilUdY@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24479

--- Comment #2 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
I am not sure I undertand - you are using the Price TT plugin in parts of the
page, but when you get the confirmation message for change the value is not
formatted.


<p>The change to give is <b><span id="modal_change">0.00</span></b>.</p>

I am not even sure why there is 0.00 in there - and the b span construct seems
risky for translation.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 22 14:22:09 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 22 Jan 2020 13:22:09 +0000
Subject: [Koha-bugs] [Bug 23844] Noisy warns in addbiblio.pl when importing
 from Z3950
In-Reply-To: <bug-23844-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23844-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23844-70-NIixYLyHqe@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23844

--- Comment #5 from Nick Clemens <nick at bywatersolutions.com> ---
(In reply to Jonathan Druart from comment #4)
> Nick, I only get those:
> 
> Use of uninitialized value $frameworkcode in string eq at
> /kohadevbox/koha/cataloguing/addbiblio.pl line 708.
> Use of uninitialized value $frameworkcode in string eq at
> /kohadevbox/koha/cataloguing/addbiblio.pl line 712.
> Use of uninitialized value $frameworkcode in string eq at
> /kohadevbox/koha/cataloguing/addbiblio.pl line 731.
> 
> 
> Who did you end up with tab that is NULL?
> 
> I get:
> MariaDB [koha_kohadev]> select distinct(tab) from marc_subfield_structure;
> +------+
> | tab  |
> +------+
> |   -1 |
> |    0 |
> |    1 |
> |    2 |
> |    3 |
> |    4 |
> |    5 |
> |    6 |
> |    7 |
> |    8 |
> |    9 |
> |   10 |
> +------+
> 12 rows in set (0.03 sec)

I believe the issue here is when the imported record has fields that are not
defined in the frameworks - so we are trying to get the tab for a field that
has no tab defined.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 22 14:24:19 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 22 Jan 2020 13:24:19 +0000
Subject: [Koha-bugs] [Bug 24167] We should support installation on Debian 10
 [OMNIBUS]
In-Reply-To: <bug-24167-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24167-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24167-70-oreyKTlZLI@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24167

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|We should support           |We should support
                   |installation on Debian 10   |installation on Debian 10
                   |                            |[OMNIBUS]
                 CC|                            |katrin.fischer at bsz-bw.de

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 22 14:25:02 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 22 Jan 2020 13:25:02 +0000
Subject: [Koha-bugs] [Bug 24474] Lost items that are checked out are always
 returned, even when attempting to renew them
In-Reply-To: <bug-24474-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24474-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24474-70-8DqqO9UH0x@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24474

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |martin.renvoize at ptfs-europe
                   |                            |.com

--- Comment #1 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Are you intending to work on this Aleisha.. just checking before I look at it
myself.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 22 14:25:57 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 22 Jan 2020 13:25:57 +0000
Subject: [Koha-bugs] [Bug 24321] Make objects.search use mappings from
 Koha::Object(s)
In-Reply-To: <bug-24321-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24321-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24321-70-2NHutPgdhy@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24321

Andrew Isherwood <andrew.isherwood at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |andrew.isherwood at ptfs-europ
                   |                            |e.com
             Blocks|                            |23916


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23916
[Bug 23916] Issuer should be recorded and visible in patron circulation history
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 22 14:25:57 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 22 Jan 2020 13:25:57 +0000
Subject: [Koha-bugs] [Bug 23916] Issuer should be recorded and visible in
 patron circulation history
In-Reply-To: <bug-23916-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23916-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23916-70-TupIWxXYqx@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23916

Andrew Isherwood <andrew.isherwood at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |24321


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24321
[Bug 24321] Make objects.search use mappings from Koha::Object(s)
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 22 14:30:58 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 22 Jan 2020 13:30:58 +0000
Subject: [Koha-bugs] [Bug 24474] Lost items that are checked out are always
 returned, even when attempting to renew them
In-Reply-To: <bug-24474-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24474-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24474-70-dIIxRbiKot@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24474

--- Comment #2 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
It feels like yet another value to add to the `MarkLostItemsAsReturned` system
preference to me.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 22 14:41:13 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 22 Jan 2020 13:41:13 +0000
Subject: [Koha-bugs] [Bug 15260] Option for extended loan with useDaysMode
In-Reply-To: <bug-15260-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15260-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15260-70-Xo8Bh3BIW5@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15260

--- Comment #48 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
categorycode=C does not exist, working on 18936 that will add a FK on the
circulation rule, the test failed.

I fixed it there (replaced C with K), but it would be good to have it create
all the data it needs, not depend on existing data.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 22 14:44:07 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 22 Jan 2020 13:44:07 +0000
Subject: [Koha-bugs] [Bug 23916] Issuer should be recorded and visible in
 patron circulation history
In-Reply-To: <bug-23916-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23916-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23916-70-TPYP4cQkl6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23916

Andrew Isherwood <andrew.isherwood at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #95504|0                           |1
        is obsolete|                            |

--- Comment #21 from Andrew Isherwood <andrew.isherwood at ptfs-europe.com> ---
Created attachment 97719
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97719&action=edit
Bug 23916: Add issues.issuer column and FK

This patch adds the issues.issuer column which is a foreign key to
borrowers.borrowernumber

Signed-off-by: Ben Veasey <B.T.Veasey at lboro.ac.uk>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 22 14:44:10 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 22 Jan 2020 13:44:10 +0000
Subject: [Koha-bugs] [Bug 23916] Issuer should be recorded and visible in
 patron circulation history
In-Reply-To: <bug-23916-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23916-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23916-70-qeWC31NUk7@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23916

Andrew Isherwood <andrew.isherwood at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #95505|0                           |1
        is obsolete|                            |

--- Comment #22 from Andrew Isherwood <andrew.isherwood at ptfs-europe.com> ---
Created attachment 97720
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97720&action=edit
Bug 23916: Add "RecordIssuer" syspref

This patch adds the "RecordIssuer" syspref, which is disabled by default

Signed-off-by: Ben Veasey <B.T.Veasey at lboro.ac.uk>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 22 14:44:13 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 22 Jan 2020 13:44:13 +0000
Subject: [Koha-bugs] [Bug 23916] Issuer should be recorded and visible in
 patron circulation history
In-Reply-To: <bug-23916-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23916-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23916-70-OhnyZ6WNAx@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23916

Andrew Isherwood <andrew.isherwood at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #95506|0                           |1
        is obsolete|                            |

--- Comment #23 from Andrew Isherwood <andrew.isherwood at ptfs-europe.com> ---
Created attachment 97721
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97721&action=edit
Bug 23916: Record and display item issuer

This patch adds the recording and display of the item issuer. This
behaviour is governed by the RecordIssuer syspref, if disabled (the
default), no recording or display of issuer will take place.

Signed-off-by: Ben Veasey <B.T.Veasey at lboro.ac.uk>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 22 14:44:16 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 22 Jan 2020 13:44:16 +0000
Subject: [Koha-bugs] [Bug 23916] Issuer should be recorded and visible in
 patron circulation history
In-Reply-To: <bug-23916-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23916-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23916-70-Funrv53nzj@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23916

Andrew Isherwood <andrew.isherwood at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #95507|0                           |1
        is obsolete|                            |

--- Comment #24 from Andrew Isherwood <andrew.isherwood at ptfs-europe.com> ---
Created attachment 97722
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97722&action=edit
Bug 23916: Anonymise 'issuer' when required

This patch adds the anonymisation of 'old_issues.issuer' alongside the
existing anonymisation of 'old_issues.borrowernumber'

Signed-off-by: Ben Veasey <B.T.Veasey at lboro.ac.uk>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 22 14:44:19 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 22 Jan 2020 13:44:19 +0000
Subject: [Koha-bugs] [Bug 23916] Issuer should be recorded and visible in
 patron circulation history
In-Reply-To: <bug-23916-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23916-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23916-70-IehSjs324d@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23916

Andrew Isherwood <andrew.isherwood at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #95508|0                           |1
        is obsolete|                            |

--- Comment #25 from Andrew Isherwood <andrew.isherwood at ptfs-europe.com> ---
Created attachment 97723
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97723&action=edit
Bug 23916: Add unit tests

This patch adds unit tests for the new functions

Signed-off-by: Ben Veasey <B.T.Veasey at lboro.ac.uk>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 22 14:44:22 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 22 Jan 2020 13:44:22 +0000
Subject: [Koha-bugs] [Bug 23916] Issuer should be recorded and visible in
 patron circulation history
In-Reply-To: <bug-23916-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23916-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23916-70-9SwdEf4iwF@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23916

Andrew Isherwood <andrew.isherwood at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #95509|0                           |1
        is obsolete|                            |

--- Comment #26 from Andrew Isherwood <andrew.isherwood at ptfs-europe.com> ---
Created attachment 97724
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97724&action=edit
Bug 23916: (follow-up) Fix column name collision

Seems that joining 'borrowers' into the query run in
C4::Members::GetAllIssues caused a column name collision, which blatted
the retrieval of issues.branchcode. So we now are being a bit more
specific in what is coming from where in the query.

Signed-off-by: Ben Veasey <B.T.Veasey at lboro.ac.uk>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 22 14:44:37 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 22 Jan 2020 13:44:37 +0000
Subject: [Koha-bugs] [Bug 23916] Issuer should be recorded and visible in
 patron circulation history
In-Reply-To: <bug-23916-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23916-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23916-70-ifdogQLlSp@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23916

--- Comment #27 from Andrew Isherwood <andrew.isherwood at ptfs-europe.com> ---
Rebased

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 22 14:45:49 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 22 Jan 2020 13:45:49 +0000
Subject: [Koha-bugs] [Bug 23354] Add a 'Pay' screen to allow anonymous
 payments in a POS fashion
In-Reply-To: <bug-23354-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23354-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23354-70-VtpzEhCVFN@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23354

--- Comment #163 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 97725
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97725&action=edit
Bug 23354: (QA follow-up) Add takepayment permission for new installs

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 22 14:48:23 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 22 Jan 2020 13:48:23 +0000
Subject: [Koha-bugs] [Bug 23354] Add a 'Pay' screen to allow anonymous
 payments in a POS fashion
In-Reply-To: <bug-23354-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23354-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23354-70-6e0CqG8TRB@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23354

--- Comment #164 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 97726
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97726&action=edit
Bug 23354: (RM follow-up) Change $q to $input for consistency

As pointed out by Jonathan, this script introduced a third form for the
CGI variable. This patch updates the script to use the more common
$input variable name.

Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 22 14:50:37 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 22 Jan 2020 13:50:37 +0000
Subject: [Koha-bugs] [Bug 24477] No permissions check for POS feature
In-Reply-To: <bug-24477-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24477-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24477-70-98JOXuRt5V@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24477

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #97697|0                           |1
        is obsolete|                            |

--- Comment #2 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 97727
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97727&action=edit
Bug 24477: Require `takepayment` permission in pos/pay.pl

When adding the point of sale take payment page in bug 23354 we missed
the permission check script side along with adding the permission at
install time (update was caught).

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 22 14:57:52 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 22 Jan 2020 13:57:52 +0000
Subject: [Koha-bugs] [Bug 24477] No permissions check for POS feature
In-Reply-To: <bug-24477-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24477-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24477-70-vJ7qRBgxHs@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24477

ByWater Sandboxes <bws.sandboxes at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #97727|0                           |1
        is obsolete|                            |

--- Comment #3 from ByWater Sandboxes <bws.sandboxes at gmail.com> ---
Created attachment 97728
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97728&action=edit
Bug 24477: Require `takepayment` permission in pos/pay.pl

When adding the point of sale take payment page in bug 23354 we missed
the permission check script side along with adding the permission at
install time (update was caught).

Signed-off-by: Andrew Fuerste-Henry <andrew at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 22 14:58:21 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 22 Jan 2020 13:58:21 +0000
Subject: [Koha-bugs] [Bug 24477] No permissions check for POS feature
In-Reply-To: <bug-24477-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24477-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24477-70-W0HsDM3hDL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24477

Andrew Fuerste-Henry <andrew at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |andrew at bywatersolutions.com
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 22 14:59:24 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 22 Jan 2020 13:59:24 +0000
Subject: [Koha-bugs] [Bug 22179] Hide columns of all the subscriptions of a
 record with columns settings (id=subscriptionst) for the OPAC
In-Reply-To: <bug-22179-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22179-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22179-70-CRiCwSlIc7@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22179

--- Comment #3 from Marjorie Barry-Vila <marjorie.barry-vila at collecto.ca> ---
+1

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 22 15:01:29 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 22 Jan 2020 14:01:29 +0000
Subject: [Koha-bugs] [Bug 24481] New: Incorrect permission in
 admin/cash_registers.pl
Message-ID: <bug-24481-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24481

            Bug ID: 24481
           Summary: Incorrect permission in admin/cash_registers.pl
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: trivial
          Priority: P5 - low
         Component: Fines and fees
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: martin.renvoize at ptfs-europe.com
        QA Contact: testopia at bugs.koha-community.org

During rebases of the cash registers feature added in bug 23321 it appears that
one case of a changed permission name was missed in admin/cash_registers.pl.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 22 15:01:37 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 22 Jan 2020 14:01:37 +0000
Subject: [Koha-bugs] [Bug 24481] Incorrect permission in
 admin/cash_registers.pl
In-Reply-To: <bug-24481-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24481-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24481-70-EJXX6GCJgh@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24481

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |martin.renvoize at ptfs-europe
                   |ity.org                     |.com

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 22 15:01:42 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 22 Jan 2020 14:01:42 +0000
Subject: [Koha-bugs] [Bug 24481] Incorrect permission in
 admin/cash_registers.pl
In-Reply-To: <bug-24481-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24481-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24481-70-S3bWzG1Yny@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24481

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |23321


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23321
[Bug 23321] Add 'cash registers' to the accounts system
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 22 15:01:42 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 22 Jan 2020 14:01:42 +0000
Subject: [Koha-bugs] [Bug 23321] Add 'cash registers' to the accounts system
In-Reply-To: <bug-23321-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23321-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23321-70-0aHlB6fpUs@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23321

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |24481


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24481
[Bug 24481] Incorrect permission in admin/cash_registers.pl
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 22 15:04:25 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 22 Jan 2020 14:04:25 +0000
Subject: [Koha-bugs] [Bug 24477] No permissions check for POS feature
In-Reply-To: <bug-24477-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24477-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24477-70-nn13jLNjuX@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24477

--- Comment #4 from ByWater Sandboxes <bws.sandboxes at gmail.com> ---
Created attachment 97729
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97729&action=edit
Bug 24478: Use `EnablePointOfSale` preference

This patch adds the `EnablePointOfSale` preference to the accounting tab
on the preferences editor and ties the display of the Point of Sale
module to it.

Test plan:
1) Enable both `UseCashRegisters` and `EnablePointOfSale` preferences.
2) Ensure you are a superuser or your user has the
   takepayment permission.
3) The Point of Sale module should be present on your staff home page
   with the above configuration, otherwhise it should not.

Signed-off-by: Andrew Fuerste-Henry <andrew at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 22 15:04:27 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 22 Jan 2020 14:04:27 +0000
Subject: [Koha-bugs] [Bug 24477] No permissions check for POS feature
In-Reply-To: <bug-24477-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24477-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24477-70-CWhg90uuBQ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24477

ByWater Sandboxes <bws.sandboxes at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #97728|0                           |1
        is obsolete|                            |

--- Comment #5 from ByWater Sandboxes <bws.sandboxes at gmail.com> ---
Created attachment 97730
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97730&action=edit
Bug 24477: Require `takepayment` permission in pos/pay.pl

When adding the point of sale take payment page in bug 23354 we missed
the permission check script side along with adding the permission at
install time (update was caught).

Signed-off-by: Andrew Fuerste-Henry <andrew at bywatersolutions.com>

Signed-off-by: Andrew Fuerste-Henry <andrew at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 22 15:04:31 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 22 Jan 2020 14:04:31 +0000
Subject: [Koha-bugs] [Bug 24481] Incorrect permission in
 admin/cash_registers.pl
In-Reply-To: <bug-24481-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24481-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24481-70-8Y4lQBsCiU@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24481

--- Comment #1 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 97731
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97731&action=edit
Bug 24481: Correct permission name for cash registers

The permission name for changed during the implimentation of bug 23321
but one case was missed. This patch corrects that mistake.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 22 15:04:41 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 22 Jan 2020 14:04:41 +0000
Subject: [Koha-bugs] [Bug 24481] Incorrect permission in
 admin/cash_registers.pl
In-Reply-To: <bug-24481-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24481-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24481-70-YU0tGn1CV7@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24481

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 22 15:04:46 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 22 Jan 2020 14:04:46 +0000
Subject: [Koha-bugs] [Bug 24481] Incorrect permission in
 admin/cash_registers.pl
In-Reply-To: <bug-24481-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24481-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24481-70-KMaFdrnDqw@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24481

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 22 15:04:50 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 22 Jan 2020 14:04:50 +0000
Subject: [Koha-bugs] [Bug 24481] Incorrect permission in
 admin/cash_registers.pl
In-Reply-To: <bug-24481-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24481-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24481-70-Ivi1jAV5Yq@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24481

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 22 15:05:03 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 22 Jan 2020 14:05:03 +0000
Subject: [Koha-bugs] [Bug 24481] Incorrect permission in
 admin/cash_registers.pl
In-Reply-To: <bug-24481-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24481-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24481-70-FvjitSsTgz@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24481

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|trivial                     |critical

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 22 15:05:32 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 22 Jan 2020 14:05:32 +0000
Subject: [Koha-bugs] [Bug 24478] Make it possible to deactivate point of sale
In-Reply-To: <bug-24478-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24478-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24478-70-02ARv7XQ5j@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24478

ByWater Sandboxes <bws.sandboxes at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #97703|0                           |1
        is obsolete|                            |

--- Comment #3 from ByWater Sandboxes <bws.sandboxes at gmail.com> ---
Created attachment 97732
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97732&action=edit
Bug 24478: Use `EnablePointOfSale` preference

This patch adds the `EnablePointOfSale` preference to the accounting tab
on the preferences editor and ties the display of the Point of Sale
module to it.

Test plan:
1) Enable both `UseCashRegisters` and `EnablePointOfSale` preferences.
2) Ensure you are a superuser or your user has the
   takepayment permission.
3) The Point of Sale module should be present on your staff home page
   with the above configuration, otherwhise it should not.

Signed-off-by: Andrew Fuerste-Henry <andrew at bywatersolutions.com>

https://bugs.koha-community.org/show_bug.cgi?id=24477

Signed-off-by: Andrew Fuerste-Henry <andrew at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 22 15:05:34 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 22 Jan 2020 14:05:34 +0000
Subject: [Koha-bugs] [Bug 24478] Make it possible to deactivate point of sale
In-Reply-To: <bug-24478-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24478-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24478-70-edgcultXP4@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24478

--- Comment #4 from ByWater Sandboxes <bws.sandboxes at gmail.com> ---
Created attachment 97733
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97733&action=edit
Bug 24477: Require `takepayment` permission in pos/pay.pl

When adding the point of sale take payment page in bug 23354 we missed
the permission check script side along with adding the permission at
install time (update was caught).

Signed-off-by: Andrew Fuerste-Henry <andrew at bywatersolutions.com>

Signed-off-by: Andrew Fuerste-Henry <andrew at bywatersolutions.com>

Signed-off-by: Andrew Fuerste-Henry <andrew at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 22 15:05:50 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 22 Jan 2020 14:05:50 +0000
Subject: [Koha-bugs] [Bug 24478] Make it possible to deactivate point of sale
In-Reply-To: <bug-24478-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24478-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24478-70-YMjEJutGvE@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24478

Andrew Fuerste-Henry <andrew at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |andrew at bywatersolutions.com
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 22 15:06:32 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 22 Jan 2020 14:06:32 +0000
Subject: [Koha-bugs] [Bug 24477] No permissions check for POS feature
In-Reply-To: <bug-24477-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24477-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24477-70-dKSjfJEwZL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24477

--- Comment #6 from Andrew Fuerste-Henry <andrew at bywatersolutions.com> ---
Apologies for signoff confusion from sandboxes!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 22 15:06:58 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 22 Jan 2020 14:06:58 +0000
Subject: [Koha-bugs] [Bug 24477] No permissions check for POS feature
In-Reply-To: <bug-24477-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24477-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24477-70-clxvp9ai0N@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24477

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #97729|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 22 15:07:36 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 22 Jan 2020 14:07:36 +0000
Subject: [Koha-bugs] [Bug 24478] Make it possible to deactivate point of sale
In-Reply-To: <bug-24478-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24478-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24478-70-RItdLgWv5P@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24478

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #97733|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 22 15:09:33 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 22 Jan 2020 14:09:33 +0000
Subject: [Koha-bugs] [Bug 24482] New: Purchase Items broken by costs
 containing a comma
Message-ID: <bug-24482-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24482

            Bug ID: 24482
           Summary: Purchase Items broken by costs containing a comma
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: Staff Client
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: andrew at bywatersolutions.com
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com

To test:
- enable cash registers and point of sale
- create a purchase item with a cost of $1000
- go to Point of Sale and attempt to sell one of your item
- Note that Koha inserts a comma into the price and breaks its own math in
calculating the amount due

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 22 15:10:03 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 22 Jan 2020 14:10:03 +0000
Subject: [Koha-bugs] [Bug 24481] Incorrect permission in
 admin/cash_registers.pl
In-Reply-To: <bug-24481-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24481-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24481-70-1gLXHS4hdS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24481

--- Comment #2 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Marking as signed off to go straight to QA as it's a minor but important
change.. I would have done it as an RM follow-up but as it needs backporting to
19.11 it's sensible to give it it's own bug

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 22 15:10:22 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 22 Jan 2020 14:10:22 +0000
Subject: [Koha-bugs] [Bug 24482] Purchase Items broken by costs containing a
 comma
In-Reply-To: <bug-24482-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24482-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24482-70-QcjaglK9Yr@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24482

Andrew Fuerste-Henry <andrew at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |martin.renvoize at ptfs-europe
                   |                            |.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 22 15:11:57 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 22 Jan 2020 14:11:57 +0000
Subject: [Koha-bugs] [Bug 24481] Incorrect permission in
 admin/cash_registers.pl
In-Reply-To: <bug-24481-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24481-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24481-70-PIv7nryAJN@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24481

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 22 15:12:00 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 22 Jan 2020 14:12:00 +0000
Subject: [Koha-bugs] [Bug 24481] Incorrect permission in
 admin/cash_registers.pl
In-Reply-To: <bug-24481-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24481-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24481-70-iURyL3Ltyx@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24481

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #97731|0                           |1
        is obsolete|                            |

--- Comment #3 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 97734
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97734&action=edit
Bug 24481: Correct permission name for cash registers

The permission name for changed during the implimentation of bug 23321
but one case was missed. This patch corrects that mistake.

Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 22 15:12:25 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 22 Jan 2020 14:12:25 +0000
Subject: [Koha-bugs] [Bug 24481] Incorrect permission in
 admin/cash_registers.pl
In-Reply-To: <bug-24481-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24481-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24481-70-nnuaryp8sq@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24481

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |nick at bywatersolutions.com

--- Comment #4 from Nick Clemens <nick at bywatersolutions.com> ---
Easy fix, simple change, SO+QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 22 15:14:04 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 22 Jan 2020 14:14:04 +0000
Subject: [Koha-bugs] [Bug 18936] Convert issuingrules fields to
 circulation_rules
In-Reply-To: <bug-18936-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18936-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18936-70-OXA2pqJJHY@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18936

--- Comment #93 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Patches rebased.

There is one test that is failing I do not manage to fix
(t/db_dependent/Koha/Charges/Fees.t).

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 22 15:22:43 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 22 Jan 2020 14:22:43 +0000
Subject: [Koha-bugs] [Bug 15522] New interface for revamped circulation rules
In-Reply-To: <bug-15522-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15522-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15522-70-SA59Cds9As@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15522

--- Comment #43 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Patches rebased.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 22 15:24:59 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 22 Jan 2020 14:24:59 +0000
Subject: [Koha-bugs] [Bug 22615] Add /ill_backends endpoint
In-Reply-To: <bug-22615-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22615-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22615-70-3vhl9XVFAJ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22615

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #87284|0                           |1
        is obsolete|                            |

--- Comment #9 from Josef Moravec <josef.moravec at gmail.com> ---
Created attachment 97735
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97735&action=edit
Bug 22615: Add /ill_backends endpoint

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 22 15:25:03 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 22 Jan 2020 14:25:03 +0000
Subject: [Koha-bugs] [Bug 22615] Add /ill_backends endpoint
In-Reply-To: <bug-22615-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22615-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22615-70-vs9kY3uiLx@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22615

--- Comment #10 from Josef Moravec <josef.moravec at gmail.com> ---
Created attachment 97736
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97736&action=edit
Bug 22615: Add endpoint for getting one ill backend

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 22 15:25:07 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 22 Jan 2020 14:25:07 +0000
Subject: [Koha-bugs] [Bug 22615] Add /ill_backends endpoint
In-Reply-To: <bug-22615-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22615-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22615-70-Oo3mHX326v@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22615

--- Comment #11 from Josef Moravec <josef.moravec at gmail.com> ---
Created attachment 97737
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97737&action=edit
Bug 22615: Fix perlcritic

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 22 15:29:57 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 22 Jan 2020 14:29:57 +0000
Subject: [Koha-bugs] [Bug 22615] Add /ill_backends endpoint
In-Reply-To: <bug-22615-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22615-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22615-70-kY85I0Scir@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22615

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff

--- Comment #12 from Josef Moravec <josef.moravec at gmail.com> ---
The RFC was voted some time ago.

Now I added a single backend endpoint.

Test plan:
1) Apply the patch
2) restart_all
3) Try to get all backends using /ill_backends endpoint
4) Try to get one backend using /ill_backends/{backend_id/name}
for exampler /ill_backends/FreeForm

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 22 15:30:14 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 22 Jan 2020 14:30:14 +0000
Subject: [Koha-bugs] [Bug 24474] Lost items that are checked out are always
 returned, even when attempting to renew them
In-Reply-To: <bug-24474-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24474-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24474-70-0V8snltOsg@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24474

--- Comment #3 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Hm, if a library doesn't charge a lost fee and somene renews an item marked
lost - would it still return it? I think the renewal part is what worries me
most here and I think we shoudl never return an item on renewal. On paying the
fine off, I can see why someone would want it and that seems ok to be pref
driven.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 22 15:36:44 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 22 Jan 2020 14:36:44 +0000
Subject: [Koha-bugs] [Bug 24483] New: When batch deleting patrons,
 report who was not deleted and why
Message-ID: <bug-24483-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24483

            Bug ID: 24483
           Summary: When batch deleting patrons, report who was not
                    deleted and why
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: Tools
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: andrew at bywatersolutions.com
        QA Contact: testopia at bugs.koha-community.org

When using the batch patron deletion tool, patrons are not deleted if:
- They have current checkouts
- They have a non-zero balance
- They are the guarantor to another patron
- They are of a patron category of type staff

But Koha never specifically tells the user which borrowers out of their defined
pool for deletion are not deleted or why.

To test:
- Create a patron list
- Add to that list one patron for each of these conditions:
-- one patron with an item checked out
-- one patron with a non-zero balance
-- one patron who is a guarantor
-- one patron in a staff category
-- one patron not meeting any of the conditions above
- Go to batch patron deletion, attempt to delete all patrons on your list
- Koha tells you 1 patron will be deleted

Ideally, Koha would give a list of which patrons will not be deleted and why.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 22 15:37:02 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 22 Jan 2020 14:37:02 +0000
Subject: [Koha-bugs] [Bug 24483] When batch deleting patrons,
 report who was not deleted and why
In-Reply-To: <bug-24483-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24483-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24483-70-StxoaF97IW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24483

Andrew Fuerste-Henry <andrew at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |nick at bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 22 15:49:36 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 22 Jan 2020 14:49:36 +0000
Subject: [Koha-bugs] [Bug 16522] Add 773 (Host item entry) to the cart
 display and e-mail
In-Reply-To: <bug-16522-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16522-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16522-70-vcP1qn86TB@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16522

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|enhancement                 |normal

--- Comment #1 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
I am changing this to be a bug - the analytical information is useless without
the source.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 22 15:51:10 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 22 Jan 2020 14:51:10 +0000
Subject: [Koha-bugs] [Bug 24481] Incorrect permission in
 admin/cash_registers.pl
In-Reply-To: <bug-24481-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24481-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24481-70-jhxYgO9WL8@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24481

--- Comment #5 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 97738
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97738&action=edit
Bug 24481: Move manage_cash_registers to parameters permission

This patch moves the manage_cash_registers subpermission to the more
appropriate location under 'parameters'.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 22 15:51:13 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 22 Jan 2020 14:51:13 +0000
Subject: [Koha-bugs] [Bug 24481] Incorrect permission in
 admin/cash_registers.pl
In-Reply-To: <bug-24481-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24481-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24481-70-QZVTMQwJ11@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24481

--- Comment #6 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 97739
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97739&action=edit
Bug 24481: Correct permission name in admin/cash_registers.pl

The permission name for changed during the implimentation of bug 23321
but one case was missed. This patch corrects that mistake.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 22 15:51:16 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 22 Jan 2020 14:51:16 +0000
Subject: [Koha-bugs] [Bug 24481] Incorrect permission in
 admin/cash_registers.pl
In-Reply-To: <bug-24481-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24481-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24481-70-Gd3p8U3O9T@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24481

--- Comment #7 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 97740
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97740&action=edit
Bug 24481: Permission corrections for admin menu templates

This patch updates the admin menu include and admin home page to reflect
the updated permissions name for cash registers

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 22 15:51:19 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 22 Jan 2020 14:51:19 +0000
Subject: [Koha-bugs] [Bug 24481] Incorrect permission in
 admin/cash_registers.pl
In-Reply-To: <bug-24481-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24481-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24481-70-m3omlSqkqM@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24481

--- Comment #8 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 97741
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97741&action=edit
Bug 24481: Permissions update for POS menu include

This patch updates the point of sale menu include to reflect the updated
permissions name for cash registers

Note: Not required for 19.11

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 22 15:54:56 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 22 Jan 2020 14:54:56 +0000
Subject: [Koha-bugs] [Bug 24481] Incorrect permission in
 admin/cash_registers.pl
In-Reply-To: <bug-24481-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24481-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24481-70-5A6TwG1Hhn@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24481

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #97734|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 22 15:55:15 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 22 Jan 2020 14:55:15 +0000
Subject: [Koha-bugs] [Bug 24481] Incorrect permission in
 admin/cash_registers.pl
In-Reply-To: <bug-24481-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24481-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24481-70-2WNlDFLn1X@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24481

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 22 15:56:17 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 22 Jan 2020 14:56:17 +0000
Subject: [Koha-bugs] [Bug 24481] Incorrect permission in
 admin/cash_registers.pl
In-Reply-To: <bug-24481-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24481-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24481-70-UF0omHj4Ul@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24481

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |23354


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23354
[Bug 23354] Add a 'Pay' screen to allow anonymous payments in a POS fashion
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 22 15:56:17 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 22 Jan 2020 14:56:17 +0000
Subject: [Koha-bugs] [Bug 23354] Add a 'Pay' screen to allow anonymous
 payments in a POS fashion
In-Reply-To: <bug-23354-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23354-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23354-70-PiOZ8OMFyO@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23354

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |24481


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24481
[Bug 24481] Incorrect permission in admin/cash_registers.pl
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 22 15:56:38 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 22 Jan 2020 14:56:38 +0000
Subject: [Koha-bugs] [Bug 24481] Incorrect permission in
 admin/cash_registers.pl
In-Reply-To: <bug-24481-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24481-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24481-70-qMOolcCfQv@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24481

--- Comment #9 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Only the final patch depends on 23354 and this patch should not be backported
to 19.11

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 22 15:59:36 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 22 Jan 2020 14:59:36 +0000
Subject: [Koha-bugs] [Bug 24440] Add ->holds and ->holds_count to
 Koha::Acquisition::Order
In-Reply-To: <bug-24440-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24440-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24440-70-E7S5KsCBcd@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24440

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org

--- Comment #5 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Koha::Acquisition::Order->holds does not make sense to me. There is not hold
placed on an order.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 22 16:03:56 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 22 Jan 2020 15:03:56 +0000
Subject: [Koha-bugs] [Bug 24484] New: Add explanatory text to batch patron
 deletion
Message-ID: <bug-24484-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24484

            Bug ID: 24484
           Summary: Add explanatory text to batch patron deletion
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: Tools
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: andrew at bywatersolutions.com
        QA Contact: testopia at bugs.koha-community.org

On the first page of the batch patron deletion tool, it'd be helpful to have
text explaining which types of patrons will be skipped in the deletion. Right
now, there is a brief bit of descriptive text that reads:
"This tool allows you to delete patrons and anonymize checkout history. For
deleting patrons, any combination of limits can be used."

I'd like that amended to:
"This tool allows you to delete patrons and anonymize checkout history. For
deleting patrons, any combination of limits can be used. Patrons will not be
deleted if they meet one of more of the following conditions:
- They have items currently checked out.
- They have a non-zero account balance.
- They are the guarantor to another patron.
- They in a patron category of type Staff."

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 22 16:05:00 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 22 Jan 2020 15:05:00 +0000
Subject: [Koha-bugs] [Bug 24228] Add a parameter to recursively embed
 objects in Koha::Object(s)->to_api
In-Reply-To: <bug-24228-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24228-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24228-70-e6Qo2WPRYM@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24228

--- Comment #20 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
What does $curr mean?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 22 16:05:06 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 22 Jan 2020 15:05:06 +0000
Subject: [Koha-bugs] [Bug 24483] When batch deleting patrons,
 report who was not deleted and why
In-Reply-To: <bug-24483-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24483-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24483-70-jd3QUQ5oOA@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24483

Sally <sally.healey at cheshiresharedservices.gov.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |sally.healey at cheshireshared
                   |                            |services.gov.uk

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 22 16:05:42 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 22 Jan 2020 15:05:42 +0000
Subject: [Koha-bugs] [Bug 24228] Add a parameter to recursively embed
 objects in Koha::Object(s)->to_api
In-Reply-To: <bug-24228-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24228-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24228-70-RLYd60mglb@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24228

--- Comment #21 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
(In reply to Jonathan Druart from comment #20)
> What does $curr mean?

ok, it's current I guess.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 22 16:14:14 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 22 Jan 2020 15:14:14 +0000
Subject: [Koha-bugs] [Bug 24477] No permissions check for POS feature
In-Reply-To: <bug-24477-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24477-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24477-70-Mekv3789Eq@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24477

--- Comment #7 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
No apology necessary, thanks for taking the time to look at it :)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 22 16:14:50 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 22 Jan 2020 15:14:50 +0000
Subject: [Koha-bugs] [Bug 22615] Add /ill_backends endpoint
In-Reply-To: <bug-22615-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22615-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22615-70-Vw3ypLsH5V@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22615

Andrew Isherwood <andrew.isherwood at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 22 16:14:53 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 22 Jan 2020 15:14:53 +0000
Subject: [Koha-bugs] [Bug 22615] Add /ill_backends endpoint
In-Reply-To: <bug-22615-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22615-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22615-70-RswkWzXL6R@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22615

Andrew Isherwood <andrew.isherwood at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #97735|0                           |1
        is obsolete|                            |

--- Comment #13 from Andrew Isherwood <andrew.isherwood at ptfs-europe.com> ---
Created attachment 97742
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97742&action=edit
Bug 22615: Add /ill_backends endpoint

Signed-off-by: Andrew Isherwood <andrew.isherwood at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 22 16:14:56 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 22 Jan 2020 15:14:56 +0000
Subject: [Koha-bugs] [Bug 22615] Add /ill_backends endpoint
In-Reply-To: <bug-22615-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22615-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22615-70-ds5Z91FV81@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22615

Andrew Isherwood <andrew.isherwood at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #97736|0                           |1
        is obsolete|                            |

--- Comment #14 from Andrew Isherwood <andrew.isherwood at ptfs-europe.com> ---
Created attachment 97743
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97743&action=edit
Bug 22615: Add endpoint for getting one ill backend

Signed-off-by: Andrew Isherwood <andrew.isherwood at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 22 16:14:59 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 22 Jan 2020 15:14:59 +0000
Subject: [Koha-bugs] [Bug 22615] Add /ill_backends endpoint
In-Reply-To: <bug-22615-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22615-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22615-70-Xu9fGyGdGP@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22615

Andrew Isherwood <andrew.isherwood at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #97737|0                           |1
        is obsolete|                            |

--- Comment #15 from Andrew Isherwood <andrew.isherwood at ptfs-europe.com> ---
Created attachment 97744
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97744&action=edit
Bug 22615: Fix perlcritic

Signed-off-by: Andrew Isherwood <andrew.isherwood at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 22 16:27:10 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 22 Jan 2020 15:27:10 +0000
Subject: [Koha-bugs] [Bug 23501] Drag-and-drop hold reordering in the staff
 client
In-Reply-To: <bug-23501-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23501-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23501-70-4hdeiLrhZi@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23501

--- Comment #9 from Christopher Brannon <cbrannon at cdalibrary.org> ---
Another thought...I like the idea of the action menu, but one thing that is
needed is to visually see that items are pinned to the bottom.  We don't have
that, from what I gather.  I'm thinking, loose the bump up and down arrows, and
keep a pushpin on the end.  Have it change color when in use (unless there is a
another pushpin in a another position.  That way it visually signals that it is
in use.  That would leave just the bump to top and bottom in the action menu. 
Personally, my thoughts are that it not THAT cumbersome to just use the
dropdown for the numbers.  The scrollbar makes that pretty simple.  BUT, I'm
wondering if those two options could be added to the top of the choice of
numbers.  For that matter, could Suspend and Cancel be added as well?  Or maybe
it is tossing to much at it?  Thoughts?

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 22 16:30:24 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 22 Jan 2020 15:30:24 +0000
Subject: [Koha-bugs] [Bug 22868] Circulation staff with suggestions_manage
 can have access to acquisition data
In-Reply-To: <bug-22868-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22868-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22868-70-nChGBlJCZx@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22868

--- Comment #23 from Christopher Brannon <cbrannon at cdalibrary.org> ---
Personally, I think if a staff member can add a suggestion, they need to be
able to edit or remove as well, but from the patron interface, not from the
global table.  Less likely to affect the wrong patron.  That seems the most
logical.  The global table needs its own permission.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 22 16:41:10 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 22 Jan 2020 15:41:10 +0000
Subject: [Koha-bugs] [Bug 22868] Circulation staff with suggestions_manage
 can have access to acquisition data
In-Reply-To: <bug-22868-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22868-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22868-70-vbsl69B9UR@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22868

--- Comment #24 from karen.fellows at citruslibraries.org ---
I agree with Christopher and going off of my comment from above-- "In the past,
staff were allowed staff to create purchase suggestions for patrons, but they
could not edit/delete them."--We want this feature back.

Circ staff need to be able to enter the suggestions but not manage them--we
have technical services staff that complete that task, not circulation staff. 
The idea is to make it easier for the circ staff to help the patrons put in
suggestions since most of the patrons don't log in to their accounts to do it
themselves.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 22 16:48:47 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 22 Jan 2020 15:48:47 +0000
Subject: [Koha-bugs] [Bug 24484] Add explanatory text to batch patron
 deletion
In-Reply-To: <bug-24484-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24484-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24484-70-5SgFc11eIi@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24484

--- Comment #1 from Andrew Fuerste-Henry <andrew at bywatersolutions.com> ---
Missed a word in my last bullet:
"They sre in a patron category of type Staff."

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 22 16:53:05 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 22 Jan 2020 15:53:05 +0000
Subject: [Koha-bugs] [Bug 24485] New: Sys Pref AllowHoldPolicyOverride will
 not Staff override a Holds Per Record Rule
Message-ID: <bug-24485-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24485

            Bug ID: 24485
           Summary: Sys Pref AllowHoldPolicyOverride will not Staff
                    override a Holds Per Record Rule
 Change sponsored?: ---
           Product: Koha
           Version: 19.05
          Hardware: All
                OS: All
            Status: NEW
          Severity: minor
          Priority: P5 - low
         Component: Hold requests
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: kelly at bywatersolutions.com
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com

Prior to 19.05, if a library had the system preference,
AllowHoldPolicyOverride, set to Allow, a staff member could place more than one
item specific hold on a record although the circulation rule for "Holds per
Record" was set to 1.  Currently, in 19.05.06, the ability to override such a
hold has been removed.  The process stops at the portion where the second item
level hold is about to be placed, however, the Place Hold (at the bottom)
button is Greyed out.  This means Koha is allowing the staff member to choose
the item and then not letting the process to complete.

A library with the system preference set to ALLOW for AllowHoldPolicyOverride
should be allowed to override a hold rule.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 22 17:20:24 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 22 Jan 2020 16:20:24 +0000
Subject: [Koha-bugs] [Bug 20212] Slowness in Receiving in Acquisitions
In-Reply-To: <bug-20212-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20212-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20212-70-uHCGPnufXW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20212

--- Comment #17 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 97745
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97745&action=edit
Bug 20212: Display correct number of items

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 22 17:21:07 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 22 Jan 2020 16:21:07 +0000
Subject: [Koha-bugs] [Bug 24467] *_count methods should be avoided
In-Reply-To: <bug-24467-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24467-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24467-70-ETRoAIcvWi@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24467

--- Comment #2 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 97746
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97746&action=edit
Bug 24467: Remove _count methods

Add a trick to guess what we need to call.

Note that it does not work, do not know why. Tests are missing to make
sure everything is ok.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 22 17:21:26 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 22 Jan 2020 16:21:26 +0000
Subject: [Koha-bugs] [Bug 24467] *_count methods should be avoided
In-Reply-To: <bug-24467-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24467-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24467-70-Ey66b3WpWG@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24467

--- Comment #3 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
This is what I had in mind.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 22 17:32:42 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 22 Jan 2020 16:32:42 +0000
Subject: [Koha-bugs] [Bug 24025] Make CodeMirror content searchable
In-Reply-To: <bug-24025-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24025-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24025-70-9JkN2edotN@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24025

Lucas Gass <lucas at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 22 17:32:52 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 22 Jan 2020 16:32:52 +0000
Subject: [Koha-bugs] [Bug 24025] Make CodeMirror content searchable
In-Reply-To: <bug-24025-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24025-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24025-70-u5oY5XgIm5@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24025

--- Comment #5 from Lucas Gass <lucas at bywatersolutions.com> ---
Created attachment 97747
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97747&action=edit
Bug 24025: Make CodeMirror content searchable

TEST PLAN:
1. Have a system pref like OPACUserJS will plenty of content.
2. Search for some with CTRL + F that is below the scroll
3. It is not findable.
4. Apply patch, restart_all, and clear your browser cache. 
5. Reload the sys pref and try again, you should be able to search through
everything.
6. Rejoice!

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 22 17:40:33 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 22 Jan 2020 16:40:33 +0000
Subject: [Koha-bugs] [Bug 24467] *_count methods should be avoided
In-Reply-To: <bug-24467-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24467-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24467-70-mmCm07GeZg@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24467

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |20212


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20212
[Bug 20212] Slowness in Receiving in Acquisitions
-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 22 17:40:33 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 22 Jan 2020 16:40:33 +0000
Subject: [Koha-bugs] [Bug 20212] Slowness in Receiving in Acquisitions
In-Reply-To: <bug-20212-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20212-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20212-70-tDaFNTt8kQ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20212

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |24467


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24467
[Bug 24467] *_count methods should be avoided
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 22 17:45:06 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 22 Jan 2020 16:45:06 +0000
Subject: [Koha-bugs] [Bug 15505] Mark Hold Items 'On hold' instead of
 'Available'
In-Reply-To: <bug-15505-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15505-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15505-70-LQZJWH2GuO@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15505

Margaret <margaret at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |margaret at bywatersolutions.c
                   |                            |om
         Version(s)|                            |19.05
        released in|                            |18.11.05

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 22 17:45:32 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 22 Jan 2020 16:45:32 +0000
Subject: [Koha-bugs] [Bug 22002] Each message_transport_type in the letters
 table is showing as a separate notice in Tools > Notices and slips
In-Reply-To: <bug-22002-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22002-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22002-70-eff58JjFrk@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22002

Margaret <margaret at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |margaret at bywatersolutions.c
                   |                            |om
         Version(s)|                            |19.05
        released in|                            |18.05.11

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 22 17:46:50 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 22 Jan 2020 16:46:50 +0000
Subject: [Koha-bugs] [Bug 22868] Circulation staff with suggestions_manage
 can have access to acquisition data
In-Reply-To: <bug-22868-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22868-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22868-70-qHHnvEsmLn@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22868

--- Comment #25 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
(In reply to karen.fellows from comment #24)
> I agree with Christopher and going off of my comment from above-- "In the
> past, staff were allowed staff to create purchase suggestions for patrons,
> but they could not edit/delete them."--We want this feature back.

I believe this is not true - the page was still accessible and staff could have
added/edited anytime, just the acq module link would not show on the start
page. We have used this 'loophole' for ages by linking to the page directly for
libraries not using the acq module otherwise. There was NO permission check on
the suggestions module page (apart from "catalogue").

I just tested this in a 17.11.:
- Create a user without any acq access
- Go to any patron account
- Create a new purchase suggestion
- Click on the "purchase suggestions" part of the breadcrumbs
- You can managed (edit/add) your heart out.

The regression is, that you can see other acq details, but not in the
suggestions handling. 

> Circ staff need to be able to enter the suggestions but not manage them--we
> have technical services staff that complete that task, not circulation
> staff.  The idea is to make it easier for the circ staff to help the patrons
> put in suggestions since most of the patrons don't log in to their accounts
> to do it themselves.

I am not saying we could not make this more granular. The change here will even
make that possible. By moving the suggestion permission to be a top-level
permission, we will be able to have sub permissions as a next step. I am just
saying, let's fix it to where we were before - then move forward from there.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 22 18:37:17 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 22 Jan 2020 17:37:17 +0000
Subject: [Koha-bugs] [Bug 24025] Make CodeMirror content searchable
In-Reply-To: <bug-24025-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24025-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24025-70-c9EGfof9Q7@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24025

ByWater Sandboxes <bws.sandboxes at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #97747|0                           |1
        is obsolete|                            |

--- Comment #6 from ByWater Sandboxes <bws.sandboxes at gmail.com> ---
Created attachment 97748
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97748&action=edit
Bug 24025: Make CodeMirror content searchable

Signed-off-by: Barbara Johnson <barbara.johnson at bedfordtx.gov>

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 22 18:39:20 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 22 Jan 2020 17:39:20 +0000
Subject: [Koha-bugs] [Bug 24025] Make CodeMirror content searchable
In-Reply-To: <bug-24025-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24025-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24025-70-ZqLM52xSvl@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24025

--- Comment #7 from Barbara Johnson <barbara.johnson at bedfordtx.gov> ---
I tested this patch with OPACUserJS, OPACUserCSS, IntranetUserJS,
IntranetUserCSS and RestrictedPageContent.  It worked for all of them.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 22 18:40:44 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 22 Jan 2020 17:40:44 +0000
Subject: [Koha-bugs] [Bug 24025] Make CodeMirror content searchable
In-Reply-To: <bug-24025-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24025-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24025-70-tDj0dSLtt5@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24025

Barbara Johnson <barbara.johnson at bedfordtx.gov> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 22 19:04:54 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 22 Jan 2020 18:04:54 +0000
Subject: [Koha-bugs] [Bug 24467] *_count methods should be avoided
In-Reply-To: <bug-24467-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24467-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24467-70-ZMdOCd5Pyo@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24467

--- Comment #4 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
(In reply to Jonathan Druart from comment #3)
> This is what I had in mind.

Nice, I would prefer the + separator. And was waiting for bug 24356 and the
work Agustin is doing for sorting and filtering on related tables.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 22 19:14:21 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 22 Jan 2020 18:14:21 +0000
Subject: [Koha-bugs] [Bug 21049] Rancor 007 field does not retain value
In-Reply-To: <bug-21049-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21049-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21049-70-WXPOwax0jE@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21049

Margaret <margaret at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|                            |19.05
        released in|                            |18.11.05
                   |                            |18.05.12
                 CC|                            |margaret at bywatersolutions.c
                   |                            |om

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 22 19:15:17 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 22 Jan 2020 18:15:17 +0000
Subject: [Koha-bugs] [Bug 24486] New: Account Wording Information is
 duplicated in Patron's Fines Tab on OPAC
Message-ID: <bug-24486-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24486

            Bug ID: 24486
           Summary: Account Wording Information is duplicated in Patron's
                    Fines Tab on OPAC
 Change sponsored?: ---
           Product: Koha
           Version: 19.05
          Hardware: All
                OS: All
            Status: NEW
          Severity: trivial
          Priority: P5 - low
         Component: OPAC
          Assignee: oleonard at myacpl.org
          Reporter: kelly at bywatersolutions.com
        QA Contact: testopia at bugs.koha-community.org

Created attachment 97749
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97749&action=edit
duplicate language

When a patron is logged into the OPAC and views their Fines tab- they will see
a description of the Fine duplicated.  

For example: 
Credit (Voided) (Voided) 
Fine (Accruing) (Acrruing)
Payment (Voided) (Voided)


Attaching a screenshot.

It is not necessary and could be confusing to the patron to have this
duplicated per line.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 22 19:30:39 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 22 Jan 2020 18:30:39 +0000
Subject: [Koha-bugs] [Bug 14850] Funds from inactive budgets appear in
 'Funds' dropdown on acqui/invoice.pl
In-Reply-To: <bug-14850-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14850-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14850-70-xanBnVUmap@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14850

Margaret <margaret at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|                            |19.05
        released in|                            |18.11.04
                 CC|                            |margaret at bywatersolutions.c
                   |                            |om

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 22 20:10:22 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 22 Jan 2020 19:10:22 +0000
Subject: [Koha-bugs] [Bug 24380] Backdated returns do not update fines
 unless CalculateFinesOnReturn is enabled
In-Reply-To: <bug-24380-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24380-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24380-70-V7otT01Ggi@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24380

--- Comment #4 from Kyle M Hall <kyle at bywatersolutions.com> ---
(In reply to Jonathan Druart from comment #3)
> Kyle, can you provide tests please?

Absolutely!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 22 20:10:46 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 22 Jan 2020 19:10:46 +0000
Subject: [Koha-bugs] [Bug 24380] Backdated returns do not update fines
 unless CalculateFinesOnReturn is enabled
In-Reply-To: <bug-24380-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24380-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24380-70-30FIEDsJIe@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24380

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 22 20:10:49 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 22 Jan 2020 19:10:49 +0000
Subject: [Koha-bugs] [Bug 24380] Backdated returns do not update fines
 unless CalculateFinesOnReturn is enabled
In-Reply-To: <bug-24380-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24380-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24380-70-5fEmHIoPaY@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24380

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #97544|0                           |1
        is obsolete|                            |

--- Comment #5 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 97750
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97750&action=edit
Bug 24380 - Unit Test

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 22 20:11:31 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 22 Jan 2020 19:11:31 +0000
Subject: [Koha-bugs] [Bug 24380] Backdated returns do not update fines
 unless CalculateFinesOnReturn is enabled
In-Reply-To: <bug-24380-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24380-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24380-70-ktC94vGfZl@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24380

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #97750|0                           |1
        is obsolete|                            |

--- Comment #6 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 97751
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97751&action=edit
Bug 24380 - Unit Test

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 22 20:11:38 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 22 Jan 2020 19:11:38 +0000
Subject: [Koha-bugs] [Bug 24380] Backdated returns do not update fines
 unless CalculateFinesOnReturn is enabled
In-Reply-To: <bug-24380-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24380-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24380-70-zyn8t7Ruxd@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24380

--- Comment #7 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 97752
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97752&action=edit
Bug 24380 - Backdated returns do not update fines unless CalculateFinesOnReturn
is enabled

In Koha 18.11 backdating a return triggered a recalculation of the fine. This
was removed in bug 14591, and I believe it was in error. The bug report itself
has no justification for the change in behavior.

Test Plan:
1) Disable CalculateFinesOnReturn
2) Backdate an overdue with fines, note the fine does not change
3) Apply this patch
4) Repeat step 2
5) The fine should be updated!

Signed-off-by: Kelly McElligott <kelly at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 22 20:47:00 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 22 Jan 2020 19:47:00 +0000
Subject: [Koha-bugs] [Bug 24474] Lost items that are checked out are always
 returned, even when attempting to renew them
In-Reply-To: <bug-24474-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24474-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24474-70-DCkFBc9LU3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24474

--- Comment #4 from Aleisha Amohia <aleisha at catalyst.net.nz> ---
(In reply to Martin Renvoize from comment #1)
> Are you intending to work on this Aleisha.. just checking before I look at
> it myself.

Thanks for checking Martin, feel free to work on this yourself.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 22 21:18:41 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 22 Jan 2020 20:18:41 +0000
Subject: [Koha-bugs] [Bug 15522] New interface for revamped circulation rules
In-Reply-To: <bug-15522-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15522-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15522-70-qvEYopjmIl@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15522

Michal Denar <black23 at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

--- Comment #44 from Michal Denar <black23 at gmail.com> ---
It's working for me. 

Nice and useful work.

Thank You Jonathan.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 22 21:55:11 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 22 Jan 2020 20:55:11 +0000
Subject: [Koha-bugs] [Bug 23064] Cannot edit subscription with strict SQL
 modes turned on
In-Reply-To: <bug-23064-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23064-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23064-70-BqG0svyw0u@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23064

Hayley Mapley <hayleymapley at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #95611|0                           |1
        is obsolete|                            |

--- Comment #10 from Hayley Mapley <hayleymapley at catalyst.net.nz> ---
Created attachment 97753
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97753&action=edit
Bug 23064: Use Koha::Subscription in ModSubscription

We must use Koha::Subscription instead of raw SQL.
It will fix issue with default and integer values.

Test plan:
Edit a subscription and set number of issues = "f"
Save
=> Without this patch there is a SQL error in the log:
  Incorrect integer value: 'f' for column 'numberlength'
=> With this patch the other changes are effective.

Note: We also could change the type attribute of the input to "number",
to have a client-side check

Also, the return value of ModSuggestion is never used, so we are safe
with that.

Signed-off-by: Hayley Mapley <hayleymapley at catalyst.net.nz>
The <strict_sql_modes> flag must be present and set to 1 in the <config>
section of koha-conf.xml

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 22 22:26:38 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 22 Jan 2020 21:26:38 +0000
Subject: [Koha-bugs] [Bug 23064] Cannot edit subscription with strict SQL
 modes turned on
In-Reply-To: <bug-23064-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23064-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23064-70-bLBntEPV6u@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23064

Hayley Mapley <hayleymapley at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 22 23:03:02 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 22 Jan 2020 22:03:02 +0000
Subject: [Koha-bugs] [Bug 23064] Cannot edit subscription with strict SQL
 modes turned on
In-Reply-To: <bug-23064-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23064-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23064-70-0dOwnBLcww@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23064

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA
   Patch complexity|---                         |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 22 23:03:06 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 22 Jan 2020 22:03:06 +0000
Subject: [Koha-bugs] [Bug 23064] Cannot edit subscription with strict SQL
 modes turned on
In-Reply-To: <bug-23064-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23064-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23064-70-wZjdBfica9@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23064

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #97753|0                           |1
        is obsolete|                            |

--- Comment #11 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 97754
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97754&action=edit
Bug 23064: Use Koha::Subscription in ModSubscription

We must use Koha::Subscription instead of raw SQL.
It will fix issue with default and integer values.

Test plan:
Edit a subscription and set number of issues = "f"
Save
=> Without this patch there is a SQL error in the log:
  Incorrect integer value: 'f' for column 'numberlength'
=> With this patch the other changes are effective.

Note: We also could change the type attribute of the input to "number",
to have a client-side check

Also, the return value of ModSuggestion is never used, so we are safe
with that.

Signed-off-by: Hayley Mapley <hayleymapley at catalyst.net.nz>
The <strict_sql_modes> flag must be present and set to 1 in the <config>
section of koha-conf.xml

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 22 23:03:35 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 22 Jan 2020 22:03:35 +0000
Subject: [Koha-bugs] [Bug 23064] Cannot edit subscription with strict SQL
 modes turned on
In-Reply-To: <bug-23064-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23064-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23064-70-7ykoieazvV@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23064

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de

--- Comment #12 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Reads nice and works well!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 22 23:06:14 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 22 Jan 2020 22:06:14 +0000
Subject: [Koha-bugs] [Bug 24380] Backdated returns do not update fines
 unless CalculateFinesOnReturn is enabled
In-Reply-To: <bug-24380-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24380-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24380-70-yEvpR5bAe6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24380

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
          Component|Architecture, internals,    |Fines and fees
                   |and plumbing                |
                 CC|                            |katrin.fischer at bsz-bw.de

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 22 23:12:33 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 22 Jan 2020 22:12:33 +0000
Subject: [Koha-bugs] [Bug 24475] Reword FinesMode system preference
In-Reply-To: <bug-24475-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24475-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24475-70-J0ELSoR0B6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24475

--- Comment #1 from Andrew Fuerste-Henry <andrew at bywatersolutions.com> ---
Proposed wording:

(Don't Calculate / Calculate and Charge / Calculate but only for mailing to the
admin)
 fines (when misc/cronjobs/fines.pl is being run and/or CalculateFinesOnReturn
is enabled).
NOTE: If the misc/cronjobs/fines.pl cronjob is being run, accruing and final
fines will be calculated when the cron runs and accruing fines will be
finalized when an item is returned. If CalculateFinesOnReturn is enabled, final
fines will be calculated when an item is returned.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 22 23:12:34 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 22 Jan 2020 22:12:34 +0000
Subject: [Koha-bugs] [Bug 24025] Make CodeMirror content searchable
In-Reply-To: <bug-24025-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24025-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24025-70-pVhlqoIW7S@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24025

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA
   Patch complexity|---                         |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 22 23:12:38 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 22 Jan 2020 22:12:38 +0000
Subject: [Koha-bugs] [Bug 24025] Make CodeMirror content searchable
In-Reply-To: <bug-24025-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24025-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24025-70-cbAFHeKp7K@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24025

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #97748|0                           |1
        is obsolete|                            |

--- Comment #8 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 97755
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97755&action=edit
Bug 24025: Make CodeMirror content searchable

Signed-off-by: Barbara Johnson <barbara.johnson at bedfordtx.gov>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 22 23:14:21 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 22 Jan 2020 22:14:21 +0000
Subject: [Koha-bugs] [Bug 24475] Reword FinesMode system preference
In-Reply-To: <bug-24475-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24475-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24475-70-Ox9UMslC9U@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24475

--- Comment #2 from Andrew Fuerste-Henry <andrew at bywatersolutions.com> ---
Also, while we're at it, CalculateFinesOnReturn needs a note of:

NOTE: This system preference requires FinesMode to be set to "Calculate and
charge."

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 22 23:17:14 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 22 Jan 2020 22:17:14 +0000
Subject: [Koha-bugs] [Bug 24475] Reword FinesMode system preference
In-Reply-To: <bug-24475-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24475-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24475-70-KaZyeK0dcf@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24475

Andrew Fuerste-Henry <andrew at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=21633

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 22 23:17:14 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 22 Jan 2020 22:17:14 +0000
Subject: [Koha-bugs] [Bug 21633] Did finesMode = test ever send email?
In-Reply-To: <bug-21633-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21633-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21633-70-uV4DAZYesG@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21633

Andrew Fuerste-Henry <andrew at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=24475

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 22 23:18:43 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 22 Jan 2020 22:18:43 +0000
Subject: [Koha-bugs] [Bug 24475] Reword FinesMode system preference
In-Reply-To: <bug-24475-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24475-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24475-70-y6JPU2wLyr@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24475

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |21633
                 CC|                            |katrin.fischer at bsz-bw.de

--- Comment #3 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Hi Andrew, the third option doesn't work and is in process to be removed -
maybe we should make this one dependent: bug 21633


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21633
[Bug 21633] Did finesMode = test ever send email?
-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 22 23:18:43 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 22 Jan 2020 22:18:43 +0000
Subject: [Koha-bugs] [Bug 21633] Did finesMode = test ever send email?
In-Reply-To: <bug-21633-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21633-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21633-70-yJoHv5NnBi@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21633

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |24475


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24475
[Bug 24475] Reword FinesMode system preference
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 22 23:31:16 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 22 Jan 2020 22:31:16 +0000
Subject: [Koha-bugs] [Bug 12090] Disabling Library Location
In-Reply-To: <bug-12090-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-12090-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12090-70-bKklvuh1Sd@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12090

--- Comment #5 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
I guess you'd have to test that out - my understanding is that the holds queue
is rebuilt every run of the cron... if that assumption is correct, it should
move.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 22 23:33:18 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 22 Jan 2020 22:33:18 +0000
Subject: [Koha-bugs] [Bug 12090] Disabling Library Location
In-Reply-To: <bug-12090-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-12090-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12090-70-cFPYmrcfLt@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12090

--- Comment #6 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
(In reply to Katrin Fischer from comment #5)
> I guess you'd have to test that out - my understanding is that the holds
> queue is rebuilt every run of the cron... if that assumption is correct, it
> should move.

Yep, it starts fresh with every run:

 174 sub CreateQueue {
 175     my $dbh   = C4::Context->dbh;
 176 
 177     $dbh->do("DELETE FROM tmp_holdsqueue");  # clear the old table for new
info
 178     $dbh->do("DELETE FROM hold_fill_targets");

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 22 23:40:49 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 22 Jan 2020 22:40:49 +0000
Subject: [Koha-bugs] [Bug 24475] Reword FinesMode system preference
In-Reply-To: <bug-24475-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24475-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24475-70-yFDuinZNTt@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24475

--- Comment #4 from Andrew Fuerste-Henry <andrew at bywatersolutions.com> ---
I was just talking to Nick about that. I'll feel him out about an expected
timeline there. This isn't strictly dependent on his change and I'd like to see
this changed sooner rather than later. Have had a few libraries inadvertently
make themselves fine-free by misunderstanding this.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 22 23:45:15 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 22 Jan 2020 22:45:15 +0000
Subject: [Koha-bugs] [Bug 24481] Incorrect permission in
 admin/cash_registers.pl
In-Reply-To: <bug-24481-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24481-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24481-70-G7hilzw9mk@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24481

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #97741|0                           |1
        is obsolete|                            |

--- Comment #10 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 97756
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97756&action=edit
Bug 24481: Permissions update for POS menu include

This patch updates the point of sale menu include to reflect the updated
permissions name for cash registers

Note: Not required for 19.11

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 22 23:46:06 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 22 Jan 2020 22:46:06 +0000
Subject: [Koha-bugs] [Bug 24481] Incorrect permission in
 admin/cash_registers.pl
In-Reply-To: <bug-24481-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24481-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24481-70-QuSmayShYq@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24481

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #97738|0                           |1
        is obsolete|                            |

--- Comment #11 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 97757
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97757&action=edit
Bug 24481: Move manage_cash_registers to parameters permission

This patch moves the manage_cash_registers subpermission to the more
appropriate location under 'parameters'.

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 22 23:46:10 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 22 Jan 2020 22:46:10 +0000
Subject: [Koha-bugs] [Bug 24481] Incorrect permission in
 admin/cash_registers.pl
In-Reply-To: <bug-24481-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24481-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24481-70-hKSby47wnr@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24481

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #97739|0                           |1
        is obsolete|                            |

--- Comment #12 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 97758
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97758&action=edit
Bug 24481: Correct permission name in admin/cash_registers.pl

The permission name for changed during the implimentation of bug 23321
but one case was missed. This patch corrects that mistake.

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 22 23:46:13 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 22 Jan 2020 22:46:13 +0000
Subject: [Koha-bugs] [Bug 24481] Incorrect permission in
 admin/cash_registers.pl
In-Reply-To: <bug-24481-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24481-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24481-70-Nve8qroIXT@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24481

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #97740|0                           |1
        is obsolete|                            |

--- Comment #13 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 97759
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97759&action=edit
Bug 24481: Permission corrections for admin menu templates

This patch updates the admin menu include and admin home page to reflect
the updated permissions name for cash registers

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 22 23:46:16 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 22 Jan 2020 22:46:16 +0000
Subject: [Koha-bugs] [Bug 24481] Incorrect permission in
 admin/cash_registers.pl
In-Reply-To: <bug-24481-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24481-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24481-70-JjRmwszLlo@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24481

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #97756|0                           |1
        is obsolete|                            |

--- Comment #14 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 97760
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97760&action=edit
Bug 24481: Permissions update for POS menu include

This patch updates the point of sale menu include to reflect the updated
permissions name for cash registers

Note: Not required for 19.11

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 22 23:47:10 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 22 Jan 2020 22:47:10 +0000
Subject: [Koha-bugs] [Bug 17179] Advanced editor: Add keyboard shortcuts to
 repeat (duplicate) a field, and cut text
In-Reply-To: <bug-17179-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17179-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17179-70-rhmOERTojn@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17179

Hayley Mapley <hayleymapley at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |hayleymapley at catalyst.net.n
                   |                            |z

--- Comment #28 from Hayley Mapley <hayleymapley at catalyst.net.nz> ---
I feel that this feature has caused some usability issues.

I find it odd that Ctrl-C has been remapped to copy the whole field to the
clipboard. I like the feature, but the default should be a different key
combination.

I encountered this because I was trying to copy an ISBN as part of testing for
bug 21665 and noticed that after selecting the text nothing was happening when
I pressed Ctrl-C, no copying to the new clipboard, no copying to my computer's
clipboard, nothing.

It took me a while to figure out what was going on and how the new shortcut was
supposed to be used, and I imagine a lot of users will encounter similar
difficulties.

I am aware that the shortcut can be remapped, but I feel that using Ctrl-C as
the default is confusing and frustrating, especially when it functions the same
way in basically every other software program.

I propose that for new installations we change the mapping to be Ctrl-E or
something similar.

Thoughts?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 22 23:50:28 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 22 Jan 2020 22:50:28 +0000
Subject: [Koha-bugs] [Bug 18532] AUTO_RENEWALS should be a patron messaging
 preference
In-Reply-To: <bug-18532-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18532-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18532-70-V061EuaGG3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18532

--- Comment #23 from Catherine E. Ingram <catherine.ingram at cedarparktexas.gov> ---
Did anyone have a chance to look at this?  Did you have questions for me?

---------------------------------
Catherine E. Ingram, MLS
Assistant Library Director
Cedar Park Public Library
Office: 512-401-5640
Catherine.Ingram at cedarparktexas.gov
550 Discovery Boulevard
Cedar Park, TX  78613
www.cedarparktexas.gov/library

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 22 23:58:35 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 22 Jan 2020 22:58:35 +0000
Subject: [Koha-bugs] [Bug 21665] Advanced editor - Double clicking on value
 brings subfield code as well
In-Reply-To: <bug-21665-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21665-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21665-70-5MBvZbtUrr@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21665

Hayley Mapley <hayleymapley at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 22 23:58:37 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 22 Jan 2020 22:58:37 +0000
Subject: [Koha-bugs] [Bug 21665] Advanced editor - Double clicking on value
 brings subfield code as well
In-Reply-To: <bug-21665-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21665-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21665-70-v1qlmlNzEo@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21665

Hayley Mapley <hayleymapley at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #96465|0                           |1
        is obsolete|                            |

--- Comment #6 from Hayley Mapley <hayleymapley at catalyst.net.nz> ---
Created attachment 97761
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97761&action=edit
Bug 21665: Advanced editor - double clicking on value brings subfield code as
well

To test, apply patch:
0/Verify that the advanced editor is enabled by going to
"Administration" and searching for "EnableAdvancedCatalogingEditor"
1/Set it to "Enable" if it isn't already.
2/Go to "Cataloging", click on "Advanced editor"
3/Search for a record by entering "specious" in the keyword box and
hitting enter
4/Click "import" on a record
5/For any subfield (maybe specifically the text in an 020 field) double
click on the text
6/Hit CNTRL-V into your favorite text editor, verify that the subfield
code was not pasted with the text from the subfield.

Signed-off-by: Hayley Mapley <hayleymapley at catalyst.net.nz>
On master Ctrl-C has been remapped to copy the current field to the
Advanced editor clipboard (Bug 17179). Remap this from Ctrl-C to Ctrl-E,
then you can use Ctrl-C to copy the double clicked field.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 23 00:02:35 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 22 Jan 2020 23:02:35 +0000
Subject: [Koha-bugs] [Bug 24478] Make it possible to deactivate point of sale
In-Reply-To: <bug-24478-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24478-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24478-70-xtIMI52dNI@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24478

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA
   Patch complexity|---                         |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 23 00:02:38 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 22 Jan 2020 23:02:38 +0000
Subject: [Koha-bugs] [Bug 24478] Make it possible to deactivate point of sale
In-Reply-To: <bug-24478-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24478-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24478-70-eKdEaOUch9@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24478

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #97702|0                           |1
        is obsolete|                            |

--- Comment #5 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 97762
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97762&action=edit
Bug 24478: Add `EnablePointOfSale` system preference

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 23 00:02:41 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 22 Jan 2020 23:02:41 +0000
Subject: [Koha-bugs] [Bug 24478] Make it possible to deactivate point of sale
In-Reply-To: <bug-24478-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24478-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24478-70-ksBPpVR7Lj@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24478

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #97732|0                           |1
        is obsolete|                            |

--- Comment #6 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 97763
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97763&action=edit
Bug 24478: Use `EnablePointOfSale` preference

This patch adds the `EnablePointOfSale` preference to the accounting tab
on the preferences editor and ties the display of the Point of Sale
module to it.

Test plan:
1) Enable both `UseCashRegisters` and `EnablePointOfSale` preferences.
2) Ensure you are a superuser or your user has the
   takepayment permission.
3) The Point of Sale module should be present on your staff home page
   with the above configuration, otherwhise it should not.

Signed-off-by: Andrew Fuerste-Henry <andrew at bywatersolutions.com>

https://bugs.koha-community.org/show_bug.cgi?id=24477

Signed-off-by: Andrew Fuerste-Henry <andrew at bywatersolutions.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 23 00:02:44 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 22 Jan 2020 23:02:44 +0000
Subject: [Koha-bugs] [Bug 24478] Make it possible to deactivate point of sale
In-Reply-To: <bug-24478-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24478-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24478-70-Is4Goxo2UD@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24478

--- Comment #7 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 97764
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97764&action=edit
Bug 24478: Fix sequence in syyprefs.sql and add missing comma

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 23 00:04:54 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 22 Jan 2020 23:04:54 +0000
Subject: [Koha-bugs] [Bug 24478] Make it possible to deactivate point of sale
In-Reply-To: <bug-24478-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24478-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24478-70-FeUzqhlCoC@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24478

--- Comment #8 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Thx Martin!

2 notes:

- The QA tools don't catch if the , is missing at the end of a line in
sysprefs.sql. I think it would be nice if we could add a check for that.

- The pref will only control the visibility of the icon on the start page, but
not access to the page. It might be nice to add a message there with a link to
activate the feature. But I am not seeing this as a blocker, as what we do
there is inconsistent:

ILL: turn pref off = 404
Course reserves: turn pref off = nothing happens (allows to prepare for use,
maybe)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 23 00:47:30 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 22 Jan 2020 23:47:30 +0000
Subject: [Koha-bugs] [Bug 21665] Advanced editor - Double clicking on value
 brings subfield code as well
In-Reply-To: <bug-21665-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21665-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21665-70-ImFqflGjIA@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21665

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de
             Status|Signed Off                  |Failed QA

--- Comment #7 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Hi Cori,

this works for me only using keyboard shortcuts:

- double click subfield text
- ctrl + c (remap Copy field action in the editor before, so you get normal
behaviour)
- ctrl + v = only text was copied

But it doesn't work if I avoid the shortcuts:

- double click subfield text
- right click - context menu - copy
- ctrl + v or ctrl + p = subfield code was copied

Could you please check/fix/comment?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 23 00:49:32 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 22 Jan 2020 23:49:32 +0000
Subject: [Koha-bugs] [Bug 24481] Incorrect permission in
 admin/cash_registers.pl
In-Reply-To: <bug-24481-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24481-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24481-70-5Q7RGnsMQF@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24481

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 23 01:26:51 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Jan 2020 00:26:51 +0000
Subject: [Koha-bugs] [Bug 3777] Field Sizes Inconsistent
In-Reply-To: <bug-3777-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-3777-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-3777-70-WcNk3qiipz@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3777

danield at brimbank.vic.gov.au changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |danield at brimbank.vic.gov.au

--- Comment #14 from danield at brimbank.vic.gov.au ---
I've also noticed these inconsistencies and I think this would be something
good to fix. It seems to still exist in the 19.11 schema.

Another thing I'd like to see changed is to expand the street number field. It
is currently limited to 10 characters. This is a problem as we have seen some
long numbered addresses as of late, for example 'Unit 12/6 130-136'.

If this is scope creep, I apologise, and I'm happy to open a different bug
report depending on what is decided here.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 23 03:44:56 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Jan 2020 02:44:56 +0000
Subject: [Koha-bugs] [Bug 24476] Allow patrons to opt-out of Auto-renewal
In-Reply-To: <bug-24476-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24476-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24476-70-qBWZ5PvyeR@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24476

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff
   Patch complexity|---                         |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 23 03:44:59 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Jan 2020 02:44:59 +0000
Subject: [Koha-bugs] [Bug 24476] Allow patrons to opt-out of Auto-renewal
In-Reply-To: <bug-24476-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24476-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24476-70-yG67aSoQPn@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24476

--- Comment #1 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 97766
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97766&action=edit
Bug 24476: Database updates

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 23 03:45:03 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Jan 2020 02:45:03 +0000
Subject: [Koha-bugs] [Bug 24476] Allow patrons to opt-out of Auto-renewal
In-Reply-To: <bug-24476-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24476-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24476-70-hDKDpP333h@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24476

--- Comment #2 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 97767
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97767&action=edit
Bug 24476: API Updates

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 23 03:45:06 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Jan 2020 02:45:06 +0000
Subject: [Koha-bugs] [Bug 24476] Allow patrons to opt-out of Auto-renewal
In-Reply-To: <bug-24476-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24476-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24476-70-Y0x6RxWzum@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24476

--- Comment #3 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 97768
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97768&action=edit
Bug 24476: Change CanBookBeRenewed and adjust tests

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 23 03:45:09 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Jan 2020 02:45:09 +0000
Subject: [Koha-bugs] [Bug 24476] Allow patrons to opt-out of Auto-renewal
In-Reply-To: <bug-24476-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24476-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24476-70-D9IqdPUXrk@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24476

--- Comment #4 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 97769
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97769&action=edit
Bug 24476: DO NOT PUSH - Schema updates

is_boolean line must be copied however

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 23 03:45:12 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Jan 2020 02:45:12 +0000
Subject: [Koha-bugs] [Bug 24476] Allow patrons to opt-out of Auto-renewal
In-Reply-To: <bug-24476-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24476-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24476-70-OFUXERaaPM@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24476

--- Comment #5 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 97770
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97770&action=edit
Bug 24476: Allow patrons to opt out of auto-renewal

To test:
1 - Verify on staff side that patron can be edited to opt in our out of auto
renewal
2 - Check out some items to a patron opted in to auto renewal
3 - Ensure the items are checked out and set to autorenew
4 - Login on the opac at the patron
5 - Verify items cannot be renewed as scheduled for auto-renewal
6 - On staff side, opt patron out of auto renewal
7 - Verify on opac items are no longer marked for auto renewal
8 - Run the auto renewal cron job, items are not renewed
9 - Set 'no renewal before' to a setting that would prevent renewal
10 - Verify that opting patron in or out of auto renewal changes only the
reason items cannot be renewed
11 - Set 'no renewal before' to a setting that would allow for renewal
12 - Verify that opting patron in/out changes their ability to renew
13 - Verify that when opted out cron does not renew
14 - Verify that when opted in the item is auto renewed
15 - Reset the due date, opt out, verify manual renewal succeeds

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 23 03:49:03 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Jan 2020 02:49:03 +0000
Subject: [Koha-bugs] [Bug 24476] Allow patrons to opt-out of Auto-renewal
In-Reply-To: <bug-24476-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24476-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24476-70-INVQ0wwsDJ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24476

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |andrew at bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 23 04:37:48 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Jan 2020 03:37:48 +0000
Subject: [Koha-bugs] [Bug 22860] Selenium tests authentication.t does not
 remove all data it created
In-Reply-To: <bug-22860-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22860-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22860-70-h2Xx1moWbA@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22860

Hayley Mapley <hayleymapley at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 23 04:37:52 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Jan 2020 03:37:52 +0000
Subject: [Koha-bugs] [Bug 22860] Selenium tests authentication.t does not
 remove all data it created
In-Reply-To: <bug-22860-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22860-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22860-70-htqdIeJ4Oz@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22860

Hayley Mapley <hayleymapley at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #89400|0                           |1
        is obsolete|                            |

--- Comment #4 from Hayley Mapley <hayleymapley at catalyst.net.nz> ---
Created attachment 97771
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97771&action=edit
Bug 22860: Remove 1 remaining patron after authentication.t is ran

Test plan:
0/ Do not apply the patch
1/ select count(*) from borrowers;
2/ Run the tests
=> Notice that you have 1 more patron
3/ Apply the patch and repeat 1/ and 2/
=> Notice that you have the same number of patrons before and after the
tests

Signed-off-by: Hayley Mapley <hayleymapley at catalyst.net.nz>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 23 04:58:29 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Jan 2020 03:58:29 +0000
Subject: [Koha-bugs] [Bug 24488] New: Holds to Pull sometimes shows the
 wrong 'first patron' details
Message-ID: <bug-24488-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24488

            Bug ID: 24488
           Summary: Holds to Pull sometimes shows the wrong 'first patron'
                    details
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Circulation
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: aleisha at catalyst.net.nz
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com

The query that pulls the information for the Circ -> Holds to pull table is
incredibly complex and doesn't always pull the correct information. It has a
bunch of commands in it that repeatedly reorders the results (group_concats and
counts). This means the order of the results cannot be guaranteed to be the
same with every execution, and sometimes we see the wrong 'first patron' for
the given date selection.

It's hard to test because it only happens sometimes, but I have been able to
reproduce it this way:
- Place two holds for two different patrons on the same biblio
- Check the Holds to pull, it'll show the details of the first patron
- Change the reservedate for the second hold in the database to be yesterday
- Check the Holds to pull, it shows the details of the wrong hold under 'first
patron' but shows the correct details 'under earliest hold date' 
- Change the date selection, it doesn't fix itself

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 23 04:58:39 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Jan 2020 03:58:39 +0000
Subject: [Koha-bugs] [Bug 24488] Holds to Pull sometimes shows the wrong
 'first patron' details
In-Reply-To: <bug-24488-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24488-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24488-70-b3XYi3HUWc@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24488

Aleisha Amohia <aleisha at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Change sponsored?|---                         |Sponsored
           Assignee|koha-bugs at lists.koha-commun |aleisha at catalyst.net.nz
                   |ity.org                     |

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 23 05:02:58 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Jan 2020 04:02:58 +0000
Subject: [Koha-bugs] [Bug 24488] Holds to Pull sometimes shows the wrong
 'first patron' details
In-Reply-To: <bug-24488-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24488-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24488-70-MajA9239ht@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24488

Aleisha Amohia <aleisha at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 23 05:03:01 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Jan 2020 04:03:01 +0000
Subject: [Koha-bugs] [Bug 24488] Holds to Pull sometimes shows the wrong
 'first patron' details
In-Reply-To: <bug-24488-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24488-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24488-70-sje96JhYJa@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24488

--- Comment #1 from Aleisha Amohia <aleisha at catalyst.net.nz> ---
Created attachment 97773
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97773&action=edit
Bug 24488: Show correct first patron details on Holds to pull

This patch rewrites the complex search query to reduce the risk of
reordering the results multiple times.

This patch includes a change to schema files so may need to upgrade
schema and/or restart memcached

To test:
1) Reproduce problem following test plan in Description
2) Apply patch and refresh page
3) Notice the correct patron is now shown
4) Play with date selection, confirm correct results are still shown
5) Test cancelling holds
6) Test filtering table results

Sponsored by: IHC New Zealand

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 23 06:51:33 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Jan 2020 05:51:33 +0000
Subject: [Koha-bugs] [Bug 24149] Add new Koha::Statistic[s] classes
In-Reply-To: <bug-24149-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24149-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24149-70-juCA5Q1SE3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24149

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 23 06:51:47 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Jan 2020 05:51:47 +0000
Subject: [Koha-bugs] [Bug 24149] Add new Koha::Statistic[s] classes
In-Reply-To: <bug-24149-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24149-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24149-70-b7JVfdOL93@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24149

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #95956|0                           |1
        is obsolete|                            |
  Attachment #95957|0                           |1
        is obsolete|                            |
  Attachment #97239|0                           |1
        is obsolete|                            |

--- Comment #6 from Josef Moravec <josef.moravec at gmail.com> ---
Created attachment 97776
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97776&action=edit
Bug 24149: Add Koha::Statistic[s] classes

Sponsored-by: Association KohaLa - https://koha-fr.org/

Signed-off-by: Josef Moravec <josef.moravec at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 23 06:51:52 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Jan 2020 05:51:52 +0000
Subject: [Koha-bugs] [Bug 24149] Add new Koha::Statistic[s] classes
In-Reply-To: <bug-24149-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24149-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24149-70-Kuy0x0aftu@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24149

--- Comment #7 from Josef Moravec <josef.moravec at gmail.com> ---
Created attachment 97777
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97777&action=edit
Bug 24149: Add Koha::Statistic->item

Sponsored-by: Association KohaLa - https://koha-fr.org/

Signed-off-by: Josef Moravec <josef.moravec at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 23 06:51:59 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Jan 2020 05:51:59 +0000
Subject: [Koha-bugs] [Bug 24149] Add new Koha::Statistic[s] classes
In-Reply-To: <bug-24149-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24149-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24149-70-irVoJ2tlrB@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24149

--- Comment #8 from Josef Moravec <josef.moravec at gmail.com> ---
Created attachment 97778
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97778&action=edit
Bug 24149: Add tests

Signed-off-by: Josef Moravec <josef.moravec at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 23 06:52:04 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Jan 2020 05:52:04 +0000
Subject: [Koha-bugs] [Bug 24149] Add new Koha::Statistic[s] classes
In-Reply-To: <bug-24149-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24149-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24149-70-vdrTgveJZa@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24149

--- Comment #9 from Josef Moravec <josef.moravec at gmail.com> ---
Created attachment 97779
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97779&action=edit
Bug 24149: (QA follow-up) Add pod for Koha::Statistics->object_class

Signed-off-by: Josef Moravec <josef.moravec at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 23 06:52:16 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Jan 2020 05:52:16 +0000
Subject: [Koha-bugs] [Bug 24149] Add new Koha::Statistic[s] classes
In-Reply-To: <bug-24149-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24149-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24149-70-VPgnmGdpIH@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24149

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |josef.moravec at gmail.com
         QA Contact|testopia at bugs.koha-communit |josef.moravec at gmail.com
                   |y.org                       |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 23 07:51:09 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Jan 2020 06:51:09 +0000
Subject: [Koha-bugs] [Bug 3777] Field Sizes Inconsistent
In-Reply-To: <bug-3777-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-3777-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-3777-70-J0s23J51fJ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3777

--- Comment #15 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
(In reply to danield from comment #14)
> I've also noticed these inconsistencies and I think this would be something
> good to fix. It seems to still exist in the 19.11 schema.
> 
> Another thing I'd like to see changed is to expand the street number field.
> It is currently limited to 10 characters. This is a problem as we have seen
> some long numbered addresses as of late, for example 'Unit 12/6 130-136'.
> 
> If this is scope creep, I apologise, and I'm happy to open a different bug
> report depending on what is decided here.

This a bigger project, if you have a certain requirement, it might be easier to
open it in a new dependent bug report for now - it might be more likely for
someone to pick it up.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 23 08:22:48 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Jan 2020 07:22:48 +0000
Subject: [Koha-bugs] [Bug 23594] Batch modification for itemtypes on
 suggestions page
In-Reply-To: <bug-23594-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23594-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23594-70-TbJkqe8liX@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23594

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |oleonard at myacpl.org
             Status|Signed Off                  |Failed QA

--- Comment #17 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Hi Jonathan,

the patch breaks the new datatables functionality in suggestions. :(

I also really believe that we have too many different forms on this page - I
think we need to at least not add another submit button and should combine the
batch editing options into one form (status, reason + new: itemtype). The 3
parts at the bottom.

Another note: I believe it would be really helpful to see the itemtype in the
table when you can bulk change it. At the moment, you can only see it by
viewing the suggestions which means you are 'blindly' bulk editing.

Adding Owen for design advice.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 23 08:27:53 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Jan 2020 07:27:53 +0000
Subject: [Koha-bugs] [Bug 24477] No permissions check for POS feature
In-Reply-To: <bug-24477-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24477-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24477-70-lsHztYyHI5@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24477

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Small patch
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 23 08:27:56 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Jan 2020 07:27:56 +0000
Subject: [Koha-bugs] [Bug 24477] No permissions check for POS feature
In-Reply-To: <bug-24477-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24477-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24477-70-5mEiiqcVpN@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24477

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #97730|0                           |1
        is obsolete|                            |

--- Comment #8 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 97780
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97780&action=edit
Bug 24477: Require `takepayment` permission in pos/pay.pl

When adding the point of sale take payment page in bug 23354 we missed
the permission check script side along with adding the permission at
install time (update was caught).

Signed-off-by: Andrew Fuerste-Henry <andrew at bywatersolutions.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 23 08:29:34 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Jan 2020 07:29:34 +0000
Subject: [Koha-bugs] [Bug 24477] No permissions check for POS feature
In-Reply-To: <bug-24477-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24477-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24477-70-WNXUPWG4mH@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24477

--- Comment #9 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Totally unrelated... but as I am running out of time: Would you be opposed to
rename Purchase items to the "Debit types". I think "Purchase items" is quite
confusing for translation (probably going to get mixed up with suggestions) and
it seems strange to have 2 different names for the same thing. If you just go
to admin, you won't find anything named this there.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 23 09:53:38 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Jan 2020 08:53:38 +0000
Subject: [Koha-bugs] [Bug 24432] order_by broken for date columns
In-Reply-To: <bug-24432-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24432-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24432-70-BnwuAQFIT8@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24432

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to master
         Version(s)|                            |20.05.00
        released in|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 23 09:53:40 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Jan 2020 08:53:40 +0000
Subject: [Koha-bugs] [Bug 24432] order_by broken for date columns
In-Reply-To: <bug-24432-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24432-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24432-70-7jZRfrTrRn@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24432

--- Comment #12 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Nice work everyone!

Pushed to master for 20.05

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 23 09:53:42 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Jan 2020 08:53:42 +0000
Subject: [Koha-bugs] [Bug 24477] No permissions check for POS feature
In-Reply-To: <bug-24477-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24477-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24477-70-6BtstDpcUB@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24477

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|                            |20.05.00
        released in|                            |
             Status|Passed QA                   |Pushed to master

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 23 09:53:43 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Jan 2020 08:53:43 +0000
Subject: [Koha-bugs] [Bug 24477] No permissions check for POS feature
In-Reply-To: <bug-24477-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24477-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24477-70-qUTjnXgfIs@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24477

--- Comment #10 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Nice work everyone!

Pushed to master for 20.05

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 23 09:53:45 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Jan 2020 08:53:45 +0000
Subject: [Koha-bugs] [Bug 24481] Incorrect permission in
 admin/cash_registers.pl
In-Reply-To: <bug-24481-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24481-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24481-70-22lw4eYaLd@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24481

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|                            |20.05.00
        released in|                            |
             Status|Passed QA                   |Pushed to master

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 23 09:53:47 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Jan 2020 08:53:47 +0000
Subject: [Koha-bugs] [Bug 24481] Incorrect permission in
 admin/cash_registers.pl
In-Reply-To: <bug-24481-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24481-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24481-70-u2L27vWVZZ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24481

--- Comment #15 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Nice work everyone!

Pushed to master for 20.05

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 23 10:03:04 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Jan 2020 09:03:04 +0000
Subject: [Koha-bugs] [Bug 23594] Batch modification for itemtypes on
 suggestions page
In-Reply-To: <bug-23594-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23594-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23594-70-5oEthCNYXj@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23594

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 23 10:03:08 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Jan 2020 09:03:08 +0000
Subject: [Koha-bugs] [Bug 23594] Batch modification for itemtypes on
 suggestions page
In-Reply-To: <bug-23594-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23594-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23594-70-GRbgg3AaUx@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23594

--- Comment #18 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 97781
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97781&action=edit
Bug 23594: Fix bad resolution conflict with bug 16784

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 23 10:04:03 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Jan 2020 09:04:03 +0000
Subject: [Koha-bugs] [Bug 23594] Batch modification for itemtypes on
 suggestions page
In-Reply-To: <bug-23594-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23594-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23594-70-gJunrIDZP1@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23594

--- Comment #19 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
(In reply to Katrin Fischer from comment #17)
> Hi Jonathan,
> 
> the patch breaks the new datatables functionality in suggestions. :(

Fixed with last patch.

> I also really believe that we have too many different forms on this page - I
> think we need to at least not add another submit button and should combine
> the batch editing options into one form (status, reason + new: itemtype).
> The 3 parts at the bottom.

I already contacted Owen before starting this dev. I advised me the current
view.

> Another note: I believe it would be really helpful to see the itemtype in
> the table when you can bulk change it. At the moment, you can only see it by
> viewing the suggestions which means you are 'blindly' bulk editing.

The itemtype is displayed already (inside the column 'Suggestion')

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 23 10:10:42 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Jan 2020 09:10:42 +0000
Subject: [Koha-bugs] [Bug 23064] Cannot edit subscription with strict SQL
 modes turned on
In-Reply-To: <bug-23064-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23064-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23064-70-wO1xNymOXZ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23064

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|                            |20.05.00
        released in|                            |
             Status|Passed QA                   |Pushed to master

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 23 10:10:43 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Jan 2020 09:10:43 +0000
Subject: [Koha-bugs] [Bug 23064] Cannot edit subscription with strict SQL
 modes turned on
In-Reply-To: <bug-23064-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23064-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23064-70-mcNzVyFBI3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23064

--- Comment #13 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Nice work everyone!

Pushed to master for 20.05

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 23 10:10:45 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Jan 2020 09:10:45 +0000
Subject: [Koha-bugs] [Bug 24236] Using quotes in a cataloging search,
 resulting in multiple pages, will not allow you to advance page
In-Reply-To: <bug-24236-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24236-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24236-70-Og4Ok97yrp@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24236

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to master
         Version(s)|                            |20.05.00
        released in|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 23 10:10:47 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Jan 2020 09:10:47 +0000
Subject: [Koha-bugs] [Bug 24236] Using quotes in a cataloging search,
 resulting in multiple pages, will not allow you to advance page
In-Reply-To: <bug-24236-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24236-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24236-70-PxYtk3TrCX@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24236

--- Comment #8 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Nice work everyone!

Pushed to master for 20.05

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 23 10:10:49 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Jan 2020 09:10:49 +0000
Subject: [Koha-bugs] [Bug 24286] FindDuplicateAuthority does not escape
 forward slash in 'GENRE/FORM'
In-Reply-To: <bug-24286-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24286-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24286-70-zKlUMTLUQM@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24286

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|                            |20.05.00
        released in|                            |
             Status|Passed QA                   |Pushed to master

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 23 10:10:51 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Jan 2020 09:10:51 +0000
Subject: [Koha-bugs] [Bug 24286] FindDuplicateAuthority does not escape
 forward slash in 'GENRE/FORM'
In-Reply-To: <bug-24286-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24286-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24286-70-Wu5jhErc74@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24286

--- Comment #8 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Nice work everyone!

Pushed to master for 20.05

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 23 10:10:53 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Jan 2020 09:10:53 +0000
Subject: [Koha-bugs] [Bug 24345] Fix process of suggesting purchase of
 existing title for non-logged-in users
In-Reply-To: <bug-24345-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24345-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24345-70-2kQUFGAPwt@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24345

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to master
         Version(s)|                            |20.05.00
        released in|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 23 10:10:55 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Jan 2020 09:10:55 +0000
Subject: [Koha-bugs] [Bug 24345] Fix process of suggesting purchase of
 existing title for non-logged-in users
In-Reply-To: <bug-24345-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24345-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24345-70-C338nFqYVB@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24345

--- Comment #8 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Nice work everyone!

Pushed to master for 20.05

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 23 10:10:56 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Jan 2020 09:10:56 +0000
Subject: [Koha-bugs] [Bug 24397] populate_db.pl is out of sync and must be
 removed
In-Reply-To: <bug-24397-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24397-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24397-70-JAuXI3XUlt@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24397

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|                            |20.05.00
        released in|                            |
             Status|Passed QA                   |Pushed to master

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 23 10:10:58 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Jan 2020 09:10:58 +0000
Subject: [Koha-bugs] [Bug 24397] populate_db.pl is out of sync and must be
 removed
In-Reply-To: <bug-24397-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24397-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24397-70-5Lf9RRFLXf@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24397

--- Comment #9 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Nice work everyone!

Pushed to master for 20.05

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 23 10:11:00 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Jan 2020 09:11:00 +0000
Subject: [Koha-bugs] [Bug 24441] Error when checking in an item with
 BranchTansferLimitsType set to itemtype
In-Reply-To: <bug-24441-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24441-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24441-70-uPwaaKgRMX@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24441

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to master
         Version(s)|                            |20.05.00
        released in|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 23 10:11:02 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Jan 2020 09:11:02 +0000
Subject: [Koha-bugs] [Bug 24441] Error when checking in an item with
 BranchTansferLimitsType set to itemtype
In-Reply-To: <bug-24441-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24441-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24441-70-fzVeGbtOTu@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24441

--- Comment #5 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Nice work everyone!

Pushed to master for 20.05

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 23 10:11:03 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Jan 2020 09:11:03 +0000
Subject: [Koha-bugs] [Bug 24457] K::A::Basket->to_api is not passing the
 parameters to the parent class implementation
In-Reply-To: <bug-24457-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24457-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24457-70-q7ZyQsGepA@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24457

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to master
         Version(s)|                            |20.05.00
        released in|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 23 10:11:05 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Jan 2020 09:11:05 +0000
Subject: [Koha-bugs] [Bug 24457] K::A::Basket->to_api is not passing the
 parameters to the parent class implementation
In-Reply-To: <bug-24457-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24457-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24457-70-EHYWGDXY11@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24457

--- Comment #9 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Nice work everyone!

Pushed to master for 20.05

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 23 10:11:07 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Jan 2020 09:11:07 +0000
Subject: [Koha-bugs] [Bug 24459] Overloaded ->to_api needs to pass $params
 through
In-Reply-To: <bug-24459-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24459-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24459-70-dtPH60hmV8@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24459

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to master
         Version(s)|                            |20.05.00
        released in|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 23 10:11:09 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Jan 2020 09:11:09 +0000
Subject: [Koha-bugs] [Bug 24459] Overloaded ->to_api needs to pass $params
 through
In-Reply-To: <bug-24459-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24459-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24459-70-5zLdmx1NY4@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24459

--- Comment #7 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Nice work everyone!

Pushed to master for 20.05

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 23 10:11:17 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Jan 2020 09:11:17 +0000
Subject: [Koha-bugs] [Bug 23594] Batch modification for itemtypes on
 suggestions page
In-Reply-To: <bug-23594-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23594-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23594-70-NmXdpsGA0z@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23594

--- Comment #20 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
I think I thought it deserved its own colum (maybe to be fixed separately :) )

Could it have been a misunderstanding? It seems really odd to not be able to
update itemtypes and status in one go?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 23 10:35:02 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Jan 2020 09:35:02 +0000
Subject: [Koha-bugs] [Bug 23594] Batch modification for itemtypes on
 suggestions page
In-Reply-To: <bug-23594-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23594-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23594-70-L70zT1Ngr4@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23594

--- Comment #21 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
(In reply to Katrin Fischer from comment #20)
> I think I thought it deserved its own colum (maybe to be fixed separately :)
> )
> 
> Could it have been a misunderstanding? It seems really odd to not be able to
> update itemtypes and status in one go?

The problem is the ugliness of both script and template. Which makes the whole
thing super hard to modify.
I am planning to clean that (suggestion related code) soon.
That should help to improve UI of this module.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 23 10:42:28 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Jan 2020 09:42:28 +0000
Subject: [Koha-bugs] [Bug 24477] No permissions check for POS feature
In-Reply-To: <bug-24477-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24477-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24477-70-2yNwaHVYMl@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24477

--- Comment #11 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
(In reply to Katrin Fischer from comment #9)
> Totally unrelated... but as I am running out of time: Would you be opposed
> to rename Purchase items to the "Debit types". I think "Purchase items" is
> quite confusing for translation (probably going to get mixed up with
> suggestions) and it seems strange to have 2 different names for the same
> thing. If you just go to admin, you won't find anything named this there.

Hmm, feel free to open that as a new bug else I'll completely forget about it..

I can see where you're coming from though I'm not entirely sure about the
change.  What I'd rather do is try to match the term to the flag that sets
whether a debit type can be sold via the POS system vs the patron accounts
pages... 'Item can be sold' I think it is.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 23 10:51:43 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Jan 2020 09:51:43 +0000
Subject: [Koha-bugs] [Bug 24467] *_count methods should be avoided
In-Reply-To: <bug-24467-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24467-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24467-70-TCRkMQ4wyU@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24467

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |24440


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24440
[Bug 24440] Add ->holds and ->holds_count to Koha::Acquisition::Order
-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 23 10:51:43 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Jan 2020 09:51:43 +0000
Subject: [Koha-bugs] [Bug 24440] Add ->holds and ->holds_count to
 Koha::Acquisition::Order
In-Reply-To: <bug-24440-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24440-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24440-70-NRFEGQMJu4@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24440

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |24467


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24467
[Bug 24467] *_count methods should be avoided
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 23 10:52:43 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Jan 2020 09:52:43 +0000
Subject: [Koha-bugs] [Bug 24477] No permissions check for POS feature
In-Reply-To: <bug-24477-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24477-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24477-70-slEwb3SXKw@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24477

--- Comment #12 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
(In reply to Martin Renvoize from comment #11)
> (In reply to Katrin Fischer from comment #9)
> > Totally unrelated... but as I am running out of time: Would you be opposed
> > to rename Purchase items to the "Debit types". I think "Purchase items" is
> > quite confusing for translation (probably going to get mixed up with
> > suggestions) and it seems strange to have 2 different names for the same
> > thing. If you just go to admin, you won't find anything named this there.
> 
> Hmm, feel free to open that as a new bug else I'll completely forget about
> it..
> 
> I can see where you're coming from though I'm not entirely sure about the
> change.  What I'd rather do is try to match the term to the flag that sets
> whether a debit type can be sold via the POS system vs the patron accounts
> pages... 'Item can be sold' I think it is.

No problem with opening a new bug - set this mostly as a reminder to myself.
But not sure I can follow your line of thought there?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 23 10:56:48 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Jan 2020 09:56:48 +0000
Subject: [Koha-bugs] [Bug 23493] jquery.dataTables.rowGrouping.js is no
 longer maintained,
 but there is an official DataTables version we could switch to
In-Reply-To: <bug-23493-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23493-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23493-70-BoY9IhoPuP@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23493

--- Comment #15 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
 609             "fnInitComplete": function(oSettings, json) {
 610                 // Disable rowGroup plugin after first use
 611                 // so any sorting on the table doesn't use it
 612                 //var oSettings = issuesTable.fnSettings();

Should we remove those 3 commented lines?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 23 11:03:04 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Jan 2020 10:03:04 +0000
Subject: [Koha-bugs] [Bug 23493] jquery.dataTables.rowGrouping.js is no
 longer maintained,
 but there is an official DataTables version we could switch to
In-Reply-To: <bug-23493-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23493-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23493-70-lQCqUJcrSV@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23493

--- Comment #16 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
One change I noticed: when the column are sorted the "grouped tr" are displayed
with this new version:
https://snipboard.io/HzXJ4l.jpg (before)
https://snipboard.io/zRb4sk.jpg (after)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 23 11:21:59 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Jan 2020 10:21:59 +0000
Subject: [Koha-bugs] [Bug 23681] Patron restrictions should be user definable
In-Reply-To: <bug-23681-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23681-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23681-70-GnCSGalJSm@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org

--- Comment #54 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
(In reply to Andrew Isherwood from comment #1)
> It has become increasingly apparent that using authorised values for this is
> not the most appropriate way forward. The number of modifications and
> additions to AV was increasing the scope of the work too much, it was clear
> that AV was not the correct place for this.

Why? Can you explain?
That was my first reaction reading the patches.
Using AV will make the feature translatable in the future (bug 20307).

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 23 11:24:06 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Jan 2020 10:24:06 +0000
Subject: [Koha-bugs] [Bug 22831] Elasticsearch - add a maintenance script
 for checking DB vs index counts
In-Reply-To: <bug-22831-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22831-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22831-70-5SEsZ9UlpB@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22831

--- Comment #27 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 97783
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97783&action=edit
Bug 22831: (RM follow-up) Code golf

Rather than performing a symmetric diff and then splitting the results
in a further loop this patch changes to logic to use two asymetric diffs
to get the results more directly.

Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 23 11:25:51 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Jan 2020 10:25:51 +0000
Subject: [Koha-bugs] [Bug 22831] Elasticsearch - add a maintenance script
 for checking DB vs index counts
In-Reply-To: <bug-22831-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22831-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22831-70-FI4AiZXz4L@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22831

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |Manual,
                   |                            |release-notes-needed

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 23 11:26:37 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Jan 2020 10:26:37 +0000
Subject: [Koha-bugs] [Bug 24105] Longoverdue gives error message when
 --itemtypes are specified
In-Reply-To: <bug-24105-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24105-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24105-70-r1BltGnK1P@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24105

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|enhancement                 |normal
                 CC|                            |martin.renvoize at ptfs-europe
                   |                            |.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 23 11:27:15 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Jan 2020 10:27:15 +0000
Subject: [Koha-bugs] [Bug 19809] Koha::Objects::find calls do not need to be
 forbidden in list context
In-Reply-To: <bug-19809-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19809-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19809-70-3OlmOhAF4q@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19809

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|rel_20_05_target            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 23 11:28:19 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Jan 2020 10:28:19 +0000
Subject: [Koha-bugs] [Bug 23681] Patron restrictions should be user definable
In-Reply-To: <bug-23681-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23681-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23681-70-n6kkfG6vmz@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681

--- Comment #55 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
So you are adding a regression, the restrictions are no longer translatable.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 23 11:28:36 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Jan 2020 10:28:36 +0000
Subject: [Koha-bugs] [Bug 24484] Add explanatory text to batch patron
 deletion
In-Reply-To: <bug-24484-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24484-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24484-70-s1XOIR3ayI@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24484

David Roberts <david.roberts at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |david.roberts at ptfs-europe.c
                   |ity.org                     |om
                 CC|                            |david.roberts at ptfs-europe.c
                   |                            |om

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 23 11:30:45 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Jan 2020 10:30:45 +0000
Subject: [Koha-bugs] [Bug 23681] Patron restrictions should be user definable
In-Reply-To: <bug-23681-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23681-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23681-70-i5SwhZxaWx@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681

--- Comment #56 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Is the "default" flag really useful? We could imagine a new "internal" flag (to
replace ronly) for AVs.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 23 11:35:38 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Jan 2020 10:35:38 +0000
Subject: [Koha-bugs] [Bug 19809] Koha::Objects::find calls do not need to be
 forbidden in list context
In-Reply-To: <bug-19809-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19809-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19809-70-hDeHeGx28M@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19809

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|                            |20.05.00
        released in|                            |
             Status|Passed QA                   |Pushed to master

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 23 11:35:40 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Jan 2020 10:35:40 +0000
Subject: [Koha-bugs] [Bug 19809] Koha::Objects::find calls do not need to be
 forbidden in list context
In-Reply-To: <bug-19809-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19809-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19809-70-Y8q4EjMKDs@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19809

--- Comment #30 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Nice work everyone!

Pushed to master for 20.05

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 23 11:35:42 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Jan 2020 10:35:42 +0000
Subject: [Koha-bugs] [Bug 22831] Elasticsearch - add a maintenance script
 for checking DB vs index counts
In-Reply-To: <bug-22831-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22831-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22831-70-PPpTGJ4bZx@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22831

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to master
         Version(s)|                            |20.05.00
        released in|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 23 11:35:46 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Jan 2020 10:35:46 +0000
Subject: [Koha-bugs] [Bug 22831] Elasticsearch - add a maintenance script
 for checking DB vs index counts
In-Reply-To: <bug-22831-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22831-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22831-70-9HZ5mv5Gxg@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22831

--- Comment #28 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Nice work everyone!

Pushed to master for 20.05

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 23 11:35:49 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Jan 2020 10:35:49 +0000
Subject: [Koha-bugs] [Bug 23884] Merge strings.inc and browser-strings.inc
In-Reply-To: <bug-23884-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23884-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23884-70-26HSX042MX@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23884

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|                            |20.05.00
        released in|                            |
             Status|Passed QA                   |Pushed to master

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 23 11:35:52 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Jan 2020 10:35:52 +0000
Subject: [Koha-bugs] [Bug 23884] Merge strings.inc and browser-strings.inc
In-Reply-To: <bug-23884-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23884-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23884-70-Pd25t994jZ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23884

--- Comment #6 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Nice work everyone!

Pushed to master for 20.05

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 23 11:35:54 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Jan 2020 10:35:54 +0000
Subject: [Koha-bugs] [Bug 24025] Make CodeMirror content searchable
In-Reply-To: <bug-24025-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24025-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24025-70-JLPKlZSSyL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24025

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|                            |20.05.00
        released in|                            |
             Status|Passed QA                   |Pushed to master

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 23 11:35:58 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Jan 2020 10:35:58 +0000
Subject: [Koha-bugs] [Bug 24025] Make CodeMirror content searchable
In-Reply-To: <bug-24025-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24025-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24025-70-EC8znxaeic@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24025

--- Comment #9 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Nice work everyone!

Pushed to master for 20.05

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 23 11:36:01 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Jan 2020 10:36:01 +0000
Subject: [Koha-bugs] [Bug 24105] Longoverdue gives error message when
 --itemtypes are specified
In-Reply-To: <bug-24105-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24105-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24105-70-DcgUtWGmHQ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24105

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|                            |20.05.00
        released in|                            |
             Status|Passed QA                   |Pushed to master

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 23 11:36:04 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Jan 2020 10:36:04 +0000
Subject: [Koha-bugs] [Bug 24105] Longoverdue gives error message when
 --itemtypes are specified
In-Reply-To: <bug-24105-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24105-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24105-70-ZgW2Bue2pc@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24105

--- Comment #4 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Nice work everyone!

Pushed to master for 20.05

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 23 11:36:07 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Jan 2020 10:36:07 +0000
Subject: [Koha-bugs] [Bug 24149] Add new Koha::Statistic[s] classes
In-Reply-To: <bug-24149-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24149-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24149-70-cMEJdeW1oA@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24149

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to master
         Version(s)|                            |20.05.00
        released in|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 23 11:36:09 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Jan 2020 10:36:09 +0000
Subject: [Koha-bugs] [Bug 24149] Add new Koha::Statistic[s] classes
In-Reply-To: <bug-24149-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24149-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24149-70-JYHIaZPVMt@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24149

--- Comment #10 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Nice work everyone!

Pushed to master for 20.05

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 23 11:36:11 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Jan 2020 10:36:11 +0000
Subject: [Koha-bugs] [Bug 24452] Advanced editor - show multiple spaces
 visually
In-Reply-To: <bug-24452-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24452-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24452-70-Z7HqCGiIOv@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24452

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to master
         Version(s)|                            |20.05.00
        released in|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 23 11:36:14 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Jan 2020 10:36:14 +0000
Subject: [Koha-bugs] [Bug 24452] Advanced editor - show multiple spaces
 visually
In-Reply-To: <bug-24452-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24452-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24452-70-q4pr2U1KAh@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24452

--- Comment #6 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Nice work everyone!

Pushed to master for 20.05

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 23 11:36:16 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Jan 2020 10:36:16 +0000
Subject: [Koha-bugs] [Bug 24478] Make it possible to deactivate point of sale
In-Reply-To: <bug-24478-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24478-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24478-70-UfmKNK9y1G@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24478

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|                            |20.05.00
        released in|                            |
             Status|Passed QA                   |Pushed to master

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 23 11:36:18 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Jan 2020 10:36:18 +0000
Subject: [Koha-bugs] [Bug 24478] Make it possible to deactivate point of sale
In-Reply-To: <bug-24478-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24478-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24478-70-SCUNRoreJ8@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24478

--- Comment #9 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Nice work everyone!

Pushed to master for 20.05

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 23 11:37:49 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Jan 2020 10:37:49 +0000
Subject: [Koha-bugs] [Bug 21979] Add option to SIP2 config to send arbitrary
 item field in CR instead of collection code
In-Reply-To: <bug-21979-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21979-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21979-70-L8d8zMvo6T@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21979

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org

--- Comment #7 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Kyle, I did not test but I see:

+            $resp .= maybe_add( FID_COLLECTION_CODE,     
$item->collection_code,     $server );

then:

+            if ( my $CR = $server->{account}->{cr_item_field} ) {
+                $resp .= maybe_add( FID_COLLECTION_CODE, $item->{$CR} );
+            } else {
+                $resp .= maybe_add( FID_COLLECTION_CODE,
$item->collection_code );
+            }

Is that correct? (twice maybe_add with FID_COLLECTION_CODE)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 23 11:58:31 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Jan 2020 10:58:31 +0000
Subject: [Koha-bugs] [Bug 23355] Add 'cashup' process to the accounts system
In-Reply-To: <bug-23355-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23355-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23355-70-W54HGD72Iq@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23355

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #97706|0                           |1
        is obsolete|                            |

--- Comment #63 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 97784
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97784&action=edit
Bug 23355: Add cash_register_actions table

This patch adds the new cash_register_actions database table to allow
for storing of cash register actions which are not already stored as
accountlines.

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 23 11:58:34 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Jan 2020 10:58:34 +0000
Subject: [Koha-bugs] [Bug 23355] Add 'cashup' process to the accounts system
In-Reply-To: <bug-23355-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23355-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23355-70-5agBei9W72@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23355

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #97707|0                           |1
        is obsolete|                            |

--- Comment #64 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 97785
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97785&action=edit
Bug 23355: [DO NOT PUSH] DBIC Classes

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 23 11:58:38 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Jan 2020 10:58:38 +0000
Subject: [Koha-bugs] [Bug 23355] Add 'cashup' process to the accounts system
In-Reply-To: <bug-23355-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23355-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23355-70-CuP4bXbojx@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23355

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #97708|0                           |1
        is obsolete|                            |

--- Comment #65 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 97786
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97786&action=edit
Bug 23355: Add CASHUP actions

This patch adds a methods relating to cashup procedures to the cash
register object to ease adding and querying for cashup actions related
to the register.

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 23 11:58:41 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Jan 2020 10:58:41 +0000
Subject: [Koha-bugs] [Bug 23355] Add 'cashup' process to the accounts system
In-Reply-To: <bug-23355-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23355-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23355-70-FxjUbSGvTj@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23355

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #97709|0                           |1
        is obsolete|                            |

--- Comment #66 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 97787
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97787&action=edit
Bug 23355: Add accountline deletion test

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 23 11:58:45 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Jan 2020 10:58:45 +0000
Subject: [Koha-bugs] [Bug 23355] Add 'cashup' process to the accounts system
In-Reply-To: <bug-23355-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23355-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23355-70-tgsUVZHd7j@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23355

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #97710|0                           |1
        is obsolete|                            |

--- Comment #67 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 97788
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97788&action=edit
Bug 23355: Link cash_register_actions to cash_registers by foreign key

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 23 11:58:48 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Jan 2020 10:58:48 +0000
Subject: [Koha-bugs] [Bug 23355] Add 'cashup' process to the accounts system
In-Reply-To: <bug-23355-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23355-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23355-70-U4QzMFhdog@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23355

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #97711|0                           |1
        is obsolete|                            |

--- Comment #68 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 97789
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97789&action=edit
Bug 23355: Split tests for Line vs Lines

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 23 11:58:52 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Jan 2020 10:58:52 +0000
Subject: [Koha-bugs] [Bug 23355] Add 'cashup' process to the accounts system
In-Reply-To: <bug-23355-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23355-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23355-70-xVV78hFW31@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23355

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #97712|0                           |1
        is obsolete|                            |

--- Comment #69 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 97790
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97790&action=edit
Bug 23355: Add register details page

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 23 11:58:55 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Jan 2020 10:58:55 +0000
Subject: [Koha-bugs] [Bug 23355] Add 'cashup' process to the accounts system
In-Reply-To: <bug-23355-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23355-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23355-70-gEnHsTCdiK@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23355

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #97713|0                           |1
        is obsolete|                            |

--- Comment #70 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 97791
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97791&action=edit
Bug 23355: Add cashup permissions

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 23 11:58:59 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Jan 2020 10:58:59 +0000
Subject: [Koha-bugs] [Bug 23355] Add 'cashup' process to the accounts system
In-Reply-To: <bug-23355-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23355-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23355-70-6ECV2fg2x3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23355

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #97714|0                           |1
        is obsolete|                            |

--- Comment #71 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 97792
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97792&action=edit
Bug 23355: Add branch details page

This patch adds a new 'branch details' page to the POS system which
displays a summary of the cash register transactions for a branch
since each register was last cashed up. It also allows for cashing
up individual registers or cashing up all registers at a given branch
in one transaction.

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 23 11:59:02 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Jan 2020 10:59:02 +0000
Subject: [Koha-bugs] [Bug 23355] Add 'cashup' process to the accounts system
In-Reply-To: <bug-23355-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23355-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23355-70-EnYy86q7nT@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23355

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #97715|0                           |1
        is obsolete|                            |

--- Comment #72 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 97793
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97793&action=edit
Bug 23355: Use rowGroup plugin

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 23 11:59:05 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Jan 2020 10:59:05 +0000
Subject: [Koha-bugs] [Bug 23355] Add 'cashup' process to the accounts system
In-Reply-To: <bug-23355-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23355-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23355-70-LmYsVrM0Fe@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23355

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #97716|0                           |1
        is obsolete|                            |

--- Comment #73 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 97794
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97794&action=edit
Bug 23355: Remove superflous use of AuthoriseValues

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 23 12:05:00 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Jan 2020 11:05:00 +0000
Subject: [Koha-bugs] [Bug 24484] Add explanatory text to batch patron
 deletion
In-Reply-To: <bug-24484-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24484-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24484-70-RAfEKPX1M6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24484

--- Comment #2 from David Roberts <david.roberts at ptfs-europe.com> ---
Created attachment 97795
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97795&action=edit
Bug 24484 - Add explanatory text to batch patron deletion

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 23 12:05:06 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Jan 2020 11:05:06 +0000
Subject: [Koha-bugs] [Bug 15522] New interface for revamped circulation rules
In-Reply-To: <bug-15522-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15522-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15522-70-iK2pmg0Ref@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15522

--- Comment #45 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
(In reply to Michal Denar from comment #44)
> It's working for me. 
> 
> Nice and useful work.
> 
> Thank You Jonathan.

Hi Michal, can you explain what you tested exactly?
Did you think your tests cover bug 18936 as well?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 23 12:05:25 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Jan 2020 11:05:25 +0000
Subject: [Koha-bugs] [Bug 24484] Add explanatory text to batch patron
 deletion
In-Reply-To: <bug-24484-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24484-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24484-70-5o2kdbR2u7@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24484

David Roberts <david.roberts at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

--- Comment #3 from David Roberts <david.roberts at ptfs-europe.com> ---
To test:

1) Open up the Batch patron deletion and anonymisation tool
2) Check the help text near the top of the screen
3) Install the patch and repeat steps 1 and 2
4) Check the help text has changed to the new version

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 23 12:09:06 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Jan 2020 11:09:06 +0000
Subject: [Koha-bugs] [Bug 20447] Add support for MARC holdings records
In-Reply-To: <bug-20447-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20447-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20447-70-ulR24QZG1U@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447

Ere Maijala <ere.maijala at helsinki.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #94539|0                           |1
        is obsolete|                            |

--- Comment #154 from Ere Maijala <ere.maijala at helsinki.fi> ---
Created attachment 97796
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97796&action=edit
Bug 20447: MARC Holdings support

Enable by setting "SummaryHoldings" option to "Use".

Sponsored-by: The National Library of Finland

Signed-off-by: Michal Denar <black23 at gmail.com>

Signed-off-by: Michal Denar <black23 at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 23 12:10:03 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Jan 2020 11:10:03 +0000
Subject: [Koha-bugs] [Bug 20447] Add support for MARC holdings records
In-Reply-To: <bug-20447-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20447-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20447-70-EnbGIm57IU@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447

Ere Maijala <ere.maijala at helsinki.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #97796|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 23 12:10:16 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Jan 2020 11:10:16 +0000
Subject: [Koha-bugs] [Bug 20447] Add support for MARC holdings records
In-Reply-To: <bug-20447-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20447-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20447-70-Gboxa9f1RR@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447

Ere Maijala <ere.maijala at helsinki.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #94540|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 23 12:10:28 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Jan 2020 11:10:28 +0000
Subject: [Koha-bugs] [Bug 20447] Add support for MARC holdings records
In-Reply-To: <bug-20447-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20447-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20447-70-NLrISpDaIL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447

Ere Maijala <ere.maijala at helsinki.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #94541|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 23 12:10:39 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Jan 2020 11:10:39 +0000
Subject: [Koha-bugs] [Bug 20447] Add support for MARC holdings records
In-Reply-To: <bug-20447-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20447-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20447-70-9xdXFZYW82@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447

Ere Maijala <ere.maijala at helsinki.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #94542|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 23 12:16:00 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Jan 2020 11:16:00 +0000
Subject: [Koha-bugs] [Bug 24484] Add explanatory text to batch patron
 deletion
In-Reply-To: <bug-24484-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24484-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24484-70-G5sVNKCF18@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24484

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Failed QA
                 CC|                            |katrin.fischer at bsz-bw.de

--- Comment #4 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Hi David,

thx for the patch! Please include the test plan in your commit message and also
a small sentence as to what is changed here (see 

Noticed something to fix too:
+<p> - They are in a patron category of type Staff..</p>

should be: staff.

Instead of paragraphs a bullet list might work nicer here too semantically.
Then you don't need to hardcode the "- " which might be missed in translation.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 23 12:17:41 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Jan 2020 11:17:41 +0000
Subject: [Koha-bugs] [Bug 24484] Add explanatory text to batch patron
 deletion
In-Reply-To: <bug-24484-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24484-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24484-70-QB4Pd55j70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24484

--- Comment #5 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Forgot the link: https://wiki.koha-community.org/wiki/Commit_messages

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 23 12:19:07 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Jan 2020 11:19:07 +0000
Subject: [Koha-bugs] [Bug 24434] C4::Circulation::updateWrongTransfer is
 never called and should be removed
In-Reply-To: <bug-24434-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24434-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24434-70-6kYSBZWc5A@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24434

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |21346

--- Comment #3 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
WT-itemNumber, WT-waitingAt and WT-From have been removed from returns.tt by:
  commit 5ed171a45c46f63b18266ad3a3d0a978719ca285
  Bug 21346: Convert dialogs to modals.


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21346
[Bug 21346] Clean up dialogs in returns.pl
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 23 12:19:07 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Jan 2020 11:19:07 +0000
Subject: [Koha-bugs] [Bug 21346] Clean up dialogs in returns.pl
In-Reply-To: <bug-21346-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21346-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21346-70-wjcRoh3uZU@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21346

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |24434


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24434
[Bug 24434] C4::Circulation::updateWrongTransfer is never called and should be
removed
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 23 12:20:19 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Jan 2020 11:20:19 +0000
Subject: [Koha-bugs] [Bug 20447] Add support for MARC holdings records
In-Reply-To: <bug-20447-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20447-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20447-70-GrsHdSG2D6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447

--- Comment #155 from Ere Maijala <ere.maijala at helsinki.fi> ---
Created attachment 97797
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97797&action=edit
Bug 20447: MARC Holdings support

Enable by setting "SummaryHoldings" option to "Use".

Sponsored-by: The National Library of Finland

Signed-off-by: Michal Denar <black23 at gmail.com>

Signed-off-by: Michal Denar <black23 at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 23 12:20:20 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Jan 2020 11:20:20 +0000
Subject: [Koha-bugs] [Bug 15522] New interface for revamped circulation rules
In-Reply-To: <bug-15522-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15522-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15522-70-0usrmF45Ge@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15522

Michal Denar <black23 at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Needs Signoff

--- Comment #46 from Michal Denar <black23 at gmail.com> ---
Hi Jonamthan
I followed test plan above. If test bug 18936 is mandatory, I'll try to make it
soon. Set this bug back as Need Signoff.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 23 12:20:24 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Jan 2020 11:20:24 +0000
Subject: [Koha-bugs] [Bug 20447] Add support for MARC holdings records
In-Reply-To: <bug-20447-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20447-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20447-70-ECpozwHB5i@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447

--- Comment #156 from Ere Maijala <ere.maijala at helsinki.fi> ---
Created attachment 97798
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97798&action=edit
Bug 20447: Add a batch rebuild script for holdings table.

This script can be used to update the columns in the holdings table from the
MARC record using the rules in the framework. In practice this will only be
required if the koha link field is changed in the framework.

Signed-off-by: Michal Denar <black23 at gmail.com>

Signed-off-by: Michal Denar <black23 at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 23 12:20:29 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Jan 2020 11:20:29 +0000
Subject: [Koha-bugs] [Bug 20447] Add support for MARC holdings records
In-Reply-To: <bug-20447-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20447-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20447-70-hMcUVDaBv1@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447

--- Comment #157 from Ere Maijala <ere.maijala at helsinki.fi> ---
Created attachment 97799
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97799&action=edit
Bug 20447: Add import/export support for holdings

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447

Adds support for importing and exporting biblios with interleaved holdings.

Test plan:

1.) Import the MARCXML file attached to the bug with the -holdings parameter:
misc/migration_tools/bulkmarcimport.pl -biblios -holdings -file holdings.xml -m
MARCXML

2.) Verify that the holdings records were imported.

3.) Export the same records with holdings:
misc/export_records.pl --record-type=bibs --starting_biblionumber 103
--ending_biblionumber 104 --filename=holdings_export.xml --format=xml
--holdings

4.) Verify that both bibliographic and holding records are exported.

5.) Verify that tests in t/db_dependent/Exporter/Record.t pass.

Signed-off-by: Michal Denar <black23 at gmail.com>

Signed-off-by: Michal Denar <black23 at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 23 12:20:34 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Jan 2020 11:20:34 +0000
Subject: [Koha-bugs] [Bug 20447] Add support for MARC holdings records
In-Reply-To: <bug-20447-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20447-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20447-70-PUiRDBvH76@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447

--- Comment #158 from Ere Maijala <ere.maijala at helsinki.fi> ---
Created attachment 97800
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97800&action=edit
Bug 20447: DBIX schema changes

Signed-off-by: Michal Denar <black23 at gmail.com>

Signed-off-by: Michal Denar <black23 at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 23 12:21:14 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Jan 2020 11:21:14 +0000
Subject: [Koha-bugs] [Bug 20447] Add support for MARC holdings records
In-Reply-To: <bug-20447-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20447-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20447-70-jAKRpiRA6c@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447

--- Comment #159 from Ere Maijala <ere.maijala at helsinki.fi> ---
Rebased.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 23 12:22:00 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Jan 2020 11:22:00 +0000
Subject: [Koha-bugs] [Bug 21280] Unify MARC editor in biblios and authorities
In-Reply-To: <bug-21280-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21280-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21280-70-tQkN7BXL9K@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21280

--- Comment #32 from Ere Maijala <ere.maijala at helsinki.fi> ---
Josef?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 23 12:23:27 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Jan 2020 11:23:27 +0000
Subject: [Koha-bugs] [Bug 24484] Add explanatory text to batch patron
 deletion
In-Reply-To: <bug-24484-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24484-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24484-70-dsRCQHjDrZ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24484

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |martin.renvoize at ptfs-europe
                   |                            |.com

--- Comment #6 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
To explain that last bit...

You have

<p> - Stuff </p>
<p> - Stuff </p>
. . .

<p> = Paragraph.. so it works mostly.. but semantically we're actually talking
about a list so...

So... 

<ul>
  <li> Stuff </li>
  <li> Stuff </li>
</ul>

This is cleaner as it's semantically describing the content more accurately..
<ul> = Unordered list, <li> = List item.

:)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 23 12:25:46 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Jan 2020 11:25:46 +0000
Subject: [Koha-bugs] [Bug 24440] Add ->holds and ->holds_count to
 Koha::Acquisition::Order
In-Reply-To: <bug-24440-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24440-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24440-70-Sps2iG4vBN@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24440

--- Comment #6 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
(In reply to Jonathan Druart from comment #5)
> Koha::Acquisition::Order->holds does not make sense to me. There is not hold
> placed on an order.

Well, on reading parcel.pl and those checks you added a patch to (thanks) I
noticed we could want to display a modal with the lists of holds for the
librarian to know what's going on. So an endpoint to fetch those related holds
didn't seem unrealistic ( GET /acq/orders/:order_id holds. And also, if we get
rid of the _count method we really need the holds method to retrieve the count.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 23 12:26:45 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Jan 2020 11:26:45 +0000
Subject: [Koha-bugs] [Bug 24434] C4::Circulation::updateWrongTransfer is
 never called and should be removed
In-Reply-To: <bug-24434-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24434-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24434-70-F25dgJeCKf@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24434

--- Comment #4 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
(In reply to Jonathan Druart from comment #3)
> WT-itemNumber, WT-waitingAt and WT-From have been removed from returns.tt by:
>   commit 5ed171a45c46f63b18266ad3a3d0a978719ca285
>   Bug 21346: Convert dialogs to modals.

I do not manage to know if that was expected. How is this related to bug 21944?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 23 12:35:48 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Jan 2020 11:35:48 +0000
Subject: [Koha-bugs] [Bug 24484] Add explanatory text to batch patron
 deletion
In-Reply-To: <bug-24484-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24484-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24484-70-7jZ6KzmLIt@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24484

--- Comment #7 from David Roberts <david.roberts at ptfs-europe.com> ---
I'm having problems adding patches with git bz attach -e - it only works
without the -e at the moment, which means I can't put the test plan in the
right place! Bear with me....

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 23 12:36:17 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Jan 2020 11:36:17 +0000
Subject: [Koha-bugs] [Bug 24443] Consider NULL as 0 for issues in items
 search
In-Reply-To: <bug-24443-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24443-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24443-70-SJ4hSpDRUJ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24443

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 23 12:36:20 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Jan 2020 11:36:20 +0000
Subject: [Koha-bugs] [Bug 24443] Consider NULL as 0 for issues in items
 search
In-Reply-To: <bug-24443-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24443-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24443-70-8YiuMCRlH0@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24443

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #97559|0                           |1
        is obsolete|                            |
  Attachment #97560|0                           |1
        is obsolete|                            |

--- Comment #12 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 97801
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97801&action=edit
Bug 24443: Consider NULL as 0 for issues in items search

In items search, we can filter by items issues count, data coming from
items.issues.
Most of the time, for an item with no issues this column contains NULL.
This enhancement proposes to consider NULL as 0 to allow searching items with
no issues.

Test plan:
1) Use SQL to count items with items.issues = NULL :
   select count(*) from items where issues is null;
2) Go to items search
3) Perform search with filter "Checkout count" = 0
4) Check you get the same number of results as SQL query

Signed-off-by: Maryse Simard <maryse.simard at inlibro.com>

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 23 12:36:24 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Jan 2020 11:36:24 +0000
Subject: [Koha-bugs] [Bug 24443] Consider NULL as 0 for issues in items
 search
In-Reply-To: <bug-24443-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24443-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24443-70-T0BZYxsBYj@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24443

--- Comment #13 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 97802
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97802&action=edit
Bug 24443: Unit test

Signed-off-by: Maryse Simard <maryse.simard at inlibro.com>

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 23 12:36:52 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Jan 2020 11:36:52 +0000
Subject: [Koha-bugs] [Bug 24443] Consider NULL as 0 for issues in items
 search
In-Reply-To: <bug-24443-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24443-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24443-70-fhCQt9L0IH@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24443

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|enhancement                 |normal
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 23 12:43:58 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Jan 2020 11:43:58 +0000
Subject: [Koha-bugs] [Bug 21674] Data integrity not enforced for library
 groups
In-Reply-To: <bug-21674-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21674-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21674-70-aepqi7IPqX@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21674

--- Comment #9 from Nick Clemens <nick at bywatersolutions.com> ---
(In reply to Jonathan Druart from comment #8)
> (In reply to Jonathan Druart from comment #7)
> > Created attachment 97667 [details] [review] [review]
> > Bug 21674: Remove duplicates from library_groups before adding the uniq
> > constraint
> > 
> > To avoid to make it fails if duplicates existed prior to this change
> 
> There is certainly a more efficient (SQL) way to do that.

DELETE FROM library_groups WHERE id NOT IN (SELECT MIN(id) FROM library_groups
WHERE parent_id IS NOT NULL GROUP BY parent_id,branchcode) AND parent_id IS NOT
NULL;

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 23 12:46:03 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Jan 2020 11:46:03 +0000
Subject: [Koha-bugs] [Bug 13121] Move search results "action" links ("Place
 hold, " "Add tag, " etc) into include file
In-Reply-To: <bug-13121-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13121-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13121-70-8XPvGfKh43@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13121

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 23 12:46:06 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Jan 2020 11:46:06 +0000
Subject: [Koha-bugs] [Bug 13121] Move search results "action" links ("Place
 hold, " "Add tag, " etc) into include file
In-Reply-To: <bug-13121-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13121-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13121-70-eojsp5abrq@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13121

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #96891|0                           |1
        is obsolete|                            |

--- Comment #3 from David Nind <david at davidnind.com> ---
Created attachment 97803
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97803&action=edit
Bug 13121: Move search results "action" links ("Place hold," "Add tag," etc)
into include file

This patch moves markup for controls repeated across several OPAC
templates into a single include: Place hold, Request article, Add tag,
Save to lists, and Add to cart.

Enable ArticleRequests and TagsInputOnList system preferences.

To test, apply the patch and view the following OPAC pages:

 - Search results
 - Shelf contents view
 - User tags list

On each of these pages all the controls should work correctly:

 - Place hold
 - Request articles
 - Add tag
 - Save to lists
 - Add to cart

Signed-off-by: David Nind <david at davidnind.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 23 12:46:32 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Jan 2020 11:46:32 +0000
Subject: [Koha-bugs] [Bug 7611] Show the NOT_LOAN authorised values for item
 status in XSLT OPAC search results
In-Reply-To: <bug-7611-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-7611-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7611-70-boXJ4OiR5T@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7611

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org
             Status|Signed Off                  |Patch doesn't apply

--- Comment #38 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
error: sha1 information is lacking or useless
(koha-tmpl/opac-tmpl/bootstrap/en/xslt/MARC21slim2OPACResults.xsl).

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 23 12:48:36 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Jan 2020 11:48:36 +0000
Subject: [Koha-bugs] [Bug 13121] Move search results "action" links ("Place
 hold, " "Add tag, " etc) into include file
In-Reply-To: <bug-13121-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13121-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13121-70-t9Ti625Qom@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13121

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |david at davidnind.com

--- Comment #4 from David Nind <david at davidnind.com> ---
I'm assuming 'Shelf contents view' is either the Cart or Lists - all the
actions seem to work as expected in those areas.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 23 12:50:01 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Jan 2020 11:50:01 +0000
Subject: [Koha-bugs] [Bug 24484] Add explanatory text to batch patron
 deletion
In-Reply-To: <bug-24484-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24484-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24484-70-MvPXfKGQGb@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24484

--- Comment #8 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
(In reply to David Roberts from comment #7)
> I'm having problems adding patches with git bz attach -e - it only works
> without the -e at the moment, which means I can't put the test plan in the
> right place! Bear with me....

Hi David, you can do it like this (the -e won't help possibly):

git commit --amend

This will bring up the commit message of the last patch on your branch and you
can edit/add to it.

Then you can do a:

git bz attach 24484 HEAD

And then you can obsolete the old patch here using bugzilla: Klick on details >
edit details > obsolete checkbox.

The -e allows you to obsolete patches and change status but afaik it won't
change the patch you upload.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 23 12:56:37 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Jan 2020 11:56:37 +0000
Subject: [Koha-bugs] [Bug 7611] Show the NOT_LOAN authorised values for item
 status in XSLT OPAC search results
In-Reply-To: <bug-7611-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-7611-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7611-70-qN0ruMCur3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7611

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Patch doesn't apply         |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 23 12:56:41 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Jan 2020 11:56:41 +0000
Subject: [Koha-bugs] [Bug 7611] Show the NOT_LOAN authorised values for item
 status in XSLT OPAC search results
In-Reply-To: <bug-7611-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-7611-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7611-70-oQz0TqWTJ4@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7611

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #95236|0                           |1
        is obsolete|                            |
  Attachment #95237|0                           |1
        is obsolete|                            |
  Attachment #95238|0                           |1
        is obsolete|                            |
  Attachment #95239|0                           |1
        is obsolete|                            |
  Attachment #95240|0                           |1
        is obsolete|                            |

--- Comment #39 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 97804
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97804&action=edit
Bug 7611: Show the NOT_LOAN authorised values for item status in XSLT OPAC
search results

Added : Call number for all not for loan status

XSLT Results template improvement : Use the NOT_LOAN authorised values

Improvement : Use the NOT_LOAN authorised values when showing items status in
the OPAC search results.
Before this patch, these items were only considered as "unavailable".

Note : This patch only affects the OPAC XSLT search results template for MARC21
records. This patch was not tested on UNIMARC or NORMARC records. I won't be
able to support these formats, so I'm hoping someone could do the same for
these other record formats.

Patch sponsored by the CCSR ( http://www.ccsr.qc.ca )

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 23 12:56:46 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Jan 2020 11:56:46 +0000
Subject: [Koha-bugs] [Bug 7611] Show the NOT_LOAN authorised values for item
 status in XSLT OPAC search results
In-Reply-To: <bug-7611-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-7611-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7611-70-NskwosQBXN@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7611

--- Comment #40 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 97805
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97805&action=edit
Bug 7611: Change negative notforloan as well

This makes the changes apply to both positive and negative notforloan values

The extra line generated before is removed

Some spans are added and cleaned up and labels moved to CSS to allow for easier
altering where needed

Itemtypes marked notforloan remain as reference, the label can be changed via
css

To test:
 1 - Have a record with items in various statuses, ideally
   - 3 available, with 2 in one branch, 1 in another
   - 3 with itemtype not for loan, 2 in one branch, 1 in another
   - 3 in a positive not for loan status, 2 and 1 as above
   - 3 in a negative not for loan status, 2 and 1 as above
   - 1 in a different positive loan status, but with the same opac description
as the negative above
 2 - Search the opac to include this record, take a screenshot
 3 - Apply patch
 4 - Restart all and refresh
 5 - Compare to screen shot
 6 - Differences include:
   - Positive statuses are now on separate line with opac description showing
   - Unavailable (not for loan items) now include callnumber and branch in
display
   - Positive and negative notforloan with same description are combined where
branches match
   - Inspect the elements, note new spans around 'Items available for
loan/reference'
 7 - Add to OPACUserCSS:
  .ItemSummary .ItemBranch{
    display:none;
  }
  .unavailable .ItemSummary .CallNumber,.unavailable .ItemSummary
.LabelCallNumber{
    display:none;
  }
 8 - Note the branches are hidden, and callnumbe rhidden for unavailable
items

Signed-off-by: Jessica Zairo <jzairo at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 23 12:56:50 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Jan 2020 11:56:50 +0000
Subject: [Koha-bugs] [Bug 7611] Show the NOT_LOAN authorised values for item
 status in XSLT OPAC search results
In-Reply-To: <bug-7611-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-7611-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7611-70-BDBUsxbAlw@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7611

--- Comment #41 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 97806
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97806&action=edit
Bug 7611: (follow-up) Add missing space

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 23 12:56:54 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Jan 2020 11:56:54 +0000
Subject: [Koha-bugs] [Bug 7611] Show the NOT_LOAN authorised values for item
 status in XSLT OPAC search results
In-Reply-To: <bug-7611-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-7611-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7611-70-x0JaNYjcPs@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7611

--- Comment #42 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 97807
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97807&action=edit
Bug 7611: (follow-up) Fix display of undefined statuses and add a class

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 23 12:56:58 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Jan 2020 11:56:58 +0000
Subject: [Koha-bugs] [Bug 7611] Show the NOT_LOAN authorised values for item
 status in XSLT OPAC search results
In-Reply-To: <bug-7611-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-7611-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7611-70-oZbcIMvFNU@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7611

--- Comment #43 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 97808
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97808&action=edit
Bug 7611: (follow-up) separate positive and negative statuses as in the past

This patch preserves someting closer to previous functionality.

Negative not for loan are in the 'unavailable' section in red, positive ones
are in the 'reference' section in green. Itemtype level will also be in green
in reference

Item specific status will override an itemtype level.

The line break between 'reference' and 'unavailable' existed before and is
preserved - negative not for loan and checked out items appear here

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 23 13:00:46 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Jan 2020 12:00:46 +0000
Subject: [Koha-bugs] [Bug 11299] Add a button to automatically link
 authority records in cataloguing (AJAX)
In-Reply-To: <bug-11299-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-11299-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11299-70-O0ukR3nL1W@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11299

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Failed QA

--- Comment #105 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
1. I see a new sub added to C4 without test coverage. Moreover it's c/ping a
lot of code from LinkBibHeadingsToAuthorities (refactoring needed)

2. New images must be replaced by bootstrap icons

3. In authorities.pl, "require C4::Heading;" why require instead of use?

4. addbiblio needs permission editcatalogue and displays the "linker button",
but 
cataloguing/automatic_linker.pl requires editauthorities. I think the button
must be hidden if permission is not sufficient.

5. Hazardous indentation in some file, for instance:

+function confirmnotdup(redirect){
+       $("#confirm_not_duplicate").attr("value","1");
+    $("#redirect").attr("value",redirect);
+       Check();
+}

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 23 13:02:52 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Jan 2020 12:02:52 +0000
Subject: [Koha-bugs] [Bug 11299] Add a button to automatically link
 authority records in cataloguing (AJAX)
In-Reply-To: <bug-11299-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-11299-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11299-70-nkBwWXc6nC@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11299

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Signed Off

--- Comment #106 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Regarding history I am removing the FQA status, letting QA step for someone
else.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 23 13:05:06 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Jan 2020 12:05:06 +0000
Subject: [Koha-bugs] [Bug 21633] Did finesMode = test ever send email?
In-Reply-To: <bug-21633-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21633-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21633-70-86O2QjxRTV@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21633

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #96835|0                           |1
        is obsolete|                            |

--- Comment #12 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 97809
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97809&action=edit
Bug 21633: Remove finesMode 'test'

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 23 13:05:37 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Jan 2020 12:05:37 +0000
Subject: [Koha-bugs] [Bug 24484] Add explanatory text to batch patron
 deletion
In-Reply-To: <bug-24484-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24484-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24484-70-fOGk5w7hyr@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24484

--- Comment #9 from David Roberts <david.roberts at ptfs-europe.com> ---
Thank you - now I understand! :-)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 23 13:06:37 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Jan 2020 12:06:37 +0000
Subject: [Koha-bugs] [Bug 21633] Did finesMode = test ever send email?
In-Reply-To: <bug-21633-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21633-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21633-70-G7lycZD0ZB@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21633

--- Comment #13 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 97810
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97810&action=edit
Bug 21633: (follow-up) Cleanup other values for finesMode

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 23 13:21:13 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Jan 2020 12:21:13 +0000
Subject: [Koha-bugs] [Bug 21674] Data integrity not enforced for library
 groups
In-Reply-To: <bug-21674-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21674-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21674-70-XU4VIW2wOY@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21674

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #97667|0                           |1
        is obsolete|                            |

--- Comment #10 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 97811
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97811&action=edit
Bug 21674: Remove duplicates from library_groups before adding the uniq
constraint

To avoid to make it fails if duplicates existed prior to this change

Credit for the SQL query goes to Nick, thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 23 13:24:56 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Jan 2020 12:24:56 +0000
Subject: [Koha-bugs] [Bug 24484] Add explanatory text to batch patron
 deletion
In-Reply-To: <bug-24484-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24484-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24484-70-zUZxdkCNAF@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24484

David Roberts <david.roberts at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #97795|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 23 13:25:25 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Jan 2020 12:25:25 +0000
Subject: [Koha-bugs] [Bug 24484] Add explanatory text to batch patron
 deletion
In-Reply-To: <bug-24484-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24484-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24484-70-yHgYSXJlwc@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24484

--- Comment #10 from David Roberts <david.roberts at ptfs-europe.com> ---
Created attachment 97812
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97812&action=edit
Bug 24484 - Add explanatory text to batch patron deletion

This patch adds a more detailed explanation about what the tool can do.

To test:

1) Open up the Batch patron deletion and anonymisation tool
2) Check the help text near the top of the screen
3) Install the patch and repeat steps 1 and 2
4) Check the help text has changed to the new version

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 23 13:26:35 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Jan 2020 12:26:35 +0000
Subject: [Koha-bugs] [Bug 24484] Add explanatory text to batch patron
 deletion
In-Reply-To: <bug-24484-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24484-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24484-70-4BDykOzGL3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24484

David Roberts <david.roberts at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Needs Signoff

--- Comment #11 from David Roberts <david.roberts at ptfs-europe.com> ---
Hopefully this is better now! :-)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 23 13:32:28 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Jan 2020 12:32:28 +0000
Subject: [Koha-bugs] [Bug 24484] Add explanatory text to batch patron
 deletion
In-Reply-To: <bug-24484-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24484-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24484-70-tdVWmRGgs4@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24484

ByWater Sandboxes <bws.sandboxes at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #97812|0                           |1
        is obsolete|                            |

--- Comment #12 from ByWater Sandboxes <bws.sandboxes at gmail.com> ---
Created attachment 97813
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97813&action=edit
Bug 24484 - Add explanatory text to batch patron deletion

This patch adds a more detailed explanation about what the tool can do.

To test:

1) Open up the Batch patron deletion and anonymisation tool
2) Check the help text near the top of the screen
3) Install the patch and repeat steps 1 and 2
4) Check the help text has changed to the new version

Signed-off-by: Andrew Fuerste-Henry <andrew at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 23 13:33:09 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Jan 2020 12:33:09 +0000
Subject: [Koha-bugs] [Bug 24484] Add explanatory text to batch patron
 deletion
In-Reply-To: <bug-24484-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24484-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24484-70-weyyq9ygjs@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24484

Andrew Fuerste-Henry <andrew at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

--- Comment #13 from Andrew Fuerste-Henry <andrew at bywatersolutions.com> ---
Thanks for jumping right on this, David!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 23 13:44:00 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Jan 2020 12:44:00 +0000
Subject: [Koha-bugs] [Bug 4042] Public OPAC search can fall prey to web
 crawlers
In-Reply-To: <bug-4042-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-4042-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-4042-70-U02L1P4XNk@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4042

Barry Cannon <bc at interleaf.ie> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |bc at interleaf.ie

--- Comment #12 from Barry Cannon <bc at interleaf.ie> ---
Reading over this bug it occurs to me that some of the steps we have taken to
mitigate this problem might help others. I will post high level information
here, in case it might help some people along.


The first step we took (after adding robots.txt) was to add a small piece of
code to the OPACHeader syspref that appended a “hidden” a href tag to a script
(sneakysnare.pl) on the site. This would be only visible to bots and once this
link was followed a page would show with a lot of useless text. In the
background though the script grabbed the source IP address and pushed it into a
deny rule on the firewall. This worked well for bots that blindly followed all
links from the page. Shortly after we noticed that not all bots were following
all links.

Our next step was to check the useragent of the incoming traffic. We noticed
that there were a lot of useragent strings causing issues. Configuring apache
for a CustomLog of “time,IP,METHOD,URI” we configured a script to run regularly
to parse this file for know “bad” useragent strings. We were then able to add
these IPs to the firewall to be dropped.

Our current setup is expanded from above: all our servers use csf/lfd for local
firewall and intrusion detection. We also use ipset extensively for other
non-Koha related services. Csf can be configured to offload deny chains to
ipset. This helps iptables and lowers the resource strain on the server. Csf
can be configured to use an Include file to deny hosts. By expanding on the
sneakysnare script and the useragent apache log we create a small job to bring
all this together and manage an csf include file. The job checks this new file
and if a new IP address has appeared it will add that IP to the deny set.

In some cases we have observed the server being slowly scrapped. This insidious
scrapping is harder to detect immediately and often slows/hogs resources over a
longer period. Quite often the source of these connections are from a
particular geographical region. If this happens - often enough - we can employ
geoblocking. Csf can be configured to use Maxmind GeoIP database lookup. Using
the configuration file we specify the country code we want to block. For
example to block all Irish and British traffic (not that we would!) we enter
the “IE,GB” into the config file. Once the daemon is restarted the GeoIP
database is referenced and all known CIDR blocks for those nountries are loaded
into ipset’s deny set. Csf can also be configured to “deny all, except”. It
this setup placing “IE” in the config file would only allow traffic from
Ireland and deny all other traffic.

There are pros and cons to all of the above and consideration should be given
before implementation.

Third party services are also very useful and moving traffic via CDN providers
(and using their security services) will greatly reduce bots, DDOS and other
hassle.

Other helpful methods include reverse proxies and mitigating at that level.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 23 13:56:30 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Jan 2020 12:56:30 +0000
Subject: [Koha-bugs] [Bug 24489] New: Prevent user from paying/writing off 0
Message-ID: <bug-24489-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24489

            Bug ID: 24489
           Summary: Prevent user from paying/writing off 0
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: Fines and fees
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: nick at bywatersolutions.com
        QA Contact: testopia at bugs.koha-community.org

On paycollect.pl we call 'moneyFormat' on the 'paid' and 'collected' amounts -
this changes fractions of a cent to 0, however, we allow for submission of the
0

When paying 0 we redirect to the page, but lose some inputs so writing off
selected, attempting to pay less than a cent, we get redirected to 'Pay fines'

We should check the form before submission and prevent submission of 0

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 23 14:00:58 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Jan 2020 13:00:58 +0000
Subject: [Koha-bugs] [Bug 24490] New: Clarify wording and function of
 Purchase Items link on POS
Message-ID: <bug-24490-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24490

            Bug ID: 24490
           Summary: Clarify wording and function of Purchase Items link on
                    POS
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: Fines and fees
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: andrew at bywatersolutions.com
        QA Contact: testopia at bugs.koha-community.org

On cgi-bin/koha/pos/pay.pl, we're given a link with text "Purchase items" that
goes to /cgi-bin/koha/admin/debit_types.pl. "Purchase items" sounds like one
would click the link to purchase things, when really one clicks the link to
define items that can be purchased.

"Purchasable items" or "Items for purchase" would be more clear. Alternately,
the debit types interface uses the wording "Can be sold" so we could try to
match that, but "Items that can be sold" is awkward.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 23 14:01:20 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Jan 2020 13:01:20 +0000
Subject: [Koha-bugs] [Bug 24490] Clarify wording and function of Purchase
 Items link on POS
In-Reply-To: <bug-24490-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24490-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24490-70-1zLJO5L40q@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24490

Andrew Fuerste-Henry <andrew at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=24477

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 23 14:01:20 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Jan 2020 13:01:20 +0000
Subject: [Koha-bugs] [Bug 24477] No permissions check for POS feature
In-Reply-To: <bug-24477-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24477-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24477-70-6we8KV3SJY@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24477

Andrew Fuerste-Henry <andrew at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=24490

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 23 14:01:42 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Jan 2020 13:01:42 +0000
Subject: [Koha-bugs] [Bug 24489] Prevent user from paying/writing off 0
In-Reply-To: <bug-24489-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24489-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24489-70-F3GfBrIpcd@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24489

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 23 14:01:45 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Jan 2020 13:01:45 +0000
Subject: [Koha-bugs] [Bug 24489] Prevent user from paying/writing off 0
In-Reply-To: <bug-24489-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24489-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24489-70-aQHYdLSq6u@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24489

--- Comment #1 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 97815
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97815&action=edit
Bug 24489: Don't allow payment of 0

To test:
1 - Put a fine on a patron
2 - Go to Accounting->Make a payment on the patrons record
3 - Select the fine and click 'Write off selected'
4 - Enter '.0001' into Writeoff amount and hit confirm
5 - You are redirected to make a payment with no error and are no longer
writing off selected
6 - Apply patch
7 - Attempt to pay less than a cent
8 -  You are warned that you must pay more than 0

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 23 14:02:05 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Jan 2020 13:02:05 +0000
Subject: [Koha-bugs] [Bug 24489] Prevent user from paying/writing off 0
In-Reply-To: <bug-24489-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24489-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24489-70-Nq0TJPTks5@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24489

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |nick at bywatersolutions.com
                   |ity.org                     |
                 CC|                            |kyle.m.hall at gmail.com,
                   |                            |martin.renvoize at ptfs-europe
                   |                            |.com

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 23 14:05:09 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Jan 2020 13:05:09 +0000
Subject: [Koha-bugs] [Bug 24489] Prevent user from paying/writing off 0
In-Reply-To: <bug-24489-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24489-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24489-70-spryAOQso6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24489

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de,
                   |                            |tomascohen at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 23 14:06:04 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Jan 2020 13:06:04 +0000
Subject: [Koha-bugs] [Bug 24491] New: Add filters to debit types interface
Message-ID: <bug-24491-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24491

            Bug ID: 24491
           Summary: Add filters to debit types interface
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Fines and fees
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: andrew at bywatersolutions.com
        QA Contact: testopia at bugs.koha-community.org

On cgi-bin/koha/admin/debit_types.pl, we have the option to filter down to only
user-defined debit types, hiding those defined by the system. It would be
helpful to also be able to filter to only those flagged for manual invoice and
only those flagged for purchase.

If we had a filter for purchasable items, we could then make the link off of
the point of sale page point to debit types with that filter enabled.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 23 14:07:24 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Jan 2020 13:07:24 +0000
Subject: [Koha-bugs] [Bug 24477] No permissions check for POS feature
In-Reply-To: <bug-24477-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24477-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24477-70-0K4flLU8eu@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24477

--- Comment #13 from Andrew Fuerste-Henry <andrew at bywatersolutions.com> ---
I opened bug 24490 for the wording of that link and then bug 24491 suggesting
some filtering options on the debit types page.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 23 14:26:57 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Jan 2020 13:26:57 +0000
Subject: [Koha-bugs] [Bug 24476] Allow patrons to opt-out of Auto-renewal
In-Reply-To: <bug-24476-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24476-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24476-70-KvAk2Z2skg@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24476

--- Comment #6 from Andrew Fuerste-Henry <andrew at bywatersolutions.com> ---
Failing on step 7. Once I've opted the patron out of auto-renew, they still
show on the OPAC as scheduled for auto-renew.

Taking a step back, I think this could be a little more clear if we weren't
defining it as a negative. Right now it's "select Yes to not auto-renew, select
No to not not auto-renew." How about "Allow auto-renew: Yes/No" rather than
"Disallow auto-renew: Yes/No"?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 23 14:27:07 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Jan 2020 13:27:07 +0000
Subject: [Koha-bugs] [Bug 24476] Allow patrons to opt-out of Auto-renewal
In-Reply-To: <bug-24476-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24476-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24476-70-HlKh5VN1gl@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24476

Andrew Fuerste-Henry <andrew at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Failed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 23 14:35:26 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Jan 2020 13:35:26 +0000
Subject: [Koha-bugs] [Bug 24477] No permissions check for POS feature
In-Reply-To: <bug-24477-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24477-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24477-70-65C23gSjtP@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24477

--- Comment #14 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
(In reply to Andrew Fuerste-Henry from comment #13)
> I opened bug 24490 for the wording of that link and then bug 24491
> suggesting some filtering options on the debit types page.

Thx!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 23 14:49:16 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Jan 2020 13:49:16 +0000
Subject: [Koha-bugs] [Bug 24476] Allow patrons to opt-out of Auto-renewal
In-Reply-To: <bug-24476-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24476-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24476-70-wMoaUNKxvN@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24476

--- Comment #7 from Owen Leonard <oleonard at myacpl.org> ---
It doesn't look like there's a way to turn off this feature. Could it be added
to patron category configuration? I know my library would not want patrons to
be able to opt out.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 23 15:06:16 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Jan 2020 14:06:16 +0000
Subject: [Koha-bugs] [Bug 23354] Add a 'Pay' screen to allow anonymous
 payments in a POS fashion
In-Reply-To: <bug-23354-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23354-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23354-70-netrBGhFxc@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23354

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |24490


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24490
[Bug 24490] Clarify wording and function of Purchase Items link on POS
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 23 15:06:16 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Jan 2020 14:06:16 +0000
Subject: [Koha-bugs] [Bug 24490] Clarify wording and function of Purchase
 Items link on POS
In-Reply-To: <bug-24490-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24490-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24490-70-hj2CENVkCV@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24490

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |martin.renvoize at ptfs-europe
                   |                            |.com
         Depends on|                            |23354


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23354
[Bug 23354] Add a 'Pay' screen to allow anonymous payments in a POS fashion
-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 23 15:06:52 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Jan 2020 14:06:52 +0000
Subject: [Koha-bugs] [Bug 24491] Add filters to debit types interface
In-Reply-To: <bug-24491-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24491-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24491-70-3Fxr7XDGqQ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24491

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |martin.renvoize at ptfs-europe
                   |                            |.com
         Depends on|                            |23354


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23354
[Bug 23354] Add a 'Pay' screen to allow anonymous payments in a POS fashion
-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 23 15:06:52 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Jan 2020 14:06:52 +0000
Subject: [Koha-bugs] [Bug 23354] Add a 'Pay' screen to allow anonymous
 payments in a POS fashion
In-Reply-To: <bug-23354-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23354-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23354-70-shIk2bDsqR@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23354

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |24491


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24491
[Bug 24491] Add filters to debit types interface
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 23 15:07:54 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Jan 2020 14:07:54 +0000
Subject: [Koha-bugs] [Bug 24477] No permissions check for POS feature
In-Reply-To: <bug-24477-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24477-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24477-70-ho8ExsOnQw@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24477

--- Comment #15 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Thanks guys, this is all really helpful feedback :)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 23 15:08:08 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Jan 2020 14:08:08 +0000
Subject: [Koha-bugs] [Bug 24476] Allow patrons to opt-out of Auto-renewal
In-Reply-To: <bug-24476-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24476-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24476-70-Dmtlyyb4HM@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24476

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de

--- Comment #8 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
(In reply to Owen Leonard from comment #7)
> It doesn't look like there's a way to turn off this feature. Could it be
> added to patron category configuration? I know my library would not want
> patrons to be able to opt out.

I agree - academic libraries here might not want that either.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 23 15:09:13 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Jan 2020 14:09:13 +0000
Subject: [Koha-bugs] [Bug 24476] Allow patrons to opt-out of Auto-renewal
In-Reply-To: <bug-24476-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24476-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24476-70-SyGyKqMN8d@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24476

--- Comment #9 from Andrew Fuerste-Henry <andrew at bywatersolutions.com> ---
To Owen's concern, as is there isn't a way for the patron to opt out for
themselves from the OPAC, so that makes it easier for a library to disallow it.

But ...

Seems like if we're going to add this feature it'd be good to also give the
patron the option to opt out for themselves from the OPAC.

Following existing conventions, this sounds like two sysprefs and a new toggle
on the category:
IntranetAutoRenewOptOut
OPACAutoRenewOptOut
and then a thingy in the category to allow an individual category to differ
from the syspref

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 23 15:11:40 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Jan 2020 14:11:40 +0000
Subject: [Koha-bugs] [Bug 23594] Batch modification for itemtypes on
 suggestions page
In-Reply-To: <bug-23594-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23594-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23594-70-71iBhlP0lv@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23594

--- Comment #22 from Owen Leonard <oleonard at myacpl.org> ---
I agree about the item type going into its own column. I think the fact that
it's a field that can be batch updated means it should be easier to see.

I agree that there are a lot of forms on the page but I don't think it's
unreasonable. I do think a nice addition could be to hide the batch update
forms until a selection has been made. But that could be a follow-up.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 23 15:12:06 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Jan 2020 14:12:06 +0000
Subject: [Koha-bugs] [Bug 24492] New: Add a 'branch cashup' workflow to the
 point of sale system
Message-ID: <bug-24492-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24492

            Bug ID: 24492
           Summary: Add a 'branch cashup' workflow to the point of sale
                    system
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Fines and fees
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: martin.renvoize at ptfs-europe.com
        QA Contact: testopia at bugs.koha-community.org

Bug 23355 adds a cashup workflow for individual cash registers, but it would be
nice to have a branch summary and cashup option too.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 23 15:12:12 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Jan 2020 14:12:12 +0000
Subject: [Koha-bugs] [Bug 24492] Add a 'branch cashup' workflow to the point
 of sale system
In-Reply-To: <bug-24492-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24492-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24492-70-Mvd0MCfUfB@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24492

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |martin.renvoize at ptfs-europe
                   |ity.org                     |.com

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 23 15:12:26 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Jan 2020 14:12:26 +0000
Subject: [Koha-bugs] [Bug 24492] Add a 'branch cashup' workflow to the point
 of sale system
In-Reply-To: <bug-24492-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24492-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24492-70-ubyrIF10Qd@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24492

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |23355


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23355
[Bug 23355] Add 'cashup' process to the accounts system
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 23 15:12:26 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Jan 2020 14:12:26 +0000
Subject: [Koha-bugs] [Bug 23355] Add 'cashup' process to the accounts system
In-Reply-To: <bug-23355-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23355-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23355-70-EoLztfLZQr@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23355

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |24492


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24492
[Bug 24492] Add a 'branch cashup' workflow to the point of sale system
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 23 15:13:18 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Jan 2020 14:13:18 +0000
Subject: [Koha-bugs] [Bug 24492] Add a 'branch cashup' workflow to the point
 of sale system
In-Reply-To: <bug-24492-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24492-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24492-70-CSKeXRcpXZ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24492

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |13985


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13985
[Bug 13985] Cash Management - Koha as 'Point of Sale'
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 23 15:13:18 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Jan 2020 14:13:18 +0000
Subject: [Koha-bugs] [Bug 13985] Cash Management - Koha as 'Point of Sale'
In-Reply-To: <bug-13985-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13985-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13985-70-Lj69D0uMQb@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13985

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |24492


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24492
[Bug 24492] Add a 'branch cashup' workflow to the point of sale system
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 23 15:14:28 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Jan 2020 14:14:28 +0000
Subject: [Koha-bugs] [Bug 23355] Add 'cashup' process to the accounts system
In-Reply-To: <bug-23355-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23355-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23355-70-OGYPEzHJSW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23355

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #97784|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 23 15:15:45 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Jan 2020 14:15:45 +0000
Subject: [Koha-bugs] [Bug 23355] Add 'cashup' process to the accounts system
In-Reply-To: <bug-23355-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23355-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23355-70-hxhj3grAH6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23355

--- Comment #74 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 97816
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97816&action=edit
Bug 23355: Add cash_register_actions table

This patch adds the new cash_register_actions database table to allow
for storing of cash register actions which are not already stored as
accountlines.

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 23 15:15:48 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Jan 2020 14:15:48 +0000
Subject: [Koha-bugs] [Bug 23355] Add 'cashup' process to the accounts system
In-Reply-To: <bug-23355-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23355-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23355-70-ghmDiB2WMZ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23355

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #97785|0                           |1
        is obsolete|                            |

--- Comment #75 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 97817
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97817&action=edit
Bug 23355: [DO NOT PUSH] DBIC Classes

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 23 15:15:52 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Jan 2020 14:15:52 +0000
Subject: [Koha-bugs] [Bug 23355] Add 'cashup' process to the accounts system
In-Reply-To: <bug-23355-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23355-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23355-70-nDehFmln95@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23355

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #97786|0                           |1
        is obsolete|                            |

--- Comment #76 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 97818
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97818&action=edit
Bug 23355: Add CASHUP actions

This patch adds methods relating to cashup procedures to the cash
register object to ease adding and querying for cashup actions related
to the register.

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 23 15:15:55 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Jan 2020 14:15:55 +0000
Subject: [Koha-bugs] [Bug 23355] Add 'cashup' process to the accounts system
In-Reply-To: <bug-23355-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23355-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23355-70-caBifVXMCq@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23355

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #97787|0                           |1
        is obsolete|                            |

--- Comment #77 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 97819
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97819&action=edit
Bug 23355: Add accountline deletion test

This patch adds a test to ensure database relations do not cascade
deletions when a cash register is deleted.

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 23 15:15:59 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Jan 2020 14:15:59 +0000
Subject: [Koha-bugs] [Bug 23355] Add 'cashup' process to the accounts system
In-Reply-To: <bug-23355-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23355-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23355-70-21V6H07Xx3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23355

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #97788|0                           |1
        is obsolete|                            |

--- Comment #78 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 97820
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97820&action=edit
Bug 23355: Link cash_register_actions to cash_registers by foreign key

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 23 15:16:02 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Jan 2020 14:16:02 +0000
Subject: [Koha-bugs] [Bug 23355] Add 'cashup' process to the accounts system
In-Reply-To: <bug-23355-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23355-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23355-70-zdpZvMylnf@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23355

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #97789|0                           |1
        is obsolete|                            |

--- Comment #79 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 97821
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97821&action=edit
Bug 23355: Split tests for Line vs Lines

This patch simply splits the existing tests for accountlines into two
test files, one for the singular object and one for the set.

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 23 15:16:06 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Jan 2020 14:16:06 +0000
Subject: [Koha-bugs] [Bug 23355] Add 'cashup' process to the accounts system
In-Reply-To: <bug-23355-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23355-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23355-70-YIGr1lWmQN@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23355

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #97790|0                           |1
        is obsolete|                            |

--- Comment #80 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 97822
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97822&action=edit
Bug 23355: Add register details page

This patch adds a new page which can be accessed via the menu to the
left of the point of sale page.  This new page displays a list of
transactions since the last 'cashup' action, a summary of transaction
amounts and a button to allow the recording of a new 'cashup action.

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 23 15:16:10 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Jan 2020 14:16:10 +0000
Subject: [Koha-bugs] [Bug 23355] Add 'cashup' process to the accounts system
In-Reply-To: <bug-23355-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23355-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23355-70-8IVmjU89Mg@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23355

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #97791|0                           |1
        is obsolete|                            |

--- Comment #81 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 97823
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97823&action=edit
Bug 23355: Add cashup permissions

Add new 'cashup' sub-permissions to the 'cash_management' permission to
allow fine grained control over whome may 'cashup' a cash register.

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 23 15:16:54 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Jan 2020 14:16:54 +0000
Subject: [Koha-bugs] [Bug 23355] Add 'cashup' process to the accounts system
In-Reply-To: <bug-23355-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23355-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23355-70-VxyV9UFsSN@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23355

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #97792|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 23 15:17:03 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Jan 2020 14:17:03 +0000
Subject: [Koha-bugs] [Bug 23355] Add 'cashup' process to the accounts system
In-Reply-To: <bug-23355-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23355-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23355-70-PQkutolAl0@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23355

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #97793|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 23 15:17:13 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Jan 2020 14:17:13 +0000
Subject: [Koha-bugs] [Bug 23355] Add 'cashup' process to the accounts system
In-Reply-To: <bug-23355-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23355-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23355-70-lDSOmmpBKm@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23355

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #97794|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 23 15:17:52 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Jan 2020 14:17:52 +0000
Subject: [Koha-bugs] [Bug 24476] Allow patrons to opt-out of Auto-renewal
In-Reply-To: <bug-24476-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24476-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24476-70-8guXcAbZ2Q@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24476

--- Comment #10 from Owen Leonard <oleonard at myacpl.org> ---
(In reply to Andrew Fuerste-Henry from comment #9)
> To Owen's concern, as is there isn't a way for the patron to opt out for
> themselves from the OPAC

They can submit the change via the same form they use to update their other
personal details. However, this reveals another bug: The request doesn't show
up in the staff client in the "Update patron records" page. It shows that a
request was made but doesn't list it.


> Following existing conventions, this sounds like two sysprefs and a new
> toggle on the category:
> IntranetAutoRenewOptOut
> OPACAutoRenewOptOut

Is there a need for the global preferences if the option can be configured at
the patron category level? Seems redundant.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 23 15:18:48 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Jan 2020 14:18:48 +0000
Subject: [Koha-bugs] [Bug 24492] Add a 'branch cashup' workflow to the point
 of sale system
In-Reply-To: <bug-24492-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24492-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24492-70-XymPVNUDEp@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24492

--- Comment #1 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 97824
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97824&action=edit
Bug 24492: Add branch details page

This patch adds a new 'branch details' page to the POS system which
displays a summary of the cash register transactions for a branch
since each register was last cashed up. It also allows for cashing
up individual registers or cashing up all registers at a given branch
in one transaction.

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 23 15:19:05 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Jan 2020 14:19:05 +0000
Subject: [Koha-bugs] [Bug 24492] Add a 'branch cashup' workflow to the point
 of sale system
In-Reply-To: <bug-24492-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24492-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24492-70-lg3VnrY0t3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24492

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 23 15:19:54 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Jan 2020 14:19:54 +0000
Subject: [Koha-bugs] [Bug 23594] Batch modification for itemtypes on
 suggestions page
In-Reply-To: <bug-23594-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23594-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23594-70-tNd8kXW83D@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23594

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 23 15:26:26 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Jan 2020 14:26:26 +0000
Subject: [Koha-bugs] [Bug 24476] Allow patrons to opt-out of Auto-renewal
In-Reply-To: <bug-24476-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24476-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24476-70-A2nljJIhvT@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24476

--- Comment #11 from Andrew Fuerste-Henry <andrew at bywatersolutions.com> ---
Whoops, right you are. Yeah, that doesn't exactly fit with the personal details
updating stuff. Maybe it needs to be broken out somehow? As we do with privacy
choices and messaging preferences?

I'm not married to the idea of a syspref AND a category configuration, that's
just how we've handled other things, like the ability to do a password reset.
On the one hand, it's nice to have one main switch for libraries that want all
their categories to behave the same. On the other hand, it's always good to
avoid making a syspref if possible.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 23 15:43:14 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Jan 2020 14:43:14 +0000
Subject: [Koha-bugs] [Bug 22359] Improve usability of 'change calculation'
 (bug 11373)
In-Reply-To: <bug-22359-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22359-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22359-70-MWhUIsNyN1@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22359

Andrew Fuerste-Henry <andrew at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |andrew at bywatersolutions.com

--- Comment #15 from Andrew Fuerste-Henry <andrew at bywatersolutions.com> ---
Giving this a bump for speedy QA and backport. We've got folks broadly confused
about what "Amount paid" and "Collect from patron" mean. Will put in a new bug
to consider alternate wording, but this patch would at least prevent them from
accidentally paying more than intended.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 23 15:47:03 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Jan 2020 14:47:03 +0000
Subject: [Koha-bugs] [Bug 24493] New: UsequeryParser wording in System
 Preference is not accurate
Message-ID: <bug-24493-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24493

            Bug ID: 24493
           Summary: UsequeryParser wording in System Preference is not
                    accurate
 Change sponsored?: ---
           Product: Koha
           Version: 19.05
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: System Administration
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: kelly at bywatersolutions.com
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com

According to the text associated with the system preference, UseQueryParser,
this TRY/Don'T Try option will not affect anything however, It does affect
searching.  

It would appear if a library does set this to TRY, it will have an impact as it
appears QueryParser is installed on Koha sites by default. 

Can we remove this text or add a different warning, such as "This will affect
all searching in KOha" 

Wording currently on system preference "to use the QueryParser module for
parsing queries. Please note: enabling this will have no impact if you do not
have QueryParser installed, and everything will continue to work as usual."

See https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18945

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 23 15:47:03 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Jan 2020 14:47:03 +0000
Subject: [Koha-bugs] [Bug 18945] UseQueryParser system preference breaks
 subject searches
In-Reply-To: <bug-18945-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18945-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18945-70-eHF2cdKXYK@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18945

Kelly McElligott <kelly at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=24493

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 23 15:48:41 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Jan 2020 14:48:41 +0000
Subject: [Koha-bugs] [Bug 22721] Normalize GetMarcFromKohaField calls
In-Reply-To: <bug-22721-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22721-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22721-70-sUL6xR0RMe@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22721

Oleg Vasilenko <synapse.ova at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |synapse.ova at gmail.com

--- Comment #12 from Oleg Vasilenko <synapse.ova at gmail.com> ---
Sorry, I have no time to open new bug. 

cataloguing/value_builder/barcode_manual.pl
lacks following line:

use C4::Biblio qw/GetMarcFromKohaField/;

Without this line, Internal server error occurs.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 23 15:52:48 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Jan 2020 14:52:48 +0000
Subject: [Koha-bugs] [Bug 24494] New: 00-valid-xml.t shouldn't check
 node_modules
Message-ID: <bug-24494-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24494

            Bug ID: 24494
           Summary: 00-valid-xml.t shouldn't check node_modules
 Change sponsored?: ---
           Product: Koha
           Version: unspecified
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Test Suite
          Assignee: chris at bigballofwax.co.nz
          Reporter: victor at tuxayo.net
        QA Contact: testopia at bugs.koha-community.org

node_modules exists when generating the CSS from the SCSS with yarn.

And it contains invalid XML file. Which shouldn't be validated by Koha's test
suite.

./node_modules/json-schema/draft-zyp-json-schema-03.xml
./node_modules/json-schema/draft-zyp-json-schema-04.xml

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 23 15:53:02 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Jan 2020 14:53:02 +0000
Subject: [Koha-bugs] [Bug 24494] 00-valid-xml.t shouldn't check node_modules
In-Reply-To: <bug-24494-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24494-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24494-70-moZEHO9q0B@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24494

Victor Grousset/tuxayo <victor at tuxayo.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|chris at bigballofwax.co.nz    |victor at tuxayo.net

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 23 15:53:08 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Jan 2020 14:53:08 +0000
Subject: [Koha-bugs] [Bug 24494] 00-valid-xml.t shouldn't check node_modules
In-Reply-To: <bug-24494-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24494-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24494-70-CAC2Qzifyw@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24494

Victor Grousset/tuxayo <victor at tuxayo.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 23 15:57:52 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Jan 2020 14:57:52 +0000
Subject: [Koha-bugs] [Bug 24495] New: Reword change collection feature
Message-ID: <bug-24495-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24495

            Bug ID: 24495
           Summary: Reword change collection feature
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: Fines and fees
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: andrew at bywatersolutions.com
        QA Contact: testopia at bugs.koha-community.org

We've had several libraries contact us with confusion over the new change
collection feature. Apparently the wording on "Amount paid" and "Collect from
patron" is not broadly intuitive. Opening this to consider alternate wording.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 23 15:58:36 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Jan 2020 14:58:36 +0000
Subject: [Koha-bugs] [Bug 24495] Reword change collection feature
In-Reply-To: <bug-24495-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24495-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24495-70-6myYZJ6JB7@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24495

Andrew Fuerste-Henry <andrew at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |kelly at bywatersolutions.com
         Depends on|                            |11373


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11373
[Bug 11373] Add "change calculation" feature to the fine payment forms
-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 23 15:58:36 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Jan 2020 14:58:36 +0000
Subject: [Koha-bugs] [Bug 11373] Add "change calculation" feature to the
 fine payment forms
In-Reply-To: <bug-11373-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-11373-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11373-70-RAcN0hLFIM@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11373

Andrew Fuerste-Henry <andrew at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |24495


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24495
[Bug 24495] Reword change collection feature
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 23 15:59:05 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Jan 2020 14:59:05 +0000
Subject: [Koha-bugs] [Bug 24495] Reword change collection feature
In-Reply-To: <bug-24495-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24495-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24495-70-NOB52OU0R7@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24495

Andrew Fuerste-Henry <andrew at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |bwsdonna at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 23 16:01:42 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Jan 2020 15:01:42 +0000
Subject: [Koha-bugs] [Bug 24496] New: Add ability to disable change
 calculation
Message-ID: <bug-24496-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24496

            Bug ID: 24496
           Summary: Add ability to disable change calculation
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: Fines and fees
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: andrew at bywatersolutions.com
        QA Contact: testopia at bugs.koha-community.org

Some libraries would like to simply disable change calculation entirely. It can
be hidden with jQuery, but some way to actually turn it off would be
preferable.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 23 16:02:04 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Jan 2020 15:02:04 +0000
Subject: [Koha-bugs] [Bug 24496] Add ability to disable change calculation
In-Reply-To: <bug-24496-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24496-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24496-70-Ngsk1jOgYF@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24496

Andrew Fuerste-Henry <andrew at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |11373


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11373
[Bug 11373] Add "change calculation" feature to the fine payment forms
-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 23 16:02:04 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Jan 2020 15:02:04 +0000
Subject: [Koha-bugs] [Bug 11373] Add "change calculation" feature to the
 fine payment forms
In-Reply-To: <bug-11373-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-11373-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11373-70-zYqy5koXTX@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11373

Andrew Fuerste-Henry <andrew at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |24496


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24496
[Bug 24496] Add ability to disable change calculation
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 23 16:03:19 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Jan 2020 15:03:19 +0000
Subject: [Koha-bugs] [Bug 24496] Add ability to disable change calculation
In-Reply-To: <bug-24496-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24496-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24496-70-RSaC63RSXw@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24496

Andrew Fuerste-Henry <andrew at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |bwsdonna at gmail.com,
                   |                            |kelly at bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 23 16:09:43 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Jan 2020 15:09:43 +0000
Subject: [Koha-bugs] [Bug 24494] 00-valid-xml.t shouldn't check node_modules
In-Reply-To: <bug-24494-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24494-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24494-70-1ikvnSCiym@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24494

--- Comment #1 from Victor Grousset/tuxayo <victor at tuxayo.net> ---
Created attachment 97825
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97825&action=edit
Bug 24494: tests: 00-valid-xml.t shouldn't check node_modules

== Test plan ==
- work with SCSS (just recompile it if you never did)
  - https://wiki.koha-community.org/wiki/Working_with_staff_client_SCSS
- now you have a node_modules directory
- prove -r t/00-valid-xml.t
- it should fail on files in node_modules
- apply this patch
- prove -r t/00-valid-xml.t
- it should work
- sabotage a legitimate XML file, like etc/SIPconfig.xml
- prove -r t/00-valid-xml.t
- it should fail, good the test is still useful
- undo the sabotage

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 23 16:10:11 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Jan 2020 15:10:11 +0000
Subject: [Koha-bugs] [Bug 24494] 00-valid-xml.t shouldn't check node_modules
In-Reply-To: <bug-24494-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24494-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24494-70-FkQKWuRlzr@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24494

Victor Grousset/tuxayo <victor at tuxayo.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 23 16:20:13 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Jan 2020 15:20:13 +0000
Subject: [Koha-bugs] [Bug 18936] Convert issuingrules fields to
 circulation_rules
In-Reply-To: <bug-18936-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18936-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18936-70-QxSKmjjRH5@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18936

--- Comment #94 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Testers should consider using the branch bug_18936 from my koha-misc4dev repo
to fix reset_all: https://gitlab.com/joubu/koha-misc4dev/commits/bug_18936
Will be cleaned and merged into master when these patches will be pushed.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 23 16:21:02 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Jan 2020 15:21:02 +0000
Subject: [Koha-bugs] [Bug 24495] Reword change collection feature
In-Reply-To: <bug-24495-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24495-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24495-70-M67UUEXIdh@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24495

Sally <sally.healey at cheshiresharedservices.gov.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |sally.healey at cheshireshared
                   |                            |services.gov.uk

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 23 16:23:45 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Jan 2020 15:23:45 +0000
Subject: [Koha-bugs] [Bug 22359] Improve usability of 'change calculation'
 (bug 11373)
In-Reply-To: <bug-22359-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22359-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22359-70-XuGIkUwKnA@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22359

--- Comment #16 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
(In reply to Andrew Fuerste-Henry from comment #15)
> Giving this a bump for speedy QA and backport. We've got folks broadly
> confused about what "Amount paid" and "Collect from patron" mean. Will put
> in a new bug to consider alternate wording, but this patch would at least
> prevent them from accidentally paying more than intended.

Did you test the patch? Could you add your stamp on it?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 23 16:29:56 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Jan 2020 15:29:56 +0000
Subject: [Koha-bugs] [Bug 24497] New: CodeMirror should be a sys pref
Message-ID: <bug-24497-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24497

            Bug ID: 24497
           Summary: CodeMirror should be a sys pref
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Tools
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: lucas at bywatersolutions.com
        QA Contact: testopia at bugs.koha-community.org

Some librarians would like the ability to turn CodeMirror off in the sys prefs
like OPACUserJS, IntranetUserCSS, etc.

An option to disable it via syspref would be nice.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 23 16:44:46 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Jan 2020 15:44:46 +0000
Subject: [Koha-bugs] [Bug 24497] CodeMirror should be a sys pref
In-Reply-To: <bug-24497-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24497-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24497-70-G96XC671gt@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24497

--- Comment #1 from Owen Leonard <oleonard at myacpl.org> ---
I would like to know more about why they want to disable it. Wanting to turn it
off may mean it's not working well in a way that we can address.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 23 16:47:08 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Jan 2020 15:47:08 +0000
Subject: [Koha-bugs] [Bug 22359] Improve usability of 'change calculation'
 (bug 11373)
In-Reply-To: <bug-22359-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22359-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22359-70-M0W90M6cGd@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22359

Andrew Fuerste-Henry <andrew at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Failed QA

--- Comment #17 from Andrew Fuerste-Henry <andrew at bywatersolutions.com> ---
Just tested, this did not work for me. What I did:
- Create manual invoice for $100
- Click Pay on that specific fee
- Leave amount paid at $100
- Set collect from patron to $50
- Submit payment
- Koha marks the entire fine as paid off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 23 17:21:54 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Jan 2020 16:21:54 +0000
Subject: [Koha-bugs] [Bug 24082] Add a 'refund' option to anonymous payments
In-Reply-To: <bug-24082-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24082-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24082-70-RNV9pJTBsP@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24082

--- Comment #2 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 97826
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97826&action=edit
Bug 24082: Add `anonymous_refund` permission to `cash_management`

This patch adds the new `anonymous_refund` permission to the
`cash_management` flag and binds it to the visability of the register
details page.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 23 17:21:57 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Jan 2020 16:21:57 +0000
Subject: [Koha-bugs] [Bug 24082] Add a 'refund' option to anonymous payments
In-Reply-To: <bug-24082-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24082-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24082-70-nz8qIRGv46@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24082

--- Comment #3 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 97827
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97827&action=edit
Bug 24082: Add refund action to relevant lines

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 23 17:21:59 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Jan 2020 16:21:59 +0000
Subject: [Koha-bugs] [Bug 24082] Add a 'refund' option to anonymous payments
In-Reply-To: <bug-24082-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24082-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24082-70-cXDydpUNdZ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24082

--- Comment #4 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 97828
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97828&action=edit
Bug 24082: Add access to historical transactions

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 23 17:22:22 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Jan 2020 16:22:22 +0000
Subject: [Koha-bugs] [Bug 24082] Add a 'refund' option to anonymous payments
In-Reply-To: <bug-24082-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24082-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24082-70-wsSFZWqqAK@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24082

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #97042|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 23 17:22:30 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Jan 2020 16:22:30 +0000
Subject: [Koha-bugs] [Bug 24082] Add a 'refund' option to anonymous payments
In-Reply-To: <bug-24082-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24082-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24082-70-CD4IAauUzf@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24082

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 23 17:27:38 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Jan 2020 16:27:38 +0000
Subject: [Koha-bugs] [Bug 24305] Batch Item modification via item number in
 reports does not work with CONCAT in report
In-Reply-To: <bug-24305-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24305-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24305-70-YelpRmV6wy@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24305

ByWater Sandboxes <bws.sandboxes at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #97302|0                           |1
        is obsolete|                            |

--- Comment #5 from ByWater Sandboxes <bws.sandboxes at gmail.com> ---
Created attachment 97829
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97829&action=edit
Bug 24305: Remove previous declaration of batch_biblionumbers

We should not init batch_biblionumbers before.
Also this patch deals with batch_cardnumbers.

Signed-off-by: Holly Cooper <hc at interleaf.ie>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 23 17:28:03 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Jan 2020 16:28:03 +0000
Subject: [Koha-bugs] [Bug 24305] Batch Item modification via item number in
 reports does not work with CONCAT in report
In-Reply-To: <bug-24305-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24305-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24305-70-xiQvpvuu8u@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24305

Holly <hc at interleaf.ie> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 23 17:39:39 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Jan 2020 16:39:39 +0000
Subject: [Koha-bugs] [Bug 20235] Telegram notifications
In-Reply-To: <bug-20235-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20235-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20235-70-GW62jxUTpT@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20235

Michal Denar <black23 at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |black23 at gmail.com

--- Comment #4 from Michal Denar <black23 at gmail.com> ---
+1

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 23 17:40:07 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Jan 2020 16:40:07 +0000
Subject: [Koha-bugs] [Bug 20235] Telegram notifications
In-Reply-To: <bug-20235-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20235-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20235-70-yBhSHXaZOc@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20235

--- Comment #5 from Michal Denar <black23 at gmail.com> ---
https://metacpan.org/pod/WWW::Telegram::BotAPI

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 23 17:56:53 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Jan 2020 16:56:53 +0000
Subject: [Koha-bugs] [Bug 24498] New: CSV profile for patron export
Message-ID: <bug-24498-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24498

            Bug ID: 24498
           Summary: CSV profile for patron export
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Tools
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: caroline.cyr-la-rose at inlibro.com
        QA Contact: testopia at bugs.koha-community.org

Right now, SQL CSV profiles are only available for some specific uses (serials,
acquisitions and one report). It would be great if profiles could also be
created for patron exports (from patron lists or a patron search).

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 23 17:57:10 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Jan 2020 16:57:10 +0000
Subject: [Koha-bugs] [Bug 23702] New UNIMARC XSLT according to last IFLA
 updates
In-Reply-To: <bug-23702-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23702-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23702-70-XfNn8URb81@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23702

--- Comment #23 from Koha Team University Lyon 3 <koha at univ-lyon3.fr> ---
Created attachment 97830
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97830&action=edit
Bug 23702 - New UNIMARC XSLT according to last IFLA updates

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 23 18:11:52 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Jan 2020 17:11:52 +0000
Subject: [Koha-bugs] [Bug 24499] New: sys pref EnhancedMessagingPreferences
 if set to Don't Allow does not even show within Patron Categories
Message-ID: <bug-24499-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24499

            Bug ID: 24499
           Summary: sys pref EnhancedMessagingPreferences if set to Don't
                    Allow does not even show within Patron Categories
 Change sponsored?: ---
           Product: Koha
           Version: 19.05
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: System Administration
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: kelly at bywatersolutions.com
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com

The system preference EnhancedMessagingPreferences, which allows or doesn't
allow for staff to see patron's messaging preferences. If Don't Allow, staff
cannot see a specific patron's message preferences. If set to Don't Allow, this
also hides the overall Messaging Preferences for Patron Categories in Admin, 

It would be extremely helpful for the Messaging Preferences to still be seen in
the Admin - Patron Categories and a place to view what patrons are defaulting
to be set up.  Understanding that general staff can't see a specific patron's
messaging preferences, but admin can see what patron categories are set up for.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 23 18:15:54 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Jan 2020 17:15:54 +0000
Subject: [Koha-bugs] [Bug 24490] Clarify wording and function of Purchase
 Items link on POS
In-Reply-To: <bug-24490-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24490-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24490-70-sgg9A0jDw0@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24490

David Roberts <david.roberts at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |david.roberts at ptfs-europe.c
                   |ity.org                     |om
                 CC|                            |david.roberts at ptfs-europe.c
                   |                            |om

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 23 18:24:54 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Jan 2020 17:24:54 +0000
Subject: [Koha-bugs] [Bug 23702] New UNIMARC XSLT according to last IFLA
 updates
In-Reply-To: <bug-23702-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23702-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23702-70-EZfwviY7Iv@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23702

Koha Team University Lyon 3 <koha at univ-lyon3.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Failed QA

--- Comment #24 from Koha Team University Lyon 3 <koha at univ-lyon3.fr> ---
Tried to apply the patch on a sandbox but it seems that there still some issues
on the xslt files :
- I don't see any bilbio information on the result pages (just place hold,
request articles..)
- in the detail page on intranet the link to see the biblio in the OPAC doesn't
work

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 23 18:46:29 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Jan 2020 17:46:29 +0000
Subject: [Koha-bugs] [Bug 24380] Backdated returns do not update fines
 unless CalculateFinesOnReturn is enabled
In-Reply-To: <bug-24380-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24380-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24380-70-Gl05HQSgUo@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24380

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         QA Contact|testopia at bugs.koha-communit |tomascohen at gmail.com
                   |y.org                       |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 23 18:52:22 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Jan 2020 17:52:22 +0000
Subject: [Koha-bugs] [Bug 24476] Allow patrons to opt-out of Auto-renewal
In-Reply-To: <bug-24476-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24476-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24476-70-lgt9lAEgj5@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24476

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 23 18:52:24 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Jan 2020 17:52:24 +0000
Subject: [Koha-bugs] [Bug 24476] Allow patrons to opt-out of Auto-renewal
In-Reply-To: <bug-24476-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24476-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24476-70-3iHoFAi5Vf@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24476

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #97766|0                           |1
        is obsolete|                            |
  Attachment #97767|0                           |1
        is obsolete|                            |
  Attachment #97768|0                           |1
        is obsolete|                            |
  Attachment #97769|0                           |1
        is obsolete|                            |
  Attachment #97770|0                           |1
        is obsolete|                            |

--- Comment #12 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 97831
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97831&action=edit
Bug 24476: Database updates

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 23 18:52:27 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Jan 2020 17:52:27 +0000
Subject: [Koha-bugs] [Bug 24476] Allow patrons to opt-out of Auto-renewal
In-Reply-To: <bug-24476-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24476-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24476-70-VRpC9ilLnH@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24476

--- Comment #13 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 97832
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97832&action=edit
Bug 24476: API Updates

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 23 18:52:30 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Jan 2020 17:52:30 +0000
Subject: [Koha-bugs] [Bug 24476] Allow patrons to opt-out of Auto-renewal
In-Reply-To: <bug-24476-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24476-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24476-70-NwjZylPVLo@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24476

--- Comment #14 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 97833
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97833&action=edit
Bug 24476: Change CanBookBeRenewed and adjust tests

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 23 18:52:32 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Jan 2020 17:52:32 +0000
Subject: [Koha-bugs] [Bug 24476] Allow patrons to opt-out of Auto-renewal
In-Reply-To: <bug-24476-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24476-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24476-70-IyORVkGjFq@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24476

--- Comment #15 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 97834
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97834&action=edit
Bug 24476: Allow patrons to opt out of auto-renewal

To test:
1 - Verify on staff side that patron can be edited to opt in our out of auto
renewal
2 - Check out some items to a patron opted in to auto renewal
3 - Ensure the items are checked out and set to autorenew
4 - Login on the opac at the patron
5 - Verify items cannot be renewed as scheduled for auto-renewal
6 - On staff side, opt patron out of auto renewal
7 - Verify on opac items are no longer marked for auto renewal
8 - Run the auto renewal cron job, items are not renewed
9 - Set 'no renewal before' to a setting that would prevent renewal
10 - Verify that opting patron in or out of auto renewal changes only the
reason items cannot be renewed
11 - Set 'no renewal before' to a setting that would allow for renewal
12 - Verify that opting patron in/out changes their ability to renew
13 - Verify that when opted out cron does not renew
14 - Verify that when opted in the item is auto renewed
15 - Reset the due date, opt out, verify manual renewal succeeds

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 23 18:52:35 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Jan 2020 17:52:35 +0000
Subject: [Koha-bugs] [Bug 24476] Allow patrons to opt-out of Auto-renewal
In-Reply-To: <bug-24476-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24476-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24476-70-EVjTVcbrW0@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24476

--- Comment #16 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 97835
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97835&action=edit
Bug 24476: DO NOT PUSH - Schema updates

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 23 18:52:38 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Jan 2020 17:52:38 +0000
Subject: [Koha-bugs] [Bug 24476] Allow patrons to opt-out of Auto-renewal
In-Reply-To: <bug-24476-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24476-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24476-70-oYjilMDJrJ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24476

--- Comment #17 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 97836
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97836&action=edit
Bug 24476: Add boolean for all TINYINT

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 23 18:57:04 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Jan 2020 17:57:04 +0000
Subject: [Koha-bugs] [Bug 24476] Allow patrons to opt-out of Auto-renewal
In-Reply-To: <bug-24476-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24476-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24476-70-lXX9Cm4jNW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24476

--- Comment #18 from Nick Clemens <nick at bywatersolutions.com> ---
I rewrote the column to be a positive instead of negative - all patrons are
'opted in' then can prevent autorenewal

I altered the update to automatically add this field to the unwanted prefs for
opac update and self-reg.

I still need to address the column not showing up on patron update requests

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 23 19:17:01 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Jan 2020 18:17:01 +0000
Subject: [Koha-bugs] [Bug 21674] Data integrity not enforced for library
 groups
In-Reply-To: <bug-21674-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21674-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21674-70-rJVYfAob0m@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21674

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 23 19:17:04 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Jan 2020 18:17:04 +0000
Subject: [Koha-bugs] [Bug 21674] Data integrity not enforced for library
 groups
In-Reply-To: <bug-21674-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21674-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21674-70-8zDWnYfSks@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21674

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #96199|0                           |1
        is obsolete|                            |
  Attachment #97658|0                           |1
        is obsolete|                            |
  Attachment #97811|0                           |1
        is obsolete|                            |

--- Comment #11 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 97837
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97837&action=edit
Bug 21674: DB changes

Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 23 19:17:06 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Jan 2020 18:17:06 +0000
Subject: [Koha-bugs] [Bug 21674] Data integrity not enforced for library
 groups
In-Reply-To: <bug-21674-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21674-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21674-70-hzQr35hWMe@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21674

--- Comment #12 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 97838
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97838&action=edit
Bug 21674: Prevent to insert twice the same library in a group

You can create hierarchical groups of libraries you are not allowed to add
several times the same library to a given group/subgroup. The libraries
that are part of the group is not displayed on the interface, to prevent
the user to select it.

However this restriction is only done template-side, the controller and
module does not handle it.

To prevent that this patchset enforces the constraint at DB level, and
display a message to the end user.

Test plan:
- Go to Home › Administration › Library groups
- Add a group
- Add a library
- reload the page several times
=> Without this patch the same library appears several times in the group
=> With this patch applied you will see a friendly error message

Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 23 19:17:09 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Jan 2020 18:17:09 +0000
Subject: [Koha-bugs] [Bug 21674] Data integrity not enforced for library
 groups
In-Reply-To: <bug-21674-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21674-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21674-70-4xj1tB1c1s@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21674

--- Comment #13 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 97839
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97839&action=edit
Bug 21674: Remove duplicates from library_groups before adding the uniq
constraint

To avoid to make it fails if duplicates existed prior to this change

Credit for the SQL query goes to Nick, thanks!

Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 23 19:17:38 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Jan 2020 18:17:38 +0000
Subject: [Koha-bugs] [Bug 23092] Transfers should record 'requested' as well
 as 'sent' and 'arrived' dates.
In-Reply-To: <bug-23092-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23092-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23092-70-oK7vGvEtL0@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23092

Sally <sally.healey at cheshiresharedservices.gov.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |sally.healey at cheshireshared
                   |                            |services.gov.uk

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 23 19:28:23 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Jan 2020 18:28:23 +0000
Subject: [Koha-bugs] [Bug 18895] Lost Items Not Removed From Patron's
 Account When Charge is Paid
In-Reply-To: <bug-18895-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18895-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18895-70-mXBIMDgvFD@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18895

--- Comment #2 from Azucena Aguayo <azucena.aguayo at uvu.edu> ---
If Koha has X ways to set an item to lost
And X ways to pay for the lost fee
Then shouldn't the result be the same: fee paid > item off the patron account


Our library cares about this bug. Having to use the 'pay' button for each fee
on a patron account is tedious and time consuming.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 23 19:28:33 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Jan 2020 18:28:33 +0000
Subject: [Koha-bugs] [Bug 24500] New: Cancelling a hold at the same time
 produces internal server error
Message-ID: <bug-24500-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24500

            Bug ID: 24500
           Summary: Cancelling a hold at the same time produces internal
                    server error
 Change sponsored?: ---
           Product: Koha
           Version: unspecified
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Hold requests
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: cbrannon at cdalibrary.org
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com

Need to have a page for holds (and probably other instances) where an object
you are working with is no longer available.  Maybe something like a "Whoops!"
page (the item you are working with is no longer available), rather than having
a default internal server error page.  We should trap these kinds of issues
better.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 23 19:32:45 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Jan 2020 18:32:45 +0000
Subject: [Koha-bugs] [Bug 23091] Restore Forgiven Overdue Fines When Lost
 Item Returned
In-Reply-To: <bug-23091-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23091-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23091-70-MHi7ZwuFMF@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23091

Azucena Aguayo <azucena.aguayo at uvu.edu> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |azucena.aguayo at uvu.edu

--- Comment #5 from Azucena Aguayo <azucena.aguayo at uvu.edu> ---
Where is the test plan?

Or should the "Needs Signoff" be changed to some other status?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 23 19:37:05 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Jan 2020 18:37:05 +0000
Subject: [Koha-bugs] [Bug 22042] BlockReturnofWithdrawn Items does not block
 refund generation when item is withdrawn and lost
In-Reply-To: <bug-22042-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22042-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22042-70-wyW5Znrb0x@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22042

Azucena Aguayo <azucena.aguayo at uvu.edu> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |azucena.aguayo at uvu.edu

--- Comment #2 from Azucena Aguayo <azucena.aguayo at uvu.edu> ---
This is a problematic bug for our library.

We've been on Koha for a few months and have just encounter this bug.

We use this setting to prevent our employees from check in items that our
library cannot accept back. Either due to a no refund policy or due to
collection agency rules.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 23 19:49:01 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Jan 2020 18:49:01 +0000
Subject: [Koha-bugs] [Bug 24501] New: Authorities 'merge' is confusing
Message-ID: <bug-24501-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24501

            Bug ID: 24501
           Summary: Authorities 'merge' is confusing
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: MARC Authority data support
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: nick at bywatersolutions.com
        QA Contact: testopia at bugs.koha-community.org

While authority updates sometimes happen because of the merging of authorities,
authority record edits also cause a need to 'merge'

Perhaps the cronjob and sysprefs should refer to 'updating' authorities?

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 23 19:49:11 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Jan 2020 18:49:11 +0000
Subject: [Koha-bugs] [Bug 24501] Authorities 'merge' is confusing
In-Reply-To: <bug-24501-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24501-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24501-70-J40iMUtg5i@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24501

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |andrew at bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 23 20:09:38 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Jan 2020 19:09:38 +0000
Subject: [Koha-bugs] [Bug 24476] Allow patrons to opt-out of Auto-renewal
In-Reply-To: <bug-24476-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24476-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24476-70-wopgxlGvWD@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24476

Andrew Fuerste-Henry <andrew at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Failed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 23 20:24:52 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Jan 2020 19:24:52 +0000
Subject: [Koha-bugs] [Bug 24501] Authorities 'merge' is confusing
In-Reply-To: <bug-24501-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24501-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24501-70-enzB6scM4N@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24501

--- Comment #1 from Andrew Fuerste-Henry <andrew at bywatersolutions.com> ---
There's a function within Koha two take two authority records and combine them
into one authority record. Koha refers to this as merging. That's a good name
for that and doesn't confuse people.

But then there's also a cron job that takes changes made to authority records
and pushes them out to bibs. Koha also refers to this as merging. This *does*
confuse people. They see a cron called "merge_authorities.pl" and assume it's
going to clean up duplicate authorities or something.

So I'd propose renaming the cron and the various system preferences that refer
to the cron, though I understand that's a change to a very well-established
Koha feature.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 23 21:35:56 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Jan 2020 20:35:56 +0000
Subject: [Koha-bugs] [Bug 22359] Improve usability of 'change calculation'
 (bug 11373)
In-Reply-To: <bug-22359-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22359-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22359-70-Pqjm2ig8sk@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22359

Michal Denar <black23 at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Needs Signoff

--- Comment #18 from Michal Denar <black23 at gmail.com> ---
Field "Collected from patron" is used for calculation how much change back to
patron if pay more that "Amount being paid". This patch don't solve situation
if librarian want to make partial write off (Collected from patron < Amount
being paid). From my point of view patch works.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 23 21:36:40 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Jan 2020 20:36:40 +0000
Subject: [Koha-bugs] [Bug 22359] Improve usability of 'change calculation'
 (bug 11373)
In-Reply-To: <bug-22359-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22359-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22359-70-ZK3YkVf5xO@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22359

Michal Denar <black23 at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 23 21:36:43 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Jan 2020 20:36:43 +0000
Subject: [Koha-bugs] [Bug 22359] Improve usability of 'change calculation'
 (bug 11373)
In-Reply-To: <bug-22359-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22359-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22359-70-ivMoggK6KT@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22359

Michal Denar <black23 at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #97229|0                           |1
        is obsolete|                            |

--- Comment #19 from Michal Denar <black23 at gmail.com> ---
Created attachment 97840
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97840&action=edit
Bug 22359: Improvements to payment collection inputs

This patch attempts to clarify the uses of the various input fields on
the paycollect screens.

It does this by adding validation to the form such that entering a
'collected' value that is lower than the 'paid' value is now forbidden.

Signed-off-by: Michal Denar <black23 at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 23 21:49:33 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Jan 2020 20:49:33 +0000
Subject: [Koha-bugs] [Bug 23260] Anonymize (remove) patron data from
 items_last_borrower
In-Reply-To: <bug-23260-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23260-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23260-70-kQgcK7CDgq@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23260

Agustín Moyano <agustinmoyano at theke.io> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Patch doesn't apply         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 23 21:49:38 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Jan 2020 20:49:38 +0000
Subject: [Koha-bugs] [Bug 23260] Anonymize (remove) patron data from
 items_last_borrower
In-Reply-To: <bug-23260-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23260-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23260-70-dN0b80Xotn@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23260

Agustín Moyano <agustinmoyano at theke.io> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #95769|0                           |1
        is obsolete|                            |
  Attachment #95770|0                           |1
        is obsolete|                            |
  Attachment #95771|0                           |1
        is obsolete|                            |
  Attachment #95772|0                           |1
        is obsolete|                            |
  Attachment #96791|0                           |1
        is obsolete|                            |

--- Comment #57 from Agustín Moyano <agustinmoyano at theke.io> ---
Created attachment 97841
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97841&action=edit
Bug 23260: Make borrowernumber nullable in items_last_borrower

This patch alters table structure to make borrowernumber nullable

Sponsored-by: Northeast Kansas Library System

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 23 21:49:43 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Jan 2020 20:49:43 +0000
Subject: [Koha-bugs] [Bug 23260] Anonymize (remove) patron data from
 items_last_borrower
In-Reply-To: <bug-23260-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23260-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23260-70-TsD9uU0UqO@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23260

--- Comment #58 from Agustín Moyano <agustinmoyano at theke.io> ---
Created attachment 97842
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97842&action=edit
Bug 23260: Inline code to anonymise_issue_history

This alternative patch reduces the complexity of the change by simply
updateing the existing anonymise_issue_history method to include
anonymisation of the items_last_borrowers table.

To test:
1) apply this patch and the previous one
2) perl installer/data/mysql/updatedatabase.pl
3) set StoreLastBorrower preference to Allow.
4) set AnonymousPatron preference to a valid patron id
5) Create a Check out followed by a Check in.
CHECK => a row should appear in items_last_borrower table with the borrower and
the item number.
6) In mysql, update created_on of items_last_borrower and returndate of
old_issues to two days earlier.
7) perl misc/cronjobs/batch_anonymise.pl --days 1
SUCCESS => borrower number in items_last_borrower changed to AnonymousPatron id
8) repeat steps 5 and 6
9) set AnonymousPatron preference to 0
10) perl misc/cronjobs/batch_anonymise.pl --days 1
SUCCESS => borrower number in items_last_borrower changed to null
11) prove t/db_dependent/Koha/Patrons.t
12) Sign off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 23 22:58:53 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Jan 2020 21:58:53 +0000
Subject: [Koha-bugs] [Bug 22359] Improve usability of 'change calculation'
 (bug 11373)
In-Reply-To: <bug-22359-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22359-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22359-70-8wdlRJ0B2X@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22359

--- Comment #20 from Andrew Fuerste-Henry <andrew at bywatersolutions.com> ---
(In reply to Michal Denar from comment #19)
Michal, I'm having trouble reconciling what you say in comment #18 and what you
say in comment #19. 
In #18 you say "This patch don't solve situation if librarian want to make
partial write off (Collected from patron < Amount being paid)." I read that as
you saying amount collected *should* be allowed to be less than amount being
paid.
In #19 you say "It does this by adding validation to the form such that
entering a
'collected' value that is lower than the 'paid' value is now forbidden." I read
that as you saying amount collected *should not* be allowed to be less than
amount being paid.
So I'm not understanding something.

Right now, with this patch applied I am still able to make a payment where
amount being paid is $10 and amount collected is $5. Koha treats this as a
payment of $10. It does not in any way indicate that I have taken actual
payment for $5 and essentially forgiven the other $5. I think this makes for
very misleading bookkeeping.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 23 23:22:32 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Jan 2020 22:22:32 +0000
Subject: [Koha-bugs] [Bug 20447] Add support for MARC holdings records
In-Reply-To: <bug-20447-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20447-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20447-70-XPPapkHsZs@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447

Michal Denar <black23 at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 23 23:22:37 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Jan 2020 22:22:37 +0000
Subject: [Koha-bugs] [Bug 20447] Add support for MARC holdings records
In-Reply-To: <bug-20447-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20447-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20447-70-8zfWgNm7hV@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447

Michal Denar <black23 at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #97797|0                           |1
        is obsolete|                            |
  Attachment #97798|0                           |1
        is obsolete|                            |
  Attachment #97799|0                           |1
        is obsolete|                            |
  Attachment #97800|0                           |1
        is obsolete|                            |

--- Comment #160 from Michal Denar <black23 at gmail.com> ---
Created attachment 97843
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97843&action=edit
Bug 20447: MARC Holdings support

Enable by setting "SummaryHoldings" option to "Use".

Sponsored-by: The National Library of Finland

Signed-off-by: Michal Denar <black23 at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 23 23:22:44 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Jan 2020 22:22:44 +0000
Subject: [Koha-bugs] [Bug 20447] Add support for MARC holdings records
In-Reply-To: <bug-20447-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20447-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20447-70-IGGkwbjpZV@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447

--- Comment #161 from Michal Denar <black23 at gmail.com> ---
Created attachment 97844
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97844&action=edit
Bug 20447: Add a batch rebuild script for holdings table.

This script can be used to update the columns in the holdings table from the
MARC record using the rules in the framework. In practice this will only be
required if the koha link field is changed in the framework.

Signed-off-by: Michal Denar <black23 at gmail.com>

Signed-off-by: Michal Denar <black23 at gmail.com>

Signed-off-by: Michal Denar <black23 at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 23 23:22:50 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Jan 2020 22:22:50 +0000
Subject: [Koha-bugs] [Bug 20447] Add support for MARC holdings records
In-Reply-To: <bug-20447-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20447-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20447-70-eqkln9FoJu@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447

--- Comment #162 from Michal Denar <black23 at gmail.com> ---
Created attachment 97845
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97845&action=edit
Bug 20447: Add import/export support for holdings

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447

Adds support for importing and exporting biblios with interleaved holdings.

Test plan:

1.) Import the MARCXML file attached to the bug with the -holdings parameter:
misc/migration_tools/bulkmarcimport.pl -biblios -holdings -file holdings.xml -m
MARCXML

2.) Verify that the holdings records were imported.

3.) Export the same records with holdings:
misc/export_records.pl --record-type=bibs --starting_biblionumber 103
--ending_biblionumber 104 --filename=holdings_export.xml --format=xml
--holdings

4.) Verify that both bibliographic and holding records are exported.

5.) Verify that tests in t/db_dependent/Exporter/Record.t pass.

Signed-off-by: Michal Denar <black23 at gmail.com>

Signed-off-by: Michal Denar <black23 at gmail.com>

Signed-off-by: Michal Denar <black23 at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 23 23:22:55 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Jan 2020 22:22:55 +0000
Subject: [Koha-bugs] [Bug 20447] Add support for MARC holdings records
In-Reply-To: <bug-20447-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20447-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20447-70-9gQJbpIYtj@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447

--- Comment #163 from Michal Denar <black23 at gmail.com> ---
Created attachment 97846
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97846&action=edit
Bug 20447: DBIX schema changes

Signed-off-by: Michal Denar <black23 at gmail.com>

Signed-off-by: Michal Denar <black23 at gmail.com>

Signed-off-by: Michal Denar <black23 at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 23 23:33:09 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Jan 2020 22:33:09 +0000
Subject: [Koha-bugs] [Bug 22245] MARC modification templates does not allow
 move or copy control fields
In-Reply-To: <bug-22245-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22245-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22245-70-LOk1KYVhFJ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22245

Hayley Mapley <hayleymapley at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 23 23:33:12 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Jan 2020 22:33:12 +0000
Subject: [Koha-bugs] [Bug 22245] MARC modification templates does not allow
 move or copy control fields
In-Reply-To: <bug-22245-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22245-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22245-70-7uaLp4CPoO@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22245

Hayley Mapley <hayleymapley at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #85209|0                           |1
        is obsolete|                            |

--- Comment #8 from Hayley Mapley <hayleymapley at catalyst.net.nz> ---
Created attachment 97847
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97847&action=edit
Bug 22245: Allow copy/move from and to control fields

The JS conditions were wrong, we want to allow copy and move between
control fields.

Test plan:
Create a new MARC modification template action using control fields.
Confirm that you are allowed to copy/move a control field to another one

Signed-off-by: Hayley Mapley <hayleymapley at catalyst.net.nz>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 23 23:43:31 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Jan 2020 22:43:31 +0000
Subject: [Koha-bugs] [Bug 22359] Improve usability of 'change calculation'
 (bug 11373)
In-Reply-To: <bug-22359-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22359-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22359-70-4OfF3koNXu@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22359

--- Comment #21 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
I'm investigating this at the moment as I'm also now seeing some very strange
behaviour.. I think something may have gone awry in the rebase.

The intention was indeed to prevent collection of less than payment prescribed.

The validation routines seems to break on decimals is where I'm at currently..

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 23 23:43:44 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Jan 2020 22:43:44 +0000
Subject: [Koha-bugs] [Bug 22359] Improve usability of 'change calculation'
 (bug 11373)
In-Reply-To: <bug-22359-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22359-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22359-70-XTcRJItYkF@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22359

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |ASSIGNED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 23 23:47:58 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Jan 2020 22:47:58 +0000
Subject: [Koha-bugs] [Bug 24496] Add ability to disable change calculation
In-Reply-To: <bug-24496-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24496-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24496-70-EoIYbQuDKW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24496

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de

--- Comment #1 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
+1 not a fan of the extra work it creates here as well.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 23 23:51:23 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Jan 2020 22:51:23 +0000
Subject: [Koha-bugs] [Bug 24493] UsequeryParser wording in System Preference
 is not accurate
In-Reply-To: <bug-24493-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24493-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24493-70-CzMs6xzOYn@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24493

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de

--- Comment #1 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Hi Kelly, I think you are right, at least the second part should be removed.
But I'd like to suggest something else: Remove QueryParser.

There are so many problems with it and it doesn't look like anyone will spend
the time to fix them (see bug 12742 and linked bugs)

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 23 23:51:41 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Jan 2020 22:51:41 +0000
Subject: [Koha-bugs] [Bug 24493] UsequeryParser wording in System Preference
 is not accurate
In-Reply-To: <bug-24493-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24493-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24493-70-p9m3SptfG8@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24493

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |12742


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12742
[Bug 12742] Omnibus: QueryParser
-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 23 23:51:41 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Jan 2020 22:51:41 +0000
Subject: [Koha-bugs] [Bug 12742] Omnibus: QueryParser
In-Reply-To: <bug-12742-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-12742-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12742-70-CQs5U5156S@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12742

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |24493


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24493
[Bug 24493] UsequeryParser wording in System Preference is not accurate
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 23 23:53:36 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Jan 2020 22:53:36 +0000
Subject: [Koha-bugs] [Bug 24497] CodeMirror should be a sys pref
In-Reply-To: <bug-24497-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24497-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24497-70-D87XvVSNGE@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24497

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de

--- Comment #2 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Was going to ask the same - since it doesn't affect your input like the wysiwyg
editor does, but only adds some formatting.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 23 23:59:48 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Jan 2020 22:59:48 +0000
Subject: [Koha-bugs] [Bug 24482] Purchase Items broken by costs containing a
 comma
In-Reply-To: <bug-24482-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24482-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24482-70-lD6eYPTGYo@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24482

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |23354


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23354
[Bug 23354] Add a 'Pay' screen to allow anonymous payments in a POS fashion
-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 23 23:59:48 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Jan 2020 22:59:48 +0000
Subject: [Koha-bugs] [Bug 23354] Add a 'Pay' screen to allow anonymous
 payments in a POS fashion
In-Reply-To: <bug-23354-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23354-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23354-70-IYpjIOgu1s@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23354

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |24482


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24482
[Bug 24482] Purchase Items broken by costs containing a comma
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 24 00:01:04 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Jan 2020 23:01:04 +0000
Subject: [Koha-bugs] [Bug 22359] Improve usability of 'change calculation'
 (bug 11373)
In-Reply-To: <bug-22359-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22359-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22359-70-XvzDTJhRIO@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22359

--- Comment #22 from Michal Denar <black23 at gmail.com> ---
I partically agree with Andrew that solution and texts are "inaccurate". But
"Collected from patron" has field for calculation function. So if we talk about
partially write off feature, we should use clear way that every librarian user
understand from UI&texts. Maybe like https://prnt.sc/qs0raw

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 24 00:02:07 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Jan 2020 23:02:07 +0000
Subject: [Koha-bugs] [Bug 24482] Purchase Items broken by costs containing a
 comma
In-Reply-To: <bug-24482-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24482-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24482-70-sPkz90M2VM@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24482

--- Comment #1 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Nice catch, I never tested with such a large figure I must admit.

I'll start digging into it asap.  Thanks for testing this feature so thoroughly
Andrew, it's great to be catching these things before live release.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 24 00:02:16 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Jan 2020 23:02:16 +0000
Subject: [Koha-bugs] [Bug 24482] Purchase Items broken by costs containing a
 comma
In-Reply-To: <bug-24482-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24482-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24482-70-kz1K3NiXie@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24482

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |martin.renvoize at ptfs-europe
                   |ity.org                     |.com

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 24 00:02:43 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Jan 2020 23:02:43 +0000
Subject: [Koha-bugs] [Bug 24356] objects.search prefetch
In-Reply-To: <bug-24356-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24356-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24356-70-27bnfmXypg@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24356

Agustín Moyano <agustinmoyano at theke.io> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |20936


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20936
[Bug 20936] Holds History for patrons in OPAC
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 24 00:02:43 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Jan 2020 23:02:43 +0000
Subject: [Koha-bugs] [Bug 20936] Holds History for patrons in OPAC
In-Reply-To: <bug-20936-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20936-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20936-70-psqWcyXZeO@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20936

Agustín Moyano <agustinmoyano at theke.io> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |24356


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24356
[Bug 24356] objects.search prefetch
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 24 00:08:19 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Jan 2020 23:08:19 +0000
Subject: [Koha-bugs] [Bug 24502] New: objects.search filter by prefetched
 columns
Message-ID: <bug-24502-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24502

            Bug ID: 24502
           Summary: objects.search filter by prefetched columns
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Architecture, internals, and plumbing
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: agustinmoyano at theke.io
        QA Contact: testopia at bugs.koha-community.org
        Depends on: 24356
            Blocks: 20936

Make object.search helper filter by prefetched columns


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20936
[Bug 20936] Holds History for patrons in OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24356
[Bug 24356] objects.search prefetch
-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 24 00:08:19 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Jan 2020 23:08:19 +0000
Subject: [Koha-bugs] [Bug 24356] objects.search prefetch
In-Reply-To: <bug-24356-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24356-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24356-70-1SUPp20CX9@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24356

Agustín Moyano <agustinmoyano at theke.io> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |24502


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24502
[Bug 24502] objects.search filter by prefetched columns
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 24 00:08:19 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Jan 2020 23:08:19 +0000
Subject: [Koha-bugs] [Bug 20936] Holds History for patrons in OPAC
In-Reply-To: <bug-20936-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20936-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20936-70-A8qjDvjaps@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20936

Agustín Moyano <agustinmoyano at theke.io> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |24502


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24502
[Bug 24502] objects.search filter by prefetched columns
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 24 00:09:15 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Jan 2020 23:09:15 +0000
Subject: [Koha-bugs] [Bug 24502] objects.search filter by prefetched columns
In-Reply-To: <bug-24502-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24502-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24502-70-P4fWBya3Vw@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24502

Agustín Moyano <agustinmoyano at theke.io> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |tomascohen at gmail.com
           Assignee|koha-bugs at lists.koha-commun |agustinmoyano at theke.io
                   |ity.org                     |

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 24 00:18:21 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Jan 2020 23:18:21 +0000
Subject: [Koha-bugs] [Bug 24502] objects.search filter by prefetched columns
In-Reply-To: <bug-24502-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24502-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24502-70-ecNpWLYUbE@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24502

Agustín Moyano <agustinmoyano at theke.io> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |24487

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 24 00:32:15 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Jan 2020 23:32:15 +0000
Subject: [Koha-bugs] [Bug 24356] objects.search prefetch
In-Reply-To: <bug-24356-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24356-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24356-70-lr5It1hVbY@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24356

Agustín Moyano <agustinmoyano at theke.io> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #97680|0                           |1
        is obsolete|                            |
  Attachment #97681|0                           |1
        is obsolete|                            |

--- Comment #4 from Agustín Moyano <agustinmoyano at theke.io> ---
Created attachment 97848
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97848&action=edit
Bug 24356: prefetch_whitelist tests

This patch adds tests for the introduced methods.

To test:
1. Run the tests :-D
=> SUCCESS: They pass!
2. Sign off :-D

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 24 00:32:19 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 23 Jan 2020 23:32:19 +0000
Subject: [Koha-bugs] [Bug 24356] objects.search prefetch
In-Reply-To: <bug-24356-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24356-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24356-70-KcVUzuiyaT@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24356

--- Comment #5 from Agustín Moyano <agustinmoyano at theke.io> ---
Created attachment 97849
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97849&action=edit
Bug 24356: Make objects.search prefetch embedded relations

This patch makes the Koha::Object(s) derived classes expose information
about prefetch-able relations. This is then used by a new helper to
generate the prefetch information for the DBIC query.

To test:
1. Apply this patch
2. Run:
   $ kshell
  k$ prove t/db_dependent/Koha/Object* \
           t/db_dependent/Koha/REST/Plugin/Objects.t \
           t/db_dependent/Koha/REST/Plugin/Query.t
=> SUCCESS: Tests pass!
3. Sign off :-D

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 24 01:13:53 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Jan 2020 00:13:53 +0000
Subject: [Koha-bugs] [Bug 23407] XSLT Details pages don't use items,
 we shouldn't pass them
In-Reply-To: <bug-23407-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23407-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23407-70-kaXEChiuF1@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23407

Hayley Mapley <hayleymapley at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 24 01:13:56 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Jan 2020 00:13:56 +0000
Subject: [Koha-bugs] [Bug 23407] XSLT Details pages don't use items,
 we shouldn't pass them
In-Reply-To: <bug-23407-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23407-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23407-70-KoUfj1TxaR@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23407

Hayley Mapley <hayleymapley at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #92045|0                           |1
        is obsolete|                            |

--- Comment #5 from Hayley Mapley <hayleymapley at catalyst.net.nz> ---
Created attachment 97850
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97850&action=edit
Bug 23407: Don't process items for XSLT on details pages

To test:
1 - Add 1000 items to a record
    Go to biblio
    Edit items
    Add multiple copies of this item
    Add 1000 and confirm
    Wait..
2 - Load the record in staff client and OPAC, note how long it takes
    Press F12 in browser to open the console
    use the Network tab of the console
    note the load time
    refresh a few times to see average time
3 - Apply patch
4 - Restart all the things
5 - Reload the record in staff and opac
6 - Note decresed time
7 - Verify nothing on the page has changed

QA can grep the standard XSLT files for details pages for 'item' to note
occurences do not use items information

Signed-off-by: Hayley Mapley <hayleymapley at catalyst.net.nz>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 24 01:18:44 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Jan 2020 00:18:44 +0000
Subject: [Koha-bugs] [Bug 22943] The in_ipset C4::Auth function name can be
 confusing
In-Reply-To: <bug-22943-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22943-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22943-70-dzpKBOwqe5@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22943

--- Comment #5 from Hayley Mapley <hayleymapley at catalyst.net.nz> ---
Thanks for your comments Mark and David. Patch still needs signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 24 01:39:16 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Jan 2020 00:39:16 +0000
Subject: [Koha-bugs] [Bug 24356] objects.search prefetch
In-Reply-To: <bug-24356-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24356-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24356-70-bnsoUCcvwM@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24356

Agustín Moyano <agustinmoyano at theke.io> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #97848|0                           |1
        is obsolete|                            |
  Attachment #97849|0                           |1
        is obsolete|                            |

--- Comment #6 from Agustín Moyano <agustinmoyano at theke.io> ---
Created attachment 97851
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97851&action=edit
Bug 24356: prefetch_whitelist tests

This patch adds tests for the introduced methods.

To test:
1. Run the tests :-D
=> SUCCESS: They pass!
2. Sign off :-D

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 24 01:39:20 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Jan 2020 00:39:20 +0000
Subject: [Koha-bugs] [Bug 24356] objects.search prefetch
In-Reply-To: <bug-24356-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24356-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24356-70-6vUr6PnOKi@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24356

--- Comment #7 from Agustín Moyano <agustinmoyano at theke.io> ---
Created attachment 97852
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97852&action=edit
Bug 24356: Make objects.search prefetch embedded relations

This patch makes the Koha::Object(s) derived classes expose information
about prefetch-able relations. This is then used by a new helper to
generate the prefetch information for the DBIC query.

To test:
1. Apply this patch
2. Run:
   $ kshell
  k$ prove t/db_dependent/Koha/Object* \
           t/db_dependent/Koha/REST/Plugin/Objects.t \
           t/db_dependent/Koha/REST/Plugin/Query.t
=> SUCCESS: Tests pass!
3. Sign off :-D

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 24 01:39:46 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Jan 2020 00:39:46 +0000
Subject: [Koha-bugs] [Bug 24356] objects.search prefetch
In-Reply-To: <bug-24356-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24356-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24356-70-ishX7mgFts@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24356

Agustín Moyano <agustinmoyano at theke.io> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 24 01:40:17 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Jan 2020 00:40:17 +0000
Subject: [Koha-bugs] [Bug 24356] objects.search prefetch
In-Reply-To: <bug-24356-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24356-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24356-70-BeLCwscULS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24356

--- Comment #8 from Agustín Moyano <agustinmoyano at theke.io> ---
(In reply to Tomás Cohen Arazi from comment #3)
> This is missing tests for the helpers.

Just added missing tests!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 24 03:19:49 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Jan 2020 02:19:49 +0000
Subject: [Koha-bugs] [Bug 20847] Add more fields to the Batch Patron
 Modification tool
In-Reply-To: <bug-20847-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20847-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20847-70-vpByJ3cRrn@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20847

--- Comment #5 from David Roberts <david.roberts at ptfs-europe.com> ---
Created attachment 97853
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97853&action=edit
Bug 20847 - Add more fields to the Batch Patron Modification tool

This patch adds streetnumber, address, address2, phone and mobile to the
Batch Patron Modify form, also moves Primary email to a more logical
place on the page

To test:

1) Install patch
2) Open Batch Patron Modification tool, and input a borrowernumber to
edit
3) Add some data into the streetnumber, address, address2, phone and
mobile fields and click Save
4) These fields in the user record should now contain your data
5) Test that running the tool again with the option to delete the data
clears the fields correctly
6) Repeat steps 1-5 with a file of user borrowernumbers

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 24 03:22:12 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Jan 2020 02:22:12 +0000
Subject: [Koha-bugs] [Bug 20847] Add more fields to the Batch Patron
 Modification tool
In-Reply-To: <bug-20847-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20847-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20847-70-VTUz8Uke8B@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20847

David Roberts <david.roberts at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

--- Comment #6 from David Roberts <david.roberts at ptfs-europe.com> ---
I've added the capability to edit the streetnumber, address, address2, phone
and mobile fields to the Batch Patron Modify form. I've also moved the Primary
email address field to a more logical place on the page (I don't know why I put
it in such a random place originally!)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 24 07:41:21 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Jan 2020 06:41:21 +0000
Subject: [Koha-bugs] [Bug 23260] Anonymize (remove) patron data from
 items_last_borrower
In-Reply-To: <bug-23260-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23260-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23260-70-mzmdserxwz@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23260

--- Comment #59 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
(In reply to Agustín Moyano from comment #58)
> Created attachment 97842 [details] [review]
> Bug 23260: Inline code to anonymise_issue_history
> 
> This alternative patch reduces the complexity of the change by simply
> updateing the existing anonymise_issue_history method to include
> anonymisation of the items_last_borrowers table.
> 
> To test:
> 1) apply this patch and the previous one
> 2) perl installer/data/mysql/updatedatabase.pl
> 3) set StoreLastBorrower preference to Allow.
> 4) set AnonymousPatron preference to a valid patron id
> 5) Create a Check out followed by a Check in.
> CHECK => a row should appear in items_last_borrower table with the borrower
> and the item number.
> 6) In mysql, update created_on of items_last_borrower and returndate of
> old_issues to two days earlier.
> 7) perl misc/cronjobs/batch_anonymise.pl --days 1
> SUCCESS => borrower number in items_last_borrower changed to AnonymousPatron
> id
> 8) repeat steps 5 and 6
> 9) set AnonymousPatron preference to 0
> 10) perl misc/cronjobs/batch_anonymise.pl --days 1
> SUCCESS => borrower number in items_last_borrower changed to null
> 11) prove t/db_dependent/Koha/Patrons.t
> 12) Sign off

Agustin,
If you agree with this patch, please test and sign off.
I could do the last step of QA.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 24 07:52:37 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Jan 2020 06:52:37 +0000
Subject: [Koha-bugs] [Bug 24331] Internal server error when placing hold on
 item if itemtype undefined
In-Reply-To: <bug-24331-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24331-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24331-70-SCTkw07Rty@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24331

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Failed QA
                 CC|                            |m.de.rooy at rijksmuseum.nl

--- Comment #5 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
(In reply to Jonathan Druart from comment #4)
> Nick, did not we (more or less) agree that we should not test if items had
> valid item type?
> See bug 21842.

Although I still intuitively feel that such tests are appropriate, I also had
the impression that we agreed not to add such tests everywhere.
If this still needs discussion, please change status accordingly. It would be
wise to have a specific coding guideline for this, Jonathan.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 24 08:00:56 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Jan 2020 07:00:56 +0000
Subject: [Koha-bugs] [Bug 23102] 404 errors on page causes SCI user to be
 logged out
In-Reply-To: <bug-23102-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23102-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23102-70-qudZvJdFOV@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23102

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Failed QA
                 CC|                            |m.de.rooy at rijksmuseum.nl

--- Comment #7 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
(In reply to Owen Leonard from comment #6)
> (In reply to Jonathan Druart from comment #4)
> > It would be great to have a regression selenium test here, do not you think?
> 
> This works for me, but should it be 'Failed QA' because of the missing test?

Changing status. Please correct if you want to sign off on this patch and add
your signoff line.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 24 08:09:41 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Jan 2020 07:09:41 +0000
Subject: [Koha-bugs] [Bug 23407] XSLT Details pages don't use items,
 we shouldn't pass them
In-Reply-To: <bug-23407-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23407-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23407-70-4Guf8ts7AV@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23407

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |BLOCKED

--- Comment #6 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
QA: Looking here


> QA can grep the standard XSLT files for details pages for 'item' to note
> occurences do not use items information

intranetResults

  xmlns:items="http://www.koha-community.org/items"
  exclude-result-prefixes="marc items str">
    <xsl:key name="item-by-status" match="items:item" use="items:status"/>
    <xsl:key name="item-by-status-and-branch" match="items:item"
use="concat(items:status, ' ', items:homebranch)"/>
        <xsl:variable name="hidelostitems"
select="marc:sysprefs/marc:syspref[@name='hidelostitems']"/>

still a few lines in intranetDetails too

Removed in a follow-up

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 24 08:09:54 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Jan 2020 07:09:54 +0000
Subject: [Koha-bugs] [Bug 23407] XSLT Details pages don't use items,
 we shouldn't pass them
In-Reply-To: <bug-23407-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23407-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23407-70-3z2SJ5oofA@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23407

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl
                   |y.org                       |
   Patch complexity|---                         |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 24 08:25:19 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Jan 2020 07:25:19 +0000
Subject: [Koha-bugs] [Bug 23407] XSLT Details pages don't use items,
 we shouldn't pass them
In-Reply-To: <bug-23407-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23407-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23407-70-7rvRMwML86@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23407

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|BLOCKED                     |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 24 08:25:22 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Jan 2020 07:25:22 +0000
Subject: [Koha-bugs] [Bug 23407] XSLT Details pages don't use items,
 we shouldn't pass them
In-Reply-To: <bug-23407-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23407-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23407-70-NmFHXTDW5w@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23407

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #97850|0                           |1
        is obsolete|                            |

--- Comment #7 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 97854
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97854&action=edit
Bug 23407: Don't process items for XSLT on details pages

To test:
1 - Add 1000 items to a record
    Go to biblio
    Edit items
    Add multiple copies of this item
    Add 1000 and confirm
    Wait..
2 - Load the record in staff client and OPAC, note how long it takes
    Press F12 in browser to open the console
    use the Network tab of the console
    note the load time
    refresh a few times to see average time
3 - Apply patch
4 - Restart all the things
5 - Reload the record in staff and opac
6 - Note decresed time
7 - Verify nothing on the page has changed

QA can grep the standard XSLT files for details pages for 'item' to note
occurences do not use items information

Signed-off-by: Hayley Mapley <hayleymapley at catalyst.net.nz>

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 24 08:25:26 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Jan 2020 07:25:26 +0000
Subject: [Koha-bugs] [Bug 23407] XSLT Details pages don't use items,
 we shouldn't pass them
In-Reply-To: <bug-23407-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23407-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23407-70-7Fsm9HGwjx@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23407

--- Comment #8 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 97855
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97855&action=edit
Bug 23407: (QA follow-up) Remove some XSLT item leftovers

Test plan:
Check intranet results and detail page.
Check opac detail.

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 24 08:25:30 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Jan 2020 07:25:30 +0000
Subject: [Koha-bugs] [Bug 23407] XSLT Details pages don't use items,
 we shouldn't pass them
In-Reply-To: <bug-23407-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23407-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23407-70-AX7UeUavPu@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23407

--- Comment #9 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 97856
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97856&action=edit
Bug 23407: (QA follow-up) Same change for UNIMARC XSLT

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 24 08:29:39 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Jan 2020 07:29:39 +0000
Subject: [Koha-bugs] [Bug 24305] Batch Item modification via item number in
 reports does not work with CONCAT in report
In-Reply-To: <bug-24305-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24305-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24305-70-5M4ziIx2H9@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24305

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Patch doesn't apply

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 24 08:33:23 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Jan 2020 07:33:23 +0000
Subject: [Koha-bugs] [Bug 23443] Paying off a lost fee will return the item,
 even if it is checked out to a different patron
In-Reply-To: <bug-23443-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23443-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23443-70-79O912ePmq@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23443

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |BLOCKED
                 CC|                            |m.de.rooy at rijksmuseum.nl

--- Comment #8 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
QAing

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 24 08:33:32 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Jan 2020 07:33:32 +0000
Subject: [Koha-bugs] [Bug 23443] Paying off a lost fee will return the item,
 even if it is checked out to a different patron
In-Reply-To: <bug-23443-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23443-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23443-70-NEffixVzF5@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23443

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl
                   |y.org                       |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 24 09:19:02 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Jan 2020 08:19:02 +0000
Subject: [Koha-bugs] [Bug 24503] New: Missing use in value builder
 barcode_manual.pl
Message-ID: <bug-24503-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24503

            Bug ID: 24503
           Summary: Missing use in value builder barcode_manual.pl
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: Cataloging
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: fridolin.somers at biblibre.com
        QA Contact: testopia at bugs.koha-community.org
                CC: m.de.rooy at rijksmuseum.nl

Bug 22721 added use C4::Biblio in cataloguing/value_builder/barcode.pl.
This is missing in value builder barcode_manual.pl.
You get the error : 
Undefined subroutine &Koha::FrameworkPlugin::GetMarcFromKohaField called at
cataloguing/value_builder/barcode_manual.pl line 41.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 24 09:19:09 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Jan 2020 08:19:09 +0000
Subject: [Koha-bugs] [Bug 24503] Missing use in value builder
 barcode_manual.pl
In-Reply-To: <bug-24503-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24503-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24503-70-meTZOAi9T5@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24503

Fridolin SOMERS <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |22721


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22721
[Bug 22721] Normalize GetMarcFromKohaField calls
-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 24 09:19:09 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Jan 2020 08:19:09 +0000
Subject: [Koha-bugs] [Bug 22721] Normalize GetMarcFromKohaField calls
In-Reply-To: <bug-22721-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22721-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22721-70-YPDNNQcu2K@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22721

Fridolin SOMERS <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |24503


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24503
[Bug 24503] Missing use in value builder barcode_manual.pl
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 24 09:19:27 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Jan 2020 08:19:27 +0000
Subject: [Koha-bugs] [Bug 24503] Missing use in value builder
 barcode_manual.pl
In-Reply-To: <bug-24503-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24503-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24503-70-Q6lPDAzWRE@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24503

Fridolin SOMERS <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Trivial patch
             Status|NEW                         |ASSIGNED
           Assignee|koha-bugs at lists.koha-commun |fridolin.somers at biblibre.co
                   |ity.org                     |m

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 24 09:24:02 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Jan 2020 08:24:02 +0000
Subject: [Koha-bugs] [Bug 24503] Missing use in value builder
 barcode_manual.pl
In-Reply-To: <bug-24503-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24503-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24503-70-M1cmQxd05f@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24503

Fridolin SOMERS <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 24 09:24:04 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Jan 2020 08:24:04 +0000
Subject: [Koha-bugs] [Bug 24503] Missing use in value builder
 barcode_manual.pl
In-Reply-To: <bug-24503-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24503-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24503-70-9QGXPHrKMu@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24503

--- Comment #1 from Fridolin SOMERS <fridolin.somers at biblibre.com> ---
Created attachment 97857
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97857&action=edit
Bug 24503: fix missing use in value builder barcode_manual.pl

Bug 22721 added use C4::Biblio in cataloguing/value_builder/barcode.pl.
This is missing in value builder barcode_manual.pl.
You get the error :
Undefined subroutine &Koha::FrameworkPlugin::GetMarcFromKohaField called at
cataloguing/value_builder/barcode_manual.pl line 41.

Test plan :
1) Configure a subfield of item to use value builder barcode_manual.pl
2) Go to a record
3) Try to add a new item
4) Check the value builder is OK

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 24 09:45:31 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Jan 2020 08:45:31 +0000
Subject: [Koha-bugs] [Bug 24149] Add new Koha::Statistic[s] classes
In-Reply-To: <bug-24149-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24149-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24149-70-pg1kdUeyvo@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24149

--- Comment #11 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 97858
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97858&action=edit
Bug 24149: Skip Koha::Statistics for TestBuilder tests

As statistics does not have a PK we need to adjust the TestBuilder
tests.
Bug 18441 already exists for adding the PK.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 24 09:48:11 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Jan 2020 08:48:11 +0000
Subject: [Koha-bugs] [Bug 24149] Add new Koha::Statistic[s] classes
In-Reply-To: <bug-24149-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24149-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24149-70-GLYlmMfQce@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24149

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |martin.renvoize at ptfs-europe
                   |                            |.com

--- Comment #12 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Followup pushed, thanks Jonathan

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 24 09:49:04 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Jan 2020 08:49:04 +0000
Subject: [Koha-bugs] [Bug 23443] Paying off a lost fee will return the item,
 even if it is checked out to a different patron
In-Reply-To: <bug-23443-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23443-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23443-70-xNAgrblwjB@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23443

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|BLOCKED                     |Passed QA
   Patch complexity|---                         |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 24 09:49:07 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Jan 2020 08:49:07 +0000
Subject: [Koha-bugs] [Bug 23443] Paying off a lost fee will return the item,
 even if it is checked out to a different patron
In-Reply-To: <bug-23443-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23443-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23443-70-Ru6MVufjy2@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23443

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #97362|0                           |1
        is obsolete|                            |

--- Comment #9 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 97859
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97859&action=edit
Bug 23443: Add tests

Signed-off-by: Andrew Fuerste-Henry <andrew at bywatersolutions.com>

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 24 09:49:12 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Jan 2020 08:49:12 +0000
Subject: [Koha-bugs] [Bug 23443] Paying off a lost fee will return the item,
 even if it is checked out to a different patron
In-Reply-To: <bug-23443-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23443-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23443-70-4qOdVfulHv@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23443

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #97363|0                           |1
        is obsolete|                            |

--- Comment #10 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 97860
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97860&action=edit
Bug 23443: Do not checkin an item if checked out to another patron when lost
fee is paid

Test plan:
0 - Do not apply this patch
1 - Check out an item to a patron
2 - Make sure a fee will be charged when lost
3 - Mark the item lost
4 - Make sure the fee will not be refunded on return of the item
5 - Return the item
6 - Check it out to a new patron
7 - Write off the fine for the original patron
=> The item is now checked in
8 - Apply this patch and repeat 1 to 7
=> The item is still checked out

Signed-off-by: Andrew Fuerste-Henry <andrew at bywatersolutions.com>

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 24 09:52:23 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Jan 2020 08:52:23 +0000
Subject: [Koha-bugs] [Bug 24305] Batch Item modification via item number in
 reports does not work with CONCAT in report
In-Reply-To: <bug-24305-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24305-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24305-70-MPOB3c18QE@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24305

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Patch doesn't apply         |Signed Off

--- Comment #6 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Marcel, they apply correctly for me, please try again.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 24 09:58:15 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Jan 2020 08:58:15 +0000
Subject: [Koha-bugs] [Bug 24503] Missing use in value builder
 barcode_manual.pl
In-Reply-To: <bug-24503-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24503-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24503-70-BoFPkfhuTV@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24503

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |BLOCKED

--- Comment #2 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Looking here

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 24 10:05:54 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Jan 2020 09:05:54 +0000
Subject: [Koha-bugs] [Bug 23157] 19.05 appears to only being tested on D9
In-Reply-To: <bug-23157-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23157-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23157-70-BTBQZMWeKc@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23157

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org
         Resolution|---                         |FIXED
             Status|NEW                         |RESOLVED

--- Comment #1 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
They have been added.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 24 10:07:33 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Jan 2020 09:07:33 +0000
Subject: [Koha-bugs] [Bug 24503] Missing use in value builder
 barcode_manual.pl
In-Reply-To: <bug-24503-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24503-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24503-70-wfQ2jrgDlK@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24503

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|BLOCKED                     |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 24 10:07:36 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Jan 2020 09:07:36 +0000
Subject: [Koha-bugs] [Bug 24503] Missing use in value builder
 barcode_manual.pl
In-Reply-To: <bug-24503-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24503-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24503-70-R9EPdYF8EO@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24503

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #97857|0                           |1
        is obsolete|                            |

--- Comment #3 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 97861
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97861&action=edit
Bug 24503: fix missing use in value builder barcode_manual.pl

Bug 22721 added use C4::Biblio in cataloguing/value_builder/barcode.pl.
This is missing in value builder barcode_manual.pl.
You get the error :
Undefined subroutine &Koha::FrameworkPlugin::GetMarcFromKohaField called at
cataloguing/value_builder/barcode_manual.pl line 41.

Test plan :
1) Configure a subfield of item to use value builder barcode_manual.pl
2) Go to a record
3) Try to add a new item
4) Check the value builder is OK

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Tested with autobarcode==year-0001,0002
No internal server error, but generates a barcode now.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 24 10:08:11 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Jan 2020 09:08:11 +0000
Subject: [Koha-bugs] [Bug 24503] Missing use in value builder
 barcode_manual.pl
In-Reply-To: <bug-24503-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24503-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24503-70-dIZHG0EH6n@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24503

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

--- Comment #4 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Trivial fix. Tested the interface. Combining SO+QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 24 10:08:19 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Jan 2020 09:08:19 +0000
Subject: [Koha-bugs] [Bug 24503] Missing use in value builder
 barcode_manual.pl
In-Reply-To: <bug-24503-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24503-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24503-70-MuvsBPZ03E@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24503

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl
                   |y.org                       |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 24 10:10:11 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Jan 2020 09:10:11 +0000
Subject: [Koha-bugs] [Bug 17084] Automatic debian/control updates (master)
In-Reply-To: <bug-17084-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17084-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17084-70-pVnc4ZXzs4@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17084

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #97236|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 24 10:10:24 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Jan 2020 09:10:24 +0000
Subject: [Koha-bugs] [Bug 24305] Batch Item modification via item number in
 reports does not work with CONCAT in report
In-Reply-To: <bug-24305-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24305-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24305-70-GXYQsaanX1@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24305

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |BLOCKED

--- Comment #7 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
(In reply to Jonathan Druart from comment #6)
> Marcel, they apply correctly for me, please try again.

And yes, they apply! Not sure what happened here.
Looking here now for QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 24 10:10:39 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Jan 2020 09:10:39 +0000
Subject: [Koha-bugs] [Bug 17084] Automatic debian/control updates (master)
In-Reply-To: <bug-17084-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17084-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17084-70-DMkUfoKRnS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17084

--- Comment #45 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Latest pushed to 20.05.x

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 24 10:12:01 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Jan 2020 09:12:01 +0000
Subject: [Koha-bugs] [Bug 24504] New: branchtransfers.pl - Entering checked
 out item cause Internal Server Error
Message-ID: <bug-24504-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24504

            Bug ID: 24504
           Summary: branchtransfers.pl - Entering checked out item cause
                    Internal Server Error
 Change sponsored?: ---
           Product: Koha
           Version: 19.05
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: Circulation
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: fraktik at gmail.com
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com

Interestingly enough this is happening only first time (item get checked in and
then this "Internal Server Error" blank page appears).
If I get back to /cgi-bin/koha/circ/branchtransfers.pl and put the same barcode
second time, the transfer is processed without any further error.

Possible relation to the Bug 3536 - Checked In item requiring transfer does not
consistently trigger transfer prompt
(https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3536)

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 24 10:13:47 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Jan 2020 09:13:47 +0000
Subject: [Koha-bugs] [Bug 23237] Add support for [% INCLUDE %] in plugin
 templates
In-Reply-To: <bug-23237-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23237-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23237-70-WD9pufJckh@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23237

--- Comment #12 from Frédéric Demians <frederic at tamil.fr> ---
(In reply to Martin Renvoize from comment #11)
> Any further thoughts regarding Tomas's comment Frederic?

Thomas is right. I implemented this before Thomas added bundle_dir() method. I
will submit a patch to use Thomas method instead of mine get_plugin_dir()
method.

bundle_dir() is available in 19.11 and after. So the new patch must not be
backported to 19.05 and 18.11. As it is the usage of new template parameter
PLUGIN_DIR will be OK in 18.11 and 19.05 as soon as plugins_dir parameter is
unique in koha-conf.xml.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 24 10:22:25 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Jan 2020 09:22:25 +0000
Subject: [Koha-bugs] [Bug 23237] Add support for [% INCLUDE %] in plugin
 templates
In-Reply-To: <bug-23237-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23237-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23237-70-QRiidQhPtY@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23237

--- Comment #13 from Frédéric Demians <frederic at tamil.fr> ---
Created attachment 97862
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97862&action=edit
Bug 23237: Fix PLUGIN_DIR parameter in master/19.11

Method get_plugin_dir() is not correct when plugin_dirs parameter is repeated
in koha-conf.xml. A new method bundle_path() must be used instead.

bundle_dir() is available in 19.11 and after. So the new patch must not be
backported to 19.05 and 18.11. As it is the usage of the new template parameter
PLUGIN_DIR will be OK in 18.11 and 19.05 as soon as plugins_dir parameter is
unique in koha-conf.xml.

Thanks Thomas

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 24 10:24:28 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Jan 2020 09:24:28 +0000
Subject: [Koha-bugs] [Bug 23237] Add support for [% INCLUDE %] in plugin
 templates
In-Reply-To: <bug-23237-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23237-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23237-70-mVPFN1Y3Kj@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23237

Frédéric Demians <frederic at tamil.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #91875|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 24 10:24:41 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Jan 2020 09:24:41 +0000
Subject: [Koha-bugs] [Bug 23237] Add support for [% INCLUDE %] in plugin
 templates
In-Reply-To: <bug-23237-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23237-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23237-70-gMNOEL0KC3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23237

Frédéric Demians <frederic at tamil.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #91876|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 24 10:43:17 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Jan 2020 09:43:17 +0000
Subject: [Koha-bugs] [Bug 16461] Add barcode and item type in fine
 description for overdue
In-Reply-To: <bug-16461-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16461-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16461-70-CJ2zUWQjX4@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16461

Theodoros Theodoropoulos <theod at lib.auth.gr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|theod at lib.auth.gr           |koha-bugs at lists.koha-commun
                   |                            |ity.org

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 24 11:04:24 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Jan 2020 10:04:24 +0000
Subject: [Koha-bugs] [Bug 24505] New: Print overdue notice with html gives
 message: "The following terms were not matched and replaced"
Message-ID: <bug-24505-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24505

            Bug ID: 24505
           Summary: Print overdue notice with html gives message: "The
                    following terms were not matched and replaced"
 Change sponsored?: ---
           Product: Koha
           Version: 19.05
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: Notices
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: somesecretemail at mailinator.com
        QA Contact: testopia at bugs.koha-community.org

In overdue notice for the option "print" we use a template containing html.
After running the overdue_notices cron job: 

> sudo perl  /usr/share/koha/bin/cronjobs/overdue_notices.pl -t -v -html /tmp

a message is presented by the system "The following terms were not matched and
replaced: html, div, etc...". 

It seems like the system confuses the "<< >>" enclosed text with the html
components. 

Nothing from the template is added to the generated html file. 

This bug is exactly the same as this bug fixed in 2013:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10720 

You can also find it well documented in the commit here:
https://gitlab.deichman.no/digibib/Koha/commit/394be84dcd65a4569d0467bc12b99dbd6341fc43

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 24 11:12:08 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Jan 2020 10:12:08 +0000
Subject: [Koha-bugs] [Bug 24506] New: Multibranch limit does not work with
 ElasticSearch
Message-ID: <bug-24506-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24506

            Bug ID: 24506
           Summary: Multibranch limit does not work with ElasticSearch
 Change sponsored?: ---
           Product: Koha
           Version: 19.05
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Searching - Elasticsearch
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: andreas.jonsson at kreablo.se

Test plan

1. Set up a system with ElasticSearch
2. Set up or make sure ther are at least two branches
3. create a group of branches
4. make sure there are items associated with any library in the group
5. make a search in opac limited by the library group
6. make an advanced search in intra limited by the library group
7. change SearchEngine system preference to Zebra and repeat 5. and 6.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 24 11:14:27 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Jan 2020 10:14:27 +0000
Subject: [Koha-bugs] [Bug 24507] New: Checkouts/ReturnClaim.t is failing on
 MySQL 8
Message-ID: <bug-24507-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24507

            Bug ID: 24507
           Summary: Checkouts/ReturnClaim.t is failing on MySQL 8
 Change sponsored?: ---
           Product: Koha
           Version: unspecified
          Hardware: All
                OS: All
            Status: ASSIGNED
          Severity: normal
          Priority: P5 - low
         Component: Test Suite
          Assignee: jonathan.druart at bugs.koha-community.org
          Reporter: jonathan.druart at bugs.koha-community.org
        QA Contact: testopia at bugs.koha-community.org
        Depends on: 14697

$ prove t/db_dependent/Koha/Checkouts/ReturnClaim.t
t/db_dependent/Koha/Checkouts/ReturnClaim.t .. 
    #   Failed test 'Exception field is correct'
    #   at t/db_dependent/Koha/Checkouts/ReturnClaim.t line 97.
    #          got: 'return_claims.issue_id'
    #     expected: 'issue_id'
    # Looks like you failed 1 test of 8.
t/db_dependent/Koha/Checkouts/ReturnClaim.t .. 1/1 
#   Failed test 'store() tests'
#   at t/db_dependent/Koha/Checkouts/ReturnClaim.t line 133.

This is similar to bug 23825.


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14697
[Bug 14697] Extend and enhance "Claims returned" lost status
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 24 11:14:27 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Jan 2020 10:14:27 +0000
Subject: [Koha-bugs] [Bug 14697] Extend and enhance "Claims returned" lost
 status
In-Reply-To: <bug-14697-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14697-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14697-70-H8UzgqLLF9@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14697

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |24507


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24507
[Bug 24507] Checkouts/ReturnClaim.t is failing on MySQL 8
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 24 11:14:27 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Jan 2020 10:14:27 +0000
Subject: [Koha-bugs] [Bug 23825] Object.t is failing - Exception not caught
In-Reply-To: <bug-23825-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23825-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23825-70-HKuczpcAdb@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23825

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=24507

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 24 11:14:31 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Jan 2020 10:14:31 +0000
Subject: [Koha-bugs] [Bug 24506] Multibranch limit does not work with
 ElasticSearch
In-Reply-To: <bug-24506-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24506-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24506-70-tiAef5NELL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24506

--- Comment #1 from Andreas Jonsson <andreas.jonsson at kreablo.se> ---
Created attachment 97863
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97863&action=edit
Bug 24506: Multibranch limit does not work with ElasticSearch

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 24 11:15:09 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Jan 2020 10:15:09 +0000
Subject: [Koha-bugs] [Bug 24506] Multibranch limit does not work with
 ElasticSearch
In-Reply-To: <bug-24506-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24506-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24506-70-LaRWzoVLu7@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24506

Andreas Jonsson <andreas.jonsson at kreablo.se> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 24 11:15:28 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Jan 2020 10:15:28 +0000
Subject: [Koha-bugs] [Bug 24508] New: Perl version stops upgrade
Message-ID: <bug-24508-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24508

            Bug ID: 24508
           Summary: Perl version stops upgrade
 Change sponsored?: ---
           Product: Koha
           Version: 19.11
          Hardware: All
                OS: Linux
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: Installation and upgrade (command-line installer)
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: hans.palsson at hkr.se
        QA Contact: testopia at bugs.koha-community.org

In reference to bug 20808, when trying to upgrade 19.05.06 to 19.11.01 the
installation fails due to dependencies. It seems Perl version 5.20.0 is
required, on our server 5.28.1 is installed. Server is Debian Jessie;

PRETTY_NAME="Debian GNU/Linux 8 (jessie)"
NAME="Debian GNU/Linux"
VERSION_ID="8"
VERSION="8 (jessie)"
ID=debian

Error message is The following packages have unmet dependencies:
 koha-common : Depends: libnet-z3950-simpleserver-perl but it is not going to
be installed
...when searching for solutions it leads to wrong version of perl installed. 

The server has previously installed and upgraded Koha up to 19.05.06 without
errors. Is it a dependence that has come with 19.11?

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 24 11:15:46 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Jan 2020 10:15:46 +0000
Subject: [Koha-bugs] [Bug 24507] Checkouts/ReturnClaim.t is failing on MySQL
 8
In-Reply-To: <bug-24507-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24507-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24507-70-1JAtG6yg6L@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24507

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 24 11:15:49 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Jan 2020 10:15:49 +0000
Subject: [Koha-bugs] [Bug 24507] Checkouts/ReturnClaim.t is failing on MySQL
 8
In-Reply-To: <bug-24507-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24507-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24507-70-OYdgCswbbx@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24507

--- Comment #1 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 97864
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97864&action=edit
Bug 24507: Make Checkouts/ReturnClaim.t pass on MySQL 8

$ prove t/db_dependent/Koha/Checkouts/ReturnClaim.t
 t/db_dependent/Koha/Checkouts/ReturnClaim.t ..
     #   Failed test 'Exception field is correct'
     #   at t/db_dependent/Koha/Checkouts/ReturnClaim.t line 97.
     #          got: 'return_claims.issue_id'
     #     expected: 'issue_id'
     # Looks like you failed 1 test of 8.
 t/db_dependent/Koha/Checkouts/ReturnClaim.t .. 1/1
 #   Failed test 'store() tests'
 #   at t/db_dependent/Koha/Checkouts/ReturnClaim.t line 133.

This is similar to bug 23825.

Test plan:
Confirm that the tests pass on MySQL8 and MariaDB

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 24 11:17:18 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Jan 2020 10:17:18 +0000
Subject: [Koha-bugs] [Bug 17084] Automatic debian/control updates (master)
In-Reply-To: <bug-17084-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17084-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17084-70-IbNdgBBMyo@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17084

--- Comment #46 from Nightly Build Bot <nightly at abunchofthings.net> ---
Created attachment 97865
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97865&action=edit
Bug 17084- Automatic debian/control updates (unstable/master)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 24 11:21:33 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Jan 2020 10:21:33 +0000
Subject: [Koha-bugs] [Bug 24043] ILL module can't show requests from more
 than one backend
In-Reply-To: <bug-24043-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24043-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24043-70-lX1AcfcfmN@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24043

Hans Pålsson <hans.palsson at hkr.se> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |hans.palsson at hkr.se

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 24 11:26:04 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Jan 2020 10:26:04 +0000
Subject: [Koha-bugs] [Bug 24507] Checkouts/ReturnClaim.t is failing on MySQL
 8
In-Reply-To: <bug-24507-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24507-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24507-70-Cba43lfN7K@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24507

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |23996


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23996
[Bug 23996] MySQL 8 support
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 24 11:26:04 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Jan 2020 10:26:04 +0000
Subject: [Koha-bugs] [Bug 23996] MySQL 8 support
In-Reply-To: <bug-23996-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23996-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23996-70-C54tKgkn91@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23996

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |24507


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24507
[Bug 24507] Checkouts/ReturnClaim.t is failing on MySQL 8
-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 24 11:35:57 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Jan 2020 10:35:57 +0000
Subject: [Koha-bugs] [Bug 24509] New: API related tests failing on MySQL8
Message-ID: <bug-24509-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24509

            Bug ID: 24509
           Summary: API related tests failing on MySQL8
 Change sponsored?: ---
           Product: Koha
           Version: unspecified
          Hardware: All
                OS: All
            Status: NEW
          Severity: major
          Priority: P5 - low
         Component: Test Suite
          Assignee: chris at bigballofwax.co.nz
          Reporter: jonathan.druart at bugs.koha-community.org
        QA Contact: testopia at bugs.koha-community.org

On Koha_Master_D9_My8:

koha_1       |     #   Failed test at
t/db_dependent/api/v1/acquisitions_orders.t line 215.
koha_1       |     # found warning: DBD::mysql::st execute failed: Duplicate
entry '11' for key 'aqorders.PRIMARY' [for Statement "INSERT INTO `aqorders` (
`basketno`, `biblionumber`, `budget_id`, `cancellationreason`, `claimed_date`,
`claims_count`, `created_by`, `currency`, `datecancellationprinted`,
`datereceived`, `discount`, `ecost`, `ecost_tax_excluded`,
`ecost_tax_included`, `entrydate`, `freight`, `invoiceid`, `listprice`,
`order_internalnote`, `order_vendornote`, `ordernumber`, `orderstatus`,
`parent_ordernumber`, `quantity`, `quantityreceived`, `replacementprice`,
`rrp`, `rrp_tax_excluded`, `rrp_tax_included`, `sort1`, `sort1_authcat`,
`sort2`, `sort2_authcat`, `subscriptionid`, `tax_rate_on_ordering`,
`tax_rate_on_receiving`, `tax_value_on_ordering`, `tax_value_on_receiving`,
`timestamp`, `uncertainprice`, `unitprice`, `unitprice_tax_excluded`,
`unitprice_tax_included`) VALUES ( ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?,
?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?,
?, ? )" with ParamValues: 0=15, 1=657, 2=18, 3="r6hKv9u",
4='2020-01-24T00:00:00', 5=1813539654, 6=2000000013, 7="c63kUgJEj3",
8='2020-01-24T09:48:48', 9='2020-01-24T00:00:00', 10=25.27, 11=5.80966e+09,
12=9.2869e+21, 13=7.8939e+21, 14='2020-01-24T00:00:00', 15=1.13533e+21, 16=4,
17=1.65401e+21, 18="This is a dummy note for testing", 19="P5I73Xh8ag", 20=11,
21="new", 22=1344446286, 23=1, 24=0, 25=10, 26=1.81972e+10, 27=9.3789e+21,
28=1.13196e+21, 29="iNIBKvZ01RxmNlvnOJ9Mjzo5D4lFg3O4hKs7bNpK0tNtYe2w2egEUo7_J",
30="oViH6QZfg",
31="j4IqwY2bOIKop0IadGiNTxFBOqTca_w1TtOw9T0A6usBvHRkUHVQLFOx27_t7MbIIk1i",
32="AcJaKIkhar", 33=8, 34=48.3, 35=79.15, 36=5.94319e+21, 37=8.43555e+21,
38='2020-01-24T09:48:46', 39=0, 40=10, 41=4.29247e+21, 42=6.66896e+21] at
/usr/share/perl5/DBIx/Class/Storage/DBI.pm line 1836.
koha_1       |     # expected to find warning: (?^u:^DBD::mysql::st execute
failed: Duplicate entry '(.*)' for key 'PRIMARY')
koha_1       |     # Looks like you failed 2 tests of 17.
koha_1       | 
koha_1       | #   Failed test 'add() tests'
koha_1       | #   at t/db_dependent/api/v1/acquisitions_orders.t line 218.



koha_1       |     #   Failed test 'exact match for JSON Pointer "/conflict"'
koha_1       |     #   at t/db_dependent/api/v1/libraries.t line 199.
koha_1       |     #          got: 'branches.PRIMARY'
koha_1       |     #     expected: 'PRIMARY'
koha_1       | 
koha_1       |     #   Failed test at t/db_dependent/api/v1/libraries.t line
203.
koha_1       |     # found warning: DBD::mysql::st execute failed: Duplicate
entry 'qjCU_semRj' for key 'branches.PRIMARY' [for Statement "INSERT INTO
`branches` ( `branchaddress1`, `branchaddress2`, `branchaddress3`,
`branchcity`, `branchcode`, `branchcountry`, `branchemail`, `branchfax`,
`branchip`, `branchname`, `branchnotes`, `branchphone`, `branchreplyto`,
`branchreturnpath`, `branchstate`, `branchurl`, `branchzip`, `geolocation`,
`marcorgcode`, `opac_info`, `pickup_location`) VALUES ( ?, ?, ?, ?, ?, ?, ?, ?,
?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ? )" with ParamValues: 0="jn6JSVVD3",
1="nfzCX9m7p", 2="TnmmeQT", 3="jY4ossWU1i", 4="qjCU_semRj", 5="cefvfFrOy2",
6="CZhVkmb", 7="AIlePzZSy", 8="Gw8tzR9ZOZ_kfD", 9="Z3s2gIPGW2", 10="HoVbnAW0Y",
11="H7hUHN", 12="QRwTVe0saq", 13="ySgMvLeX", 14="LuUohqY", 15="zXY2PO",
16="A5fbE0k5VgCVrnfjXxL",
17="y_cg0kJTm0hZHuoiGPbLtuY8iolmUcw78vJz_K6Ep7yoBJ93JP7zZp4aNGW0SbOBqQan44GNBBQFlHee4u3AgUTQQ8RMi52NGrS9j2ZCyB_9_btunsWQy9Me1DMOmP9l6t2m9H60DXWJ0b9ulYoIR4viWLakcRBGIG8FuZgshd_4REkRMs4IRZLmE4rS6ktXsbbc5E3uwd7tZEo3FcPagvfFVKbnZfA1n",
18="sV8SwEd5MI2VP", 19="NUFih1L", 20=1] at
/usr/share/perl5/DBIx/Class/Storage/DBI.pm line 1836.
koha_1       |     # expected to find warning: (?^u:^DBD::mysql::st execute
failed: Duplicate entry '(.*)' for key 'PRIMARY')
koha_1       |     # Looks like you failed 2 tests of 17.
koha_1       | 
koha_1       | #   Failed test 'add() tests'
koha_1       | #   at t/db_dependent/api/v1/libraries.t line 206.



koha_1       |     #   Failed test 'Exception field is correct'
koha_1       |     #   at t/db_dependent/Koha/Object.t line 615.
koha_1       |     #          got: 'api_keys.secret'
koha_1       |     #     expected: 'secret'
koha_1       |     # Looks like you failed 1 test of 16.
koha_1       | 
koha_1       | #   Failed test 'store() tests'
koha_1       | #   at t/db_dependent/Koha/Object.t line 688.
koha_1       | # Looks like you failed 1 test of 17.
koha_1       | [10:11:10] t/db_dependent/Koha/Object.t
............................................ 


koha_1       | #   Failed test 'add() tests'
koha_1       | #   at t/db_dependent/api/v1/patrons.t line 215.
koha_1       | 
koha_1       |         #   Failed test 'exact match for JSON Pointer
"/conflict"'
koha_1       |         #   at t/db_dependent/api/v1/patrons.t line 311.
koha_1       |         #          got: 'borrowers.cardnumber'
koha_1       |         #     expected: 'cardnumber'

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 24 11:36:31 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Jan 2020 10:36:31 +0000
Subject: [Koha-bugs] [Bug 24509] API related tests failing on MySQL8
In-Reply-To: <bug-24509-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24509-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24509-70-d1gVrd1FjB@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24509

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=24507
             Blocks|                            |23996


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23996
[Bug 23996] MySQL 8 support
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 24 11:36:31 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Jan 2020 10:36:31 +0000
Subject: [Koha-bugs] [Bug 23996] MySQL 8 support
In-Reply-To: <bug-23996-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23996-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23996-70-TTQMXDZPxW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23996

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |24509


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24509
[Bug 24509] API related tests failing on MySQL8
-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 24 11:36:31 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Jan 2020 10:36:31 +0000
Subject: [Koha-bugs] [Bug 24507] Checkouts/ReturnClaim.t is failing on MySQL
 8
In-Reply-To: <bug-24507-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24507-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24507-70-SD9xAjIXXo@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24507

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=24509

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 24 11:43:49 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Jan 2020 10:43:49 +0000
Subject: [Koha-bugs] [Bug 24509] API related tests failing on MySQL8
In-Reply-To: <bug-24509-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24509-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24509-70-nT3Q4mEzec@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24509

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |martin.renvoize at ptfs-europe
                   |                            |.com, tomascohen at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 24 11:44:18 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Jan 2020 10:44:18 +0000
Subject: [Koha-bugs] [Bug 24507] Checkouts/ReturnClaim.t is failing on MySQL
 8
In-Reply-To: <bug-24507-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24507-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24507-70-y3Qz5POT2F@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24507

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |martin.renvoize at ptfs-europe
                   |                            |.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 24 11:54:01 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Jan 2020 10:54:01 +0000
Subject: [Koha-bugs] [Bug 24508] Perl version stops upgrade
In-Reply-To: <bug-24508-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24508-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24508-70-lzu1RbKyk0@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24508

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de,
                   |                            |martin.renvoize at ptfs-europe
                   |                            |.com,
                   |                            |mirko at abunchofthings.net,
                   |                            |mtj at kohaaloha.com
          Component|Installation and upgrade    |Packaging
                   |(command-line installer)    |

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 24 12:15:45 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Jan 2020 11:15:45 +0000
Subject: [Koha-bugs] [Bug 20718] Add ability to have lists that are
 available to all list editors
In-Reply-To: <bug-20718-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20718-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20718-70-Huc8OZNpeu@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20718

Fiona Borthwick <fiona.borthwick at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |fiona.borthwick at ptfs-europe
                   |                            |.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 24 12:16:58 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Jan 2020 11:16:58 +0000
Subject: [Koha-bugs] [Bug 24509] API related tests failing on MySQL8
In-Reply-To: <bug-24509-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24509-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24509-70-tPLUnV088z@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24509

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|chris at bigballofwax.co.nz    |tomascohen at gmail.com
           Severity|major                       |normal
            Version|unspecified                 |master

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 24 12:26:39 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Jan 2020 11:26:39 +0000
Subject: [Koha-bugs] [Bug 24305] Batch Item modification via item number in
 reports does not work with CONCAT in report
In-Reply-To: <bug-24305-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24305-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24305-70-7jwybwWv1n@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24305

--- Comment #8 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Figured out how you should use the square brackets in a SQL query in Reporting.
Well documented?
You can do:
SELECT [[items.biblionumber|bieb]]
This becomes SELECT items.biblionumber AS bieb
Not sure why we need it if using "AS" is just as easy but anyway.
Adding a few comment lines in the code with a follow-up.

Using this construct does not work with the == 'biblionumber' test. Adding one
extra line in get_prepped_report for that as well. This is consistent with the
headers filled by $sth->{NAME}.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 24 12:27:20 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Jan 2020 11:27:20 +0000
Subject: [Koha-bugs] [Bug 24305] Batch Item modification via item number in
 reports does not work with CONCAT in report
In-Reply-To: <bug-24305-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24305-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24305-70-CYLehrBG9E@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24305

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Small patch
             Status|BLOCKED                     |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 24 12:27:23 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Jan 2020 11:27:23 +0000
Subject: [Koha-bugs] [Bug 24305] Batch Item modification via item number in
 reports does not work with CONCAT in report
In-Reply-To: <bug-24305-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24305-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24305-70-yR6x8ihcvx@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24305

--- Comment #9 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 97866
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97866&action=edit
Bug 24305: (QA follow-up) Strip table name in [[table.field|alias]]

When you would use the construct, you wont have batch features unless
we strip the table name. This is consistent with the $sth->{NAME} used
to fill the headers by default.

Test plan:
Use [[items.biblionumber|bibno]] instead of items.biblionumber in a
reporting query.

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 24 12:27:42 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Jan 2020 11:27:42 +0000
Subject: [Koha-bugs] [Bug 24305] Batch Item modification via item number in
 reports does not work with CONCAT in report
In-Reply-To: <bug-24305-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24305-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24305-70-4yJcKfmG2l@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24305

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #96629|0                           |1
        is obsolete|                            |

--- Comment #10 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 97867
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97867&action=edit
Bug 24305: Fix links to batch tools when report's columns do not contain
integers

If report's columns do not only contain integers, we should not point to
batch tools.
For instance, if the value is a link, the batch tools will not work as
they will not retrieve the id (itemnnumber or biblionumber) properly

Test plan:
Create a report like:
    SELECT CONCAT('<a
href=\"/cgi-bin/koha/cataloguing/additem.pl?op=edititem&biblionumber=',
biblionumber, '&itemnumber=', itemnumber, '#edititem', '\">', itemnumber,
'</a>' ) AS itemnumber
    FROM items
    LIMIT 10;
Execute it
=> There is not link to the batch tools

Edit the report like:
    SELECT itemnumber
    FROM items
    LIMIT 10;
Execute it
=> There is a link to the batch tools

Edit the report like

    SELECT itemnumber, CONCAT('<a
href=\"/cgi-bin/koha/cataloguing/additem.pl?op=edititem&biblionumber=',
biblionumber, '&itemnumber=', itemnumber, '#edititem', '\">', itemnumber,
'</a>' ) AS itemnumber
    FROM items
    LIMIT 10;
Execute it
=> There is link to the batch tools

Try other combinations with biblionumber.

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 24 12:27:46 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Jan 2020 11:27:46 +0000
Subject: [Koha-bugs] [Bug 24305] Batch Item modification via item number in
 reports does not work with CONCAT in report
In-Reply-To: <bug-24305-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24305-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24305-70-GXat2szE0W@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24305

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #97829|0                           |1
        is obsolete|                            |

--- Comment #11 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 97868
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97868&action=edit
Bug 24305: Remove previous declaration of batch_biblionumbers

We should not init batch_biblionumbers before.
Also this patch deals with batch_cardnumbers.

Signed-off-by: Holly Cooper <hc at interleaf.ie>

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 24 12:27:50 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Jan 2020 11:27:50 +0000
Subject: [Koha-bugs] [Bug 24305] Batch Item modification via item number in
 reports does not work with CONCAT in report
In-Reply-To: <bug-24305-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24305-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24305-70-nVKyKmTIBJ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24305

--- Comment #12 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 97869
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97869&action=edit
Bug 24305: (follow-up) Add small comment for square brackets in
get_prepped_report

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 24 12:27:54 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Jan 2020 11:27:54 +0000
Subject: [Koha-bugs] [Bug 24305] Batch Item modification via item number in
 reports does not work with CONCAT in report
In-Reply-To: <bug-24305-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24305-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24305-70-lHkUXjQ6Vp@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24305

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #97866|0                           |1
        is obsolete|                            |

--- Comment #13 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 97870
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97870&action=edit
Bug 24305: (QA follow-up) Strip table name in [[table.field|alias]]

When you would use the construct, you wont have batch features unless
we strip the table name. This is consistent with the $sth->{NAME} used
to fill the headers by default.

Test plan:
Use [[items.biblionumber|bibno]] instead of items.biblionumber in a
reporting query.

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 24 12:28:20 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Jan 2020 11:28:20 +0000
Subject: [Koha-bugs] [Bug 24305] Batch Item modification via item number in
 reports does not work with CONCAT in report
In-Reply-To: <bug-24305-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24305-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24305-70-sYv6buH2Im@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24305

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl
                   |y.org                       |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 24 12:29:25 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Jan 2020 11:29:25 +0000
Subject: [Koha-bugs] [Bug 24305] Batch Item modification via item number in
 reports does not work with CONCAT in report
In-Reply-To: <bug-24305-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24305-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24305-70-BoOSoWek8U@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24305

--- Comment #14 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Still one question remaining. No blocker for me.

+            <textarea style="display:none" name="cardnumberlist"
id="cardnumberlist">[% FOREACH result IN results %][% FOREACH cells IN
result.cells %][% place = loop.index %][% IF header_row.$place.cell ==
'cardnumber' || header_types.item(header_row.$place.cell) == 'cardnumber' &&
cells.cell.match('^(\d+)$') %][% SET batch_cardnumbers = 1 %]

Why do you check on only digits for cardnumber here? The field cardnumber is a
varchar ?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 24 12:37:06 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Jan 2020 11:37:06 +0000
Subject: [Koha-bugs] [Bug 24508] Perl version stops upgrade
In-Reply-To: <bug-24508-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24508-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24508-70-EGdShvaTIb@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24508

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |13937
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org

--- Comment #1 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
The dependency has been added by bug 13937, that is part of 19.11 indeed.

libnet-z3950-simpleserver-perl is not available in Jessie (which we are going
to stop supporting soon), but it should not be mandatory, but optional.


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13937
[Bug 13937] Add an Elasticsearch-compatible Z39.50/SRU daemon
-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 24 12:37:06 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Jan 2020 11:37:06 +0000
Subject: [Koha-bugs] [Bug 13937] Add an Elasticsearch-compatible Z39.50/SRU
 daemon
In-Reply-To: <bug-13937-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13937-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13937-70-3FktkTMxZK@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13937

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |24508


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24508
[Bug 24508] Perl version stops upgrade
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 24 12:46:24 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Jan 2020 11:46:24 +0000
Subject: [Koha-bugs] [Bug 24305] Batch Item modification via item number in
 reports does not work with CONCAT in report
In-Reply-To: <bug-24305-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24305-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24305-70-Nb4LNKh67V@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24305

--- Comment #15 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
that's wrong then :)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 24 12:50:22 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Jan 2020 11:50:22 +0000
Subject: [Koha-bugs] [Bug 24505] Print overdue notice with html gives
 message: "The following terms were not matched and replaced"
In-Reply-To: <bug-24505-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24505-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24505-70-ZYP8UlSFDb@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24505

Stefan Norinder <somesecretemail at mailinator.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=10720

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 24 12:50:22 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Jan 2020 11:50:22 +0000
Subject: [Koha-bugs] [Bug 10720] Substitution term in overdue notices
 shouldn't be removed even if they don't match
In-Reply-To: <bug-10720-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-10720-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10720-70-UtaFP4nbPX@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10720

Stefan Norinder <somesecretemail at mailinator.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=24505

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 24 12:55:10 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Jan 2020 11:55:10 +0000
Subject: [Koha-bugs] [Bug 24490] Clarify wording and function of Purchase
 Items link on POS
In-Reply-To: <bug-24490-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24490-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24490-70-CRX46EMVM5@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24490

--- Comment #1 from David Roberts <david.roberts at ptfs-europe.com> ---
Created attachment 97872
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97872&action=edit
Bug 24490: Clarify wording and function of Purchase Items link on POS

This patch changes the wording of the links on the POS side menu

To test:

1) Apply the patch
2) Check that the links on the left hand side of the screen read
"Configure Cash Registers" and "Configure Items for Purchase"
3) Click both links to ensure you are taken to the relevant config
pages.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 24 12:56:14 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Jan 2020 11:56:14 +0000
Subject: [Koha-bugs] [Bug 24483] When batch deleting patrons,
 report who was not deleted and why
In-Reply-To: <bug-24483-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24483-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24483-70-DeRD4gP8Xk@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24483

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org
           Severity|normal                      |enhancement

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 24 12:56:43 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Jan 2020 11:56:43 +0000
Subject: [Koha-bugs] [Bug 24490] Clarify wording and function of Purchase
 Items link on POS
In-Reply-To: <bug-24490-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24490-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24490-70-oPdbppi84U@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24490

David Roberts <david.roberts at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

--- Comment #2 from David Roberts <david.roberts at ptfs-europe.com> ---
I decided to change the wording on both of the links on the POS page to
"Configure Cash Registers" and "Configure Items for Sale". This makes it
immediately clear what are the purpose of the two links.

To test:

1) Apply the patch
2) Check that the links on the left hand side of the screen read
"Configure Cash Registers" and "Configure Items for Purchase"
3) Click both links to ensure you are taken to the relevant config
pages.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 24 12:57:38 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Jan 2020 11:57:38 +0000
Subject: [Koha-bugs] [Bug 4042] Public OPAC search can fall prey to web
 crawlers
In-Reply-To: <bug-4042-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-4042-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-4042-70-m8U17MCG9D@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4042

clodagh.kerin at educampus.ie changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |clodagh.kerin at educampus.ie

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 24 13:20:53 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Jan 2020 12:20:53 +0000
Subject: [Koha-bugs] [Bug 24509] API related tests failing on MySQL8
In-Reply-To: <bug-24509-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24509-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24509-70-yAnFm0N9np@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24509

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 24 13:24:54 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Jan 2020 12:24:54 +0000
Subject: [Koha-bugs] [Bug 20708] Withdrawn status should show when placing a
 request in staff client
In-Reply-To: <bug-20708-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20708-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20708-70-ayJRNojSDv@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20708

Kelly McElligott <kelly at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |kelly at bywatersolutions.com

--- Comment #2 from Kelly McElligott <kelly at bywatersolutions.com> ---
I think this is a valid bug.  Koha recently made the item display as Damaged if
it were in fact damaged when placing a hold and this allows staff to see that
the item that is possibly being placed on hold is Withdrawn.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 24 13:24:55 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Jan 2020 12:24:55 +0000
Subject: [Koha-bugs] [Bug 22359] Improve usability of 'change calculation'
 (bug 11373)
In-Reply-To: <bug-22359-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22359-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22359-70-PqpkesrZTn@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22359

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #97840|0                           |1
        is obsolete|                            |

--- Comment #23 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 97873
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97873&action=edit
Bug 22359: Improvements to payment collection inputs

This patch attempts to clarify the uses of the various input fields on
the paycollect screens.

It does this by adding validation to the form such that entering a
'collected' value that is lower than the 'paid' value is now forbidden.

Signed-off-by: Michal Denar <black23 at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 24 13:24:59 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Jan 2020 12:24:59 +0000
Subject: [Koha-bugs] [Bug 22359] Improve usability of 'change calculation'
 (bug 11373)
In-Reply-To: <bug-22359-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22359-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22359-70-axs8QbmUII@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22359

--- Comment #24 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 97874
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97874&action=edit
Bug 22359: Prevent undercollection at the server

This patch adds some additional handling to prevent undercollection of
fees at the server side.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 24 13:26:45 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Jan 2020 12:26:45 +0000
Subject: [Koha-bugs] [Bug 24509] API related tests failing on MySQL8
In-Reply-To: <bug-24509-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24509-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24509-70-IuQvLFUXIm@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24509

--- Comment #1 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 97875
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97875&action=edit
Bug 24509: Fix tests failing on MySQL8

This patch makes a trivial change to the tests so they catch the way
MySQL 8 reports the duplicate key message. The difference on the API
error message is irrelevant and so it is ok to just make the tests try
both MySQL 8 output and the rest of the supported engines.

To test:
1. Run:
   $ kshell
  k$ prove t/db_dependent/api/v1/acquisitions_orders.t \
           t/db_dependent/api/v1/libraries.t \
           t/db_dependent/api/v1/patrons.t
=> FAIL: Tests fail due to warning and conflict message differences
2. Apply this patch
3. Repeat 1
=> SUCCESS: Tests pass!
4. Sign off :-D

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 24 13:29:13 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Jan 2020 12:29:13 +0000
Subject: [Koha-bugs] [Bug 24507] Checkouts/ReturnClaim.t is failing on MySQL
 8
In-Reply-To: <bug-24507-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24507-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24507-70-q7tD7yCgJs@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24507

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #97864|0                           |1
        is obsolete|                            |

--- Comment #2 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 97876
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97876&action=edit
Bug 24507: Make Checkouts/ReturnClaim.t pass on MySQL 8

 $ prove t/db_dependent/Koha/Checkouts/ReturnClaim.t
 t/db_dependent/Koha/Checkouts/ReturnClaim.t ..
     #   Failed test 'Exception field is correct'
     #   at t/db_dependent/Koha/Checkouts/ReturnClaim.t line 97.
     #          got: 'return_claims.issue_id'
     #     expected: 'issue_id'
     # Looks like you failed 1 test of 8.
 t/db_dependent/Koha/Checkouts/ReturnClaim.t .. 1/1
 #   Failed test 'store() tests'
 #   at t/db_dependent/Koha/Checkouts/ReturnClaim.t line 133.

This is similar to bug 23825.

Test plan:
Confirm that the tests pass on MySQL8 and MariaDB

Signed-off-by: Tomás Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 24 13:29:18 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Jan 2020 12:29:18 +0000
Subject: [Koha-bugs] [Bug 22359] Improve usability of 'change calculation'
 (bug 11373)
In-Reply-To: <bug-22359-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22359-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22359-70-fdfdYrn9Xm@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22359

--- Comment #25 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
(In reply to Michal Denar from comment #22)
> I partically agree with Andrew that solution and texts are "inaccurate". But
> "Collected from patron" has field for calculation function. So if we talk
> about partially write off feature, we should use clear way that every
> librarian user understand from UI&texts. Maybe like https://prnt.sc/qs0raw

I think that's a different enhancement and should be logged as it's own bug..
I'm really just trying to clarify the existing functionality as it stands...

I've attached a followup that prevents undercollection at the server end and
returns an error message.

However, I'm still stuck on the clientside validation, it seems that our jquery
validate library simply falls over at a value of 100 for 'minimum'.. I've
reported a bug upstream and spend ages trying to debug it.

Bug: https://github.com/jquery-validation/jquery-validation/issues/2311
Fiddle: https://jsfiddle.net/ashimema/1uxysdap/17/

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 24 13:29:37 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Jan 2020 12:29:37 +0000
Subject: [Koha-bugs] [Bug 24507] Checkouts/ReturnClaim.t is failing on MySQL
 8
In-Reply-To: <bug-24507-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24507-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24507-70-qii1w8F1T8@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24507

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off
            Version|unspecified                 |master
                 CC|                            |tomascohen at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 24 13:30:01 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Jan 2020 12:30:01 +0000
Subject: [Koha-bugs] [Bug 24507] Checkouts/ReturnClaim.t is failing on MySQL
 8
In-Reply-To: <bug-24507-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24507-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24507-70-rJ6dTILRbA@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24507

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

--- Comment #3 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Trivial fix, tested on ku-my8. Passing QA.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 24 13:37:13 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Jan 2020 12:37:13 +0000
Subject: [Koha-bugs] [Bug 22359] Improve usability of 'change calculation'
 (bug 11373)
In-Reply-To: <bug-22359-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22359-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22359-70-3kaMhyg9n0@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22359

--- Comment #26 from Andrew Fuerste-Henry <andrew at bywatersolutions.com> ---
See bug 24495 for changing the wording on this interface.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 24 13:37:50 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Jan 2020 12:37:50 +0000
Subject: [Koha-bugs] [Bug 22359] Improve usability of 'change calculation'
 (bug 11373)
In-Reply-To: <bug-22359-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22359-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22359-70-VPerzpFByc@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22359

ByWater Sandboxes <bws.sandboxes at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #97873|0                           |1
        is obsolete|                            |

--- Comment #27 from ByWater Sandboxes <bws.sandboxes at gmail.com> ---
Created attachment 97877
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97877&action=edit
Bug 22359: Improvements to payment collection inputs

This patch attempts to clarify the uses of the various input fields on
the paycollect screens.

It does this by adding validation to the form such that entering a
'collected' value that is lower than the 'paid' value is now forbidden.

Signed-off-by: Michal Denar <black23 at gmail.com>

Signed-off-by: Andrew Fuerste-Henry <andrew at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 24 13:37:54 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Jan 2020 12:37:54 +0000
Subject: [Koha-bugs] [Bug 22359] Improve usability of 'change calculation'
 (bug 11373)
In-Reply-To: <bug-22359-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22359-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22359-70-VjHvK6dxiI@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22359

ByWater Sandboxes <bws.sandboxes at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #97874|0                           |1
        is obsolete|                            |

--- Comment #28 from ByWater Sandboxes <bws.sandboxes at gmail.com> ---
Created attachment 97878
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97878&action=edit
Bug 22359: Prevent undercollection at the server

This patch adds some additional handling to prevent undercollection of
fees at the server side.

Signed-off-by: Andrew Fuerste-Henry <andrew at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 24 13:40:51 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Jan 2020 12:40:51 +0000
Subject: [Koha-bugs] [Bug 24508] Perl version stops upgrade
In-Reply-To: <bug-24508-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24508-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24508-70-YRMjOPYqPb@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24508

--- Comment #2 from Mason James <mtj at kohaaloha.com> ---
(In reply to Hans Pålsson from comment #0)
> In reference to bug 20808, when trying to upgrade 19.05.06 to 19.11.01 the
> installation fails due to dependencies. It seems Perl version 5.20.0 is
> required, on our server 5.28.1 is installed. Server is Debian Jessie;
> 
> PRETTY_NAME="Debian GNU/Linux 8 (jessie)"
> NAME="Debian GNU/Linux"
> VERSION_ID="8"
> VERSION="8 (jessie)"
> ID=debian
> 
> Error message is The following packages have unmet dependencies:
>  koha-common : Depends: libnet-z3950-simpleserver-perl but it is not going
> to be installed
> ...when searching for solutions it leads to wrong version of perl installed. 
> 
> The server has previously installed and upgraded Koha up to 19.05.06 without
> errors. Is it a dependence that has come with 19.11?

hi Hans

this problem seems to be caused by your system running a deb10 version of perl
on deb8

https://packages.debian.org/jessie/perl v5.20
https://packages.debian.org/buster/perl v5.28

my advice would be to attempt to build and install a
libnet-z3950-simpleserver-perl package for your specific system

https://packages.debian.org/source/jessie/libnet-z3950-simpleserver-perl

or install a 5.20 perl, or upgrade to deb10

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 24 13:42:24 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Jan 2020 12:42:24 +0000
Subject: [Koha-bugs] [Bug 24508] Perl version stops upgrade
In-Reply-To: <bug-24508-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24508-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24508-70-u3tLyEgSWv@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24508

--- Comment #3 from Mason James <mtj at kohaaloha.com> ---
(In reply to Jonathan Druart from comment #1)
> The dependency has been added by bug 13937, that is part of 19.11 indeed.
> 
> libnet-z3950-simpleserver-perl is not available in Jessie (which we are
> going to stop supporting soon), but it should not be mandatory, but optional.

hi Jonathan, there is a version for jessie

 https://packages.debian.org/jessie/libnet-z3950-simpleserver-perl

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 24 13:43:16 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Jan 2020 12:43:16 +0000
Subject: [Koha-bugs] [Bug 22359] Improve usability of 'change calculation'
 (bug 11373)
In-Reply-To: <bug-22359-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22359-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22359-70-qx4Obz9mxG@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22359

--- Comment #29 from Andrew Fuerste-Henry <andrew at bywatersolutions.com> ---
I'm signing this off, as it did block me from submitting a payment where
collected < paid. But one non-blocking bit of weirdness -- it gives me
different error messages depending on whether or not I'm paying off the whole
fine.

If amount being paid = total amount payable and amount collected < amount being
paid, Koha lets me click confirm and then pops up a big yellow alert saying
"You must collect a value greater than or equal to [amount being paid]".

If amount being paid < total amount payable and amount collected < amount being
paid, Koha immediately makes amount collected red and adds a little red message
next to it reading "Please enter a value greater than or equal to [amount being
paid]."

So, it works, but the inconsistency is weird.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 24 13:46:18 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Jan 2020 12:46:18 +0000
Subject: [Koha-bugs] [Bug 24490] Clarify wording and function of Purchase
 Items link on POS
In-Reply-To: <bug-24490-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24490-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24490-70-lkguJOHCkt@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24490

ByWater Sandboxes <bws.sandboxes at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #97872|0                           |1
        is obsolete|                            |

--- Comment #3 from ByWater Sandboxes <bws.sandboxes at gmail.com> ---
Created attachment 97879
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97879&action=edit
Bug 24490: Clarify wording and function of Purchase Items link on POS

This patch changes the wording of the links on the POS side menu

To test:

1) Apply the patch
2) Check that the links on the left hand side of the screen read
"Configure Cash Registers" and "Configure Items for Purchase"
3) Click both links to ensure you are taken to the relevant config
pages.

Signed-off-by: Andrew Fuerste-Henry <andrew at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 24 13:46:36 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Jan 2020 12:46:36 +0000
Subject: [Koha-bugs] [Bug 24490] Clarify wording and function of Purchase
 Items link on POS
In-Reply-To: <bug-24490-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24490-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24490-70-cFKSX6ycEu@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24490

Andrew Fuerste-Henry <andrew at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 24 13:46:42 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Jan 2020 12:46:42 +0000
Subject: [Koha-bugs] [Bug 24508] Perl version stops upgrade
In-Reply-To: <bug-24508-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24508-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24508-70-LLdgiaRwby@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24508

--- Comment #4 from Mason James <mtj at kohaaloha.com> ---

> hi Hans
> 
> this problem seems to be caused by your system running a deb10 version of
> perl on deb8
> 
> https://packages.debian.org/jessie/perl v5.20
> https://packages.debian.org/buster/perl v5.28
> 
> my advice would be to attempt to build and install a
> libnet-z3950-simpleserver-perl package for your specific system
> 
> https://packages.debian.org/source/jessie/libnet-z3950-simpleserver-perl
> 
> or install a 5.20 perl, or upgrade to deb10

or attempt to install a deb10 version of the package
 https://packages.debian.org/buster/libnet-z3950-simpleserver-perl

this might be tricky as there looks to be other dependancies for the package,
which you will need to install too

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 24 13:46:49 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Jan 2020 12:46:49 +0000
Subject: [Koha-bugs] [Bug 24490] Clarify wording and function of Purchase
 Items link on POS
In-Reply-To: <bug-24490-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24490-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24490-70-mMlt5pQmxB@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24490

--- Comment #4 from Andrew Fuerste-Henry <andrew at bywatersolutions.com> ---
Looks good, thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 24 13:51:11 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Jan 2020 12:51:11 +0000
Subject: [Koha-bugs] [Bug 24509] API related tests failing on MySQL8
In-Reply-To: <bug-24509-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24509-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24509-70-Ape3Z4Kp1J@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24509

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 24 13:51:14 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Jan 2020 12:51:14 +0000
Subject: [Koha-bugs] [Bug 24509] API related tests failing on MySQL8
In-Reply-To: <bug-24509-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24509-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24509-70-6mYSV01eul@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24509

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #97875|0                           |1
        is obsolete|                            |

--- Comment #2 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 97880
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97880&action=edit
Bug 24509: Fix API relared tests failing on MySQL8

This patch makes a trivial change to the tests so they catch the way
MySQL 8 reports the duplicate key message. The difference on the API
error message is irrelevant and so it is ok to just make the tests try
both MySQL 8 output and the rest of the supported engines.

To test:
1. Run:
   $ kshell
  k$ prove t/db_dependent/api/v1/acquisitions_orders.t \
           t/db_dependent/api/v1/libraries.t \
           t/db_dependent/api/v1/patrons.t
=> FAIL: Tests fail due to warning and conflict message differences
2. Apply this patch
3. Repeat 1
=> SUCCESS: Tests pass!
4. Sign off :-D

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 24 13:51:28 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Jan 2020 12:51:28 +0000
Subject: [Koha-bugs] [Bug 24509] API related tests failing on MySQL8
In-Reply-To: <bug-24509-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24509-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24509-70-TrvuGjl4MR@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24509

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

--- Comment #3 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Thanks Tomas!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 24 13:59:16 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Jan 2020 12:59:16 +0000
Subject: [Koha-bugs] [Bug 24508] Perl version stops upgrade
In-Reply-To: <bug-24508-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24508-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24508-70-QM22mSBs0c@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24508

--- Comment #5 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Indeed!
https://packages.debian.org/search?keywords=libnet-z3950-simpleserver-perl
I did not notice that the search defaulted to "stable" only!

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 24 14:44:14 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Jan 2020 13:44:14 +0000
Subject: [Koha-bugs] [Bug 24421] Generated authorities are missing subfields
In-Reply-To: <bug-24421-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24421-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24421-70-DwD1jZAZvT@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24421

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 24 14:44:17 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Jan 2020 13:44:17 +0000
Subject: [Koha-bugs] [Bug 24421] Generated authorities are missing subfields
In-Reply-To: <bug-24421-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24421-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24421-70-QJKzzTtA2H@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24421

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #97583|0                           |1
        is obsolete|                            |

--- Comment #6 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 97881
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97881&action=edit
Bug 24421: Unit tests

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 24 14:44:20 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Jan 2020 13:44:20 +0000
Subject: [Koha-bugs] [Bug 24421] Generated authorities are missing subfields
In-Reply-To: <bug-24421-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24421-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24421-70-GtJygx18Zl@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24421

--- Comment #7 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 97882
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97882&action=edit
Bug 24421: Check if subfields are valid using the biblio tag

To test:
 1 - Enable the sysprefs
     AutoCreateAuthorities
     BiblioAddsAuthorities
     CatalogModuleRelink
 2 - Open a record with a subject heading with a subdivision and add a new
subfield, or add a new unauthroized heading to a record and save it
    e.g. 650$aChess$xOpenings$vFiction.
 3 - Save the record, note the created authority and that field is linked
 4 - Save the record again and note the authority number changes
 5 - Find and view the authority linked to the record
 6 - The record is for 'Chess', not Chess openings'
 7 - Search authorities for 'Chess' - note duplicated records
 8 - Apply patch, restart all
 9 - Save the record, auth number increases again, we shoudl create the correct
record this time
10 - Save again, auth number should not change
11 - Search authorities and confirm the generated authority has the correct
subfields

Signed-off-by: Myka Kennedy Stephens <mkstephens at lancasterseminary.edu>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 24 15:23:51 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Jan 2020 14:23:51 +0000
Subject: [Koha-bugs] [Bug 18186] Plack config: Amounts with decimal comma
 instead of decimal dot breaking payments
In-Reply-To: <bug-18186-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18186-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18186-70-MTvVDUDtQl@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18186

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |tomascohen at gmail.com

--- Comment #4 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
So, if you fix some variables:
- browser,
- browser locale
- settings in Koha

then if you switch the locale and restart plack the behaviour change?

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 24 15:30:19 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Jan 2020 14:30:19 +0000
Subject: [Koha-bugs] [Bug 24510] New: When Placing a Hold,
 cursor doesn't focus on Patron Name
Message-ID: <bug-24510-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24510

            Bug ID: 24510
           Summary: When Placing a Hold, cursor doesn't focus on Patron
                    Name
 Change sponsored?: ---
           Product: Koha
           Version: 19.11
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Hold requests
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: kelly at bywatersolutions.com
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com

To reproduce: 

1. Go to Biblio Record
2. Place Hold (request.pl) - either the Hold above the Bib or the Hold on the
left, it does the same thing. 
3. Note that the cursor does not go to Patron Name (for whom to place the hold
for), it goes to the Top Search bar under Checkout.  

In 19.05, the cursor does go to the Patron Name during this process and that
makes sense from a workflow standpoint.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 24 15:34:25 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Jan 2020 14:34:25 +0000
Subject: [Koha-bugs] [Bug 24488] Holds to Pull sometimes shows the wrong
 'first patron' details
In-Reply-To: <bug-24488-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24488-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24488-70-YLfCdAqiWF@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24488

Kelly McElligott <kelly at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |kelly at bywatersolutions.com

--- Comment #2 from Kelly McElligott <kelly at bywatersolutions.com> ---
Aleisha- something odd- nothing is showing in the Holds To Pull report.  I have
tried this multiple times and unable to get the holds to populate. Both biblio
and Item level holds.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 24 15:36:46 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Jan 2020 14:36:46 +0000
Subject: [Koha-bugs] [Bug 20443] Move C4::Members::Attributes to Koha
 namespace
In-Reply-To: <bug-20443-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20443-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20443-70-GJw59Q140q@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20443

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         QA Contact|testopia at bugs.koha-communit |tomascohen at gmail.com
                   |y.org                       |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 24 15:38:16 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Jan 2020 14:38:16 +0000
Subject: [Koha-bugs] [Bug 24486] Account Wording Information is duplicated
 in Patron's Fines Tab on OPAC
In-Reply-To: <bug-24486-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24486-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24486-70-uAke6vKI1n@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24486

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |23115
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org

--- Comment #1 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Caused by
  commit efc21e6f47801503e55e3ba709a48c3f426f90ac
  Bug 23115: (follow-up) Move switches to a TT block


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23115
[Bug 23115] Totals are unclear when a credit is involved on the OPAC 'Fines and
charges' screen
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 24 15:38:16 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Jan 2020 14:38:16 +0000
Subject: [Koha-bugs] [Bug 23115] Totals are unclear when a credit is
 involved on the OPAC 'Fines and charges' screen
In-Reply-To: <bug-23115-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23115-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23115-70-6h2hoW4avX@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23115

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |24486


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24486
[Bug 24486] Account Wording Information is duplicated in Patron's Fines Tab on
OPAC
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 24 15:38:42 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Jan 2020 14:38:42 +0000
Subject: [Koha-bugs] [Bug 24486] Account Wording Information is duplicated
 in Patron's Fines Tab on OPAC
In-Reply-To: <bug-24486-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24486-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24486-70-DM5uVeCkuK@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24486

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|oleonard at myacpl.org         |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org
            Version|19.05                       |master
             Status|NEW                         |ASSIGNED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 24 15:42:10 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Jan 2020 14:42:10 +0000
Subject: [Koha-bugs] [Bug 24486] Account Wording Information is duplicated
 in Patron's Fines Tab on OPAC
In-Reply-To: <bug-24486-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24486-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24486-70-1oh29oViTV@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24486

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 24 15:42:13 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Jan 2020 14:42:13 +0000
Subject: [Koha-bugs] [Bug 24486] Account Wording Information is duplicated
 in Patron's Fines Tab on OPAC
In-Reply-To: <bug-24486-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24486-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24486-70-nv9rPx4XSD@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24486

--- Comment #2 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 97883
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97883&action=edit
Bug 24486: Remove duplicated account information at the OPAC

commit efc21e6f47801503e55e3ba709a48c3f426f90ac
  Bug 23115: (follow-up) Move switches to a TT block

Duplicated the following line:
+                        [% PROCESS account_type_description
account=ACCOUNT_LINE %]
                         [%- PROCESS account_status_description
account=ACCOUNT_LINE -%]

Which cause the info to appear twice

Test plan:
Create a manual invoice
Pay it
Void it

Go to the opac, account
=> You should see only one "(Voided)"

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 24 15:44:25 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Jan 2020 14:44:25 +0000
Subject: [Koha-bugs] [Bug 24504] branchtransfers.pl - Entering checked out
 item cause Internal Server Error
In-Reply-To: <bug-24504-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24504-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24504-70-H46bkVRWTj@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24504

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org

--- Comment #1 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
It could help to know the error you have in the Koha log file.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 24 15:46:42 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Jan 2020 14:46:42 +0000
Subject: [Koha-bugs] [Bug 24504] branchtransfers.pl - Entering checked out
 item cause Internal Server Error
In-Reply-To: <bug-24504-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24504-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24504-70-kCDiREAy2s@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24504

--- Comment #2 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Which exact version of Koha?

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 24 15:58:22 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Jan 2020 14:58:22 +0000
Subject: [Koha-bugs] [Bug 24511] New: Patron emailer report not using
 specified email column
Message-ID: <bug-24511-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24511

            Bug ID: 24511
           Summary: Patron emailer report not using specified email column
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: Command-line Utilities
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: nick at bywatersolutions.com
        QA Contact: testopia at bugs.koha-community.org
                CC: robin at catalyst.net.nz

The script takes a specific column to use as the to email address, however, due
to variable confusion, the column is not respected

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 24 16:03:44 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Jan 2020 15:03:44 +0000
Subject: [Koha-bugs] [Bug 18936] Convert issuingrules fields to
 circulation_rules
In-Reply-To: <bug-18936-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18936-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18936-70-pRusmFOZ9B@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18936

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         QA Contact|kyle at bywatersolutions.com   |joonas.kylmala at helsinki.fi

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 24 16:03:51 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Jan 2020 15:03:51 +0000
Subject: [Koha-bugs] [Bug 24511] Patron emailer report not using specified
 email column
In-Reply-To: <bug-24511-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24511-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24511-70-sV8ZG1rfny@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24511

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Trivial patch
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 24 16:03:54 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Jan 2020 15:03:54 +0000
Subject: [Koha-bugs] [Bug 24511] Patron emailer report not using specified
 email column
In-Reply-To: <bug-24511-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24511-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24511-70-8QFIfhdyvM@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24511

--- Comment #1 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 97884
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97884&action=edit
Bug 24511: Update variable names to avoid confusion

To test:
1 - Create a report
    SELECT borrowernumber, firstname, surname, email, emailpro FROM borrowers
WHERE surname='acosta'
2 - Create or edit patron with surname acosta to have a separate email and
emailpro
3 - perl misc/cronjobs/patron_emailer --notice HOLDS --module reserves
--verbose --email emailpro --report ## --from 'me at you.us'
4 - Note email is used, not email pro
5 - Apply patch
6 - Repeat, correct eamil is used

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 24 16:08:41 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Jan 2020 15:08:41 +0000
Subject: [Koha-bugs] [Bug 24512] New: Should be able to have
 'hidden'/'administrative' branches
Message-ID: <bug-24512-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24512

            Bug ID: 24512
           Summary: Should be able to have 'hidden'/'administrative'
                    branches
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: System Administration
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: nick at bywatersolutions.com
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com

Some libraries have branches that are not for the public, or are used for
statistics etc.

It would be nice to be able to define a branch as 'hidden' in administration
and make sure it is not shown in opac dropdowns for search etc.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 24 16:10:43 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Jan 2020 15:10:43 +0000
Subject: [Koha-bugs] [Bug 24513] New: Should have SIPRenewalBranch
 preference like OpacRenewalBranch
Message-ID: <bug-24513-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24513

            Bug ID: 24513
           Summary: Should have SIPRenewalBranch preference like
                    OpacRenewalBranch
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: SIP2
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: nick at bywatersolutions.com
        QA Contact: testopia at bugs.koha-community.org
                CC: colin.campbell at ptfs-europe.com

Some libraries have services that operate via SIP but allow users to renew from
home. In this case the statistics records the branch of the SIP user, it would
be nice to allow other options so the renewal could be counted for the issuing
branch without requiring a SIP user per branch

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 24 16:12:16 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Jan 2020 15:12:16 +0000
Subject: [Koha-bugs] [Bug 24513] Should have SIPRenewalBranch preference
 like OpacRenewalBranch
In-Reply-To: <bug-24513-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24513-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24513-70-iemY9PXsQ7@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24513

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |kyle at bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 24 16:15:06 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Jan 2020 15:15:06 +0000
Subject: [Koha-bugs] [Bug 22359] Improve usability of 'change calculation'
 (bug 11373)
In-Reply-To: <bug-22359-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22359-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22359-70-BcAaAQ7ZOQ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22359

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #97877|0                           |1
        is obsolete|                            |

--- Comment #30 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 97885
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97885&action=edit
Bug 22359: Improvements to payment collection inputs

This patch attempts to clarify the uses of the various input fields on
the paycollect screens.

It does this by adding validation to the form such that entering a
'collected' value that is lower than the 'paid' value is now forbidden.

Signed-off-by: Michal Denar <black23 at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 24 16:15:09 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Jan 2020 15:15:09 +0000
Subject: [Koha-bugs] [Bug 22359] Improve usability of 'change calculation'
 (bug 11373)
In-Reply-To: <bug-22359-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22359-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22359-70-UEXcmUcAJz@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22359

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #97878|0                           |1
        is obsolete|                            |

--- Comment #31 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 97886
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97886&action=edit
Bug 22359: Prevent undercollection at the server

This patch adds some additional handling to prevent undercollection of
fees at the server side.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 24 16:15:34 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Jan 2020 15:15:34 +0000
Subject: [Koha-bugs] [Bug 22359] Improve usability of 'change calculation'
 (bug 11373)
In-Reply-To: <bug-22359-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22359-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22359-70-U3mIyHoSyk@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22359

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 24 16:15:55 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Jan 2020 15:15:55 +0000
Subject: [Koha-bugs] [Bug 22359] Improve usability of 'change calculation'
 (bug 11373)
In-Reply-To: <bug-22359-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22359-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22359-70-SBUpYAI0s5@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22359

--- Comment #32 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
The issues should all be fixed now.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 24 16:21:06 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Jan 2020 15:21:06 +0000
Subject: [Koha-bugs] [Bug 23407] XSLT Details pages don't use items,
 we shouldn't pass them
In-Reply-To: <bug-23407-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23407-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23407-70-B3AX3hrwzE@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23407

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|                            |20.05.00
        released in|                            |
             Status|Passed QA                   |Pushed to master

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 24 16:21:08 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Jan 2020 15:21:08 +0000
Subject: [Koha-bugs] [Bug 23407] XSLT Details pages don't use items,
 we shouldn't pass them
In-Reply-To: <bug-23407-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23407-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23407-70-4UoAWdIkTh@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23407

--- Comment #10 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Nice work everyone!

Pushed to master for 20.05

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 24 16:21:10 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Jan 2020 15:21:10 +0000
Subject: [Koha-bugs] [Bug 23443] Paying off a lost fee will return the item,
 even if it is checked out to a different patron
In-Reply-To: <bug-23443-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23443-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23443-70-dNBsXzj4zB@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23443

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|                            |20.05.00
        released in|                            |
             Status|Passed QA                   |Pushed to master

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 24 16:21:12 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Jan 2020 15:21:12 +0000
Subject: [Koha-bugs] [Bug 23443] Paying off a lost fee will return the item,
 even if it is checked out to a different patron
In-Reply-To: <bug-23443-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23443-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23443-70-4KgZV78pBW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23443

--- Comment #11 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Nice work everyone!

Pushed to master for 20.05

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 24 16:21:14 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Jan 2020 15:21:14 +0000
Subject: [Koha-bugs] [Bug 24305] Batch Item modification via item number in
 reports does not work with CONCAT in report
In-Reply-To: <bug-24305-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24305-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24305-70-AWf5SGKKOS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24305

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to master
         Version(s)|                            |20.05.00
        released in|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 24 16:21:16 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Jan 2020 15:21:16 +0000
Subject: [Koha-bugs] [Bug 24305] Batch Item modification via item number in
 reports does not work with CONCAT in report
In-Reply-To: <bug-24305-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24305-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24305-70-HJMvsbAwFB@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24305

--- Comment #16 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Nice work everyone!

Pushed to master for 20.05

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 24 16:21:18 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Jan 2020 15:21:18 +0000
Subject: [Koha-bugs] [Bug 24443] Consider NULL as 0 for issues in items
 search
In-Reply-To: <bug-24443-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24443-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24443-70-PqkPiElALR@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24443

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|                            |20.05.00
        released in|                            |
             Status|Passed QA                   |Pushed to master

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 24 16:21:20 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Jan 2020 15:21:20 +0000
Subject: [Koha-bugs] [Bug 24443] Consider NULL as 0 for issues in items
 search
In-Reply-To: <bug-24443-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24443-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24443-70-xeCSTOf5x4@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24443

--- Comment #14 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Nice work everyone!

Pushed to master for 20.05

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 24 16:21:21 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Jan 2020 15:21:21 +0000
Subject: [Koha-bugs] [Bug 24503] Missing use in value builder
 barcode_manual.pl
In-Reply-To: <bug-24503-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24503-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24503-70-OfESb3hY4T@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24503

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to master
         Version(s)|                            |20.05.00
        released in|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 24 16:21:23 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Jan 2020 15:21:23 +0000
Subject: [Koha-bugs] [Bug 24503] Missing use in value builder
 barcode_manual.pl
In-Reply-To: <bug-24503-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24503-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24503-70-SNcPwPQIM9@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24503

--- Comment #5 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Nice work everyone!

Pushed to master for 20.05

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 24 16:21:25 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Jan 2020 15:21:25 +0000
Subject: [Koha-bugs] [Bug 24507] Checkouts/ReturnClaim.t is failing on MySQL
 8
In-Reply-To: <bug-24507-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24507-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24507-70-MGu9uxgWg0@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24507

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|                            |20.05.00
        released in|                            |
             Status|Passed QA                   |Pushed to master

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 24 16:21:27 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Jan 2020 15:21:27 +0000
Subject: [Koha-bugs] [Bug 24507] Checkouts/ReturnClaim.t is failing on MySQL
 8
In-Reply-To: <bug-24507-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24507-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24507-70-nhhZyLQh4g@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24507

--- Comment #4 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Nice work everyone!

Pushed to master for 20.05

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 24 16:21:28 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Jan 2020 15:21:28 +0000
Subject: [Koha-bugs] [Bug 24509] API related tests failing on MySQL8
In-Reply-To: <bug-24509-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24509-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24509-70-okshQaiLkt@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24509

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|                            |20.05.00
        released in|                            |
             Status|Passed QA                   |Pushed to master

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 24 16:21:30 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Jan 2020 15:21:30 +0000
Subject: [Koha-bugs] [Bug 24509] API related tests failing on MySQL8
In-Reply-To: <bug-24509-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24509-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24509-70-XodFpAC4NF@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24509

--- Comment #4 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Nice work everyone!

Pushed to master for 20.05

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 24 16:23:40 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Jan 2020 15:23:40 +0000
Subject: [Koha-bugs] [Bug 24489] Prevent user from paying/writing off 0
In-Reply-To: <bug-24489-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24489-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24489-70-LEMXTDN9vF@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24489

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |14825


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14825
[Bug 14825] Accounts Rewrite Omnibus
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 24 16:23:40 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Jan 2020 15:23:40 +0000
Subject: [Koha-bugs] [Bug 14825] Accounts Rewrite Omnibus
In-Reply-To: <bug-14825-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14825-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14825-70-fNpjSP49uM@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14825

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |24489


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24489
[Bug 24489] Prevent user from paying/writing off 0
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 24 16:29:11 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Jan 2020 15:29:11 +0000
Subject: [Koha-bugs] [Bug 24339] SIP codes are missing from the default
 payment_types on installation
In-Reply-To: <bug-24339-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24339-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24339-70-bAB3ne7VAY@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24339

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |RM_priority

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 24 16:32:20 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Jan 2020 15:32:20 +0000
Subject: [Koha-bugs] [Bug 24152] Add the ability to purge pseudonymized data
In-Reply-To: <bug-24152-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24152-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24152-70-AVGC7UGhQc@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24152

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |RM_priority

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 24 16:33:30 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Jan 2020 15:33:30 +0000
Subject: [Koha-bugs] [Bug 23260] Anonymize (remove) patron data from
 items_last_borrower
In-Reply-To: <bug-23260-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23260-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23260-70-PiU6jLxNH4@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23260

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |RM_priority

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 24 16:35:20 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Jan 2020 15:35:20 +0000
Subject: [Koha-bugs] [Bug 24510] When Placing a Hold,
 cursor doesn't focus on Patron Name
In-Reply-To: <bug-24510-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24510-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24510-70-n8AuBIPFcr@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24510

Lucas Gass <lucas at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 24 16:35:23 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Jan 2020 15:35:23 +0000
Subject: [Koha-bugs] [Bug 24510] When Placing a Hold,
 cursor doesn't focus on Patron Name
In-Reply-To: <bug-24510-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24510-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24510-70-XN4QihE320@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24510

--- Comment #1 from Lucas Gass <lucas at bywatersolutions.com> ---
Created attachment 97887
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97887&action=edit
Bug 24510: Add focus to Patron/club input

TEST PLAN:
1. Go to Biblio Record
2. Place Hold (request.pl) - either the Hold above the Bib or the Hold on the
left, it does the same thing. 
3. Note that the cursor does not go to Patron Name (for whom to place the hold
for), it goes to the Top Search bar under Checkout.  
4. Apply patch and reload the page. 
5. The focus should now be correctly set.
6. Toggle between 'Patrons' and 'Club' tabs.
7. Focus should stay set.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 24 16:36:02 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Jan 2020 15:36:02 +0000
Subject: [Koha-bugs] [Bug 24510] When Placing a Hold,
 cursor doesn't focus on Patron Name
In-Reply-To: <bug-24510-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24510-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24510-70-hENpMQ1QjR@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24510

Lucas Gass <lucas at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |lucas at bywatersolutions.com
           Assignee|koha-bugs at lists.koha-commun |lucas at bywatersolutions.com
                   |ity.org                     |

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 24 16:36:46 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Jan 2020 15:36:46 +0000
Subject: [Koha-bugs] [Bug 22359] Improve usability of 'change calculation'
 (bug 11373)
In-Reply-To: <bug-22359-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22359-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22359-70-faW3n1dwHv@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22359

ByWater Sandboxes <bws.sandboxes at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #97885|0                           |1
        is obsolete|                            |

--- Comment #33 from ByWater Sandboxes <bws.sandboxes at gmail.com> ---
Created attachment 97888
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97888&action=edit
Bug 22359: Improvements to payment collection inputs

This patch attempts to clarify the uses of the various input fields on
the paycollect screens.

It does this by adding validation to the form such that entering a
'collected' value that is lower than the 'paid' value is now forbidden.

Signed-off-by: Michal Denar <black23 at gmail.com>

Signed-off-by: Andrew Fuerste-Henry <andrew at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 24 16:36:49 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Jan 2020 15:36:49 +0000
Subject: [Koha-bugs] [Bug 22359] Improve usability of 'change calculation'
 (bug 11373)
In-Reply-To: <bug-22359-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22359-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22359-70-o8VwZfN2EH@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22359

ByWater Sandboxes <bws.sandboxes at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #97886|0                           |1
        is obsolete|                            |

--- Comment #34 from ByWater Sandboxes <bws.sandboxes at gmail.com> ---
Created attachment 97889
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97889&action=edit
Bug 22359: Prevent undercollection at the server

This patch adds some additional handling to prevent undercollection of
fees at the server side.

Signed-off-by: Andrew Fuerste-Henry <andrew at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 24 16:37:23 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Jan 2020 15:37:23 +0000
Subject: [Koha-bugs] [Bug 22359] Improve usability of 'change calculation'
 (bug 11373)
In-Reply-To: <bug-22359-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22359-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22359-70-7qcS9sm9o0@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22359

Andrew Fuerste-Henry <andrew at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

--- Comment #35 from Andrew Fuerste-Henry <andrew at bywatersolutions.com> ---
It works! Great!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 24 16:46:31 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Jan 2020 15:46:31 +0000
Subject: [Koha-bugs] [Bug 20847] Add more fields to the Batch Patron
 Modification tool
In-Reply-To: <bug-20847-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20847-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20847-70-0z9Uj1t3QV@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20847

ByWater Sandboxes <bws.sandboxes at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #97853|0                           |1
        is obsolete|                            |

--- Comment #7 from ByWater Sandboxes <bws.sandboxes at gmail.com> ---
Created attachment 97890
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97890&action=edit
Bug 20847 - Add more fields to the Batch Patron Modification tool

This patch adds streetnumber, address, address2, phone and mobile to the
Batch Patron Modify form, also moves Primary email to a more logical
place on the page

To test:

1) Install patch
2) Open Batch Patron Modification tool, and input a borrowernumber to
edit
3) Add some data into the streetnumber, address, address2, phone and
mobile fields and click Save
4) These fields in the user record should now contain your data
5) Test that running the tool again with the option to delete the data
clears the fields correctly
6) Repeat steps 1-5 with a file of user borrowernumbers

Signed-off-by: Daniel J <daniel.jones at cheshiresharedservices.gov.uk>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 24 16:49:16 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Jan 2020 15:49:16 +0000
Subject: [Koha-bugs] [Bug 20847] Add more fields to the Batch Patron
 Modification tool
In-Reply-To: <bug-20847-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20847-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20847-70-YgOs5Olupx@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20847

daniel.jones at cheshiresharedservices.gov.uk changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |daniel.jones at cheshireshared
                   |                            |services.gov.uk
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 24 17:09:30 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Jan 2020 16:09:30 +0000
Subject: [Koha-bugs] [Bug 24497] CodeMirror should be a sys pref
In-Reply-To: <bug-24497-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24497-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24497-70-c8noAc8xAL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24497

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |nick at bywatersolutions.com

--- Comment #3 from Nick Clemens <nick at bywatersolutions.com> ---
We had a report of indentation woes, it seems CodeMirror doesn't like
mismatched combined parentheses. I.e.

Enter below and go to new line:
SELECT CONCAT( CONCAT('a','b') )

No indent

Enter below and go to new line:
SELECT CONCAT( CONCAT('a','b'))

                  Extreme indent

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 24 17:11:35 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Jan 2020 16:11:35 +0000
Subject: [Koha-bugs] [Bug 24485] Sys Pref AllowHoldPolicyOverride will not
 Staff override a Holds Per Record Rule
In-Reply-To: <bug-24485-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24485-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24485-70-ktlZ98qNNM@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24485

--- Comment #1 from Kelly McElligott <kelly at bywatersolutions.com> ---
A broader issue to this bug seems to also stem from the system preference
"maxreserves". 

In the example below, AllowHoldPolicyOverride is set to Allow, a staff member
should be able to override the Holds per Record value and also the MaxReserves
system preference, however, Koha is again stopping the override from happening
if it hits this system preference MaxREserves.

1. AllowHoldPolicyOverride- set to Allow
2. Circulation Rule - 500 Holds Per Record allowed 
3. MaxReserve system preference set to 5.
4. Patron has 6 holds - 1 of those holds is on 1 item of a bib record.
5. Staff can not place a second item level hold on a record due to this sys
pref MaxReserve value.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 24 17:48:46 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Jan 2020 16:48:46 +0000
Subject: [Koha-bugs] [Bug 24514] New: Holds Awaiting Pickup sorting by title
 before surname
Message-ID: <bug-24514-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24514

            Bug ID: 24514
           Summary: Holds Awaiting Pickup sorting by title before surname
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: Circulation
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: andrew at bywatersolutions.com
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com

Bug 24024 fixed an error causing Holds Awaiting Pickup to sort by firstname
rather than firstname. However, it's now sorting by title, then surname, then
firstname.

To test:
- generate and capture a hold for a patron named "Mr. A A"
- generate and capture a hold for a patron named "A A"
- generste and capture a hold for patron named "Mr. B B"
- generste and capture a hold for patron named "B B"
- go to holds awaiting pickup
- sort by patron name ascending
- holds sort Mr. A, Mr. B, A, B
- sort by patron name descending
- holds sort B, A, Mr. B, Mr. A

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 24 17:49:01 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Jan 2020 16:49:01 +0000
Subject: [Koha-bugs] [Bug 24514] Holds Awaiting Pickup sorting by title
 before surname
In-Reply-To: <bug-24514-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24514-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24514-70-OV7rpi1aQ3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24514

Andrew Fuerste-Henry <andrew at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |nick at bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 24 17:51:56 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Jan 2020 16:51:56 +0000
Subject: [Koha-bugs] [Bug 21946] Group circulation by item type
In-Reply-To: <bug-21946-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21946-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21946-70-chH8dOWpav@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21946

Sally <sally.healey at cheshiresharedservices.gov.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |sally.healey at cheshireshared
                   |                            |services.gov.uk

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 24 18:09:47 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Jan 2020 17:09:47 +0000
Subject: [Koha-bugs] [Bug 24497] CodeMirror indentation problems
In-Reply-To: <bug-24497-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24497-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24497-70-oLd1HOcSSN@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24497

Lucas Gass <lucas at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|CodeMirror should be a sys  |CodeMirror indentation
                   |pref                        |problems

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 24 18:34:07 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Jan 2020 17:34:07 +0000
Subject: [Koha-bugs] [Bug 24514] Holds Awaiting Pickup sorting by title
 before surname
In-Reply-To: <bug-24514-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24514-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24514-70-3CSKwszbAN@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24514

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Trivial patch
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 24 18:34:09 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Jan 2020 17:34:09 +0000
Subject: [Koha-bugs] [Bug 24514] Holds Awaiting Pickup sorting by title
 before surname
In-Reply-To: <bug-24514-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24514-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24514-70-0IMuy4JVyg@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24514

--- Comment #1 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 97891
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97891&action=edit
Bug 24514: Add option to exclude title from patron-title.inc

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 24 18:44:12 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Jan 2020 17:44:12 +0000
Subject: [Koha-bugs] [Bug 23463] Move C4::Items CRUD subroutines to
 Koha::Item
In-Reply-To: <bug-23463-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23463-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23463-70-1DrYwHZkHZ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23463

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |ASSIGNED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 24 19:07:48 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Jan 2020 18:07:48 +0000
Subject: [Koha-bugs] [Bug 24511] Patron emailer report not using specified
 email column
In-Reply-To: <bug-24511-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24511-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24511-70-efPdwxM284@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24511

ByWater Sandboxes <bws.sandboxes at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #97884|0                           |1
        is obsolete|                            |

--- Comment #2 from ByWater Sandboxes <bws.sandboxes at gmail.com> ---
Created attachment 97892
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97892&action=edit
Bug 24511: Update variable names to avoid confusion

To test:
1 - Create a report
    SELECT borrowernumber, firstname, surname, email, emailpro FROM borrowers
WHERE surname='acosta'
2 - Create or edit patron with surname acosta to have a separate email and
emailpro
3 - perl misc/cronjobs/patron_emailer --notice HOLDS --module reserves
--verbose --email emailpro --report ## --from 'me at you.us'
4 - Note email is used, not email pro
5 - Apply patch
6 - Repeat, correct eamil is used

Signed-off-by: Kelly McElligott <kelly at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 24 19:09:17 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Jan 2020 18:09:17 +0000
Subject: [Koha-bugs] [Bug 24511] Patron emailer report not using specified
 email column
In-Reply-To: <bug-24511-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24511-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24511-70-6NcHNJfkir@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24511

--- Comment #3 from Kelly McElligott <kelly at bywatersolutions.com> ---

The line should be this : 

perl misc/cronjobs/patron_emailer.pl --notice HOLD --module reserves --verbose
--email emailpro --report ## --from 'me at you.us'


but it did work as expected. It used the emailpro email when running this cron
line.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 24 19:09:30 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Jan 2020 18:09:30 +0000
Subject: [Koha-bugs] [Bug 24511] Patron emailer report not using specified
 email column
In-Reply-To: <bug-24511-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24511-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24511-70-IBVvFdFCVw@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24511

Kelly McElligott <kelly at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off
                 CC|                            |kelly at bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 24 19:19:52 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Jan 2020 18:19:52 +0000
Subject: [Koha-bugs] [Bug 24497] CodeMirror indentation problems
In-Reply-To: <bug-24497-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24497-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24497-70-xYSbdA3E4D@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24497

Lucas Gass <lucas at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 24 19:19:54 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Jan 2020 18:19:54 +0000
Subject: [Koha-bugs] [Bug 24497] CodeMirror indentation problems
In-Reply-To: <bug-24497-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24497-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24497-70-4nGWojj0A5@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24497

--- Comment #4 from Lucas Gass <lucas at bywatersolutions.com> ---
Created attachment 97893
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97893&action=edit
Bug 24497: Turn off smartIndent for SQL

This only seems to effect SQL CodeMirror inputs and I belive it to be the
smartIndent feature. This patch turns that off for SQL only.
TEST PLAN:
1. Enter 'SELECT CONCAT( CONCAT('a','b'))' into a SQL Report and press Enter
2. Extreme indent
3. Apply patch.
4. Enter 'SELECT CONCAT( CONCAT('a','b'))' into a SQL Report and press Enter
5. No indent.
6. Check that other indenting still works proper.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 24 19:20:27 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Jan 2020 18:20:27 +0000
Subject: [Koha-bugs] [Bug 24497] CodeMirror indentation problems
In-Reply-To: <bug-24497-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24497-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24497-70-HnwddQPMFk@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24497

Lucas Gass <lucas at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |lucas at bywatersolutions.com
                   |ity.org                     |

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 24 19:20:40 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Jan 2020 18:20:40 +0000
Subject: [Koha-bugs] [Bug 24025] Make CodeMirror content searchable
In-Reply-To: <bug-24025-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24025-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24025-70-WSo3Gstyox@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24025

Lucas Gass <lucas at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|enhancement                 |minor
                 CC|                            |lucas at bywatersolutions.com

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 24 19:48:31 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Jan 2020 18:48:31 +0000
Subject: [Koha-bugs] [Bug 24486] Account Wording Information is duplicated
 in Patron's Fines Tab on OPAC
In-Reply-To: <bug-24486-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24486-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24486-70-rH65Dajs57@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24486

Lucas Gass <lucas at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |lucas at bywatersolutions.com

--- Comment #3 from Lucas Gass <lucas at bywatersolutions.com> ---
Hi Jonathan,

Yes I only see one one "(Voided)" but in some cases (when payment has not been
voided) I see nothing at all.

I could be wrong but shouldn't it be 'account_status_description' that is
deleted and 'account_type_description' that should stay?


Thank you.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 24 20:00:31 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Jan 2020 19:00:31 +0000
Subject: [Koha-bugs] [Bug 6138] Show local help and isbd punctuation
 automatically when we are cataloguing
In-Reply-To: <bug-6138-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-6138-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-6138-70-uAcFNUpTVl@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6138

Ingrid <ingridschiessl at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |ingridschiessl at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 24 20:08:40 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Jan 2020 19:08:40 +0000
Subject: [Koha-bugs] [Bug 24486] Account Wording Information is duplicated
 in Patron's Fines Tab on OPAC
In-Reply-To: <bug-24486-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24486-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24486-70-MtjiE9oKrM@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24486

ByWater Sandboxes <bws.sandboxes at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #97883|0                           |1
        is obsolete|                            |

--- Comment #4 from ByWater Sandboxes <bws.sandboxes at gmail.com> ---
Created attachment 97894
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97894&action=edit
Bug 24486: Remove duplicated account information at the OPAC

  commit efc21e6f47801503e55e3ba709a48c3f426f90ac
  Bug 23115: (follow-up) Move switches to a TT block

Duplicated the following line:
+                        [% PROCESS account_type_description
account=ACCOUNT_LINE %]
                         [%- PROCESS account_status_description
account=ACCOUNT_LINE -%]

Which cause the info to appear twice

Test plan:
Create a manual invoice
Pay it
Void it

Go to the opac, account
=> You should see only one "(Voided)"

Signed-off-by: Christofer Zorn <christofer.zorn at ajaxlibrary.ca>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 24 20:10:44 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Jan 2020 19:10:44 +0000
Subject: [Koha-bugs] [Bug 24486] Account Wording Information is duplicated
 in Patron's Fines Tab on OPAC
In-Reply-To: <bug-24486-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24486-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24486-70-VV40mulyTI@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24486

Christofer Zorn <christofer.zorn at ajaxlibrary.ca> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off
                 CC|                            |christofer.zorn at ajaxlibrary
                   |                            |.ca

--- Comment #5 from Christofer Zorn <christofer.zorn at ajaxlibrary.ca> ---
Followed test plan and was able to duplicate the error. After applying the
patch, the duplication of text was no longer there. 

Christofer

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 24 20:42:51 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Jan 2020 19:42:51 +0000
Subject: [Koha-bugs] [Bug 23463] Move C4::Items CRUD subroutines to
 Koha::Item
In-Reply-To: <bug-23463-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23463-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23463-70-oqkqkPQu05@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23463

--- Comment #35 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Rebased against master. Leaving ASSIGNED while I QA this.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 24 20:42:53 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Jan 2020 19:42:53 +0000
Subject: [Koha-bugs] [Bug 23463] Move C4::Items CRUD subroutines to
 Koha::Item
In-Reply-To: <bug-23463-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23463-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23463-70-PnrfUDXAnb@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23463

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #96145|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 24 20:42:55 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Jan 2020 19:42:55 +0000
Subject: [Koha-bugs] [Bug 23463] Move C4::Items CRUD subroutines to
 Koha::Item
In-Reply-To: <bug-23463-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23463-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23463-70-a1aG1TXc6T@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23463

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #95899|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 24 20:42:57 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Jan 2020 19:42:57 +0000
Subject: [Koha-bugs] [Bug 23463] Move C4::Items CRUD subroutines to
 Koha::Item
In-Reply-To: <bug-23463-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23463-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23463-70-3oi6Vr2ORv@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23463

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #95900|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 24 20:42:59 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Jan 2020 19:42:59 +0000
Subject: [Koha-bugs] [Bug 23463] Move C4::Items CRUD subroutines to
 Koha::Item
In-Reply-To: <bug-23463-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23463-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23463-70-Po5lHX1wYX@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23463

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #95901|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 24 20:43:02 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Jan 2020 19:43:02 +0000
Subject: [Koha-bugs] [Bug 23463] Move C4::Items CRUD subroutines to
 Koha::Item
In-Reply-To: <bug-23463-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23463-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23463-70-ppeiOf3X2R@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23463

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #95902|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 24 20:43:04 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Jan 2020 19:43:04 +0000
Subject: [Koha-bugs] [Bug 23463] Move C4::Items CRUD subroutines to
 Koha::Item
In-Reply-To: <bug-23463-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23463-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23463-70-eb6NHDSlsK@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23463

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #95903|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 24 20:43:06 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Jan 2020 19:43:06 +0000
Subject: [Koha-bugs] [Bug 23463] Move C4::Items CRUD subroutines to
 Koha::Item
In-Reply-To: <bug-23463-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23463-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23463-70-WDVPdkshMu@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23463

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #95904|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 24 20:43:08 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Jan 2020 19:43:08 +0000
Subject: [Koha-bugs] [Bug 23463] Move C4::Items CRUD subroutines to
 Koha::Item
In-Reply-To: <bug-23463-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23463-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23463-70-huOGlL7QNs@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23463

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #95905|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 24 20:43:10 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Jan 2020 19:43:10 +0000
Subject: [Koha-bugs] [Bug 23463] Move C4::Items CRUD subroutines to
 Koha::Item
In-Reply-To: <bug-23463-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23463-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23463-70-N5H27Pc64I@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23463

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #95906|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 24 20:43:12 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Jan 2020 19:43:12 +0000
Subject: [Koha-bugs] [Bug 23463] Move C4::Items CRUD subroutines to
 Koha::Item
In-Reply-To: <bug-23463-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23463-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23463-70-OrlRiYFSNQ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23463

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #95907|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 24 20:43:14 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Jan 2020 19:43:14 +0000
Subject: [Koha-bugs] [Bug 23463] Move C4::Items CRUD subroutines to
 Koha::Item
In-Reply-To: <bug-23463-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23463-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23463-70-5Y4H8oQRJV@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23463

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #95908|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 24 20:43:17 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Jan 2020 19:43:17 +0000
Subject: [Koha-bugs] [Bug 23463] Move C4::Items CRUD subroutines to
 Koha::Item
In-Reply-To: <bug-23463-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23463-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23463-70-LpjHzbhYLn@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23463

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #95909|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 24 20:43:19 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Jan 2020 19:43:19 +0000
Subject: [Koha-bugs] [Bug 23463] Move C4::Items CRUD subroutines to
 Koha::Item
In-Reply-To: <bug-23463-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23463-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23463-70-uuQG61tygY@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23463

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #95910|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 24 20:43:21 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Jan 2020 19:43:21 +0000
Subject: [Koha-bugs] [Bug 23463] Move C4::Items CRUD subroutines to
 Koha::Item
In-Reply-To: <bug-23463-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23463-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23463-70-OHCXTyXHlV@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23463

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #95911|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 24 20:43:23 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Jan 2020 19:43:23 +0000
Subject: [Koha-bugs] [Bug 23463] Move C4::Items CRUD subroutines to
 Koha::Item
In-Reply-To: <bug-23463-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23463-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23463-70-yNjFjp2Wpw@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23463

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #95912|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 24 20:43:25 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Jan 2020 19:43:25 +0000
Subject: [Koha-bugs] [Bug 23463] Move C4::Items CRUD subroutines to
 Koha::Item
In-Reply-To: <bug-23463-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23463-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23463-70-umB9sNiLeu@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23463

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #95913|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 24 20:43:28 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Jan 2020 19:43:28 +0000
Subject: [Koha-bugs] [Bug 23463] Move C4::Items CRUD subroutines to
 Koha::Item
In-Reply-To: <bug-23463-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23463-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23463-70-MNYQHhwzkR@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23463

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #95914|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 24 20:43:30 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Jan 2020 19:43:30 +0000
Subject: [Koha-bugs] [Bug 23463] Move C4::Items CRUD subroutines to
 Koha::Item
In-Reply-To: <bug-23463-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23463-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23463-70-nIxc3ZzALv@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23463

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #95915|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 24 20:43:32 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Jan 2020 19:43:32 +0000
Subject: [Koha-bugs] [Bug 23463] Move C4::Items CRUD subroutines to
 Koha::Item
In-Reply-To: <bug-23463-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23463-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23463-70-PvjKizMj7h@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23463

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #95916|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 24 20:43:35 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Jan 2020 19:43:35 +0000
Subject: [Koha-bugs] [Bug 23463] Move C4::Items CRUD subroutines to
 Koha::Item
In-Reply-To: <bug-23463-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23463-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23463-70-SoPMtZGkk3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23463

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #95917|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 24 20:43:37 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Jan 2020 19:43:37 +0000
Subject: [Koha-bugs] [Bug 23463] Move C4::Items CRUD subroutines to
 Koha::Item
In-Reply-To: <bug-23463-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23463-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23463-70-vux3hZnvU5@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23463

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #95918|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 24 20:43:39 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Jan 2020 19:43:39 +0000
Subject: [Koha-bugs] [Bug 23463] Move C4::Items CRUD subroutines to
 Koha::Item
In-Reply-To: <bug-23463-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23463-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23463-70-0dJNAyUojY@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23463

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #95919|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 24 20:43:41 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Jan 2020 19:43:41 +0000
Subject: [Koha-bugs] [Bug 23463] Move C4::Items CRUD subroutines to
 Koha::Item
In-Reply-To: <bug-23463-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23463-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23463-70-DN8utfsX34@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23463

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #95920|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 24 20:43:44 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Jan 2020 19:43:44 +0000
Subject: [Koha-bugs] [Bug 23463] Move C4::Items CRUD subroutines to
 Koha::Item
In-Reply-To: <bug-23463-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23463-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23463-70-CIQhFlg1xc@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23463

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #95921|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 24 20:43:46 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Jan 2020 19:43:46 +0000
Subject: [Koha-bugs] [Bug 23463] Move C4::Items CRUD subroutines to
 Koha::Item
In-Reply-To: <bug-23463-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23463-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23463-70-CfGQGRWmcs@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23463

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #95922|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 24 20:43:48 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Jan 2020 19:43:48 +0000
Subject: [Koha-bugs] [Bug 23463] Move C4::Items CRUD subroutines to
 Koha::Item
In-Reply-To: <bug-23463-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23463-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23463-70-9QdVtwp4dP@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23463

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #95923|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 24 20:43:51 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Jan 2020 19:43:51 +0000
Subject: [Koha-bugs] [Bug 23463] Move C4::Items CRUD subroutines to
 Koha::Item
In-Reply-To: <bug-23463-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23463-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23463-70-rcQqZsQhcT@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23463

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #95925|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 24 20:44:42 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Jan 2020 19:44:42 +0000
Subject: [Koha-bugs] [Bug 23463] Move C4::Items CRUD subroutines to
 Koha::Item
In-Reply-To: <bug-23463-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23463-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23463-70-z68sOQ9uPA@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23463

--- Comment #36 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 97895
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97895&action=edit
Bug 23463: Replace SearchItemsByField by SearchItems

The subroutine SearchItemsByField is only called once and can be
replaced easily with SearchItems

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 24 20:44:46 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Jan 2020 19:44:46 +0000
Subject: [Koha-bugs] [Bug 23463] Move C4::Items CRUD subroutines to
 Koha::Item
In-Reply-To: <bug-23463-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23463-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23463-70-yHYpMtnpXU@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23463

--- Comment #37 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 97896
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97896&action=edit
Bug 23463: Remove uneeded SearchItemsByField subroutine

It is no longer used.

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 24 20:44:49 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Jan 2020 19:44:49 +0000
Subject: [Koha-bugs] [Bug 23463] Move C4::Items CRUD subroutines to
 Koha::Item
In-Reply-To: <bug-23463-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23463-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23463-70-s0eL3L3SJ8@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23463

--- Comment #38 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 97897
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97897&action=edit
Bug 23463: fix for testbuilder - set default value items.damaged=0

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 24 20:44:53 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Jan 2020 19:44:53 +0000
Subject: [Koha-bugs] [Bug 23463] Move C4::Items CRUD subroutines to
 Koha::Item
In-Reply-To: <bug-23463-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23463-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23463-70-IDa3Ww2tyJ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23463

--- Comment #39 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 97898
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97898&action=edit
Bug 23463: Replace AddItem calls with Koha::Item->store

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 24 20:44:57 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Jan 2020 19:44:57 +0000
Subject: [Koha-bugs] [Bug 23463] Move C4::Items CRUD subroutines to
 Koha::Item
In-Reply-To: <bug-23463-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23463-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23463-70-BXQdhsOE7N@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23463

--- Comment #40 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 97899
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97899&action=edit
Bug 23463: Remove _set_defaults_for_add

_set_defaults_for_add is no longer needed as it is handled by dbic and
koha::object->store

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 24 20:45:01 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Jan 2020 19:45:01 +0000
Subject: [Koha-bugs] [Bug 23463] Move C4::Items CRUD subroutines to
 Koha::Item
In-Reply-To: <bug-23463-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23463-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23463-70-Pke5LuYY3v@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23463

--- Comment #41 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 97900
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97900&action=edit
Bug 23463: Replace _set_derived_columns_for_add

Remove the unique call to _set_derived_columns_for_add
Even if design to deal with other values it only dealts with cn_sort

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 24 20:45:04 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Jan 2020 19:45:04 +0000
Subject: [Koha-bugs] [Bug 23463] Move C4::Items CRUD subroutines to
 Koha::Item
In-Reply-To: <bug-23463-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23463-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23463-70-ZvYceiBd7C@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23463

--- Comment #42 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 97901
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97901&action=edit
Bug 23463: AddItem removing

We are done with AddItem, only need to log and index.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 24 20:45:08 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Jan 2020 19:45:08 +0000
Subject: [Koha-bugs] [Bug 23463] Move C4::Items CRUD subroutines to
 Koha::Item
In-Reply-To: <bug-23463-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23463-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23463-70-BxQ7x6V6Gp@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23463

--- Comment #43 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 97902
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97902&action=edit
Bug 23463: Replace ModItem with Koha::Item->store

Starting to replace the ModItem calls with Koha::Item->store

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 24 20:45:11 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Jan 2020 19:45:11 +0000
Subject: [Koha-bugs] [Bug 23463] Move C4::Items CRUD subroutines to
 Koha::Item
In-Reply-To: <bug-23463-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23463-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23463-70-a4rZcFFZqs@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23463

--- Comment #44 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 97903
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97903&action=edit
Bug 23463: remove trivial UpdateHoldingbranch sub

We do not need this subroutine, moving it where it is used.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 24 20:45:15 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Jan 2020 19:45:15 +0000
Subject: [Koha-bugs] [Bug 23463] Move C4::Items CRUD subroutines to
 Koha::Item
In-Reply-To: <bug-23463-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23463-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23463-70-8jA1YgdUe8@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23463

--- Comment #45 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 97904
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97904&action=edit
Bug 23463: Move plugin hook

>From C4::Items to Koha::Item

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 24 20:45:19 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Jan 2020 19:45:19 +0000
Subject: [Koha-bugs] [Bug 23463] Move C4::Items CRUD subroutines to
 Koha::Item
In-Reply-To: <bug-23463-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23463-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23463-70-NQH6Oqgjub@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23463

--- Comment #46 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 97905
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97905&action=edit
Bug 23463: _set_derived_columns_for_mod was only used for cn_sort

Same as _set_defaults_for_add

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 24 20:45:23 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Jan 2020 19:45:23 +0000
Subject: [Koha-bugs] [Bug 23463] Move C4::Items CRUD subroutines to
 Koha::Item
In-Reply-To: <bug-23463-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23463-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23463-70-45pBBQuE0N@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23463

--- Comment #47 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 97906
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97906&action=edit
Bug 23463: _do_column_fixes_for_mod dealt with integer location and timestamp
moved

That's done in Koha::Item->store, and Koha::Object->store for integers.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 24 20:45:26 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Jan 2020 19:45:26 +0000
Subject: [Koha-bugs] [Bug 23463] Move C4::Items CRUD subroutines to
 Koha::Item
In-Reply-To: <bug-23463-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23463-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23463-70-Lh1UIqldCS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23463

--- Comment #48 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 97907
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97907&action=edit
Bug 23463: Remove _mod_item_dates

We did not do anything useful here.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 24 20:45:30 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Jan 2020 19:45:30 +0000
Subject: [Koha-bugs] [Bug 23463] Move C4::Items CRUD subroutines to
 Koha::Item
In-Reply-To: <bug-23463-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23463-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23463-70-fZCnC8ygQs@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23463

--- Comment #49 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 97908
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97908&action=edit
Bug 23463: Remove ModItem

There should not be any calls left

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 24 20:45:34 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Jan 2020 19:45:34 +0000
Subject: [Koha-bugs] [Bug 23463] Move C4::Items CRUD subroutines to
 Koha::Item
In-Reply-To: <bug-23463-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23463-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23463-70-fmU0rZLHbf@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23463

--- Comment #50 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 97909
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97909&action=edit
Bug 23463: Remove DelItem

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 24 20:45:37 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Jan 2020 19:45:37 +0000
Subject: [Koha-bugs] [Bug 23463] Move C4::Items CRUD subroutines to
 Koha::Item
In-Reply-To: <bug-23463-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23463-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23463-70-U4q4y8SbTi@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23463

--- Comment #51 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 97910
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97910&action=edit
Bug 23463: Remove DelItemCheck and ItemSafeToDelete

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 24 20:45:41 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Jan 2020 19:45:41 +0000
Subject: [Koha-bugs] [Bug 23463] Move C4::Items CRUD subroutines to
 Koha::Item
In-Reply-To: <bug-23463-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23463-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23463-70-J8Mensn3rn@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23463

--- Comment #52 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 97911
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97911&action=edit
Bug 23463: Remove no longer needed subs related to default values

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 24 20:45:44 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Jan 2020 19:45:44 +0000
Subject: [Koha-bugs] [Bug 23463] Move C4::Items CRUD subroutines to
 Koha::Item
In-Reply-To: <bug-23463-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23463-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23463-70-7AKE3btxHh@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23463

--- Comment #53 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 97912
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97912&action=edit
Bug 23463: Fix CancelReceipt.t

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 24 20:45:48 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Jan 2020 19:45:48 +0000
Subject: [Koha-bugs] [Bug 23463] Move C4::Items CRUD subroutines to
 Koha::Item
In-Reply-To: <bug-23463-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23463-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23463-70-LYb2yIy1Gd@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23463

--- Comment #54 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 97913
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97913&action=edit
Bug 23463: Fix failing tests

And adding a FIXME about discard_changes

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 24 20:45:52 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Jan 2020 19:45:52 +0000
Subject: [Koha-bugs] [Bug 23463] Move C4::Items CRUD subroutines to
 Koha::Item
In-Reply-To: <bug-23463-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23463-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23463-70-9t3vKeTAsN@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23463

--- Comment #55 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 97914
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97914&action=edit
Bug 23463: Getting less item-level_itypes warnings (?)

So, we get less warnings. I do not really understand why...

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 24 20:45:55 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Jan 2020 19:45:55 +0000
Subject: [Koha-bugs] [Bug 23463] Move C4::Items CRUD subroutines to
 Koha::Item
In-Reply-To: <bug-23463-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23463-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23463-70-WhFqP2luU1@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23463

--- Comment #56 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 97915
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97915&action=edit
Bug 23463: Fix AutomaticItemModificationByAge.t

We do not want to log if nothing changed

How could we do that better?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 24 20:45:59 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Jan 2020 19:45:59 +0000
Subject: [Koha-bugs] [Bug 23463] Move C4::Items CRUD subroutines to
 Koha::Item
In-Reply-To: <bug-23463-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23463-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23463-70-yj52ZoxpPB@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23463

--- Comment #57 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 97916
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97916&action=edit
Bug 23463: update permanent_location if location has been updated

This change to Koha::Item->store seems correct here, but tests from
/db_dependent/Items.t is failing now.

Adjusting them to make them pass.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 24 20:46:02 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Jan 2020 19:46:02 +0000
Subject: [Koha-bugs] [Bug 23463] Move C4::Items CRUD subroutines to
 Koha::Item
In-Reply-To: <bug-23463-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23463-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23463-70-2S75jxFC30@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23463

--- Comment #58 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 97917
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97917&action=edit
Bug 23463: Fix items.cn_source vs cn_source

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 24 20:46:06 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Jan 2020 19:46:06 +0000
Subject: [Koha-bugs] [Bug 23463] Move C4::Items CRUD subroutines to
 Koha::Item
In-Reply-To: <bug-23463-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23463-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23463-70-6RU00nU7h3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23463

--- Comment #59 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 97918
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97918&action=edit
Bug 23463: build cn_sort only if needed

No need to calculate cn_sort if not dirty when we store

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 24 20:46:10 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Jan 2020 19:46:10 +0000
Subject: [Koha-bugs] [Bug 23463] Move C4::Items CRUD subroutines to
 Koha::Item
In-Reply-To: <bug-23463-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23463-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23463-70-bE954jIRBL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23463

--- Comment #60 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 97919
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97919&action=edit
Bug 23463: Replace recently added occurrences

Few occurrences have been added since this patchset has been originaly
written

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 24 20:46:13 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Jan 2020 19:46:13 +0000
Subject: [Koha-bugs] [Bug 23463] Move C4::Items CRUD subroutines to
 Koha::Item
In-Reply-To: <bug-23463-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23463-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23463-70-JeSQ8dnS16@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23463

--- Comment #61 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 97920
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97920&action=edit
Bug 23463: cn_sort needs to be updated if cn_source changed

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 24 20:46:17 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Jan 2020 19:46:17 +0000
Subject: [Koha-bugs] [Bug 23463] Move C4::Items CRUD subroutines to
 Koha::Item
In-Reply-To: <bug-23463-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23463-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23463-70-ivYEAS54BR@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23463

--- Comment #62 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 97921
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97921&action=edit
Bug 23463: (follow-up) Remove DelItemCheck and ItemSafeToDelete

Wrong replacement in additem.pl

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 24 21:12:16 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Jan 2020 20:12:16 +0000
Subject: [Koha-bugs] [Bug 24515] New: Column Configuration for
 pay-fines-table does not hide Account Type properly
Message-ID: <bug-24515-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24515

            Bug ID: 24515
           Summary: Column Configuration for pay-fines-table does not hide
                    Account Type properly
 Change sponsored?: ---
           Product: Koha
           Version: 19.11
          Hardware: All
                OS: All
            Status: NEW
          Severity: minor
          Priority: P5 - low
         Component: Staff Client
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: kelly at bywatersolutions.com
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com

In the Patron set of the Column Configuration under Pay-Fines-Table, checking
to hide the "account type" field does not hide the "Account Type" in pay.pl. 
If "Account Type" and "Description" are both chosen, it will hide the "account
type" in pay.pl but not the "description".

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 24 21:25:09 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Jan 2020 20:25:09 +0000
Subject: [Koha-bugs] [Bug 24510] When Placing a Hold,
 cursor doesn't focus on Patron Name
In-Reply-To: <bug-24510-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24510-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24510-70-jySNac0OzU@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24510

ByWater Sandboxes <bws.sandboxes at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #97887|0                           |1
        is obsolete|                            |

--- Comment #2 from ByWater Sandboxes <bws.sandboxes at gmail.com> ---
Created attachment 97922
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97922&action=edit
Bug 24510: Add focus to Patron/club input

Signed-off-by: Kelly McElligott <kelly at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 24 21:25:34 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Jan 2020 20:25:34 +0000
Subject: [Koha-bugs] [Bug 24510] When Placing a Hold,
 cursor doesn't focus on Patron Name
In-Reply-To: <bug-24510-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24510-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24510-70-0tdVhWS2N6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24510

Kelly McElligott <kelly at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 24 21:53:44 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Jan 2020 20:53:44 +0000
Subject: [Koha-bugs] [Bug 24476] Allow patrons to opt-out of Auto-renewal
In-Reply-To: <bug-24476-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24476-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24476-70-26jXBwtunn@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24476

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 24 21:53:47 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Jan 2020 20:53:47 +0000
Subject: [Koha-bugs] [Bug 24476] Allow patrons to opt-out of Auto-renewal
In-Reply-To: <bug-24476-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24476-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24476-70-QZWLYCthGR@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24476

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #97831|0                           |1
        is obsolete|                            |
  Attachment #97832|0                           |1
        is obsolete|                            |
  Attachment #97833|0                           |1
        is obsolete|                            |
  Attachment #97834|0                           |1
        is obsolete|                            |
  Attachment #97835|0                           |1
        is obsolete|                            |
  Attachment #97836|0                           |1
        is obsolete|                            |

--- Comment #19 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 97923
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97923&action=edit
Bug 24476: Database updates

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 24 21:53:50 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Jan 2020 20:53:50 +0000
Subject: [Koha-bugs] [Bug 24476] Allow patrons to opt-out of Auto-renewal
In-Reply-To: <bug-24476-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24476-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24476-70-0Nse12WgRy@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24476

--- Comment #20 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 97924
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97924&action=edit
Bug 24476: API Updates

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 24 21:53:53 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Jan 2020 20:53:53 +0000
Subject: [Koha-bugs] [Bug 24476] Allow patrons to opt-out of Auto-renewal
In-Reply-To: <bug-24476-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24476-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24476-70-NdViA8mZEJ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24476

--- Comment #21 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 97925
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97925&action=edit
Bug 24476: Change CanBookBeRenewed and adjust tests

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 24 21:53:56 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Jan 2020 20:53:56 +0000
Subject: [Koha-bugs] [Bug 24476] Allow patrons to opt-out of Auto-renewal
In-Reply-To: <bug-24476-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24476-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24476-70-o0xx4vtlQN@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24476

--- Comment #22 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 97926
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97926&action=edit
Bug 24476: Allow patrons to opt out of auto-renewal

To test:
1 - Verify on staff side that patron can be edited to opt in our out of auto
renewal
2 - Check out some items to a patron opted in to auto renewal
3 - Ensure the items are checked out and set to autorenew
4 - Login on the opac at the patron
5 - Verify items cannot be renewed as scheduled for auto-renewal
6 - On staff side, opt patron out of auto renewal
7 - Verify on opac items are no longer marked for auto renewal
8 - Run the auto renewal cron job, items are not renewed
9 - Set 'no renewal before' to a setting that would prevent renewal
10 - Verify that opting patron in or out of auto renewal changes only the
reason items cannot be renewed
11 - Set 'no renewal before' to a setting that would allow for renewal
12 - Verify that opting patron in/out changes their ability to renew
13 - Verify that when opted out cron does not renew
14 - Verify that when opted in the item is auto renewed
15 - Reset the due date, opt out, verify manual renewal succeeds

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 24 21:53:58 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Jan 2020 20:53:58 +0000
Subject: [Koha-bugs] [Bug 24476] Allow patrons to opt-out of Auto-renewal
In-Reply-To: <bug-24476-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24476-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24476-70-thgMjn17Ks@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24476

--- Comment #23 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 97927
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97927&action=edit
Bug 24476: DO NOT PUSH - Schema updates

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 24 21:54:01 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Jan 2020 20:54:01 +0000
Subject: [Koha-bugs] [Bug 24476] Allow patrons to opt-out of Auto-renewal
In-Reply-To: <bug-24476-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24476-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24476-70-2TbnKWAFaD@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24476

--- Comment #24 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 97928
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97928&action=edit
Bug 24476: Add boolean for all TINYINT

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 24 22:10:21 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Jan 2020 21:10:21 +0000
Subject: [Koha-bugs] [Bug 24497] CodeMirror indentation problems
In-Reply-To: <bug-24497-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24497-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24497-70-l2p0L4eU39@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24497

ByWater Sandboxes <bws.sandboxes at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #97893|0                           |1
        is obsolete|                            |

--- Comment #5 from ByWater Sandboxes <bws.sandboxes at gmail.com> ---
Created attachment 97929
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97929&action=edit
Bug 24497: Turn off smartIndent for SQL

Signed-off-by: Christopher Brannon <cbrannon at cdalibrary.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 24 22:11:18 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Jan 2020 21:11:18 +0000
Subject: [Koha-bugs] [Bug 24497] CodeMirror indentation problems
In-Reply-To: <bug-24497-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24497-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24497-70-qRB0l5s4TI@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24497

Christopher Brannon <cbrannon at cdalibrary.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off
                 CC|                            |cbrannon at cdalibrary.org

--- Comment #6 from Christopher Brannon <cbrannon at cdalibrary.org> ---
Yes!  You are a life saver!  Works much better!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 24 23:01:37 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Jan 2020 22:01:37 +0000
Subject: [Koha-bugs] [Bug 18186] Plack config: Amounts with decimal comma
 instead of decimal dot breaking payments
In-Reply-To: <bug-18186-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18186-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18186-70-lAUNVjpPyK@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18186

--- Comment #5 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
(In reply to Tomás Cohen Arazi from comment #4)
> So, if you fix some variables:
> - browser,
> - browser locale
> - settings in Koha
> 
> then if you switch the locale and restart plack the behaviour change?

Yes. We have seen this happen twice - we fixed it, we lost the setting in
Plack... we fixed it again. I know it sounds strange, we were a bit puzzled as
well.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 24 23:28:02 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Jan 2020 22:28:02 +0000
Subject: [Koha-bugs] [Bug 24501] Authorities 'merge' is confusing
In-Reply-To: <bug-24501-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24501-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24501-70-hlVJHQKG6w@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24501

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de

--- Comment #2 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
I understand that it is confusing, but changing a cronjob name means that in
every installations people might have to change their cronjob setup... I am not
sure if we should do this. And if we do it, maybe it should be a gradual
process turning the current script into a wrapper that sends a deprecation
warning to the logs for one release and asks you to switch.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 24 23:30:26 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Jan 2020 22:30:26 +0000
Subject: [Koha-bugs] [Bug 24504] branchtransfers.pl - Entering checked out
 item cause Internal Server Error
In-Reply-To: <bug-24504-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24504-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24504-70-y8d1ENqwJT@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24504

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de

--- Comment #3 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Could it be the item was missing a holdingbranch or something like that? 

But Jonathan is right, without more information (steps we can replicate) or at
least the error from the logs, I am not sure how we can help here.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 24 23:36:55 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Jan 2020 22:36:55 +0000
Subject: [Koha-bugs] [Bug 24490] Clarify wording and function of Purchase
 Items link on POS
In-Reply-To: <bug-24490-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24490-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24490-70-moIBi7pntu@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24490

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Failed QA
                 CC|                            |katrin.fischer at bsz-bw.de

--- Comment #5 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
I am sorry David, but the new text doesn't have the right capitalization. Only
the first word of each link should be capitalized (see coding guidelines). 

Do you want to have a go at fixing this? Let me know if I can help.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 24 23:37:37 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Jan 2020 22:37:37 +0000
Subject: [Koha-bugs] [Bug 24490] Clarify wording and function of Purchase
 Items link on POS
In-Reply-To: <bug-24490-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24490-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24490-70-5oKUUkQax9@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24490

--- Comment #6 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Btw - I like the new wording much better :)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 24 23:40:45 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Jan 2020 22:40:45 +0000
Subject: [Koha-bugs] [Bug 24305] Batch Item modification via item number in
 reports does not work with CONCAT in report
In-Reply-To: <bug-24305-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24305-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24305-70-EiiZlQBec5@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24305

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de

--- Comment #17 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
(In reply to Marcel de Rooy from comment #14)
> Still one question remaining. No blocker for me.
> 
> +            <textarea style="display:none" name="cardnumberlist"
> id="cardnumberlist">[% FOREACH result IN results %][% FOREACH cells IN
> result.cells %][% place = loop.index %][% IF header_row.$place.cell ==
> 'cardnumber' || header_types.item(header_row.$place.cell) == 'cardnumber' &&
> cells.cell.match('^(\d+)$') %][% SET batch_cardnumbers = 1 %]
> 
> Why do you check on only digits for cardnumber here? The field cardnumber is
> a varchar ?

So... should we not have removed it?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 24 23:41:25 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Jan 2020 22:41:25 +0000
Subject: [Koha-bugs] [Bug 24305] Batch Item modification via item number in
 reports does not work with CONCAT in report
In-Reply-To: <bug-24305-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24305-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24305-70-WTFDcqWaYG@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24305

--- Comment #18 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
I think almost all our libraries would fail the cardnumber is numeric test...

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 24 23:58:45 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Jan 2020 22:58:45 +0000
Subject: [Koha-bugs] [Bug 18186] Plack config: Amounts with decimal comma
 instead of decimal dot breaking payments
In-Reply-To: <bug-18186-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18186-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18186-70-PBKYQY9AnZ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18186

--- Comment #6 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
(In reply to Katrin Fischer from comment #5)
> (In reply to Tomás Cohen Arazi from comment #4)
> > So, if you fix some variables:
> > - browser,
> > - browser locale
> > - settings in Koha
> > 
> > then if you switch the locale and restart plack the behaviour change?
> 
> Yes. We have seen this happen twice - we fixed it, we lost the setting in
> Plack... we fixed it again. I know it sounds strange, we were a bit puzzled
> as well.

The only thing I can think of right now is that Plack is smart and imports the
env locales settings. And I bet some of our libraries for handling number
representations, like TT, is picking that. So we should be hardcoding the
'no-locale' setting.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Sat Jan 25 00:25:49 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Jan 2020 23:25:49 +0000
Subject: [Koha-bugs] [Bug 24490] Clarify wording and function of Purchase
 Items link on POS
In-Reply-To: <bug-24490-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24490-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24490-70-DrO3MI4XM3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24490

David Roberts <david.roberts at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #97879|0                           |1
        is obsolete|                            |

--- Comment #7 from David Roberts <david.roberts at ptfs-europe.com> ---
Created attachment 97930
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97930&action=edit
Bug 24490: Clarify wording and function of Purchase Items link on POS

This patch changes the wording of the links on the POS side menu

To test:

1) Apply the patch
2) Check that the links on the left hand side of the screen read
"Configure Cash Registers" and "Configure Items for Purchase"
3) Click both links to ensure you are taken to the relevant config
pages.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jan 25 00:27:05 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Jan 2020 23:27:05 +0000
Subject: [Koha-bugs] [Bug 24490] Clarify wording and function of Purchase
 Items link on POS
In-Reply-To: <bug-24490-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24490-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24490-70-L45QrUqJHZ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24490

David Roberts <david.roberts at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Needs Signoff

--- Comment #8 from David Roberts <david.roberts at ptfs-europe.com> ---
Hi Katrin

OK, try that instead. Do I need to mark it back to Needs Signoff? I've done
that anyway, just in case.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jan 25 00:29:43 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Jan 2020 23:29:43 +0000
Subject: [Koha-bugs] [Bug 24515] Column Configuration for pay-fines-table
 does not hide Account Type properly
In-Reply-To: <bug-24515-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24515-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24515-70-LMvfK6kQmU@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24515

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Trivial patch
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Sat Jan 25 00:29:46 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Jan 2020 23:29:46 +0000
Subject: [Koha-bugs] [Bug 24515] Column Configuration for pay-fines-table
 does not hide Account Type properly
In-Reply-To: <bug-24515-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24515-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24515-70-akxRlU19tB@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24515

--- Comment #1 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 97931
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97931&action=edit
Bug 24515: Column Configuration for pay-fines-table does not hide Account Type
properly

This patch corrects the order of the columns in the columns
configuration YML file. The incorrect order was causing the wrong column
to be hidden when changing the columns settings for the table in
Administration.

To test, apply the patch and go to Administration -> Columns settings.

 - Under Patrons -> pay-fines-table, test hiding the account_type and
   description columns, together and separately.
 - Verify that the correct columns are hidden on the pay fines screen
   (Patron -> Accounting -> Make a payment)

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Sat Jan 25 00:29:57 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 24 Jan 2020 23:29:57 +0000
Subject: [Koha-bugs] [Bug 24515] Column Configuration for pay-fines-table
 does not hide Account Type properly
In-Reply-To: <bug-24515-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24515-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24515-70-PPMj2Ait2k@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24515

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |oleonard at myacpl.org
                   |ity.org                     |
            Version|19.11                       |master

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Sat Jan 25 03:11:50 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 25 Jan 2020 02:11:50 +0000
Subject: [Koha-bugs] [Bug 13327] OPACPopupAuthorsSearch doesn't work with
 XSLT views
In-Reply-To: <bug-13327-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13327-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13327-70-O1t043XNvT@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13327

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |david at davidnind.com

--- Comment #3 from David Nind <david at davidnind.com> ---
Created attachment 97932
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97932&action=edit
Bug 13327: Screenshots with different options

Results from my testing:

- For OPACPopupAuthorsSearch enabled and OPACXSLTDetailsDisplay default:
    • works for the author search (the new style for the modal is much nicer)
    • the modal for subject terms doesn't appear/work

- For OPACPopupAuthorsSearch enabled and OPACXSLTDetailsDisplay empty:
    • search icon different for additional authors
    • old search icon displays for ‘Subject(s):’
    • the modal for subject terms works, but uses 'old style'

- For OPACPopupAuthorsSearch disabled and OPACXSLTDetailsDisplay empty - the
record displays the same as for OPACPopupAuthorsSearch enabled and
OPACXSLTDetailsDisplay empty

I've attached a document with screenshots.

Tested use Firefox Developer Edition and Google Chrome on Ubuntu 18.04 -
cleared browser history, cache, etc for different combination of options. Also
used a fresh container for each combination using koha-testing-docker.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jan 25 03:41:12 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 25 Jan 2020 02:41:12 +0000
Subject: [Koha-bugs] [Bug 24515] Column Configuration for pay-fines-table
 does not hide Account Type properly
In-Reply-To: <bug-24515-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24515-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24515-70-37wsmRGQUf@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24515

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jan 25 03:41:17 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 25 Jan 2020 02:41:17 +0000
Subject: [Koha-bugs] [Bug 24515] Column Configuration for pay-fines-table
 does not hide Account Type properly
In-Reply-To: <bug-24515-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24515-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24515-70-T6ATUrcsyJ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24515

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #97931|0                           |1
        is obsolete|                            |

--- Comment #2 from David Nind <david at davidnind.com> ---
Created attachment 97933
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97933&action=edit
Bug 24515: Column Configuration for pay-fines-table does not hide Account Type
properly

This patch corrects the order of the columns in the columns
configuration YML file. The incorrect order was causing the wrong column
to be hidden when changing the columns settings for the table in
Administration.

To test, apply the patch and go to Administration -> Columns settings.

 - Under Patrons -> pay-fines-table, test hiding the account_type and
   description columns, together and separately.
 - Verify that the correct columns are hidden on the pay fines screen
   (Patron -> Accounting -> Make a payment)

Signed-off-by: David Nind <david at davidnind.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jan 25 04:08:40 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 25 Jan 2020 03:08:40 +0000
Subject: [Koha-bugs] [Bug 24502] objects.search filter by prefetched columns
In-Reply-To: <bug-24502-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24502-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24502-70-KGAe3uGjKR@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24502

Agustín Moyano <agustinmoyano at theke.io> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff
   Patch complexity|---                         |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jan 25 04:08:43 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 25 Jan 2020 03:08:43 +0000
Subject: [Koha-bugs] [Bug 24502] objects.search filter by prefetched columns
In-Reply-To: <bug-24502-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24502-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24502-70-vYe7IrTuXd@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24502

--- Comment #1 from Agustín Moyano <agustinmoyano at theke.io> ---
Created attachment 97934
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97934&action=edit
Bug 24502: object.search also filter by prefetched columns

This patch adds the possibility to object.search helper, to also filter by
prefetched columns.

In order to dynamically add filter parameters, they must be coded as json
string, and sent within the q parameter.

The coded json, is in fact dbix syntax.

To test:
1. apply this patch
2. prove t/Koha/REST/Plugin/Query.t t/db_dependent/Koha/REST/Plugin/Objects.t
3. Sign off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jan 25 04:13:12 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 25 Jan 2020 03:13:12 +0000
Subject: [Koha-bugs] [Bug 24356] objects.search prefetch
In-Reply-To: <bug-24356-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24356-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24356-70-Rojmr39rtl@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24356

Agustín Moyano <agustinmoyano at theke.io> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jan 25 04:13:16 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 25 Jan 2020 03:13:16 +0000
Subject: [Koha-bugs] [Bug 24356] objects.search prefetch
In-Reply-To: <bug-24356-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24356-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24356-70-mYd0EdqL3l@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24356

Agustín Moyano <agustinmoyano at theke.io> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #97851|0                           |1
        is obsolete|                            |
  Attachment #97852|0                           |1
        is obsolete|                            |

--- Comment #9 from Agustín Moyano <agustinmoyano at theke.io> ---
Created attachment 97935
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97935&action=edit
Bug 24356: prefetch_whitelist tests

This patch adds tests for the introduced methods.

To test:
1. Run the tests :-D
=> SUCCESS: They pass!
2. Sign off :-D

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jan 25 04:13:19 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 25 Jan 2020 03:13:19 +0000
Subject: [Koha-bugs] [Bug 24356] objects.search prefetch
In-Reply-To: <bug-24356-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24356-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24356-70-2s44R1MpVE@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24356

--- Comment #10 from Agustín Moyano <agustinmoyano at theke.io> ---
Created attachment 97936
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97936&action=edit
Bug 24356: Make objects.search prefetch embedded relations

This patch makes the Koha::Object(s) derived classes expose information
about prefetch-able relations. This is then used by a new helper to
generate the prefetch information for the DBIC query.

To test:
1. Apply this patch
2. Run:
   $ kshell
  k$ prove t/db_dependent/Koha/Object* \
           t/db_dependent/Koha/REST/Plugin/Objects.t \
           t/db_dependent/Koha/REST/Plugin/Query.t
=> SUCCESS: Tests pass!
3. Sign off :-D

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jan 25 04:15:03 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 25 Jan 2020 03:15:03 +0000
Subject: [Koha-bugs] [Bug 23944] Phase out use of jquery.cookie.js in favor
 of js.cookie.js
In-Reply-To: <bug-23944-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23944-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23944-70-DfRxFRFbz1@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23944

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jan 25 04:15:06 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 25 Jan 2020 03:15:06 +0000
Subject: [Koha-bugs] [Bug 23944] Phase out use of jquery.cookie.js in favor
 of js.cookie.js
In-Reply-To: <bug-23944-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23944-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23944-70-Uth7d98Kup@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23944

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #96826|0                           |1
        is obsolete|                            |

--- Comment #5 from David Nind <david at davidnind.com> ---
Created attachment 97937
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97937&action=edit
Bug 23944: Phase out use of jquery.cookie.js in favor of js.cookie.js

This patch adds a new JavaScript file to the staff client's global
JavaScript include file: js.cookie-2.2.1.min.js. This "plugin" will
replace jquery.cookie.js which is no longer maintained.

The "About" page in the staff client is updated to include this new
resource as well as adding previously-missing information about the old
plugin which will remain until all instances of its usage have been
removed.

To test, apply the patch and check the About page to confirm the correct
information is included.

No functionality change is introduced by this bug. The only other
observable change is the existence of the new files and the inclusion of
the minified version of the file in any staff client page.

Signed-off-by: David Nind <david at davidnind.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jan 25 04:15:10 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 25 Jan 2020 03:15:10 +0000
Subject: [Koha-bugs] [Bug 23944] Phase out use of jquery.cookie.js in favor
 of js.cookie.js
In-Reply-To: <bug-23944-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23944-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23944-70-QoFgCGUx5q@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23944

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #96827|0                           |1
        is obsolete|                            |

--- Comment #6 from David Nind <david at davidnind.com> ---
Created attachment 97938
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97938&action=edit
Bug 23944: (follow-up) Update circulation to use new library

This patch updates the circulation page to use the new JavaScript Cookie
library for cookie management.

To test, apply the patch and open a patron record for checkout in the
staff client.

 - Click "Search to hold" in the toolbar and perform a catalog search
   which will return results.
 - On the search results page, the toolbar at the top of the results
   should include a split "Place hold" button. The button's menu should
   include "Place hold for <patron>" and "Forget <patron>" options. Test
   that these work correctly.
 - In the table of search results each title should include a "Place
   hold for <patron>" link.
 - Go to the checkouts page for a patron with one or more checked-out
   items.
   - Check the "Always show checkouts immediately" checkbox.
   - The patron's checkouts should load.
   - Open another patron for checkout who has checked-out items.
   - The table of checkouts should load automatically.

Signed-off-by: David Nind <david at davidnind.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jan 25 10:12:51 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 25 Jan 2020 09:12:51 +0000
Subject: [Koha-bugs] [Bug 22359] Improve usability of 'change calculation'
 (bug 11373)
In-Reply-To: <bug-22359-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22359-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22359-70-OMQYqk3Dx0@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22359

--- Comment #36 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
(In reply to Andrew Fuerste-Henry from comment #29)
> I'm signing this off, as it did block me from submitting a payment where
> collected < paid. But one non-blocking bit of weirdness -- it gives me
> different error messages depending on whether or not I'm paying off the
> whole fine.
> 
> If amount being paid = total amount payable and amount collected < amount
> being paid, Koha lets me click confirm and then pops up a big yellow alert
> saying "You must collect a value greater than or equal to [amount being
> paid]".
> 
> If amount being paid < total amount payable and amount collected < amount
> being paid, Koha immediately makes amount collected red and adds a little
> red message next to it reading "Please enter a value greater than or equal
> to [amount being paid]."
> 
> So, it works, but the inconsistency is weird.

I somehow missed this comment.. did you mean the wording in the yellow alert
box was inconsistent?  I can happily fix that here as a followup.. just wanted
to clarify what you meant.. That box should now only appear if you have
javascript disabled, but it's nice to know we're catching things in that case
too.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jan 25 10:14:10 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 25 Jan 2020 09:14:10 +0000
Subject: [Koha-bugs] [Bug 24495] Reword change collection feature
In-Reply-To: <bug-24495-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24495-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24495-70-ZdBb8oXrxb@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24495

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |david.roberts at ptfs-europe.c
                   |                            |om,
                   |                            |martin.renvoize at ptfs-europe
                   |                            |.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jan 25 10:14:58 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 25 Jan 2020 09:14:58 +0000
Subject: [Koha-bugs] [Bug 24495] Reword change collection feature
In-Reply-To: <bug-24495-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24495-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24495-70-HduWAL8cfV@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24495

--- Comment #1 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
This now spans two places.. the Point of Sale page and the Paycollect page..

Very open to suggestions on how to improve the wording here.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Sat Jan 25 10:15:07 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 25 Jan 2020 09:15:07 +0000
Subject: [Koha-bugs] [Bug 24495] Reword change collection feature
In-Reply-To: <bug-24495-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24495-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24495-70-yelfHUOqMq@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24495

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |Academy

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Sat Jan 25 10:15:12 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 25 Jan 2020 09:15:12 +0000
Subject: [Koha-bugs] [Bug 24495] Reword change collection feature
In-Reply-To: <bug-24495-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24495-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24495-70-6NLNnbampZ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24495

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |String patch

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Sat Jan 25 11:37:33 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 25 Jan 2020 10:37:33 +0000
Subject: [Koha-bugs] [Bug 24501] Authorities 'merge' is confusing
In-Reply-To: <bug-24501-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24501-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24501-70-qkdV3ZDM1K@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24501

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |m.de.rooy at rijksmuseum.nl

--- Comment #3 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
>From ExLibris:
Authorities - Preferred Term Correction – This job performs preferred term
correction on all bibliographic records that are linked to authority records
using the Authorities - Link BIB Headings job. For example, if a bibliographic
record contains the non-preferred term “Narcotics, Control of,” and the
associated authority record contains the preferred term “Drug control,” the
Authorities – Preferred Term Correction job replaces “Narcotics, Control of”
with the preferred term “Drug control.” Bibliographic records are also updated
with any subsequent updates to authority records.

=> The general term updating is used here in connection with preferred term
correction.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jan 25 11:39:35 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 25 Jan 2020 10:39:35 +0000
Subject: [Koha-bugs] [Bug 24501] Authorities 'merge' is confusing
In-Reply-To: <bug-24501-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24501-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24501-70-5b72GID6Df@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24501

--- Comment #4 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
OCLC: Once you control a heading (and add or replace the record in WorldCat),
the heading in the bibliographic record is automatically updated whenever the
linked authority record changes.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jan 25 11:44:16 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 25 Jan 2020 10:44:16 +0000
Subject: [Koha-bugs] [Bug 24501] Authorities 'merge' is confusing
In-Reply-To: <bug-24501-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24501-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24501-70-oqdKmKUAkr@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24501

--- Comment #5 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
(In reply to Katrin Fischer from comment #2)
> I understand that it is confusing, but changing a cronjob name means that in
> every installations people might have to change their cronjob setup... I am
> not sure if we should do this. And if we do it, maybe it should be a gradual
> process turning the current script into a wrapper that sends a deprecation
> warning to the logs for one release and asks you to switch.

We have renamed cron jobs in the past. But I agree that we should not do that
too often ;) In this case I think it is more important to update interface,
documentation etc. and even the routine name (C4::AuthoritiesMarc::merge) than
renaming the script and cronjobs.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jan 25 12:44:19 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 25 Jan 2020 11:44:19 +0000
Subject: [Koha-bugs] [Bug 24291] Explanation next to limit item types by
 library is confusing
In-Reply-To: <bug-24291-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24291-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24291-70-FnmgI102zJ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24291

--- Comment #1 from David Nind <david at davidnind.com> ---
Created attachment 97939
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97939&action=edit
Bug 24291: Update the item type form text for library limitation field

Bug 15497 introduced the ability to limit item types by library.
However, the text next to the 'Library limitation' selection field on
the item type form mentions authorized values and is confusing.

The current text reads: "Select 'All libraries' if this authorized value
must be displayed all the time. Otherwise select libraries you want to
associate with this value."

This patch updates the text on the item type add or edit form for the
'Library limitation' field to something more understandable.

To test:
1) Apply the patch
2) Go to Administration > Basic parameters > Item types
3) Click 'Edit' for any item type
4) The text next to the 'Library limitation' field should now show
"Select 'All libraries' if all libraries use this item type. Otherwise,
select the specific libraries that use this item type."
5) Sign off

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jan 25 12:45:18 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 25 Jan 2020 11:45:18 +0000
Subject: [Koha-bugs] [Bug 24291] Explanation next to limit item types by
 library is confusing
In-Reply-To: <bug-24291-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24291-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24291-70-c441oBPGaA@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24291

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |david at davidnind.com
                   |ity.org                     |
             Status|NEW                         |Needs Signoff
                 CC|                            |david at davidnind.com

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jan 25 15:49:10 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 25 Jan 2020 14:49:10 +0000
Subject: [Koha-bugs] [Bug 24516] New: Column Configuration does not hide
 Return Date
Message-ID: <bug-24516-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24516

            Bug ID: 24516
           Summary: Column Configuration does not hide Return Date
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: minor
          Priority: P5 - low
         Component: Staff Client
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: kelly at bywatersolutions.com
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com

There are two tables within the Patron module (in column configuration) that
work with the Accounting portion of Koha. "Pay Fines" and "Account Fines" -
both of these tables present the user with hiding a specific column found in
these areas within the Accounting screens, however, attempting to hide "Return
Date" in either/both of these tables does not work. 

To recreate:t

1. Go to Column Configuration.
2. Choose Patrons
3. Choose either Pay Fines or Account Fines table
4. Hide Return Date
5. Save
6. Check on patron's screen - boraccount.pl or pay.pl depending on which or
both tables you attempted to hide the return date- see that the return date is
still appearing. 

I have filed another bug similar to this 24515 dealing with these same tables.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jan 25 16:46:13 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 25 Jan 2020 15:46:13 +0000
Subject: [Koha-bugs] [Bug 13327] OPACPopupAuthorsSearch doesn't work with
 XSLT views
In-Reply-To: <bug-13327-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13327-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13327-70-47oou1ABlO@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13327

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Failed QA

--- Comment #4 from Owen Leonard <oleonard at myacpl.org> ---
Thanks for testing, David! I'll take a look.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jan 25 17:12:32 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 25 Jan 2020 16:12:32 +0000
Subject: [Koha-bugs] [Bug 22690] Merging records with many items too slow
 (Elasticsearch)
In-Reply-To: <bug-22690-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22690-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22690-70-uU80yEAGls@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22690

Michal Denar <black23 at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Failed QA

--- Comment #15 from Michal Denar <black23 at gmail.com> ---
Hi Ere,
patch working, but one test fails:
Test Summary Report
-------------------
t/db_dependent/Koha/Item.t (Wstat: 256 Tests: 5 Failed: 1)
  Failed test:  3
  Non-zero exit status: 1

Second test was OK.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jan 25 18:45:51 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 25 Jan 2020 17:45:51 +0000
Subject: [Koha-bugs] [Bug 24515] Column Configuration for pay-fines-table
 does not hide Account Type properly
In-Reply-To: <bug-24515-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24515-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24515-70-uAT691Usw0@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24515

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jan 25 18:45:54 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 25 Jan 2020 17:45:54 +0000
Subject: [Koha-bugs] [Bug 24515] Column Configuration for pay-fines-table
 does not hide Account Type properly
In-Reply-To: <bug-24515-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24515-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24515-70-cdOxs5ilHO@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24515

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #97933|0                           |1
        is obsolete|                            |

--- Comment #3 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 97940
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97940&action=edit
Bug 24515: Column Configuration for pay-fines-table does not hide Account Type
properly

This patch corrects the order of the columns in the columns
configuration YML file. The incorrect order was causing the wrong column
to be hidden when changing the columns settings for the table in
Administration.

To test, apply the patch and go to Administration -> Columns settings.

 - Under Patrons -> pay-fines-table, test hiding the account_type and
   description columns, together and separately.
 - Verify that the correct columns are hidden on the pay fines screen
   (Patron -> Accounting -> Make a payment)

Signed-off-by: David Nind <david at davidnind.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jan 25 18:50:14 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 25 Jan 2020 17:50:14 +0000
Subject: [Koha-bugs] [Bug 24497] CodeMirror indentation problems
In-Reply-To: <bug-24497-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24497-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24497-70-MJxBS5ZUGD@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24497

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Trivial patch
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jan 25 18:50:17 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 25 Jan 2020 17:50:17 +0000
Subject: [Koha-bugs] [Bug 24497] CodeMirror indentation problems
In-Reply-To: <bug-24497-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24497-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24497-70-O4VX1LVxb5@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24497

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #97929|0                           |1
        is obsolete|                            |

--- Comment #7 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 97941
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97941&action=edit
Bug 24497: Turn off smartIndent for SQL

Signed-off-by: Christopher Brannon <cbrannon at cdalibrary.org>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jan 25 18:51:00 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 25 Jan 2020 17:51:00 +0000
Subject: [Koha-bugs] [Bug 24511] Patron emailer report not using specified
 email column
In-Reply-To: <bug-24511-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24511-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24511-70-HSLRl4MtGg@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24511

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de
           Assignee|koha-bugs at lists.koha-commun |nick at bywatersolutions.com
                   |ity.org                     |

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jan 25 19:18:40 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 25 Jan 2020 18:18:40 +0000
Subject: [Koha-bugs] [Bug 18186] Plack config: Amounts with decimal comma
 instead of decimal dot breaking payments
In-Reply-To: <bug-18186-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18186-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18186-70-IGcJReJXuq@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18186

--- Comment #7 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Sounds plausible.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jan 25 19:29:54 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 25 Jan 2020 18:29:54 +0000
Subject: [Koha-bugs] [Bug 24511] Patron emailer report not using specified
 email column
In-Reply-To: <bug-24511-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24511-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24511-70-sGZUm1wXOQ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24511

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jan 25 19:29:58 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 25 Jan 2020 18:29:58 +0000
Subject: [Koha-bugs] [Bug 24511] Patron emailer report not using specified
 email column
In-Reply-To: <bug-24511-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24511-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24511-70-oV9bCpXswb@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24511

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #97892|0                           |1
        is obsolete|                            |

--- Comment #4 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 97942
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97942&action=edit
Bug 24511: Update variable names to avoid confusion

To test:
1 - Create a report
    SELECT borrowernumber, firstname, surname, email, emailpro FROM borrowers
WHERE surname='acosta'
2 - Create or edit patron with surname acosta to have a separate email and
emailpro
3 - perl misc/cronjobs/patron_emailer --notice HOLDS --module reserves
--verbose --email emailpro --report ## --from 'me at you.us'
4 - Note email is used, not email pro
5 - Apply patch
6 - Repeat, correct eamil is used

Signed-off-by: Kelly McElligott <kelly at bywatersolutions.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jan 25 19:34:31 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 25 Jan 2020 18:34:31 +0000
Subject: [Koha-bugs] [Bug 24484] Add explanatory text to batch patron
 deletion
In-Reply-To: <bug-24484-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24484-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24484-70-Tr0emWyexb@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24484

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |String patch
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jan 25 19:34:34 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 25 Jan 2020 18:34:34 +0000
Subject: [Koha-bugs] [Bug 24484] Add explanatory text to batch patron
 deletion
In-Reply-To: <bug-24484-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24484-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24484-70-tQ5xSowoyW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24484

--- Comment #14 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 97943
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97943&action=edit
Bug 24484: Add explanatory text to batch patron deletion

This patch adds a more detailed explanation about what the tool can do.

To test:

1) Open up the Batch patron deletion and anonymisation tool
2) Check the help text near the top of the screen
3) Install the patch and repeat steps 1 and 2
4) Check the help text has changed to the new version

Signed-off-by: Andrew Fuerste-Henry <andrew at bywatersolutions.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jan 25 19:34:52 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 25 Jan 2020 18:34:52 +0000
Subject: [Koha-bugs] [Bug 24484] Add explanatory text to batch patron
 deletion
In-Reply-To: <bug-24484-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24484-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24484-70-N6hC0gJug3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24484

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #97813|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jan 25 19:37:38 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 25 Jan 2020 18:37:38 +0000
Subject: [Koha-bugs] [Bug 13121] Move search results "action" links ("Place
 hold, " "Add tag, " etc) into include file
In-Reply-To: <bug-13121-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13121-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13121-70-q1MzAwNgWR@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13121

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Failed QA
                 CC|                            |katrin.fischer at bsz-bw.de

--- Comment #5 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Hi Owen, can you please check this fail from the QA script?

 FAIL   koha-tmpl/opac-tmpl/bootstrap/en/includes/title-actions-menu.inc
   OK     filters
   FAIL   forbidden patterns
                forbidden pattern: Contains old bootstrap style for buttons
(see bug 16239) (line 32)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jan 25 20:17:33 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 25 Jan 2020 19:17:33 +0000
Subject: [Koha-bugs] [Bug 13121] Move search results "action" links ("Place
 hold, " "Add tag, " etc) into include file
In-Reply-To: <bug-13121-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13121-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13121-70-N2sfpqdW5K@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13121

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Needs Signoff

--- Comment #6 from Owen Leonard <oleonard at myacpl.org> ---
(In reply to Katrin Fischer from comment #5)
> 		forbidden pattern: Contains old bootstrap style for buttons (see bug

It's a false positive. The OPAC still uses the "old bootstrap." The warning
should only be triggered for staff client templates.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jan 25 23:36:27 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 25 Jan 2020 22:36:27 +0000
Subject: [Koha-bugs] [Bug 24480] Fields added with Marc modifications
 templates are not added in an ordered way
In-Reply-To: <bug-24480-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24480-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24480-70-SnTHdeKw0D@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24480

Arthur Suzuki <arthur.suzuki at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #97695|0                           |1
        is obsolete|                            |

--- Comment #2 from Arthur Suzuki <arthur.suzuki at biblibre.com> ---
Created attachment 97944
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97944&action=edit
Bug 24480: Fix insert_fields_ordered instead of append_fields in SimpleMARC

Test plan :
 - create a marc modification template which add a new field to a record
 - apply that template to some records
 - verify that the new field is always appended at the bottom of the record,
even if some fields are higher.
 - apply patch
 - apply template to another set of records
 - verify the added field is now ordered within the already existing fields in
the records

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jan 25 23:36:59 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 25 Jan 2020 22:36:59 +0000
Subject: [Koha-bugs] [Bug 24480] Fields added with Marc modifications
 templates are not added in an ordered way
In-Reply-To: <bug-24480-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24480-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24480-70-Xl4EgP6Ula@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24480

Arthur Suzuki <arthur.suzuki at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jan 25 23:37:02 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 25 Jan 2020 22:37:02 +0000
Subject: [Koha-bugs] [Bug 24480] Fields added with Marc modifications
 templates are not added in an ordered way
In-Reply-To: <bug-24480-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24480-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24480-70-J7TNN6fFMo@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24480

--- Comment #3 from Arthur Suzuki <arthur.suzuki at biblibre.com> ---
Created attachment 97945
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97945&action=edit
Bug 24480: Unit test

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Jan 26 00:25:57 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 25 Jan 2020 23:25:57 +0000
Subject: [Koha-bugs] [Bug 17697] Improve NotesBlacklist system preference
 description to make clear where it will apply
In-Reply-To: <bug-17697-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17697-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17697-70-yqgdPQnHny@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17697

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Jan 26 00:26:02 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 25 Jan 2020 23:26:02 +0000
Subject: [Koha-bugs] [Bug 17697] Improve NotesBlacklist system preference
 description to make clear where it will apply
In-Reply-To: <bug-17697-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17697-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17697-70-W1oVKDZUGW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17697

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #97266|0                           |1
        is obsolete|                            |

--- Comment #3 from David Nind <david at davidnind.com> ---
Created attachment 97946
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97946&action=edit
Bug 17697: Improve NotesBlacklist system preference description

- Switched 'separator' for more common 'tab' and rephrased sentence
- Added examples
- Added note to use hidden settings for hiding in other spots.

To test:
- Search for NotesBlacklist system preference and read the description
- Apply patch
- Refresh and read again
- If improved, sign off.

https://bugs.koha-community.org/show_bug.cgi?id=24206

Signed-off-by: David Nind <david at davidnind.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Jan 26 00:30:10 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 25 Jan 2020 23:30:10 +0000
Subject: [Koha-bugs] [Bug 17697] Improve NotesBlacklist system preference
 description to make clear where it will apply
In-Reply-To: <bug-17697-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17697-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17697-70-4tTOWner1N@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17697

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |david at davidnind.com

--- Comment #4 from David Nind <david at davidnind.com> ---
Reads much better to me! Made a very minor tweak - added an 'a' (changed 'Use
comma..." to "Use a comma...").

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Jan 26 00:31:11 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 25 Jan 2020 23:31:11 +0000
Subject: [Koha-bugs] [Bug 22806] HoldTitle and HoldItem do not check
 AllowHoldsOnPatronsPossessions
In-Reply-To: <bug-22806-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22806-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22806-70-r9tK3DKER8@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22806

--- Comment #11 from Arthur Suzuki <arthur.suzuki at biblibre.com> ---
Created attachment 97947
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97947&action=edit
Bug 22806: Unit Tests

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Jan 26 01:26:48 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 26 Jan 2020 00:26:48 +0000
Subject: [Koha-bugs] [Bug 24495] Reword change collection feature
In-Reply-To: <bug-24495-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24495-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24495-70-Y43pkux6Oq@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24495

David Roberts <david.roberts at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |david.roberts at ptfs-europe.c
                   |ity.org                     |om

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Sun Jan 26 01:40:34 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 26 Jan 2020 00:40:34 +0000
Subject: [Koha-bugs] [Bug 24495] Reword change collection feature
In-Reply-To: <bug-24495-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24495-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24495-70-mJHRgVnoV7@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24495

--- Comment #2 from David Roberts <david.roberts at ptfs-europe.com> ---
Would changing "Amount being paid" to something like "total owed" or
"subtotal", and "Collect from patron" to something like "Amount tendered" be an
acceptable rewording?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Jan 26 07:19:51 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 26 Jan 2020 06:19:51 +0000
Subject: [Koha-bugs] [Bug 24347] Add a 'search to order' option similar to
 'search to hold'
In-Reply-To: <bug-24347-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24347-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24347-70-zcNvkbeFSo@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24347

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Jan 26 07:19:54 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 26 Jan 2020 06:19:54 +0000
Subject: [Koha-bugs] [Bug 24347] Add a 'search to order' option similar to
 'search to hold'
In-Reply-To: <bug-24347-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24347-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24347-70-JlSqkQRXCU@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24347

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #96838|0                           |1
        is obsolete|                            |

--- Comment #4 from David Nind <david at davidnind.com> ---
Created attachment 97948
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97948&action=edit
Bug 24347: Add a 'search to order' option similar to 'search to hold'

This patch modifes the process of searching for an existing record
to add to a basket. Now the search is performed as a keyword search in
the regular catalog rather than via a custom search script. Options are
added to the search results and detail pages to add results to an order.

This process follows the same pattern as the "Search to hold" feature:
When the search is initiated, a cookie is set with the requisite
information--in this case vendor id and basket number.

If the search results or bibliographic detail pages detect that a
"searchToOrder" cookie is present, the correct "Add order" link will be
shown. Like with the "search to hold" feature, the cookie expires in 10
minutes.

To test, apply the patch and log into the staff client as a user who has
permission to add to a basket in acquisitions.

 - Go to Acquisitions -> Vendor -> Basket -> Add to basket.
 - Using the "From an existing record" option, perform a search.
 - On the search results page, test the "Add order" link which appears
   with each result. Clicking the link should take you to the "New
   order" page for the correct vendor and basket. The catalog
   details section of the form should include the correct information.
 - From the search results page view the bibliographic details page for
   any record. There should be a new toolbar button, "Add order." Verify
   that it works correctly.
   - Test the same thing from all bibliographic detail pages: Normal,
     MARC, Labeled MARC (enable viewLabeledMARC system preference), ISBD,
     as well as the items page (moredetail.pl).
 - Test this process for both the locations in acquisitions where one
   can add to an existing basket: Vendor search results and the basket
   detail page
 - Test the cookie timeout: Wait 10 minutes and perform another catalog
   search. The "Add order" link should no longer be present.

Signed-off-by: David Nind <david at davidnind.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Jan 26 07:19:58 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 26 Jan 2020 06:19:58 +0000
Subject: [Koha-bugs] [Bug 24347] Add a 'search to order' option similar to
 'search to hold'
In-Reply-To: <bug-24347-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24347-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24347-70-ML8hJ1jlS8@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24347

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #96839|0                           |1
        is obsolete|                            |

--- Comment #5 from David Nind <david at davidnind.com> ---
Created attachment 97949
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97949&action=edit
Bug 24347: (follow-up) Remove custom catalog search from acquisitions

This patch removes the "neworderbiblio" script and template which are
made obsolete by the "search to order" feature.

deleted:    acqui/neworderbiblio.pl
deleted:    koha-tmpl/intranet-tmpl/prog/en/modules/acqui/neworderbiblio.tt

Some documentation in addorder.pl has been corrected to remove reference
to neworderbiblio.pl.

To test, apply the patch and verify that the correct files have been
removed.

Search the Koha codebase to verify that no links to
acqui/neworderbiblio.pl remain.

Signed-off-by: David Nind <david at davidnind.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Jan 26 07:34:49 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 26 Jan 2020 06:34:49 +0000
Subject: [Koha-bugs] [Bug 23947] Phase out jquery.cookie.js: Authority merge
In-Reply-To: <bug-23947-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23947-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23947-70-JHf0vCoQB4@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23947

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Jan 26 07:34:52 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 26 Jan 2020 06:34:52 +0000
Subject: [Koha-bugs] [Bug 23947] Phase out jquery.cookie.js: Authority merge
In-Reply-To: <bug-23947-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23947-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23947-70-dz6EP3RIPI@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23947

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #94956|0                           |1
        is obsolete|                            |

--- Comment #2 from David Nind <david at davidnind.com> ---
Created attachment 97950
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97950&action=edit
Bug 23947: Phase out jquery.cookie.js: Authority merge

This patch updates the JavaScript which sets cookies during the
authority merge process so that it uses the new js-cookie library.

To test, apply the patch and perform a search in the authority module
which will return multiple results.

 - Select "Merge" from the Actions menu next to any result.
   - A message should appear at the top of the page: "Merging with
     authority: <title>".
   - Click "Cancel merge." The message should disappear.
 - Select a record to merge again.
   - Select another record.
   - The page should redirect to the authority merge page.

Signed-off-by: David Nind <david at davidnind.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Jan 26 18:41:47 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 26 Jan 2020 17:41:47 +0000
Subject: [Koha-bugs] [Bug 24502] Add a query language and param (q=) to the
 API
In-Reply-To: <bug-24502-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24502-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24502-70-nXLCV18dJL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24502

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         QA Contact|testopia at bugs.koha-communit |
                   |y.org                       |
            Summary|objects.search filter by    |Add a query language and
                   |prefetched columns          |param (q=) to the API
          Component|Architecture, internals,    |REST API
                   |and plumbing                |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Jan 26 18:42:15 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 26 Jan 2020 17:42:15 +0000
Subject: [Koha-bugs] [Bug 24502] Add a query language and param (q=) to the
 API
In-Reply-To: <bug-24502-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24502-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24502-70-HRypM3MxdB@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24502

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org,
                   |                            |kyle at bywatersolutions.com,
                   |                            |martin.renvoize at ptfs-europe
                   |                            |.com,
                   |                            |nick at bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Jan 26 21:26:02 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 26 Jan 2020 20:26:02 +0000
Subject: [Koha-bugs] [Bug 23915] Replace OPAC list sort menu with Bootstrap
 menu button
In-Reply-To: <bug-23915-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23915-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23915-70-3JYpSxeAy3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23915

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Patch doesn't apply
                 CC|                            |david at davidnind.com

--- Comment #3 from David Nind <david at davidnind.com> ---
Error message when applying patch - I think this means the patch didn't apply:

Applying: Bug 23915: Replace OPAC list sort menu with Bootstrap menu button
error: sha1 information is lacking or useless
(koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-shelves.tt).
error: could not build fake ancestor
Patch failed at 0001 Bug 23915: Replace OPAC list sort menu with Bootstrap menu
button
The copy of the patch that failed is found in: .git/rebase-apply/patch
When you have resolved this problem run "git bz apply --continue".
If you would prefer to skip this patch, instead run "git bz apply --skip".
To restore the original branch and stop patching run "git bz apply --abort".
Patch left in
/tmp/Bug-23915-Replace-OPAC-list-sort-menu-with-Bootstr-dRZj3P.patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Jan 26 21:42:37 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 26 Jan 2020 20:42:37 +0000
Subject: [Koha-bugs] [Bug 24488] Holds to Pull sometimes shows the wrong
 'first patron' details
In-Reply-To: <bug-24488-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24488-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24488-70-KEc1mUdTIo@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24488

--- Comment #3 from Aleisha Amohia <aleisha at catalyst.net.nz> ---
(In reply to Kelly McElligott from comment #2)
> Aleisha- something odd- nothing is showing in the Holds To Pull report.  I
> have tried this multiple times and unable to get the holds to populate. Both
> biblio and Item level holds.

Hi Kelly, is this before or after you apply the patch? If after, did you try
upgrading the schema files and restarting memcached?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Jan 26 23:43:50 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 26 Jan 2020 22:43:50 +0000
Subject: [Koha-bugs] [Bug 22868] Circulation staff with suggestions_manage
 can have access to acquisition data
In-Reply-To: <bug-22868-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22868-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22868-70-l7UaQtOfrT@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22868

Hayley Mapley <hayleymapley at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Jan 26 23:43:54 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 26 Jan 2020 22:43:54 +0000
Subject: [Koha-bugs] [Bug 22868] Circulation staff with suggestions_manage
 can have access to acquisition data
In-Reply-To: <bug-22868-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22868-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22868-70-d67yBpsEB4@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22868

Hayley Mapley <hayleymapley at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #97666|0                           |1
        is obsolete|                            |

--- Comment #26 from Hayley Mapley <hayleymapley at catalyst.net.nz> ---
Created attachment 97951
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97951&action=edit
Bug 22868: Move suggestions_manage subperm out of acquisition perm

Bug 11911 replaced the permission of suggestions.pl (create a purchase
suggestion) from catalogue => 1 to acquisition => 'suggestions_manage'.
However we have a lot of acquisition scripts that have lax permissions
(acquisition => '*' which means any sub permissions of acquisition is
enough).

That causes problem when a circulation staff can create purchase
suggestions but not access acquisition information.

One solution is to move the suggestions_manage subpermission out of the
acquisition permission and create a new suggestion permission.

Test plan:
0. Setup
* Create a patron with several permission (and full acquisition
permission)
* Create another patron with several permission, and suggestions_manage
permission
* Create another patron without the suggestions_manage permission
1. Apply the patch and execute the update database entry
2. Note that the third patron you create still does not have
suggestions_manage
3. Confirm that you can create a purchase suggestion if you have
suggestions_manage, but cannot access acquisition pages if you do not
have any subpermissions of the acquisition permission

Signed-off-by: Hayley Mapley <hayleymapley at catalyst.net.nz>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 27 01:49:18 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Jan 2020 00:49:18 +0000
Subject: [Koha-bugs] [Bug 23113] members/pay.tt account_grp is not longer
 used
In-Reply-To: <bug-23113-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23113-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23113-70-5mm9knf7Yk@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23113

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 27 01:49:21 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Jan 2020 00:49:21 +0000
Subject: [Koha-bugs] [Bug 23113] members/pay.tt account_grp is not longer
 used
In-Reply-To: <bug-23113-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23113-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23113-70-taHgwvrwpz@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23113

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #96889|0                           |1
        is obsolete|                            |

--- Comment #4 from David Nind <david at davidnind.com> ---
Created attachment 97952
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97952&action=edit
Bug 23113: members/pay.tt account_grp is not longer used

This patch removes obsolete markup from pay.tt.

To test, apply the patch and search the Koha codebase for instances of
"account_grp" There should be none.

Log in to the staff client and go to the account of a patron who has
fines. Confirm that the "Accounting" page ("Make a payment" tab) works
correctly.

Signed-off-by: David Nind <david at davidnind.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 27 02:30:28 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Jan 2020 01:30:28 +0000
Subject: [Koha-bugs] [Bug 24496] Add ability to disable change calculation
In-Reply-To: <bug-24496-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24496-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24496-70-ljx2iMDy3Z@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24496

David Roberts <david.roberts at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |david.roberts at ptfs-europe.c
                   |                            |om

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 27 02:44:04 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Jan 2020 01:44:04 +0000
Subject: [Koha-bugs] [Bug 23856] Split author and ISBN/ISSN out of citation
 in staged MARC record management
In-Reply-To: <bug-23856-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23856-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23856-70-tpvGptB8vA@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23856

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 27 02:44:07 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Jan 2020 01:44:07 +0000
Subject: [Koha-bugs] [Bug 23856] Split author and ISBN/ISSN out of citation
 in staged MARC record management
In-Reply-To: <bug-23856-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23856-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23856-70-yWy8UiTXSD@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23856

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #94479|0                           |1
        is obsolete|                            |

--- Comment #2 from David Nind <david at davidnind.com> ---
Created attachment 97953
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97953&action=edit
Bug 23856: Split author and ISBN/ISSN out of citation in staged MARC record
management

This patch modifies the way data is passed to the staged MARC record
management template, splitting author, ISBN, and ISSN out of the
"citation" variable and passing them separately.

The DataTables configuration for the staged MARC record management page
is modified so that those now-separate variables are conditionally
displayed.

Unrelated minor change: Added a class to the MARC preview modal so that
it displays wider.

To test, apply the patch and view the "Staged MARC management" page for
both batches of bibliographic records and batches of authority records.

In each case the title or authority heading should be displayed as a
link while author, ISBN, and ISSN (if any) should not.

Signed-off-by: David Nind <david at davidnind.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 27 02:52:52 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Jan 2020 01:52:52 +0000
Subject: [Koha-bugs] [Bug 24475] Reword FinesMode system preference
In-Reply-To: <bug-24475-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24475-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24475-70-j7SOdmbngO@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24475

David Roberts <david.roberts at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |david.roberts at ptfs-europe.c
                   |                            |om
           Assignee|koha-bugs at lists.koha-commun |david.roberts at ptfs-europe.c
                   |ity.org                     |om

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 27 03:05:38 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Jan 2020 02:05:38 +0000
Subject: [Koha-bugs] [Bug 24475] Reword FinesMode system preference
In-Reply-To: <bug-24475-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24475-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24475-70-wd8lySsOnX@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24475

--- Comment #5 from David Roberts <david.roberts at ptfs-europe.com> ---
Created attachment 97954
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97954&action=edit
Bug 24475: Reword FinesMode system preference

This patch changes the wording of the FinesMode and
CalculateFinesOnReturn syste
m preferences explanations

1) Install Patch
2) Check that the wording of the FinesMode system preference has changed
to "NOTE: If the misc/cronjobs/fines.pl cronjob is being run, accruing
and final fines will be calculated when the cron runs and accruing fines
will be finalized when an item is returned. If CalculateFinesOnReturn is
enabled, final fines will be calculated when an item is returned."
3) Check that the wording of the CalculateFinesOnReturn system
preference has changed to add "NOTE: This system preference requires
FinesMode to be set to 'Calculate and charge.'" to the existing note.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 27 03:09:09 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Jan 2020 02:09:09 +0000
Subject: [Koha-bugs] [Bug 24475] Reword FinesMode system preference
In-Reply-To: <bug-24475-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24475-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24475-70-6BmQbJCEes@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24475

David Roberts <david.roberts at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

--- Comment #6 from David Roberts <david.roberts at ptfs-europe.com> ---
Working on the assumption that this is a purely cosmetic change and the actual
functional changes to the system preference discussed here will be resolved
elsewhere, I've changed the wording on these two system preferences. I don't
think that the change I've made here will depend on the changes in bug 21633.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 27 03:54:10 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Jan 2020 02:54:10 +0000
Subject: [Koha-bugs] [Bug 12469] Add more information to the ILS-DI results
In-Reply-To: <bug-12469-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-12469-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12469-70-AnoRmj5dvH@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12469

--- Comment #8 from Arthur Suzuki <arthur.suzuki at biblibre.com> ---
Created attachment 97955
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97955&action=edit
Bug 12469: make ILS-DI include the call number.

This has ILS-DI include the call number as part of the human-readable
location field. It is included in the same form as the examples in the
specification.

Test plan:
* Hit an ILS-DI URL like:
http://koha/cgi-bin/koha/ilsdi.pl?service=GetAvailability&id=1+2+1781&id_type=item
* see that the location information is now "Branch, Call # 123.4 ABC"

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 27 03:54:38 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Jan 2020 02:54:38 +0000
Subject: [Koha-bugs] [Bug 12469] Add more information to the ILS-DI results
In-Reply-To: <bug-12469-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-12469-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12469-70-RE8RQZxxlO@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12469

Arthur Suzuki <arthur.suzuki at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #29201|0                           |1
        is obsolete|                            |
  Attachment #29202|0                           |1
        is obsolete|                            |

--- Comment #9 from Arthur Suzuki <arthur.suzuki at biblibre.com> ---
Created attachment 97956
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97956&action=edit
Bug 12469: add due dates to the ILSDI interface

This adds the dlf:dateavailable field to ILSDI item availability
information if an item is currently checked out.

Test plan:
* Hit the ILSDI GetAvailability URL for an issued item
* See that it now has the return date

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 27 03:54:55 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Jan 2020 02:54:55 +0000
Subject: [Koha-bugs] [Bug 12469] Add more information to the ILS-DI results
In-Reply-To: <bug-12469-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-12469-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12469-70-fllbQJXS4T@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12469

--- Comment #10 from Arthur Suzuki <arthur.suzuki at biblibre.com> ---
Created attachment 97957
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97957&action=edit
Bug 12469: Moved callnumber to a specific XML node in reply

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 27 03:55:09 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Jan 2020 02:55:09 +0000
Subject: [Koha-bugs] [Bug 12469] Add more information to the ILS-DI results
In-Reply-To: <bug-12469-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-12469-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12469-70-utincjfME7@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12469

--- Comment #11 from Arthur Suzuki <arthur.suzuki at biblibre.com> ---
Created attachment 97958
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97958&action=edit
Bug 12469: Added Unit tests for GetAvailability

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 27 03:55:23 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Jan 2020 02:55:23 +0000
Subject: [Koha-bugs] [Bug 12469] Add more information to the ILS-DI results
In-Reply-To: <bug-12469-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-12469-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12469-70-s8TLxyGH3L@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12469

Arthur Suzuki <arthur.suzuki at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 27 05:46:16 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Jan 2020 04:46:16 +0000
Subject: [Koha-bugs] [Bug 22379] ILS-DI Method "CancelHold" don't check
 CanReserveBeCanceledFromOpac
In-Reply-To: <bug-22379-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22379-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22379-70-WiXQXUNCOb@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22379

Arthur Suzuki <arthur.suzuki at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #94387|0                           |1
        is obsolete|                            |

--- Comment #5 from Arthur Suzuki <arthur.suzuki at biblibre.com> ---
Created attachment 97959
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97959&action=edit
Bug 22379: Fix checks not made by ILS-DI method CancelHold

Disable the possibility for a borrower to cancel a reservation
which is either in a Transit or Waiting state.
This reproduce the behaviour seen on the OPAC.
Also replaces previous checks on the borrowernumber
since CanReserveBeCanceledFromOpac already checks this.

--------------------------------

Test plan (before patch) :
-Put a reserve for a borrower
-Try to cancel the reserve providing another borrowernumber as argument
        -> Should fail and reply "RecordNotFound"
        -> Reserve still appears in the list of holds.

-Try to cancel the reserve providing the borrowernumber the reserve is
for.
        -> Should succeed, reply with "Canceled"
        -> Reserve do not show up in the list of holds for the borrower

-Put a new reserve with a pickup branch != from the homebranch
-Transfer the item to the pickup branch (reserve status = Transit)
-Try to cancel the reserve (with proper borrowernumber)
        -> Should succeed, reply with "Canceled"
        -> Reserve do not show up in the list of holds for the borrower

-Checkout the reserved item in the pickup branch (reserve status =
Waiting)
-Try to cancel the reserve (with proper borrowernumber)
        -> Should succeed, reply with "Canceled"
        -> Reserve do not show up in the list of holds for the borrower

--------------------------------

Test plan (after patch) :
-Put a reserve for a borrower
-Try to cancel the reserve providing another borrowernumber as argument
        -> Should fail and reply "BorrowerCannotCancelHold"
        -> Reserve still appears in the list of holds.

-Try to cancel the reserve providing the borrowernumber the reserve is
for.
        -> Should succeed, reply with "Canceled"
        -> Reserve do not show up in the list of holds for the borrower

-Put a new reserve with a pickup branch != from the homebranch
-Transfer the item to the pickup branch (reserve status = Transit)
-Try to cancel the reserve (with proper borrowernumber)
        -> Should fail and reply "BorrowerCannotCancelHold"
        -> Reserve still appears in the list of holds.

-Checkout the reserved item in the pickup branch (reserve status =
Waiting)
-Try to cancel the reserve (with proper borrowernumber)
        -> Should fail and reply "BorrowerCannotCancelHold"
        -> Reserve still appears in the list of holds.

Signed-off-by: Laurence Rault <laurence.rault at biblibre.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 27 05:46:38 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Jan 2020 04:46:38 +0000
Subject: [Koha-bugs] [Bug 22379] ILS-DI Method "CancelHold" don't check
 CanReserveBeCanceledFromOpac
In-Reply-To: <bug-22379-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22379-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22379-70-mb68e7Vf2u@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22379

Arthur Suzuki <arthur.suzuki at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 27 05:46:41 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Jan 2020 04:46:41 +0000
Subject: [Koha-bugs] [Bug 22379] ILS-DI Method "CancelHold" don't check
 CanReserveBeCanceledFromOpac
In-Reply-To: <bug-22379-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22379-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22379-70-JRJK5IZxq5@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22379

--- Comment #6 from Arthur Suzuki <arthur.suzuki at biblibre.com> ---
Created attachment 97960
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97960&action=edit
Bug 22379: Unit tests for CancelHold service

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 27 08:59:44 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Jan 2020 07:59:44 +0000
Subject: [Koha-bugs] [Bug 24517] New: Zebra: date-entered-on-file misses 6th
 position
Message-ID: <bug-24517-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24517

            Bug ID: 24517
           Summary: Zebra: date-entered-on-file misses 6th position
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Architecture, internals, and plumbing
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: m.de.rooy at rijksmuseum.nl
        QA Contact: testopia at bugs.koha-community.org

Date entered on file is in MARC21 tag 008 position 00 to 05 (or 1-6 for normal
humans). In Koha only the first 5 digits are indexed with Zebra. Does not
really facilitate searching ;)

  <index_control_field tag="008" offset="0" length="5">
    <target_index>date-entered-on-file:n</target_index>
  </index_control_field>
  <index_control_field tag="008" offset="0" length="5">
    <target_index>date-entered-on-file:s</target_index>
  </index_control_field>

  <xslo:template match="marc:controlfield[@tag='008']">
    <z:index name="date-entered-on-file:n">
      <xslo:value-of select="substring(., 1, 5)"/>
    </z:index>
    <z:index name="date-entered-on-file:s">
      <xslo:value-of select="substring(., 1, 5)"/>
    </z:index>

Elasticsearch appears to do a better job:

  date-entered-on-file:
    label: date-entered-on-file
    mappings:
      - facet: ''
        marc_field: '008_/0-5'
        marc_type: marc21
        sort: ~
        suggestible: ''
      - facet: ''
        marc_field: '008_/0-5'
        marc_type: normarc
        sort: ~
        suggestible: ''

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 27 09:10:10 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Jan 2020 08:10:10 +0000
Subject: [Koha-bugs] [Bug 22690] Merging records with many items too slow
 (Elasticsearch)
In-Reply-To: <bug-22690-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22690-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22690-70-AeJSitIlMt@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22690

--- Comment #16 from Ere Maijala <ere.maijala at helsinki.fi> ---
Mike, which test is failing? I'm seeing some errors from an unrelated test that
tries to clean up the database in wrong order (remove patrons before their
checkouts).

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 27 09:29:50 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Jan 2020 08:29:50 +0000
Subject: [Koha-bugs] [Bug 17084] Automatic debian/control updates (master)
In-Reply-To: <bug-17084-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17084-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17084-70-3gHmQ2lioP@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17084

--- Comment #47 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
I'm confused, why is it removing libarray-utils-perl and why is said module not
installed on koha-testing-docker from koha-common ?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 27 09:30:12 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Jan 2020 08:30:12 +0000
Subject: [Koha-bugs] [Bug 17084] Automatic debian/control updates (master)
In-Reply-To: <bug-17084-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17084-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17084-70-vXWjla0qKN@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17084

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         QA Contact|testopia at bugs.koha-communit |mtj at kohaaloha.com
                   |y.org                       |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 27 09:33:44 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Jan 2020 08:33:44 +0000
Subject: [Koha-bugs] [Bug 17510] MARC modification templates ignore subfield
 $0
In-Reply-To: <bug-17510-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17510-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17510-70-1UlFI9kb7g@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17510

Andreas Roussos <arouss1980 at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
           Assignee|gmcharlt at gmail.com          |arouss1980 at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 27 09:38:56 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Jan 2020 08:38:56 +0000
Subject: [Koha-bugs] [Bug 24486] Account Wording Information is duplicated
 in Patron's Fines Tab on OPAC
In-Reply-To: <bug-24486-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24486-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24486-70-JvSn7C0vkJ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24486

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|jonathan.druart at bugs.koha-c |oleonard at myacpl.org
                   |ommunity.org                |
             Status|Signed Off                  |ASSIGNED
                 CC|                            |martin.renvoize at ptfs-europe
                   |                            |.com,
                   |                            |nick at bywatersolutions.com

--- Comment #6 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
(In reply to Lucas Gass from comment #3)
> Hi Jonathan,
> 
> Yes I only see one one "(Voided)" but in some cases (when payment has not
> been voided) I see nothing at all.
> 
> I could be wrong but shouldn't it be 'account_status_description' that is
> deleted and 'account_type_description' that should stay?
> 
> 
> Thank you.

Ho you are right Lucas, the lines are not the same!
Then I do not know how to correctly fix this issue.

Martin or Nick may know.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 27 09:40:25 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Jan 2020 08:40:25 +0000
Subject: [Koha-bugs] [Bug 24486] Account Wording Information is duplicated
 in Patron's Fines Tab on OPAC
In-Reply-To: <bug-24486-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24486-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24486-70-Hvj0QTqf3Q@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24486

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |NEW

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 27 09:46:00 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Jan 2020 08:46:00 +0000
Subject: [Koha-bugs] [Bug 24486] Account Wording Information is duplicated
 in Patron's Fines Tab on OPAC
In-Reply-To: <bug-24486-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24486-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24486-70-LU0Tbfl4wT@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24486

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 27 09:46:04 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Jan 2020 08:46:04 +0000
Subject: [Koha-bugs] [Bug 24486] Account Wording Information is duplicated
 in Patron's Fines Tab on OPAC
In-Reply-To: <bug-24486-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24486-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24486-70-ehDJ716ikx@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24486

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #97894|0                           |1
        is obsolete|                            |

--- Comment #7 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 97961
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97961&action=edit
Bug 24486: Remove duplicated account information at the OPAC

Test plan:
Create a manual invoice
Pay it
Void it

Go to the opac, account
=> You should see only one "(Voided)"

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 27 09:46:23 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Jan 2020 08:46:23 +0000
Subject: [Koha-bugs] [Bug 24486] Account Wording Information is duplicated
 in Patron's Fines Tab on OPAC
In-Reply-To: <bug-24486-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24486-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24486-70-nupAgnVFhf@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24486

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|oleonard at myacpl.org         |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org

--- Comment #8 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
I think I finally found the proper fix.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 27 10:26:55 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Jan 2020 09:26:55 +0000
Subject: [Koha-bugs] [Bug 23681] Patron restrictions should be user definable
In-Reply-To: <bug-23681-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23681-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23681-70-PfqCDT6fJw@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681

--- Comment #57 from Andrew Isherwood <andrew.isherwood at ptfs-europe.com> ---
(In reply to Jonathan Druart from comment #54)
> (In reply to Andrew Isherwood from comment #1)
> > It has become increasingly apparent that using authorised values for this is
> > not the most appropriate way forward. The number of modifications and
> > additions to AV was increasing the scope of the work too much, it was clear
> > that AV was not the correct place for this.
> 
> Why? Can you explain?
> That was my first reaction reading the patches.
> Using AV will make the feature translatable in the future (bug 20307).

Clearly AV would have been the preferable route, which is why I spent some
considerable time trying to implement using AV before reluctantly abandoning
it, it certainly wasn't abandoned lightly. There were too many requirements of
this work that were not provided by AV and working around them was becoming
increasingly cludgy and unmaintainable.

This work was done a few months ago, so my memory of it isn't what it was, but
examples would be:
- the ability to specify a default restriction type, which any restrictions
would fall back to if the restriction type they were using was deleted
- the ability to prevent certain restriction types from being edited
- the ability to prevent certain restriction types from being deleted

> So you are adding a regression, the restrictions are no longer translatable.

They were previously held in borrower_debarments.type, they are now in
debarment_types, so I'm guessing adding translation support for the default
values is not an insurmountable problem, I am happy to add whatever work is
required to make that happen to this bug. Any additional values are added by
the user anyway, so are by their nature translatable.

>Is the "default" flag really useful? We could imagine a new "internal" flag (to replace ronly) for AVs.

I believe so. Restrictions need a type, even if one is not explicitly chosen.
Also, we need an ability to say "if a restriction type is deleted, any
restrictions that use this type should fall back to type X", the default flag
indicates which type is X.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 27 11:07:18 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Jan 2020 10:07:18 +0000
Subject: [Koha-bugs] [Bug 24339] SIP codes are missing from the default
 payment_types on installation
In-Reply-To: <bug-24339-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24339-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24339-70-iejeMsPRX7@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24339

--- Comment #10 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 97962
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97962&action=edit
Bug 24339: Do not assume there are exactly 3 SIP* AVs

Update DB entry 19.06.00.017:
We created SIP* AV from accountlines if '^Pay[[:digit:]]{2}$', so I
think we should assume that more than SIP00, SIP01, SIP02 can exist.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 27 11:08:19 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Jan 2020 10:08:19 +0000
Subject: [Koha-bugs] [Bug 24339] SIP codes are missing from the default
 payment_types on installation
In-Reply-To: <bug-24339-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24339-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24339-70-srzVmLAagP@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24339

--- Comment #11 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
(In reply to Martin Renvoize from comment #9)
> If we set it to >0 it'll be a regression in so much as we will now always
> show the 'Payment type' dropdown even if only system types are defined.

I do not understand what you meant here.
I suggested "payment_types - excluded > 0"
What about this follow-up?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 27 11:16:54 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Jan 2020 10:16:54 +0000
Subject: [Koha-bugs] [Bug 24497] CodeMirror indentation problems
In-Reply-To: <bug-24497-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24497-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24497-70-grZ4bEBwiA@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24497

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|enhancement                 |trivial
                 CC|                            |martin.renvoize at ptfs-europe
                   |                            |.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 27 11:17:21 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Jan 2020 10:17:21 +0000
Subject: [Koha-bugs] [Bug 24484] Add explanatory text to batch patron
 deletion
In-Reply-To: <bug-24484-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24484-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24484-70-GXz6QOogoT@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24484

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to master
         Version(s)|                            |20.05.00
        released in|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 27 11:17:23 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Jan 2020 10:17:23 +0000
Subject: [Koha-bugs] [Bug 24484] Add explanatory text to batch patron
 deletion
In-Reply-To: <bug-24484-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24484-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24484-70-phFubskBef@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24484

--- Comment #15 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Nice work everyone!

Pushed to master for 20.05

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 27 11:17:25 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Jan 2020 10:17:25 +0000
Subject: [Koha-bugs] [Bug 24497] CodeMirror indentation problems
In-Reply-To: <bug-24497-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24497-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24497-70-tODuvhP34i@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24497

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to master
         Version(s)|                            |20.05.00
        released in|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 27 11:17:27 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Jan 2020 10:17:27 +0000
Subject: [Koha-bugs] [Bug 24497] CodeMirror indentation problems
In-Reply-To: <bug-24497-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24497-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24497-70-fY29rEyXjV@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24497

--- Comment #8 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Nice work everyone!

Pushed to master for 20.05

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 27 11:17:29 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Jan 2020 10:17:29 +0000
Subject: [Koha-bugs] [Bug 24511] Patron emailer report not using specified
 email column
In-Reply-To: <bug-24511-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24511-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24511-70-hkJEYozQBc@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24511

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to master
         Version(s)|                            |20.05.00
        released in|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 27 11:17:31 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Jan 2020 10:17:31 +0000
Subject: [Koha-bugs] [Bug 24511] Patron emailer report not using specified
 email column
In-Reply-To: <bug-24511-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24511-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24511-70-N6PCNydKn6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24511

--- Comment #5 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Nice work everyone!

Pushed to master for 20.05

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 27 11:17:32 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Jan 2020 10:17:32 +0000
Subject: [Koha-bugs] [Bug 24515] Column Configuration for pay-fines-table
 does not hide Account Type properly
In-Reply-To: <bug-24515-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24515-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24515-70-1DEetW4qZ7@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24515

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to master
         Version(s)|                            |20.05.00
        released in|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 27 11:17:34 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Jan 2020 10:17:34 +0000
Subject: [Koha-bugs] [Bug 24515] Column Configuration for pay-fines-table
 does not hide Account Type properly
In-Reply-To: <bug-24515-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24515-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24515-70-a5YhZpb76f@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24515

--- Comment #4 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Nice work everyone!

Pushed to master for 20.05

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 27 11:23:11 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Jan 2020 10:23:11 +0000
Subject: [Koha-bugs] [Bug 24339] SIP codes are missing from the default
 payment_types on installation
In-Reply-To: <bug-24339-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24339-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24339-70-QY3njSNwXN@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24339

--- Comment #12 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Misread your comment

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 27 11:26:31 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Jan 2020 10:26:31 +0000
Subject: [Koha-bugs] [Bug 24339] SIP codes are missing from the default
 payment_types on installation
In-Reply-To: <bug-24339-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24339-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24339-70-HDFtejpHru@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24339

--- Comment #13 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
OK, I like your followup, it's much nicer than my original attempt. Thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 27 11:28:49 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Jan 2020 10:28:49 +0000
Subject: [Koha-bugs] [Bug 23681] Patron restrictions should be user definable
In-Reply-To: <bug-23681-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23681-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23681-70-kIZsmzWCaZ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681

--- Comment #58 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
(In reply to Andrew Isherwood from comment #57)
> (In reply to Jonathan Druart from comment #54)
> >Is the "default" flag really useful? We could imagine a new "internal" flag (to replace ronly) for AVs.
> 
> I believe so. Restrictions need a type, even if one is not explicitly
> chosen. Also, we need an ability to say "if a restriction type is deleted,
> any restrictions that use this type should fall back to type X", the default
> flag indicates which type is X.

I do not remember I saw a way to modify it, it's hardcoded in DB (and so could
be in the code).

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 27 11:31:07 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Jan 2020 10:31:07 +0000
Subject: [Koha-bugs] [Bug 24339] SIP codes are missing from the default
 payment_types on installation
In-Reply-To: <bug-24339-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24339-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24339-70-atIJEzIOle@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24339

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #97962|0                           |1
        is obsolete|                            |

--- Comment #14 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 97963
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97963&action=edit
Bug 24339: Do not assume there are exactly 3 SIP* AVs

Update DB entry 19.06.00.017:
We created SIP* AV from accountlines if '^Pay[[:digit:]]{2}$', so I
think we should assume that more than SIP00, SIP01, SIP02 can exist.

Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 27 11:31:54 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Jan 2020 10:31:54 +0000
Subject: [Koha-bugs] [Bug 23885] Move staff client search results JavaScript
 into separate file
In-Reply-To: <bug-23885-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23885-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23885-70-wBetTY5Yeo@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23885

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 27 11:31:57 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Jan 2020 10:31:57 +0000
Subject: [Koha-bugs] [Bug 23885] Move staff client search results JavaScript
 into separate file
In-Reply-To: <bug-23885-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23885-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23885-70-P8BksgY7bZ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23885

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #94630|0                           |1
        is obsolete|                            |

--- Comment #2 from David Nind <david at davidnind.com> ---
Created attachment 97964
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97964&action=edit
Bug 23885: Move staff client search results JavaScript into separate file

This patch moves most of the JavaScript embedded in results.tt into a
separate file. The JavaScript that remains on the page is everything
which requires processing by Template Toolkit. This is limited to
variable definition.

To test, apply the patch and perform a catalog search in the staff
client. On the results page, test that JavaScript functionality has not
been affected:

 - The search results toolbar should "float" as you scroll
 - Select all and Clear all
 - Default search term highlighting; Unhighlight and highlight controls
 - Adding and removing one or more items from the cart
 - Adding one or more items to a list
 - Placing one or more holds by making selections and clicking "Place
   hold"
 - Browse selected records
 - Z39.50 search (search form should be populated with your search
   terms)
 - "Show more" and "Show less" links in the facets sidebar
 - Book cover image services: Amazon, Coce, local covers, etc.
 - Open a patron record and click "Search to hold"
  - Perform a search and select one or more results
    - Test "Place hold" from the hold menu in the toolbar
    - Test "Place hold for..." from the hold menu in the toolbar
    - Test "Forget..." from the hold menu in the toolbar
 - In Tools -> Patron clubs, locate a club with enrolled members
   - From the "Actions" menu, select "Search to hold"
     - Perform a search and select one or more results
       - Test "Place hold" from the hold menu in the toolbar
       - Test "Place hold for..." from the hold menu in the toolbar
       - Test "Forget..." from the hold menu in the toolbar

Signed-off-by: David Nind <david at davidnind.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 27 11:35:35 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Jan 2020 10:35:35 +0000
Subject: [Koha-bugs] [Bug 24339] SIP codes are missing from the default
 payment_types on installation
In-Reply-To: <bug-24339-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24339-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24339-70-HAbgWk2h4F@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24339

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 27 11:35:39 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Jan 2020 10:35:39 +0000
Subject: [Koha-bugs] [Bug 24339] SIP codes are missing from the default
 payment_types on installation
In-Reply-To: <bug-24339-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24339-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24339-70-oIQezHvFmK@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24339

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #97676|0                           |1
        is obsolete|                            |
  Attachment #97677|0                           |1
        is obsolete|                            |
  Attachment #97963|0                           |1
        is obsolete|                            |

--- Comment #15 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 97965
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97965&action=edit
Bug 24339: Add SIP2 payment types for installation

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 27 11:35:42 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Jan 2020 10:35:42 +0000
Subject: [Koha-bugs] [Bug 24339] SIP codes are missing from the default
 payment_types on installation
In-Reply-To: <bug-24339-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24339-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24339-70-GhUsj31GF3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24339

--- Comment #16 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 97966
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97966&action=edit
Bug 24339: Remove SIP payment types from staff pay screens

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 27 11:35:46 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Jan 2020 10:35:46 +0000
Subject: [Koha-bugs] [Bug 24339] SIP codes are missing from the default
 payment_types on installation
In-Reply-To: <bug-24339-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24339-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24339-70-MOI3hg9OZC@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24339

--- Comment #17 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 97967
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97967&action=edit
Bug 24339: Do not assume there are exactly 3 SIP* AVs

Update DB entry 19.06.00.017:
We created SIP* AV from accountlines if '^Pay[[:digit:]]{2}$', so I
think we should assume that more than SIP00, SIP01, SIP02 can exist.

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 27 11:42:11 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Jan 2020 10:42:11 +0000
Subject: [Koha-bugs] [Bug 24339] SIP codes are missing from the default
 payment_types on installation
In-Reply-To: <bug-24339-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24339-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24339-70-aI3iN6H3uW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24339

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|                            |20.05.00
        released in|                            |
             Status|Passed QA                   |Pushed to master

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 27 11:42:13 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Jan 2020 10:42:13 +0000
Subject: [Koha-bugs] [Bug 24339] SIP codes are missing from the default
 payment_types on installation
In-Reply-To: <bug-24339-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24339-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24339-70-K3tDf01iiK@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24339

--- Comment #18 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Nice work everyone!

Pushed to master for 20.05

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 27 11:43:08 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Jan 2020 10:43:08 +0000
Subject: [Koha-bugs] [Bug 24421] Generated authorities are missing subfields
In-Reply-To: <bug-24421-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24421-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24421-70-kMWIlstUp9@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24421

--- Comment #8 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Coming from
  commit b2b7d376d4854394322310f28d2f5aa1560384e0
  Bug 21826: Use subfield map in LinkBibHeadingsToAuthorities

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 27 11:43:49 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Jan 2020 10:43:49 +0000
Subject: [Koha-bugs] [Bug 24421] Generated authorities are missing subfields
In-Reply-To: <bug-24421-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24421-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24421-70-1frR1OQYJD@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24421

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 27 11:43:53 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Jan 2020 10:43:53 +0000
Subject: [Koha-bugs] [Bug 24421] Generated authorities are missing subfields
In-Reply-To: <bug-24421-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24421-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24421-70-qGEMjNkZg7@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24421

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #97881|0                           |1
        is obsolete|                            |
  Attachment #97882|0                           |1
        is obsolete|                            |

--- Comment #9 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 97968
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97968&action=edit
Bug 24421: Unit tests

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 27 11:43:56 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Jan 2020 10:43:56 +0000
Subject: [Koha-bugs] [Bug 24421] Generated authorities are missing subfields
In-Reply-To: <bug-24421-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24421-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24421-70-YVXpHX6LUR@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24421

--- Comment #10 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 97969
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97969&action=edit
Bug 24421: Check if subfields are valid using the biblio tag

To test:
 1 - Enable the sysprefs
     AutoCreateAuthorities
     BiblioAddsAuthorities
     CatalogModuleRelink
 2 - Open a record with a subject heading with a subdivision and add a new
subfield, or add a new unauthroized heading to a record and save it
    e.g. 650$aChess$xOpenings$vFiction.
 3 - Save the record, note the created authority and that field is linked
 4 - Save the record again and note the authority number changes
 5 - Find and view the authority linked to the record
 6 - The record is for 'Chess', not Chess openings'
 7 - Search authorities for 'Chess' - note duplicated records
 8 - Apply patch, restart all
 9 - Save the record, auth number increases again, we shoudl create the correct
record this time
10 - Save again, auth number should not change
11 - Search authorities and confirm the generated authority has the correct
subfields

Signed-off-by: Myka Kennedy Stephens <mkstephens at lancasterseminary.edu>

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 27 11:44:21 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Jan 2020 10:44:21 +0000
Subject: [Koha-bugs] [Bug 23885] Move staff client search results JavaScript
 into separate file
In-Reply-To: <bug-23885-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23885-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23885-70-eJRAHydMi6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23885

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |david at davidnind.com

--- Comment #3 from David Nind <david at davidnind.com> ---
Created attachment 97970
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97970&action=edit
Bug 23885: Screenshots of potential problem

A potential problem identified during testing is placing a hold for a Patron
club. 

This didn’t work for me before the patch was applied as well as when the patch
was applied, so it is either something I did or it is another issue.

When you select an item with a tick and then try to place a hold for the Patron
Club from the drop down list (screenshot 1 in attachment) you get “No items are
available” (see screenshot 2 in attachment).

Selecting ‘Place hold for ...’ from the links works fine though.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 27 11:44:40 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Jan 2020 10:44:40 +0000
Subject: [Koha-bugs] [Bug 24339] SIP codes are missing from the default
 payment_types on installation
In-Reply-To: <bug-24339-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24339-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24339-70-9xIMaC2BUe@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24339

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|RM_priority                 |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 27 11:45:25 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Jan 2020 10:45:25 +0000
Subject: [Koha-bugs] [Bug 22721] Normalize GetMarcFromKohaField calls
In-Reply-To: <bug-22721-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22721-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22721-70-4eVyqij4JX@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22721

--- Comment #13 from Fridolin SOMERS <fridolin.somers at biblibre.com> ---
(In reply to Oleg Vasilenko from comment #12)
> Sorry, I have no time to open new bug. 
> 
> cataloguing/value_builder/barcode_manual.pl
> lacks following line:
> 
> use C4::Biblio qw/GetMarcFromKohaField/;
> 
> Without this line, Internal server error occurs.

Already fixed, by Bug 24503

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 27 11:57:04 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Jan 2020 10:57:04 +0000
Subject: [Koha-bugs] [Bug 18501] Automatic refunds need protection from
 failure
In-Reply-To: <bug-18501-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18501-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18501-70-tQN7PiBV4B@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18501

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org

--- Comment #1 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Can you confirm we are talking about RefundLostOnReturnControl here?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 27 11:58:37 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Jan 2020 10:58:37 +0000
Subject: [Koha-bugs] [Bug 24486] Account Wording Information is duplicated
 in Patron's Fines Tab on OPAC
In-Reply-To: <bug-24486-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24486-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24486-70-ig5h3PoLOT@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24486

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #97961|0                           |1
        is obsolete|                            |

--- Comment #9 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 97971
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97971&action=edit
Bug 24486: Remove duplicated account information at the OPAC

Test plan:
Create a manual invoice
Pay it
Void it

Go to the opac, account
=> You should see only one "(Voided)"

Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 27 11:59:08 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Jan 2020 10:59:08 +0000
Subject: [Koha-bugs] [Bug 24486] Account Wording Information is duplicated
 in Patron's Fines Tab on OPAC
In-Reply-To: <bug-24486-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24486-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24486-70-shppJsK078@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24486

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

--- Comment #10 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Good catch, trivial fix.. works as expected, Passing QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 27 11:59:13 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Jan 2020 10:59:13 +0000
Subject: [Koha-bugs] [Bug 24486] Account Wording Information is duplicated
 in Patron's Fines Tab on OPAC
In-Reply-To: <bug-24486-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24486-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24486-70-39nKYt3gbI@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24486

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 27 12:02:02 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Jan 2020 11:02:02 +0000
Subject: [Koha-bugs] [Bug 24348] Record matching rules: required match
 checks does not work
In-Reply-To: <bug-24348-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24348-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24348-70-pmpMFdERBb@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24348

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |22046
           See Also|https://bugs.koha-community |
                   |.org/bugzilla3/show_bug.cgi |
                   |?id=22046                   |
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org
           Assignee|koha-bugs at lists.koha-commun |andreas.jonsson at kreablo.se
                   |ity.org                     |


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22046
[Bug 22046] Simplify C4::Matcher->get_matches
-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 27 12:02:02 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Jan 2020 11:02:02 +0000
Subject: [Koha-bugs] [Bug 22046] Simplify C4::Matcher->get_matches
In-Reply-To: <bug-22046-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22046-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22046-70-2yhd0twEH9@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22046

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |24348
           See Also|https://bugs.koha-community |
                   |.org/bugzilla3/show_bug.cgi |
                   |?id=24348                   |


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24348
[Bug 24348] Record matching rules: required match checks does not work
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 27 12:11:25 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Jan 2020 11:11:25 +0000
Subject: [Koha-bugs] [Bug 23091] Restore Forgiven Overdue Fines When Lost
 Item Returned
In-Reply-To: <bug-23091-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23091-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23091-70-VsLmlrAxM0@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23091

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |ASSIGNED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 27 12:15:10 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Jan 2020 11:15:10 +0000
Subject: [Koha-bugs] [Bug 24338] CASH is missing from the default
 payment_types
In-Reply-To: <bug-24338-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24338-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24338-70-5o2NK8NUk7@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24338

--- Comment #1 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 97972
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97972&action=edit
Bug 24338: Add 'CASH' to default 'PAYMENT_TYPE' AV

Bug 23321 adds cash registers to the koha accounts system and as part of
that work introduces the 'CASH' payment type as a required option to
allow requirment of a 'CASH_REGISTER' when making cash payments. The
original patchset, however, forgot to add this new authorised value
during installation and upgrade.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 27 12:15:38 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Jan 2020 11:15:38 +0000
Subject: [Koha-bugs] [Bug 24338] CASH is missing from the default
 payment_types
In-Reply-To: <bug-24338-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24338-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24338-70-WtpRpTwKsr@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24338

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 27 12:16:30 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Jan 2020 11:16:30 +0000
Subject: [Koha-bugs] [Bug 24338] CASH is missing from the default
 payment_types
In-Reply-To: <bug-24338-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24338-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24338-70-rncPjHMVDW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24338

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |kyle at bywatersolutions.com,
                   |                            |nick at bywatersolutions.com,
                   |                            |tomascohen at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 27 12:25:40 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Jan 2020 11:25:40 +0000
Subject: [Koha-bugs] [Bug 24428] Elastic search index does not contain
 consistent item information
In-Reply-To: <bug-24428-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24428-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24428-70-cCxyCNgLhW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24428

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Version|18.11                       |master
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org
           Severity|critical                    |enhancement

--- Comment #5 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
I would consider this more like an enhancement request than a critical bug. We
will need to create a new index for items, which implies a quite big work.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 27 12:28:05 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Jan 2020 11:28:05 +0000
Subject: [Koha-bugs] [Bug 24518] New: Partner filtering does not work in IE11
Message-ID: <bug-24518-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24518

            Bug ID: 24518
           Summary: Partner filtering does not work in IE11
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: ILL
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: andrew.isherwood at ptfs-europe.com

We're doing something like this to hide options that are not applicable to the
current filtering string:

$('#my_select_option').hide();

This applies the following CSS rule to the <option> element:

display: none

It turns out that IE won't hide option elements. So, that's annoying.

We have a couple of choices here. We could either clone the entire list of
partners, filter out the ones that don't match the search string and then use
the remainder to repopulate the <option> elements. Or we could wrap the
<options> in something that IE11 will apply display:none to, such as a <span>
or something. However, this will lead to something that is semantically
incorrect for HTML5, since a <select> can only have <option> or <optgroup> as
it's children.

Despite the first option feeling a bit gnarly, I'm going to go for that as it
will fix the problem and not lead to broken markup.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 27 12:28:27 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Jan 2020 11:28:27 +0000
Subject: [Koha-bugs] [Bug 24518] Partner filtering does not work in IE11
In-Reply-To: <bug-24518-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24518-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24518-70-RUx0FGOrcX@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24518

Andrew Isherwood <andrew.isherwood at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|enhancement                 |normal
             Status|NEW                         |ASSIGNED
           Assignee|koha-bugs at lists.koha-commun |andrew.isherwood at ptfs-europ
                   |ity.org                     |e.com

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 27 12:43:44 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Jan 2020 11:43:44 +0000
Subject: [Koha-bugs] [Bug 24428] Elastic search index does not contain
 consistent item information
In-Reply-To: <bug-24428-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24428-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24428-70-BPEodVRjQA@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24428

--- Comment #6 from Ere Maijala <ere.maijala at helsinki.fi> ---
Workaround, or a solution depending on how you view this, is to set the
ElasticsearchMARCFormat pref to "Searchable array" and reindex everything. Then
the item information would be available in the 952 field.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 27 12:44:13 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Jan 2020 11:44:13 +0000
Subject: [Koha-bugs] [Bug 24428] Elasticsearch index does not contain
 consistent item information
In-Reply-To: <bug-24428-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24428-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24428-70-cJ2OSnkzAv@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24428

Ere Maijala <ere.maijala at helsinki.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Elastic search index does   |Elasticsearch index does
                   |not contain consistent item |not contain consistent item
                   |information                 |information

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 27 12:49:12 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Jan 2020 11:49:12 +0000
Subject: [Koha-bugs] [Bug 24486] Account Wording Information is duplicated
 in Patron's Fines Tab on OPAC
In-Reply-To: <bug-24486-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24486-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24486-70-ipFYTdvMwc@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24486

--- Comment #11 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 97973
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97973&action=edit
Bug 24486: Alternate

Test plan:
Create a manual invoice
Pay it
Void it

Go to the opac, account
=> You should see only one "(Voided)"

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 27 13:06:15 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Jan 2020 12:06:15 +0000
Subject: [Koha-bugs] [Bug 24518] Partner filtering does not work in IE11
In-Reply-To: <bug-24518-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24518-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24518-70-6DUg7wAwJ7@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24518

Andrew Isherwood <andrew.isherwood at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 27 13:06:18 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Jan 2020 12:06:18 +0000
Subject: [Koha-bugs] [Bug 24518] Partner filtering does not work in IE11
In-Reply-To: <bug-24518-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24518-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24518-70-gSUzC2WijA@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24518

--- Comment #1 from Andrew Isherwood <andrew.isherwood at ptfs-europe.com> ---
Created attachment 97974
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97974&action=edit
Bug 24518: Fix IE11 partner filtering

This patch adopts the approach detailed in comment #1.

It also fixes a couple of additional minor bugs relating to the ILL
partner list:
- Exclude partners with no email address, we cannot use them
- Quote the "value" attribute to avoid warnings displayed by IE, they
should be quoted anyway!

Test plan: USE IE11
- Apply the patch
- Define 3 ILL partner patrons (patrons in the category that has a code
that matches the <partner_code> value in the ILL config). One patron
should have no email address, the other two should have an email address
- Navigate to "Place request with partners" for an ILL request
- TEST: Observe that the patron with no email address is not displayed
- Try filtering the list
- TEST: Observe that the list filters correctly

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 27 13:17:03 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Jan 2020 12:17:03 +0000
Subject: [Koha-bugs] [Bug 24502] Add a query language and param (q=) to the
 API
In-Reply-To: <bug-24502-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24502-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24502-70-RfoJts5CFE@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24502

--- Comment #2 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
How about taking ES and an example for DSL and Querying structures..

They allow for a simple syntax in the query string, but if you want to 'level
up' your queries then they use JSON in a request body.. 

I like this work so far, but I'm not a big fan of escaped JSON directly in the
query string, it feels a bit messy and feels like it could end up leading to
escaping problems down the line.  Moving the JSON based query DSL into a GET
request body seems like a good move to me.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 27 13:17:21 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Jan 2020 12:17:21 +0000
Subject: [Koha-bugs] [Bug 24502] Add a query language and param (q=) to the
 API
In-Reply-To: <bug-24502-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24502-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24502-70-Em0KWnUj27@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24502

--- Comment #3 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
https://www.elastic.co/guide/en/elasticsearch/reference/current/search-search.html
for inspiration.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 27 13:21:28 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Jan 2020 12:21:28 +0000
Subject: [Koha-bugs] [Bug 24502] Add a query language and param (q=) to the
 API
In-Reply-To: <bug-24502-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24502-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24502-70-JnkliUufuO@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24502

--- Comment #4 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Tomas also asked me to mention how I did similar when coding another project..
just for possible inspiration...


I used 'Search::Query::Dialect' and adopted the DBIx::Class dialect with some
customised additions to get it working.. it leads to a reasonably nice
functional query string syntax for mostly simple queries.. I don't remember
getting as far as doing full-on JSON based body queries though.. so I'm not
sure how helpful it would be here?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 27 13:29:14 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Jan 2020 12:29:14 +0000
Subject: [Koha-bugs] [Bug 23681] Patron restrictions should be user definable
In-Reply-To: <bug-23681-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23681-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23681-70-q9VI7tJyis@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681

--- Comment #59 from Andrew Isherwood <andrew.isherwood at ptfs-europe.com> ---
The default (In reply to Jonathan Druart from comment #58)
> > t
> > I believe so. Restrictions need a type, even if one is not explicitly
> > chosen. Also, we need an ability to say "if a restriction type is deleted,
> > any restrictions that use this type should fall back to type X", the default
> > flag indicates which type is X.
> 
> I do not remember I saw a way to modify it, it's hardcoded in DB (and so
> could be in the code).

You're absolutely right, the default must always be "MANUAL" due to the way the
restrictions were originally implemented, however the name can be changed so as
far as the user is concerned, it can be anything they wish.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 27 13:33:35 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Jan 2020 12:33:35 +0000
Subject: [Koha-bugs] [Bug 13985] Cash Management - Koha as 'Point of Sale'
In-Reply-To: <bug-13985-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13985-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13985-70-NAoclBgjaP@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13985

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |24491


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24491
[Bug 24491] Add filters to debit types interface
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 27 13:33:35 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Jan 2020 12:33:35 +0000
Subject: [Koha-bugs] [Bug 24491] Add filters to debit types interface
In-Reply-To: <bug-24491-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24491-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24491-70-EIzkvGKUZA@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24491

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |13985


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13985
[Bug 13985] Cash Management - Koha as 'Point of Sale'
-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 27 13:33:53 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Jan 2020 12:33:53 +0000
Subject: [Koha-bugs] [Bug 24477] No permissions check for POS feature
In-Reply-To: <bug-24477-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24477-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24477-70-MY7CDDHvgl@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24477

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |23355


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23355
[Bug 23355] Add 'cashup' process to the accounts system
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 27 13:33:53 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Jan 2020 12:33:53 +0000
Subject: [Koha-bugs] [Bug 23355] Add 'cashup' process to the accounts system
In-Reply-To: <bug-23355-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23355-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23355-70-SVUtXlzShw@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23355

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |24477


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24477
[Bug 24477] No permissions check for POS feature
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 27 13:34:08 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Jan 2020 12:34:08 +0000
Subject: [Koha-bugs] [Bug 24478] Make it possible to deactivate point of sale
In-Reply-To: <bug-24478-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24478-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24478-70-ZeF1uUjiXI@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24478

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |23355


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23355
[Bug 23355] Add 'cashup' process to the accounts system
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 27 13:34:08 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Jan 2020 12:34:08 +0000
Subject: [Koha-bugs] [Bug 23355] Add 'cashup' process to the accounts system
In-Reply-To: <bug-23355-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23355-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23355-70-UvJUyq2Mjr@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23355

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |24478


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24478
[Bug 24478] Make it possible to deactivate point of sale
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 27 13:34:29 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Jan 2020 12:34:29 +0000
Subject: [Koha-bugs] [Bug 24481] Incorrect permission in
 admin/cash_registers.pl
In-Reply-To: <bug-24481-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24481-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24481-70-cxy7wd5l5G@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24481

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |23355


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23355
[Bug 23355] Add 'cashup' process to the accounts system
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 27 13:34:29 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Jan 2020 12:34:29 +0000
Subject: [Koha-bugs] [Bug 23355] Add 'cashup' process to the accounts system
In-Reply-To: <bug-23355-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23355-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23355-70-BYiUGopAOg@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23355

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |24481


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24481
[Bug 24481] Incorrect permission in admin/cash_registers.pl
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 27 13:34:52 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Jan 2020 12:34:52 +0000
Subject: [Koha-bugs] [Bug 24482] Purchase Items broken by costs containing a
 comma
In-Reply-To: <bug-24482-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24482-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24482-70-UUSH4cRcLj@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24482

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |23355


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23355
[Bug 23355] Add 'cashup' process to the accounts system
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 27 13:34:52 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Jan 2020 12:34:52 +0000
Subject: [Koha-bugs] [Bug 23355] Add 'cashup' process to the accounts system
In-Reply-To: <bug-23355-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23355-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23355-70-6AzBprhQRU@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23355

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |24482


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24482
[Bug 24482] Purchase Items broken by costs containing a comma
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 27 13:35:14 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Jan 2020 12:35:14 +0000
Subject: [Koha-bugs] [Bug 23354] Add a 'Pay' screen to allow anonymous
 payments in a POS fashion
In-Reply-To: <bug-23354-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23354-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23354-70-lEnQYKqXyW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23354

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|23355                       |


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23355
[Bug 23355] Add 'cashup' process to the accounts system
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 27 13:35:14 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Jan 2020 12:35:14 +0000
Subject: [Koha-bugs] [Bug 23355] Add 'cashup' process to the accounts system
In-Reply-To: <bug-23355-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23355-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23355-70-EEpF7eogBK@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23355

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|23354                       |


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23354
[Bug 23354] Add a 'Pay' screen to allow anonymous payments in a POS fashion
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 27 13:42:03 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Jan 2020 12:42:03 +0000
Subject: [Koha-bugs] [Bug 5161] patron attributes clearing if duplicate
 warning
In-Reply-To: <bug-5161-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-5161-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-5161-70-bOzFmInENV@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5161

Sally <sally.healey at cheshiresharedservices.gov.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |sally.healey at cheshireshared
                   |                            |services.gov.uk

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 27 13:42:13 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Jan 2020 12:42:13 +0000
Subject: [Koha-bugs] [Bug 13121] Move search results "action" links ("Place
 hold, " "Add tag, " etc) into include file
In-Reply-To: <bug-13121-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13121-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13121-70-nS6qeJBZRr@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13121

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 27 13:50:55 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Jan 2020 12:50:55 +0000
Subject: [Koha-bugs] [Bug 23915] Replace OPAC list sort menu with Bootstrap
 menu button
In-Reply-To: <bug-23915-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23915-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23915-70-GjUGurutB8@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23915

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Patch doesn't apply         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 27 13:50:58 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Jan 2020 12:50:58 +0000
Subject: [Koha-bugs] [Bug 23915] Replace OPAC list sort menu with Bootstrap
 menu button
In-Reply-To: <bug-23915-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23915-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23915-70-R7U7S6ZyN1@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23915

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #94817|0                           |1
        is obsolete|                            |

--- Comment #4 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 97975
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97975&action=edit
Bug 23915: Replace OPAC list sort menu with Bootstrap menu button

This patch adds JavaScript to the list contents page which converts the
resort form's <select> menu into a Bootstrap dropdown menu. This allows
for a more compact and consistent display.

To test, apply the patch and regenerate the OPAC CSS
(https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client).

View a list in the OPAC. The toolbar of list controls ("New list,"
"Download list," etc.) should have a similary-styled "Sort" button. Each
sorting option should work correctly.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 27 14:56:18 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Jan 2020 13:56:18 +0000
Subject: [Koha-bugs] [Bug 23070] Use Koha::Hold in
 C4::Reserves::RevertWaitingStatus
In-Reply-To: <bug-23070-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23070-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23070-70-ERjl2fVEZQ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23070

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|In Discussion               |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 27 14:56:21 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Jan 2020 13:56:21 +0000
Subject: [Koha-bugs] [Bug 23070] Use Koha::Hold in
 C4::Reserves::RevertWaitingStatus
In-Reply-To: <bug-23070-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23070-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23070-70-6YIdplASJW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23070

--- Comment #7 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 97976
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97976&action=edit
Bug 23070: Add tests

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 27 14:56:25 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Jan 2020 13:56:25 +0000
Subject: [Koha-bugs] [Bug 23070] Use Koha::Hold in
 C4::Reserves::RevertWaitingStatus
In-Reply-To: <bug-23070-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23070-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23070-70-6BF0zCnuYq@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23070

--- Comment #8 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 97977
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97977&action=edit
Bug 23070: Increment all priorities in 1 query

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 27 15:06:59 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Jan 2020 14:06:59 +0000
Subject: [Koha-bugs] [Bug 22359] Improve usability of 'change calculation'
 (bug 11373)
In-Reply-To: <bug-22359-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22359-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22359-70-VKXTetT2Sn@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22359

--- Comment #37 from Andrew Fuerste-Henry <andrew at bywatersolutions.com> ---
I meant it was inconsistent in that sometimes it gave that big yellow box and
sometimes it just gave some red alert text within the payment form. I don't
have strong feeling about this, but it would be a little cleaner if it always
errored out in the same way. I've got no problem with pushing this as-is, maybe
changing it in another bug.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 27 15:10:27 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Jan 2020 14:10:27 +0000
Subject: [Koha-bugs] [Bug 24490] Clarify wording and function of Purchase
 Items link on POS
In-Reply-To: <bug-24490-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24490-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24490-70-r0iSSI82pG@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24490

--- Comment #9 from ByWater Sandboxes <bws.sandboxes at gmail.com> ---
Created attachment 97979
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97979&action=edit
Bug 24339: Do not assume there are exactly 3 SIP* AVs

Update DB entry 19.06.00.017:
We created SIP* AV from accountlines if '^Pay[[:digit:]]{2}$', so I
think we should assume that more than SIP00, SIP01, SIP02 can exist.

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

Signed-off-by: Andrew Fuerste-Henry <andrew at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 27 15:17:07 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Jan 2020 14:17:07 +0000
Subject: [Koha-bugs] [Bug 20936] Holds History for patrons in OPAC
In-Reply-To: <bug-20936-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20936-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20936-70-BGGLUDT0b8@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20936

Jason Robb <jrobb at sekls.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jrobb at sekls.org

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 27 15:18:06 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Jan 2020 14:18:06 +0000
Subject: [Koha-bugs] [Bug 24495] Reword change collection feature
In-Reply-To: <bug-24495-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24495-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24495-70-oejLFCiY1v@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24495

--- Comment #3 from Andrew Fuerste-Henry <andrew at bywatersolutions.com> ---
I have a really hard time guessing at what might work better here, because I
very much thought the existing wording was clear. But once we'd upgraded our
partner libraries we got a lot of questions about it. I *think* the issue is
more with "collect from patron" than with "amount paid." 

"Amount tendered" seems like a good option. I think that's fairly standard cash
register wording.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 27 15:19:46 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Jan 2020 14:19:46 +0000
Subject: [Koha-bugs] [Bug 24269] Authority matching in Elasticsearch is
 broken when authority has subdivisions
In-Reply-To: <bug-24269-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24269-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24269-70-hfO3vVlJD8@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24269

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 27 15:19:50 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Jan 2020 14:19:50 +0000
Subject: [Koha-bugs] [Bug 24269] Authority matching in Elasticsearch is
 broken when authority has subdivisions
In-Reply-To: <bug-24269-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24269-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24269-70-zy0dzIPOjd@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24269

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #97357|0                           |1
        is obsolete|                            |

--- Comment #2 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 97981
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97981&action=edit
Bug 24269: Adjust C4::Heading to generate headings from auth tags

To test:
1 - Be using Elasticsearch
2 - Check that field 150 is mapped to 'Match-heading' or add it (the subfields
don't matter)
3 - Add a topic term authority record like "150 $aCats$vFiction"
4 - Add a 650 with $aCats and $vFiction and  $e depicted to a bibliographic
record
5 - Run the linker for the bib
    perl misc/link_bibs_to_authorities.pl --bib-limit "biblionumber=89" -v
6 - Confirm the record is not correctly linked to the record
7 - Apply patch
8 - Reindex authorities for ES
    perl misc/search_tools/rebuild_elasticsearch.pl -v -d -a
9 - Run the linker and confirm record is correctly linked
    perl misc/link_bibs_to_authorities.pl --bib-limit "biblionumber=89" -v

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 27 15:22:20 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Jan 2020 14:22:20 +0000
Subject: [Koha-bugs] [Bug 24421] Generated authorities are missing subfields
In-Reply-To: <bug-24421-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24421-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24421-70-eXl64TAmNj@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24421

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |24269


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24269
[Bug 24269] Authority matching in Elasticsearch is broken when authority has
subdivisions
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 27 15:22:20 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Jan 2020 14:22:20 +0000
Subject: [Koha-bugs] [Bug 24269] Authority matching in Elasticsearch is
 broken when authority has subdivisions
In-Reply-To: <bug-24269-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24269-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24269-70-EDXAH7Zmdf@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24269

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |24421


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24421
[Bug 24421] Generated authorities are missing subfields
-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 27 15:22:23 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Jan 2020 14:22:23 +0000
Subject: [Koha-bugs] [Bug 24269] Authority matching in Elasticsearch is
 broken when authority has subdivisions
In-Reply-To: <bug-24269-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24269-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24269-70-tj9nE3apNS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24269

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #97981|0                           |1
        is obsolete|                            |

--- Comment #3 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 97982
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97982&action=edit
Bug 24269: Adjust C4::Heading to generate headings from auth tags

To test:
1 - Be using Elasticsearch
2 - Check that field 150 is mapped to 'Match-heading' or add it (the subfields
don't matter)
3 - Add a topic term authority record like "150 $aCats$vFiction"
4 - Add a 650 with $aCats and $vFiction and  $e depicted to a bibliographic
record
5 - Run the linker for the bib
    perl misc/link_bibs_to_authorities.pl --bib-limit "biblionumber=89" -v
6 - Confirm the record is not correctly linked to the record
7 - Apply patch
8 - Reindex authorities for ES
    perl misc/search_tools/rebuild_elasticsearch.pl -v -d -a
9 - Run the linker and confirm record is correctly linked
    perl misc/link_bibs_to_authorities.pl --bib-limit "biblionumber=89" -v

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 27 15:27:57 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Jan 2020 14:27:57 +0000
Subject: [Koha-bugs] [Bug 24490] Clarify wording and function of Purchase
 Items link on POS
In-Reply-To: <bug-24490-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24490-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24490-70-FhMjxXKsKZ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24490

Andrew Fuerste-Henry <andrew at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #97979|0                           |1
        is obsolete|                            |

--- Comment #10 from Andrew Fuerste-Henry <andrew at bywatersolutions.com> ---
Comment on attachment 97979
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97979
Bug 24339: Do not assume there are exactly 3 SIP* AVs

Sorry, didn't drink enough coffee before trying this.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 27 15:28:22 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Jan 2020 14:28:22 +0000
Subject: [Koha-bugs] [Bug 24490] Clarify wording and function of Purchase
 Items link on POS
In-Reply-To: <bug-24490-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24490-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24490-70-3k5uet5HNO@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24490

Andrew Fuerste-Henry <andrew at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Failed QA

--- Comment #11 from Andrew Fuerste-Henry <andrew at bywatersolutions.com> ---
Patch didn't apply.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 27 16:00:53 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Jan 2020 15:00:53 +0000
Subject: [Koha-bugs] [Bug 24475] Reword FinesMode system preference
In-Reply-To: <bug-24475-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24475-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24475-70-STReOF1oJ7@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24475

Andrew Fuerste-Henry <andrew at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Failed QA

--- Comment #7 from Andrew Fuerste-Henry <andrew at bywatersolutions.com> ---
Failing QA because the text added to CalculateFinesOnReturn has an extra
period. 
It says : 
NOTE: This system preference requires FinesMode to be set to 'Calculate and
charge.'.

Should be:
NOTE: This system preference requires FinesMode to be set to 'Calculate and
charge.'

Sorry, very trivial. Thanks for writing this!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 27 16:01:21 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Jan 2020 15:01:21 +0000
Subject: [Koha-bugs] [Bug 24490] Clarify wording and function of Purchase
 Items link on POS
In-Reply-To: <bug-24490-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24490-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24490-70-0UlcWjckmM@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24490

--- Comment #12 from David Roberts <david.roberts at ptfs-europe.com> ---
I'm confused - are these last three comments relevant to this bug, or have they
been attached to the wrong bug?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 27 16:01:40 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Jan 2020 15:01:40 +0000
Subject: [Koha-bugs] [Bug 22359] Improve usability of 'change calculation'
 (bug 11373)
In-Reply-To: <bug-22359-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22359-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22359-70-DUB2A2fLdo@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22359

--- Comment #38 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Aha, I see.. so at this point if you have javascript enabled you should only
ever see the client-side validation.. i.e. the red hints in the form itself. If
you have javascript disabled you should only ever see the yellow alert box..
i.e. the serverside validation will be triggered.  Hopefully, that makes sense

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 27 16:03:02 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Jan 2020 15:03:02 +0000
Subject: [Koha-bugs] [Bug 22359] Improve usability of 'change calculation'
 (bug 11373)
In-Reply-To: <bug-22359-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22359-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22359-70-jsKIKlqXoN@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22359

--- Comment #39 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Note to self.. opening a bug to add the same logic to the point of sale page.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 27 16:03:49 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Jan 2020 15:03:49 +0000
Subject: [Koha-bugs] [Bug 24482] Purchase Items broken by costs containing a
 comma
In-Reply-To: <bug-24482-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24482-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24482-70-eFFGJvSXWb@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24482

--- Comment #2 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 97983
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97983&action=edit
Bug 24482: Fix for formatted price issue with value over 1000

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 27 16:04:09 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Jan 2020 15:04:09 +0000
Subject: [Koha-bugs] [Bug 24482] Purchase Items broken by costs containing a
 comma
In-Reply-To: <bug-24482-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24482-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24482-70-PIrHBnBDP7@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24482

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 27 16:04:27 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Jan 2020 15:04:27 +0000
Subject: [Koha-bugs] [Bug 24482] Purchase Items broken by costs containing a
 comma
In-Reply-To: <bug-24482-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24482-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24482-70-6AsxHNEAdG@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24482

--- Comment #3 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Test plan, see first comment of bug. ;)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 27 16:13:11 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Jan 2020 15:13:11 +0000
Subject: [Koha-bugs] [Bug 24475] Reword FinesMode system preference
In-Reply-To: <bug-24475-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24475-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24475-70-4SGZOOMjVf@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24475

David Roberts <david.roberts at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #97954|0                           |1
        is obsolete|                            |

--- Comment #8 from David Roberts <david.roberts at ptfs-europe.com> ---
Created attachment 97984
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97984&action=edit
Bug 24475: Reword FinesMode system preference

This patch changes the wording of the FinesMode and CalculateFinesOnReturn
system preferences explanations

1) Install Patch
2) Check that the wording of the FinesMode system preference has changed to
"NOTE: If the misc/cronjobs/fines.pl cronjob is being run, accruing and final
fines will be calculated when the cron runs and accruing fines will be
finalized when an item is returned. If CalculateFinesOnReturn is enabled, final
fines will be calculated when an item is returned."
3) Check that the wording of the CalculateFinesOnReturn system preference has
changed to add "NOTE: This system preference requires FinesMode to be set to
'Calculate and charge.'" to the existing note.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 27 16:13:54 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Jan 2020 15:13:54 +0000
Subject: [Koha-bugs] [Bug 24475] Reword FinesMode system preference
In-Reply-To: <bug-24475-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24475-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24475-70-hFdDYvSr9O@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24475

David Roberts <david.roberts at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Needs Signoff

--- Comment #9 from David Roberts <david.roberts at ptfs-europe.com> ---
Typo removed, and new patch submitted

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 27 16:15:08 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Jan 2020 15:15:08 +0000
Subject: [Koha-bugs] [Bug 24519] New: Change calculation and validation in
 Point of Sale should match Paycollect
Message-ID: <bug-24519-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24519

            Bug ID: 24519
           Summary: Change calculation and validation in Point of Sale
                    should match Paycollect
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Fines and fees
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: martin.renvoize at ptfs-europe.com
        QA Contact: testopia at bugs.koha-community.org

Bug 22359 updates the paycollect form logic to clarify each input fields use
and adds validation to reduce the risk of errant data being entered.

The point of sale screen payment form should match these changes.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 27 16:15:24 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Jan 2020 15:15:24 +0000
Subject: [Koha-bugs] [Bug 24519] Change calculation and validation in Point
 of Sale should match Paycollect
In-Reply-To: <bug-24519-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24519-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24519-70-1crA6fNJdx@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24519

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |22359


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22359
[Bug 22359] Improve usability of 'change calculation' (bug 11373)
-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 27 16:15:24 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Jan 2020 15:15:24 +0000
Subject: [Koha-bugs] [Bug 22359] Improve usability of 'change calculation'
 (bug 11373)
In-Reply-To: <bug-22359-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22359-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22359-70-nJjJD6XOP5@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22359

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |24519


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24519
[Bug 24519] Change calculation and validation in Point of Sale should match
Paycollect
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 27 16:15:42 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Jan 2020 15:15:42 +0000
Subject: [Koha-bugs] [Bug 24482] Purchase Items broken by costs containing a
 comma
In-Reply-To: <bug-24482-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24482-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24482-70-ZSWiiUoE1I@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24482

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |24519


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24519
[Bug 24519] Change calculation and validation in Point of Sale should match
Paycollect
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 27 16:15:42 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Jan 2020 15:15:42 +0000
Subject: [Koha-bugs] [Bug 24519] Change calculation and validation in Point
 of Sale should match Paycollect
In-Reply-To: <bug-24519-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24519-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24519-70-VWqGuvzK1A@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24519

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |24482


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24482
[Bug 24482] Purchase Items broken by costs containing a comma
-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 27 16:17:33 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Jan 2020 15:17:33 +0000
Subject: [Koha-bugs] [Bug 24519] Change calculation and validation in Point
 of Sale should match Paycollect
In-Reply-To: <bug-24519-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24519-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24519-70-LqJBSlNyXn@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24519

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |martin.renvoize at ptfs-europe
                   |ity.org                     |.com

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 27 16:20:12 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Jan 2020 15:20:12 +0000
Subject: [Koha-bugs] [Bug 24488] Holds to Pull sometimes shows the wrong
 'first patron' details
In-Reply-To: <bug-24488-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24488-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24488-70-eJxtdTzz9S@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24488

--- Comment #4 from Kelly McElligott <kelly at bywatersolutions.com> ---
Hi Aleisha,
I have done what you have recommended.  I am now getting an error when I try to
go to the Holds to Pull report 

DBIx::Class::Storage::DBI::_dbh_execute(): 'koha_hold.reserve.reserve_id' isn't
in GROUP BY at /kohadevbox/koha/Koha/Objects.pm line 130
 at /usr/share/perl5/DBIx/Class/Exception.pm line 77

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 27 16:21:28 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Jan 2020 15:21:28 +0000
Subject: [Koha-bugs] [Bug 24490] Clarify wording and function of Purchase
 Items link on POS
In-Reply-To: <bug-24490-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24490-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24490-70-B6lYvnu5XE@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24490

--- Comment #13 from Andrew Fuerste-Henry <andrew at bywatersolutions.com> ---
Sorry, that's my fault! The new patch for this bug didn't apply, but I was very
slow to realize it. I went to the POS screen, saw that the links were showing
the correct capitalization, but didn't realize that was because they were
reverting to the original wording. So then I tried to sign off. Because the
actual patch hadn't applied, the sandbox just grabbed the most recent patch on
there (which was from another bug) and signed it off here.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 27 16:23:27 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Jan 2020 15:23:27 +0000
Subject: [Koha-bugs] [Bug 23355] Add 'cashup' process to the accounts system
In-Reply-To: <bug-23355-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23355-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23355-70-0zsLeLfY6y@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23355

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Text to go in the|                            |This new feature
      release notes|                            |complements the new 'Point
                   |                            |of sale' page introduced in
                   |                            |bug 23354 by adding a page
                   |                            |to display historic
                   |                            |transactions that have
                   |                            |taken place on the selected
                   |                            |cash register since the
                   |                            |last 'cashup' event.  One
                   |                            |can record a 'cashup' from
                   |                            |this page by comparing the
                   |                            |summary values displayed on
                   |                            |the page to the actual
                   |                            |amounts found in the cash
                   |                            |register and then clicking
                   |                            |the 'cashup' button to
                   |                            |record that this process
                   |                            |has taken place.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 27 16:23:42 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Jan 2020 15:23:42 +0000
Subject: [Koha-bugs] [Bug 23355] Add 'cashup' process to the accounts system
In-Reply-To: <bug-23355-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23355-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23355-70-M007gadkDE@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23355

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |andrew at bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 27 16:24:44 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Jan 2020 15:24:44 +0000
Subject: [Koha-bugs] [Bug 24490] Clarify wording and function of Purchase
 Items link on POS
In-Reply-To: <bug-24490-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24490-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24490-70-ab3ewgSFN8@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24490

--- Comment #14 from David Roberts <david.roberts at ptfs-europe.com> ---
OK thanks - no idea why the patch wouldn't apply. I'll rebase and try again.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 27 16:25:57 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Jan 2020 15:25:57 +0000
Subject: [Koha-bugs] [Bug 18501] Automatic refunds need protection from
 failure
In-Reply-To: <bug-18501-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18501-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18501-70-SMqOnAlPRP@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18501

--- Comment #2 from Christopher Brannon <cbrannon at cdalibrary.org> ---
(In reply to Jonathan Druart from comment #1)
> Can you confirm we are talking about RefundLostOnReturnControl here?

I believe so.  Honestly, this was 2.5 years ago.  I don't remember much about
this, but that sounds right.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 27 16:28:57 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Jan 2020 15:28:57 +0000
Subject: [Koha-bugs] [Bug 24520] New: Share via Twitter option on OPAC is
 out of line with rest of Share options
Message-ID: <bug-24520-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24520

            Bug ID: 24520
           Summary: Share via Twitter option on OPAC is out of line with
                    rest of Share options
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: OPAC
          Assignee: lucas at bywatersolutions.com
          Reporter: kelly at bywatersolutions.com
        QA Contact: testopia at bugs.koha-community.org

It would appear as most Share options, email, facebook, linkedin are Font
Awesome - however, the Tweet option is not.  Therefore when the Tweet Options
appears next to the other share options, it is out of line with them.

It would be nice to make the Tweet option also Font Awesome to keep them
consistent and look nice.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 27 16:36:04 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Jan 2020 15:36:04 +0000
Subject: [Koha-bugs] [Bug 13125] Total Holds does not tally holds /
 items.reserves is not populated
In-Reply-To: <bug-13125-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13125-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13125-70-z5EiabcGp4@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13125

Christopher Brannon <cbrannon at cdalibrary.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |cbrannon at cdalibrary.org

--- Comment #5 from Christopher Brannon <cbrannon at cdalibrary.org> ---
I would like to see this implemented.  Doesn't make sense to keep running
totals of checkouts and renewals and not reserves.

I guess we need to start with, what counts?

Personally, I want to know every hold, whether cancelled or filled.  Some might
want only filled, and others might say only those that have been picked up.  I
say all combinations should be a preference, but all should be an option for
the tally.

Logistically, it would be easiest to add to the tally at the time of creation
for all holds placed.  But for only filled holds or picked up holds to be
tallied, that would probably need to be added at the time of fulfillment, or at
time of pickup, and not at the time of creation.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 27 16:43:36 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Jan 2020 15:43:36 +0000
Subject: [Koha-bugs] [Bug 24490] Clarify wording and function of Purchase
 Items link on POS
In-Reply-To: <bug-24490-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24490-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24490-70-CQO3DKYOf9@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24490

David Roberts <david.roberts at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #97930|0                           |1
        is obsolete|                            |

--- Comment #15 from David Roberts <david.roberts at ptfs-europe.com> ---
Created attachment 97985
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97985&action=edit
Bug 24490: Clarify wording and function of Purchase Items link on POS

This patch changes the wording of the links on the POS side menu

To test:

1) Apply the patch
2) Check that the links on the left hand side of the screen read "Configure
cash registers" and "Configure items for purchase"
3) Click both links to ensure you are taken to the relevant config pages.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 27 16:44:16 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Jan 2020 15:44:16 +0000
Subject: [Koha-bugs] [Bug 24490] Clarify wording and function of Purchase
 Items link on POS
In-Reply-To: <bug-24490-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24490-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24490-70-Ix6rGcdTT5@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24490

David Roberts <david.roberts at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Needs Signoff

--- Comment #16 from David Roberts <david.roberts at ptfs-europe.com> ---
Hopefully that is now OK - no idea what went wrong with the last one - the
branch I worked on was in a total pickle.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 27 16:45:53 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Jan 2020 15:45:53 +0000
Subject: [Koha-bugs] [Bug 24520] Share via Twitter option on OPAC is out of
 line with rest of Share options
In-Reply-To: <bug-24520-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24520-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24520-70-JfOgwNGIv7@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24520

--- Comment #1 from Owen Leonard <oleonard at myacpl.org> ---
The tweet link is a Font Awesome icon, but there is also some JavaScript which
loads Twitter's version of the button in its place. I must have it blocked in
my browser because I didn't see it until I switched to another one.

The solution is to remove the Twitter-specific JS:

Line 1410:

[% IF ( SocialNetworks ) %]
    <script>!function(d,s,id){var
js,fjs=d.getElementsByTagName(s)[0];if(!d.getElementById(id)){js=d.createElement(s);js.id=id;js.src="//platform.twitter.com/widgets.js";fjs.parentNode.insertBefore(js,fjs);}}(document,"script","twitter-wjs");</script>
[% END %]

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 27 16:48:37 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Jan 2020 15:48:37 +0000
Subject: [Koha-bugs] [Bug 23463] Move C4::Items CRUD subroutines to
 Koha::Item
In-Reply-To: <bug-23463-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23463-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23463-70-3BpAUms0OH@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23463

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 27 16:48:39 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Jan 2020 15:48:39 +0000
Subject: [Koha-bugs] [Bug 23463] Move C4::Items CRUD subroutines to
 Koha::Item
In-Reply-To: <bug-23463-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23463-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23463-70-i9gBovpSVK@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23463

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #97920|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 27 16:48:42 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Jan 2020 15:48:42 +0000
Subject: [Koha-bugs] [Bug 23463] Move C4::Items CRUD subroutines to
 Koha::Item
In-Reply-To: <bug-23463-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23463-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23463-70-NjZG7oxfCs@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23463

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #97921|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 27 16:48:44 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Jan 2020 15:48:44 +0000
Subject: [Koha-bugs] [Bug 23463] Move C4::Items CRUD subroutines to
 Koha::Item
In-Reply-To: <bug-23463-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23463-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23463-70-pcBh1nDLRI@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23463

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #97895|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 27 16:48:47 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Jan 2020 15:48:47 +0000
Subject: [Koha-bugs] [Bug 23463] Move C4::Items CRUD subroutines to
 Koha::Item
In-Reply-To: <bug-23463-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23463-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23463-70-kal5CUnr6X@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23463

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #97896|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 27 16:48:49 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Jan 2020 15:48:49 +0000
Subject: [Koha-bugs] [Bug 23463] Move C4::Items CRUD subroutines to
 Koha::Item
In-Reply-To: <bug-23463-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23463-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23463-70-HD9hEyUp2f@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23463

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #97897|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 27 16:48:52 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Jan 2020 15:48:52 +0000
Subject: [Koha-bugs] [Bug 23463] Move C4::Items CRUD subroutines to
 Koha::Item
In-Reply-To: <bug-23463-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23463-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23463-70-NWcVYpLnJv@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23463

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #97898|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 27 16:48:54 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Jan 2020 15:48:54 +0000
Subject: [Koha-bugs] [Bug 23463] Move C4::Items CRUD subroutines to
 Koha::Item
In-Reply-To: <bug-23463-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23463-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23463-70-wkZtD3AjJF@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23463

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #97899|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 27 16:48:57 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Jan 2020 15:48:57 +0000
Subject: [Koha-bugs] [Bug 23463] Move C4::Items CRUD subroutines to
 Koha::Item
In-Reply-To: <bug-23463-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23463-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23463-70-mD1BeUUSDU@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23463

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #97900|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 27 16:48:59 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Jan 2020 15:48:59 +0000
Subject: [Koha-bugs] [Bug 23463] Move C4::Items CRUD subroutines to
 Koha::Item
In-Reply-To: <bug-23463-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23463-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23463-70-9M2SQ0NhNC@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23463

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #97901|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 27 16:49:02 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Jan 2020 15:49:02 +0000
Subject: [Koha-bugs] [Bug 23463] Move C4::Items CRUD subroutines to
 Koha::Item
In-Reply-To: <bug-23463-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23463-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23463-70-gkNqivYpeE@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23463

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #97902|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 27 16:49:04 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Jan 2020 15:49:04 +0000
Subject: [Koha-bugs] [Bug 23463] Move C4::Items CRUD subroutines to
 Koha::Item
In-Reply-To: <bug-23463-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23463-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23463-70-jGZKbxqrqQ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23463

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #97903|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 27 16:49:06 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Jan 2020 15:49:06 +0000
Subject: [Koha-bugs] [Bug 23463] Move C4::Items CRUD subroutines to
 Koha::Item
In-Reply-To: <bug-23463-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23463-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23463-70-5pgDryCwmh@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23463

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #97904|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 27 16:49:09 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Jan 2020 15:49:09 +0000
Subject: [Koha-bugs] [Bug 23463] Move C4::Items CRUD subroutines to
 Koha::Item
In-Reply-To: <bug-23463-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23463-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23463-70-e10aJN7k6w@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23463

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #97905|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 27 16:49:11 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Jan 2020 15:49:11 +0000
Subject: [Koha-bugs] [Bug 23463] Move C4::Items CRUD subroutines to
 Koha::Item
In-Reply-To: <bug-23463-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23463-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23463-70-6gZJdgNGfj@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23463

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #97906|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 27 16:49:13 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Jan 2020 15:49:13 +0000
Subject: [Koha-bugs] [Bug 23463] Move C4::Items CRUD subroutines to
 Koha::Item
In-Reply-To: <bug-23463-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23463-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23463-70-6zzxx3jheQ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23463

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #97907|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 27 16:49:15 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Jan 2020 15:49:15 +0000
Subject: [Koha-bugs] [Bug 23463] Move C4::Items CRUD subroutines to
 Koha::Item
In-Reply-To: <bug-23463-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23463-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23463-70-TH7Q8wHTLh@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23463

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #97908|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 27 16:49:18 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Jan 2020 15:49:18 +0000
Subject: [Koha-bugs] [Bug 23463] Move C4::Items CRUD subroutines to
 Koha::Item
In-Reply-To: <bug-23463-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23463-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23463-70-fWvNhumMfF@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23463

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #97909|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 27 16:49:20 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Jan 2020 15:49:20 +0000
Subject: [Koha-bugs] [Bug 23463] Move C4::Items CRUD subroutines to
 Koha::Item
In-Reply-To: <bug-23463-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23463-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23463-70-N6OW0v2Q8F@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23463

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #97910|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 27 16:49:22 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Jan 2020 15:49:22 +0000
Subject: [Koha-bugs] [Bug 23463] Move C4::Items CRUD subroutines to
 Koha::Item
In-Reply-To: <bug-23463-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23463-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23463-70-wd69EH4QHD@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23463

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #97911|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 27 16:49:25 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Jan 2020 15:49:25 +0000
Subject: [Koha-bugs] [Bug 23463] Move C4::Items CRUD subroutines to
 Koha::Item
In-Reply-To: <bug-23463-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23463-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23463-70-vBvRKda9wp@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23463

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #97912|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 27 16:49:27 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Jan 2020 15:49:27 +0000
Subject: [Koha-bugs] [Bug 23463] Move C4::Items CRUD subroutines to
 Koha::Item
In-Reply-To: <bug-23463-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23463-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23463-70-emiOf0hdam@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23463

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #97913|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 27 16:49:29 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Jan 2020 15:49:29 +0000
Subject: [Koha-bugs] [Bug 23463] Move C4::Items CRUD subroutines to
 Koha::Item
In-Reply-To: <bug-23463-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23463-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23463-70-RcYdWER9nk@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23463

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #97914|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 27 16:49:32 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Jan 2020 15:49:32 +0000
Subject: [Koha-bugs] [Bug 23463] Move C4::Items CRUD subroutines to
 Koha::Item
In-Reply-To: <bug-23463-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23463-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23463-70-kKt21hfLcy@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23463

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #97915|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 27 16:49:34 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Jan 2020 15:49:34 +0000
Subject: [Koha-bugs] [Bug 23463] Move C4::Items CRUD subroutines to
 Koha::Item
In-Reply-To: <bug-23463-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23463-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23463-70-JnULS7MSyG@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23463

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #97916|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 27 16:49:36 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Jan 2020 15:49:36 +0000
Subject: [Koha-bugs] [Bug 23463] Move C4::Items CRUD subroutines to
 Koha::Item
In-Reply-To: <bug-23463-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23463-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23463-70-OHmzC6XTSj@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23463

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #97917|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 27 16:49:39 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Jan 2020 15:49:39 +0000
Subject: [Koha-bugs] [Bug 23463] Move C4::Items CRUD subroutines to
 Koha::Item
In-Reply-To: <bug-23463-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23463-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23463-70-6lca1YuB1b@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23463

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #97918|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 27 16:49:41 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Jan 2020 15:49:41 +0000
Subject: [Koha-bugs] [Bug 23463] Move C4::Items CRUD subroutines to
 Koha::Item
In-Reply-To: <bug-23463-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23463-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23463-70-H7rDNUE9xx@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23463

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #97919|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 27 16:50:12 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Jan 2020 15:50:12 +0000
Subject: [Koha-bugs] [Bug 23463] Move C4::Items CRUD subroutines to
 Koha::Item
In-Reply-To: <bug-23463-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23463-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23463-70-o2vrZyQk2j@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23463

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                URL|                            |https://gitlab.com/joubu/Ko
                   |                            |ha/commits/bug_23463

--- Comment #63 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Patches rebased and remote branch updated.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 27 16:59:46 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Jan 2020 15:59:46 +0000
Subject: [Koha-bugs] [Bug 24486] Account Wording Information is duplicated
 in Patron's Fines Tab on OPAC
In-Reply-To: <bug-24486-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24486-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24486-70-0unocp1nbY@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24486

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #97971|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 27 17:00:07 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Jan 2020 16:00:07 +0000
Subject: [Koha-bugs] [Bug 24421] Generated authorities are missing subfields
In-Reply-To: <bug-24421-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24421-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24421-70-rO1fI4Qxiy@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24421

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to master
         Version(s)|                            |20.05.00
        released in|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 27 17:00:09 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Jan 2020 16:00:09 +0000
Subject: [Koha-bugs] [Bug 24421] Generated authorities are missing subfields
In-Reply-To: <bug-24421-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24421-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24421-70-wv3DdkkKec@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24421

--- Comment #11 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Nice work everyone!

Pushed to master for 20.05

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 27 17:00:10 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Jan 2020 16:00:10 +0000
Subject: [Koha-bugs] [Bug 24486] Account Wording Information is duplicated
 in Patron's Fines Tab on OPAC
In-Reply-To: <bug-24486-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24486-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24486-70-FDRHuK7KZ5@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24486

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|                            |20.05.00
        released in|                            |
             Status|Passed QA                   |Pushed to master

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 27 17:00:12 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Jan 2020 16:00:12 +0000
Subject: [Koha-bugs] [Bug 24486] Account Wording Information is duplicated
 in Patron's Fines Tab on OPAC
In-Reply-To: <bug-24486-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24486-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24486-70-oyoOWKOId2@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24486

--- Comment #12 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Nice work everyone!

Pushed to master for 20.05

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 27 17:15:37 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Jan 2020 16:15:37 +0000
Subject: [Koha-bugs] [Bug 23128] Missing Net::OAuth2::AuthorizationServer
 dependency
In-Reply-To: <bug-23128-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23128-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23128-70-B5QVHFBFdF@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23128

--- Comment #8 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Wiki pages updated, an announcement to follow once we have D10 support
varified.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 27 17:32:36 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Jan 2020 16:32:36 +0000
Subject: [Koha-bugs] [Bug 20271] Merge deleted biblio, biblioitems,
 biblio_metadata, and items tables with their "alive" cousins
In-Reply-To: <bug-20271-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20271-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20271-70-TXGnlXCilF@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |ASSIGNED
         Depends on|                            |23463
           Assignee|oha at oha.it                  |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org

--- Comment #192 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
I am working on a rebased version of these patches, on top of bug 23463.


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23463
[Bug 23463] Move C4::Items CRUD subroutines to Koha::Item
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 27 17:32:36 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Jan 2020 16:32:36 +0000
Subject: [Koha-bugs] [Bug 23463] Move C4::Items CRUD subroutines to
 Koha::Item
In-Reply-To: <bug-23463-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23463-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23463-70-bxcUgF0gY1@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23463

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |20271


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271
[Bug 20271] Merge deleted biblio, biblioitems, biblio_metadata, and items
tables with their "alive" cousins
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 27 17:32:57 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Jan 2020 16:32:57 +0000
Subject: [Koha-bugs] [Bug 20271] Merge deleted biblio, biblioitems,
 biblio_metadata, and items tables
In-Reply-To: <bug-20271-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20271-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20271-70-wjQwFJreaV@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Merge deleted biblio,       |Merge deleted biblio,
                   |biblioitems,                |biblioitems,
                   |biblio_metadata, and items  |biblio_metadata, and items
                   |tables with their "alive"   |tables
                   |cousins                     |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 27 17:44:15 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Jan 2020 16:44:15 +0000
Subject: [Koha-bugs] [Bug 24361] Fix warnings (or failing tests) from bug
 24217
In-Reply-To: <bug-24361-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24361-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24361-70-dbLNkIZN12@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24361

--- Comment #10 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 97991
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97991&action=edit
Bug 24361: Silent t/db_dependent/Items.t

its output is displaying tons of
Use of uninitialized value $field in regexp compilation at
/kohadevbox/koha/C4/Items.pm line 2106.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 27 17:49:38 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Jan 2020 16:49:38 +0000
Subject: [Koha-bugs] [Bug 24490] Clarify wording and function of Purchase
 Items link on POS
In-Reply-To: <bug-24490-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24490-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24490-70-9XqIc9Mh2z@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24490

ByWater Sandboxes <bws.sandboxes at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #97985|0                           |1
        is obsolete|                            |

--- Comment #17 from ByWater Sandboxes <bws.sandboxes at gmail.com> ---
Created attachment 97992
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97992&action=edit
Bug 24490: Clarify wording and function of Purchase Items link on POS

This patch changes the wording of the links on the POS side menu

To test:

1) Apply the patch
2) Check that the links on the left hand side of the screen read "Configure
cash registers" and "Configure items for purchase"
3) Click both links to ensure you are taken to the relevant config pages.

Signed-off-by: Andrew Fuerste-Henry <andrew at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 27 17:50:09 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Jan 2020 16:50:09 +0000
Subject: [Koha-bugs] [Bug 24490] Clarify wording and function of Purchase
 Items link on POS
In-Reply-To: <bug-24490-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24490-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24490-70-3myXpb0mUE@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24490

Andrew Fuerste-Henry <andrew at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

--- Comment #18 from Andrew Fuerste-Henry <andrew at bywatersolutions.com> ---
Ok, actually signing off this time. Thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 27 18:23:33 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Jan 2020 17:23:33 +0000
Subject: [Koha-bugs] [Bug 20271] Merge deleted biblio, biblioitems,
 biblio_metadata, and items tables
In-Reply-To: <bug-20271-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20271-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20271-70-fyOGezOWdY@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271

--- Comment #193 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Note for myself:

* comment 182

* comment 183

* comment 184

* deal with reports

* my $item_object = Koha::Items->find({barcode => $barcode });
=> We need to remove the barcode unique index

* Prevent regression and deal with Koha::Items->find Koha::Items->search
Ideas:
  - ->find returns only non-deleted items when ->find_deleted returns only
deleted items
  - same for ->search, ->search_deleted

Or keep Koha::Old::Items that could inherit from Koha::Items

Or update all the occurrences (how many?)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 27 18:26:00 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Jan 2020 17:26:00 +0000
Subject: [Koha-bugs] [Bug 20271] Merge deleted biblio, biblioitems,
 biblio_metadata, and items tables
In-Reply-To: <bug-20271-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20271-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20271-70-Lmzi8OF8SM@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                URL|                            |https://gitlab.com/joubu/Ko
                   |                            |ha/commits/bug_20271

--- Comment #194 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Up-to-date patches are on https://gitlab.com/joubu/Koha/commits/bug_20271

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 27 18:26:22 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Jan 2020 17:26:22 +0000
Subject: [Koha-bugs] [Bug 20271] Merge deleted biblio, biblioitems,
 biblio_metadata, and items tables
In-Reply-To: <bug-20271-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20271-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20271-70-YSIU3vBPAG@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #76493|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 27 18:26:26 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Jan 2020 17:26:26 +0000
Subject: [Koha-bugs] [Bug 20271] Merge deleted biblio, biblioitems,
 biblio_metadata, and items tables
In-Reply-To: <bug-20271-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20271-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20271-70-afAZNKYUn7@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #76494|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 27 18:26:30 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Jan 2020 17:26:30 +0000
Subject: [Koha-bugs] [Bug 20271] Merge deleted biblio, biblioitems,
 biblio_metadata, and items tables
In-Reply-To: <bug-20271-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20271-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20271-70-DOC1qyxyVX@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #76495|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 27 18:26:34 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Jan 2020 17:26:34 +0000
Subject: [Koha-bugs] [Bug 20271] Merge deleted biblio, biblioitems,
 biblio_metadata, and items tables
In-Reply-To: <bug-20271-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20271-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20271-70-Oi7AmcM1v3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #76496|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 27 18:26:38 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Jan 2020 17:26:38 +0000
Subject: [Koha-bugs] [Bug 20271] Merge deleted biblio, biblioitems,
 biblio_metadata, and items tables
In-Reply-To: <bug-20271-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20271-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20271-70-CDorfDQclU@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #76497|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 27 18:26:42 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Jan 2020 17:26:42 +0000
Subject: [Koha-bugs] [Bug 20271] Merge deleted biblio, biblioitems,
 biblio_metadata, and items tables
In-Reply-To: <bug-20271-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20271-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20271-70-NAl4cMV8kz@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #76498|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 27 18:26:46 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Jan 2020 17:26:46 +0000
Subject: [Koha-bugs] [Bug 20271] Merge deleted biblio, biblioitems,
 biblio_metadata, and items tables
In-Reply-To: <bug-20271-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20271-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20271-70-p1JR2dzL4Y@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #76499|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 27 18:26:50 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Jan 2020 17:26:50 +0000
Subject: [Koha-bugs] [Bug 20271] Merge deleted biblio, biblioitems,
 biblio_metadata, and items tables
In-Reply-To: <bug-20271-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20271-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20271-70-0rQIVrEgbR@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #76500|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 27 18:26:54 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Jan 2020 17:26:54 +0000
Subject: [Koha-bugs] [Bug 20271] Merge deleted biblio, biblioitems,
 biblio_metadata, and items tables
In-Reply-To: <bug-20271-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20271-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20271-70-pxkY5JrJUe@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #76501|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 27 18:26:58 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Jan 2020 17:26:58 +0000
Subject: [Koha-bugs] [Bug 20271] Merge deleted biblio, biblioitems,
 biblio_metadata, and items tables
In-Reply-To: <bug-20271-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20271-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20271-70-pioz4Mb1Ui@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #76502|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 27 18:27:02 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Jan 2020 17:27:02 +0000
Subject: [Koha-bugs] [Bug 20271] Merge deleted biblio, biblioitems,
 biblio_metadata, and items tables
In-Reply-To: <bug-20271-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20271-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20271-70-OaFUt7uDLI@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #76503|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 27 18:27:06 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Jan 2020 17:27:06 +0000
Subject: [Koha-bugs] [Bug 20271] Merge deleted biblio, biblioitems,
 biblio_metadata, and items tables
In-Reply-To: <bug-20271-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20271-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20271-70-NarpxTnIgQ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #76504|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 27 18:27:10 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Jan 2020 17:27:10 +0000
Subject: [Koha-bugs] [Bug 20271] Merge deleted biblio, biblioitems,
 biblio_metadata, and items tables
In-Reply-To: <bug-20271-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20271-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20271-70-NfM1M6Q1Zl@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #76505|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 27 18:27:14 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Jan 2020 17:27:14 +0000
Subject: [Koha-bugs] [Bug 20271] Merge deleted biblio, biblioitems,
 biblio_metadata, and items tables
In-Reply-To: <bug-20271-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20271-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20271-70-lkQOeK5mJB@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #76506|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 27 18:27:18 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Jan 2020 17:27:18 +0000
Subject: [Koha-bugs] [Bug 20271] Merge deleted biblio, biblioitems,
 biblio_metadata, and items tables
In-Reply-To: <bug-20271-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20271-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20271-70-hcNz3KypcM@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #76507|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 27 18:27:22 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Jan 2020 17:27:22 +0000
Subject: [Koha-bugs] [Bug 20271] Merge deleted biblio, biblioitems,
 biblio_metadata, and items tables
In-Reply-To: <bug-20271-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20271-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20271-70-hR96McR6wT@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #76508|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 27 18:27:26 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Jan 2020 17:27:26 +0000
Subject: [Koha-bugs] [Bug 20271] Merge deleted biblio, biblioitems,
 biblio_metadata, and items tables
In-Reply-To: <bug-20271-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20271-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20271-70-xSKHjWnwBl@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #76509|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 27 18:27:29 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Jan 2020 17:27:29 +0000
Subject: [Koha-bugs] [Bug 20271] Merge deleted biblio, biblioitems,
 biblio_metadata, and items tables
In-Reply-To: <bug-20271-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20271-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20271-70-MMn9axS3TF@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #76510|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 27 18:27:33 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Jan 2020 17:27:33 +0000
Subject: [Koha-bugs] [Bug 20271] Merge deleted biblio, biblioitems,
 biblio_metadata, and items tables
In-Reply-To: <bug-20271-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20271-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20271-70-hngLnzkzuN@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #76511|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 27 18:27:37 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Jan 2020 17:27:37 +0000
Subject: [Koha-bugs] [Bug 20271] Merge deleted biblio, biblioitems,
 biblio_metadata, and items tables
In-Reply-To: <bug-20271-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20271-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20271-70-U6TQTKJWHU@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #76512|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 27 18:27:41 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Jan 2020 17:27:41 +0000
Subject: [Koha-bugs] [Bug 20271] Merge deleted biblio, biblioitems,
 biblio_metadata, and items tables
In-Reply-To: <bug-20271-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20271-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20271-70-vaKYdhG67A@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #76513|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 27 18:27:45 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Jan 2020 17:27:45 +0000
Subject: [Koha-bugs] [Bug 20271] Merge deleted biblio, biblioitems,
 biblio_metadata, and items tables
In-Reply-To: <bug-20271-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20271-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20271-70-KEEhoC7gga@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #76514|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 27 19:14:22 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Jan 2020 18:14:22 +0000
Subject: [Koha-bugs] [Bug 20271] Merge deleted biblio, biblioitems,
 biblio_metadata, and items tables
In-Reply-To: <bug-20271-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20271-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20271-70-AWfnAm9j4m@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271

--- Comment #195 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
(In reply to Jonathan Druart from comment #193)
> Note for myself:
> 
> * comment 182
> 
> * comment 183
> 
> * comment 184
> 
> * deal with reports

This should be done using DB views. What is the 'deleted' column name we
picked?

> * my $item_object = Koha::Items->find({barcode => $barcode });
> => We need to remove the barcode unique index

We need to rely on the DB to handle barcode uniqueness... we should move the
barcode to another column, say... deleted_barcode.

> * Prevent regression and deal with Koha::Items->find Koha::Items->search
> Ideas:
>   - ->find returns only non-deleted items when ->find_deleted returns only
> deleted items
>   - same for ->search, ->search_deleted
> 
> Or keep Koha::Old::Items that could inherit from Koha::Items
> 
> Or update all the occurrences (how many?)

On the API I would expect the endpoint to return non-deleted ones as default,
and I would prefer to handle it explicitly: manually adding deleted => 0 to the
query. And have ?include_deleted=true and/or ?deleted=true be mandatory to get
the deleted ones.

Maybe we could encapsulate this pattern in Koha::Objects::Deleted, which
extended Koha::Objects with new generic methods: ->search_without_deleted

I haven't made up my mind yet, but I feel it smells to have ->search have a
weird behaviour other than the expected.

I'm also worried how we would handle:

my $items = $biblio->items;

so it doesn't return deleted ones.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 27 19:36:20 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Jan 2020 18:36:20 +0000
Subject: [Koha-bugs] [Bug 24476] Allow patrons to opt-out of Auto-renewal
In-Reply-To: <bug-24476-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24476-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24476-70-QKnlPkgS5u@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24476

Phil Ringnalda <phil at chetcolibrary.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |phil at chetcolibrary.org

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 27 19:36:31 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Jan 2020 18:36:31 +0000
Subject: [Koha-bugs] [Bug 18532] AUTO_RENEWALS should be a patron messaging
 preference
In-Reply-To: <bug-18532-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18532-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18532-70-gKPncmzBRb@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18532

Phil Ringnalda <phil at chetcolibrary.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |phil at chetcolibrary.org

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 27 19:51:25 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Jan 2020 18:51:25 +0000
Subject: [Koha-bugs] [Bug 23673] Separate time sent from time created in
 message_queue table
In-Reply-To: <bug-23673-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23673-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23673-70-0XDBT47Hcl@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23673

--- Comment #17 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
(In reply to Jonathan Druart from comment #16)
> (In reply to Agustín Moyano from comment #14)
> > Hi Jonathan
> >  
> > > 1. Should not we have the new column with the "default CURRENT_TIMESTAMP on
> > > update CURRENT_TIMESTAMP" clause in order to delegate the update of this
> > > value to the DBMS?
> > 
> > Mysql doesn't accept a table with 2 columns with "default
> > CURRENT_TIMESTAMP".. there can be only one.
> 
> Hola Agustín, Yes I know and that's why I suggested to have it on the new
> column :)
> 
> Take a look at library_groups or borrowers tables for instance. Note that
> article_requests does the reverse.

You mean making the 'time_queued' column TIMESTAMP DEFAULT NULL (and so making
us set it manually), and making 'updated_on' be the one with the trigger? (so
we don't do the update manually?). I'm fine with either. Just trying to clarify
so we move this forward.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 27 19:57:55 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Jan 2020 18:57:55 +0000
Subject: [Koha-bugs] [Bug 24361] Fix warnings (or failing tests) from bug
 24217
In-Reply-To: <bug-24361-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24361-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24361-70-lg1mcgSGUO@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24361

--- Comment #11 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Bug 24361: Silent t/db_dependent/Items.t  pushed to master

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 27 19:58:22 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Jan 2020 18:58:22 +0000
Subject: [Koha-bugs] [Bug 23128] Missing Net::OAuth2::AuthorizationServer
 dependency
In-Reply-To: <bug-23128-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23128-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23128-70-z1EZak8MD2@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23128

--- Comment #9 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
https://meetings.koha-community.org/2019/development_irc_meeting_26_june_2019.2019-06-26-19.00.html

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 27 20:01:16 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Jan 2020 19:01:16 +0000
Subject: [Koha-bugs] [Bug 24348] Record matching rules: required match
 checks does not work
In-Reply-To: <bug-24348-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24348-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24348-70-XJGDWgNoqS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24348

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #96825|0                           |1
        is obsolete|                            |

--- Comment #3 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 97993
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97993&action=edit
Bug 24348: Pass marc record to _passes_required_checks

Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 27 20:02:28 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Jan 2020 19:02:28 +0000
Subject: [Koha-bugs] [Bug 24348] Record matching rules: required match
 checks does not work
In-Reply-To: <bug-24348-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24348-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24348-70-vEFKUhixAg@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24348

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |martin.renvoize at ptfs-europe
                   |                            |.com
             Status|Needs Signoff               |Signed Off

--- Comment #4 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Works as expected, signing off.. it would be great to see an accompanying
regression test though.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 27 20:03:52 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Jan 2020 19:03:52 +0000
Subject: [Koha-bugs] [Bug 18532] AUTO_RENEWALS should be a patron messaging
 preference
In-Reply-To: <bug-18532-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18532-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18532-70-HmhA4KgwA0@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18532

--- Comment #24 from Agustín Moyano <agustinmoyano at theke.io> ---
Sorry, I was almost abducted by another (evil) bug.

I'll remove those lines from atomicupdate ASAP, so this can move forward.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 27 20:11:43 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Jan 2020 19:11:43 +0000
Subject: [Koha-bugs] [Bug 8132] Batch delete tool deletes items with holds
 on them
In-Reply-To: <bug-8132-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-8132-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8132-70-DKIovlgQYX@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8132

--- Comment #43 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Still testing this Kelly?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 27 20:19:05 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Jan 2020 19:19:05 +0000
Subject: [Koha-bugs] [Bug 13420] Holdings table sorting on volume
 information incorrect
In-Reply-To: <bug-13420-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13420-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13420-70-wYDPv6tBmt@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13420

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #88995|0                           |1
        is obsolete|                            |

--- Comment #23 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 97994
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97994&action=edit
Bug 13420: Sort "Serial enumeration" by published date

So far the sorting on volume information is incorrect. It sorts by the
string displayed in the cell, which may not have any logics.

A better solution would be to use Kyle's suggestion, see comments 7, 8,
but it will need much more work.

This patch suggests to use the publication date to sort this column.
Note: In the code there is a switch depending on the existence of
items.publisheddate, but I do not think it is valid, this valid should
always exist if the item is received (did I miss something?)

Test plan:
You need to have different existing subscription, using different
numbering.
On the detail page of the bibliographic record you should be able to
sort the serials (tab "Holdings") by "Serial enumeration".
The sort will now use the publication dates.

Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 27 20:19:09 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Jan 2020 19:19:09 +0000
Subject: [Koha-bugs] [Bug 13420] Holdings table sorting on volume
 information incorrect
In-Reply-To: <bug-13420-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13420-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13420-70-njWixKMUzv@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13420

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #92026|0                           |1
        is obsolete|                            |

--- Comment #24 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 97995
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97995&action=edit
Bug 13420: Fallback to the previous behavior if published date is not used

Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 27 20:19:37 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Jan 2020 19:19:37 +0000
Subject: [Koha-bugs] [Bug 13420] Holdings table sorting on volume
 information incorrect
In-Reply-To: <bug-13420-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13420-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13420-70-CCijdQGVKM@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13420

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off
                 CC|                            |martin.renvoize at ptfs-europe
                   |                            |.com

--- Comment #25 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
This works as described and seems a suitable interim solution to me.. Signing
off.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 27 20:21:46 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Jan 2020 19:21:46 +0000
Subject: [Koha-bugs] [Bug 24516] Column Configuration does not hide Return
 Date
In-Reply-To: <bug-24516-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24516-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24516-70-heiAv2oxlH@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24516

Lucas Gass <lucas at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |lucas at bywatersolutions.com

--- Comment #1 from Lucas Gass <lucas at bywatersolutions.com> ---
I cannot reproduce this in master now. I believe the problem was solved by
bz24515.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 27 20:22:08 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Jan 2020 19:22:08 +0000
Subject: [Koha-bugs] [Bug 24485] Sys Pref AllowHoldPolicyOverride will not
 Staff override a Holds Per Record Rule
In-Reply-To: <bug-24485-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24485-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24485-70-LM3kXm4Oq8@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24485

Andrew Fuerste-Henry <andrew at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |andrew at bywatersolutions.com
                   |                            |, nick at bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 27 20:25:51 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Jan 2020 19:25:51 +0000
Subject: [Koha-bugs] [Bug 24269] Authority matching in Elasticsearch is
 broken when authority has subdivisions
In-Reply-To: <bug-24269-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24269-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24269-70-SEa7KIsPVU@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24269

--- Comment #4 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Comment on attachment 97982
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97982
Bug 24269: Adjust C4::Heading to generate headings from auth tags

Review of attachment 97982:
 --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=24269&attachment=97982)
-----------------------------------------------------------------

::: C4/Heading.pm
@@ +52,5 @@
>  
>  Given a C<MARC::Field> object containing a heading from a 
>  bib record, create a C<C4::Heading> object.
>  
> +The optional third parameter is 'auth' - it is handled as boolean. If supplied we treat the field as an auth record field. Otherwise if it is a bib field. The fields checked are the same in a UNIMARC system and this parameter is ignored

I'm not sure I understand this rewording.. you've removed the '$marc_flavour'
param right, and instead, always use the application context?  I think this
could be more clearly worded.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 27 20:26:45 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Jan 2020 19:26:45 +0000
Subject: [Koha-bugs] [Bug 24269] Authority matching in Elasticsearch is
 broken when authority has subdivisions
In-Reply-To: <bug-24269-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24269-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24269-70-6A3Ek5OPek@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24269

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #97982|0                           |1
        is obsolete|                            |

--- Comment #5 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 97996
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97996&action=edit
Bug 24269: Adjust C4::Heading to generate headings from auth tags

To test:
1 - Be using Elasticsearch
2 - Check that field 150 is mapped to 'Match-heading' or add it (the subfields
don't matter)
3 - Add a topic term authority record like "150 $aCats$vFiction"
4 - Add a 650 with $aCats and $vFiction and  $e depicted to a bibliographic
record
5 - Run the linker for the bib
    perl misc/link_bibs_to_authorities.pl --bib-limit "biblionumber=89" -v
6 - Confirm the record is not correctly linked to the record
7 - Apply patch
8 - Reindex authorities for ES
    perl misc/search_tools/rebuild_elasticsearch.pl -v -d -a
9 - Run the linker and confirm record is correctly linked
    perl misc/link_bibs_to_authorities.pl --bib-limit "biblionumber=89" -v

Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 27 20:27:44 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Jan 2020 19:27:44 +0000
Subject: [Koha-bugs] [Bug 24269] Authority matching in Elasticsearch is
 broken when authority has subdivisions
In-Reply-To: <bug-24269-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24269-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24269-70-OoO1etGY6Y@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24269

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

--- Comment #6 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Signing off as this logically all makes sense, the tests pass and it passes
it's test plan.

Minor comment about rewording the updated POD slightly as it's not entirely
clear without reading the code.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 27 20:30:13 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Jan 2020 19:30:13 +0000
Subject: [Koha-bugs] [Bug 23915] Replace OPAC list sort menu with Bootstrap
 menu button
In-Reply-To: <bug-23915-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23915-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23915-70-Xj8wHyt5Mv@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23915

--- Comment #5 from David Nind <david at davidnind.com> ---
Everything looks and works fine except for the sort by copyright date.

- Copyright date (newest to oldest): sorts as asc when it should be desc (for
example, lists an 1875 item before 2009)

- Copyright date (oldest to newest): sorts as desc when it should be asc (for
example, lists an 2009 item before 1875)

It looks like this was introduced by Bug 23913 - the above behaviour is in
master, but not in 19.11.x.

Should this be fixed in this bug, or should it be a new bug?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 27 20:31:47 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Jan 2020 19:31:47 +0000
Subject: [Koha-bugs] [Bug 10869] Can't cancel order line if title deleted
In-Reply-To: <bug-10869-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-10869-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10869-70-5KLXeDvqzu@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10869

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |martin.renvoize at ptfs-europe
                   |                            |.com
         QA Contact|paul.poulain at biblibre.com   |testopia at bugs.koha-communit
                   |                            |y.org

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 27 20:32:42 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Jan 2020 19:32:42 +0000
Subject: [Koha-bugs] [Bug 10869] Can't cancel order line if title deleted
In-Reply-To: <bug-10869-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-10869-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10869-70-6Q8HNTyNR4@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10869

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |additional_work_needed

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 27 20:32:52 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Jan 2020 19:32:52 +0000
Subject: [Koha-bugs] [Bug 10869] Can't cancel order line if title deleted
In-Reply-To: <bug-10869-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-10869-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10869-70-fm9OLLqlFv@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10869

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |RM_priority

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 27 20:51:39 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Jan 2020 19:51:39 +0000
Subject: [Koha-bugs] [Bug 23463] Move C4::Items CRUD subroutines to
 Koha::Item
In-Reply-To: <bug-23463-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23463-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23463-70-AtUmMbfnai@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23463

--- Comment #64 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
About the timestamp handling: shouldn't we better implement
Koha::Object->set_and_store of similar, that instead of overwriting the whole
object, just sets the really changed fields, and we leave the DB do the heavy
lifting? It looks wrong (as you also say, Jonathan) to be setting the timestamp
manually on the ->store method (be it in the Koha::Item class, or as a generic
approach in Koha::Object)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 27 21:00:29 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Jan 2020 20:00:29 +0000
Subject: [Koha-bugs] [Bug 24269] Authority matching in Elasticsearch is
 broken when authority has subdivisions
In-Reply-To: <bug-24269-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24269-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24269-70-4dCDjk7B0r@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24269

--- Comment #7 from Nick Clemens <nick at bywatersolutions.com> ---
(In reply to Martin Renvoize from comment #4)
> Comment on attachment 97982 [details] [review]
> Bug 24269: Adjust C4::Heading to generate headings from auth tags
> 
> Review of attachment 97982 [details] [review]:
> -----------------------------------------------------------------
> 
> ::: C4/Heading.pm
> @@ +52,5 @@
> >  
> >  Given a C<MARC::Field> object containing a heading from a 
> >  bib record, create a C<C4::Heading> object.
> >  
> > +The optional third parameter is 'auth' - it is handled as boolean. If supplied we treat the field as an auth record field. Otherwise if it is a bib field. The fields checked are the same in a UNIMARC system and this parameter is ignored
> 
> I'm not sure I understand this rewording.. you've removed the
> '$marc_flavour' param right, and instead, always use the application
> context?  I think this could be more clearly worded.

I did, I didn't mention it in the POD, meant to mention in the commit message -
we had that option, but it was never used and I didn't see a reason to preserve
it

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 27 21:01:02 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Jan 2020 20:01:02 +0000
Subject: [Koha-bugs] [Bug 24269] Authority matching in Elasticsearch is
 broken when authority has subdivisions
In-Reply-To: <bug-24269-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24269-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24269-70-FGgL7NQjJ5@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24269

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |nick at bywatersolutions.com
                   |ity.org                     |

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 27 21:11:51 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Jan 2020 20:11:51 +0000
Subject: [Koha-bugs] [Bug 22690] Merging records with many items too slow
 (Elasticsearch)
In-Reply-To: <bug-22690-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22690-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22690-70-LBRa5GtQiA@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22690

--- Comment #17 from Michal Denar <black23 at gmail.com> ---
Hi Ere,
prove t/db_dependent/Koha/Item.t:

    not ok 3 - Value is mapped correctly for column biblionumber

    #   Failed test 'Value is mapped correctly for column biblionumber'
    #   at t/db_dependent/Koha/Item.t line 109.
    #          got: undef
    #     expected: '462'

    not ok 4 - Value is mapped correctly for column biblioitemnumber

    #   Failed test 'Value is mapped correctly for column biblioitemnumber'
    #   at t/db_dependent/Koha/Item.t line 109.
    #          got: undef
    #     expected: '461'

    not ok 28 - Value is mapped correctly for column timestamp

    #   Failed test 'Value is mapped correctly for column timestamp'
    #   at t/db_dependent/Koha/Item.t line 109.
    #          got: undef
    #     expected: '2020-01-24 22:23:22'

   not ok 42 - Value is mapped correctly for column biblionumber

    #   Failed test 'Value is mapped correctly for column biblionumber'
    #   at t/db_dependent/Koha/Item.t line 124.
    #          got: undef
    #     expected: '462'

  not ok 67 - Value is mapped correctly for column timestamp

    #   Failed test 'Value is mapped correctly for column timestamp'
    #   at t/db_dependent/Koha/Item.t line 124.
    #          got: undef
    #     expected: '2020-01-24 22:23:22'


    # Looks like you failed 6 tests of 79.
not ok 3 - as_marc_field() tests


It's problem with my mappings?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 27 21:26:01 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Jan 2020 20:26:01 +0000
Subject: [Koha-bugs] [Bug 24476] Allow patrons to opt-out of Auto-renewal
In-Reply-To: <bug-24476-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24476-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24476-70-oBDIOTJSyh@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24476

--- Comment #25 from Andrew Fuerste-Henry <andrew at bywatersolutions.com> ---
New test plan:
1 - Set loan period and No Renewal Before such than an item is eligable for
renewal immediately upon checkout
2 - Check out an item to a patron opted in to auto renewal
3 - Ensure the item is checked out and set to autorenew
4 - Opt patron out of auto-renew
5 - Verify that patron's checkout now shows as available for manual renewal
6 - Make sure OpacRenewalAllowed is set to Allow and "autorenewal" is not in
PatronSelfModificationBorrowerUnwantedField
7 - Login on the opac at the patron
8 - Verify checkout shows as available for manual renewal
9 - Verify you can submit change request from OPAC to opt patron in to
auto-renew
10 - Find change request on intranet, verify it shows change to autorenew
opt-in, accept change request
11 - Reload patron summary on OPAC, verify it now shows checkout is scheduled
for auto-renewal
12 - On staff side, opt patron out of auto-renew
13 - Run misc/cronjobs/automatic_renewals.pl, verify item is not renewed
14 - Manually renew item from the intranet
15 - Manually renew item from the OPAC
16 - Opt patron in for auto-renew
17 - Run misc/cronjobs/automatic_renewals.pl, verify item is renewed
18 - Set No Renewal Before value so item is no longer eligable for renewal
19 - Verify intranet and OPAC still show checkout scheduled for auto-renewal
20 - Opt patron out of auto-renew
21 - Verify intranet and OPAC show checkout ineligible for manual renewal due
to No Renewal Before
22 - Opt patron in to auto-renew
22 - Add "autorenewal to PatronSelfModificationBorrowerUnwantedField and
BorrowerUnwantedField
23 - Confirm patron can no longer be opted out of auto-renew on intranet or
OPAC

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 27 21:27:40 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Jan 2020 20:27:40 +0000
Subject: [Koha-bugs] [Bug 24476] Allow patrons to opt-out of Auto-renewal
In-Reply-To: <bug-24476-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24476-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24476-70-2K8muIHuXn@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24476

ByWater Sandboxes <bws.sandboxes at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #97923|0                           |1
        is obsolete|                            |

--- Comment #26 from ByWater Sandboxes <bws.sandboxes at gmail.com> ---
Created attachment 97997
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97997&action=edit
Bug 24476: Database updates

Signed-off-by: Andrew <andrew at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 27 21:27:43 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Jan 2020 20:27:43 +0000
Subject: [Koha-bugs] [Bug 24476] Allow patrons to opt-out of Auto-renewal
In-Reply-To: <bug-24476-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24476-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24476-70-0dzJk5Cs5s@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24476

ByWater Sandboxes <bws.sandboxes at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #97924|0                           |1
        is obsolete|                            |

--- Comment #27 from ByWater Sandboxes <bws.sandboxes at gmail.com> ---
Created attachment 97998
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97998&action=edit
Bug 24476: API Updates

Signed-off-by: Andrew <andrew at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 27 21:27:46 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Jan 2020 20:27:46 +0000
Subject: [Koha-bugs] [Bug 24476] Allow patrons to opt-out of Auto-renewal
In-Reply-To: <bug-24476-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24476-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24476-70-q0FC4IHnoh@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24476

ByWater Sandboxes <bws.sandboxes at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #97925|0                           |1
        is obsolete|                            |

--- Comment #28 from ByWater Sandboxes <bws.sandboxes at gmail.com> ---
Created attachment 97999
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97999&action=edit
Bug 24476: Change CanBookBeRenewed and adjust tests

Signed-off-by: Andrew <andrew at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 27 21:27:48 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Jan 2020 20:27:48 +0000
Subject: [Koha-bugs] [Bug 24476] Allow patrons to opt-out of Auto-renewal
In-Reply-To: <bug-24476-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24476-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24476-70-9eEB6HpaRc@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24476

ByWater Sandboxes <bws.sandboxes at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #97926|0                           |1
        is obsolete|                            |

--- Comment #29 from ByWater Sandboxes <bws.sandboxes at gmail.com> ---
Created attachment 98000
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98000&action=edit
Bug 24476: Allow patrons to opt out of auto-renewal

To test:
1 - Verify on staff side that patron can be edited to opt in our out of auto
renewal
2 - Check out some items to a patron opted in to auto renewal
3 - Ensure the items are checked out and set to autorenew
4 - Login on the opac at the patron
5 - Verify items cannot be renewed as scheduled for auto-renewal
6 - On staff side, opt patron out of auto renewal
7 - Verify on opac items are no longer marked for auto renewal
8 - Run the auto renewal cron job, items are not renewed
9 - Set 'no renewal before' to a setting that would prevent renewal
10 - Verify that opting patron in or out of auto renewal changes only the
reason items cannot be renewed
11 - Set 'no renewal before' to a setting that would allow for renewal
12 - Verify that opting patron in/out changes their ability to renew
13 - Verify that when opted out cron does not renew
14 - Verify that when opted in the item is auto renewed
15 - Reset the due date, opt out, verify manual renewal succeeds

Signed-off-by: Andrew <andrew at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 27 21:27:51 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Jan 2020 20:27:51 +0000
Subject: [Koha-bugs] [Bug 24476] Allow patrons to opt-out of Auto-renewal
In-Reply-To: <bug-24476-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24476-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24476-70-dyxdWPfH0b@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24476

ByWater Sandboxes <bws.sandboxes at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #97927|0                           |1
        is obsolete|                            |

--- Comment #30 from ByWater Sandboxes <bws.sandboxes at gmail.com> ---
Created attachment 98001
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98001&action=edit
Bug 24476: DO NOT PUSH - Schema updates

Signed-off-by: Andrew <andrew at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 27 21:27:54 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Jan 2020 20:27:54 +0000
Subject: [Koha-bugs] [Bug 24476] Allow patrons to opt-out of Auto-renewal
In-Reply-To: <bug-24476-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24476-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24476-70-h386YmpV5S@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24476

ByWater Sandboxes <bws.sandboxes at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #97928|0                           |1
        is obsolete|                            |

--- Comment #31 from ByWater Sandboxes <bws.sandboxes at gmail.com> ---
Created attachment 98002
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98002&action=edit
Bug 24476: Add boolean for all TINYINT

Signed-off-by: Andrew <andrew at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 27 21:56:43 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Jan 2020 20:56:43 +0000
Subject: [Koha-bugs] [Bug 13121] Move search results "action" links ("Place
 hold, " "Add tag, " etc) into include file
In-Reply-To: <bug-13121-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13121-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13121-70-wmqQ85A8xF@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13121

--- Comment #7 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
(In reply to Owen Leonard from comment #6)
> (In reply to Katrin Fischer from comment #5)
> > 		forbidden pattern: Contains old bootstrap style for buttons (see bug
> 
> It's a false positive. The OPAC still uses the "old bootstrap." The warning
> should only be triggered for staff client templates.

Thx!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 27 22:07:01 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Jan 2020 21:07:01 +0000
Subject: [Koha-bugs] [Bug 24521] New: Removing a record from the cart
 doesn't remove the (remove) label
Message-ID: <bug-24521-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24521

            Bug ID: 24521
           Summary: Removing a record from the cart doesn't remove the
                    (remove) label
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: OPAC
          Assignee: oleonard at myacpl.org
          Reporter: katrin.fischer at bsz-bw.de
        QA Contact: testopia at bugs.koha-community.org

When adding a record to the cart from the result list, the entry changes to "In
your cart (remove)", but clicking on it again doesn't change the label back.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 27 22:07:49 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Jan 2020 21:07:49 +0000
Subject: [Koha-bugs] [Bug 13121] Move search results "action" links ("Place
 hold, " "Add tag, " etc) into include file
In-Reply-To: <bug-13121-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13121-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13121-70-KF2Ix6b1Y7@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13121

--- Comment #8 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Hi Owen, I am passing this, but it looks like with and without this patch
removing a title from the cart no longer works quite right. The (remove) link
remains. Also: the cart message is hiding behind the floating toolbar for me. I
filed bug 24521.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 27 22:08:20 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Jan 2020 21:08:20 +0000
Subject: [Koha-bugs] [Bug 13121] Move search results "action" links ("Place
 hold, " "Add tag, " etc) into include file
In-Reply-To: <bug-13121-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13121-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13121-70-e7257Qcr6N@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13121

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 27 22:08:25 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Jan 2020 21:08:25 +0000
Subject: [Koha-bugs] [Bug 13121] Move search results "action" links ("Place
 hold, " "Add tag, " etc) into include file
In-Reply-To: <bug-13121-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13121-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13121-70-0iAAbH9Xj6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13121

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #97803|0                           |1
        is obsolete|                            |

--- Comment #9 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 98003
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98003&action=edit
Bug 13121: Move search results "action" links ("Place hold," "Add tag," etc)
into include file

This patch moves markup for controls repeated across several OPAC
templates into a single include: Place hold, Request article, Add tag,
Save to lists, and Add to cart.

To test, apply the patch and view the following OPAC pages:

 - Search results
 - Shelf contents view
 - User tags list

On each of these pages all the controls should work correctly:

 - Place hold
 - Request art
 - Add tag
 - Save to lists
 - Add to cart

Signed-off-by: David Nind <david at davidnind.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 27 22:18:52 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Jan 2020 21:18:52 +0000
Subject: [Koha-bugs] [Bug 24476] Allow patrons to opt-out of Auto-renewal
In-Reply-To: <bug-24476-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24476-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24476-70-1zX8uorbrG@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24476

Andrew Fuerste-Henry <andrew at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 27 22:20:39 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Jan 2020 21:20:39 +0000
Subject: [Koha-bugs] [Bug 23885] Move staff client search results JavaScript
 into separate file
In-Reply-To: <bug-23885-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23885-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23885-70-axOtthU8f7@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23885

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de

--- Comment #4 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
(In reply to David Nind from comment #3)
> Created attachment 97970 [details]
> Bug 23885: Screenshots of potential problem
> 
> A potential problem identified during testing is placing a hold for a Patron
> club. 
> 
> This didn’t work for me before the patch was applied as well as when the
> patch was applied, so it is either something I did or it is another issue.
> 
> When you select an item with a tick and then try to place a hold for the
> Patron Club from the drop down list (screenshot 1 in attachment) you get “No
> items are available” (see screenshot 2 in attachment).
> 
> Selecting ‘Place hold for ...’ from the links works fine though.

I haven't managed to get the pull down to display when testing without the
patch - maybe someone else can give this a try?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 27 22:23:49 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Jan 2020 21:23:49 +0000
Subject: [Koha-bugs] [Bug 24521] Removing a record from the cart doesn't
 remove the (remove) label
In-Reply-To: <bug-24521-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24521-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24521-70-cmD25B8ZBx@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24521

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|normal                      |enhancement

--- Comment #1 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Just realized you have to click on the 'remove' part. :) When you click on 'in
your cart' the message about items in the cart flashes really quickly.
Maybe we could improve the usability a bit?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 27 22:25:10 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Jan 2020 21:25:10 +0000
Subject: [Koha-bugs] [Bug 24488] Holds to Pull sometimes shows the wrong
 'first patron' details
In-Reply-To: <bug-24488-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24488-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24488-70-mjqmRfTdwx@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24488

Aleisha Amohia <aleisha at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Failed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 27 22:29:22 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Jan 2020 21:29:22 +0000
Subject: [Koha-bugs] [Bug 24522] New: Nothing happens when trying to add
 nothing to a list in staff
Message-ID: <bug-24522-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24522

            Bug ID: 24522
           Summary: Nothing happens when trying to add nothing to a list
                    in staff
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Staff Client
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: katrin.fischer at bsz-bw.de
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com

When no entries are selected in a staff search results list and 'add to list'
is used, nothing happens.
Try the same in the OPAC and a message "No item was selected" will display.
We should have a message for the staff client as well.

Note: For better translatability it would be nice to avoid item here - maybe
'search result' or 'record' would work?

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 27 22:31:04 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Jan 2020 21:31:04 +0000
Subject: [Koha-bugs] [Bug 24521] Usability for cart handling from OPAC
 search results could be slightly improved
In-Reply-To: <bug-24521-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24521-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24521-70-KrBCtx2GFa@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24521

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Removing a record from the  |Usability for cart handling
                   |cart doesn't remove the     |from OPAC search results
                   |(remove) label              |could be slightly improved

--- Comment #2 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Another small thing: when scrolling down, the floating toolbar can hide the
cart messages.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 27 22:56:04 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Jan 2020 21:56:04 +0000
Subject: [Koha-bugs] [Bug 23885] Move staff client search results JavaScript
 into separate file
In-Reply-To: <bug-23885-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23885-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23885-70-OKqEcZCrIn@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23885

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 27 22:56:07 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Jan 2020 21:56:07 +0000
Subject: [Koha-bugs] [Bug 23885] Move staff client search results JavaScript
 into separate file
In-Reply-To: <bug-23885-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23885-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23885-70-5vBu16P3dd@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23885

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #97964|0                           |1
        is obsolete|                            |

--- Comment #5 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 98004
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98004&action=edit
Bug 23885: Move staff client search results JavaScript into separate file

This patch moves most of the JavaScript embedded in results.tt into a
separate file. The JavaScript that remains on the page is everything
which requires processing by Template Toolkit. This is limited to
variable definition.

To test, apply the patch and perform a catalog search in the staff
client. On the results page, test that JavaScript functionality has not
been affected:

 - The search results toolbar should "float" as you scroll
 - Select all and Clear all
 - Default search term highlighting; Unhighlight and highlight controls
 - Adding and removing one or more items from the cart
 - Adding one or more items to a list
 - Placing one or more holds my making selections and clicking "Place
   hold"
 - Browse selected records
 - Z39.50 search (search form should be populated with your search
   terms)
 - "Show more" and "Show less" links in the facets sidebar
 - Book cover image services: Amazon, Coce, local covers, etc.
 - Open a patron record and click "Search to hold"
  - Perform a search and select one or more results
    - Test "Place hold" from the hold menu in the toolbar
    - Test "Place hold for..." from the hold menu in the toolbar
    - Test "Forget..." from the hold menu in the toolbar
 - In Tools -> Patron clubs, locate a club with enrolled members
   - From the "Actions" menu, select "Search to hold"
     - Perform a search and select one or more results
       - Test "Place hold" from the hold menu in the toolbar
       - Test "Place hold for..." from the hold menu in the toolbar
       - Test "Forget..." from the hold menu in the toolbar

Signed-off-by: David Nind <david at davidnind.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 27 23:01:26 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Jan 2020 22:01:26 +0000
Subject: [Koha-bugs] [Bug 23856] Split author and ISBN/ISSN out of citation
 in staged MARC record management
In-Reply-To: <bug-23856-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23856-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23856-70-H5eDCgB24b@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23856

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 27 23:01:30 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Jan 2020 22:01:30 +0000
Subject: [Koha-bugs] [Bug 23856] Split author and ISBN/ISSN out of citation
 in staged MARC record management
In-Reply-To: <bug-23856-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23856-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23856-70-A84N57zVkV@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23856

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #97953|0                           |1
        is obsolete|                            |

--- Comment #3 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 98005
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98005&action=edit
Bug 23856: Split author and ISBN/ISSN out of citation in staged MARC record
management

This patch modifies the way data is passed to the staged MARC record
management template, splitting author, ISBN, and ISSN out of the
"citation" variable and passing them separately.

The DataTables configuration for the staged MARC record management page
is modified so that those now-separate variables are conditionally
displayed.

Unrelated minor change: Added a class to the MARC preview modal so that
it displays wider.

To test, apply the patch and view the "Staged MARC management" page for
both batches of bibliographic records and batches of authority records.

In each case the title or authority heading should be displayed as a
link while author, ISBN, and ISSN (if any) should not.

Signed-off-by: David Nind <david at davidnind.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 27 23:04:04 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Jan 2020 22:04:04 +0000
Subject: [Koha-bugs] [Bug 24523] New: Fix opac-password-recovery markup
 mistake
Message-ID: <bug-24523-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24523

            Bug ID: 24523
           Summary: Fix opac-password-recovery markup mistake
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: OPAC
          Assignee: oleonard at myacpl.org
          Reporter: lucas at bywatersolutions.com
        QA Contact: testopia at bugs.koha-community.org

ON the opac-password-recovery page the paragraph "To reset your password, enter
your login or your email address." is missing a closing </p>.

This is trivial but it does make it nearly impossible to update or hide that
element with jQuery as it will effect the entire form below it.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 27 23:04:14 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Jan 2020 22:04:14 +0000
Subject: [Koha-bugs] [Bug 24523] Fix opac-password-recovery markup mistake
In-Reply-To: <bug-24523-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24523-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24523-70-cmHeEjVmy7@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24523

Lucas Gass <lucas at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|enhancement                 |trivial

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 27 23:04:26 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Jan 2020 22:04:26 +0000
Subject: [Koha-bugs] [Bug 23113] members/pay.tt account_grp is not longer
 used
In-Reply-To: <bug-23113-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23113-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23113-70-4CjJClWTEG@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23113

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 27 23:04:30 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Jan 2020 22:04:30 +0000
Subject: [Koha-bugs] [Bug 23113] members/pay.tt account_grp is not longer
 used
In-Reply-To: <bug-23113-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23113-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23113-70-AIUpOIZFkR@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23113

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #97952|0                           |1
        is obsolete|                            |

--- Comment #5 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 98006
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98006&action=edit
Bug 23113: members/pay.tt account_grp is not longer used

This patch removes obsolete markup from pay.tt.

To test, apply the patch and search the Koha codebase for instances of
"account_grp" There should be none.

Log in to the staff client and go to the account of a patron who has
fines. Confirm that the "Accounting" page ("Make a payment" tab) works
correctly.

Signed-off-by: David Nind <david at davidnind.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 27 23:06:34 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Jan 2020 22:06:34 +0000
Subject: [Koha-bugs] [Bug 24488] Holds to Pull sometimes shows the wrong
 'first patron' details
In-Reply-To: <bug-24488-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24488-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24488-70-Jzl7sMW7v2@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24488

Aleisha Amohia <aleisha at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Needs Signoff

--- Comment #5 from Aleisha Amohia <aleisha at catalyst.net.nz> ---
(In reply to Kelly McElligott from comment #4)
> Hi Aleisha,
> I have done what you have recommended.  I am now getting an error when I try
> to go to the Holds to Pull report 
> 
> DBIx::Class::Storage::DBI::_dbh_execute(): 'koha_hold.reserve.reserve_id'
> isn't in GROUP BY at /kohadevbox/koha/Koha/Objects.pm line 130
>  at /usr/share/perl5/DBIx/Class/Exception.pm line 77

Hi Kelly, I can't reproduce this error. There might be a problem in your
database? Sorry!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 27 23:10:12 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Jan 2020 22:10:12 +0000
Subject: [Koha-bugs] [Bug 24523] Fix opac-password-recovery markup mistake
In-Reply-To: <bug-24523-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24523-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24523-70-zkNkdbjkpy@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24523

Lucas Gass <lucas at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 27 23:10:14 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Jan 2020 22:10:14 +0000
Subject: [Koha-bugs] [Bug 24523] Fix opac-password-recovery markup mistake
In-Reply-To: <bug-24523-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24523-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24523-70-JgQeMvY3gE@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24523

--- Comment #1 from Lucas Gass <lucas at bywatersolutions.com> ---
Created attachment 98007
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98007&action=edit
Bug 24523: add missing </p>

TEST PLAN: 
1. Add this jQuery to OPACUserJS ( $('p:contains("To reset your password, enter
your login or your email address.")').text('I want to change this text'); )
2. Reload the opac-password-recovery page.   
3. The text is changed but the rest of the form is now gone   
4. Apply patch and reload the opac-password-recovery page.
5. Reload the page and the text should be changed but the form should be there!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 27 23:10:46 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Jan 2020 22:10:46 +0000
Subject: [Koha-bugs] [Bug 24523] Fix opac-password-recovery markup mistake
In-Reply-To: <bug-24523-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24523-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24523-70-YKDCYdN1DT@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24523

Lucas Gass <lucas at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|oleonard at myacpl.org         |lucas at bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 27 23:32:08 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Jan 2020 22:32:08 +0000
Subject: [Koha-bugs] [Bug 24495] Reword change collection feature
In-Reply-To: <bug-24495-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24495-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24495-70-WNrvpC8DWw@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24495

--- Comment #4 from David Roberts <david.roberts at ptfs-europe.com> ---
So you are happy with "Amount tendered"? I agree that is normal cash register
terminology. What about "Amount due" or "Amount owed" for the other field, or
shall we just leave that as it is?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jan 27 23:34:21 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Jan 2020 22:34:21 +0000
Subject: [Koha-bugs] [Bug 24488] Holds to Pull sometimes shows the wrong
 'first patron' details
In-Reply-To: <bug-24488-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24488-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24488-70-Ku6cfG30yk@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24488

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de
             Status|Needs Signoff               |Failed QA

--- Comment #6 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Hi Aleisha, I think this is related to bug 21941/bug 17258 - a DBMS version
problem. Can you please check?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 28 00:21:24 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Jan 2020 23:21:24 +0000
Subject: [Koha-bugs] [Bug 21608] Arranging holds priority with dropdowns is
 faulty when there are waiting/intransit holds
In-Reply-To: <bug-21608-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21608-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21608-70-95GOrafFJs@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21608

Margaret <margaret at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|                            |18.11.01
        released in|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 28 00:21:43 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Jan 2020 23:21:43 +0000
Subject: [Koha-bugs] [Bug 24523] Fix opac-password-recovery markup mistake
In-Reply-To: <bug-24523-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24523-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24523-70-Bxd9tz3O5p@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24523

PTFS Europe Sandboxes <sandboxes at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #98007|0                           |1
        is obsolete|                            |

--- Comment #2 from PTFS Europe Sandboxes <sandboxes at ptfs-europe.com> ---
Created attachment 98008
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98008&action=edit
Bug 24523: add missing </p>

Signed-off-by: David Roberts <david.roberts at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 28 00:22:37 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Jan 2020 23:22:37 +0000
Subject: [Koha-bugs] [Bug 24523] Fix opac-password-recovery markup mistake
In-Reply-To: <bug-24523-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24523-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24523-70-SxEvvTGEK2@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24523

David Roberts <david.roberts at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off
                 CC|                            |david.roberts at ptfs-europe.c
                   |                            |om

--- Comment #3 from David Roberts <david.roberts at ptfs-europe.com> ---
Works OK as per test, as long as the OpacResetPassword system preference is
also enabled.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 28 00:26:24 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 27 Jan 2020 23:26:24 +0000
Subject: [Koha-bugs] [Bug 24495] Reword change collection feature
In-Reply-To: <bug-24495-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24495-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24495-70-xbwCLvhCUT@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24495

--- Comment #5 from Andrew Fuerste-Henry <andrew at bywatersolutions.com> ---
Let's try:
- "Total amount payable"
- "Amount being paid"
- "Amount tendered"
- "Change to give"

So that's nothing changed except "Collected from patron" changed to "Amount
tendered."
I talked to other folks here and in all the cases where libraries have gotten
confused about this, they just asked us to hide it entirely so we don't have
much for specific wording feedback.
Thanks for looking at this!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 28 01:24:23 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 28 Jan 2020 00:24:23 +0000
Subject: [Koha-bugs] [Bug 24495] Reword change collection feature
In-Reply-To: <bug-24495-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24495-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24495-70-rs6cy2IV2v@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24495

--- Comment #6 from David Roberts <david.roberts at ptfs-europe.com> ---
Created attachment 98009
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98009&action=edit
Bug 24495: Reword change collection feature

This patch changes the text of the "Collect from patron" field to read "Amount
tendered"

To Test:

1) In the Point of Sale screen, check that the text inside the "Collect
payment" box reads "Collect from patron"
2) Go into a patron record, and create a manual invoice.
3) Go to Make a payment, and select to "Pay an amount". Check the text reads
"Collect from patron".
4) Repeat the process with the "Pay Selected", and "Pay" button (listed next to
the individual invoice)
5) Install the patch
6) Repeat steps 1-4, but the text should now read "Amount tendered", instead of
"Collect from patron" in all payment options in the patron record, and in the
Point of Sale screen.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 28 01:25:52 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 28 Jan 2020 00:25:52 +0000
Subject: [Koha-bugs] [Bug 24495] Reword change collection feature
In-Reply-To: <bug-24495-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24495-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24495-70-MEKidmniGJ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24495

David Roberts <david.roberts at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

--- Comment #7 from David Roberts <david.roberts at ptfs-europe.com> ---
I've now changed the text of the "Collect from patron" box to "Amount tendered"
in both the POS and Paycollect pages. No other fields have been altered.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 28 02:57:14 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 28 Jan 2020 01:57:14 +0000
Subject: [Koha-bugs] [Bug 22835] Serve static files from plugins through the
 API
In-Reply-To: <bug-22835-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22835-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22835-70-HG1kn8ZESf@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22835

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |lucas at bywatersolutions.com
           Keywords|release-notes-needed        |

--- Comment #26 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
It applies to the 19.05.x branch! And works!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 28 03:11:26 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 28 Jan 2020 02:11:26 +0000
Subject: [Koha-bugs] [Bug 23070] Use Koha::Hold in
 C4::Reserves::RevertWaitingStatus
In-Reply-To: <bug-23070-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23070-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23070-70-gQOELMFUW3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23070

--- Comment #9 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
(In reply to Martin Renvoize from comment #3)
> (In reply to Jonathan Druart from comment #2)
> > I am missing a DBIx::Class trick to make this better.
> 
> If we were not getting rid of being able to call dbic's 'update' routine
> there might be.. though even then I think you'd need to pass some raw sql
> via a scalar ref.. something along the lines
> 
> `Koha::Holds->search({ biblionumber => $hold->biblionumber, priority => {
> '>' => 0 } })->update({ priority => \'priority + 1' });`
> 
> However, as we're keen to ensure we always go via our 'store' codepath to
> catch triggers then that is the equivalent to having to call ->update_all in
> DBIx::Class::ResultSet world.. which as that triggers a loop internally and
> a db hit per row rather than a db hit for the set then what you've got here
> seems the best we can do.
> 
> We could possibly get clever when we work on a solution for our version of
> update and check whether there are triggers in the local store routing and
> either call dbics underlying update directly or manipulate it into a loop
> which calls our store routines much like dbic does for update_all.

I'm leaning towards thinking we shouldn't use a catch-all ->store method, but
an ->insert and an ->update methods... There's a reasoning behind how DBIC does
things... We've gone too far with our use of ->update_or_insert and we end up
having a big IF clause on the more interesting Koha::Object-derived classes, to
detect if it is an update or an insert...

And I also belive many business stuffs should be on the controllers instead. We
are inserting too many things in the DAO (not exactly the pattern, I know) only
to be backwards compatible.

That said, this patches look correct the way our codebase is going forward.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 28 04:12:22 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 28 Jan 2020 03:12:22 +0000
Subject: [Koha-bugs] [Bug 22217] error "Connection to the memcached servers
 '__MEMCACHED_SERVERS__' failed" during install
In-Reply-To: <bug-22217-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22217-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22217-70-jWuUc5uAIP@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22217

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |tomascohen at gmail.com
            Version|18.11                       |master

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 28 04:12:59 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 28 Jan 2020 03:12:59 +0000
Subject: [Koha-bugs] [Bug 22217] error "Connection to the memcached servers
 '__MEMCACHED_SERVERS__' failed" during install
In-Reply-To: <bug-22217-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22217-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22217-70-SzhDEKfENu@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22217

--- Comment #2 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
This weird warning should be removed.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 28 07:59:20 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 28 Jan 2020 06:59:20 +0000
Subject: [Koha-bugs] [Bug 24495] Reword change collection feature
In-Reply-To: <bug-24495-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24495-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24495-70-7dSn8X3Xcm@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24495

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 28 07:59:24 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 28 Jan 2020 06:59:24 +0000
Subject: [Koha-bugs] [Bug 24495] Reword change collection feature
In-Reply-To: <bug-24495-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24495-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24495-70-Hr67VWd2dM@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24495

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #98009|0                           |1
        is obsolete|                            |

--- Comment #8 from David Nind <david at davidnind.com> ---
Created attachment 98010
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98010&action=edit
Bug 24495: Reword change collection feature

This patch changes the text of the "Collected from patron" field to read
"Amount tendered"

To Test:

0) Enable the point of sale system (EnablePointOfSale + UseCashRegister)
1) In the Point of Sale screen, check that the text inside the "Collect
payment" box reads "Collected from patron"
2) Go into a patron record, and create a manual invoice.
3) Go to Make a payment, and select to "Pay an amount". Check the text reads
"Collected from patron".
4) Repeat the process with the "Pay Selected", and "Pay" button (listed next to
the individual invoice)
5) Install the patch
6) Repeat steps 1-4, but the text should now read "Amount tendered", instead of
"Collected from patron" in all payment options in the patron record, and in the
Point of Sale screen.

Signed-off-by: David Nind <david at davidnind.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 28 08:02:15 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 28 Jan 2020 07:02:15 +0000
Subject: [Koha-bugs] [Bug 24495] Reword change collection feature
In-Reply-To: <bug-24495-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24495-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24495-70-wakXI7EpVB@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24495

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |david at davidnind.com

--- Comment #9 from David Nind <david at davidnind.com> ---
Note that current master says "Collected from patron" rather than "Collect from
patron". 

I updated the test plan to reflect that, including the system preferences to
enable the point of sale feature.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 28 08:46:14 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 28 Jan 2020 07:46:14 +0000
Subject: [Koha-bugs] [Bug 22217] error "Connection to the memcached servers
 '__MEMCACHED_SERVERS__' failed" during install
In-Reply-To: <bug-22217-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22217-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22217-70-eYu9XdAcv2@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22217

--- Comment #3 from David Cook <dcook at prosentient.com.au> ---
(In reply to Tomás Cohen Arazi from comment #2)
> This weird warning should be removed.

+1

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 28 08:59:11 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 28 Jan 2020 07:59:11 +0000
Subject: [Koha-bugs] [Bug 22543] Patron might be logged in again using
 browser back button
In-Reply-To: <bug-22543-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22543-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22543-70-TTrkpkRmOz@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22543

David Cook <dcook at prosentient.com.au> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |dcook at prosentient.com.au

--- Comment #31 from David Cook <dcook at prosentient.com.au> ---
Just noting that the problem behaviour still persists in the staff client. 

On one hand, it might not be a problem, because the staff client probably
wouldn't be used on a public terminal. On the other hand, a savvy person could
impersonate another staff member (e.g. a low privilege user gaining a higher
privilege user's session) using this tactic.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 28 09:04:55 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 28 Jan 2020 08:04:55 +0000
Subject: [Koha-bugs] [Bug 24428] Elasticsearch index does not contain
 consistent item information
In-Reply-To: <bug-24428-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24428-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24428-70-KAnWSBFx8h@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24428

--- Comment #7 from david holoshka <david.holoshka at ub.lu.se> ---
Hi,

I don't really follow how breaking functionality then say that restoring the
functionality is a enhancement.

We have several modifications to koha that depended on finding organized item
information in the es index.  It wase previously structured so that index 0,
for example, for all item info always belonged to the same item.  I thought the
community was moving towards es I so I used this fast searching ability to
build new functionality. 

It is a waste of time to lookup something in an index that contains all the
info then look up the item again in a database  or in koha's case look up
biblio info again in the biblio tables.  If the item information is organized
in es we can make use of es fast search capabilities to improve koha's
performance for a lot more scenarios eg subscriptions.

We are working to optimize the koha search here, but it is going to take
awhile.

Best Regards,
David

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 28 09:14:12 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 28 Jan 2020 08:14:12 +0000
Subject: [Koha-bugs] [Bug 20388] Elasticsearch - Ability to add search
 fields from UI
In-Reply-To: <bug-20388-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20388-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20388-70-XclrqXe0ky@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20388

Alex Arnaud <alex.arnaud at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #90517|0                           |1
        is obsolete|                            |

--- Comment #87 from Alex Arnaud <alex.arnaud at biblibre.com> ---
Created attachment 98011
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98011&action=edit
Bug 20388: Add/delete search fields from search engine configuration page

Test plan:

  - apply this patch,
  - check that SearchEngine system preference is set to Elasticsearch,
  - go to Admin > Search engine configuration,
  - on the search fields tab, fill a new line at the bottom of the table
    (name, label, type)
  - click on the "Add" button and save,
  - check that the new search field has been saved,
  - also test field deletions,
  - check that you can't delete already mapped fields.

Signed-off-by: Nicolas Legrand <nicolas.legrand at bulac.fr>
Signed-off-by: Séverine QUEUNE <severine.queune at bulac.fr>

Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
Signed-off-by: Björn Nylén <bjorn.nylen at ub.lu.se>
Signed-off-by: Julian Maurice <julian.maurice at biblibre.com>
Signed-off-by: Michal Denar <black23 at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 28 09:14:24 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 28 Jan 2020 08:14:24 +0000
Subject: [Koha-bugs] [Bug 20388] Elasticsearch - Ability to add search
 fields from UI
In-Reply-To: <bug-20388-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20388-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20388-70-ydyE5jwoL7@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20388

Alex Arnaud <alex.arnaud at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #90518|0                           |1
        is obsolete|                            |

--- Comment #88 from Alex Arnaud <alex.arnaud at biblibre.com> ---
Created attachment 98012
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98012&action=edit
Bug 20388: Keep data consistency when adding/removing mapping

Test plan:
  - create a new search field, save,
  - create a mapping using it (don't save),
  - check that you can't delete the search field.

  - delete all the mapping related to a search field (biblios and
    authorities), don't save,
  - check that you can delete this search field.

Signed-off-by: Nicolas Legrand <nicolas.legrand at bulac.fr>
Signed-off-by: Björn Nylén <bjorn.nylen at ub.lu.se>
Signed-off-by: Julian Maurice <julian.maurice at biblibre.com>
Signed-off-by: Michal Denar <black23 at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 28 09:14:36 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 28 Jan 2020 08:14:36 +0000
Subject: [Koha-bugs] [Bug 20388] Elasticsearch - Ability to add search
 fields from UI
In-Reply-To: <bug-20388-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20388-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20388-70-2eak2YSj50@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20388

Alex Arnaud <alex.arnaud at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #90519|0                           |1
        is obsolete|                            |

--- Comment #89 from Alex Arnaud <alex.arnaud at biblibre.com> ---
Created attachment 98013
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98013&action=edit
Bug 20388: Prevent user from using a search field for a mapping after removing
it

Test plan:

 - add a search field,
 - save,
 - remove this search field
 - check that it has been removed from the mapping lists (bottom
   select).

Signed-off-by: Björn Nylén <bjorn.nylen at ub.lu.se>
Signed-off-by: Julian Maurice <julian.maurice at biblibre.com>
Signed-off-by: Michal Denar <black23 at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 28 09:14:51 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 28 Jan 2020 08:14:51 +0000
Subject: [Koha-bugs] [Bug 20388] Elasticsearch - Ability to add search
 fields from UI
In-Reply-To: <bug-20388-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20388-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20388-70-UgD6bl2dHm@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20388

Alex Arnaud <alex.arnaud at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #90520|0                           |1
        is obsolete|                            |

--- Comment #90 from Alex Arnaud <alex.arnaud at biblibre.com> ---
Created attachment 98014
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98014&action=edit
Bug 20388: Use live handler for deleting elements

Signed-off-by: Björn Nylén <bjorn.nylen at ub.lu.se>
Signed-off-by: Julian Maurice <julian.maurice at biblibre.com>
Signed-off-by: Michal Denar <black23 at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 28 09:15:09 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 28 Jan 2020 08:15:09 +0000
Subject: [Koha-bugs] [Bug 20388] Elasticsearch - Ability to add search
 fields from UI
In-Reply-To: <bug-20388-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20388-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20388-70-tKmkEDNI1U@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20388

Alex Arnaud <alex.arnaud at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #90521|0                           |1
        is obsolete|                            |

--- Comment #91 from Alex Arnaud <alex.arnaud at biblibre.com> ---
Created attachment 98015
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98015&action=edit
Bug 20388: QA fixes: - pass search field objects in template instead of
unblessed ones - disable drag n drop

Signed-off-by: Julian Maurice <julian.maurice at biblibre.com>
Signed-off-by: Michal Denar <black23 at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 28 09:15:23 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 28 Jan 2020 08:15:23 +0000
Subject: [Koha-bugs] [Bug 20388] Elasticsearch - Ability to add search
 fields from UI
In-Reply-To: <bug-20388-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20388-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20388-70-GZC8VU4cgN@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20388

Alex Arnaud <alex.arnaud at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #90522|0                           |1
        is obsolete|                            |

--- Comment #92 from Alex Arnaud <alex.arnaud at biblibre.com> ---
Created attachment 98016
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98016&action=edit
Bug 20388: QA fixe : delete line who add elements in biblios and authorities in
the same time

Signed-off-by: Michal Denar <black23 at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 28 09:15:35 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 28 Jan 2020 08:15:35 +0000
Subject: [Koha-bugs] [Bug 20388] Elasticsearch - Ability to add search
 fields from UI
In-Reply-To: <bug-20388-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20388-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20388-70-67BNhQlUE7@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20388

Alex Arnaud <alex.arnaud at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #90523|0                           |1
        is obsolete|                            |

--- Comment #93 from Alex Arnaud <alex.arnaud at biblibre.com> ---
Created attachment 98017
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98017&action=edit
Bug 20388: add of types in the new entries dropdown of searchfiels

Signed-off-by: Michal Denar <black23 at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 28 09:15:47 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 28 Jan 2020 08:15:47 +0000
Subject: [Koha-bugs] [Bug 20388] Elasticsearch - Ability to add search
 fields from UI
In-Reply-To: <bug-20388-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20388-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20388-70-Rtb7SFtuPX@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20388

Alex Arnaud <alex.arnaud at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #90524|0                           |1
        is obsolete|                            |

--- Comment #94 from Alex Arnaud <alex.arnaud at biblibre.com> ---
Created attachment 98018
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98018&action=edit
Bug 20388: QA fixe : add searchfield only if it doesn't exist

To test:

Without the fix:
- in search field configuration -> search field
- add the search field "uri" at the bottom of the tab
- you should have two fields "uri" like that : https://snag.gy/BpxcIq.jpg

Then apply the fix
- try to add the search field uri
- this time an alert should appear with the message :
" SearchField uri already exist "

Signed-off-by: Michal Denar <black23 at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 28 09:17:42 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 28 Jan 2020 08:17:42 +0000
Subject: [Koha-bugs] [Bug 20388] Elasticsearch - Ability to add search
 fields from UI
In-Reply-To: <bug-20388-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20388-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20388-70-kp6b2kRHlH@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20388

Alex Arnaud <alex.arnaud at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff

--- Comment #95 from Alex Arnaud <alex.arnaud at biblibre.com> ---
Patches have been rebased on upon bug 19482 which prevent removing mandatory
fields.

So set back to need signoff.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 28 09:18:10 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 28 Jan 2020 08:18:10 +0000
Subject: [Koha-bugs] [Bug 20388] Elasticsearch - Ability to add search
 fields from UI
In-Reply-To: <bug-20388-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20388-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20388-70-qHv4YeXw0f@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20388

Alex Arnaud <alex.arnaud at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |19482


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19482
[Bug 19482] Elasticsearch - prevent removal / editing of required indexes
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 28 09:18:10 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 28 Jan 2020 08:18:10 +0000
Subject: [Koha-bugs] [Bug 19482] Elasticsearch - prevent removal / editing
 of required indexes
In-Reply-To: <bug-19482-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19482-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19482-70-qbgBMgVDWF@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19482

Alex Arnaud <alex.arnaud at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |20388


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20388
[Bug 20388] Elasticsearch - Ability to add search fields from UI
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 28 09:22:21 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 28 Jan 2020 08:22:21 +0000
Subject: [Koha-bugs] [Bug 7709] Cover Images Template plugin
In-Reply-To: <bug-7709-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-7709-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7709-70-zxEdsw1jyu@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7709

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |josef.moravec at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 28 09:26:26 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 28 Jan 2020 08:26:26 +0000
Subject: [Koha-bugs] [Bug 22543] Patron might be logged in again using
 browser back button
In-Reply-To: <bug-22543-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22543-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22543-70-Cll06btW3a@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22543

--- Comment #32 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Hi David, please report a new security bug.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 28 09:50:37 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 28 Jan 2020 08:50:37 +0000
Subject: [Koha-bugs] [Bug 11530] Recalculating a book's total issue count
 from items.issues or statistics-table with update_totalissues.pl ignores
 deleted_items.
In-Reply-To: <bug-11530-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-11530-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11530-70-couGoOmxxd@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11530

Fridolin SOMERS <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |fridolin.somers at biblibre.co
                   |                            |m

--- Comment #1 from Fridolin SOMERS <fridolin.somers at biblibre.com> ---
Since statistics contains only itemnumber, once item deleted we can not link
this itemnumber to its biblionumber.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 28 10:12:06 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 28 Jan 2020 09:12:06 +0000
Subject: [Koha-bugs] [Bug 20271] Merge deleted biblio, biblioitems,
 biblio_metadata, and items tables
In-Reply-To: <bug-20271-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20271-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20271-70-DSyZtIAaUP@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271

--- Comment #196 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
(In reply to Tomás Cohen Arazi from comment #195)
> (In reply to Jonathan Druart from comment #193)
> > Note for myself:
> > 
> > * comment 182
> > 
> > * comment 183
> > 
> > * comment 184
> > 
> > * deal with reports
> 
> This should be done using DB views. What is the 'deleted' column name we
> picked?

I wanted to try and add an automatic conversion, like we did for
biblio_metadata (bug 17898).
The column is a datetime and is named deleted_on (deleted_at in the first
patches).

> > * my $item_object = Koha::Items->find({barcode => $barcode });
> > => We need to remove the barcode unique index
> 
> We need to rely on the DB to handle barcode uniqueness... we should move the
> barcode to another column, say... deleted_barcode.

If we want to keep the DBMS handle barode uniqueness we will need to discuss
how to deal with that correctly then :)
I do not like moving the column, but maybe we could add a unique constraint on
(barcode, deleted_on).

> > * Prevent regression and deal with Koha::Items->find Koha::Items->search
> > Ideas:
> >   - ->find returns only non-deleted items when ->find_deleted returns only
> > deleted items
> >   - same for ->search, ->search_deleted
> > 
> > Or keep Koha::Old::Items that could inherit from Koha::Items
> > 
> > Or update all the occurrences (how many?)
> 
> On the API I would expect the endpoint to return non-deleted ones as
> default, and I would prefer to handle it explicitly: manually adding deleted
> => 0 to the query. And have ?include_deleted=true and/or ?deleted=true be
> mandatory to get the deleted ones.
> 
> Maybe we could encapsulate this pattern in Koha::Objects::Deleted, which
> extended Koha::Objects with new generic methods: ->search_without_deleted
> 
> I haven't made up my mind yet, but I feel it smells to have ->search have a
> weird behaviour other than the expected.

I like you idea, I will try to have a look at how we can implement it.
Also I think we will need a separate find method.

> I'm also worried how we would handle:
> 
> my $items = $biblio->items;
> 
> so it doesn't return deleted ones.

We deal with that already:
406 sub items {
407     my ($self) = @_;
408 
409     my $items_rs = $self->_result->items->search({ deleted_on => undef });
410 
411     return Koha::Items->_new_from_dbic( $items_rs );
412 }

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 28 10:12:15 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 28 Jan 2020 09:12:15 +0000
Subject: [Koha-bugs] [Bug 22543] Patron might be logged in again using
 browser back button
In-Reply-To: <bug-22543-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22543-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22543-70-JVIHbmyG4u@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22543

David Cook <dcook at prosentient.com.au> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=24524

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 28 10:12:40 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 28 Jan 2020 09:12:40 +0000
Subject: [Koha-bugs] [Bug 22543] Patron might be logged in again using
 browser back button
In-Reply-To: <bug-22543-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22543-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22543-70-BuOgabpXT7@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22543

--- Comment #33 from David Cook <dcook at prosentient.com.au> ---
(In reply to Katrin Fischer from comment #32)
> Hi David, please report a new security bug.

You got it 👍

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 28 10:46:25 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 28 Jan 2020 09:46:25 +0000
Subject: [Koha-bugs] [Bug 23113] members/pay.tt account_grp is not longer
 used
In-Reply-To: <bug-23113-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23113-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23113-70-3FhqRN4Ne9@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23113

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|                            |20.05.00
        released in|                            |
             Status|Passed QA                   |Pushed to master

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 28 10:46:27 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 28 Jan 2020 09:46:27 +0000
Subject: [Koha-bugs] [Bug 23113] members/pay.tt account_grp is not longer
 used
In-Reply-To: <bug-23113-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23113-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23113-70-R5o9PEIzdt@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23113

--- Comment #6 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Nice work everyone!

Pushed to master for 20.05

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 28 10:48:19 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 28 Jan 2020 09:48:19 +0000
Subject: [Koha-bugs] [Bug 18936] Convert issuingrules fields to
 circulation_rules
In-Reply-To: <bug-18936-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18936-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18936-70-Bubw2ZyVtf@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18936

Minna Kivinen <minna.kivinen at hamk.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off
                 CC|                            |minna.kivinen at hamk.fi

--- Comment #95 from Minna Kivinen <minna.kivinen at hamk.fi> ---
Signed-off-by: Minna Kivinen <minna.kivinen at hamk.fi>
Tested following:
- Added several rules for different combinations of patron category and item
type
- Modified rules
- Removed rules
- Added new rules
- Tested functionalities against rules: Hard due date, Loan period, Loans
allowed (total), Renewals allowed (count), No renewal before, Holds allowed
(total)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 28 11:10:25 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 28 Jan 2020 10:10:25 +0000
Subject: [Koha-bugs] [Bug 23493] jquery.dataTables.rowGrouping.js is no
 longer maintained,
 but there is an official DataTables version we could switch to
In-Reply-To: <bug-23493-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23493-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23493-70-NKLUAT20j6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23493

--- Comment #17 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Hmm, 

Removing the commented lines seems sensible.. I'll do that now..

As for the display discrepancy you mention.. I can't seem to replicate that.

https://snipboard.io/1DOacC.jpg (before)
https://snipboard.io/gOLAkD.jpg (after)

There are subtle styling differences (which I'm sure can be resolved at the CSS
level if we want to do so?), but I can't replicate the 'before' you show
without grouping or the after with two "Today's" groupings.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 28 11:13:41 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 28 Jan 2020 10:13:41 +0000
Subject: [Koha-bugs] [Bug 20271] Merge deleted biblio, biblioitems,
 biblio_metadata, and items tables
In-Reply-To: <bug-20271-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20271-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20271-70-RRTYCOERoZ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271

--- Comment #197 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
(In reply to Jonathan Druart from comment #196)
> If we want to keep the DBMS handle barode uniqueness we will need to discuss
> how to deal with that correctly then :)
> I do not like moving the column, but maybe we could add a unique constraint
> on (barcode, deleted_on).

Oops, that cannot work. Unique constraint allows multiple NULL values.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 28 11:20:38 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 28 Jan 2020 10:20:38 +0000
Subject: [Koha-bugs] [Bug 23493] jquery.dataTables.rowGrouping.js is no
 longer maintained,
 but there is an official DataTables version we could switch to
In-Reply-To: <bug-23493-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23493-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23493-70-gCsP6DqxYu@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23493

--- Comment #18 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
I bet you did not sort the column by "due date".
Take a look at the "checked out on" and "due date" column on my screenshots.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 28 11:25:55 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 28 Jan 2020 10:25:55 +0000
Subject: [Koha-bugs] [Bug 24492] Add a 'branch cashup' workflow to the point
 of sale system
In-Reply-To: <bug-24492-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24492-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24492-70-gGgAjwnhg1@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24492

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 28 11:25:59 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 28 Jan 2020 10:25:59 +0000
Subject: [Koha-bugs] [Bug 24492] Add a 'branch cashup' workflow to the point
 of sale system
In-Reply-To: <bug-24492-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24492-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24492-70-veABc5itND@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24492

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #97824|0                           |1
        is obsolete|                            |

--- Comment #2 from David Nind <david at davidnind.com> ---
Created attachment 98019
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98019&action=edit
Bug 24492: Add branch details page

This patch adds a new 'branch details' page to the POS system which
displays a summary of the cash register transactions for a branch
since each register was last cashed up. It also allows for cashing
up individual registers or cashing up all registers at a given branch
in one transaction.

1) Enable the point of sale feature (EnablePointOfSale + UseCashRegister system
preferences)
2) Add a cash register for a library (Home > Point of sale > Cash registers >
New cash register)
3) Add some items that can be purchased (Home > Point of sale > Purchase items
> New debit type)
   . Enter a 'Debit type code', 'Default amount', 'Description', tick 'Can be
manually invoiced?' and 'Can be sold?', and select 'All libraries' for the
'Libraries limitation'
   . Repeat so that you have two or three items
4) Add a sales transaction
   . Home > Point of sale
   . Click on 'Add' next to an item in the 'Items for purchase' area
   . Add another item
   . Under the 'Collect payment' area  enter the amount collected from the
patron
   . Click 'Confirm'
   . Keep a record of the transactions for step 7
   . Repeat and add another sales transaction
5) Go to the Branch details screen - this lists the cash registers for the
branch and allows you to 'Record cashup' either for an individual register all
all registers
6) Click on 'Record cashup' button for the cash register setup in step 2
7) This lists all the transactions - check that transactions match with the
transactions you entered
8) Check that the summary figires match
9) From the cash registers screen check that you can archive and restore a cash
register
10) Form the cash registers screen check that you can change the details for a
cash register
11) Sign-off bug!

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

Signed-off-by: David Nind <david at davidnind.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 28 11:27:14 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 28 Jan 2020 10:27:14 +0000
Subject: [Koha-bugs] [Bug 24519] Change calculation and validation in Point
 of Sale should match Paycollect
In-Reply-To: <bug-24519-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24519-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24519-70-8lqs7AQrSZ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24519

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |13985


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13985
[Bug 13985] Cash Management - Koha as 'Point of Sale'
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 28 11:27:14 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 28 Jan 2020 10:27:14 +0000
Subject: [Koha-bugs] [Bug 13985] Cash Management - Koha as 'Point of Sale'
In-Reply-To: <bug-13985-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13985-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13985-70-DCjJzxDMJx@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13985

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |24519


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24519
[Bug 24519] Change calculation and validation in Point of Sale should match
Paycollect
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 28 11:28:04 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 28 Jan 2020 10:28:04 +0000
Subject: [Koha-bugs] [Bug 22359] Improve usability of 'change calculation'
 (bug 11373)
In-Reply-To: <bug-22359-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22359-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22359-70-zzexfdLyZZ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22359

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|13985                       |


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13985
[Bug 13985] Cash Management - Koha as 'Point of Sale'
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 28 11:28:04 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 28 Jan 2020 10:28:04 +0000
Subject: [Koha-bugs] [Bug 13985] Cash Management - Koha as 'Point of Sale'
In-Reply-To: <bug-13985-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13985-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13985-70-Rttmzcpcct@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13985

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|22359                       |


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22359
[Bug 22359] Improve usability of 'change calculation' (bug 11373)
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 28 11:28:44 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 28 Jan 2020 10:28:44 +0000
Subject: [Koha-bugs] [Bug 24492] Add a 'branch cashup' workflow to the point
 of sale system
In-Reply-To: <bug-24492-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24492-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24492-70-JC8b6dO42E@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24492

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|23355                       |24082


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23355
[Bug 23355] Add 'cashup' process to the accounts system
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24082
[Bug 24082] Add a 'refund' option to anonymous payments
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 28 11:28:44 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 28 Jan 2020 10:28:44 +0000
Subject: [Koha-bugs] [Bug 23355] Add 'cashup' process to the accounts system
In-Reply-To: <bug-23355-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23355-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23355-70-tmpQXtqE4E@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23355

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|24492                       |


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24492
[Bug 24492] Add a 'branch cashup' workflow to the point of sale system
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 28 11:28:44 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 28 Jan 2020 10:28:44 +0000
Subject: [Koha-bugs] [Bug 24082] Add a 'refund' option to anonymous payments
In-Reply-To: <bug-24082-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24082-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24082-70-vHas2VY3yg@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24082

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |24492


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24492
[Bug 24492] Add a 'branch cashup' workflow to the point of sale system
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 28 11:29:09 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 28 Jan 2020 10:29:09 +0000
Subject: [Koha-bugs] [Bug 24082] Add a 'refund' option to anonymous payments
In-Reply-To: <bug-24082-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24082-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24082-70-PbeMZRh9ag@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24082

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|13985                       |


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13985
[Bug 13985] Cash Management - Koha as 'Point of Sale'
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 28 11:29:09 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 28 Jan 2020 10:29:09 +0000
Subject: [Koha-bugs] [Bug 13985] Cash Management - Koha as 'Point of Sale'
In-Reply-To: <bug-13985-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13985-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13985-70-H8BDJ77onC@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13985

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|24082                       |


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24082
[Bug 24082] Add a 'refund' option to anonymous payments
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 28 11:31:39 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 28 Jan 2020 10:31:39 +0000
Subject: [Koha-bugs] [Bug 18936] Convert issuingrules fields to
 circulation_rules
In-Reply-To: <bug-18936-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18936-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18936-70-22FWoZieDn@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18936

Minna Kivinen <minna.kivinen at hamk.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 28 11:35:54 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 28 Jan 2020 10:35:54 +0000
Subject: [Koha-bugs] [Bug 18936] Convert issuingrules fields to
 circulation_rules
In-Reply-To: <bug-18936-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18936-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18936-70-iiLVokq1xn@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18936

--- Comment #96 from Joonas Kylmälä <joonas.kylmala at helsinki.fi> ---
Problems I noticed after doing database upgrade and comparing the web page
before db upgrade and after db upgrade: 

- The "Clone these rules to: " feature is missing after the patch set

- "Holds allowed (daily)" was previously empty now with the patch set it says
"Unlimited"

- "Fine amount" is now with 6 decimals instead of previous 2

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 28 11:36:14 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 28 Jan 2020 10:36:14 +0000
Subject: [Koha-bugs] [Bug 24492] Add a 'branch cashup' workflow to the point
 of sale system
In-Reply-To: <bug-24492-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24492-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24492-70-f1zlye2KNk@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24492

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |david at davidnind.com

--- Comment #3 from David Nind <david at davidnind.com> ---
Created attachment 98020
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98020&action=edit
Bugs 24492 - Screenshot of POS screen

Just a couple of minor points on the screen layout:

- In the items for purchase area the search box and labels are not aligned very
well. This applies to the show entries label as well. (Tested on Google Chrome
and Firefox).

- It may be better to have the 'Confirm' button and 'Cancel' link under the
collect payment section to better fit a normal workflow: add items, enter
payment details then press confirm.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 28 11:42:21 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 28 Jan 2020 10:42:21 +0000
Subject: [Koha-bugs] [Bug 23113] members/pay.tt account_grp is not longer
 used
In-Reply-To: <bug-23113-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23113-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23113-70-TMLjZl6tXi@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23113

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |david at davidnind.com
  Text to go in the|                            |This patch removes markup
      release notes|                            |that is no longer required
                   |                            |in the pay.tt template
                   |                            |(this template is used in
                   |                            |the accounting section for
                   |                            |patrons).

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 28 11:50:19 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 28 Jan 2020 10:50:19 +0000
Subject: [Koha-bugs] [Bug 18936] Convert issuingrules fields to
 circulation_rules
In-Reply-To: <bug-18936-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18936-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18936-70-gkyEnI3BwO@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18936

--- Comment #97 from Joonas Kylmälä <joonas.kylmala at helsinki.fi> ---
(In reply to Joonas Kylmälä from comment #96)
> - "Holds allowed (daily)" was previously empty now with the patch set it
> says "Unlimited"

This is fine, the empty value previously also meant "Unlimited", here it is
just made explicit.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 28 11:55:13 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 28 Jan 2020 10:55:13 +0000
Subject: [Koha-bugs] [Bug 20271] Merge deleted biblio, biblioitems,
 biblio_metadata, and items tables
In-Reply-To: <bug-20271-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20271-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20271-70-COth5wW6jZ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |In Discussion

--- Comment #198 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
As we are going to face this situation for some other tables as well (at least
columns borrowers.cardnumber, borrowers.userid, issues.itemnumber), I think we
need an approach that will work and be named identically for them.

We could have a boolean flag is_deleted, in addition of deleted_on that
contains an important info. The problem is that it will not work either, as:
The following situation should be valid but will fail the unique constraint:
(id, is_deleted)
(42, 1)
(42, 0)
(42, 0)

So we could have a nullable is_not_deleted:
(id, is_not_deleted)
(42, 1)
(42, NULL)
(42, NULL)
The work but it will not be a boolean, as 0 will not be a "valid" value (not a
big deal anyway).

"is_not_deleted" is not ideal, maybe is_alive? is_current? naming suggestions?

We will not be able to confirm the data integrity between this new column and
deleted_on. But that seems easy to handle at code level.

Note that Postgres can deal with a WHERE clause on a unique constraint. Also
that CHECK could be helpful here, but we need it to be present in the stable
versions of the DBMS we support.

Something else to suggest?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 28 12:54:01 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 28 Jan 2020 11:54:01 +0000
Subject: [Koha-bugs] [Bug 23173] ILL should be able to search third party
 sources prior to request creation
In-Reply-To: <bug-23173-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23173-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23173-70-ibufa3ga0A@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23173

--- Comment #31 from Andrew Isherwood <andrew.isherwood at ptfs-europe.com> ---
The test plans says "Create an article FreeForm request containing a valid DOI
(ideally one that you know Unpaywall is aware of)", it turns out finding a DOI
that Unpaywall is aware of is harder than you think, so:

10.1038/nature12373

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 28 13:01:18 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 28 Jan 2020 12:01:18 +0000
Subject: [Koha-bugs] [Bug 23463] Move C4::Items CRUD subroutines to
 Koha::Item
In-Reply-To: <bug-23463-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23463-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23463-70-NdUMVhIQOg@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23463

--- Comment #65 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
(In reply to Tomás Cohen Arazi from comment #64)
> About the timestamp handling: shouldn't we better implement
> Koha::Object->set_and_store of similar, that instead of overwriting the
> whole object, just sets the really changed fields, and we leave the DB do
> the heavy lifting? It looks wrong (as you also say, Jonathan) to be setting
> the timestamp manually on the ->store method (be it in the Koha::Item class,
> or as a generic approach in Koha::Object)

I have added a follow-up to the branch. Still not optimal however.
I am on a "less regressions as possible" approach here. We will certainly
want/need to improve later.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 28 13:03:20 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 28 Jan 2020 12:03:20 +0000
Subject: [Koha-bugs] [Bug 20271] Merge deleted biblio, biblioitems,
 biblio_metadata, and items tables
In-Reply-To: <bug-20271-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20271-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20271-70-QEC5xn0uzk@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271

--- Comment #199 from Ere Maijala <ere.maijala at helsinki.fi> ---
Stuff something like '$$DELETED$$' . <id field> or UUID::uuid() in any unique
fields upon deletion?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 28 13:16:03 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 28 Jan 2020 12:16:03 +0000
Subject: [Koha-bugs] [Bug 24348] Record matching rules: required match
 checks does not work
In-Reply-To: <bug-24348-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24348-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24348-70-Nnek6MIAZi@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24348

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 28 13:16:06 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 28 Jan 2020 12:16:06 +0000
Subject: [Koha-bugs] [Bug 24348] Record matching rules: required match
 checks does not work
In-Reply-To: <bug-24348-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24348-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24348-70-i2a7dHC9Qs@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24348

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #97993|0                           |1
        is obsolete|                            |

--- Comment #5 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 98021
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98021&action=edit
Bug 24348: Pass marc record to _passes_required_checks

Test plan:

* Add record matching rule:

 Matching rule code: test
 Description: 001 and 003
 Match threshold: 1000
 Record type: Bibliografic record

 Match points:
    Search index: Control-number
    Score: 1000
    Tag: 001
    Subfields:
    Offset:
    Length:
    Normalization rule: none

 Required match checks:

    Source (incoming) record check field

    Tag: 003
    Subfields:
    Offset:
    Length:
    Normalization rule: none

    Target (database) record check field

    Tag: 003
    Subfields:
    Offset:
    Length:
    Normalization rule: none

* Note the match rule identity number.
* Stage a marc-file for import, for instance this one
ftp://ftp.libris.kb.se/pub/export2/X/marc/X.20200104.marc

sudo /usr/sbin/koha-shell -c "perl /home/vagrant/kohaclone/misc/stage_file.pl
--match 4 --file 'X.20200104.marc' --format ISO2709 --comment 'test'" kohadev

* Note the batch number and commit the file using the batch number:

sudo /usr/sbin/koha-shell -c "perl /home/vagrant/kohaclone/misc/commit_file.pl
--batch-number 1" kohadev

* Again, stage the same marc-file  for import:

sudo /usr/sbin/koha-shell -c "perl /home/vagrant/kohaclone/misc/stage_file.pl
--match 4 --file 'X.20200104.marc' --format ISO2709 --comment 'test'" kohadev

* Note the number of records matched.

Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
I did not test, trusting author and SO. Changes make perfect sense to
me.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 28 13:23:07 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 28 Jan 2020 12:23:07 +0000
Subject: [Koha-bugs] [Bug 20847] Add more fields to the Batch Patron
 Modification tool
In-Reply-To: <bug-20847-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20847-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20847-70-yv8FhbRL5t@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20847

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 28 13:23:10 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 28 Jan 2020 12:23:10 +0000
Subject: [Koha-bugs] [Bug 20847] Add more fields to the Batch Patron
 Modification tool
In-Reply-To: <bug-20847-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20847-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20847-70-nKkETIM0T4@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20847

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #97890|0                           |1
        is obsolete|                            |

--- Comment #8 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 98022
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98022&action=edit
Bug 20847: Add more fields to the Batch Patron Modification tool

This patch adds streetnumber, address, address2, phone and mobile to the
Batch Patron Modify form, also moves Primary email to a more logical
place on the page

To test:

1) Install patch
2) Open Batch Patron Modification tool, and input a borrowernumber to
edit
3) Add some data into the streetnumber, address, address2, phone and
mobile fields and click Save
4) These fields in the user record should now contain your data
5) Test that running the tool again with the option to delete the data
clears the fields correctly
6) Repeat steps 1-5 with a file of user borrowernumbers

Signed-off-by: Daniel J <daniel.jones at cheshiresharedservices.gov.uk>

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Amended patch: replace tab with 4 spaces.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 28 13:24:07 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 28 Jan 2020 12:24:07 +0000
Subject: [Koha-bugs] [Bug 20847] Add more fields to the Batch Patron
 Modification tool
In-Reply-To: <bug-20847-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20847-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20847-70-zfbCx5avfH@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20847

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org

--- Comment #9 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
I amended the patch to pass the QA script


 FAIL   tools/modborrowers.pl
   FAIL   forbidden patterns
                forbidden pattern: tab char (line 211)
                forbidden pattern: tab char (line 213)
                forbidden pattern: tab char (line 216)
                forbidden pattern: tab char (line 217)
                forbidden pattern: tab char (line 221)


Processing additional checks

        * Commit title does not start with 'Bug XXXXX: ' - 513e8dd09b


David, you should edit your editor's preferences to make it uses spaces instead
of tabulations.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 28 13:25:11 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 28 Jan 2020 12:25:11 +0000
Subject: [Koha-bugs] [Bug 24428] Elasticsearch index does not contain
 consistent item information
In-Reply-To: <bug-24428-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24428-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24428-70-kkowEPkkin@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24428

--- Comment #8 from Nick Clemens <nick at bywatersolutions.com> ---
(In reply to david holoshka from comment #7) 
> We have several modifications to koha that depended on finding organized
> item information in the es index. 

Hi David,

Are these modifications available to the community in bugzilla or github so
that we can see how they work?

We are striving to improve the Elasticsearch functionality and most of the work
has been put into efforts to improve the basic search functionality. While we
have talked about using ES as a data store, we have not focused on this area
yet, which is why I think we would call this an enhancement.

Classifying it this way doesn't mean we don't think it is important or
necessary, just that it doesn't break the features built in to Koha at this
time.

I would try switching the system preference ElasticsearchMARCFormat as Ere
mentions, as this indexes the full marc record as a searchable array and may
help with your issue.

-Nick

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 28 13:33:28 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 28 Jan 2020 12:33:28 +0000
Subject: [Koha-bugs] [Bug 24296] Move stock rotation transfer triggers from
 `comments` to `trigger`
In-Reply-To: <bug-24296-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24296-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24296-70-8nI1x8tfis@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24296

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Patch doesn't apply
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org

--- Comment #9 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
CONFLICT (content): Merge conflict in t/db_dependent/StockRotationItems.t
CONFLICT (content): Merge conflict in Koha/StockRotationItem.pm

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 28 13:34:32 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 28 Jan 2020 12:34:32 +0000
Subject: [Koha-bugs] [Bug 24296] Move stock rotation transfer triggers from
 `comments` to `trigger`
In-Reply-To: <bug-24296-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24296-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24296-70-ixISsA0QQE@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24296

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #97518|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 28 13:34:44 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 28 Jan 2020 12:34:44 +0000
Subject: [Koha-bugs] [Bug 24296] Move stock rotation transfer triggers from
 `comments` to `trigger`
In-Reply-To: <bug-24296-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24296-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24296-70-2uubXrqyWs@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24296

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Patch doesn't apply         |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 28 13:35:26 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 28 Jan 2020 12:35:26 +0000
Subject: [Koha-bugs] [Bug 24296] Move stock rotation transfer triggers from
 `comments` to `trigger`
In-Reply-To: <bug-24296-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24296-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24296-70-LymtEtLvGg@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24296

--- Comment #10 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
(In reply to Jonathan Druart from comment #9)
> CONFLICT (content): Merge conflict in t/db_dependent/StockRotationItems.t
> CONFLICT (content): Merge conflict in Koha/StockRotationItem.pm

Forget that, a previous patch was not obsoleted.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 28 13:36:30 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 28 Jan 2020 12:36:30 +0000
Subject: [Koha-bugs] [Bug 20271] Merge deleted biblio, biblioitems,
 biblio_metadata, and items tables
In-Reply-To: <bug-20271-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20271-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20271-70-7XdrkYCFj9@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271

--- Comment #200 from Kyle M Hall <kyle at bywatersolutions.com> ---
> We could have a boolean flag is_deleted, in addition of deleted_on that
> contains an important info. The problem is that it will not work either, as:
> The following situation should be valid but will fail the unique constraint:
> (id, is_deleted)
> (42, 1)
> (42, 0)
> (42, 0)

I don't think I understand what scenario would create a situation such as this,
could you elaborate?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 28 13:44:37 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 28 Jan 2020 12:44:37 +0000
Subject: [Koha-bugs] [Bug 6976] User hold limit can be avoided by users in
 OPAC
In-Reply-To: <bug-6976-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-6976-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-6976-70-IV8iwTSNE1@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6976

--- Comment #33 from Nick Clemens <nick at bywatersolutions.com> ---
(In reply to Nick Clemens from comment #32)
> (In reply to Nick Clemens from comment #31)
> > (In reply to Jonathan Druart from comment #30)
> > > Still valid.
> > 
> > I cannot recreate.
> > 
> > Set an All/All/All rule for limit 2 holds, do a search, select all, place
> > hold - user gets two holds
> > 
> > Cancel those
> > 
> > Set maxreserves to 1
> > Search - select all - place hold - warning that I can only select one -
> > error if I try to place all holds
> 
> NVM, set ReservesControlBranch to 'Items home library'

This may be fixed in 19.05+, I cannot recreate, can someone confirm?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 28 13:49:18 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 28 Jan 2020 12:49:18 +0000
Subject: [Koha-bugs] [Bug 20271] Merge deleted biblio, biblioitems,
 biblio_metadata, and items tables
In-Reply-To: <bug-20271-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20271-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20271-70-tZ6BvruUBu@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271

--- Comment #201 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
(In reply to Kyle M Hall from comment #200)
> > We could have a boolean flag is_deleted, in addition of deleted_on that
> > contains an important info. The problem is that it will not work either, as:
> > The following situation should be valid but will fail the unique constraint:
> > (id, is_deleted)
> > (42, 1)
> > (42, 0)
> > (42, 0)
> 
> I don't think I understand what scenario would create a situation such as
> this, could you elaborate?

Sorry, wrong copy/paste, it was the reverse:
(id, is_deleted)
(42, 0)
(42, 1)
(42, 1)
So barcode=42 can appear several times, but only once with is_deleted=0.
Result is the same, the constraint will fail.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 28 13:55:43 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 28 Jan 2020 12:55:43 +0000
Subject: [Koha-bugs] [Bug 24287] Transfers should record how they were
 triggered.
In-Reply-To: <bug-24287-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24287-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24287-70-M110rSEqfH@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24287

--- Comment #6 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 98023
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98023&action=edit
Bug 24287: Add `reason` to `branchtransfers`

This patch adds the `reason` field to the `branchtransfers` table to
record what triggered a transfer.

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 28 13:56:18 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 28 Jan 2020 12:56:18 +0000
Subject: [Koha-bugs] [Bug 24296] Move stock rotation transfer triggers from
 `comments` to `trigger`
In-Reply-To: <bug-24296-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24296-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24296-70-yXDG7veTjj@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24296

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #97533|0                           |1
        is obsolete|                            |

--- Comment #11 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 98024
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98024&action=edit
Bug 24296: Update existing data in the database

This DB udpate adds the stockration states to the trigger enum in the
branchtransfers table and then populates it with any such data currently
contained within the comments field.

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 28 13:56:21 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 28 Jan 2020 12:56:21 +0000
Subject: [Koha-bugs] [Bug 24296] Move stock rotation transfer triggers from
 `comments` to `trigger`
In-Reply-To: <bug-24296-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24296-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24296-70-PSxThY5ZkI@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24296

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #97534|0                           |1
        is obsolete|                            |

--- Comment #12 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 98025
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98025&action=edit
Bug 24296: Update stockrotation process to use branchtransfers.reason

This patch updates all occurences of stockrotation related lookups of
branchtransfers status from using the 'comments' field to using the new
'reason' field.

Test plan:
1) Work through the process of creating a stock rotation plan and adding
   items to the plan.. no errors should be encoutered during this process.
2) Run the stockrotation cronjob to move some items on.. no errors
   should be encountered.

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 28 13:56:42 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 28 Jan 2020 12:56:42 +0000
Subject: [Koha-bugs] [Bug 24287] Transfers should record how they were
 triggered.
In-Reply-To: <bug-24287-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24287-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24287-70-sYnrPr8Bo8@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24287

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 28 13:56:52 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 28 Jan 2020 12:56:52 +0000
Subject: [Koha-bugs] [Bug 24287] Transfers should record how they were
 triggered.
In-Reply-To: <bug-24287-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24287-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24287-70-R6xlrsM0mT@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24287

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #97532|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 28 13:56:57 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 28 Jan 2020 12:56:57 +0000
Subject: [Koha-bugs] [Bug 24296] Move stock rotation transfer triggers from
 `comments` to `trigger`
In-Reply-To: <bug-24296-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24296-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24296-70-gnvChEYtea@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24296

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 28 14:40:06 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 28 Jan 2020 13:40:06 +0000
Subject: [Koha-bugs] [Bug 24428] Elasticsearch index does not contain
 consistent item information
In-Reply-To: <bug-24428-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24428-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24428-70-NVIqRclwTW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24428

--- Comment #9 from david holoshka <david.holoshka at ub.lu.se> ---
Hi Nick,

Does this mean you are not against making the es index backward compatible ? 

I also noticed that my code broke because the marc record in es is now in some
encoded format (or in some cases marcxml)  instead of json.  

I will work on a patch for the indexer to make it backward compatible.  We will
try to add es 6.5 support with aliasing to make index rebuilds possible during
working hours.  We are setting the default for marc to marcxml as it is easier
to debug.  I guess the base64 format uses a little less space.

Thanks for considering this problem.

Best Regards,
David

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 28 14:43:33 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 28 Jan 2020 13:43:33 +0000
Subject: [Koha-bugs] [Bug 24428] Elasticsearch index does not contain
 consistent item information
In-Reply-To: <bug-24428-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24428-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24428-70-2u55hv0Muj@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24428

--- Comment #10 from Ere Maijala <ere.maijala at helsinki.fi> ---
David, please see comment #6. There's no need to to additional work.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 28 14:51:44 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 28 Jan 2020 13:51:44 +0000
Subject: [Koha-bugs] [Bug 24338] CASH is missing from the default
 payment_types
In-Reply-To: <bug-24338-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24338-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24338-70-3C33R9003X@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24338

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |andrew at bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 28 14:53:59 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 28 Jan 2020 13:53:59 +0000
Subject: [Koha-bugs] [Bug 23355] Add 'cashup' process to the accounts system
In-Reply-To: <bug-23355-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23355-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23355-70-0DIvDs5uom@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23355

--- Comment #82 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 98026
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98026&action=edit
Bug 24082: Add `anonymous_refund` permission to `cash_management`

This patch adds the new `anonymous_refund` permission to the
`cash_management` flag and binds it to the visability of the register
details page.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 28 14:54:03 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 28 Jan 2020 13:54:03 +0000
Subject: [Koha-bugs] [Bug 23355] Add 'cashup' process to the accounts system
In-Reply-To: <bug-23355-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23355-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23355-70-YqHpEpjQJf@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23355

--- Comment #83 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 98027
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98027&action=edit
Bug 24082: Add refund action to relevant lines

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 28 14:54:06 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 28 Jan 2020 13:54:06 +0000
Subject: [Koha-bugs] [Bug 23355] Add 'cashup' process to the accounts system
In-Reply-To: <bug-23355-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23355-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23355-70-QgxjwbneXe@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23355

--- Comment #84 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 98028
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98028&action=edit
Bug 24082: Add access to historical transactions

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 28 15:00:54 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 28 Jan 2020 14:00:54 +0000
Subject: [Koha-bugs] [Bug 24525] New: Hide SIP payment types from the Point
 of Sale page
Message-ID: <bug-24525-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24525

            Bug ID: 24525
           Summary: Hide SIP payment types from the Point of Sale page
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Fines and fees
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: martin.renvoize at ptfs-europe.com
        QA Contact: testopia at bugs.koha-community.org

Bug 24339 adds the SIP2 payment_types to the default installed values for the
payment type authorized values and also hides these values from appearing in
the select boxes in paycollect.. however, the new Point of Sale screen was
missed.

This bug will take care of removing the SIP payment type from the payment type
select options on the point of sale screen.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 28 15:01:16 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 28 Jan 2020 14:01:16 +0000
Subject: [Koha-bugs] [Bug 24525] Hide SIP payment types from the Point of
 Sale page
In-Reply-To: <bug-24525-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24525-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24525-70-khaec0AMuu@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24525

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |24339, 23354


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23354
[Bug 23354] Add a 'Pay' screen to allow anonymous payments in a POS fashion
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24339
[Bug 24339] SIP codes are missing from the default payment_types on
installation
-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 28 15:01:16 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 28 Jan 2020 14:01:16 +0000
Subject: [Koha-bugs] [Bug 23354] Add a 'Pay' screen to allow anonymous
 payments in a POS fashion
In-Reply-To: <bug-23354-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23354-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23354-70-MwDp6Ax1fE@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23354

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |24525


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24525
[Bug 24525] Hide SIP payment types from the Point of Sale page
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 28 15:01:16 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 28 Jan 2020 14:01:16 +0000
Subject: [Koha-bugs] [Bug 24339] SIP codes are missing from the default
 payment_types on installation
In-Reply-To: <bug-24339-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24339-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24339-70-86Tfsncnbc@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24339

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |24525


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24525
[Bug 24525] Hide SIP payment types from the Point of Sale page
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 28 15:01:21 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 28 Jan 2020 14:01:21 +0000
Subject: [Koha-bugs] [Bug 24525] Hide SIP payment types from the Point of
 Sale page
In-Reply-To: <bug-24525-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24525-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24525-70-yiVkRKz303@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24525

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |martin.renvoize at ptfs-europe
                   |ity.org                     |.com

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 28 15:01:49 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 28 Jan 2020 14:01:49 +0000
Subject: [Koha-bugs] [Bug 24485] Sys Pref AllowHoldPolicyOverride will not
 Staff override a Holds Per Record Rule
In-Reply-To: <bug-24485-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24485-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24485-70-WuRjDjsGhy@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24485

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 28 15:01:59 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 28 Jan 2020 14:01:59 +0000
Subject: [Koha-bugs] [Bug 24485] Sys Pref AllowHoldPolicyOverride will not
 Staff override a Holds Per Record Rule
In-Reply-To: <bug-24485-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24485-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24485-70-KeMgMsJYbO@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24485

--- Comment #2 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 98032
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98032&action=edit
Bug 24485: Allow hold when some can be overridden

The check to see if we can place a hold counts the number that we can override
vs the number of items on the record.

We cannot override if we already have a hold on an item, however, we don't
count these to see if they plus
the number of overrides equal the items on the record.

To test:
1 - Set max reserves to 2, allow 2 holds per recrod
2 - Place 2 holds for a patron on some records
3 - Find another record with 2 items
4 - Place a hold on the first item, you will be notified about the limit but
you can override
5 - Attempt to place hold on second item, cannot be done, button disabled
6 - Apply patch
7 - Repeat
8 - You can place the second hold

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 28 15:02:43 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 28 Jan 2020 14:02:43 +0000
Subject: [Koha-bugs] [Bug 14784] Missing checkin message for debarred
 patrons when issuing rules 'fine days = 0'
In-Reply-To: <bug-14784-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14784-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14784-70-ijkSYIaxs3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14784

Arthur Suzuki <arthur.suzuki at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |arthur.suzuki at biblibre.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 28 15:03:41 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 28 Jan 2020 14:03:41 +0000
Subject: [Koha-bugs] [Bug 24485] Sys Pref AllowHoldPolicyOverride will not
 Staff override a Holds Per Record Rule
In-Reply-To: <bug-24485-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24485-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24485-70-nRCxU69kZA@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24485

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Version|19.05                       |master
           Severity|minor                       |normal
                 CC|                            |tomascohen at gmail.com
           Assignee|koha-bugs at lists.koha-commun |nick at bywatersolutions.com
                   |ity.org                     |

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 28 15:06:43 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 28 Jan 2020 14:06:43 +0000
Subject: [Koha-bugs] [Bug 24448] Add Koha::Biblio->subscriptions_count
In-Reply-To: <bug-24448-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24448-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24448-70-GHwweBEPvP@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24448

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 28 15:06:47 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 28 Jan 2020 14:06:47 +0000
Subject: [Koha-bugs] [Bug 24448] Add Koha::Biblio->subscriptions_count
In-Reply-To: <bug-24448-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24448-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24448-70-aSJPPqKw9Z@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24448

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #97571|0                           |1
        is obsolete|                            |
  Attachment #97572|0                           |1
        is obsolete|                            |

--- Comment #11 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 98033
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98033&action=edit
Bug 24448: Unit tests

This patch adds tests for the new method to be introduced. It also moves
the tests for Koha::Biblio->subscriptions to the Biblio.t where it
really belongs.

To test, run this tests along with the patch implementing the new
method.

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 28 15:06:52 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 28 Jan 2020 14:06:52 +0000
Subject: [Koha-bugs] [Bug 24448] Add Koha::Biblio->subscriptions_count
In-Reply-To: <bug-24448-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24448-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24448-70-u0AnyzipZE@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24448

--- Comment #12 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 98034
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98034&action=edit
Bug 24448: Add Koha::Biblio->subscriptions_count

This patch adds the handy subscriptions_count method to the Koha::Biblio
class. It is intended to be used as a shortcut for

    $biblio->subscriptions->count

in places like the API where we can embed the output of a method.

To test:
1. Apply this patches
2. Run:
   $ kshell
  k$ prove t/db_dependent/Koha/Biblio.t \
           t/db_dependent/Koha/Biblios.t
=> SUCCESS: Tests pass! i.e. Biblios.t still passes, and the tests for
the new method in Biblio.t pass as well.
3. Sign off :-D

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 28 15:06:53 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 28 Jan 2020 14:06:53 +0000
Subject: [Koha-bugs] [Bug 24525] Hide SIP payment types from the Point of
 Sale page
In-Reply-To: <bug-24525-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24525-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24525-70-4TfUJSe6yn@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24525

--- Comment #1 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 98035
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98035&action=edit
Bug 24525: Remove SIP payment types from point of sale

This patch removes the SIP payments types from displaying in the select
options on the point of sale payment page.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 28 15:06:56 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 28 Jan 2020 14:06:56 +0000
Subject: [Koha-bugs] [Bug 24448] Add Koha::Biblio->subscriptions_count
In-Reply-To: <bug-24448-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24448-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24448-70-6gDBDNk5S0@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24448

--- Comment #13 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 98036
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98036&action=edit
Bug 24448: Adding a notice to tell the _count methods are temporary

See bug 24467. You are allowed to flog tcohen with an RJ45 cable if this
is not fixed in the next months.

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 28 15:07:34 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 28 Jan 2020 14:07:34 +0000
Subject: [Koha-bugs] [Bug 24525] Hide SIP payment types from the Point of
 Sale page
In-Reply-To: <bug-24525-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24525-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24525-70-lSlRGgWYiW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24525

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|24339, 23354                |24338


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23354
[Bug 23354] Add a 'Pay' screen to allow anonymous payments in a POS fashion
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24338
[Bug 24338] CASH is missing from the default payment_types
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24339
[Bug 24339] SIP codes are missing from the default payment_types on
installation
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 28 15:07:34 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 28 Jan 2020 14:07:34 +0000
Subject: [Koha-bugs] [Bug 23354] Add a 'Pay' screen to allow anonymous
 payments in a POS fashion
In-Reply-To: <bug-23354-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23354-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23354-70-ETXNatziQV@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23354

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|24525                       |


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24525
[Bug 24525] Hide SIP payment types from the Point of Sale page
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 28 15:07:34 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 28 Jan 2020 14:07:34 +0000
Subject: [Koha-bugs] [Bug 24338] CASH is missing from the default
 payment_types
In-Reply-To: <bug-24338-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24338-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24338-70-GOTFV35pgG@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24338

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |24525


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24525
[Bug 24525] Hide SIP payment types from the Point of Sale page
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 28 15:07:34 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 28 Jan 2020 14:07:34 +0000
Subject: [Koha-bugs] [Bug 24339] SIP codes are missing from the default
 payment_types on installation
In-Reply-To: <bug-24339-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24339-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24339-70-XIaDmP2ghl@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24339

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|24525                       |


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24525
[Bug 24525] Hide SIP payment types from the Point of Sale page
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 28 15:08:06 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 28 Jan 2020 14:08:06 +0000
Subject: [Koha-bugs] [Bug 24525] Hide SIP payment types from the Point of
 Sale page
In-Reply-To: <bug-24525-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24525-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24525-70-LRpx8KYHk1@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24525

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |23354, 24339


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23354
[Bug 23354] Add a 'Pay' screen to allow anonymous payments in a POS fashion
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24339
[Bug 24339] SIP codes are missing from the default payment_types on
installation
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 28 15:08:06 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 28 Jan 2020 14:08:06 +0000
Subject: [Koha-bugs] [Bug 23354] Add a 'Pay' screen to allow anonymous
 payments in a POS fashion
In-Reply-To: <bug-23354-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23354-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23354-70-U5k4URIRCR@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23354

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |24525


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24525
[Bug 24525] Hide SIP payment types from the Point of Sale page
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 28 15:08:06 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 28 Jan 2020 14:08:06 +0000
Subject: [Koha-bugs] [Bug 24339] SIP codes are missing from the default
 payment_types on installation
In-Reply-To: <bug-24339-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24339-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24339-70-sy6G0AdwWM@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24339

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |24525


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24525
[Bug 24525] Hide SIP payment types from the Point of Sale page
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 28 15:08:32 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 28 Jan 2020 14:08:32 +0000
Subject: [Koha-bugs] [Bug 24372] Elasticsearch - cannot search for titles
 containing a colon next to a search term using the colon
In-Reply-To: <bug-24372-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24372-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24372-70-xFbG1KmwED@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24372

Marjorie Barry-Vila <marjorie.barry-vila at collecto.ca> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |marjorie.barry-vila at collect
                   |                            |o.ca

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 28 15:09:36 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 28 Jan 2020 14:09:36 +0000
Subject: [Koha-bugs] [Bug 24525] Hide SIP payment types from the Point of
 Sale page
In-Reply-To: <bug-24525-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24525-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24525-70-qAun7jkZv3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24525

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |13985


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13985
[Bug 13985] Cash Management - Koha as 'Point of Sale'
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 28 15:09:36 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 28 Jan 2020 14:09:36 +0000
Subject: [Koha-bugs] [Bug 13985] Cash Management - Koha as 'Point of Sale'
In-Reply-To: <bug-13985-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13985-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13985-70-TAeBdwwhbK@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13985

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |24525


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24525
[Bug 24525] Hide SIP payment types from the Point of Sale page
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 28 15:10:23 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 28 Jan 2020 14:10:23 +0000
Subject: [Koha-bugs] [Bug 24472] Add ability to log changes to hold
 suspensions to action logs
In-Reply-To: <bug-24472-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24472-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24472-70-5BttnAvlXM@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24472

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |DUPLICATE
             Status|NEW                         |RESOLVED

--- Comment #1 from Kyle M Hall <kyle at bywatersolutions.com> ---


*** This bug has been marked as a duplicate of bug 14642 ***

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 28 15:10:23 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 28 Jan 2020 14:10:23 +0000
Subject: [Koha-bugs] [Bug 14642] Add logging of hold modifications
In-Reply-To: <bug-14642-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14642-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14642-70-01PTvyuSOr@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14642

--- Comment #30 from Kyle M Hall <kyle at bywatersolutions.com> ---
*** Bug 24472 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 28 15:10:26 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 28 Jan 2020 14:10:26 +0000
Subject: [Koha-bugs] [Bug 24525] Hide SIP payment types from the Point of
 Sale page
In-Reply-To: <bug-24525-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24525-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24525-70-3YxgnKKuKW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24525

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 28 15:10:34 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 28 Jan 2020 14:10:34 +0000
Subject: [Koha-bugs] [Bug 24525] Hide SIP payment types from the Point of
 Sale page
In-Reply-To: <bug-24525-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24525-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24525-70-Xe2LNiJFQ7@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24525

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|enhancement                 |normal

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 28 15:29:39 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 28 Jan 2020 14:29:39 +0000
Subject: [Koha-bugs] [Bug 24526] Auto renewal cronjob should have verbose
 and test mode options
In-Reply-To: <bug-24526-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24526-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24526-70-zU4Yar9hP2@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24526

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |nick at bywatersolutions.com
                   |ity.org                     |

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 28 15:30:04 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 28 Jan 2020 14:30:04 +0000
Subject: [Koha-bugs] [Bug 24526] Auto renewal cronjob should have verbose
 and test mode options
In-Reply-To: <bug-24526-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24526-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24526-70-rOMyxgWKu8@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24526

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff
   Patch complexity|---                         |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 28 15:30:07 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 28 Jan 2020 14:30:07 +0000
Subject: [Koha-bugs] [Bug 24526] Auto renewal cronjob should have verbose
 and test mode options
In-Reply-To: <bug-24526-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24526-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24526-70-731SgU6EtR@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24526

--- Comment #1 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 98037
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98037&action=edit
Bug 24526: Add verbose and commit options to automatic_renewals cronjob

To test:
 1 - Apply patch
 2 - Have some items marked for auto-renewal
 3 - Run the job with no parameters
 4 - It should print 'Test mode'
 5 - Provide -v
 6 - It should print 'Test mode' then a line for each item
 7 - Provide -v -c
 8 - It should not say test mode, but should provide a line for each item
 9 - Provide -c
10 - Shoudl run as expected with no output

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 28 15:32:23 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 28 Jan 2020 14:32:23 +0000
Subject: [Koha-bugs] [Bug 24526] Auto renewal cronjob should have verbose
 and test mode options
In-Reply-To: <bug-24526-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24526-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24526-70-5CQJmc8Flp@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24526

Andrew Fuerste-Henry <andrew at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |andrew at bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 28 15:36:30 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 28 Jan 2020 14:36:30 +0000
Subject: [Koha-bugs] [Bug 18936] Convert issuingrules fields to
 circulation_rules
In-Reply-To: <bug-18936-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18936-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18936-70-zt1HaRoDei@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18936

--- Comment #98 from Joonas Kylmälä <joonas.kylmala at helsinki.fi> ---
Even though it should be allowed, I get this error message when making a hold
for Student patron for Music item: "Daily hold limit reached for patron".

I have rules:

category = Student, itemtype = Music, Holds allowed (daily) = Unlimited

and

category = All, itemtype = ALL, Holds allowed (daily) = 0

If for the latter "All rule" I change it to 1 then things work.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 28 16:02:05 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 28 Jan 2020 15:02:05 +0000
Subject: [Koha-bugs] [Bug 17697] Improve NotesBlacklist system preference
 description to make clear where it will apply
In-Reply-To: <bug-17697-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17697-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17697-70-o5sgx4HDfz@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17697

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org

--- Comment #5 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Can I add a br tag before the last sentence?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 28 16:04:23 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 28 Jan 2020 15:04:23 +0000
Subject: [Koha-bugs] [Bug 24527] New: misc/cronjobs/update_totalissues.pl
 problem with multiple items
Message-ID: <bug-24527-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24527

            Bug ID: 24527
           Summary: misc/cronjobs/update_totalissues.pl problem with
                    multiple items
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: major
          Priority: P5 - low
         Component: Command-line Utilities
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: fridolin.somers at biblibre.com
        QA Contact: testopia at bugs.koha-community.org
                CC: robin at catalyst.net.nz

misc/cronjobs/update_totalissues.pl when issuing statistics table has a problem
for biblio with multiple items.
The first SQL query gets the biblios linked to items with issues in statistics
:

SELECT biblio.biblionumber, COUNT(statistics.itemnumber) FROM biblio LEFT JOIN
items ON (biblio.biblionumber=items.biblionumber) LEFT JOIN statistics ON
(items.itemnumber=statistics.itemnumber) WHERE statistics.type = 'issue' $limit
GROUP BY biblio.biblionumber

The second SQL query is :
SELECT biblio.biblionumber, 0 FROM biblio LEFT JOIN items ON
(biblio.biblionumber=items.biblionumber) LEFT JOIN statistics ON
(items.itemnumber=statistics.itemnumber) WHERE statistics.itemnumber IS NULL
GROUP BY biblio.biblionumber

The problem is that this second query will set to 0 where ANY item has no entry
in statistics table.

I think the best fix is to use "WHERE statistics.type = 'issue'" inside que
JOIN :
LEFT JOIN statistics ON (items.itemnumber=statistics.itemnumber AND
statistics.type = 'issue')

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 28 16:06:31 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 28 Jan 2020 15:06:31 +0000
Subject: [Koha-bugs] [Bug 24287] Transfers should record how they were
 triggered.
In-Reply-To: <bug-24287-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24287-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24287-70-WaGebhjJu9@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24287

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|                            |20.05.00
        released in|                            |
             Status|Passed QA                   |Pushed to master

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 28 16:06:33 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 28 Jan 2020 15:06:33 +0000
Subject: [Koha-bugs] [Bug 24287] Transfers should record how they were
 triggered.
In-Reply-To: <bug-24287-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24287-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24287-70-Ell6PxmzxE@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24287

--- Comment #7 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Nice work everyone!

Pushed to master for 20.05

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 28 16:06:35 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 28 Jan 2020 15:06:35 +0000
Subject: [Koha-bugs] [Bug 24296] Move stock rotation transfer triggers from
 `comments` to `trigger`
In-Reply-To: <bug-24296-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24296-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24296-70-aRxyfXXv6D@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24296

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|                            |20.05.00
        released in|                            |
             Status|Passed QA                   |Pushed to master

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 28 16:06:37 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 28 Jan 2020 15:06:37 +0000
Subject: [Koha-bugs] [Bug 24296] Move stock rotation transfer triggers from
 `comments` to `trigger`
In-Reply-To: <bug-24296-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24296-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24296-70-7f3sdYJQC1@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24296

--- Comment #13 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Nice work everyone!

Pushed to master for 20.05

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 28 16:06:39 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 28 Jan 2020 15:06:39 +0000
Subject: [Koha-bugs] [Bug 24348] Record matching rules: required match
 checks does not work
In-Reply-To: <bug-24348-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24348-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24348-70-ed7t7dOKMh@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24348

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to master
         Version(s)|                            |20.05.00
        released in|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 28 16:06:41 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 28 Jan 2020 15:06:41 +0000
Subject: [Koha-bugs] [Bug 24348] Record matching rules: required match
 checks does not work
In-Reply-To: <bug-24348-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24348-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24348-70-6Sa9hL4Yyc@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24348

--- Comment #6 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Nice work everyone!

Pushed to master for 20.05

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 28 16:06:43 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 28 Jan 2020 15:06:43 +0000
Subject: [Koha-bugs] [Bug 24448] Add Koha::Biblio->subscriptions_count
In-Reply-To: <bug-24448-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24448-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24448-70-Uz9z6nn2Hi@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24448

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|                            |20.05.00
        released in|                            |
             Status|Passed QA                   |Pushed to master

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 28 16:06:45 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 28 Jan 2020 15:06:45 +0000
Subject: [Koha-bugs] [Bug 24448] Add Koha::Biblio->subscriptions_count
In-Reply-To: <bug-24448-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24448-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24448-70-j2LjRbTpqZ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24448

--- Comment #14 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Nice work everyone!

Pushed to master for 20.05

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 28 16:08:10 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 28 Jan 2020 15:08:10 +0000
Subject: [Koha-bugs] [Bug 24527] misc/cronjobs/update_totalissues.pl problem
 with multiple items
In-Reply-To: <bug-24527-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24527-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24527-70-nwoEtNIz1g@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24527

Fridolin SOMERS <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
           Assignee|koha-bugs at lists.koha-commun |fridolin.somers at biblibre.co
                   |ity.org                     |m

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 28 16:37:02 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 28 Jan 2020 15:37:02 +0000
Subject: [Koha-bugs] [Bug 24485] Sys Pref AllowHoldPolicyOverride will not
 Staff override a Holds Per Record Rule
In-Reply-To: <bug-24485-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24485-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24485-70-if5EDRnqqr@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24485

ByWater Sandboxes <bws.sandboxes at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #98032|0                           |1
        is obsolete|                            |

--- Comment #3 from ByWater Sandboxes <bws.sandboxes at gmail.com> ---
Created attachment 98038
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98038&action=edit
Bug 24485: Allow hold when some can be overridden

The check to see if we can place a hold counts the number that we can override
vs the number of items on the record.

We cannot override if we already have a hold on an item, however, we don't
count these to see if they plus
the number of overrides equal the items on the record.

To test:
1 - Set max reserves to 2, allow 2 holds per recrod
2 - Place 2 holds for a patron on some records
3 - Find another record with 2 items
4 - Place a hold on the first item, you will be notified about the limit but
you can override
5 - Attempt to place hold on second item, cannot be done, button disabled
6 - Apply patch
7 - Repeat
8 - You can place the second hold

Signed-off-by: Kelly McElligott <kelly at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 28 16:38:07 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 28 Jan 2020 15:38:07 +0000
Subject: [Koha-bugs] [Bug 24485] Sys Pref AllowHoldPolicyOverride will not
 Staff override a Holds Per Record Rule
In-Reply-To: <bug-24485-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24485-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24485-70-vHdefj8pCA@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24485

Kelly McElligott <kelly at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 28 16:38:44 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 28 Jan 2020 15:38:44 +0000
Subject: [Koha-bugs] [Bug 23915] Replace OPAC list sort menu with Bootstrap
 menu button
In-Reply-To: <bug-23915-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23915-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23915-70-3DTKLKKXpG@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23915

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #97975|0                           |1
        is obsolete|                            |

--- Comment #6 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 98039
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98039&action=edit
Bug 23915: Replace OPAC list sort menu with Bootstrap menu button

This patch adds JavaScript to the list contents page which converts the
resort form's <select> menu into a Bootstrap dropdown menu. This allows
for a more compact and consistent display.

To test, apply the patch and regenerate the OPAC CSS
(https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client).

View a list in the OPAC. The toolbar of list controls ("New list,"
"Download list," etc.) should have a similary-styled "Sort" button. Each
sorting option should work correctly.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 28 16:38:47 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 28 Jan 2020 15:38:47 +0000
Subject: [Koha-bugs] [Bug 24527] misc/cronjobs/update_totalissues.pl problem
 with multiple items
In-Reply-To: <bug-24527-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24527-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24527-70-XCDtW5wAvr@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24527

Fridolin SOMERS <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Small patch
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 28 16:38:49 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 28 Jan 2020 15:38:49 +0000
Subject: [Koha-bugs] [Bug 24527] misc/cronjobs/update_totalissues.pl problem
 with multiple items
In-Reply-To: <bug-24527-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24527-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24527-70-gy2emReOD8@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24527

--- Comment #1 from Fridolin SOMERS <fridolin.somers at biblibre.com> ---
Created attachment 98040
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98040&action=edit
Bug 24527 : misc/cronjobs/update_totalissues.pl problem with multiple items

misc/cronjobs/update_totalissues.pl when issuing statistics table,
no-incremental,  has a problem for biblio with multiple items.
The first SQL query gets the biblios linked to items with issues in statistics
:

SELECT biblio.biblionumber, COUNT(statistics.itemnumber) FROM biblio LEFT JOIN
items ON (biblio.biblionumber=items.biblionumber) LEFT JOIN statistics ON
(items.itemnumber=statistics.itemnumber) WHERE statistics.type = 'issue' $limit
GROUP BY biblio.biblionumber

The second SQL query is :
SELECT biblio.biblionumber, 0 FROM biblio LEFT JOIN items ON
(biblio.biblionumber=items.biblionumber) LEFT JOIN statistics ON
(items.itemnumber=statistics.itemnumber) WHERE statistics.itemnumber IS NULL
GROUP BY biblio.biblionumber

The problem is that this second query will set to 0 where ANY item has no entry
in statistics table.
So when running it sets 0 to the biblio that had a value from first
query.

I think the best fix is to use "WHERE statistics.type = 'issue'" inside que
JOIN :
LEFT JOIN statistics ON (items.itemnumber=statistics.itemnumber AND
statistics.type = 'issue')

Test plan :
1) Begin with an empty database
2) Create a biblio 1 with no items
3) Create a biblio 2 with 3 items
4) Create a biblio 3 with 2 items
5) Checkout and checkin all items of biblio 2
6) Checkout and checkin the firt item of biblio 3
7) run misc/cronjobs/update_totalissues.pl --use-stats -v
8) Check biblio 1 has biblioitems.totalissues = 0
9) Check biblio 2 has biblioitems.totalissues = 3
10) Without patch the biblio 3 has biblioitems.totalissues = 0
11) With patch the biblio 3 has biblioitems.totalissues = 1
12) Check misc/cronjobs/update_totalissues.pl --incremental is OK

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 28 16:43:15 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 28 Jan 2020 15:43:15 +0000
Subject: [Koha-bugs] [Bug 23915] Replace OPAC list sort menu with Bootstrap
 menu button
In-Reply-To: <bug-23915-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23915-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23915-70-UOAVjw6juC@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23915

--- Comment #7 from Owen Leonard <oleonard at myacpl.org> ---
(In reply to David Nind from comment #5)
> Should this be fixed in this bug, or should it be a new bug?

I have modified the patch.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 28 16:45:59 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 28 Jan 2020 15:45:59 +0000
Subject: [Koha-bugs] [Bug 24522] Nothing happens when trying to add nothing
 to a list in staff
In-Reply-To: <bug-24522-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24522-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24522-70-apAoz27LlP@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24522

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |oleonard at myacpl.org
                   |ity.org                     |

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 28 16:46:32 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 28 Jan 2020 15:46:32 +0000
Subject: [Koha-bugs] [Bug 24528] New: Add a syntax for specifying counts on
 x-koha-embed
Message-ID: <bug-24528-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24528

            Bug ID: 24528
           Summary: Add a syntax for specifying counts on x-koha-embed
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: REST API
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: tomascohen at gmail.com

We need a way to specify that we want the count of the relation result and not
the result itself, this way we don't need to implement *_count methods (see bug
24467)

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 28 16:46:48 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 28 Jan 2020 15:46:48 +0000
Subject: [Koha-bugs] [Bug 24528] Add a syntax for specifying counts on
 x-koha-embed
In-Reply-To: <bug-24528-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24528-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24528-70-hZKKjkqhNo@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24528

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |tomascohen at gmail.com
                   |ity.org                     |
             Status|NEW                         |ASSIGNED
             Blocks|                            |24467


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24467
[Bug 24467] *_count methods should be avoided
-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 28 16:46:48 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 28 Jan 2020 15:46:48 +0000
Subject: [Koha-bugs] [Bug 24467] *_count methods should be avoided
In-Reply-To: <bug-24467-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24467-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24467-70-jN14j1UIIr@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24467

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |24528


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24528
[Bug 24528] Add a syntax for specifying counts on x-koha-embed
-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 28 18:20:43 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 28 Jan 2020 17:20:43 +0000
Subject: [Koha-bugs] [Bug 23493] jquery.dataTables.rowGrouping.js is no
 longer maintained,
 but there is an official DataTables version we could switch to
In-Reply-To: <bug-23493-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23493-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23493-70-WfvbJ3nXws@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23493

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #97704|0                           |1
        is obsolete|                            |

--- Comment #19 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 98041
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98041&action=edit
Bug 23493: Replace rowGrouping with rowGroup

This patch replaces the unmaintained third party rowGrouping datatables
plugin with the supported core rowGroup replacement.

Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 28 18:20:46 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 28 Jan 2020 17:20:46 +0000
Subject: [Koha-bugs] [Bug 23493] jquery.dataTables.rowGrouping.js is no
 longer maintained,
 but there is an official DataTables version we could switch to
In-Reply-To: <bug-23493-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23493-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23493-70-ZUMsA4Juvd@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23493

--- Comment #20 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 98042
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98042&action=edit
Bug 23493: (follow-up) Switch to aDataSort for multi-column sorting

This patch adds aDataSort configurations for each sortable column such
that we always maintain the group sorting primarily and apply a
secondary sort using the column in question.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 28 18:21:30 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 28 Jan 2020 17:21:30 +0000
Subject: [Koha-bugs] [Bug 23493] jquery.dataTables.rowGrouping.js is no
 longer maintained,
 but there is an official DataTables version we could switch to
In-Reply-To: <bug-23493-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23493-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23493-70-pFHmXkpHAH@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23493

--- Comment #21 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
OK, I see what you mean now.. good catch.

See followup which I believe addresses the issue.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 28 18:34:22 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 28 Jan 2020 17:34:22 +0000
Subject: [Koha-bugs] [Bug 18064] Long overdue cronjob does not follow the
 library's calendar and skip closed days
In-Reply-To: <bug-18064-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18064-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18064-70-6wRE7csMVM@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18064

--- Comment #10 from Andrew Fuerste-Henry <andrew at bywatersolutions.com> ---
I'm still very much in favor of making this change, but:
The patron emailer cron introduced in bug 16149 can be used to send a daily
email to all patrons with items that have gone to Long Overdue in the past day,
thereby sidestepping the regular overdues process and this issue.
But I imagine those libraries that prefer not to send overdues when the library
is closed would still prefer not to set overdue items to lost and bill patrons
on days the library is closed.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 28 18:44:57 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 28 Jan 2020 17:44:57 +0000
Subject: [Koha-bugs] [Bug 24495] Reword change collection feature
In-Reply-To: <bug-24495-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24495-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24495-70-SlcYl55NXN@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24495

ByWater Sandboxes <bws.sandboxes at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #98010|0                           |1
        is obsolete|                            |

--- Comment #10 from ByWater Sandboxes <bws.sandboxes at gmail.com> ---
Created attachment 98043
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98043&action=edit
Bug 24495: Reword change collection feature

This patch changes the text of the "Collect from patron" field to read "Amount
tendered"

To Test:

1) In the Point of Sale screen, check that the text inside the "Collect
payment" box reads "Collect from patron"
2) Go into a patron record, and create a manual invoice.
3) Go to Make a payment, and select to "Pay an amount". Check the text reads
"Collect from patron".
4) Repeat the process with the "Pay Selected", and "Pay" button (listed next to
the individual invoice)
5) Install the patch
6) Repeat steps 1-4, but the text should now read "Amount tendered", instead of
"Collect from patron" in all payment options in the patron record, and in the
Point of Sale screen.

Signed-off-by: David Nind <david at davidnind.com>

Signed-off-by: Andrew Fuerste-Henry <andrew at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 28 18:46:34 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 28 Jan 2020 17:46:34 +0000
Subject: [Koha-bugs] [Bug 24495] Reword change collection feature
In-Reply-To: <bug-24495-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24495-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24495-70-MSlis9K8vH@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24495

--- Comment #11 from Andrew Fuerste-Henry <andrew at bywatersolutions.com> ---
Looks good! Adding my signoff.
I did notice that the popup that tells you to give change still says "amount
collected from patron." I'm not concerned about it, but am pointing it out in
case someone else has a stronger need for consistency.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 28 18:54:32 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 28 Jan 2020 17:54:32 +0000
Subject: [Koha-bugs] [Bug 23260] Anonymize (remove) patron data from
 items_last_borrower
In-Reply-To: <bug-23260-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23260-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23260-70-3xjGXhfmC7@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23260

Agustín Moyano <agustinmoyano at theke.io> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #97842|0                           |1
        is obsolete|                            |

--- Comment #60 from Agustín Moyano <agustinmoyano at theke.io> ---
Created attachment 98044
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98044&action=edit
Bug 23260: Inline code to anonymise_issue_history

This alternative patch reduces the complexity of the change by simply
updateing the existing anonymise_issue_history method to include
anonymisation of the items_last_borrowers table.

To test:
1) apply this patch and the previous one
2) perl installer/data/mysql/updatedatabase.pl
3) set StoreLastBorrower preference to Allow.
4) set AnonymousPatron preference to a valid patron id
5) Create a Check out followed by a Check in.
CHECK => a row should appear in items_last_borrower table with the borrower and
the item number.
6) In mysql, update created_on of items_last_borrower and returndate of
old_issues to two days earlier.
7) perl misc/cronjobs/batch_anonymise.pl --days 1
SUCCESS => borrower number in items_last_borrower changed to AnonymousPatron id
8) repeat steps 5 and 6
9) set AnonymousPatron preference to 0
10) perl misc/cronjobs/batch_anonymise.pl --days 1
SUCCESS => borrower number in items_last_borrower changed to null
11) prove t/db_dependent/Koha/Patrons.t
12) Sign off

Signed-off-by: Agustin Moyano <agustinmoyano at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 28 18:54:55 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 28 Jan 2020 17:54:55 +0000
Subject: [Koha-bugs] [Bug 23260] Anonymize (remove) patron data from
 items_last_borrower
In-Reply-To: <bug-23260-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23260-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23260-70-bSz6JaWa6P@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23260

Agustín Moyano <agustinmoyano at theke.io> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 28 19:30:30 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 28 Jan 2020 18:30:30 +0000
Subject: [Koha-bugs] [Bug 23915] Replace OPAC list sort menu with Bootstrap
 menu button
In-Reply-To: <bug-23915-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23915-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23915-70-bYlT9gVBSQ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23915

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 28 19:30:33 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 28 Jan 2020 18:30:33 +0000
Subject: [Koha-bugs] [Bug 23915] Replace OPAC list sort menu with Bootstrap
 menu button
In-Reply-To: <bug-23915-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23915-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23915-70-WS5qNkedhJ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23915

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #98039|0                           |1
        is obsolete|                            |

--- Comment #8 from David Nind <david at davidnind.com> ---
Created attachment 98045
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98045&action=edit
Bug 23915: Replace OPAC list sort menu with Bootstrap menu button

This patch adds JavaScript to the list contents page which converts the
resort form's <select> menu into a Bootstrap dropdown menu. This allows
for a more compact and consistent display.

To test, apply the patch and regenerate the OPAC CSS
(https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client).

View a list in the OPAC. The toolbar of list controls ("New list,"
"Download list," etc.) should have a similary-styled "Sort" button. Each
sorting option should work correctly.

Signed-off-by: David Nind <david at davidnind.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 28 20:08:58 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 28 Jan 2020 19:08:58 +0000
Subject: [Koha-bugs] [Bug 21652] reserves.waitingdate is set to current date
 by printing new hold slip
In-Reply-To: <bug-21652-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21652-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21652-70-cz9IFpNqxQ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21652

Daniel Gaghan <daniel.gaghan at pueblolibrary.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |daniel.gaghan at pueblolibrary
                   |                            |.org

--- Comment #3 from Daniel Gaghan <daniel.gaghan at pueblolibrary.org> ---
PCCLD is seeing this bug too in 19.05.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 28 20:30:39 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 28 Jan 2020 19:30:39 +0000
Subject: [Koha-bugs] [Bug 24528] Add a syntax for specifying counts on
 x-koha-embed
In-Reply-To: <bug-24528-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24528-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24528-70-uT49BzmTOD@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24528

--- Comment #1 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 98046
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98046&action=edit
Bug 24528: Unit tests for Koha::Object->to_api

This patch introduces unit tests for the new to_api bejaviour for
*_count methods.

To test:
1. Apply this patch
2. Run:
   $ kshell
  k$ prove t/db_dependent/Koha/Object.t
=> FAIL: Tests fail because the feature is not implemented

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 28 20:30:44 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 28 Jan 2020 19:30:44 +0000
Subject: [Koha-bugs] [Bug 24528] Add a syntax for specifying counts on
 x-koha-embed
In-Reply-To: <bug-24528-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24528-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24528-70-SSVw9ebZHb@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24528

--- Comment #2 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 98047
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98047&action=edit
Bug 24528: Add *_count support to to_api

This patch adds a way to tell to_api an attribute needs to be calculated
as the count on an existing method/relationship result. For example, if
we wanted to include the holds_count attribute for a Koha::Patron
object, we would call it:

    $ patron_json = $patron->to_api({ embed => { holds_count => { is_count => 1
} } });

This way to_api will internally call

    $json->{holds_count} = $self->holds->count;

To test:
1. Apply the tests patch
2. Run:
   $ kshell
  k$ prove t/db_dependent/Koha/Object.t
=> FAIL: Tests fail!
3. Apply this patch
4. Repeat (2)
=> SUCCESS: Tests pass!
5. Sign off :-D

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 28 20:32:49 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 28 Jan 2020 19:32:49 +0000
Subject: [Koha-bugs] [Bug 24528] Add a syntax for specifying counts on
 x-koha-embed
In-Reply-To: <bug-24528-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24528-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24528-70-7lXR51N43g@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24528

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |agustinmoyano at theke.io,
                   |                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org,
                   |                            |martin.renvoize at ptfs-europe
                   |                            |.com

--- Comment #3 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Submitting the first bit once I got it for review. It is pretty simple, but I
had a nightmare because I picked Koha::Biblio as an example... Will need to fix
the overloaded to_api once I get this sorted.

Next step is parsing relation+count on the API code, and adding is_count => 1
to the structure.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 28 20:43:30 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 28 Jan 2020 19:43:30 +0000
Subject: [Koha-bugs] [Bug 15704] The 264 index should be split by subfield
 to match how 260 is indexed
In-Reply-To: <bug-15704-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15704-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15704-70-3P0QhMSVRO@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15704

Marjorie Barry-Vila <marjorie.barry-vila at collecto.ca> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |marjorie.barry-vila at collect
                   |                            |o.ca

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 28 21:07:55 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 28 Jan 2020 20:07:55 +0000
Subject: [Koha-bugs] [Bug 22801] Advance search yr uses copydate instead of
 date-of-publication
In-Reply-To: <bug-22801-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22801-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22801-70-aUXFI6Sz4j@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22801

Marjorie Barry-Vila <marjorie.barry-vila at collecto.ca> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|marjorie.barry-vila at collect |
                   |o.ca                        |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 28 21:08:05 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 28 Jan 2020 20:08:05 +0000
Subject: [Koha-bugs] [Bug 22801] Advance search yr uses copydate instead of
 date-of-publication
In-Reply-To: <bug-22801-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22801-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22801-70-rKDqRyEnju@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22801

Marjorie Barry-Vila <marjorie.barry-vila at collecto.ca> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |marjorie.barry-vila at collect
                   |                            |o.ca

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 28 21:22:09 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 28 Jan 2020 20:22:09 +0000
Subject: [Koha-bugs] [Bug 11530] Recalculating a book's total issue count
 from items.issues or statistics-table with update_totalissues.pl ignores
 deleted_items.
In-Reply-To: <bug-11530-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-11530-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11530-70-bJatm6Bd5u@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11530

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de

--- Comment #2 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
(In reply to Fridolin SOMERS from comment #1)
> Since statistics contains only itemnumber, once item deleted we can not link
> this itemnumber to its biblionumber.

What we do is use a union of items and deleteditems in most reports - then you
can.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 28 21:36:50 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 28 Jan 2020 20:36:50 +0000
Subject: [Koha-bugs] [Bug 20271] Merge deleted biblio, biblioitems,
 biblio_metadata, and items tables
In-Reply-To: <bug-20271-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20271-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20271-70-o7s3bQJxt2@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271

--- Comment #202 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Use cases:
- Items: reused barcode stickers or barcode slips, maybe for ILL items?
- Cardnumbers: reusing expensive chip cards for different guest users

I don't think invalidating with a prefix for something would be very elegant,
it also gets more complicated when things are reused more than one time. Also
would make writing reports harder and the data harder to interpret for the
libraries.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 28 22:22:27 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 28 Jan 2020 21:22:27 +0000
Subject: [Koha-bugs] [Bug 24088] Add link to item search in staff client
 main page
In-Reply-To: <bug-24088-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24088-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24088-70-ygDREDkdTa@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24088

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de

--- Comment #5 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
(In reply to Owen Leonard from comment #4)
> One could also add a link to the header menu using the IntranetNav system
> preference if you wanted to avoid that click:
> 
> <li><a href="/cgi-bin/koha/catalogue/itemsearch.pl">Item search</a></li>
> 
> In my opinion we don't need such a prominent link on the home page.

+1

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 28 22:28:24 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 28 Jan 2020 21:28:24 +0000
Subject: [Koha-bugs] [Bug 24428] Elasticsearch index does not contain
 consistent item information
In-Reply-To: <bug-24428-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24428-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24428-70-wQJydEfS3e@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24428

--- Comment #11 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
I slightly disagree with Nick in that I think item searching is part of the
basic search we are aiming at right now. The itemtype, location and collection
searches and facetting on item values are prominent features in our OPAC and
basically they never worked correctly with Zebra. You can argue that this is
not a regression compared to how Zebra worked (it's just the same bug as
before...), but you could also say we should work to get rid if our old
problems with a new implementation :)

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Tue Jan 28 23:57:27 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 28 Jan 2020 22:57:27 +0000
Subject: [Koha-bugs] [Bug 24495] Reword change collection feature
In-Reply-To: <bug-24495-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24495-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24495-70-9LpJ3dXD1x@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24495

--- Comment #12 from David Roberts <david.roberts at ptfs-europe.com> ---
The wording in the popup is pretty clear as it is a complete sentence which is
pretty self-explanatory. I can change it if people wish, but I personally don't
think it's necessary.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 29 03:12:39 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 29 Jan 2020 02:12:39 +0000
Subject: [Koha-bugs] [Bug 11815] Convert BorrowersTitles to an authorised
 value
In-Reply-To: <bug-11815-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-11815-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11815-70-sBZsT8irUs@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11815

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |david at davidnind.com

--- Comment #4 from David Nind <david at davidnind.com> ---
Two queries from testing:

1) Does the Description (OPAC) text for the authorized value appear anywhere? I
had two different values for Description and Description (OPAC). On the OPAC I
could only see what is in the Description.

2) I'm getting this error when trying to search in OPAC and staff interface
(even though it is not in the test plan) - can post the full error somewhere if
required: 
> Error trace
> DBIx::Class::Storage::DBI::_dbh_execute(): 'localization.translation' isn't in GROUP BY at /kohadevbox/koha/Koha/Objects.pm line 130
>  at /usr/share/perl5/DBIx/Class/Exception.pm line 77
> in DBIx::Class::Exception::throw at /usr/share/perl5/DBIx/Class/Exception.pm line 77

Otherwise, everything works as expected.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 29 04:08:33 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 29 Jan 2020 03:08:33 +0000
Subject: [Koha-bugs] [Bug 24194] Add system preference to hide expiration
 date options for reserves
In-Reply-To: <bug-24194-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24194-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24194-70-o4HCOwpijq@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24194

Aleisha Amohia <aleisha at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #96121|0                           |1
        is obsolete|                            |

--- Comment #4 from Aleisha Amohia <aleisha at catalyst.net.nz> ---
Created attachment 98048
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98048&action=edit
Bug 24194: Add HideReserveExpiration system preference to hide expiration date
options for reserves

To test:
1) Update database
2) Go to place a hold on any biblio in the staff intranet and confirm
you can see the 'Hold expires on date' field.
3) In another tab, go to place a hold on any biblio in the OPAC and
confirm you can see the 'Hold not needed after' field as an option.
4) In yet another tab, open the staff intranet and place a reserve for a user.
Check it in and set the reserve as
waiting. Notice that an expiration date has now been generated for this
reserve.
5) Attempt to check out the item you reserved to some other borrower.
Revert waiting status. Notice that the expiration date that was
generated remains.
6) Go to Administration -> system preferences and set HideReserveExpiration
system preference to 'Hide'
7) Refresh the hold request page in the intranet. Confirm the expiration
date field disappears.
8) Refresh the hold request page in the OPAC. Confirm the expiration
date field disappears.
9) Place another reserve. Check it in and set the reserve as waiting.
Notice that no expiration date was generated for this reserve.
10) Attempt to check out the item you reserved to some other borrower.
Revert waiting status. The expiration date should remain null.

Sponsored-by: Horowhenua Library Trust

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 29 04:10:00 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 29 Jan 2020 03:10:00 +0000
Subject: [Koha-bugs] [Bug 24194] Add system preference to hide expiration
 date options for reserves
In-Reply-To: <bug-24194-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24194-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24194-70-CPDhnaVCWU@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24194

Aleisha Amohia <aleisha at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Needs Signoff

--- Comment #5 from Aleisha Amohia <aleisha at catalyst.net.nz> ---
(In reply to Jonathan Druart from comment #3)
> Should not it be hidden locally in CSS or JS instead?

It turns out the library wants to not use expiration dates for reserves at all,
so the latest patch now includes not setting an expiration date when setting a
reserve as waiting, and nullifying an expiration date when reverting waiting
status. Back to needs signoff, with a new test plan.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 29 04:58:41 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 29 Jan 2020 03:58:41 +0000
Subject: [Koha-bugs] [Bug 17016] Button to clear all fields in budget
 planning
In-Reply-To: <bug-17016-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17016-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17016-70-sbGyxqUHGQ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17016

Aleisha Amohia <aleisha at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 29 04:58:45 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 29 Jan 2020 03:58:45 +0000
Subject: [Koha-bugs] [Bug 17016] Button to clear all fields in budget
 planning
In-Reply-To: <bug-17016-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17016-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17016-70-INV5ZWv1V3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17016

Aleisha Amohia <aleisha at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #53872|0                           |1
        is obsolete|                            |

--- Comment #4 from Aleisha Amohia <aleisha at catalyst.net.nz> ---
Created attachment 98049
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98049&action=edit
Bug 17016: Button to clear all fields in budget planning

I have used the function from admin --> circ and fines rules

To test:
1) Go to Admin --> Budgets
2) Click a budget
3) Click Planning -> any option
4) Test the Auto-fill button to see what it does
5) Apply patch and refresh page
6) Should now be a Clear button
7) Auto-fill the row then click Clear button. Confirm it clears all
fields and sets the fund remaining back to the original amount and
styles.
8) Add another fund and confirm that this still works with multiple
funds.

Sponsored-by: Catalyst IT

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 29 08:12:44 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 29 Jan 2020 07:12:44 +0000
Subject: [Koha-bugs] [Bug 24194] Add system preference to hide expiration
 date options for reserves
In-Reply-To: <bug-24194-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24194-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24194-70-MZATIJqZn1@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24194

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de

--- Comment #6 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
(In reply to Aleisha Amohia from comment #5)
> (In reply to Jonathan Druart from comment #3)
> > Should not it be hidden locally in CSS or JS instead?
> 
> It turns out the library wants to not use expiration dates for reserves at
> all, so the latest patch now includes not setting an expiration date when
> setting a reserve as waiting, and nullifying an expiration date when
> reverting waiting status. Back to needs signoff, with a new test plan.

Hi Aleisha, can you please update the bug title? Sounds like quite a different
thing now!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 29 08:20:38 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 29 Jan 2020 07:20:38 +0000
Subject: [Koha-bugs] [Bug 23944] Phase out use of jquery.cookie.js in favor
 of js.cookie.js
In-Reply-To: <bug-23944-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23944-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23944-70-peQa6tjf83@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23944

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de

--- Comment #7 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
I had to delete my old issues-table-load-immediately-circulation cookies first
to get this to work, but now it does :)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 29 08:21:12 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 29 Jan 2020 07:21:12 +0000
Subject: [Koha-bugs] [Bug 23944] Phase out use of jquery.cookie.js in favor
 of js.cookie.js
In-Reply-To: <bug-23944-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23944-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23944-70-wDVJWxWQno@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23944

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 29 08:21:15 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 29 Jan 2020 07:21:15 +0000
Subject: [Koha-bugs] [Bug 23944] Phase out use of jquery.cookie.js in favor
 of js.cookie.js
In-Reply-To: <bug-23944-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23944-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23944-70-iQWrLiid5m@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23944

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #97937|0                           |1
        is obsolete|                            |

--- Comment #8 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 98050
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98050&action=edit
Bug 23944: Phase out use of jquery.cookie.js in favor of js.cookie.js

This patch adds a new JavaScript file to the staff client's global
JavaScript include file: js.cookie-2.2.1.min.js. This "plugin" will
replace jquery.cookie.js which is no longer maintained.

The "About" page in the staff client is updated to include this new
resource as well as adding previously-missing information about the old
plugin which will remain until all instances of its usage have been
removed.

To test, apply the patch and check the About page to confirm the correct
information is included.

No functionality change is introduced by this bug. The only other
observable change is the existence of the new files and the inclusion of
the minified version of the file in any staff client page.

Signed-off-by: David Nind <david at davidnind.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 29 08:21:18 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 29 Jan 2020 07:21:18 +0000
Subject: [Koha-bugs] [Bug 23944] Phase out use of jquery.cookie.js in favor
 of js.cookie.js
In-Reply-To: <bug-23944-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23944-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23944-70-l30fmZo6tp@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23944

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #97938|0                           |1
        is obsolete|                            |

--- Comment #9 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 98051
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98051&action=edit
Bug 23944: (follow-up) Update circulation to use new library

This patch updates the circulation page to use the new JavaScript Cookie
library for cookie management.

To test, apply the patch and open a patron record for checkout in the
staff client.

 - Click "Search to hold" in the toolbar and perform a catalog search
   which will return results.
 - On the search results page, the toolbar at the top of the results
   should include a split "Place hold" button. The button's menu should
   include "Place hold for <patron>" and "Forget <patron>" options. Test
   that these work correctly.
 - In the table of search results each title should include a "Place
   hold for <patron>" link.
 - Go to the checkouts page for a patron with one or more checked-out
   items.
   - Check the "Always show checkouts immediately" checkbox.
   - The patron's checkouts should load.
   - Open another patron for checkout who has checked-out items.
   - The table of checkouts should load automatically.

Signed-off-by: David Nind <david at davidnind.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 29 08:25:44 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 29 Jan 2020 07:25:44 +0000
Subject: [Koha-bugs] [Bug 15516] Allow to place a hold on first available
 item from a group of titles
In-Reply-To: <bug-15516-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15516-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15516-70-x2QGQ5jLHD@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |martin.renvoize at ptfs-europe
                   |                            |.com

--- Comment #212 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Are you hoping to pick this back up at some point Julian or are you hoping
someone will adopt it?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 29 08:26:09 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 29 Jan 2020 07:26:09 +0000
Subject: [Koha-bugs] [Bug 23947] Phase out jquery.cookie.js: Authority merge
In-Reply-To: <bug-23947-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23947-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23947-70-YvPjQIzsK1@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23947

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 29 08:26:12 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 29 Jan 2020 07:26:12 +0000
Subject: [Koha-bugs] [Bug 23947] Phase out jquery.cookie.js: Authority merge
In-Reply-To: <bug-23947-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23947-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23947-70-jroeN5kKYG@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23947

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #97950|0                           |1
        is obsolete|                            |

--- Comment #3 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 98052
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98052&action=edit
Bug 23947: Phase out jquery.cookie.js: Authority merge

This patch updates the JavaScript which sets cookies during the
authority merge process so that it uses the new js-cookie library.

To test, apply the patch and perform a search in the authority module
which will return multiple results.

 - Select "Merge" from the Actions menu next to any result.
   - A message should appear at the top of the page: "Merging with
     authority: <title>".
   - Click "Cancel merge." The message should disappear.
 - Select a record to merge again.
   - Select another record.
   - The page should redirect to the authority merge page.

Signed-off-by: David Nind <david at davidnind.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 29 09:03:39 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 29 Jan 2020 08:03:39 +0000
Subject: [Koha-bugs] [Bug 24298] Record if a transfer was triggered by
 'return to homebranch'
In-Reply-To: <bug-24298-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24298-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24298-70-nvLRom1IRw@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24298

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |martin.renvoize at ptfs-europe
                   |ity.org                     |.com

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 29 10:07:24 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 29 Jan 2020 09:07:24 +0000
Subject: [Koha-bugs] [Bug 23260] Anonymize (remove) patron data from
 items_last_borrower
In-Reply-To: <bug-23260-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23260-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23260-70-A0nMa7YzV3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23260

--- Comment #61 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 98053
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98053&action=edit
Bug 23260: Simplify tests

Use build_sample_item and build_object

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 29 10:07:28 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 29 Jan 2020 09:07:28 +0000
Subject: [Koha-bugs] [Bug 23260] Anonymize (remove) patron data from
 items_last_borrower
In-Reply-To: <bug-23260-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23260-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23260-70-0UhrlGhwZI@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23260

--- Comment #62 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 98054
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98054&action=edit
Bug 23260: Add a new test

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 29 10:08:52 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 29 Jan 2020 09:08:52 +0000
Subject: [Koha-bugs] [Bug 23260] Anonymize (remove) patron data from
 items_last_borrower
In-Reply-To: <bug-23260-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23260-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23260-70-aVo6Onsbcx@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23260

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Failed QA

--- Comment #63 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Almost done but I think I found an issue, the method does no longer return the
number of issues modified.
I do not think we should sum the number of items_last_borrower updated.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 29 10:10:06 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 29 Jan 2020 09:10:06 +0000
Subject: [Koha-bugs] [Bug 13121] Move search results "action" links ("Place
 hold, " "Add tag, " etc) into include file
In-Reply-To: <bug-13121-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13121-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13121-70-NR8OHU52xW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13121

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to master
         Version(s)|                            |20.05.00
        released in|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 29 10:10:08 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 29 Jan 2020 09:10:08 +0000
Subject: [Koha-bugs] [Bug 13121] Move search results "action" links ("Place
 hold, " "Add tag, " etc) into include file
In-Reply-To: <bug-13121-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13121-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13121-70-CH1LUFpKcR@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13121

--- Comment #10 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Nice work everyone!

Pushed to master for 20.05

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 29 10:10:10 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 29 Jan 2020 09:10:10 +0000
Subject: [Koha-bugs] [Bug 20847] Add more fields to the Batch Patron
 Modification tool
In-Reply-To: <bug-20847-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20847-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20847-70-nO0mq4fC4e@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20847

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to master
         Version(s)|                            |20.05.00
        released in|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 29 10:10:12 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 29 Jan 2020 09:10:12 +0000
Subject: [Koha-bugs] [Bug 20847] Add more fields to the Batch Patron
 Modification tool
In-Reply-To: <bug-20847-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20847-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20847-70-8ZRLZJPuPL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20847

--- Comment #10 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Nice work everyone!

Pushed to master for 20.05

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 29 10:10:15 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 29 Jan 2020 09:10:15 +0000
Subject: [Koha-bugs] [Bug 23856] Split author and ISBN/ISSN out of citation
 in staged MARC record management
In-Reply-To: <bug-23856-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23856-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23856-70-Oynh9WDwwE@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23856

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to master
         Version(s)|                            |20.05.00
        released in|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 29 10:10:16 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 29 Jan 2020 09:10:16 +0000
Subject: [Koha-bugs] [Bug 23856] Split author and ISBN/ISSN out of citation
 in staged MARC record management
In-Reply-To: <bug-23856-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23856-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23856-70-xscNXXpM2T@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23856

--- Comment #4 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Nice work everyone!

Pushed to master for 20.05

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 29 10:10:18 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 29 Jan 2020 09:10:18 +0000
Subject: [Koha-bugs] [Bug 23885] Move staff client search results JavaScript
 into separate file
In-Reply-To: <bug-23885-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23885-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23885-70-T6qlFyaQPR@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23885

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|                            |20.05.00
        released in|                            |
             Status|Passed QA                   |Pushed to master

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 29 10:10:20 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 29 Jan 2020 09:10:20 +0000
Subject: [Koha-bugs] [Bug 23885] Move staff client search results JavaScript
 into separate file
In-Reply-To: <bug-23885-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23885-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23885-70-dTELzTvaX9@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23885

--- Comment #6 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Nice work everyone!

Pushed to master for 20.05

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 29 10:10:21 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 29 Jan 2020 09:10:21 +0000
Subject: [Koha-bugs] [Bug 23944] Phase out use of jquery.cookie.js in favor
 of js.cookie.js
In-Reply-To: <bug-23944-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23944-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23944-70-PcdPExoOri@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23944

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|                            |20.05.00
        released in|                            |
             Status|Passed QA                   |Pushed to master

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 29 10:10:23 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 29 Jan 2020 09:10:23 +0000
Subject: [Koha-bugs] [Bug 23944] Phase out use of jquery.cookie.js in favor
 of js.cookie.js
In-Reply-To: <bug-23944-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23944-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23944-70-TKtqvi0hFu@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23944

--- Comment #10 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Nice work everyone!

Pushed to master for 20.05

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 29 10:10:25 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 29 Jan 2020 09:10:25 +0000
Subject: [Koha-bugs] [Bug 23947] Phase out jquery.cookie.js: Authority merge
In-Reply-To: <bug-23947-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23947-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23947-70-Bus8dILN6t@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23947

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to master
         Version(s)|                            |20.05.00
        released in|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 29 10:10:27 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 29 Jan 2020 09:10:27 +0000
Subject: [Koha-bugs] [Bug 23947] Phase out jquery.cookie.js: Authority merge
In-Reply-To: <bug-23947-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23947-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23947-70-hQ2zDsCYoe@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23947

--- Comment #4 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Nice work everyone!

Pushed to master for 20.05

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 29 10:23:22 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 29 Jan 2020 09:23:22 +0000
Subject: [Koha-bugs] [Bug 23493] jquery.dataTables.rowGrouping.js is no
 longer maintained,
 but there is an official DataTables version we could switch to
In-Reply-To: <bug-23493-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23493-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23493-70-V2oFR18NCj@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23493

--- Comment #22 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
I do not think it's correct, now we cannot really sort by due date:
https://snipboard.io/TRx43j.jpg

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 29 10:31:58 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 29 Jan 2020 09:31:58 +0000
Subject: [Koha-bugs] [Bug 23493] jquery.dataTables.rowGrouping.js is no
 longer maintained,
 but there is an official DataTables version we could switch to
In-Reply-To: <bug-23493-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23493-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23493-70-GvWzyFAMet@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23493

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 29 10:32:01 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 29 Jan 2020 09:32:01 +0000
Subject: [Koha-bugs] [Bug 23493] jquery.dataTables.rowGrouping.js is no
 longer maintained,
 but there is an official DataTables version we could switch to
In-Reply-To: <bug-23493-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23493-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23493-70-aB4kza67Kt@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23493

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #98041|0                           |1
        is obsolete|                            |
  Attachment #98042|0                           |1
        is obsolete|                            |

--- Comment #23 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 98055
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98055&action=edit
Bug 23493: Replace rowGrouping with rowGroup

This patch replaces the unmaintained third party rowGrouping datatables
plugin with the supported core rowGroup replacement.

Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 29 10:32:05 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 29 Jan 2020 09:32:05 +0000
Subject: [Koha-bugs] [Bug 23493] jquery.dataTables.rowGrouping.js is no
 longer maintained,
 but there is an official DataTables version we could switch to
In-Reply-To: <bug-23493-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23493-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23493-70-fNaxiybBhq@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23493

--- Comment #24 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 98056
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98056&action=edit
Bug 23493: Remove commented lines

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 29 10:34:00 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 29 Jan 2020 09:34:00 +0000
Subject: [Koha-bugs] [Bug 23493] jquery.dataTables.rowGrouping.js is no
 longer maintained,
 but there is an official DataTables version we could switch to
In-Reply-To: <bug-23493-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23493-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23493-70-tCzlSqLMLT@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23493

--- Comment #25 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Ok so I confused Martin with my previous comments.

I wanted to highlight the fact that there was a behavior's change, but did not
consider it a regression or blocker. I am happy with how it works as it.

I have attached a follow-up to remove the 3 commented lines.

Marked as Passed QA!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 29 11:03:35 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 29 Jan 2020 10:03:35 +0000
Subject: [Koha-bugs] [Bug 6976] User hold limit can be avoided by users in
 OPAC
In-Reply-To: <bug-6976-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-6976-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-6976-70-RT1F9C0qkt@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6976

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|REOPENED                    |RESOLVED
         Resolution|---                         |FIXED

--- Comment #34 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
(In reply to Nick Clemens from comment #33)
> (In reply to Nick Clemens from comment #32)
> > (In reply to Nick Clemens from comment #31)
> > > (In reply to Jonathan Druart from comment #30)
> > > > Still valid.
> > > 
> > > I cannot recreate.
> > > 
> > > Set an All/All/All rule for limit 2 holds, do a search, select all, place
> > > hold - user gets two holds
> > > 
> > > Cancel those
> > > 
> > > Set maxreserves to 1
> > > Search - select all - place hold - warning that I can only select one -
> > > error if I try to place all holds
> > 
> > NVM, set ReservesControlBranch to 'Items home library'
> 
> This may be fixed in 19.05+, I cannot recreate, can someone confirm?

I cannot either. Closing. New bug report must be opened with steps to recreate
if the bug pops up again.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 29 11:08:45 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 29 Jan 2020 10:08:45 +0000
Subject: [Koha-bugs] [Bug 23673] Separate time sent from time created in
 message_queue table
In-Reply-To: <bug-23673-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23673-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23673-70-ZRA0Iq808K@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23673

--- Comment #18 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
(In reply to Tomás Cohen Arazi from comment #17)
> (In reply to Jonathan Druart from comment #16)
> > (In reply to Agustín Moyano from comment #14)
> > > Hi Jonathan
> > >  
> > > > 1. Should not we have the new column with the "default CURRENT_TIMESTAMP on
> > > > update CURRENT_TIMESTAMP" clause in order to delegate the update of this
> > > > value to the DBMS?
> > > 
> > > Mysql doesn't accept a table with 2 columns with "default
> > > CURRENT_TIMESTAMP".. there can be only one.
> > 
> > Hola Agustín, Yes I know and that's why I suggested to have it on the new
> > column :)
> > 
> > Take a look at library_groups or borrowers tables for instance. Note that
> > article_requests does the reverse.
> 
> You mean making the 'time_queued' column TIMESTAMP DEFAULT NULL (and so
> making us set it manually), and making 'updated_on' be the one with the
> trigger? (so we don't do the update manually?). I'm fine with either. Just
> trying to clarify so we move this forward.

Yes, that is what I meant.

4252     created_on TIMESTAMP NULL,             -- Date and time of creation
4253     updated_on TIMESTAMP NOT NULL DEFAULT CURRENT_TIMESTAMP ON UPDATE
CURRENT_TIMESTAMP, -- Date and time of last

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 29 11:17:44 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 29 Jan 2020 10:17:44 +0000
Subject: [Koha-bugs] [Bug 24305] Batch Item modification via item number in
 reports does not work with CONCAT in report
In-Reply-To: <bug-24305-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24305-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24305-70-y9XykGBx9G@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24305

--- Comment #19 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 98057
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98057&action=edit
Bug 24305: (follow-up) Remove previous declaration of batch_biblionumbers

Revert change for cardnumbers, they are not always numbers.
We may need to add a regex to remove special chars however, will be done
on its own bug report if needed.

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 29 11:20:36 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 29 Jan 2020 10:20:36 +0000
Subject: [Koha-bugs] [Bug 24305] Batch Item modification via item number in
 reports does not work with CONCAT in report
In-Reply-To: <bug-24305-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24305-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24305-70-qAnVDnL6ke@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24305

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |martin.renvoize at ptfs-europe
                   |                            |.com

--- Comment #20 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Followup pushed, thanks Jonathan for beating me to this.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 29 11:23:41 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 29 Jan 2020 10:23:41 +0000
Subject: [Koha-bugs] [Bug 24482] Purchase Items broken by costs containing a
 comma
In-Reply-To: <bug-24482-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24482-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24482-70-lFUGZjLDeD@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24482

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 29 11:23:44 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 29 Jan 2020 10:23:44 +0000
Subject: [Koha-bugs] [Bug 24482] Purchase Items broken by costs containing a
 comma
In-Reply-To: <bug-24482-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24482-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24482-70-TeAgqVLmEK@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24482

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #97983|0                           |1
        is obsolete|                            |

--- Comment #4 from David Nind <david at davidnind.com> ---
Created attachment 98058
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98058&action=edit
Bug 24482: Fix for formatted price issue with value over 1000

This patch for the point of sale feature fixes an issue where items for
purchase with a value of $1,000 or more break the payment calculations. 

Test plan:
1) Enable the point of sale feature (EnablePointOfSale + UseCashRegisters
system preferences)
2) Add a cash register for a library (Home > Point of sale >  Cash registers >
New cash register)
3) Create a purchase item with a cost of $1000 (Home > Point of sale > 
Purchase items > New debit type)
4) Go to to the point of sale page and attempt to sell one of your items (Home
> Point of sale > click 'Add' next to the item to purchase)
5) Note that Koha inserts a comma into the price in the list of items for
purchase
6) Note that the 'Amount being paid' changes to 0.00 instead of $1,000, which
affects the other calculations
7) Apply the patch
8) Repeat step 4
9) Amount being paid and other calculations should now be correct
10) Enter an amount for 'Collected from patron' and click 'Confirm' - check
that the change calculation is correct
11) Sign-off the patch!

Signed-off-by: David Nind <david at davidnind.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 29 11:32:06 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 29 Jan 2020 10:32:06 +0000
Subject: [Koha-bugs] [Bug 24482] Purchase Items broken by costs containing a
 comma
In-Reply-To: <bug-24482-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24482-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24482-70-tM6yiDxlP6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24482

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |david at davidnind.com

--- Comment #5 from David Nind <david at davidnind.com> ---
I identified two other possible issues testing this bug:

1. If you press enter in the 'Collected from patron' field it adds the first
item listed under the 'Items for purchase' section to 'This sale'.

2. If the amount you enter in 'Collected from patron' is less than the total
amount owed and you press confirm it is accepted. For a cash payment maybe
there should be a warning or error, or not let the transaction be accepted or
completed.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 29 11:48:14 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 29 Jan 2020 10:48:14 +0000
Subject: [Koha-bugs] [Bug 24526] Auto renewal cronjob should have verbose
 and test mode options
In-Reply-To: <bug-24526-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24526-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24526-70-SwpIuj4DuY@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24526

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 29 11:48:18 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 29 Jan 2020 10:48:18 +0000
Subject: [Koha-bugs] [Bug 24526] Auto renewal cronjob should have verbose
 and test mode options
In-Reply-To: <bug-24526-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24526-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24526-70-DdCkgANxQ9@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24526

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #98037|0                           |1
        is obsolete|                            |

--- Comment #2 from David Nind <david at davidnind.com> ---
Created attachment 98059
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98059&action=edit
Bug 24526: Add verbose and commit options to automatic_renewals cronjob

To test:
 1 - Apply patch
 2 - Have some items marked for auto-renewal
 3 - Run the job with no parameters
 4 - It should print 'Test mode'
 5 - Provide -v
 6 - It should print 'Test mode' then a line for each item
 7 - Provide -v -c
 8 - It should not say test mode, but should provide a line for each item
 9 - Provide -c
10 - Shoudl run as expected with no output

Signed-off-by: David Nind <david at davidnind.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 29 12:06:06 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 29 Jan 2020 11:06:06 +0000
Subject: [Koha-bugs] [Bug 23673] Separate time sent from time created in
 message_queue table
In-Reply-To: <bug-23673-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23673-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23673-70-ZeNV44e0tD@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23673

Sally <sally.healey at cheshiresharedservices.gov.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |sally.healey at cheshireshared
                   |                            |services.gov.uk

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 29 12:21:26 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 29 Jan 2020 11:21:26 +0000
Subject: [Koha-bugs] [Bug 17016] Button to clear all fields in budget
 planning
In-Reply-To: <bug-17016-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17016-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17016-70-5w2LHxmvzn@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17016

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 29 12:21:29 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 29 Jan 2020 11:21:29 +0000
Subject: [Koha-bugs] [Bug 17016] Button to clear all fields in budget
 planning
In-Reply-To: <bug-17016-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17016-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17016-70-dc9hcFNMEE@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17016

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #98049|0                           |1
        is obsolete|                            |

--- Comment #5 from David Nind <david at davidnind.com> ---
Created attachment 98060
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98060&action=edit
Bug 17016: Button to clear all fields in budget planning

I have used the function from admin --> circ and fines rules

To test:
1) Go to Admin --> Budgets
2) Click a budget
3) Click Planning -> any option
4) Test the Auto-fill button to see what it does
5) Apply patch and refresh page
6) Should now be a Clear button
7) Auto-fill the row then click Clear button. Confirm it clears all
fields and sets the fund remaining back to the original amount and
styles.
8) Add another fund and confirm that this still works with multiple
funds.

Sponsored-by: Catalyst IT

Signed-off-by: David Nind <david at davidnind.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 29 12:32:52 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 29 Jan 2020 11:32:52 +0000
Subject: [Koha-bugs] [Bug 23493] jquery.dataTables.rowGrouping.js is no
 longer maintained,
 but there is an official DataTables version we could switch to
In-Reply-To: <bug-23493-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23493-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23493-70-i40ahriZjY@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23493

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to master
         Version(s)|                            |20.05.00
        released in|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 29 12:32:54 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 29 Jan 2020 11:32:54 +0000
Subject: [Koha-bugs] [Bug 23493] jquery.dataTables.rowGrouping.js is no
 longer maintained,
 but there is an official DataTables version we could switch to
In-Reply-To: <bug-23493-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23493-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23493-70-5w9TnGZ0TS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23493

--- Comment #26 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Nice work everyone!

Pushed to master for 20.05

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 29 12:39:36 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 29 Jan 2020 11:39:36 +0000
Subject: [Koha-bugs] [Bug 21466] Data inconsistencies - koha fields linked
 to AV cat values must have a corresponding authorised value
In-Reply-To: <bug-21466-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21466-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21466-70-rlKz6924zi@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21466

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to master            |ASSIGNED

--- Comment #12 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
I found a bug in this one. I am working on it.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 29 12:48:00 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 29 Jan 2020 11:48:00 +0000
Subject: [Koha-bugs] [Bug 21466] Data inconsistencies - koha fields linked
 to AV cat values must have a corresponding authorised value
In-Reply-To: <bug-21466-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21466-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21466-70-J5NYwBujoD@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21466

--- Comment #13 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 98062
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98062&action=edit
Bug 21466: Keep all AVs for a given framework

There was a major (and silly) issue in the previous version, only one AV
was kept as we erased the hash value at the end of each iteration:
$invalid_locations_per_framework->{$framework->frameworkcode } =
  { items => $items, av_category => $mss->authorised_value, kohafield =>
$kohafield };

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 29 12:59:35 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 29 Jan 2020 11:59:35 +0000
Subject: [Koha-bugs] [Bug 21466] Data inconsistencies - koha fields linked
 to AV cat values must have a corresponding authorised value
In-Reply-To: <bug-21466-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21466-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21466-70-pI9zieX4wg@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21466

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #98062|0                           |1
        is obsolete|                            |

--- Comment #14 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 98063
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98063&action=edit
Bug 21466: Keep all AVs for a given framework

There was a major (and silly) issue in the previous version, only one AV
was kept as we erased the hash value at the end of each iteration:
$invalid_locations_per_framework->{$framework->frameworkcode } =
  { items => $items, av_category => $mss->authorised_value, kohafield =>
$kohafield };

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 29 13:04:20 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 29 Jan 2020 12:04:20 +0000
Subject: [Koha-bugs] [Bug 23260] Anonymize (remove) patron data from
 items_last_borrower
In-Reply-To: <bug-23260-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23260-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23260-70-sLO5fNe8YT@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23260

--- Comment #64 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
(In reply to Jonathan Druart from comment #63)
> Almost done but I think I found an issue, the method does no longer return
> the number of issues modified.
> I do not think we should sum the number of items_last_borrower updated.

I think your right.. looks like an oversight on my part when I first submitted
the alternative approach.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 29 13:11:51 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 29 Jan 2020 12:11:51 +0000
Subject: [Koha-bugs] [Bug 23260] Anonymize (remove) patron data from
 items_last_borrower
In-Reply-To: <bug-23260-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23260-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23260-70-a2F6jx7P53@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23260

--- Comment #65 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 98064
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98064&action=edit
Bug 23260: (follow-up) Remove last_borrower updates from issues count

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 29 13:33:34 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 29 Jan 2020 12:33:34 +0000
Subject: [Koha-bugs] [Bug 24528] Add a syntax for specifying counts on
 x-koha-embed
In-Reply-To: <bug-24528-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24528-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24528-70-aXvys9bHIJ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24528

--- Comment #4 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 98065
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98065&action=edit
Bug 24528: Add a syntax to x-koha-embed to specify counts

This patch adds a + syntax to specify on the x-koha-embed header that we
want the count of a relation in the response. For example:

GET /patrons/1
x-koha-embed: checkouts+count

Would return a JSON representation of a Koha::Patron, with a new
attribute added: checkouts_count, which will be the result of calling
$patron->checkouts->count.

This is all done automatically in to_api. This patch makes parsing the
x-koha-embed header build the right structure for passing to the to_api
method.

To test:
1. Apply this patch
2. Run:
   $ kshell
  k$ prove t/Koha/REST/Plugin/Query.t
=> SUCCESS: Tests pass!
3. Sign off :-D

Sponsored-by: ByWater Solutions

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 29 13:33:59 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 29 Jan 2020 12:33:59 +0000
Subject: [Koha-bugs] [Bug 24528] Add a syntax for specifying counts on
 x-koha-embed
In-Reply-To: <bug-24528-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24528-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24528-70-PhxC1f8PRE@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24528

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff

--- Comment #5 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Ready for testing!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 29 13:34:29 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 29 Jan 2020 12:34:29 +0000
Subject: [Koha-bugs] [Bug 24528] Add a syntax for specifying counts on
 x-koha-embed
In-Reply-To: <bug-24528-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24528-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24528-70-fQEOGcdQNG@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24528

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |joonas.kylmala at helsinki.fi,
                   |                            |josef.moravec at gmail.com,
                   |                            |kyle at bywatersolutions.com,
                   |                            |nick at bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 29 13:47:23 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 29 Jan 2020 12:47:23 +0000
Subject: [Koha-bugs] [Bug 21979] Add option to SIP2 config to send arbitrary
 item field in CR instead of collection code
In-Reply-To: <bug-21979-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21979-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21979-70-StNmTqbk5I@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21979

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #93535|0                           |1
        is obsolete|                            |

--- Comment #8 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 98066
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98066&action=edit
Bug 21979: Add option to SIP2 config to send arbitrary item field in CR instead
of collection code

Some libraries need to send a different field as the collection code,
depending on how the library catalogs items. We should allow any arbitrary
item field to be used as the value for the CR field.

Test Plan:
1) Apply this patch
2) Set the new option cr_item_field to 'shelving_location'
3) Restart the SIP server
3) Perform a checkin via SIP
4) Note the CR field contains the shelving location code in the response
5) Perform an item information request
6) Note the CR field contains the shelving location code in the response

Signed-off-by: Jesse Maseto <jesse at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 29 13:48:28 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 29 Jan 2020 12:48:28 +0000
Subject: [Koha-bugs] [Bug 21979] Add option to SIP2 config to send arbitrary
 item field in CR instead of collection code
In-Reply-To: <bug-21979-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21979-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21979-70-oBvhRsGnDL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21979

--- Comment #9 from Kyle M Hall <kyle at bywatersolutions.com> ---
(In reply to Jonathan Druart from comment #7)
> Kyle, I did not test but I see:
> 
> +            $resp .= maybe_add( FID_COLLECTION_CODE,     
> $item->collection_code,     $server );
> 
> then:
> 
> +            if ( my $CR = $server->{account}->{cr_item_field} ) {
> +                $resp .= maybe_add( FID_COLLECTION_CODE, $item->{$CR} );
> +            } else {
> +                $resp .= maybe_add( FID_COLLECTION_CODE,
> $item->collection_code );
> +            }
> 
> Is that correct? (twice maybe_add with FID_COLLECTION_CODE)

Fixed! Looks like the original patch got a bad rebase perhaps.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 29 14:12:37 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 29 Jan 2020 13:12:37 +0000
Subject: [Koha-bugs] [Bug 23896] logaction should pass the correct interface
 to Koha::Logger
In-Reply-To: <bug-23896-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23896-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23896-70-LUwivZQOpB@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23896

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off
                 CC|                            |martin.renvoize at ptfs-europe
                   |                            |.com

--- Comment #6 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
This is a trivial oneliner patch and I waited three months for a signoff
without any response. Taking the liberty to switch it to Signed off myself.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 29 14:13:34 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 29 Jan 2020 13:13:34 +0000
Subject: [Koha-bugs] [Bug 24440] Add ->holds and ->holds_count to
 Koha::Acquisition::Order
In-Reply-To: <bug-24440-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24440-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24440-70-Szx7aSF2PZ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24440

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |In Discussion

--- Comment #7 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
The holds_count method will be dropped now we introduced bug 24528. But there's
still some discussion about the need for ->holds, so setting it to IN (short)
DISCUSSION.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 29 14:14:15 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 29 Jan 2020 13:14:15 +0000
Subject: [Koha-bugs] [Bug 21190] GDPR: Log successful/unsuccessful login
 attempts [part 1]
In-Reply-To: <bug-21190-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21190-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21190-70-uYpdzCwTXL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21190

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #94713|0                           |1
        is obsolete|                            |

--- Comment #25 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 98067
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98067&action=edit
Bug 21190: Prepare Log.t for further changes

This patch only makes cosmetic changes:
[1] It moves the existing tests at 'root level' inside a new subtest.
[2] It obviously adds indentation for step 1.
[3] It fixes some whitespace (tabs, space before newline)

Test plan:
Run t/db../Log.t

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 29 14:14:19 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 29 Jan 2020 13:14:19 +0000
Subject: [Koha-bugs] [Bug 21190] GDPR: Log successful/unsuccessful login
 attempts [part 1]
In-Reply-To: <bug-21190-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21190-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21190-70-BInzSFggaa@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21190

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #94714|0                           |1
        is obsolete|                            |

--- Comment #26 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 98068
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98068&action=edit
Bug 21190: Add subtest to Log.t for GDPR logging

Apart from a new subtest, doing some more cleanup:
[1] Copyright statement
[2] Removing the (unneeded) flush
[3] Removing C4::Log from the BEGIN block; we seem to skip that nowadays.
[4] $succes goes to the subtest, $schema and $dbh are global our vars.
    Not required but just what we should do if it would run under Plack.

Test plan:
Run t/db_dependent/Log.t

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 29 14:14:24 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 29 Jan 2020 13:14:24 +0000
Subject: [Koha-bugs] [Bug 21190] GDPR: Log successful/unsuccessful login
 attempts [part 1]
In-Reply-To: <bug-21190-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21190-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21190-70-p7u8a1H65O@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21190

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #94715|0                           |1
        is obsolete|                            |

--- Comment #27 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 98069
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98069&action=edit
Bug 21190: Add interfaces parameter to POD in C4::Logs

Just fixing documentation along the way.
No test plan, just read the patch.

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 29 14:14:28 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 29 Jan 2020 13:14:28 +0000
Subject: [Koha-bugs] [Bug 21190] GDPR: Log successful/unsuccessful login
 attempts [part 1]
In-Reply-To: <bug-21190-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21190-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21190-70-Uig61oSrUL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21190

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #94717|0                           |1
        is obsolete|                            |

--- Comment #28 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 98070
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98070&action=edit
Bug 21190: Remove t/Log.t

Since we have t/db../Log.t and t/Log.t simply does nothing, we would
better remove it.

No test plan either :)

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 29 14:14:33 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 29 Jan 2020 13:14:33 +0000
Subject: [Koha-bugs] [Bug 21190] GDPR: Log successful/unsuccessful login
 attempts [part 1]
In-Reply-To: <bug-21190-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21190-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21190-70-DHCVRiHI2G@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21190

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #94734|0                           |1
        is obsolete|                            |

--- Comment #29 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 98071
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98071&action=edit
Bug 21190: Introduce preferences AuthFailureLog and AuthSuccessLog

Test plan:
Run atomic update.
Check the Logs tab of preferences.

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 29 14:14:37 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 29 Jan 2020 13:14:37 +0000
Subject: [Koha-bugs] [Bug 21190] GDPR: Log successful/unsuccessful login
 attempts [part 1]
In-Reply-To: <bug-21190-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21190-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21190-70-AZ5hpDQIyO@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21190

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #94735|0                           |1
        is obsolete|                            |

--- Comment #30 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 98072
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98072&action=edit
Bug 21190: Add authentication logging to checkpw

Add optional logging for successful and failing login attempts in
checkpw.

Test plan:
Enable the preferences
Perform a good login and a bad attempt
Check action_logs

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 29 14:14:41 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 29 Jan 2020 13:14:41 +0000
Subject: [Koha-bugs] [Bug 21190] GDPR: Log successful/unsuccessful login
 attempts [part 1]
In-Reply-To: <bug-21190-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21190-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21190-70-Evmj0gAVQ7@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21190

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #94736|0                           |1
        is obsolete|                            |

--- Comment #31 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 98073
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98073&action=edit
Bug 21190: Allow browsing the system logs for AUTH events

Trivial change, adding AUTH to viewlog template only.

Test plan:
Look for the Authentication log lines in viewlog.pl (intranet tools).

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 29 14:14:46 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 29 Jan 2020 13:14:46 +0000
Subject: [Koha-bugs] [Bug 21190] GDPR: Log successful/unsuccessful login
 attempts [part 1]
In-Reply-To: <bug-21190-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21190-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21190-70-BhJ9qEchDY@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21190

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #94805|0                           |1
        is obsolete|                            |

--- Comment #32 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 98074
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98074&action=edit
Bug 21190: Add tests for authentication success and failure

Test plan:
Run t/db_dependent/Log.t

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 29 14:15:41 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 29 Jan 2020 13:15:41 +0000
Subject: [Koha-bugs] [Bug 19814] Batch Check-in function
In-Reply-To: <bug-19814-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19814-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19814-70-GuZKwt8iqk@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19814

Sebastian Hierl <s.hierl at aarome.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |s.hierl at aarome.org

--- Comment #7 from Sebastian Hierl <s.hierl at aarome.org> ---
We would welcome this feature as well and would be able to contribute to a
development.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 29 14:16:49 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 29 Jan 2020 13:16:49 +0000
Subject: [Koha-bugs] [Bug 21190] GDPR: Log successful/unsuccessful login
 attempts [part 1]
In-Reply-To: <bug-21190-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21190-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21190-70-2Oj1XxMKKA@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21190

--- Comment #33 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Last action before I obsolete this report. If you ask for a change, please be
ready to support its development by testing it too. Sending a signoff request
to the mailing list. No response means closing this report and wasted time!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 29 14:18:11 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 29 Jan 2020 13:18:11 +0000
Subject: [Koha-bugs] [Bug 24529] New: Uninitialised value warnings in
 C4::Reserves
Message-ID: <bug-24529-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24529

            Bug ID: 24529
           Summary: Uninitialised value warnings in C4::Reserves
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Architecture, internals, and plumbing
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: martin.renvoize at ptfs-europe.com
        QA Contact: testopia at bugs.koha-community.org

There is an uninitialised value warning coming from C4::Reserves which is
causing a fair bit of noise when running the circulation tests.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 29 14:21:25 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 29 Jan 2020 13:21:25 +0000
Subject: [Koha-bugs] [Bug 24529] Uninitialised value warnings in C4::Reserves
In-Reply-To: <bug-24529-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24529-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24529-70-vy7VDpXAxa@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24529

--- Comment #1 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 98075
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98075&action=edit
Bug 24529: Silence warnings for title level holds

This patch simply adds a test for itemnumber being defined in the
reserve before comparing it to silence the warning.

Test plan:
1) Prior to patch, run prove t/db_dependant/Circulation.t and note lots
   of `Use of uninitialized value in numeric eq (==) at
   /kohadevbox/koha/C4/Reserves.pm line 790` warnings.
2) Apply the patch, re-run the test and note the tests still pass but
   the warnings are now gone.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 29 14:22:09 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 29 Jan 2020 13:22:09 +0000
Subject: [Koha-bugs] [Bug 21466] Data inconsistencies - koha fields linked
 to AV cat values must have a corresponding authorised value
In-Reply-To: <bug-21466-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21466-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21466-70-cKWKE2LshC@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21466

--- Comment #15 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
See also https://gitlab.com/koha-community/koha-misc4dev/-/merge_requests/36

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 29 14:22:17 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 29 Jan 2020 13:22:17 +0000
Subject: [Koha-bugs] [Bug 21466] Data inconsistencies - koha fields linked
 to AV cat values must have a corresponding authorised value
In-Reply-To: <bug-21466-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21466-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21466-70-kRx1Lz27Xs@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21466

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 29 14:22:40 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 29 Jan 2020 13:22:40 +0000
Subject: [Koha-bugs] [Bug 21466] Data inconsistencies - koha fields linked
 to AV cat values must have a corresponding authorised value
In-Reply-To: <bug-21466-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21466-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21466-70-AdWfsaIqQV@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21466

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off
           Keywords|                            |additional_work_needed

--- Comment #16 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
I think it's ready now, but I'd like a QA review on the last patch.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 29 14:24:27 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 29 Jan 2020 13:24:27 +0000
Subject: [Koha-bugs] [Bug 19814] Batch Check-in function
In-Reply-To: <bug-19814-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19814-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19814-70-VvmQxPuMdp@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19814

--- Comment #8 from Sebastian Hierl <s.hierl at aarome.org> ---
(In reply to Sebastian Hierl from comment #7)
> We would welcome this feature as well and would be able to contribute to a
> development.

Actually, would anyone be interested in co-sponsoring? It seems that this would
be a fairly easy (and affordable) thing to implement. Perhaps just two or three
libraries coming together could make it happen.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 29 14:25:32 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 29 Jan 2020 13:25:32 +0000
Subject: [Koha-bugs] [Bug 24529] Uninitialised value warnings in C4::Reserves
In-Reply-To: <bug-24529-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24529-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24529-70-FcS3zFP4EQ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24529

--- Comment #2 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 98076
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98076&action=edit
Bug 24529: Silence another uninitialised value warning

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 29 14:25:42 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 29 Jan 2020 13:25:42 +0000
Subject: [Koha-bugs] [Bug 24529] Uninitialised value warnings in C4::Reserves
In-Reply-To: <bug-24529-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24529-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24529-70-Xa1ogdQXRn@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24529

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |martin.renvoize at ptfs-europe
                   |ity.org                     |.com

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 29 14:25:47 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 29 Jan 2020 13:25:47 +0000
Subject: [Koha-bugs] [Bug 24529] Uninitialised value warnings in C4::Reserves
In-Reply-To: <bug-24529-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24529-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24529-70-9dkPyOLMGY@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24529

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 29 14:26:50 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 29 Jan 2020 13:26:50 +0000
Subject: [Koha-bugs] [Bug 24529] Uninitialised value warnings in C4::Reserves
In-Reply-To: <bug-24529-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24529-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24529-70-sWsr7p9v4o@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24529

--- Comment #3 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Test plan:
Both t/db_dependant/Circulation.t and t/db_dependant/Reserves.t should pass
before and after the patches but after they should not contain warnings from
C4::Reserves.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 29 14:29:54 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 29 Jan 2020 13:29:54 +0000
Subject: [Koha-bugs] [Bug 24495] Reword change collection feature
In-Reply-To: <bug-24495-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24495-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24495-70-bTdX9tcY9P@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24495

--- Comment #13 from Andrew Fuerste-Henry <andrew at bywatersolutions.com> ---
Works for me!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 29 14:30:58 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 29 Jan 2020 13:30:58 +0000
Subject: [Koha-bugs] [Bug 24529] Uninitialised value warnings in C4::Reserves
In-Reply-To: <bug-24529-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24529-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24529-70-w1j6cDLhSw@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24529

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |24217
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24217
[Bug 24217] use strict for all modules
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 29 14:30:58 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 29 Jan 2020 13:30:58 +0000
Subject: [Koha-bugs] [Bug 24217] use strict for all modules
In-Reply-To: <bug-24217-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24217-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24217-70-JpByOV8RR9@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24217

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |24529


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24529
[Bug 24529] Uninitialised value warnings in C4::Reserves
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 29 14:32:16 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 29 Jan 2020 13:32:16 +0000
Subject: [Koha-bugs] [Bug 24473] Syndetics content should be $raw filtered
 on opac-detail.tt
In-Reply-To: <bug-24473-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24473-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24473-70-yor2eDRzBU@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24473

ByWater Sandboxes <bws.sandboxes at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #97679|0                           |1
        is obsolete|                            |

--- Comment #2 from ByWater Sandboxes <bws.sandboxes at gmail.com> ---
Created attachment 98077
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98077&action=edit
Bug 24473: Add $raw filter for Syndetics content

Signed-off-by: Stina Hallin <stina.hallin at ub.lu.se>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 29 14:32:57 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 29 Jan 2020 13:32:57 +0000
Subject: [Koha-bugs] [Bug 23896] logaction should pass the correct interface
 to Koha::Logger
In-Reply-To: <bug-23896-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23896-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23896-70-lcOnaO6MBz@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23896

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org
             Status|Signed Off                  |Failed QA

--- Comment #7 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Please cover this change with a test :)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 29 14:34:44 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 29 Jan 2020 13:34:44 +0000
Subject: [Koha-bugs] [Bug 18532] AUTO_RENEWALS should be a patron messaging
 preference
In-Reply-To: <bug-18532-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18532-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18532-70-DnbvdCW9t1@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18532

Agustín Moyano <agustinmoyano at theke.io> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 29 14:34:48 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 29 Jan 2020 13:34:48 +0000
Subject: [Koha-bugs] [Bug 18532] AUTO_RENEWALS should be a patron messaging
 preference
In-Reply-To: <bug-18532-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18532-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18532-70-dzXT0ZVYuU@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18532

Agustín Moyano <agustinmoyano at theke.io> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #96494|0                           |1
        is obsolete|                            |
  Attachment #96495|0                           |1
        is obsolete|                            |

--- Comment #25 from Agustín Moyano <agustinmoyano at theke.io> ---
Created attachment 98078
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98078&action=edit
Bug 18532: Add new letter AUTO_RENEWALS_DGST, new Auto_Renewals in
message_attributes, and configured message_transports

Signed-off-by: tgoat <tgoatley at gmail.com>

Signed-off-by: Kelly McElligott <kelly at bywatersolutions.com>

Signed-off-by: Marti Fuerst <mfuerst at hmcpl.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 29 14:34:53 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 29 Jan 2020 13:34:53 +0000
Subject: [Koha-bugs] [Bug 18532] AUTO_RENEWALS should be a patron messaging
 preference
In-Reply-To: <bug-18532-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18532-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18532-70-AFlWIaMKOF@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18532

--- Comment #26 from Agustín Moyano <agustinmoyano at theke.io> ---
Created attachment 98079
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98079&action=edit
Bug 18532: set auto_renewals as patron messaging preference

This patch adds the "Auto renewals" messaging preference on intranet and OPAC,
and adds digest feature to misc/cronjobs/automatic_renewals.pl script.

To test:
1. apply patches
2. perl installer/data/mysql/updatedatabase.pl
3. make sure automatic renewals are allowed in circ rules
4. grab a patron and go to details page
CHECK => patron's messaging preferences has a "Auto renewals" row
5. change autorenewals digest settings and save
6. go to opac with that same patron to "your messaging" option
CHECK => patron's messaging preferences has a "Auto renewals" row, and displays
changes made in staff interface.
7. go to patron categories in administration of staff interface and choose a
category.
CHECK => in "Default messaging preferences for this patron category" has a
"Auto renewals" row
8. set "Auto renewals" messaging preference for a patron and check email and
digest.
9. check out an item for that patron, and set it as automatic renewal and set
due date as your current date and time
10. perl misc/cronjobs/automatic_renewals.pl --send-notices -v
SUCCESS => item was renewed, and in message_queue table there now should be
message of type AUTO_RENEWALS_DGST for the patron
11. Sign off

Signed-off-by: tgoat <tgoatley at gmail.com>

Signed-off-by: Kelly McElligott <kelly at bywatersolutions.com>

Signed-off-by: Kelly McElligott <kelly at bywatersolutions.com>

Signed-off-by: Marti Fuerst <mfuerst at hmcpl.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 29 14:35:57 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 29 Jan 2020 13:35:57 +0000
Subject: [Koha-bugs] [Bug 23896] logaction should pass the correct interface
 to Koha::Logger
In-Reply-To: <bug-23896-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23896-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23896-70-S0bOQAVQf2@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23896

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #94721|0                           |1
        is obsolete|                            |

--- Comment #8 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 98080
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98080&action=edit
Bug 23896: logaction should pass the correct interface to Koha::Logger

Trivial fix.

Test plan:
Run t/db../Log.t to ensure that we did not break stuff.
If you set opac to debug in log4perl config, inspect opac-error.log to see
if you have extra loglines from running the test script.

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 29 14:39:59 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 29 Jan 2020 13:39:59 +0000
Subject: [Koha-bugs] [Bug 24526] Auto renewal cronjob should have verbose
 and test mode options
In-Reply-To: <bug-24526-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24526-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24526-70-ZfxeDu3D2I@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24526

--- Comment #3 from Andrew Fuerste-Henry <andrew at bywatersolutions.com> ---
Running the cron with only -c produces a line that just reads "would be
renewed." Items renew as expected, so some weird text is a minor problem, but
still a little weird.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 29 14:48:24 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 29 Jan 2020 13:48:24 +0000
Subject: [Koha-bugs] [Bug 24526] Auto renewal cronjob should have verbose
 and test mode options
In-Reply-To: <bug-24526-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24526-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24526-70-Vy3XOdmHHz@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24526

--- Comment #4 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 98081
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98081&action=edit
Bug 24526: (follow-up) clean up verbose conditional

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 29 14:51:07 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 29 Jan 2020 13:51:07 +0000
Subject: [Koha-bugs] [Bug 23896] logaction should pass the correct interface
 to Koha::Logger
In-Reply-To: <bug-23896-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23896-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23896-70-FbjpqyAFbX@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23896

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |16436


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16436
[Bug 16436] Allow action logs to be logged to the koha log file
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 29 14:51:07 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 29 Jan 2020 13:51:07 +0000
Subject: [Koha-bugs] [Bug 16436] Allow action logs to be logged to the koha
 log file
In-Reply-To: <bug-16436-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-16436-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-16436-70-Mzcd3I6rjg@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16436

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |23896


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23896
[Bug 23896] logaction should pass the correct interface to Koha::Logger
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 29 14:56:02 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 29 Jan 2020 13:56:02 +0000
Subject: [Koha-bugs] [Bug 24530] New: Show a number in title notes just as
 in the other tabs
Message-ID: <bug-24530-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24530

            Bug ID: 24530
           Summary: Show a number in title notes just as in the other tabs
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: OPAC
          Assignee: oleonard at myacpl.org
          Reporter: m.de.rooy at rijksmuseum.nl
        QA Contact: testopia at bugs.koha-community.org

Although we do not show an empty title notes tab [see bug 10349], the number of
notes might still be interesting just as we do for other tabs on the detail
page like holdings, subscriptions, comments, etc. Intuitively, you are also
inclined to think that there are no notes when you see a number after holdings
and no number after descriptions etc.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 29 15:04:34 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 29 Jan 2020 14:04:34 +0000
Subject: [Koha-bugs] [Bug 23896] logaction should pass the correct interface
 to Koha::Logger
In-Reply-To: <bug-23896-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23896-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23896-70-KbUTzfLXfj@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23896

--- Comment #9 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
(In reply to Jonathan Druart from comment #7)
> Please cover this change with a test :)

IRC:
[14:36] <marcelr> did you see comment4 on the report btw? it justifies the
absence of a test
[14:37] <marcelr> i considered it as out of balance

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 29 15:06:33 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 29 Jan 2020 14:06:33 +0000
Subject: [Koha-bugs] [Bug 24526] Auto renewal cronjob should have verbose
 and test mode options
In-Reply-To: <bug-24526-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24526-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24526-70-YGDgZt5fY9@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24526

ByWater Sandboxes <bws.sandboxes at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #98059|0                           |1
        is obsolete|                            |

--- Comment #5 from ByWater Sandboxes <bws.sandboxes at gmail.com> ---
Created attachment 98082
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98082&action=edit
Bug 24526: Add verbose and commit options to automatic_renewals cronjob

To test:
 1 - Apply patch
 2 - Have some items marked for auto-renewal
 3 - Run the job with no parameters
 4 - It should print 'Test mode'
 5 - Provide -v
 6 - It should print 'Test mode' then a line for each item
 7 - Provide -v -c
 8 - It should not say test mode, but should provide a line for each item
 9 - Provide -c
10 - Shoudl run as expected with no output

Signed-off-by: David Nind <david at davidnind.com>

Signed-off-by: Andrew Fuerste-Henry <andrew at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 29 15:06:36 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 29 Jan 2020 14:06:36 +0000
Subject: [Koha-bugs] [Bug 24526] Auto renewal cronjob should have verbose
 and test mode options
In-Reply-To: <bug-24526-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24526-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24526-70-vxBcvWckbX@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24526

ByWater Sandboxes <bws.sandboxes at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #98081|0                           |1
        is obsolete|                            |

--- Comment #6 from ByWater Sandboxes <bws.sandboxes at gmail.com> ---
Created attachment 98083
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98083&action=edit
Bug 24526: (follow-up) clean up verbose conditional

Signed-off-by: Andrew Fuerste-Henry <andrew at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 29 15:09:57 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 29 Jan 2020 14:09:57 +0000
Subject: [Koha-bugs] [Bug 12446] Enable an adult to have a guarantor
In-Reply-To: <bug-12446-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-12446-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12446-70-8uXybKb5Em@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12446

Andrew Fuerste-Henry <andrew at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |andrew at bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 29 15:12:49 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 29 Jan 2020 14:12:49 +0000
Subject: [Koha-bugs] [Bug 24530] Show a number in title notes just as in the
 other tabs
In-Reply-To: <bug-24530-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24530-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24530-70-PYHJtu2LTo@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24530

--- Comment #1 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Just wondering about this line in the opac-detail template:

                        [% IF ( MARCNOTES || notes || ( SyndeticsEnabled &&
SyndeticsSummary && SYNDETICS_SUMMARY )) %]

Where do we fill notes? Cant find that at first.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 29 15:25:57 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 29 Jan 2020 14:25:57 +0000
Subject: [Koha-bugs] [Bug 24279] Claims Returned does not work when set from
 moredetail.pl or additem.pl
In-Reply-To: <bug-24279-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24279-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24279-70-BzUEde9FCz@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24279

--- Comment #6 from Andrew Fuerste-Henry <andrew at bywatersolutions.com> ---
Katrin, did you mean to mark this signed off?

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 29 15:27:23 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 29 Jan 2020 14:27:23 +0000
Subject: [Koha-bugs] [Bug 24531] New: OAI-PMH sets only consider first field
 with a given tag
Message-ID: <bug-24531-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24531

            Bug ID: 24531
           Summary: OAI-PMH sets only consider first field with a given
                    tag
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: major
          Priority: P5 - low
         Component: Web services
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: magnus at libriotech.no
        QA Contact: testopia at bugs.koha-community.org

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 29 15:27:59 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 29 Jan 2020 14:27:59 +0000
Subject: [Koha-bugs] [Bug 24279] Claims Returned does not work when set from
 moredetail.pl or additem.pl
In-Reply-To: <bug-24279-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24279-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24279-70-zIfDmhMQtR@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24279

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

--- Comment #7 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Thx, Andrew! Changed status.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 29 15:31:49 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 29 Jan 2020 14:31:49 +0000
Subject: [Koha-bugs] [Bug 23493] jquery.dataTables.rowGrouping.js is no
 longer maintained,
 but there is an official DataTables version we could switch to
In-Reply-To: <bug-23493-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23493-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23493-70-JxfvB8cNoF@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23493

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |additional_work_needed

--- Comment #27 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
(In reply to Martin Renvoize from comment #26)
> Nice work everyone!
> 
> Pushed to master for 20.05

There is something very wrong here Martin. You pushed:
Bug 23493: (follow-up) Disable rowGroup on due date sort
Bug 23493: (follow-up) Switch to aDataSort for multi-column sorting
Bug 23493: Replace rowGrouping with rowGroup

They all have my signed off. However I disagreed with the last 2. Additionally
the last one has never been published here.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 29 15:38:46 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 29 Jan 2020 14:38:46 +0000
Subject: [Koha-bugs] [Bug 24531] OAI-PMH sets only consider first field with
 a given tag
In-Reply-To: <bug-24531-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24531-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24531-70-vP2HMvukwg@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24531

--- Comment #1 from Magnus Enger <magnus at libriotech.no> ---
A mapping to say that a record should be included in a OAI-PMH set if it has
the value "PDF" in field 347$b can be defined as:

Field = 347
Subfield = b
Operator = equals
Value = PDF

In C4::OAI::Sets::_evalRule, this is the code that picks out the relevant field
and subfield: 

 544     my @subfield_values = $record->subfield($field, $subfield);

But this will only return the value from the first field with tag $field, it
does not really work in array context. The code works, if your 347$b = PDF
occurs as the first 347 field, but not if it occurs in a subsequent field 347. 

So the code needs to be expanded into something like this:

my @subfield_values;
my @fields = $record->field($field);
foreach my $field ( @fields ) {
    if ( my $subfield_value = $field->subfield($subfield) ) {
        push @subfield_values, $subfield_value;
    }
}

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 29 15:43:21 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 29 Jan 2020 14:43:21 +0000
Subject: [Koha-bugs] [Bug 24531] OAI-PMH set mappings only consider first
 field with a given tag
In-Reply-To: <bug-24531-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24531-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24531-70-l54hn03w1o@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24531

Magnus Enger <magnus at libriotech.no> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|OAI-PMH sets only consider  |OAI-PMH set mappings only
                   |first field with a given    |consider first field with a
                   |tag                         |given tag

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 29 15:45:19 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 29 Jan 2020 14:45:19 +0000
Subject: [Koha-bugs] [Bug 24530] Show a number in title notes just as in the
 other tabs
In-Reply-To: <bug-24530-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24530-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24530-70-K4YdJvOhcB@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24530

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Trivial patch
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 29 15:45:21 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 29 Jan 2020 14:45:21 +0000
Subject: [Koha-bugs] [Bug 24530] Show a number in title notes just as in the
 other tabs
In-Reply-To: <bug-24530-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24530-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24530-70-lyhwISHt8o@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24530

--- Comment #2 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 98084
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98084&action=edit
Bug 24530: Show a number for title notes on opac-detail

A number (just as on most other tabs) tells more than a boolean (i.e. the
tab does not appear for zero marc notes). Intuitively, you might be misled
by "Holdings (1), Descriptions" and think there are none.

Test plan:
Verify that the number of title notes on opac detail page matches your
expectations.

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 29 15:51:10 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 29 Jan 2020 14:51:10 +0000
Subject: [Koha-bugs] [Bug 23896] logaction should pass the correct interface
 to Koha::Logger
In-Reply-To: <bug-23896-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23896-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23896-70-BtvstP90qu@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23896

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 29 15:51:13 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 29 Jan 2020 14:51:13 +0000
Subject: [Koha-bugs] [Bug 23896] logaction should pass the correct interface
 to Koha::Logger
In-Reply-To: <bug-23896-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23896-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23896-70-X9YpKM17Pj@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23896

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #98080|0                           |1
        is obsolete|                            |

--- Comment #10 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 98085
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98085&action=edit
Bug 23896: logaction should pass the correct interface to Koha::Logger

Trivial fix.

Test plan:
Run t/db../Log.t to ensure that we did not break stuff.
If you set opac to debug in log4perl config, inspect opac-error.log to see
if you have extra loglines from running the test script.

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 29 15:55:50 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 29 Jan 2020 14:55:50 +0000
Subject: [Koha-bugs] [Bug 24530] Show a number in title notes just as in the
 other tabs
In-Reply-To: <bug-24530-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24530-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24530-70-ccPDHuApBN@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24530

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|oleonard at myacpl.org         |m.de.rooy at rijksmuseum.nl

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 29 15:55:56 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 29 Jan 2020 14:55:56 +0000
Subject: [Koha-bugs] [Bug 24532] New: Some account types are converted to
 debits when they shouldn't be
Message-ID: <bug-24532-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24532

            Bug ID: 24532
           Summary: Some account types are converted to debits when they
                    shouldn't be
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: Fines and fees
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: nick at bywatersolutions.com
        QA Contact: testopia at bugs.koha-community.org

Bug 23049 converts some credit types to debit types

The logic seems to be:
1 - Get all unique types where the accountline is a debit
2 - Convert all lines with these types to have debit codes

But in step 1 if we have any type 'Pay' or 'W' for example, where the amount is
greater than 0 (pathological credits which have debit amounts) then 'Pay' is
added as a debit type and all 'Pay' lines get that as a debit code.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 29 15:56:11 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 29 Jan 2020 14:56:11 +0000
Subject: [Koha-bugs] [Bug 24532] Some account types are converted to debits
 when they shouldn't be
In-Reply-To: <bug-24532-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24532-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24532-70-TKbPH2gW0s@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24532

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|normal                      |major
           Assignee|koha-bugs at lists.koha-commun |martin.renvoize at ptfs-europe
                   |ity.org                     |.com

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 29 15:57:49 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 29 Jan 2020 14:57:49 +0000
Subject: [Koha-bugs] [Bug 24530] Show a number in title notes just as in the
 other tabs of opac detail page
In-Reply-To: <bug-24530-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24530-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24530-70-ytXX0GpOUy@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24530

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Show a number in title      |Show a number in title
                   |notes just as in the other  |notes just as in the other
                   |tabs                        |tabs of opac detail page

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 29 15:57:52 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 29 Jan 2020 14:57:52 +0000
Subject: [Koha-bugs] [Bug 24529] Uninitialised value warnings in C4::Reserves
In-Reply-To: <bug-24529-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24529-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24529-70-rT05RA8ny6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24529

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 29 15:57:55 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 29 Jan 2020 14:57:55 +0000
Subject: [Koha-bugs] [Bug 24529] Uninitialised value warnings in C4::Reserves
In-Reply-To: <bug-24529-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24529-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24529-70-CWigr4gv0j@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24529

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #98075|0                           |1
        is obsolete|                            |
  Attachment #98076|0                           |1
        is obsolete|                            |

--- Comment #4 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 98086
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98086&action=edit
Bug 24529: Silence warnings for title level holds

This patch simply adds a test for itemnumber being defined in the
reserve before comparing it to silence the warning.

Test plan:
1) Prior to patch, run prove t/db_dependant/Circulation.t and note lots
   of `Use of uninitialized value in numeric eq (==) at
   /kohadevbox/koha/C4/Reserves.pm line 790` warnings.
2) Apply the patch, re-run the test and note the tests still pass but
   the warnings are now gone.

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 29 15:57:58 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 29 Jan 2020 14:57:58 +0000
Subject: [Koha-bugs] [Bug 24529] Uninitialised value warnings in C4::Reserves
In-Reply-To: <bug-24529-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24529-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24529-70-FH4saoAXXW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24529

--- Comment #5 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 98087
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98087&action=edit
Bug 24529: Silence another uninitialised value warning

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 29 15:59:47 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 29 Jan 2020 14:59:47 +0000
Subject: [Koha-bugs] [Bug 24528] Add a syntax for specifying counts on
 x-koha-embed
In-Reply-To: <bug-24528-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24528-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24528-70-4PtHzdCHD1@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24528

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |m.de.rooy at rijksmuseum.nl

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 29 16:50:16 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 29 Jan 2020 15:50:16 +0000
Subject: [Koha-bugs] [Bug 8132] Batch delete tool deletes items with holds
 on them
In-Reply-To: <bug-8132-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-8132-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8132-70-XABXPjj39K@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8132

--- Comment #44 from Kelly McElligott <kelly at bywatersolutions.com> ---
Hi Martin,
Attempted to sign off on this bug Martin, 
Looks like something in the Bug that this is dependant (23463) on has changed,
I received this error while testing:


Template process failed: undef error - The method Koha::Item->safe_to_delete is
not covered by tests!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 29 17:22:53 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 29 Jan 2020 16:22:53 +0000
Subject: [Koha-bugs] [Bug 24533] New: Improved sorting in checkouts table
Message-ID: <bug-24533-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24533

            Bug ID: 24533
           Summary: Improved sorting in checkouts table
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Circulation
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: martin.renvoize at ptfs-europe.com
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com

The sorting in the checkouts table regressed with bug 23493.

Before the patch:

* Initial table load would group the results by "Today's checkouts" and
"Previous checkouts".
* Any subsequent column sort would disable the grouping entirely.

After the patch:

* Initial table load groups the results by "Today's checkouts" and "Previous
checkouts".
* Any subsequent column sort will sort by that column, but leave the group
titles intact. As such, sorting by title for example can end up with multiple
"Today's checkouts" header rows which is confusing.

I propose that for all column sorts, with the exception of due date, we perform
a primary sort on the grouping field followed by a secondary sort on the column
in question.  This way we maintain the grouping and just sort within the
groups.

For the due date column sort I propose sorting directly on due date and
removing the grouping header rows entirely.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 29 17:23:07 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 29 Jan 2020 16:23:07 +0000
Subject: [Koha-bugs] [Bug 24533] Improved sorting in checkouts table
In-Reply-To: <bug-24533-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24533-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24533-70-988xog0CBg@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24533

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |23493


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23493
[Bug 23493] jquery.dataTables.rowGrouping.js is no longer maintained, but there
is an official DataTables version we could switch to
-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 29 17:23:07 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 29 Jan 2020 16:23:07 +0000
Subject: [Koha-bugs] [Bug 23493] jquery.dataTables.rowGrouping.js is no
 longer maintained,
 but there is an official DataTables version we could switch to
In-Reply-To: <bug-23493-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23493-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23493-70-hY30Z4mQeI@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23493

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |24533


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24533
[Bug 24533] Improved sorting in checkouts table
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 29 17:27:09 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 29 Jan 2020 16:27:09 +0000
Subject: [Koha-bugs] [Bug 24533] Improved sorting in checkouts table
In-Reply-To: <bug-24533-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24533-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24533-70-n38k6bCcG5@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24533

--- Comment #1 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 98088
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98088&action=edit
Bug 24533: Switch to aDataSort for multi-column sorting

This patch adds aDataSort configurations for each sortable column such
that we always maintain the group sorting primarily and apply a
secondary sort using the column in question.

When sorting by due date you are much more likely to want the true date
sorting without forcing a primary sort on the grouping column. We achieve
that by removing the primary sort on checkout date and disable rowGrouping
in such a case.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 29 17:27:21 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 29 Jan 2020 16:27:21 +0000
Subject: [Koha-bugs] [Bug 24533] Improved sorting in checkouts table
In-Reply-To: <bug-24533-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24533-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24533-70-bWBA9mUW7E@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24533

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 29 17:27:29 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 29 Jan 2020 16:27:29 +0000
Subject: [Koha-bugs] [Bug 24533] Improved sorting in checkouts table
In-Reply-To: <bug-24533-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24533-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24533-70-9QpCHN7YWl@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24533

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |martin.renvoize at ptfs-europe
                   |ity.org                     |.com

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 29 17:30:59 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 29 Jan 2020 16:30:59 +0000
Subject: [Koha-bugs] [Bug 24533] Improved sorting in checkouts table
In-Reply-To: <bug-24533-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24533-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24533-70-iD7Pca1ngB@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24533

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |oleonard at myacpl.org

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 29 17:31:19 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 29 Jan 2020 16:31:19 +0000
Subject: [Koha-bugs] [Bug 24533] Improved sorting in checkouts table
In-Reply-To: <bug-24533-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24533-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24533-70-VTTJ2mGtY3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24533

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |lucas at bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 29 17:39:03 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 29 Jan 2020 16:39:03 +0000
Subject: [Koha-bugs] [Bug 15516] Allow to place a hold on first available
 item from a group of titles
In-Reply-To: <bug-15516-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15516-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15516-70-i1uoOJJj2H@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516

--- Comment #213 from Owen Leonard <oleonard at myacpl.org> ---
(In reply to Martin Renvoize from comment #212)
> Are you hoping to pick this back up at some point Julian or are you hoping
> someone will adopt it?

I second this question! My library is looking for something like this.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 29 17:44:10 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 29 Jan 2020 16:44:10 +0000
Subject: [Koha-bugs] [Bug 24376] Wording of Fine Returned is confusing
In-Reply-To: <bug-24376-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24376-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24376-70-bslJP7VVHc@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24376

amanda.jones at williamsoncounty-tn.gov changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |amanda.jones at williamsoncoun
                   |                            |ty-tn.gov

--- Comment #3 from amanda.jones at williamsoncounty-tn.gov ---
We also take issue with the wording (Returned). We prefer the to replace it
with (Outstanding) as Final may not be the case if that item is renewed and
then becomes late again.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 29 17:47:01 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 29 Jan 2020 16:47:01 +0000
Subject: [Koha-bugs] [Bug 24534] New: Selection Options for Importing Staged
 MARC Records
Message-ID: <bug-24534-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24534

            Bug ID: 24534
           Summary: Selection Options for Importing Staged MARC Records
 Change sponsored?: ---
           Product: Koha
           Version: unspecified
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Tools
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: jzairo at bywatersolutions.com
        QA Contact: testopia at bugs.koha-community.org

It would be great to have a selection option in the Staged MARD Management tool
that allowed you to choose which bibliographic records get imported into the
system. Right now the only option is to import all records. 

Sometimes librarians get records from vendors where the record may have errors
or not be complete. It would be great to have an option to select the records
you want to import on /koha/tools/manage-marc-import.pl

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 29 17:47:12 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 29 Jan 2020 16:47:12 +0000
Subject: [Koha-bugs] [Bug 23493] jquery.dataTables.rowGrouping.js is no
 longer maintained,
 but there is an official DataTables version we could switch to
In-Reply-To: <bug-23493-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23493-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23493-70-sFH4GghbHc@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23493

--- Comment #28 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Corrected by reverting the errantly pushed patches and applying the followup
here instead.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 29 17:47:39 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 29 Jan 2020 16:47:39 +0000
Subject: [Koha-bugs] [Bug 24534] Selection Options for Importing Staged MARC
 Records
In-Reply-To: <bug-24534-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24534-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24534-70-N7cqGxmM2W@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24534

Jessie Zairo <jzairo at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |kelly at bywatersolutions.com,
                   |                            |nick at bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 29 18:01:14 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 29 Jan 2020 17:01:14 +0000
Subject: [Koha-bugs] [Bug 8132] Batch delete tool deletes items with holds
 on them
In-Reply-To: <bug-8132-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-8132-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8132-70-zwAf0u1SAK@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8132

--- Comment #45 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
(In reply to Kelly McElligott from comment #44)
> Hi Martin,
> Attempted to sign off on this bug Martin, 
> Looks like something in the Bug that this is dependant (23463) on has
> changed, I received this error while testing:
> 
> 
> Template process failed: undef error - The method Koha::Item->safe_to_delete
> is not covered by tests!

Hi Kelly, are you able to use the remote branch? You should be able to specify
it if you are using the sandboxes.
The problem is that the patches from bug 23463 are not attached to the bug
report (but also on a remote branch).

The remote branch https://gitlab.com/joubu/Koha/commits/bug_8132 contains all
the necessary commits.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 29 18:37:12 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 29 Jan 2020 17:37:12 +0000
Subject: [Koha-bugs] [Bug 15516] Allow to place a hold on first available
 item from a group of titles
In-Reply-To: <bug-15516-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15516-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15516-70-b7JN90tFZc@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516

--- Comment #214 from Julian Maurice <julian.maurice at biblibre.com> ---
(In reply to Martin Renvoize from comment #212)
> Are you hoping to pick this back up at some point Julian or are you hoping
> someone will adopt it?

I'm always hoping to have the time to work on patches I submitted, but that
shouldn't stop people to rebase them, or submit follow-up patches.
I certainly won't be mad if someone other than me make it pass QA :D

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 29 18:55:09 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 29 Jan 2020 17:55:09 +0000
Subject: [Koha-bugs] [Bug 18532] AUTO_RENEWALS should be a patron messaging
 preference
In-Reply-To: <bug-18532-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18532-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18532-70-VpdN24kQAn@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18532

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Version|unspecified                 |master

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 29 19:09:58 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 29 Jan 2020 18:09:58 +0000
Subject: [Koha-bugs] [Bug 18532] AUTO_RENEWALS should be a patron messaging
 preference
In-Reply-To: <bug-18532-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18532-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18532-70-PA2vAVmPkE@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18532

--- Comment #27 from Agustín Moyano <agustinmoyano at theke.io> ---
(In reply to Catherine E. Ingram from comment #21)
> We were playing around with it this morning and wondered about roll out. 
> The way it looked in the sandbox was that it would default to all existing
> patrons getting NO notices (with both email and digest un-checked). Did
> anyone else encounter this?  
> ~Catherine

Hi Catherine, you were right.. I believed that if I didn't add that preference
on patrons that already had preferences setted, Koha would break, but it didn't
happen at the end.

Thanks for spotting that out.

Can you please try it out again?

Thanks.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 29 19:39:31 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 29 Jan 2020 18:39:31 +0000
Subject: [Koha-bugs] [Bug 24377] Record branch in statistics for auto-renewal
In-Reply-To: <bug-24377-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24377-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24377-70-Ncshf31q05@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24377

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 29 19:44:26 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 29 Jan 2020 18:44:26 +0000
Subject: [Koha-bugs] [Bug 21791] Add payment type on Cash register report
 (cash_register_stats.pl)
In-Reply-To: <bug-21791-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21791-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21791-70-RfW4YXAb4e@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21791

Eric Phetteplace <ephetteplace at cca.edu> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |ephetteplace at cca.edu

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 29 20:25:49 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 29 Jan 2020 19:25:49 +0000
Subject: [Koha-bugs] [Bug 23673] Separate time sent from time created in
 message_queue table
In-Reply-To: <bug-23673-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23673-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23673-70-7afuVjvFnu@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23673

Agustín Moyano <agustinmoyano at theke.io> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #96451|0                           |1
        is obsolete|                            |
  Attachment #96452|0                           |1
        is obsolete|                            |
  Attachment #96643|0                           |1
        is obsolete|                            |

--- Comment #19 from Agustín Moyano <agustinmoyano at theke.io> ---
Created attachment 98090
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98090&action=edit
Bug 23673: change db structure

Signed-off-by: Kelly McElligott <kelly at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 29 20:25:53 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 29 Jan 2020 19:25:53 +0000
Subject: [Koha-bugs] [Bug 23673] Separate time sent from time created in
 message_queue table
In-Reply-To: <bug-23673-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23673-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23673-70-vzoLOhSNdr@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23673

--- Comment #20 from Agustín Moyano <agustinmoyano at theke.io> ---
Created attachment 98091
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98091&action=edit
Bug 23673: Add "Updated on" column to patron's notices

This patch adds "Updated on" column to patron's notices tab. It also adds logic
to C4::Letters to retrieve updated_on column.

To test:

1. Apply patches.

2. Restart plack.

3. Choose a patron and add a purchase suggestion.

4. Change suggestion status.

5. Open patron's notifications.
CHECK => Messages table has now "Updated on" and "Time created" columns, and
"Time" column is gone.
SUCCESS => There is a message with status pending, with a "time created" that
equals "updated on"

6. Execute in the shell in Koha directory

   $ ./misc/cronjobs/process_message_queue.pl

7. Open patron's notifications one more time.
SUCCESS => The message changed status. Time created remained the same, and now
"updated on" has the current timestamp.

8. Resend the message and repeat sep 6.
SUCCESS => Every time you change the status, time created remains the same and
updated on updates.

9. prove t/db_dependant/Letters.t

10. Sign off

Signed-off-by: Kelly McElligott <kelly at bywatersolutions.com>

Signed-off-by: Kelly McElligott <kelly at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 29 20:53:59 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 29 Jan 2020 19:53:59 +0000
Subject: [Koha-bugs] [Bug 24377] Record branch in statistics for auto-renewal
In-Reply-To: <bug-24377-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24377-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24377-70-RtZm2VNYPe@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24377

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|normal                      |major

--- Comment #7 from Nick Clemens <nick at bywatersolutions.com> ---
Bumping to major, this causes data loss for statistics

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 29 20:55:36 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 29 Jan 2020 19:55:36 +0000
Subject: [Koha-bugs] [Bug 24194] Add system preference to disable the use of
 expiration dates for reserves
In-Reply-To: <bug-24194-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24194-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24194-70-kcGhpcHKKM@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24194

Aleisha Amohia <aleisha at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Add system preference to    |Add system preference to
                   |hide expiration date        |disable the use of
                   |options for reserves        |expiration dates for
                   |                            |reserves

--- Comment #7 from Aleisha Amohia <aleisha at catalyst.net.nz> ---
(In reply to Katrin Fischer from comment #6)
> (In reply to Aleisha Amohia from comment #5)
> > (In reply to Jonathan Druart from comment #3)
> > > Should not it be hidden locally in CSS or JS instead?
> > 
> > It turns out the library wants to not use expiration dates for reserves at
> > all, so the latest patch now includes not setting an expiration date when
> > setting a reserve as waiting, and nullifying an expiration date when
> > reverting waiting status. Back to needs signoff, with a new test plan.
> 
> Hi Aleisha, can you please update the bug title? Sounds like quite a
> different thing now!

Fair enough Katrin, have updated!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 29 22:17:46 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 29 Jan 2020 21:17:46 +0000
Subject: [Koha-bugs] [Bug 24376] Wording of Fine Returned is confusing
In-Reply-To: <bug-24376-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24376-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24376-70-ib8ddYDeiy@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24376

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |martin.renvoize at ptfs-europe
                   |                            |.com

--- Comment #4 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
(In reply to amanda.jones from comment #3)
> We also take issue with the wording (Returned). We prefer the to replace it
> with (Outstanding) as Final may not be the case if that item is renewed and
> then becomes late again.

Hi Amanda, if the item is renewed and becomes overdue again, this will create a
new line in the accounting table (fine accrueing). But I think that's another
reason why returned might not be a good pick here - if it's also used for
renewals?

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 29 22:18:59 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 29 Jan 2020 21:18:59 +0000
Subject: [Koha-bugs] [Bug 24535] New: Add the ability to have longer
 barcodes than 20 digits
Message-ID: <bug-24535-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24535

            Bug ID: 24535
           Summary: Add the ability to have longer barcodes than 20 digits
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Cataloging
          Assignee: nick at bywatersolutions.com
          Reporter: kelly at bywatersolutions.com
        QA Contact: testopia at bugs.koha-community.org
                CC: m.de.rooy at rijksmuseum.nl

Currently, in Koha, an item's barcode can only be up to 20 digits, it would be
nice to increase this value to possibly a higher number such as 32.  Koha
recently increased the patron's barcode length to 32 and it was helpful to
libraries.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 29 22:29:30 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 29 Jan 2020 21:29:30 +0000
Subject: [Koha-bugs] [Bug 19814] Batch Check-in function
In-Reply-To: <bug-19814-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19814-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19814-70-U7FIBSBnEV@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19814

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de
  Change sponsored?|---                         |Seeking cosponsors

--- Comment #9 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
(In reply to Sebastian Hierl from comment #8)
> (In reply to Sebastian Hierl from comment #7)
> > We would welcome this feature as well and would be able to contribute to a
> > development.
> 
> Actually, would anyone be interested in co-sponsoring? It seems that this
> would be a fairly easy (and affordable) thing to implement. Perhaps just two
> or three libraries coming together could make it happen.

Hi Sebastian, I've set 'seeking cosponsors' in the Change sponsored? field.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 29 22:47:27 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 29 Jan 2020 21:47:27 +0000
Subject: [Koha-bugs] [Bug 23915] Replace OPAC list sort menu with Bootstrap
 menu button
In-Reply-To: <bug-23915-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23915-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23915-70-5NfTM7HMN3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23915

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 29 22:47:30 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 29 Jan 2020 21:47:30 +0000
Subject: [Koha-bugs] [Bug 23915] Replace OPAC list sort menu with Bootstrap
 menu button
In-Reply-To: <bug-23915-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23915-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23915-70-FcuG7BHtrP@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23915

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #98045|0                           |1
        is obsolete|                            |

--- Comment #9 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 98092
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98092&action=edit
Bug 23915: Replace OPAC list sort menu with Bootstrap menu button

This patch adds JavaScript to the list contents page which converts the
resort form's <select> menu into a Bootstrap dropdown menu. This allows
for a more compact and consistent display.

To test, apply the patch and regenerate the OPAC CSS
(https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client).

View a list in the OPAC. The toolbar of list controls ("New list,"
"Download list," etc.) should have a similary-styled "Sort" button. Each
sorting option should work correctly.

Signed-off-by: David Nind <david at davidnind.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 29 22:51:36 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 29 Jan 2020 21:51:36 +0000
Subject: [Koha-bugs] [Bug 23031] Improve UX of buttons on order search page
In-Reply-To: <bug-23031-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23031-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23031-70-pwmbkhI4xw@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23031

--- Comment #5 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
If I understand this correctly, the 'view' is on the basket name link and the
'add to order' is default action on the button?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 29 22:54:44 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 29 Jan 2020 21:54:44 +0000
Subject: [Koha-bugs] [Bug 23031] Improve UX of buttons on order search page
In-Reply-To: <bug-23031-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23031-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23031-70-RfBHtoOOR5@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23031

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 29 22:54:48 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 29 Jan 2020 21:54:48 +0000
Subject: [Koha-bugs] [Bug 23031] Improve UX of buttons on order search page
In-Reply-To: <bug-23031-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23031-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23031-70-sABFCT720u@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23031

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #97409|0                           |1
        is obsolete|                            |

--- Comment #6 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 98093
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98093&action=edit
Bug 23031: Make 'add to basket' accessible in one click (fix regression)

Since bug 21364 we have 'view' then 'add to basket' that is accessible
in 2 clicks. We should have it directly accessible.

Test plan:
Create a new basket
Add a new order to the basket (note that the link is directly
accessible)
When a new order is added you can close the basket from the basket list
view
Note that the dropdown button displays correctly

Signed-off-by: Owen Leonard <oleonard at myacpl.org>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 29 23:00:09 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 29 Jan 2020 22:00:09 +0000
Subject: [Koha-bugs] [Bug 24536] New: Move itemtype on suggestions table
 into its own column
Message-ID: <bug-24536-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24536

            Bug ID: 24536
           Summary: Move itemtype on suggestions table into its own column
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Acquisitions
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: katrin.fischer at bsz-bw.de
        QA Contact: testopia at bugs.koha-community.org

the itemtype on the suggestions page in acq is part of the suggestion (title)
information. It would be nice if it was sortable in its own column.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 29 23:01:49 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 29 Jan 2020 22:01:49 +0000
Subject: [Koha-bugs] [Bug 23594] Batch modification for itemtypes on
 suggestions page
In-Reply-To: <bug-23594-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23594-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23594-70-Z7ZLccK8H2@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23594

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Small patch
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 29 23:01:52 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 29 Jan 2020 22:01:52 +0000
Subject: [Koha-bugs] [Bug 23594] Batch modification for itemtypes on
 suggestions page
In-Reply-To: <bug-23594-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23594-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23594-70-FcWOeb4yRH@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23594

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #97781|0                           |1
        is obsolete|                            |

--- Comment #23 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 98094
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98094&action=edit
Bug 23594: Fix bad resolution conflict with bug 16784

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 29 23:02:20 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 29 Jan 2020 22:02:20 +0000
Subject: [Koha-bugs] [Bug 23594] Batch modification for itemtypes on
 suggestions page
In-Reply-To: <bug-23594-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23594-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23594-70-ChNpHiSrg0@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23594

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #97663|0                           |1
        is obsolete|                            |

--- Comment #24 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 98095
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98095&action=edit
Bug 23594: Batch modification for itemtypes on suggestions page

This new enhancement adds the ability to update the item types for
selected suggestions on the suggestions management page
(suggestion/suggestion.pl)

To achieve this goal we needed to refresh a bit the template, in order
to get rid of weird code. To not recreate the previous coding awkwardness
some code has been rewritten (mainly the removal of suggestiontype)

Test plan:
- Create some suggestions
- On the suggestions management page, select some of them and a new item
types.
- Submit the form and confirm that the itemtype of the suggestions has
been updated

- Also you should confirm that the "delete" and "change status" still
work as before

Sponsored-by: BULAC - http://www.bulac.fr/

Signed-off-by: Séverine QUEUNE <severine.queune at bulac.fr>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 29 23:02:25 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 29 Jan 2020 22:02:25 +0000
Subject: [Koha-bugs] [Bug 23594] Batch modification for itemtypes on
 suggestions page
In-Reply-To: <bug-23594-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23594-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23594-70-yT3NegwAk0@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23594

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #97664|0                           |1
        is obsolete|                            |

--- Comment #25 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 98096
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98096&action=edit
Bug 23594: Fix [un]checkall links

Sponsored-by: BULAC - http://www.bulac.fr/

Signed-off-by: Séverine QUEUNE <severine.queune at bulac.fr>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 29 23:02:30 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 29 Jan 2020 22:02:30 +0000
Subject: [Koha-bugs] [Bug 23594] Batch modification for itemtypes on
 suggestions page
In-Reply-To: <bug-23594-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23594-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23594-70-lSm4cGv29J@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23594

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #97665|0                           |1
        is obsolete|                            |

--- Comment #26 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 98097
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98097&action=edit
Bug 23594: Restore previous view after delete or update itemtype

We want to restore the previous view when suggestions are deleted or
their itemtypes are updated.
To avoid c/p the code is moved to a new subroutine.

Sponsored-by: BULAC - http://www.bulac.fr/

Signed-off-by: Séverine QUEUNE <severine.queune at bulac.fr>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 29 23:02:34 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 29 Jan 2020 22:02:34 +0000
Subject: [Koha-bugs] [Bug 23594] Batch modification for itemtypes on
 suggestions page
In-Reply-To: <bug-23594-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23594-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23594-70-OiPyFREBVm@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23594

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #97693|0                           |1
        is obsolete|                            |

--- Comment #27 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 98098
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98098&action=edit
Bug 23594: Add missing html filters

Also fixes the following QA failure:
forbidden pattern: Attribute type should not be used for script tags (bug
20053) (line 840)

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 29 23:02:38 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 29 Jan 2020 22:02:38 +0000
Subject: [Koha-bugs] [Bug 23594] Batch modification for itemtypes on
 suggestions page
In-Reply-To: <bug-23594-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23594-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23594-70-iVABC9RXyv@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23594

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #98094|0                           |1
        is obsolete|                            |

--- Comment #28 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 98099
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98099&action=edit
Bug 23594: Fix bad resolution conflict with bug 16784

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 29 23:03:32 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 29 Jan 2020 22:03:32 +0000
Subject: [Koha-bugs] [Bug 23594] Batch modification for itemtypes on
 suggestions page
In-Reply-To: <bug-23594-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23594-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23594-70-3ui3OuX1sq@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23594

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=24536

--- Comment #29 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Filed bug 24536 for adding a new column for itemtype.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 29 23:03:32 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 29 Jan 2020 22:03:32 +0000
Subject: [Koha-bugs] [Bug 24536] Move itemtype on suggestions table into its
 own column
In-Reply-To: <bug-24536-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24536-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24536-70-nftlKqiWZm@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24536

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=23594

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 29 23:11:21 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 29 Jan 2020 22:11:21 +0000
Subject: [Koha-bugs] [Bug 23590] Allow to modify the manager of a suggestion
In-Reply-To: <bug-23590-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23590-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23590-70-ZnDRCHGizv@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23590

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Patch doesn't apply
                 CC|                            |katrin.fischer at bsz-bw.de

--- Comment #52 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Onto the next one... Jonathan, can you please rebase?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 29 23:22:41 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 29 Jan 2020 22:22:41 +0000
Subject: [Koha-bugs] [Bug 24376] Wording of Fine Returned is confusing
In-Reply-To: <bug-24376-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24376-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24376-70-twR8zrwDbC@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24376

--- Comment #5 from amanda.jones at williamsoncounty-tn.gov ---
Patrons can also see this wording on the OPAC. They might be thrown off by one
fine stating FINAL then seeing that fine begin to accrue again.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 29 23:28:54 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 29 Jan 2020 22:28:54 +0000
Subject: [Koha-bugs] [Bug 24376] Wording of Fine Returned is confusing
In-Reply-To: <bug-24376-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24376-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24376-70-he0zhHxnn7@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24376

--- Comment #6 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
I agree about final not being ideal. Not being a native speaker probably
doesn't help much here... but is the opposite of an accrueing fine?

Static? 
Frozen?
just: Fine 
Unpaid?

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 29 23:36:45 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 29 Jan 2020 22:36:45 +0000
Subject: [Koha-bugs] [Bug 22868] Circulation staff with suggestions_manage
 can have access to acquisition data
In-Reply-To: <bug-22868-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22868-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22868-70-m7ti7qayNf@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22868

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Small patch
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 29 23:36:48 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 29 Jan 2020 22:36:48 +0000
Subject: [Koha-bugs] [Bug 22868] Circulation staff with suggestions_manage
 can have access to acquisition data
In-Reply-To: <bug-22868-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22868-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22868-70-eetJc2oE4r@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22868

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #97951|0                           |1
        is obsolete|                            |

--- Comment #27 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 98100
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98100&action=edit
Bug 22868: Move suggestions_manage subperm out of acquisition perm

Bug 11911 replaced the permission of suggestions.pl (create a purchase
suggestion) from catalogue => 1 to acquisition => 'suggestions_manage'.
However we have a lot of acquisition scripts that have lax permissions
(acquisition => '*' which means any sub permissions of acquisition is
enough).

That causes problem when a circulation staff can create purchase
suggestions but not access acquisition information.

One solution is to move the suggestions_manage subpermission out of the
acquisition permission and create a new suggestion permission.

Test plan:
0. Setup
* Create a patron with several permission (and full acquisition
permission)
* Create another patron with several permission, and suggestions_manage
permission
* Create another patron without the suggestions_manage permission
1. Apply the patch and execute the update database entry
2. Note that the third patron you create still does not have
suggestions_manage
3. Confirm that you can create a purchase suggestion if you have
suggestions_manage, but cannot access acquisition pages if you do not
have any subpermissions of the acquisition permission

Signed-off-by: Hayley Mapley <hayleymapley at catalyst.net.nz>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 29 23:40:36 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 29 Jan 2020 22:40:36 +0000
Subject: [Koha-bugs] [Bug 22868] Circulation staff with suggestions_manage
 can have access to acquisition data
In-Reply-To: <bug-22868-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22868-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22868-70-b64MVf545M@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22868

--- Comment #28 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
This patch will fix the regression found (see comments before), for further
improving/splitting permissions, it would be great if separate bug reports
could be reported.

There are small glitches:
- The top permission has one sub permission now. It might have been slightly
more consistent to have it only as a top level module permission, but seeing
requests here for more granular permissions, this might see more work later.
- The breadcrumbs show Acquisitions, but when you click on it, you got no
permission. I am not seeing this as a blocker, as this is what we had before
the regression was introduced. So I think we can think about this separately.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 29 23:45:40 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 29 Jan 2020 22:45:40 +0000
Subject: [Koha-bugs] [Bug 24347] Add a 'search to order' option similar to
 'search to hold'
In-Reply-To: <bug-24347-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24347-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24347-70-ZwOjcavcMm@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24347

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |Manual
         QA Contact|testopia at bugs.koha-communit |katrin.fischer at bsz-bw.de
                   |y.org                       |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 29 23:53:54 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 29 Jan 2020 22:53:54 +0000
Subject: [Koha-bugs] [Bug 24347] Add a 'search to order' option similar to
 'search to hold'
In-Reply-To: <bug-24347-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24347-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24347-70-OzXBU4XeDP@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24347

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 29 23:53:57 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 29 Jan 2020 22:53:57 +0000
Subject: [Koha-bugs] [Bug 24347] Add a 'search to order' option similar to
 'search to hold'
In-Reply-To: <bug-24347-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24347-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24347-70-XgxiFk2M9i@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24347

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #97948|0                           |1
        is obsolete|                            |

--- Comment #6 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 98101
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98101&action=edit
Bug 24347: Add a 'search to order' option similar to 'search to hold'

This patch modifes the process of searching for an existing record
to add to a basket. Now the search is performed as a keyword search in
the regular catalog rather than via a custom search script. Options are
added to the search results and detail pages to add results to an order.

This process follows the same pattern as the "Search to hold" feature:
When the search is initiated, a cookie is set with the requisite
information--in this case vendor id and basket number.

If the search results or bibliographic detail pages detect that a
"searchToOrder" cookie is present, the correct "Add order" link will be
shown. Like with the "search to hold" feature, the cookie expires in 10
minutes.

To test, apply the patch and log into the staff client as a user who has
permission to add to a basket in acquisitions.

 - Go to Acquisitions -> Vendor -> Basket -> Add to basket.
 - Using the "From an existing record" option, perform a search.
 - On the search results page, test the "Add order" link which appears
   with each result. Clicking the link should take you to the "New
   order" page for the correct vendor and basket. The catalog
   details section of the form should include the correct information.
 - From the search results page view the bibliographic details page for
   any record. There should be a new toolbar button, "Add order." Verify
   that it works correctly.
   - Test the same thing from all bibliographic detail pages: Normal,
     MARC, Labeled MARC, ISBD, as well as the items page
     (moredetail.pl).
 - Test this process for both the locations in acquisitions where one
   can add to an existing basket: Vendor search results and the basket
   detail page
 - Test the cookie timeout: Wait 10 minutes and perform another catalog
   search. The "Add order" link should no longer be present.

Signed-off-by: David Nind <david at davidnind.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 29 23:54:01 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 29 Jan 2020 22:54:01 +0000
Subject: [Koha-bugs] [Bug 24347] Add a 'search to order' option similar to
 'search to hold'
In-Reply-To: <bug-24347-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24347-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24347-70-6JkTtdxoFk@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24347

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #97949|0                           |1
        is obsolete|                            |

--- Comment #7 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 98102
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98102&action=edit
Bug 24347: (follow-up) Remove custom catalog search from acquisitions

This patch removes the "neworderbiblio" script and template which are
made obsolete by the "search to order" feature.

deleted:    acqui/neworderbiblio.pl
deleted:    koha-tmpl/intranet-tmpl/prog/en/modules/acqui/neworderbiblio.tt

Some documentation in addorder.pl has been corrected to remove reference
to neworderbiblio.pl.

To test, apply the patch and verify that the correct files have been
removed.

Search the Koha codebase to verify that no links to
acqui/neworderbiblio.pl remain.

Signed-off-by: David Nind <david at davidnind.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 29 23:54:58 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 29 Jan 2020 22:54:58 +0000
Subject: [Koha-bugs] [Bug 24456] previousIssuesDefaultSortOrder and
 todaysIssuesDefaultSortOrder sort incorrectly
In-Reply-To: <bug-24456-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24456-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24456-70-lElg3Lwpf2@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24456

ByWater Sandboxes <bws.sandboxes at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #97580|0                           |1
        is obsolete|                            |

--- Comment #2 from ByWater Sandboxes <bws.sandboxes at gmail.com> ---
Created attachment 98103
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98103&action=edit
Bug 24456: change default sort orders/make wording clearer

Signed-off-by: Andrew Fuerste-Henry <andrew at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jan 29 23:55:16 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 29 Jan 2020 22:55:16 +0000
Subject: [Koha-bugs] [Bug 24456] previousIssuesDefaultSortOrder and
 todaysIssuesDefaultSortOrder sort incorrectly
In-Reply-To: <bug-24456-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24456-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24456-70-efWj3oX1cI@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24456

Andrew Fuerste-Henry <andrew at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |andrew at bywatersolutions.com
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 30 00:00:37 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 29 Jan 2020 23:00:37 +0000
Subject: [Koha-bugs] [Bug 24347] Add a 'search to order' option similar to
 'search to hold'
In-Reply-To: <bug-24347-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24347-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24347-70-j7ndVy4JmJ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24347

--- Comment #8 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Thx a lot Owen for picking up my idea and running with it!

Possible improvement I could imagine:
- Add a link to jump directly to Advanced search
- Improve the styling of the 'Add to order' pop up to make all our different
options a bit easier to handle (not related to this bug actually)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 30 00:46:58 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 29 Jan 2020 23:46:58 +0000
Subject: [Koha-bugs] [Bug 21791] Add payment type on Cash register report
 (cash_register_stats.pl)
In-Reply-To: <bug-21791-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21791-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21791-70-3OgkwLvcV7@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21791

--- Comment #2 from Eric Phetteplace <ephetteplace at cca.edu> ---
Created attachment 98104
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98104&action=edit
UNTESTED patch

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 30 00:53:29 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 29 Jan 2020 23:53:29 +0000
Subject: [Koha-bugs] [Bug 21791] Add payment type on Cash register report
 (cash_register_stats.pl)
In-Reply-To: <bug-21791-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21791-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21791-70-2qYvhioDGG@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21791

--- Comment #3 from Eric Phetteplace <ephetteplace at cca.edu> ---
I took a pass at adding this field but I'm not sure if it will work; I didn't
test on a sandbox instance. One question I had: the values of
accountlines.payment_type come from the PAYMENT_TYPE authorized values. Should
the report show the field's literal value (the code) or its (more readable)
associated Description? I lean towards showing literal values as they tend to
be more consistent over time but I'm not sure if there's a standardized
approach for Koha.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 30 01:11:05 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Jan 2020 00:11:05 +0000
Subject: [Koha-bugs] [Bug 21190] GDPR: Log successful/unsuccessful login
 attempts [part 1]
In-Reply-To: <bug-21190-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21190-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21190-70-ZsaQyrPeLt@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21190

--- Comment #34 from Agnes Rivers-Moore <arm at hanover.ca> ---
I added comments as an end-user, my way of supporting work on this - will be
sad to see it die. I appreciate the work done.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 30 02:35:39 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Jan 2020 01:35:39 +0000
Subject: [Koha-bugs] [Bug 23068] Add ability for Koha to handle
 X-Forwarded-For headers so REMOTE_ADDR features work behind a proxy
In-Reply-To: <bug-23068-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23068-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23068-70-4nMmwRjhhd@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23068

--- Comment #38 from David Cook <dcook at prosentient.com.au> ---
I just want to say that this is working beautifully in 19.11. Thanks a lot,
Kyle!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 30 04:05:45 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Jan 2020 03:05:45 +0000
Subject: [Koha-bugs] [Bug 23068] Add ability for Koha to handle
 X-Forwarded-For headers so REMOTE_ADDR features work behind a proxy
In-Reply-To: <bug-23068-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23068-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23068-70-Wp7XJeBuHT@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23068

--- Comment #39 from David Cook <dcook at prosentient.com.au> ---
I've been thinking about this one more, and I just want to say again well done,
Kyle! 

I like how it can handle multiple proxies, and the trust model so that end
users can't hack REMOTE_USER using their own user-supplied headers. 

It's too bad there are no unit tests for Koha::Middleware::RealIP. I ended up
writing a very basic one here just to test that it worked for multiple proxies.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 30 04:11:42 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Jan 2020 03:11:42 +0000
Subject: [Koha-bugs] [Bug 23068] Add ability for Koha to handle
 X-Forwarded-For headers so REMOTE_ADDR features work behind a proxy
In-Reply-To: <bug-23068-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23068-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23068-70-uzAjZMBFwG@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23068

--- Comment #40 from David Cook <dcook at prosentient.com.au> ---
One last note for people interested in this feature, Net::Netmask lets you
define IP addresses in a number of ways. If you wanted to trust a whole local
subnet, you could do 192.168.0.0/16, or something like that. 

(If you're using a proxy like an AWS Elastic Load Balancer, which is
dynamically assigned an IP address chosen by AWS, you could specify the subnets
for your ELBs, and then wouldn't have to worry about IP addresses changing and
keeping your koha-conf.xml up to date.)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 30 04:40:24 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Jan 2020 03:40:24 +0000
Subject: [Koha-bugs] [Bug 24537] New: Allow IP ranges in
 ILS-DI:AuthorizedIPs using Net::Netmask
Message-ID: <bug-24537-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24537

            Bug ID: 24537
           Summary: Allow IP ranges in ILS-DI:AuthorizedIPs using
                    Net::Netmask
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Web services
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: dcook at prosentient.com.au
        QA Contact: testopia at bugs.koha-community.org

By using Net::Netmask (introduced by Bug 23068), we can allow IP ranges in the
ILS-DI:AuthorizedIPs system preference. 

This makes it much easier to integrate with other systems.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 30 05:04:53 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Jan 2020 04:04:53 +0000
Subject: [Koha-bugs] [Bug 23068] Add ability for Koha to handle
 X-Forwarded-For headers so REMOTE_ADDR features work behind a proxy
In-Reply-To: <bug-23068-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23068-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23068-70-4aFexwgwBI@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23068

--- Comment #41 from David Cook <dcook at prosentient.com.au> ---
Ok found a little problem and I'll open up a separate bug report for it.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 30 05:12:28 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Jan 2020 04:12:28 +0000
Subject: [Koha-bugs] [Bug 24538] New: REMOTE_USER set to undef if
 koha_trusted_proxies contains invalid value
Message-ID: <bug-24538-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24538

            Bug ID: 24538
           Summary: REMOTE_USER set to undef if koha_trusted_proxies
                    contains invalid value
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: minor
          Priority: P5 - low
         Component: Architecture, internals, and plumbing
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: dcook at prosentient.com.au
        QA Contact: testopia at bugs.koha-community.org

If koha_trusted_proxies contains an invalid or unparseable value, say due to a
typo, like "1.1.1.", it'll treat it as a 0.0.0.0/0 mask and match against
everything. 

In my tests, this leads to REMOTE_USER being set to undef.

(On the plus side, at least a 0.0.0.0/0 mask leads to zero privileges rather
than all privileges.)

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 30 05:12:35 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Jan 2020 04:12:35 +0000
Subject: [Koha-bugs] [Bug 24538] REMOTE_USER set to undef if
 koha_trusted_proxies contains invalid value
In-Reply-To: <bug-24538-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24538-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24538-70-CKaM7fLVrt@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24538

David Cook <dcook at prosentient.com.au> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |23068


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23068
[Bug 23068] Add ability for Koha to handle X-Forwarded-For headers so
REMOTE_ADDR features work behind a proxy
-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 30 05:12:35 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Jan 2020 04:12:35 +0000
Subject: [Koha-bugs] [Bug 23068] Add ability for Koha to handle
 X-Forwarded-For headers so REMOTE_ADDR features work behind a proxy
In-Reply-To: <bug-23068-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23068-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23068-70-VX71LJIRXt@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23068

David Cook <dcook at prosentient.com.au> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |24538


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24538
[Bug 24538] REMOTE_USER set to undef if koha_trusted_proxies contains invalid
value
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 30 05:14:18 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Jan 2020 04:14:18 +0000
Subject: [Koha-bugs] [Bug 24538] REMOTE_USER set to undef if
 koha_trusted_proxies contains invalid value
In-Reply-To: <bug-24538-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24538-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24538-70-rDdOTGrbLt@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24538

--- Comment #1 from David Cook <dcook at prosentient.com.au> ---
The solution should probably use either the new2 constructor (code smell...) or
check the $objet->{'ERROR'} value as per
https://metacpan.org/pod/Net::Netmask#CONSTRUCTING. 

(Note that I actually found this while testing a patch for
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24537)

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 30 05:21:46 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Jan 2020 04:21:46 +0000
Subject: [Koha-bugs] [Bug 24537] Allow IP ranges in ILS-DI:AuthorizedIPs
 using Net::Netmask
In-Reply-To: <bug-24537-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24537-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24537-70-LvMU5HR3f7@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24537

David Cook <dcook at prosentient.com.au> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Small patch
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 30 05:21:48 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Jan 2020 04:21:48 +0000
Subject: [Koha-bugs] [Bug 24537] Allow IP ranges in ILS-DI:AuthorizedIPs
 using Net::Netmask
In-Reply-To: <bug-24537-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24537-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24537-70-4lmQh0KWsb@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24537

--- Comment #1 from David Cook <dcook at prosentient.com.au> ---
Created attachment 98105
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98105&action=edit
Bug 24537: Allow IP ranges in ILS-DI:AuthorizedIPs using Net::Netmask

This patch uses Net::Netmask to match IPs from ILS-DI:AuthorizedIPs
against $ENV{REMOTE_USER}. By using Net::Netmask, we can use addresses
in a variety of formats. This includes 127.0.0.1, 192.168.1.0/24,
10.0.0, and so on.

To Test:
1. Apply the patch
2. Empty the 'ILS-DI:AuthorizedIPs' system preference
3. Send a request to
'/cgi-bin/koha/ilsdi.pl?service=LookupPatron&id=1&id_type=cardnumber'
3b. Note that the request is successful
4. Set the 'ILS-DI:AuthorizedIPs' system preference to a subnet including
your IP address (e.g. 192.168.1.0/24)
5. Send a request to
'/cgi-bin/koha/ilsdi.pl?service=LookupPatron&id=1&id_type=cardnumber'
5b. Note that the request is successful
6. Set the 'ILS-DI:AuthorizedIPs' system preference to a subnet that doesn't
include
your IP address (e.g. 1.1.1)
7. Send a request to
'/cgi-bin/koha/ilsdi.pl?service=LookupPatron&id=1&id_type=cardnumber'
7b. Note that your request is refused
8. Try a variety of permutations including bad values (e.g. 192.168.1.) or
multiple values
(e.g. 10.0.0.0/8,192.168.1.0/24) or multiple values including a mix of good and
bad values

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 30 05:22:16 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Jan 2020 04:22:16 +0000
Subject: [Koha-bugs] [Bug 24537] Allow IP ranges in ILS-DI:AuthorizedIPs
 using Net::Netmask
In-Reply-To: <bug-24537-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24537-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24537-70-pFDQrUnD2a@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24537

David Cook <dcook at prosentient.com.au> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=23068

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 30 05:22:16 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Jan 2020 04:22:16 +0000
Subject: [Koha-bugs] [Bug 23068] Add ability for Koha to handle
 X-Forwarded-For headers so REMOTE_ADDR features work behind a proxy
In-Reply-To: <bug-23068-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23068-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23068-70-0fgjAJJv25@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23068

David Cook <dcook at prosentient.com.au> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=24537

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 30 05:24:46 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Jan 2020 04:24:46 +0000
Subject: [Koha-bugs] [Bug 24537] Allow IP ranges in ILS-DI:AuthorizedIPs
 using Net::Netmask
In-Reply-To: <bug-24537-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24537-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24537-70-uO36R5XOij@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24537

--- Comment #2 from David Cook <dcook at prosentient.com.au> ---
Note that this really shines when you're running Koha behind a reverse proxy
and you use koha_trusted_proxies to set your REMOTE_USER to the IP address that
contacted your reverse proxy (or the last one in a trust chain). 

(Note also that there are other places in Koha that could benefit from this.
Like OpacSuppressionByIPRange, RestrictedPageLocalIPs, etc.)

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 30 07:53:20 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Jan 2020 06:53:20 +0000
Subject: [Koha-bugs] [Bug 22490] Some strings in javascript files are
 untranslatable
In-Reply-To: <bug-22490-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22490-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22490-70-UTBk41ZZ9G@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22490

Fridolin SOMERS <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |NEW
           Assignee|fridolin.somers at biblibre.co |koha-bugs at lists.koha-commun
                   |m                           |ity.org

--- Comment #6 from Fridolin SOMERS <fridolin.somers at biblibre.com> ---
Bug 24046 fixed "Activate filters"

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 30 07:53:29 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Jan 2020 06:53:29 +0000
Subject: [Koha-bugs] [Bug 24046] 'Activate filters' untranslatable
In-Reply-To: <bug-24046-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24046-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24046-70-iCAFFvmmY1@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24046

Fridolin SOMERS <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |22490
                 CC|                            |fridolin.somers at biblibre.co
                   |                            |m


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22490
[Bug 22490] Some strings in javascript files are untranslatable
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 30 07:53:29 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Jan 2020 06:53:29 +0000
Subject: [Koha-bugs] [Bug 22490] Some strings in javascript files are
 untranslatable
In-Reply-To: <bug-22490-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22490-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22490-70-ALT9rW2NnY@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22490

Fridolin SOMERS <fridolin.somers at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |24046


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24046
[Bug 24046] 'Activate filters' untranslatable
-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 30 07:56:08 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Jan 2020 06:56:08 +0000
Subject: [Koha-bugs] [Bug 20243] ILS-DI CIDR notation
In-Reply-To: <bug-20243-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20243-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20243-70-13AGZEu3U0@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20243

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de
         Resolution|---                         |DUPLICATE
             Status|NEW                         |RESOLVED

--- Comment #1 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
I think this is a possible duplicate to bug 24537 - marking as such, please
undo if incorrect.

*** This bug has been marked as a duplicate of bug 24537 ***

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 30 07:56:08 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Jan 2020 06:56:08 +0000
Subject: [Koha-bugs] [Bug 24537] Allow IP ranges in ILS-DI:AuthorizedIPs
 using Net::Netmask
In-Reply-To: <bug-24537-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24537-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24537-70-1kwXVMmpSy@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24537

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |bc at interleaf.ie

--- Comment #3 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
*** Bug 20243 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 30 08:00:35 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Jan 2020 07:00:35 +0000
Subject: [Koha-bugs] [Bug 17374] Make use of fields from syspref
 'DefaultPatronSearchFields' in patron search fields dropdown
In-Reply-To: <bug-17374-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17374-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17374-70-XNEgp7vMjl@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17374

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|14874                       |
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=14874


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14874
[Bug 14874] Add ability to search for patrons by date of birth from checkout
and patron quick searches
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 30 08:00:35 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Jan 2020 07:00:35 +0000
Subject: [Koha-bugs] [Bug 14874] Add ability to search for patrons by date
 of birth from checkout and patron quick searches
In-Reply-To: <bug-14874-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14874-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14874-70-necUUfKG5Y@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14874

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|17374                       |
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=17374


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17374
[Bug 17374] Make use of fields from syspref 'DefaultPatronSearchFields' in
patron search fields dropdown
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 30 08:05:00 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Jan 2020 07:05:00 +0000
Subject: [Koha-bugs] [Bug 23885] Move staff client search results JavaScript
 into separate file
In-Reply-To: <bug-23885-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23885-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23885-70-Sm3khwmg9V@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23885

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Text to go in the|                            |As part of the coding
      release notes|                            |guidelines (JS1 - Whenever
                   |                            |possible JavaScript should
                   |                            |be placed in a separate
                   |                            |file), this patch patch
                   |                            |moves most of the
                   |                            |JavaScript embedded in
                   |                            |results.tt for the staff
                   |                            |interface into a separate
                   |                            |file.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 30 08:10:47 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Jan 2020 07:10:47 +0000
Subject: [Koha-bugs] [Bug 13121] Move search results "action" links ("Place
 hold, " "Add tag, " etc) into include file
In-Reply-To: <bug-13121-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13121-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13121-70-8gsB0Lm4sb@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13121

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Text to go in the|                            |This patch moves markup for
      release notes|                            |controls repeated across
                   |                            |several OPAC templates into
                   |                            |a single include (making it
                   |                            |easier to maintain in the
                   |                            |future): Place hold,
                   |                            |Request article, Add tag,
                   |                            |Save to lists, and Add to
                   |                            |cart.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 30 08:33:46 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Jan 2020 07:33:46 +0000
Subject: [Koha-bugs] [Bug 17374] Make use of fields from syspref
 'DefaultPatronSearchFields' in patron search fields dropdown
In-Reply-To: <bug-17374-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17374-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17374-70-Zav0Xhl7zo@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17374

--- Comment #41 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 98106
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98106&action=edit
Bug 17374: (QA follow-up) Make search labels match with patron record

Makes some small changes to the patronfields.inc to make sure the
search labels match with the labels in the patron record.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 30 08:34:25 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Jan 2020 07:34:25 +0000
Subject: [Koha-bugs] [Bug 24539] New: Build generic authentication module
 interface
Message-ID: <bug-24539-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24539

            Bug ID: 24539
           Summary: Build generic authentication module interface
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Authentication
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: dcook at prosentient.com.au
        QA Contact: testopia at bugs.koha-community.org
                CC: dpavlin at rot13.org

Locally, I run a number of custom authentication integrations for Koha, and
I've been thinking it would be great if there were a generic authentication
module interface.

So I've refactored my local OpenID Connect implementation, so that the changes
to Auth.pm and opac-auth.tt are very generic, and other authentication modules
could easily leverage them without touching Auth.pm or opac-auth.tt. (The
latter remains translateable as generic messages are in opac-auth.tt and they
are bound to keys passed from the authentication module.)

Right now, you invoke a custom endpoint (I have ideas about making those more
generic and extensible too) and it passes an object to C4::Auth::checkauth().
The module for that object and some other data are persisted in the logged in
user's session.

To log off, you just hit the log off button, Koha gets relevant info from the
user's session, and runs the authentication module's logout hook. 

My goal is to make it so that people can rapidly develop authentication
modules, and make it easy to swap in and out different modules. (For instance,
my local OpenID Connect code works and works reasonable well, but it's not
perfect. However, I shouldn't need to touch Auth.pm and opac-auth.tt to improve
that code. The improvements should be isolated within the specific
authentication module itself.)

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 30 08:40:28 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Jan 2020 07:40:28 +0000
Subject: [Koha-bugs] [Bug 21586] Add generic OpenIDConnect client
 implementation
In-Reply-To: <bug-21586-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21586-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21586-70-tBntz9HaGC@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21586

--- Comment #12 from David Cook <dcook at prosentient.com.au> ---
I decided to make some strides on generic authentication and opened
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24539

I've refactored my OpenID Connect code to take advantage of a standard generic
interface in Auth.pm and opac-auth.tt. 

I still have some work to do on the endpoint that triggers the login, but I
have some ideas about that.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 30 08:41:23 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Jan 2020 07:41:23 +0000
Subject: [Koha-bugs] [Bug 24539] Build generic authentication module
 interface
In-Reply-To: <bug-24539-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24539-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24539-70-MkHHGDc5tC@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24539

--- Comment #1 from David Cook <dcook at prosentient.com.au> ---
I'm not using the existing Koha plugin system, as I'm still not 100% sure I
want to implement these as plugins that end-users can upload... but still
thinking.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 30 08:42:17 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Jan 2020 07:42:17 +0000
Subject: [Koha-bugs] [Bug 23068] Add ability for Koha to handle
 X-Forwarded-For headers so REMOTE_ADDR features work behind a proxy
In-Reply-To: <bug-23068-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23068-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23068-70-zqyzniUS6w@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23068

--- Comment #42 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
(In reply to David Cook from comment #39)
> It's too bad there are no unit tests for Koha::Middleware::RealIP. I ended
> up writing a very basic one here just to test that it worked for multiple
> proxies.

Agreed, but I didn't want to hold up this vital development and we weren't at
all sure how to write such a test.. as it sounds like you've got the
foundations for a test written, please submit it upstream ;)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 30 08:49:52 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Jan 2020 07:49:52 +0000
Subject: [Koha-bugs] [Bug 21791] Add payment type on Cash register report
 (cash_register_stats.pl)
In-Reply-To: <bug-21791-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21791-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21791-70-lWtuvvtAJW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21791

--- Comment #4 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
I would say for an inbuilt report like this one then translating codes to
descriptions is the preferred approach.. however this is a great start.

Just to note, however, I am currently considering a patch to merge payment_type
into credit_types as I'm not sure that having two levels of 'type' makes sense
now that we have a clearer distinction between 'credit' and 'debit' lines.

I'd be interested in feedback for that approach.. are there really times when
one would want `pay` + `cash` or `credit` + `beans` vs just having `cash`,
`card` and `beans` as a top-level credit type?

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 30 08:52:14 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Jan 2020 07:52:14 +0000
Subject: [Koha-bugs] [Bug 24539] Build generic authentication module
 interface
In-Reply-To: <bug-24539-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24539-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24539-70-qK3FuadnCe@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24539

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |josef.moravec at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 30 09:19:42 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Jan 2020 08:19:42 +0000
Subject: [Koha-bugs] [Bug 24088] Add link to item search in staff client
 main page
In-Reply-To: <bug-24088-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24088-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24088-70-MRhU2vcE1W@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24088

--- Comment #6 from Fridolin SOMERS <fridolin.somers at biblibre.com> ---
Mmm, a lot of our customers asked for that, saying they use it a lot and want
to save a click.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 30 09:21:48 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Jan 2020 08:21:48 +0000
Subject: [Koha-bugs] [Bug 24482] Purchase Items broken by costs containing a
 comma
In-Reply-To: <bug-24482-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24482-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24482-70-WIoh1xbo9I@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24482

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #98058|0                           |1
        is obsolete|                            |

--- Comment #6 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 98107
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98107&action=edit
Bug 24482: Fix for formatted price issue with value over 1000

This patch for the point of sale feature fixes an issue where items for
purchase with a value of $1,000 or more break the payment calculations.

Test plan:
1) Enable the point of sale feature
   (EnablePointOfSale + UseCashRegisters system preferences)
2) Add a cash register for a library
   (Home > Point of sale > Cash registers > New cash register)
3) Create a purchase item with a cost of $1000
   (Home > Point of sale >  Purchase items > New debit type)
4) Go to to the point of sale page and attempt to sell one of your items
   (Home > Point of sale > click 'Add' next to the item to purchase)
5) Note that Koha inserts a comma into the price in the list of items for
   purchase
6) Note that the 'Amount being paid' changes to 0.00 instead of $1,000,
   which affects the other calculations
7) Apply the patch
8) Repeat step 4
9) Amount being paid and other calculations should now be correct
10) Enter an amount for 'Collected from patron' and click 'Confirm'
    check that the change calculation is correct.
11) Sign-off the patch!

Signed-off-by: David Nind <david at davidnind.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 30 09:22:18 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Jan 2020 08:22:18 +0000
Subject: [Koha-bugs] [Bug 24482] Purchase Items broken by costs containing a
 comma
In-Reply-To: <bug-24482-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24482-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24482-70-9xTNzYCKK9@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24482

--- Comment #7 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Thanks for testing, and that's a wonderfully detailed test plan, thankyou!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 30 09:23:46 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Jan 2020 08:23:46 +0000
Subject: [Koha-bugs] [Bug 24482] Purchase Items broken by costs containing a
 comma
In-Reply-To: <bug-24482-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24482-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24482-70-wrcdKlU4qN@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24482

--- Comment #8 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
(In reply to David Nind from comment #5)
> I identified two other possible issues testing this bug:
> 
> 1. If you press enter in the 'Collected from patron' field it adds the first
> item listed under the 'Items for purchase' section to 'This sale'.

Oh, weird.. I'll open a new bug for that.

> 
> 2. If the amount you enter in 'Collected from patron' is less than the total
> amount owed and you press confirm it is accepted. For a cash payment maybe
> there should be a warning or error, or not let the transaction be accepted
> or completed.

I'll be submitting a fix for this one in bug 24519 ;)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 30 09:25:57 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Jan 2020 08:25:57 +0000
Subject: [Koha-bugs] [Bug 24540] New: Unexpected behaviour on 'enter' in
 point of sale payment fields
Message-ID: <bug-24540-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24540

            Bug ID: 24540
           Summary: Unexpected behaviour on 'enter' in point of sale
                    payment fields
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: Staff Client
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: martin.renvoize at ptfs-europe.com
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com
        Depends on: 24482

If you press enter in the 'Collected from patron' field it adds the first item
listed under the 'Items for purchase' section to 'This sale'.


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24482
[Bug 24482] Purchase Items broken by costs containing a comma
-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 30 09:25:57 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Jan 2020 08:25:57 +0000
Subject: [Koha-bugs] [Bug 24482] Purchase Items broken by costs containing a
 comma
In-Reply-To: <bug-24482-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24482-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24482-70-u3FClZ0B5S@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24482

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |24540


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24540
[Bug 24540] Unexpected behaviour on 'enter' in point of sale payment fields
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 30 09:26:03 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Jan 2020 08:26:03 +0000
Subject: [Koha-bugs] [Bug 24540] Unexpected behaviour on 'enter' in point of
 sale payment fields
In-Reply-To: <bug-24540-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24540-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24540-70-wXhOPSxHnz@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24540

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |martin.renvoize at ptfs-europe
                   |ity.org                     |.com

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 30 09:29:29 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Jan 2020 08:29:29 +0000
Subject: [Koha-bugs] [Bug 17697] Improve NotesBlacklist system preference
 description to make clear where it will apply
In-Reply-To: <bug-17697-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17697-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17697-70-o445lhtrp8@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17697

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #97946|0                           |1
        is obsolete|                            |

--- Comment #6 from David Nind <david at davidnind.com> ---
Created attachment 98108
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98108&action=edit
Bug 17697: Improve NotesBlacklist system preference description

- Switched 'separator' for more common 'tab' and rephrased sentence
- Added examples
- Added note to use hidden settings for hiding in other spots.

To test:
- Search for NotesBlacklist system preference and read the description
- Apply patch
- Refresh and read again
- If improved, sign off.

https://bugs.koha-community.org/show_bug.cgi?id=24206

Signed-off-by: David Nind <david at davidnind.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 30 09:30:16 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Jan 2020 08:30:16 +0000
Subject: [Koha-bugs] [Bug 17697] Improve NotesBlacklist system preference
 description to make clear where it will apply
In-Reply-To: <bug-17697-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17697-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17697-70-WnfBsDxRqK@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17697

--- Comment #7 from David Nind <david at davidnind.com> ---
(In reply to Jonathan Druart from comment #5)
> Can I add a br tag before the last sentence?

Added.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 30 09:30:30 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Jan 2020 08:30:30 +0000
Subject: [Koha-bugs] [Bug 21190] GDPR: Log successful/unsuccessful login
 attempts [part 1]
In-Reply-To: <bug-21190-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21190-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21190-70-L63qqo9fLh@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21190

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |black23 at gmail.com,
                   |                            |josef.moravec at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 30 09:43:26 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Jan 2020 08:43:26 +0000
Subject: [Koha-bugs] [Bug 20813] Revamp user permissions system
In-Reply-To: <bug-20813-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20813-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20813-70-hwFr9ySL8u@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20813

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |martin.renvoize at ptfs-europe
                   |                            |.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 30 09:55:32 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Jan 2020 08:55:32 +0000
Subject: [Koha-bugs] [Bug 21190] GDPR: Log successful/unsuccessful login
 attempts [part 1]
In-Reply-To: <bug-21190-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21190-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21190-70-fnJCB23GWT@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21190

--- Comment #35 from Magnus Enger <magnus at libriotech.no> ---
Tested this, and everything looks good. To me it makes perfect sense to have
two regular sysprefs, as Marcel says, some libraries might want to log only
success or failure. 

I have one question, though. After doing one failed login and some successful
ones I have this in the database: 

+-----------+---------------------+------+--------+---------+--------+--------------------------+-----------+
| action_id | timestamp           | user | module | action  | object | info    
                | interface |
+-----------+---------------------+------+--------+---------+--------+--------------------------+-----------+
|      1676 | 2020-01-29 22:17:06 |   51 | AUTH   | SUCCESS |     51 | Valid
password for admin | intranet  |
|      1678 | 2020-01-29 22:17:17 |    0 | AUTH   | FAILURE |      0 | Wrong
password for admin | intranet  |
|      1680 | 2020-01-29 22:17:20 |   51 | AUTH   | SUCCESS |     51 | Valid
password for admin | intranet  |
|      1681 | 2020-01-29 22:18:11 |   51 | AUTH   | SUCCESS |     51 | Valid
password for admin | intranet  |
+-----------+---------------------+------+--------+---------+--------+--------------------------+-----------+

The successfull logins are tied to a user (51), but the failed one is not (0).
Couldn't the failed one also be tied to the user, as long as the username
provided is the username of an actual user in the db? Or is there some reason
for not doing this? 

Apart from this question I'm ready to sign off.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 30 10:03:08 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Jan 2020 09:03:08 +0000
Subject: [Koha-bugs] [Bug 24541] New: Database cleanups, purge messages
Message-ID: <bug-24541-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24541

            Bug ID: 24541
           Summary: Database cleanups, purge messages
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Command-line Utilities
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: didier.gautheron at biblibre.com
        QA Contact: testopia at bugs.koha-community.org
                CC: robin at catalyst.net.nz

misc/cronjobs/cleanup_database.pl provides some database cleanup.
Yet some tables that could need cleanup are not in this script.

Purge messages older than day (default 365).

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 30 10:09:24 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Jan 2020 09:09:24 +0000
Subject: [Koha-bugs] [Bug 17697] Improve NotesBlacklist system preference
 description to make clear where it will apply
In-Reply-To: <bug-17697-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17697-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17697-70-WYy4vojSMf@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17697

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 30 10:09:27 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Jan 2020 09:09:27 +0000
Subject: [Koha-bugs] [Bug 17697] Improve NotesBlacklist system preference
 description to make clear where it will apply
In-Reply-To: <bug-17697-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17697-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17697-70-NoowhPo8Ob@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17697

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #98108|0                           |1
        is obsolete|                            |

--- Comment #8 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 98109
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98109&action=edit
Bug 17697: Improve NotesBlacklist system preference description

- Switched 'separator' for more common 'tab' and rephrased sentence
- Added examples
- Added note to use hidden settings for hiding in other spots.

To test:
- Search for NotesBlacklist system preference and read the description
- Apply patch
- Refresh and read again
- If improved, sign off.

Signed-off-by: David Nind <david at davidnind.com>

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 30 10:11:15 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Jan 2020 09:11:15 +0000
Subject: [Koha-bugs] [Bug 22690] Merging records with many items too slow
 (Elasticsearch)
In-Reply-To: <bug-22690-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22690-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22690-70-Zly6u7O7lt@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22690

--- Comment #18 from Ere Maijala <ere.maijala at helsinki.fi> ---
Mike, that seems unrelated to any of the changes here. I tried with both MARC
21 and UNIMARC default mappings and couldn't reproduce, so I'd say it's an
issue with your mappings, but I'm a bit at loss if they're at defaults. Do you
see the issue with plain master version of Koha?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 30 10:16:54 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Jan 2020 09:16:54 +0000
Subject: [Koha-bugs] [Bug 21190] GDPR: Log successful/unsuccessful login
 attempts [part 1]
In-Reply-To: <bug-21190-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21190-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21190-70-voG8UxKz3L@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21190

ByWater Sandboxes <bws.sandboxes at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #98067|0                           |1
        is obsolete|                            |

--- Comment #36 from ByWater Sandboxes <bws.sandboxes at gmail.com> ---
Created attachment 98110
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98110&action=edit
Bug 21190: Prepare Log.t for further changes

This patch only makes cosmetic changes:
[1] It moves the existing tests at 'root level' inside a new subtest.
[2] It obviously adds indentation for step 1.
[3] It fixes some whitespace (tabs, space before newline)

Test plan:
Run t/db../Log.t

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

Signed-off-by: Jon Knight <J.P.Knight at lboro.ac.uk>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 30 10:16:57 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Jan 2020 09:16:57 +0000
Subject: [Koha-bugs] [Bug 21190] GDPR: Log successful/unsuccessful login
 attempts [part 1]
In-Reply-To: <bug-21190-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21190-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21190-70-5VPqEqKOQ0@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21190

ByWater Sandboxes <bws.sandboxes at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #98068|0                           |1
        is obsolete|                            |

--- Comment #37 from ByWater Sandboxes <bws.sandboxes at gmail.com> ---
Created attachment 98111
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98111&action=edit
Bug 21190: Add subtest to Log.t for GDPR logging

Apart from a new subtest, doing some more cleanup:
[1] Copyright statement
[2] Removing the (unneeded) flush
[3] Removing C4::Log from the BEGIN block; we seem to skip that nowadays.
[4] $succes goes to the subtest, $schema and $dbh are global our vars.
    Not required but just what we should do if it would run under Plack.

Test plan:
Run t/db_dependent/Log.t

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

Signed-off-by: Jon Knight <J.P.Knight at lboro.ac.uk>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 30 10:17:00 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Jan 2020 09:17:00 +0000
Subject: [Koha-bugs] [Bug 21190] GDPR: Log successful/unsuccessful login
 attempts [part 1]
In-Reply-To: <bug-21190-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21190-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21190-70-S4W5ONppVy@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21190

ByWater Sandboxes <bws.sandboxes at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #98069|0                           |1
        is obsolete|                            |

--- Comment #38 from ByWater Sandboxes <bws.sandboxes at gmail.com> ---
Created attachment 98112
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98112&action=edit
Bug 21190: Add interfaces parameter to POD in C4::Logs

Just fixing documentation along the way.
No test plan, just read the patch.

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

Signed-off-by: Jon Knight <J.P.Knight at lboro.ac.uk>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 30 10:17:04 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Jan 2020 09:17:04 +0000
Subject: [Koha-bugs] [Bug 21190] GDPR: Log successful/unsuccessful login
 attempts [part 1]
In-Reply-To: <bug-21190-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21190-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21190-70-rU7AZpLLKE@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21190

ByWater Sandboxes <bws.sandboxes at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #98070|0                           |1
        is obsolete|                            |

--- Comment #39 from ByWater Sandboxes <bws.sandboxes at gmail.com> ---
Created attachment 98113
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98113&action=edit
Bug 21190: Remove t/Log.t

Since we have t/db../Log.t and t/Log.t simply does nothing, we would
better remove it.

No test plan either :)

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

Signed-off-by: Jon Knight <J.P.Knight at lboro.ac.uk>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 30 10:17:07 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Jan 2020 09:17:07 +0000
Subject: [Koha-bugs] [Bug 21190] GDPR: Log successful/unsuccessful login
 attempts [part 1]
In-Reply-To: <bug-21190-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21190-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21190-70-p3cbrkYAam@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21190

ByWater Sandboxes <bws.sandboxes at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #98071|0                           |1
        is obsolete|                            |

--- Comment #40 from ByWater Sandboxes <bws.sandboxes at gmail.com> ---
Created attachment 98114
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98114&action=edit
Bug 21190: Introduce preferences AuthFailureLog and AuthSuccessLog

Test plan:
Run atomic update.
Check the Logs tab of preferences.

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

Signed-off-by: Jon Knight <J.P.Knight at lboro.ac.uk>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 30 10:17:10 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Jan 2020 09:17:10 +0000
Subject: [Koha-bugs] [Bug 21190] GDPR: Log successful/unsuccessful login
 attempts [part 1]
In-Reply-To: <bug-21190-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21190-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21190-70-QE9TEnQRLv@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21190

ByWater Sandboxes <bws.sandboxes at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #98072|0                           |1
        is obsolete|                            |

--- Comment #41 from ByWater Sandboxes <bws.sandboxes at gmail.com> ---
Created attachment 98115
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98115&action=edit
Bug 21190: Add authentication logging to checkpw

Add optional logging for successful and failing login attempts in
checkpw.

Test plan:
Enable the preferences
Perform a good login and a bad attempt
Check action_logs

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

Signed-off-by: Jon Knight <J.P.Knight at lboro.ac.uk>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 30 10:17:13 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Jan 2020 09:17:13 +0000
Subject: [Koha-bugs] [Bug 21190] GDPR: Log successful/unsuccessful login
 attempts [part 1]
In-Reply-To: <bug-21190-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21190-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21190-70-023rDGSVpw@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21190

ByWater Sandboxes <bws.sandboxes at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #98073|0                           |1
        is obsolete|                            |

--- Comment #42 from ByWater Sandboxes <bws.sandboxes at gmail.com> ---
Created attachment 98116
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98116&action=edit
Bug 21190: Allow browsing the system logs for AUTH events

Trivial change, adding AUTH to viewlog template only.

Test plan:
Look for the Authentication log lines in viewlog.pl (intranet tools).

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

Signed-off-by: Jon Knight <J.P.Knight at lboro.ac.uk>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 30 10:17:16 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Jan 2020 09:17:16 +0000
Subject: [Koha-bugs] [Bug 21190] GDPR: Log successful/unsuccessful login
 attempts [part 1]
In-Reply-To: <bug-21190-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21190-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21190-70-ZrGeXYPPni@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21190

ByWater Sandboxes <bws.sandboxes at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #98074|0                           |1
        is obsolete|                            |

--- Comment #43 from ByWater Sandboxes <bws.sandboxes at gmail.com> ---
Created attachment 98117
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98117&action=edit
Bug 21190: Add tests for authentication success and failure

Test plan:
Run t/db_dependent/Log.t

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

Signed-off-by: Jon Knight <J.P.Knight at lboro.ac.uk>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 30 10:18:39 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Jan 2020 09:18:39 +0000
Subject: [Koha-bugs] [Bug 21190] GDPR: Log successful/unsuccessful login
 attempts [part 1]
In-Reply-To: <bug-21190-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21190-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21190-70-Z9jHXOQFAT@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21190

Jon Knight <J.P.Knight at lboro.ac.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |J.P.Knight at lboro.ac.uk
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 30 10:19:18 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Jan 2020 09:19:18 +0000
Subject: [Koha-bugs] [Bug 21190] GDPR: Log successful/unsuccessful login
 attempts [part 1]
In-Reply-To: <bug-21190-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21190-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21190-70-aSRQog6s6S@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21190

Jacek Ablewicz <abl at biblos.pk.edu.pl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |abl at biblos.pk.edu.pl

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 30 10:22:53 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Jan 2020 09:22:53 +0000
Subject: [Koha-bugs] [Bug 21190] GDPR: Log successful/unsuccessful login
 attempts [part 1]
In-Reply-To: <bug-21190-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21190-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21190-70-jcNWvt5ccu@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21190

--- Comment #44 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
(In reply to Magnus Enger from comment #35)
> Tested this, and everything looks good. To me it makes perfect sense to have
> two regular sysprefs, as Marcel says, some libraries might want to log only
> success or failure. 
> 
> I have one question, though. After doing one failed login and some
> successful ones I have this in the database: 
> 
> +-----------+---------------------+------+--------+---------+--------+-------
> -------------------+-----------+
> | action_id | timestamp           | user | module | action  | object | info 
> | interface |
> +-----------+---------------------+------+--------+---------+--------+-------
> -------------------+-----------+
> |      1676 | 2020-01-29 22:17:06 |   51 | AUTH   | SUCCESS |     51 | Valid
> password for admin | intranet  |
> |      1678 | 2020-01-29 22:17:17 |    0 | AUTH   | FAILURE |      0 | Wrong
> password for admin | intranet  |
> |      1680 | 2020-01-29 22:17:20 |   51 | AUTH   | SUCCESS |     51 | Valid
> password for admin | intranet  |
> |      1681 | 2020-01-29 22:18:11 |   51 | AUTH   | SUCCESS |     51 | Valid
> password for admin | intranet  |
> +-----------+---------------------+------+--------+---------+--------+-------
> -------------------+-----------+
> 
> The successfull logins are tied to a user (51), but the failed one is not
> (0). Couldn't the failed one also be tied to the user, as long as the
> username provided is the username of an actual user in the db? Or is there
> some reason for not doing this? 
> 
> Apart from this question I'm ready to sign off.

Thanks, Magnus.
I do not really remember a specific reason. I could register it if it is
available. People could try to hack an existing and a not-existing account.
So we might have a $patron, we might not.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 30 10:22:59 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Jan 2020 09:22:59 +0000
Subject: [Koha-bugs] [Bug 23493] jquery.dataTables.rowGrouping.js is no
 longer maintained,
 but there is an official DataTables version we could switch to
In-Reply-To: <bug-23493-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23493-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23493-70-4lWZORkEL5@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23493

--- Comment #29 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 98118
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98118&action=edit
Bug 23493: Fix selenium/regressions.t

One test wants to make sure thead, tfood and tbody will have th/td's
with the same size/number.
Existing test for tbody was retrieving the grouped td, which has a
colspan of 100%. Note that this 100% value seems to be wrong as it is
interpreted like "100" by the browser. We do not want to test this row
anyway, but the real row, the one with all the td's.

This patch makes it retrieve the second tr and count the number of td it
has.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 30 10:23:14 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Jan 2020 09:23:14 +0000
Subject: [Koha-bugs] [Bug 21190] GDPR: Log successful/unsuccessful login
 attempts [part 1]
In-Reply-To: <bug-21190-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21190-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21190-70-6Cyt7eGW98@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21190

--- Comment #45 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
(In reply to ByWater Sandboxes from comment #43)
> Signed-off-by: Jon Knight <J.P.Knight at lboro.ac.uk>

Thanks Jon

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 30 10:24:41 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Jan 2020 09:24:41 +0000
Subject: [Koha-bugs] [Bug 23031] Improve UX of buttons on order search page
In-Reply-To: <bug-23031-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23031-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23031-70-0TBAEf7Ds2@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23031

--- Comment #7 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
(In reply to Katrin Fischer from comment #5)
> If I understand this correctly, the 'view' is on the basket name link and
> the 'add to order' is default action on the button?

Yes, from comment 0:
"""
The "View" part of the split button is an unnecessary duplication of the linked
basket name earlier in the table
"""

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 30 10:31:08 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Jan 2020 09:31:08 +0000
Subject: [Koha-bugs] [Bug 22690] Merging records with many items too slow
 (Elasticsearch)
In-Reply-To: <bug-22690-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22690-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22690-70-DA0gfvJ8b9@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22690

--- Comment #19 from Michal Denar <black23 at gmail.com> ---
Hi Ere,
I've kohadevbox on master, with almost defaults settings. Framework test show 1
error: subfields not in same tabs, but at biblio fileds.  I'll test it again,
because and propably switch to SO.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 30 10:31:33 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Jan 2020 09:31:33 +0000
Subject: [Koha-bugs] [Bug 23590] Allow to modify the manager of a suggestion
In-Reply-To: <bug-23590-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23590-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23590-70-y1xTazAzPr@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23590

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Patch doesn't apply         |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 30 10:31:37 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Jan 2020 09:31:37 +0000
Subject: [Koha-bugs] [Bug 23590] Allow to modify the manager of a suggestion
In-Reply-To: <bug-23590-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23590-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23590-70-EDDLKqYqro@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23590

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #95487|0                           |1
        is obsolete|                            |
  Attachment #95488|0                           |1
        is obsolete|                            |
  Attachment #95489|0                           |1
        is obsolete|                            |
  Attachment #95490|0                           |1
        is obsolete|                            |
  Attachment #95491|0                           |1
        is obsolete|                            |
  Attachment #95492|0                           |1
        is obsolete|                            |
  Attachment #95493|0                           |1
        is obsolete|                            |
  Attachment #95494|0                           |1
        is obsolete|                            |
  Attachment #95495|0                           |1
        is obsolete|                            |
  Attachment #95496|0                           |1
        is obsolete|                            |
  Attachment #95497|0                           |1
        is obsolete|                            |
  Attachment #95498|0                           |1
        is obsolete|                            |

--- Comment #53 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 98119
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98119&action=edit
Bug 23590: Add ability to edit the manager of a suggestion

Prior to this patch there was an hidden behavior that set the manager to
the logged in user when a suggestion was edited. This patch proposes to
let the librarian pick another manager.
Other small adjustements will be added to polish this new behavior:
 * Create 2 new DB columns: suggestions.lastmodificationby and
 suggestion.lastmodificationdate
 * Choose a manager when editing a suggestion
 * Batch modify suggestions and set a manager for them
 * Let notify the new manager using the TO_PROCESS letter
 * Display the manageddate, lastmodificationby and lastmodificationdate
 info where appropriate

This first patch adds a new "Select manager" link when editing a
suggestion.

Test plan for the whole patchset:
0/
  a. Execute the update DB entry, generate the new DBIC file and restart all
  b. Create at least 2 patrons with the suggestions_manage permission
1/ Submit a new suggestion (OPAC or staff, not important)
2/ Accept it
3/ Edit it
=> "Last modification by" is empty
=> You see that you are the manager of this suggestion
4/ Click "Select manager" and search for a new manager
=> The patron search will only display patrons with the
suggestions_manage permission
5/ Save
6/ Edit again
=> The manager is set to you, but there is a note saying that previously
it was the patron you picked
=> The "Last modification by" is set to you
7/ Click "Keep existing manager"
=> The manager is now set to the previous manager
8/ Select another manager (which has a valid email address defined)
9/ Click the "notify" checkbox
10/ Save
11/ Confirm that a TO_PROCESS notice has been generated into the
message_queue table
12/ Create at least one other suggestion
13/ List the suggestions
=> There is a 4th action column to assign a manager to several
suggestions in one go.
14/ Use this new button and confirm that it works as expected
15/ Go to your purchase suggestion list (OPAC and staff)
=> You see the "managed date" displayed in a new column

Sponsored-by: BULAC - http://www.bulac.fr/

Signed-off-by: Séverine QUEUNE <severine.queune at bulac.fr>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 30 10:31:40 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Jan 2020 09:31:40 +0000
Subject: [Koha-bugs] [Bug 23590] Allow to modify the manager of a suggestion
In-Reply-To: <bug-23590-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23590-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23590-70-xsrwkDeUjr@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23590

--- Comment #54 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 98120
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98120&action=edit
Bug 23590: Clean TT variables for patrons

Just a bit of cleaning

Sponsored-by: BULAC - http://www.bulac.fr/

Signed-off-by: Séverine QUEUNE <severine.queune at bulac.fr>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 30 10:31:47 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Jan 2020 09:31:47 +0000
Subject: [Koha-bugs] [Bug 23590] Allow to modify the manager of a suggestion
In-Reply-To: <bug-23590-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23590-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23590-70-JdfF5ja94h@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23590

--- Comment #56 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 98122
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98122&action=edit
Bug 23590: Batch update manager for suggestions

Sponsored-by: BULAC - http://www.bulac.fr/

Signed-off-by: Séverine QUEUNE <severine.queune at bulac.fr>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 30 10:31:51 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Jan 2020 09:31:51 +0000
Subject: [Koha-bugs] [Bug 23590] Allow to modify the manager of a suggestion
In-Reply-To: <bug-23590-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23590-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23590-70-xWN9i7LOSd@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23590

--- Comment #57 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 98123
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98123&action=edit
Bug 23590: Only return patrons that have the suggestions_manage permission

Sponsored-by: BULAC - http://www.bulac.fr/

Signed-off-by: Séverine QUEUNE <severine.queune at bulac.fr>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 30 10:31:44 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Jan 2020 09:31:44 +0000
Subject: [Koha-bugs] [Bug 23590] Allow to modify the manager of a suggestion
In-Reply-To: <bug-23590-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23590-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23590-70-hndPyc60fT@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23590

--- Comment #55 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 98121
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98121&action=edit
Bug 23590: Cleaning - Remove op_* vars

Sponsored-by: BULAC - http://www.bulac.fr/

Signed-off-by: Séverine QUEUNE <severine.queune at bulac.fr>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 30 10:31:54 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Jan 2020 09:31:54 +0000
Subject: [Koha-bugs] [Bug 23590] Allow to modify the manager of a suggestion
In-Reply-To: <bug-23590-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23590-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23590-70-tIie7E9BlS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23590

--- Comment #58 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 98124
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98124&action=edit
Bug 23590: Add the ability to notify a new manager

Sponsored-by: BULAC - http://www.bulac.fr/

Signed-off-by: Séverine QUEUNE <severine.queune at bulac.fr>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 30 10:31:56 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Jan 2020 09:31:56 +0000
Subject: [Koha-bugs] [Bug 21190] GDPR: Log successful/unsuccessful login
 attempts [part 1]
In-Reply-To: <bug-21190-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21190-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21190-70-2kMaQIdmfs@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21190

--- Comment #46 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 98125
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98125&action=edit
Bug 21190: (follow-up) Save patron id in failure when available

The wrong password might belong to an existing user. If that is the case,
we have a $patron.
Note that logaction will save the object info but has no user in the
context environment for a failure.

Test plan:
Login with good user, bad pw and bad user, bad pw. Check logviewer.

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 30 10:32:06 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Jan 2020 09:32:06 +0000
Subject: [Koha-bugs] [Bug 23590] Allow to modify the manager of a suggestion
In-Reply-To: <bug-23590-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23590-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23590-70-UWWGnuDPdW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23590

--- Comment #61 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 98128
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98128&action=edit
Bug 23590: Add atomic update file

Sponsored-by: BULAC - http://www.bulac.fr/

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 30 10:32:09 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Jan 2020 09:32:09 +0000
Subject: [Koha-bugs] [Bug 23590] Allow to modify the manager of a suggestion
In-Reply-To: <bug-23590-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23590-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23590-70-hBujVzlkJ3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23590

--- Comment #62 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 98129
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98129&action=edit
Bug 23590: Remove JS error on the suggestion list

The notify option is only available from the edit view

Sponsored-by: BULAC - http://www.bulac.fr/

Signed-off-by: Séverine QUEUNE <severine.queune at bulac.fr>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 30 10:31:58 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Jan 2020 09:31:58 +0000
Subject: [Koha-bugs] [Bug 23590] Allow to modify the manager of a suggestion
In-Reply-To: <bug-23590-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23590-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23590-70-tfn0by1Fuu@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23590

--- Comment #59 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 98126
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98126&action=edit
Bug 23590: Display managed date in 'Your purchase suggestions'

Sponsored-by: BULAC - http://www.bulac.fr/

Signed-off-by: Séverine QUEUNE <severine.queune at bulac.fr>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 30 10:32:02 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Jan 2020 09:32:02 +0000
Subject: [Koha-bugs] [Bug 23590] Allow to modify the manager of a suggestion
In-Reply-To: <bug-23590-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23590-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23590-70-csr8uKFtHO@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23590

--- Comment #60 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 98127
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98127&action=edit
Bug 23590: Add lastmodification by and date columns

No tests are provided for the changes made to SearchSuggestion. It is
going to be remove very soon as it is super ugly...

Sponsored-by: BULAC - http://www.bulac.fr/

Signed-off-by: Séverine QUEUNE <severine.queune at bulac.fr>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 30 10:32:13 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Jan 2020 09:32:13 +0000
Subject: [Koha-bugs] [Bug 23590] Allow to modify the manager of a suggestion
In-Reply-To: <bug-23590-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23590-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23590-70-IhK96vTnWW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23590

--- Comment #63 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 98130
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98130&action=edit
Bug 23590: Fix select manager on list for all tabs

Sponsored-by: BULAC - http://www.bulac.fr/

Signed-off-by: Séverine QUEUNE <severine.queune at bulac.fr>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 30 10:32:17 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Jan 2020 09:32:17 +0000
Subject: [Koha-bugs] [Bug 23590] Allow to modify the manager of a suggestion
In-Reply-To: <bug-23590-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23590-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23590-70-VDLqEhwTcW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23590

--- Comment #64 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 98131
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98131&action=edit
Bug 23590: DBIC Changes

Sponsored-by: BULAC - http://www.bulac.fr/

Signed-off-by: Séverine QUEUNE <severine.queune at bulac.fr>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 30 10:40:57 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Jan 2020 09:40:57 +0000
Subject: [Koha-bugs] [Bug 22868] Circulation staff with suggestions_manage
 can have access to acquisition data
In-Reply-To: <bug-22868-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22868-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22868-70-GBoKkvjzZQ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22868

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to master
         Version(s)|                            |20.05.00
        released in|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 30 10:40:59 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Jan 2020 09:40:59 +0000
Subject: [Koha-bugs] [Bug 22868] Circulation staff with suggestions_manage
 can have access to acquisition data
In-Reply-To: <bug-22868-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22868-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22868-70-EAN5Sof0wO@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22868

--- Comment #29 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Nice work everyone!

Pushed to master for 20.05

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 30 10:41:03 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Jan 2020 09:41:03 +0000
Subject: [Koha-bugs] [Bug 23493] jquery.dataTables.rowGrouping.js is no
 longer maintained,
 but there is an official DataTables version we could switch to
In-Reply-To: <bug-23493-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23493-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23493-70-Vi6cWDnrkD@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23493

--- Comment #30 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Nice work everyone!

Pushed to master for 20.05

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 30 10:44:52 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Jan 2020 09:44:52 +0000
Subject: [Koha-bugs] [Bug 23493] jquery.dataTables.rowGrouping.js is no
 longer maintained,
 but there is an official DataTables version we could switch to
In-Reply-To: <bug-23493-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23493-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23493-70-FyZ4dba7dA@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23493

--- Comment #31 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 98132
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98132&action=edit
Bug 23493: (RM follow-up) Let datatables calculate colspan for us

Prior to this we arbitrarily set a colspan of 100 for the rowgroup
header row.  If we remove the td wrapper from the render function then
datatables will automatically wrap the output in an appropraite td with
cell with fullwidth colspan correctly set.

Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 30 10:49:12 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Jan 2020 09:49:12 +0000
Subject: [Koha-bugs] [Bug 24542] New: Checkout page - Can't locate object
 method "search" via package "Koha::Account::DebitTypes"
Message-ID: <bug-24542-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24542

            Bug ID: 24542
           Summary: Checkout page - Can't locate object method "search"
                    via package "Koha::Account::DebitTypes"
 Change sponsored?: ---
           Product: Koha
           Version: unspecified
          Hardware: All
                OS: All
            Status: NEW
          Severity: blocker
          Priority: P5 - low
         Component: Circulation
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: jonathan.druart at bugs.koha-community.org
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com

>From the mailing list
https://lists.katipo.co.nz/pipermail/koha/2020-January/054224.html

Impact 19.11.02 and master.


When trying to checkout items, after choosing a patron by name, the
following page (
https://seattle-intra.theosophicallibrary.org/cgi-bin/koha/circ/circulation.pl?borrowernumber=XX)
returns:

Software error:

Can't locate object method "search" via package "Koha::Account::DebitTypes"
(perhaps you forgot to load "Koha::Account::DebitTypes"?) at
/usr/share/koha/lib/Koha/Account.pm line 674.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 30 10:50:04 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Jan 2020 09:50:04 +0000
Subject: [Koha-bugs] [Bug 24542] Checkout page - Can't locate object method
 "search" via package "Koha::Account::DebitTypes"
In-Reply-To: <bug-24542-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24542-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24542-70-e4w7vJ1rPa@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24542

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
           Assignee|koha-bugs at lists.koha-commun |jonathan.druart at bugs.koha-c
                   |ity.org                     |ommunity.org

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 30 10:50:43 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Jan 2020 09:50:43 +0000
Subject: [Koha-bugs] [Bug 21190] GDPR: Log successful/unsuccessful login
 attempts [part 1]
In-Reply-To: <bug-21190-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21190-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21190-70-DShMHCFY3x@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21190

Michal Denar <black23 at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #98110|0                           |1
        is obsolete|                            |
  Attachment #98111|0                           |1
        is obsolete|                            |
  Attachment #98112|0                           |1
        is obsolete|                            |
  Attachment #98113|0                           |1
        is obsolete|                            |
  Attachment #98114|0                           |1
        is obsolete|                            |
  Attachment #98115|0                           |1
        is obsolete|                            |
  Attachment #98116|0                           |1
        is obsolete|                            |
  Attachment #98117|0                           |1
        is obsolete|                            |
  Attachment #98125|0                           |1
        is obsolete|                            |

--- Comment #47 from Michal Denar <black23 at gmail.com> ---
Created attachment 98133
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98133&action=edit
Bug 21190: Prepare Log.t for further changes

This patch only makes cosmetic changes:
[1] It moves the existing tests at 'root level' inside a new subtest.
[2] It obviously adds indentation for step 1.
[3] It fixes some whitespace (tabs, space before newline)

Test plan:
Run t/db../Log.t

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

Signed-off-by: Jon Knight <J.P.Knight at lboro.ac.uk>

Signed-off-by: Michal Denar <black23 at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 30 10:50:48 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Jan 2020 09:50:48 +0000
Subject: [Koha-bugs] [Bug 21190] GDPR: Log successful/unsuccessful login
 attempts [part 1]
In-Reply-To: <bug-21190-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21190-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21190-70-ERwsvPo417@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21190

--- Comment #48 from Michal Denar <black23 at gmail.com> ---
Created attachment 98134
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98134&action=edit
Bug 21190: Add subtest to Log.t for GDPR logging

Apart from a new subtest, doing some more cleanup:
[1] Copyright statement
[2] Removing the (unneeded) flush
[3] Removing C4::Log from the BEGIN block; we seem to skip that nowadays.
[4] $succes goes to the subtest, $schema and $dbh are global our vars.
    Not required but just what we should do if it would run under Plack.

Test plan:
Run t/db_dependent/Log.t

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

Signed-off-by: Jon Knight <J.P.Knight at lboro.ac.uk>

Signed-off-by: Michal Denar <black23 at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 30 10:50:52 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Jan 2020 09:50:52 +0000
Subject: [Koha-bugs] [Bug 21190] GDPR: Log successful/unsuccessful login
 attempts [part 1]
In-Reply-To: <bug-21190-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21190-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21190-70-8XJJ1kZuR4@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21190

--- Comment #49 from Michal Denar <black23 at gmail.com> ---
Created attachment 98135
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98135&action=edit
Bug 21190: Add interfaces parameter to POD in C4::Logs

Just fixing documentation along the way.
No test plan, just read the patch.

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

Signed-off-by: Jon Knight <J.P.Knight at lboro.ac.uk>

Signed-off-by: Michal Denar <black23 at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 30 10:50:57 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Jan 2020 09:50:57 +0000
Subject: [Koha-bugs] [Bug 21190] GDPR: Log successful/unsuccessful login
 attempts [part 1]
In-Reply-To: <bug-21190-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21190-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21190-70-98jjzCfHwH@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21190

--- Comment #50 from Michal Denar <black23 at gmail.com> ---
Created attachment 98136
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98136&action=edit
Bug 21190: Remove t/Log.t

Since we have t/db../Log.t and t/Log.t simply does nothing, we would
better remove it.

No test plan either :)

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

Signed-off-by: Jon Knight <J.P.Knight at lboro.ac.uk>

Signed-off-by: Michal Denar <black23 at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 30 10:51:01 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Jan 2020 09:51:01 +0000
Subject: [Koha-bugs] [Bug 21190] GDPR: Log successful/unsuccessful login
 attempts [part 1]
In-Reply-To: <bug-21190-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21190-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21190-70-tE6z62DscK@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21190

--- Comment #51 from Michal Denar <black23 at gmail.com> ---
Created attachment 98137
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98137&action=edit
Bug 21190: Introduce preferences AuthFailureLog and AuthSuccessLog

Test plan:
Run atomic update.
Check the Logs tab of preferences.

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

Signed-off-by: Jon Knight <J.P.Knight at lboro.ac.uk>

Signed-off-by: Michal Denar <black23 at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 30 10:51:06 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Jan 2020 09:51:06 +0000
Subject: [Koha-bugs] [Bug 21190] GDPR: Log successful/unsuccessful login
 attempts [part 1]
In-Reply-To: <bug-21190-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21190-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21190-70-m8l3ofqLmO@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21190

--- Comment #52 from Michal Denar <black23 at gmail.com> ---
Created attachment 98138
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98138&action=edit
Bug 21190: Add authentication logging to checkpw

Add optional logging for successful and failing login attempts in
checkpw.

Test plan:
Enable the preferences
Perform a good login and a bad attempt
Check action_logs

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

Signed-off-by: Jon Knight <J.P.Knight at lboro.ac.uk>

Signed-off-by: Michal Denar <black23 at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 30 10:51:10 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Jan 2020 09:51:10 +0000
Subject: [Koha-bugs] [Bug 21190] GDPR: Log successful/unsuccessful login
 attempts [part 1]
In-Reply-To: <bug-21190-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21190-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21190-70-FbWzHjx1Sr@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21190

--- Comment #53 from Michal Denar <black23 at gmail.com> ---
Created attachment 98139
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98139&action=edit
Bug 21190: Allow browsing the system logs for AUTH events

Trivial change, adding AUTH to viewlog template only.

Test plan:
Look for the Authentication log lines in viewlog.pl (intranet tools).

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

Signed-off-by: Jon Knight <J.P.Knight at lboro.ac.uk>

Signed-off-by: Michal Denar <black23 at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 30 10:51:14 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Jan 2020 09:51:14 +0000
Subject: [Koha-bugs] [Bug 21190] GDPR: Log successful/unsuccessful login
 attempts [part 1]
In-Reply-To: <bug-21190-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21190-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21190-70-VhNue3NstL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21190

--- Comment #54 from Michal Denar <black23 at gmail.com> ---
Created attachment 98140
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98140&action=edit
Bug 21190: Add tests for authentication success and failure

Test plan:
Run t/db_dependent/Log.t

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

Signed-off-by: Jon Knight <J.P.Knight at lboro.ac.uk>

Signed-off-by: Michal Denar <black23 at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 30 10:51:18 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Jan 2020 09:51:18 +0000
Subject: [Koha-bugs] [Bug 21190] GDPR: Log successful/unsuccessful login
 attempts [part 1]
In-Reply-To: <bug-21190-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21190-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21190-70-hZHJ9q99Ea@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21190

--- Comment #55 from Michal Denar <black23 at gmail.com> ---
Created attachment 98141
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98141&action=edit
Bug 21190: (follow-up) Save patron id in failure when available

The wrong password might belong to an existing user. If that is the case,
we have a $patron.
Note that logaction will save the object info but has no user in the
context environment for a failure.

Test plan:
Login with good user, bad pw and bad user, bad pw. Check logviewer.

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

Signed-off-by: Michal Denar <black23 at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 30 10:51:23 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Jan 2020 09:51:23 +0000
Subject: [Koha-bugs] [Bug 24542] Checkout page - Can't locate object method
 "search" via package "Koha::Account::DebitTypes"
In-Reply-To: <bug-24542-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24542-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24542-70-0L8Pc9wqfW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24542

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |23049


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049
[Bug 23049] Replace MANUAL_INV authorised value with a dedicated table
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 30 10:51:23 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Jan 2020 09:51:23 +0000
Subject: [Koha-bugs] [Bug 23049] Replace MANUAL_INV authorised value with a
 dedicated table
In-Reply-To: <bug-23049-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23049-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23049-70-FvJOElLE9i@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |24542


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24542
[Bug 24542] Checkout page - Can't locate object method "search" via package
"Koha::Account::DebitTypes"
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 30 10:53:51 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Jan 2020 09:53:51 +0000
Subject: [Koha-bugs] [Bug 24542] Checkout page - Can't locate object method
 "search" via package "Koha::Account::DebitTypes"
In-Reply-To: <bug-24542-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24542-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24542-70-T2s579tRK6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24542

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 30 10:53:54 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Jan 2020 09:53:54 +0000
Subject: [Koha-bugs] [Bug 24542] Checkout page - Can't locate object method
 "search" via package "Koha::Account::DebitTypes"
In-Reply-To: <bug-24542-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24542-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24542-70-9Jox601CAd@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24542

--- Comment #1 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 98142
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98142&action=edit
Bug 24542: (bug 23049 follow-up) Add missing use statement in Koha::Account

Fix the following error when an item is checked out and that
ManInvInNoissuesCharge is turned off:
Can't locate object method "search" via package "Koha::Account::DebitTypes"

Test plan:
0/ Turn off ManInvInNoissuesCharge
1/ Check an item out

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 30 10:57:01 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Jan 2020 09:57:01 +0000
Subject: [Koha-bugs] [Bug 22690] Merging records with many items too slow
 (Elasticsearch)
In-Reply-To: <bug-22690-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22690-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22690-70-cSkihCdHQP@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22690

Michal Denar <black23 at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 30 10:57:04 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Jan 2020 09:57:04 +0000
Subject: [Koha-bugs] [Bug 22690] Merging records with many items too slow
 (Elasticsearch)
In-Reply-To: <bug-22690-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22690-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22690-70-hFYvWPo1Wz@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22690

Michal Denar <black23 at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #97696|0                           |1
        is obsolete|                            |

--- Comment #20 from Michal Denar <black23 at gmail.com> ---
Created attachment 98143
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98143&action=edit
Bug 22690: Refactor merging of records to improve performance (Elasticsearch)

This patch allows merging of records with many items without the web server
timing out.

Test plan:

Without the patch:

- Create 2 records (one with e.g. 1000 items).
- Do a cataloguing search that displays both records, select them and click
"Merge selected".
- Choose the record with many items as the one to be eliminated.
- Start the merging.
- After a while the web server should give you a timeout error (the merging
process may still continue)

With the patch:
- Do the same as above
- This time verify that the records are merged without timeout
- Create a new biblio with an item
- Add with the item:
  * acquisition order
  * hold (reserve)
- Merge the biblio to another one
- Verify that the item and its related data was moved
- Verify that tests pass:
  prove -v t/db_dependent/Koha/Item.t
  prove -v t/db_dependent/Items/MoveItemFromBiblio.t

Signed-off-by: Michal Denar <black23 at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 30 10:58:03 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Jan 2020 09:58:03 +0000
Subject: [Koha-bugs] [Bug 21190] GDPR: Log successful/unsuccessful login
 attempts [part 1]
In-Reply-To: <bug-21190-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21190-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21190-70-cDNLT6so2s@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21190

--- Comment #56 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
(In reply to Michal Denar from comment #55)
> Signed-off-by: Michal Denar <black23 at gmail.com>

Thanks Michal too!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 30 11:00:49 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Jan 2020 10:00:49 +0000
Subject: [Koha-bugs] [Bug 24542] Checkout page - Can't locate object method
 "search" via package "Koha::Account::DebitTypes"
In-Reply-To: <bug-24542-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24542-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24542-70-iNxIcndhyJ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24542

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Trivial patch
                 CC|                            |martin.renvoize at ptfs-europe
                   |                            |.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 30 11:01:32 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Jan 2020 10:01:32 +0000
Subject: [Koha-bugs] [Bug 24542] Checkout page - Can't locate object method
 "search" via package "Koha::Account::DebitTypes"
In-Reply-To: <bug-24542-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24542-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24542-70-r9w4Os76cQ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24542

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #98142|0                           |1
        is obsolete|                            |

--- Comment #2 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 98144
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98144&action=edit
Bug 24542: (bug 23049 follow-up) Add missing use statement in Koha::Account

Fix the following error when an item is checked out and that
ManInvInNoissuesCharge is turned off:
Can't locate object method "search" via package "Koha::Account::DebitTypes"

Test plan:
0/ Turn off ManInvInNoissuesCharge
1/ Check an item out

Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 30 11:02:14 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Jan 2020 10:02:14 +0000
Subject: [Koha-bugs] [Bug 24542] Checkout page - Can't locate object method
 "search" via package "Koha::Account::DebitTypes"
In-Reply-To: <bug-24542-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24542-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24542-70-GHQJVAuvon@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24542

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

--- Comment #3 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Yikes, going straight for a QA on this one.. very trivial patch.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 30 11:02:19 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Jan 2020 10:02:19 +0000
Subject: [Koha-bugs] [Bug 24542] Checkout page - Can't locate object method
 "search" via package "Koha::Account::DebitTypes"
In-Reply-To: <bug-24542-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24542-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24542-70-TKFc2yCcqh@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24542

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 30 11:02:23 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Jan 2020 10:02:23 +0000
Subject: [Koha-bugs] [Bug 24542] Checkout page - Can't locate object method
 "search" via package "Koha::Account::DebitTypes"
In-Reply-To: <bug-24542-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24542-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24542-70-m4aZBnQxLa@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24542

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         QA Contact|testopia at bugs.koha-communit |martin.renvoize at ptfs-europe
                   |y.org                       |.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 30 11:03:15 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Jan 2020 10:03:15 +0000
Subject: [Koha-bugs] [Bug 24542] Checkout page - Can't locate object method
 "search" via package "Koha::Account::DebitTypes"
In-Reply-To: <bug-24542-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24542-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24542-70-PluMbY8sW0@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24542

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|                            |20.05.00
        released in|                            |
             Status|Passed QA                   |Pushed to master

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 30 11:03:17 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Jan 2020 10:03:17 +0000
Subject: [Koha-bugs] [Bug 24542] Checkout page - Can't locate object method
 "search" via package "Koha::Account::DebitTypes"
In-Reply-To: <bug-24542-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24542-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24542-70-GiJQUBIpmp@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24542

--- Comment #4 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Nice work everyone!

Pushed to master for 20.05

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 30 11:07:49 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Jan 2020 10:07:49 +0000
Subject: [Koha-bugs] [Bug 22844] Simplify the process of selecting database
 columns for system preferences
In-Reply-To: <bug-22844-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22844-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22844-70-YIfETKAR85@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22844

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 30 11:07:52 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Jan 2020 10:07:52 +0000
Subject: [Koha-bugs] [Bug 22844] Simplify the process of selecting database
 columns for system preferences
In-Reply-To: <bug-22844-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22844-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22844-70-1rYxG95dPo@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22844

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #89530|0                           |1
        is obsolete|                            |

--- Comment #32 from David Nind <david at davidnind.com> ---
Created attachment 98145
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98145&action=edit
Bug 22844: Simplify the process of selecting database columns for system
preferences

This patch introduces a new way for users to select database columns for
system preferences like BorrowerMandatoryField, which currently
require hand-typing of database names.

This new system uses a JSON file containing label:column pairs for
database columns which are relevant to preferences which reference
borrower table columns. My intention was to have user-friendly values as
the labels, but embedding English strings in JSON would make them
untranslatable.

The following preferences are affected:

 - BorrowerMandatoryField
 - BorrowerUnwantedField
 - PatronSelfModificationBorrowerUnwantedField
 - PatronSelfRegistrationBorrowerMandatoryField
 - PatronSelfRegistrationBorrowerUnwantedField

To test, apply the patch and regenerate the staff client CSS.
restart_all to make sure the updated .pref file is used.

 - Go to Administration -> System preferences, and search for
   "PatronSelf"
 - The input fields for PatronSelfModificationBorrowerUnwantedField,
   PatronSelfRegistrationBorrowerMandatoryField, and
   PatronSelfRegistrationBorrowerUnwantedField should appear as "locked"
   (read-only) inputs.
 - Clicking the input field should trigger a modal window with
   checkboxes for each available column from the borrowers table.
 - Test that the "select all" and "clear all" links work correctly.
 - Test that the "cancel" link closes the modal without saving your
   selections.
 - Test that the "Save" button closes the modal, copies your selections
   to the form field, and triggers the preference-saving function (this
   eliminates the need to click a save button again after closing the
   modal).
   - Test this process by making modifications to all three different
     preferences, confirming that the right data is preselected each
     time the modal is shown and the right data is saved to the right
     field each time.

Signed-off-by: Hayley Mapley <hayleymapley at catalyst.net.nz>

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

Signed-off-by: David Nind <david at davidnind.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 30 11:07:56 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Jan 2020 10:07:56 +0000
Subject: [Koha-bugs] [Bug 22844] Simplify the process of selecting database
 columns for system preferences
In-Reply-To: <bug-22844-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22844-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22844-70-agULA7OEZ4@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22844

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #89531|0                           |1
        is obsolete|                            |

--- Comment #33 from David Nind <david at davidnind.com> ---
Created attachment 98146
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98146&action=edit
Bug 22844: (QA follow-up) Add pref PatronQuickAddFields too

Description slightly adjusted.

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

Signed-off-by: David Nind <david at davidnind.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 30 11:08:00 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Jan 2020 10:08:00 +0000
Subject: [Koha-bugs] [Bug 22844] Simplify the process of selecting database
 columns for system preferences
In-Reply-To: <bug-22844-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22844-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22844-70-TSsZEEqkh5@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22844

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #89903|0                           |1
        is obsolete|                            |

--- Comment #34 from David Nind <david at davidnind.com> ---
Created attachment 98147
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98147&action=edit
Bug 22844: Add the new DB column borrower_attribute_types.mandatory

Signed-off-by: David Nind <david at davidnind.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 30 11:08:04 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Jan 2020 10:08:04 +0000
Subject: [Koha-bugs] [Bug 22844] Simplify the process of selecting database
 columns for system preferences
In-Reply-To: <bug-22844-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22844-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22844-70-byppv52WKe@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22844

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #89904|0                           |1
        is obsolete|                            |

--- Comment #35 from David Nind <david at davidnind.com> ---
Created attachment 98148
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98148&action=edit
Bug 22844: Add the new entry to the patron attr types form

Will conflict with bug 20443 \o/

Signed-off-by: David Nind <david at davidnind.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 30 11:08:08 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Jan 2020 10:08:08 +0000
Subject: [Koha-bugs] [Bug 22844] Simplify the process of selecting database
 columns for system preferences
In-Reply-To: <bug-22844-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22844-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22844-70-porhIZgCGo@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22844

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #89905|0                           |1
        is obsolete|                            |

--- Comment #36 from David Nind <david at davidnind.com> ---
Created attachment 98149
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98149&action=edit
Bug 22844: Make the attribute mandatory when editing a patron

Note: I am not confident with this patch, I think it's not polished. I
will not have time to improve it to make it ready for 19.05.00
1. Conflict with bug 20443 (which would have make this change way much
easier!)
2. It does not work :) You will be able to submit the memberentry form
even if the patron attribute is marked as mandatory (??)
3. What about the OPAC?
4. What about repeatable fields? We certainly will need JS code here
5. What about the "Quick add" feature? (I had trouble in the past to not
introduce regression when we played with this template...)

Do not forget to run updatedatabase.pl and regenerate DBIC schema if you
want to play with this patchset.

Signed-off-by: David Nind <david at davidnind.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 30 11:08:12 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Jan 2020 10:08:12 +0000
Subject: [Koha-bugs] [Bug 22844] Simplify the process of selecting database
 columns for system preferences
In-Reply-To: <bug-22844-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22844-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22844-70-DNkV45Jz9a@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22844

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #90407|0                           |1
        is obsolete|                            |

--- Comment #37 from David Nind <david at davidnind.com> ---
Created attachment 98150
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98150&action=edit
Bug 22844: (QA follow-up) Build items.json for UniqueItemFields

Adding items.json, built from latest kohastructure.sql.
Control UniqueItemFields with this source file.
And add StatisticsFields.

Test plan:
Go to Preferences, play with UniqueItemFields.
Adjust StatisticsFields and look at patron record, statistics tab.

Moved-from: Bug 22867
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

Signed-off-by: David Nind <david at davidnind.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 30 11:08:16 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Jan 2020 10:08:16 +0000
Subject: [Koha-bugs] [Bug 22844] Simplify the process of selecting database
 columns for system preferences
In-Reply-To: <bug-22844-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22844-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22844-70-yKiaLVSVZ8@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22844

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #96007|0                           |1
        is obsolete|                            |

--- Comment #38 from David Nind <david at davidnind.com> ---
Created attachment 98151
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98151&action=edit
Bug 22844: (follow-up) Make the attribute mandatory when editing a patron

Previous patch forgot the most important, adding the required attribute
to the select/textarea

Signed-off-by: David Nind <david at davidnind.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 30 11:09:04 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Jan 2020 10:09:04 +0000
Subject: [Koha-bugs] [Bug 24541] Database cleanups, purge messages
In-Reply-To: <bug-24541-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24541-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24541-70-sIvOwDbAut@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24541

didier <didier.gautheron at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 30 11:09:06 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Jan 2020 10:09:06 +0000
Subject: [Koha-bugs] [Bug 24541] Database cleanups, purge messages
In-Reply-To: <bug-24541-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24541-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24541-70-sAkHBdhvNc@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24541

--- Comment #1 from didier <didier.gautheron at biblibre.com> ---
Created attachment 98152
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98152&action=edit
Bug 24541: Purge old messages

misc/cronjobs/cleanup_database.pl provides some database cleanup.

This patch adds cleanup for messages table.

Test plan :
- Count messages : select count(*),date(message_date) from  messages group by
date(message_date);
- Run cleanup : misc/cronjobs/cleanup_database.pl -v --messages 365
- Recount messages

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 30 11:09:29 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Jan 2020 10:09:29 +0000
Subject: [Koha-bugs] [Bug 22844] Simplify the process of selecting database
 columns for system preferences
In-Reply-To: <bug-22844-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22844-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22844-70-ZrlzLWClhx@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22844

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |david at davidnind.com

--- Comment #39 from David Nind <david at davidnind.com> ---
Hope I tested this correctly - followed steps in comment 6 and 27, and
everything seemed to work nicely!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 30 11:10:15 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Jan 2020 10:10:15 +0000
Subject: [Koha-bugs] [Bug 20271] Merge deleted biblio, biblioitems,
 biblio_metadata, and items tables
In-Reply-To: <bug-20271-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20271-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20271-70-JEHqndsryk@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271

--- Comment #203 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Hmm.. CHECK constraints come to mind.. but to use them we would need to up our
minimum MySQL and MariaDB versions.. and carefully test how their
implementations of CHECK constraints compare.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 30 11:20:17 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Jan 2020 10:20:17 +0000
Subject: [Koha-bugs] [Bug 21586] Add generic OpenIDConnect client
 implementation
In-Reply-To: <bug-21586-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21586-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21586-70-gmgu1C6GNP@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21586

--- Comment #13 from Michal Denar <black23 at gmail.com> ---
Great news, David.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 30 11:23:44 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Jan 2020 10:23:44 +0000
Subject: [Koha-bugs] [Bug 24531] OAI-PMH set mappings only consider first
 field with a given tag
In-Reply-To: <bug-24531-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24531-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24531-70-qAoTxB4cxj@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24531

Magnus Enger <magnus at libriotech.no> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |magnus at libriotech.no
                   |ity.org                     |

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 30 11:33:27 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Jan 2020 10:33:27 +0000
Subject: [Koha-bugs] [Bug 24531] OAI-PMH set mappings only consider first
 field with a given tag
In-Reply-To: <bug-24531-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24531-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24531-70-YBFJ408lJt@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24531

--- Comment #2 from Magnus Enger <magnus at libriotech.no> ---
Created attachment 98153
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98153&action=edit
Bug 24531 - Test for OAI-PMH sets and repeated fields

This patch adds two tests related to OAI-PMH sets. It creates a
dummy record with a repeated field, with different values. It then
tests if the record is caught by mappings that match the value in
the first field, and then if it is caught by mappings that match
the second field.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 30 11:33:30 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Jan 2020 10:33:30 +0000
Subject: [Koha-bugs] [Bug 24531] OAI-PMH set mappings only consider first
 field with a given tag
In-Reply-To: <bug-24531-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24531-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24531-70-lPtkONAVIB@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24531

--- Comment #3 from Magnus Enger <magnus at libriotech.no> ---
Created attachment 98154
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98154&action=edit
Bug 24531 - Fix OAI-PMH sets for records with repeated fields

Currently, an OAI-PMH set mapping will only match if the value it
is looking for occurs in the first instance of a repeated field.

To test:
- Apply the first patch with two new tests
- Run something like this:
  sudo koha-shell -c "prove -v t/db_dependent/OAI/Sets.t" kohadev
- Verify that the last test fails
- Apply this secind patch
- Rerun the test file above
- Verify that all tests now pass

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 30 11:34:10 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Jan 2020 10:34:10 +0000
Subject: [Koha-bugs] [Bug 24531] OAI-PMH set mappings only consider first
 field with a given tag
In-Reply-To: <bug-24531-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24531-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24531-70-1IFhDdTfZo@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24531

Magnus Enger <magnus at libriotech.no> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff
   Patch complexity|---                         |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 30 11:36:30 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Jan 2020 10:36:30 +0000
Subject: [Koha-bugs] [Bug 20271] Merge deleted biblio, biblioitems,
 biblio_metadata, and items tables
In-Reply-To: <bug-20271-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20271-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20271-70-PwJ0UKGlAW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271

--- Comment #204 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
I think i like your suggestion of 'is_alive'/'is_current' the best at the
moment.. it feels like the cleanest approach so far and does not require a DB
version lift or additional linked tables etc.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 30 11:38:56 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Jan 2020 10:38:56 +0000
Subject: [Koha-bugs] [Bug 24338] CASH is missing from the default
 payment_types
In-Reply-To: <bug-24338-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24338-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24338-70-0HHq0d3N2V@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24338

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |david at davidnind.com

--- Comment #2 from David Nind <david at davidnind.com> ---
On master I can already see a CASH payment type, so not sure whether this is
required or not.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 30 11:42:27 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Jan 2020 10:42:27 +0000
Subject: [Koha-bugs] [Bug 21190] GDPR: Log successful/unsuccessful login
 attempts [part 1]
In-Reply-To: <bug-21190-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21190-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21190-70-rsNClJUtCx@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21190

--- Comment #57 from Magnus Enger <magnus at libriotech.no> ---
(In reply to Marcel de Rooy from comment #46)
> Created attachment 98125 [details] [review]
> Bug 21190: (follow-up) Save patron id in failure when available
> 
> The wrong password might belong to an existing user. If that is the case,
> we have a $patron.
> Note that logaction will save the object info but has no user in the
> context environment for a failure.
> 
> Test plan:
> Login with good user, bad pw and bad user, bad pw. Check logviewer.

Thanks, Marcel! Looks like people beat me to the signoff, though. :-)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 30 11:43:46 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Jan 2020 10:43:46 +0000
Subject: [Koha-bugs] [Bug 23031] Improve UX of buttons on order search page
In-Reply-To: <bug-23031-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23031-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23031-70-ffaNkdhSEY@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23031

--- Comment #8 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
(In reply to Jonathan Druart from comment #7)
> (In reply to Katrin Fischer from comment #5)
> > If I understand this correctly, the 'view' is on the basket name link and
> > the 'add to order' is default action on the button?
> 
> Yes, from comment 0:
> """
> The "View" part of the split button is an unnecessary duplication of the
> linked basket name earlier in the table
> """

All good then :)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 30 11:50:53 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Jan 2020 10:50:53 +0000
Subject: [Koha-bugs] [Bug 24543] New: Wrong test in api/v1/checkouts.t
Message-ID: <bug-24543-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24543

            Bug ID: 24543
           Summary: Wrong test in api/v1/checkouts.t
 Change sponsored?: ---
           Product: Koha
           Version: unspecified
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: Test Suite
          Assignee: chris at bigballofwax.co.nz
          Reporter: jonathan.druart at bugs.koha-community.org
        QA Contact: testopia at bugs.koha-community.org

In t/db_dependent/api/v1/checkouts.t we define a circulation rule with
renewalperiod=7. But then the expected due date is today+14 days.
However, at the beginning of the script, the due_date of the issue is today+14
days.

That highlight that the renewal period is not taken into account.

The circulation rule is created with renewalperiod and renewalsallowed, however
GetLoanLength check the existence of issuelength to return the rule.
GetLoanLength finally return the default rule, with renewalperiod=0

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 30 11:51:12 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Jan 2020 10:51:12 +0000
Subject: [Koha-bugs] [Bug 24543] Wrong test in api/v1/checkouts.t
In-Reply-To: <bug-24543-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24543-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24543-70-HHbfaeYrHc@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24543

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|chris at bigballofwax.co.nz    |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org
                 CC|                            |joonas.kylmala at helsinki.fi
         Depends on|                            |13895
             Status|NEW                         |ASSIGNED


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13895
[Bug 13895] Add routes for checkouts retrieval and renewal
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 30 11:51:12 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Jan 2020 10:51:12 +0000
Subject: [Koha-bugs] [Bug 13895] Add routes for checkouts retrieval and
 renewal
In-Reply-To: <bug-13895-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-13895-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-13895-70-9MxkkNfEne@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13895

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |24543


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24543
[Bug 24543] Wrong test in api/v1/checkouts.t
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 30 11:53:13 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Jan 2020 10:53:13 +0000
Subject: [Koha-bugs] [Bug 24543] Wrong test in api/v1/checkouts.t
In-Reply-To: <bug-24543-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24543-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24543-70-CH5fwzlzxA@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24543

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 30 11:53:17 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Jan 2020 10:53:17 +0000
Subject: [Koha-bugs] [Bug 24543] Wrong test in api/v1/checkouts.t
In-Reply-To: <bug-24543-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24543-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24543-70-20rjIKtTAS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24543

--- Comment #1 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 98155
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98155&action=edit
Bug 24543: Fix wrong test in api/v1/checkouts.t

In t/db_dependent/api/v1/checkouts.t we define a circulation rule with
renewalperiod=7.
But then the expected due date is today+14 days.
However, at the beginning of the script, the due_date of the issue is today+14
days.

That highlight that the renewal period is not taken into account.

The circulation rule is created with renewalperiod and renewalsallowed,
however GetLoanLength check the existence of issuelength to return the rule.
GetLoanLength finally return the default rule, with renewalperiod=0

Note that this has been found working on bug 18936, code will be cleaned on
that patchset.

Test plan:
 % prove t/db_dependent/api/v1/checkouts.t
must return green before and after this patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 30 11:53:35 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Jan 2020 10:53:35 +0000
Subject: [Koha-bugs] [Bug 23896] logaction should pass the correct interface
 to Koha::Logger
In-Reply-To: <bug-23896-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23896-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23896-70-zgWKdxsJE9@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23896

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|enhancement                 |normal

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 30 11:56:35 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Jan 2020 10:56:35 +0000
Subject: [Koha-bugs] [Bug 23594] Batch modification for itemtypes on
 suggestions page
In-Reply-To: <bug-23594-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23594-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23594-70-OkoHXjttLM@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23594

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Text to go in the|                            |This enhancement allows
      release notes|                            |users to update the item
                   |                            |types for selected
                   |                            |suggestions on the
                   |                            |suggestions management
                   |                            |page.
                 CC|                            |martin.renvoize at ptfs-europe
                   |                            |.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 30 11:56:44 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Jan 2020 10:56:44 +0000
Subject: [Koha-bugs] [Bug 23594] Batch modification for itemtypes on
 suggestions page
In-Reply-To: <bug-23594-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23594-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23594-70-bDd5eeXrCN@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23594

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |Manual

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 30 11:59:43 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Jan 2020 10:59:43 +0000
Subject: [Koha-bugs] [Bug 24347] Add a 'search to order' option similar to
 'search to hold'
In-Reply-To: <bug-24347-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24347-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24347-70-B238RQurxZ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24347

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |martin.renvoize at ptfs-europe
                   |                            |.com
           Keywords|                            |release-notes-needed

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 30 12:01:46 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Jan 2020 11:01:46 +0000
Subject: [Koha-bugs] [Bug 24347] Add a 'search to order' option similar to
 'search to hold'
In-Reply-To: <bug-24347-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24347-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24347-70-MDKLpFJlyc@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24347

--- Comment #9 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
This introduces a new cookie right.. should this get recorded on the wiki page
for cookies?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 30 12:02:35 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Jan 2020 11:02:35 +0000
Subject: [Koha-bugs] [Bug 24347] Add a 'search to order' option similar to
 'search to hold'
In-Reply-To: <bug-24347-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24347-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24347-70-pNsPexm2mA@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24347

--- Comment #10 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
https://wiki.koha-community.org/wiki/Use_of_Cookies - Katrin or Owen.. could
you do the honours pretty please.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 30 12:03:28 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Jan 2020 11:03:28 +0000
Subject: [Koha-bugs] [Bug 22683] Make issue and old_issue prefetchable from
 Koha::Account::Line
In-Reply-To: <bug-22683-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22683-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22683-70-HQ1ZK42X9L@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22683

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org

--- Comment #10 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
You are adding 2 FK on the same column? I do not think this is possible.

Moreover you add a note for the 2 constraints:
+Note: This DBIC only relationship should be removed (as it will get
automatically recreated)
+if we add a proper foreign key for accountlines.issue_id

But we will not be able to create this constraint at DB level.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 30 12:03:46 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Jan 2020 11:03:46 +0000
Subject: [Koha-bugs] [Bug 17697] Improve NotesBlacklist system preference
 description to make clear where it will apply
In-Reply-To: <bug-17697-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17697-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17697-70-ina3vAXahz@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17697

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|                            |20.05.00
        released in|                            |
             Status|Passed QA                   |Pushed to master

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 30 12:03:48 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Jan 2020 11:03:48 +0000
Subject: [Koha-bugs] [Bug 17697] Improve NotesBlacklist system preference
 description to make clear where it will apply
In-Reply-To: <bug-17697-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17697-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17697-70-M5KgKk62qF@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17697

--- Comment #9 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Nice work everyone!

Pushed to master for 20.05

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 30 12:03:50 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Jan 2020 11:03:50 +0000
Subject: [Koha-bugs] [Bug 23031] Improve UX of buttons on order search page
In-Reply-To: <bug-23031-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23031-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23031-70-ImQFGzK07G@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23031

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|                            |20.05.00
        released in|                            |
             Status|Passed QA                   |Pushed to master

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 30 12:03:52 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Jan 2020 11:03:52 +0000
Subject: [Koha-bugs] [Bug 23031] Improve UX of buttons on order search page
In-Reply-To: <bug-23031-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23031-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23031-70-wwlJ38Ww7T@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23031

--- Comment #9 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Nice work everyone!

Pushed to master for 20.05

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 30 12:03:54 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Jan 2020 11:03:54 +0000
Subject: [Koha-bugs] [Bug 23594] Batch modification for itemtypes on
 suggestions page
In-Reply-To: <bug-23594-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23594-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23594-70-YumoBHpXB4@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23594

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to master
         Version(s)|                            |20.05.00
        released in|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 30 12:03:56 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Jan 2020 11:03:56 +0000
Subject: [Koha-bugs] [Bug 23594] Batch modification for itemtypes on
 suggestions page
In-Reply-To: <bug-23594-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23594-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23594-70-yZNx2EqxKL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23594

--- Comment #30 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Nice work everyone!

Pushed to master for 20.05

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 30 12:03:58 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Jan 2020 11:03:58 +0000
Subject: [Koha-bugs] [Bug 23896] logaction should pass the correct interface
 to Koha::Logger
In-Reply-To: <bug-23896-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23896-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23896-70-yVx9aJRkBj@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23896

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to master
         Version(s)|                            |20.05.00
        released in|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 30 12:03:59 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Jan 2020 11:03:59 +0000
Subject: [Koha-bugs] [Bug 23896] logaction should pass the correct interface
 to Koha::Logger
In-Reply-To: <bug-23896-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23896-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23896-70-OZP9X6t9Hv@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23896

--- Comment #11 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Nice work everyone!

Pushed to master for 20.05

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 30 12:04:01 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Jan 2020 11:04:01 +0000
Subject: [Koha-bugs] [Bug 23915] Replace OPAC list sort menu with Bootstrap
 menu button
In-Reply-To: <bug-23915-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23915-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23915-70-hLwv4aVcJt@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23915

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|                            |20.05.00
        released in|                            |
             Status|Passed QA                   |Pushed to master

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 30 12:04:03 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Jan 2020 11:04:03 +0000
Subject: [Koha-bugs] [Bug 23915] Replace OPAC list sort menu with Bootstrap
 menu button
In-Reply-To: <bug-23915-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23915-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23915-70-nAcj8bFLqz@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23915

--- Comment #10 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Nice work everyone!

Pushed to master for 20.05

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 30 12:04:05 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Jan 2020 11:04:05 +0000
Subject: [Koha-bugs] [Bug 24347] Add a 'search to order' option similar to
 'search to hold'
In-Reply-To: <bug-24347-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24347-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24347-70-uj23DuYd9U@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24347

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|                            |20.05.00
        released in|                            |
             Status|Passed QA                   |Pushed to master

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 30 12:04:06 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Jan 2020 11:04:06 +0000
Subject: [Koha-bugs] [Bug 24347] Add a 'search to order' option similar to
 'search to hold'
In-Reply-To: <bug-24347-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24347-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24347-70-wp1BW4E48B@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24347

--- Comment #11 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Nice work everyone!

Pushed to master for 20.05

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 30 12:04:21 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Jan 2020 11:04:21 +0000
Subject: [Koha-bugs] [Bug 23031] Improve UX of buttons on order search page
In-Reply-To: <bug-23031-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23031-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23031-70-cqz2bFtRHF@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23031

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |Manual
                 CC|                            |martin.renvoize at ptfs-europe
                   |                            |.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 30 12:04:58 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Jan 2020 11:04:58 +0000
Subject: [Koha-bugs] [Bug 22684] Make Acquisition::Basket->bookseller match
 the code guidlines
In-Reply-To: <bug-22684-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22684-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22684-70-KeRwLyyKFd@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22684

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Failed QA
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org

--- Comment #2 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
No, a basket must have a vendor, we do not need this patch.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 30 12:07:36 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Jan 2020 11:07:36 +0000
Subject: [Koha-bugs] [Bug 24347] Add a 'search to order' option similar to
 'search to hold'
In-Reply-To: <bug-24347-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24347-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24347-70-GROPlfqe2Z@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24347

--- Comment #12 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
(In reply to Martin Renvoize from comment #10)
> https://wiki.koha-community.org/wiki/Use_of_Cookies - Katrin or Owen.. could
> you do the honours pretty please.

I already added a personal tag about it yesterday :) Is there a way we could
mark them otherwise/publicly? I have an update of the cookie docs on the agenda
since I think I found a few missing.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 30 12:08:50 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Jan 2020 11:08:50 +0000
Subject: [Koha-bugs] [Bug 22685] Koha::Acquisition::Bookseller methods must
 return Koha::Objects using the DBIx::Class relationships
In-Reply-To: <bug-22685-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22685-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22685-70-JVtSSpCA4F@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22685

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Koha::Acquisition::Booksell |Koha::Acquisition::Booksell
                   |er->baskets returns a dbic  |er methods must return
                   |resultset rather than       |Koha::Objects using the
                   |Koha::Objects               |DBIx::Class relationships
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 30 12:08:56 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Jan 2020 11:08:56 +0000
Subject: [Koha-bugs] [Bug 22685] Koha::Acquisition::Bookseller methods must
 return Koha::Objects using the DBIx::Class relationships
In-Reply-To: <bug-22685-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22685-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22685-70-JHhxsQtsy1@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22685

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |jonathan.druart at bugs.koha-c
                   |ity.org                     |ommunity.org
             Status|NEW                         |ASSIGNED

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 30 12:15:09 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Jan 2020 11:15:09 +0000
Subject: [Koha-bugs] [Bug 24330] When importing patrons from CSV,
 automatically strip BOM from file if it exists
In-Reply-To: <bug-24330-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24330-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24330-70-2kWYabyAtk@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24330

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #96789|0                           |1
        is obsolete|                            |

--- Comment #6 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 98156
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98156&action=edit
Bug 24330: When importing patrons from CSV, automatically strip BOM from file
if it exists

We have a partner that exports UTF-8 CSV files, and is experiencing the same
thing as the author of this article:
https://www.freecodecamp.org/news/a-quick-tale-about-feff-the-invisible-character-cd25cd4630e7/

In short, Excel is inserting an invisible UTF-8 character at the start of the
file, so that the column name "cardnumber" is actually named
"\x{feff}cardnumber", causing "cardnumber" to be blank.

A simple solution is provided here:
https://stackoverflow.com/questions/24390034/remove-bom-from-string-with-perl

Test Plan:
1) Download the example.csv file
2) Attempt to import it using the patron import tool
3) Note the invalid column name error
4) Apply this patch, restart all the things!
5) Attempt the import again
6) Assuming you have a branchcode MPL and a cataegory code S, the patron should
import!

Signed-off-by: David Nind <david at davidnind.com>

Signed-off-by: Yew Chung College Library <library at yccece.edu.hk>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 30 12:39:05 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Jan 2020 11:39:05 +0000
Subject: [Koha-bugs] [Bug 22685] Koha::Acquisition::Bookseller methods must
 return Koha::Objects using the DBIx::Class relationships
In-Reply-To: <bug-22685-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22685-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22685-70-QrIB7KLyWF@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22685

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 30 12:39:08 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Jan 2020 11:39:08 +0000
Subject: [Koha-bugs] [Bug 22685] Koha::Acquisition::Bookseller methods must
 return Koha::Objects using the DBIx::Class relationships
In-Reply-To: <bug-22685-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22685-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22685-70-UQW8x4uDCt@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22685

--- Comment #1 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 98157
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98157&action=edit
Bug 22685: Use DBIx::Class relationships in Koha::Acq::Bookseller methods

To match PERL15 we change the behavior of Koha::Object methods to make
them use the DBIx::Class relationships.

Test plan:
- Create a vendor, basket and contact
- Edit the vendor => the contact must appears
- Go to the view of a vendor => you cannot delete the vendor, it has
a basket attached
- Create another vendor, without basket
- Go to the view of the vendor => You can delete it

Additionally:
 % prove t/db_dependent/Koha/Acquisition/Booksellers.t
must return green

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 30 12:41:25 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Jan 2020 11:41:25 +0000
Subject: [Koha-bugs] [Bug 21190] GDPR: Log successful/unsuccessful login
 attempts [part 1]
In-Reply-To: <bug-21190-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21190-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21190-70-xasHNh82tc@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21190

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |martin.renvoize at ptfs-europe
                   |                            |.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 30 13:00:45 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Jan 2020 12:00:45 +0000
Subject: [Koha-bugs] [Bug 24330] When importing patrons from CSV,
 automatically strip BOM from file if it exists
In-Reply-To: <bug-24330-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24330-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24330-70-e0dtLQcMWI@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24330

--- Comment #7 from Kyle M Hall <kyle at bywatersolutions.com> ---
(In reply to Jonathan Druart from comment #4)
> The example CSV file works correctly for me without the patch.

I must admit I can no longer recreate the error, it appears I've lost the
specific file that caused the error. The uploaded file no longer has the feff
bom.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 30 13:05:24 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Jan 2020 12:05:24 +0000
Subject: [Koha-bugs] [Bug 24544] New: Add a script for inserting persistent
 identifiers to MARC records
Message-ID: <bug-24544-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24544

            Bug ID: 24544
           Summary: Add a script for inserting persistent identifiers to
                    MARC records
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Command-line Utilities
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: m.de.rooy at rijksmuseum.nl
        QA Contact: testopia at bugs.koha-community.org
                CC: robin at catalyst.net.nz

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 30 13:05:38 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Jan 2020 12:05:38 +0000
Subject: [Koha-bugs] [Bug 24544] Add a script for inserting persistent
 identifiers to MARC records
In-Reply-To: <bug-24544-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24544-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24544-70-7PMIIgkK5x@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24544

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
           Assignee|koha-bugs at lists.koha-commun |m.de.rooy at rijksmuseum.nl
                   |ity.org                     |

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 30 13:22:44 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Jan 2020 12:22:44 +0000
Subject: [Koha-bugs] [Bug 22833] Block suspend and cancel on holds
In-Reply-To: <bug-22833-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22833-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22833-70-aMlQS9Y85u@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22833

Stina Hallin <stina.hallin at ub.lu.se> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |stina.hallin at ub.lu.se

--- Comment #6 from Stina Hallin <stina.hallin at ub.lu.se> ---
Hello Magnus, I tried the patch, but when testing, Koha gave an error message
when I unchecked the Cancel and Suspend hold check boxes on the Item types
administration side (the error message came after saving). It said "Error when
saving..." The new settings where not saved.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 30 13:32:51 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Jan 2020 12:32:51 +0000
Subject: [Koha-bugs] [Bug 24431] Convert overpayment on accruing fines into
 credits
In-Reply-To: <bug-24431-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24431-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24431-70-Czmm8McT8L@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24431

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |DUPLICATE

--- Comment #1 from Kyle M Hall <kyle at bywatersolutions.com> ---
As far as I can tell, this was implemented in bug 21727.

*** This bug has been marked as a duplicate of bug 21727 ***

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 30 13:32:51 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Jan 2020 12:32:51 +0000
Subject: [Koha-bugs] [Bug 21727] Add Koha::Account::Line->adjust
In-Reply-To: <bug-21727-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21727-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21727-70-kzw8IiA5oE@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21727

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|19.05                       |---

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |andrew at bywatersolutions.com

--- Comment #34 from Kyle M Hall <kyle at bywatersolutions.com> ---
*** Bug 24431 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 30 13:48:36 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Jan 2020 12:48:36 +0000
Subject: [Koha-bugs] [Bug 20271] Merge deleted biblio, biblioitems,
 biblio_metadata, and items tables
In-Reply-To: <bug-20271-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20271-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20271-70-v9Uxohed8Z@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271

--- Comment #205 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Additional question: what's the point of biblioitem.deleted_on and
biblio_metadata.deleted_on?
I think we only need items.deleted_on and biblio.deleted_on

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 30 13:59:49 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Jan 2020 12:59:49 +0000
Subject: [Koha-bugs] [Bug 20271] Merge deleted biblio, biblioitems,
 biblio_metadata, and items tables
In-Reply-To: <bug-20271-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20271-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20271-70-tcXa53V0Fr@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271

--- Comment #206 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
(In reply to Jonathan Druart from comment #205)
> Additional question: what's the point of biblioitem.deleted_on and
> biblio_metadata.deleted_on?
> I think we only need items.deleted_on and biblio.deleted_on

As long as we have biblioitems, a last change can be helpful. But I agree we
are actually using biblioitems as an overflow for biblio only. The columns
could be moved up.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 30 14:09:13 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Jan 2020 13:09:13 +0000
Subject: [Koha-bugs] [Bug 24431] Convert overpayment on accruing fines into
 credits
In-Reply-To: <bug-24431-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24431-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24431-70-2zOH9yx1vs@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24431

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |martin.renvoize at ptfs-europe
                   |                            |.com

--- Comment #2 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---


*** This bug has been marked as a duplicate of bug 21747 ***

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 30 14:09:13 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Jan 2020 13:09:13 +0000
Subject: [Koha-bugs] [Bug 21747] Update C4::Overdues::UpdateFine to use
 Koha::Account->add_debit and Koha::Account::Line->adjust
In-Reply-To: <bug-21747-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21747-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21747-70-FV8C3oQUbf@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21747

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|19.05                       |---
                 CC|                            |andrew at bywatersolutions.com

--- Comment #26 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
*** Bug 24431 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 30 14:09:54 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Jan 2020 13:09:54 +0000
Subject: [Koha-bugs] [Bug 24431] Convert overpayment on accruing fines into
 credits
In-Reply-To: <bug-24431-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24431-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24431-70-dcw7GilTTU@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24431

--- Comment #3 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
I think it's actually 21747 which switches UpdateFine to using the adjust
method added in bug 21727 and as such is the duplicate here :)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 30 14:12:17 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Jan 2020 13:12:17 +0000
Subject: [Koha-bugs] [Bug 24532] Some account types are converted to debits
 when they shouldn't be
In-Reply-To: <bug-24532-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24532-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24532-70-Y0zuvdTj1s@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24532

--- Comment #1 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Hmm.. this is a hard one.

I can't easily see how 'credit' type accountlines have gotten their 'amounts'
inverted in the first place and as such I'm not entirely confident in switching
the sign on them.

Any thoughts on what we should do here..?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 30 14:12:20 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Jan 2020 13:12:20 +0000
Subject: [Koha-bugs] [Bug 20271] Merge deleted biblio, biblioitems,
 biblio_metadata, and items tables
In-Reply-To: <bug-20271-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20271-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20271-70-lXFIdDZk4S@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271

--- Comment #207 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
(In reply to Marcel de Rooy from comment #206)
> (In reply to Jonathan Druart from comment #205)
> > Additional question: what's the point of biblioitem.deleted_on and
> > biblio_metadata.deleted_on?
> > I think we only need items.deleted_on and biblio.deleted_on
> 
> As long as we have biblioitems, a last change can be helpful. But I agree we
> are actually using biblioitems as an overflow for biblio only. The columns
> could be moved up.

Having a timestamp (last modified), created and deleted is what would be
helpful. We have some sync functionality with our unoin catalog, where the
dates are needed. 

We might want the newest of them to survive, because: depending on the change,
not every of the 3 tables in question is updated and the timestamps might be
out of sync.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 30 14:15:05 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Jan 2020 13:15:05 +0000
Subject: [Koha-bugs] [Bug 24532] Some account types are converted to debits
 when they shouldn't be
In-Reply-To: <bug-24532-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24532-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24532-70-zpDlA9DVm9@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24532

--- Comment #2 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
yikes.. what we certainly should do however is update that second step to
ensure it only catches the weird cases rather than updating all matching codes!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 30 14:40:35 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Jan 2020 13:40:35 +0000
Subject: [Koha-bugs] [Bug 24532] Some account types are converted to debits
 when they shouldn't be
In-Reply-To: <bug-24532-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24532-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24532-70-8ZP9IHaVVC@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24532

Andrew Fuerste-Henry <andrew at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |andrew at bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 30 14:41:13 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Jan 2020 13:41:13 +0000
Subject: [Koha-bugs] [Bug 24545] New: Replace Franklin Street by
 gnu.org/licenses in copyright
Message-ID: <bug-24545-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24545

            Bug ID: 24545
           Summary: Replace Franklin Street by gnu.org/licenses in
                    copyright
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Architecture, internals, and plumbing
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: m.de.rooy at rijksmuseum.nl
        QA Contact: testopia at bugs.koha-community.org

No big deal but inconsistent:

git grep -l "gnu.org/licenses"| wc -l
1156
git grep -l "Franklin Street"| wc -l
471

It seems easier to me to go to gnu.org than writing to Boston ? Even in newer
files sometimes the older copyright is copied.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 30 14:43:47 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Jan 2020 13:43:47 +0000
Subject: [Koha-bugs] [Bug 24544] Add a script for inserting persistent
 identifiers to MARC records
In-Reply-To: <bug-24544-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24544-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24544-70-r9QSTdBH1p@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24544

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org

--- Comment #1 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Could you add Franklin Street into qa tools to stop new ones, Jonathan?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 30 14:44:02 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Jan 2020 13:44:02 +0000
Subject: [Koha-bugs] [Bug 24544] Add a script for inserting persistent
 identifiers to MARC records
In-Reply-To: <bug-24544-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24544-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24544-70-7VSXG0R4of@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24544

--- Comment #2 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
(In reply to Marcel de Rooy from comment #1)
> Could you add Franklin Street into qa tools to stop new ones, Jonathan?

Wrong report, sorry

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 30 14:44:40 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Jan 2020 13:44:40 +0000
Subject: [Koha-bugs] [Bug 24545] Replace Franklin Street by gnu.org/licenses
 in copyright
In-Reply-To: <bug-24545-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24545-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24545-70-94pf7qEgjK@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24545

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org

--- Comment #1 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Could you add Franklin Street into qa tools to stop new ones, Jonathan?

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 30 14:44:56 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Jan 2020 13:44:56 +0000
Subject: [Koha-bugs] [Bug 24544] Add a script for inserting persistent
 identifiers to MARC records
In-Reply-To: <bug-24544-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24544-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24544-70-f7rm9Vbeqj@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24544

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|jonathan.druart at bugs.koha-c |
                   |ommunity.org                |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 30 14:52:33 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Jan 2020 13:52:33 +0000
Subject: [Koha-bugs] [Bug 24543] Wrong test in api/v1/checkouts.t
In-Reply-To: <bug-24543-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24543-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24543-70-sPcQWM6MfI@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24543

Joonas Kylmälä <joonas.kylmala at helsinki.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #98155|0                           |1
        is obsolete|                            |

--- Comment #2 from Joonas Kylmälä <joonas.kylmala at helsinki.fi> ---
Created attachment 98158
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98158&action=edit
Bug 24543: Fix wrong test in api/v1/checkouts.t

In t/db_dependent/api/v1/checkouts.t we define a circulation rule with
renewalperiod=7.
But then the expected due date is today+14 days.
However, at the beginning of the script, the due_date of the issue is today+14
days.

That highlight that the renewal period is not taken into account.

The circulation rule is created with renewalperiod and renewalsallowed,
however GetLoanLength check the existence of issuelength to return the rule.
GetLoanLength finally return the default rule, with renewalperiod=0

Note that this has been found working on bug 18936, code will be cleaned on
that patchset.

Test plan:
 % prove t/db_dependent/api/v1/checkouts.t
must return green before and after this patch

Signed-off-by: Joonas Kylmälä <joonas.kylmala at helsinki.fi>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 30 14:53:31 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Jan 2020 13:53:31 +0000
Subject: [Koha-bugs] [Bug 24543] Wrong test in api/v1/checkouts.t
In-Reply-To: <bug-24543-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24543-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24543-70-SzME8wMenN@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24543

Joonas Kylmälä <joonas.kylmala at helsinki.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 30 14:53:33 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Jan 2020 13:53:33 +0000
Subject: [Koha-bugs] [Bug 24543] Wrong test in api/v1/checkouts.t
In-Reply-To: <bug-24543-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24543-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24543-70-kgvBOOGANN@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24543

Joonas Kylmälä <joonas.kylmala at helsinki.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #98158|0                           |1
        is obsolete|                            |

--- Comment #3 from Joonas Kylmälä <joonas.kylmala at helsinki.fi> ---
Created attachment 98159
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98159&action=edit
Bug 24543: Fix wrong test in api/v1/checkouts.t

In t/db_dependent/api/v1/checkouts.t we define a circulation rule with
renewalperiod=7.
But then the expected due date is today+14 days.
However, at the beginning of the script, the due_date of the issue is today+14
days.

That highlight that the renewal period is not taken into account.

The circulation rule is created with renewalperiod and renewalsallowed,
however GetLoanLength check the existence of issuelength to return the rule.
GetLoanLength finally return the default rule, with renewalperiod=0

Note that this has been found working on bug 18936, code will be cleaned on
that patchset.

Test plan:
 % prove t/db_dependent/api/v1/checkouts.t
must return green before and after this patch

Signed-off-by: Joonas Kylmälä <joonas.kylmala at helsinki.fi>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 30 14:58:28 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Jan 2020 13:58:28 +0000
Subject: [Koha-bugs] [Bug 24431] Convert overpayment on accruing fines into
 credits
In-Reply-To: <bug-24431-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24431-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24431-70-oDya6juSEX@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24431

--- Comment #4 from Andrew Fuerste-Henry <andrew at bywatersolutions.com> ---
Thanks, Martin! This resolves a huge pain point for several of our libraries.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 30 15:00:16 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Jan 2020 14:00:16 +0000
Subject: [Koha-bugs] [Bug 20271] Merge deleted biblio, biblioitems,
 biblio_metadata, and items tables
In-Reply-To: <bug-20271-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20271-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20271-70-JUA7lrhRTk@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271

--- Comment #208 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---

> Having a timestamp (last modified), created and deleted is what would be
> helpful. We have some sync functionality with our unoin catalog, where the
> dates are needed. 
> 
> We might want the newest of them to survive, because: depending on the
> change, not every of the 3 tables in question is updated and the timestamps
> might be out of sync.

In case of you wondering why I am not making sense... I was one step ahead -
merging all the things (which we are not doing here...)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 30 15:18:05 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Jan 2020 14:18:05 +0000
Subject: [Koha-bugs] [Bug 17108] Automatic debian/control updates
 (stable/18.11.x)
In-Reply-To: <bug-17108-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17108-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17108-70-SaOpoxXx5b@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17108

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de

--- Comment #19 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
(In reply to Nightly Build Bot from comment #18)
> Created attachment 95933 [details] [review]
> Bug 17108- Automatic debian/control updates (stable/19.05.x)

It looks like there might be an error in this one?

+Build-Depends: EEEK: unknown package for DBIx::RunSQL,
+ EEEK: unknown package for Search::Elasticsearch,
+ libalgorithm-checkdigits-perl,

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 30 15:37:34 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Jan 2020 14:37:34 +0000
Subject: [Koha-bugs] [Bug 24546] New: Club/Hold.t has a wrong call to
 build_sample_item
Message-ID: <bug-24546-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24546

            Bug ID: 24546
           Summary: Club/Hold.t has a wrong call to build_sample_item
 Change sponsored?: ---
           Product: Koha
           Version: unspecified
          Hardware: All
                OS: All
            Status: NEW
          Severity: minor
          Priority: P5 - low
         Component: Test Suite
          Assignee: chris at bigballofwax.co.nz
          Reporter: jonathan.druart at bugs.koha-community.org
        QA Contact: testopia at bugs.koha-community.org

In t/db_dependent/Koha/Club/Hold.t:
my $item1 = $builder->build_sample_item({ branchcode => $library->branchcode
});
my $item2 = $builder->build_sample_item({ branchcode => $library->branchcode
});

build_sample_item takes either "library" or the item's attributes.
branchcode is not part of the item's table, so what those 2 lines are trying to
acchieve is wrong.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 30 15:38:19 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Jan 2020 14:38:19 +0000
Subject: [Koha-bugs] [Bug 24546] Club/Hold.t has a wrong call to
 build_sample_item
In-Reply-To: <bug-24546-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24546-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24546-70-YPgltmr2ed@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24546

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |19618

--- Comment #1 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Coming from
  commit 474eca3dbcabe40eead066c3221d4984b0b890b4
  Bug 19618: Add tests


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19618
[Bug 19618] Add 'Club Holds' feature
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 30 15:38:19 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Jan 2020 14:38:19 +0000
Subject: [Koha-bugs] [Bug 19618] Add 'Club Holds' feature
In-Reply-To: <bug-19618-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-19618-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-19618-70-DvvHNx5MCA@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19618

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |24546


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24546
[Bug 24546] Club/Hold.t has a wrong call to build_sample_item
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 30 15:39:53 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Jan 2020 14:39:53 +0000
Subject: [Koha-bugs] [Bug 24546] Club/Hold.t has a wrong call to
 build_sample_item
In-Reply-To: <bug-24546-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24546-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24546-70-Yhhnt5PiQw@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24546

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 30 15:39:55 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Jan 2020 14:39:55 +0000
Subject: [Koha-bugs] [Bug 24546] Club/Hold.t has a wrong call to
 build_sample_item
In-Reply-To: <bug-24546-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24546-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24546-70-Hf3qhl4xr8@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24546

--- Comment #2 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 98160
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98160&action=edit
Bug 24546: Fix intentions of build_sample_item in Club/Hold.t

In t/db_dependent/Koha/Club/Hold.t:
my $item1 = $builder->build_sample_item({ branchcode => $library->branchcode
});
my $item2 = $builder->build_sample_item({ branchcode => $library->branchcode
});

build_sample_item takes either "library" or the item's attributes.
branchcode is not part of the item's table, so what those 2 lines are trying to
acchieve is wrong.

Test plan:
 % prove t/db_dependent/Koha/Club/Hold.t
must return green before and after this patch

Note that this patch also remove an uneeded debugging statement.

This has been caught by bug 24363.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 30 15:40:13 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Jan 2020 14:40:13 +0000
Subject: [Koha-bugs] [Bug 24546] Club/Hold.t has a wrong call to
 build_sample_item
In-Reply-To: <bug-24546-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24546-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24546-70-UwwTHGwYEv@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24546

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|chris at bigballofwax.co.nz    |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org
             Blocks|                            |24363


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24363
[Bug 24363] Datepicker calendar is not always sexy
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 30 15:40:13 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Jan 2020 14:40:13 +0000
Subject: [Koha-bugs] [Bug 24363] Datepicker calendar is not always sexy
In-Reply-To: <bug-24363-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24363-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24363-70-R0aWx0qfBx@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24363

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |24546


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24546
[Bug 24546] Club/Hold.t has a wrong call to build_sample_item
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 30 15:40:22 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Jan 2020 14:40:22 +0000
Subject: [Koha-bugs] [Bug 24532] Some account types are converted to debits
 when they shouldn't be
In-Reply-To: <bug-24532-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24532-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24532-70-11KpnHNb0z@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24532

--- Comment #3 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 98161
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98161&action=edit
Bug 24532: Fix original DB update for bug 23049

Pathalogical cases of Payments and Writeoffs being converted to debits
are identified during the DB update for bug 23049, but we are not
correctly limiting to those types accountlines when subsequently
populating the debit_type field.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 30 15:40:25 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Jan 2020 14:40:25 +0000
Subject: [Koha-bugs] [Bug 24532] Some account types are converted to debits
 when they shouldn't be
In-Reply-To: <bug-24532-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24532-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24532-70-azxHYyavJG@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24532

--- Comment #4 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 98162
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98162&action=edit
Bug 24532: Fix misidentified credit_types from bug 23049

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 30 15:40:37 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Jan 2020 14:40:37 +0000
Subject: [Koha-bugs] [Bug 24532] Some account types are converted to debits
 when they shouldn't be
In-Reply-To: <bug-24532-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24532-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24532-70-BiYyQkl26O@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24532

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 30 15:48:56 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Jan 2020 14:48:56 +0000
Subject: [Koha-bugs] [Bug 24532] Some account types are converted to debits
 when they shouldn't be
In-Reply-To: <bug-24532-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24532-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24532-70-vRN4irDGwK@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24532

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |23049


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049
[Bug 23049] Replace MANUAL_INV authorised value with a dedicated table
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 30 15:48:56 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Jan 2020 14:48:56 +0000
Subject: [Koha-bugs] [Bug 23049] Replace MANUAL_INV authorised value with a
 dedicated table
In-Reply-To: <bug-23049-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23049-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23049-70-1DcjWdd2lf@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |24532


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24532
[Bug 24532] Some account types are converted to debits when they shouldn't be
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 30 15:53:43 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Jan 2020 14:53:43 +0000
Subject: [Koha-bugs] [Bug 24543] Wrong test in api/v1/checkouts.t
In-Reply-To: <bug-24543-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24543-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24543-70-elyep4f5ov@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24543

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #98159|0                           |1
        is obsolete|                            |

--- Comment #4 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 98163
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98163&action=edit
Bug 24543: Fix wrong test in api/v1/checkouts.t

In t/db_dependent/api/v1/checkouts.t we define a circulation rule with
renewalperiod=7.
But then the expected due date is today+14 days.
However, at the beginning of the script, the due_date of the issue is today+14
days.

That highlight that the renewal period is not taken into account.

The circulation rule is created with renewalperiod and renewalsallowed,
however GetLoanLength check the existence of issuelength to return the rule.
GetLoanLength finally return the default rule, with renewalperiod=0

Note that this has been found working on bug 18936, code will be cleaned on
that patchset.

Test plan:
 % prove t/db_dependent/api/v1/checkouts.t
must return green before and after this patch

Signed-off-by: Joonas Kylmälä <joonas.kylmala at helsinki.fi>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 30 15:53:57 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Jan 2020 14:53:57 +0000
Subject: [Koha-bugs] [Bug 24543] Wrong test in api/v1/checkouts.t
In-Reply-To: <bug-24543-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24543-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24543-70-3WvkP0ewut@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24543

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA
                 CC|                            |martin.renvoize at ptfs-europe
                   |                            |.com

--- Comment #5 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Good catch, passing QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 30 16:05:09 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Jan 2020 15:05:09 +0000
Subject: [Koha-bugs] [Bug 24377] Record branch in statistics for auto-renewal
In-Reply-To: <bug-24377-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24377-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24377-70-xarjIoPgu0@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24377

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #97441|0                           |1
        is obsolete|                            |

--- Comment #8 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 98167
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98167&action=edit
Bug 24377: Unit test

Signed-off-by: Andrew Fuerste-Henry <andrew at bywatersolutions.com>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 30 16:05:12 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Jan 2020 15:05:12 +0000
Subject: [Koha-bugs] [Bug 24377] Record branch in statistics for auto-renewal
In-Reply-To: <bug-24377-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24377-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24377-70-BPpKK7T4So@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24377

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #97453|0                           |1
        is obsolete|                            |

--- Comment #9 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 98168
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98168&action=edit
Bug 24377: Record passed branch if renewing via cron

To test:
1 - Checkout an item with auto renewal set and eligible for auto renew
2 - Set no renewal before in the circ rules to 99 (something greater than the
checkout period)
3 - perl misc/cronjobs/automatic_renewals.pl
4 - Check the statistics table, note the branch for renewal is null
    SELECT * FROM statistics WHERE itemnumber={itemnumber} AND type='RENEWAL'
5 - Apply patch
6 - Repeat 1-4
7 - Note the branch is set to the issuing branch

Signed-off-by: Andrew Fuerste-Henry <andrew at bywatersolutions.com>
Signed-off-by: Ed Veal <eveal at mckinneytexas.org>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 30 16:05:47 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Jan 2020 15:05:47 +0000
Subject: [Koha-bugs] [Bug 24377] Record branch in statistics for auto-renewal
In-Reply-To: <bug-24377-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24377-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24377-70-yI2XACsC02@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24377

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |martin.renvoize at ptfs-europe
                   |                            |.com
             Status|Signed Off                  |Passed QA

--- Comment #10 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Yikes, that is not a side effect I had imagined.. sorry guys. Thanks for the
quick fix Nick.. passing QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 30 16:06:00 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Jan 2020 15:06:00 +0000
Subject: [Koha-bugs] [Bug 24377] Record branch in statistics for auto-renewal
In-Reply-To: <bug-24377-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24377-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24377-70-fTvPpaUG2a@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24377

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 30 16:06:04 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Jan 2020 15:06:04 +0000
Subject: [Koha-bugs] [Bug 24377] Record branch in statistics for auto-renewal
In-Reply-To: <bug-24377-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24377-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24377-70-EOAFdgmBYx@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24377

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         QA Contact|testopia at bugs.koha-communit |martin.renvoize at ptfs-europe
                   |y.org                       |.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 30 16:10:40 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Jan 2020 15:10:40 +0000
Subject: [Koha-bugs] [Bug 21357] Filter elisions from index and search terms
 in Elasticsearch
In-Reply-To: <bug-21357-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21357-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21357-70-x5z761mpLi@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21357

Julian Maurice <julian.maurice at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |julian.maurice at biblibre.com

--- Comment #32 from Julian Maurice <julian.maurice at biblibre.com> ---
I think that enabling french analyzer (or parts of french analyzer) by default
is not the best solution. Sure it will work with french catalogs, but what will
happen when one want to add support for another language (or, for the weird
people above, 350 other languages! :)) ?

I think a better solution is to use multi-fields with multiple analyzers, as
suggested here :
https://www.elastic.co/guide/en/elasticsearch/reference/current/multi-fields.html#_multi_fields_with_multiple_analyzers

The idea is to have multiple "subfields" for each field, one subfield per
language. For instance:
- `title` will be language agnostic
- `title.lang_en` will use an english analyzer
- `title.lang_fr` will use a french analyzer

When searching, Koha can search in all these fields, and the query will be
analyzed by all analyzers.

I've been testing this idea this week, and I made a small patch that I will
submit here. It is only a proof of concept for now, but I hope it will help

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 30 16:11:13 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Jan 2020 15:11:13 +0000
Subject: [Koha-bugs] [Bug 21357] Filter elisions from index and search terms
 in Elasticsearch
In-Reply-To: <bug-21357-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21357-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21357-70-2q1hOfpjF0@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21357

--- Comment #33 from Julian Maurice <julian.maurice at biblibre.com> ---
Created attachment 98169
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98169&action=edit
Bug 21357: Allow to use multiple ES language analyzers

Test plan:
1. Apply this patch
2. If you have a custom `field_config.yaml` report the diff in your
custom config
3. Create biblios in english and french
4. misc/search_tools/rebuild_elasticsearch.pl
5. Test biblio search at intranet with stemming and ellision in mind

Examples of test queries:
- "journal actualité" => should return results with "Journaux
d'actualités" in it
- "lord lady" => should return results with "Lords and Ladies" in it

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 30 16:11:16 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Jan 2020 15:11:16 +0000
Subject: [Koha-bugs] [Bug 21674] Data integrity not enforced for library
 groups
In-Reply-To: <bug-21674-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21674-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21674-70-z6R0zjBZKT@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21674

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #97837|0                           |1
        is obsolete|                            |

--- Comment #14 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 98170
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98170&action=edit
Bug 21674: DB changes

Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 30 16:11:19 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Jan 2020 15:11:19 +0000
Subject: [Koha-bugs] [Bug 21674] Data integrity not enforced for library
 groups
In-Reply-To: <bug-21674-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21674-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21674-70-kEnw71C0DF@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21674

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #97838|0                           |1
        is obsolete|                            |

--- Comment #15 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 98171
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98171&action=edit
Bug 21674: Prevent to insert twice the same library in a group

When you create hierarchical groups of libraries you are not allowed to add
several times the same library to a given group/subgroup. The libraries
that are part of the group is not displayed on the interface, to prevent
the user to select it.

However this restriction is only done template-side, the controller and
module does not handle it.

To prevent that this patchset enforces the constraint at DB level, and
display a message to the end user.

Test plan:
- Go to Home › Administration › Library groups
- Add a group
- Add a library
- reload the page several times
=> Without this patch the same library appears several times in the group
=> With this patch applied you will see a friendly error message

Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 30 16:11:23 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Jan 2020 15:11:23 +0000
Subject: [Koha-bugs] [Bug 21674] Data integrity not enforced for library
 groups
In-Reply-To: <bug-21674-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21674-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21674-70-75ANg7w2z0@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21674

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #97839|0                           |1
        is obsolete|                            |

--- Comment #16 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 98172
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98172&action=edit
Bug 21674: Remove duplicates from library_groups before adding the uniq
constraint

To avoid to make it fails if duplicates existed prior to this change

Credit for the SQL query goes to Nick, thanks!

Signed-off-by: Nick Clemens <nick at bywatersolutions.com>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 30 16:11:48 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Jan 2020 15:11:48 +0000
Subject: [Koha-bugs] [Bug 21674] Data integrity not enforced for library
 groups
In-Reply-To: <bug-21674-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21674-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21674-70-4wss2L8Ojj@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21674

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |martin.renvoize at ptfs-europe
                   |                            |.com
             Status|Signed Off                  |Passed QA

--- Comment #17 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Nice teamwork guys.. all works as expected.

Passing QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 30 16:12:02 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Jan 2020 15:12:02 +0000
Subject: [Koha-bugs] [Bug 21357] Filter elisions from index and search terms
 in Elasticsearch
In-Reply-To: <bug-21357-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21357-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21357-70-uSdJwG4GjO@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21357

Julian Maurice <julian.maurice at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Needs Signoff

--- Comment #34 from Julian Maurice <julian.maurice at biblibre.com> ---
Changing status to needs signoff to get opinions

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 30 16:17:36 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Jan 2020 15:17:36 +0000
Subject: [Koha-bugs] [Bug 24330] When importing patrons from CSV,
 automatically strip BOM from file if it exists
In-Reply-To: <bug-24330-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24330-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24330-70-t3R2QZP8cb@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24330

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #98156|0                           |1
        is obsolete|                            |

--- Comment #8 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 98173
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98173&action=edit
Bug 24330: When importing patrons from CSV, automatically strip BOM from file
if it exists

We have a partner that exports UTF-8 CSV files, and is experiencing the same
thing as the author of this article:
https://www.freecodecamp.org/news/a-quick-tale-about-feff-the-invisible-character-cd25cd4630e7/

In short, Excel is inserting an invisible UTF-8 character at the start of the
file, so that the column name "cardnumber" is actually named
"\x{feff}cardnumber", causing "cardnumber" to be blank.

A simple solution is provided here:
https://stackoverflow.com/questions/24390034/remove-bom-from-string-with-perl

Test Plan:
1) Download the example.csv file
2) Attempt to import it using the patron import tool
3) Note the invalid column name error
4) Apply this patch, restart all the things!
5) Attempt the import again
6) Assuming you have a branchcode MPL and a cataegory code S, the patron should
import!

Signed-off-by: David Nind <david at davidnind.com>
Signed-off-by: Yew Chung College Library <library at yccece.edu.hk>
Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 30 16:17:39 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Jan 2020 15:17:39 +0000
Subject: [Koha-bugs] [Bug 20271] Merge deleted biblio, biblioitems,
 biblio_metadata, and items tables
In-Reply-To: <bug-20271-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20271-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20271-70-hV4Lk1yUS4@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271

--- Comment #209 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
I have just pushed some follow-ups implementing the last bit we talked about.

I did not test the whole changes as I am waiting for bug 23463 to be integrated
first.

Early tests and reviews would be appreciated however.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 30 16:18:56 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Jan 2020 15:18:56 +0000
Subject: [Koha-bugs] [Bug 24330] When importing patrons from CSV,
 automatically strip BOM from file if it exists
In-Reply-To: <bug-24330-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24330-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24330-70-i2m84YoZkD@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24330

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |martin.renvoize at ptfs-europe
                   |                            |.com
             Status|Signed Off                  |Passed QA

--- Comment #9 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
I've run up against this one a few times myself.. I always wondered if we
should be reading the BOM and doing something with it.. but actually I could
never find any documentation as to 'what' to do.. so.. removing it makes sense
to me.

Passing QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 30 16:24:21 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Jan 2020 15:24:21 +0000
Subject: [Koha-bugs] [Bug 24547] New: Add more action logs for holds
Message-ID: <bug-24547-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24547

            Bug ID: 24547
           Summary: Add more action logs for holds
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Circulation
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: kyle at bywatersolutions.com
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com

It seems like ModReserveFill and ModReserveAffect should both produce action
logs for holds.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 30 16:24:30 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Jan 2020 15:24:30 +0000
Subject: [Koha-bugs] [Bug 24547] Add more action logs for holds
In-Reply-To: <bug-24547-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24547-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24547-70-hBvxNbjXgp@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24547

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |kyle at bywatersolutions.com
                   |ity.org                     |

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 30 16:27:59 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Jan 2020 15:27:59 +0000
Subject: [Koha-bugs] [Bug 22690] Merging records with many items too slow
 (Elasticsearch)
In-Reply-To: <bug-22690-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22690-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22690-70-0vlEKHsB0f@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22690

--- Comment #21 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Comment on attachment 98143
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98143
Bug 22690: Refactor merging of records to improve performance (Elasticsearch)

Review of attachment 98143:
 --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=22690&attachment=98143)
-----------------------------------------------------------------

This looks like a reasonable approach to me and seems to work well.. a
relatively minor point regarding the introduce Koha/Biblio method.

::: Koha/Biblio.pm
@@ +854,5 @@
> +Move items from the given biblio
> +
> +=cut
> +
> +sub move_items_from_biblio {

I feel like 'move_items_from_biblio' isn't immediately obvious as a function
name.. are we moving from 'this' biblio or to it..  perhaps
'adopt_items_from_biblio' is a bit clearer?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 30 16:30:28 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Jan 2020 15:30:28 +0000
Subject: [Koha-bugs] [Bug 24547] Add more action logs for holds
In-Reply-To: <bug-24547-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24547-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24547-70-mm83ZHSrIq@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24547

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 30 16:30:31 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Jan 2020 15:30:31 +0000
Subject: [Koha-bugs] [Bug 24547] Add more action logs for holds
In-Reply-To: <bug-24547-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24547-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24547-70-qD4ffRcqr3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24547

--- Comment #1 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 98174
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98174&action=edit
Bug 24547: Add more action logs for holds

It seems like ModReserveFill and ModReserveAffect should both produce action
logs for holds.

Test Plan:
1) Apply this patch
2) Place a hold
3) Check in the item to trap the hold
4) Check out the item to fill the hold
5) Check the action logs for that reserve id
6) Note the new logs!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 30 16:45:51 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Jan 2020 15:45:51 +0000
Subject: [Koha-bugs] [Bug 21674] Data integrity not enforced for library
 groups
In-Reply-To: <bug-21674-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21674-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21674-70-BwPp3HQTja@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21674

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|                            |20.05.00
        released in|                            |
             Status|Passed QA                   |Pushed to master

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 30 16:45:53 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Jan 2020 15:45:53 +0000
Subject: [Koha-bugs] [Bug 21674] Data integrity not enforced for library
 groups
In-Reply-To: <bug-21674-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21674-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21674-70-iDxGJavRke@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21674

--- Comment #18 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Nice work everyone!

Pushed to master for 20.05

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 30 16:45:55 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Jan 2020 15:45:55 +0000
Subject: [Koha-bugs] [Bug 24330] When importing patrons from CSV,
 automatically strip BOM from file if it exists
In-Reply-To: <bug-24330-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24330-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24330-70-JQbAmpT9Q6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24330

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|                            |20.05.00
        released in|                            |
             Status|Passed QA                   |Pushed to master

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 30 16:45:57 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Jan 2020 15:45:57 +0000
Subject: [Koha-bugs] [Bug 24330] When importing patrons from CSV,
 automatically strip BOM from file if it exists
In-Reply-To: <bug-24330-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24330-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24330-70-TJp4ydVNCe@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24330

--- Comment #10 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Nice work everyone!

Pushed to master for 20.05

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 30 16:45:58 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Jan 2020 15:45:58 +0000
Subject: [Koha-bugs] [Bug 24377] Record branch in statistics for auto-renewal
In-Reply-To: <bug-24377-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24377-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24377-70-WxJVnbQmRW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24377

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|                            |20.05.00
        released in|                            |
             Status|Passed QA                   |Pushed to master

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 30 16:46:00 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Jan 2020 15:46:00 +0000
Subject: [Koha-bugs] [Bug 24377] Record branch in statistics for auto-renewal
In-Reply-To: <bug-24377-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24377-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24377-70-vLDZ74ybU9@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24377

--- Comment #11 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Nice work everyone!

Pushed to master for 20.05

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 30 16:46:06 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Jan 2020 15:46:06 +0000
Subject: [Koha-bugs] [Bug 24543] Wrong test in api/v1/checkouts.t
In-Reply-To: <bug-24543-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24543-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24543-70-npbcbSszQ0@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24543

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|                            |20.05.00
        released in|                            |
             Status|Passed QA                   |Pushed to master

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 30 16:46:08 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Jan 2020 15:46:08 +0000
Subject: [Koha-bugs] [Bug 24543] Wrong test in api/v1/checkouts.t
In-Reply-To: <bug-24543-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24543-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24543-70-NDSn7eLWRM@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24543

--- Comment #6 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Nice work everyone!

Pushed to master for 20.05

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 30 17:05:50 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Jan 2020 16:05:50 +0000
Subject: [Koha-bugs] [Bug 24213] Koha::Object->get_from_storage should
 return undef if the object has been deleted
In-Reply-To: <bug-24213-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24213-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24213-70-R0PV0WByqq@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24213

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #96179|0                           |1
        is obsolete|                            |

--- Comment #3 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 98175
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98175&action=edit
Bug 24213: Add tests

Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 30 17:05:53 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Jan 2020 16:05:53 +0000
Subject: [Koha-bugs] [Bug 24213] Koha::Object->get_from_storage should
 return undef if the object has been deleted
In-Reply-To: <bug-24213-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24213-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24213-70-0msIOHTpeO@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24213

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #96180|0                           |1
        is obsolete|                            |

--- Comment #4 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 98176
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98176&action=edit
Bug 24213: Fix Koha::Object->get_from_storage if the object has been deleted

Without this patch it fails with something like:
  DBIC result _type  isn't of the _type Subscription at t/db_dependent/Biblio.t
line 627.

Test plan:
- Apply the first patch (Add tests)
- Confirm that they fail
- Apply this patch
- Confirm that the tests pass

Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 30 17:06:44 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Jan 2020 16:06:44 +0000
Subject: [Koha-bugs] [Bug 24213] Koha::Object->get_from_storage should
 return undef if the object has been deleted
In-Reply-To: <bug-24213-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24213-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24213-70-yvEvJiGrwF@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24213

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |martin.renvoize at ptfs-europe
                   |                            |.com
             Status|Needs Signoff               |Signed Off

--- Comment #5 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Works as expected and makes sense.. Signing off.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 30 17:11:38 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Jan 2020 16:11:38 +0000
Subject: [Koha-bugs] [Bug 21901] Foreign keys are missing on the serials and
 subscriptions tables
In-Reply-To: <bug-21901-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21901-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21901-70-OYjjSPZlAV@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21901

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #96181|0                           |1
        is obsolete|                            |

--- Comment #2 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 98177
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98177&action=edit
Bug 21901: Add FK on subscription and serial tables

In order to improve performance in the serial modules and add DB constraints,
this patch is going to add missing foreign key on the following columns:
 * serial.biblionumber
 * serial.subscription
 * subscriptionhistory.biblionumber
 * subscriptionhistory.subscriptionid
 * subscription.biblionumber

Once done, some code can be removed from the Del* subroutines, as the ON
CASCASE clause will make the RDBMS handles the deletions.

Test plan:
0/ It would be useful to test the update DB entry on a big and old
production DB, to make sure the constraints will be added correctly.
We could remove the entries before creating the constraints, but it can
be unecessary
1/ Make sure you can recreate a fresh install with the kohastructure.sql
from this patch
2/ Make sure you can upgrade from a master install
3/ Create a subscription, serial, etc. and delete the biblio
=> The subscription/serials should have been deleted from the DB
4/ Create a subscription, serial, etc. and delete the subscription
=> The serials should have been deleted from the DB

Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 30 17:12:15 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Jan 2020 16:12:15 +0000
Subject: [Koha-bugs] [Bug 21901] Foreign keys are missing on the serials and
 subscriptions tables
In-Reply-To: <bug-21901-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21901-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21901-70-OPeUrffWd0@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21901

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |martin.renvoize at ptfs-europe
                   |                            |.com
             Status|Needs Signoff               |Signed Off

--- Comment #3 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
I like seeing foreign keys added.. works as expected.. Signing off.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 30 17:16:22 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Jan 2020 16:16:22 +0000
Subject: [Koha-bugs] [Bug 24389] Claiming an order can display an invalid
 successful message
In-Reply-To: <bug-24389-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24389-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24389-70-Jrfz7GdCG6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24389

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #97126|0                           |1
        is obsolete|                            |

--- Comment #2 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 98178
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98178&action=edit
Bug 24389: Better error handle when claiming late orders

A successful message says that the email has been sent and the order has
been claimed, but nothing happened.

Test plan:
0. Do not apply this patch
1. Create a new vendor, does not create a contact
2. Create some orders, close the basket
3. Go to the late orders page and claims some orders
=> You get a successful message, but the claim has not been done!
4. Apply this patch
5. Claim the orders
=> You get an error
6. Set a contact for the vendor
7. Claim the orders
=> Success

In the docker container, you may need to:
% apt install postfix
% postfix start
Edit /etc/hosts
127.0.0.1       localhost localhost.localdomain

Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 30 17:16:44 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Jan 2020 16:16:44 +0000
Subject: [Koha-bugs] [Bug 24389] Claiming an order can display an invalid
 successful message
In-Reply-To: <bug-24389-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24389-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24389-70-KhRmGPijjo@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24389

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |martin.renvoize at ptfs-europe
                   |                            |.com
             Status|Needs Signoff               |Signed Off

--- Comment #3 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Good improvement, Signing off.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 30 17:31:35 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Jan 2020 16:31:35 +0000
Subject: [Koha-bugs] [Bug 24548] New: Show different status in OPAC for
 items that have holds but have not yet been captured
Message-ID: <bug-24548-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24548

            Bug ID: 24548
           Summary: Show different status in OPAC for items that have
                    holds but have not yet been captured
 Change sponsored?: ---
           Product: Koha
           Version: 19.11
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Hold requests
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: bwsdonna at gmail.com
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com

There are situations where an item has a hold placed on it, but staff have not
yet processed the holds to pull/queue and captured the hold, and another patron
sees that the item is available in the OPAC and expects to be able to take it
off the shelf.  It would be a nice functionality to have the option of showing
that item as "pending hold" or something, so that patrons realize the item is
potentially going to be unavailable soon.

The library request was that as soon as a bib record has a hold placed on it,
the "available" status changes to something else.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 30 17:46:21 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Jan 2020 16:46:21 +0000
Subject: [Koha-bugs] [Bug 24502] Add a query language and param (q=) to the
 API
In-Reply-To: <bug-24502-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24502-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24502-70-iPHmC9ha7t@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24502

--- Comment #5 from Agustín Moyano <agustinmoyano at theke.io> ---
(In reply to Martin Renvoize from comment #2)
> How about taking ES and an example for DSL and Querying structures..
> 
> They allow for a simple syntax in the query string, but if you want to
> 'level up' your queries then they use JSON in a request body.. 
> 
> I like this work so far, but I'm not a big fan of escaped JSON directly in
> the query string, it feels a bit messy and feels like it could end up
> leading to escaping problems down the line.  Moving the JSON based query DSL
> into a GET request body seems like a good move to me.

Hi Martin, agreed, I'll put the q parameter in the body.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 30 17:54:59 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Jan 2020 16:54:59 +0000
Subject: [Koha-bugs] [Bug 24502] Add a query language and param (q=) to the
 API
In-Reply-To: <bug-24502-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24502-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24502-70-mkpm7eG9XW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24502

--- Comment #6 from Agustín Moyano <agustinmoyano at theke.io> ---
(In reply to Martin Renvoize from comment #4)
> Tomas also asked me to mention how I did similar when coding another
> project.. just for possible inspiration...
> 
> 
> I used 'Search::Query::Dialect' and adopted the DBIx::Class dialect with
> some customised additions to get it working.. it leads to a reasonably nice
> functional query string syntax for mostly simple queries.. I don't remember
> getting as far as doing full-on JSON based body queries though.. so I'm not
> sure how helpful it would be here?

Regarding DSL, I didn't find it was illogical the one dbic proposes.. it
certainly has ugly names like "-or" or "-and", but the rest it's quite similar.

Maybe we can discuss it later on a following bug?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 30 18:46:20 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Jan 2020 17:46:20 +0000
Subject: [Koha-bugs] [Bug 23963] Visible reduction in image quality
In-Reply-To: <bug-23963-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23963-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23963-70-J5E3lgVCAF@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23963

Todd Goatley <tgoatley at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |tgoatley at gmail.com

--- Comment #3 from Todd Goatley <tgoatley at gmail.com> ---
Created attachment 98179
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98179&action=edit
Image display issues

Martin and Fridolin, I've recently been contacted by a Koha site on 19.05.06
reporting they're still having issues with images. I have 3 images but could
only attached 1. This Koha site reports:

The top example is from before the upgrade. - clear and crisp
The bottom 2 are from after the upgrade - blurred

Images that come in automatically from online are clean/clear, but many of the
images I add myself. There was no change in the quality of the images, but it
changed with the upgrade.

Thanks! Curious as to what is happening with this...

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 30 18:47:44 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Jan 2020 17:47:44 +0000
Subject: [Koha-bugs] [Bug 23963] Visible reduction in image quality
In-Reply-To: <bug-23963-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23963-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23963-70-7Rq4DPf2ic@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23963

--- Comment #4 from Todd Goatley <tgoatley at gmail.com> ---
Comment on attachment 98179
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98179
Image display issues

The individual reporting this can be reached at generalslibrary at ibethel.org

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 30 18:50:41 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Jan 2020 17:50:41 +0000
Subject: [Koha-bugs] [Bug 9949] Tidy up the intranet set up and fix a
 potential security issue when running from git
In-Reply-To: <bug-9949-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-9949-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9949-70-Eh4r5yODex@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9949

--- Comment #17 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 98180
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98180&action=edit
Bug 9949: Moving intranet scripts into their own dir

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 30 18:50:44 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Jan 2020 17:50:44 +0000
Subject: [Koha-bugs] [Bug 9949] Tidy up the intranet set up and fix a
 potential security issue when running from git
In-Reply-To: <bug-9949-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-9949-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9949-70-cV0h2bQsQG@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9949

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #16994|0                           |1
        is obsolete|                            |

--- Comment #18 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 98181
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98181&action=edit
Bug 9949: Fixing config files up to handle new structure

Now we have moved the files git log will not tell us the full history,
unless we use --follow

git log intranet/mainpage.pl  #only since we moved
git log --follow intranet/mainpage.pl # full history

The same for git blame

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 30 18:50:48 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Jan 2020 17:50:48 +0000
Subject: [Koha-bugs] [Bug 9949] Tidy up the intranet set up and fix a
 potential security issue when running from git
In-Reply-To: <bug-9949-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-9949-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9949-70-dwdvaVgvp8@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9949

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #16995|0                           |1
        is obsolete|                            |

--- Comment #19 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 98182
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98182&action=edit
Bug 9949: Moving the install data out of the intranet dir

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 30 18:50:52 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Jan 2020 17:50:52 +0000
Subject: [Koha-bugs] [Bug 9949] Tidy up the intranet set up and fix a
 potential security issue when running from git
In-Reply-To: <bug-9949-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-9949-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9949-70-3dIH6P6sXN@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9949

--- Comment #20 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 98183
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98183&action=edit
Bug 9949: Continuing tidying up a few missed places

Just the MakeFile.PL to go

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 30 18:50:55 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Jan 2020 17:50:55 +0000
Subject: [Koha-bugs] [Bug 9949] Tidy up the intranet set up and fix a
 potential security issue when running from git
In-Reply-To: <bug-9949-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-9949-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9949-70-KRmouV1hAo@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9949

--- Comment #21 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 98184
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98184&action=edit
Bug 9949: Fix some missed instances of install_data

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 30 18:51:09 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Jan 2020 17:51:09 +0000
Subject: [Koha-bugs] [Bug 9949] Tidy up the intranet set up and fix a
 potential security issue when running from git
In-Reply-To: <bug-9949-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-9949-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9949-70-WNC6YGgEzf@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9949

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |martin.renvoize at ptfs-europe
                   |                            |.com
  Attachment #16993|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 30 18:51:19 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Jan 2020 17:51:19 +0000
Subject: [Koha-bugs] [Bug 9949] Tidy up the intranet set up and fix a
 potential security issue when running from git
In-Reply-To: <bug-9949-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-9949-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9949-70-jVOQBU8QhU@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9949

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #17214|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 30 18:51:34 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Jan 2020 17:51:34 +0000
Subject: [Koha-bugs] [Bug 9949] Tidy up the intranet set up and fix a
 potential security issue when running from git
In-Reply-To: <bug-9949-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-9949-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9949-70-nMpSmIHRq3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9949

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Needs Signoff

--- Comment #22 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Rebased

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 30 18:56:50 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Jan 2020 17:56:50 +0000
Subject: [Koha-bugs] [Bug 24502] Add a query language and param (q=) to the
 API
In-Reply-To: <bug-24502-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24502-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24502-70-GfBK1zQHSR@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24502

--- Comment #7 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
All sounds good to me. 😀

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 30 19:23:23 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Jan 2020 18:23:23 +0000
Subject: [Koha-bugs] [Bug 24347] Add a 'search to order' option similar to
 'search to hold'
In-Reply-To: <bug-24347-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24347-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24347-70-wivghtzRwd@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24347

--- Comment #13 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Could add a public keyword I suppose.. I use those allot to share States with
people.. like the Manual and needs-release-notes.. how about 'new-cookie' ?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 30 19:32:20 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Jan 2020 18:32:20 +0000
Subject: [Koha-bugs] [Bug 24347] Add a 'search to order' option similar to
 'search to hold'
In-Reply-To: <bug-24347-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24347-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24347-70-OI1k8w6yZK@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24347

--- Comment #14 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
(In reply to Martin Renvoize from comment #13)
> Could add a public keyword I suppose.. I use those allot to share States
> with people.. like the Manual and needs-release-notes.. how about
> 'new-cookie' ?

+1

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 30 20:27:18 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Jan 2020 19:27:18 +0000
Subject: [Koha-bugs] [Bug 24502] Add a query language and param (q=) to the
 API
In-Reply-To: <bug-24502-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24502-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24502-70-ExEPBUaUsM@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24502

Agustín Moyano <agustinmoyano at theke.io> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #97934|0                           |1
        is obsolete|                            |

--- Comment #8 from Agustín Moyano <agustinmoyano at theke.io> ---
Created attachment 98185
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98185&action=edit
Bug 24502: object.search also filter by prefetched columns

This patch adds the possibility to object.search helper, to also filter by
prefetched columns.

In order to dynamically add filter parameters, they must be coded as json and
placed in the body of the request, within the q parameter.

The coded json, is in fact dbix syntax.

To test:
1. apply this patch
2. prove t/Koha/REST/Plugin/Query.t t/db_dependent/Koha/REST/Plugin/Objects.t
3. Sign off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 30 20:27:23 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Jan 2020 19:27:23 +0000
Subject: [Koha-bugs] [Bug 24502] Add a query language and param (q=) to the
 API
In-Reply-To: <bug-24502-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24502-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24502-70-31qcXOFXQV@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24502

--- Comment #9 from Agustín Moyano <agustinmoyano at theke.io> ---
Created attachment 98186
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98186&action=edit
Bug 24502: (follow-up) Add default q parameter in api definition

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 30 20:31:05 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Jan 2020 19:31:05 +0000
Subject: [Koha-bugs] [Bug 24502] Add a query language and param (q=) to the
 API
In-Reply-To: <bug-24502-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24502-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24502-70-36jqERPxxU@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24502

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |joonas.kylmala at helsinki.fi,
                   |                            |josef.moravec at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 30 21:24:06 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Jan 2020 20:24:06 +0000
Subject: [Koha-bugs] [Bug 21791] Add payment type on Cash register report
 (cash_register_stats.pl)
In-Reply-To: <bug-21791-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21791-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21791-70-V46cNmS5Eu@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21791

--- Comment #5 from Eric Phetteplace <ephetteplace at cca.edu> ---
Ah OK I will hold off working on this then. For what it's worth, I agree that
the payment type/credit type setup seems redundant, but I'll ask our staff what
they think about it, too.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 30 21:41:39 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Jan 2020 20:41:39 +0000
Subject: [Koha-bugs] [Bug 24347] Add a 'search to order' option similar to
 'search to hold'
In-Reply-To: <bug-24347-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24347-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24347-70-2vaMTy01UO@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24347

--- Comment #15 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Cookie description added!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 30 21:50:02 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Jan 2020 20:50:02 +0000
Subject: [Koha-bugs] [Bug 24549] New: Cookies for last patron link are
 always set - even if showLastPatron is turned off
Message-ID: <bug-24549-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24549

            Bug ID: 24549
           Summary: Cookies for last patron link are always set - even if
                    showLastPatron is turned off
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: minor
          Priority: P5 - low
         Component: Staff Client
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: katrin.fischer at bsz-bw.de
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com

Noticed this while updating the cookie documentation - the cookies relating to
the showLastPatron feature are always set, even if the feature itself is turned
off.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 30 22:19:37 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Jan 2020 21:19:37 +0000
Subject: [Koha-bugs] [Bug 24548] Show different status in OPAC for items
 that have holds but have not yet been captured
In-Reply-To: <bug-24548-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24548-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24548-70-cbFoFz2nIU@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24548

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de

--- Comment #1 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
I think we already have that in a way with OPACShowHoldQueueDetails.

I am not sure if changing from available to 'pending hold' will work for title
level holds when there are multiple items that could fulfill the hold?

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 30 22:19:45 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Jan 2020 21:19:45 +0000
Subject: [Koha-bugs] [Bug 24548] Show different status in OPAC for items
 that have holds but have not yet been captured
In-Reply-To: <bug-24548-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24548-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24548-70-bMs36BkwmL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24548

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Version|19.11                       |master

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 30 22:25:53 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Jan 2020 21:25:53 +0000
Subject: [Koha-bugs] [Bug 24525] Hide SIP payment types from the Point of
 Sale page
In-Reply-To: <bug-24525-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24525-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24525-70-L0cnDjBqt5@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24525

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 30 22:26:05 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Jan 2020 21:26:05 +0000
Subject: [Koha-bugs] [Bug 24525] Hide SIP payment types from the Point of
 Sale page
In-Reply-To: <bug-24525-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24525-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24525-70-5fb44xkzU0@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24525

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #98035|0                           |1
        is obsolete|                            |

--- Comment #2 from David Nind <david at davidnind.com> ---
Created attachment 98187
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98187&action=edit
Bug 24525: Remove SIP payment types from point of sale

This patch removes the SIP payments types from displaying in the select
options on the point of sale payment page.

Test plan:
1) Enable the point of sale feature
   (EnablePointOfSale + UseCashRegisters system preferences)
2) Add a cash register for a library
   (Home > Point of sale > Cash registers > New cash register)
3) Go to to the point of sale page and select the 'Payment type' 
   drop down list - you should see these payment types:
   - Cash
   - Cash via SIP
   - Creditcard via SIP2
   - Visa via SIP2
4) Apply the patch
5) Refresh the point of sale page
6) Now only Cash should be displayed in the drop down list
7) Sign-off the patch!

Signed-off-by: David Nind <david at davidnind.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 30 22:49:03 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Jan 2020 21:49:03 +0000
Subject: [Koha-bugs] [Bug 21357] Filter elisions from index and search terms
 in Elasticsearch
In-Reply-To: <bug-21357-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21357-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21357-70-2rg3zZhz4t@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21357

--- Comment #35 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Hi Julian, does it mean it searches the different representations
simultanously? 
I am still not quite sure about 'French specific'. 

It feels like every catalog containing some French materials would be happy to
have "l'avion" work the way you describe - we would. In my experience most
catalogs contain records in different languages.

I wonder how it would work for English, thinking of words like "can't" or
"doesn't".

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 30 23:07:58 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Jan 2020 22:07:58 +0000
Subject: [Koha-bugs] [Bug 12430] Using QueryAutoTruncate breaks relevance
 ranking
In-Reply-To: <bug-12430-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-12430-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12430-70-bYEP8Ur8z5@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12430

Victor Grousset/tuxayo <victor at tuxayo.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #96167|0                           |1
        is obsolete|                            |

--- Comment #18 from Victor Grousset/tuxayo <victor at tuxayo.net> ---
Created attachment 98188
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98188&action=edit
Bug 12430 - Truncation disables relevance ranking when not using QueryParser

The system preference "QueryWeightFields" is mutually exclusive with
the system preference "QueryAutoTruncate" and the * truncation
modifier, when not using QueryParser.

If you use truncation, relevance won't work anymore. (N.B. Relevance
doesn't work probably when using QueryParser, but for a very different
reason beyond the current scope of this bug.)

This patch adds relevance ranking when using truncation (or basically
when QueryWeightFields is disabled).

_TEST PLAN_

1) Turn on "QueryWeightFields" and set "QueryAutoTruncate" to auto
2) Turn off "UseQueryParser"
3) Do a keyword search in the OPAC
4) Note that the results are ordered by biblionumber ascending

5) Apply patch

6) Do the same keyword search in the OPAC
7) Note that the results are never ordered differently
(presumably in relevance order :P)

If you're a stickler, throw in some warns so that you can see
what CCL query is being sent to Zebra.

Signed-off-by: Victor Grousset/tuxayo <victor at tuxayo.net>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jan 30 23:13:42 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Jan 2020 22:13:42 +0000
Subject: [Koha-bugs] [Bug 12430] Using QueryAutoTruncate breaks relevance
 ranking
In-Reply-To: <bug-12430-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-12430-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12430-70-YsXQKRkC3c@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12430

Victor Grousset/tuxayo <victor at tuxayo.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |victor at tuxayo.net
             Status|Needs Signoff               |Signed Off

--- Comment #19 from Victor Grousset/tuxayo <victor at tuxayo.net> ---
> I've attempted a rebase of the patch.. 
> it's not an area I'm all that familiar with so testing is required.

- test plan passed
- signed off
- fixed test plan: TryQueryParser => UseQueryParser
- clarified test plan: "enable QueryAutoTruncate" =>  "set QueryAutoTruncate to
auto"

As per the uncertainty about regressions, should the ticket status be "In
discussion" ?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 31 00:22:02 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Jan 2020 23:22:02 +0000
Subject: [Koha-bugs] [Bug 23974] hours_between and days_between lack tests
In-Reply-To: <bug-23974-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23974-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23974-70-eTKzRJWLOi@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23974

Joy Nelson <joy at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to master            |Pushed to stable
                 CC|                            |joy at bywatersolutions.com
         Version(s)|20.05.00                    |20.05.00, 19.11.03
        released in|                            |

--- Comment #46 from Joy Nelson <joy at bywatersolutions.com> ---
Pushed to 19.11.x branch for 19.11.03

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 31 00:33:15 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Jan 2020 23:33:15 +0000
Subject: [Koha-bugs] [Bug 24123] bulkmarcimport.pl doesn't support UTF-8
 encoded MARCXML records
In-Reply-To: <bug-24123-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24123-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24123-70-oxivFnE78s@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24123

Joy Nelson <joy at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|20.05.00                    |20.05.00, 19.11.03
        released in|                            |
                 CC|                            |joy at bywatersolutions.com
             Status|Pushed to master            |Pushed to stable

--- Comment #10 from Joy Nelson <joy at bywatersolutions.com> ---
Pushed to 19.11.x branch for 19.11.03

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 31 00:33:38 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Jan 2020 23:33:38 +0000
Subject: [Koha-bugs] [Bug 24313] XSLT errors should show in the logs
In-Reply-To: <bug-24313-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24313-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24313-70-UHKF1Dizgx@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24313

Joy Nelson <joy at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |joy at bywatersolutions.com
         Version(s)|20.05.00                    |20.05.00, 19.11.03
        released in|                            |
             Status|Pushed to master            |Pushed to stable

--- Comment #6 from Joy Nelson <joy at bywatersolutions.com> ---
Pushed to 19.11.x branch for 19.11.03

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 31 00:33:59 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Jan 2020 23:33:59 +0000
Subject: [Koha-bugs] [Bug 24394] Typo when adding a new cash register
In-Reply-To: <bug-24394-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24394-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24394-70-eH4Oys9IxZ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24394

Joy Nelson <joy at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to master            |Pushed to stable
         Version(s)|20.05.00                    |20.05.00, 19.11.03
        released in|                            |
                 CC|                            |joy at bywatersolutions.com

--- Comment #5 from Joy Nelson <joy at bywatersolutions.com> ---
Pushed to 19.11.x branch for 19.11.03

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 31 00:36:08 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Jan 2020 23:36:08 +0000
Subject: [Koha-bugs] [Bug 10352] Cataloguing log search mixing
 itemnumber/bibnumber
In-Reply-To: <bug-10352-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-10352-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10352-70-4mz8SAEKfo@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10352

Joy Nelson <joy at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |joy at bywatersolutions.com
             Status|Pushed to master            |Pushed to stable
         Version(s)|20.05.00                    |20.05.00, 19.11.03
        released in|                            |

--- Comment #33 from Joy Nelson <joy at bywatersolutions.com> ---
Pushed to 19.11.x branch for 19.11.03

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 31 00:41:23 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Jan 2020 23:41:23 +0000
Subject: [Koha-bugs] [Bug 20243] ILS-DI CIDR notation
In-Reply-To: <bug-20243-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20243-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20243-70-wcHrpdBGnd@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20243

David Cook <dcook at prosentient.com.au> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |dcook at prosentient.com.au

--- Comment #2 from David Cook <dcook at prosentient.com.au> ---
Yeah this is definitely a duplicate. Barry, feel free to sign off
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24537 :D

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 31 00:44:40 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Jan 2020 23:44:40 +0000
Subject: [Koha-bugs] [Bug 23068] Add ability for Koha to handle
 X-Forwarded-For headers so REMOTE_ADDR features work behind a proxy
In-Reply-To: <bug-23068-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23068-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23068-70-y1NRsuMuEy@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23068

--- Comment #43 from David Cook <dcook at prosentient.com.au> ---
(In reply to Martin Renvoize from comment #42)
> (In reply to David Cook from comment #39)
> > It's too bad there are no unit tests for Koha::Middleware::RealIP. I ended
> > up writing a very basic one here just to test that it worked for multiple
> > proxies.
> 
> Agreed, but I didn't want to hold up this vital development and we weren't
> at all sure how to write such a test.. as it sounds like you've got the
> foundations for a test written, please submit it upstream ;)

That makes sense. I really am loving this development overall!

I'll do a patch for
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24538 and write a
test for it. It won't be total coverage I suppose, but it should be enough to
test the change.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 31 00:49:32 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Jan 2020 23:49:32 +0000
Subject: [Koha-bugs] [Bug 23533] Reindent patron entry form
 (memberentrygen.tt)
In-Reply-To: <bug-23533-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23533-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23533-70-ijZRGJuKp7@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23533

Lucas Gass <lucas at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 31 00:49:37 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Jan 2020 23:49:37 +0000
Subject: [Koha-bugs] [Bug 23533] Reindent patron entry form
 (memberentrygen.tt)
In-Reply-To: <bug-23533-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23533-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23533-70-SpGrpTIBL4@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23533

Lucas Gass <lucas at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #96170|0                           |1
        is obsolete|                            |

--- Comment #11 from Lucas Gass <lucas at bywatersolutions.com> ---
Created attachment 98189
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98189&action=edit
Bug 23533: Reindent patron entry form (memberentrygen.tt)

This patch re-indents the template for patron entry/editing. It
makes only whitespace changes. It should have no effect on the behavior
of the page.

To test, create or edit a patron.

Test every aspect of the process. At each step the page should work
correctly. Including:

 - Adult patron
 - Child patron
 - Organizational patron
 - Quick patron add
 - Duplicate patron
 - With mandatory fields
 - With 'BorrowerUnwantedField's defined
 - With ExtendedPatronAttributes enabled

Signed-off-by: Lucas Gass <lucas at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 31 00:50:03 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Jan 2020 23:50:03 +0000
Subject: [Koha-bugs] [Bug 23533] Reindent patron entry form
 (memberentrygen.tt)
In-Reply-To: <bug-23533-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23533-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23533-70-YOQZ7ftRik@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23533

Lucas Gass <lucas at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #96172|0                           |1
        is obsolete|                            |

--- Comment #12 from Lucas Gass <lucas at bywatersolutions.com> ---
Created attachment 98190
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98190&action=edit
Bug 23533: (follow-up) Add markup comments

This patch adds comments to the template to highlight the markup
structure.

This patch should have no effect on the interface or functionality.

https://bugs.koha-community.org/show_bug.cgi?id=23533

Signed-off-by: Lucas Gass <lucas at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 31 00:55:24 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Jan 2020 23:55:24 +0000
Subject: [Koha-bugs] [Bug 23377] bulkmarcimport.pl disables syspref caching
In-Reply-To: <bug-23377-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23377-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23377-70-F3KRcUfraj@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23377

Joy Nelson <joy at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |joy at bywatersolutions.com
         Version(s)|20.05.00                    |20.05.00, 19.11.03
        released in|                            |
             Status|Pushed to master            |Pushed to stable

--- Comment #8 from Joy Nelson <joy at bywatersolutions.com> ---
Pushed to 19.11.x branch for 19.11.03

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 31 00:55:36 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Jan 2020 23:55:36 +0000
Subject: [Koha-bugs] [Bug 24200] Borrower_PrevCheckout.t failing randomly
In-Reply-To: <bug-24200-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24200-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24200-70-UXfU9OCIpq@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24200

Joy Nelson <joy at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|20.05.00                    |20.05.00, 19.11.03
        released in|                            |
                 CC|                            |joy at bywatersolutions.com
             Status|Pushed to master            |Pushed to stable

--- Comment #6 from Joy Nelson <joy at bywatersolutions.com> ---
Pushed to 19.11.x branch for 19.11.03

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 31 00:56:25 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Jan 2020 23:56:25 +0000
Subject: [Koha-bugs] [Bug 24396] Suggestions.t is failing with MySQL 8
In-Reply-To: <bug-24396-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24396-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24396-70-rNzjgTq00P@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24396

Joy Nelson <joy at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |joy at bywatersolutions.com
             Status|Pushed to master            |Pushed to stable
         Version(s)|20.05.00                    |20.05.00, 19.11.03
        released in|                            |

--- Comment #5 from Joy Nelson <joy at bywatersolutions.com> ---
Pushed to 19.11.x branch for 19.11.03

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 31 00:56:38 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Jan 2020 23:56:38 +0000
Subject: [Koha-bugs] [Bug 23274] t/db_dependent/XISBN.t fails with
 Elasticsearch
In-Reply-To: <bug-23274-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23274-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23274-70-CI2oggY5LF@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23274

Joy Nelson <joy at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |joy at bywatersolutions.com
         Version(s)|20.05.00                    |20.05.00, 19.11.03
        released in|                            |
             Status|Pushed to master            |Pushed to stable

--- Comment #7 from Joy Nelson <joy at bywatersolutions.com> ---
Pushed to 19.11.x branch for 19.11.03

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 31 00:56:53 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Jan 2020 23:56:53 +0000
Subject: [Koha-bugs] [Bug 24323] Advanced editor - Invalid 008 with helper
 silently fails to save
In-Reply-To: <bug-24323-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24323-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24323-70-HYBjJwKgaQ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24323

Joy Nelson <joy at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|20.05.00                    |20.05.00, 19.11.03
        released in|                            |
                 CC|                            |joy at bywatersolutions.com
             Status|Pushed to master            |Pushed to stable

--- Comment #10 from Joy Nelson <joy at bywatersolutions.com> ---
Pushed to 19.11.x branch for 19.11.03

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 31 00:57:06 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Jan 2020 23:57:06 +0000
Subject: [Koha-bugs] [Bug 24371] OPAC 'Showing only available items/Show all
 items' is double encoded
In-Reply-To: <bug-24371-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24371-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24371-70-SdXynEuaOU@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24371

Joy Nelson <joy at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to master            |Pushed to stable
         Version(s)|20.05.00                    |20.05.00, 19.11.03
        released in|                            |
                 CC|                            |joy at bywatersolutions.com

--- Comment #6 from Joy Nelson <joy at bywatersolutions.com> ---
Pushed to 19.11.x branch for 19.11.03

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 31 00:57:19 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 30 Jan 2020 23:57:19 +0000
Subject: [Koha-bugs] [Bug 14759] Replacement for Text::Unaccent
In-Reply-To: <bug-14759-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-14759-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-14759-70-6i6X3Eerxh@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14759

Joy Nelson <joy at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|20.05.00                    |20.05.00, 19.11.03
        released in|                            |
                 CC|                            |joy at bywatersolutions.com
             Status|Pushed to master            |Pushed to stable

--- Comment #48 from Joy Nelson <joy at bywatersolutions.com> ---
Pushed to 19.11.x branch for 19.11.03

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 31 01:04:56 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 31 Jan 2020 00:04:56 +0000
Subject: [Koha-bugs] [Bug 10879] OverDrive should check for
 OverDriveLibraryID before performing search
In-Reply-To: <bug-10879-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-10879-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10879-70-GsnRuXOqG0@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10879

Lucas Gass <lucas at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 31 01:05:01 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 31 Jan 2020 00:05:01 +0000
Subject: [Koha-bugs] [Bug 10879] OverDrive should check for
 OverDriveLibraryID before performing search
In-Reply-To: <bug-10879-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-10879-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-10879-70-vQu4TCFZrp@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10879

Lucas Gass <lucas at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #95584|0                           |1
        is obsolete|                            |

--- Comment #2 from Lucas Gass <lucas at bywatersolutions.com> ---
Created attachment 98191
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98191&action=edit
Bug 10879: OverDrive should check for OverDriveLibraryID before performing
search

This patch modifies the OPAC search results template to check for three
populated system preferences before performing an OverDrive search:
OverDriveLibraryID, OverDriveClientKey, and OverDriveClientSecret.
Previously OverDriveLibraryID was not checked, but without it the
interface reports an error performing the search.

To test you must have credentials for the OverDrive API as defined
in OverDriveClientKey, OverDriveClientSecret, and OverDriveLibraryID
system preferences.

 - With OverDriveLibraryID defined, the catalog search results page in
   the OPAC should show a link to results in the library's OverDrive
   collection.

 - With no value in the OverDriveLibraryID preference the catalog
   search page should not show any message about an OverDrive
   collection.

Signed-off-by: Lucas Gass <lucas at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 31 01:19:45 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 31 Jan 2020 00:19:45 +0000
Subject: [Koha-bugs] [Bug 15142] Titles facet does not work in UNIMARC
In-Reply-To: <bug-15142-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15142-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15142-70-rMyZi25B7d@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15142

Joy Nelson <joy at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to master            |Pushed to stable
         Version(s)|20.05.00                    |20.05.00, 19.11.03
        released in|                            |
                 CC|                            |joy at bywatersolutions.com

--- Comment #17 from Joy Nelson <joy at bywatersolutions.com> ---
Pushed to 19.11.x branch for 19.11.03

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 31 01:20:00 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 31 Jan 2020 00:20:00 +0000
Subject: [Koha-bugs] [Bug 23934] Item level holds not checked for
 LocalHoldsPriority in Holds Queue
In-Reply-To: <bug-23934-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23934-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23934-70-lASiqsU0x1@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23934

Joy Nelson <joy at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |joy at bywatersolutions.com
         Version(s)|20.05.00                    |20.05.00, 19.11.03
        released in|                            |
             Status|Pushed to master            |Pushed to stable

--- Comment #12 from Joy Nelson <joy at bywatersolutions.com> ---
Pushed to 19.11.x branch for 19.11.03

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 31 01:20:15 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 31 Jan 2020 00:20:15 +0000
Subject: [Koha-bugs] [Bug 17885]
 Koha::SearchEngine::Elasticsearch->reset_elasticsearch_mappings throws
 DBD::mysql Duplicate entry exceptions
In-Reply-To: <bug-17885-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-17885-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-17885-70-2A3GJPDUWh@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17885

Joy Nelson <joy at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to master            |Pushed to stable
                 CC|                            |joy at bywatersolutions.com
         Version(s)|20.05.00                    |20.05.00, 19.11.03
        released in|                            |

--- Comment #18 from Joy Nelson <joy at bywatersolutions.com> ---
Pushed to 19.11.x branch for 19.11.03

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 31 01:20:30 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 31 Jan 2020 00:20:30 +0000
Subject: [Koha-bugs] [Bug 23676] Elasticsearch - 0 is not a valid boolean
 for suppress
In-Reply-To: <bug-23676-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23676-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23676-70-X8caG0bSll@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23676

Joy Nelson <joy at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to master            |Pushed to stable
         Version(s)|20.05.00                    |20.05.00, 19.11.03
        released in|                            |
                 CC|                            |joy at bywatersolutions.com

--- Comment #13 from Joy Nelson <joy at bywatersolutions.com> ---
Pushed to 19.11.x branch for 19.11.03

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 31 01:20:44 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 31 Jan 2020 00:20:44 +0000
Subject: [Koha-bugs] [Bug 22426] Elasticsearch - Index location is missing
 in advanced search
In-Reply-To: <bug-22426-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22426-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22426-70-BH0JpVsQ2P@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22426

Joy Nelson <joy at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to master            |Pushed to stable
                 CC|                            |joy at bywatersolutions.com
         Version(s)|20.05.00                    |20.05.00, 19.11.03
        released in|                            |

--- Comment #18 from Joy Nelson <joy at bywatersolutions.com> ---
Pushed to 19.11.x branch for 19.11.03

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 31 01:26:32 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 31 Jan 2020 00:26:32 +0000
Subject: [Koha-bugs] [Bug 24429] Advanced editor - Add ability to generate
 an export file as cataloger saves
In-Reply-To: <bug-24429-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24429-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24429-70-2phkcmUmlS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24429

Cori Lynn Arnold <carnold at dgiinc.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Failed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 31 01:42:20 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 31 Jan 2020 00:42:20 +0000
Subject: [Koha-bugs] [Bug 24421] Generated authorities are missing subfields
In-Reply-To: <bug-24421-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24421-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24421-70-Lol6iYjaJX@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24421

Joy Nelson <joy at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|20.05.00                    |20.05.00, 19.11.03
        released in|                            |
                 CC|                            |joy at bywatersolutions.com
             Status|Pushed to master            |Pushed to stable

--- Comment #12 from Joy Nelson <joy at bywatersolutions.com> ---
Pushed to 19.11.x branch for 19.11.03

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 31 01:42:37 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 31 Jan 2020 00:42:37 +0000
Subject: [Koha-bugs] [Bug 24423] Broken link to return to record after batch
 item modification
In-Reply-To: <bug-24423-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24423-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24423-70-r5BRZNfEJf@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24423

Joy Nelson <joy at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|20.05.00                    |20.05.00, 19.11.03
        released in|                            |
                 CC|                            |joy at bywatersolutions.com
             Status|Pushed to master            |Pushed to stable

--- Comment #10 from Joy Nelson <joy at bywatersolutions.com> ---
Pushed to 19.11.x branch for 19.11.03

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 31 01:48:31 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 31 Jan 2020 00:48:31 +0000
Subject: [Koha-bugs] [Bug 24484] Add explanatory text to batch patron
 deletion
In-Reply-To: <bug-24484-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24484-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24484-70-Bq1isMZG1H@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24484

Joy Nelson <joy at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |joy at bywatersolutions.com
         Version(s)|20.05.00                    |20.05.00, 19.11.03
        released in|                            |
             Status|Pushed to master            |Pushed to stable

--- Comment #16 from Joy Nelson <joy at bywatersolutions.com> ---
Pushed to 19.11.x branch for 19.11.03

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 31 01:48:42 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 31 Jan 2020 00:48:42 +0000
Subject: [Koha-bugs] [Bug 24377] Record branch in statistics for auto-renewal
In-Reply-To: <bug-24377-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24377-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24377-70-MLD5eV29hu@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24377

Joy Nelson <joy at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|20.05.00                    |20.05.00, 19.11.03
        released in|                            |
                 CC|                            |joy at bywatersolutions.com
             Status|Pushed to master            |Pushed to stable

--- Comment #12 from Joy Nelson <joy at bywatersolutions.com> ---
Pushed to 19.11.x branch for 19.11.03

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 31 01:48:53 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 31 Jan 2020 00:48:53 +0000
Subject: [Koha-bugs] [Bug 23443] Paying off a lost fee will return the item,
 even if it is checked out to a different patron
In-Reply-To: <bug-23443-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23443-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23443-70-XWniBQMZNQ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23443

Joy Nelson <joy at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to master            |Pushed to stable
         Version(s)|20.05.00                    |20.05.00, 19.11.03
        released in|                            |
                 CC|                            |joy at bywatersolutions.com

--- Comment #12 from Joy Nelson <joy at bywatersolutions.com> ---
Pushed to 19.11.x branch for 19.11.03

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 31 01:59:08 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 31 Jan 2020 00:59:08 +0000
Subject: [Koha-bugs] [Bug 24429] Advanced editor - Add ability to generate
 an export file as cataloger saves
In-Reply-To: <bug-24429-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24429-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24429-70-iRt49pf1zh@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24429

Cori Lynn Arnold <carnold at dgiinc.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #97404|1                           |0
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 31 02:39:25 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 31 Jan 2020 01:39:25 +0000
Subject: [Koha-bugs] [Bug 24550] New: Books renewals triggers item loan
 policies to revert to branch renewing item
Message-ID: <bug-24550-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24550

            Bug ID: 24550
           Summary: Books renewals triggers item loan policies to revert
                    to branch renewing item
 Change sponsored?: ---
           Product: Koha
           Version: 19.05
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Circulation
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: rrussell at pacificoaks.edu
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com

Created attachment 98192
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98192&action=edit
Renewal changes item policies

Since the new update, we've noticed issues with our items not following
policies from their home branch, triggering overdue notices, causing issues
with holds, not charging fines, and reverting to the default branch. Not
certain if self renewal is triggering this as well. These were never issues
before.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 31 02:54:01 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 31 Jan 2020 01:54:01 +0000
Subject: [Koha-bugs] [Bug 24551] New: OpacMySummaryHTML broken
Message-ID: <bug-24551-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24551

            Bug ID: 24551
           Summary: OpacMySummaryHTML broken
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: minor
          Priority: P5 - low
         Component: OPAC
          Assignee: oleonard at myacpl.org
          Reporter: arthur.suzuki at biblibre.com
        QA Contact: testopia at bugs.koha-community.org

Created attachment 98193
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98193&action=edit
Screenshot showing html broken

I was trying to use OpacMySummaryHTML to display things upon patrons connection
but the functionality seems broken, at least on 18.11.

the html gets its ending quote escaped and/or removed which make part of the
link have a funny address like :
<a href="test.pl>Yolo!</a></td></tr></tbody></table></form><p><a href="
opac-ics.pl"="">Download as iCal/.ics file</a>

Also it kind of make things look ugly and desired message might not show up for
patrons.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 31 02:56:39 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 31 Jan 2020 01:56:39 +0000
Subject: [Koha-bugs] [Bug 24551] OpacMySummaryHTML broken
In-Reply-To: <bug-24551-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24551-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24551-70-htbK6p2cGd@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24551

--- Comment #1 from Arthur Suzuki <arthur.suzuki at biblibre.com> ---
Forgot to mention that I saw this on the opac-user.pl but the bug also affects
opac-readingrecord.pl

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 31 02:59:22 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 31 Jan 2020 01:59:22 +0000
Subject: [Koha-bugs] [Bug 24551] OpacMySummaryHTML broken
In-Reply-To: <bug-24551-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24551-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24551-70-Qm0wjd08tv@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24551

Arthur Suzuki <arthur.suzuki at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |INVALID

--- Comment #2 from Arthur Suzuki <arthur.suzuki at biblibre.com> ---
My bad, my mistake... sry for that :)
(too late to be working properly I guess?)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 31 03:21:35 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 31 Jan 2020 02:21:35 +0000
Subject: [Koha-bugs] [Bug 23968] OPACMySummaryNote does not work
In-Reply-To: <bug-23968-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23968-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23968-70-lXOoOdrMNk@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23968

Arthur Suzuki <arthur.suzuki at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |arthur.suzuki at biblibre.com

--- Comment #8 from Arthur Suzuki <arthur.suzuki at biblibre.com> ---
The functionality is broken for 18.11 though but patch applies fine :)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 31 04:12:24 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 31 Jan 2020 03:12:24 +0000
Subject: [Koha-bugs] [Bug 24440] Add ->current_holds to
 Koha::Acquisition::Order
In-Reply-To: <bug-24440-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24440-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24440-70-CicQcDxFNj@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24440

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|In Discussion               |Needs Signoff
            Summary|Add ->holds and             |Add ->current_holds to
                   |->holds_count to            |Koha::Acquisition::Order
                   |Koha::Acquisition::Order    |

--- Comment #8 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
During the QA review, it was pointed out that this method was not well
conceived as it needed to replicate the behaviour from parcel.pl and it wasn't
doing that.

I have now reworked it.

Thanks Jonathan for your feedback!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 31 04:12:49 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 31 Jan 2020 03:12:49 +0000
Subject: [Koha-bugs] [Bug 24440] Add ->current_holds to
 Koha::Acquisition::Order
In-Reply-To: <bug-24440-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24440-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24440-70-rNiDKHDQXQ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24440

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |tomascohen at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 31 04:12:52 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 31 Jan 2020 03:12:52 +0000
Subject: [Koha-bugs] [Bug 24440] Add ->current_holds to
 Koha::Acquisition::Order
In-Reply-To: <bug-24440-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24440-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24440-70-T0rk3a0Ckd@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24440

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #97491|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 31 04:12:55 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 31 Jan 2020 03:12:55 +0000
Subject: [Koha-bugs] [Bug 24440] Add ->current_holds to
 Koha::Acquisition::Order
In-Reply-To: <bug-24440-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24440-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24440-70-NUBBoHkmep@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24440

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #97492|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 31 04:33:20 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 31 Jan 2020 03:33:20 +0000
Subject: [Koha-bugs] [Bug 24440] Add ->current_holds to
 Koha::Acquisition::Order
In-Reply-To: <bug-24440-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24440-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24440-70-v9qXhCK4mv@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24440

--- Comment #9 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 98194
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98194&action=edit
Bug 24440: Unit tests

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: David Nind <david at davidnind.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 31 04:33:24 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 31 Jan 2020 03:33:24 +0000
Subject: [Koha-bugs] [Bug 24440] Add ->current_holds to
 Koha::Acquisition::Order
In-Reply-To: <bug-24440-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24440-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24440-70-BgNdThHGYZ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24440

--- Comment #10 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 98195
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98195&action=edit
Bug 24440: Add ->current_holds to Koha::Acquisition::Order

This patch introduces a method to fetch the current holds associated with the
items linked to an order line. It basically implements what's done in
parcel.pl, but fully tested and suitable for using on the API.

To test:
1. Apply this patches
2. Run:
   $ kshell
  k$ prove t/db_dependent/Koha/Acquisition/Order.t
=> SUCCESS: Tests pass!
3. Sign off :-D

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 31 04:33:29 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 31 Jan 2020 03:33:29 +0000
Subject: [Koha-bugs] [Bug 24440] Add ->current_holds to
 Koha::Acquisition::Order
In-Reply-To: <bug-24440-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24440-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24440-70-zqdNR1M9x9@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24440

--- Comment #11 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 98196
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98196&action=edit
Bug 24440: ->biblio tests

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 31 04:57:54 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 31 Jan 2020 03:57:54 +0000
Subject: [Koha-bugs] [Bug 24440] Add ->current_holds to
 Koha::Acquisition::Order
In-Reply-To: <bug-24440-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24440-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24440-70-XF6tk9nR5L@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24440

--- Comment #12 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 98197
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98197&action=edit
Bug 24440: (follow-up) Make related objects prefetchable

This patch creates aliases for the relations used to retrieve the linked
objects from other tables. It makes the accessor names match the used
relation name, for consistency.

This is important for code trying to be smart and guessing what needs to
be prefetched, like the API code.

To test:
1. Run:
   $ kshell
  k$ prove t/db_dependent/Koha/Acquisition/Order.t
=> SUCCESS: Tests pass
2. Apply this patch
3. Repeat (1)
=> SUCCESS: Tests pass! No behaviour change
4. Verify the POD changes make sense
5. Sign off :-D

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 31 05:25:59 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 31 Jan 2020 04:25:59 +0000
Subject: [Koha-bugs] [Bug 24528] Add a syntax for specifying counts on
 x-koha-embed
In-Reply-To: <bug-24528-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24528-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24528-70-JpRnJfYutt@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24528

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |20212


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20212
[Bug 20212] Slowness in Receiving in Acquisitions
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 31 05:25:59 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 31 Jan 2020 04:25:59 +0000
Subject: [Koha-bugs] [Bug 20212] Slowness in Receiving in Acquisitions
In-Reply-To: <bug-20212-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20212-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20212-70-AN63e5t3WQ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20212

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |24528


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24528
[Bug 24528] Add a syntax for specifying counts on x-koha-embed
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 31 05:26:47 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 31 Jan 2020 04:26:47 +0000
Subject: [Koha-bugs] [Bug 24467] *_count methods should be avoided
In-Reply-To: <bug-24467-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24467-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24467-70-459O6Nkszj@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24467

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|20212                       |
             Blocks|                            |20212


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20212
[Bug 20212] Slowness in Receiving in Acquisitions
-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 31 05:26:47 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 31 Jan 2020 04:26:47 +0000
Subject: [Koha-bugs] [Bug 20212] Slowness in Receiving in Acquisitions
In-Reply-To: <bug-20212-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20212-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20212-70-g8oylsVt4y@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20212

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|24467                       |
         Depends on|                            |24467


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24467
[Bug 24467] *_count methods should be avoided
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 31 05:46:45 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 31 Jan 2020 04:46:45 +0000
Subject: [Koha-bugs] [Bug 24467] *_count methods should be avoided
In-Reply-To: <bug-24467-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24467-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24467-70-rPK9uf1azK@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24467

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #97746|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 31 05:46:57 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 31 Jan 2020 04:46:57 +0000
Subject: [Koha-bugs] [Bug 24467] *_count methods should be avoided
In-Reply-To: <bug-24467-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24467-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24467-70-ADjiZ9fUTD@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24467

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
           Assignee|koha-bugs at lists.koha-commun |tomascohen at gmail.com
                   |ity.org                     |

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 31 05:48:45 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 31 Jan 2020 04:48:45 +0000
Subject: [Koha-bugs] [Bug 24467] *_count methods should be avoided
In-Reply-To: <bug-24467-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24467-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24467-70-wG5NSr8xBC@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24467

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff
   Patch complexity|---                         |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 31 05:49:04 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 31 Jan 2020 04:49:04 +0000
Subject: [Koha-bugs] [Bug 24467] *_count methods should be avoided
In-Reply-To: <bug-24467-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24467-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24467-70-jCgZsK8gjT@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24467

--- Comment #5 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 98198
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98198&action=edit
Bug 24467: Remove _count methods introduced for API use

This patch removes some methods that were introduced for API usage in
the first iteration of the object embedding development effort.

Those methods were obsoleted by bug 24528, which introduces a smarter
way for Koha::Object->to_api to embed *_count attributes on the output
structure based on the relationships and a call to ->count.

To test:
1. Apply this patch
2. Run:
   $ kshell
  k$ prove t/db_dependent/Koha/Biblio.t
=> SUCCESS: Tests pass
3. Sign off :-D

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 31 05:50:08 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 31 Jan 2020 04:50:08 +0000
Subject: [Koha-bugs] [Bug 24440] Add ->current_holds to
 Koha::Acquisition::Order
In-Reply-To: <bug-24440-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24440-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24440-70-jgWgtSEGbh@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24440

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|24467                       |


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24467
[Bug 24467] *_count methods should be avoided
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 31 05:50:08 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 31 Jan 2020 04:50:08 +0000
Subject: [Koha-bugs] [Bug 24467] *_count methods should be avoided
In-Reply-To: <bug-24467-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24467-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24467-70-DSgHGtJCES@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24467

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|24440                       |


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24440
[Bug 24440] Add ->current_holds to Koha::Acquisition::Order
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 31 07:36:48 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 31 Jan 2020 06:36:48 +0000
Subject: [Koha-bugs] [Bug 24528] Add a syntax for specifying counts on
 x-koha-embed
In-Reply-To: <bug-24528-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24528-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24528-70-MwGwyYuQ7S@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24528

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 31 07:36:52 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 31 Jan 2020 06:36:52 +0000
Subject: [Koha-bugs] [Bug 24528] Add a syntax for specifying counts on
 x-koha-embed
In-Reply-To: <bug-24528-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24528-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24528-70-MDvOgIC2h7@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24528

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #98046|0                           |1
        is obsolete|                            |

--- Comment #6 from David Nind <david at davidnind.com> ---
Created attachment 98199
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98199&action=edit
Bug 24528: Unit tests for Koha::Object->to_api

This patch introduces unit tests for the new to_api bejaviour for
*_count methods.

To test:
1. Apply this patch
2. Run:
   $ kshell
  k$ prove t/db_dependent/Koha/Object.t
=> FAIL: Tests fail because the feature is not implemented

Signed-off-by: David Nind <david at davidnind.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 31 07:36:55 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 31 Jan 2020 06:36:55 +0000
Subject: [Koha-bugs] [Bug 24528] Add a syntax for specifying counts on
 x-koha-embed
In-Reply-To: <bug-24528-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24528-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24528-70-3kxRB7A5U5@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24528

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #98047|0                           |1
        is obsolete|                            |

--- Comment #7 from David Nind <david at davidnind.com> ---
Created attachment 98200
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98200&action=edit
Bug 24528: Add *_count support to to_api

This patch adds a way to tell to_api an attribute needs to be calculated
as the count on an existing method/relationship result. For example, if
we wanted to include the holds_count attribute for a Koha::Patron
object, we would call it:

    $ patron_json = $patron->to_api({ embed => { holds_count => { is_count => 1
} } });

This way to_api will internally call

    $json->{holds_count} = $self->holds->count;

To test:
1. Apply the tests patch
2. Run:
   $ kshell
  k$ prove t/db_dependent/Koha/Object.t
=> FAIL: Tests fail!
3. Apply this patch
4. Repeat (2)
=> SUCCESS: Tests pass!
5. Sign off :-D

Signed-off-by: David Nind <david at davidnind.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 31 07:36:59 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 31 Jan 2020 06:36:59 +0000
Subject: [Koha-bugs] [Bug 24528] Add a syntax for specifying counts on
 x-koha-embed
In-Reply-To: <bug-24528-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24528-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24528-70-yHrYXNbhzk@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24528

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #98065|0                           |1
        is obsolete|                            |

--- Comment #8 from David Nind <david at davidnind.com> ---
Created attachment 98201
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98201&action=edit
Bug 24528: Add a syntax to x-koha-embed to specify counts

This patch adds a + syntax to specify on the x-koha-embed header that we
want the count of a relation in the response. For example:

GET /patrons/1
x-koha-embed: checkouts+count

Would return a JSON representation of a Koha::Patron, with a new
attribute added: checkouts_count, which will be the result of calling
$patron->checkouts->count.

This is all done automatically in to_api. This patch makes parsing the
x-koha-embed header build the right structure for passing to the to_api
method.

To test:
1. Apply this patch
2. Run:
   $ kshell
  k$ prove t/Koha/REST/Plugin/Query.t
=> SUCCESS: Tests pass!
3. Sign off :-D

Sponsored-by: ByWater Solutions

Signed-off-by: David Nind <david at davidnind.com>

Signed-off-by: David Nind <david at davidnind.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 31 07:38:39 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 31 Jan 2020 06:38:39 +0000
Subject: [Koha-bugs] [Bug 24213] Koha::Object->get_from_storage should
 return undef if the object has been deleted
In-Reply-To: <bug-24213-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24213-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24213-70-QF4WY0v77R@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24213

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |m.de.rooy at rijksmuseum.nl
             Status|Signed Off                  |BLOCKED

--- Comment #6 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
QAing

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 31 07:40:02 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 31 Jan 2020 06:40:02 +0000
Subject: [Koha-bugs] [Bug 23924] Add a parameter to the script
 add_date_fields_to_marc_records.pl to specify a date field
In-Reply-To: <bug-23924-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23924-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23924-70-EyvzeATNtl@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23924

Hugo Agud <hagud at orex.es> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Failed QA

--- Comment #5 from Hugo Agud <hagud at orex.es> ---
when processing more than one record, the firts records creates propertly 905
field, but the second one doubles de 905 field with the info from record 1 and
record 3

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 31 07:40:52 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 31 Jan 2020 06:40:52 +0000
Subject: [Koha-bugs] [Bug 24213] Koha::Object->get_from_storage should
 return undef if the object has been deleted
In-Reply-To: <bug-24213-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24213-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24213-70-lo68OK3c4B@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24213

--- Comment #7 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
    # Subtest: Bad value tests
        1..3
        # No tests run!
    not ok 16 - No tests run for subtest "Bad value tests"
    #   Failed test 'No tests run for subtest "Bad value tests"'
    #   at t/db_dependent/Koha/Object.t line 685.
    # Looks like you failed 1 test of 16.
not ok 16 - store() tests
#   Failed test 'store() tests'
#   at t/db_dependent/Koha/Object.t line 688.

Stumbling across this fail, but also without your patch.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 31 07:42:11 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 31 Jan 2020 06:42:11 +0000
Subject: [Koha-bugs] [Bug 24467] *_count methods should be avoided
In-Reply-To: <bug-24467-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24467-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24467-70-ekUg9sgR0S@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24467

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 31 07:42:14 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 31 Jan 2020 06:42:14 +0000
Subject: [Koha-bugs] [Bug 24467] *_count methods should be avoided
In-Reply-To: <bug-24467-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24467-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24467-70-MCYsL7WdxU@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24467

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #98198|0                           |1
        is obsolete|                            |

--- Comment #6 from David Nind <david at davidnind.com> ---
Created attachment 98202
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98202&action=edit
Bug 24467: Remove _count methods introduced for API use

This patch removes some methods that were introduced for API usage in
the first iteration of the object embedding development effort.

Those methods were obsoleted by bug 24528, which introduces a smarter
way for Koha::Object->to_api to embed *_count attributes on the output
structure based on the relationships and a call to ->count.

To test:
1. Apply this patch
2. Run:
   $ kshell
  k$ prove t/db_dependent/Koha/Biblio.t
=> SUCCESS: Tests pass
3. Sign off :-D

Signed-off-by: David Nind <david at davidnind.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 31 07:43:43 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 31 Jan 2020 06:43:43 +0000
Subject: [Koha-bugs] [Bug 24213] Koha::Object->get_from_storage should
 return undef if the object has been deleted
In-Reply-To: <bug-24213-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24213-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24213-70-Q12KR8E8F6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24213

--- Comment #8 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
(In reply to Marcel de Rooy from comment #7)
>     # Subtest: Bad value tests
>         1..3
>         # No tests run!
>     not ok 16 - No tests run for subtest "Bad value tests"
>     #   Failed test 'No tests run for subtest "Bad value tests"'
>     #   at t/db_dependent/Koha/Object.t line 685.
>     # Looks like you failed 1 test of 16.
> not ok 16 - store() tests
> #   Failed test 'store() tests'
> #   at t/db_dependent/Koha/Object.t line 688.
> 
> Stumbling across this fail, but also without your patch.

Can be ignored. Resolved with strict_sql_mode. Maybe an idea to put this key in
the default koha-conf.xml (commented or zero)?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 31 07:46:04 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 31 Jan 2020 06:46:04 +0000
Subject: [Koha-bugs] [Bug 22690] Merging records with many items too slow
 (Elasticsearch)
In-Reply-To: <bug-22690-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22690-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22690-70-FFoYUfgmIP@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22690

--- Comment #22 from Joonas Kylmälä <joonas.kylmala at helsinki.fi> ---
(In reply to Martin Renvoize from comment #21)
> Comment on attachment 98143 [details] [review]
> Bug 22690: Refactor merging of records to improve performance (Elasticsearch)
> 
> Review of attachment 98143 [details] [review]:
> -----------------------------------------------------------------
> 
> This looks like a reasonable approach to me and seems to work well.. a
> relatively minor point regarding the introduce Koha/Biblio method.
> 
> ::: Koha/Biblio.pm
> @@ +854,5 @@
> > +Move items from the given biblio
> > +
> > +=cut
> > +
> > +sub move_items_from_biblio {
> 
> I feel like 'move_items_from_biblio' isn't immediately obvious as a function
> name.. are we moving from 'this' biblio or to it..  perhaps
> 'adopt_items_from_biblio' is a bit clearer?

I would just reverse the original idea: move_items_to_biblio. Then it should be
obvious we are talking about the current object's items being moved. Not sure
if perl OO style supports overloading, but in that case it could be just
move_items, and the parameters defined whether we move them to another biblio
or (yet to be included to Koha) to a holdings record.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 31 07:46:18 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 31 Jan 2020 06:46:18 +0000
Subject: [Koha-bugs] [Bug 24213] Koha::Object->get_from_storage should
 return undef if the object has been deleted
In-Reply-To: <bug-24213-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24213-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24213-70-fNxJPHFKC8@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24213

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|BLOCKED                     |Passed QA
   Patch complexity|---                         |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 31 07:46:21 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 31 Jan 2020 06:46:21 +0000
Subject: [Koha-bugs] [Bug 24213] Koha::Object->get_from_storage should
 return undef if the object has been deleted
In-Reply-To: <bug-24213-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24213-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24213-70-Zv3vs2cvoX@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24213

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #98175|0                           |1
        is obsolete|                            |

--- Comment #9 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 98203
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98203&action=edit
Bug 24213: Add tests

Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 31 07:46:26 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 31 Jan 2020 06:46:26 +0000
Subject: [Koha-bugs] [Bug 24213] Koha::Object->get_from_storage should
 return undef if the object has been deleted
In-Reply-To: <bug-24213-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24213-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24213-70-3KdkO6cAqy@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24213

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #98176|0                           |1
        is obsolete|                            |

--- Comment #10 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 98204
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98204&action=edit
Bug 24213: Fix Koha::Object->get_from_storage if the object has been deleted

Without this patch it fails with something like:
  DBIC result _type  isn't of the _type Subscription at t/db_dependent/Biblio.t
line 627.

Test plan:
- Apply the first patch (Add tests)
- Confirm that they fail
- Apply this patch
- Confirm that the tests pass

Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 31 07:46:40 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 31 Jan 2020 06:46:40 +0000
Subject: [Koha-bugs] [Bug 24213] Koha::Object->get_from_storage should
 return undef if the object has been deleted
In-Reply-To: <bug-24213-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24213-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24213-70-HCbnmqgaS3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24213

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl
                   |y.org                       |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 31 07:50:16 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 31 Jan 2020 06:50:16 +0000
Subject: [Koha-bugs] [Bug 21901] Foreign keys are missing on the serials and
 subscriptions tables
In-Reply-To: <bug-21901-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21901-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21901-70-Ub1y6KYgMI@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21901

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |BLOCKED
         QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl
                   |y.org                       |
                 CC|                            |m.de.rooy at rijksmuseum.nl

--- Comment #4 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
QAing

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 31 07:55:52 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 31 Jan 2020 06:55:52 +0000
Subject: [Koha-bugs] [Bug 24356] objects.search prefetch
In-Reply-To: <bug-24356-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24356-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24356-70-LtLjRA74ke@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24356

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |david at davidnind.com
             Status|Needs Signoff               |Failed QA

--- Comment #11 from David Nind <david at davidnind.com> ---
Tests fail:

prove t/db_dependent/Koha/Object*

t/db_dependent/Koha/Objects.t .. 18/21 
    #   Failed test 'Relationship matching method name is listed'
    #   at t/db_dependent/Koha/Objects.t line 800.

    #   Failed test 'Guessed the object class correctly'
    #   at t/db_dependent/Koha/Objects.t line 804.
    #          got: undef
    #     expected: 'Koha::Acquisition::BasketGroup'
    # Looks like you failed 2 tests of 2.

#   Failed test 'prefetch_whitelist() tests'
#   at t/db_dependent/Koha/Objects.t line 809.
# Looks like you failed 1 test of 21.
t/db_dependent/Koha/Objects.t .. Dubious, test returned 1 (wstat 256, 0x100)
Failed 1/21 subtests 
t/db_dependent/Koha/Object.t ... 17/18 
    #   Failed test 'Relationship matching method name is listed'
    #   at t/db_dependent/Koha/Object.t line 754.

    #   Failed test 'Guessed the object class correctly'
    #   at t/db_dependent/Koha/Object.t line 758.
    #          got: undef
    #     expected: 'Koha::Acquisition::BasketGroup'
    # Looks like you failed 2 tests of 2.

#   Failed test 'prefetch_whitelist() tests'
#   at t/db_dependent/Koha/Object.t line 763.
# Looks like you failed 1 test of 18.
t/db_dependent/Koha/Object.t ... Dubious, test returned 1 (wstat 256, 0x100)
Failed 1/18 subtests 

Test Summary Report
-------------------
t/db_dependent/Koha/Objects.t (Wstat: 256 Tests: 21 Failed: 1)
  Failed test:  21
  Non-zero exit status: 1
t/db_dependent/Koha/Object.t (Wstat: 256 Tests: 18 Failed: 1)
  Failed test:  18
  Non-zero exit status: 1
Files=2, Tests=39, 22 wallclock secs ( 0.05 usr  0.01 sys + 17.92 cusr  3.05
csys = 21.03 CPU)
Result: FAIL

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 31 07:56:26 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 31 Jan 2020 06:56:26 +0000
Subject: [Koha-bugs] [Bug 21901] Foreign keys are missing on the serials and
 subscriptions tables
In-Reply-To: <bug-21901-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21901-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21901-70-UZtXtbXSOL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21901

--- Comment #5 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
(In reply to Jonathan Druart from comment #1)
> 0/ It would be useful to test the update DB entry on a big and old
> production DB, to make sure the constraints will be added correctly.
> We could remove the entries before creating the constraints, but it can
> be unecessary

Since it is theoretically possible that a delete was not completely executed
somehow leaving some bad keys in the table, it would be useful to remove the
entries and not assume they are not. Cannot be verified by one or two tests.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 31 07:59:28 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 31 Jan 2020 06:59:28 +0000
Subject: [Koha-bugs] [Bug 22690] Merging records with many items too slow
 (Elasticsearch)
In-Reply-To: <bug-22690-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22690-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22690-70-TbxUjZ8UUk@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22690

--- Comment #23 from Joonas Kylmälä <joonas.kylmala at helsinki.fi> ---
(In reply to Joonas Kylmälä from comment #22)
> I would just reverse the original idea: move_items_to_biblio. Then it should
> be obvious we are talking about the current object's items being moved. Not
> sure if perl OO style supports overloading, but in that case it could be
> just move_items, and the parameters defined whether we move them to another
> biblio or (yet to be included to Koha) to a holdings record.

Or we could do this even in the Item and Items objects for maximum code
reusability, like $biblio->items->move_to_biblio?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 31 08:00:13 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 31 Jan 2020 07:00:13 +0000
Subject: [Koha-bugs] [Bug 21901] Foreign keys are missing on the serials and
 subscriptions tables
In-Reply-To: <bug-21901-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21901-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21901-70-VuYmKIv2Dk@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21901

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|BLOCKED                     |Failed QA

--- Comment #6 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Inclined to think that could be a blocker. We dont want large installs fail on
this step.
Feel free to change the status again, well argumented ;)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 31 08:01:30 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 31 Jan 2020 07:01:30 +0000
Subject: [Koha-bugs] [Bug 24528] Add a syntax for specifying counts on
 x-koha-embed
In-Reply-To: <bug-24528-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24528-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24528-70-zdHujRBA7O@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24528

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |BLOCKED

--- Comment #9 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
QAing

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 31 08:05:25 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 31 Jan 2020 07:05:25 +0000
Subject: [Koha-bugs] [Bug 24440] Add ->current_holds to
 Koha::Acquisition::Order
In-Reply-To: <bug-24440-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24440-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24440-70-FoQOf2JRYI@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24440

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 31 08:05:29 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 31 Jan 2020 07:05:29 +0000
Subject: [Koha-bugs] [Bug 24440] Add ->current_holds to
 Koha::Acquisition::Order
In-Reply-To: <bug-24440-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24440-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24440-70-dg7k5kh5jl@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24440

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #98194|0                           |1
        is obsolete|                            |

--- Comment #13 from David Nind <david at davidnind.com> ---
Created attachment 98205
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98205&action=edit
Bug 24440: Unit tests

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: David Nind <david at davidnind.com>

Signed-off-by: David Nind <david at davidnind.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 31 08:05:33 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 31 Jan 2020 07:05:33 +0000
Subject: [Koha-bugs] [Bug 24440] Add ->current_holds to
 Koha::Acquisition::Order
In-Reply-To: <bug-24440-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24440-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24440-70-0U2lDBKEA5@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24440

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #98195|0                           |1
        is obsolete|                            |

--- Comment #14 from David Nind <david at davidnind.com> ---
Created attachment 98206
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98206&action=edit
Bug 24440: Add ->current_holds to Koha::Acquisition::Order

This patch introduces a method to fetch the current holds associated with the
items linked to an order line. It basically implements what's done in
parcel.pl, but fully tested and suitable for using on the API.

To test:
1. Apply this patches
2. Run:
   $ kshell
  k$ prove t/db_dependent/Koha/Acquisition/Order.t
=> SUCCESS: Tests pass!
3. Sign off :-D

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

Signed-off-by: David Nind <david at davidnind.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 31 08:05:36 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 31 Jan 2020 07:05:36 +0000
Subject: [Koha-bugs] [Bug 24440] Add ->current_holds to
 Koha::Acquisition::Order
In-Reply-To: <bug-24440-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24440-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24440-70-fUVmKpha3u@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24440

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #98196|0                           |1
        is obsolete|                            |

--- Comment #15 from David Nind <david at davidnind.com> ---
Created attachment 98207
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98207&action=edit
Bug 24440: ->biblio tests

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

Signed-off-by: David Nind <david at davidnind.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 31 08:05:40 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 31 Jan 2020 07:05:40 +0000
Subject: [Koha-bugs] [Bug 24440] Add ->current_holds to
 Koha::Acquisition::Order
In-Reply-To: <bug-24440-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24440-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24440-70-8V7MagaKoK@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24440

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #98197|0                           |1
        is obsolete|                            |

--- Comment #16 from David Nind <david at davidnind.com> ---
Created attachment 98208
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98208&action=edit
Bug 24440: (follow-up) Make related objects prefetchable

This patch creates aliases for the relations used to retrieve the linked
objects from other tables. It makes the accessor names match the used
relation name, for consistency.

This is important for code trying to be smart and guessing what needs to
be prefetched, like the API code.

To test:
1. Run:
   $ kshell
  k$ prove t/db_dependent/Koha/Acquisition/Order.t
=> SUCCESS: Tests pass
2. Apply this patch
3. Repeat (1)
=> SUCCESS: Tests pass! No behaviour change
4. Verify the POD changes make sense
5. Sign off :-D

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

Signed-off-by: David Nind <david at davidnind.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 31 08:10:57 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 31 Jan 2020 07:10:57 +0000
Subject: [Koha-bugs] [Bug 22690] Merging records with many items too slow
 (Elasticsearch)
In-Reply-To: <bug-22690-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22690-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22690-70-r5i1sSiB3F@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22690

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de

--- Comment #24 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---

> Or we could do this even in the Item and Items objects for maximum code
> reusability, like $biblio->items->move_to_biblio?

Maybe just move in this case? They can't go anywhere else than another biblio.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 31 08:13:44 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 31 Jan 2020 07:13:44 +0000
Subject: [Koha-bugs] [Bug 21357] Filter elisions from index and search terms
 in Elasticsearch
In-Reply-To: <bug-21357-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21357-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21357-70-cELj4Z29WA@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21357

--- Comment #36 from Ere Maijala <ere.maijala at helsinki.fi> ---
I can't really see the benefit since, as far as I can see, elision handling is
not prone to cause conflicts with other language analysis. Separating analysis
for different languages also won't work for mixed-language fields. Think about
names and a (very fictional) example phrase "Images from movie l'Avion". You'd
get either elision filtering or English stemming but not both. For sure it will
still be found with a simple keyword search, but it breaks at least adjacent
word searches and relevance ranking.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 31 08:14:28 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 31 Jan 2020 07:14:28 +0000
Subject: [Koha-bugs] [Bug 22690] Merging records with many items too slow
 (Elasticsearch)
In-Reply-To: <bug-22690-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22690-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22690-70-IllMr5tV4i@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22690

--- Comment #25 from Joonas Kylmälä <joonas.kylmala at helsinki.fi> ---
(In reply to Katrin Fischer from comment #24)
> > Or we could do this even in the Item and Items objects for maximum code
> > reusability, like $biblio->items->move_to_biblio?
> 
> Maybe just move in this case? They can't go anywhere else than another
> biblio.

This bug is a dependency for Bug 20447 which introduces holdings records so
similar moving of items to another holdings record is needed there in addition
to moving to another biblio.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 31 08:22:44 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 31 Jan 2020 07:22:44 +0000
Subject: [Koha-bugs] [Bug 24523] Fix opac-password-recovery markup mistake
In-Reply-To: <bug-24523-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24523-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24523-70-zqKia5NSiK@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24523

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA
   Patch complexity|---                         |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 31 08:22:47 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 31 Jan 2020 07:22:47 +0000
Subject: [Koha-bugs] [Bug 24523] Fix opac-password-recovery markup mistake
In-Reply-To: <bug-24523-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24523-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24523-70-gT6ryjriGI@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24523

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #98008|0                           |1
        is obsolete|                            |

--- Comment #4 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 98209
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98209&action=edit
Bug 24523: add missing </p>

Signed-off-by: David Roberts <david.roberts at ptfs-europe.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

https://bugs.koha-community.org/show_bug.cgi?id=24532

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 31 08:23:52 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 31 Jan 2020 07:23:52 +0000
Subject: [Koha-bugs] [Bug 22690] Merging records with many items too slow
 (Elasticsearch)
In-Reply-To: <bug-22690-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22690-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22690-70-jTcILA7wQ4@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22690

--- Comment #26 from Ere Maijala <ere.maijala at helsinki.fi> ---
I'll rename the method as Martin suggested. Any other changes will cause
complications with bug 20447 where we need to move holdings too (so that would
become adopt_holdings_and_items_from_biblio). They can't really be separated
since they depend on each other.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 31 08:25:38 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 31 Jan 2020 07:25:38 +0000
Subject: [Koha-bugs] [Bug 24502] Add a query language and param (q=) to the
 API
In-Reply-To: <bug-24502-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24502-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24502-70-6mYUqVKyek@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24502

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |david at davidnind.com

--- Comment #10 from David Nind <david at davidnind.com> ---
I get this message when trying to apply this patch (git bz apply 24502):

 Failed to retrieve bug information: NotPermitted

Other bugs apply fine.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 31 08:43:18 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 31 Jan 2020 07:43:18 +0000
Subject: [Koha-bugs] [Bug 22690] Merging records with many items too slow
 (Elasticsearch)
In-Reply-To: <bug-22690-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22690-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22690-70-gnQDUWAKFp@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22690

Ere Maijala <ere.maijala at helsinki.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #98143|0                           |1
        is obsolete|                            |

--- Comment #27 from Ere Maijala <ere.maijala at helsinki.fi> ---
Created attachment 98210
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98210&action=edit
Bug 22690: Refactor merging of records to improve performance (Elasticsearch)

This patch allows merging of records with many items without the web server
timing out.

Test plan:

Without the patch:

- Create 2 records (one with e.g. 1000 items).
- Do a cataloguing search that displays both records, select them and click
"Merge selected".
- Choose the record with many items as the one to be eliminated.
- Start the merging.
- After a while the web server should give you a timeout error (the merging
process may still continue)

With the patch:
- Do the same as above
- This time verify that the records are merged without timeout
- Create a new biblio with an item
- Add with the item:
  * acquisition order
  * hold (reserve)
- Merge the biblio to another one
- Verify that the item and its related data was moved
- Verify that tests pass:
  prove -v t/db_dependent/Koha/Item.t
  prove -v t/db_dependent/Items/MoveItemFromBiblio.t

Signed-off-by: Michal Denar <black23 at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 31 08:50:12 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 31 Jan 2020 07:50:12 +0000
Subject: [Koha-bugs] [Bug 22690] Merging records with many items too slow
 (Elasticsearch)
In-Reply-To: <bug-22690-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22690-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22690-70-0zLtW2PX6A@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22690

Ere Maijala <ere.maijala at helsinki.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #98210|0                           |1
        is obsolete|                            |

--- Comment #28 from Ere Maijala <ere.maijala at helsinki.fi> ---
Created attachment 98211
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98211&action=edit
Bug 22690: Refactor merging of records to improve performance (Elasticsearch)

This patch allows merging of records with many items without the web server
timing out.

Test plan:

Without the patch:

- Create 2 records (one with e.g. 1000 items).
- Do a cataloguing search that displays both records, select them and click
"Merge selected".
- Choose the record with many items as the one to be eliminated.
- Start the merging.
- After a while the web server should give you a timeout error (the merging
process may still continue)

With the patch:
- Do the same as above
- This time verify that the records are merged without timeout
- Create a new biblio with an item
- Add with the item:
  * acquisition order
  * hold (reserve)
- Merge the biblio to another one
- Verify that the item and its related data was moved
- Verify that tests pass:
  prove -v t/db_dependent/Koha/Item.t
  prove -v t/db_dependent/Items/MoveItemFromBiblio.t

Signed-off-by: Michal Denar <black23 at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 31 08:50:50 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 31 Jan 2020 07:50:50 +0000
Subject: [Koha-bugs] [Bug 22690] Merging records with many items too slow
 (Elasticsearch)
In-Reply-To: <bug-22690-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22690-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22690-70-vZzBVcDZIe@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22690

--- Comment #29 from Ere Maijala <ere.maijala at helsinki.fi> ---
Rename done.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 31 08:58:39 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 31 Jan 2020 07:58:39 +0000
Subject: [Koha-bugs] [Bug 24528] Add a syntax for specifying counts on
 x-koha-embed
In-Reply-To: <bug-24528-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24528-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24528-70-JskiAEesVS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24528

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|BLOCKED                     |Passed QA
   Patch complexity|---                         |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 31 08:58:42 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 31 Jan 2020 07:58:42 +0000
Subject: [Koha-bugs] [Bug 24528] Add a syntax for specifying counts on
 x-koha-embed
In-Reply-To: <bug-24528-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24528-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24528-70-qqDW5pfjzS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24528

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #98199|0                           |1
        is obsolete|                            |

--- Comment #10 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 98212
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98212&action=edit
Bug 24528: Unit tests for Koha::Object->to_api

This patch introduces unit tests for the new to_api bejaviour for
*_count methods.

To test:
1. Apply this patch
2. Run:
   $ kshell
  k$ prove t/db_dependent/Koha/Object.t
=> FAIL: Tests fail because the feature is not implemented

Signed-off-by: David Nind <david at davidnind.com>

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 31 08:58:47 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 31 Jan 2020 07:58:47 +0000
Subject: [Koha-bugs] [Bug 24528] Add a syntax for specifying counts on
 x-koha-embed
In-Reply-To: <bug-24528-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24528-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24528-70-lZkVYBS0Bk@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24528

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #98200|0                           |1
        is obsolete|                            |

--- Comment #11 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 98213
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98213&action=edit
Bug 24528: Add *_count support to to_api

This patch adds a way to tell to_api an attribute needs to be calculated
as the count on an existing method/relationship result. For example, if
we wanted to include the holds_count attribute for a Koha::Patron
object, we would call it:

    $ patron_json = $patron->to_api({ embed => { holds_count => { is_count => 1
} } });

This way to_api will internally call

    $json->{holds_count} = $self->holds->count;

To test:
1. Apply the tests patch
2. Run:
   $ kshell
  k$ prove t/db_dependent/Koha/Object.t
=> FAIL: Tests fail!
3. Apply this patch
4. Repeat (2)
=> SUCCESS: Tests pass!
5. Sign off :-D

Signed-off-by: David Nind <david at davidnind.com>

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 31 08:58:51 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 31 Jan 2020 07:58:51 +0000
Subject: [Koha-bugs] [Bug 24528] Add a syntax for specifying counts on
 x-koha-embed
In-Reply-To: <bug-24528-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24528-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24528-70-paXS7P9m7g@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24528

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #98201|0                           |1
        is obsolete|                            |

--- Comment #12 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 98214
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98214&action=edit
Bug 24528: Add a syntax to x-koha-embed to specify counts

This patch adds a + syntax to specify on the x-koha-embed header that we
want the count of a relation in the response. For example:

GET /patrons/1
x-koha-embed: checkouts+count

Would return a JSON representation of a Koha::Patron, with a new
attribute added: checkouts_count, which will be the result of calling
$patron->checkouts->count.

This is all done automatically in to_api. This patch makes parsing the
x-koha-embed header build the right structure for passing to the to_api
method.

To test:
1. Apply this patch
2. Run:
   $ kshell
  k$ prove t/Koha/REST/Plugin/Query.t
=> SUCCESS: Tests pass!
3. Sign off :-D

Sponsored-by: ByWater Solutions

Signed-off-by: David Nind <david at davidnind.com>

Signed-off-by: David Nind <david at davidnind.com>

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 31 08:59:05 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 31 Jan 2020 07:59:05 +0000
Subject: [Koha-bugs] [Bug 24528] Add a syntax for specifying counts on
 x-koha-embed
In-Reply-To: <bug-24528-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24528-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24528-70-QzZawWIAqM@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24528

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         QA Contact|                            |m.de.rooy at rijksmuseum.nl

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 31 09:01:40 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 31 Jan 2020 08:01:40 +0000
Subject: [Koha-bugs] [Bug 24547] Add more action logs for holds
In-Reply-To: <bug-24547-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24547-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24547-70-OkAGg74FZb@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24547

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 31 09:01:43 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 31 Jan 2020 08:01:43 +0000
Subject: [Koha-bugs] [Bug 24547] Add more action logs for holds
In-Reply-To: <bug-24547-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24547-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24547-70-vReHwTVksX@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24547

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #98174|0                           |1
        is obsolete|                            |

--- Comment #2 from David Nind <david at davidnind.com> ---
Created attachment 98215
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98215&action=edit
Bug 24547: Add more action logs for holds

It seems like ModReserveFill and ModReserveAffect should both produce action
logs for holds.

Test Plan:
0) Enable HoldsLog system preference
1) Apply this patch
2) Place a hold
3) Check in the item to trap the hold
4) Check out the item to fill the hold
5) Check the action logs for that reserve id
6) Note the new logs!

Signed-off-by: David Nind <david at davidnind.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 31 09:10:55 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 31 Jan 2020 08:10:55 +0000
Subject: [Koha-bugs] [Bug 24546] Club/Hold.t has a wrong call to
 build_sample_item
In-Reply-To: <bug-24546-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24546-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24546-70-woXIAIYjlJ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24546

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 31 09:10:58 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 31 Jan 2020 08:10:58 +0000
Subject: [Koha-bugs] [Bug 24546] Club/Hold.t has a wrong call to
 build_sample_item
In-Reply-To: <bug-24546-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24546-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24546-70-4P9GouTOG3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24546

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #98160|0                           |1
        is obsolete|                            |

--- Comment #3 from David Nind <david at davidnind.com> ---
Created attachment 98216
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98216&action=edit
Bug 24546: Fix intentions of build_sample_item in Club/Hold.t

In t/db_dependent/Koha/Club/Hold.t:
my $item1 = $builder->build_sample_item({ branchcode => $library->branchcode
});
my $item2 = $builder->build_sample_item({ branchcode => $library->branchcode
});

build_sample_item takes either "library" or the item's attributes.
branchcode is not part of the item's table, so what those 2 lines are trying to
acchieve is wrong.

Test plan:
 % prove t/db_dependent/Koha/Club/Hold.t
must return green before and after this patch

Note that this patch also remove an uneeded debugging statement.

This has been caught by bug 24363.

Signed-off-by: David Nind <david at davidnind.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 31 09:17:34 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 31 Jan 2020 08:17:34 +0000
Subject: [Koha-bugs] [Bug 18936] Convert issuingrules fields to
 circulation_rules
In-Reply-To: <bug-18936-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18936-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18936-70-FK0GopsNCJ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18936

Minna Kivinen <minna.kivinen at hamk.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

--- Comment #99 from Minna Kivinen <minna.kivinen at hamk.fi> ---
Signed-off-by: Minna Kivinen <minna.kivinen at hamk.fi>
Tested following:
- Added several rules for different combinations of patron category and item
type
- Modified rules
- Removed rules
- Added new rules
- Tested functionalities against rules: Hard due date, Loan period, Loans
allowed (total), Renewals allowed (count), No renewal before, Holds allowed
(total)
- Tested especially empty values on rules

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 31 10:02:09 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 31 Jan 2020 09:02:09 +0000
Subject: [Koha-bugs] [Bug 21357] Filter elisions from index and search terms
 in Elasticsearch
In-Reply-To: <bug-21357-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21357-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21357-70-HIjIYLhBEX@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21357

--- Comment #37 from Julian Maurice <julian.maurice at biblibre.com> ---
(In reply to Katrin Fischer from comment #35)
> Hi Julian, does tit mean it searches the different representations
> simultanously? 

Only one query to ES is needed, if that's what you mean by simultaneously

> I wonder how it would work for English, thinking of words like "can't" or
> "doesn't".

The built-in english analyzer does not do anything with words that end with
"n't" but it should possible to configure a custom english analyzer that treats
"can't" and "cannot" the same way.

(In reply to Ere Maijala from comment #36)
> I can't really see the benefit since, as far as I can see, elision handling
> is not prone to cause conflicts with other language analysis.

Ellision might not cause troubles (but what about names like "D'Amato" ?).
I'm thinking about the next step : stemming is very different from one language
to another and we need to find a way to have stemming for multi-language
catalogs.

> Separating analysis for different languages also won't work for
> mixed-language fields.  Think about names and a (very fictional)
> example phrase "Images from movie l'Avion". You'd get either elision
> filtering or English stemming but not both. For sure it will still be
> found with a simple keyword search, but it breaks at least adjacent
> word searches and relevance ranking.

Nothing would work perfectly with mixed-language fields. But in this particular
example, you could have another subfield `lang_en_fr` that does english
stemming and french elision

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 31 10:02:53 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 31 Jan 2020 09:02:53 +0000
Subject: [Koha-bugs] [Bug 23924] Add a parameter to the script
 add_date_fields_to_marc_records.pl to specify a date field
In-Reply-To: <bug-23924-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23924-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23924-70-bIep5kYBew@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23924

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 31 10:02:57 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 31 Jan 2020 09:02:57 +0000
Subject: [Koha-bugs] [Bug 23924] Add a parameter to the script
 add_date_fields_to_marc_records.pl to specify a date field
In-Reply-To: <bug-23924-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23924-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23924-70-zdNHj9tl6d@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23924

--- Comment #6 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 98217
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98217&action=edit
Bug 23924: Reset the fields to add

We do not want to copy fields from the previous records!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 31 10:03:21 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 31 Jan 2020 09:03:21 +0000
Subject: [Koha-bugs] [Bug 23924] Add a parameter to the script
 add_date_fields_to_marc_records.pl to specify a date field
In-Reply-To: <bug-23924-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23924-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23924-70-3ElmPYgKzK@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23924

--- Comment #7 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
(In reply to Hugo Agud from comment #5)
> when processing more than one record, the firts records creates propertly
> 905 field, but the second one doubles de 905 field with the info from record
> 1 and record 3

That was a silly mistake, sorry about that!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 31 10:03:47 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 31 Jan 2020 09:03:47 +0000
Subject: [Koha-bugs] [Bug 24454] currency formatting from JS
In-Reply-To: <bug-24454-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24454-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24454-70-7fJURpEj7x@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24454

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |martin.renvoize at ptfs-europe
                   |                            |.com

--- Comment #2 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Erm....  did you see /koha-tmpl/intranet-tmpl/prog/en/includes/format_price.inc
?

Just trying to wrap my head around the difference between this and that at the
moment.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 31 10:05:24 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 31 Jan 2020 09:05:24 +0000
Subject: [Koha-bugs] [Bug 24454] currency formatting from JS
In-Reply-To: <bug-24454-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24454-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24454-70-Bkj1lFxovu@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24454

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=12987

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 31 10:05:24 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 31 Jan 2020 09:05:24 +0000
Subject: [Koha-bugs] [Bug 12987] Update table footer with the visible rows
In-Reply-To: <bug-12987-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-12987-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12987-70-IVg6e00lrZ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12987

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=24454

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 31 10:05:49 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 31 Jan 2020 09:05:49 +0000
Subject: [Koha-bugs] [Bug 24454] currency formatting from JS
In-Reply-To: <bug-24454-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24454-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24454-70-UO1CWm1Ppx@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24454

--- Comment #3 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
(In reply to Martin Renvoize from comment #2)
> Erm....  did you see
> /koha-tmpl/intranet-tmpl/prog/en/includes/format_price.inc ?
> 
> Just trying to wrap my head around the difference between this and that at
> the moment.

Frankly, that include is well hidden.. it was introduced in bug 12987

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 31 10:14:26 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 31 Jan 2020 09:14:26 +0000
Subject: [Koha-bugs] [Bug 21357] Filter elisions from index and search terms
 in Elasticsearch
In-Reply-To: <bug-21357-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21357-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21357-70-qKuYmnZ9lE@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21357

--- Comment #38 from Ere Maijala <ere.maijala at helsinki.fi> ---
(In reply to Julian Maurice from comment #37)
> Ellision might not cause troubles (but what about names like "D'Amato" ?).
> I'm thinking about the next step : stemming is very different from one
> language to another and we need to find a way to have stemming for
> multi-language catalogs.

I agree that stemming is difficult, and I'e tried to purposefully limit this
bug to elisions. 

> > Separating analysis for different languages also won't work for
> > mixed-language fields.  Think about names and a (very fictional)
> > example phrase "Images from movie l'Avion". You'd get either elision
> > filtering or English stemming but not both. For sure it will still be
> > found with a simple keyword search, but it breaks at least adjacent
> > word searches and relevance ranking.
> 
> Nothing would work perfectly with mixed-language fields. But in this
> particular example, you could have another subfield `lang_en_fr` that does
> english stemming and french elision

And maybe lang_fi_fr, lang_sv_fr etc. This gets complicated pretty quickly. And
I'm afraid separating the different language analysis chains doesn't solve the
issue with stemming etc. because you'd need to avoid indexing into "wrong"
fields which would require you to know what language the string to be indexed
is in.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 31 10:25:58 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 31 Jan 2020 09:25:58 +0000
Subject: [Koha-bugs] [Bug 24454] currency formatting from JS
In-Reply-To: <bug-24454-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24454-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24454-70-7OkIwjillO@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24454

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=20352

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 31 10:25:58 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 31 Jan 2020 09:25:58 +0000
Subject: [Koha-bugs] [Bug 20352] Add ability of currency/price to have a
 symbol after amount
In-Reply-To: <bug-20352-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20352-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20352-70-7yzHqvIYrB@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20352

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.koha-community
                   |                            |.org/bugzilla3/show_bug.cgi
                   |                            |?id=24454

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 31 10:36:28 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 31 Jan 2020 09:36:28 +0000
Subject: [Koha-bugs] [Bug 24363] Datepicker calendar is not always sexy
In-Reply-To: <bug-24363-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24363-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24363-70-Q2hftnV4Ty@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24363

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |david at davidnind.com

--- Comment #13 from David Nind <david at davidnind.com> ---
Everything looks good in Firefox.

However with Google Chrome the icon is aligned to the inside left of the box
and the start of the date overlays it.

I can post screenshots if required.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 31 10:39:33 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 31 Jan 2020 09:39:33 +0000
Subject: [Koha-bugs] [Bug 21357] Filter elisions from index and search terms
 in Elasticsearch
In-Reply-To: <bug-21357-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21357-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21357-70-Y7kkM28RW9@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21357

--- Comment #39 from Julian Maurice <julian.maurice at biblibre.com> ---
> because you'd need to avoid indexing into "wrong" fields which would
> require you to know what language the string to be indexed is in.

I don't think you have to avoid indexing into the wrong fields (but I agree it
would be better). You just need to have at least one that match.
You might end up with false positives (more results that you should have) but
in my opinion it's still better than not having the results you expected.

I realize that stemming is out of the scope of this bug, but even if we talk
only about ellision, I think it would be better to have one field analyzed with
ellision and one field without ellision, and to search in both fields every
time

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 31 10:41:44 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 31 Jan 2020 09:41:44 +0000
Subject: [Koha-bugs] [Bug 24454] currency formatting from JS
In-Reply-To: <bug-24454-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24454-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24454-70-L5LQkuy5lj@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24454

--- Comment #4 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Hola Agustín,
As Martin said, there already is another include file doing more or less the
same things.

Several points:
1. Do you have an example that is using that code?
2. The existing include file is wrong (written 6 years ago), and is ignoring
Koha::Number::Price, in which we are defining the display option of prices.
3. See also bug 20352, this is where are should go, ie. all the parameters
defined in the currency table, not depending on the CurrencyFormat syspref (we
should get rid of it)
4. I have the feeling that the currency TT plugin should not exist, but Price
could be used instead, to retrieve the format_parameters.
5. Note that the copyright statement is wrong

Let me know if you have any questions!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 31 10:46:51 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 31 Jan 2020 09:46:51 +0000
Subject: [Koha-bugs] [Bug 21674] Data integrity not enforced for library
 groups
In-Reply-To: <bug-21674-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21674-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21674-70-wm1tc9xknz@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21674

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |additional_work_needed

--- Comment #19 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
I'm getting a wierd DB error on this one: 

DBD::mysql::db do failed: Table 'library_groups' is specified twice, both as a
target for 'DELETE' and as a separate source for data [for Statement "
            DELETE FROM library_groups
            WHERE id NOT IN (
                SELECT MIN(id)
                FROM library_groups
                WHERE parent_id IS NOT NULL
                GROUP BY parent_id, branchcode
            )
            AND parent_id IS NOT NULL;
        "] at ./installer/data/mysql/updatedatabase.pl line 20666.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 31 10:47:36 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 31 Jan 2020 09:47:36 +0000
Subject: [Koha-bugs] [Bug 18936] Convert issuingrules fields to
 circulation_rules
In-Reply-To: <bug-18936-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18936-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18936-70-Px5MUPUR75@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18936

--- Comment #100 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
(In reply to Minna Kivinen from comment #99)
> Signed-off-by: Minna Kivinen <minna.kivinen at hamk.fi>
> Tested following:
> - Added several rules for different combinations of patron category and item
> type
> - Modified rules
> - Removed rules
> - Added new rules
> - Tested functionalities against rules: Hard due date, Loan period, Loans
> allowed (total), Renewals allowed (count), No renewal before, Holds allowed
> (total)
> - Tested especially empty values on rules

Thank you! I have added your signed-off-by lines to the commit messages.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 31 10:50:41 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 31 Jan 2020 09:50:41 +0000
Subject: [Koha-bugs] [Bug 24467] *_count methods should be avoided
In-Reply-To: <bug-24467-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24467-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24467-70-qefBcRy4mv@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24467

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         QA Contact|testopia at bugs.koha-communit |josef.moravec at gmail.com
                   |y.org                       |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 31 10:51:21 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 31 Jan 2020 09:51:21 +0000
Subject: [Koha-bugs] [Bug 24467] *_count methods should be avoided
In-Reply-To: <bug-24467-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24467-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24467-70-Ji5DfRLUFE@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24467

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 31 10:51:24 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 31 Jan 2020 09:51:24 +0000
Subject: [Koha-bugs] [Bug 24467] *_count methods should be avoided
In-Reply-To: <bug-24467-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24467-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24467-70-zaI040hJ3T@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24467

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #98202|0                           |1
        is obsolete|                            |

--- Comment #7 from Josef Moravec <josef.moravec at gmail.com> ---
Created attachment 98218
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98218&action=edit
Bug 24467: Remove _count methods introduced for API use

This patch removes some methods that were introduced for API usage in
the first iteration of the object embedding development effort.

Those methods were obsoleted by bug 24528, which introduces a smarter
way for Koha::Object->to_api to embed *_count attributes on the output
structure based on the relationships and a call to ->count.

To test:
1. Apply this patch
2. Run:
   $ kshell
  k$ prove t/db_dependent/Koha/Biblio.t
=> SUCCESS: Tests pass
3. Sign off :-D

Signed-off-by: David Nind <david at davidnind.com>

Signed-off-by: Josef Moravec <josef.moravec at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 31 10:51:32 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 31 Jan 2020 09:51:32 +0000
Subject: [Koha-bugs] [Bug 24467] *_count methods should be avoided
In-Reply-To: <bug-24467-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24467-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24467-70-du9Shig4Ev@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24467

--- Comment #8 from Josef Moravec <josef.moravec at gmail.com> ---
Created attachment 98219
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98219&action=edit
Bug 24467: (QA follow-up) Fix POD in Koha::Biblio

Signed-off-by: Josef Moravec <josef.moravec at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 31 10:51:38 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 31 Jan 2020 09:51:38 +0000
Subject: [Koha-bugs] [Bug 24467] *_count methods should be avoided
In-Reply-To: <bug-24467-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24467-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24467-70-kLE4KS9Y10@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24467

--- Comment #9 from Josef Moravec <josef.moravec at gmail.com> ---
Created attachment 98220
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98220&action=edit
Bug 24467: (QA follow-up) Clarify tests wording for ->count methods

Signed-off-by: Josef Moravec <josef.moravec at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 31 10:55:19 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 31 Jan 2020 09:55:19 +0000
Subject: [Koha-bugs] [Bug 20627] Prevent leakages of user permissions to api
 access tokens
In-Reply-To: <bug-20627-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20627-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20627-70-FKSOZZuJGG@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20627

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |m.de.rooy at rijksmuseum.nl

--- Comment #1 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Any developments on this front since almost two years passed? :)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 31 10:56:28 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 31 Jan 2020 09:56:28 +0000
Subject: [Koha-bugs] [Bug 12430] Using QueryAutoTruncate breaks relevance
 ranking
In-Reply-To: <bug-12430-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-12430-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12430-70-5B339z1ROv@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12430

--- Comment #20 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
(In reply to Victor Grousset/tuxayo from comment #19)
> > I've attempted a rebase of the patch.. 
> > it's not an area I'm all that familiar with so testing is required.
> 
> - test plan passed
> - signed off
> - fixed test plan: TryQueryParser => UseQueryParser
> - clarified test plan: "enable QueryAutoTruncate" =>  "set QueryAutoTruncate
> to auto"
> 
> As per the uncertainty about regressions, should the ticket status be "In
> discussion" ?

Did you try the problematic cases?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 31 10:58:41 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 31 Jan 2020 09:58:41 +0000
Subject: [Koha-bugs] [Bug 24531] OAI-PMH set mappings only consider first
 field with a given tag
In-Reply-To: <bug-24531-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24531-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24531-70-t8D3PI8qaG@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24531

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 31 10:58:44 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 31 Jan 2020 09:58:44 +0000
Subject: [Koha-bugs] [Bug 24531] OAI-PMH set mappings only consider first
 field with a given tag
In-Reply-To: <bug-24531-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24531-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24531-70-kQTljYudQh@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24531

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #98153|0                           |1
        is obsolete|                            |

--- Comment #4 from David Nind <david at davidnind.com> ---
Created attachment 98221
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98221&action=edit
Bug 24531 - Test for OAI-PMH sets and repeated fields

This patch adds two tests related to OAI-PMH sets. It creates a
dummy record with a repeated field, with different values. It then
tests if the record is caught by mappings that match the value in
the first field, and then if it is caught by mappings that match
the second field.

Signed-off-by: David Nind <david at davidnind.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 31 10:58:47 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 31 Jan 2020 09:58:47 +0000
Subject: [Koha-bugs] [Bug 24531] OAI-PMH set mappings only consider first
 field with a given tag
In-Reply-To: <bug-24531-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24531-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24531-70-k6eOjP1Wcn@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24531

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #98154|0                           |1
        is obsolete|                            |

--- Comment #5 from David Nind <david at davidnind.com> ---
Created attachment 98222
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98222&action=edit
Bug 24531 - Fix OAI-PMH sets for records with repeated fields

Currently, an OAI-PMH set mapping will only match if the value it
is looking for occurs in the first instance of a repeated field.

To test:
- Apply the first patch with two new tests
- Run something like this:
  sudo koha-shell -c "prove -v t/db_dependent/OAI/Sets.t" kohadev
- Verify that the last test fails
- Apply this secind patch
- Rerun the test file above
- Verify that all tests now pass

Signed-off-by: David Nind <david at davidnind.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 31 11:03:47 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 31 Jan 2020 10:03:47 +0000
Subject: [Koha-bugs] [Bug 23128] Missing Net::OAuth2::AuthorizationServer
 dependency
In-Reply-To: <bug-23128-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23128-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23128-70-197gMCRrJf@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23128

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |m.de.rooy at rijksmuseum.nl

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 31 11:08:35 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 31 Jan 2020 10:08:35 +0000
Subject: [Koha-bugs] [Bug 24213] Koha::Object->get_from_storage should
 return undef if the object has been deleted
In-Reply-To: <bug-24213-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24213-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24213-70-RckR6vfzU5@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24213

--- Comment #11 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
(In reply to Marcel de Rooy from comment #8)
> (In reply to Marcel de Rooy from comment #7)
> >     # Subtest: Bad value tests
> >         1..3
> >         # No tests run!
> >     not ok 16 - No tests run for subtest "Bad value tests"
> >     #   Failed test 'No tests run for subtest "Bad value tests"'
> >     #   at t/db_dependent/Koha/Object.t line 685.
> >     # Looks like you failed 1 test of 16.
> > not ok 16 - store() tests
> > #   Failed test 'store() tests'
> > #   at t/db_dependent/Koha/Object.t line 688.
> > 
> > Stumbling across this fail, but also without your patch.
> 
> Can be ignored. Resolved with strict_sql_mode. Maybe an idea to put this key
> in the default koha-conf.xml (commented or zero)?

I do not understand what you meant.

The test passes for me, with strict_sql_mode set.
When run with prove, the strict mode is enabled automatically.
Also the flag is set for devs (so from koha-testing-docker), that's is
expected, we want devs to catch such problems.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 31 11:11:30 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 31 Jan 2020 10:11:30 +0000
Subject: [Koha-bugs] [Bug 21901] Foreign keys are missing on the serials and
 subscriptions tables
In-Reply-To: <bug-21901-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21901-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21901-70-L61UdTcL0q@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21901

--- Comment #7 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
(In reply to Marcel de Rooy from comment #6)
> Inclined to think that could be a blocker. We dont want large installs fail
> on this step.
> Feel free to change the status again, well argumented ;)

I let that kind of comment to get help on it, not to see people asking me to
unlock the issue.
We need to test it on a old and big production DB, as I said. I do not have one
to try.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 31 11:13:12 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 31 Jan 2020 10:13:12 +0000
Subject: [Koha-bugs] [Bug 24552] New: Koha does not work with
 Search::Elasticsearch 6.00
Message-ID: <bug-24552-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24552

            Bug ID: 24552
           Summary: Koha does not work with Search::Elasticsearch 6.00
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: minor
          Priority: P5 - low
         Component: Architecture, internals, and plumbing
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: julian.maurice at biblibre.com
        QA Contact: testopia at bugs.koha-community.org

Koha doesn't work with the latest version of Search::Elasticsearch (6.00)

Steps to reproduce:
1. Install latest version of Search::Elasticsearch
2. Set SearchEngine syspref to 'Elasticsearch'
3. Reload starman
4. Do a search

The search fails with the following error message:

Error: Can't locate Search/Elasticsearch/Client/5_0/Direct.pm in @INC (you may
need to install the Search::Elasticsearch::Client::5_0::Direct module)

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 31 11:16:00 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 31 Jan 2020 10:16:00 +0000
Subject: [Koha-bugs] [Bug 21901] Foreign keys are missing on the serials and
 subscriptions tables
In-Reply-To: <bug-21901-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21901-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21901-70-esmghpp50f@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21901

--- Comment #8 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
(In reply to Jonathan Druart from comment #7)
> (In reply to Marcel de Rooy from comment #6)
> > Inclined to think that could be a blocker. We dont want large installs fail
> > on this step.
> > Feel free to change the status again, well argumented ;)
> 
> I let that kind of comment to get help on it, not to see people asking me to
> unlock the issue.
> We need to test it on a old and big production DB, as I said. I do not have
> one to try.

Yes, but what I am saying is that one such a test does not prove anything. If
it does not contain referential errors, it goes fine. Does not prove that
nobody else has such problems..

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 31 11:17:21 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 31 Jan 2020 10:17:21 +0000
Subject: [Koha-bugs] [Bug 24552] Koha does not work with
 Search::Elasticsearch 6.00
In-Reply-To: <bug-24552-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24552-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24552-70-8KdlvHEegh@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24552

--- Comment #1 from Julian Maurice <julian.maurice at biblibre.com> ---
Created attachment 98223
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98223&action=edit
Bug 24552: Be compatible with Search::Elasticsearch 6.00

There is no need to specify the `client` param here because
'5_0::Direct' is the default value for Search::Elasticsearch 5.x and it
breaks when Search::Elasticsearch 6.x is installed

Test plan:
1. Apply the patch
2. Make sure you have Search::Elasticsearch 5.x
3. Reload starman
4. Verify that search works
5. Install Search::Elasticsearch 6.x
6. Reload starman
7. Verify that search works

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 31 11:17:35 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 31 Jan 2020 10:17:35 +0000
Subject: [Koha-bugs] [Bug 24552] Koha does not work with
 Search::Elasticsearch 6.00
In-Reply-To: <bug-24552-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24552-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24552-70-OzsEHHhs58@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24552

Julian Maurice <julian.maurice at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 31 11:25:59 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 31 Jan 2020 10:25:59 +0000
Subject: [Koha-bugs] [Bug 21901] Foreign keys are missing on the serials and
 subscriptions tables
In-Reply-To: <bug-21901-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21901-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21901-70-kHBDkHVSLy@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21901

--- Comment #9 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
What do you suggest then?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 31 11:36:21 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 31 Jan 2020 10:36:21 +0000
Subject: [Koha-bugs] [Bug 24083] Koha should support "seen" vs "unseen"
 renewals
In-Reply-To: <bug-24083-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24083-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24083-70-KRY1LEYDdd@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24083

Fiona Borthwick <fiona.borthwick at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |fiona.borthwick at ptfs-europe
                   |                            |.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 31 11:48:45 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 31 Jan 2020 10:48:45 +0000
Subject: [Koha-bugs] [Bug 21901] Foreign keys are missing on the serials and
 subscriptions tables
In-Reply-To: <bug-21901-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21901-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21901-70-ZjVNT3srWf@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21901

--- Comment #10 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
<marcelr> ashimema: did you test on a large production DB ?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 31 12:09:29 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 31 Jan 2020 11:09:29 +0000
Subject: [Koha-bugs] [Bug 21357] Filter elisions from index and search terms
 in Elasticsearch
In-Reply-To: <bug-21357-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21357-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21357-70-A1MYTKtYLB@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21357

--- Comment #40 from Nick Clemens <nick at bywatersolutions.com> ---
(In reply to Julian Maurice from comment #39)

What about using a record field to determine the language of the record and
applying different analyser settings based on that? 008/35-37 or 041 in marc21,
I don't know if there is a UNIMARC equivalent

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 31 12:18:35 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 31 Jan 2020 11:18:35 +0000
Subject: [Koha-bugs] [Bug 24528] Add a syntax for specifying counts on
 x-koha-embed
In-Reply-To: <bug-24528-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24528-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24528-70-QocuLnGADw@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24528

--- Comment #13 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
+            if ( $embed =~ m/^(?<relation>.*)_count$/

and

+        if ( $curr =~ m/^(?<relation>.*)\+count/ ) {
+            my $key = $+{relation} . "_count";

Why did not you keep "relation+count"?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 31 12:21:57 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 31 Jan 2020 11:21:57 +0000
Subject: [Koha-bugs] [Bug 21357] Filter elisions from index and search terms
 in Elasticsearch
In-Reply-To: <bug-21357-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21357-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21357-70-hvfMDcdNyJ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21357

--- Comment #41 from Julian Maurice <julian.maurice at biblibre.com> ---
(In reply to Nick Clemens from comment #40)
> (In reply to Julian Maurice from comment #39)
> 
> What about using a record field to determine the language of the record and
> applying different analyser settings based on that? 008/35-37 or 041 in
> marc21, I don't know if there is a UNIMARC equivalent

In UNIMARC there is field 101 that could be used for that.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 31 12:33:28 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 31 Jan 2020 11:33:28 +0000
Subject: [Koha-bugs] [Bug 24528] Add a syntax for specifying counts on
 x-koha-embed
In-Reply-To: <bug-24528-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24528-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24528-70-zX39iIKqvb@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24528

--- Comment #14 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
(In reply to Jonathan Druart from comment #13)
> +            if ( $embed =~ m/^(?<relation>.*)_count$/
> 
> and
> 
> +        if ( $curr =~ m/^(?<relation>.*)\+count/ ) {
> +            my $key = $+{relation} . "_count";
> 
> Why did not you keep "relation+count"?

Inertia. Coding at 2 am. I agree with keeping the +.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 31 12:35:58 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 31 Jan 2020 11:35:58 +0000
Subject: [Koha-bugs] [Bug 24545] Replace Franklin Street by gnu.org/licenses
 in copyright
In-Reply-To: <bug-24545-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24545-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24545-70-HE7ONDc4RH@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24545

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|koha-bugs at lists.koha-commun |jonathan.druart at bugs.koha-c
                   |ity.org                     |ommunity.org
             Status|NEW                         |ASSIGNED

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 31 12:40:25 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 31 Jan 2020 11:40:25 +0000
Subject: [Koha-bugs] [Bug 21674] Data integrity not enforced for library
 groups
In-Reply-To: <bug-21674-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21674-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21674-70-NVEg5427Jv@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21674

--- Comment #20 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 98224
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98224&action=edit
Bug 21674: (RM follow-up) Fix updatedatabase error

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 31 12:49:45 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 31 Jan 2020 11:49:45 +0000
Subject: [Koha-bugs] [Bug 24553] New: Cancelling hold via SIP returns a
 failed response even when cancellation succeeds
Message-ID: <bug-24553-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24553

            Bug ID: 24553
           Summary: Cancelling hold via SIP returns a failed response even
                    when cancellation succeeds
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: SIP2
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: nick at bywatersolutions.com
        QA Contact: testopia at bugs.koha-community.org
                CC: colin.campbell at ptfs-europe.com

It looks like we have some odd code here. We delete the hold
(C4::SIP::ILS::Transaction::Hold->drop_hold), then we check the patron to see
if they have a hold on the item (C4::SIP::ILS::Patron->drop_hold) - of course
we don't find the hold because we already cancelled it.

348     $trans->patron($patron);
349     $trans->item($item);
350     $trans->drop_hold;
351     unless ($trans->ok) {
352         $trans->screen_msg("Error with transaction drop_hold: " .
$trans->screen_msg);
353         return $trans;
354     }
355     # Remove the hold from the patron's record first
356     $trans->ok($patron->drop_hold($item_id));   # different than the
transaction drop!
357 
358     unless ($trans->ok) {
359         # We didn't find it on the patron record
360         $trans->screen_msg("No such hold on patron record.");
361         return $trans;
362     }

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 31 12:51:04 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 31 Jan 2020 11:51:04 +0000
Subject: [Koha-bugs] [Bug 24553] Cancelling hold via SIP returns a failed
 response even when cancellation succeeds
In-Reply-To: <bug-24553-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24553-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24553-70-hUNLZKyYjB@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24553

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |kyle at bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 31 12:54:17 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 31 Jan 2020 11:54:17 +0000
Subject: [Koha-bugs] [Bug 18936] Convert issuingrules fields to
 circulation_rules
In-Reply-To: <bug-18936-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18936-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18936-70-xJAW3480uB@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18936

--- Comment #101 from Joonas Kylmälä <joonas.kylmala at helsinki.fi> ---
The qa-koha.pl tool detected an issue with constant being redefined:

> FAIL   Koha/CirculationRules.pm              
>   FAIL   valid                  
>                Constant subroutine >Koha::CirculationRules::GUESSED_ITEMTYPES_KEY redefined

This appears to be from circular dependency:

Koha/CirculationRules.pm -> Koha/CirculationRule.pm -> Koha/ItemTypes.pm ->
Koha/ItemType.pm -> Koha/CirculationRules.pm

if someone has the time to remove the circularity here would be great!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 31 13:05:00 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 31 Jan 2020 12:05:00 +0000
Subject: [Koha-bugs] [Bug 24554] New: Only embed relations from Koha::Biblio
 in to_api
Message-ID: <bug-24554-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24554

            Bug ID: 24554
           Summary: Only embed relations from Koha::Biblio in to_api
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: REST API
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: tomascohen at gmail.com

The current implemented behaviour of this method (fallback to the biblioitems
relations) breaks using it with bug 24538. On fixing it, I noticed the method
is quite over-engineered.

As biblioitems is not a real entity on the API and we are not going to add
related tables to bilbioitems (most probably get it merged into biblio) we
don't need the pass-through of embeds into the biblioitem object.

This makes counts work, and also makes sense :-D

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 31 13:06:01 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 31 Jan 2020 12:06:01 +0000
Subject: [Koha-bugs] [Bug 24554] Only embed relations from Koha::Biblio in
 to_api
In-Reply-To: <bug-24554-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24554-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24554-70-atO4nYfr5Y@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24554

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff
             Blocks|                            |20212
           Assignee|koha-bugs at lists.koha-commun |tomascohen at gmail.com
                   |ity.org                     |
         Depends on|                            |24366, 24528


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20212
[Bug 20212] Slowness in Receiving in Acquisitions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24366
[Bug 24366] Merging biblioitems should happen in Koha::Biblio->to_api
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24528
[Bug 24528] Add a syntax for specifying counts on x-koha-embed
-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 31 13:06:01 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 31 Jan 2020 12:06:01 +0000
Subject: [Koha-bugs] [Bug 20212] Slowness in Receiving in Acquisitions
In-Reply-To: <bug-20212-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20212-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20212-70-m7MvcZewPZ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20212

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |24554


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24554
[Bug 24554] Only embed relations from Koha::Biblio in to_api
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 31 13:06:01 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 31 Jan 2020 12:06:01 +0000
Subject: [Koha-bugs] [Bug 24366] Merging biblioitems should happen in
 Koha::Biblio->to_api
In-Reply-To: <bug-24366-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24366-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24366-70-5RGGxEDdsY@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24366

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |24554


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24554
[Bug 24554] Only embed relations from Koha::Biblio in to_api
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 31 13:06:01 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 31 Jan 2020 12:06:01 +0000
Subject: [Koha-bugs] [Bug 24528] Add a syntax for specifying counts on
 x-koha-embed
In-Reply-To: <bug-24528-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24528-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24528-70-S6LN9JDxyf@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24528

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |24554


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24554
[Bug 24554] Only embed relations from Koha::Biblio in to_api
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 31 13:11:20 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 31 Jan 2020 12:11:20 +0000
Subject: [Koha-bugs] [Bug 24554] Only embed relations from Koha::Biblio in
 to_api
In-Reply-To: <bug-24554-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24554-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24554-70-jp7U0587Wz@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24554

--- Comment #1 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 98225
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98225&action=edit
Bug 24554: Only embed relations from Koha::Biblio in to_api

This patch simplifies the behaviour of Koha::Biblio->to_api. It was
designed with the idea of handling possible methods that would be added
to Koha::Biblioitem. But it had a weird fallback behaviour was
highlighted by using it with bug 24528.

On fixing it it become obvious that it was unnessessarily complex and
that it was not worth. That's the reason there wasn't any test for it,
as Koha::Biblioitem doesn't implement any extra methods.

To test:
1. Run:
   $ kshell
  k$ prove t/db_dependent/Koha/Biblio.t
=> SUCCESS: Tests pass
2. Apply this patch
3. Repeat (1)
=> SUCCESS: Tests pass!
4. Sign off :-D

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 31 13:21:18 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 31 Jan 2020 12:21:18 +0000
Subject: [Koha-bugs] [Bug 20212] Slowness in Receiving in Acquisitions
In-Reply-To: <bug-20212-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20212-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20212-70-oD9bporLrc@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20212

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #97635|0                           |1
        is obsolete|                            |
  Attachment #97745|0                           |1
        is obsolete|                            |

--- Comment #18 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 98226
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98226&action=edit
Bug 20212: Use the API to render orders

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 31 13:31:22 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 31 Jan 2020 12:31:22 +0000
Subject: [Koha-bugs] [Bug 21901] Foreign keys are missing on the serials and
 subscriptions tables
In-Reply-To: <bug-21901-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21901-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21901-70-hcXyvgQQrE@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21901

--- Comment #11 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
I tested on 4 large clones of production Databases.. none of them failed in the
way you are suggesting.. but it may not be a terrible idea to add a line for
each foreign key addition to 'clean' the bad data.

I did find that in a fair few cases that malformed date fields would crash the
update... I'm not sure whether to fold in a check and clean for such fields
into this patch or open another bug to be honest.. I think I'm inclined to fold
it in here to ensure the DB update will actually run.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 31 13:34:56 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 31 Jan 2020 12:34:56 +0000
Subject: [Koha-bugs] [Bug 21357] Filter elisions from index and search terms
 in Elasticsearch
In-Reply-To: <bug-21357-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21357-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21357-70-T87mon5nW0@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21357

--- Comment #42 from Ere Maijala <ere.maijala at helsinki.fi> ---
At least with MARC 21 that's the language of the catalogued item, not the
language of the metadata record, right? We've been through this with our
discovery interface and had to give up trying to guess the language.
Additionally, a record can contain metadata fields in multiple languages.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 31 13:35:03 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 31 Jan 2020 12:35:03 +0000
Subject: [Koha-bugs] [Bug 24546] Club/Hold.t has a wrong call to
 build_sample_item
In-Reply-To: <bug-24546-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24546-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24546-70-OkLmnJ5KVP@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24546

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |tomascohen at gmail.com
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 31 13:35:05 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 31 Jan 2020 12:35:05 +0000
Subject: [Koha-bugs] [Bug 24546] Club/Hold.t has a wrong call to
 build_sample_item
In-Reply-To: <bug-24546-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24546-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24546-70-i9JaJEvvvb@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24546

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #98216|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 31 13:35:25 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 31 Jan 2020 12:35:25 +0000
Subject: [Koha-bugs] [Bug 24546] Club/Hold.t has a wrong call to
 build_sample_item
In-Reply-To: <bug-24546-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24546-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24546-70-55STSHQrDs@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24546

--- Comment #4 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 98227
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98227&action=edit
Bug 24546: Fix intentions of build_sample_item in Club/Hold.t

In t/db_dependent/Koha/Club/Hold.t:
my $item1 = $builder->build_sample_item({ branchcode => $library->branchcode
});
my $item2 = $builder->build_sample_item({ branchcode => $library->branchcode
});

build_sample_item takes either "library" or the item's attributes.
branchcode is not part of the item's table, so what those 2 lines are trying to
acchieve is wrong.

Test plan:
 % prove t/db_dependent/Koha/Club/Hold.t
must return green before and after this patch

Note that this patch also remove an uneeded debugging statement.

This has been caught by bug 24363.

Signed-off-by: David Nind <david at davidnind.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 31 13:56:10 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 31 Jan 2020 12:56:10 +0000
Subject: [Koha-bugs] [Bug 24554] Only embed relations from Koha::Biblio in
 to_api
In-Reply-To: <bug-24554-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24554-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24554-70-89T7O7obQV@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24554

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Patch complexity|---                         |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 31 13:57:39 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 31 Jan 2020 12:57:39 +0000
Subject: [Koha-bugs] [Bug 24454] currency formatting from JS
In-Reply-To: <bug-24454-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24454-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24454-70-Dj3AuofM04@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24454

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|20212                       |
             Blocks|                            |20212


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20212
[Bug 20212] Slowness in Receiving in Acquisitions
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 31 13:57:39 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 31 Jan 2020 12:57:39 +0000
Subject: [Koha-bugs] [Bug 20212] Slowness in Receiving in Acquisitions
In-Reply-To: <bug-20212-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20212-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20212-70-PjQTtGNd0L@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20212

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|24454                       |
         Depends on|                            |24454


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24454
[Bug 24454] currency formatting from JS
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 31 14:07:42 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 31 Jan 2020 13:07:42 +0000
Subject: [Koha-bugs] [Bug 21357] Filter elisions from index and search terms
 in Elasticsearch
In-Reply-To: <bug-21357-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21357-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21357-70-rIlXtJXEJQ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21357

--- Comment #43 from Nick Clemens <nick at bywatersolutions.com> ---
(In reply to Ere Maijala from comment #42)
> At least with MARC 21 that's the language of the catalogued item, not the
> language of the metadata record, right? We've been through this with our
> discovery interface and had to give up trying to guess the language.
> Additionally, a record can contain metadata fields in multiple languages.

True, but for at least certain fields like 'title' shouldn't the language
match? i.e. the french version should have the french title and the english
version the english title?

Maybe the problem here is 'MARC is bad' :-)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 31 14:16:26 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 31 Jan 2020 13:16:26 +0000
Subject: [Koha-bugs] [Bug 24454] currency formatting from JS
In-Reply-To: <bug-24454-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24454-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24454-70-5uELiZ6A61@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24454

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #97573|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 31 14:16:46 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 31 Jan 2020 13:16:46 +0000
Subject: [Koha-bugs] [Bug 24454] currency formatting from JS
In-Reply-To: <bug-24454-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24454-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24454-70-KEeW4yAyOB@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24454

--- Comment #5 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 98228
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98228&action=edit
Bug 24454: Add Currencies.pm template plugin and currency.inc files

This patch adds a new TT plugin called Currencies which retrieves information
about the active currency.

It also adds a currency.inc file in both opac and intranet, which if included
in your TT, you will have the $currency function available in JS.

The $currency function formats numbers into the configured active currency
format.

For example:

$currency(12322.4532) //Returns '$12,322.45' if currency format is 'US' and
active currency has '$' symbol and no space separation.

To test you must implement and test bug 20212, where it will be used

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 31 14:22:34 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 31 Jan 2020 13:22:34 +0000
Subject: [Koha-bugs] [Bug 21901] Foreign keys are missing on the serials and
 subscriptions tables
In-Reply-To: <bug-21901-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21901-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21901-70-5PN1P7PQGO@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21901

--- Comment #12 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 98229
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98229&action=edit
Bug 21901: (QA follow-up) Ensure consistent data before adding keys

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 31 14:22:52 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 31 Jan 2020 13:22:52 +0000
Subject: [Koha-bugs] [Bug 24454] currency formatting from JS
In-Reply-To: <bug-24454-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24454-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24454-70-0e5pIyw3MF@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24454

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

--- Comment #6 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
I added my signature, but keeping the NSO, but I have to say: this is awesome
Agustín! I left it for the last step in my dev (bug 20212) and cought me by
surprise: it is so elegant :-D

Jonathan: take a look at the latest WIP patch in bug 20212 to see how to use
it!

Agustín: I think we should be able to specify if we want the currency symbol.
In my use case the original table doesn't show it. But if we mixed currencies,
it would be great being able to choose which one to use, not just the active.
So default: active, but have the option to pass a currency id.

I know we need a third party signature.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 31 14:23:55 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 31 Jan 2020 13:23:55 +0000
Subject: [Koha-bugs] [Bug 20212] Slowness in Receiving in Acquisitions
In-Reply-To: <bug-20212-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20212-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20212-70-spHklad9IO@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20212

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #98226|0                           |1
        is obsolete|                            |

--- Comment #19 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 98230
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98230&action=edit
[WIP] Bug 20212: Use the API to render orders

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 31 14:24:22 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 31 Jan 2020 13:24:22 +0000
Subject: [Koha-bugs] [Bug 21901] Foreign keys are missing on the serials and
 subscriptions tables
In-Reply-To: <bug-21901-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21901-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21901-70-3kUKg8rXkh@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21901

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #98229|0                           |1
        is obsolete|                            |

--- Comment #13 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 98231
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98231&action=edit
Bug 21901: (QA follow-up) Ensure consistent data before adding keys

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 31 14:25:26 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 31 Jan 2020 13:25:26 +0000
Subject: [Koha-bugs] [Bug 21901] Foreign keys are missing on the serials and
 subscriptions tables
In-Reply-To: <bug-21901-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21901-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21901-70-jeIa0M04GG@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21901

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Signed Off

--- Comment #14 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Run against a series of large databases.. adding the additional security of the
followup did not result in any discernible performance degradation of the
update so I think it's a worthwhile addition.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 31 14:40:37 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 31 Jan 2020 13:40:37 +0000
Subject: [Koha-bugs] [Bug 24482] Purchase Items broken by costs containing a
 comma
In-Reply-To: <bug-24482-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24482-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24482-70-J8LfT1OIsr@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24482

--- Comment #9 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Bug 24540 opened for the weird enter behaviour.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 31 14:44:41 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 31 Jan 2020 13:44:41 +0000
Subject: [Koha-bugs] [Bug 24545] Replace Franklin Street by gnu.org/licenses
 in copyright
In-Reply-To: <bug-24545-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24545-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24545-70-KVNuFwiIIa@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24545

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |9978


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9978
[Bug 9978] Update GNU licenses header in Koha files from GPL2 to GPL3
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 31 14:44:41 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 31 Jan 2020 13:44:41 +0000
Subject: [Koha-bugs] [Bug 9978] Update GNU licenses header in Koha files
 from GPL2 to GPL3
In-Reply-To: <bug-9978-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-9978-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9978-70-7L9VPZVrou@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9978

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |24545


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24545
[Bug 24545] Replace Franklin Street by gnu.org/licenses in copyright
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 31 14:48:04 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 31 Jan 2020 13:48:04 +0000
Subject: [Koha-bugs] [Bug 24545] Replace Franklin Street by gnu.org/licenses
 in copyright
In-Reply-To: <bug-24545-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24545-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24545-70-dRRhijeuF7@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24545

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 31 14:48:08 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 31 Jan 2020 13:48:08 +0000
Subject: [Koha-bugs] [Bug 24545] Replace Franklin Street by gnu.org/licenses
 in copyright
In-Reply-To: <bug-24545-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24545-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24545-70-a5DA2m2fiB@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24545

--- Comment #2 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 98232
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98232&action=edit
Bug 24545: Fix license statements

Bug 9978 should have fixed them all, but some were missing.
We want all the license statements part of Koha to be identical, and
using the GPLv3 statement.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 31 14:48:11 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 31 Jan 2020 13:48:11 +0000
Subject: [Koha-bugs] [Bug 24545] Replace Franklin Street by gnu.org/licenses
 in copyright
In-Reply-To: <bug-24545-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24545-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24545-70-35P6cxBaW9@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24545

--- Comment #3 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 98233
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98233&action=edit
Bug 24545: Fix find-license-problems.t to catch future wrong license statements

File adjust to run tests and be executed on all our codebase.

Test plan:
- Apply this patch without the other one
- run the tests
=> Several failures
- apply the other patch
- run the tests
=> Should pass now

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 31 14:48:40 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 31 Jan 2020 13:48:40 +0000
Subject: [Koha-bugs] [Bug 24545] Replace Franklin Street by gnu.org/licenses
 in copyright
In-Reply-To: <bug-24545-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24545-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24545-70-Ndp9Lgwl66@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24545

--- Comment #4 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
(In reply to Marcel de Rooy from comment #1)
> Could you add Franklin Street into qa tools to stop new ones, Jonathan?

We could, please open a new issue on the project's bug tracker.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 31 14:50:21 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 31 Jan 2020 13:50:21 +0000
Subject: [Koha-bugs] [Bug 21901] Foreign keys are missing on the serials and
 subscriptions tables
In-Reply-To: <bug-21901-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21901-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21901-70-US4AO6P0z5@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21901

--- Comment #15 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
As I said this morning on #koha, I do not think we should silently delete those
rows.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 31 14:51:23 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 31 Jan 2020 13:51:23 +0000
Subject: [Koha-bugs] [Bug 24467] *_count methods should be avoided
In-Reply-To: <bug-24467-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24467-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24467-70-1XNFBTvNzT@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24467

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to master
         Version(s)|                            |20.05.00
        released in|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 31 14:51:25 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 31 Jan 2020 13:51:25 +0000
Subject: [Koha-bugs] [Bug 24467] *_count methods should be avoided
In-Reply-To: <bug-24467-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24467-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24467-70-5fYqLdpkK6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24467

--- Comment #10 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Nice work everyone!

Pushed to master for 20.05

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 31 14:51:27 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 31 Jan 2020 13:51:27 +0000
Subject: [Koha-bugs] [Bug 24523] Fix opac-password-recovery markup mistake
In-Reply-To: <bug-24523-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24523-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24523-70-uzYyKX0VG3@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24523

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to master
         Version(s)|                            |20.05.00
        released in|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 31 14:51:28 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 31 Jan 2020 13:51:28 +0000
Subject: [Koha-bugs] [Bug 24523] Fix opac-password-recovery markup mistake
In-Reply-To: <bug-24523-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24523-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24523-70-z7lmTJtSKj@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24523

--- Comment #5 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Nice work everyone!

Pushed to master for 20.05

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 31 14:51:30 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 31 Jan 2020 13:51:30 +0000
Subject: [Koha-bugs] [Bug 24528] Add a syntax for specifying counts on
 x-koha-embed
In-Reply-To: <bug-24528-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24528-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24528-70-uYkdvlZGUa@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24528

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|                            |20.05.00
        released in|                            |
             Status|Passed QA                   |Pushed to master

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 31 14:51:32 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 31 Jan 2020 13:51:32 +0000
Subject: [Koha-bugs] [Bug 24528] Add a syntax for specifying counts on
 x-koha-embed
In-Reply-To: <bug-24528-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24528-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24528-70-8yKesA1b2G@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24528

--- Comment #15 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Nice work everyone!

Pushed to master for 20.05

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 31 14:56:15 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 31 Jan 2020 13:56:15 +0000
Subject: [Koha-bugs] [Bug 24213] Koha::Object->get_from_storage should
 return undef if the object has been deleted
In-Reply-To: <bug-24213-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24213-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24213-70-OBsufJitid@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24213

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Version(s)|                            |20.05.00
        released in|                            |
             Status|Passed QA                   |Pushed to master

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 31 14:56:17 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 31 Jan 2020 13:56:17 +0000
Subject: [Koha-bugs] [Bug 24213] Koha::Object->get_from_storage should
 return undef if the object has been deleted
In-Reply-To: <bug-24213-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24213-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24213-70-cPQ78zwei6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24213

--- Comment #12 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Nice work everyone!

Pushed to master for 20.05

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 31 14:56:19 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 31 Jan 2020 13:56:19 +0000
Subject: [Koha-bugs] [Bug 24546] Club/Hold.t has a wrong call to
 build_sample_item
In-Reply-To: <bug-24546-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24546-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24546-70-zdjMLx3AyY@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24546

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to master
         Version(s)|                            |20.05.00
        released in|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 31 14:56:21 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 31 Jan 2020 13:56:21 +0000
Subject: [Koha-bugs] [Bug 24546] Club/Hold.t has a wrong call to
 build_sample_item
In-Reply-To: <bug-24546-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24546-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24546-70-kSYh3kkZDR@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24546

--- Comment #5 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Nice work everyone!

Pushed to master for 20.05

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 31 14:58:52 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 31 Jan 2020 13:58:52 +0000
Subject: [Koha-bugs] [Bug 24528] Add a syntax for specifying counts on
 x-koha-embed
In-Reply-To: <bug-24528-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24528-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24528-70-pYPk7q2cbO@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24528

--- Comment #16 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
(In reply to Tomás Cohen Arazi from comment #14)
> (In reply to Jonathan Druart from comment #13)
> > +            if ( $embed =~ m/^(?<relation>.*)_count$/
> > 
> > and
> > 
> > +        if ( $curr =~ m/^(?<relation>.*)\+count/ ) {
> > +            my $key = $+{relation} . "_count";
> > 
> > Why did not you keep "relation+count"?
> 
> Inertia. Coding at 2 am. I agree with keeping the +.

We decided to keep with the snake_case syntax as using + would (1) not follow
the API naming conventions, and (2) it would become problematic to access the
hash elements i.e.  order.biblio+count means concatenating order.biblio and
count.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 31 15:02:46 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 31 Jan 2020 14:02:46 +0000
Subject: [Koha-bugs] [Bug 24440] Add ->current_holds to
 Koha::Acquisition::Order
In-Reply-To: <bug-24440-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24440-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24440-70-99itnne8uW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24440

--- Comment #17 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
-    my $biblio_rs= $self->_result->biblionumber;
+    my $biblio_rs= $self->_result->biblio;
+    return unless $biblio_rs;

You are not testing that. It looks correct but I think it deserves its own bug
report (bug fix, could be backported).

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 31 15:04:35 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 31 Jan 2020 14:04:35 +0000
Subject: [Koha-bugs] [Bug 24440] Add ->current_holds to
 Koha::Acquisition::Order
In-Reply-To: <bug-24440-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24440-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24440-70-ZuiK0L380M@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24440

--- Comment #18 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
(In reply to Jonathan Druart from comment #17)
> -    my $biblio_rs= $self->_result->biblionumber;
> +    my $biblio_rs= $self->_result->biblio;
> +    return unless $biblio_rs;
> 
> You are not testing that. It looks correct but I think it deserves its own
> bug report (bug fix, could be backported).

There is a test!

 73     is( $order->biblio, undef, 'If no linked biblio, undef is returned' );

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 31 15:09:07 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 31 Jan 2020 14:09:07 +0000
Subject: [Koha-bugs] [Bug 20352] Add ability of currency/price to have a
 symbol after amount
In-Reply-To: <bug-20352-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20352-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20352-70-UyxdLbwoog@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20352

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #96410|0                           |1
        is obsolete|                            |

--- Comment #6 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 98234
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98234&action=edit
Bug 20352: DB changes

Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 31 15:09:10 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 31 Jan 2020 14:09:10 +0000
Subject: [Koha-bugs] [Bug 20352] Add ability of currency/price to have a
 symbol after amount
In-Reply-To: <bug-20352-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20352-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20352-70-jkyr82dr0b@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20352

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #96411|0                           |1
        is obsolete|                            |

--- Comment #7 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 98235
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98235&action=edit
Bug 20352: Schema changes

Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 31 15:09:14 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 31 Jan 2020 14:09:14 +0000
Subject: [Koha-bugs] [Bug 20352] Add ability of currency/price to have a
 symbol after amount
In-Reply-To: <bug-20352-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20352-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20352-70-5ZDSkcDLrO@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20352

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #96412|0                           |1
        is obsolete|                            |

--- Comment #8 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 98236
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98236&action=edit
Bug 20352: Add the ability to chose the position of the currency

This patch mimicks what has been done for p_sep_by_space to add a space
separation between the symbol and the value.
Here we are adding p_cs_precedes to display the symbol before or after
the value.
Note that so far the symbol is only displayed in one place at the OPAC
(opac-main)

Test plan:
- Create a manual invoice for a patron
- Edit the active currency, select 'Before' (should be the default here)
- Use the charged patron to login at the OPAC
=> On the mainpage you should see the charges displayed, with the symbol
before the value
- Edit the active currency, select 'After'
=> The symbol is now positionned after the value

QA note:
>From https://www.gnu.org/software/libc/manual/html_node/Currency-Symbol.html
p_cs_precedes is only used for positive amount, n_cs_precedes should be
used for negative. Here we are assuming that positive and negative
amounts are displayed the same way.

Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 31 15:09:44 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 31 Jan 2020 14:09:44 +0000
Subject: [Koha-bugs] [Bug 20352] Add ability of currency/price to have a
 symbol after amount
In-Reply-To: <bug-20352-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20352-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20352-70-1pJO2quPF2@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20352

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |martin.renvoize at ptfs-europe
                   |                            |.com
             Status|Needs Signoff               |Signed Off

--- Comment #9 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Works nicely, Signing off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 31 15:10:22 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 31 Jan 2020 14:10:22 +0000
Subject: [Koha-bugs] [Bug 24440] Add ->current_holds to
 Koha::Acquisition::Order
In-Reply-To: <bug-24440-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24440-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24440-70-jEdqAYyLga@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24440

--- Comment #19 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 98237
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98237&action=edit
Bug 24440: Adding 2 more tests for ->biblio

Not directly related to the other changes but seems good to have them
here.

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 31 15:11:50 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 31 Jan 2020 14:11:50 +0000
Subject: [Koha-bugs] [Bug 24440] Add ->current_holds to
 Koha::Acquisition::Order
In-Reply-To: <bug-24440-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24440-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24440-70-NKRdkjHViG@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24440

--- Comment #20 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Tomas, I am still not sure.
->current_holds will actually return the item-level hold only.
Maybe it should be item_holds or current_item_level_holds, or...?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 31 15:18:10 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 31 Jan 2020 14:18:10 +0000
Subject: [Koha-bugs] [Bug 20352] Add ability of currency/price to have a
 symbol after amount
In-Reply-To: <bug-20352-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20352-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20352-70-CtBM4KDQ4K@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20352

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |release-notes-needed,
                   |                            |rel_20_05_target

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 31 15:18:45 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 31 Jan 2020 14:18:45 +0000
Subject: [Koha-bugs] [Bug 23974] hours_between and days_between lack tests
In-Reply-To: <bug-23974-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23974-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23974-70-SY55bkoLAW@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23974

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|rel_20_05_target            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 31 15:18:54 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 31 Jan 2020 14:18:54 +0000
Subject: [Koha-bugs] [Bug 18355] Add 'permanent location' alongside
 'shelving location' when located on cart
In-Reply-To: <bug-18355-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18355-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18355-70-Kc91gzhSD2@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18355

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|rel_20_05_target            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 31 15:26:47 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 31 Jan 2020 14:26:47 +0000
Subject: [Koha-bugs] [Bug 24094] Authority punctuation mismatch prevents
 linking to correct records
In-Reply-To: <bug-24094-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24094-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24094-70-NkLmbAXOXE@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24094

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 31 15:26:50 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 31 Jan 2020 14:26:50 +0000
Subject: [Koha-bugs] [Bug 24094] Authority punctuation mismatch prevents
 linking to correct records
In-Reply-To: <bug-24094-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24094-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24094-70-adQDIM7NK5@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24094

--- Comment #3 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 98238
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98238&action=edit
Bug 24094: Unit tests

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 31 15:26:52 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 31 Jan 2020 14:26:52 +0000
Subject: [Koha-bugs] [Bug 24094] Authority punctuation mismatch prevents
 linking to correct records
In-Reply-To: <bug-24094-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24094-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24094-70-4deuCUJOGi@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24094

--- Comment #4 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 98239
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98239&action=edit
Bug 24094: Strip trailing spaces and punctuation from authority headings

Both when searching for and creating new authorities we need to remove
punctuation that exists in the bibliographic record but does not belong in
the authority record.

For example, a series with a volume contains a semicolon in the bib record,
however, this should not be passed to the authority as the volume is not
included in the authority record.

To test:
 1 - Set AutoCreateAuthorities to 'generate'
 2 - Set BiblioAddsAuthorities to 'true'
 3 - Set CatalogModuleRelink to 'Do'
 4 - Find or create a record with:
    a 100 field with a subfield e preceded by a comma: 100 $aBoring, M. Eugene
M ,$e author
    an 830 field with a volume preceded by a semicolon: 650$aLord of the rings
;$v 3.
 5 - Save the records and check the links
 6 - Note punctuation is passed through
 7 - Save again, auth records are created again
 8 - Apply patch
 9 - Save again, new auth records are created again
10 - Check the records, punctuation has been removed
11 - Save again, no more records created.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 31 15:29:05 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 31 Jan 2020 14:29:05 +0000
Subject: [Koha-bugs] [Bug 22784] Archiving Purchase Suggestions
In-Reply-To: <bug-22784-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-22784-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-22784-70-gn5UFc0s1r@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22784

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |rel_20_05_target
                 CC|                            |martin.renvoize at ptfs-europe
                   |                            |.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 31 15:30:26 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 31 Jan 2020 14:30:26 +0000
Subject: [Koha-bugs] [Bug 23590] Allow to modify the manager of a suggestion
In-Reply-To: <bug-23590-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23590-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23590-70-6TKzRLk7fg@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23590

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |rel_20_05_target
                 CC|                            |martin.renvoize at ptfs-europe
                   |                            |.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 31 15:42:14 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 31 Jan 2020 14:42:14 +0000
Subject: [Koha-bugs] [Bug 23590] Allow to modify the manager of a suggestion
In-Reply-To: <bug-23590-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23590-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23590-70-yd9nCz2Ak4@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23590

--- Comment #65 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Created attachment 98240
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98240&action=edit
Bug 23590: (QA follow-up) Add missing filters and drop script type

Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 31 15:42:28 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 31 Jan 2020 14:42:28 +0000
Subject: [Koha-bugs] [Bug 24454] currency formatting from JS
In-Reply-To: <bug-24454-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24454-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24454-70-lbcDfxK0eT@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24454

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |RESOLVED
         Resolution|---                         |DUPLICATE

--- Comment #7 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Jonathan, I belive we would be good with just using format_price. We overlooked
it in the codebase. You mention it should do things different (using
Koha::Number::Price) does that imply some work is needed on it? Regarding the
currency symbol we can go without it, and add it later if required. The symbol
is not used in the table I'm wokring on (pending orders).

Closing this, bug if you say we can just use your method.

*** This bug has been marked as a duplicate of bug 12987 ***

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 31 15:42:28 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 31 Jan 2020 14:42:28 +0000
Subject: [Koha-bugs] [Bug 12987] Update table footer with the visible rows
In-Reply-To: <bug-12987-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-12987-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-12987-70-6cfTABcd0M@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12987

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |agustinmoyano at theke.io

--- Comment #16 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
*** Bug 24454 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 31 15:42:29 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 31 Jan 2020 14:42:29 +0000
Subject: [Koha-bugs] [Bug 20212] Slowness in Receiving in Acquisitions
In-Reply-To: <bug-20212-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20212-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20212-70-ppXtXXqDZK@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20212
Bug 20212 depends on bug 24454, which changed state.

Bug 24454 Summary: currency formatting from JS
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24454

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |RESOLVED
         Resolution|---                         |DUPLICATE

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 31 15:42:42 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 31 Jan 2020 14:42:42 +0000
Subject: [Koha-bugs] [Bug 21357] Filter elisions from index and search terms
 in Elasticsearch
In-Reply-To: <bug-21357-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21357-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21357-70-q85BQc8nn8@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21357

--- Comment #44 from Nicolas Legrand <nicolas.legrand at bulac.fr> ---
Julian, for non latin scripts we are doing a latin transliteration and so are
suppose to do all the ABES partners in France. Look at 

https://catalogue.bulac.fr/cgi-bin/koha/opac-detail.pl?biblionumber=976426
http://www.sudoc.fr/18117295X

If I check the language here, it's Hebrew. I've got a 200$a with a Hebrew title
in hebrew and another one with a Hebrew title in Latin alphabet.

To know what to do, I have to look at 200$6 and 200$7 which are ABES non
standard ways to describe non latin scripts (I like to think we are not using
UNIMARC but ABESMARC).

http://documentation.abes.fr/sudoc/regles/Catalogage/Regles_Multiecritures.htm#Ss-zones$6$7

Voilà. Don't know what to think yet, but now you know.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 31 15:43:12 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 31 Jan 2020 14:43:12 +0000
Subject: [Koha-bugs] [Bug 23590] Allow to modify the manager of a suggestion
In-Reply-To: <bug-23590-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23590-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23590-70-eHG7phaFPg@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23590

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         QA Contact|testopia at bugs.koha-communit |katrin.fischer at bsz-bw.de
                   |y.org                       |

--- Comment #66 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Looks like Katrin is on the case here.. so just uploading a followup to silence
the warning from the QA scripts and leaving Katrin to finish :)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 31 15:45:43 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 31 Jan 2020 14:45:43 +0000
Subject: [Koha-bugs] [Bug 20212] Slowness in Receiving in Acquisitions
In-Reply-To: <bug-20212-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20212-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20212-70-Q4Lc7BdF4Q@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20212

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #98230|0                           |1
        is obsolete|                            |

--- Comment #20 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 98241
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98241&action=edit
[WIP] Bug 20212: Use the API to render orders

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 31 15:46:08 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 31 Jan 2020 14:46:08 +0000
Subject: [Koha-bugs] [Bug 24454] currency formatting from JS
In-Reply-To: <bug-24454-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24454-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24454-70-T7RurjBrZy@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24454

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|20212                       |


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20212
[Bug 20212] Slowness in Receiving in Acquisitions
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 31 15:46:08 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 31 Jan 2020 14:46:08 +0000
Subject: [Koha-bugs] [Bug 20212] Slowness in Receiving in Acquisitions
In-Reply-To: <bug-20212-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20212-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20212-70-QKZwUC7JiS@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20212

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|24454                       |


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24454
[Bug 24454] currency formatting from JS
-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 31 15:46:45 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 31 Jan 2020 14:46:45 +0000
Subject: [Koha-bugs] [Bug 24455] date formatting from JS
In-Reply-To: <bug-24455-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24455-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24455-70-7vQ9ZGrgJQ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24455

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 31 15:50:06 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 31 Jan 2020 14:50:06 +0000
Subject: [Koha-bugs] [Bug 24440] Add ->current_holds to
 Koha::Acquisition::Order
In-Reply-To: <bug-24440-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24440-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24440-70-uunZzol1z5@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24440

--- Comment #21 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
(In reply to Jonathan Druart from comment #20)
> Tomas, I am still not sure.
> ->current_holds will actually return the item-level hold only.
> Maybe it should be item_holds or current_item_level_holds, or...?

I agree with renaming it. I like current_item_level_holds.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 31 16:05:00 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 31 Jan 2020 15:05:00 +0000
Subject: [Koha-bugs] [Bug 24440] Add ->current_holds to
 Koha::Acquisition::Order
In-Reply-To: <bug-24440-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24440-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24440-70-akFSWmZ0tH@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24440

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         QA Contact|testopia at bugs.koha-communit |jonathan.druart at bugs.koha-c
                   |y.org                       |ommunity.org

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 31 16:25:41 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 31 Jan 2020 15:25:41 +0000
Subject: [Koha-bugs] [Bug 18936] Convert issuingrules fields to
 circulation_rules
In-Reply-To: <bug-18936-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18936-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18936-70-yjf7Eve5wZ@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18936

--- Comment #102 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Minor:
Koha::CirculationRule ->item_type, ->library and ->patron_category must use the
DBIC RS

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 31 16:26:56 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 31 Jan 2020 15:26:56 +0000
Subject: [Koha-bugs] [Bug 24449] SIP2 - too_many_overdue flag is not
 implemented
In-Reply-To: <bug-24449-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24449-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24449-70-6DNe7kRBaD@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24449

Christopher Brannon <cbrannon at cdalibrary.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |cbrannon at cdalibrary.org

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 31 16:29:43 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 31 Jan 2020 15:29:43 +0000
Subject: [Koha-bugs] [Bug 18936] Convert issuingrules fields to
 circulation_rules
In-Reply-To: <bug-18936-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18936-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18936-70-cgZexyJ3L4@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18936

--- Comment #103 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
(In reply to Joonas Kylmälä from comment #101)
> The qa-koha.pl tool detected an issue with constant being redefined:
> 
> > FAIL   Koha/CirculationRules.pm              
> >   FAIL   valid                  
> >                Constant subroutine >Koha::CirculationRules::GUESSED_ITEMTYPES_KEY redefined
> 
> This appears to be from circular dependency:
> 
> Koha/CirculationRules.pm -> Koha/CirculationRule.pm -> Koha/ItemTypes.pm ->
> Koha/ItemType.pm -> Koha/CirculationRules.pm
> 
> if someone has the time to remove the circularity here would be great!

I would not care much about that.
Note that the QA script is ignoring the "subroutine ... redefined" warning.
Here it displays "Constant subroutine ... redefined" and that is why it's not
ignored.

The circular dependency already existed:
% git checkout master
% perl -wc Koha/CirculationRules.pm 
Subroutine get_effective_rule redefined at Koha/CirculationRules.pm line 42.
Subroutine set_rule redefined at Koha/CirculationRules.pm line 82.
Subroutine set_rules redefined at Koha/CirculationRules.pm line 140.
Subroutine delete redefined at Koha/CirculationRules.pm line 171.
Subroutine _type redefined at Koha/CirculationRules.pm line 184.
Subroutine object_class redefined at Koha/CirculationRules.pm line 192.
Koha/CirculationRules.pm syntax OK

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 31 16:50:40 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 31 Jan 2020 15:50:40 +0000
Subject: [Koha-bugs] [Bug 18936] Convert issuingrules fields to
 circulation_rules
In-Reply-To: <bug-18936-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-18936-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-18936-70-zf9XF6B0Fp@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18936

--- Comment #104 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
I've given this a look over myself now and am pretty happy.. as soon as we have
your stamp of approval Joonas we'll go for it! :)

Well done guys!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 31 17:00:03 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 31 Jan 2020 16:00:03 +0000
Subject: [Koha-bugs] [Bug 15508] Select which library a staff user can login
 as
In-Reply-To: <bug-15508-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-15508-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-15508-70-4rfJDYQTTL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15508

Andrew Fuerste-Henry <andrew at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |DUPLICATE
             Status|NEW                         |RESOLVED
                 CC|                            |andrew at bywatersolutions.com

--- Comment #2 from Andrew Fuerste-Henry <andrew at bywatersolutions.com> ---


*** This bug has been marked as a duplicate of bug 11420 ***

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 31 17:00:03 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 31 Jan 2020 16:00:03 +0000
Subject: [Koha-bugs] [Bug 11420] Patron preference to restrict staff from
 changing location
In-Reply-To: <bug-11420-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-11420-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11420-70-3MAlyth5zi@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11420

Andrew Fuerste-Henry <andrew at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |cbrannon at cdalibrary.org

--- Comment #2 from Andrew Fuerste-Henry <andrew at bywatersolutions.com> ---
*** Bug 15508 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 31 17:00:30 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 31 Jan 2020 16:00:30 +0000
Subject: [Koha-bugs] [Bug 11420] Patron preference to restrict staff from
 changing location
In-Reply-To: <bug-11420-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-11420-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11420-70-Ik7NMZfqe1@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11420

Andrew Fuerste-Henry <andrew at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |andrew at bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 31 17:01:33 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 31 Jan 2020 16:01:33 +0000
Subject: [Koha-bugs] [Bug 24555] New: POC Elasticsearch - Use boolean
 queries instead of full text queries
Message-ID: <bug-24555-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24555

            Bug ID: 24555
           Summary: POC Elasticsearch - Use boolean queries instead of
                    full text queries
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Searching - Elasticsearch
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: alex.arnaud at biblibre.com

Here is a proof of concept for replacing current use of full text queries (with
query_string) by boolean queries on biblio searches.

Advantage:
    => No search craches with special character ( "!", ")" etc...)
    => Separate query context and filter context:
        - Search scores are not altered by facets,
        - Ability to use range filter  (i.e for publication date facet)

Also, this POC adds a button "ES query" in the search results header so you can
see the query sent to ES.

Code is not beautiful, there is no unit test, it's a POC.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 31 17:02:23 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 31 Jan 2020 16:02:23 +0000
Subject: [Koha-bugs] [Bug 11420] Patron preference to restrict staff from
 changing location
In-Reply-To: <bug-11420-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-11420-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11420-70-Q0W6hO4h4t@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11420

Donna <bwsdonna at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |bwsdonna at gmail.com

--- Comment #3 from Donna <bwsdonna at gmail.com> ---
This is still a concern for many libraries, would be a great enhancement in the
ongoing permissions fine tuning!

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 31 17:04:42 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 31 Jan 2020 16:04:42 +0000
Subject: [Koha-bugs] [Bug 24555] POC Elasticsearch - Use boolean queries
 instead of full text queries
In-Reply-To: <bug-24555-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24555-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24555-70-JX4iuCWTHK@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24555

--- Comment #1 from Alex Arnaud <alex.arnaud at biblibre.com> ---
Created attachment 98242
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98242&action=edit
Bug 24555: Replace query string with boolean query

Test plan:
 Just make simple and advanced searches

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 31 17:04:49 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 31 Jan 2020 16:04:49 +0000
Subject: [Koha-bugs] [Bug 24555] POC Elasticsearch - Use boolean queries
 instead of full text queries
In-Reply-To: <bug-24555-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24555-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24555-70-mSsdZRutp7@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24555

--- Comment #2 from Alex Arnaud <alex.arnaud at biblibre.com> ---
Created attachment 98243
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98243&action=edit
Bug 24555: add a button that shows ES query in search result

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 31 17:05:49 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 31 Jan 2020 16:05:49 +0000
Subject: [Koha-bugs] [Bug 24555] POC Elasticsearch - Use boolean queries
 instead of full text queries
In-Reply-To: <bug-24555-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24555-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24555-70-tcBNWkLbVL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24555

Alex Arnaud <alex.arnaud at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 31 17:26:30 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 31 Jan 2020 16:26:30 +0000
Subject: [Koha-bugs] [Bug 24553] Cancelling hold via SIP returns a failed
 response even when cancellation succeeds
In-Reply-To: <bug-24553-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24553-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24553-70-dKGf91q0Fe@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24553

AspenCat Team <aspencatteam at clicweb.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |aspencatteam at clicweb.org

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 31 17:30:11 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 31 Jan 2020 16:30:11 +0000
Subject: [Koha-bugs] [Bug 24296] Move stock rotation transfer triggers from
 `comments` to `reason`
In-Reply-To: <bug-24296-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24296-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24296-70-hpNVNF3JoA@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24296

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Move stock rotation         |Move stock rotation
                   |transfer triggers from      |transfer triggers from
                   |`comments` to `trigger`     |`comments` to `reason`

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 31 18:28:34 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 31 Jan 2020 17:28:34 +0000
Subject: [Koha-bugs] [Bug 24556] New: Option to toggle certain alerts on
 check in
Message-ID: <bug-24556-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24556

            Bug ID: 24556
           Summary: Option to toggle certain alerts on check in
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Circulation
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: cbrannon at cdalibrary.org
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com

It would be great if libraries had the option to show certain alerts or not. 
Some libraries do not need to see any/all of the 'Not Check Out' or 'Local Use
Recorded', or cart alerts.  It pulls their attention unnecessarily to the
alert.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 31 18:32:22 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 31 Jan 2020 17:32:22 +0000
Subject: [Koha-bugs] [Bug 24557] New: Cancel Hold on check in
Message-ID: <bug-24557-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24557

            Bug ID: 24557
           Summary: Cancel Hold on check in
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Hold requests
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: cbrannon at cdalibrary.org
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com

It would be great if there were another option next to the Cancel hold button
during check in like "Cancel and process next", which would be available if
there were other holds on the item, or the item needed to transfer back home. 
If neither are the case, the button would not appear.

Currently, we cancel holds by checking an item in, and using the Cancel hold
button.  Then, not know if there are any holds or if the item is being
transferred, we have to check it in again to see.  This second step could be
automated with a new conditional button.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 31 18:38:31 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 31 Jan 2020 17:38:31 +0000
Subject: [Koha-bugs] [Bug 24558] New: Catching old holds on check in
Message-ID: <bug-24558-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24558

            Bug ID: 24558
           Summary: Catching old holds on check in
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Hold requests
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: cbrannon at cdalibrary.org
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com

Many libraries have public hold shelves, where holds that are waiting are on a
publicly accessible shelf where patrons can pick them up and check them out.

Sometimes these libraries have patrons that 'mistakenly' pick up the hold and
'forget' to check them out.

These items are then returned and the library checks them in, not know the
previous status.  The same hold is triggered, and the hold goes back out on the
shelf.

While we print the expiration date of the hold on the slip, not all staff
notice the date.

I would propose that if an expired hold, or a hold with an expiration shorter
than that assigned to ReservesMaxPickUpDelay is checked in, a message or alert
displays, to alert staff that this is an old hold.  They would still have all
the usual options with that hold, but would be alerted to its old status.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 31 19:01:57 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 31 Jan 2020 18:01:57 +0000
Subject: [Koha-bugs] [Bug 11420] Patron preference to restrict staff from
 changing location
In-Reply-To: <bug-11420-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-11420-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-11420-70-DiCiZ5LnDG@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11420

--- Comment #4 from Christopher Brannon <cbrannon at cdalibrary.org> ---
(In reply to Galen Charlton from comment #1)
> I suggest a slightly broader way of looking at it.  The question isn't so
> much whether or not a staff member can change their active library at all,
> it's what libraries they're allowed to change to.
> 
> Currently, if IndependentBranches is OFF, a (non-superlibrarian) staff
> member is presumed to have their privileges at all libraries.  If
> IndependentBranches is ON, they're presumed to have their privileges only at
> their home library.
> 
> To allow for more fine-grained control, I propose the creation of a new
> table that would store the libraries that a given patron has privileges at
> (most likely this would apply only to staff users).  Initially, that list
> could be used to control what library or libraries the staff member can
> change to.  Another extension, though, would be to use it to control what
> libraries are available for various drop-down controls.

+1

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 31 19:30:01 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 31 Jan 2020 18:30:01 +0000
Subject: [Koha-bugs] [Bug 24559] New: Elasticsearch - add support for 'date'
 fields
Message-ID: <bug-24559-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24559

            Bug ID: 24559
           Summary: Elasticsearch - add support for 'date' fields
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: Searching - Elasticsearch
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: nick at bywatersolutions.com

There is a fixme in the code related to this. For dates like the 260c and 264c
we need a way to parse p2014 into 2014 etc. This affects sorting on dates

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 31 21:04:16 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 31 Jan 2020 20:04:16 +0000
Subject: [Koha-bugs] [Bug 20022] use Modern::Perl in t (test) perl scripts
In-Reply-To: <bug-20022-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-20022-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-20022-70-wSbu1v0KJ2@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20022

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Patch doesn't apply
                 CC|                            |david at davidnind.com

--- Comment #5 from David Nind <david at davidnind.com> ---
Patch no longer applies.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 31 21:24:58 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 31 Jan 2020 20:24:58 +0000
Subject: [Koha-bugs] [Bug 21357] Filter elisions from index and search terms
 in Elasticsearch
In-Reply-To: <bug-21357-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21357-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21357-70-ZgGbq0Wu53@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21357

Michal Denar <black23 at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 31 21:25:01 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 31 Jan 2020 20:25:01 +0000
Subject: [Koha-bugs] [Bug 21357] Filter elisions from index and search terms
 in Elasticsearch
In-Reply-To: <bug-21357-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21357-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21357-70-lkSritv3LY@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21357

Michal Denar <black23 at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #87901|0                           |1
        is obsolete|                            |
  Attachment #90191|0                           |1
        is obsolete|                            |
  Attachment #98169|0                           |1
        is obsolete|                            |

--- Comment #45 from Michal Denar <black23 at gmail.com> ---
Created attachment 98244
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98244&action=edit
Bug 21357: Add elision filtering to default ES index config

To test:

1. Rebuild Elasticsearch index with the new config
2. Add a record with "l'avion" in the title
3. Verify that the record can be found with both "l'avion" and "avion"

Signed-off-by: Séverine QUEUNE <severine.queune at bulac.fr>
Signed-off-by: Björn Nylén <bjorn.nylen at ub.lu.se>

Signed-off-by: Michal Denar <black23 at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 31 21:25:06 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 31 Jan 2020 20:25:06 +0000
Subject: [Koha-bugs] [Bug 21357] Filter elisions from index and search terms
 in Elasticsearch
In-Reply-To: <bug-21357-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21357-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21357-70-uDWxSLy16K@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21357

--- Comment #46 from Michal Denar <black23 at gmail.com> ---
Created attachment 98245
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98245&action=edit
Bug 21357: Case-insensive articles to the elision filter

Test with :
GET index/_analyze
{
  "filter": ["elision"],
  "text": "qu'ils"
}

With different cases :
QU'ILS
Qu'ils
qu'ils
qU'ILS

Signed-off-by: Michal Denar <black23 at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 31 21:25:11 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 31 Jan 2020 20:25:11 +0000
Subject: [Koha-bugs] [Bug 21357] Filter elisions from index and search terms
 in Elasticsearch
In-Reply-To: <bug-21357-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21357-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21357-70-BjrlgC0d1q@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21357

--- Comment #47 from Michal Denar <black23 at gmail.com> ---
Created attachment 98246
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98246&action=edit
Bug 21357: Allow to use multiple ES language analyzers

Test plan:
1. Apply this patch
2. If you have a custom `field_config.yaml` report the diff in your
custom config
3. Create biblios in english and french
4. misc/search_tools/rebuild_elasticsearch.pl
5. Test biblio search at intranet with stemming and ellision in mind

Examples of test queries:
- "journal actualité" => should return results with "Journaux
d'actualités" in it
- "lord lady" => should return results with "Lords and Ladies" in it

Signed-off-by: Michal Denar <black23 at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 31 21:32:32 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 31 Jan 2020 20:32:32 +0000
Subject: [Koha-bugs] [Bug 24555] POC Elasticsearch - Use boolean queries
 instead of full text queries
In-Reply-To: <bug-24555-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24555-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24555-70-mb5vEHWPhr@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24555

Michal Denar <black23 at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 31 21:32:35 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 31 Jan 2020 20:32:35 +0000
Subject: [Koha-bugs] [Bug 24555] POC Elasticsearch - Use boolean queries
 instead of full text queries
In-Reply-To: <bug-24555-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24555-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24555-70-RfLj7ciI5E@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24555

Michal Denar <black23 at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #98242|0                           |1
        is obsolete|                            |
  Attachment #98243|0                           |1
        is obsolete|                            |

--- Comment #3 from Michal Denar <black23 at gmail.com> ---
Created attachment 98247
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98247&action=edit
Bug 24555: Replace query string with boolean query

Test plan:
 Just make simple and advanced searches

Signed-off-by: Michal Denar <black23 at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 31 21:32:39 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 31 Jan 2020 20:32:39 +0000
Subject: [Koha-bugs] [Bug 24555] POC Elasticsearch - Use boolean queries
 instead of full text queries
In-Reply-To: <bug-24555-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24555-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24555-70-PEWDJuYXeL@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24555

--- Comment #4 from Michal Denar <black23 at gmail.com> ---
Created attachment 98248
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98248&action=edit
Bug 24555: add a button that shows ES query in search result

Signed-off-by: Michal Denar <black23 at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 31 21:39:36 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 31 Jan 2020 20:39:36 +0000
Subject: [Koha-bugs] [Bug 24560] New: Don't show "Public Lists" in OPAC List
 menu if no public lists exist
Message-ID: <bug-24560-70@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24560

            Bug ID: 24560
           Summary: Don't show "Public Lists" in OPAC List menu if no
                    public lists exist
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: OPAC
          Assignee: oleonard at myacpl.org
          Reporter: andrew at bywatersolutions.com
        QA Contact: testopia at bugs.koha-community.org

On the OPAC, the dropdown for Lists always includes the heading Public Lists,
even if no public lists exist. This is sub-optimal for libraries that want
VirtualShelves enabled for private lists but don't want to use public lists.
Could we just make the heading not show if there are no public lists in the
system?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 31 21:41:32 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 31 Jan 2020 20:41:32 +0000
Subject: [Koha-bugs] [Bug 24560] Don't show "Public Lists" in OPAC List menu
 if no public lists exist
In-Reply-To: <bug-24560-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24560-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24560-70-iU74lNOES5@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24560

Andrew Fuerste-Henry <andrew at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |bwsdonna at gmail.com,
                   |                            |jzairo at bywatersolutions.com
                   |                            |,
                   |                            |kelly at bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 31 21:42:40 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 31 Jan 2020 20:42:40 +0000
Subject: [Koha-bugs] [Bug 24552] Koha does not work with
 Search::Elasticsearch 6.00
In-Reply-To: <bug-24552-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24552-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24552-70-CabPwSHB2O@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24552

Michal Denar <black23 at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 31 21:42:42 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 31 Jan 2020 20:42:42 +0000
Subject: [Koha-bugs] [Bug 24552] Koha does not work with
 Search::Elasticsearch 6.00
In-Reply-To: <bug-24552-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24552-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24552-70-dTdx4063Gx@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24552

Michal Denar <black23 at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #98223|0                           |1
        is obsolete|                            |

--- Comment #2 from Michal Denar <black23 at gmail.com> ---
Created attachment 98249
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98249&action=edit
Bug 24552: Be compatible with Search::Elasticsearch 6.00

There is no need to specify the `client` param here because
'5_0::Direct' is the default value for Search::Elasticsearch 5.x and it
breaks when Search::Elasticsearch 6.x is installed

Test plan:
1. Apply the patch
2. Make sure you have Search::Elasticsearch 5.x
3. Reload starman
4. Verify that search works
5. Install Search::Elasticsearch 6.x
6. Reload starman
7. Verify that search works

Signed-off-by: Michal Denar <black23 at gmail.com>

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 31 21:44:35 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 31 Jan 2020 20:44:35 +0000
Subject: [Koha-bugs] [Bug 24552] Koha does not work with
 Search::Elasticsearch 6.00
In-Reply-To: <bug-24552-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24552-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24552-70-wL5SkkAfdg@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24552

Michal Denar <black23 at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |black23 at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 31 21:45:23 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 31 Jan 2020 20:45:23 +0000
Subject: [Koha-bugs] [Bug 21357] Filter elisions from index and search terms
 in Elasticsearch
In-Reply-To: <bug-21357-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-21357-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-21357-70-JRO5IU6dtF@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21357

Michal Denar <black23 at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |black23 at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 31 21:45:47 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 31 Jan 2020 20:45:47 +0000
Subject: [Koha-bugs] [Bug 24555] POC Elasticsearch - Use boolean queries
 instead of full text queries
In-Reply-To: <bug-24555-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24555-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24555-70-PLDjOc2Jhf@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24555

Michal Denar <black23 at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |black23 at gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 31 21:46:06 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 31 Jan 2020 20:46:06 +0000
Subject: [Koha-bugs] [Bug 24327] Anonymous suggestions should not be allowed
 if AnonymousPatron misconfigured
In-Reply-To: <bug-24327-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24327-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24327-70-ohpoaNXRxl@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24327

Lucas Gass <lucas at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |lucas at bywatersolutions.com

--- Comment #12 from Lucas Gass <lucas at bywatersolutions.com> ---
cant clean apply this patchset to the 19.05.x branch, if needed please rebase

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 31 22:01:44 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 31 Jan 2020 21:01:44 +0000
Subject: [Koha-bugs] [Bug 23233] AllowItemsOnHoldCheckout is misnamed and
 should only work for for SIP-based checkouts
In-Reply-To: <bug-23233-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-23233-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-23233-70-2VFDlmz62V@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23233

Lucas Gass <lucas at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to stable            |Pushed to oldstable
                 CC|                            |lucas at bywatersolutions.com

--- Comment #41 from Lucas Gass <lucas at bywatersolutions.com> ---
backported to 19.05.x for 19.05.08

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 31 22:16:07 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 31 Jan 2020 21:16:07 +0000
Subject: [Koha-bugs] [Bug 24016] manager_id in Koha::Patron::Message->store
 should not depend on userenv alone
In-Reply-To: <bug-24016-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24016-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24016-70-NHgUaPTbBY@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24016

Lucas Gass <lucas at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |lucas at bywatersolutions.com

--- Comment #16 from Lucas Gass <lucas at bywatersolutions.com> ---
applying this patchset to 19.05.x does not fix failing tests:

root at 9d08dec7451a:koha(rmain1905)$ kshell
kohadev-koha at 9d08dec7451a:/kohadevbox/koha$ prove
t/db_dependent/Koha/Patron/Messages.t
t/db_dependent/Koha/Patron/Messages.t .. DBD::mysql::st execute failed: Unknown
column 'guarantorid' in 'field list' [for Statement "INSERT INTO `borrowers` (
`B_address`, `B_address2`, `B_city`, `B_country`, `B_email`, `B_phone`,
`B_state`, `B_streetnumber`, `B_streettype`, `B_zipcode`, `address`,
`address2`, `altcontactaddress1`, `altcontactaddress2`, `altcontactaddress3`,
`altcontactcountry`, `altcontactfirstname`, `altcontactphone`,
`altcontactstate`, `altcontactsurname`, `altcontactzipcode`, `anonymized`,
`borrowernotes`, `branchcode`, `cardnumber`, `categorycode`,
`checkprevcheckout`, `city`, `contactfirstname`, `contactname`, `contactnote`,
`contacttitle`, `country`, `date_renewed`, `dateenrolled`, `dateexpiry`,
`dateofbirth`, `debarred`, `debarredcomment`, `email`, `emailpro`, `fax`,
`firstname`, `flags`, `gonenoaddress`, `guarantorid`, `initials`, `lang`,
`lastseen`, `login_attempts`, `lost`, `mobile`, `opacnote`, `othernames`,
`overdrive_auth_token`, `password`, `phone`, `phonepro`, `privacy`,
`privacy_guarantor_checkouts`, `relationship`, `sex`, `sms_provider_id`,
`smsalertnumber`, `sort1`, `sort2`, `state`, `streetnumber`, `streettype`,
`surname`, `title`, `updated_on`, `userid`, `zipcode`) VALUES ( ?, ?, ?, ?, ?,
?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?,
?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?,
?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ? )" with ParamValues:
0='dsfXiD0bhN_Iri6D8_7Rve0MH_Le6eYtfogBFV35tjHc_OYo_5ZGbMlCSokxv1sESnPqhVykkN5qZJyXRky8ySiYte9RvGybEQ',
1='bdRSyw0kq', 2='fPBf1Ji', 3='u7RsyL', 4='OfcT6ffQf', 5='rcD6M_iG3m',
6='fnUS5CyoXp', 7='EWseWBt',
8='ju_b4e_TdcgwUJPFR_IsUSZvBeb1sLK2uLNJUibWvx4F6GcAK',
9='T2Q22IQFrTo_og9QMbBml', 10='gVpx0mTmSG', 11='wyGJtbEs',
12='qkd0eaSUnb42MW8oAvWDOU_16KWfnVP3PIfX8sdNO0Cm8RtosH95MT5m2yhsUVRx5lV16MNPi8Oi48Ru4QxbiHBUif8xOBK3pRg4PgRwKPjjqRzp1SyNW5NmcTMuil0acZIlDOE1rslDAVwyMHYktiS5Eqg1VAnE4gYrQsFruC',
13='msGSC825iBX4M7OuRhQKuXV__tjKAXUQriwPvwGn_aYNAViOC5uijMZux6t1bhmO2525PGllcOVeTr3XxI5IJ8uZVg4R9d4P0HfArsfbypi77fIvn0QptQSy0aQI1ESte',
14='xFiiV7F5x7fzKv1cmeiUnj7Ja8YNfRDsKFThBs7p1ILYqaMxnDLEp3u3yjL3ka1dTyOIagySKjuyDrr06TkIeZroMD9jIogz1icBzErdC_n5aRO3TPnnXaE6Kdd2hS5KxenbFKBFC08HZxHXuAUCtMywcpdqgO6hBHdVO1',
15='Hnxbu1lirw',
16='nT8k9RiiweO3D8FBqcjX_7fhmUOILpfp7IdYji5VFENw71YjkFUzZbNVBiHc9TBOnnp7noM3im7ID8cJ6SAHNTKn6jtf_3A5uGSiwnDOF5yiV0tGaMgJwnlNs_l9avyHCctVVJhajlwpB1EEdC6T3aYVxc8W8eqcb',
17='vqaQ98adCShrZ2wox54FH6PLC2q38JbXzqoB0XSENaew3Q', 18='Uh53jcZP',
19='sPdyHqyhvm0vLW4AhhSEb18Tu7NK0zhV6DGiiybwJjBHdsMgzuIIb3gSNuK6YTSCG97iTYKTjxOB9fZlQsmvBEjNy66wBbxC3rAfBj8ss92IfpLMGQiKPzJlcd3byfDnLgJsrBTPwFx8lYXHWXkHCiOjLncZOajTkKnslo7y_qMmsrTEx5gy5FQoqmsTBpmLLMm_sARQQUJSg5AzLNCfYDN1sjsuO1cnsensXJOvx6Yffiv38IrfAeG',
20='bntUYrlkCwkWTb9xbS6mV2CUlsFf2AJAn2AqV3OMtWk4lA9P', 21=56, 22='',
23='DSJhVvn4Rw', 24='yqTQOXHdMpWkM8MRQ4c', 25='MCKEl6hMOe', 26='n5VnCO',
27='o2_hMs', 28='pXGEplsk', 29='hsxs6d',
30='DeOgCD01Wtr1SKYOraMafMIc9CunUnuIpHVBepXrhwSFaQuurMK7Qb5hHVSFYZMe1Buc8maMr9_6FYXNxgj1udChCuY__FHkimdHbN5m1BZDCCvvS2MxBay6GOwVKzygchoJaP9PCTMXTg0UKFGUdjwcY8T6WVFgSnVRPoOhweIuUym7dHh6W4_g1aHI0eN9OLxvaoO4ZIDGd4DeR3',
31='O15Xgh2kA', 32='esAtWtG3Vo', 33='2020-01-31', 34='2020-01-31',
35='2020-01-31', 36='2020-01-31', 37=undef,
38='BXq2R24Cemae3ZSEWGHF4nAlDGspvadGk2S9ku3W6eILaK9LeaYk33ASJHrjneiK7zS1qohjhRvVUGPkQCl8j2lGTuLJZnZDXuD4_w3m5hK83KkSMBfoxU_ejqjrIfY5PCwfITmBrNMuy4Px_U_Kkwgt5qOCttmbEDtgXYFytHWTvh5YyEsEXMmh0eglmtYcLqqfJFKQWGIxd',
39='BfKNDY6N', 40='xJn3_EftwI', 41='UwRvRu9', 42='e0eCU28XIv', 43=1714647854,
44=undef, 45=1954786734, 46='UrQkAgLU0', 47='KyxyqZ3Enl2H7O7oz8',
48='2020-01-31 21:14:38', 49=0, 50=undef,
51='Ibpe0jP90_9g89G6nzikMttyeq_UXk7l4SAZxMcqyhU4k91o', 52='SmgzznOrL',
53='aWZwno', 54='puTMcILF', 55='ygiTDJwvBllqExheHESxfaEYF3sOdBVzp2mI4H',
56='w_GhFSP', 57='YRx8C6ECo4', 58=1639155680, 59=6,
60='dCd5tojJQRqjPPl80wkdfezqdGcNfv5pWNKg0zx0jPXL9XjBEuX25Xv', 61='r', 62='5',
63='KnBQOrV3VAh7nJtmT_ChLplMPYrgdHfku1pRID',
64='UUJAorN7pcaewsmuCNJMSaA36VY8mgEtFamIfk4cFtumSvG3d6T7FuQtqOwtN',
65='gsgbBTxsN0RW3WPlwq4O2hkKJN9TKljl4js4sdOb2929bajH4We3oNCO', 66='T66bhpE',
67='jnbyDwz', 68='Y51EY5pVjPYLWNlt8_iyqTXokQas1oYRrEaak9vydyAEhSw85',
69='YEKi_OwDG', 70='AX7qez', 71='2020-01-31 21:14:38',
72='c6wOzffrV8eOg6D0FltAURYZqSy0eiXcTWWrrvCf7daQNzYu4XhQWGql3O7pBCd4_sbcP5ui_D',
73='bqqDQdFa5RrvkAufRbZuPdt'] at /usr/share/perl5/DBIx/Class/Storage/DBI.pm
line 1836.
DBIx::Class::Storage::DBI::_dbh_execute(): Unknown column 'guarantorid' in
'field list' at /kohadevbox/koha/t/lib/TestBuilder.pm line 358
# Looks like your test exited with 255 before it could output anything.
t/db_dependent/Koha/Patron/Messages.t .. Dubious, test returned 255 (wstat
65280, 0xff00)
Failed 12/12 subtests

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 31 22:22:29 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 31 Jan 2020 21:22:29 +0000
Subject: [Koha-bugs] [Bug 24027] Adding multiple items is slow
In-Reply-To: <bug-24027-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24027-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24027-70-imoW8fx9m6@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24027

Michal Denar <black23 at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #95473|0                           |1
        is obsolete|                            |

--- Comment #14 from Michal Denar <black23 at gmail.com> ---
Created attachment 98250
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98250&action=edit
Bug 24027: Call ModZebra only once after all items have been added

Why happened:
- call to ModZebra was done after EACH item added,
  but it was called only with main biblionumber only,
  so call was the same on each of requests
- and also time spent in that ModZebra sub increased with every
  next hundred items in DB for that element: so adding every next 100
  was slower and slower,

Solved:
- now it's called only once (by adding some extra parameter to "AddItem*" sub
set in postponed mode)
- and now adding of elements not so heavily depends from how much items was in
DB before.

Test plan / How to replicate the issue:
(test depends from how already populated DB and Zebra/Elasticsearch DBs
 so might be not so noticeably fast on empty DBs)

- go to one of bibliotitems cataloguing/additem.pl?biblionumber=XXX pages
- press button "add multiple copies of this item", put 1000 on slower machines,
5000 on faster
- start measuring time + submit page/form

It takes some amount of time even up to timeout.
After applying patch, run the same procedure for same number of items.
Note: it goes fast in both variants on empty database so time not so
noticeable (also depents how ModZebra-related stuff is configured).

Also it slows more linearly when number of items grows.

But, again, it heavily depends how database is populated and indexes are
rebuild
but it's obvious that it will me much more efficient to call "ModZebra" once
after 1000 addings, then call it 1000 times on each item created in the loop.

Signed-off-by: Michal Denar <black23 at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 31 22:22:33 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 31 Jan 2020 21:22:33 +0000
Subject: [Koha-bugs] [Bug 24027] Adding multiple items is slow
In-Reply-To: <bug-24027-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24027-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24027-70-zGIlEvxH6q@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24027

Michal Denar <black23 at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #95663|0                           |1
        is obsolete|                            |

--- Comment #15 from Michal Denar <black23 at gmail.com> ---
Created attachment 98251
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98251&action=edit
Bug 24027: (follow-up) Don't combine multiple items add POST page with list
generation

When hundreds or thousands of items added, it takes time to add to DB.
Then generation of items list in the SAME request also takes time.
This "doubles" page generation time.

This patch proposes to show only the number of added and total items on
POST-generated page instead of list generation, but not always:
only if some limit are reached ("OpacMaxItemsToDisplay" // 50 is used),
and propose navigation link for the user to see the list after.

It's much more sensible on big databases and libraries hosting/clouds
with limited resources even up to page generation timeout.

This stacks up with previous patch for the combined speed up effect.

Other improvements with this patch:

because added counters for both:
- added now items,
- overall items for this biblioid in DB,
it is now shows:
- number of added items after adding in "dialog message" style box,
- number of total displayed items on the beginning of the list table.

Signed-off-by: Michal Denar <black23 at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 31 22:23:00 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 31 Jan 2020 21:23:00 +0000
Subject: [Koha-bugs] [Bug 24027] Adding multiple items is slow
In-Reply-To: <bug-24027-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24027-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24027-70-fAyeRO90Jf@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24027

Michal Denar <black23 at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 31 22:23:52 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 31 Jan 2020 21:23:52 +0000
Subject: [Koha-bugs] [Bug 24027] Adding multiple items is slow
In-Reply-To: <bug-24027-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24027-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24027-70-eFL3dNDjtu@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24027

Michal Denar <black23 at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #98250|0                           |1
        is obsolete|                            |
  Attachment #98251|0                           |1
        is obsolete|                            |

--- Comment #16 from Michal Denar <black23 at gmail.com> ---
Created attachment 98252
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98252&action=edit
Bug 24027: Call ModZebra only once after all items have been added

Why happened:
- call to ModZebra was done after EACH item added,
  but it was called only with main biblionumber only,
  so call was the same on each of requests
- and also time spent in that ModZebra sub increased with every
  next hundred items in DB for that element: so adding every next 100
  was slower and slower,

Solved:
- now it's called only once (by adding some extra parameter to "AddItem*" sub
set in postponed mode)
- and now adding of elements not so heavily depends from how much items was in
DB before.

Test plan / How to replicate the issue:
(test depends from how already populated DB and Zebra/Elasticsearch DBs
 so might be not so noticeably fast on empty DBs)

- go to one of bibliotitems cataloguing/additem.pl?biblionumber=XXX pages
- press button "add multiple copies of this item", put 1000 on slower machines,
5000 on faster
- start measuring time + submit page/form

It takes some amount of time even up to timeout.
After applying patch, run the same procedure for same number of items.
Note: it goes fast in both variants on empty database so time not so
noticeable (also depents how ModZebra-related stuff is configured).

Also it slows more linearly when number of items grows.

But, again, it heavily depends how database is populated and indexes are
rebuild
but it's obvious that it will me much more efficient to call "ModZebra" once
after 1000 addings, then call it 1000 times on each item created in the loop.

Signed-off-by: Michal Denar <black23 at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 31 22:23:56 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 31 Jan 2020 21:23:56 +0000
Subject: [Koha-bugs] [Bug 24027] Adding multiple items is slow
In-Reply-To: <bug-24027-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24027-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24027-70-SOWJSlZWxB@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24027

--- Comment #17 from Michal Denar <black23 at gmail.com> ---
Created attachment 98253
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98253&action=edit
Bug 24027: (follow-up) Don't combine multiple items add POST page with list
generation

When hundreds or thousands of items added, it takes time to add to DB.
Then generation of items list in the SAME request also takes time.
This "doubles" page generation time.

This patch proposes to show only the number of added and total items on
POST-generated page instead of list generation, but not always:
only if some limit are reached ("OpacMaxItemsToDisplay" // 50 is used),
and propose navigation link for the user to see the list after.

It's much more sensible on big databases and libraries hosting/clouds
with limited resources even up to page generation timeout.

This stacks up with previous patch for the combined speed up effect.

Other improvements with this patch:

because added counters for both:
- added now items,
- overall items for this biblioid in DB,
it is now shows:
- number of added items after adding in "dialog message" style box,
- number of total displayed items on the beginning of the list table.

Signed-off-by: Michal Denar <black23 at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 31 22:29:03 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 31 Jan 2020 21:29:03 +0000
Subject: [Koha-bugs] [Bug 24388] Useless test in acqui/lateorders.tt
In-Reply-To: <bug-24388-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24388-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24388-70-faj2m7lKg1@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24388

Michal Denar <black23 at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Patch doesn't apply
                 CC|                            |black23 at gmail.com

--- Comment #2 from Michal Denar <black23 at gmail.com> ---
Hi Jonathan,
can you rebase this patch?

sing index info to reconstruct a base tree...
M       t/db_dependent/Koha/Acquisition/Basket.t
Falling back to patching base and 3-way merge...
Auto-merging t/db_dependent/Koha/Acquisition/Basket.t
CONFLICT (content): Merge conflict in t/db_dependent/Koha/Acquisition/Basket.t
error: Failed to merge in the changes.
Patch failed at 0001 Bug 24161: Add tests

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 31 22:31:05 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 31 Jan 2020 21:31:05 +0000
Subject: [Koha-bugs] [Bug 24171] Cannot do automatic renewal with
 itemBarcodeFallbackSearch
In-Reply-To: <bug-24171-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24171-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24171-70-WRaA4hOd7m@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24171

Bouzid Fergani <bouzid.fergani at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #96726|0                           |1
        is obsolete|                            |

--- Comment #11 from Bouzid Fergani <bouzid.fergani at inlibro.com> ---
Created attachment 98254
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98254&action=edit
Bug 24171: Preserve auto_renew when triggering itemBarcodeFallbackSearch

The auto_renew parameter is not sent to the template when the popup
triggered by itemBarcodeFallbackSearch is displayed.

Test plan:
- Turn on itemBarcodeFallbackSearch
- Open a patron account
- Check the checkboxes for automatic-renewal
- Search for a title keyword in the checkout input box
- Verify that auto-renewal flag is set

Note for QA: The auto_renew flag will be set in any cases. Should we
expect regression?

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Bouzid Fergani <bouzid.fergani at inlibro.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 31 22:31:10 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 31 Jan 2020 21:31:10 +0000
Subject: [Koha-bugs] [Bug 24171] Cannot do automatic renewal with
 itemBarcodeFallbackSearch
In-Reply-To: <bug-24171-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24171-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24171-70-QIfefGrJam@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24171

Bouzid Fergani <bouzid.fergani at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #96727|0                           |1
        is obsolete|                            |

--- Comment #12 from Bouzid Fergani <bouzid.fergani at inlibro.com> ---
Created attachment 98255
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98255&action=edit
Bug 24171: Check auto_renew if confirmation is needed

Test plan:
Add some fines
Check auto_renew and check an item out, using a title keyword
Pick one item
You get the confirmation box
=> Notice that the auto_renew checkbox is checked

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>
Signed-off-by: Bouzid Fergani <bouzid.fergani at inlibro.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 31 22:31:21 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 31 Jan 2020 21:31:21 +0000
Subject: [Koha-bugs] [Bug 24373] Correct basic cataloging editor CSS
In-Reply-To: <bug-24373-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24373-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24373-70-vNjCcoihFI@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24373

Joy Nelson <joy at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
         Version(s)|20.05.00                    |20.05.00, 19.11.03
        released in|                            |
             Status|Pushed to master            |RESOLVED
                 CC|                            |joy at bywatersolutions.com

--- Comment #7 from Joy Nelson <joy at bywatersolutions.com> ---
Pushed to 19.11.x branch for 19.11.03

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 31 22:31:45 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 31 Jan 2020 21:31:45 +0000
Subject: [Koha-bugs] [Bug 9156] System preference itemcallnumber not pulling
 more than 2 subfields
In-Reply-To: <bug-9156-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-9156-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-9156-70-3l6Y4XFRqV@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9156

Joy Nelson <joy at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |joy at bywatersolutions.com
         Version(s)|20.05.00                    |20.05.00, 19.11.03
        released in|                            |
             Status|Pushed to master            |Pushed to stable

--- Comment #28 from Joy Nelson <joy at bywatersolutions.com> ---
Pushed to 19.11.x branch for 19.11.03

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 31 22:32:07 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 31 Jan 2020 21:32:07 +0000
Subject: [Koha-bugs] [Bug 24146] Paying Accruing Fines prior to return
 causes another accruing fine when returned
In-Reply-To: <bug-24146-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24146-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24146-70-aVXTzk468l@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24146

Joy Nelson <joy at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to master            |Pushed to stable
                 CC|                            |joy at bywatersolutions.com
         Version(s)|20.05.00                    |20.05.00, 19.11.03
        released in|                            |

--- Comment #22 from Joy Nelson <joy at bywatersolutions.com> ---
Pushed to 19.11.x branch for 19.11.03

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 31 22:32:51 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 31 Jan 2020 21:32:51 +0000
Subject: [Koha-bugs] [Bug 3426] Change itemcallnumber system preference to
 allow multiple tags
In-Reply-To: <bug-3426-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-3426-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-3426-70-V6jZa1pYUz@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3426

Joy Nelson <joy at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |joy at bywatersolutions.com
             Status|Pushed to master            |RESOLVED
         Resolution|---                         |FIXED

--- Comment #19 from Joy Nelson <joy at bywatersolutions.com> ---
Enhancement not backported to 19.11 branch

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 31 22:36:58 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 31 Jan 2020 21:36:58 +0000
Subject: [Koha-bugs] [Bug 24420] Cataloging search results Location column
 should account for waiting on hold items
In-Reply-To: <bug-24420-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24420-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24420-70-NmJI3318d5@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24420

Bouzid Fergani <bouzid.fergani at inlibro.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #97417|0                           |1
        is obsolete|                            |

--- Comment #3 from Bouzid Fergani <bouzid.fergani at inlibro.com> ---
Created attachment 98256
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98256&action=edit
Bug 24420: Cataloging search results Location column should account for waiting
on hold items

Signed-off-by: Barbara Johnson <barbara.johnson at bedfordtx.gov>
Signed-off-by: Bouzid Fergani <bouzid.fergani at inlibro.com>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 31 22:52:54 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 31 Jan 2020 21:52:54 +0000
Subject: [Koha-bugs] [Bug 24340] We ought to be able to disable SIP using
 koha-sip
In-Reply-To: <bug-24340-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24340-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24340-70-MZT8iLLq67@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24340

Liz Rea <wizzyrea at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 31 22:52:57 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 31 Jan 2020 21:52:57 +0000
Subject: [Koha-bugs] [Bug 24340] We ought to be able to disable SIP using
 koha-sip
In-Reply-To: <bug-24340-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24340-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24340-70-9WZ0qUHLhx@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24340

Liz Rea <wizzyrea at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #97379|0                           |1
        is obsolete|                            |
  Attachment #97380|0                           |1
        is obsolete|                            |
  Attachment #97381|0                           |1
        is obsolete|                            |

--- Comment #14 from Liz Rea <wizzyrea at gmail.com> ---
Created attachment 98257
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98257&action=edit
Bug 24340: allow koha-sip --disable inst

To test:

- Enable sip for your testing instance
 sudo koha-sip --enable inst
- Start sip for your testing instance
 sudo koha-sip --start inst
- Verify it is running
 ps ax |grep sip -> you should see processes
- Disable sip for your testing intance
 sudo koha-sip --disable inst
- Verify that the following has happened:
 * SIP is no longer running for your instance - no SIP processes
 * SIP Cannot be started for the instance because it is not enabled.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 31 23:11:12 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 31 Jan 2020 22:11:12 +0000
Subject: [Koha-bugs] [Bug 24171] Cannot do automatic renewal with
 itemBarcodeFallbackSearch
In-Reply-To: <bug-24171-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24171-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24171-70-fhTAEsGACt@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24171

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 31 23:19:58 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 31 Jan 2020 22:19:58 +0000
Subject: [Koha-bugs] [Bug 24340] We ought to be able to disable SIP using
 koha-sip
In-Reply-To: <bug-24340-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24340-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24340-70-zWZoNvOhf0@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24340

Liz Rea <wizzyrea at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #98257|0                           |1
        is obsolete|                            |

--- Comment #15 from Liz Rea <wizzyrea at gmail.com> ---
Created attachment 98258
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98258&action=edit
Bug 24340: allow koha-sip --disable inst

To test:

- Enable sip for your testing instance
 sudo koha-sip --enable inst
- Start sip for your testing instance
 sudo koha-sip --start inst
- Verify it is running
 ps ax |grep sip -> you should see processes
- Disable sip for your testing intance
 sudo koha-sip --disable inst
- Verify that the following has happened:
 * SIP is no longer running for your instance - no SIP processes
 * SIP Cannot be started for the instance because it is not enabled.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 31 23:34:47 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 31 Jan 2020 22:34:47 +0000
Subject: [Koha-bugs] [Bug 24206] Change URLs for default options in
 OPACSearchForTitleIn
In-Reply-To: <bug-24206-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24206-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24206-70-DH0QZkLZ6t@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24206

Joy Nelson <joy at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to master            |Pushed to stable
                 CC|                            |joy at bywatersolutions.com
         Version(s)|20.05.00                    |20.05.00, 19.11.03
        released in|                            |

--- Comment #22 from Joy Nelson <joy at bywatersolutions.com> ---
Pushed to 19.11.x branch for 19.11.03

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jan 31 23:54:52 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 31 Jan 2020 22:54:52 +0000
Subject: [Koha-bugs] [Bug 24016] manager_id in Koha::Patron::Message->store
 should not depend on userenv alone
In-Reply-To: <bug-24016-70@https.bugs.koha-community.org/bugzilla3/>
References: <bug-24016-70@https.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-24016-70-oU9J0YHuFH@https.bugs.koha-community.org/bugzilla3/>

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24016

--- Comment #17 from Lucas Gass <lucas at bywatersolutions.com> ---
please ignore my previous comment. I wonked my database, this patchset works

-- 
You are receiving this mail because:
You are watching all bug changes.