[Koha-bugs] [Bug 21520] More complex OAI sets mappings

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21520

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org
             Status|Signed Off                  |Failed QA

--- Comment #6 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Hi Matts,
A couple QA remarks:

1. FAIL   koha-tmpl/intranet-tmpl/prog/en/modules/admin/oai_set_mappings.tt
   FAIL   tt_valid
                lines 49, 50, 77, 78

You are not allowed to build a HTML tag using TT conditional as it breaks the
translator script.

2. update database:
 a. rule_order is always null, is that expected?
 b. first rule should have a null for "rule_operator", isn't it?

Before:
+--------+-----------+--------------+----------+-----------+
| set_id | marcfield | marcsubfield | operator | marcvalue |
+--------+-----------+--------------+----------+-----------+
|      3 | 100       | a            | equal    | pouet     |
|      3 | 200       | a            | equal    | pouet     |
|      3 | 300       | a            | equal    | pouet     |
+--------+-----------+--------------+----------+-----------+

After the update:
+--------+------------+---------------+-----------+--------------+----------+-----------+
| set_id | rule_order | rule_operator | marcfield | marcsubfield | operator |
marcvalue |
+--------+------------+---------------+-----------+--------------+----------+-----------+
|      3 |       NULL | or            | 100       | a            | equal    |
pouet     |
|      3 |       NULL | or            | 200       | a            | equal    |
pouet     |
|      3 |       NULL | or            | 300       | a            | equal    |
pouet     |
+--------+------------+---------------+-----------+--------------+----------+-----------+

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.