[Koha-bugs] [Bug 24350] Can't place holds

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24350

--- Comment #3 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
(In reply to Jonathan Druart from comment #2)
> Created attachment 96860 [details] [review]
> Bug 24350: Fix Branches.pickup_locations
> 
> This will fix the following error:
> Template process failed: undef error - Not a HASH reference at
> /home/vagrant/kohaclone/Koha/Template/Plugin/Branches.pm line 96.
>  at /home/vagrant/kohaclone/C4/Templates.pm line 122
> 
> Koha::Libraries->pickup_locations does not always return an array, but
> arrayref if $biblio is not a Koha::Biblio object.
> 
> I do not think it's the correct fix, the pattern in
> Koha::Libraries->pickup_locations is wrong: we should not expect 2
> different types for a given parameter, biblio should always be a
> Koha::Biblio (idem for item btw).
> That could be fixed easily if the template had the Koha::Biblio object
> sent.

I think we should fix this blocker with your patch, Jonathan, and file a
separate bug for refactoring things. This way people can keep testing the
feature and writing the manual pages, while we implement things in a different
way.

-- 
You are receiving this mail because:
You are watching all bug changes.