[Koha-bugs] [Bug 19014] Patrons should not get an 'on_reserve' notification if the due date is far into the future

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19014

ByWater Sandboxes <bws.sandboxes at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #96689|0                           |1
        is obsolete|                            |

--- Comment #60 from ByWater Sandboxes <bws.sandboxes at gmail.com> ---
Created attachment 97396
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97396&action=edit
Bug 19014: Return auto_too_soon before on_reserve

When calling CanBookBeRenewed we do check for 'too_soon', however, a reserve
makes the return 'on_reserve' before other statuses. It seems the patron
specific reasons
should be returned first. This patch places the 'on_reserve' check after
too_soon and others

To test:
 1 - Checkout an item to a patron with a due date 2 days in the future and 'No
renewal before' unset
 2 - Place a hold on that item
 3 - Define an AUTO_RENEWALS circulation notice with below at a minimum
     [% checkout.auto_renew_error %]
 4 - perl misc/cronjobs/automatic_renewals.pl --send-notices
 5 - Patron is not notified
 6 - Set 'No renewal before' to 1
 7 - run cronjob
 8 - Patron is notified with error 'on_reserve'
 9 - Set 'No renewal before' to 3
10 - UPDATE issues SET auto_renew_error = NULL;
11 - run cronjob
12 - Patron is notified with error 'on_reserve'
13 - APPLY PATCH
14 - Unset 'No renewal before'
15 - UPDATE issues SET auto_renew_error = NULL;
16 - run cronjob
17 - Patron is not notified
18 - UPDATE issues SET auto_renew_error = NULL;
19 - Set 'No renewal before' to 1
20 - run cronjob
21 - Patron is notified with error 'on_reserve'
22 - Set 'No renewal before' to 3
23 - UPDATE issues SET auto_renew_error = NULL;
24 - run cronjob
25 - Patron is not notified

Signed-off-by: Andrew Fuerste-Henry <andrew at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.