[Koha-bugs] [Bug 16787] 'Too many holds' message appears inappropriately and is missing data

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16787

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #96152|0                           |1
        is obsolete|                            |

--- Comment #21 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 97403
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97403&action=edit
Bug 16787: 'Too many holds' message appears inappropriately and is missing data

This patch alters C4/Reserves.pm to pass back 'noReservesAllowed' when
allowedreserves=0. This allows passing to the user an appropriate
message about the availability of items for holds

This patch also fixes a FIXME about using effective_itemtype to fetch item
rules

To test:
1 - Set one itemtype to allow no holds
2 - Set 'Holds per record' to 0 for another itemtype/patron combination
3 - Create or find 2 records, each with items only of the itemtypes above
3 - Attempt to place a hold for a patron on each record above
4 - The message will be 'Too many holds'
5 - Apply patch and repeat
6 - Message should be "No holds allowed: [Firstname Surname] cannot
place holds on any of these items"
7 - Try placing a multihold with either record above and a holdable record,
  message should end "...cannot place holds on some of these titles'
  items"
8 - prove -v t/db_dependent/Holds.t

-- 
You are receiving this mail because:
You are watching all bug changes.