[Koha-bugs] [Bug 24447] New: POD of C4::Members::Messaging::GetMessagingPreferences() is misleading

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24447

            Bug ID: 24447
           Summary: POD of
                    C4::Members::Messaging::GetMessagingPreferences() is
                    misleading
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Keywords: Academy
          Severity: minor
          Priority: P5 - low
         Component: Notices
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: magnus at libriotech.no
        QA Contact: testopia at bugs.koha-community.org

Part of the POD for this subroutine looks like this:

  42   my $preferences = C4::Members::Messaging::GetMessagingPreferences( {
borrowernumber => $borrower->{'borrowernumber'},
  43                                                                       
message_name   => 'DUE' } );
  44 
  45   my $preferences = C4::Members::Messaging::GetMessagingPreferences( {
categorycode => 'LIBRARY',
  46                                                                       
message_name   => 'DUE' } );

It looks like the value for message_name should be a value from letter.code,
but it should be a name from message_attributes.message_name:

  75 AND    message_transports.is_digest =
borrower_message_preferences.wants_digest
  76 WHERE  message_attributes.message_name = ?
  77 END_SQL
  78 
  79     my @bind_params = ( $params->{'message_name'} );

Note: This subroutine is set to be renamed and moved by Bug 18595, but the POD
seems to be untouched there.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.