[Koha-bugs] [Bug 18936] Convert issuingrules fields to circulation_rules

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18936

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Needs Signoff

--- Comment #92 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
(In reply to Joonas Kylmälä from comment #91)
> Hi Jonathan,
> 
> failing the patches "Bug 18936: More fixes", "Bug 18936: Fix Circulation.t",
> "Bug 18936: Fix several issues" and "Bug 18936: Fix Update DB entry" since
> they miss description of the changes so there is no way to know what is the
> intended change here therefore testing will be super difficult. Also with
> "Bug 18936: Fix several issues" it would be more logical to have then
> several commits for those.
> 
> So I will take a look again once the descriptions of changes are added, ok?

Hi Joonas,
Those patches are follow-up sI submitted when I retested the feature after a
feature. I can understand they do not make sense in the git log, but they do
for me (as I am rebasing this for 2 years now). I would suggest to squash the
patches when reviewing them, and you will see that the changes make sense.

Fix Circulation.t: Make the tests Circulation.t pass (maxissueqty was missing
when the rule was created)

Fix several issues: branchcode, categorycode and itemtype are no longer
mandatory to create a new rule

Fix Update DB entry: Some rules were missing (or added when they should not).
Also branchcode, categorycode and itemtype must not be '*' but NULL, otherwise
the FK constraint will not be satisfied.

We are at Signoff step, that should not block testers to test this feature.

-- 
You are receiving this mail because:
You are watching all bug changes.