[Koha-bugs] [Bug 24397] populate_db.pl is out of sync and must be removed

bugzilla-daemon at bugs.koha-community.org bugzilla-daemon at bugs.koha-community.org
Tue Jan 21 11:11:03 CET 2020


https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24397

--- Comment #5 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
(In reply to Marcel de Rooy from comment #3)
> Removing it is easy and I understand the argument. But we could discuss if
> the statement "koha-misc4dev must be used instead" has full consensus.

Maybe a bit of history was needed. I submitted koha:populate_db.pl to have an
handy script, but then realized that our process (SO+QA+push) was too slow to
get things pushed quickly. So I created misc4dev and copied the script there,
along with a lot of other stuffs for Koha devs.
The things is that koha-misc4dev is now used by the sandbox and jenkins
(koha-testing-docker), and so we need a super fast reactivity when something is
broken there, and we now it's broken as the CI is failing in that case.
I am the one who usually fix it

https://gitlab.com/koha-community/koha-misc4dev/commits/master

Most of the time the change is minor and trivial.

> How do we make sure that it is in sync and that it meets our coding
> guidelines etc? It is easier to grep one git repo than two?

Those scripts cannot be part of Koha, as I said previously we need a fast push
and cannot wait for review. I ask for review when I am adding new enhancements
(and in that cases it usually takes several weeks).

> The reason for putting it outside Koha probably relates to the tedious
> process of getting things signed off and pushed in Koha mainstream. Somehow
> we do not manage as community to get that more smoothly. But I still think
> we should address that and not just move code somewhere else.

How? :)

> As an alternative approach, should we copy this script (or even more) at
> release time into the codebase? Formulate some procedure to sync them?

Nope, the script will be broken during the release cycle, and so the script
will become obsolete.

-- 
You are receiving this mail because:
You are watching all bug changes.


More information about the Koha-bugs mailing list