[Koha-bugs] [Bug 20443] Move C4::Members::Attributes to Koha namespace

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20443

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Failed QA

--- Comment #19 from Josef Moravec <josef.moravec at gmail.com> ---
Hello Jonathan, thanks to rebasing this again.

Firstly, there are some trivials found by qa tools:

 FAIL   Koha/Patron/Attribute.pm
   FAIL   pod
                *** ERROR: 
                empty =head3

                 in file Koha/Patron/Attribute.pm

                *** ERROR: 
                empty =head3

                 in file Koha/Patron/Attribute.pm

 FAIL   Koha/Patron/Attributes.pm
   FAIL   pod
                *** ERROR: 
                empty =head3

                 in file Koha/Patron/Attributes.pm

   FAIL   pod coverage
                POD is missing for merge_with
                POD is missing for object_class


 FAIL   Koha/Patrons.pm
   FAIL   spelling
                 paramter  ==> parameter


Otherwise it looks nice.



Note for QA: this is false positive:
 FAIL   Koha/Patron/Attribute.pm
   FAIL   forbidden patterns
                forbidden pattern: Warning: The 'sub type' may be wrong is
declared in a Koha::* package (see bug 15446) (line 63)

-- 
You are receiving this mail because:
You are watching all bug changes.