[Koha-bugs] [Bug 24236] Using quotes in a cataloging search, resulting in multiple pages, will not allow you to advance page

bugzilla-daemon at bugs.koha-community.org bugzilla-daemon at bugs.koha-community.org
Tue Jan 21 13:22:48 CET 2020


https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24236

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #97413|0                           |1
        is obsolete|                            |

--- Comment #7 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 97657
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97657&action=edit
Bug 24236: Fix pagination to use query_cgi

This is still wrong, we should use page-numbers.inc, but that is a larger
refactoring
This patch fixes non-QueryParser searches by simple getting an using the
escaped query (query_cgi)

For QueryParser, we do what the QP code does, just uri escape the query - the
way that SimpleSearch does the query parsing instead of the usual buildQuery
suggest to me that we should probably switch all of this to use the general
Zebra search.

The issues with reservoir should be their own bug

To test:
1 - Search for cat in cataloging search
2 - Get results and see you can paginate
3 - Search for "cat"
4 - Get results but subsequent pages empty
5 - Apply patch
6 - Repeat search for "cat"
7 - You can paginate
8 - Enable UseQueryParser syspref (don't worry about installing)
9 - Confirm can still search with quotes and paginate

Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

Signed-off-by: George Williams <george at nekls.org>

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

-- 
You are receiving this mail because:
You are watching all bug changes.


More information about the Koha-bugs mailing list