[Koha-bugs] [Bug 24471] New: Rename ILL method handle_commit_maybe

bugzilla-daemon at bugs.koha-community.org bugzilla-daemon at bugs.koha-community.org
Tue Jan 21 17:16:22 CET 2020


https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24471

            Bug ID: 24471
           Summary: Rename ILL method handle_commit_maybe
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: ILL
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: andrew.isherwood at ptfs-europe.com

The naming of “handle_commit_maybe” is very misleading. As far as I can see
from comments and old commits, it was intended to do more at some point but all
it does, and has ever done, is redirect the user based on some conditions. A
better name would be something simpler like “redirect_user”

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.


More information about the Koha-bugs mailing list