[Koha-bugs] [Bug 24529] Uninitialised value warnings in C4::Reserves

bugzilla-daemon at bugs.koha-community.org bugzilla-daemon at bugs.koha-community.org
Wed Jan 29 15:57:55 CET 2020


https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24529

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #98075|0                           |1
        is obsolete|                            |
  Attachment #98076|0                           |1
        is obsolete|                            |

--- Comment #4 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 98086
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98086&action=edit
Bug 24529: Silence warnings for title level holds

This patch simply adds a test for itemnumber being defined in the
reserve before comparing it to silence the warning.

Test plan:
1) Prior to patch, run prove t/db_dependant/Circulation.t and note lots
   of `Use of uninitialized value in numeric eq (==) at
   /kohadevbox/koha/C4/Reserves.pm line 790` warnings.
2) Apply the patch, re-run the test and note the tests still pass but
   the warnings are now gone.

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

-- 
You are receiving this mail because:
You are watching all bug changes.


More information about the Koha-bugs mailing list