[Koha-bugs] [Bug 23590] Allow to modify the manager of a suggestion

bugzilla-daemon at bugs.koha-community.org bugzilla-daemon at bugs.koha-community.org
Thu Jan 30 10:31:37 CET 2020


https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23590

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #95487|0                           |1
        is obsolete|                            |
  Attachment #95488|0                           |1
        is obsolete|                            |
  Attachment #95489|0                           |1
        is obsolete|                            |
  Attachment #95490|0                           |1
        is obsolete|                            |
  Attachment #95491|0                           |1
        is obsolete|                            |
  Attachment #95492|0                           |1
        is obsolete|                            |
  Attachment #95493|0                           |1
        is obsolete|                            |
  Attachment #95494|0                           |1
        is obsolete|                            |
  Attachment #95495|0                           |1
        is obsolete|                            |
  Attachment #95496|0                           |1
        is obsolete|                            |
  Attachment #95497|0                           |1
        is obsolete|                            |
  Attachment #95498|0                           |1
        is obsolete|                            |

--- Comment #53 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 98119
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98119&action=edit
Bug 23590: Add ability to edit the manager of a suggestion

Prior to this patch there was an hidden behavior that set the manager to
the logged in user when a suggestion was edited. This patch proposes to
let the librarian pick another manager.
Other small adjustements will be added to polish this new behavior:
 * Create 2 new DB columns: suggestions.lastmodificationby and
 suggestion.lastmodificationdate
 * Choose a manager when editing a suggestion
 * Batch modify suggestions and set a manager for them
 * Let notify the new manager using the TO_PROCESS letter
 * Display the manageddate, lastmodificationby and lastmodificationdate
 info where appropriate

This first patch adds a new "Select manager" link when editing a
suggestion.

Test plan for the whole patchset:
0/
  a. Execute the update DB entry, generate the new DBIC file and restart all
  b. Create at least 2 patrons with the suggestions_manage permission
1/ Submit a new suggestion (OPAC or staff, not important)
2/ Accept it
3/ Edit it
=> "Last modification by" is empty
=> You see that you are the manager of this suggestion
4/ Click "Select manager" and search for a new manager
=> The patron search will only display patrons with the
suggestions_manage permission
5/ Save
6/ Edit again
=> The manager is set to you, but there is a note saying that previously
it was the patron you picked
=> The "Last modification by" is set to you
7/ Click "Keep existing manager"
=> The manager is now set to the previous manager
8/ Select another manager (which has a valid email address defined)
9/ Click the "notify" checkbox
10/ Save
11/ Confirm that a TO_PROCESS notice has been generated into the
message_queue table
12/ Create at least one other suggestion
13/ List the suggestions
=> There is a 4th action column to assign a manager to several
suggestions in one go.
14/ Use this new button and confirm that it works as expected
15/ Go to your purchase suggestion list (OPAC and staff)
=> You see the "managed date" displayed in a new column

Sponsored-by: BULAC - http://www.bulac.fr/

Signed-off-by: Séverine QUEUNE <severine.queune at bulac.fr>

-- 
You are receiving this mail because:
You are watching all bug changes.


More information about the Koha-bugs mailing list