[Koha-bugs] [Bug 23068] Add ability for Koha to handle X-Forwarded-For headers so REMOTE_ADDR features work behind a proxy

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23068

--- Comment #43 from David Cook <dcook at prosentient.com.au> ---
(In reply to Martin Renvoize from comment #42)
> (In reply to David Cook from comment #39)
> > It's too bad there are no unit tests for Koha::Middleware::RealIP. I ended
> > up writing a very basic one here just to test that it worked for multiple
> > proxies.
> 
> Agreed, but I didn't want to hold up this vital development and we weren't
> at all sure how to write such a test.. as it sounds like you've got the
> foundations for a test written, please submit it upstream ;)

That makes sense. I really am loving this development overall!

I'll do a patch for
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24538 and write a
test for it. It won't be total coverage I suppose, but it should be enough to
test the change.

-- 
You are receiving this mail because:
You are watching all bug changes.