[Koha-bugs] [Bug 24553] New: Cancelling hold via SIP returns a failed response even when cancellation succeeds

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24553

            Bug ID: 24553
           Summary: Cancelling hold via SIP returns a failed response even
                    when cancellation succeeds
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: SIP2
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: nick at bywatersolutions.com
        QA Contact: testopia at bugs.koha-community.org
                CC: colin.campbell at ptfs-europe.com

It looks like we have some odd code here. We delete the hold
(C4::SIP::ILS::Transaction::Hold->drop_hold), then we check the patron to see
if they have a hold on the item (C4::SIP::ILS::Patron->drop_hold) - of course
we don't find the hold because we already cancelled it.

348     $trans->patron($patron);
349     $trans->item($item);
350     $trans->drop_hold;
351     unless ($trans->ok) {
352         $trans->screen_msg("Error with transaction drop_hold: " .
$trans->screen_msg);
353         return $trans;
354     }
355     # Remove the hold from the patron's record first
356     $trans->ok($patron->drop_hold($item_id));   # different than the
transaction drop!
357 
358     unless ($trans->ok) {
359         # We didn't find it on the patron record
360         $trans->screen_msg("No such hold on patron record.");
361         return $trans;
362     }

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.