[Koha-bugs] [Bug 18936] Convert issuingrules fields to circulation_rules

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18936

--- Comment #103 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
(In reply to Joonas Kylmälä from comment #101)
> The qa-koha.pl tool detected an issue with constant being redefined:
> 
> > FAIL   Koha/CirculationRules.pm              
> >   FAIL   valid                  
> >                Constant subroutine >Koha::CirculationRules::GUESSED_ITEMTYPES_KEY redefined
> 
> This appears to be from circular dependency:
> 
> Koha/CirculationRules.pm -> Koha/CirculationRule.pm -> Koha/ItemTypes.pm ->
> Koha/ItemType.pm -> Koha/CirculationRules.pm
> 
> if someone has the time to remove the circularity here would be great!

I would not care much about that.
Note that the QA script is ignoring the "subroutine ... redefined" warning.
Here it displays "Constant subroutine ... redefined" and that is why it's not
ignored.

The circular dependency already existed:
% git checkout master
% perl -wc Koha/CirculationRules.pm 
Subroutine get_effective_rule redefined at Koha/CirculationRules.pm line 42.
Subroutine set_rule redefined at Koha/CirculationRules.pm line 82.
Subroutine set_rules redefined at Koha/CirculationRules.pm line 140.
Subroutine delete redefined at Koha/CirculationRules.pm line 171.
Subroutine _type redefined at Koha/CirculationRules.pm line 184.
Subroutine object_class redefined at Koha/CirculationRules.pm line 192.
Koha/CirculationRules.pm syntax OK

-- 
You are receiving this mail because:
You are watching all bug changes.