From bugzilla-daemon at bugs.koha-community.org Wed Jul 1 00:42:56 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 30 Jun 2020 22:42:56 +0000
Subject: [Koha-bugs] [Bug 23653] Plack stopped working - JSON validation
timeout
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23653
--- Comment #18 from Victor Grousset/tuxayo ---
Issue reported to upstream's upstream:
https://github.com/swagger-api/swagger.io/issues/281
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Jul 1 01:04:50 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 30 Jun 2020 23:04:50 +0000
Subject: [Koha-bugs] [Bug 21665] Advanced editor - Double clicking on value
brings subfield code as well
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21665
--- Comment #10 from Cori Lynn Arnold ---
Hey Heather! I hear your frustration. One thing we did here to help was to
remove the "Control-C" from the default for our Koha installations (we have
over 20). To do that:
1. Go to the Advanced Editor
2. Click on the "Keyboard Shortcuts" button
3. Click on the link for "Refine shortcuts"
4. Either delete or redefine what is in that first box for "Copy current field"
If you don't have permissions to do that, talk to your Koha Admin. That was a
good start for us. Hope that helps.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Jul 1 01:41:24 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 30 Jun 2020 23:41:24 +0000
Subject: [Koha-bugs] [Bug 20271] Merge deleted biblio, biblioitems,
biblio_metadata, and items tables
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271
--- Comment #226 from Tomás Cohen Arazi ---
(In reply to Jonathan Druart from comment #225)
> Tomas, with your patches we now have:
> biblio.deleted_on, biblio.deleted
> and
> items.deleted_on, items.is_current
> I think it's confusing.
Yes. I think is_current is an anomaly and shouldn't be the rule. But I wouldn't
block this for that.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Jul 1 02:06:43 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Jul 2020 00:06:43 +0000
Subject: [Koha-bugs] [Bug 23653] Plack stopped working - JSON validation
timeout
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23653
Hayley Mapley changed:
What |Removed |Added
----------------------------------------------------------------------------
Severity|major |blocker
CC| |hayleymapley at catalyst.net.n
| |z
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Jul 1 02:37:52 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Jul 2020 00:37:52 +0000
Subject: [Koha-bugs] [Bug 23653] Plack stopped working - JSON validation
timeout
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23653
David Cook changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |dcook at prosentient.com.au
--- Comment #19 from David Cook ---
A solution to this problem is to provide our own argument "schema" argument to
the load_and_validate_schema() method.
https://metacpan.org/pod/JSON::Validator#load_and_validate_schema
I've looked through the code and there's a variety of ways of providing the
schema, which we can source from
https://raw.githubusercontent.com/mojolicious/json-validator/3.06/lib/JSON/Validator/cache/36d1bd12eeed51e86c8695bd8876a9df
I'd say we should provide it as a local file, so that we're not relying on any
web servers to provide this crucial file.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Jul 1 02:52:51 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Jul 2020 00:52:51 +0000
Subject: [Koha-bugs] [Bug 23653] Plack stopped working - JSON validation
timeout
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23653
Federico Paiz changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |federicoantoniopaiz at gmail.c
| |om
--- Comment #20 from Federico Paiz ---
The same thing happened to me, I solved it by doing
>cpan
> install Mojolicious::Plugin::OpenAPI
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Jul 1 02:56:53 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Jul 2020 00:56:53 +0000
Subject: [Koha-bugs] [Bug 23653] Plack stopped working - JSON validation
timeout
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23653
--- Comment #21 from David Cook ---
(In reply to Federico Paiz from comment #20)
> The same thing happened to me, I solved it by doing
>
> >cpan
> > install Mojolicious::Plugin::OpenAPI
Yeah, the CPAN version of that module comes with the "cache" which the Debian
package excludes, so you'll be fine with that.
But it's a short-term solution.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Jul 1 02:57:10 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Jul 2020 00:57:10 +0000
Subject: [Koha-bugs] [Bug 23653] Plack stopped working - JSON validation
timeout
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23653
--- Comment #22 from David Cook ---
I'm about to start on a patch for this. Hopefully will have something very
soon.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Jul 1 03:43:57 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Jul 2020 01:43:57 +0000
Subject: [Koha-bugs] [Bug 23653] Plack stopped working - JSON validation
timeout
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23653
--- Comment #23 from Tomás Cohen Arazi ---
(In reply to David Cook from comment #22)
> I'm about to start on a patch for this. Hopefully will have something very
> soon.
We should just package the library with the correct cache
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Jul 1 03:45:54 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Jul 2020 01:45:54 +0000
Subject: [Koha-bugs] [Bug 23653] Plack stopped working - JSON validation
timeout
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23653
--- Comment #24 from David Cook ---
Note that this should only affect plugin-enabled instances
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Jul 1 03:49:03 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Jul 2020 01:49:03 +0000
Subject: [Koha-bugs] [Bug 23653] Plack stopped working - JSON validation
timeout
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23653
--- Comment #25 from David Cook ---
(In reply to Tomás Cohen Arazi from comment #23)
> (In reply to David Cook from comment #22)
> > I'm about to start on a patch for this. Hopefully will have something very
> > soon.
>
> We should just package the library with the correct cache
Maybe. I think there is more to this than we think.
Consider ./Koha/REST/V1.pm:
$validator->bundle uses a schema of
$self->home->rel_file("api/v1/swagger/swagger.json"), which is a drastically
reduced schema file.
Calls to $validator->load_and_validate_schema (in ./Koha/REST/V1.pm and
./Koha/REST/Plugin/PluginRoutes.pm) don't use that same schema. They try to
fetch http://swagger.io/v2/schema.json.
The question I have is whether they should all be using
$self->home->rel_file("api/v1/swagger/swagger.json"), or if *some* calls should
use our local swagger.json and others should use the full swagger 2.0 schema.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Jul 1 03:52:29 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Jul 2020 01:52:29 +0000
Subject: [Koha-bugs] [Bug 23653] Plack stopped working - JSON validation
timeout
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23653
--- Comment #26 from David Cook ---
Oh wait I'm misunderstanding...
$validator->bundle is just loading the schema... and it doesn't validate it.
Whereas $validator->load_and_validate_schema loads the schema, but then
validates it against the Swagger 2.0 API schema.
Wow, JSON::Validator really overloads the word "schema" in its code...
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Jul 1 03:54:23 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Jul 2020 01:54:23 +0000
Subject: [Koha-bugs] [Bug 23653] Plack stopped working - JSON validation
timeout
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23653
--- Comment #27 from David Cook ---
>From what I can see, we're not actually validating the schema in
./Koha/REST/V1.pm when we use bundle().
We only validate it in ./Koha/REST/V1.pm when we do the catch{} block.
And we always validate ./Koha/REST/Plugin/PluginRoutes.pm.
Ok... yeah re-packaging libjson-validator-perl to include the "cache" probably
makes the most sense.
I'm going to post a code-level patch anyway (partially just because I'm already
this far anyway)
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Jul 1 03:54:46 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Jul 2020 01:54:46 +0000
Subject: [Koha-bugs] [Bug 23653] Plack stopped working - JSON validation
timeout
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23653
--- Comment #28 from David Cook ---
(In reply to David Cook from comment #27)
> I'm going to post a code-level patch anyway (partially just because I'm
> already this far anyway)
Plus, if I do that, then we wouldn't have to maintain another custom package
dependency...
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Jul 1 04:12:54 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Jul 2020 02:12:54 +0000
Subject: [Koha-bugs] [Bug 23653] Plack stopped working - JSON validation
timeout
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23653
--- Comment #29 from David Cook ---
Actually, it looks like Koha::REST::Plugin::PluginRoutes doesn't receive the
validator.
It looks like the OpenAPI plugin must be calling a validator and that's where
it's failing...
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Jul 1 04:22:35 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Jul 2020 02:22:35 +0000
Subject: [Koha-bugs] [Bug 23653] Plack stopped working - JSON validation
timeout
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23653
--- Comment #30 from Victor Grousset/tuxayo ---
(In reply to Tomás Cohen Arazi from comment #23)
> We should just package the library with the correct cache
Indeed, that way, deployers only have to update the perl-deps, no patch to
apply.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Jul 1 04:31:54 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Jul 2020 02:31:54 +0000
Subject: [Koha-bugs] [Bug 23653] Plack stopped working - JSON validation
timeout
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23653
David Cook changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|In Discussion |Needs Signoff
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Jul 1 04:31:58 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Jul 2020 02:31:58 +0000
Subject: [Koha-bugs] [Bug 23653] Plack stopped working - JSON validation
timeout
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23653
--- Comment #31 from David Cook ---
Created attachment 106444
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106444&action=edit
Bug 23653: use local copy of swagger v2 schema
By default, JSON::Validator::OpenAPI tries to fetch the
swagger v2 schema from http://swagger.io/v2/schema.json.
If you've installed from CPAN, JSON::Validator::OpenAPI will
come with a cached copy, so it won't try to fetch it over HTTP.
However, if you've installed from libjson-validator-perl
from Debian/Ubuntu, the Debian package excludes the cached copy,
so JSON::Validator::OpenAPI tries to fetch it over HTTP.
Unfortunately, today and other days in the past, the file at
http://swagger.io/v2/schema.json has been unavailable, and this causes
Koha to crash in a perpetual loop.
This patch includes a copy of the swagger v2 schema, and it loads
it locally rather than fetching over HTTP.
The changes to Koha/REST/Plugin/PluginRoutes.pm are not required,
since the validator isn't currently called there, but I've added
a patch to future proof it.
To Test:
0a) Remove
/usr/share/perl5/JSON/Validator/cache/36d1bd12eeed51e86c8695bd8876a9df
if it exists
0b) Block external access to http://swagger.io/v2/schema.json or
test during an outage when it's unavailable
0c) Do not apply patch
1) koha-plack --restart kohadev
2) Note that it crashes in a loop and is unavailable in web browser
3) Apply patch
4) koha-plack --restart kohadev
5) Note that Koha comes up and there are no errors in the Plack logs
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Jul 1 04:49:09 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Jul 2020 02:49:09 +0000
Subject: [Koha-bugs] [Bug 15504] Track Patron's Last Activity
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15504
--- Comment #26 from David Cook ---
(In reply to Christopher Brannon from comment #17)
> "Not a priority for us"...who is "US"?
Ah, fair question! I mean the vendor I work for Prosentient Systems and the
libraries that it supports. None of our libraries are signalling this as a
priority for us, so we're working on other things that are more important for
them.
I should've been more precise with my language :).
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Jul 1 04:56:48 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Jul 2020 02:56:48 +0000
Subject: [Koha-bugs] [Bug 23653] Plack stopped working - JSON validation
timeout
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23653
Victor Grousset/tuxayo changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #106444|0 |1
is obsolete| |
--- Comment #32 from Victor Grousset/tuxayo ---
Created attachment 106445
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106445&action=edit
Bug 23653: use local copy of swagger v2 schema
By default, JSON::Validator::OpenAPI tries to fetch the
swagger v2 schema from http://swagger.io/v2/schema.json.
If you've installed from CPAN, JSON::Validator::OpenAPI will
come with a cached copy, so it won't try to fetch it over HTTP.
However, if you've installed from libjson-validator-perl
from Debian/Ubuntu, the Debian package excludes the cached copy,
so JSON::Validator::OpenAPI tries to fetch it over HTTP.
Unfortunately, today and other days in the past, the file at
http://swagger.io/v2/schema.json has been unavailable, and this causes
Koha to crash in a perpetual loop.
This patch includes a copy of the swagger v2 schema, and it loads
it locally rather than fetching over HTTP.
The changes to Koha/REST/Plugin/PluginRoutes.pm are not required,
since the validator isn't currently called there, but I've added
a patch to future proof it.
To Test:
0a) Remove
/usr/share/perl5/JSON/Validator/cache/36d1bd12eeed51e86c8695bd8876a9df
if it exists
0b) Block external access to http://swagger.io/v2/schema.json or
test during an outage when it's unavailable
0c) Do not apply patch
1) koha-plack --restart kohadev
2) Note that it crashes in a loop and is unavailable in web browser
3) Apply patch
4) koha-plack --restart kohadev
5) Note that Koha comes up and there are no errors in the Plack logs
Signed-off-by: Victor Grousset/tuxayo
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Jul 1 04:57:09 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Jul 2020 02:57:09 +0000
Subject: [Koha-bugs] [Bug 25898] Prohibit indirect object notation
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25898
David Cook changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |dcook at prosentient.com.au
--- Comment #3 from David Cook ---
This is great to see, although also impossible to test?
I guess if we can get it into master ASAP though then there's a better chance
of any issues being caught early in this release cycle.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Jul 1 04:57:45 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Jul 2020 02:57:45 +0000
Subject: [Koha-bugs] [Bug 25900] Double quotes breaks search with Zebra and
QueryWeightFields
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25900
David Cook changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |dcook at prosentient.com.au
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Jul 1 04:58:16 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Jul 2020 02:58:16 +0000
Subject: [Koha-bugs] [Bug 25851] 19.11 upgrade creates holdallowed rule with
empty value
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25851
David Cook changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |dcook at prosentient.com.au
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Jul 1 05:19:35 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Jul 2020 03:19:35 +0000
Subject: [Koha-bugs] [Bug 23653] Plack stopped working - JSON validation
timeout
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23653
Victor Grousset/tuxayo changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Needs Signoff |Signed Off
--- Comment #33 from Victor Grousset/tuxayo ---
It works! :D
(In reply to Victor Grousset/tuxayo from comment #30)
> Indeed, that way, deployers only have to update the perl-deps, no patch to
> apply.
Should we actually expect a significant number of instances to have more
difficulty applying such a simple patch (just this patch, not updating Koha)
compared to updating the perl deps?
The question is whether or not packaging libjson-validator-perl during some
time is worth it. Not sure now.
Also, if http://swagger.io/v2/schema.json would work again tomorrow that would
help letting those instances count on that until their next Koha update.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Jul 1 05:54:00 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Jul 2020 03:54:00 +0000
Subject: [Koha-bugs] [Bug 23653] Plack stopped working - JSON validation
timeout
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23653
--- Comment #34 from David Cook ---
(In reply to Victor Grousset/tuxayo from comment #33)
> Should we actually expect a significant number of instances to have more
> difficulty applying such a simple patch (just this patch, not updating Koha)
> compared to updating the perl deps?
>
> The question is whether or not packaging libjson-validator-perl during some
> time is worth it. Not sure now.
>
> Also, if http://swagger.io/v2/schema.json would work again tomorrow that
> would help letting those instances count on that until their next Koha
> update.
I'm curious about this as well. While we felt this in production in Australia,
I'm guessing the rest of the world might not feel it for another few hours.
I don't know where Jonathan is physically located these days, but I'm guessing
that we may have just missed him as well, so the Koha world is in for an
interesting day...
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Jul 1 06:00:06 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Jul 2020 04:00:06 +0000
Subject: [Koha-bugs] [Bug 23653] Plack stopped working - JSON validation
timeout
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23653
--- Comment #35 from David Cook ---
Mason announced 30 minutes ago on koha-devel that he's updated the
libjson-validator-perl package.
As per his email:
hi Folks
i've updated the 'libjson-validator-perl' package to include the cache dir
to update the package...
$ sudo apt update
$ sudo apt install libjson-validator-perl
run the following command, and confirm the result...
$ apt-cache policy libjson-validator-perl
libjson-validator-perl:
Installed: 3.06+dfsg-1+koha1
Candidate: 3.06+dfsg-1+koha1
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Jul 1 06:03:09 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Jul 2020 04:03:09 +0000
Subject: [Koha-bugs] [Bug 23653] Plack stopped working - JSON validation
timeout
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23653
--- Comment #36 from David Cook ---
I've tested the new package in koha-testing-docker and it looks good.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Jul 1 06:54:42 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Jul 2020 04:54:42 +0000
Subject: [Koha-bugs] [Bug 17981] Add the ability to preview generated notice
templates
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17981
--- Comment #68 from David Cook ---
(In reply to David Cook from comment #67)
> Going to double-check but this might be broken in 19.11...
I must've been mistaken as it looks fine now.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Jul 1 07:40:16 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Jul 2020 05:40:16 +0000
Subject: [Koha-bugs] [Bug 25803] Internet Explorer: unable to save patron
edits or view patron checkouts
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25803
David Cook changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |RESOLVED
Resolution|--- |WONTFIX
--- Comment #6 from David Cook ---
Ok looking at this again...
Using https://babeljs.io/, it's suggesting the following.
Replace:
$(`.guarantor-details[data-borrowernumber=${borrower.borrowernumber}]`).length;
With:
(".guarantor-details[data-borrowernumber=".concat(borrower.borrowernumber,
"]")).length;
However, I notice ./koha-tmpl/opac-tmpl/lib/kjua/lib/dom.js uses template
literals as well, and there might be other Javascript that does too.
As Owen said, really there's no reason people should be using computers without
Edge, and Edge supports newer Javascript, so I think the best solution might
actually be to push back on Intranet users and advise that the Koha Intranet
isn't fully compatible with older browsers like IE 11.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Jul 1 07:54:30 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Jul 2020 05:54:30 +0000
Subject: [Koha-bugs] [Bug 20271] Merge deleted biblio, biblioitems,
biblio_metadata, and items tables
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271
--- Comment #227 from Katrin Fischer ---
(In reply to Tomás Cohen Arazi from comment #226)
> (In reply to Jonathan Druart from comment #225)
> > Tomas, with your patches we now have:
> > biblio.deleted_on, biblio.deleted
> > and
> > items.deleted_on, items.is_current
> > I think it's confusing.
>
> Yes. I think is_current is an anomaly and shouldn't be the rule. But I
> wouldn't block this for that.
Can you explain? I think if possible we should be consistent, thinking of the
many report writeres out there.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Jul 1 08:19:58 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Jul 2020 06:19:58 +0000
Subject: [Koha-bugs] [Bug 25900] Double quotes breaks search with Zebra and
QueryWeightFields
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25900
Theodoros Theodoropoulos changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |theod at lib.auth.gr
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Jul 1 08:52:30 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Jul 2020 06:52:30 +0000
Subject: [Koha-bugs] [Bug 25905] New: REST API: create endpoint for
importing OAI-PMH records from external OAI-PMH clients
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25905
Bug ID: 25905
Summary: REST API: create endpoint for importing OAI-PMH
records from external OAI-PMH clients
Change sponsored?: ---
Product: Koha
Version: unspecified
Hardware: All
OS: All
Status: NEW
Severity: enhancement
Priority: P5 - low
Component: REST API
Assignee: koha-bugs at lists.koha-community.org
Reporter: dcook at prosentient.com.au
Following on from previous work on #10662 and koha-plugin-oaipmh-import, I'm
now thinking that it would be best to have a REST API endpoint for importing
OAI-PMH records in the Koha mainstream.
This would give libraries assurance that the core OAI-PMH ingest functionality
will be in the main codebase and get Koha community support.
For now, I'm still planning to keep my planned OAI-PMH harvester/client as a
plugin/third-party dependency, but completion of this work will allow Koha
libraries to use any OAI-PMH harvester they choose to ingest records into Koha.
This could be with a Perl cronjob using HTTP::OAI, or it could be a Golang
daemon, or whatever. Lots of possibilities.
Anyway, I've got a lot of this work done already in koha-plugin-oaipmh-import,
so I'll look at re-organising it to fit into Koha proper.
It'll be in my own time, so I don't have a timeline for it, but it is on my
TODO list.
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Jul 1 08:52:44 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Jul 2020 06:52:44 +0000
Subject: [Koha-bugs] [Bug 10662] Build OAI-PMH Harvesting Client
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10662
--- Comment #305 from David Cook ---
(In reply to Michal Denar from comment #304)
> Hi,
> I could participate on documetation. But I'm not developer, I need some "how
> to" from David or Tomás, how integrate translation into code.
No worries.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Jul 1 08:55:42 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Jul 2020 06:55:42 +0000
Subject: [Koha-bugs] [Bug 10662] Build OAI-PMH Harvesting Client
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10662
--- Comment #306 from David Cook ---
While I hate to keep waffling, I've been thinking that having the OAI-PMH
ingest code in mainstream Koha is probably a good idea. I've opened #25905 to
that end.
I'll change my koha-plugin-oaipmh-import work to fit into mainstream Koha, and
submit a patch on #25905.
The initial work won't be very complicated, so it shouldn't be very difficult
to test.
I'll still do the OAI-PMH harvester as a plugin though, since what I have in
mind is complex and not necessarily suitable for everyone.
My hope is that when #25905 is done, people might set up their own harvesters
as best fits their needs.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Jul 1 08:55:52 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Jul 2020 06:55:52 +0000
Subject: [Koha-bugs] [Bug 25905] REST API: create endpoint for importing
OAI-PMH records from external OAI-PMH clients
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25905
David Cook changed:
What |Removed |Added
----------------------------------------------------------------------------
See Also| |https://bugs.koha-community
| |.org/bugzilla3/show_bug.cgi
| |?id=10662
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
From bugzilla-daemon at bugs.koha-community.org Wed Jul 1 08:55:52 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Jul 2020 06:55:52 +0000
Subject: [Koha-bugs] [Bug 10662] Build OAI-PMH Harvesting Client
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10662
David Cook changed:
What |Removed |Added
----------------------------------------------------------------------------
See Also| |https://bugs.koha-community
| |.org/bugzilla3/show_bug.cgi
| |?id=25905
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Jul 1 09:03:24 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Jul 2020 07:03:24 +0000
Subject: [Koha-bugs] [Bug 10744] ExpireReservesMaxPickUpDelay works with
hold(s) over report
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10744
Emmi Takkinen changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #44464|0 |1
is obsolete| |
CC| |emmi.takkinen at outlook.com
--- Comment #6 from Emmi Takkinen ---
Created attachment 106446
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106446&action=edit
Bug 10744 - ExpireReservesMaxPickUpDelay works with hold(s) over report
Hold(s) over -report at circ/waitingreserves.pl doesn't work because
ExpireReservesMaxPickup removes reserves from the koha.reserves-table to the
koha.old_reserves-table.
This patch adds a new column koha.reserves.pickupexpired telling when/if the
reserve has got it's pickup duration expired.
This date is used to pull old reserves to the waitingreserves-view.
syspref 'PickupExpiredHoldsOverReportDuration' controls how many days after
expiration old reserves are displayed on the report, and the values respect
Koha::Calendar holidays
To test:
1) Apply patch.
2) Enable 'ExpireReservesMaxPickUpDelay'.
3) Set some value to 'ReservesMaxPickUpDelay' and
'PickupExpiredHoldsOverReportDuration' (e.g. 2 and 7).
4) Find or create hold(s) waiting pickup and set their expiration date so it
exceeds 'ReservesMaxPickUpDelay'
but not 'PickupExpiredHoldsOverReportDuration'.
5) Confirm hold(s) are moved to 'Holds waiting over ...' list.
6) Run misc/cronjobs/holds/cancel_expired_holds.pl.
7) Confirm hold(s) are still displayed on the list.
8) Confirm from db that hold(s) have 'pickupexpired' set same as
'expirationdate'.
9) Set new value to 'PickupExpiredHoldsOverReportDuration' so it no longer
covers hold(s) expiration date(s).
10) Confirm that hold(s) are no longer displayed in waiting list
Also prove t/db_depentent/Koha/Old.t
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Jul 1 09:05:05 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Jul 2020 07:05:05 +0000
Subject: [Koha-bugs] [Bug 10744] ExpireReservesMaxPickUpDelay works with
hold(s) over report
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10744
Emmi Takkinen changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Patch doesn't apply |Needs Signoff
--- Comment #7 from Emmi Takkinen ---
Fixed patch to apply master version and removed dependencies to other patches.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Jul 1 09:11:57 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Jul 2020 07:11:57 +0000
Subject: [Koha-bugs] [Bug 23653] Plack stopped working - JSON validation
timeout
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23653
--- Comment #37 from David Cook ---
I'd recommend to people starting their day to look at
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23653#c11 for a quick
fix to get through the worst of things right now.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Jul 1 09:12:09 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Jul 2020 07:12:09 +0000
Subject: [Koha-bugs] [Bug 23653] Plack stopped working - JSON validation
timeout
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23653
David Cook changed:
What |Removed |Added
----------------------------------------------------------------------------
Assignee|tomascohen at gmail.com |dcook at prosentient.com.au
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Jul 1 09:16:59 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Jul 2020 07:16:59 +0000
Subject: [Koha-bugs] [Bug 25898] Prohibit indirect object notation
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25898
--- Comment #4 from Julian Maurice ---
(In reply to Katrin Fischer from comment #2)
> Would it make sense to create a Perl 7 Omnibus bug we can use for these?
If I understood correctly there would be only 2 bugs under that omnibus : this
one, and one for removing bareword filehandle. I'll let you decide if it makes
sense to have an omnibus ;)
(In reply to David Cook from comment #3)
> This is great to see, although also impossible to test?
I agree. The only reasonable way to "test" would be to carefully review the
patch change by change. If it can help, I did it with `git show
--word-diff=color --word-diff-regex=.` (It takes time, prepare some
coffee/tea/mate first)
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Jul 1 09:22:17 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Jul 2020 07:22:17 +0000
Subject: [Koha-bugs] [Bug 23653] Plack stopped working - JSON validation
timeout
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23653
--- Comment #38 from David Cook ---
I think Mason found that newer versions of Ubuntu weren't installing 3.06 as
they were using newer versions, but it looks like he's now released a
3.23+dfsg-1+koha1 version.
I've installed that on Debian Jessie in koha-testing-docker, and it looks like
it's working successfully.
So folk using the Debian packages shoudl be able to just do the following:
apt-get update
apt-get install libjson-validator-perl
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Jul 1 09:40:10 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Jul 2020 07:40:10 +0000
Subject: [Koha-bugs] [Bug 23653] Plack stopped working - JSON validation
timeout
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23653
--- Comment #39 from David Cook ---
Ok that 3.23 is still in the staging repo.
If you're running a Debian/Ubuntu package, you'll be vulnerable, but not if
you're running a Koha Community package.
So you should be fine on Debian Jessie and Debian Stretch and Ubuntu Xenial.
If you're on anything newer than those, you'll need to upgrade to the Koha
Community 3.06 (or 3.23 when it is available) as per the table below:
__Koha Community Apt Repo__
libjson-validator-perl_0.67+dfsg-1~koha1_all.deb
libjson-validator-perl_0.97-1~kohadev1_all.deb
libjson-validator-perl_3.06+dfsg-1+koha1_all.deb
__Debian__
Stretch 9: libjson-validator-perl (0.92+dfsg-1)
Buster 10: libjson-validator-perl (3.06+dfsg-1)
Bullseye 11: libjson-validator-perl (3.25+dfsg-1)
__Ubuntu__
Xenial 16.04: libjson-validator-perl (0.66+dfsg-1)
Bionic 18.04: libjson-validator-perl (1.08+dfsg-1)
Eoan 19.10: libjson-validator-perl (3.14+dfsg-1)
Focal 20.04: libjson-validator-perl (3.23+dfsg-1)
Groovy 20.10: libjson-validator-perl (3.25+dfsg-1)
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Jul 1 09:57:49 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Jul 2020 07:57:49 +0000
Subject: [Koha-bugs] [Bug 23653] Plack stopped working - JSON validation
timeout
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23653
--- Comment #40 from David Cook ---
Here's a condensed version of the above:
Good (don't worry):
- Debian Jessie 8
- Debian Stretch 9
- Ubuntu Xenial 16.04
Bad (do worry):
- Debian Buster 10 (and above)
- Ubuntu Bionic 18.04 (and above)
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Jul 1 10:40:55 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Jul 2020 08:40:55 +0000
Subject: [Koha-bugs] [Bug 25906] New: In opac-serial-issues.pl,
when looking at full history, the search facet form should look good.
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25906
Bug ID: 25906
Summary: In opac-serial-issues.pl, when looking at full
history, the search facet form should look good.
Change sponsored?: ---
Product: Koha
Version: master
Hardware: All
OS: All
Status: NEW
Severity: enhancement
Priority: P5 - low
Component: Templates
Assignee: oleonard at myacpl.org
Reporter: timothy_alexis.vass at ub.lu.se
QA Contact: testopia at bugs.koha-community.org
Created attachment 106447
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106447&action=edit
What it currently looks like.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Jul 1 10:42:13 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Jul 2020 08:42:13 +0000
Subject: [Koha-bugs] [Bug 25906] In opac-serial-issues.pl,
when looking at full history, the search facet form should look good.
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25906
--- Comment #1 from Timothy Alexis Vass ---
Created attachment 106448
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106448&action=edit
What it should look like.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Jul 1 10:50:48 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Jul 2020 08:50:48 +0000
Subject: [Koha-bugs] [Bug 25906] In opac-serial-issues.pl,
when looking at full history, the search facet form should look good.
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25906
--- Comment #2 from Timothy Alexis Vass ---
1. In linked stylesheet:
#menu form, #search-facets form {
margin: 0em;
}
Change margin to 1em.
-----
2. In the inline style block:
#search-facets fieldset.action {
padding-left: 4px;
margin: .3em;
}
Remove padding-let and margin, set text-align to center.
-----
3. In opac-full-serial-issues:
Remove style="width:10em;" from these two elements.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Jul 1 11:16:04 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Jul 2020 09:16:04 +0000
Subject: [Koha-bugs] [Bug 24239] Let the ILL module set ad hoc hard due dates
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24239
--- Comment #6 from Magnus Enger ---
(In reply to Katrin Fischer from comment #5)
> Would you mind me tinkering with that a bit?
Not at all, tinker away! :-)
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Jul 1 11:37:10 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Jul 2020 09:37:10 +0000
Subject: [Koha-bugs] [Bug 25905] REST API: create endpoint for importing
OAI-PMH records from external OAI-PMH clients
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25905
Andreas Hedström Mace changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |andreas.hedstrom.mace at sub.s
| |u.se
--- Comment #1 from Andreas Hedström Mace ---
I think this would be really good to have. A stable endpoint to ingest the
records, and the harvester as a plug-in (or even various harvester plug-ins).
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Jul 1 11:58:26 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Jul 2020 09:58:26 +0000
Subject: [Koha-bugs] [Bug 25861] [19.11] Unknown column 'important' in
'field list'
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25861
Nick Clemens changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |hayleymapley at catalyst.net.n
| |z,
| |nick at bywatersolutions.com
Keywords| |rel_19_11_candidate
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Jul 1 13:11:08 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Jul 2020 11:11:08 +0000
Subject: [Koha-bugs] [Bug 25906] In opac-serial-issues.pl,
when looking at full history, the search facet form should look good.
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25906
--- Comment #3 from Owen Leonard ---
Created attachment 106449
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106449&action=edit
How it looks in master
What version are you looking at? What I see in master doesn't match your "What
it currently looks like" screenshot.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Jul 1 13:31:46 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Jul 2020 11:31:46 +0000
Subject: [Koha-bugs] [Bug 4948] When cancelling a waiting hold,
allow to trigger hold for next patron
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4948
--- Comment #4 from Kyle M Hall ---
Created attachment 106450
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106450&action=edit
Bug 4948: When cancelling a waiting hold on returns.pl, looks for new hold to
fill without rescanning barcode
Test Plan:
1) Place two or more holds on a record
2) Check in the item
3) Confirm the hold
4) Check in the item again
5) Cancel the hold
6) Koha should now display the modal asking to confirm the next hold
without the need to rescan the barcode!
--
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.
From bugzilla-daemon at bugs.koha-community.org Wed Jul 1 13:50:28 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Jul 2020 11:50:28 +0000
Subject: [Koha-bugs] [Bug 25907] New: When cancelling a waiting hold on
circulation.pl, allow to trigger hold for next patron
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25907
Bug ID: 25907
Summary: When cancelling a waiting hold on circulation.pl,
allow to trigger hold for next patron
Change sponsored?: ---
Product: Koha
Version: master
Hardware: All
OS: All
Status: NEW
Severity: enhancement
Priority: P5 - low
Component: Circulation
Assignee: koha-bugs at lists.koha-community.org
Reporter: kyle at bywatersolutions.com
QA Contact: testopia at bugs.koha-community.org
CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com
Right now, after canceling a hold on the checkin screen, a librarian needs to
rescan the item barcode to check and trap the next hold. This is an extra
unnecessary step.
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
From bugzilla-daemon at bugs.koha-community.org Wed Jul 1 13:50:40 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Jul 2020 11:50:40 +0000
Subject: [Koha-bugs] [Bug 25907] When cancelling a waiting hold on
circulation.pl, allow to trigger hold for next patron
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25907
Kyle M Hall changed:
What |Removed |Added
----------------------------------------------------------------------------
See Also| |https://bugs.koha-community
| |.org/bugzilla3/show_bug.cgi
| |?id=4948
Severity|enhancement |minor
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
From bugzilla-daemon at bugs.koha-community.org Wed Jul 1 13:50:40 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Jul 2020 11:50:40 +0000
Subject: [Koha-bugs] [Bug 4948] When cancelling a waiting hold,
allow to trigger hold for next patron
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4948
Kyle M Hall changed:
What |Removed |Added
----------------------------------------------------------------------------
See Also| |https://bugs.koha-community
| |.org/bugzilla3/show_bug.cgi
| |?id=25907
--
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Jul 1 13:50:49 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Jul 2020 11:50:49 +0000
Subject: [Koha-bugs] [Bug 25907] When cancelling a waiting hold on
circulation.pl, allow to trigger hold for next patron
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25907
Kyle M Hall changed:
What |Removed |Added
----------------------------------------------------------------------------
Assignee|koha-bugs at lists.koha-commun |kyle at bywatersolutions.com
|ity.org |
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
From bugzilla-daemon at bugs.koha-community.org Wed Jul 1 13:51:18 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Jul 2020 11:51:18 +0000
Subject: [Koha-bugs] [Bug 4948] When cancelling a waiting hold on returns.pl,
looks for new hold to fill without rescanning barcode
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4948
Kyle M Hall changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |kyle at bywatersolutions.com
Summary|When cancelling a waiting |When cancelling a waiting
|hold, allow to trigger hold |hold on returns.pl, looks
|for next patron |for new hold to fill
| |without rescanning barcode
--
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.
From bugzilla-daemon at bugs.koha-community.org Wed Jul 1 13:52:07 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Jul 2020 11:52:07 +0000
Subject: [Koha-bugs] [Bug 4948] When cancelling a waiting hold,
allow to trigger hold for next patron
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4948
Kyle M Hall changed:
What |Removed |Added
----------------------------------------------------------------------------
Summary|When cancelling a waiting |When cancelling a waiting
|hold on returns.pl, looks |hold, allow to trigger hold
|for new hold to fill |for next patron
|without rescanning barcode |
--
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Jul 1 13:52:21 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Jul 2020 11:52:21 +0000
Subject: [Koha-bugs] [Bug 25907] When cancelling a waiting hold on
returns.pl, looks for new hold to fill without rescanning barcode
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25907
Kyle M Hall changed:
What |Removed |Added
----------------------------------------------------------------------------
Summary|When cancelling a waiting |When cancelling a waiting
|hold on circulation.pl, |hold on returns.pl, looks
|allow to trigger hold for |for new hold to fill
|next patron |without rescanning barcode
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Jul 1 13:53:39 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Jul 2020 11:53:39 +0000
Subject: [Koha-bugs] [Bug 25907] When cancelling a waiting hold on
returns.pl, looks for new hold to fill without rescanning barcode
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25907
Kyle M Hall changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |Needs Signoff
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Jul 1 13:53:43 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Jul 2020 11:53:43 +0000
Subject: [Koha-bugs] [Bug 25907] When cancelling a waiting hold on
returns.pl, looks for new hold to fill without rescanning barcode
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25907
--- Comment #1 from Kyle M Hall ---
Created attachment 106451
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106451&action=edit
Bug 25907: When cancelling a waiting hold on returns.pl, looks for new hold to
fill without rescanning barcode
Right now, after canceling a hold on the checkin screen, a librarian needs to
rescan the item barcode to check and trap the next hold. This is an extra
unnecessary step.
Test Plan:
1) Place two or more holds on a record
2) Check in the item
3) Confirm the hold
4) Check in the item again
5) Cancel the hold
6) Koha should now display the modal asking to confirm the next hold
without the need to rescan the barcode!
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Jul 1 13:55:35 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Jul 2020 11:55:35 +0000
Subject: [Koha-bugs] [Bug 4948] When cancelling a waiting hold,
allow to trigger hold for next patron
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4948
Kyle M Hall changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #106450|0 |1
is obsolete| |
--
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Jul 1 14:01:09 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Jul 2020 12:01:09 +0000
Subject: [Koha-bugs] [Bug 25903] Sending a SIP patron information request
with a summary field flag in indexes 6-9 will crash server
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25903
Kyle M Hall changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Needs Signoff |Signed Off
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Jul 1 14:01:12 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Jul 2020 12:01:12 +0000
Subject: [Koha-bugs] [Bug 25903] Sending a SIP patron information request
with a summary field flag in indexes 6-9 will crash server
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25903
Kyle M Hall changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #106443|0 |1
is obsolete| |
--- Comment #2 from Kyle M Hall ---
Created attachment 106452
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106452&action=edit
Bug 25903: Sending a SIP patron information request with a summary field flag
in indexes 6-9 will crash server
The 'summary' field in the patron information request specifies if detail
information should be send for holds, overdues, fines, etc. The field is 10
characters in length (0-9). However, the SIP2 spec only defines indexes 0
though 5, leave 6 though 9 undefined. Some ILSs specify behavior for these
undefined indexes. Apparently the 7th field is often used to request 'Fees', as
opposed to 'Fines' in some ILS. Some software that integrate via SIP try both
the 5th and 7th indexes to ensure they get all fines and fees.
The problem is that Koha's SIP server crashes if any 'summary' index beyond 5
is flagged. We should simply ignore flags beyond 5 and act as if no flags were
sent.
Test Plan:
1) Enable SIP for your instance
2) Send a patron information request with a summary flag in any index beyond 5.
i.e.: 6300120200617 124846 Y AOMIDAY|AA21030050054321
3) Note the SIP server just closes the connection without a response
4) Apply this patch
5) Restart the SIP server
6) Send the same request
7) Note you get back the patron information response!
Signed-off-by: Kyle M Hall
Signed-off-by: Jeff Gaines
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Jul 1 14:01:51 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Jul 2020 12:01:51 +0000
Subject: [Koha-bugs] [Bug 25907] When cancelling a waiting hold on
returns.pl, looks for new hold to fill without rescanning barcode
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25907
Owen Leonard changed:
What |Removed |Added
----------------------------------------------------------------------------
Patch complexity|--- |Trivial patch
Status|Needs Signoff |Signed Off
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Jul 1 14:01:53 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Jul 2020 12:01:53 +0000
Subject: [Koha-bugs] [Bug 25907] When cancelling a waiting hold on
returns.pl, looks for new hold to fill without rescanning barcode
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25907
Owen Leonard changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #106451|0 |1
is obsolete| |
--- Comment #2 from Owen Leonard ---
Created attachment 106453
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106453&action=edit
Bug 25907: When cancelling a waiting hold on returns.pl, looks for new hold to
fill without rescanning barcode
Right now, after canceling a hold on the checkin screen, a librarian
needs to rescan the item barcode to check and trap the next hold. This
is an extra unnecessary step.
Test Plan:
1) Place two or more holds on a record
2) Check in the item
3) Confirm the hold
4) Check in the item again
5) Cancel the hold
6) Koha should now display the modal asking to confirm the next hold
without the need to rescan the barcode!
Signed-off-by: Owen Leonard
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Jul 1 14:05:12 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Jul 2020 12:05:12 +0000
Subject: [Koha-bugs] [Bug 23653] Plack stopped working - JSON validation
timeout
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23653
Fridolin SOMERS changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |fridolin.somers at biblibre.co
| |m
--- Comment #41 from Fridolin SOMERS ---
For Ubuntu Debian, we at biblibre installed from CPAN JSON::Validator 4.01 and
added the cache file.
It works without patch on sources.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Jul 1 14:23:11 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Jul 2020 12:23:11 +0000
Subject: [Koha-bugs] [Bug 20271] Merge deleted biblio, biblioitems,
biblio_metadata, and items tables
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271
--- Comment #228 from Tomás Cohen Arazi ---
(In reply to Katrin Fischer from comment #227)
> (In reply to Tomás Cohen Arazi from comment #226)
> > (In reply to Jonathan Druart from comment #225)
> > > Tomas, with your patches we now have:
> > > biblio.deleted_on, biblio.deleted
> > > and
> > > items.deleted_on, items.is_current
> > > I think it's confusing.
> >
> > Yes. I think is_current is an anomaly and shouldn't be the rule. But I
> > wouldn't block this for that.
>
> Can you explain? I think if possible we should be consistent, thinking of
> the many report writeres out there.
Comment #198 explains it. What really makes sense is a 'deleted' flag, but
because of this very special case in which we want to preserve the UNIQUE
constraint on the items.barcode column which some libraries would like to
reuse, and the DBMS doesn't allow us to have the constraint on non-NULL values,
we need to do it in reverse (i.e. instead of 'deleted' we do 'not_deleted' and
set NULL to represent deleted). So we are forcing the DB structure because of
our limitations on the DB features we are allowed to use, or the versions of
the DB we want to support (all for good reasons, not arguing).
I would just add a FIXME on the items table and leave the other tables saner.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Jul 1 14:55:11 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Jul 2020 12:55:11 +0000
Subject: [Koha-bugs] [Bug 25799] Edition information to Holds queue report
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25799
Owen Leonard changed:
What |Removed |Added
----------------------------------------------------------------------------
Patch complexity|--- |Trivial patch
Status|Needs Signoff |Signed Off
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Jul 1 14:55:14 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Jul 2020 12:55:14 +0000
Subject: [Koha-bugs] [Bug 25799] Edition information to Holds queue report
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25799
Owen Leonard changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #106429|0 |1
is obsolete| |
--- Comment #6 from Owen Leonard ---
Created attachment 106454
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106454&action=edit
Bug 25799: Add edition information to "Holds queue" report
Added a feature that displays edition information of the book
together with title in "Holds queue" report.
Edition information is fetched from "biblioitem" table
as "editionstatement" and transferred to template.
1. Place a hold on a book with edition information.
2. Run build_holds_queue.pl cron job.
3. Go to /cgi-bin/koha/circ/view_holdsqueue.pl and check the "title"
table of that book that you placed hold on.
4. Observe that there's no information about edition of that book.
5. Apply patch.
6. Repeat step 3.
7. Observe that cinformation about edition of that book appeared
in the title table after book's title and author.
Mentored-by: Andrew Nugged
Signed-off-by: Owen Leonard
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Jul 1 15:12:23 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Jul 2020 13:12:23 +0000
Subject: [Koha-bugs] [Bug 25896] Missing closing tag in smart-rules.tt
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25896
Owen Leonard changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Needs Signoff |Signed Off
Patch complexity|--- |Trivial patch
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Jul 1 15:12:26 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Jul 2020 13:12:26 +0000
Subject: [Koha-bugs] [Bug 25896] Missing closing tag in smart-rules.tt
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25896
Owen Leonard changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #106420|0 |1
is obsolete| |
--- Comment #2 from Owen Leonard ---
Created attachment 106455
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106455&action=edit
Bug 25896: Add missing closing tag
File koha-tmpl/intranet-tmpl/prog/en/modules/admin/smart-rules.tt had
one lost closing tag in "daysmode" block. Added.
Mentored-by: Andrew Nugged
Signed-off-by: Owen Leonard
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Jul 1 15:47:02 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Jul 2020 13:47:02 +0000
Subject: [Koha-bugs] [Bug 25698] Curbside Pickup
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25698
Sally changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |sally.healey at cheshireshared
| |services.gov.uk
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Jul 1 15:58:54 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Jul 2020 13:58:54 +0000
Subject: [Koha-bugs] [Bug 25698] Curbside Pickup
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25698
--- Comment #3 from Martin Renvoize ---
I'm interested in trying to get a specification for this together.. starting
with something simple hopefully that we can implement as a quick phase one.
I can see challenges around notification of when items are available for pickup
and what items are available for request and when... nothing unsolvable but it
would be interesting to get peoples thoughts around the topic.
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Jul 1 17:12:07 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Jul 2020 15:12:07 +0000
Subject: [Koha-bugs] [Bug 24201] Attach desk to intranet session
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24201
Nicolas Legrand changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Needs Signoff |Patch doesn't apply
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Jul 1 17:29:41 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Jul 2020 15:29:41 +0000
Subject: [Koha-bugs] [Bug 25698] Curbside Pickup
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25698
--- Comment #4 from Lisette Scheer ---
Martin,
I know Lucas at Bywater put together some JQ that replaces the "notes" section
on the OPAC with a very basic curbside scheduler. It works well for
single-branch libraries (or libraries where you can only put on holds from your
branch) but I'm not sure you can limit how many patrons at a time are doing
curbside so you don't get flooded with curbside appointments.
For us as a consortium with multi-branch libraries within the consortium, we
would want to schedule pickup once the hold is available and be able to limit
how many people are doing curbside at a time, as well as setting times and
limits on each branch. We are doing a 15 minute window with up to 10 pickups at
a time at our branch. Currently our branch is using a paid service to
facilitate this.
Ideally in Koha we could do a link/have them go to the OPAC login and could
schedule from there once holds were in.
It would be helpful if we could check out all waiting holds with a button press
so when we are prepping the materials we can say 'these are the 15 holds for
this patrons, check them all out' to speed up the process and reduce how much
staff is handling the items. I know we could copy the barcodes into batch
checkout, but it would be much smoother if there was a button.
For the long run, having it be something you could turn on and off/branch would
be ideal, although if you could set pickup times for each branch those that
aren't using it could just not set up times.
I think I saw that Evergreen's plan was to have a check in option when they
arrived and I think that would be helpful as well.
Lisette
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Jul 1 17:41:10 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Jul 2020 15:41:10 +0000
Subject: [Koha-bugs] [Bug 25908] New: Batch Record Modification adds new
marc fields to bottom of record instead of in order
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25908
Bug ID: 25908
Summary: Batch Record Modification adds new marc fields to
bottom of record instead of in order
Change sponsored?: ---
Product: Koha
Version: 19.11
Hardware: All
OS: All
Status: NEW
Severity: enhancement
Priority: P5 - low
Component: Tools
Assignee: koha-bugs at lists.koha-community.org
Reporter: kelly at bywatersolutions.com
QA Contact: testopia at bugs.koha-community.org
When processing a Batch Record Modification, specifically adding a new marc
field, Koha adds this new marc field to the bottom of the record and not in
order with the other fields. It would be useful to have newly added marc fields
to be in numeric order when the marc record is saved. A user would generally
look for the marc field in the record where it should be and not look to the
bottom of the record.
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
From bugzilla-daemon at bugs.koha-community.org Wed Jul 1 18:13:05 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Jul 2020 16:13:05 +0000
Subject: [Koha-bugs] [Bug 23653] Plack stopped working - JSON validation
timeout
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23653
--- Comment #42 from Victor Grousset/tuxayo ---
The schema hosting at swagger.io is back
https://github.com/swagger-api/swagger.io/issues/282
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Jul 1 18:52:59 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Jul 2020 16:52:59 +0000
Subject: [Koha-bugs] [Bug 21665] Advanced editor - Double clicking on value
brings subfield code as well
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21665
--- Comment #11 from Heather ---
Hi, Cori!
Thank you--yes, I'm aware of (and can, and have already been) redefining the
shortcut keys, but that doesn't address the issue that started the ticket, that
the subfield delimiter letter was always copied when "double-clicked" and now
nothing is able to be selectively copied when double-clicked in the Advanced
Editor--the only ability now under 19.11 is copy an entire subfield (with the
delimiter character and delimited letter) into the Koha clipboard only.
This bug also was created to copy the double-clicked text into Notepad, and
that's now impossible as well without the ability to copy from the Advanced
Editor into the OS clipboard.
Or am I missing something? I haven't seen how changing/redefining the keyboard
shortcut can change the ability to copy double-clicked (or otherwise
highlighted text that is less than an entire subfield) into, e.g., Notepad or
other app via the OS clipboard?
Thanks!! --h2
(In reply to Cori Lynn Arnold from comment #10)
> Hey Heather! I hear your frustration. One thing we did here to help was to
> remove the "Control-C" from the default for our Koha installations (we have
> over 20). To do that:
>
> 1. Go to the Advanced Editor
> 2. Click on the "Keyboard Shortcuts" button
> 3. Click on the link for "Refine shortcuts"
> 4. Either delete or redefine what is in that first box for "Copy current
> field"
>
> If you don't have permissions to do that, talk to your Koha Admin. That was
> a good start for us. Hope that helps.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Jul 1 18:54:26 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Jul 2020 16:54:26 +0000
Subject: [Koha-bugs] [Bug 25654] Make the contact and non-patron guarantor
sections separate on patron entry form
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25654
Lucas Gass changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #106355|0 |1
is obsolete| |
--- Comment #15 from Lucas Gass ---
Created attachment 106456
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106456&action=edit
Bug 25654: Make the contact and non-patron guarantor sections separate on
patron entry form
This patch reverses what I think was an unintended change made by Bug
14570 in which the non-patron guarantor fields are shown for all patron
types (not just child patrons) and grouped with the patron contact fields.
This patch creates a new "Non-patron guarantor" fieldset to show along
with "Patron guarantor" when adding or editing child patrons.
To test, apply the patch check that the BorrowerUnwantedField system
preference does not contain contactname, contactfirstname,
or relationship.
- Open an adult patron for editing. You should see no guarantor-related
fields.
- Open a child patron for editing. There should be two guarantor
sections: "Patron guarantor" and "Non-patron guarantor."
- Test that adding patron guarantors and non-patron guarantors works
correctly.
- Add "contactname|contactfirstname|relationship" to the
BorrowerUnwantedField system preference.
- Reload the child patron entry form. The non-patron guarantor
section should now be hidden.
Signed-off-by: Lucas Gass
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Jul 1 18:55:06 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Jul 2020 16:55:06 +0000
Subject: [Koha-bugs] [Bug 25654] Make the contact and non-patron guarantor
sections separate on patron entry form
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25654
Lucas Gass changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Needs Signoff |Signed Off
CC| |lucas at bywatersolutions.com
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Jul 1 19:24:57 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Jul 2020 17:24:57 +0000
Subject: [Koha-bugs] [Bug 25654] Make the contact and non-patron guarantor
sections separate on patron entry form
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25654
ByWater Sandboxes changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #106456|0 |1
is obsolete| |
--- Comment #16 from ByWater Sandboxes ---
Created attachment 106457
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106457&action=edit
Bug 25654: Make the contact and non-patron guarantor sections separate on
patron entry form
This patch reverses what I think was an unintended change made by Bug
14570 in which the non-patron guarantor fields are shown for all patron
types (not just child patrons) and grouped with the patron contact fields.
This patch creates a new "Non-patron guarantor" fieldset to show along
with "Patron guarantor" when adding or editing child patrons.
To test, apply the patch check that the BorrowerUnwantedField system
preference does not contain contactname, contactfirstname,
or relationship.
- Open an adult patron for editing. You should see no guarantor-related
fields.
- Open a child patron for editing. There should be two guarantor
sections: "Patron guarantor" and "Non-patron guarantor."
- Test that adding patron guarantors and non-patron guarantors works
correctly.
- Add "contactname|contactfirstname|relationship" to the
BorrowerUnwantedField system preference.
- Reload the child patron entry form. The non-patron guarantor
section should now be hidden.
Signed-off-by: Lucas Gass
Signed-off-by: Christopher Brannon
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Jul 1 19:25:01 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Jul 2020 17:25:01 +0000
Subject: [Koha-bugs] [Bug 25909] New: Recent change to datatables JS in the
OPAC causes errors
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25909
Bug ID: 25909
Summary: Recent change to datatables JS in the OPAC causes
errors
Change sponsored?: ---
Product: Koha
Version: master
Hardware: All
OS: All
Status: NEW
Severity: enhancement
Priority: P5 - low
Component: Architecture, internals, and plumbing
Assignee: koha-bugs at lists.koha-community.org
Reporter: oleonard at myacpl.org
QA Contact: testopia at bugs.koha-community.org
CC: agustinmoyano at theke.io,
jonathan.druart at bugs.koha-community.org,
kyle at bywatersolutions.com,
martin.renvoize at ptfs-europe.com,
nick at bywatersolutions.com, tomascohen at gmail.com
Depends on: 25287
Bug 25287 made a lot of changes to
koha-tmpl/opac-tmpl/bootstrap/js/datatables.js which seem to be unrelated to
the purpose of the bug. Included in the changes is the double-underscore "__()"
translation function which hasn't yet been implemented in the OPAC. Since the
function isn't defined this causes an error.
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25287
[Bug 25287] Add columns_settings support to API datatables wrapper
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Jul 1 19:25:01 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Jul 2020 17:25:01 +0000
Subject: [Koha-bugs] [Bug 25287] Add columns_settings support to API
datatables wrapper
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25287
Owen Leonard changed:
What |Removed |Added
----------------------------------------------------------------------------
Blocks| |25909
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25909
[Bug 25909] Recent change to datatables JS in the OPAC causes errors
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Jul 1 19:25:48 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Jul 2020 17:25:48 +0000
Subject: [Koha-bugs] [Bug 25654] Make the contact and non-patron guarantor
sections separate on patron entry form
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25654
--- Comment #17 from Christopher Brannon ---
Clean and straight forward. Thanks for fixing this!
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Jul 1 19:32:59 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Jul 2020 17:32:59 +0000
Subject: [Koha-bugs] [Bug 21648] Patron Merge needs more flexibility and
transparency
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21648
Christopher Brannon changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |cbrannon at cdalibrary.org
--- Comment #2 from Christopher Brannon ---
This wreaks havoc with our records because of duplicated patron attributes and
no easy way to clean up. This should be considered a bug, not an enhancement,
IMO.
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
From bugzilla-daemon at bugs.koha-community.org Wed Jul 1 19:46:08 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Jul 2020 17:46:08 +0000
Subject: [Koha-bugs] [Bug 25909] Recent change to datatables JS in the OPAC
causes errors
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25909
Tomás Cohen Arazi changed:
What |Removed |Added
----------------------------------------------------------------------------
Severity|enhancement |major
Assignee|koha-bugs at lists.koha-commun |tomascohen at gmail.com
|ity.org |
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Jul 1 19:48:52 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Jul 2020 17:48:52 +0000
Subject: [Koha-bugs] [Bug 25877] [19.11] Error libraryNotPickupLocation when
placing a hold if logged in branchcode is not a pickup location
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25877
Kyle M Hall changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Failed QA |Signed Off
--- Comment #6 from Kyle M Hall ---
Just tested on 19.11.x, the problem still exists:
https://monosnap.com/file/gbped1dKxSpMy7LU9Lz10lZHjXHrmw
(In reply to Katrin Fischer from comment #5)
> I have done the following:
> - I have changed Centerville to be 'no pickup location' in the library
> configuration
> - My staff patron has home library Centerville and that was also my logged
> in library
> - When I try to place a hold, Centerville is not in the pickup location
> list, but there is also no error. I can place holds with other pickup
> locations without an error.
>
> What am I missing? I was testing on latest 19.11.x
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Jul 1 19:48:57 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Jul 2020 17:48:57 +0000
Subject: [Koha-bugs] [Bug 25909] Recent change to datatables JS in the OPAC
causes errors
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25909
--- Comment #1 from Tomás Cohen Arazi ---
Created attachment 106458
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106458&action=edit
Bug 25909: Revert wrong use of js/i18n.js __ in OPAC
This reverts commit 6b82d1416687434c61fe49b4230c15ad8b795b6e
The __ function is not implemented in the OPAC and so the original
implementation that relied on _ should be used instead.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Jul 1 19:49:13 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Jul 2020 17:49:13 +0000
Subject: [Koha-bugs] [Bug 25909] Recent change to datatables JS in the OPAC
causes errors
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25909
Tomás Cohen Arazi changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |Needs Signoff
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Jul 1 20:10:40 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Jul 2020 18:10:40 +0000
Subject: [Koha-bugs] [Bug 25909] Recent change to datatables JS in the OPAC
causes errors
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25909
--- Comment #2 from Tomás Cohen Arazi ---
(In reply to Owen Leonard from comment #0)
> Bug 25287 made a lot of changes to
> koha-tmpl/opac-tmpl/bootstrap/js/datatables.js which seem to be unrelated to
> the purpose of the bug. Included in the changes is the double-underscore
> "__()" translation function which hasn't yet been implemented in the OPAC.
> Since the function isn't defined this causes an error.
Bug 25287 targeted being used in the OPAC by bug 20936, which we just reverted
to 'the old way' because of the route the discussion about the API
implementation took.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Jul 1 20:12:55 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Jul 2020 18:12:55 +0000
Subject: [Koha-bugs] [Bug 21648] Patron Merge duplicates patron attributes
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21648
Andrew Fuerste-Henry changed:
What |Removed |Added
----------------------------------------------------------------------------
Severity|enhancement |normal
Summary|Patron Merge needs more |Patron Merge duplicates
|flexibility and |patron attributes
|transparency |
--- Comment #3 from Andrew Fuerste-Henry ---
Renaming and refocusing this bug. I agree the attributes are a more pressing
aspect of this, so let's make this specific and therefore more easily
addressed.
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
From bugzilla-daemon at bugs.koha-community.org Wed Jul 1 20:22:49 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Jul 2020 18:22:49 +0000
Subject: [Koha-bugs] [Bug 21648] Patron Merge duplicates patron attributes
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21648
--- Comment #4 from Christopher Brannon ---
(In reply to Andrew Fuerste-Henry from comment #3)
> Renaming and refocusing this bug. I agree the attributes are a more pressing
> aspect of this, so let's make this specific and therefore more easily
> addressed.
+1
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
From bugzilla-daemon at bugs.koha-community.org Wed Jul 1 20:42:51 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Jul 2020 18:42:51 +0000
Subject: [Koha-bugs] [Bug 25861] [19.11] Cannot copy MARC frameworks
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25861
Andrew Fuerste-Henry changed:
What |Removed |Added
----------------------------------------------------------------------------
Summary|[19.11] Unknown column |[19.11] Cannot copy MARC
|'important' in 'field list' |frameworks
CC| |andrew at bywatersolutions.com
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed Jul 1 21:05:30 2020
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 Jul 2020 19:05:30 +0000
Subject: [Koha-bugs] [Bug 25910] New: Two blank values in authorised value
category selection in marc frameworks
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25910
Bug ID: 25910
Summary: Two blank values in authorised value category
selection in marc frameworks
Change sponsored?: ---
Product: Koha
Version: master
Hardware: All
OS: All
Status: NEW
Severity: minor
Priority: P5 - low
Component: Staff Client
Assignee: koha-bugs at lists.koha-community.org
Reporter: nick at bywatersolutions.com
QA Contact: testopia at bugs.koha-community.org
CC: gmcharlt at gmail.com
When selecting the authorised value for a marc subfield in the frameworks:
admin/marc_subfields_structure.pl
There are two blank values at the top of the dropdown
One comes from the template:
179
180