[Koha-bugs] [Bug 25909] Recent change to datatables JS in the OPAC causes errors

bugzilla-daemon at bugs.koha-community.org bugzilla-daemon at bugs.koha-community.org
Thu Jul 2 14:23:48 CEST 2020


https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25909

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Failed QA

--- Comment #3 from Owen Leonard <oleonard at myacpl.org> ---
I'm not sure how to proceed with this one... The patch changes __() to _(),
which will eliminate the JS error but won't make the strings translatable
because the _() function doesn't work in standalone JavaScript files.

Bug 25351 implements the JavaScript i18n feature while updated the Cart
JavaScript to use it. If that were approved it would make this bug obsolete.

Otherwise the correct patch for this is to fully revert the changes to lines
where the MST_DT_* variables were used.

http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=6f5dc3dc0dd9fa02d6d11e92a6e466e545b8eccc#patch2

-- 
You are receiving this mail because:
You are watching all bug changes.


More information about the Koha-bugs mailing list