[Koha-bugs] [Bug 24683] Holds on biblios with different item types: rules for holds allowed are not applied correctly if any item type is available

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24683

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org

--- Comment #10 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
I confirm this patch fixes another bug:

If there is a biblio with 2 items having different itemtypes.
First item is not available for holds, the other one is checked out, and
available "if all unavailable".
At the OPAC there was a blocking message "There are no items that can be placed
on hold."
With this patch I am able to place a hold on the second item.

Technical comments:
It seems ok, only minor changes:
* perltidy a bit the tests
* add tests in a subtest
* AddReturn statement is not needed
* it would be great to have IsAvailableForItemLevelRequest tested as well (just
in case, especially because we are lacking test coverage for this circ rule!

This comment does not block the signoff process.

-- 
You are receiving this mail because:
You are watching all bug changes.