[Koha-bugs] [Bug 16371] Quote of the Day (QOTD) for the staff interface

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16371

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Failed QA

--- Comment #29 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Hi Emmi,

patches apply now, sorry for missing the patch double up.

0) There are some problems highlighted by the QA tools:

FAIL    Koha/Quote.pm
   FAIL   critic
                "return" statement with explicit "undef" at line 129, column 9.
See page 199 of PBP.

 FAIL   Koha/Quotes.pm
   FAIL   pod coverage
                POD is missing for 'object_class'

 FAIL   koha-tmpl/intranet-tmpl/prog/en/modules/intranet-main.tt
   FAIL   filters
                missing_filter at line 41 (                            <span
id="daily-quote-text">[% daily_quote.text %]</span><span id="daily-quote-sep">
~ </span><span id="daily-quote-source">[% daily_quote.source %]</span>)
                missing_filter at line 41 (                            <span
id="daily-quote-text">[% daily_quote.text %]</span><span id="daily-quote-sep">
~ </span><span id="daily-quote-source">[% daily_quote.source %]</span>)


1) I see that you moved the routine to the new namespace, but it appears to be
unchanged. Especially the SQL parts I think should be replaced/rewritten.

2) I like making the old sys pref multiple choice :) Can you please use staff
interface? 
https://wiki.koha-community.org/wiki/Terminology

3) I think we need a database update to change the type of the system
preference in the database from YesNo to multi.

-- 
You are receiving this mail because:
You are watching all bug changes.