[Koha-bugs] [Bug 18532] AUTO_RENEWALS should be a patron messaging preference

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18532

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Failed QA

--- Comment #49 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Hi Augustin,

1) For the letter content:
installer/data/mysql/atomicupdate/bug-18532.perl

Please make some changes:
notification on auto renewing 
= Notification on auto renewals

was renewed until [% checkout.date_due %] 
Should be formatted as due date (see the other auto renewal notice now)
[% checkout.date_due | $KohaDates as_due_date => 1 %]
The sample files have a filter, but not the due date one, so there is an
inconsistency there.

items that were not correctly renewed.
items that where correctly renewed.
Personally I'd get rid of "correctly" here - they are renewed, there is no
incorrect renew :)

2) System preference:
The sentence doesn't quite work for the first and last choices, maybe one of
the native speakers could help? Can you explain about the deprecation? It might
appear as if the cronjob was deprecated, but I think what is meant is a
specific option. I think being more clear here would be helpful.
+         - "Send automatic renewal notices "
+         - pref: AutoRenewalNotices
+           choices:
+               never: never
+               preferences: according to patron messaging preferences
+               cron: (Deprecated) according to cron switch

3) Please take a look at the terminology list on the wiki - we are aiming to be
more consistent:
branch = library
borrower = patron
issue = checkout
etc.

4) Translated installers
You've only updated the Polish sample notices file, but you need to update
every translated installer and the new default .yml file with the new notice.

-- 
You are receiving this mail because:
You are watching all bug changes.