[Koha-bugs] [Bug 24379] Borrowers login attempts happen to be NULL instead of 0

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24379

--- Comment #12 from David Cook <dcook at prosentient.com.au> ---
No change to login_attempts between 19.11.05 and 19.11.07...

No change to login_attempts between 19.11.05 and origin/19.11.x...

Ah, but this is an upgraded database.

I see in kohastructure.sql that login_attempts has "default 0" but in my actual
upgraded database it has "default null". 

In 16.12.00.037, there is the following (for Bug 18314 - Add
FailedLoginAttempts and borrowers.login_attempts):
ALTER TABLE borrowers ADD COLUMN login_attempts INT(4) DEFAULT 0 AFTER lastseen

In 17.06.00.009, the DEFAULT 0 was removed (for Bug 19344 -  Reorder lang and
login_attempts in the [deleted]borrowers tables):
ALTER TABLE borrowers MODIFY COLUMN login_attempts int(4) AFTER lang;

So that explains that.

New databases will be fine, but upgraded databases will not be.

-- 
You are receiving this mail because:
You are watching all bug changes.