[Koha-bugs] [Bug 22407] OMNIBUS: Use DBIC relations to fetch related object rather than searching for the object

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22407

--- Comment #14 from Julian Maurice <julian.maurice at biblibre.com> ---
(In reply to David Cook from comment #13)
> I've noticed a lot of Koha code directly returning the output of a method
> call, and it drives me crazy. We should do more data validation. It'll mean
> fewer bugs and easier maintenance.

What is there to check in this particular situation ? _new_from_dbic either
dies or return a blessed object. If it dies then Koha::Patron::guarantor should
die too, if it returns a blessed object, then there is nothing to check.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.