[Koha-bugs] [Bug 14648] Batch remove reserve items

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14648

--- Comment #19 from Nick Clemens <nick at bywatersolutions.com> ---
(In reply to Joe Sikowitz from comment #18)
> Hi Nick,
> 
> These patches keep things simple and work as expected.
> 
> Blocker:
> 1 - If I enter barcodes that are not in any courses I report successful
> deletion from all courses - I don't think that's right
> 
> I'm going to fix this one and readd the patch.
> 
> Couple questions:
> 1 - Why not a bulk option to remove from a single course?
> 
> I've already submitted this patch and it has been signed off as bug 25606.
> 
> 2 - Could the results report which courses the items were deleted from, at
> the very least maybe the number of courses it was removed from?
> 
> This sounds reasonable. I'll look into adding it.
> 
> 3 - I would rather see this use Objects, but CourseReserves could use a
> refactor as a whole
> 
> I'm not sure what Objects you are referring to. Any information you can
> provide would be great.
> 
> Thanks,
> Joe

For #3 I meant using:
Koha::Course::Reserve->find({itemnumber=> $item->id});
instead of:
GetItemCourseReservesInfo(itemnumber => $item->id);

Probably we should have a 'course_reserves' function in Item.pm or something,
but I think that is beyond scope here

-- 
You are receiving this mail because:
You are watching all bug changes.