[Koha-bugs] [Bug 23091] Add options to charge new or restore forgiven overdues when a lost item is returned

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23091

--- Comment #39 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Sorry Andrew, looks like I didn't catch you early enough there.. I spotted a
couple of nasty failure cases which I'm working through... It's turning into a
bit of an unravelling thread.

For the new charge, we need to fetch an old issue if any of the
MarkLostItemReturned values are involved... I think that's the case that caught
you.. 

My test environment had those all disabled for some reason.. a DB reset meant I
suddenly saw your failure cases.

I'll take a look at your other comments and embellish the t at plan a bit
further tomorrow when I'm fresh.  There's soooo many syspref interactions at
play here I hadn't fully appreciated when I embarked down this path.

Also, a question for you.. what should happen in the case where they have the
system set to not forgive fines and to also charge a fresh fine on return of a
lost item.. if feels like a mis-configuration at that point to me but should we
catch that case and just fallback to doing nothing or should we niavely
continue to charge a fresh fine on top so the patron would end up with two
fines.. one dated up to the date when the item was marked lost and then a
second dated up to the date it was marked found again?

-- 
You are receiving this mail because:
You are watching all bug changes.