[Koha-bugs] [Bug 25723] Improve efficiency of holiday calculation

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25723

--- Comment #54 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
(In reply to Nick Clemens from comment #53)
> Created attachment 107000 [details] [review]
> Bug 25723: (QA follow-up)  Handle holiday and exception on same day
> 
> When a holiday is entered, then exceptions generated on a range, there
> exists both a holiday and exception in
> the special holidays table. We should cache the exception over the holiday
> instead of both
> 
> Also, !1 in perl returns '' rather than 0, so we should explicitly set the
> value
> 
> Add blank line to clear pod error from qa tools
> 
> Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

Good catch and an elegant solution.. thanks :)

-- 
You are receiving this mail because:
You are watching all bug changes.