[Koha-bugs] [Bug 24683] Holds on biblios with different item types: rules for holds allowed are not applied correctly if any item type is available

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24683

--- Comment #20 from Andrew Nugged <nugged at gmail.com> ---
(In reply to Jonathan Druart from comment #10)
> Technical comments:

> * perltidy a bit the tests

done

> * add tests in a subtest

done

> * AddReturn statement is not needed

done

> * it would be great to have IsAvailableForItemLevelRequest tested as well
> (just in case, especially because we are lacking test coverage for this circ
> rule!

done + also because this I propose (last 107076 patch) some clarification
in subroutine description (I agree that's tricky logic but I reversed up by
calls through code and that how it made and looks expected this sub behavior,
so I just decided to note this in sub desc).

Also, Jonathan: this have one more integral update: optimization added to cut
of loop if first available found: thanks for Joonas for the idea.

-- 
You are receiving this mail because:
You are watching all bug changes.