[Koha-bugs] [Bug 24160] Short loan collection holds

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24160

--- Comment #6 from Joonas Kylmälä <joonas.kylmala at helsinki.fi> ---
(In reply to Jonathan Druart from comment #5)
> As I wrote in the commit message, moving this code to a module is not
> trivial and is, imo, out of the scope of this bug report.
> This is a bugfix for a code that existed already in the controller. I am the
> one to blame for the original code (bug 17453), but at that time it was
> already tricky to have the code in a module, the whole script needs to be
> rewritten/redesigned.

Are you sure? Please see in C4::Reserves IsAvailableForItemLevelRequest(). You
can pass pickup branch there too and it follows the circ rules. So now that I
studied the problem description here more, I think removing bunch of code from
the opac-reserve.pl and adding in the already existing call to
IsAvailableForItemLevelRequest() just the the pickup branch parameter fixes
this. This way even the syspref OPACHoldsIfAvailableAtPickup can be dropped
since it has no effect. There might be a gotcha here but I have not come across
any yet so my stance on not approving this patch as-it-is still stands.

-- 
You are receiving this mail because:
You are watching all bug changes.