[Koha-bugs] [Bug 19909] Show attributes in patron search results

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19909

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Failed QA

--- Comment #15 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Salut Julian,

Could you add a unit test and replace 
+            $patron->{attributes} = Koha::Patron::Attributes->search({
borrowernumber => $patron_object->borrowernumber });

with a call to $patron->extended_attributes?


Also a question:
  const extendedAttributesColumnIndex = columns_settings.findIndex(column =>
column.columnname === 'extended_attributes');
  columns_settings.splice(extendedAttributesColumnIndex, 1);

findIndex returns -1 if not found. It should not happen I'd say, but should not
we prevent side-effects and check if extendedAttributesColumnIndex != -1?

-- 
You are receiving this mail because:
You are watching all bug changes.