[Koha-bugs] [Bug 25711] Add ability to define expiredpickup charge for patron category and item type

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25711

--- Comment #1 from Peter Vashchuk <stalkernoid at gmail.com> ---
Created attachment 107144
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107144&action=edit
Bug 25711: add ExpireReservesMaxPickUpDelayCharge to circulation rules

Add a feature that allows to define ExpireReservesMaxPickUpDelayCharge 
in circulation rules per specific items/patron categories. 
When it’s undefined in circulation rules it uses global 
ExpireReservesMaxPickUpDelayCharge which was used before this feature 
was introduced.

To check the feature after applying the patch:
    1) Go to /cgi-bin/koha/admin/preferences.pl and set
ExpireReservesMaxPickUpDelay to allow.
    1) Go to /cgi-bin/koha/admin/smart-rules.pl circulation rules table
and notice the newly added “Expire reserve charge” row.
    2) In that row add numerical values to type/patron categories
that you will be using later to test this feature.
    3) Prepare an item for our next step, pick a biblio that has item
with the same itemtype you altered in smart rules and check it out.
    3) Place a hold on that item and set the expiration date as the
next day.
    4) Check in it after that.
    5) Do SQL request to change expiration date manually to "yesterday":
in "reserves" table, find the id of the hold that you placed and
"UPDATE reserves SET `expirationdate`='2020-07-19' WHERE 
`reserve_id`=329;"
 Or alternatively:
    5) Wait for tomorrow, change server time or invent a time machine.
    6) Run cancel_expired_holds.pl cron job. 
    7) Check that patron got charged in "accounting" left tab and
"transactions" upper tab: your patron should have debt of that amount 
of fee you assigned in that rule 
(/cgi-bin/koha/members/boraccount.pl?borrowernumber=...YourPatronID...)
    8) You can repeat this with other rules and different 
numbers/biblio/item types to check that different fees apply according 
to smart rules.
    9) If no smart rule will be found or smart rules have an "empty" 
fee – global ExpireReservesMaxPickUpDelayCharge variable value 
will be used.

IMPORTANT:
Different actions when rules applied to biblio and item level holds:
- if there is biblio-level hold ("next available") 
then biblio item type used for rule preselection
- if there is direct item-level hold for particular barcode, 
then item "item type" will be used for rule preselection
In most cases we have the same items as biblio item types, 
but in case there's different item types: 
be accurate and attentive with rules creation and overlapping.

Mentored-by: Andrew Nugged <nugged at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.