[Koha-bugs] [Bug 17704] Fix OAI breakage when using HTTP::OAI 4.03+

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17704

--- Comment #20 from David Cook <dcook at prosentient.com.au> ---
Comment on attachment 75331
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75331
Bug 17704: Adapt Koha::OAI::* to the new HTTP::OAI api

Review of attachment 75331:
 --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=17704&attachment=75331)
-----------------------------------------------------------------

::: Koha/OAI/Server/Repository.pm
@@ +152,5 @@
> +            Handler => my $builder = XML::LibXML::SAX::Builder->new()
> +        );
> +
> +    $self->{ driver  } = $driver;
> +    $self->{ builder } = $builder;

Tomas, did you put driver and builder here for a specific purpose? I'm guessing
for testing purposes? I don't see any functional reason otherwise?

@@ +156,5 @@
> +    $self->{ builder } = $builder;
> +
> +    $driver->start_oai_pmh();
> +
> +    $response->set_handler($w);

I don't understand the purpose of this, but I noticed it in the
HTTP::OAI::Repository example, so I imagine it must be necessary.

I find HTTP::OAI to be an unnecessarily arcane library, and since it's just a
couple lines here, it's probably not worth taking the time to interrogate it
too closely...

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.