[Koha-bugs] [Bug 25855] Add hook to AddRenewal using a new _after_circ_actions method in circulation

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25855

--- Comment #23 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
(In reply to Jonathan Druart from comment #19)
> A couple of questions:
> 
> 1. Why do we have the hook before UpdateStats and logaction?
> We could imagine a plugin that want to deal with them, and so get up-to-date
> info
>
> 2. A renewal is identified by an issue_id, why don't we only pass the
> issue_id to the plugin?
> It could then retrieve the info it wants.
> We should limit the number of params we pass, we only need to inform the
> plugin "yeah, we've just renewed this!".
> It will make the plugins' api more robust and maintainable IMO.

Those are valid questions. About the stats calls, I only copied what we already
do. 

The most relevant information is the issue_id and the new date due. My
impression was that we could send all the info we already had. In my case I
needed the itemnumber and date due so my plugin notified a third party system
and no extra call to the DB is required.

-- 
You are receiving this mail because:
You are watching all bug changes.