[Koha-bugs] [Bug 25193] Add syspref to control location for use of AllowRenewalIfOtherItemsAvailable

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25193

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl
                   |y.org                       |
             Status|Signed Off                  |Failed QA

--- Comment #7 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Aleisha,

Have some concern about the interaction of both sysprefs and if the interface
now helps us to understand it well..

AllowRenewalIfOtherItemsAvailable / AllowRenewalIfOtherItemsAvailableLocation   
Dont allow / Allow
a patron to renew an item with unfilled holds if other available items 
at any branch / at the hold's pickup branch
can fill that hold. 

If the pref is set to Allow, we may examine the other pref. But if we say Do
not allow we now suggest that it is conditional depending on the second pref.
But that is not the case:
    if ( $resfound
        && C4::Context->preference('AllowRenewalIfOtherItemsAvailable') )
    {

I wonder if we confuse people? How could we improve that?

Another question: Would holding branch be a better wording?

Changing status for feedback.

-- 
You are receiving this mail because:
You are watching all bug changes.