[Koha-bugs] [Bug 25711] Add ability to define expiredpickup charge for patron category and item type

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25711

--- Comment #2 from Joonas Kylmälä <joonas.kylmala at helsinki.fi> ---
Comment on attachment 107144
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107144
Bug 25711: add ExpireReservesMaxPickUpDelayCharge to circulation rules

Review of attachment 107144:
 --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=25711&attachment=107144)
-----------------------------------------------------------------

In addition the the other comments, the expire_reserves_charge is missing from
installer/data/mysql/kohastructure.sql.

::: Koha/Hold.pm
@@ +372,5 @@
>              C4::Reserves::_FixPriority({ biblionumber => $self->biblionumber });
>  
> +            my $item = $self->item;
> +
> +            my $controlbranch = C4::Context->preference('ReservesControlBranch');

This and the code below should use C4::Reserves::GetReservesControlBranch()

@@ +384,5 @@
> +
> +            my $rule = Koha::CirculationRules->get_effective_rule(
> +                {
> +                    categorycode => $self->borrower->categorycode,
> +                    itemtype     => $item ? $item->effective_itemtype : $self->biblio->itemtype,

Should use instead the syspref item-level_itypes

::: t/db_dependent/Holds/Holdfine.t
@@ +1,1 @@
> +#!/usr/bin/perl

License header and copyright info is missing.

-- 
You are receiving this mail because:
You are watching all bug changes.