[Koha-bugs] [Bug 25273] Elasticsearch Authority matching is returning too many results

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25273

--- Comment #19 from Nick Clemens <nick at bywatersolutions.com> ---
(In reply to Julian Maurice from comment #15)
> (In reply to Nick Clemens from comment #14)
> > 1 - Yes, was trying to save a call to GuessAuthType, reverted
> GuessAuthTypeCode only checks in its hardcoded list of authtypecodes, it
> doesn't even check if the auth type code exist in database. If someone use
> custom authority types, this will probably break.
> 
> There is get_auth_type_location but it needs the authtypecode... so we
> cannot use it to find the authtypecode in the MARC record.
> 
> It seems that the only way to get the correct information is to get it
> directly from database using the authid (SELECT authtypecode WHERE authid =
> ?)
> Or maybe it would be better to pass a Koha::Object (Koha::Authority or
> Koha::Biblio) to the indexer, so we can retrieve easily the authtypecode and
> the MARC::Record but that would probably require rewriting some parts of the
> indexation code.
> 
> I'm not sure where to go on this one. It clearly shows that passing the
> MARC::Record alone to the indexer is not enough.
> Any thoughts ?

Custom authorites don't work in C4/Headings.pm either - the lists of subfields
are hardcoded - I think that should be its own bug.

This issue affects stable branches and we should fix it for standard
authorities then tackle custom I believe as it will be a bigger job. We should
keep these small for backporting

-- 
You are receiving this mail because:
You are watching all bug changes.