[Koha-bugs] [Bug 15851] "Analytics: Show analytics" showing regardless of whether they have analytics

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15851

--- Comment #48 from David Cook <dcook at prosentient.com.au> ---
(In reply to Tomás Cohen Arazi from comment #47)
> I take it as a compliment-ish comment, thanks :-P
>

I'm sure that you know that I think the world of you, Tomás <3. Heh.

> Can you give me the query so I can try on my databases as well?
> 

Actually, now that I look at it, I gave it a bad query. I tried
"local-number=1000" thinking I had it set up for CCL2RPN, but it actually tried
that as a PQF query. It got 0 hits, but it searched it as "local and number and
1000" with subquery results of 250,000, 125,000 and 20,000 respectively in
0.435 seconds.

I just tried searching "the" and it took 5.16 seconds to return a result with
1,125,000 hits.

I just tried "local" and got 250,000 hits in 0.193 seconds. 

Note that this is all using yaz-client and a unix socket (rather than a TCP
socket).

I wonder if doing a CCL2RPN conversion adds much overhead... I'll try that and
add another separate comment, as this one is growing too large.

> > For some people, adding .432 seconds to web page load time is unacceptable,
> > but I imagine most of us might not care too much.
> 
> I'd agree. We could make it an opt-in feature? PreciseAnalyticsLink or smth.
> 
> > I'd argue that this lookup should be performed asynchronously after the HTML
> > page has loaded.
> > 
> > The MARC data could trigger whether to show an "Analytics" label I suppose,
> > and then the result of the async lookup would say something like "Show
> > Analytics" or "None" or something like that. 
> > 
> > Anyway, that's just a thought. I'm not interested in doing any work on this.
> > I'm just always interested in performance. 
> > 
> > The current patches are fine, so I'm not being critical, but I think an
> > optimization would be to do an async lookup.
> 
> I like the idea. Will draft an endpoint for fetching such information using
> the exact queries we use here.

If we're doing it async, I don't think we'd need it to be an opt-in feature, as
it would already be optimized. 

And thanks for drafting that!

-- 
You are receiving this mail because:
You are watching all bug changes.