From bugzilla-daemon at bugs.koha-community.org Mon Jun 1 01:25:04 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 31 May 2020 23:25:04 +0000 Subject: [Koha-bugs] [Bug 25632] New: Update MARC21 frameworks to update Nr. 30 (May 2020) Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25632 Bug ID: 25632 Summary: Update MARC21 frameworks to update Nr. 30 (May 2020) Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: MARC Bibliographic data support Assignee: koha-bugs at lists.koha-community.org Reporter: bgkriegel at gmail.com QA Contact: testopia at bugs.koha-community.org A few changes in bibliographic data format. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 1 01:54:45 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 31 May 2020 23:54:45 +0000 Subject: [Koha-bugs] [Bug 25632] Update MARC21 frameworks to update Nr. 30 (May 2020) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25632 --- Comment #1 from Bernardo Gonzalez Kriegel --- Created attachment 105448 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105448&action=edit Bug 25632: Update MARC21 frameworks to update Nr. 30 (May 2020) New subfields 0 1 2 in 310 and 321 Changes 310 change to repeatable 883 renamed 883 a d q renamed To test: 1) Remove bibliographic frameworks 2) Check mandatory bibliographic fw load without problem misc/load_yaml.pl --load --file=installer/data/mysql/en/marcflavour/marc21/mandatory/marc21_framework_DEFAULT.yml 3) Check new/renamed fields/subfields -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 1 01:56:15 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 31 May 2020 23:56:15 +0000 Subject: [Koha-bugs] [Bug 25632] Update MARC21 frameworks to update Nr. 30 (May 2020) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25632 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Assignee|koha-bugs at lists.koha-commun |bgkriegel at gmail.com |ity.org | Severity|enhancement |trivial Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Jun 1 02:13:49 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Jun 2020 00:13:49 +0000 Subject: [Koha-bugs] [Bug 25632] Update MARC21 frameworks to update Nr. 30 (May 2020) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25632 --- Comment #2 from Bernardo Gonzalez Kriegel --- Created attachment 105449 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105449&action=edit Bug 25632: [19.11] Update MARC21 frameworks to update Nr. 30 (May 2020) For version <= 19.11 New subfields 0 1 2 in 310 and 321 Changes 310 change to repeatable 883 renamed 883 a d q renamed To test: 1) Remove bibliographic frameworks 2) Check mandatory bibliographic fw load without problem 3) Check new/renamed fields/subfields -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 1 03:55:56 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Jun 2020 01:55:56 +0000 Subject: [Koha-bugs] [Bug 25625] Google Assistant/Voice command In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25625 --- Comment #2 from Viral --- Thanks for your comment. Usually, we give input into OPAC for searching items, if we can automate the search input through voice command it will help a lot. Means, user do not need to type the book details. Additionally, if Google Assistant has configured properly, it will work to search Multilingual books. Google Assistant does provide regional language support and at present Google Assistant is available in English, French, German, Hindi, Indonesian, Italian, Japanese, Korean, Portuguese (Brazilian), Spanish, Swedish, and Vietnamese and more languages are coming soon. Now hypothetically, if we have books details in Indonesian language(bahasa Indonesia) and library staff catalogued the books into bahasa Indonesia with UTF font, then by taking input from Google Assistant we can generate the searching string in bahasa Indonesia. It will be very much helpful to the people who are having less typing skills for Non-English language. It may also going to help visually challenged users. Looking into Koha, it gives UTF font support for all the languages, so my idea is if we can take search input from Google Assistant and insert it into OPAC search box as string and then make a search it may get work out. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Jun 1 05:03:29 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Jun 2020 03:03:29 +0000 Subject: [Koha-bugs] [Bug 25591] Update list-deps for Debian 10 and Ubuntu 20.04 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25591 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #105397|0 |1 is obsolete| | --- Comment #28 from Mason James --- Created attachment 105450 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105450&action=edit Bug 25591: Update list-deps for Debian 10 and Ubuntu 20.04 update list-deps for libcpan-meta-perl package -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 1 05:48:57 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Jun 2020 03:48:57 +0000 Subject: [Koha-bugs] [Bug 25591] Update list-deps for Debian 10 and Ubuntu 20.04 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25591 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #105397|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 1 05:56:55 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Jun 2020 03:56:55 +0000 Subject: [Koha-bugs] [Bug 25633] New: Update debian/control.ini file Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25633 Bug ID: 25633 Summary: Update debian/control.ini file Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Packaging Assignee: koha-bugs at lists.koha-community.org Reporter: mtj at kohaaloha.com QA Contact: testopia at bugs.koha-community.org CC: mirko at abunchofthings.net This patch updates the debian/control.ini file for the 20.05 release cycle -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 1 05:59:21 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Jun 2020 03:59:21 +0000 Subject: [Koha-bugs] [Bug 25633] Update debian/control.ini file for 20.05 release cycle In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25633 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Update debian/control.ini |Update debian/control.ini |file |file for 20.05 release | |cycle -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 1 05:59:59 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Jun 2020 03:59:59 +0000 Subject: [Koha-bugs] [Bug 25633] Update debian/control.ini file for 20.05 release cycle In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25633 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |mtj at kohaaloha.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Jun 1 06:01:31 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Jun 2020 04:01:31 +0000 Subject: [Koha-bugs] [Bug 25633] Update debian/control.ini file for 20.05 release cycle In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25633 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |String patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 1 06:01:34 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Jun 2020 04:01:34 +0000 Subject: [Koha-bugs] [Bug 25633] Update debian/control.ini file for 20.05 release cycle In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25633 --- Comment #1 from Mason James --- Created attachment 105451 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105451&action=edit Bug 25633: Update debian/control.ini file for 20.05 release cycle update maintainer details -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 1 06:01:56 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Jun 2020 04:01:56 +0000 Subject: [Koha-bugs] [Bug 25633] Update debian/control.ini file for 20.05 release cycle In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25633 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 - low |P1 - high Severity|normal |blocker -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 1 07:07:06 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Jun 2020 05:07:06 +0000 Subject: [Koha-bugs] [Bug 17532] koha-shell -c does not propagate the error code In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17532 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au --- Comment #17 from David Cook --- This has a perhaps unforeseen consequence with koha-foreach. Since koha-foreach uses "set -e", if 1 instance runs a command with koha-shell which has a non-zero status, koha-foreach exits. If you have 10 instances and the 1st produces an error, the other 9 instances won't have their commands run at all. (https://www.gnu.org/software/bash/manual/html_node/The-Set-Builtin.html#The-Set-Builtin) I can't imagine that's what we'd want to do? I'll open a new bug report. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 1 07:13:18 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Jun 2020 05:13:18 +0000 Subject: [Koha-bugs] [Bug 25634] New: koha-foreach exits if 1 command has non-zero status Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25634 Bug ID: 25634 Summary: koha-foreach exits if 1 command has non-zero status Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs at lists.koha-community.org Reporter: dcook at prosentient.com.au QA Contact: testopia at bugs.koha-community.org In 19.11.05 (and certainly other versions affected by Bug 17532), koha-foreach will exit early if 1 command for 1 instance has a non-zero status. It seems to me that we should warn on a failure, but we should continue the for loop, because the failure could be instance (rather than system) specific. In my case, /usr/share/koha/bin/cronjobs/overdue_notices.pl isn't running for most instances, because one of the instances starting with A is encountering this error: "No branches with active overduerules at /usr/share/koha/bin/cronjobs/overdue_notices.pl line 347". While I'll address that individually, it's an unfortunate consequence of Bug 17532 to ditch out early. I'm thinking the easiest solution would be to remove "set -e" from koha-foreach, and warn on individual failures. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Jun 1 07:13:29 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Jun 2020 05:13:29 +0000 Subject: [Koha-bugs] [Bug 25634] koha-foreach exits if 1 command has non-zero status In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25634 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |17532 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17532 [Bug 17532] koha-shell -c does not propagate the error code -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 1 07:13:29 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Jun 2020 05:13:29 +0000 Subject: [Koha-bugs] [Bug 17532] koha-shell -c does not propagate the error code In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17532 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |25634 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25634 [Bug 25634] koha-foreach exits if 1 command has non-zero status -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 1 07:19:16 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Jun 2020 05:19:16 +0000 Subject: [Koha-bugs] [Bug 25634] koha-foreach exits too early if any command has non-zero status In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25634 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|koha-foreach exits if 1 |koha-foreach exits too |command has non-zero status |early if any command has | |non-zero status -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Jun 1 07:24:40 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Jun 2020 05:24:40 +0000 Subject: [Koha-bugs] [Bug 17084] Automatic debian/control updates (master) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17084 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #105313|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 1 07:24:49 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Jun 2020 05:24:49 +0000 Subject: [Koha-bugs] [Bug 17084] Automatic debian/control updates (master) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17084 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #105314|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 1 07:24:55 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Jun 2020 05:24:55 +0000 Subject: [Koha-bugs] [Bug 17084] Automatic debian/control updates (master) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17084 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #105409|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 1 07:25:04 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Jun 2020 05:25:04 +0000 Subject: [Koha-bugs] [Bug 17084] Automatic debian/control updates (master) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17084 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #105416|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 1 07:25:17 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Jun 2020 05:25:17 +0000 Subject: [Koha-bugs] [Bug 17084] Automatic debian/control updates (master) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17084 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|mirko at abunchofthings.net |mtj at kohaaloha.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 1 07:26:42 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Jun 2020 05:26:42 +0000 Subject: [Koha-bugs] [Bug 17084] Automatic debian/control updates (master) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17084 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 1 07:26:46 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Jun 2020 05:26:46 +0000 Subject: [Koha-bugs] [Bug 17084] Automatic debian/control updates (master) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17084 --- Comment #60 from Mason James --- Created attachment 105452 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105452&action=edit Bug 17084: Automatic debian/control updates (master) update for 20.05 release cycle -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 1 07:27:09 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Jun 2020 05:27:09 +0000 Subject: [Koha-bugs] [Bug 17084] Automatic debian/control updates (master) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17084 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|trivial |blocker Priority|P5 - low |P1 - high -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 1 07:28:39 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Jun 2020 05:28:39 +0000 Subject: [Koha-bugs] [Bug 17084] Automatic debian/control updates (master) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17084 --- Comment #61 from Mason James --- (In reply to Victor Grousset/tuxayo from comment #58) > Thanks for the clarifications, I'll double check. > > > conflict in debian/control hi folks my patches are applied to the v20.05.00 tag -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 1 07:31:30 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Jun 2020 05:31:30 +0000 Subject: [Koha-bugs] [Bug 25635] New: overdue_notices.pl dies if no overdue rules are defined Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25635 Bug ID: 25635 Summary: overdue_notices.pl dies if no overdue rules are defined Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs at lists.koha-community.org Reporter: dcook at prosentient.com.au QA Contact: testopia at bugs.koha-community.org overdue_notices.pl dies if no overdue rules are defined, but there are many cases where you might not want any overdue rules to be defined. (If you're running overdue_notices.pl within koha-foreach, koha-foreach will now die on the first instance it encounters that has no overdue rules defined.) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 1 07:31:36 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Jun 2020 05:31:36 +0000 Subject: [Koha-bugs] [Bug 25635] overdue_notices.pl dies if no overdue rules are defined In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25635 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=25634 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Jun 1 07:31:36 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Jun 2020 05:31:36 +0000 Subject: [Koha-bugs] [Bug 25634] koha-foreach exits too early if any command has non-zero status In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25634 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=25635 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Jun 1 07:33:35 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Jun 2020 05:33:35 +0000 Subject: [Koha-bugs] [Bug 25634] koha-foreach exits too early if any command has non-zero status In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25634 --- Comment #1 from David Cook --- I suppose there might be times where you want a koha-foreach to die if any command fails, but perhaps we should add a flag to koha-foreach for that scenario... -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Jun 1 07:38:19 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Jun 2020 05:38:19 +0000 Subject: [Koha-bugs] [Bug 25634] koha-foreach exits too early if any command has non-zero status In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25634 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |dcook at prosentient.com.au |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 1 07:55:54 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Jun 2020 05:55:54 +0000 Subject: [Koha-bugs] [Bug 25634] koha-foreach exits too early if any command has non-zero status In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25634 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 1 07:55:56 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Jun 2020 05:55:56 +0000 Subject: [Koha-bugs] [Bug 25634] koha-foreach exits too early if any command has non-zero status In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25634 --- Comment #2 from David Cook --- Created attachment 105453 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105453&action=edit Bug 25634: Warn if koha-shell returns non-zero in koha-foreach By putting koha-shell in an if statement, "set -e" will no longer cause the entire koha-foreach program to exit, if koha-shell returns a non-zero status. If a non-zero status is returned, we warn on it, and the caller of koha-foreach can interpret that command visually. To Test: 1) Write a shell script that says "Hello" and then exits with a 1 status 2) Run koha-foreach against that shell script with multiple instances available to koha-foreach 3) Before the patch, koha-foreach will die after the first "Hello" 4) After the patch, koha-foreach will continue, through all the instances, and report which instances returned non-zero statuses by which command. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 1 07:57:36 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Jun 2020 05:57:36 +0000 Subject: [Koha-bugs] [Bug 25634] koha-foreach exits too early if any command has non-zero status In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25634 --- Comment #3 from David Cook --- (In reply to David Cook from comment #0) > I'm thinking the easiest solution would be to remove "set -e" from > koha-foreach, and warn on individual failures. Actually, the easiest solution was to wrap koha-shell in an if statement ad just warn on what instance and command return a non-zero status. "set -e" won't exit if the non-zero status is returned by a command wrapped by an if statement. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 1 09:37:33 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Jun 2020 07:37:33 +0000 Subject: [Koha-bugs] [Bug 25637] New: I am DarkSoul Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25637 Bug ID: 25637 Summary: I am DarkSoul Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Browser compatibility Assignee: oleonard at myacpl.org Reporter: mrqueenara367 at gmail.com QA Contact: testopia at bugs.koha-community.org Created attachment 105455 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105455&action=edit Bye -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 1 09:51:36 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Jun 2020 07:51:36 +0000 Subject: [Koha-bugs] [Bug 25292] L1 cache too long in Z3950 server (z3950-responder) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25292 --- Comment #6 from Jonathan Druart --- This is all what I do: ZOOM>connect localhost:2100 ZOOM>set databaseName biblios ZOOM>search x localhost:2100: 18 hits # Change the syspref SearchEngine ZOOM>search x localhost:2100: 230 hits This is a ugly way of confirming that the correct value has been retrieve, but you could add a warn statement in the code, in search_handler, to check which value from cache (so easy to test is a syspref) is retrieved. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 1 09:52:51 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Jun 2020 07:52:51 +0000 Subject: [Koha-bugs] [Bug 25508] Confusing renewal message when paying accruing fine In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25508 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |martin.renvoize at ptfs-europe |ity.org |.com CC| |martin.renvoize at ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Jun 1 09:58:45 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Jun 2020 07:58:45 +0000 Subject: [Koha-bugs] [Bug 25293] Don't call escapeHtml on null In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25293 George Veranis changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |gveranis at dataly.gr --- Comment #4 from George Veranis --- (In reply to Frédéric Demians from comment #2) > How an item can have a 'homebranch' field empty or how can a biblio record > have no title? A biblio can not have a title if you not entered in biblio framework , some cataloguers do that for some special records. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 1 10:03:23 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Jun 2020 08:03:23 +0000 Subject: [Koha-bugs] [Bug 25634] koha-foreach exits too early if any command has non-zero status In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25634 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #4 from Jonathan Druart --- I agree, should not we display the error code? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 1 10:27:41 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Jun 2020 08:27:41 +0000 Subject: [Koha-bugs] [Bug 25626] Translation issues with OPAC problem reports (status and 'sent to') In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25626 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Jun 1 10:27:44 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Jun 2020 08:27:44 +0000 Subject: [Koha-bugs] [Bug 25626] Translation issues with OPAC problem reports (status and 'sent to') In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25626 --- Comment #1 from Jonathan Druart --- Created attachment 105456 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105456&action=edit Bug 25626: Fix untranslatable strings on the 'OPAC problem reports' admin The 'Sent to' and 'Status' column values were not translatable. Test plan: Translate the interface Report some problems at the OPAC Go to the admin page and notice that all the columns are now translated -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Jun 1 10:27:59 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Jun 2020 08:27:59 +0000 Subject: [Koha-bugs] [Bug 25626] Translation issues with OPAC problem reports (status and 'sent to') In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25626 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |jonathan.druart at bugs.koha-c |ity.org |ommunity.org CC| |jonathan.druart at bugs.koha-c | |ommunity.org Severity|enhancement |minor -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Jun 1 10:33:36 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Jun 2020 08:33:36 +0000 Subject: [Koha-bugs] [Bug 25623] Some tests in oauth.t do not roll back In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25623 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |20624 CC| |jonathan.druart at bugs.koha-c | |ommunity.org Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20624 [Bug 20624] Disable the OAuth2 client credentials grant by default -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 1 10:33:36 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Jun 2020 08:33:36 +0000 Subject: [Koha-bugs] [Bug 20624] Disable the OAuth2 client credentials grant by default In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20624 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |25623 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25623 [Bug 25623] Some tests in oauth.t do not roll back -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 1 10:34:56 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Jun 2020 08:34:56 +0000 Subject: [Koha-bugs] [Bug 25623] Some tests in oauth.t do not roll back In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25623 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 1 10:35:00 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Jun 2020 08:35:00 +0000 Subject: [Koha-bugs] [Bug 25623] Some tests in oauth.t do not roll back In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25623 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #105438|0 |1 is obsolete| | --- Comment #3 from Jonathan Druart --- Created attachment 105457 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105457&action=edit Bug 25623: Make sure oauth.t rolls back the db This patch adds a missing transaction wrapping one of the subtests. This is probably an oversight when refactoring this file. To test: 1. Open the patron categories page 2. Run: $ kshell k$ prove t/db_dependent/api/v1/oauth.t => SUCCESS: Tests pass 3. Reload the patron categories page => FAIL: There's random data in there 4. Apply this patch and repeat 2 5. Reload the patron categories page => SUCCESS: The random data from the previous tests is still there, but no new random data => SUCCESS: Tests still pass 6. Sign off :-D Signed-off-by: Tomas Cohen Arazi Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 1 10:47:02 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Jun 2020 08:47:02 +0000 Subject: [Koha-bugs] [Bug 17084] Automatic debian/control updates (master) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17084 --- Comment #62 from Jonathan Druart --- (In reply to Mason James from comment #61) > (In reply to Victor Grousset/tuxayo from comment #58) > > Thanks for the clarifications, I'll double check. > > > > > > conflict in debian/control > > hi folks > my patches are applied to the v20.05.00 tag If I checkout v20.05.00 I don't see those patches. Is there something missing in master or you are talking about another repo? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 1 11:01:30 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Jun 2020 09:01:30 +0000 Subject: [Koha-bugs] [Bug 25513] Integer casting in Koha::Object->TO_JSON causes random test failures In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25513 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=25638 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 1 11:01:30 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Jun 2020 09:01:30 +0000 Subject: [Koha-bugs] [Bug 25638] New: API related tests failing on comparing floats Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25638 Bug ID: 25638 Summary: API related tests failing on comparing floats Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Test Suite Assignee: chris at bigballofwax.co.nz Reporter: jonathan.druart at bugs.koha-community.org QA Contact: testopia at bugs.koha-community.org Failing on almost all jobs currently 23:42:46 koha_1 | # Failed test 'exact match for JSON Pointer ""' 23:42:46 koha_1 | # at t/db_dependent/api/v1/patrons_accounts.t line 95. 23:42:46 koha_1 | # Structures begin differing at: 23:42:46 koha_1 | # $got->{outstanding_debits}{lines}[0]{amount} = '50' 23:42:46 koha_1 | # $expected->{outstanding_debits}{lines}[0]{amount} = '50.000000' 23:42:46 koha_1 | 23:42:46 koha_1 | # Failed test 'exact match for JSON Pointer ""' 23:42:46 koha_1 | # at t/db_dependent/api/v1/patrons_accounts.t line 139. 23:42:46 koha_1 | # Structures begin differing at: 23:42:46 koha_1 | # $got->{outstanding_credits}{lines}[0]{amount} = '-10' 23:42:46 koha_1 | # $expected->{outstanding_credits}{lines}[0]{amount} = '-10.000000' 23:42:46 koha_1 | # Looks like you failed 2 tests of 12. 23:42:46 koha_1 | 23:42:46 koha_1 | # Failed test 'get_balance() tests' 23:42:46 koha_1 | # at t/db_dependent/api/v1/patrons_accounts.t line 153. 23:42:47 koha_1 | # Looks like you failed 1 test of 2. 23:42:47 koha_1 | [21:42:47] t/db_dependent/api/v1/patrons_accounts.t ................................ 23:42:47 koha_1 | Dubious, test returned 1 (wstat 256, 0x100) 23:42:47 koha_1 | Failed 1/2 subtests 23:43:12 koha_1 | 23:43:12 koha_1 | # Failed test 'SWAGGER3.3.2' 23:43:12 koha_1 | # at t/db_dependent/api/v1/acquisitions_orders.t line 129. 23:43:12 koha_1 | # Structures begin differing at: 23:43:12 koha_1 | # $got->{list_price} = '2.02412229767404e+21' 23:43:12 koha_1 | # $expected->{list_price} = '2024122297674040344576.000000' 23:43:14 koha_1 | 23:43:14 koha_1 | # Failed test 'Number representation should be consistent' 23:43:14 koha_1 | # at t/db_dependent/api/v1/acquisitions_orders.t line 154. 23:43:14 koha_1 | # Structures begin differing at: 23:43:14 koha_1 | # $got->{unit_price_tax_included} = '2.32181072793363e+21' 23:43:14 koha_1 | # $expected->{unit_price_tax_included} = '2321810727933630742528.000000' 23:43:14 koha_1 | # Looks like you failed 2 tests of 8. 23:43:14 koha_1 | 23:43:14 koha_1 | # Failed test 'get() tests' 23:43:14 koha_1 | # at t/db_dependent/api/v1/acquisitions_orders.t line 158. 23:43:22 koha_1 | # Looks like you failed 1 test of 5. 23:43:22 koha_1 | [21:43:22] t/db_dependent/api/v1/acquisitions_orders.t ............................. 23:43:22 koha_1 | Dubious, test returned 1 (wstat 256, 0x100) 23:43:22 koha_1 | Failed 1/5 subtests 23:43:50 koha_1 | 23:43:50 koha_1 | # Failed test 'SWAGGER3.3.2' 23:43:50 koha_1 | # at t/db_dependent/api/v1/items.t line 131. 23:43:50 koha_1 | # Structures begin differing at: 23:43:50 koha_1 | # $got->{purchase_price} = '742834.7' 23:43:50 koha_1 | # $expected->{purchase_price} = '742834.70' 23:43:50 koha_1 | # Looks like you failed 1 test of 9. 23:43:50 koha_1 | 23:43:50 koha_1 | # Failed test 'get() tests' 23:43:50 koha_1 | # at t/db_dependent/api/v1/items.t line 143. 23:43:50 koha_1 | # Looks like you failed 1 test of 2. 23:43:50 koha_1 | [21:43:50] t/db_dependent/api/v1/items.t -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 1 11:01:46 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Jun 2020 09:01:46 +0000 Subject: [Koha-bugs] [Bug 25638] API related tests failing on comparing floats In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25638 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|chris at bigballofwax.co.nz |tomascohen at gmail.com Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 1 11:03:13 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Jun 2020 09:03:13 +0000 Subject: [Koha-bugs] [Bug 25637] SPAM In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25637 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|I am DarkSoul |SPAM Status|NEW |RESOLVED Resolution|--- |INVALID -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 1 12:23:33 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Jun 2020 10:23:33 +0000 Subject: [Koha-bugs] [Bug 25635] overdue_notices.pl dies if no overdue rules are defined In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25635 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #1 from Jonathan Druart --- Yes, even with bug 25634 fixed I think we should replace the die with a warn+exit 0 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Jun 1 12:26:23 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Jun 2020 10:26:23 +0000 Subject: [Koha-bugs] [Bug 25635] overdue_notices.pl dies if no overdue rules are defined In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25635 --- Comment #2 from Katrin Fischer --- Is that a regression? We certainly have libraries without rules and multiple instances on servers... Having no rules should not be seen as a problem or error, it's just configuration. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 1 12:38:51 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Jun 2020 10:38:51 +0000 Subject: [Koha-bugs] [Bug 25635] overdue_notices.pl dies if no overdue rules are defined In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25635 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |17532 --- Comment #3 from Jonathan Druart --- The behaviour of the script has not been modified, but the consequence on koha-foreach comes from a change in koha-shell (bug 17532) Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17532 [Bug 17532] koha-shell -c does not propagate the error code -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 1 12:38:51 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Jun 2020 10:38:51 +0000 Subject: [Koha-bugs] [Bug 17532] koha-shell -c does not propagate the error code In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17532 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |25635 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25635 [Bug 25635] overdue_notices.pl dies if no overdue rules are defined -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 1 12:45:28 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Jun 2020 10:45:28 +0000 Subject: [Koha-bugs] [Bug 25635] overdue_notices.pl dies if no overdue rules are defined In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25635 --- Comment #4 from Katrin Fischer --- That explains why we haven't run into this yet on production systems. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 1 12:48:05 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Jun 2020 10:48:05 +0000 Subject: [Koha-bugs] [Bug 25639] New: Add search queries to HTML so queries can be retrieved via JS Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25639 Bug ID: 25639 Summary: Add search queries to HTML so queries can be retrieved via JS Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Notices Assignee: koha-bugs at lists.koha-community.org Reporter: nick at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org For integrations or custom code it would be nice to have access to the search strings used in Koha to the html, like loggedinbranch etc. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 1 12:50:47 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Jun 2020 10:50:47 +0000 Subject: [Koha-bugs] [Bug 17084] Automatic debian/control updates (master) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17084 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |24167 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24167 [Bug 24167] We should support installation on Debian 10 [OMNIBUS] -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 1 12:50:47 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Jun 2020 10:50:47 +0000 Subject: [Koha-bugs] [Bug 24167] We should support installation on Debian 10 [OMNIBUS] In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24167 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |17084 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17084 [Bug 17084] Automatic debian/control updates (master) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 1 12:51:03 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Jun 2020 10:51:03 +0000 Subject: [Koha-bugs] [Bug 25633] Update debian/control.ini file for 20.05 release cycle In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25633 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |24167 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24167 [Bug 24167] We should support installation on Debian 10 [OMNIBUS] -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 1 12:51:03 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Jun 2020 10:51:03 +0000 Subject: [Koha-bugs] [Bug 24167] We should support installation on Debian 10 [OMNIBUS] In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24167 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |25633 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25633 [Bug 25633] Update debian/control.ini file for 20.05 release cycle -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 1 12:51:37 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Jun 2020 10:51:37 +0000 Subject: [Koha-bugs] [Bug 25639] Add search queries to HTML so queries can be retrieved via JS In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25639 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 1 12:51:39 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Jun 2020 10:51:39 +0000 Subject: [Koha-bugs] [Bug 25639] Add search queries to HTML so queries can be retrieved via JS In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25639 --- Comment #1 from Nick Clemens --- Created attachment 105458 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105458&action=edit Bug 25639: Add query strings to html This development simply adds the contructed queries generated by Koha to the HTML source. This is useful for integrations like the Hoopla plugin: https://github.com/bywatersolutions/koha-plugin-hoopla To test: 1 - Search on OPAC for "qwertyuiop" 2 - View the HTML source 3 - Find 'qwertyuiop' in the source, it is not easily accessible via JS 4 - Apply patch 5 - Repeat 6 - Note that now there are spans with data elements containing the queries used by Koha 7 - Sign off -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 1 12:52:30 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Jun 2020 10:52:30 +0000 Subject: [Koha-bugs] [Bug 25640] New: [OMNIBUS] Ubuntu 20.04 support Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25640 Bug ID: 25640 Summary: [OMNIBUS] Ubuntu 20.04 support Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs at lists.koha-community.org Reporter: jonathan.druart at bugs.koha-community.org QA Contact: testopia at bugs.koha-community.org -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 1 12:53:21 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Jun 2020 10:53:21 +0000 Subject: [Koha-bugs] [Bug 25630] More capitalization and terminology fixes for system preferences In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25630 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |String patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 1 12:53:24 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Jun 2020 10:53:24 +0000 Subject: [Koha-bugs] [Bug 25630] More capitalization and terminology fixes for system preferences In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25630 --- Comment #2 from Katrin Fischer --- Created attachment 105459 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105459&action=edit Bug 25630: Fix capitalization and terminology for Staff interface system preferences This changes "staff client" to "staff interface" and fixes capitalization in a couple of cases. For terminology changes see: https://wiki.koha-community.org/wiki/Terminology#S To test: - Read through the preferences of the "staff interface" tab. - Staff interface should be used consistently. - Firefox "PlugIn" was changed to "add-on" reflecting Mozilla's own terminology. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 1 12:53:28 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Jun 2020 10:53:28 +0000 Subject: [Koha-bugs] [Bug 25630] More capitalization and terminology fixes for system preferences In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25630 --- Comment #3 from Katrin Fischer --- Created attachment 105460 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105460&action=edit Bug 25630: Fix capitalization and terminology fixes for Searching system preferences - Rephrases LoadSearchHistoryToTheFirstLoggedUser system preference - Consistently use "staff interface" - Add ending punctuation to some preferences To test: - Read through the Searching system preferences - Verify consistent use of staff interface - Verify LoadSearchHistoryToTheFirstLoggedUser description is improved -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 1 12:53:31 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Jun 2020 10:53:31 +0000 Subject: [Koha-bugs] [Bug 25630] More capitalization and terminology fixes for system preferences In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25630 --- Comment #4 from Katrin Fischer --- Created attachment 105461 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105461&action=edit Bug 25630: Fix capitalization and terminology for Acquisitions and Tools system preferences - Adds some ending punctuation - Fixes capitalization - Consistent use of "staff interface" To test: - Verify: - NewsAuthorDisplay - EmailPurchaseSuggestions - UseACQFrameworkForBiblioRecords - AcqItemSetSubfieldsWhenReceived - AcqItemSetSubfieldsWhenReceiptIsCancelled - OrderPriceRounding - read correctly. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 1 12:53:31 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Jun 2020 10:53:31 +0000 Subject: [Koha-bugs] [Bug 25641] New: Koha/XSLT/Base.t is failing on U20 Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25641 Bug ID: 25641 Summary: Koha/XSLT/Base.t is failing on U20 Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: minor Priority: P5 - low Component: Test Suite Assignee: jonathan.druart at bugs.koha-community.org Reporter: jonathan.druart at bugs.koha-community.org QA Contact: testopia at bugs.koha-community.org kohadev-koha at a72d3d9a1f4d:/kohadevbox/koha$ prove t/db_dependent/Koha/XSLT/Base.t t/db_dependent/Koha/XSLT/Base.t .. 1/33 # Failed test 'Malformed XML warning correctly displayed' # at t/db_dependent/Koha/XSLT/Base.t line 87. # found warning: XSLT::Base: :1: parser error : Opening and ending tag mismatch: a line 0 and b # expected to find warning: (?^u:parser error : Opening and ending tag mismatch: a line 1 and b) # Failed test 'Malformed XML warning correctly displayed' # at t/db_dependent/Koha/XSLT/Base.t line 99. # found warning: XSLT::Base: :1: parser error : Opening and ending tag mismatch: a line 0 and b # expected to find warning: (?^u:parser error : Opening and ending tag mismatch: a line 1 and b) # Failed test 'Malformed XML warning correctly displayed' # at t/db_dependent/Koha/XSLT/Base.t line 104. # found warning: XSLT::Base: :1: parser error : Opening and ending tag mismatch: a line 0 and b # expected to find warning: (?^u:parser error : Opening and ending tag mismatch: a line 1 and b) # Failed test 'Malformed XML warning correctly displayed' # at t/db_dependent/Koha/XSLT/Base.t line 110. # found warning: XSLT::Base: :1: parser error : Opening and ending tag mismatch: a line 0 and b # expected to find warning: (?^u:parser error : Opening and ending tag mismatch: a line 1 and b) # Looks like you failed 4 tests of 33. t/db_dependent/Koha/XSLT/Base.t .. Dubious, test returned 4 (wstat 1024, 0x400) Failed 4/33 subtests Test Summary Report ------------------- t/db_dependent/Koha/XSLT/Base.t (Wstat: 1024 Tests: 33 Failed: 4) Failed tests: 10, 12, 14, 16 Non-zero exit status: 4 Files=1, Tests=33, 1 wallclock secs ( 0.03 usr 0.01 sys + 0.44 cusr 0.04 csys = 0.52 CPU) Result: FAIL -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 1 12:53:35 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Jun 2020 10:53:35 +0000 Subject: [Koha-bugs] [Bug 25630] More capitalization and terminology fixes for system preferences In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25630 --- Comment #5 from Katrin Fischer --- Created attachment 105462 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105462&action=edit Bug 25630: Fix capitalization and terminology for Enhanced content and Web services system preferences - Fixes capitalization, including URL and OPAC - Consistent use of "staff interface" - Ending punctuation - Spelling: web service To test: - Verify: - Enhanced content page heading - Babeltheque_url_js - Babeltheque_url_update - FRBRizeEditions - BakerTaylorEnabled - NovelistSelectStaffProfile - NovelistSelectStaffEnabled - CustomCoverImages - LocalCoverImages - IntranetCoce - AutoShareWithMana - OAI-PMH:AutoUpdateSets - IdRef - read correctly. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 1 12:53:39 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Jun 2020 10:53:39 +0000 Subject: [Koha-bugs] [Bug 25630] More capitalization and terminology fixes for system preferences In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25630 --- Comment #6 from Katrin Fischer --- Created attachment 105463 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105463&action=edit Bug 25630: Fix capitalization and terminology for Patrons system preferences - Consistent use of 'staff interface' - Ending punctuation - Rearranged/rephrased for better readability To test: - Verify: - patronimages - PatronsPerPage (rearranged) - PatronQuickAddFields (rearranged) - PrefillGuaranteeField (punctuation) - borrowerRelationship (punctuation) - GDPR_Policy - CollapseFieldsPatronAddForm - read correctly. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 1 12:53:43 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Jun 2020 10:53:43 +0000 Subject: [Koha-bugs] [Bug 25630] More capitalization and terminology fixes for system preferences In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25630 --- Comment #7 from Katrin Fischer --- Created attachment 105464 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105464&action=edit Bug 25630: Fix capitalization and terminology for OPAC system preferences - Ending punctuation (p) - Capitalization (c) - Terminology: library instead of branch, patron instead of borrower, system preferences instead of syspref To test: - Verify: - OPACUserSummary (p, rephrase: mainpage) - HighlightOwnItemsOnOPACWhich (library) - OPACXSLTListsDisplay (p) - OPACXSLTResultsDisplay (p) - OPACXSLTDetailsDisplay (p) - OpacNoItemTypeImages (p) - NotHighlightedWords (p) - opaclayoutstylesheet (CSS) - OPACReportProblem (c) - OpacBrowser (p) - OpacCloud (p) - SocialNetworks (p) - QuoteOfTheDay (c,p) - OpacNewsLibrarySelect (library) - OPACFineNoRenewalsIncludeCredits (p) - AllowPurchaseSuggestionBranchChoice (p) - OpacHiddenItemsExceptions (p, patron) - OpacAllowPublicListCreation (p) - OpacAllowSharingPrivateLists (p) - BlockExpiredPatronOpacActions (whitespace) - MaxOpenSuggestions (p) - AnonSuggestions (p) - OPACPrivacy (p, whitespace) - AnonymousPatron (c,p) - TrackClicks (p) - RestrictedPageLocalIPs (p) - RestrictedPageTitle (p) - OpacAdvSearchOptions (p) - OpacAdvSearchMoreOptions (p) - PayPal* (p) - OPACUserSummary (mainpage to OPAC start page) - read correctly. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 1 12:53:46 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Jun 2020 10:53:46 +0000 Subject: [Koha-bugs] [Bug 25640] [OMNIBUS] Ubuntu 20.04 support In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25640 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |25591, 25641 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25591 [Bug 25591] Update list-deps for Debian 10 and Ubuntu 20.04 https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25641 [Bug 25641] Koha/XSLT/Base.t is failing on U20 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 1 12:53:47 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Jun 2020 10:53:47 +0000 Subject: [Koha-bugs] [Bug 25630] More capitalization and terminology fixes for system preferences In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25630 --- Comment #8 from Katrin Fischer --- Created attachment 105465 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105465&action=edit Bug 25630: Fix capitalization and terminology for Logs and I18N system preferences - (Ending) punctuation (p) - Capitalization (p) - Terminology To test: - Verify: - alphabet (p) - TranslateNotics (c) - IllLog (p) - ReturnLog (returned to checked in) - DumpTemplateVars* (HTML) - read correctly. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 1 12:53:46 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Jun 2020 10:53:46 +0000 Subject: [Koha-bugs] [Bug 25591] Update list-deps for Debian 10 and Ubuntu 20.04 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25591 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |25640 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25640 [Bug 25640] [OMNIBUS] Ubuntu 20.04 support -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 1 12:53:46 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Jun 2020 10:53:46 +0000 Subject: [Koha-bugs] [Bug 25641] Koha/XSLT/Base.t is failing on U20 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25641 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |25640 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25640 [Bug 25640] [OMNIBUS] Ubuntu 20.04 support -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 1 12:53:51 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Jun 2020 10:53:51 +0000 Subject: [Koha-bugs] [Bug 25630] More capitalization and terminology fixes for system preferences In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25630 --- Comment #9 from Katrin Fischer --- Created attachment 105466 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105466&action=edit Bug 25630: Fix capitalization and terminology for Circulation system preferences - (Ending) punctuation (p) - Terminology - Capitalization (c) To test: - Verify: - CircSidebar (c) - itemBarcodeInputFilter (from to form) - HoldsToPullStartDate (preference to system preference) - NoticeCSS (c) - UpdateTotalIssuesOnCirc (issues to checkouts) - ExportRemovefields (p) - AllowItemsOnHoldCheckoutSIP (c) - OnSiteCheckoutAutoCheck (onsite to on-site) - AllowOfflineCirculation (plugin to add-on) - AllowFineOverride (add 'system preference') - AutomaticItemReturn (returned to checked in) - UseTransportCostMatrix (branches to libraries) - AllowReturnToBranch (materials to items, return to checkin) - RenewalSendNotice (clarify 'messaging preference for 'Item checkout') - TransfersMaxDaysWarning (c) - noissuescharge (books to items) - *NoissuesCharge (add 'system preference') - ReturnBeforeExpiry (books to items) - NoticeBcc (p) - OverdueNoticeCalendar (c, p) - OverduesBlockCirc (p) - DefaultLongOverdueChargeValue (whitespace after :) - OPACFineNoRenewalsBlockAutoRenew (c) - RenewAccruingItemWhenPaid (p, c, syspref to system preference) - RenewAccruingItemInOpac (p, c, syspref to system preference) - HoldsSplitQueue (staff interface) - StaffSearchResultsDisplayBranch (staff interface, rephrase) - HidePersonalPatronDetailOnCirculation (rephrase) - StoreLastBorrower (add 'system preferences') - HoldsSplitQueue (& to and, staff interface) - HouseboundModule (p) - StockRotation (p) - ArticleRequests* (p) - ClaimReturnedLostValue (rephrase) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 1 12:53:54 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Jun 2020 10:53:54 +0000 Subject: [Koha-bugs] [Bug 25630] More capitalization and terminology fixes for system preferences In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25630 --- Comment #10 from Katrin Fischer --- Created attachment 105467 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105467&action=edit Bug 25630: Fix capitalization and terminology for Authorities and Cataloging system preferences - Punctuation (p) - Terminology - Capitalization (c) To test: - Verify: - AuthDisplayHierarchy (biblio to bibliographic) - MARCAuthorityControlField008 (p) - UNIMARCAuthorityField100 (p) - LinkerModule (c) - LinkerOptions (p) - SpineLabelShowPrintOnBibDetails (bib to bibliographic) - DefaultLanguageField008 (p) - DefaultCountryField008 (p) - SubfieldsToAllowForRestricted* (p, rephrase) - URLLinkText (added 'and items' - new with 20.05) - IntranetBiblioDefaultView (c) - MergeReportFields (rephrase) - BibtexExportAdditionalFields (marc to MARC) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 1 12:53:58 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Jun 2020 10:53:58 +0000 Subject: [Koha-bugs] [Bug 25630] More capitalization and terminology fixes for system preferences In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25630 --- Comment #11 from Katrin Fischer --- Created attachment 105468 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105468&action=edit Bug 25630: Fix capitalization and terminology for Accounting, Administration and Serials system preferences - Punctuation (p) - Terminology - Capitalization (c) To test: - Verify: - AccountAutoReconcile (Do not to Don't for consistency with other prefs) - IndependentBranchesPatronModifications (p) - IndependentBranchesTransfers (p) - GoogleOpenIDConnect (google to Google) - UsageStatsLibrariesInfo (c) - opacSerialDefaultTab (c) - StaffSerialIssueDisplayCount (staff interface) - SubscriptionDuplicateDroppedInput (c) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 1 12:55:59 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Jun 2020 10:55:59 +0000 Subject: [Koha-bugs] [Bug 25641] Koha/XSLT/Base.t is failing on U20 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25641 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 1 12:56:03 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Jun 2020 10:56:03 +0000 Subject: [Koha-bugs] [Bug 25641] Koha/XSLT/Base.t is failing on U20 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25641 --- Comment #1 from Jonathan Druart --- Created attachment 105469 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105469&action=edit Bug 25641: Fix Koha/XSLT/Base.t failures on U20 There is a change in the version number. On U20 we get Opening and ending tag mismatch: a line 0 and b On others (D9, D10, U18) we get: Opening and ending tag mismatch: a line 1 and b I did not find where it did come from, so assuming it's just a minor change and won't have side-effects. Test plan: Make sure the tests pass on U20 and another OS -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 1 12:58:09 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Jun 2020 10:58:09 +0000 Subject: [Koha-bugs] [Bug 17084] Automatic debian/control updates (master) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17084 --- Comment #63 from Mason James --- (In reply to Jonathan Druart from comment #62) > (In reply to Mason James from comment #61) > > (In reply to Victor Grousset/tuxayo from comment #58) > > > Thanks for the clarifications, I'll double check. > > > > > > > > > conflict in debian/control > > > > hi folks > > my patches are applied to the v20.05.00 tag > > If I checkout v20.05.00 I don't see those patches. Is there something > missing in master or you are talking about another repo? i mean i've based these patches on the v20.05.00 commit $ git reset --hard v20.05.00 $ git bz apply -s 17084 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 1 13:23:21 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Jun 2020 11:23:21 +0000 Subject: [Koha-bugs] [Bug 24555] POC Elasticsearch - Use boolean queries instead of full text queries In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24555 --- Comment #8 from Julian Maurice --- Created attachment 105470 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105470&action=edit Bug 24555: Use operator "and" for match query -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 1 13:23:55 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Jun 2020 11:23:55 +0000 Subject: [Koha-bugs] [Bug 24555] POC Elasticsearch - Use boolean queries instead of full text queries In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24555 --- Comment #9 from Julian Maurice --- Created attachment 105471 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105471&action=edit Bug 24555: Fix search limits -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 1 13:41:21 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Jun 2020 11:41:21 +0000 Subject: [Koha-bugs] [Bug 25638] API related tests failing on comparing floats In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25638 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- URL| |https://github.com/mojolici | |ous/json-validator/commit/8 | |b19ba025633597de49b6ec9e352 | |46c71580271e -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 1 13:41:26 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Jun 2020 11:41:26 +0000 Subject: [Koha-bugs] [Bug 25638] API related tests failing on comparing floats In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25638 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Version|unspecified |master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 1 14:04:52 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Jun 2020 12:04:52 +0000 Subject: [Koha-bugs] [Bug 24555] POC Elasticsearch - Use boolean queries instead of full text queries In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24555 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #105471|0 |1 is obsolete| | --- Comment #10 from Julian Maurice --- Created attachment 105472 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105472&action=edit Bug 24555: Fix search limits -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 1 14:16:56 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Jun 2020 12:16:56 +0000 Subject: [Koha-bugs] [Bug 25638] API related tests failing on comparing floats In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25638 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|major |normal --- Comment #1 from Tomás Cohen Arazi --- It is urgent because it makes noise, but it is not critical, as the resulting float representations on the API are valid. This is more of a way we test and how things are compared on the tests. I will be spending time on trying to solve this. I think we will end up reverting the removal of the Koha::Object->TO_JSON code, and adding a coercion on the decimal representation... But it is just a guess... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 1 14:25:00 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Jun 2020 12:25:00 +0000 Subject: [Koha-bugs] [Bug 6918] Can't place holds on 'on order' items with AllowOnShelfHolds off In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6918 --- Comment #51 from Andrew Fuerste-Henry --- Test plan: 1: Apply patch, updatedatabase, restart all 2: Set AllowOnOrderOnShelfHolds to Allow 3: Set relevant circ rule to allow onshelf holds If Any Unavailable 4: Find a bib with 2 items, one available and one on-order 5: Confirm that you can place hold on bib or on-order item 5: set circ rule to On Shelf Holds = If All Unavailable 6: confirm no holds can be placed 7: set circ rule to On Shelf Holds = Yes 8: confirm you can place hold on bib or either item 9 Set AllowOnOrderOnShelfHolds to Don't Allow 10: confirm circ rule still set to On Shelf Holds = Yes 11: confirm you can place hold on bib or either item 12: Set relevant circ rule to allow onshelf holds If Any Unavailable 13: Confirm no holds can be placed 14: set circ rule to On Shelf Holds = If All Unavailable 15: confirm no holds can be placed -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 1 14:25:49 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Jun 2020 12:25:49 +0000 Subject: [Koha-bugs] [Bug 6918] Can't place holds on 'on order' items with AllowOnShelfHolds off In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6918 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #103179|0 |1 is obsolete| | --- Comment #52 from Andrew Fuerste-Henry --- Created attachment 105473 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105473&action=edit Bug 6918: Can't place holds on 'on order' items with AllowOnShelfHolds off Test Plan: 1) Apply patch 2) Turn off AllowOnShelfHolds 3) Create a bib with one item, mark the item as 'on order' 4) Attempt to place a hold on the item, you should now be able to do so Signed-off-by: Andrew Fuerste-Henry Signed-off-by: Andrew Fuerste-Henry -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 1 14:25:54 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Jun 2020 12:25:54 +0000 Subject: [Koha-bugs] [Bug 6918] Can't place holds on 'on order' items with AllowOnShelfHolds off In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6918 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #105390|0 |1 is obsolete| | --- Comment #53 from Andrew Fuerste-Henry --- Created attachment 105474 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105474&action=edit Bug 6918: Add syspref Signed-off-by: Andrew Fuerste-Henry -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 1 14:35:22 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Jun 2020 12:35:22 +0000 Subject: [Koha-bugs] [Bug 25642] New: Technical notes are missing from the release Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25642 Bug ID: 25642 Summary: Technical notes are missing from the release Change sponsored?: --- Product: Koha Version: 20.05 Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: About Assignee: koha-bugs at lists.koha-community.org Reporter: martin.renvoize at ptfs-europe.com QA Contact: testopia at bugs.koha-community.org I inadvertently forgot to add the technical highlights notes into the release notes for the 20.05 release. This bug serves to clone them from the notes on the website into the notes contained within the release itself. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Jun 1 14:35:52 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Jun 2020 12:35:52 +0000 Subject: [Koha-bugs] [Bug 25642] Technical notes are missing from the release In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25642 --- Comment #1 from Martin Renvoize --- Created attachment 105475 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105475&action=edit Bug 25642: Add technical notes Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 1 14:36:04 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Jun 2020 12:36:04 +0000 Subject: [Koha-bugs] [Bug 25642] Technical notes are missing from the release In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25642 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 1 14:37:18 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Jun 2020 12:37:18 +0000 Subject: [Koha-bugs] [Bug 25642] Technical notes are missing from the release In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25642 --- Comment #2 from Martin Renvoize --- The output can be seen here: https://gitlab.com/koha-community/koha-release-notes/-/blob/mr_tests/release_notes_20_05_00.md -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Jun 1 14:40:01 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Jun 2020 12:40:01 +0000 Subject: [Koha-bugs] [Bug 22890] Add a chronological changelog In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22890 --- Comment #25 from Martin Renvoize --- Sorry.. this one slipped out of 20.05.. one project too many for me to multi-task on. I'm still keen to work on this area and intend to get back to it this cycle... I have a bit of catching up on the conversation to do. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 1 15:21:20 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Jun 2020 13:21:20 +0000 Subject: [Koha-bugs] [Bug 17842] Broken diacritics on records exported as MARC from cart In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17842 --- Comment #46 from Jonathan Druart --- I think the whole block could be: $output .= encode("UTF-8", $record->as_usmarc()) // q{}; >From Encode::encode POD: "If the $string is undef, then undef is returned." -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 1 16:38:52 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Jun 2020 14:38:52 +0000 Subject: [Koha-bugs] [Bug 25641] Koha/XSLT/Base.t is failing on U20 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25641 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Version|unspecified |master CC| |tomascohen at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 1 16:55:27 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Jun 2020 14:55:27 +0000 Subject: [Koha-bugs] [Bug 25349] Enter in the username field submits the login, instead of moving focus to the password field In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25349 --- Comment #7 from Lucas Gass --- Good point Victor, Currently it will not submit the form by pressing enter in either of the fields. But maybe it would be better workflow if it DID submit the form when pressing enter in the 2nd field (password)? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 1 17:00:25 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Jun 2020 15:00:25 +0000 Subject: [Koha-bugs] [Bug 25643] New: Remove maxreserves syspref Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25643 Bug ID: 25643 Summary: Remove maxreserves syspref Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Hold requests Assignee: koha-bugs at lists.koha-community.org Reporter: caroline.cyr-la-rose at inlibro.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com Unless someone can explain to me how it's not redundant, I think we should remove the maxreserves system preference. The maximum amount of holds (regardless of patron category and can be set in Circulation and fines rules > Default checkout, hold and return policy > Maximum total holds allowed (count). For upgrades, if there is a value in maxreserves, it should be transferred to circulation_rules > max_holds. Not sure what it should do if there is already a value in max_holds... take the biggest? give a warning in the about page? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 1 17:03:52 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Jun 2020 15:03:52 +0000 Subject: [Koha-bugs] [Bug 25643] Remove maxreserves syspref In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25643 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org, | |katrin.fischer at bsz-bw.de, | |kyle at bywatersolutions.com, | |nick at bywatersolutions.com --- Comment #1 from Jonathan Druart --- Kyle, Nick, Katrin, do you see any reasons to keep this syspref instead of using the "Maximum total holds allowed (count)" of the default circ rule? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 1 17:11:00 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Jun 2020 15:11:00 +0000 Subject: [Koha-bugs] [Bug 25643] Remove maxreserves syspref In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25643 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |4045 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4045 [Bug 4045] No check for maximum number of allowed holds from OPAC. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Jun 1 17:11:00 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Jun 2020 15:11:00 +0000 Subject: [Koha-bugs] [Bug 4045] No check for maximum number of allowed holds from OPAC. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4045 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Target Milestone|Oldversions |--- Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |25643 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25643 [Bug 25643] Remove maxreserves syspref -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 1 17:25:25 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Jun 2020 15:25:25 +0000 Subject: [Koha-bugs] [Bug 25537] Page reload at branchtransfers.pl loses destination branch In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25537 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 1 17:25:28 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Jun 2020 15:25:28 +0000 Subject: [Koha-bugs] [Bug 25537] Page reload at branchtransfers.pl loses destination branch In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25537 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #105224|0 |1 is obsolete| | --- Comment #2 from Andrew Fuerste-Henry --- Created attachment 105476 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105476&action=edit Bug 25537: Page reload at branchtransfers.pl loses destination branch At branchtransfers.pl, one selects a destination branch and scans in any number of items to generate transfers to that branch. However, anything that makes the page reload causes your branch selection to be lost, reverting you back to whichever branch comes first alphabetically. This is an invitation to error when one has a stack of books to send all to the same branch. Could that error handling get moved into a modal or something that won't reload the page? Test Plan: 1) Place a hold on an item and set it to waiting 2) Initiate a branch transfer from branchtransfers.pl for any branch but the first in the pulldown branch selector 3) Choose to cancel the hold and transfer 4) Note the pulldown reverts to the first option 5) Apply this patch 6) Repeat steps 1-3 7) Note the pulldown retains your preveiously selected branch! Signed-off-by: Andrew Fuerste-Henry -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 1 17:44:12 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Jun 2020 15:44:12 +0000 Subject: [Koha-bugs] [Bug 25644] New: Self Check in Patron Account Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25644 Bug ID: 25644 Summary: Self Check in Patron Account Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: cbrannon at cdalibrary.org QA Contact: testopia at bugs.koha-community.org Currently, self checkout requires a patron to use staff machines. This is understandable, if you have security equipment to desensitize items. A new thought in workflow is to allow patrons the ability to check out items via their own device. The patron would sign in on the OPAC on their device, go to a Check Out tab, and start scanning barcodes with their camera. All self check rules would still apply. The only thing that would be different is that checkout receipts are e-mailed or not. There would be no option for printing a receipt. Thoughts? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 1 18:02:29 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Jun 2020 16:02:29 +0000 Subject: [Koha-bugs] [Bug 25643] Remove maxreserves syspref In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25643 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=24868 --- Comment #2 from Nick Clemens --- (In reply to Jonathan Druart from comment #1) > Kyle, Nick, Katrin, do you see any reasons to keep this syspref instead of > using the "Maximum total holds allowed (count)" of the default circ rule? I don't think it means the same thing under all circumstances, at least not currently See bug 24868. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 1 18:02:29 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Jun 2020 16:02:29 +0000 Subject: [Koha-bugs] [Bug 24868] When CircControl or ReservesControlBranch are enforced based on item, location limits are enforced per library In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24868 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=25643 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 1 18:38:19 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Jun 2020 16:38:19 +0000 Subject: [Koha-bugs] [Bug 25643] Remove maxreserves syspref In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25643 --- Comment #3 from Katrin Fischer --- The maxreserves is an 'over all libraries' rule. The default on all libraries is (I think) just a fall back if there is no rule for a specific library. At least it should be. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Jun 1 18:42:56 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Jun 2020 16:42:56 +0000 Subject: [Koha-bugs] [Bug 25643] Remove maxreserves syspref In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25643 --- Comment #4 from Katrin Fischer --- I've seen some discussion currently on several bugs and I think that things are confusing at the moment. The page is labelled: Defining circulation and fine rules for all libraries But that's not actually what it states below and how it does work. A rule that you set there will only apply, if there is no other more specific rule for the library. It's a 'default' (fallback) not an 'all libraries' page. And I feel the fix is to change the labelling (and I also believe that in old versions it was labelled differently). And maybe have real global settings somewhere else, not necessarily in the system preferences. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 1 19:48:07 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Jun 2020 17:48:07 +0000 Subject: [Koha-bugs] [Bug 14570] Make it possible to add multiple guarantors to a record In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14570 Kelly McElligott changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=25645 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 1 19:48:07 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Jun 2020 17:48:07 +0000 Subject: [Koha-bugs] [Bug 25645] New: When adding a guarantee to an account, the Guarantor must be attached Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25645 Bug ID: 25645 Summary: When adding a guarantee to an account, the Guarantor must be attached Change sponsored?: --- Product: Koha Version: 19.11 Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Patrons Assignee: koha-bugs at lists.koha-community.org Reporter: kelly at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com This is a regression from a previous workflow: Before 19.11 1. From an Adult Account, choose Add Guarantee 2. On the Guarantee's account, you will see the Guarantor's information already linked to the guarantee's account. Currently 19.11 1. From an Adult Account , choose Add Guarantee 2. On the Guarantee's account, Koha is asking for staff to search and apply the guarantor to the record, although the guarantor is where this process started. 3. If staff do not look up and attach the guarantor to the new guarantee account, Koha will save account without linking. >From https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14570 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 1 19:55:13 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Jun 2020 17:55:13 +0000 Subject: [Koha-bugs] [Bug 25646] New: Enabling itemBarcodeFallbackSearch does not give a good set of search results Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25646 Bug ID: 25646 Summary: Enabling itemBarcodeFallbackSearch does not give a good set of search results Change sponsored?: --- Product: Koha Version: 19.11 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs at lists.koha-community.org Reporter: kelly at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com The option for a library to use the feature, itemBarcodeFallbackSearch, does not work as expected. When entering in a title into this checkout box, the search that Koha performs does not give accurate or close to accurate results. A library may expect to find the same search results that they would get from doing a keyword search in Koha, however, this is not the case. The title of "Great Britain" into the checkout box, gives no results with either Great or Britain in the 10 results Koha displays. Using the keyword search in Koha (search the catalog), searching Great Britain, the first result is the correct result. Increased relevancy of this feature is much desired! -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Jun 1 21:58:41 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Jun 2020 19:58:41 +0000 Subject: [Koha-bugs] [Bug 25647] New: Allow hold notifications to be disabled separately from the process_message_queue Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25647 Bug ID: 25647 Summary: Allow hold notifications to be disabled separately from the process_message_queue Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Notices Assignee: koha-bugs at lists.koha-community.org Reporter: wizzyrea at gmail.com QA Contact: testopia at bugs.koha-community.org During these library closures, it has been apparent that it would be good to allow the hold notices to be disabled separately from the process message queue. A common scenario is a library wants to process holds but does not want hold notifications to go out. They also want to have overdues and advanced due notices to go out. I know we can already (or very soon) run the message queue enabled for different branches, but I feel there needs to be a way to allow the libraries to be able to manage what is on or off from the interface, and not with a cron flag as it is done currently. I've thought of a few ways we might do this - through the enhanced messaging preferences (allow an override per patron category or branch for these optional notices) - as a different set of flags on the process_message_queue cron or something else entirely. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 1 22:18:56 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Jun 2020 20:18:56 +0000 Subject: [Koha-bugs] [Bug 25349] Enter in the username field submits the login, instead of moving focus to the password field In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25349 --- Comment #8 from Donna --- (In reply to Lucas Gass from comment #7) > Good point Victor, > > Currently it will not submit the form by pressing enter in either of the > fields. But maybe it would be better workflow if it DID submit the form when > pressing enter in the 2nd field (password)? This would be the ideal behavior. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 1 22:37:30 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Jun 2020 20:37:30 +0000 Subject: [Koha-bugs] [Bug 25349] Enter in the username field submits the login, instead of moving focus to the password field In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25349 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #9 from Lucas Gass --- Failing qa here and will submit a new patch ASAP -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 1 23:39:37 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Jun 2020 21:39:37 +0000 Subject: [Koha-bugs] [Bug 25511] Add --force option to update_dbix_class_files.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25511 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |martin.renvoize at ptfs-europe |ity.org |.com --- Comment #3 from Katrin Fischer --- Is 19.11 correct here? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 1 23:41:47 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Jun 2020 21:41:47 +0000 Subject: [Koha-bugs] [Bug 20057] Auto-approve option for borrower modifications In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20057 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |glasklas at gmail.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 1 23:42:02 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Jun 2020 21:42:02 +0000 Subject: [Koha-bugs] [Bug 25347] Add support for circulation status 11 ( claimed returned ) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25347 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |kyle at bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 2 00:00:25 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Jun 2020 22:00:25 +0000 Subject: [Koha-bugs] [Bug 25648] New: When looking for specific title, it gives me way too many hits, and not the exact thing I'm looking for. Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25648 Bug ID: 25648 Summary: When looking for specific title, it gives me way too many hits, and not the exact thing I'm looking for. Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: bugs.koha-community.org Assignee: koha-bugs at lists.koha-community.org Reporter: orlib at yahoo.com QA Contact: testopia at bugs.koha-community.org I find that the catalog system for both Willows and Orland has changed in that when I ask for an author like Miller, Derek B., what comes up are not books by that author, but books galore by authors with Derek or Miller in their own names, or books that have America or Day in the title. We had this problem previously, but it was fixed. Can you tell me what's going on? Why is this problem back? Thank you. I look forward to a timely reply. Best, Estel Porras, Orland Free Library, Orland CA 95963 orlib at yahoo.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jun 2 00:19:13 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Jun 2020 22:19:13 +0000 Subject: [Koha-bugs] [Bug 25648] When looking for specific title, it gives me way too many hits, and not the exact thing I'm looking for. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25648 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |INVALID --- Comment #1 from Katrin Fischer --- Hi Estel, this looks more like a support request, so it would be much better suited for your support provider or the general mailing list (https://koha-community.org/support/koha-mailing-lists/). One thing you could try is making sure that you have not turned on QueryAutoTruncate as this created problem with the relevance ranking. In general I'd check for changes with your searching system preferences. If you mail the mailing list, please make sure to include your Koha version and if this occured after an update or after any changes were made etc. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jun 2 00:38:45 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Jun 2020 22:38:45 +0000 Subject: [Koha-bugs] [Bug 25606] Adds "Remove all reserves" button to course details In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25606 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas at bywatersolutions.com --- Comment #2 from Lucas Gass --- Hey Joe, This seems like a great enhancement! Would you mind adding a test plan to this patch? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 2 00:45:39 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Jun 2020 22:45:39 +0000 Subject: [Koha-bugs] [Bug 25434] When viewing cart on small screen sizes selections-toolbar is hidden In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25434 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 2 00:45:43 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Jun 2020 22:45:43 +0000 Subject: [Koha-bugs] [Bug 25434] When viewing cart on small screen sizes selections-toolbar is hidden In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25434 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #105353|0 |1 is obsolete| | --- Comment #5 from Lucas Gass --- Created attachment 105477 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105477&action=edit Bug 25434: Display selections-toolbar on small screens Signed-off-by: Lucas Gass -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 2 01:45:17 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Jun 2020 23:45:17 +0000 Subject: [Koha-bugs] [Bug 25638] API related tests failing on comparing floats In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25638 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj at kohaaloha.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 2 01:50:05 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Jun 2020 23:50:05 +0000 Subject: [Koha-bugs] [Bug 25634] koha-foreach exits too early if any command has non-zero status In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25634 --- Comment #5 from David Cook --- (In reply to Jonathan Druart from comment #4) > I agree, should not we display the error code? Mmm good point. I'll add an alternative patch. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 2 01:53:46 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Jun 2020 23:53:46 +0000 Subject: [Koha-bugs] [Bug 25634] koha-foreach exits too early if any command has non-zero status In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25634 --- Comment #6 from David Cook --- Created attachment 105478 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105478&action=edit Bug 25634: [Alternate] Warn if koha-shell returns non-zero in koha-foreach By putting koha-shell in an if statement, "set -e" will no longer cause the entire koha-foreach program to exit, if koha-shell returns a non-zero status. If a non-zero status is returned, we warn on it, and the caller of koha-foreach can interpret that command visually. To Test: 1) Write a shell script that says "Hello" and then exits with a 1 status 2) Run koha-foreach against that shell script with multiple instances available to koha-foreach 3) Before the patch, koha-foreach will die after the first "Hello" 4) After the patch, koha-foreach will continue, through all the instances, and report which instances returned non-zero statuses by which command. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 2 01:56:03 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 01 Jun 2020 23:56:03 +0000 Subject: [Koha-bugs] [Bug 25635] overdue_notices.pl dies if no overdue rules are defined In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25635 --- Comment #5 from David Cook --- (In reply to Jonathan Druart from comment #1) > Yes, even with bug 25634 fixed I think we should replace the die with a > warn+exit 0 That's my thinking too. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jun 2 02:03:23 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Jun 2020 00:03:23 +0000 Subject: [Koha-bugs] [Bug 17842] Broken diacritics on records exported as MARC from cart In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17842 --- Comment #47 from David Cook --- (In reply to Jonathan Druart from comment #46) > I think the whole block could be: > > $output .= encode("UTF-8", $record->as_usmarc()) // q{}; > > From Encode::encode POD: > "If the $string is undef, then undef is returned." Personally, I don't like putting method output directly into another function call, as it can make exception handling harder. But your suggestion does look more elegant and would be less code to maintain. I'd be happy with either. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 2 02:09:03 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Jun 2020 00:09:03 +0000 Subject: [Koha-bugs] [Bug 22890] Add a chronological changelog In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22890 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au --- Comment #26 from David Cook --- (In reply to Martin Renvoize from comment #13) > In fact, I'd go so far as to say it might be nice to filter out a fair bit > of the existing data that goes into the release notes.. I don't think > librarian end users actually need/want to see a record of every single 'bug' > that's made it into a release.. especially at the moment whilst there's lots > of architectural bugs going in that don't really affect end users. > > By having the two distinct fields we could more easily direct the > information to the right people. +1000000 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 2 02:15:52 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Jun 2020 00:15:52 +0000 Subject: [Koha-bugs] [Bug 25649] New: Eaea Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25649 Bug ID: 25649 Summary: Eaea Change sponsored?: --- Product: Koha Version: master Hardware: HP OS: Other Status: NEW Severity: major Priority: P5 - low Component: About Assignee: koha-bugs at lists.koha-community.org Reporter: renalkoclok at gmail.com QA Contact: testopia at bugs.koha-community.org Created attachment 105479 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105479&action=edit Eaea Airono -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jun 2 02:16:13 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Jun 2020 00:16:13 +0000 Subject: [Koha-bugs] [Bug 22890] Add a chronological changelog In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22890 --- Comment #27 from David Cook --- (In reply to Martin Renvoize from comment #13) > In fact, I'd go so far as to say it might be nice to filter out a fair bit > of the existing data that goes into the release notes.. I don't think > librarian end users actually need/want to see a record of every single 'bug' > that's made it into a release.. especially at the moment whilst there's lots > of architectural bugs going in that don't really affect end users. > > By having the two distinct fields we could more easily direct the > information to the right people. I have librarians ask me what's new in a release, and at the moment I painstakingly read through the release notes to create a condensed user-friendly version that might actually be meaningful to them. The technical release notes are useful for developers for sure. I always learn something new when I read them, as it's very challenging to stay 100% current on every patch that gets pushed to every release. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 2 02:36:21 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Jun 2020 00:36:21 +0000 Subject: [Koha-bugs] [Bug 25566] Change in DecreaseLoanHighHolds behaviour In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25566 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|normal |major --- Comment #4 from Nick Clemens --- Bumping severity, for affected libraries this can cause loan reductions across a wide range of materials -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 2 03:34:18 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Jun 2020 01:34:18 +0000 Subject: [Koha-bugs] [Bug 25641] Koha/XSLT/Base.t is failing on U20 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25641 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 2 03:35:04 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Jun 2020 01:35:04 +0000 Subject: [Koha-bugs] [Bug 24167] We should support installation on Debian 10 [OMNIBUS] In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24167 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 2 03:38:00 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Jun 2020 01:38:00 +0000 Subject: [Koha-bugs] [Bug 25293] Don't call escapeHtml on null In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25293 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au --- Comment #5 from David Cook --- I usually encounter this issue because of the Keyword To MARC mapping removal, which caused some really bad Koha to MARC mappings in the biblio. It caused a lot of problems for us. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 2 06:28:39 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Jun 2020 04:28:39 +0000 Subject: [Koha-bugs] [Bug 22417] Delegate background jobs execution In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22417 --- Comment #50 from David Cook --- We use RabbitMQ for some other projects, and I think I'm going to start looking at using it with some of our local Koha extensions. I don't have a timeline. It's mostly just going to be when I have some free time, but happy to report back on how it goes, lessons learned, etc. Tomas, I'm also interested in using RabbitMQ with Koha plugins. I think I agree now with the general model that you suggested. My koha-plugin-oaipmh-import plugin would be able to make use of RabbitMQ, so I'd be keen to test it out on the plugin side. I suppose the minimum we'd need in Koha is the following: 1) A RabbitMQ server 2) A background Koha worker (which can invoke Koha plugins) The plugin worker could write results to its own result store (ie a plugin controlled database table). A core (ie non plugin) result store is probably a good idea but not an immediate requirement I would think... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 2 08:39:37 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Jun 2020 06:39:37 +0000 Subject: [Koha-bugs] [Bug 25310] Ability to centrally turn off sending/generating of HOLD notices In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25310 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |wizzyrea at gmail.com --- Comment #1 from Katrin Fischer --- *** Bug 25647 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 2 08:39:37 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Jun 2020 06:39:37 +0000 Subject: [Koha-bugs] [Bug 25647] Allow hold notifications to be disabled separately from the process_message_queue In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25647 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |DUPLICATE --- Comment #1 from Katrin Fischer --- *** This bug has been marked as a duplicate of bug 25310 *** -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 2 09:46:27 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Jun 2020 07:46:27 +0000 Subject: [Koha-bugs] [Bug 25650] New: Add location and itype descriptions in ILS-DI GetRecords Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25650 Bug ID: 25650 Summary: Add location and itype descriptions in ILS-DI GetRecords Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Web services Assignee: julian.maurice at biblibre.com Reporter: julian.maurice at biblibre.com QA Contact: testopia at bugs.koha-community.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 2 09:47:03 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Jun 2020 07:47:03 +0000 Subject: [Koha-bugs] [Bug 25650] Add location and itype descriptions in ILS-DI GetRecords In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25650 --- Comment #1 from Julian Maurice --- Created attachment 105480 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105480&action=edit Bug 25650: Add location and itype descriptions in ILS-DI GetRecords Test plan: 1. Create a record with an item, and set the item's shelving location and itemtype. 2. Go to http:///cgi-bin/koha/ilsdi.pl?service=GetRecords&id= 3. Check that there is and and that their value is correct. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 2 09:47:14 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Jun 2020 07:47:14 +0000 Subject: [Koha-bugs] [Bug 25650] Add location and itype descriptions in ILS-DI GetRecords In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25650 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 2 09:56:24 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Jun 2020 07:56:24 +0000 Subject: [Koha-bugs] [Bug 24293] Schema will need 20.05 to be added In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24293 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |FIXED Keywords|rel_20_05_candidate | --- Comment #4 from Jonathan Druart --- Has been done by Chris. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 2 10:56:44 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Jun 2020 08:56:44 +0000 Subject: [Koha-bugs] [Bug 25643] Remove maxreserves syspref In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25643 --- Comment #5 from Jonathan Druart --- So far the maxreserves syspref is only used in the controllers, it is not used in the "canbereserved*" subroutines. That means there is an obvious issue in the code. My proposition is to: 1. Remove maxreserves 2. And instead use: * max_holds from "Default checkout, hold and return policy" as maxreserves. Either for "default" (all libraries), or per library. * or max_holds from "Default checkout, hold policy by patron category" if defined (default or library specific). -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 2 11:06:03 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Jun 2020 09:06:03 +0000 Subject: [Koha-bugs] [Bug 17842] Broken diacritics on records exported as MARC from cart In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17842 --- Comment #48 from Jonathan Druart --- Created attachment 105481 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105481&action=edit Bug 17842: Simplify the code There is no need for all the conditions. >From Encode::encode POD: "If the $string is undef, then undef is returned." -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 2 11:27:55 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Jun 2020 09:27:55 +0000 Subject: [Koha-bugs] [Bug 25643] Remove maxreserves syspref In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25643 --- Comment #6 from Katrin Fischer --- I believe it's not the same thing and we should really discuss how to interpet default vs. all libraries - I believe we cannot have both and should not mix them. There needs to be a clear definition to move forward and we should avoid changing behaviour unintentionally for libraries. Say you have 3 libraries. As they all have the same circulation conditions you only enter rules under "Default (all libraries)". Max holds is set to 5. maxreserves is set to 10. What I believe happens is that you can have only up to 10 holds (capped by maxreserves), but a max of 5 for each of the libraries. If we remove maxreserves, we either remove the ability to inherit or remove the global capping. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jun 2 12:07:22 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Jun 2020 10:07:22 +0000 Subject: [Koha-bugs] [Bug 25591] Update list-deps for Debian 10 and Ubuntu 20.04 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25591 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org Keywords|rel_20_05_candidate | Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 2 12:07:27 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Jun 2020 10:07:27 +0000 Subject: [Koha-bugs] [Bug 25633] Update debian/control.ini file for 20.05 release cycle In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25633 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 2 12:07:46 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Jun 2020 10:07:46 +0000 Subject: [Koha-bugs] [Bug 17084] Automatic debian/control updates (master) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17084 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 2 12:07:56 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Jun 2020 10:07:56 +0000 Subject: [Koha-bugs] [Bug 17084] Automatic debian/control updates (master) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17084 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 2 12:08:01 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Jun 2020 10:08:01 +0000 Subject: [Koha-bugs] [Bug 25591] Update list-deps for Debian 10 and Ubuntu 20.04 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25591 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 2 12:08:05 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Jun 2020 10:08:05 +0000 Subject: [Koha-bugs] [Bug 25633] Update debian/control.ini file for 20.05 release cycle In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25633 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 2 13:07:53 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Jun 2020 11:07:53 +0000 Subject: [Koha-bugs] [Bug 25582] Don't show OPAC problems entry on dashboard when there are no reports In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25582 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Severity|enhancement |trivial -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 2 13:14:41 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Jun 2020 11:14:41 +0000 Subject: [Koha-bugs] [Bug 25582] Don't show OPAC problems entry on dashboard when there are no reports In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25582 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 2 13:14:44 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Jun 2020 11:14:44 +0000 Subject: [Koha-bugs] [Bug 25582] Don't show OPAC problems entry on dashboard when there are no reports In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25582 --- Comment #1 from Owen Leonard --- Created attachment 105482 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105482&action=edit Bug 25582: Don't show OPAC problems entry on dashboard when there are no reports This patch makes a minor correction to the template to correct the check on outstanding OPAC problem reports. An error was preventing the check from working correctly. To test, apply the patch and enable the OPACReportProblem system preference. - On the staff interface home page, check the area showing pending operations (suggestions, tags, etc.). - If you have no pending OPAC problem reports there should be no line for OPAC problem reports. - If necessary, mark all pending OPAC problem reports closed and confirm that when there are no outstanding reports the link is hidden. - If necessary, test that the link appears when you have one or more OPAC problem reports. - Go to the OPAC and use the "Report a problem" to submit a test report. - Check that the staff interface home page reflects that there is now a pending report. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 2 13:23:19 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Jun 2020 11:23:19 +0000 Subject: [Koha-bugs] [Bug 25641] Koha/XSLT/Base.t is failing on U20 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25641 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj at kohaaloha.com --- Comment #2 from Mason James --- (In reply to Jonathan Druart from comment #1) > Created attachment 105469 [details] [review] > Bug 25641: Fix Koha/XSLT/Base.t failures on U20 > > There is a change in the version number. > On U20 we get > Opening and ending tag mismatch: a line 0 and b > On others (D9, D10, U18) we get: > Opening and ending tag mismatch: a line 1 and b > > I did not find where it did come from, so assuming it's just a minor > change and won't have side-effects. > > Test plan: > Make sure the tests pass on U20 and another OS hi, i've seen the same error on deb11 too https://jenkins.koha-community.org/job/Koha_Master_D11/2/ https://jenkins.koha-community.org/job/Koha_Master_D11/2/testReport/junit/(root)/t_db_dependent_Koha_XSLT_Base_t/Malformed_XML_warning_correctly_displayed__2075_/ not ok 10 - Malformed XML warning correctly displayed ok 11 - Engine returns error on malformed xml not ok 12 - Malformed XML warning correctly displayed ok 13 - Engine respects do_not_return_source==1 not ok 14 - Malformed XML warning correctly displayed ok 15 - Second engine respects it too not ok 16 - Malformed XML warning correctly displayed -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 2 13:41:17 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Jun 2020 11:41:17 +0000 Subject: [Koha-bugs] [Bug 25651] New: Modifying an authorised value make it disappear Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25651 Bug ID: 25651 Summary: Modifying an authorised value make it disappear Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: critical Priority: P5 - low Component: System Administration Assignee: julian.maurice at biblibre.com Reporter: julian.maurice at biblibre.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com Steps to reproduce: 1. Go to Admin » Authorised Values » [any AV category that has values in it] » Edit one » Save 2. The modified authorised value is gone -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 2 13:42:11 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Jun 2020 11:42:11 +0000 Subject: [Koha-bugs] [Bug 25651] Modifying an authorised value make it disappear In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25651 --- Comment #1 from Julian Maurice --- Created attachment 105483 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105483&action=edit Bug 25651: Fix modification of authorised value When modifying an existing authorised value, the category is not correctly passed to the template and so it is not passed to the POST request, which results in the authorised value switching to category '', which effectively make it disappear from the interface. This patch fixes that. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 2 13:42:21 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Jun 2020 11:42:21 +0000 Subject: [Koha-bugs] [Bug 25651] Modifying an authorised value make it disappear In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25651 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 2 13:47:58 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Jun 2020 11:47:58 +0000 Subject: [Koha-bugs] [Bug 25643] Remove maxreserves syspref In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25643 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrew at bywatersolutions.com --- Comment #7 from Andrew Fuerste-Henry --- (In reply to Katrin Fischer from comment #6) > I believe it's not the same thing and we should really discuss how to > interpet default vs. all libraries - I believe we cannot have both and > should not mix them. There needs to be a clear definition to move forward > and we should avoid changing behaviour unintentionally for libraries. > > Say you have 3 libraries. > As they all have the same circulation conditions you only enter rules under > "Default (all libraries)". Max holds is set to 5. > > maxreserves is set to 10. > > What I believe happens is that you can have only up to 10 holds (capped by > maxreserves), but a max of 5 for each of the libraries. > > If we remove maxreserves, we either remove the ability to inherit or remove > the global capping. +1 to all of this. Katrin's example scenario correctly describes the current behavior (based on what they've got ReservesControl set to). There's nothing in the circ rules that can accomplish exactly what MaxReserves does and I hate to remove that functionality, even though it is confusing. For what it's worth, I get libraries asking for more functionality along the lines of what MaxReserves does -- they want to be able to set global limits irrespective of library and define things like "Patrons in Category A can have a total of 50 holds across all branches." As Koha stands now, that sort of rule may or may not be possible based on ReservesControl and other rules. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 2 13:53:28 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Jun 2020 11:53:28 +0000 Subject: [Koha-bugs] [Bug 25651] Modifying an authorised value make it disappear In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25651 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 2 14:12:00 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Jun 2020 12:12:00 +0000 Subject: [Koha-bugs] [Bug 25643] Remove maxreserves syspref In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25643 --- Comment #8 from Katrin Fischer --- I agree that it would be nice and improve transparency if the 'maxreserves' was not hiding in system preferences. It would be nice if we had something like a different configuration area for this visible under circulation rules somehow. I'd also suggest getting rid of the 'all libraries' terminology in favor of something else. I believe we had some iterations of phrasing there already, but the current one does seem more confusing than ever. Maybe something like: Default rules Default fallback rules (for libraries) ? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 2 14:31:56 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Jun 2020 12:31:56 +0000 Subject: [Koha-bugs] [Bug 25643] Remove maxreserves syspref In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25643 --- Comment #9 from Jonathan Druart --- What about moving the maxreserves pref under a "global" section of the circ rules page? It would be displayed only if no library is selected. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 2 14:35:23 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Jun 2020 12:35:23 +0000 Subject: [Koha-bugs] [Bug 25442] Koha history ends in November 2019 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25442 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #1 from Jonathan Druart --- The last line on master is 1084 1589278508>-May 12 2020>Slava Shishkin becomes the 428th developer to have a patch pushed>--developer -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jun 2 14:35:49 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Jun 2020 12:35:49 +0000 Subject: [Koha-bugs] [Bug 25442] Koha history ends in November 2019 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25442 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|koha-bugs at lists.koha-commun |jonathan.druart at bugs.koha-c |ity.org |ommunity.org --- Comment #2 from Jonathan Druart --- However it's missing the minor releases' dates -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jun 2 14:50:41 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Jun 2020 12:50:41 +0000 Subject: [Koha-bugs] [Bug 25638] API related tests failing on comparing floats In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25638 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |25513 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25513 [Bug 25513] Integer casting in Koha::Object->TO_JSON causes random test failures -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 2 14:50:41 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Jun 2020 12:50:41 +0000 Subject: [Koha-bugs] [Bug 25513] Integer casting in Koha::Object->TO_JSON causes random test failures In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25513 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |25638 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25638 [Bug 25638] API related tests failing on comparing floats -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 2 14:53:07 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Jun 2020 12:53:07 +0000 Subject: [Koha-bugs] [Bug 25638] API related tests failing on comparing floats In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25638 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 2 14:53:17 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Jun 2020 12:53:17 +0000 Subject: [Koha-bugs] [Bug 25638] API related tests failing on comparing floats In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25638 --- Comment #2 from Jonathan Druart --- Created attachment 105484 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105484&action=edit Bug 25638: Revert "Bug 25513: Remove unneeded integer casting in Koha::Object->TO_JSON" This reverts commit a79cf4150e8a08e743acc7d7147af91757d7a9b8. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 2 14:53:25 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Jun 2020 12:53:25 +0000 Subject: [Koha-bugs] [Bug 25638] API related tests failing on comparing floats In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25638 --- Comment #3 from Jonathan Druart --- Created attachment 105485 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105485&action=edit Bug 25638: Fix floag/decimal comparison in API related tests The previous fix from bug 25513 does not work in all versions we are supporting. Let's hack the float/decimal columns in the same way we did for integer. prove t/db_dependent/api/v1/acquisitions_vendors.t t/db_dependent/api/v1/patrons_accounts.t t/db_dependent/api/v1/acquisitions_orders.t Note that there is another error on U20 for acquisitions_orders.t -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 2 15:00:31 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Jun 2020 13:00:31 +0000 Subject: [Koha-bugs] [Bug 25644] Self Check in Patron Account In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25644 Sally changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sally.healey at cheshireshared | |services.gov.uk -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 2 15:07:34 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Jun 2020 13:07:34 +0000 Subject: [Koha-bugs] [Bug 25652] New: Holds Daily is not looking at Item Type when Not Allowing Holds Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25652 Bug ID: 25652 Summary: Holds Daily is not looking at Item Type when Not Allowing Holds Change sponsored?: --- Product: Koha Version: 19.11 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Hold requests Assignee: koha-bugs at lists.koha-community.org Reporter: kelly at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com If a library has a rule that allows 5 holds daily on DVDs and 50 holds daily on the BOOK rule, Koha will count the first 5 holds regardless of item type and not allow any more of that item type (DVD) for a hold, but will allow more BOOK holds. 423 my $today_holds = Koha::Holds->search({ 424 borrowernumber => $borrowernumber, 425 reservedate => dt_from_string->date 426 }); Koha should be looking at Item Type when determining whether a hold can be placed in this today_holds search. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 2 15:17:36 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Jun 2020 13:17:36 +0000 Subject: [Koha-bugs] [Bug 25606] Adds "Remove all reserves" button to course details In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25606 --- Comment #3 from Joe Sikowitz --- Test plan 1. Install patch 2. Log in as user with permission to delete reserves 3. View a course reserve record with multiple items attached 4. There should now be a button that says "- Batch remove reserves" 5. When you click the button a dialog box should appear with a warning 6. Click "Ok" 7. All course reserves should be removed from the record 8. Add an item to more than course record 9. Redo 3-7 10. Items should have been removed from that course but remain on all other courses 11. Log in as a user without delete reserves permission 12. You should not see the batch remove option -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 2 15:22:19 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Jun 2020 13:22:19 +0000 Subject: [Koha-bugs] [Bug 17084] Automatic debian/control updates (master) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17084 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |20.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 2 15:22:22 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Jun 2020 13:22:22 +0000 Subject: [Koha-bugs] [Bug 17084] Automatic debian/control updates (master) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17084 --- Comment #64 from Jonathan Druart --- Pushed to master for 20.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 2 15:22:26 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Jun 2020 13:22:26 +0000 Subject: [Koha-bugs] [Bug 25591] Update list-deps for Debian 10 and Ubuntu 20.04 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25591 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)|20.05.00 |20.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 2 15:22:30 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Jun 2020 13:22:30 +0000 Subject: [Koha-bugs] [Bug 25591] Update list-deps for Debian 10 and Ubuntu 20.04 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25591 --- Comment #29 from Jonathan Druart --- Pushed to master for 20.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 2 15:22:32 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Jun 2020 13:22:32 +0000 Subject: [Koha-bugs] [Bug 25633] Update debian/control.ini file for 20.05 release cycle In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25633 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |20.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 2 15:22:34 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Jun 2020 13:22:34 +0000 Subject: [Koha-bugs] [Bug 25633] Update debian/control.ini file for 20.05 release cycle In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25633 --- Comment #2 from Jonathan Druart --- Pushed to master for 20.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 2 15:23:28 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Jun 2020 13:23:28 +0000 Subject: [Koha-bugs] [Bug 25651] Modifying an authorised value make it disappear In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25651 ByWater Sandboxes changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #105483|0 |1 is obsolete| | --- Comment #2 from ByWater Sandboxes --- Created attachment 105486 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105486&action=edit Bug 25651: Fix modification of authorised value When modifying an existing authorised value, the category is not correctly passed to the template and so it is not passed to the POST request, which results in the authorised value switching to category '', which effectively make it disappear from the interface. This patch fixes that. Signed-off-by: Sally -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 2 15:23:52 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Jun 2020 13:23:52 +0000 Subject: [Koha-bugs] [Bug 25651] Modifying an authorised value make it disappear In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25651 Sally changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |sally.healey at cheshireshared | |services.gov.uk -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 2 15:41:14 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Jun 2020 13:41:14 +0000 Subject: [Koha-bugs] [Bug 25639] Add search queries to HTML so queries can be retrieved via JS In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25639 ByWater Sandboxes changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #105458|0 |1 is obsolete| | --- Comment #2 from ByWater Sandboxes --- Created attachment 105487 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105487&action=edit Bug 25639: Add query strings to html This development simply adds the contructed queries generated by Koha to the HTML source. This is useful for integrations like the Hoopla plugin: https://github.com/bywatersolutions/koha-plugin-hoopla To test: 1 - Search on OPAC for "qwertyuiop" 2 - View the HTML source 3 - Find 'qwertyuiop' in the source, it is not easily accessible via JS 4 - Apply patch 5 - Repeat 6 - Note that now there are spans with data elements containing the queries used by Koha 7 - Sign off Signed-off-by: Sally -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jun 2 15:41:30 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Jun 2020 13:41:30 +0000 Subject: [Koha-bugs] [Bug 25639] Add search queries to HTML so queries can be retrieved via JS In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25639 Sally changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sally.healey at cheshireshared | |services.gov.uk Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jun 2 15:58:21 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Jun 2020 13:58:21 +0000 Subject: [Koha-bugs] [Bug 25511] Add --force option to update_dbix_class_files.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25511 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Version|19.11 |master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 2 15:59:37 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Jun 2020 13:59:37 +0000 Subject: [Koha-bugs] [Bug 25532] Add a wikipedia-style search suggestion feature to the OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25532 ByWater Sandboxes changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #105220|0 |1 is obsolete| | --- Comment #9 from ByWater Sandboxes --- Created attachment 105488 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105488&action=edit Bug 25532: Add a wikipedia-style search suggestion feature to the OPAC This patch adds an auto-complete function to the OPAC search and a new system preference 'OPACSearchAutoComplete' To test: 1) Install the patch 2) Go to the OPAC and start typing a search term, e.g. Harry Potter 3) You should see a drop down will appear suggesting likely search terms which can be selected 4) Repeat the search, but mis-spell your search term, e.g. Hrry Potter. 5) You should still see the correctly spelled search term being offered for selection 6) Check that the search is unaffected, and still works correctly, both when logged in and not logged in. Signed-off-by: Sally -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 2 15:59:57 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Jun 2020 13:59:57 +0000 Subject: [Koha-bugs] [Bug 25532] Add a wikipedia-style search suggestion feature to the OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25532 Sally changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 2 16:00:19 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Jun 2020 14:00:19 +0000 Subject: [Koha-bugs] [Bug 25653] New: Authorities search does not retain selection Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25653 Bug ID: 25653 Summary: Authorities search does not retain selection Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: MARC Authority data support Assignee: koha-bugs at lists.koha-community.org Reporter: nick at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org To recreate: 1 - Browse to Authorities 2 - Search in each tab 3 - Note all search results revert to 'Search main heading a only' -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 2 16:03:05 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Jun 2020 14:03:05 +0000 Subject: [Koha-bugs] [Bug 25653] Authorities search does not retain selection In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25653 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jun 2 16:03:07 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Jun 2020 14:03:07 +0000 Subject: [Koha-bugs] [Bug 25653] Authorities search does not retain selection In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25653 --- Comment #1 from Nick Clemens --- Created attachment 105489 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105489&action=edit Bug 25653: Update tab selector to use 'active' and include all options It looks like the functionality was broken when ui tabs were upgraded and mainmainentry was added To test: 1 - Browse to Authorities 2 - Search in each tab 3 - Note all search results revert to 'Search main heading a only' 4 - Apply patch 5 - Note selection is retained after search -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jun 2 16:03:15 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Jun 2020 14:03:15 +0000 Subject: [Koha-bugs] [Bug 25653] Authorities search does not retain selection In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25653 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |nick at bywatersolutions.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jun 2 16:03:56 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Jun 2020 14:03:56 +0000 Subject: [Koha-bugs] [Bug 25654] New: Making the Contact Section / Guarantor Section separate from the Contact details of the patron would be less confusing Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25654 Bug ID: 25654 Summary: Making the Contact Section / Guarantor Section separate from the Contact details of the patron would be less confusing Change sponsored?: --- Product: Koha Version: 19.11 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Patrons Assignee: koha-bugs at lists.koha-community.org Reporter: kelly at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com Created attachment 105490 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105490&action=edit differences With the recent change of the Guarantors in Koha, the Contact section of the Patron Detail page (when editing) is confusing. Prior to 19.11, the Contact section was created for the Contact details of the Patron, phone, email, fax. Now in 19.11, the Guarantor (Non-Koha) has been added to the contact section, causing questions if this is the Guarantor's contact information or the primary patron's contact information. It would be nice if there could be a separation of the two areas in the Koha patrons form (memberentry.pl) Attaching an image of the before 19.11 and 19.11 contact section. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jun 2 16:05:34 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Jun 2020 14:05:34 +0000 Subject: [Koha-bugs] [Bug 25653] Authorities search does not retain selection In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25653 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrew at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 2 16:15:09 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Jun 2020 14:15:09 +0000 Subject: [Koha-bugs] [Bug 25653] Authorities search does not retain selection In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25653 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |oleonard at myacpl.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 2 16:25:45 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Jun 2020 14:25:45 +0000 Subject: [Koha-bugs] [Bug 23243] Allow filtering out of historic subscription expirations in the check expiration of serials page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23243 --- Comment #9 from Martin Renvoize --- I'm OK with `Include expirations before today.` Seems like a simple change; I'm less sure about expanding it to two inputs, I think that adds more complexity to the patch than is really required here. -- You are receiving this mail because: You are watching all bug changes. You are on the CC list for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jun 2 16:27:40 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Jun 2020 14:27:40 +0000 Subject: [Koha-bugs] [Bug 23243] Allow filtering out of historic subscription expirations in the check expiration of serials page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23243 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #91138|0 |1 is obsolete| | --- Comment #10 from Martin Renvoize --- Created attachment 105491 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105491&action=edit Bug 23243: Restore filtering out historic expired subscriptions The 'Check Expiration' page in Serials is now hardcoded to display all expired subscriptions before the entered date. This patch restores the ability to limit the results to just those expiring between 'today' and the date entered. Original code taken from bug 6968 autored by Maxime Pelletier, rebased by Charles Farmer and then moved to a new report and rebased again by Martin Renvoize. Test plan: 1) Without the patch any results after a search from this page will result in matches both before after todays date (but before the date you entered). 2) With the patch you should see a 'Show historic expirations' checkbox which will allow you to limit the results to just those that expire between the date you enter and today. Sponsored-by: CCSR Rescued-by: Charles Farmer Rescued-by: Martin Renvoize Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are on the CC list for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 2 16:27:44 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Jun 2020 14:27:44 +0000 Subject: [Koha-bugs] [Bug 23243] Allow filtering out of historic subscription expirations in the check expiration of serials page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23243 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #96215|0 |1 is obsolete| | --- Comment #11 from Martin Renvoize --- Created attachment 105492 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105492&action=edit Bug 23243: Adjust previous patch Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are on the CC list for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 2 16:27:48 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Jun 2020 14:27:48 +0000 Subject: [Koha-bugs] [Bug 23243] Allow filtering out of historic subscription expirations in the check expiration of serials page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23243 --- Comment #12 from Martin Renvoize --- Created attachment 105493 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105493&action=edit Bug 23243: (follow-up) Update wording as requested -- You are receiving this mail because: You are on the CC list for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 2 16:28:16 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Jun 2020 14:28:16 +0000 Subject: [Koha-bugs] [Bug 23243] Allow filtering out of historic subscription expirations in the check expiration of serials page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23243 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are on the CC list for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jun 2 16:34:10 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Jun 2020 14:34:10 +0000 Subject: [Koha-bugs] [Bug 25606] Adds "Remove all reserves" button to course details In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25606 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 2 16:34:13 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Jun 2020 14:34:13 +0000 Subject: [Koha-bugs] [Bug 25606] Adds "Remove all reserves" button to course details In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25606 --- Comment #4 from Lucas Gass --- Created attachment 105494 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105494&action=edit Bug 25606: Remove all reserve items button Adds button to course records to remove all attached reserve items. A warning dialog box will appear before executed. Test plan 1. Install patch 2. Log in as user with permission to delete reserves 3. View a course reserve record with multiple items attached 4. There should now be a button that says "- Batch remove reserves" 5. When you click the button a dialog box should appear with a warning 6. Click "Ok" 7. All course reserves should be removed from the record 8. Add an item to more than course record 9. Redo 3-7 10. Items should have been removed from that course but remain on all other courses 11. Log in as a user without delete reserves permission 12. You should not see the batch remove option Signed-off-by: Lucas Gass -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 2 16:39:00 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Jun 2020 14:39:00 +0000 Subject: [Koha-bugs] [Bug 25654] Making the Contact Section / Guarantor Section separate from the Contact details of the patron would be less confusing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25654 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrew at bywatersolutions.com --- Comment #1 from Andrew Fuerste-Henry --- +1, this is confusing -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 2 17:11:33 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Jun 2020 15:11:33 +0000 Subject: [Koha-bugs] [Bug 25643] Remove maxreserves syspref In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25643 --- Comment #10 from Andrew Fuerste-Henry --- I like moving this into circ rules somewhere rather than leaving in sysprefs. But that compounds both the naming issue that Katrin's raising *and* the control branch issue that Nick's raising. We don't exactly have a place in circ rules right now in which to define that sort of global rules, we only have default rules. Even if those defaults are our *only* rules, they'll still be enforced for each library individually. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jun 2 17:39:19 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Jun 2020 15:39:19 +0000 Subject: [Koha-bugs] [Bug 25655] New: Additionally store actual cost in foreign currency, currency and currency rate used Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25655 Bug ID: 25655 Summary: Additionally store actual cost in foreign currency, currency and currency rate used Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Acquisitions Assignee: koha-bugs at lists.koha-community.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org Bug 24158 allows to calculate the actual cost on time of receive from a foreign currency. If I understand our current database structure correctly, we store in aqorders.currency the currency used at the time of ordering, but we don't store the conversion rate used or the original price. I think it would make sense to store them as well. It will also allow to display the orginal prices and rates used on invoices and possibly other pages, which will help staff when checking that everythign was handled correctly. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 2 17:39:19 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Jun 2020 15:39:19 +0000 Subject: [Koha-bugs] [Bug 24158] Add ability to receive items in multiple currencies In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24158 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=25655 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 2 17:40:32 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Jun 2020 15:40:32 +0000 Subject: [Koha-bugs] [Bug 25653] Authorities search does not retain selection In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25653 Claire Gravely changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 2 17:40:35 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Jun 2020 15:40:35 +0000 Subject: [Koha-bugs] [Bug 25653] Authorities search does not retain selection In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25653 Claire Gravely changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #105489|0 |1 is obsolete| | --- Comment #2 from Claire Gravely --- Created attachment 105495 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105495&action=edit Bug 25653: Update tab selector to use 'active' and include all options It looks like the functionality was broken when ui tabs were upgraded and mainmainentry was added To test: 1 - Browse to Authorities 2 - Search in each tab 3 - Note all search results revert to 'Search main heading a only' 4 - Apply patch 5 - Note selection is retained after search Signed-off-by: Claire Gravely -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 2 17:45:15 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Jun 2020 15:45:15 +0000 Subject: [Koha-bugs] [Bug 25656] New: Allow entering of currency rate to use when receiving and ordering in acq Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25656 Bug ID: 25656 Summary: Allow entering of currency rate to use when receiving and ordering in acq Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Acquisitions Assignee: koha-bugs at lists.koha-community.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org When advertising bug 24158 we had some discussion about further improvements to currency handling in Koha. It would be nice if the currency rate used for the conversion on ordering and receiving would be shown in the form (pulled from administration > currencies) but be editable at the same time, so you can update it if necessary. We could also show a checkbox to update the currency rate in administration from there, visibility of the checkbox depending on the existing manage_currencies permission. This could go together with bug 25655 that suggests storing original prices and rates used. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 2 18:40:56 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Jun 2020 16:40:56 +0000 Subject: [Koha-bugs] [Bug 8338] Fines not cleared with dropbox mode In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8338 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #104900|0 |1 is obsolete| | --- Comment #27 from Martin Renvoize --- Created attachment 105496 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105496&action=edit Bug 8338: Unit Tests Signed-off-by: Andrew Fuerste-Henry -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 2 18:41:00 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Jun 2020 16:41:00 +0000 Subject: [Koha-bugs] [Bug 8338] Fines not cleared with dropbox mode In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8338 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #104901|0 |1 is obsolete| | --- Comment #28 from Martin Renvoize --- Created attachment 105497 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105497&action=edit Bug 8338: Remove zero amount overdues on backdated returns where appropriate This patch removes any overdues which would be reversed on a backdated return if CalcFineOnBackdate is enabled and the user has not already attempted to pay off the accruing fine. Signed-off-by: Andrew Fuerste-Henry -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 2 18:41:04 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Jun 2020 16:41:04 +0000 Subject: [Koha-bugs] [Bug 8338] Fines not cleared with dropbox mode In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8338 --- Comment #29 from Martin Renvoize --- Created attachment 105498 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105498&action=edit Bug 8338: (follow-up) Fix test This patch moves the previous test introduced with bug 24075 into the same block as the rest of the AddReturn tests and updates it to test for the new 'remove accountline' behaviour as well as the reduce and refund behaviour. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 2 18:41:31 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Jun 2020 16:41:31 +0000 Subject: [Koha-bugs] [Bug 8338] Fines not cleared with dropbox mode In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8338 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #30 from Martin Renvoize --- The failing test is fixed and enhanced to catch more cases in the follow :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 2 18:47:18 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Jun 2020 16:47:18 +0000 Subject: [Koha-bugs] [Bug 24597] Add ability to add note on all payment screens In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24597 Donna changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bwsdonna at gmail.com --- Comment #2 from Donna --- This takes on a bit more urgency with bug 25526 - staff have no way to add a note to a write off. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jun 2 18:50:57 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Jun 2020 16:50:57 +0000 Subject: [Koha-bugs] [Bug 24379] Borrowers Login Attempts is NULL In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24379 --- Comment #8 from Kelly McElligott --- This is currently still the case on 19.11. When creating a new patron, the login attempts are set to NULL making the password recovery not work on the OPAC. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 2 19:12:39 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Jun 2020 17:12:39 +0000 Subject: [Koha-bugs] [Bug 14564] Export configuration: Unfortunately, no backups are available. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14564 John Sterbenz changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jsterben at umich.edu -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 2 20:52:15 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Jun 2020 18:52:15 +0000 Subject: [Koha-bugs] [Bug 25657] New: Import Patron fails without userid - not stated as required field in notes Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25657 Bug ID: 25657 Summary: Import Patron fails without userid - not stated as required field in notes Change sponsored?: --- Product: Koha Version: 19.11 Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Patrons Assignee: koha-bugs at lists.koha-community.org Reporter: eb at efdss.org QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com Somewhere in a recent upgrade, the userid became a required field for importing patrons. If it is not present Koha will attempt to use the userid from the person logged in for all userids. This causes the import to fail as they're 'duplicate'. This is an easy fix - update the notes to state the userid is a required field. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 2 20:59:01 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Jun 2020 18:59:01 +0000 Subject: [Koha-bugs] [Bug 16126] Display base-level amounts on the acquisition module home page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16126 Benjamin Daeuber changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bdaeuber at cityoffargo.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 2 20:59:26 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Jun 2020 18:59:26 +0000 Subject: [Koha-bugs] [Bug 23767] Spent and Ordered total values don't include child funds on acqui-home In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23767 Benjamin Daeuber changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bdaeuber at cityoffargo.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 2 21:28:26 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Jun 2020 19:28:26 +0000 Subject: [Koha-bugs] [Bug 25619] Add ability to adjust expiration date for waiting holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25619 Lisette Scheer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lisetteslatah at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 2 21:43:52 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Jun 2020 19:43:52 +0000 Subject: [Koha-bugs] [Bug 25658] New: Print icon sometimes obscures patron barcode Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25658 Bug ID: 25658 Summary: Print icon sometimes obscures patron barcode Change sponsored?: --- Product: Koha Version: 19.11 Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Circulation Assignee: koha-bugs at lists.koha-community.org Reporter: bdaeuber at cityoffargo.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com Created attachment 105499 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105499&action=edit screenshot of the print button covering the patron information On circulation.pl, the print icon in the checkout box can sometimes obscure the patron's barcode. Making the window a slightly different size can address this, but that' sometimes not an option. I am attaching a screenshot. This is taken from Chrome 83, but I can confirm it's occurring in Firefox as well. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 2 21:54:20 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Jun 2020 19:54:20 +0000 Subject: [Koha-bugs] [Bug 18532] AUTO_RENEWALS should be a patron messaging preference In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18532 Agustín Moyano changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 2 21:54:26 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Jun 2020 19:54:26 +0000 Subject: [Koha-bugs] [Bug 18532] AUTO_RENEWALS should be a patron messaging preference In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18532 Agustín Moyano changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #104880|0 |1 is obsolete| | Attachment #104881|0 |1 is obsolete| | Attachment #104882|0 |1 is obsolete| | Attachment #104883|0 |1 is obsolete| | --- Comment #44 from Agustín Moyano --- Created attachment 105500 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105500&action=edit Bug 18532: Add new letter AUTO_RENEWALS_DGST, new Auto_Renewals in message_attributes, and configured message_transports Signed-off-by: tgoat Signed-off-by: Kelly McElligott Signed-off-by: Marti Fuerst -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 2 21:54:31 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Jun 2020 19:54:31 +0000 Subject: [Koha-bugs] [Bug 18532] AUTO_RENEWALS should be a patron messaging preference In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18532 --- Comment #45 from Agustín Moyano --- Created attachment 105501 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105501&action=edit Bug 18532: set auto_renewals as patron messaging preference This patch adds the "Auto renewals" messaging preference on intranet and OPAC, and adds digest feature to misc/cronjobs/automatic_renewals.pl script. (Deprecated test plan. Please check the last patch) To test: 1. apply patches 2. perl installer/data/mysql/updatedatabase.pl 3. make sure automatic renewals are allowed in circ rules, have a positive number of allowed renewals and a positive number for renewal period 4. go to patron categories in administration of staff interface and choose a category. CHECK => in "Default messaging preferences for this patron category" has a "Auto renewals" row and has email and digest options checked 5. grab a patron and go to details page CHECK => patron's messaging preferences has a "Auto renewals" row with email and digest options checked 6. some settings and save 7. go to opac with that same patron to "your messaging" option CHECK => patron's messaging preferences has a "Auto renewals" row, and displays changes made in staff interface. 8. uncheck email and digest from "Auto renewals" row and save 9. check out an item for that patron, and set it as automatic renewal and set due date as your current yesterday 10. perl misc/cronjobs/automatic_renewals.pl -c --send-notices -v SUCCESS => item was renewed, and in message_queue table there is no new message for the patron 11. update patrons messaging preferences and set email option of "Auto renewals" row as checked 12. repeat steps 9 and 10 SUCCESS => item was renewed, but in message_queue table there is a new message of type AUTO_RENEWALS 13. update patrons messaging preferences and set email and digest options of "Auto renewals" row as checked 14. repeat steps 9 and 10 CHECK => item was not renewed 15. run step 10 again, but add -d flag, like this: perl misc/cronjobs/automatic_renewals.pl -c --send-notices -v -d SUCCESS => item was renewed, and in message_queue table there is a new message of type AUTO_RENEWALS_DGST 16. Sign off Signed-off-by: tgoat Signed-off-by: Kelly McElligott Signed-off-by: Kelly McElligott Signed-off-by: Marti Fuerst -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 2 21:54:36 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Jun 2020 19:54:36 +0000 Subject: [Koha-bugs] [Bug 18532] AUTO_RENEWALS should be a patron messaging preference In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18532 --- Comment #46 from Agustín Moyano --- Created attachment 105502 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105502&action=edit Bug 18532: (follow-up) Remove digest switch and add preference -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 2 21:54:38 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Jun 2020 19:54:38 +0000 Subject: [Koha-bugs] [Bug 25659] New: Hide batch actions from reports results if no permissions Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25659 Bug ID: 25659 Summary: Hide batch actions from reports results if no permissions Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Reports Assignee: koha-bugs at lists.koha-community.org Reporter: andrew at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org After bug 23197, reports give a handy button to send items, bibs, and patrons to batch processes. However, this button will appear and offer options that the user may not have access to. It'd be handy to check permissions before offering the button. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 2 21:54:42 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Jun 2020 19:54:42 +0000 Subject: [Koha-bugs] [Bug 18532] AUTO_RENEWALS should be a patron messaging preference In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18532 --- Comment #47 from Agustín Moyano --- Created attachment 105503 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105503&action=edit Bug 18532: add individual issues to digest notice and hide auto_renewals messaging preference when not needed This patch enhances auto_renewals message, removes auto_renewals messaging preference when AutoRenewalNotices is not set to ‘preferences’ and uses that preference to send notices in automatic_renewals.pl script. To test: 1. Apply patches 2. updatedatabase 3. make sure automatic renewals are allowed in circ rules, have a positive number of allowed renewals and a positive number for renewal period 4. Check AutoRenewalNotices preference SUCCESS => AutoRenewalNotices has the value ‘cron’ (means that It keeps the usual behaviour) 5. Checkout two items for a patron, and set them as automatic renewal and set due date as your current yesterday 6. perl misc/cronjobs/automatic_renewals.pl -c -v SUCCESS => items were renewed, but there is no message in message_queue table in mysql 7. Repeat step 5 8. perl misc/cronjobs/automatic_renewals.pl -c -s -v SUCCESS => items were renewed, and there is one message per item in message_queue table in mysql 9. Change AutoRenewalNotices to ‘never’ 10. Repeat step 5 11. perl misc/cronjobs/automatic_renewals.pl -c -s -v SUCCESS => items were renewed, but there is no message in message_queue table in mysql, even with the -s switch 12. Check any patron’s category, and any detail page in staff or OPAC interface, and in any of them you should find Auto Renewals messaging preference 13. Change AutoRenewalNotices to ‘preferences’ 14. Repeat step 12, but this time all of them shows the Auto Renewals messaging preference. 15. Repeat step 5 with a patron that has no messaging preference setted 16. perl misc/cronjobs/automatic_renewals.pl -c -s -v SUCCESS => items were renewed, but there is no message in message_queue table in mysql, because patron didn’t choose to receive messages 17. Grab a category and modify auto renewals messaging preferences, and save 18. Create a new patron from that category. SUCCESS => created patron has the same messaging preference for auto renewals 19. Grab that patron and change auto renewals messaging preference to email but not digest 20. Repeat step 5 for that last patron. 21. perl misc/cronjobs/automatic_renewals.pl -c -v SUCCESS => Items were renewed, and there is a message for each item in message_queue table in mysql. 22. Change auto renewals messaging preference from the same patron and set to email and digest. 23. Repeat step 5. 24. perl misc/cronjobs/automatic_renewals.pl -c -v SUCCESS => items where renewed, and now there is only one message in message_queue table with the details of both renewed items. 25. Check that any changes to a patron’s auto renewals messaging preference in staff is reflected in OPAC, and the other way arround too. 26. Sign off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 2 21:55:09 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Jun 2020 19:55:09 +0000 Subject: [Koha-bugs] [Bug 25659] Hide batch actions from reports results if no permissions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25659 George Williams (NEKLS) changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |george at nekls.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 2 21:56:02 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Jun 2020 19:56:02 +0000 Subject: [Koha-bugs] [Bug 25659] Hide batch actions from reports results if no permissions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25659 Lisette Scheer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lisetteslatah at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 2 21:56:07 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Jun 2020 19:56:07 +0000 Subject: [Koha-bugs] [Bug 25659] Hide batch actions from reports results if no permissions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25659 --- Comment #1 from George Williams (NEKLS) --- It would definitely be better to have the options not show if staff cannot perform those actions. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 2 22:04:04 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Jun 2020 20:04:04 +0000 Subject: [Koha-bugs] [Bug 18532] AUTO_RENEWALS should be a patron messaging preference In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18532 --- Comment #48 from Agustín Moyano --- Thak you Nick so much for your code, it was illuminating! :D -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 2 23:00:32 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Jun 2020 21:00:32 +0000 Subject: [Koha-bugs] [Bug 25642] Technical notes are missing from the release In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25642 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jun 2 23:00:37 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Jun 2020 21:00:37 +0000 Subject: [Koha-bugs] [Bug 25642] Technical notes are missing from the release In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25642 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #105475|0 |1 is obsolete| | --- Comment #3 from Bernardo Gonzalez Kriegel --- Created attachment 105505 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105505&action=edit Bug 25642: Add technical notes Signed-off-by: Martin Renvoize Signed-off-by: Bernardo Gonzalez Kriegel -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 3 00:21:07 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Jun 2020 22:21:07 +0000 Subject: [Koha-bugs] [Bug 25660] New: Unable to change system preferences in "vintage" git install without plack Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25660 Bug ID: 25660 Summary: Unable to change system preferences in "vintage" git install without plack Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: System Administration Assignee: koha-bugs at lists.koha-community.org Reporter: caroline.cyr-la-rose at inlibro.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com Created attachment 105506 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105506&action=edit screenshot showing the error message Ok, so I don't know if this should be a bug. Tomás said to file one anyway. :) It does impact my ability to do pretty much anything with my Koha install. I have a git install of Koha which I update using git pull/updatedatabase. No plack, no memcached. For a couple of weeks, I haven't been able to change system preferences. When I try to save, it says "Internal Server Error, please reload the page". This is not the blank Internal Server Error you get when you have plack. It's a message that pops-up in a dark grey box (see attachment). -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jun 3 00:31:55 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Jun 2020 22:31:55 +0000 Subject: [Koha-bugs] [Bug 25526] Using Write Off Selected will not allow for a different amount to be written off In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25526 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 3 00:31:58 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Jun 2020 22:31:58 +0000 Subject: [Koha-bugs] [Bug 25526] Using Write Off Selected will not allow for a different amount to be written off In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25526 --- Comment #2 from Lucas Gass --- Created attachment 105507 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105507&action=edit Bug 25526: Allow write off selected of less than or equal to amount TEST PLAN: 1. Have a fine on a Patron's account. 2. Choose the "Write off Selected" button 3. Enter an amount less than the amount owed by the patron. 4. Koha will give a yellow box with a note "You must collect a value greater than or equal to 2.00." The $2.00 is the amount that is attempted to write off (the amount less than the amount owed). 5. Apply patch 6. Again try to pay an amount less than the amount owed. 7. You should be able to pay it off. 8. Try paying an amount more than owed, you should still get an error. You shouldn't be able to write off more than the amount. 9. Make sure 'Pay selected' still works as it should. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 3 01:15:13 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 02 Jun 2020 23:15:13 +0000 Subject: [Koha-bugs] [Bug 25660] Unable to change system preferences in "vintage" git install without plack In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25660 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au --- Comment #1 from David Cook --- Is this using koha-gitify via koha-testing-docker or kohadevbox? I think I've seen this where I've been working on the staff client and the OPAC, and I've logged out of the OPAC but then tried to save a system preference in the staff client and then got an error like this. It was because the session cookie was shared between the staff client and OPAC as I was using the same hostname with different ports. That might not be relevant for you though. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 3 05:04:21 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jun 2020 03:04:21 +0000 Subject: [Koha-bugs] [Bug 25661] New: auth_header missing authtypecode index Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25661 Bug ID: 25661 Summary: auth_header missing authtypecode index Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs at lists.koha-community.org Reporter: dcook at prosentient.com.au QA Contact: testopia at bugs.koha-community.org While code like tools/export.pl and Koha/MetadataRecord/Authority.pm all seem to rely primarily on the authid primary key, it seems to me that there are scenarios where you want to report on authority records using only the authtypecode field. At the moment, the database has to do a row scan through every auth_header row in order to determine which records to return. If we used an authtypecode index, the database would be able to process the search query much quicker and do much less work on the backend. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jun 3 10:13:15 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jun 2020 08:13:15 +0000 Subject: [Koha-bugs] [Bug 25634] koha-foreach exits too early if any command has non-zero status In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25634 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #105453|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 3 10:13:50 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jun 2020 08:13:50 +0000 Subject: [Koha-bugs] [Bug 25634] koha-foreach exits too early if any command has non-zero status In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25634 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|normal |major -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 3 10:14:29 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jun 2020 08:14:29 +0000 Subject: [Koha-bugs] [Bug 12388] IssueSlip output should be sorted by date_due, not timestamp In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12388 Joonas Kylmälä changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |joonas.kylmala at helsinki.fi Status|Signed Off |Failed QA --- Comment #12 from Joonas Kylmälä --- Hi, the tests didn't remove/replace the now unneeded code under the comments > # Set timestamps to the same value to avoid a different order Also the test cases now only test sorting with issue date, not by date due. Testing of date due sorting should be added to cover this change fully. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 3 10:20:00 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jun 2020 08:20:00 +0000 Subject: [Koha-bugs] [Bug 24683] Holds on biblios with different item types: rules for holds allowed are not applied correctly if any item type is available In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24683 Andrew Nugged changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |nugged at gmail.com |ity.org | CC| |nugged at gmail.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jun 3 10:20:26 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jun 2020 08:20:26 +0000 Subject: [Koha-bugs] [Bug 24683] Holds on biblios with different item types: rules for holds allowed are not applied correctly if any item type is available In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24683 Andrew Nugged changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |slavashishkin at gmail.com, | |stalkernoid at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 3 10:28:41 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jun 2020 08:28:41 +0000 Subject: [Koha-bugs] [Bug 25657] Import Patron fails without userid - not stated as required field in notes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25657 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #1 from Jonathan Druart --- Hi Elaine, I have tried on 19.11.06, I am not sure I understand what the problem is. If I use the import patron tool to create new patrons and the csv file does not contain a userid (either no value in the cell, or no header at all), then the userid is automatically built concatenating firstname and surname. Can you detail a bit more? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 3 10:34:17 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jun 2020 08:34:17 +0000 Subject: [Koha-bugs] [Bug 25662] New: Create hold route does not check maxreserves syspref Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25662 Bug ID: 25662 Summary: Create hold route does not check maxreserves syspref Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: REST API Assignee: koha-bugs at lists.koha-community.org Reporter: jonathan.druart at bugs.koha-community.org Depends on: 13903 The "maxreserves" syspref is only checked in opac/opac-reserve.pl and reserve/request.pl Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13903 [Bug 13903] Add API routes to list, create, update, delete holds -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jun 3 10:34:17 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jun 2020 08:34:17 +0000 Subject: [Koha-bugs] [Bug 13903] Add API routes to list, create, update, delete holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13903 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |25662 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25662 [Bug 25662] Create hold route does not check maxreserves syspref -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 3 10:34:25 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jun 2020 08:34:25 +0000 Subject: [Koha-bugs] [Bug 25643] Remove maxreserves syspref In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25643 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=25662 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jun 3 10:34:25 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jun 2020 08:34:25 +0000 Subject: [Koha-bugs] [Bug 25662] Create hold route does not check maxreserves syspref In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25662 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=25643 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 3 11:00:16 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jun 2020 09:00:16 +0000 Subject: [Koha-bugs] [Bug 23191] Administrators should be able to install plugins from the command line In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23191 --- Comment #23 from Martin Renvoize --- (In reply to David Cook from comment #22) > I like the sound of this but the implementation seems very different to what > I would have expected. > > I thought it would be something like "misc/devel/install_plugin.pl > ". Feel free to add such this additional functionality in a new bug ;) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 3 11:07:47 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jun 2020 09:07:47 +0000 Subject: [Koha-bugs] [Bug 22417] Delegate background jobs execution In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22417 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_20_11_target, | |RM_priority -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 3 11:23:31 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jun 2020 09:23:31 +0000 Subject: [Koha-bugs] [Bug 23231] We display too many layout options for the onscreen keyboard in the advanced cataloguing editor In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23231 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|RM_priority | CC| |jonathan.druart at bugs.koha-c | |ommunity.org -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jun 3 11:24:08 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jun 2020 09:24:08 +0000 Subject: [Koha-bugs] [Bug 6664] Allow to set a weekly holiday for a given data range In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6664 Alexander Borkowski changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |alexander.borkowski at kau.se -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 3 11:27:30 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jun 2020 09:27:30 +0000 Subject: [Koha-bugs] [Bug 24782] Calendar edit only applies to first day In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24782 Alexander Borkowski changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |alexander.borkowski at kau.se -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 3 11:27:51 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jun 2020 09:27:51 +0000 Subject: [Koha-bugs] [Bug 12446] Enable an adult to have a guarantor In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12446 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_20_11_target | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 3 11:27:54 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jun 2020 09:27:54 +0000 Subject: [Koha-bugs] [Bug 22569] Stock rotation: 'Transfers to send' report In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22569 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_20_11_target | CC| |jonathan.druart at bugs.koha-c | |ommunity.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 3 11:27:57 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jun 2020 09:27:57 +0000 Subject: [Koha-bugs] [Bug 15326] Add CMS feature In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15326 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_20_11_target | CC| |jonathan.druart at bugs.koha-c | |ommunity.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 3 11:28:02 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jun 2020 09:28:02 +0000 Subject: [Koha-bugs] [Bug 22818] ILL should be able to send notices In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22818 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_20_11_target | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 3 11:28:05 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jun 2020 09:28:05 +0000 Subject: [Koha-bugs] [Bug 13952] Import and export of authority types In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13952 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_20_11_target | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 3 11:28:10 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jun 2020 09:28:10 +0000 Subject: [Koha-bugs] [Bug 18506] SSO - Shibboleth Only Mode In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18506 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_20_11_target | CC| |jonathan.druart at bugs.koha-c | |ommunity.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 3 11:28:13 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jun 2020 09:28:13 +0000 Subject: [Koha-bugs] [Bug 24083] Koha should support "seen" vs "unseen" renewals In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24083 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_20_11_target | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 3 11:28:16 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jun 2020 09:28:16 +0000 Subject: [Koha-bugs] [Bug 24412] Attach waiting reserve to desk In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24412 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org Keywords|rel_20_11_target | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 3 11:28:18 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jun 2020 09:28:18 +0000 Subject: [Koha-bugs] [Bug 23092] Transfers should record 'requested' as well as 'sent' and 'arrived' dates. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23092 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_20_11_target | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 3 11:28:30 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jun 2020 09:28:30 +0000 Subject: [Koha-bugs] [Bug 15985] Include checkout library in fines In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15985 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_20_11_target | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 3 11:28:34 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jun 2020 09:28:34 +0000 Subject: [Koha-bugs] [Bug 11299] Add a button to automatically link authority records in cataloguing (AJAX) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11299 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_20_11_target | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 3 11:28:37 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jun 2020 09:28:37 +0000 Subject: [Koha-bugs] [Bug 23838] Add ability to view item renew history In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23838 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_20_11_target | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 3 11:28:43 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jun 2020 09:28:43 +0000 Subject: [Koha-bugs] [Bug 23681] Patron restrictions should be user definable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|jonathan.druart at bugs.koha-c | |ommunity.org | Keywords|rel_20_11_target | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 3 11:28:52 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jun 2020 09:28:52 +0000 Subject: [Koha-bugs] [Bug 25261] Multiple parts handling - confirmation alert In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25261 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_20_11_target | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 3 11:28:55 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jun 2020 09:28:55 +0000 Subject: [Koha-bugs] [Bug 22393] Remove last remaining manualinvoice use In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22393 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_20_11_target | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 3 11:28:59 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jun 2020 09:28:59 +0000 Subject: [Koha-bugs] [Bug 8338] Fines not cleared with dropbox mode In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8338 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_20_11_target | CC| |jonathan.druart at bugs.koha-c | |ommunity.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 3 11:29:00 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jun 2020 09:29:00 +0000 Subject: [Koha-bugs] [Bug 25222] Add ability to let plugins live in individual subdirectories In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25222 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org Keywords|rel_20_11_target | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 3 11:29:04 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jun 2020 09:29:04 +0000 Subject: [Koha-bugs] [Bug 24631] Plugin metadata should be outside the main class In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24631 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_20_11_target | CC| |jonathan.druart at bugs.koha-c | |ommunity.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 3 11:29:07 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jun 2020 09:29:07 +0000 Subject: [Koha-bugs] [Bug 22773] Bulk Close invoices and Filter invoice view (open/closed) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22773 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_20_11_target | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 3 11:29:09 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jun 2020 09:29:09 +0000 Subject: [Koha-bugs] [Bug 19036] Number payment receipts / payment slips In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19036 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_20_11_target | CC| |jonathan.druart at bugs.koha-c | |ommunity.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 3 11:29:10 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jun 2020 09:29:10 +0000 Subject: [Koha-bugs] [Bug 14957] Write protecting MARC fields based on source of import In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_20_11_target | CC| |jonathan.druart at bugs.koha-c | |ommunity.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 3 11:29:13 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jun 2020 09:29:13 +0000 Subject: [Koha-bugs] [Bug 24632] Plugins should support simple signing for security/verifiability In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24632 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_20_11_target | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 3 11:29:17 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jun 2020 09:29:17 +0000 Subject: [Koha-bugs] [Bug 24197] Custom destination for failed overdue notices In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24197 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org Keywords|rel_20_11_target | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 3 11:29:19 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jun 2020 09:29:19 +0000 Subject: [Koha-bugs] [Bug 11808] When searching for a cardnumber in the intranet, also try to search for it on the LDAP server if one is configured and add/update user In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11808 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org Keywords|rel_20_11_target | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 3 11:29:25 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jun 2020 09:29:25 +0000 Subject: [Koha-bugs] [Bug 21249] Syspref to choose whether to search homebranch, holding branch or both for library groups in advanced search In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21249 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_20_11_target | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 3 11:29:26 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jun 2020 09:29:26 +0000 Subject: [Koha-bugs] [Bug 24201] Attach desk to intranet session In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24201 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_20_11_target | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 3 11:29:29 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jun 2020 09:29:29 +0000 Subject: [Koha-bugs] [Bug 23890] Plugins that utilise possibly security breaching hooks should warn In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23890 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_20_11_target | CC| |jonathan.druart at bugs.koha-c | |ommunity.org -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jun 3 11:29:30 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jun 2020 09:29:30 +0000 Subject: [Koha-bugs] [Bug 24446] Stockrotation: Update to use daterequested in branchtransfers In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24446 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_20_11_target | CC| |jonathan.druart at bugs.koha-c | |ommunity.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 3 11:29:33 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jun 2020 09:29:33 +0000 Subject: [Koha-bugs] [Bug 22745] Need a "Do not notify" option in messaging preferences In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22745 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_20_11_target | CC| |jonathan.druart at bugs.koha-c | |ommunity.org -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 3 11:29:35 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jun 2020 09:29:35 +0000 Subject: [Koha-bugs] [Bug 23695] Items holdingbranch should be set to the originating library when generating a manual transfer In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23695 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_20_11_target | CC| |jonathan.druart at bugs.koha-c | |ommunity.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 3 11:29:36 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jun 2020 09:29:36 +0000 Subject: [Koha-bugs] [Bug 22539] Fines charged on back-dated checkin when item has been renewed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22539 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_20_11_target | CC| |jonathan.druart at bugs.koha-c | |ommunity.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 3 11:29:39 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jun 2020 09:29:39 +0000 Subject: [Koha-bugs] [Bug 18729] Librarian unable to update hold pickup library from patron pages without "modify_holds_priority" permission In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18729 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_20_11_target | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 3 11:29:42 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jun 2020 09:29:42 +0000 Subject: [Koha-bugs] [Bug 7376] Transfer limits should be checked at check-in In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7376 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_20_11_target | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 3 11:29:45 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jun 2020 09:29:45 +0000 Subject: [Koha-bugs] [Bug 18958] If patron has multiple record level holds on one record transferring first hold causes next hold to become item level In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18958 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_20_11_target | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 3 11:29:46 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jun 2020 09:29:46 +0000 Subject: [Koha-bugs] [Bug 23091] Restore Forgiven Overdue Fines When Lost Item Returned In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23091 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_20_11_target | CC| |jonathan.druart at bugs.koha-c | |ommunity.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 3 11:29:49 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jun 2020 09:29:49 +0000 Subject: [Koha-bugs] [Bug 25377] Transfer does not change current item location In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25377 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_20_11_target | CC| |jonathan.druart at bugs.koha-c | |ommunity.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 3 11:47:14 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jun 2020 09:47:14 +0000 Subject: [Koha-bugs] [Bug 24379] Borrowers Login Attempts is NULL In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24379 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #9 from Jonathan Druart --- I have tried on both master and 19.11.x and login_attempts contains "0" -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 3 11:49:04 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jun 2020 09:49:04 +0000 Subject: [Koha-bugs] [Bug 25638] API related tests failing on comparing floats In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25638 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|tomascohen at gmail.com |jonathan.druart at bugs.koha-c | |ommunity.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 3 11:49:28 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jun 2020 09:49:28 +0000 Subject: [Koha-bugs] [Bug 25638] API related tests failing on comparing floats In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25638 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |RM_priority -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 3 11:54:10 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jun 2020 09:54:10 +0000 Subject: [Koha-bugs] [Bug 25550] Koha/Plugins/Plugins.t is failing randomly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25550 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |DUPLICATE Status|NEW |RESOLVED --- Comment #1 from Jonathan Druart --- *** This bug has been marked as a duplicate of bug 21670 *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 3 11:54:10 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jun 2020 09:54:10 +0000 Subject: [Koha-bugs] [Bug 21670] t/db_dependent/Plugins.t is failing randomly on Jenkins (U18) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21670 --- Comment #2 from Jonathan Druart --- *** Bug 25550 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 3 11:54:11 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jun 2020 09:54:11 +0000 Subject: [Koha-bugs] [Bug 25551] [OMNIBUS] Some tests are failing randomly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25551 Bug 25551 depends on bug 25550, which changed state. Bug 25550 Summary: Koha/Plugins/Plugins.t is failing randomly https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25550 What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |DUPLICATE -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 3 11:54:30 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jun 2020 09:54:30 +0000 Subject: [Koha-bugs] [Bug 21670] t/db_dependent/Plugins.t is failing randomly on Jenkins (U18) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21670 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=25549 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 3 11:54:30 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jun 2020 09:54:30 +0000 Subject: [Koha-bugs] [Bug 25549] Install plugin script/method should remove broken plugins In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25549 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=21670 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 3 12:14:08 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jun 2020 10:14:08 +0000 Subject: [Koha-bugs] [Bug 13125] Total Holds does not tally holds / items.reserves is not populated In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13125 anne-cecile.bories at iepg.fr changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |anne-cecile.bories at iepg.fr -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 3 12:36:15 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jun 2020 10:36:15 +0000 Subject: [Koha-bugs] [Bug 22522] API authentication breaks with updated Mojolicious version In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22522 --- Comment #54 from Jonathan Druart --- All the API related tests are failing for 18.11 and 19.05 (maybe 19.11 as well, I have just requested a new run 19.11_D9 #156). Could that be related to this change? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 3 12:47:04 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jun 2020 10:47:04 +0000 Subject: [Koha-bugs] [Bug 25663] New: Koha::RefundLostItemFeeRules should be merged into Koha::CirculationRules Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25663 Bug ID: 25663 Summary: Koha::RefundLostItemFeeRules should be merged into Koha::CirculationRules Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs at lists.koha-community.org Reporter: martin.renvoize at ptfs-europe.com QA Contact: testopia at bugs.koha-community.org Now that we have a clearer set of methods within the Koha::CirculationRules module, we should clean up the stepping stone RefundLostItemFeeRules modules. This also paves the way for some enhancements to this area of functionality I am looking to do in bug 23091 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 3 12:56:59 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jun 2020 10:56:59 +0000 Subject: [Koha-bugs] [Bug 25554] Refactor rule kinds assignments in CirculationRules.pm In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25554 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #2 from Jonathan Druart --- Hum, I am going to ask myself "what it scope2 again?" for years :) I agree we could have that in a variable, but be more explicit: b_c, b_i, b_c_i or, even better IMO: branch_category, branch_itemtype, branch_category_itemtype -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 3 12:57:55 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jun 2020 10:57:55 +0000 Subject: [Koha-bugs] [Bug 19821] Run tests on a separate database In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19821 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com QA Contact|testopia at bugs.koha-communit |kyle at bywatersolutions.com |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 3 13:02:48 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jun 2020 11:02:48 +0000 Subject: [Koha-bugs] [Bug 25557] Column config table in acquisitions order does not match the acq table in baskets In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25557 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org Attachment #105425|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 3 13:05:08 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jun 2020 11:05:08 +0000 Subject: [Koha-bugs] [Bug 19821] Run tests on a separate database In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19821 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #62 from Kyle M Hall --- Jonathan, can we get a unified test plan for this patch set? I'm not sure if I'm testing wrong. Selenium tests pass in 'normal' mode, so I know it's not my Selenium container that's not problematic: root at 16935ef8a671:koha(bug19821-qa)$ prove -Mt::lib::Bootstrap t/db_dependent/selenium/00-installation.t t/db_dependent/selenium/00-installation.t .. Use of uninitialized value in concatenation (.) or string at /kohadevbox/koha/t/lib/Selenium.pm line 87. Use of uninitialized value in concatenation (.) or string at /kohadevbox/koha/t/lib/Selenium.pm line 87. STRACE: /usr/share/perl5/Try/Tiny.pm:124 in Selenium::Remote::Driver::catch {...} /usr/local/share/perl/5.24.1/Selenium/Remote/Driver.pm:353 in Try::Tiny::try (eval 340):1 in Selenium::Remote::Driver::__ANON__ (eval 342):2 in Selenium::Remote::Driver::__ANON__ /usr/local/share/perl/5.24.1/Selenium/Remote/Driver.pm:937 in Selenium::Remote::Driver::_execute_command t/db_dependent/selenium/00-installation.t:54 in Selenium::Remote::Driver::get SCREENSHOT: https://framapic.org/g4mzi23sJZJh/qs6oGBNksp4u Error while executing command: get: An unknown server-side error occurred while processing the command.: Target URL /cgi-bin/koha/mainpage.pl is not well-formed. Build info: version: '2.53.1', revision: 'a36b8b1', time: '2016-06-30 17:37:03' System info: host: '61269cb7f179', ip: '172.18.0.4', os.name: 'Linux', os.arch: 'amd64', os.version: '4.19.76-linuxkit', java.version: '1.8.0_91' Driver info: driver.version: unknown at /usr/local/share/perl/5.24.1/Selenium/Remote/Driver.pm line 404. at /usr/local/share/perl/5.24.1/Selenium/Remote/Driver.pm line 348. # Looks like your test exited with 255 before it could output anything. t/db_dependent/selenium/00-installation.t .. Dubious, test returned 255 (wstat 65280, 0xff00) Failed 2/2 subtests Test Summary Report ------------------- t/db_dependent/selenium/00-installation.t (Wstat: 65280 Tests: 0 Failed: 0) Non-zero exit status: 255 Parse errors: Bad plan. You planned 2 tests but ran 0. Files=1, Tests=0, 5 wallclock secs ( 0.02 usr 0.00 sys + 1.10 cusr 0.20 csys = 1.32 CPU) Result: FAIL -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 3 13:57:51 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jun 2020 11:57:51 +0000 Subject: [Koha-bugs] [Bug 25664] New: login_attempts for imported borrowers can be set to NULL Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25664 Bug ID: 25664 Summary: login_attempts for imported borrowers can be set to NULL Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Tools Assignee: koha-bugs at lists.koha-community.org Reporter: nick at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org On bug 24379 there has been some conversation about login_attempts being set to null. While it doesn't seem to happen at creation it does during an import To recreate: 1 - Check your DB select distinct login_attempts from borrowers; 2 - All should be 0 (if you have some nulls already, thats ok) 3 - Run a report and download as CSV (you may need to set the delimiter syspref to comma) select surname, cardnumber, categorycode, branchcode FROM borrowers 4 - Tools -> Import borrowers 5 - Set to match on cardnumber and overwrite patrons 6 - Check the DB after import select distinct login_attempts from borrowers; 7 - All login_attempts are NULL -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 3 13:58:20 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jun 2020 11:58:20 +0000 Subject: [Koha-bugs] [Bug 25664] login_attempts for imported borrowers can be set to NULL In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25664 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |24379 CC| |jonathan.druart at bugs.koha-c | |ommunity.org, | |kelly at bywatersolutions.com Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24379 [Bug 24379] Borrowers Login Attempts is NULL -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 3 13:58:20 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jun 2020 11:58:20 +0000 Subject: [Koha-bugs] [Bug 24379] Borrowers Login Attempts is NULL In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24379 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |25664 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25664 [Bug 25664] login_attempts for imported borrowers can be set to NULL -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 3 14:08:46 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jun 2020 12:08:46 +0000 Subject: [Koha-bugs] [Bug 25375] Elasticsearch: Limit on available items does not work In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25375 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrew at bywatersolutions.com Status|Needs Signoff |Failed QA --- Comment #2 from Andrew Fuerste-Henry --- I'm getting an error in the Elastic rebuild: root at 287fd5fefa08:koha(master)$ perl misc/search_tools/rebuild_elasticsearch.pl -d -b Can't call method "items" on an undefined value at /kohadevbox/koha/Koha/SearchEngine/Elasticsearch.pm line 710. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 3 14:18:43 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jun 2020 12:18:43 +0000 Subject: [Koha-bugs] [Bug 24379] Borrowers Login Attempts is NULL In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24379 --- Comment #10 from Nick Clemens --- Created attachment 105522 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105522&action=edit Bug 24379: Don't drop default of 0 for login attempts When moving the column we drop the default, this means that DBs upgraded form earlier versions get the wrong values set To test: 1 - Checkout 16.11.x 2 - Reset all 3 - Checkout master 4 - updatedatabase 5 - SHOW CREATE TABLE borrowers; 6 - Note the column login_attempts defaults to NULL 7 - Apply patch(es) 8 - Repeat 9 - Now it defaults ot 0 (and has NOT NULL if applied all) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 3 14:23:43 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jun 2020 12:23:43 +0000 Subject: [Koha-bugs] [Bug 22522] API authentication breaks with updated Mojolicious version In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22522 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com --- Comment #55 from Kyle M Hall --- (In reply to Jonathan Druart from comment #54) > All the API related tests are failing for 18.11 and 19.05 (maybe 19.11 as > well, I have just requested a new run 19.11_D9 #156). > > Could that be related to this change? I think so. At least, they are failing for me on koha-testing-docker, presumably because the Mojo version is too new. - my $spec = $c->match->endpoint->pattern->defaults->{'openapi.op_spec'}; + my $spec = $c->openapi->spec || $c->match->endpoint->pattern->defaults->{'openapi.op_spec'}; Fixes it for me. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 3 15:35:35 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jun 2020 13:35:35 +0000 Subject: [Koha-bugs] [Bug 25442] Release dates are missing from the timeline In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25442 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Koha history ends in |Release dates are missing |November 2019 |from the timeline -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 3 15:39:52 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jun 2020 13:39:52 +0000 Subject: [Koha-bugs] [Bug 25442] Release dates are missing from the timeline In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25442 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 3 15:39:55 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jun 2020 13:39:55 +0000 Subject: [Koha-bugs] [Bug 25442] Release dates are missing from the timeline In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25442 --- Comment #3 from Jonathan Druart --- Created attachment 105523 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105523&action=edit Bug 25442: Add release dates from the timeline It also fixes 326th<=>327th and 393rd<=>394th dev positions -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 3 15:40:04 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jun 2020 13:40:04 +0000 Subject: [Koha-bugs] [Bug 25442] Release dates are missing from the timeline In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25442 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |minor -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 3 15:55:09 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jun 2020 13:55:09 +0000 Subject: [Koha-bugs] [Bug 25663] Koha::RefundLostItemFeeRules should be merged into Koha::CirculationRules In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25663 --- Comment #1 from Martin Renvoize --- Created attachment 105524 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105524&action=edit Bug 25663: Add unit tests This patch adds unit tests for a new get_lostretun_policy method which is getting added to Koha::CirculationRules. Test plan: 1/ Read the additions to t/db_dependent/CirculationRules.t code and compare to the t/db_dependent/RefundLostItemFeeRule.t. 2/ Run the test after applying the patch that adds the new method 3/ If the tests all pass, signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jun 3 15:55:12 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jun 2020 13:55:12 +0000 Subject: [Koha-bugs] [Bug 25663] Koha::RefundLostItemFeeRules should be merged into Koha::CirculationRules In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25663 --- Comment #2 from Martin Renvoize --- Created attachment 105525 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105525&action=edit Bug 25663: Add get_lostreturn_policy method to CirculationRules This patch adds a new get_lostreturn_policy method to Koha::CirculationRules which returns a boolean to the caller which denotes whether a refund should be applied or not on the return of a lost item. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jun 3 15:55:15 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jun 2020 13:55:15 +0000 Subject: [Koha-bugs] [Bug 25663] Koha::RefundLostItemFeeRules should be merged into Koha::CirculationRules In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25663 --- Comment #3 from Martin Renvoize --- Created attachment 105526 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105526&action=edit Bug 25663: Remove Koha::RefundLostItemFeeRule and uses This patch replaces all calls to RefundLostItemFeeRules with Koha::CirculationRules->get_lostreturn_policy and removes the module it makes redundant. Test plan 1/ Confirm that there are no longer any uses of RefundLostItemFeeRules in the codebase 2/ Confirm circulation tests still all pass 3/ Confirm you can still set and unset the lost return rules 4/ Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 3 15:58:25 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jun 2020 13:58:25 +0000 Subject: [Koha-bugs] [Bug 25663] Koha::RefundLostItemFeeRules should be merged into Koha::CirculationRules In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25663 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |23091 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23091 [Bug 23091] Restore Forgiven Overdue Fines When Lost Item Returned -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jun 3 15:58:25 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jun 2020 13:58:25 +0000 Subject: [Koha-bugs] [Bug 23091] Restore Forgiven Overdue Fines When Lost Item Returned In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23091 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |25663 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25663 [Bug 25663] Koha::RefundLostItemFeeRules should be merged into Koha::CirculationRules -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 3 16:06:36 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jun 2020 14:06:36 +0000 Subject: [Koha-bugs] [Bug 25663] Koha::RefundLostItemFeeRules should be merged into Koha::CirculationRules In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25663 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |martin.renvoize at ptfs-europe |ity.org |.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 3 16:06:44 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jun 2020 14:06:44 +0000 Subject: [Koha-bugs] [Bug 25663] Koha::RefundLostItemFeeRules should be merged into Koha::CirculationRules In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25663 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 3 16:09:40 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jun 2020 14:09:40 +0000 Subject: [Koha-bugs] [Bug 25663] Koha::RefundLostItemFeeRules should be merged into Koha::CirculationRules In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25663 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #105526|0 |1 is obsolete| | --- Comment #4 from Martin Renvoize --- Created attachment 105527 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105527&action=edit Bug 25663: Remove Koha::RefundLostItemFeeRule and uses This patch replaces all calls to RefundLostItemFeeRules with Koha::CirculationRules->get_lostreturn_policy and removes the module it makes redundant. Test plan 1/ Confirm that there are no longer any uses of RefundLostItemFeeRules in the codebase 2/ Confirm circulation tests still all pass 3/ Confirm you can still set and unset the lost return rules 4/ Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 3 16:10:03 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jun 2020 14:10:03 +0000 Subject: [Koha-bugs] [Bug 25663] Koha::RefundLostItemFeeRules should be merged into Koha::CirculationRules In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25663 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 3 16:11:45 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jun 2020 14:11:45 +0000 Subject: [Koha-bugs] [Bug 25660] Unable to change system preferences in "vintage" git install without plack In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25660 --- Comment #2 from Caroline Cyr La Rose --- Hi David, No I'm not using docker nor devbox. Caroline -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 3 16:53:38 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jun 2020 14:53:38 +0000 Subject: [Koha-bugs] [Bug 15522] New interface for revamped circulation rules In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15522 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Signed Off --- Comment #119 from Nick Clemens --- Sponsoring library has approved, removing discussion status -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 3 17:07:19 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jun 2020 15:07:19 +0000 Subject: [Koha-bugs] [Bug 25526] Using Write Off Selected will not allow for a different amount to be written off In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25526 ByWater Sandboxes changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #105507|0 |1 is obsolete| | --- Comment #3 from ByWater Sandboxes --- Created attachment 105528 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105528&action=edit Bug 25526: Allow write off selected of less than or equal to amount TEST PLAN: 1. Have a fine on a Patron's account. 2. Choose the "Write off Selected" button 3. Enter an amount less than the amount owed by the patron. 4. Koha will give a yellow box with a note "You must collect a value greater than or equal to 2.00." The $2.00 is the amount that is attempted to write off (the amount less than the amount owed). 5. Apply patch 6. Again try to pay an amount less than the amount owed. 7. You should be able to pay it off. 8. Try paying an amount more than owed, you should still get an error. You shouldn't be able to write off more than the amount. 9. Make sure 'Pay selected' still works as it should. Signed-off-by: Lisette Scheer -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jun 3 17:07:33 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jun 2020 15:07:33 +0000 Subject: [Koha-bugs] [Bug 25526] Using Write Off Selected will not allow for a different amount to be written off In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25526 Lisette Scheer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jun 3 17:11:10 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jun 2020 15:11:10 +0000 Subject: [Koha-bugs] [Bug 15522] New interface for revamped circulation rules In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15522 --- Comment #120 from Jonathan Druart --- (In reply to Nick Clemens from comment #119) > Sponsoring library has approved, removing discussion status Could you share a summary of what has been tested and discussed? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 3 17:26:16 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jun 2020 15:26:16 +0000 Subject: [Koha-bugs] [Bug 25434] When viewing cart on small screen sizes selections-toolbar is hidden In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25434 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|lucas at bywatersolutions.com |jonathan.druart at bugs.koha-c | |ommunity.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 3 17:26:52 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jun 2020 15:26:52 +0000 Subject: [Koha-bugs] [Bug 25233] Staff XSLT material type label "Book" should be "Text" In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25233 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to oldstable |RESOLVED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 3 17:27:13 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jun 2020 15:27:13 +0000 Subject: [Koha-bugs] [Bug 23694] Author "By" should have its own class In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23694 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 3 17:27:35 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jun 2020 15:27:35 +0000 Subject: [Koha-bugs] [Bug 23720] Add div wrapper to search results to make moving cover images easier In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23720 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to master |RESOLVED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 3 17:27:59 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jun 2020 15:27:59 +0000 Subject: [Koha-bugs] [Bug 23862] Add enumchron to holds-table on checkout page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23862 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to master |RESOLVED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 3 17:28:44 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jun 2020 15:28:44 +0000 Subject: [Koha-bugs] [Bug 23683] Course reserves public notes on specific items should allow for HTML In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23683 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldstable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 3 17:29:07 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jun 2020 15:29:07 +0000 Subject: [Koha-bugs] [Bug 24184] Reword FallbackToSMSIfNoEmail syspref text In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24184 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldstable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 3 17:29:26 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jun 2020 15:29:26 +0000 Subject: [Koha-bugs] [Bug 23506] Sound material type displays wrong icon in OPAC/Staff details In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23506 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldoldstable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 3 17:29:49 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jun 2020 15:29:49 +0000 Subject: [Koha-bugs] [Bug 24371] OPAC 'Showing only available items/Show all items' is double encoded In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24371 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to oldoldstable |RESOLVED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 3 17:30:35 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jun 2020 15:30:35 +0000 Subject: [Koha-bugs] [Bug 24523] Fix opac-password-recovery markup mistake In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24523 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldstable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 3 17:31:04 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jun 2020 15:31:04 +0000 Subject: [Koha-bugs] [Bug 24497] CodeMirror indentation problems In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24497 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldoldstable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 3 17:31:34 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jun 2020 15:31:34 +0000 Subject: [Koha-bugs] [Bug 22381] Wording on Calendar-related system preferences not standardized In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22381 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to oldstable |RESOLVED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 3 17:31:34 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jun 2020 15:31:34 +0000 Subject: [Koha-bugs] [Bug 24858] Incorrect labels on wording in ExcludeHolidaysFromMaxPickUpDelay system preference In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24858 Bug 24858 depends on bug 22381, which changed state. Bug 22381 Summary: Wording on Calendar-related system preferences not standardized https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22381 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldstable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 3 17:32:32 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jun 2020 15:32:32 +0000 Subject: [Koha-bugs] [Bug 24390] Add item total to rotating collections (addItems.tt) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24390 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to master |RESOLVED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 3 17:33:00 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jun 2020 15:33:00 +0000 Subject: [Koha-bugs] [Bug 24510] When placing a hold, cursor doesn't focus on patron name In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24510 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to master |RESOLVED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 3 17:33:22 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jun 2020 15:33:22 +0000 Subject: [Koha-bugs] [Bug 24456] previousIssuesDefaultSortOrder and todaysIssuesDefaultSortOrder sort incorrectly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24456 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldstable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 3 17:33:48 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jun 2020 15:33:48 +0000 Subject: [Koha-bugs] [Bug 24858] Incorrect labels on wording in ExcludeHolidaysFromMaxPickUpDelay system preference In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24858 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldstable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 3 17:34:48 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jun 2020 15:34:48 +0000 Subject: [Koha-bugs] [Bug 24764] TinyMCE shouldnt do automatic code cleanup when editing HTML in News Feature In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24764 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to oldstable |RESOLVED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 3 17:35:26 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jun 2020 15:35:26 +0000 Subject: [Koha-bugs] [Bug 21565] SCO checkout confirm should be modal In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21565 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldstable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 3 17:35:52 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jun 2020 15:35:52 +0000 Subject: [Koha-bugs] [Bug 25341] When adding a single item to course reserves, ignore whitespace In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25341 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to oldstable |RESOLVED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 3 17:50:31 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jun 2020 15:50:31 +0000 Subject: [Koha-bugs] [Bug 14848] Fund level user restriction is not working In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14848 Kelly McElligott changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kelly at bywatersolutions.com --- Comment #1 from Kelly McElligott --- This is still relevant in 19.05. Creating a fund restricting to the owner, users and library all seem to be not applying when using a fund logged in (as not the owner, user or library) In addition, the funds that are specific to a library (through the Fund setup) are still showing to Baskets created at other libraries. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jun 3 17:52:18 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jun 2020 15:52:18 +0000 Subject: [Koha-bugs] [Bug 25311] Better error handling when creating/updating a patron In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25311 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |victor at tuxayo.net --- Comment #20 from Victor Grousset/tuxayo --- It doesn't apply cleanly on 19.05.x and the conflict isn't simple to solve. If there is an interest in having this backported, feel free to submit a patch for 19.05. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 3 18:11:22 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jun 2020 16:11:22 +0000 Subject: [Koha-bugs] [Bug 23091] Restore Forgiven Overdue Fines When Lost Item Returned In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23091 --- Comment #6 from Martin Renvoize --- Created attachment 105529 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105529&action=edit Bug 23091: Database update This patch updates the 'refund' circulation rule to be called 'lostreturn' and populates the value with 'refund' where appropriate. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 3 18:11:25 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jun 2020 16:11:25 +0000 Subject: [Koha-bugs] [Bug 23091] Restore Forgiven Overdue Fines When Lost Item Returned In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23091 --- Comment #7 from Martin Renvoize --- Created attachment 105530 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105530&action=edit Bug 23091: Update unit test This patch updates the unit test for get_lostreturn_policy to reflect the rule_name and return code changes. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 3 18:11:29 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jun 2020 16:11:29 +0000 Subject: [Koha-bugs] [Bug 23091] Restore Forgiven Overdue Fines When Lost Item Returned In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23091 --- Comment #8 from Martin Renvoize --- Created attachment 105531 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105531&action=edit Bug 23091: Add handling for new lostreturn rules This patch adds circulation handling for two new lost item return rules. These new rules allow for the new options of refund lost item charge plus charge a freshly calculated overdue fine and refind of lost item charge plus charge a new fine matching the amount from the original overdue fine. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 3 18:11:55 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jun 2020 16:11:55 +0000 Subject: [Koha-bugs] [Bug 23091] Restore Forgiven Overdue Fines When Lost Item Returned In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23091 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #96217|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 3 18:19:29 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jun 2020 16:19:29 +0000 Subject: [Koha-bugs] [Bug 23091] Restore Forgiven Overdue Fines When Lost Item Returned In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23091 --- Comment #9 from Martin Renvoize --- Current state.. 'Refund, 'Refund and Charge' should both be working as expected at this point.. I am still working on 'Refund and Restore'. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 3 19:32:40 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jun 2020 17:32:40 +0000 Subject: [Koha-bugs] [Bug 25657] Import Patron fails without userid - not stated as required field in notes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25657 Elaine Bradtke changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |eb at efdss.org --- Comment #2 from Elaine Bradtke --- This happened in 19.11.05. I upload and overwrite the patron data on a quarterly basis (it's derived from a spreadsheet of membership data). The error message I got was: "Userid elaine.bradtke is already used by another patron" repeated for all 2000+ records. I went back to the spreadsheet, gave everyone arbitrary userids and it worked. Just to test this wasn't a fluke, I've gone back to the spreadsheet, removed the userid column and tried the upload again. It failed: mport results : 0 imported records 0 overwritten 0 not imported because already in borrowers table and overwrite disabled 2124 not imported because they are not in the expected format 2124 records parsed Back to Tools Feedback: headerrow : cardnumber, title, firstname, surname, address, address2, city, state, zipcode, country, dateexpiry, email, phone, branchcode, categorycode, Content-Disposition : form-data; name="uploadborrowers"; filename="EFDSS - Membership Export 2020-06-02.csv" Content-Type : application/octet-stream Parsing upload file EFDSS - Membership Export 2020-06-02.csv Error analysis: Userid elaine.bradtke is already used by another patron. (repeated 2000+ times) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jun 3 19:35:44 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jun 2020 17:35:44 +0000 Subject: [Koha-bugs] [Bug 25665] New: test t/db_dependent/Circulation.t fails on a specific date Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25665 Bug ID: 25665 Summary: test t/db_dependent/Circulation.t fails on a specific date Change sponsored?: --- Product: Koha Version: 19.05 Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Test Suite Assignee: chris at bigballofwax.co.nz Reporter: victor at tuxayo.net QA Contact: testopia at bugs.koha-community.org 2020-06-02 == Test plan == Warning: changing the system time to something too far in the past will disrupt HTTPS & TLS so you will have errors if you try to browse the web in parallel. And other software(like email clients) might pop errors. Nothing to worry about. 1. Set system date to 2020-06-01 (time: somewhere during that day) 2. prove t/db_dependent/Circulation.t 3. "All tests successful." 4. Set system date to 2020-06-02 (time: somewhere during that day) 5. prove t/db_dependent/Circulation.t 6. Fail 7. Set system date to 2020-06-03 (time: somewhere during that day) 8. "All tests successful." master : doesn't happen 19.11.x: doesn't happen 19.05.x: happens (v19.05.11) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 3 19:35:52 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jun 2020 17:35:52 +0000 Subject: [Koha-bugs] [Bug 25665] test t/db_dependent/Circulation.t fails on a specific date In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25665 --- Comment #1 from Victor Grousset/tuxayo --- I tried very quickly to find if the test suite mentioned mocking time (to have a clean way to test) but I haven't found such thing. (will continue searching) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 3 19:36:51 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jun 2020 17:36:51 +0000 Subject: [Koha-bugs] [Bug 25665] test t/db_dependent/Circulation.t fails on a specific date In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25665 --- Comment #2 from Victor Grousset/tuxayo --- Severity: minor but it will also depend of the underlying cause. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 3 19:37:20 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jun 2020 17:37:20 +0000 Subject: [Koha-bugs] [Bug 20168] Update of the OPAC bootstrap template to bootstrap v4 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20168 --- Comment #6 from Owen Leonard --- Work in progress: https://gitlab.com/koha-dev/koha-dev/-/tree/wip-2020-05-14-opac-bootstrap-4 If you test, you'll need to run 'yarn install' before running 'yarn build --view opac' -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 3 19:38:00 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jun 2020 17:38:00 +0000 Subject: [Koha-bugs] [Bug 25665] test t/db_dependent/Circulation.t fails on a specific date In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25665 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=24881 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 3 19:38:00 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jun 2020 17:38:00 +0000 Subject: [Koha-bugs] [Bug 24881] Circulation.t still fails if tests are ran slowly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24881 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=25665 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 3 19:39:40 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jun 2020 17:39:40 +0000 Subject: [Koha-bugs] [Bug 25665] test t/db_dependent/Circulation.t fails on a specific date In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25665 --- Comment #3 from Victor Grousset/tuxayo --- failure message: kohadev-koha at 04fc7d250165:/kohadevbox/koha$ prove t/db_dependent/Circulation.t t/db_dependent/Circulation.t .. 43/46 # Failed test 'Hourly rental charge calculated correctly with finesCalendar = noFinesWhenClosed and closed Wednesdays (168h - 24h * 0.25u)' # at t/db_dependent/Circulation.t line 3245. # got: '30' # expected: '36' # Looks like you failed 1 test of 20. t/db_dependent/Circulation.t .. 44/46 # Failed test 'Incremented fee tests' # at t/db_dependent/Circulation.t line 3270. t/db_dependent/Circulation.t .. 45/46 # Looks like you failed 1 test of 46. t/db_dependent/Circulation.t .. Dubious, test returned 1 (wstat 256, 0x100) Failed 1/46 subtests Test Summary Report ------------------- t/db_dependent/Circulation.t (Wstat: 256 Tests: 46 Failed: 1) Failed test: 44 Non-zero exit status: 1 Files=1, Tests=46, 30 wallclock secs ( 0.10 usr 0.02 sys + 22.21 cusr 4.17 csys = 26.50 CPU) Result: FAIL kohadev-koha at 04fc7d250165:/kohadevbox/koha$ -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 3 19:44:15 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jun 2020 17:44:15 +0000 Subject: [Koha-bugs] [Bug 25665] test t/db_dependent/Circulation.t fails on a specific date In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25665 --- Comment #4 from Victor Grousset/tuxayo --- Patch of bug 24881 comment 1 is still in 19.05.x and isn't not the cause of this bug. A revert doesn't make the test output change. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 3 19:44:22 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jun 2020 17:44:22 +0000 Subject: [Koha-bugs] [Bug 25665] test t/db_dependent/Circulation.t fails on a specific date In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25665 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 3 19:44:41 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jun 2020 17:44:41 +0000 Subject: [Koha-bugs] [Bug 24881] Circulation.t still fails if tests are ran slowly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24881 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |victor at tuxayo.net --- Comment #18 from Victor Grousset/tuxayo --- Info: patch of comment 1 is still in 19.05.x and isn't not the cause of bug 25665 (test t/db_dependent/Circulation.t fails on a specific date) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 3 19:52:15 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jun 2020 17:52:15 +0000 Subject: [Koha-bugs] [Bug 25665] test t/db_dependent/Circulation.t fails on a specific date In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25665 --- Comment #5 from Victor Grousset/tuxayo --- TODO use Time::Fake to reproduce instead of changing date. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 3 19:55:07 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jun 2020 17:55:07 +0000 Subject: [Koha-bugs] [Bug 25665] test t/db_dependent/Circulation.t fails on a specific date In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25665 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 3 20:18:03 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jun 2020 18:18:03 +0000 Subject: [Koha-bugs] [Bug 25666] New: yasmin Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25666 Bug ID: 25666 Summary: yasmin Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Acquisitions Assignee: koha-bugs at lists.koha-community.org Reporter: yp897109 at gmail.com QA Contact: testopia at bugs.koha-community.org Created attachment 105532 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105532&action=edit Hahaha -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 3 20:19:08 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jun 2020 18:19:08 +0000 Subject: [Koha-bugs] [Bug 25667] New: Add field for items.notforloan_on to record when a notforloan status is applied Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25667 Bug ID: 25667 Summary: Add field for items.notforloan_on to record when a notforloan status is applied Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Database Assignee: koha-bugs at lists.koha-community.org Reporter: andrew at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org We record lost_on and damaged_on. Can we record notforloan_on, too? It'd be helpful for various reports. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 3 20:24:45 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jun 2020 18:24:45 +0000 Subject: [Koha-bugs] [Bug 25657] Import Patron fails without userid - not stated as required field in notes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25657 --- Comment #3 from Elaine Bradtke --- (In reply to Jonathan Druart from comment #1) > Hi Elaine, > > I have tried on 19.11.06, I am not sure I understand what the problem is. > If I use the import patron tool to create new patrons and the csv file does > not contain a userid (either no value in the cell, or no header at all), > then the userid is automatically built concatenating firstname and surname. > > Can you detail a bit more? Are you saying it would work if there was a column userid, but no data in it? We've never had a userid field empty or not, in previous imports and it worked. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 3 20:34:10 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jun 2020 18:34:10 +0000 Subject: [Koha-bugs] [Bug 25666] SPAM In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25666 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|yasmin |SPAM -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 3 20:34:22 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jun 2020 18:34:22 +0000 Subject: [Koha-bugs] [Bug 25666] SPAM In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25666 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #105532|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jun 3 20:34:35 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jun 2020 18:34:35 +0000 Subject: [Koha-bugs] [Bug 25666] SPAM In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25666 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |INVALID Status|NEW |RESOLVED -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jun 3 20:36:48 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jun 2020 18:36:48 +0000 Subject: [Koha-bugs] [Bug 25349] Enter in the username field submits the login, instead of moving focus to the password field In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25349 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 3 20:36:51 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jun 2020 18:36:51 +0000 Subject: [Koha-bugs] [Bug 25349] Enter in the username field submits the login, instead of moving focus to the password field In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25349 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #105446|0 |1 is obsolete| | --- Comment #10 from Lucas Gass --- Created attachment 105533 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105533&action=edit Bug 25349: Add checkEnter function and apply it to SCO page This patch adds the checkEnter function to the OPAC global.js and then applies it to the SCO login page. TO TEST: 1. Go to SCO login and try entering something in the "Login:" input amd "Password:" input. 2. Pressing enter while in either will automatically submit the form. 3. Apply patch. 4. Type something into the Login: field and press enter, the form should NOT submit. 5. Type something into the Password: field and pess enter, this SHOULD submit the form. 6. Change the syspref SelfCheckoutByLogin to 'Cardnumber' 7. TType something into the Please enter your card number: field, the form should NOT submit. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 3 20:38:37 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jun 2020 18:38:37 +0000 Subject: [Koha-bugs] [Bug 25349] Enter in the username field submits the login, instead of moving focus to the password field In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25349 --- Comment #11 from Lucas Gass --- I changed how this patch functions so I am reseting to Needs Sign-off, I also removed Victor's sign-off line. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 3 20:59:26 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jun 2020 18:59:26 +0000 Subject: [Koha-bugs] [Bug 25668] New: ElasticSearch 6 deprecation: the default number of shards will change in version 7 Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25668 Bug ID: 25668 Summary: ElasticSearch 6 deprecation: the default number of shards will change in version 7 Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Searching - Elasticsearch Assignee: koha-bugs at lists.koha-community.org Reporter: victor at tuxayo.net This happens in koha-testing-docker with ES 6.8.8 When indexing: ./misc/search_tools/rebuild_elasticsearch.pl -v -d Here are both deprecation messages that are outputted and related: [DEPRECATION] the default number of shards will change from [5] to [1] in 7.0.0; if you wish to continue using the default of [5] shards, you must manage this on the create index request or with an index template - In request: {body => {settings => {index => {analysis => {analyzer => {analyzer_phrase => {char_filter => ["punctuation"],filter => ["icu_folding"],tokenizer => "keyword"},analyzer_standard => {filter => ["icu_folding"],tokenizer => "icu_tokenizer"},analyzer_stdno => {char_filter => ["punctuation"],filter => ["icu_folding"],tokenizer => "whitespace"}},char_filter => {punctuation => {pattern => "([\\x00-\\x1F,\\x21-\\x2F,\\x3A-\\x40,\\x5B-\\x60,\\x7B-\\x89,\\x8B,\\x8D,\\x8F,\\x90-\\x99,\\x9B,\\x9D,\\xA0-\\xBF,\\xD7,\\xF7])",replacement => "",type => "pattern_replace"}},normalizer => {icu_folding_normalizer => {filter => ["icu_folding"],type => "custom"},nfkc_cf_normalizer => {char_filter => "icu_normalizer",type => "custom"}}}},"index.mapping.total_fields.limit" => 10000}},ignore => [],method => "PUT",mime_type => "application/json",path => "/koha_kohadev_biblios",qs => {},serialize => "std"} [DEPRECATION] the default number of shards will change from [5] to [1] in 7.0.0; if you wish to continue using the default of [5] shards, you must manage this on the create index request or with an index template - In request: {body => {settings => {index => {analysis => {analyzer => {analyzer_phrase => {char_filter => ["punctuation"],filter => ["icu_folding"],tokenizer => "keyword"},analyzer_standard => {filter => ["icu_folding"],tokenizer => "icu_tokenizer"},analyzer_stdno => {char_filter => ["punctuation"],filter => ["icu_folding"],tokenizer => "whitespace"}},char_filter => {punctuation => {pattern => "([\\x00-\\x1F,\\x21-\\x2F,\\x3A-\\x40,\\x5B-\\x60,\\x7B-\\x89,\\x8B,\\x8D,\\x8F,\\x90-\\x99,\\x9B,\\x9D,\\xA0-\\xBF,\\xD7,\\xF7])",replacement => "",type => "pattern_replace"}},normalizer => {icu_folding_normalizer => {filter => ["icu_folding"],type => "custom"},nfkc_cf_normalizer => {char_filter => "icu_normalizer",type => "custom"}}}},"index.mapping.total_fields.limit" => 10000}},ignore => [],method => "PUT",mime_type => "application/json",path => "/koha_kohadev_authorities",qs => {},serialize => "std"} -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 3 21:03:11 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jun 2020 19:03:11 +0000 Subject: [Koha-bugs] [Bug 25669] New: ElasticSearch 6 deprecation: [types removal] Specifying types in put mapping requests is deprecated (incompatible with 7) Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25669 Bug ID: 25669 Summary: ElasticSearch 6 deprecation: [types removal] Specifying types in put mapping requests is deprecated (incompatible with 7) Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Searching - Elasticsearch Assignee: koha-bugs at lists.koha-community.org Reporter: victor at tuxayo.net This happens in koha-testing-docker with ES 6.8.8 When indexing: ./misc/search_tools/rebuild_elasticsearch.pl -v -d Here are both deprecation messages that are outputted and related: [DEPRECATION] [types removal] Specifying types in put mapping requests is deprecated. To be compatible with 7.0, the mapping definition should not be nested under the type name, and the parameter include_type_name must be provided and set to false. - In request: {body => {data => {properties => {abstract => {analyzer => "analyzer_standard",fields => {ci_raw => {normalizer => "icu_folding_normalizer",type => "keyword"},phrase => {analyzer => "analyzer_phrase",search_analyzer => "analyzer_phrase",type => "text"},raw => {normalizer => "nfkc_cf_normalizer",type => "keyword"}},search_analyzer => "analyzer_standard",type => "text"},abstract__sort => {index => "false",numeric => "true",type => "icu_collation_keyword"},acqsource => $VAR1->{body}{data}{properties}{abstract},acqsource__sort => $VAR1->{body}{data}{properties}{abstract__sort},arl => $VAR1->{body}{data}{properties}{abstract},arl__sort => $VAR1->{body}{data}{properties}{abstract__sort},arp => $VAR1->{body}{data}{properties}{abstract},arp__sort => $VAR1->{body}{data}{properties}{abstract_ _sort},author => $VAR1->{body}{data}{properties}{abstract},"author-in-order" => $VAR1->{body}{data}{properties}{abstract},"author-in-order__sort" => $VAR1->{body}{data}{properties}{abstract__sort},"author-name-corporate" => $VAR1->{body}{data}{properties}{abstract},"author-name-corporate__sort" => $VAR1->{body}{data}{properties}{abstract__sort},"author-name-personal" => $VAR1->{body}{data}{properties}{abstract},"author-name-personal__sort" => $VAR1->{body}{data}{properties}{abstract__sort},"author-personal-bibliography" => $VAR1->{body}{data}{properties}{abstract},"author-personal-bibliography__sort" => $VAR1->{body}{data}{properties}{abstract__sort},"author-title" => $VAR1->{body}{data}{properties}{abstract},"author-title__sort" => $VAR1->{body}{data}{properties}{abstract__sort},author__facet => {type => "keyword"},author__sort => $VAR1->{body}{data}{properties}{abstract__sort},author__suggestion => {analyzer => "simple",max_input_length => 100,search_analyzer => "simple",type => "completion"},barcode => $VAR1->{body}{data}{properties}{abstract},barcode__sort => $VAR1->{body}{data}{properties}{abstract__sort},"bgf-number" => $VAR1->{body}{data}{properties}{abstract},"bgf-number__sort" => $VAR1->{body}{data}{properties}{abstract__sort},"bib-level" => $VAR1->{body}{data}{properties}{abstract},"bib-level__sort" => $VAR1->{body}{data}{properties}{abstract__sort},biblioitemnumber => $VAR1->{body}{data}{properties}{abstract},biblioitemnumber__sort => $VAR1->{body}{data}{properties}{abstract__sort},bio => $VAR1->{body}{data}{properties}{abstract},bio__sort => $VAR 1->{body}{data}{properties}{abstract__sort},"bnb-card-number" => $VAR1->{body}{data}{properties}{abstract},"bnb-card-number__sort" => $VAR1->{body}{data}{properties}{abstract__sort},ccode => $VAR1->{body}{data}{properties}{abstract},ccode__facet => $VAR1->{body}{data}{properties}{author__facet},ccode__sort => $VAR1->{body}{data}{properties}{abstract__sort},"classification-source" => $VAR1->{body}{data}{properties}{abstract},"classification-source__sort" => $VAR1->{body}{data}{properties}{abstract__sort},"cn-bib-sort" => $V AR1->{body}{data}{properties}{abstract},"cn-bib-sort__sort" => $VAR1->{body}{data}{properties}{abstract__sort},"cn-bib-source" => $VAR1->{body}{data}{properties}{abstract},"cn-bib-source__sort" => $VAR1->{body}{data}{properties}{abstract__sort},"cn-class" => $VAR1->{body}{data}{properties}{abstract},"cn-class__sort" => $VAR1->{body}{data}{properties}{abstract__sort},"cn-item" => $VAR1->{body}{data}{properties}{abstract},"cn-item__sort" => $VAR1->{body}{data}{properties}{abstract__sort},"cn-prefix" => $VAR1->{body}{data}{properties}{abstract},"cn-prefix__sort" => $VAR1->{body}{data}{properties}{abstract__sort},"cn-sort" => $VAR1->{body}{data}{properties}{abstract},"cn-sort__sort" => $VAR1->{body}{data}{properties}{abstract__sort},"cn-suffix" => $VAR1->{body}{data}{properties}{abstract},"cn-suffix__sort" => $VAR1->{body}{data}{properties}{abstract__sort},"code-geographic" => $VAR1->{body}{data}{properties}{abstract},"code-geographic__sort" => $VAR1->{body}{data}{properties}{abstract__sort},"code-institution" => $VAR1->{body}{data}{properties}{abstract},"code-institution__sort" => $VAR1->{body}{data}{properties}{abstract__sort},"coded-location-qualifier" => $VAR1->{body}{data}{properties}{abstract},"coded-location-qualifier__sort" => $VAR1->{body}{data}{properties}{abstract__sort},coden => $VAR1->{body}{data}{properties}{abstract},coden__sort => $VAR1->{body}{data}{properties}{abstract__sort},"conference-name" => $VAR1->{body}{data}{properties}{abstract},"conference-name__sort" => $VAR1->{body}{data}{properties}{abstract__sort},"control-number" => $VAR1->{body} {data}{properties}{abstract},"control-number__sort" => $VAR1->{body}{data}{properties}{abstract__sort},copydate => $VAR1->{body}{data}{properties}{abstract},copydate__facet => $VAR1->{body}{data}{properties}{author__facet},copydate__sort => $VAR1->{body}{data}{properties}{abstract__sort},copynumber => $VAR1->{body}{data}{properties}{abstract},copynumber__sort => $VAR1->{body}{data}{properties}{abstract__sort},"corporate-name" => $VAR1->{body}{data}{properties}{abstract},"corporate-name__sort" => $VAR1->{body}{data}{properties}{abstract__sort},"cross-reference" => $VAR1->{body}{data}{properties}{abstract},"cross-reference__sort" => $VAR1->{body}{data}{properties}{abstract__sort},ctype => $VAR1->{body}{data}{properties}{abstract},ctype__sort => $VAR1->{body}{data}{properties}{abstract__sort},curriculum => $VAR1->{body}{data}{properties}{abstract},curriculum__sort => $VAR1->{body}{data}{properties}{abstract__sort},damaged => $VAR1->{body}{data}{properties}{abstract},damaged__sort => $VAR1->{body}{data}{properties}{abstract__sort},"date-entered -on-file" => $VAR1->{body}{data}{properties}{abstract},"date-entered-on-file__sort" => $VAR1->{body}{data}{properties}{abstract__sort},"date-of-acquisition" => $VAR1->{body}{data}{properties}{abstract},"date-of-acquisition__sort" => $VAR1->{body}{data}{properties}{abstract__sort},"date-of-publication" => $VAR1->{body}{data}{properties}{abstract},"date-of-publication__sort" => $VAR1->{body}{data}{properties}{abstract__sort},"date-time-last-modified" => $VAR1->{body}{data}{properties}{abstract},"date-time-last-modified__sort " => $VAR1->{body}{data}{properties}{abstract__sort},datelastborrowed => $VAR1->{body}{data}{properties}{abstract},datelastborrowed__sort => $VAR1->{body}{data}{properties}{abstract__sort},datelastseen => $VAR1->{body}{data}{properties}{abstract},datelastseen__sort => $VAR1->{body}{data}{properties}{abstract__sort},"dewey-classification" => $VAR1->{body}{data}{properties}{abstract},"dewey-classification__sort" => $VAR1->{body}{data}{properties}{abstract__sort},"dissertation-information" => $VAR1->{body}{data}{properties}{a bstract},"dissertation-information__sort" => $VAR1->{body}{data}{properties}{abstract__sort},editor => $VAR1->{body}{data}{properties}{abstract},editor__sort => $VAR1->{body}{data}{properties}{abstract__sort},extent => $VAR1->{body}{data}{properties}{abstract},extent__sort => $VAR1->{body}{data}{properties}{abstract__sort},"ff7-00" => $VAR1->{body}{data}{properties}{abstract},"ff7-00__sort" => $VAR1->{body}{data}{properties}{abstract__sort},"ff7-01" => $VAR1->{body}{data}{properties}{abstract},"ff7-01-02" => $VAR1->{body}{ data}{properties}{abstract},"ff7-01-02__sort" => $VAR1->{body}{data}{properties}{abstract__sort},"ff7-01__sort" => $VAR1->{body}{data}{properties}{abstract__sort},"ff7-02" => $VAR1->{body}{data}{properties}{abstract},"ff7-02__sort" => $VAR1->{body}{data}{properties}{abstract__sort},"ff8-23" => $VAR1->{body}{data}{properties}{abstract},"ff8-23__sort" => $VAR1->{body}{data}{properties}{abstract__sort},"ff8-29" => $VAR1->{body}{data}{properties}{abstract},"ff8-29__sort" => $VAR1->{body}{data}{properties}{abstract__sort},"geog raphic-class" => $VAR1->{body}{data}{properties}{abstract},"geographic-class__sort" => $VAR1->{body}{data}{properties}{abstract__sort},holdingbranch => $VAR1->{body}{data}{properties}{abstract},holdingbranch__facet => $VAR1->{body}{data}{properties}{author__facet},homebranch => $VAR1->{body}{data}{properties}{abstract},homebranch__facet => $VAR1->{body}{data}{properties}{author__facet},"host-item" => $VAR1->{body}{data}{properties}{abstract},"host-item-number" => {null_value => 0,type => "integer"},"host-item-number__sort" => $VAR1->{body}{data}{properties}{abstract__sort},"host-item__sort" => $VAR1->{body}{data}{properties}{abstract__sort},"identifier-other" => $VAR1->{body}{data}{properties}{abstract},"identifier-other__sort" => $VAR1->{body}{data}{properties}{abstract__sort},"identifier-publisher-for-music" => $VAR1->{body}{data}{properties}{abstract},"identifier-publisher-for-music__sort" => $VAR1->{body}{data}{properties}{abstract__sort},"identifier-standard" => {analyzer => "analyzer_stdno",fields => {phrase => {analyzer => "analyzer_ phrase",search_analyzer => "analyzer_phrase",type => "text"},raw => {type => "keyword"}},search_analyzer => "analyzer_stdno",type => "text"},"identifier-standard__sort" => $VAR1->{body}{data}{properties}{abstract__sort},"index-term-genre" => $VAR1->{body}{data}{properties}{abstract},"index-term-genre__sort" => $VAR1->{body}{data}{properties}{abstract__sort},"index-term-uncontrolled" => $VAR1->{body}{data}{properties}{abstract},"index-term-uncontrolled__sort" => $VAR1->{body}{data}{properties}{abstract__sort},"indexed-by" = > $VAR1->{body}{data}{properties}{abstract},"indexed-by__sort" => $VAR1->{body}{data}{properties}{abstract__sort},"interest-age-level" => $VAR1->{body}{data}{properties}{abstract},"interest-age-level__sort" => $VAR1->{body}{data}{properties}{abstract__sort},"interest-grade-level" => $VAR1->{body}{data}{properties}{abstract},"interest-grade-level__sort" => $VAR1->{body}{data}{properties}{abstract__sort},isbn => $VAR1->{body}{data}{properties}{"identifier-standard"},isbn__sort => $VAR1->{body}{data}{properties}{abstract__sor t},issn => $VAR1->{body}{data}{properties}{"identifier-standard"},issn__sort => $VAR1->{body}{data}{properties}{abstract__sort},issues => $VAR1->{body}{data}{properties}{"host-item-number"},issues__sort => $VAR1->{body}{data}{properties}{abstract__sort},itemnumber => $VAR1->{body}{data}{properties}{"host-item-number"},itemtype => $VAR1->{body}{data}{properties}{abstract},itemtype__sort => $VAR1->{body}{data}{properties}{abstract__sort},itype => $VAR1->{body}{data}{properties}{abstract},itype__facet => $VAR1->{body}{data}{p roperties}{author__facet},itype__sort => $VAR1->{body}{data}{properties}{abstract__sort},"koha-auth-number" => $VAR1->{body}{data}{properties}{abstract},"koha-auth-number__sort" => $VAR1->{body}{data}{properties}{abstract__sort},"language-original" => $VAR1->{body}{data}{properties}{abstract},"language-original__sort" => $VAR1->{body}{data}{properties}{abstract__sort},"lc-call-number" => $VAR1->{body}{data}{properties}{abstract},"lc-call-number__sort" => $VAR1->{body}{data}{properties}{abstract__sort},"lc-card-number" => $ VAR1->{body}{data}{properties}{abstract},"lc-card-number__sort" => $VAR1->{body}{data}{properties}{abstract__sort},"lexile-number" => $VAR1->{body}{data}{properties}{abstract},"lexile-number__sort" => $VAR1->{body}{data}{properties}{abstract__sort},lf => $VAR1->{body}{data}{properties}{abstract},lf__sort => $VAR1->{body}{data}{properties}{abstract__sort},llength => $VAR1->{body}{data}{properties}{abstract},llength__sort => $VAR1->{body}{data}{properties}{abstract__sort},ln => $VAR1->{body}{data}{properties}{abstract},"ln-a udio" => $VAR1->{body}{data}{properties}{abstract},"ln-audio__sort" => $VAR1->{body}{data}{properties}{abstract__sort},"ln-subtitle" => $VAR1->{body}{data}{properties}{abstract},"ln-subtitle__sort" => $VAR1->{body}{data}{properties}{abstract__sort},ln__facet => $VAR1->{body}{data}{properties}{author__facet},ln__sort => $VAR1->{body}{data}{properties}{abstract__sort},"local-classification" => $VAR1->{body}{data}{properties}{abstract},"local-classification__suggestion" => $VAR1->{body}{data}{properties}{author__suggestion}," local-number" => $VAR1->{body}{data}{properties}{abstract},location => $VAR1->{body}{data}{properties}{abstract},location__facet => $VAR1->{body}{data}{properties}{author__facet},lost => $VAR1->{body}{data}{properties}{abstract},lost__sort => $VAR1->{body}{data}{properties}{abstract__sort},"map-scale" => $VAR1->{body}{data}{properties}{abstract},"map-scale__sort" => $VAR1->{body}{data}{properties}{abstract__sort},marc_data => {analyzer => "keyword",index => "false",store => "true",type => "text"},marc_data_array => {dynami c => "true",type => "object"},marc_format => {analyzer => "keyword",index => "false",store => "true",type => "text"},"material-type" => $VAR1->{body}{data}{properties}{abstract},"material-type__sort" => $VAR1->{body}{data}{properties}{abstract__sort},"materials-specified" => $VAR1->{body}{data}{properties}{abstract},"materials-specified__sort" => $VAR1->{body}{data}{properties}{abstract__sort},"microform-generation" => $VAR1->{body}{data}{properties}{abstract},"microform-generation__sort" => $VAR1->{body}{data}{properties} {abstract__sort},"music-key" => $VAR1->{body}{data}{properties}{abstract},"music-key__sort" => $VAR1->{body}{data}{properties}{abstract__sort},"nal-call-number" => $VAR1->{body}{data}{properties}{abstract},"nal-call-number__sort" => $VAR1->{body}{data}{properties}{abstract__sort},name => $VAR1->{body}{data}{properties}{abstract},"name-and-title" => $VAR1->{body}{data}{properties}{abstract},"name-and-title__sort" => $VAR1->{body}{data}{properties}{abstract__sort},"name-geographic" => $VAR1->{body}{data}{properties}{abstract },"name-geographic__sort" => $VAR1->{body}{data}{properties}{abstract__sort},name__sort => $VAR1->{body}{data}{properties}{abstract__sort},"nlm-call-number" => $VAR1->{body}{data}{properties}{abstract},"not-onloan-count" => $VAR1->{body}{data}{properties}{abstract},"not-onloan-count__sort" => $VAR1->{body}{data}{properties}{abstract__sort},note => $VAR1->{body}{data}{properties}{abstract},note__sort => $VAR1->{body}{data}{properties}{abstract__sort},notforloan => $VAR1->{body}{data}{properties}{"host-item-number"},"number- db" => $VAR1->{body}{data}{properties}{abstract},"number-db__sort" => $VAR1->{body}{data}{properties}{abstract__sort},"number-govt-pub" => $VAR1->{body}{data}{properties}{abstract},"number-govt-pub__sort" => $VAR1->{body}{data}{properties}{abstract__sort},"number-legal-deposit" => $VAR1->{body}{data}{properties}{abstract},"number-legal-deposit__sort" => $VAR1->{body}{data}{properties}{abstract__sort},"number-local-acquisition" => $VAR1->{body}{data}{properties}{abstract},"number-local-acquisition__sort" => $VAR1->{body}{da ta}{properties}{abstract__sort},"number-natl-biblio" => $VAR1->{body}{data}{properties}{abstract},"number-natl-biblio__sort" => $VAR1->{body}{data}{properties}{abstract__sort},onloan => {null_value => "false",type => "boolean"},"other-control-number" => $VAR1->{body}{data}{properties}{abstract},"other-control-number__sort" => $VAR1->{body}{data}{properties}{abstract__sort},"personal-name" => $VAR1->{body}{data}{properties}{abstract},"personal-name__sort" => $VAR1->{body}{data}{properties}{abstract__sort},pl => $VAR1->{body }{data}{properties}{abstract},pl__sort => $VAR1->{body}{data}{properties}{abstract__sort},price => $VAR1->{body}{data}{properties}{abstract},price__sort => $VAR1->{body}{data}{properties}{abstract__sort},provider => $VAR1->{body}{data}{properties}{abstract},provider__sort => $VAR1->{body}{data}{properties}{abstract__sort},publisher => $VAR1->{body}{data}{properties}{abstract},publisher__facet => $VAR1->{body}{data}{properties}{author__facet},publisher__sort => $VAR1->{body}{data}{properties}{abstract__sort},"reading-grade- level" => $VAR1->{body}{data}{properties}{abstract},"reading-grade-level__sort" => $VAR1->{body}{data}{properties}{abstract__sort},"record-control-number" => $VAR1->{body}{data}{properties}{abstract},"record-control-number__sort" => $VAR1->{body}{data}{properties}{abstract__sort},"record-source" => $VAR1->{body}{data}{properties}{abstract},"record-source__sort" => $VAR1->{body}{data}{properties}{abstract__sort},"related-periodical" => $VAR1->{body}{data}{properties}{abstract},"related-periodical__sort" => $VAR1->{body}{dat a}{properties}{abstract__sort},renewals => $VAR1->{body}{data}{properties}{abstract},renewals__sort => $VAR1->{body}{data}{properties}{abstract__sort},replacementprice => $VAR1->{body}{data}{properties}{abstract},replacementprice__sort => $VAR1->{body}{data}{properties}{abstract__sort},replacementpricedate => $VAR1->{body}{data}{properties}{abstract},replacementpricedate__sort => $VAR1->{body}{data}{properties}{abstract__sort},"report-number" => $VAR1->{body}{data}{properties}{abstract},"report-number__sort" => $VAR1->{bod y}{data}{properties}{abstract__sort},reserves => $VAR1->{body}{data}{properties}{abstract},reserves__sort => $VAR1->{body}{data}{properties}{abstract__sort},restricted => $VAR1->{body}{data}{properties}{abstract},restricted__sort => $VAR1->{body}{data}{properties}{abstract__sort},rtype => $VAR1->{body}{data}{properties}{abstract},rtype__sort => $VAR1->{body}{data}{properties}{abstract__sort},stack => $VAR1->{body}{data}{properties}{abstract},stack__sort => $VAR1->{body}{data}{properties}{abstract__sort},"stock-number" => $ VAR1->{body}{data}{properties}{abstract},"stock-number__sort" => $VAR1->{body}{data}{properties}{abstract__sort},"su-geo" => $VAR1->{body}{data}{properties}{abstract},"su-geo__facet" => $VAR1->{body}{data}{properties}{author__facet},"su-geo__sort" => $VAR1->{body}{data}{properties}{abstract__sort},subject => $VAR1->{body}{data}{properties}{abstract},"subject-name-personal" => $VAR1->{body}{data}{properties}{abstract},"subject-name-personal__sort" => $VAR1->{body}{data}{properties}{abstract__sort},subject__facet => $VAR1->{ body}{data}{properties}{author__facet},subject__sort => $VAR1->{body}{data}{properties}{abstract__sort},subject__suggestion => $VAR1->{body}{data}{properties}{author__suggestion},suppress => $VAR1->{body}{data}{properties}{onloan},suppress__sort => $VAR1->{body}{data}{properties}{abstract__sort},ta => $VAR1->{body}{data}{properties}{abstract},ta__sort => $VAR1->{body}{data}{properties}{abstract__sort},"thematic-number" => $VAR1->{body}{data}{properties}{abstract},"thematic-number__sort" => $VAR1->{body}{data}{properties}{a bstract__sort},title => $VAR1->{body}{data}{properties}{abstract},"title-abbreviated" => $VAR1->{body}{data}{properties}{abstract},"title-abbreviated__sort" => $VAR1->{body}{data}{properties}{abstract__sort},"title-collective" => $VAR1->{body}{data}{properties}{abstract},"title-collective__sort" => $VAR1->{body}{data}{properties}{abstract__sort},"title-cover" => $VAR1->{body}{data}{properties}{abstract},"title-cover__sort" => $VAR1->{body}{data}{properties}{abstract__sort},"title-expanded" => $VAR1->{body}{data}{properties }{abstract},"title-expanded__sort" => $VAR1->{body}{data}{properties}{abstract__sort},"title-former" => $VAR1->{body}{data}{properties}{abstract},"title-former__sort" => $VAR1->{body}{data}{properties}{abstract__sort},"title-key" => $VAR1->{body}{data}{properties}{abstract},"title-key__sort" => $VAR1->{body}{data}{properties}{abstract__sort},"title-later" => $VAR1->{body}{data}{properties}{abstract},"title-later__sort" => $VAR1->{body}{data}{properties}{abstract__sort},"title-other-variant" => $VAR1->{body}{data}{propertie s}{abstract},"title-other-variant__sort" => $VAR1->{body}{data}{properties}{abstract__sort},"title-series" => $VAR1->{body}{data}{properties}{abstract},"title-series__facet" => $VAR1->{body}{data}{properties}{author__facet},"title-series__sort" => $VAR1->{body}{data}{properties}{abstract__sort},"title-uniform" => $VAR1->{body}{data}{properties}{abstract},"title-uniform__sort" => $VAR1->{body}{data}{properties}{abstract__sort},title__sort => $VAR1->{body}{data}{properties}{abstract__sort},title__suggestion => $VAR1->{body}{ data}{properties}{author__suggestion},totalissues => $VAR1->{body}{data}{properties}{abstract},totalissues__sort => $VAR1->{body}{data}{properties}{abstract__sort},"udc-classification" => $VAR1->{body}{data}{properties}{abstract},"udc-classification__sort" => $VAR1->{body}{data}{properties}{abstract__sort},uri => $VAR1->{body}{data}{properties}{abstract},uri__sort => $VAR1->{body}{data}{properties}{abstract__sort},withdrawn => $VAR1->{body}{data}{properties}{abstract},withdrawn__sort => $VAR1->{body}{data}{properties}{abst ract__sort}}}},ignore => [],method => "PUT",mime_type => "application/json",path => "/koha_kohadev_biblios/_mapping/data",qs => {},serialize => "std"} [DEPRECATION] [types removal] Specifying types in put mapping requests is deprecated. To be compatible with 7.0, the mapping definition should not be nested under the type name, and the parameter include_type_name must be provided and set to false. - In request: {body => {data => {properties => {authtype => {analyzer => "analyzer_standard",fields => {ci_raw => {normalizer => "icu_folding_normalizer",type => "keyword"},phrase => {analyzer => "analyzer_phrase",search_analyzer => "analyzer_phrase",type => "text"},raw => {normalizer => "nfkc_cf_normalizer",type => "keyword"}},search_analyzer => "analyzer_standard",type => "text"},authtype__sort => {index => "false",numeric => "true",type => "icu_collation_keyword"},"corporate-name-see-also-from" => $VAR1->{body}{data}{properties}{authtype},"corporate-name-see-also-from__sort" => $VAR1->{body}{data}{properties}{authtype__sort},"corporate-name-see-from" => $VAR1->{body}{data}{properties}{authtype},"corporate-name-see-from__sort" => $VAR1->{body}{data}{properties}{authtype__sort},"descriptive-cata loging-rules" => $VAR1->{body}{data}{properties}{authtype},"descriptive-cataloging-rules__sort" => $VAR1->{body}{data}{properties}{authtype__sort},heading => $VAR1->{body}{data}{properties}{authtype},"heading-main" => $VAR1->{body}{data}{properties}{authtype},"heading-main__sort" => $VAR1->{body}{data}{properties}{authtype__sort},"heading-use-main-or-added-entry" => $VAR1->{body}{data}{properties}{authtype},"heading-use-main-or-added-entry__sort" => $VAR1->{body}{data}{properties}{authtype__sort},"heading-use-series-added- entry" => $VAR1->{body}{data}{properties}{authtype},"heading-use-series-added-entry__sort" => $VAR1->{body}{data}{properties}{authtype__sort},"heading-use-subject-added-entry" => $VAR1->{body}{data}{properties}{authtype},"heading-use-subject-added-entry__sort" => $VAR1->{body}{data}{properties}{authtype__sort},heading__sort => $VAR1->{body}{data}{properties}{authtype__sort},"kind-of-record" => $VAR1->{body}{data}{properties}{authtype},"kind-of-record__sort" => $VAR1->{body}{data}{properties}{authtype__sort},"lc-card-number " => $VAR1->{body}{data}{properties}{authtype},"lc-card-number__sort" => $VAR1->{body}{data}{properties}{authtype__sort},"local-number" => $VAR1->{body}{data}{properties}{authtype},"local-number__sort" => $VAR1->{body}{data}{properties}{authtype__sort},marc_data => {analyzer => "keyword",index => "false",store => "true",type => "text"},marc_data_array => {dynamic => "true",type => "object"},marc_format => {analyzer => "keyword",index => "false",store => "true",type => "text"},match => $VAR1->{body}{data}{properties}{authty pe},"match-heading" => $VAR1->{body}{data}{properties}{authtype},"match-heading-see-from" => $VAR1->{body}{data}{properties}{authtype},"match-heading-see-from__sort" => $VAR1->{body}{data}{properties}{authtype__sort},"match-heading__sort" => $VAR1->{body}{data}{properties}{authtype__sort},match__sort => $VAR1->{body}{data}{properties}{authtype__sort},"meeting-name" => $VAR1->{body}{data}{properties}{authtype},"meeting-name-heading" => $VAR1->{body}{data}{properties}{authtype},"meeting-name-heading__sort" => $VAR1->{body}{d ata}{properties}{authtype__sort},"meeting-name-see-also-from" => $VAR1->{body}{data}{properties}{authtype},"meeting-name-see-also-from__sort" => $VAR1->{body}{data}{properties}{authtype__sort},"meeting-name-see-from" => $VAR1->{body}{data}{properties}{authtype},"meeting-name-see-from__sort" => $VAR1->{body}{data}{properties}{authtype__sort},"meeting-name__sort" => $VAR1->{body}{data}{properties}{authtype__sort},"personal-name" => $VAR1->{body}{data}{properties}{authtype},"personal-name-heading" => $VAR1->{body}{data}{prope rties}{authtype},"personal-name-heading__sort" => $VAR1->{body}{data}{properties}{authtype__sort},"personal-name-see-also-from" => $VAR1->{body}{data}{properties}{authtype},"personal-name-see-also-from__sort" => $VAR1->{body}{data}{properties}{authtype__sort},"personal-name-see-from" => $VAR1->{body}{data}{properties}{authtype},"personal-name-see-from__sort" => $VAR1->{body}{data}{properties}{authtype__sort},"personal-name__sort" => $VAR1->{body}{data}{properties}{authtype__sort},"record-source" => $VAR1->{body}{data}{prop erties}{authtype},"record-source__sort" => $VAR1->{body}{data}{properties}{authtype__sort},"see-also-from" => $VAR1->{body}{data}{properties}{authtype},"see-also-from__sort" => $VAR1->{body}{data}{properties}{authtype__sort},"see-from" => $VAR1->{body}{data}{properties}{authtype},"see-from__sort" => $VAR1->{body}{data}{properties}{authtype__sort},"subject-heading-thesaurus" => $VAR1->{body}{data}{properties}{authtype},"subject-heading-thesaurus__sort" => $VAR1->{body}{data}{properties}{authtype__sort}}}},ignore => [],metho d => "PUT",mime_type => "application/json",path => "/koha_kohadev_authorities/_mapping/data",qs => {},serialize => "std"} -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jun 3 21:07:07 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jun 2020 19:07:07 +0000 Subject: [Koha-bugs] [Bug 25668] ElasticSearch 6 deprecation: the default number of shards will change in version 7 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25668 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jun 3 21:07:08 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jun 2020 19:07:08 +0000 Subject: [Koha-bugs] [Bug 25669] ElasticSearch 6 deprecation: [types removal] Specifying types in put mapping requests is deprecated (incompatible with 7) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25669 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jun 3 21:07:18 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jun 2020 19:07:18 +0000 Subject: [Koha-bugs] [Bug 25668] ElasticSearch 6 deprecation: the default number of shards will change in version 7 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25668 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |25439 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25439 [Bug 25439] [Omnibus] Prepare Koha to ElasticSearch 7 - ES7 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jun 3 21:07:18 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jun 2020 19:07:18 +0000 Subject: [Koha-bugs] [Bug 25439] [Omnibus] Prepare Koha to ElasticSearch 7 - ES7 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25439 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |25668 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25668 [Bug 25668] ElasticSearch 6 deprecation: the default number of shards will change in version 7 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 3 21:07:21 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jun 2020 19:07:21 +0000 Subject: [Koha-bugs] [Bug 25669] ElasticSearch 6 deprecation: [types removal] Specifying types in put mapping requests is deprecated (incompatible with 7) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25669 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |25439 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25439 [Bug 25439] [Omnibus] Prepare Koha to ElasticSearch 7 - ES7 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 3 21:07:21 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jun 2020 19:07:21 +0000 Subject: [Koha-bugs] [Bug 25439] [Omnibus] Prepare Koha to ElasticSearch 7 - ES7 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25439 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |25669 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25669 [Bug 25669] ElasticSearch 6 deprecation: [types removal] Specifying types in put mapping requests is deprecated (incompatible with 7) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jun 3 21:18:28 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jun 2020 19:18:28 +0000 Subject: [Koha-bugs] [Bug 24986] Maximum row size reached soon for borrowers and deletedborrowers In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24986 Magnus Enger changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |magnus at libriotech.no --- Comment #1 from Magnus Enger --- I got a similar error when upgrading a straight package install from 18.11.06 to 19.11.06: DBD::mysql::db do failed: Row size too large. The maximum row size for the used table type, not counting BLOBs, is 8126. This includes storage overhead, check the manual. You have to change some columns to TEXT or BLOBs [for Statement " ALTER TABLE borrowers ADD COLUMN flgAnonymized tinyint DEFAULT 0 AFTER overdrive_auth_token "] at /usr/share/koha/intranet/cgi-bin/installer/data/mysql/updatedatabase.pl line 18071. DBD::mysql::db do failed: Row size too large. The maximum row size for the used table type, not counting BLOBs, is 8126. This includes storage overhead, check the manual. You have to change some columns to TEXT or BLOBs [for Statement " ALTER TABLE deletedborrowers ADD COLUMN flgAnonymized tinyint DEFAULT 0 AFTER overdrive_auth_token "] at /usr/share/koha/intranet/cgi-bin/installer/data/mysql/updatedatabase.pl line 18077. Upgrade to 18.12.00.049 done (Bug 21336 - Add field flgAnonymized) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jun 3 21:21:42 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jun 2020 19:21:42 +0000 Subject: [Koha-bugs] [Bug 24986] Maximum row size reached soon for borrowers and deletedborrowers In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24986 --- Comment #2 from Magnus Enger --- When I run those same updates manually they work: MariaDB [koha_hkr]> ALTER TABLE borrowers -> ADD COLUMN flgAnonymized tinyint DEFAULT 0 -> AFTER overdrive_auth_token; Query OK, 0 rows affected (0.006 sec) Records: 0 Duplicates: 0 Warnings: 0 MariaDB [koha_hkr]> ALTER TABLE deletedborrowers -> ADD COLUMN flgAnonymized tinyint DEFAULT 0 -> AFTER overdrive_auth_token; Query OK, 0 rows affected (0.006 sec) Records: 0 Duplicates: 0 Warnings: 0 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jun 3 21:21:57 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jun 2020 19:21:57 +0000 Subject: [Koha-bugs] [Bug 13952] Import and export of authority types In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13952 Michal Denar changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply --- Comment #111 from Michal Denar --- Hi Aleisha, it need to be rebase on top of master. Thanks -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 3 21:25:59 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jun 2020 19:25:59 +0000 Subject: [Koha-bugs] [Bug 25669] ElasticSearch 6: [types removal] Specifying types in put mapping requests is deprecated (incompatible with 7) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25669 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|ElasticSearch 6 |ElasticSearch 6: [types |deprecation: [types |removal] Specifying types |removal] Specifying types |in put mapping requests is |in put mapping requests is |deprecated (incompatible |deprecated (incompatible |with 7) |with 7) | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 3 21:35:26 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jun 2020 19:35:26 +0000 Subject: [Koha-bugs] [Bug 25662] Create hold route does not check maxreserves syspref In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25662 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com --- Comment #1 from Tomás Cohen Arazi --- (In reply to Jonathan Druart from comment #0) > The "maxreserves" syspref is only checked in opac/opac-reserve.pl and > reserve/request.pl Why isn't maxreserves checked in CanItemBeReserved? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jun 3 21:38:41 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jun 2020 19:38:41 +0000 Subject: [Koha-bugs] [Bug 24986] Maximum row size reached soon for borrowers and deletedborrowers In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24986 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|normal |critical CC| |tomascohen at gmail.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 3 21:54:37 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jun 2020 19:54:37 +0000 Subject: [Koha-bugs] [Bug 25670] New: Add a method to search by ordernumber on transfered ones as well to K:A:Orders Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25670 Bug ID: 25670 Summary: Add a method to search by ordernumber on transfered ones as well to K:A:Orders Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Acquisitions Assignee: koha-bugs at lists.koha-community.org Reporter: tomascohen at gmail.com QA Contact: testopia at bugs.koha-community.org This is something that happens in C4::Acquisition::SearchOrders and is needed to be used on the API controller. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jun 3 21:54:43 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jun 2020 19:54:43 +0000 Subject: [Koha-bugs] [Bug 25670] Add a method to search by ordernumber on transfered ones as well to K:A:Orders In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25670 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |tomascohen at gmail.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 3 21:54:58 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jun 2020 19:54:58 +0000 Subject: [Koha-bugs] [Bug 25670] Add a method to search by ordernumber on transfered ones as well to K:A:Orders In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25670 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |20212 Status|NEW |ASSIGNED Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20212 [Bug 20212] Slowness in Receiving in Acquisitions -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 3 21:54:58 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jun 2020 19:54:58 +0000 Subject: [Koha-bugs] [Bug 20212] Slowness in Receiving in Acquisitions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20212 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |25670 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25670 [Bug 25670] Add a method to search by ordernumber on transfered ones as well to K:A:Orders -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 3 22:05:56 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jun 2020 20:05:56 +0000 Subject: [Koha-bugs] [Bug 25670] Add a method to search by ordernumber on transfered ones as well to K:A:Orders In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25670 --- Comment #1 from Tomás Cohen Arazi --- Created attachment 105534 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105534&action=edit Bug 25670: Unit tests -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 3 22:06:01 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jun 2020 20:06:01 +0000 Subject: [Koha-bugs] [Bug 25670] Add a method to search by ordernumber on transfered ones as well to K:A:Orders In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25670 --- Comment #2 from Tomás Cohen Arazi --- Created attachment 105535 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105535&action=edit Bug 25670: Add Koha::Acquisition::Orders->filter_by_id_including_transfers This patch introduces a method to filter on the ordernumber, looking for it on the aqorders_transfers table ('ordernumber_from' field). To test: 1. Apply this patches 2. Run: $ kshell k$ prove t/db_dependent/Koha/Acquisition/Orders.t => SUCCESS: Tests pass! 3. Sign off :-D -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 3 22:45:03 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jun 2020 20:45:03 +0000 Subject: [Koha-bugs] [Bug 23019] Ability to create 'matching profiles' when importing records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23019 Agustín Moyano changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 3 22:45:07 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jun 2020 20:45:07 +0000 Subject: [Koha-bugs] [Bug 23019] Ability to create 'matching profiles' when importing records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23019 Agustín Moyano changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #104972|0 |1 is obsolete| | Attachment #104973|0 |1 is obsolete| | Attachment #104974|0 |1 is obsolete| | Attachment #104975|0 |1 is obsolete| | Attachment #104976|0 |1 is obsolete| | --- Comment #11 from Agustín Moyano --- Created attachment 105536 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105536&action=edit Bug 23019: Update database structure and add atomic update -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 3 22:45:11 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jun 2020 20:45:11 +0000 Subject: [Koha-bugs] [Bug 23019] Ability to create 'matching profiles' when importing records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23019 --- Comment #12 from Agustín Moyano --- Created attachment 105537 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105537&action=edit Bug 23019: Add koha_object_class and koha_objects_class methods to ImportBatch.pm schema -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 3 22:45:15 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jun 2020 20:45:15 +0000 Subject: [Koha-bugs] [Bug 23019] Ability to create 'matching profiles' when importing records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23019 --- Comment #13 from Agustín Moyano --- Created attachment 105538 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105538&action=edit Bug 23019: Add ImportBatchesProfile schema and set is_boolean to parse_items column -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 3 22:45:19 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jun 2020 20:45:19 +0000 Subject: [Koha-bugs] [Bug 23019] Ability to create 'matching profiles' when importing records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23019 --- Comment #14 from Agustín Moyano --- Created attachment 105539 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105539&action=edit Bug 23019: Add tests -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 3 22:45:23 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jun 2020 20:45:23 +0000 Subject: [Koha-bugs] [Bug 23019] Ability to create 'matching profiles' when importing records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23019 --- Comment #15 from Agustín Moyano --- Created attachment 105540 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105540&action=edit Bug 23019: Add profiles to stage-import-batch and magnage-import-batch pages This patch adds the logic and the needed UI elements to be able to pre-load an import profile. It also displays which profile was used to stage an import in staged import manager. To test: 1. Apply all patches 2. Updatedatabase 3. Go to Stage MARC records for Import tool in admin, and upload a file with MARC records. CHECK => after uploading, there is a fieldset with the legend “Profile settings” => inside the fieldset there is a select labeled “Pre fill values with profile”. The only value it has is “Do not use profile”. 4. Change some settings, and set “profile 1” as profile name and click on “Add profile” SUCCESS => The select now has the new profile selected 5. Change profile select to “Do not use profile” SUCCESS => Default values are now displayed in the form 6. Reload the page and upload the file again SUCCESS => the select still has the profile recently added 7. Select the profile, change some parameter in the form and set the profile name to “profile 2”, and click add profile SUCCESS => there are two profiles now, and if you toggle between them, the parameter changes 8. Select profile 1, change one parameter and click on update profile SUCCESS => if you toggle that profile with the other, the new parameter of the value is shown when you select profile 1 9. Select profile 2, change some parameter and click Add profile (leaving the name as profile 2) SUCCESS => the page complains there is another profile with the same name, and asks if you want to replace it. 10. Click on accept SUCCESS => profile 2 now has the new value in the parameter 11. Select profile 2 and change the name to profile 1 SUCCESS => the page complains there is another profile with that name, and asks if you want to replace it 12. Click on accept SUCCESS => in profile select there is only one profile called profile 1 that has the values of profile 2 13. Select profile 1 and click remove profile SUCCESS => there is no profile in profile select. 14. Create a profile and click on “Stage for import” 15. Go to Staged MARC management page SUCCESS => Improt should have the name of the profile in profile column, and when you click on the file name, there should be the name of the profile in the details. 16. prove t/db_dependent/ImportBatch.t t/db_dependent/api/v1/import_batch_profiles.t 17. Sign off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 3 23:16:55 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jun 2020 21:16:55 +0000 Subject: [Koha-bugs] [Bug 25375] Elasticsearch: Limit on available items does not work In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25375 Jason Robb changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jrobb at sekls.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 3 23:43:50 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jun 2020 21:43:50 +0000 Subject: [Koha-bugs] [Bug 23019] Ability to create 'matching profiles' when importing records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23019 --- Comment #16 from Abbey Holt --- This is great! There is one area where my matching preferences would not stick when I created a profile. If I select "No" under "Check for embedded item record data" and click "Add profile", No switches back to Yes. My selection for "how to process items" is remembered. It is just the yes-no button that isn't being saved. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 4 01:39:47 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 03 Jun 2020 23:39:47 +0000 Subject: [Koha-bugs] [Bug 23191] Administrators should be able to install plugins from the command line In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23191 --- Comment #24 from David Cook --- (In reply to Martin Renvoize from comment #23) > (In reply to David Cook from comment #22) > > I like the sound of this but the implementation seems very different to what > > I would have expected. > > > > I thought it would be something like "misc/devel/install_plugin.pl > > ". > > Feel free to add such this additional functionality in a new bug ;) It's on my mind! Heh. I just have so much going on at the moment. I haven't even been working on plugins, as I've just needed the free time to decompress. (I'm just about to roll out some experimental work with RabbitMQ to select production instances, so I might have more to say on Bug 22417 at least.) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 4 02:07:56 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jun 2020 00:07:56 +0000 Subject: [Koha-bugs] [Bug 22417] Delegate background jobs execution In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22417 --- Comment #51 from David Cook --- (In reply to David Cook from comment #50) > We use RabbitMQ for some other projects, and I think I'm going to start > looking at using it with some of our local Koha extensions. > With my own code, I've added a local tool to tools-home.pl, and I have that add a JSON message to RabbitMQ with Net::Stomp. I have a background worker using Net::Stomp to get the JSON message, do the long-running task, and then email a user with the result. It does the bare minimum of what I need it to do, and I'll be looking to roll it out soon as an experimental feature to select Koha instances. Both the web app and daemon worker rely on configuration in koha-conf.xml to know not only the RabbitMQ server address, username, and password, but also what queues to use. (I rather use a YAML file for this, but koha-conf.xml already has caching support, so it's so easy to use.) Things to think about: - Installing RabbitMQ and plugins are easy, but you need enable the stomp plugin and create virtual hosts as the RabbitMQ administrator... which is only possible if they're running on the same machine - Technically, all Koha instances could use the root vhost, and we could prefix the queue names. (I'm going to be running into this issue when I roll out my experimental work more widely.) - Flow control for the background worker. Should it do 1 task at a time, or should it fork off workers? If it forks workers, you can easily exhaust your system's resources if you don't have any artificial limits, but you can also do more work. (Alternatively, we could create the facility to run X background workers, so sysadmins would determine the limits.) - How best to store the results of background tasks? Should it be in 1 central store, or should it be more task specific? Most of those are sysadmin type questions except for the last one. For the last one, I'm thinking task specific might be best, especially when it comes to background tasks done by Koha Plugins. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 4 02:09:21 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jun 2020 00:09:21 +0000 Subject: [Koha-bugs] [Bug 22417] Delegate background jobs execution In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22417 --- Comment #52 from David Cook --- Oh and in the JSON message I specify "class" and "method" (much like the Koha::Plugin::Handler). It also provides "args". So it loads the "class", and runs the "method" with the "args". It's pretty simple. If I were to record results, I'd probably have a "result_callback_method" or something too. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 4 02:13:52 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jun 2020 00:13:52 +0000 Subject: [Koha-bugs] [Bug 25660] Unable to change system preferences in "vintage" git install without plack In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25660 --- Comment #3 from David Cook --- (In reply to Caroline Cyr La Rose from comment #2) > Hi David, > > No I'm not using docker nor devbox. > > Caroline Ok. That's what you meant by "vintage" git install hehe. Well, I primarily use a "vintage" git install as well. I haven't tested master recently with that particular install. I'll try to remember to take a look. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jun 4 02:16:42 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jun 2020 00:16:42 +0000 Subject: [Koha-bugs] [Bug 23191] Administrators should be able to install plugins from the command line In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23191 --- Comment #25 from David Cook --- (In reply to Martin Renvoize from comment #23) > (In reply to David Cook from comment #22) > > I like the sound of this but the implementation seems very different to what > > I would have expected. > > > > I thought it would be something like "misc/devel/install_plugin.pl > > ". > > Feel free to add such this additional functionality in a new bug ;) I'm thinking "koha-plugin-install ". Then if you wanted all your instances to be running one plugin, it would be trivial... Ok I'll open a bug report now but probably won't work on for a while (although you never know :O) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 4 02:20:53 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jun 2020 00:20:53 +0000 Subject: [Koha-bugs] [Bug 25671] New: Administrators should be able to add/upload plugins from the command line Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25671 Bug ID: 25671 Summary: Administrators should be able to add/upload plugins from the command line Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Plugin architecture Assignee: koha-bugs at lists.koha-community.org Reporter: dcook at prosentient.com.au QA Contact: testopia at bugs.koha-community.org I want to create the following: koha-plugin-install You'd have 1 KPZ package, and you'd be able to add/upload/install it into an instance from the command line. This would allow a sysadmin to easily automate the installation of plugins across Koha instances from the server side. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jun 4 02:21:02 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jun 2020 00:21:02 +0000 Subject: [Koha-bugs] [Bug 23191] Administrators should be able to install plugins from the command line In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23191 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=25671 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 4 02:21:02 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jun 2020 00:21:02 +0000 Subject: [Koha-bugs] [Bug 25671] Administrators should be able to add/upload plugins from the command line In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25671 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=23191 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 4 02:25:00 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jun 2020 00:25:00 +0000 Subject: [Koha-bugs] [Bug 25672] New: Administrators should be able to disable client-side and enable server-side plugin management Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25672 Bug ID: 25672 Summary: Administrators should be able to disable client-side and enable server-side plugin management Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Plugin architecture Assignee: koha-bugs at lists.koha-community.org Reporter: dcook at prosentient.com.au QA Contact: testopia at bugs.koha-community.org Administrators should be able to prevent Koha web users from uploading/installing/uninstalling Koha plugins, and instead allow uploading/installing/uninstalling Koha plugins on the server-side from the CLI. This would allow Koha web users to "use" plugins, but it would require plugins to be vetted and managed by a server sysadmin. This should improve stability and maintainability. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 4 02:25:12 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jun 2020 00:25:12 +0000 Subject: [Koha-bugs] [Bug 25672] Administrators should be able to disable client-side and enable server-side plugin management In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25672 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=25671 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jun 4 02:25:12 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jun 2020 00:25:12 +0000 Subject: [Koha-bugs] [Bug 25671] Administrators should be able to add/upload plugins from the command line In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25671 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=25672 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jun 4 02:25:31 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jun 2020 00:25:31 +0000 Subject: [Koha-bugs] [Bug 25672] Administrators should be able to disable client-side and enable server-side plugin management In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25672 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=23191 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jun 4 02:25:31 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jun 2020 00:25:31 +0000 Subject: [Koha-bugs] [Bug 23191] Administrators should be able to install plugins from the command line In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23191 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=25672 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 4 02:27:05 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jun 2020 00:27:05 +0000 Subject: [Koha-bugs] [Bug 25671] Administrators should be able to add/upload plugins from the command line In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25671 --- Comment #1 from David Cook --- It would also be interesting to use "koha-plugin-install " That could make plugin management even easier. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 4 03:04:19 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jun 2020 01:04:19 +0000 Subject: [Koha-bugs] [Bug 23019] Ability to create 'matching profiles' when importing records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23019 Agustín Moyano changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #105540|0 |1 is obsolete| | --- Comment #17 from Agustín Moyano --- Created attachment 105541 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105541&action=edit Bug 23019: Add profiles to stage-import-batch and magnage-import-batch pages This patch adds the logic and the needed UI elements to be able to pre-load an import profile. It also displays which profile was used to stage an import in staged import manager. To test: 1. Apply all patches 2. Updatedatabase 3. Go to Stage MARC records for Import tool in admin, and upload a file with MARC records. CHECK => after uploading, there is a fieldset with the legend “Profile settings” => inside the fieldset there is a select labeled “Pre fill values with profile”. The only value it has is “Do not use profile”. 4. Change some settings, and set “profile 1” as profile name and click on “Add profile” SUCCESS => The select now has the new profile selected 5. Change profile select to “Do not use profile” SUCCESS => Default values are now displayed in the form 6. Reload the page and upload the file again SUCCESS => the select still has the profile recently added 7. Select the profile, change some parameter in the form and set the profile name to “profile 2”, and click add profile SUCCESS => there are two profiles now, and if you toggle between them, the parameter changes 8. Select profile 1, change one parameter and click on update profile SUCCESS => if you toggle that profile with the other, the new parameter of the value is shown when you select profile 1 9. Select profile 2, change some parameter and click Add profile (leaving the name as profile 2) SUCCESS => the page complains there is another profile with the same name, and asks if you want to replace it. 10. Click on accept SUCCESS => profile 2 now has the new value in the parameter 11. Select profile 2 and change the name to profile 1 SUCCESS => the page complains there is another profile with that name, and asks if you want to replace it 12. Click on accept SUCCESS => in profile select there is only one profile called profile 1 that has the values of profile 2 13. Select profile 1 and click remove profile SUCCESS => there is no profile in profile select. 14. Create a profile and click on “Stage for import” 15. Go to Staged MARC management page SUCCESS => Improt should have the name of the profile in profile column, and when you click on the file name, there should be the name of the profile in the details. 16. prove t/db_dependent/ImportBatch.t t/db_dependent/api/v1/import_batch_profiles.t 17. Sign off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 4 03:05:37 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jun 2020 01:05:37 +0000 Subject: [Koha-bugs] [Bug 23019] Ability to create 'matching profiles' when importing records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23019 --- Comment #18 from Agustín Moyano --- (In reply to Abbey Holt from comment #16) > This is great! There is one area where my matching preferences would not > stick when I created a profile. If I select "No" under "Check for embedded > item record data" and click "Add profile", No switches back to Yes. My > selection for "how to process items" is remembered. It is just the yes-no > button that isn't being saved. Hi Abbey, thanks so much for pointing that out.. could you please try again? Thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 4 05:19:12 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jun 2020 03:19:12 +0000 Subject: [Koha-bugs] [Bug 22417] Delegate background jobs execution In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22417 --- Comment #53 from David Cook --- Created attachment 105542 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105542&action=edit [Prosentient] Create experimental support for RabbitMQ-based background tasks This patch includes a koha-mq-scheduler service which creates a mq_scheduler.pl daemon, which listens to RabbitMQ queues. This patch also includes an audit-authorities.pl web script, which sends a message to RabbitMQ. The mq_scheduler.pl daemon loads Koha::Prosentient::MQ::AuditAuthorities.pm, and runs a class method which does a background task to audit bib-auth linkages. Koha community work: https://bugs.koha-community.org/bugzilla3//show_bug.cgi?id=22417 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 4 05:20:19 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jun 2020 03:20:19 +0000 Subject: [Koha-bugs] [Bug 22417] Delegate background jobs execution In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22417 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #105542|1 |0 is patch| | Attachment #105542|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 4 05:22:09 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jun 2020 03:22:09 +0000 Subject: [Koha-bugs] [Bug 22417] Delegate background jobs execution In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22417 --- Comment #54 from David Cook --- Created attachment 105543 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105543&action=edit [Local Prosentient] Create experimental support for RabbitMQ-based background tasks This patch includes a koha-mq-scheduler service which creates a mq_scheduler.pl daemon, which listens to RabbitMQ queues. This patch also includes an audit-authorities.pl web script, which sends a message to RabbitMQ. The mq_scheduler.pl daemon loads Koha::Prosentient::MQ::AuditAuthorities.pm, and runs a class method which does a background task to audit bib-auth linkages. Koha community work: https://bugs.koha-community.org/bugzilla3//show_bug.cgi?id=22417 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 4 05:30:26 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jun 2020 03:30:26 +0000 Subject: [Koha-bugs] [Bug 22417] Delegate background jobs execution In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22417 --- Comment #55 from David Cook --- At Tomas's request, I've attached a patch I've done for a local customization to use RabbitMQ. It's very simple. I don't have any time-based "task scheduling" per se. It's just FIFO. The mq_scheduler.pl script is problematic in a number of ways, but it's just an experiment. Early testing is good. You submit a form on the Koha web UI, it sends a message to RabbitMQ, the mq_scheduler.pl receives the message from RabbitMQ, the mq_scheduler.pl loads a module and runs some code (which in this case also sends an email), and then it marks the message complete/acknowledged in RabbitMQ. This patch does require a person to run "add_vhost" and "set_permissions" manually using rabbitmqctl on the host running RabbitMQ. However, as I'm defining the queues in koha-conf.xml, the root vhost could be used, and the queues could be prefixed with __DB_NAME__. At this point, I'm fairly indifferent to the method. I like vhosts for the logical separation of the messages, but if it's not practical for a package installation, then maybe we should just use the prefixed queues. The systemd service is *very* package installation friendly. We'd need to update the debian/* files accordingly, but it would be so easy. I haven't done that yet, as I'm testing on non-package installations first. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 4 08:23:43 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jun 2020 06:23:43 +0000 Subject: [Koha-bugs] [Bug 24562] addbiblio.pl overloading CPU In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24562 --- Comment #16 from Marcel de Rooy --- Are you really sure that the problem is in addbiblio.pl? Could it be that some other process is overloading the CPU which could explain that the addbiblio is getting a timeout ? I recently had some similar issues and I do not trust the z3950 searches for instance. This is a asynchronous search that might create problems under Plack, where I would not expect that so quickly for addbiblio ? But note that I am also still searching for a clue. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jun 4 08:47:18 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jun 2020 06:47:18 +0000 Subject: [Koha-bugs] [Bug 24562] addbiblio.pl overloading CPU In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24562 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au --- Comment #17 from David Cook --- (In reply to Jawad Makki from comment #7) > some bibliographic records include few items (between 1 to 5 items). > other bibliographic records are for Serials, they are including high number > of issues (items) that can reach more than 1000 items in some cases. > Does the high CPU usage only happen for records with a high number of items or does it happen also for records with a low number of items? Of course, it could be something else on the system. Is your database on the same server or a separate server? It could be stuck waiting for I/O on the database end, although I tend to only see that on databases much larger than the largest Koha database I've ever seen. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 4 10:43:15 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jun 2020 08:43:15 +0000 Subject: [Koha-bugs] [Bug 25673] New: Access logging of borrower's personal information Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25673 Bug ID: 25673 Summary: Access logging of borrower's personal information Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Staff Client Assignee: koha-bugs at lists.koha-community.org Reporter: joonas.kylmala at helsinki.fi QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com Blocks: 18081 I don't know if this is directly related to GDPR but at least this seems like a good practice: create a log if a librarian has accessed a Koha page in intranet that contains borrower's personal information. This way the library can make sure by auditing the logs that nobody has for example downloaded all the borrowers' info en masse with screen scraping. Currently this is a bit hard to implement in Koha since borrower's personal info is displayed on many many pages, but to ease this we should think if displaying borrower's real name is necessary or would a cardnumber or borrowernumber be better. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18081 [Bug 18081] [omnibus] GDPR (General Data Protection Regulation) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jun 4 10:43:15 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jun 2020 08:43:15 +0000 Subject: [Koha-bugs] [Bug 18081] [omnibus] GDPR (General Data Protection Regulation) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18081 Joonas Kylmälä changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |25673 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25673 [Bug 25673] Access logging of borrower's personal information -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jun 4 10:43:15 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jun 2020 08:43:15 +0000 Subject: [Koha-bugs] [Bug 21189] GDPR: Log all CRUD actions on patron data In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21189 Joonas Kylmälä changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=25673 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 4 10:55:00 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jun 2020 08:55:00 +0000 Subject: [Koha-bugs] [Bug 22417] Delegate background jobs execution In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22417 --- Comment #56 from Jonathan Druart --- Can we dedicate this bug report to the base idea, then create bug report on top of it for experiment? I'd like to avoid noise for testers and keep the comment list easy to follow. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 4 11:40:23 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jun 2020 09:40:23 +0000 Subject: [Koha-bugs] [Bug 25657] Import Patron fails without userid - not stated as required field in notes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25657 --- Comment #4 from Jonathan Druart --- Yes, I have tried with: * "userid" header and no data in it * no userid header In both cases the import succeeded, and the patrons had a userid=firstname.surname Could you create a new patron with a given userid, login with it, then use a simple version of the CSV file? If you can recreate the problem (on a sandbox for intance), share the CSV sample file and I will investigate what's going on. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jun 4 11:46:59 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jun 2020 09:46:59 +0000 Subject: [Koha-bugs] [Bug 25665] test t/db_dependent/Circulation.t fails on a specific date In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25665 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #6 from Jonathan Druart --- When you managed to make it fail, share the patch to make sure it fails for someone else as well. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 4 11:47:19 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jun 2020 09:47:19 +0000 Subject: [Koha-bugs] [Bug 25665] test t/db_dependent/Circulation.t fails on a specific date In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25665 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|chris at bigballofwax.co.nz |victor at tuxayo.net -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 4 11:54:39 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jun 2020 09:54:39 +0000 Subject: [Koha-bugs] [Bug 23091] Restore Forgiven Overdue Fines When Lost Item Returned In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23091 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #105529|0 |1 is obsolete| | --- Comment #10 from Martin Renvoize --- Created attachment 105544 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105544&action=edit Bug 23091: Database update This patch updates the 'refund' circulation rule to be called 'lostreturn' and populates the value with 'refund' where appropriate. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 4 11:54:43 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jun 2020 09:54:43 +0000 Subject: [Koha-bugs] [Bug 23091] Restore Forgiven Overdue Fines When Lost Item Returned In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23091 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #105530|0 |1 is obsolete| | --- Comment #11 from Martin Renvoize --- Created attachment 105545 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105545&action=edit Bug 23091: Update unit test This patch updates the unit test for get_lostreturn_policy to reflect the rule_name and return code changes. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 4 11:54:46 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jun 2020 09:54:46 +0000 Subject: [Koha-bugs] [Bug 23091] Restore Forgiven Overdue Fines When Lost Item Returned In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23091 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #105531|0 |1 is obsolete| | --- Comment #12 from Martin Renvoize --- Created attachment 105546 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105546&action=edit Bug 23091: Add handling for new lostreturn rules This patch adds circulation handling for two new lost item return rules. These new rules allow for the new options of refund lost item charge plus charge a freshly calculated overdue fine and refind of lost item charge plus charge a new fine matching the amount from the original overdue fine. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 4 11:54:50 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jun 2020 09:54:50 +0000 Subject: [Koha-bugs] [Bug 23091] Restore Forgiven Overdue Fines When Lost Item Returned In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23091 --- Comment #13 from Martin Renvoize --- Created attachment 105547 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105547&action=edit Bug 23091: Add handling for restore case This patch adds handling for the 'restore' case of lostreturn policy. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 4 11:55:02 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jun 2020 09:55:02 +0000 Subject: [Koha-bugs] [Bug 23091] Restore Forgiven Overdue Fines When Lost Item Returned In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23091 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 4 11:55:52 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jun 2020 09:55:52 +0000 Subject: [Koha-bugs] [Bug 23091] Restore Forgiven Overdue Fines When Lost Item Returned In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23091 --- Comment #14 from Martin Renvoize --- This needs new units tests for the QA step, but I wanted some early testing to check that the end results are as expected by those interested in the feature. Many thanks in advance. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 4 11:57:43 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jun 2020 09:57:43 +0000 Subject: [Koha-bugs] [Bug 24986] Maximum row size reached soon for borrowers and deletedborrowers In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24986 --- Comment #3 from Jonathan Druart --- What's the return of show variables where Variable_name = 'innodb_file_per_table'; show variables where Variable_name = 'innodb_default_row_format'; -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 4 12:04:05 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jun 2020 10:04:05 +0000 Subject: [Koha-bugs] [Bug 23091] Restore Forgiven Overdue Fines When Lost Item Returned In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23091 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com, | |tomascohen at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 4 12:04:47 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jun 2020 10:04:47 +0000 Subject: [Koha-bugs] [Bug 23091] Restore Forgiven Overdue Fines When Lost Item Returned In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23091 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|major |enhancement -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 4 12:06:24 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jun 2020 10:06:24 +0000 Subject: [Koha-bugs] [Bug 23091] Add options to charge new or restore forgiven overdues when a lost item is returned In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23091 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Restore Forgiven Overdue |Add options to charge new |Fines When Lost Item |or restore forgiven |Returned |overdues when a lost item | |is returned -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 4 12:10:05 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jun 2020 10:10:05 +0000 Subject: [Koha-bugs] [Bug 24986] Maximum row size reached soon for borrowers and deletedborrowers In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24986 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |jonathan.druart at bugs.koha-c |ity.org |ommunity.org Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jun 4 12:14:38 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jun 2020 10:14:38 +0000 Subject: [Koha-bugs] [Bug 24986] Maximum row size reached soon for borrowers and deletedborrowers In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24986 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 4 12:14:42 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jun 2020 10:14:42 +0000 Subject: [Koha-bugs] [Bug 24986] Maximum row size reached soon for borrowers and deletedborrowers In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24986 --- Comment #4 from Jonathan Druart --- Created attachment 105548 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105548&action=edit Bug 24986: Modify some borrowers DB fields to (TINY|MEDIUM)TEXT -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 4 12:15:05 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jun 2020 10:15:05 +0000 Subject: [Koha-bugs] [Bug 24986] Maximum row size reached soon for borrowers and deletedborrowers In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24986 --- Comment #5 from Jonathan Druart --- Can you confirm this patch resolves the problem? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 4 12:15:49 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jun 2020 10:15:49 +0000 Subject: [Koha-bugs] [Bug 24986] Maximum row size reached soon for borrowers and deletedborrowers In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24986 --- Comment #6 from Jonathan Druart --- https://dev.mysql.com/doc/refman/8.0/en/column-count-limit.html https://dev.mysql.com/doc/refman/8.0/en/storage-requirements.html -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 4 12:18:47 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jun 2020 10:18:47 +0000 Subject: [Koha-bugs] [Bug 25673] Access logging of borrower's personal information In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25673 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 4 12:45:07 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jun 2020 10:45:07 +0000 Subject: [Koha-bugs] [Bug 25508] Confusing renewal message when paying accruing fine In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25508 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|martin.renvoize at ptfs-europe |david.roberts at ptfs-europe.c |.com |om -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 4 12:46:24 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jun 2020 10:46:24 +0000 Subject: [Koha-bugs] [Bug 25644] Self Check in Patron Account In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25644 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard at myacpl.org |koha-bugs at lists.koha-commun | |ity.org -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 4 12:51:15 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jun 2020 10:51:15 +0000 Subject: [Koha-bugs] [Bug 8338] Fines not cleared with dropbox mode In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8338 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=22539 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 4 12:51:15 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jun 2020 10:51:15 +0000 Subject: [Koha-bugs] [Bug 22539] Fines charged on back-dated checkin when item has been renewed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22539 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=8338 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 4 12:51:24 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jun 2020 10:51:24 +0000 Subject: [Koha-bugs] [Bug 8338] Fines not cleared with dropbox mode In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8338 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|22539 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22539 [Bug 22539] Fines charged on back-dated checkin when item has been renewed -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 4 12:51:24 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jun 2020 10:51:24 +0000 Subject: [Koha-bugs] [Bug 22539] Fines charged on back-dated checkin when item has been renewed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22539 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|8338 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8338 [Bug 8338] Fines not cleared with dropbox mode -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 4 12:52:11 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jun 2020 10:52:11 +0000 Subject: [Koha-bugs] [Bug 22539] Fines charged on back-dated checkin when item has been renewed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22539 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |14825 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14825 [Bug 14825] Accounts Rewrite Omnibus -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 4 12:52:11 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jun 2020 10:52:11 +0000 Subject: [Koha-bugs] [Bug 14825] Accounts Rewrite Omnibus In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14825 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |22539 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22539 [Bug 22539] Fines charged on back-dated checkin when item has been renewed -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 4 13:08:52 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jun 2020 11:08:52 +0000 Subject: [Koha-bugs] [Bug 24986] Maximum row size reached soon for borrowers and deletedborrowers In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24986 --- Comment #7 from Magnus Enger --- (In reply to Jonathan Druart from comment #3) > What's the return of > show variables where Variable_name = 'innodb_file_per_table'; > show variables where Variable_name = 'innodb_default_row_format'; MariaDB [koha]> show variables where Variable_name = 'innodb_file_per_table'; +-----------------------+-------+ | Variable_name | Value | +-----------------------+-------+ | innodb_file_per_table | ON | +-----------------------+-------+ 1 row in set (0.001 sec) MariaDB [koha]> show variables where Variable_name = 'innodb_default_row_format'; +---------------------------+---------+ | Variable_name | Value | +---------------------------+---------+ | innodb_default_row_format | dynamic | +---------------------------+---------+ 1 row in set (0.001 sec) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 4 14:10:47 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jun 2020 12:10:47 +0000 Subject: [Koha-bugs] [Bug 24986] Maximum row size reached soon for borrowers and deletedborrowers In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24986 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com --- Comment #8 from Kyle M Hall --- > After re-injecting an old clean dump and replaying the updatedatabase.pl > errors are gone, so it was probably because of other columns coming from > patches not yet in master. > Maybe we should start moving some columns to other tables. An obvious > candidate is all the address fields that can be moved in a patron_addresses > table. Another option would be to move some columns into a JSON column. MariaDB 10.2.7 and MySQL 5.7 both have JSON data types and functions to use JSON values in a query. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 4 14:20:34 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jun 2020 12:20:34 +0000 Subject: [Koha-bugs] [Bug 25627] Move OPAC problem reports from administration to tools? In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25627 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 4 14:20:37 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jun 2020 12:20:37 +0000 Subject: [Koha-bugs] [Bug 25627] Move OPAC problem reports from administration to tools? In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25627 --- Comment #1 from Owen Leonard --- Created attachment 105549 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105549&action=edit Bug 25627: Move OPAC problem reports from administration to tools This patch moves the OPAC problem report management page from the Administration section to the Tools section. I think this makes sense because management of reports is an ongoing task, not a configuration. To test, apply the patch and enable the OPACReportProblem system preference. - Go to Administration. There should be no link to OPAC problem reports. - Open an administration page which shows the Administration menu in the left-hand sidebar, e.g. Libraries. There should be no link to OPAC problem reports in the menu. - Go to Tools. There should be a link to OPAC problem reports in the "Addional tools" section. - Open the OPAC problem reports page and confirm that it works correctly. - The breadcrumbs menu should show "Tools > OPAC problem reports." - Confirm that the link in the sidebar menu works correctly. - If necessary, submit an OPAC problem report via the OPAC so that there is a pending report. Go to the staff interface home page and check that the "OPAC problem reports pending" link works correctly. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 4 14:20:47 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jun 2020 12:20:47 +0000 Subject: [Koha-bugs] [Bug 25627] Move OPAC problem reports from administration to tools In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25627 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Move OPAC problem reports |Move OPAC problem reports |from administration to |from administration to |tools? |tools -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 4 14:23:34 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jun 2020 12:23:34 +0000 Subject: [Koha-bugs] [Bug 23091] Add options to charge new or restore forgiven overdues when a lost item is returned In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23091 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|needs_rfc |rel_20_11_target -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 4 14:31:42 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jun 2020 12:31:42 +0000 Subject: [Koha-bugs] [Bug 10846] Add preference for naming OverDrive collection In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10846 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |gmcharlt at gmail.com Component|OPAC |System Administration Assignee|oleonard at myacpl.org |koha-bugs at lists.koha-commun | |ity.org -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 4 14:39:44 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jun 2020 12:39:44 +0000 Subject: [Koha-bugs] [Bug 25593] Terminology: Fix "There is no order for this biblio." on catalog detail page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25593 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |String patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 4 14:39:46 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jun 2020 12:39:46 +0000 Subject: [Koha-bugs] [Bug 25593] Terminology: Fix "There is no order for this biblio." on catalog detail page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25593 --- Comment #1 from Owen Leonard --- Created attachment 105550 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105550&action=edit Bug 25593: Terminology: Fix "There is no order for this biblio." on catalog detail page This patch changes the phrase "There is no order for this biblio" to "There is no order for this bibliographic record." on the catalog detail page. To test, apply the patch and view the bibliographic detail page for a record which has no order associated with it. The text in the "Acquisitions details" tab should be correct. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 4 14:39:51 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jun 2020 12:39:51 +0000 Subject: [Koha-bugs] [Bug 23112] Add circulation process to inter-library loans In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23112 --- Comment #88 from Jonathan Druart --- +use Carp::Always; That should be removed, right? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 4 14:45:04 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jun 2020 12:45:04 +0000 Subject: [Koha-bugs] [Bug 10199] Move fields type, options and explanation from systempreferences table? In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10199 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- CC|oleonard at myacpl.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 4 14:58:10 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jun 2020 12:58:10 +0000 Subject: [Koha-bugs] [Bug 25660] Unable to change system preferences in "vintage" git install without plack In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25660 --- Comment #4 from Caroline Cyr La Rose --- hehe! Phew! I'm glad I'm not the only one using vintage methods :) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jun 4 14:59:55 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jun 2020 12:59:55 +0000 Subject: [Koha-bugs] [Bug 22417] Add a task queue In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22417 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Delegate background jobs |Add a task queue |execution | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 4 15:01:17 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jun 2020 13:01:17 +0000 Subject: [Koha-bugs] [Bug 25662] Create hold route does not check maxreserves syspref In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25662 --- Comment #2 from Jonathan Druart --- It must indeed be moved to CanItemBeReserved (and I think stay in the controller as well, for multi holds). -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 4 15:01:58 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jun 2020 13:01:58 +0000 Subject: [Koha-bugs] [Bug 25674] New: Add RabbitMQ options to koha-create Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25674 Bug ID: 25674 Summary: Add RabbitMQ options to koha-create Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Installation and upgrade (command-line installer) Assignee: koha-bugs at lists.koha-community.org Reporter: tomascohen at gmail.com QA Contact: testopia at bugs.koha-community.org Now that we plan to use RabbitMQ as message broken for a task queue manager, we need to be able to set the RabbitMQ options on instance creation. It should fallback to localhost, etc. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jun 4 15:02:05 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jun 2020 13:02:05 +0000 Subject: [Koha-bugs] [Bug 25674] Add RabbitMQ options to koha-create In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25674 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |22417 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22417 [Bug 22417] Add a task queue -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 4 15:02:05 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jun 2020 13:02:05 +0000 Subject: [Koha-bugs] [Bug 22417] Add a task queue In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22417 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |25674 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25674 [Bug 25674] Add RabbitMQ options to koha-create -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 4 15:02:29 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jun 2020 13:02:29 +0000 Subject: [Koha-bugs] [Bug 25643] Remove maxreserves syspref In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25643 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |In Discussion --- Comment #11 from Jonathan Druart --- If there is a discussion (maybe on the ML?) and we found a consensus, I am willing to implement it. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jun 4 15:16:09 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jun 2020 13:16:09 +0000 Subject: [Koha-bugs] [Bug 25662] Create hold route does not check maxreserves syspref In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25662 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Version|unspecified |master Assignee|koha-bugs at lists.koha-commun |tomascohen at gmail.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 4 15:17:03 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jun 2020 13:17:03 +0000 Subject: [Koha-bugs] [Bug 25658] Print icon sometimes obscures patron barcode In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25658 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #1 from Jonathan Druart --- Where does come from this print icon? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 4 15:25:07 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jun 2020 13:25:07 +0000 Subject: [Koha-bugs] [Bug 25658] Print icon sometimes obscures patron barcode In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25658 --- Comment #2 from Benjamin Daeuber --- (In reply to Jonathan Druart from comment #1) > Where does come from this print icon? It was introduced in 19.05 with the DisplayClearScreenButton system preference. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jun 4 15:34:04 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jun 2020 13:34:04 +0000 Subject: [Koha-bugs] [Bug 18086] overduerules table is lacking foreign key constraints In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18086 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 4 15:34:07 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jun 2020 13:34:07 +0000 Subject: [Koha-bugs] [Bug 18086] overduerules table is lacking foreign key constraints In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18086 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #105424|0 |1 is obsolete| | --- Comment #17 from Kyle M Hall --- Created attachment 105551 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105551&action=edit Bug 18086: Add FK constraints for branchcode and categorycode The overduerules table has no foreign key constraints to any for the related tables. The columns for branchcode, categorycode, letter1, letter2, and letter3 should all be foreign keys. Test Plan: 0) Create some overdue rules with invalid branchcodes and categorycodes 1) Apply this patch 2) Restart all the things! 3) Run updatedatabase.pl 4) Note the invalid rules are deleted 5) Note Default codes are NULL now instead of empty strings 6) Editor should behave as it did before -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 4 15:35:36 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jun 2020 13:35:36 +0000 Subject: [Koha-bugs] [Bug 25586] Something wrong with KOHA_HOME (?) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25586 --- Comment #2 from Jonathan Druart --- KOHA_HOME can be: * /usr/share/koha # pkg install * /kohadevbox/koha # dev install (or another path ofc, the one in the intranetdir config) Weird thing: * debian/scripts/koha-plack 392 adjust_paths_dev_install $name 393 export DEV_INSTALL 394 export KOHA_HOME 395 PERL5LIB=$PERL5LIB:$KOHA_HOME/installer:$KOHA_HOME/lib/installer On a pkg install we don't have /usr/share/koha/installer or /usr/share/koha/lib/installer On a dev instal we don't have /kohadevbox/koha/lib -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jun 4 15:37:14 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jun 2020 13:37:14 +0000 Subject: [Koha-bugs] [Bug 25586] Something wrong with KOHA_HOME (?) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25586 --- Comment #3 from Jonathan Druart --- Created attachment 105552 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105552&action=edit Bug 25586: (bug 25618 follow-up) Use KOHA_HOME to guess pkg bin dir -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jun 4 15:45:38 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jun 2020 13:45:38 +0000 Subject: [Koha-bugs] [Bug 25658] Print icon sometimes obscures patron barcode In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25658 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |17854 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17854 [Bug 17854] New Print slip and close button next to Close button -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 4 15:45:38 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jun 2020 13:45:38 +0000 Subject: [Koha-bugs] [Bug 17854] New Print slip and close button next to Close button In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17854 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |25658 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25658 [Bug 25658] Print icon sometimes obscures patron barcode -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 4 15:48:57 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jun 2020 13:48:57 +0000 Subject: [Koha-bugs] [Bug 25675] New: System preference PatronSelfRegistration incorrectly described Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25675 Bug ID: 25675 Summary: System preference PatronSelfRegistration incorrectly described Change sponsored?: --- Product: Koha Version: 19.11 Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: System Administration Assignee: koha-bugs at lists.koha-community.org Reporter: bwsdonna at gmail.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com The system preference PatronSelfRegistration description states: "library patrons to register or modify their account via the OPAC" however, in testing it, patron self modification is actually controlled by OPACPatronDetails system preference, which is in a different area of system preferences. At the very least, the description for PatronSelfRegistration should be updated to removed the reference to "modify". I would also propose that OPACPatronDetails and PatronSelfModificationBorrowerUnwantedField are placed together. It is very confusing to enable the modification function in one section, and define the display in another section. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jun 4 15:52:21 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jun 2020 13:52:21 +0000 Subject: [Koha-bugs] [Bug 25676] New: Staff client catalog search shows incorrect item status under location Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25676 Bug ID: 25676 Summary: Staff client catalog search shows incorrect item status under location Change sponsored?: --- Product: Koha Version: 19.11 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Searching Assignee: koha-bugs at lists.koha-community.org Reporter: joe at flo.org QA Contact: testopia at bugs.koha-community.org Created attachment 105553 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105553&action=edit Incorrect search result example If you have an item that has a Lost status of "Lost" it will appear as "long overdue" in staff client search results. See attached screenshots for an example. This should display the current Lost status instead. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jun 4 15:53:22 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jun 2020 13:53:22 +0000 Subject: [Koha-bugs] [Bug 25676] Staff client catalog search shows incorrect item status under location In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25676 --- Comment #1 from Joe Sikowitz --- Created attachment 105554 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105554&action=edit Correct item record example -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jun 4 16:06:41 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jun 2020 14:06:41 +0000 Subject: [Koha-bugs] [Bug 23019] Ability to create 'matching profiles' when importing records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23019 --- Comment #19 from Abbey Holt --- (In reply to Agustín Moyano from comment #18) > (In reply to Abbey Holt from comment #16) > > This is great! There is one area where my matching preferences would not > > stick when I created a profile. If I select "No" under "Check for embedded > > item record data" and click "Add profile", No switches back to Yes. My > > selection for "how to process items" is remembered. It is just the yes-no > > button that isn't being saved. > > Hi Abbey, thanks so much for pointing that out.. could you please try again? > > Thanks! It worked! I'm signing off. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 4 16:07:34 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jun 2020 14:07:34 +0000 Subject: [Koha-bugs] [Bug 23019] Ability to create 'matching profiles' when importing records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23019 ByWater Sandboxes changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #105541|0 |1 is obsolete| | --- Comment #20 from ByWater Sandboxes --- Created attachment 105555 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105555&action=edit Bug 23019: Add profiles to stage-import-batch and magnage-import-batch pages This patch adds the logic and the needed UI elements to be able to pre-load an import profile. It also displays which profile was used to stage an import in staged import manager. To test: 1. Apply all patches 2. Updatedatabase 3. Go to Stage MARC records for Import tool in admin, and upload a file with MARC records. CHECK => after uploading, there is a fieldset with the legend “Profile settings” => inside the fieldset there is a select labeled “Pre fill values with profile”. The only value it has is “Do not use profile”. 4. Change some settings, and set “profile 1” as profile name and click on “Add profile” SUCCESS => The select now has the new profile selected 5. Change profile select to “Do not use profile” SUCCESS => Default values are now displayed in the form 6. Reload the page and upload the file again SUCCESS => the select still has the profile recently added 7. Select the profile, change some parameter in the form and set the profile name to “profile 2”, and click add profile SUCCESS => there are two profiles now, and if you toggle between them, the parameter changes 8. Select profile 1, change one parameter and click on update profile SUCCESS => if you toggle that profile with the other, the new parameter of the value is shown when you select profile 1 9. Select profile 2, change some parameter and click Add profile (leaving the name as profile 2) SUCCESS => the page complains there is another profile with the same name, and asks if you want to replace it. 10. Click on accept SUCCESS => profile 2 now has the new value in the parameter 11. Select profile 2 and change the name to profile 1 SUCCESS => the page complains there is another profile with that name, and asks if you want to replace it 12. Click on accept SUCCESS => in profile select there is only one profile called profile 1 that has the values of profile 2 13. Select profile 1 and click remove profile SUCCESS => there is no profile in profile select. 14. Create a profile and click on “Stage for import” 15. Go to Staged MARC management page SUCCESS => Improt should have the name of the profile in profile column, and when you click on the file name, there should be the name of the profile in the details. 16. prove t/db_dependent/ImportBatch.t t/db_dependent/api/v1/import_batch_profiles.t 17. Sign off Signed-off-by: Abbey Holt -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 4 16:18:03 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jun 2020 14:18:03 +0000 Subject: [Koha-bugs] [Bug 25642] Technical notes are missing from the release In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25642 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |martin.renvoize at ptfs-europe |ity.org |.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jun 4 16:18:22 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jun 2020 14:18:22 +0000 Subject: [Koha-bugs] [Bug 25642] Technical notes are missing from the release In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25642 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org, | |lucas at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 4 16:18:30 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jun 2020 14:18:30 +0000 Subject: [Koha-bugs] [Bug 25642] Technical notes are missing from the release In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25642 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |String patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 4 16:20:48 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jun 2020 14:20:48 +0000 Subject: [Koha-bugs] [Bug 25261] Multiple parts handling - confirmation alert In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25261 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_20_11_target -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 4 16:20:57 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jun 2020 14:20:57 +0000 Subject: [Koha-bugs] [Bug 25349] Enter in the username field submits the login, instead of moving focus to the password field In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25349 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #105533|0 |1 is obsolete| | --- Comment #12 from Lucas Gass --- Created attachment 105556 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105556&action=edit Bug 25349: Add checkEnter function and apply it to SCO page This patch adds the checkEnter function to the OPAC global.js and then applies it to the SCO login page. TO TEST: 1. Go to SCO login and try entering something in the "Login:" input amd "Password:" input. 2. Pressing enter while in either will automatically submit the form. 3. Apply patch. 4. Type something into the Login: field and press enter, the form should NOT submit. 5. Type something into the Password: field and pess enter, this SHOULD submit the form. 6. Change the syspref SelfCheckoutByLogin to 'Cardnumber' 7. Type something into the Please enter your card number: field, the form should submit. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 4 16:32:45 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jun 2020 14:32:45 +0000 Subject: [Koha-bugs] [Bug 25349] Enter in the username field submits the login, instead of moving focus to the password field In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25349 ByWater Sandboxes changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #105556|0 |1 is obsolete| | --- Comment #13 from ByWater Sandboxes --- Created attachment 105557 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105557&action=edit Bug 25349: Add checkEnter function and apply it to SCO page This patch adds the checkEnter function to the OPAC global.js and then applies it to the SCO login page. TO TEST: 1. Go to SCO login and try entering something in the "Login:" input amd "Password:" input. 2. Pressing enter while in either will automatically submit the form. 3. Apply patch. 4. Type something into the Login: field and press enter, the form should NOT submit. 5. Type something into the Password: field and pess enter, this SHOULD submit the form. 6. Change the syspref SelfCheckoutByLogin to 'Cardnumber' 7. Type something into the Please enter your card number: field, the form should submit. Signed-off-by: Donnab -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 4 16:34:18 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jun 2020 14:34:18 +0000 Subject: [Koha-bugs] [Bug 25349] Enter in the username field submits the login, instead of moving focus to the password field In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25349 Donna changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 4 17:09:53 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jun 2020 15:09:53 +0000 Subject: [Koha-bugs] [Bug 24159] Short loan collection issues on a day marked as closed (move useDaysMode to circ rules) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24159 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |18936 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18936 [Bug 18936] Move issuingrules into circulation_rules -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 4 17:09:53 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jun 2020 15:09:53 +0000 Subject: [Koha-bugs] [Bug 18936] Move issuingrules into circulation_rules In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18936 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |24159 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24159 [Bug 24159] Short loan collection issues on a day marked as closed (move useDaysMode to circ rules) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 4 17:15:52 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jun 2020 15:15:52 +0000 Subject: [Koha-bugs] [Bug 25658] Print icon sometimes obscures patron barcode In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25658 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |oleonard at myacpl.org |ity.org | Version|19.11 |master Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jun 4 17:17:52 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jun 2020 15:17:52 +0000 Subject: [Koha-bugs] [Bug 25552] Add missing Claims Returned option to MarkLostItemsAsReturned In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25552 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 4 17:17:56 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jun 2020 15:17:56 +0000 Subject: [Koha-bugs] [Bug 25552] Add missing Claims Returned option to MarkLostItemsAsReturned In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25552 --- Comment #6 from Kyle M Hall --- Created attachment 105558 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105558&action=edit Bug 25552: Mark issue as returned if MarkLostItemsAsReturned, even if not charging a lost fee -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 4 17:25:25 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jun 2020 15:25:25 +0000 Subject: [Koha-bugs] [Bug 25552] Add missing Claims Returned option to MarkLostItemsAsReturned In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25552 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #105558|0 |1 is obsolete| | --- Comment #7 from Kyle M Hall --- Created attachment 105559 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105559&action=edit Bug 25552: Mark issue as returned if MarkLostItemsAsReturned, even if not charging a lost fee -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 4 17:33:34 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jun 2020 15:33:34 +0000 Subject: [Koha-bugs] [Bug 25658] Print icon sometimes obscures patron barcode In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25658 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 4 17:33:37 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jun 2020 15:33:37 +0000 Subject: [Koha-bugs] [Bug 25658] Print icon sometimes obscures patron barcode In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25658 --- Comment #3 from Owen Leonard --- Created attachment 105560 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105560&action=edit Bug 25658: Print icon sometimes obscures patron barcode This patch alters the style of the patron name/cardnumber label on the checkout screen so that it has a maximum width. This will help avoid the label being obscured by the print/close buttons displayed when DisplayClearScreenButton is enabled. To test, apply the patch and rebuild the staff client CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client). - Enable the DisplayClearScreenButton system preference. - Check out to a patron. Resize the browser to confirm that at narrower browser widths the patron name in the checkout form isn't obscured by the print and clear screen buttons. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 4 17:46:47 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jun 2020 15:46:47 +0000 Subject: [Koha-bugs] [Bug 23091] Add options to charge new or restore forgiven overdues when a lost item is returned In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23091 --- Comment #15 from Andrew Fuerste-Henry --- I wrote this test plan: 1- apply patch 2- updatedatabase, restart_all 3- verify finesmode and CalculateFinesOnReturn and WhenLostChargeReplacementFee are on 4- verify WhenLostForgiveFine is set to "Forgive" 5- verify circ rules include fines 6- set Default lost item fee refund on return policy to "Refund lost item charge" 7- create 4 overdue checkouts that will incur fines 8- run fines.pl 9- confirm 4 items checked out with accruing fines 10- confirm all 4 items have a replacement price Item 1 11- mark the first item lost 12- verify that fine is gone and lost fee has been charged 13- check item in 14- verify that lost fee is gone and overdue charge has not returned Item 2 15- set Default lost item fee refund on return policy to "Refund lost item charge and charge new overdue fine" 16- mark second item lost 17- verify that fine is gone and lost fee has been charged 18- check item in 19- verify that lost fee is gone and a new overdue charge has been made Item 3 20- set Default lost item fee refund on return policy to "Refund lost item charge and restore overdue fine" 21- mark second item lost 22- verify that fine is gone and lost fee has been charged 23- check item in 24- verify that lost fee is gone and the old overdue charge has been restored Item 4 25- set Default lost item fee refund on return policy to "Leave lost item charge" 26- mark second item lost 27- verify that fine is gone and lost fee has been charged 28- check item in 29- verify that lost fee remains and the overdue charge is still gone -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 4 17:50:03 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jun 2020 15:50:03 +0000 Subject: [Koha-bugs] [Bug 23091] Add options to charge new or restore forgiven overdues when a lost item is returned In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23091 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #16 from Andrew Fuerste-Henry --- On step 18 of my plan above, I got this error: "Unknown error code LostItemFeeCharged at /kohadevbox/koha/circ/returns.pl line 538" Other thoughts: - I like the general structure here. where you've chosen to put this setting makes sense - What happens if my accruing fine has been fully/partially written off or paid? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 4 17:53:52 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jun 2020 15:53:52 +0000 Subject: [Koha-bugs] [Bug 23091] Add options to charge new or restore forgiven overdues when a lost item is returned In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23091 --- Comment #17 from Andrew Fuerste-Henry --- It occurs to me that we're not giving any option to keep the lost fee and restore / recharge the overdue. I don't think anyone needs to do so, but raising it here in case someone wants to make the case. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 4 17:54:33 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jun 2020 15:54:33 +0000 Subject: [Koha-bugs] [Bug 24003] REST API basic auth lacks C4::Context->userenv In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24003 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|lari.taskula at hypernova.fi |tomascohen at gmail.com CC| |tomascohen at gmail.com Severity|enhancement |major Resolution|WONTFIX |--- Status|RESOLVED |REOPENED Version|unspecified |master --- Comment #4 from Tomás Cohen Arazi --- There's been big changes on the API front, but it is not clear when we will be able to make a clean transition into using Mojolicious for all controlling code and thus making the stash accessible to Koha::* classes. That said, I'm taking over this bug, and will make it take care of setting userenv on every authentication method, as we are now seeing action_logs with no borrowernumber responsible for changes that happen in the API. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 4 17:54:47 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jun 2020 15:54:47 +0000 Subject: [Koha-bugs] [Bug 24003] REST API should set C4::Context->userenv In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24003 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|REST API basic auth lacks |REST API should set |C4::Context->userenv |C4::Context->userenv -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 4 18:23:30 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jun 2020 16:23:30 +0000 Subject: [Koha-bugs] [Bug 25675] System preference PatronSelfRegistration incorrectly described In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25675 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jun 4 18:23:32 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jun 2020 16:23:32 +0000 Subject: [Koha-bugs] [Bug 25675] System preference PatronSelfRegistration incorrectly described In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25675 --- Comment #1 from Andrew Fuerste-Henry --- Created attachment 105561 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105561&action=edit Bug 25675: Reword and reorganize sysprefs related to patron self modification To Test: 1: apply patch 2: restart all 3: go to System Preferences > OPAC 4: confirm "Self registration" section is now labeled "Self registration and modification" 5: confirm OPACPatronDetails is now in the "Self registration and modification" section 6: confirm PatronSelfRegistration now reads "(Allow / Don't allow) library patrons to register for an account via the OPAC." 7: set OPACPatronDetails to Don't allow 8: set PatronSelfRegistration to Allow 9: log into the opac and verify you're not able to edit your patron details on an existing account -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 4 18:24:01 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jun 2020 16:24:01 +0000 Subject: [Koha-bugs] [Bug 25675] System preference PatronSelfRegistration incorrectly described In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25675 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |andrew at bywatersolutions.com |ity.org | Version|19.11 |master CC| |andrew at bywatersolutions.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 4 18:36:38 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jun 2020 16:36:38 +0000 Subject: [Koha-bugs] [Bug 25676] Staff client catalog search shows incorrect item status under location In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25676 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrew at bywatersolutions.com --- Comment #2 from Andrew Fuerste-Henry --- Looking at Joe's site, this seems to be particular to items that are set to itemlost=1 (which should show "Lost") but are also still checked out. select biblionumber from items where onloan is not null and itemlost=1 Bibs listed in this report display "long overdue" as Joe has described. select biblionumber from items where onloan is null and itemlost=1 Bibs listed in this report show "Lost" as they should -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 4 19:01:45 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jun 2020 17:01:45 +0000 Subject: [Koha-bugs] [Bug 25675] System preference PatronSelfRegistration incorrectly described In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25675 ByWater Sandboxes changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #105561|0 |1 is obsolete| | --- Comment #2 from ByWater Sandboxes --- Created attachment 105562 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105562&action=edit Bug 25675: Reword and reorganize sysprefs related to patron self modification To Test: 1: apply patch 2: restart all 3: go to System Preferences > OPAC 4: confirm "Self registration" section is now labeled "Self registration and modification" 5: confirm OPACPatronDetails is now in the "Self registration and modification" section 6: confirm PatronSelfRegistration now reads "(Allow / Don't allow) library patrons to register for an account via the OPAC." 7: set OPACPatronDetails to Don't allow 8: set PatronSelfRegistration to Allow 9: log into the opac and verify you're not able to edit your patron details on an existing account Signed-off-by: DonnaB -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 4 19:02:07 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jun 2020 17:02:07 +0000 Subject: [Koha-bugs] [Bug 25675] System preference PatronSelfRegistration incorrectly described In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25675 Donna changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 4 19:22:53 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jun 2020 17:22:53 +0000 Subject: [Koha-bugs] [Bug 24003] REST API should set C4::Context->userenv In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24003 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|REOPENED |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 4 19:34:10 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jun 2020 17:34:10 +0000 Subject: [Koha-bugs] [Bug 25309] Unable to save patron if streetnumber is too long In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25309 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |victor at tuxayo.net --- Comment #10 from Victor Grousset/tuxayo --- Can't be backported to 19.05.x due to dependence on bug 25311. So if someone is interested in this bug being backported to 19.05.x, send help to bug 25311 ^^ -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 4 20:18:50 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jun 2020 18:18:50 +0000 Subject: [Koha-bugs] [Bug 25469] Typo: Item does not belongs to your library In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25469 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED --- Comment #1 from Owen Leonard --- Does anyone know how to create the circumstance under which the typo is shown? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 4 20:27:22 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jun 2020 18:27:22 +0000 Subject: [Koha-bugs] [Bug 25213] Notify reporter when an OPAC problem is resolved In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25213 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard at myacpl.org |koha-bugs at lists.koha-commun | |ity.org Summary|It would be beneficial to |Notify reporter when an |be able to notify the |OPAC problem is resolved |patron of a resolution | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jun 4 20:43:50 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jun 2020 18:43:50 +0000 Subject: [Koha-bugs] [Bug 25677] New: Checkbox options for EDI accounts cannot be enabled Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25677 Bug ID: 25677 Summary: Checkbox options for EDI accounts cannot be enabled Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Acquisitions Assignee: koha-bugs at lists.koha-community.org Reporter: kyle at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org Checking any of the checkboxes in the EDI Account editor does nothing. They always remain set to "off". -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jun 4 20:43:53 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jun 2020 18:43:53 +0000 Subject: [Koha-bugs] [Bug 25677] Checkbox options for EDI accounts cannot be enabled In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25677 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |kyle at bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 4 20:48:55 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jun 2020 18:48:55 +0000 Subject: [Koha-bugs] [Bug 25677] Checkbox options for EDI accounts cannot be enabled In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25677 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 4 20:48:58 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jun 2020 18:48:58 +0000 Subject: [Koha-bugs] [Bug 25677] Checkbox options for EDI accounts cannot be enabled In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25677 --- Comment #1 from Kyle M Hall --- Created attachment 105563 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105563&action=edit Bug 25677 - Checkbox options for EDI accounts cannot be enabled Checking any of the checkboxes in the EDI Account editor does nothing. They always remain set to "off". Test Plan: 1) Browse to edi_accounts.pl 2) Create a new EDI account, check all the checkboxes 3) Edit the account, note none of the checkboxes are checked 4) Apply this patch 5) Repeat steps 1-2 6) Note the checkboxes remain checked -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 4 21:24:43 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jun 2020 19:24:43 +0000 Subject: [Koha-bugs] [Bug 25657] Import Patron fails without userid - not stated as required field in notes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25657 --- Comment #5 from Elaine Bradtke --- We have two instances of Koha, they are supposed to be identical (one test, one production) I always do large imports in test first. The problem seems to be in the test site, I just successfully imported into production the same patron data that failed in test. I'll have a word with our tech person as to what differences there are, aside from being on two different cloud servers. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 4 21:41:34 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jun 2020 19:41:34 +0000 Subject: [Koha-bugs] [Bug 25677] Checkbox options for EDI accounts cannot be enabled In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25677 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 4 21:41:36 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jun 2020 19:41:36 +0000 Subject: [Koha-bugs] [Bug 25677] Checkbox options for EDI accounts cannot be enabled In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25677 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #105563|0 |1 is obsolete| | --- Comment #2 from Andrew Fuerste-Henry --- Created attachment 105564 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105564&action=edit Bug 25677 - Checkbox options for EDI accounts cannot be enabled Checking any of the checkboxes in the EDI Account editor does nothing. They always remain set to "off". Test Plan: 1) Browse to edi_accounts.pl 2) Create a new EDI account, check all the checkboxes 3) Edit the account, note none of the checkboxes are checked 4) Apply this patch 5) Repeat steps 1-2 6) Note the checkboxes remain checked Signed-off-by: Andrew Fuerste-Henry -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 5 01:37:19 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jun 2020 23:37:19 +0000 Subject: [Koha-bugs] [Bug 22417] Add a task queue In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22417 --- Comment #57 from David Cook --- (In reply to Jonathan Druart from comment #56) > Can we dedicate this bug report to the base idea, then create bug report on > top of it for experiment? I'd like to avoid noise for testers and keep the > comment list easy to follow. Sounds like a plan, boss man 👍 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 5 01:45:28 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jun 2020 23:45:28 +0000 Subject: [Koha-bugs] [Bug 25674] Add RabbitMQ options to koha-create In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25674 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au --- Comment #1 from David Cook --- I'm wondering if we should put connection information (ie hostname, port, username, password, vhost) in koha-conf.xml or have a dedicated file. I feel like koha-conf.xml is simpler for the developer, but a dedicated file would be easier for a sysadmin/operations. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 5 01:45:35 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 04 Jun 2020 23:45:35 +0000 Subject: [Koha-bugs] [Bug 25674] Add RabbitMQ options to koha-create In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25674 --- Comment #2 from David Cook --- I feel like this is also the right bug report for discussing virtual hosts VS instance-prefixed queue names. (Virtual hosts add sysadmin/operations overhead, but offers a better logical separation message data.) (Note that I haven't found a public method for deleting RabbitMQ queues. Deleting a virtual host might be easier from a RabbitMQ cleanup perspective.) I think requiring a sysadmin to set up RabbitMQ isn't necessarily a deal breaker, so long as we have appropriate error-handling and alert Koha admin users that they can't use certain functionality until RabbitMQ has been properly configured. This is my current inclination. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 5 02:29:38 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Jun 2020 00:29:38 +0000 Subject: [Koha-bugs] [Bug 25586] Something wrong with KOHA_HOME (?) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25586 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au --- Comment #4 from David Cook --- I was wondering what KOHA_HOME was about yesterday... Maybe KOHA_HOME should be set to "/usr/share/koha" only if KOHA_HOME is unset. Then in kohadevbox and koha-testing-docker, an environmental variable can be set to a dev install location? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 5 02:36:00 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Jun 2020 00:36:00 +0000 Subject: [Koha-bugs] [Bug 23690] During checkout, window hangs with a pop up "Loading...you may continue scanning." In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23690 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au --- Comment #3 from David Cook --- There is a problem related to this but the original description isn't clear enough... -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 5 02:40:34 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Jun 2020 00:40:34 +0000 Subject: [Koha-bugs] [Bug 25678] New: Checkout stuck "Loading... you may continue scanning" because of Javascript error Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25678 Bug ID: 25678 Summary: Checkout stuck "Loading... you may continue scanning" because of Javascript error Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Circulation Assignee: koha-bugs at lists.koha-community.org Reporter: dcook at prosentient.com.au QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com checkouts.js creates fatal Javascript errors when it tries to run "escapeHtml()" on null values. This typically happens when a title or some other data element is null. That said, in theory many of these data elements shouldn't be null. But... we shouldn't be dying on Javascript errors either. We should catch the condition and do something about it. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Jun 5 02:40:41 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Jun 2020 00:40:41 +0000 Subject: [Koha-bugs] [Bug 25678] Checkout stuck "Loading... you may continue scanning" because of Javascript error In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25678 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=23690 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 5 02:40:41 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Jun 2020 00:40:41 +0000 Subject: [Koha-bugs] [Bug 23690] During checkout, window hangs with a pop up "Loading...you may continue scanning." In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23690 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=25678 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 5 02:47:01 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Jun 2020 00:47:01 +0000 Subject: [Koha-bugs] [Bug 25679] New: If no value is set in the system preference NoIssueCharge, Odd Yellow Box appears Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25679 Bug ID: 25679 Summary: If no value is set in the system preference NoIssueCharge, Odd Yellow Box appears Change sponsored?: --- Product: Koha Version: 19.11 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs at lists.koha-community.org Reporter: kelly at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com If a library does not set the system preference, NoIssueCharge- by leaving this blank. Koha will not checkout items to any patrons who owe any amount of money. The alert box (yellow) will display and give no words on what the error is. Can we add wording to the system preference that a dollar amount should be in this system preference and also, have the Yellow alert box indicate some notation about the error. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Jun 5 03:03:59 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Jun 2020 01:03:59 +0000 Subject: [Koha-bugs] [Bug 23808] Creating Child Guarantee doesn't populate Guarantor Information In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23808 --- Comment #28 from Nick Clemens --- Created attachment 105565 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105565&action=edit Bug 23808: [19.11.x] Pre-fill guarantor fields when adding guarantee to guarantor Bug 14570 removed the guarantor pre-fill functionality when selecting 'Add guarantee' to an Adult patron. This is because guarantor information would now only display if (1) the patron record exists (which it won't when first adding guarantee to guarantor record) and (2) if there is already a guarantor added to a guarantee This patchfix will pre-fill guarantor fields and address fields (so the guarantee has the same address as the guarantor) if no relationship (existing guarantor data exists) and a guarantor_id is handed to memberenty.pl in URL when clicking 'Add guarantee' button on Adults patron record. Test plan: 1. Add adult patron make sure to fill in their 'Main address' details 2. Select 'Add guarantee' 3. Observe no details of the adult patron are displaying in the 'Guarantor information' section or 'Main address' sections of memberentry.pl 4. Select 'Search to add', search for your adult patron and choose 'Select' to add them as guarantor 5. Fill out rest of memberentry.pl and 'Save' 6. Observe adult is showing as the guarantor 7. Apply patch 8. Run tests: sudo koha-shell prove xt prove t 9. Confirm tests pass 10. Return to your adult patron 11. Select 'Add guarantee' 12. Observe in 'Guarantor information' and 'Main address' sections of memberentry.pl are pre-filled with the 'patron #' (borrowernumber), surname, firstname and street number, address, address2 (if you filled that in on adults account), city 13. Fill out the rest of memberenty.pl and save and confirm your adult patron is showing as the guarantor and the pre-filled address details have been saved and are showing 14. Repeat steps 10,11 and 12 and in the 'Guarantor information' select 'Search to add' and add another adult as guarantor 15. Fill out the rest of memberentry.pl and 'Save' and notice with this patch applied you can still add multiple guarantors successfully Sponsored-By: South Taranaki District Council, NZ Signed-off-by: Andrew Fuerste-Henry Signed-off-by: George Veranis Followed the test plan, works as expected. The only failure was t/DateUtils.t test which will be fixed by Bug 24850. Also corrected a small typo in the sponsored-by trailer. Signed-off-by: Kyle M Hall Bug 23808: (follow-up) Display card number in 'Guarantor information' in memberentry.pl Instead of displaying 'Patron #' and displaying the guarantor's borrowernumber in 'Guarantor information' we should display 'Patron card number:' with the cardnumber displayed as that value is more meaningful to librarians. The hyperlink containing the borrowernumber should stay the same so that librarians can easily visit the patron record of existing guarantor patrons. Test plan: 1. Apply first patch and follow it's test plan 2. On an Adult patrons record select 'Add guarantee' 3. In 'Guarantor information' section of memberentry.pl observe in the pre-filled guarantor information there is a line 'Patron #:' with a link displaying a borrowernumber (not card number) and when you click on the link it takes you to the adult/guarantors patron account 4. Select 'Search to add' and search and add another guarantor 5. Observe in the added guarantor 'Patron #:' is displayed along with the borrowernumber (not card number). The borrowernumber displayed in not a link. 6. Apply this patch 7. On a adults patron select 'Add guarantee' 8. Observe in 'Guarantor information' section the pre-filled guarantor now has 'Patron card number:' displayed (instead of 'Patron #:', and it's link now displays the guarantors cardnumber. Clicking on the link still takes you to the guarantors patron account 9. Repeat step 4 10. Observe in the added guarantor they also have 'Patron card number:' (instead of 'Patron #:'). A cardnumber rather than borrowernumber is displayed. The cardnumber is not a link. 11. Confirm tests still pass: sudo koha-shell prove xt prove t Sponsored-by: South Taranaki District Council, NZ Signed-off-by: Andreas Roussos Signed-off-by: Kyle M Hall Bug 23808: (follow-up) Pre-fill guarantee's contact details from guarantor patron in memberentry.pl Pre-fill guarantee contact details (email, phone) from guarantor record when adding a gurantee to a guarantor's record Test plan: 1. Apply first two patches and follow test plans 2. On an adult's patron record (which has an primary phone number, secondary phone, other phone, primary email, secondary email and fax set) select 'Add a guarantee' and observe the guarantee's 'Contact' section is not pre-filled with that information from the guarantor 3. Apply this patch 4. On the same adult's record select 'Add a guarantee' and observe that the 'Primary phone', 'Secondary phone', 'Other phone', 'Primary email', 'Secondary email', 'Fax' have been pre-filled from the guarantor's record 5. Fill out the rest of the memberentry.pl and 'Save' and observe that those contact details are successfully saved 6. Repeat step 4 and alter the 'Primary phone' and 'Primary email' fields and save and observe that those altered values are saved 7. Run tests and confirm they pass: sudo koha-shell prove xt prove t Sponsored-by: South Taranaki District Council, NZ Signed-off-by: Andreas Roussos Signed-off-by: Kyle M Hall Bug 23808: (follow-up) Object methods can be used directly, no need for unblessed Signed-off-by: Kyle M Hall fix tabs -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 5 07:37:57 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Jun 2020 05:37:57 +0000 Subject: [Koha-bugs] [Bug 20554] New OPAC CSS In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20554 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au --- Comment #55 from David Cook --- By the way, fontfaceobserver.min.js is getting flagged as the Miner.Jswebcoin virus by Symantec Endpoint Protection. It says that Symantec have had it flagged for more than 1 year, and that the file is untrustworthy. I have examined the Javascript, and it really appears to be a false positive, but I'm noting it here anyway. I'm going to look at removing fontfaceobserver locally so that it can pass security checks for the time being. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 5 09:35:30 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Jun 2020 07:35:30 +0000 Subject: [Koha-bugs] [Bug 25587] JavaScript issue - "clear" button doesn't reset some dropdowns In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25587 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #105285|0 |1 is obsolete| | --- Comment #4 from Julian Maurice --- Created attachment 105566 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105566&action=edit Bug 25587: fix for "clear" button to reset all selects Button "clear" on cgi-bin/koha/admin/smart-rules.pl did not reset fields with a dropdown selector except the first one. This happens because jQuery selector .find("select option:first") in koha-tmpl/intranet-tmpl/prog/en/modules/admin/smart-rules.tt selects only single first element in the whole group, as from jquery doc: > The :first pseudo-class is equivalent to :eq( 0 ). It could also be > written as :lt( 1 ). While this matches only a single element, > :first-child can match more than one: One for each parent. > (https://api.jquery.com/first-selector/) And it works if replaced by: .find("select option:first-child") To reproduce: 1) Go to /cgi-bin/koha/admin/smart-rules.pl 2) Start editing one of existing rules or filling a new one, change all selects to have non-first option selected. Fill text input fields with sample data. 3) Reset all fields with the "clear" button. 4) Observe that only the first dropdown field was reset to the first option while all others still contain previously given values, meanwhile all text input fields are cleared as expected. 5) Apply the patch. 6) Repeat steps 1, 2 and 3. 7) Check that all dropdown fields were reset to first option, as expected. Mentored-by: Andrew Nugged Signed-off-by: Lucas Gass Signed-off-by: Julian Maurice -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 5 09:35:44 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Jun 2020 07:35:44 +0000 Subject: [Koha-bugs] [Bug 25587] JavaScript issue - "clear" button doesn't reset some dropdowns In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25587 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |julian.maurice at biblibre.com Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 5 09:47:21 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Jun 2020 07:47:21 +0000 Subject: [Koha-bugs] [Bug 25273] Elasticsearch Authority matching is returning too many results In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25273 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |julian.maurice at biblibre.com --- Comment #10 from Julian Maurice --- Hi Nick, (In reply to Nick Clemens from comment #9) > This may work in this simpler case, however, specifying the fields generates > them in a fixed order, and authorities order can differ and has different > meanings Can you provide a test plan with a complex case, which cannot be solved using configuration only ? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 5 10:09:54 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Jun 2020 08:09:54 +0000 Subject: [Koha-bugs] [Bug 23091] Add options to charge new or restore forgiven overdues when a lost item is returned In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23091 --- Comment #18 from Martin Renvoize --- (In reply to Andrew Fuerste-Henry from comment #16) > On step 18 of my plan above, I got this error: > "Unknown error code LostItemFeeCharged at /kohadevbox/koha/circ/returns.pl > line 538" Good catch, I forgot to add the template handling in there. > Other thoughts: > - I like the general structure here. where you've chosen to put this setting > makes sense > - What happens if my accruing fine has been fully/partially written off or > paid? Glad you asked this, as I started to ask the same question myself.. The existing code prior to this patch writes off/forgives any outstanding debt on the overdue as opposed to the original amount of the debt.. so if the patron has already paid or partially paid the accruing fine prior to reporting the item as lost then only the outstanding debt will be forgiven. I'm not sure that logic makes sense to start with but didn't want to change it here as it probably warrants another discussion. This patch uses the actual forgiven credit line to restore the outstanding amount.. so if there as a partial payment then we only restore the previously unpaid part of the debt. Hope that makes sense. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 5 10:21:01 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Jun 2020 08:21:01 +0000 Subject: [Koha-bugs] [Bug 23091] Add options to charge new or restore forgiven overdues when a lost item is returned In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23091 --- Comment #19 from Martin Renvoize --- Created attachment 105567 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105567&action=edit Bug 23091: Add template handling for new messages This patch adds handling for the display of the two new messages added by this patchset in the returns screen. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 5 10:21:19 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Jun 2020 08:21:19 +0000 Subject: [Koha-bugs] [Bug 23091] Add options to charge new or restore forgiven overdues when a lost item is returned In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23091 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 5 10:22:04 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Jun 2020 08:22:04 +0000 Subject: [Koha-bugs] [Bug 23091] Add options to charge new or restore forgiven overdues when a lost item is returned In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23091 --- Comment #20 from Martin Renvoize --- Final patch corrects the error Andrew was running into.. the wording of the output messages could perhaps be improved; I am open to suggestions ;) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 5 10:23:05 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Jun 2020 08:23:05 +0000 Subject: [Koha-bugs] [Bug 23091] Add options to charge new or restore forgiven overdues when a lost item is returned In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23091 --- Comment #21 from Martin Renvoize --- (In reply to Andrew Fuerste-Henry from comment #17) > It occurs to me that we're not giving any option to keep the lost fee and > restore / recharge the overdue. I don't think anyone needs to do so, but > raising it here in case someone wants to make the case. I wondered about this case too.. but as those that had commented to date had only brought up the two cases I have dealt with here I felt we could perhaps leave such handling for another bug if someone wishes to raise it. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 5 10:33:37 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Jun 2020 08:33:37 +0000 Subject: [Koha-bugs] [Bug 17842] Broken diacritics on records exported as MARC from cart In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17842 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #105440|0 |1 is obsolete| | --- Comment #49 from Julian Maurice --- Created attachment 105568 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105568&action=edit Bug 17842: UTF-8 encode ISO2709 MARC download from cart The cart was outputing ISO2709 MARC records with Latin-1 encoding. Records containing non-latin1 characters were automatically re-encoded as UTF-8 by browsers, which led to inconsistent character encodings for downloaded MARC files. This patch explicitly encodes ISO2709 MARC characters from the cart download as UTF-8 encoded bytes, which resolves the problem. Test Plan: 0) Don't apply patch 1) Create bib record with only ASCII characters 2) Add a ü character to the title 3) Save bib record 4) Download bib record from cart (opac and staff client) 5) Using xxd or some other program, note that the ü is represented by a FC byte (latin-1 encoded) 6) Apply the patch 7) Download bib record from cart (opac and staff client) 8) Using xxd or some other program, note that the ü is represented by C3 BC bytes (utf-8 encoded) 9) Success (Note that you could potentially use Notepad++ or some other program to open the downloaded file and just note the encoding that it finds. You could also try "chardetect" instead. Lots of options for figuring out the encoding.) Signed-off-by: Victor Grousset/tuxayo Signed-off-by: Julian Maurice -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 5 10:33:40 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Jun 2020 08:33:40 +0000 Subject: [Koha-bugs] [Bug 17842] Broken diacritics on records exported as MARC from cart In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17842 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #105481|0 |1 is obsolete| | --- Comment #50 from Julian Maurice --- Created attachment 105569 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105569&action=edit Bug 17842: Simplify the code There is no need for all the conditions. >From Encode::encode POD: "If the $string is undef, then undef is returned." Signed-off-by: Julian Maurice -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 5 10:35:26 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Jun 2020 08:35:26 +0000 Subject: [Koha-bugs] [Bug 17842] Broken diacritics on records exported as MARC from cart In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17842 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |julian.maurice at biblibre.com --- Comment #51 from Julian Maurice --- (In reply to David Cook from comment #47) > (In reply to Jonathan Druart from comment #46) > > I think the whole block could be: > > > > $output .= encode("UTF-8", $record->as_usmarc()) // q{}; > > > > From Encode::encode POD: > > "If the $string is undef, then undef is returned." > > Personally, I don't like putting method output directly into another > function call, as it can make exception handling harder. I don't like it either, but it should be harmless in this particular case. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 5 10:39:32 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Jun 2020 08:39:32 +0000 Subject: [Koha-bugs] [Bug 25322] Adding a guarantor with no relationship defaults to father In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25322 Alex Arnaud changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |alex.arnaud at biblibre.com |y.org | CC| |alex.arnaud at biblibre.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 5 10:40:53 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Jun 2020 08:40:53 +0000 Subject: [Koha-bugs] [Bug 25653] Authorities search does not retain selection In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25653 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #105495|0 |1 is obsolete| | --- Comment #3 from Julian Maurice --- Created attachment 105570 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105570&action=edit Bug 25653: Update tab selector to use 'active' and include all options It looks like the functionality was broken when ui tabs were upgraded and mainmainentry was added To test: 1 - Browse to Authorities 2 - Search in each tab 3 - Note all search results revert to 'Search main heading a only' 4 - Apply patch 5 - Note selection is retained after search Signed-off-by: Claire Gravely Signed-off-by: Julian Maurice -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 5 10:41:54 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Jun 2020 08:41:54 +0000 Subject: [Koha-bugs] [Bug 25678] Checkout stuck "Loading... you may continue scanning" because of Javascript error In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25678 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |DUPLICATE CC| |jonathan.druart at bugs.koha-c | |ommunity.org Status|NEW |RESOLVED --- Comment #1 from Jonathan Druart --- *** This bug has been marked as a duplicate of bug 25293 *** -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Jun 5 10:41:54 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Jun 2020 08:41:54 +0000 Subject: [Koha-bugs] [Bug 25293] Don't call escapeHtml on null In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25293 --- Comment #6 from Jonathan Druart --- *** Bug 25678 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 5 10:42:34 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Jun 2020 08:42:34 +0000 Subject: [Koha-bugs] [Bug 25653] Authorities search does not retain selection In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25653 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |julian.maurice at biblibre.com Status|Signed Off |Passed QA --- Comment #4 from Julian Maurice --- THANK YOU! :) This bug was so annoying... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 5 10:43:29 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Jun 2020 08:43:29 +0000 Subject: [Koha-bugs] [Bug 25293] Don't call escapeHtml on null In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25293 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #7 from Jonathan Druart --- (In reply to David Cook from comment #5) > I usually encounter this issue because of the Keyword To MARC mapping > removal, which caused some really bad Koha to MARC mappings in the biblio. > > It caused a lot of problems for us. So, sign it off? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 5 10:46:18 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Jun 2020 08:46:18 +0000 Subject: [Koha-bugs] [Bug 25680] New: When adding a new patron and missing to fill a field, on saving, the invalidFocus should show the focused field clearly in view. Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25680 Bug ID: 25680 Summary: When adding a new patron and missing to fill a field, on saving, the invalidFocus should show the focused field clearly in view. Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Patrons Assignee: koha-bugs at lists.koha-community.org Reporter: timothy_alexis.vass at ub.lu.se QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com Created attachment 105571 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105571&action=edit Expected result: The focused field being clearly in view. Steps to reproduce: login: demo password: demo - http://koha.adminkuhn.ch:8080/cgi-bin/koha/members/memberentry.pl?op=add&categorycode=K - Fill in Surname and Save. Result: Focus is set on input with id="cardnumber". Bug: The object is out of view. Expected result: The focused field being clearly in view. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Jun 5 10:49:56 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Jun 2020 08:49:56 +0000 Subject: [Koha-bugs] [Bug 25322] Adding a guarantor with no relationship defaults to father In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25322 --- Comment #21 from Jonathan Druart --- QA, please test with "|father|mother" in the syspref. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 5 11:07:32 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Jun 2020 09:07:32 +0000 Subject: [Koha-bugs] [Bug 25369] IntranetCoce not displaying Cover Images on Staff Client In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25369 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |18421 CC| |jonathan.druart at bugs.koha-c | |ommunity.org Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18421 [Bug 18421] Make Coce cover images available for staff search -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Jun 5 11:07:32 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Jun 2020 09:07:32 +0000 Subject: [Koha-bugs] [Bug 18421] Make Coce cover images available for staff search In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18421 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |25369 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25369 [Bug 25369] IntranetCoce not displaying Cover Images on Staff Client -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 5 11:14:34 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Jun 2020 09:14:34 +0000 Subject: [Koha-bugs] [Bug 7757] Edit basket vendor after it has been created In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7757 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |25611 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25611 [Bug 25611] Changing the vendor when creating the Basket does not keep that new vendor. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 5 11:14:34 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Jun 2020 09:14:34 +0000 Subject: [Koha-bugs] [Bug 25611] Changing the vendor when creating the Basket does not keep that new vendor. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25611 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org Status|NEW |ASSIGNED Assignee|koha-bugs at lists.koha-commun |jonathan.druart at bugs.koha-c |ity.org |ommunity.org Depends on| |7757 --- Comment #1 from Jonathan Druart --- Looks like a super old bug, good catch! Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7757 [Bug 7757] Edit basket vendor after it has been created -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 5 11:17:16 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Jun 2020 09:17:16 +0000 Subject: [Koha-bugs] [Bug 25322] Adding a guarantor with no relationship defaults to father In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25322 --- Comment #22 from Alex Arnaud --- Agree with Andrew and Jonathan. "|father|mother" in borrowerRelationship syspref allows to save unspecified relationship. As the main issue described here is "If no relationship is specified, then it ought not to be populate", i have to say that i don't find any bug. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 5 11:18:18 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Jun 2020 09:18:18 +0000 Subject: [Koha-bugs] [Bug 25611] Changing the vendor when creating the Basket does not keep that new vendor. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25611 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 5 11:18:20 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Jun 2020 09:18:20 +0000 Subject: [Koha-bugs] [Bug 25611] Changing the vendor when creating the Basket does not keep that new vendor. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25611 --- Comment #2 from Jonathan Druart --- Created attachment 105572 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105572&action=edit Bug 25611: Use selected vendor when creating a basket We did not take into account the vendor selected. Test plan: 1. Choose Vendor 2. Create Basket 3. Assign a new vendor Without the patch this new vendor is not changed With the patch applied the vendor is changed 4. Edit the basket, change the vendor -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 5 11:19:41 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Jun 2020 09:19:41 +0000 Subject: [Koha-bugs] [Bug 11317] Add a way to access files from the intranet In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11317 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |Manual -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 5 11:20:41 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Jun 2020 09:20:41 +0000 Subject: [Koha-bugs] [Bug 25322] Adding a guarantor with no relationship defaults to father In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25322 --- Comment #23 from Alex Arnaud --- However, it may not be very clear for users to set the syspref with an empty value. I would agree with a patch allowing empty value with the same in the syspref -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 5 11:21:22 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Jun 2020 09:21:22 +0000 Subject: [Koha-bugs] [Bug 25322] Adding a guarantor with no relationship defaults to father In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25322 --- Comment #24 from Alex Arnaud --- (In reply to Alex Arnaud from comment #23) > I would agree with a patch allowing empty value with the same in the syspref Without** the same in the syspref -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 5 11:25:39 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Jun 2020 09:25:39 +0000 Subject: [Koha-bugs] [Bug 25037] Add checkout_type to checkouts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25037 --- Comment #59 from Joonas Kylmälä --- Comment on attachment 104268 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104268 Bug 25037: Replace occurences to issues.onsite_checkout Review of attachment 104268: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=25037&attachment=104268) ----------------------------------------------------------------- I checked all the other patches and they were looking good! ::: api/v1/swagger/definitions/checkout.json @@ +53,5 @@ > "description": "Date the item was issued" > }, > + "checkout_type": { > + "type": ["string", "null"], > + "description": "Checkout type, an authorised value under CHECKOUT_TYPE category" The description is still from the v1 version where authorized values were used. Could you here a) add enum for values "CHECKOUT" and "ONSITE" and b) update the description. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 5 11:25:48 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Jun 2020 09:25:48 +0000 Subject: [Koha-bugs] [Bug 25037] Add checkout_type to checkouts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25037 Joonas Kylmälä changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |joonas.kylmala at helsinki.fi Status|Needs Signoff |Failed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 5 11:38:25 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Jun 2020 09:38:25 +0000 Subject: [Koha-bugs] [Bug 25680] When adding a new patron and missing to fill a field, on saving, the invalidFocus should show the focused field clearly in view. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25680 --- Comment #1 from Timothy Alexis Vass --- $("#entryform").validate({ focusInvalid: false, invalidHandler: function(form, validator) { var errors = validator.numberOfInvalids(); if (errors) { window.scrollTo(0, 0); validator.errorList[0].element.focus(); window.scrollBy(0,$(window).height()/1.618); } }, This will set the element at the "golden section" in the window. Can anyone think of a simpler way to do it? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Jun 5 11:39:14 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Jun 2020 09:39:14 +0000 Subject: [Koha-bugs] [Bug 23942] After upgrading koha from version 16.5 to 18.11 itemtype, itype and other list boxes corresponding to authorised values attached to frameworks fail to show the selected values upon editing the bib and item records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23942 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |INVALID --- Comment #3 from Jonathan Druart --- Did you try the script? I am closing this, please reopen if it is still valid. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 5 11:39:47 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Jun 2020 09:39:47 +0000 Subject: [Koha-bugs] [Bug 25680] When adding a new patron and missing to fill a field, on saving, the invalidFocus should show the focused field clearly in view. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25680 --- Comment #2 from Timothy Alexis Vass --- Above code is in koha-tmpl/intranet-tmpl/prog/js/members.js -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 5 11:42:23 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Jun 2020 09:42:23 +0000 Subject: [Koha-bugs] [Bug 25322] Adding a guarantor with no relationship defaults to father In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25322 --- Comment #25 from Jonathan Druart --- Can we agree on this? * If the pref does not contain an empty entry then we add a preselected empty value in the dropdown list and make it mandatory * If the pref contain an empty entry ("|father|mother"), then we make it optional. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 5 11:43:52 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Jun 2020 09:43:52 +0000 Subject: [Koha-bugs] [Bug 25586] Something wrong with KOHA_HOME (?) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25586 Joonas Kylmälä changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |joonas.kylmala at helsinki.fi Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Jun 5 11:44:24 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Jun 2020 09:44:24 +0000 Subject: [Koha-bugs] [Bug 25586] Something wrong with KOHA_HOME (?) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25586 Joonas Kylmälä changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 5 11:44:29 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Jun 2020 09:44:29 +0000 Subject: [Koha-bugs] [Bug 25586] Something wrong with KOHA_HOME (?) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25586 Joonas Kylmälä changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #105552|0 |1 is obsolete| | --- Comment #5 from Joonas Kylmälä --- Created attachment 105573 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105573&action=edit Bug 25586: (bug 25618 follow-up) Use KOHA_HOME to guess pkg bin dir Signed-off-by: Joonas Kylmälä -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 5 11:45:14 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Jun 2020 09:45:14 +0000 Subject: [Koha-bugs] [Bug 25586] Something wrong with KOHA_HOME (?) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25586 --- Comment #6 from Jonathan Druart --- (In reply to David Cook from comment #4) > I was wondering what KOHA_HOME was about yesterday... > > Maybe KOHA_HOME should be set to "/usr/share/koha" only if KOHA_HOME is > unset. > > Then in kohadevbox and koha-testing-docker, an environmental variable can be > set to a dev install location? We already have 'dev_install' and 'intranetdir' in koha-conf. I don't think adding more variables will help. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 5 11:47:59 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Jun 2020 09:47:59 +0000 Subject: [Koha-bugs] [Bug 25586] Something wrong with KOHA_HOME (?) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25586 Joonas Kylmälä changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |In Discussion -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Jun 5 11:56:27 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Jun 2020 09:56:27 +0000 Subject: [Koha-bugs] [Bug 25586] Something wrong with KOHA_HOME (?) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25586 --- Comment #7 from Joonas Kylmälä --- KOHA_HOME is the place where intranetdir code is placed, I got this with grep: > koha-functions.sh: KOHA_HOME=$(run_safe_xmlstarlet $instancename intranetdir) So using KOHA_HOME is favourable in my opinion to be able to support installations with different installation paths. The user should be able to change only the paths in koha-conf.xml and stuff should work, now without this variable things don't work so the original patch should be extended to include also koha-plack and maybe other scripts. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Jun 5 11:58:56 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Jun 2020 09:58:56 +0000 Subject: [Koha-bugs] [Bug 25586] Something wrong with KOHA_HOME (?) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25586 --- Comment #8 from Marcel de Rooy --- (In reply to Jonathan Druart from comment #6) > (In reply to David Cook from comment #4) > > I was wondering what KOHA_HOME was about yesterday... > > > > Maybe KOHA_HOME should be set to "/usr/share/koha" only if KOHA_HOME is > > unset. > > > > Then in kohadevbox and koha-testing-docker, an environmental variable can be > > set to a dev install location? > > We already have 'dev_install' and 'intranetdir' in koha-conf. I don't think > adding more variables will help. This is not a new variable. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 5 12:08:10 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Jun 2020 10:08:10 +0000 Subject: [Koha-bugs] [Bug 25346] Only show warn about existing directory on installing translations when verbose is used In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25346 Alex Arnaud changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |alex.arnaud at biblibre.com QA Contact|testopia at bugs.koha-communit |alex.arnaud at biblibre.com |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 5 12:13:13 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Jun 2020 10:13:13 +0000 Subject: [Koha-bugs] [Bug 25586] Something wrong with KOHA_HOME (?) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25586 --- Comment #9 from Jonathan Druart --- (In reply to Marcel de Rooy from comment #8) > (In reply to Jonathan Druart from comment #6) > > (In reply to David Cook from comment #4) > > > I was wondering what KOHA_HOME was about yesterday... > > > > > > Maybe KOHA_HOME should be set to "/usr/share/koha" only if KOHA_HOME is > > > unset. > > > > > > Then in kohadevbox and koha-testing-docker, an environmental variable can be > > > set to a dev install location? > > > > We already have 'dev_install' and 'intranetdir' in koha-conf. I don't think > > adding more variables will help. > > This is not a new variable. KOHA_HOME is not (hence this bug report). David's suggestion was to add a new one. At least it's what I understood. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 5 12:14:46 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Jun 2020 10:14:46 +0000 Subject: [Koha-bugs] [Bug 23128] Missing Net::OAuth2::AuthorizationServer dependency In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23128 --- Comment #10 from Jonathan Druart --- What is needed here? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 5 12:15:31 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Jun 2020 10:15:31 +0000 Subject: [Koha-bugs] [Bug 25394] Cronjob path in the AuthorityMergeLimit syspref description is wrong In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25394 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |minor CC| |jonathan.druart at bugs.koha-c | |ommunity.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 5 12:22:56 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Jun 2020 10:22:56 +0000 Subject: [Koha-bugs] [Bug 25642] Technical notes are missing from the release In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25642 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Version|20.05 |master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 5 12:32:26 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Jun 2020 10:32:26 +0000 Subject: [Koha-bugs] [Bug 19821] Run tests on a separate database In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19821 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #63 from Jonathan Druart --- (In reply to Kyle M Hall from comment #62) > Jonathan, can we get a unified test plan for this patch set? I'm not sure if > I'm testing wrong. Selenium tests pass in 'normal' mode, so I know it's not > my Selenium container that's not problematic: Hi Kyle, The test plan provided by Victor is quite good. If you want to "just it passes" you can: 1. $ mysql -h db -u root --password=password > GRANT ALL PRIVILEGES ON `koha_test`.* TO 'koha_kohadev'; 2. # Edit $KOHA_CONF and add koha_test 3. $ prove -Mt::lib::Bootstrap t/db_dependent/selenium/00-installation.t And the tests should pass. But the different steps described by Victor are useful to understand how it works. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 5 12:33:23 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Jun 2020 10:33:23 +0000 Subject: [Koha-bugs] [Bug 19821] Run tests on a separate database In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19821 --- Comment #64 from Jonathan Druart --- ha, don't forget to apply patches from both bug 19821 and bug 19185. They go together. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 5 12:34:39 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Jun 2020 10:34:39 +0000 Subject: [Koha-bugs] [Bug 23204] Add script for exporting elasticsearch mappings to YAML In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23204 --- Comment #46 from Jonathan Druart --- Could someone deal with that? At least to open a new bug report. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 5 12:36:40 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Jun 2020 10:36:40 +0000 Subject: [Koha-bugs] [Bug 25607] Wrong behaviour about perl versions in list-deps In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25607 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org, | |mtj at kohaaloha.com --- Comment #1 from Jonathan Druart --- Mason, is that something we can fix? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 5 12:45:16 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Jun 2020 10:45:16 +0000 Subject: [Koha-bugs] [Bug 25442] Release dates are missing from the timeline In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25442 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 5 13:06:58 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Jun 2020 11:06:58 +0000 Subject: [Koha-bugs] [Bug 22796] koha-common and mariadb start in the wrong order In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22796 Joonas Kylmälä changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |joonas.kylmala at helsinki.fi Status|NEW |In Discussion --- Comment #1 from Joonas Kylmälä --- I couldn't come up with any way to fix this issue in Koha Debian packages. The database could as well be in a remote server so it looks like it is up to the person upgrading koha-common package to make sure database is accepting connections during the upgrade. What we could probably do is recommend users to upgrade first koha-common and then the database separately, although one might want to coordinate the upgrade so that when the database is down some nice maintenance page is shown or use a database cluster to keep koha running all the time. Some might suggest adding a retry time (for example 10 seconds) but who knows how long a give DB server upgrade might take. I suggest closing this issue and editing the instructions in wiki. Ben, does this sound good? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 5 13:10:36 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Jun 2020 11:10:36 +0000 Subject: [Koha-bugs] [Bug 22796] koha-common and mariadb start in the wrong order In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22796 --- Comment #2 from Joonas Kylmälä --- Well, maybe creating a new debian package for one server installations we could add mysql-server as dependency and then this would work but I have not seen this done anywhere with other debian packages so not sure it's worth the extra packaging work and would even work. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Jun 5 13:23:55 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Jun 2020 11:23:55 +0000 Subject: [Koha-bugs] [Bug 25442] Release dates are missing from the timeline In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25442 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #4 from Jonathan Druart --- The dates are wrong, epoch must come from commit dates, and the date converted in UTC. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 5 13:25:15 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Jun 2020 11:25:15 +0000 Subject: [Koha-bugs] [Bug 25477] The responsive design in opac-main.tt should be correct In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25477 Timothy Alexis Vass changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 5 13:27:38 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Jun 2020 11:27:38 +0000 Subject: [Koha-bugs] [Bug 25680] When adding a new patron and missing to fill a field, on saving, the invalidFocus should show the focused field clearly in view. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25680 --- Comment #3 from Owen Leonard --- I don't find that the above code does what you want it to. Testing in Firefox and Chrome on Mac the result is that the first invalid field is still hidden at the top of the page by the floating toolbar. Also: If you submit your change as a patch it will be easier for folks to test it. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 5 13:30:28 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Jun 2020 11:30:28 +0000 Subject: [Koha-bugs] [Bug 25680] When adding a new patron and missing to fill a field, on saving, the invalidFocus should show the focused field clearly in view. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25680 --- Comment #4 from Timothy Alexis Vass --- Created attachment 105574 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105574&action=edit $("#entryform").validate focuses invalid field clearly in view. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Jun 5 13:42:00 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Jun 2020 11:42:00 +0000 Subject: [Koha-bugs] [Bug 25680] When adding a new patron and missing to fill a field, on saving, the invalidFocus should show the focused field clearly in view. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25680 --- Comment #5 from Timothy Alexis Vass --- Created attachment 105575 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105575&action=edit Bug 25680 - When adding a new patron and missing to fill a field, on saving, the invalidFocus should show the focused field clearly in view. This patch will center the focused field at the golden section in the window. To test: 1) Begin to add a new patron. 2) Leave a required field empty, which is outside the screen view, and click Save. 3) Notice that the field is at the bottom, behind the language bar if there is one. 4) Apply patch 5) Add a new patron. 6) Leave the required field empty again and Save. 7) Notice that the required field is now clearly shown in view. 8) Sign off. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Jun 5 13:42:37 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Jun 2020 11:42:37 +0000 Subject: [Koha-bugs] [Bug 25442] Release dates are missing from the timeline In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25442 --- Comment #5 from Martin Renvoize --- OK.. I think we need distinct bugs.. one for correcting the epoch date vs display date issue (I've updated bin/get_developers.pl to output a nicely formatted fix for this in the release_tools and can upload a generated patch here or on a new bug) and one to add in all the missing releases.. minor releases are hard to pick out of the commit log as they're each on their own branch. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 5 13:43:00 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Jun 2020 11:43:00 +0000 Subject: [Koha-bugs] [Bug 25680] When adding a new patron and missing to fill a field, on saving, the invalidFocus should show the focused field clearly in view. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25680 Timothy Alexis Vass changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Change sponsored?|--- |Sponsored Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Jun 5 13:43:44 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Jun 2020 11:43:44 +0000 Subject: [Koha-bugs] [Bug 25662] Create hold route does not check maxreserves syspref In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25662 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 5 13:44:48 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Jun 2020 11:44:48 +0000 Subject: [Koha-bugs] [Bug 24807] Add "year" type to improve sorting by publication date In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24807 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |julian.maurice at biblibre.com --- Comment #29 from Julian Maurice --- > return map { s/[u]/0/gr } ( $value =~ /[0-9u]{4}/g ); This line has some problems IMO: - It only considers years of 4 digits. I believe it is valid in MARC21 to write years with 3 digits or less, so it should be possible to index those values too. - In UNIMARC uncertain digits can be replaced by a blank (space) in some cases (100$a for instance : https://www.transition-bibliographique.fr/wp-content/uploads/2018/07/B100-6-2010.pdf [in french, sorry]) - Replacing the uncertain character by 0 can be problematic. 197u is not 1970. Ideally, searching for records published in 1975 should return records where publication date is "197u", right ? Elasticsearch has an integer_range data type that could be useful in this situation. What do you think ? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 5 13:47:52 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Jun 2020 11:47:52 +0000 Subject: [Koha-bugs] [Bug 21366] add plack reload In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21366 Joonas Kylmälä changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |joonas.kylmala at helsinki.fi --- Comment #2 from Joonas Kylmälä --- In koha-suomi fork we use start-stop-daemon to send the HUP signal, that's probably the preferable way since koha-plack uses start-stop-daemon already to send the process kill signal. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 5 13:49:51 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Jun 2020 11:49:51 +0000 Subject: [Koha-bugs] [Bug 20517] Use the "sort bin" field in SIP2 Checkin Response In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20517 Magnus Enger changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #11 from Magnus Enger --- Need to revise this a bit. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 5 13:55:24 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Jun 2020 11:55:24 +0000 Subject: [Koha-bugs] [Bug 25322] Adding a guarantor with no relationship defaults to father In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25322 --- Comment #26 from Andrew Fuerste-Henry --- (In reply to Jonathan Druart from comment #25) > Can we agree on this? > > * If the pref does not contain an empty entry then we add a preselected > empty value in the dropdown list and make it mandatory > > * If the pref contain an empty entry ("|father|mother"), then we make it > optional. Works for me! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 5 14:00:06 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Jun 2020 12:00:06 +0000 Subject: [Koha-bugs] [Bug 25642] Technical notes are missing from the release In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25642 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |julian.maurice at biblibre.com --- Comment #4 from Julian Maurice --- Maybe too late but, > misc/devel/update_dbix_class_files.pl now defaults to using > koha-conf.xml so you are not required to always append parameters now > to run the script This is not true. You have to use the --koha-conf option to get this behaviour. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 5 14:00:24 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Jun 2020 12:00:24 +0000 Subject: [Koha-bugs] [Bug 25680] When adding a new patron and missing to fill a field, on saving, the invalidFocus should show the focused field clearly in view. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25680 Timothy Alexis Vass changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #105575|0 |1 is obsolete| | --- Comment #6 from Timothy Alexis Vass --- Created attachment 105576 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105576&action=edit Bug 25680 - When adding a new patron and missing to fill a field, on saving, the invalidFocus should show the focused field clearly in view. This patch will center the focused field at the golden section in the window. To test: 1) Begin to add a new patron. 2) Leave a required field empty, which is outside the screen view, and click Save. 3) Notice that the field is at the bottom, behind the language bar if there is one. 4) Apply patch 5) Add a new patron. 6) Leave the required field empty again and Save. 7) Notice that the required field is now clearly shown in view. 8) Sign off. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 5 14:05:18 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Jun 2020 12:05:18 +0000 Subject: [Koha-bugs] [Bug 25680] When adding a new patron and missing to fill a field, on saving, the invalidFocus should show the focused field clearly in view. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25680 Timothy Alexis Vass changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #105576|0 |1 is obsolete| | --- Comment #7 from Timothy Alexis Vass --- Created attachment 105577 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105577&action=edit Bug 25680 - When adding a new patron and missing to fill a field, on saving, the invalidFocus should show the focused field clearly in view. This patch will center the focused field at the golden section in the window. To test: 1) Begin to add a new patron. 2) Leave a required field empty, which is outside the screen view, and click Save. 3) Notice that the field is at the bottom, behind the language bar if there is one. 4) Apply patch 5) Add a new patron. 6) Leave the required field empty again and Save. 7) Notice that the required field is now clearly shown in view. 8) Sign off. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 5 14:07:05 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Jun 2020 12:07:05 +0000 Subject: [Koha-bugs] [Bug 23091] Add options to charge new or restore forgiven overdues when a lost item is returned In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23091 --- Comment #22 from Andrew Fuerste-Henry --- > The existing code prior to this patch writes off/forgives any outstanding debt > on the overdue as opposed to the original amount of the debt.. so if the > patron has already paid or partially paid the accruing fine prior to > reporting the item as lost then only the outstanding debt will be forgiven. That sounds right to me. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 5 14:13:31 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Jun 2020 12:13:31 +0000 Subject: [Koha-bugs] [Bug 25346] Only show warn about existing directory on installing translations when verbose is used In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25346 --- Comment #4 from Alex Arnaud --- Created attachment 105578 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105578&action=edit Bug 25346: Supress warning message when install dir exists To see it enable verbose mode To test: 1) Install lang with install dir (cd misc/translator; ./tranlste install de-DE) check message: "de-DE installer dir /...mysql/de-DE already exists." 2) Apply patch 3) Repeat 1, now message is gone 4) Repeat 1 in verbose mode (./translate install de-DE -v) check the message now appears at the bottom. Signed-off-by: Katrin Fischer Signed-off-by: Alex Arnaud -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 5 14:13:58 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Jun 2020 12:13:58 +0000 Subject: [Koha-bugs] [Bug 25346] Only show warn about existing directory on installing translations when verbose is used In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25346 Alex Arnaud changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 5 14:21:26 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Jun 2020 12:21:26 +0000 Subject: [Koha-bugs] [Bug 23091] Add options to charge new or restore forgiven overdues when a lost item is returned In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23091 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #23 from Andrew Fuerste-Henry --- New error at the same place -- step 18, checking in a lost item while rule is set to one of the new options. Here's the error: No branchcode argument passed to Koha::Calendar->new at /kohadevbox/koha/C4/Overdues.pm line 319. at /usr/share/perl/5.24/Carp.pm line 167 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 5 14:28:25 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Jun 2020 12:28:25 +0000 Subject: [Koha-bugs] [Bug 24003] REST API should set C4::Context->userenv In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24003 --- Comment #5 from Tomás Cohen Arazi --- Created attachment 105579 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105579&action=edit Bug 24003: Regression tests This patch adds regression tests for the different authentication mechanisms Koha supports. It highlights the fact that Koha expects userenv to be set on authentication. Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 5 14:28:31 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Jun 2020 12:28:31 +0000 Subject: [Koha-bugs] [Bug 24003] REST API should set C4::Context->userenv In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24003 --- Comment #6 from Tomás Cohen Arazi --- Created attachment 105580 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105580&action=edit Bug 24003: Make the API set userenv on authentication This patch makes the authentication step stash the user that got authenticated so code outside the Mojo part of Koha can use it (i.e. through the use of C4::Context->userenv). To test: 1. Apply the regression tests 2. Run: $ kshell k$ prove t/db_dependent/api/v1/auth_authenticate_api_request.t \ t/db_dependent/api/v1/auth_basic.t => FAIL: Tests fail! 3. Apply this patch 4. Repeat 2 => SUCCESS: Tests pass! Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 5 14:28:34 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Jun 2020 12:28:34 +0000 Subject: [Koha-bugs] [Bug 24003] REST API should set C4::Context->userenv In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24003 --- Comment #7 from Tomás Cohen Arazi --- Created attachment 105581 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105581&action=edit Bug 24003: (follow-up) Basic auth missing tests for stashed user Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 5 14:33:49 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Jun 2020 12:33:49 +0000 Subject: [Koha-bugs] [Bug 24003] REST API should set C4::Context->userenv In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24003 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 5 14:33:52 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Jun 2020 12:33:52 +0000 Subject: [Koha-bugs] [Bug 24003] REST API should set C4::Context->userenv In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24003 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95228|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 5 14:33:55 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Jun 2020 12:33:55 +0000 Subject: [Koha-bugs] [Bug 24003] REST API should set C4::Context->userenv In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24003 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95230|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 5 14:35:11 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Jun 2020 12:35:11 +0000 Subject: [Koha-bugs] [Bug 25642] Technical notes are missing from the release In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25642 --- Comment #5 from Jonathan Druart --- Can you follow-up please? We can still update the website. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 5 14:36:57 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Jun 2020 12:36:57 +0000 Subject: [Koha-bugs] [Bug 25442] Release dates are missing from the timeline In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25442 --- Comment #6 from Jonathan Druart --- I am doing that: git log --tags --simplify-by-decoration --pretty="format:%at %d"|grep 'tag: v'|sort -n -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 5 14:38:59 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Jun 2020 12:38:59 +0000 Subject: [Koha-bugs] [Bug 25638] API related tests failing on comparing floats In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25638 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #105484|0 |1 is obsolete| | --- Comment #4 from Martin Renvoize --- Created attachment 105582 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105582&action=edit Bug 25638: Revert "Bug 25513: Remove unneeded integer casting in Koha::Object->TO_JSON" This reverts commit a79cf4150e8a08e743acc7d7147af91757d7a9b8. Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 5 14:39:03 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Jun 2020 12:39:03 +0000 Subject: [Koha-bugs] [Bug 25638] API related tests failing on comparing floats In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25638 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #105485|0 |1 is obsolete| | --- Comment #5 from Martin Renvoize --- Created attachment 105583 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105583&action=edit Bug 25638: Fix floag/decimal comparison in API related tests The previous fix from bug 25513 does not work in all versions we are supporting. Let's hack the float/decimal columns in the same way we did for integer. prove t/db_dependent/api/v1/acquisitions_vendors.t t/db_dependent/api/v1/patrons_accounts.t t/db_dependent/api/v1/acquisitions_orders.t Note that there is another error on U20 for acquisitions_orders.t Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 5 14:40:00 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Jun 2020 12:40:00 +0000 Subject: [Koha-bugs] [Bug 25642] Technical notes are missing from the release In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25642 --- Comment #6 from Julian Maurice --- Created attachment 105584 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105584&action=edit Bug 25642: Fix description of new feature in update_dbix_class_files.pl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 5 14:40:00 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Jun 2020 12:40:00 +0000 Subject: [Koha-bugs] [Bug 25638] API related tests failing on comparing floats In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25638 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com Status|Needs Signoff |Signed Off --- Comment #6 from Martin Renvoize --- Works as expected.. this is a reasonable interim measure whilst we work on converting to use MariaDB::DBD -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 5 14:47:02 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Jun 2020 12:47:02 +0000 Subject: [Koha-bugs] [Bug 25597] Javascript errors in self-checkout printslip.pl preventing printing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25597 --- Comment #3 from Alex Arnaud --- Created attachment 105585 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105585&action=edit Bug 25597: Add missing Javascript libraries to sco printslip This patch adds missing Javascript libraries to the self-checkout print slip. These missing libraries were preventing the auto print prompt and close. There was also a font error. To Test: 0) Apply patch 1) Turn on system preference SelfCheckReceiptPrompt 2) Check out item via /cgi-bin/koha/sco/sco-main.pl 3) Click "Finish" 4) Press F12 on keyboard and choose Console 5) Note no Javascript errors 6) Note that print dialog appears and closes after a print option is chosen Signed-off-by: Katrin Fischer Signed-off-by: Alex Arnaud -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 5 14:47:43 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Jun 2020 12:47:43 +0000 Subject: [Koha-bugs] [Bug 25597] Javascript errors in self-checkout printslip.pl preventing printing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25597 Alex Arnaud changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |alex.arnaud at biblibre.com Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 5 14:47:47 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Jun 2020 12:47:47 +0000 Subject: [Koha-bugs] [Bug 25597] Javascript errors in self-checkout printslip.pl preventing printing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25597 Alex Arnaud changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |alex.arnaud at biblibre.com |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 5 14:48:17 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Jun 2020 12:48:17 +0000 Subject: [Koha-bugs] [Bug 24003] REST API should set C4::Context->userenv In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24003 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #105579|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 5 14:48:20 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Jun 2020 12:48:20 +0000 Subject: [Koha-bugs] [Bug 24003] REST API should set C4::Context->userenv In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24003 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #105580|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 5 14:48:24 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Jun 2020 12:48:24 +0000 Subject: [Koha-bugs] [Bug 24003] REST API should set C4::Context->userenv In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24003 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #105581|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 5 14:49:33 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Jun 2020 12:49:33 +0000 Subject: [Koha-bugs] [Bug 24003] REST API should set C4::Context->userenv In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24003 --- Comment #8 from Tomás Cohen Arazi --- Created attachment 105586 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105586&action=edit Bug 24003: Regression tests This patch adds regression tests for the different authentication mechanisms Koha supports. It highlights the fact that Koha expects userenv to be set on authentication. Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 5 14:49:40 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Jun 2020 12:49:40 +0000 Subject: [Koha-bugs] [Bug 24003] REST API should set C4::Context->userenv In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24003 --- Comment #9 from Tomás Cohen Arazi --- Created attachment 105587 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105587&action=edit Bug 24003: Make the API set userenv on authentication This patch makes the authentication step stash the user that got authenticated so code outside the Mojo part of Koha can use it (i.e. through the use of C4::Context->userenv). To test: 1. Apply the regression tests 2. Run: $ kshell k$ prove t/db_dependent/api/v1/auth_authenticate_api_request.t \ t/db_dependent/api/v1/auth_basic.t => FAIL: Tests fail! 3. Apply this patch 4. Repeat 2 => SUCCESS: Tests pass! Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 5 14:49:46 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Jun 2020 12:49:46 +0000 Subject: [Koha-bugs] [Bug 24003] REST API should set C4::Context->userenv In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24003 --- Comment #10 from Tomás Cohen Arazi --- Created attachment 105588 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105588&action=edit Bug 24003: (follow-up) Move interface setting to a more readable place Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 5 14:53:01 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Jun 2020 12:53:01 +0000 Subject: [Koha-bugs] [Bug 24003] REST API should set C4::Context->userenv In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24003 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org, | |kyle at bywatersolutions.com, | |martin.renvoize at ptfs-europe | |.com --- Comment #11 from Tomás Cohen Arazi --- I went on and added missing tests in basic auth, and also added a test for an untested feature (C4::Context->interface being set to 'api'). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 5 15:32:50 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Jun 2020 13:32:50 +0000 Subject: [Koha-bugs] [Bug 25623] Some tests in oauth.t do not roll back In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25623 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #105457|0 |1 is obsolete| | --- Comment #4 from Julian Maurice --- Created attachment 105589 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105589&action=edit Bug 25623: Make sure oauth.t rolls back the db This patch adds a missing transaction wrapping one of the subtests. This is probably an oversight when refactoring this file. To test: 1. Open the patron categories page 2. Run: $ kshell k$ prove t/db_dependent/api/v1/oauth.t => SUCCESS: Tests pass 3. Reload the patron categories page => FAIL: There's random data in there 4. Apply this patch and repeat 2 5. Reload the patron categories page => SUCCESS: The random data from the previous tests is still there, but no new random data => SUCCESS: Tests still pass 6. Sign off :-D Signed-off-by: Tomas Cohen Arazi Signed-off-by: Jonathan Druart Signed-off-by: Julian Maurice -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 5 15:33:00 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Jun 2020 13:33:00 +0000 Subject: [Koha-bugs] [Bug 25623] Some tests in oauth.t do not roll back In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25623 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |julian.maurice at biblibre.com Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 5 15:35:24 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Jun 2020 13:35:24 +0000 Subject: [Koha-bugs] [Bug 25638] API related tests failing on comparing floats In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25638 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com QA Contact|testopia at bugs.koha-communit |tomascohen at gmail.com |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 5 15:46:06 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Jun 2020 13:46:06 +0000 Subject: [Koha-bugs] [Bug 15522] New interface for revamped circulation rules In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15522 Donna changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bwsdonna at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 5 16:03:04 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Jun 2020 14:03:04 +0000 Subject: [Koha-bugs] [Bug 22522] API authentication breaks with updated Mojolicious version In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22522 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 5 16:03:34 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Jun 2020 14:03:34 +0000 Subject: [Koha-bugs] [Bug 25638] API related tests failing on comparing floats In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25638 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 5 16:04:16 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Jun 2020 14:04:16 +0000 Subject: [Koha-bugs] [Bug 25641] Koha/XSLT/Base.t is failing on U20 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25641 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 5 16:09:59 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Jun 2020 14:09:59 +0000 Subject: [Koha-bugs] [Bug 25638] API related tests failing on comparing floats In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25638 --- Comment #7 from Jonathan Druart --- Created attachment 105590 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105590&action=edit Bug 25638: Fix failure on Koha/Object.t -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 5 16:27:13 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Jun 2020 14:27:13 +0000 Subject: [Koha-bugs] [Bug 25266] Not all vendors are listed in the filters on the late order claims page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25266 Alex Arnaud changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |alex.arnaud at biblibre.com Status|Signed Off |Failed QA --- Comment #24 from Alex Arnaud --- Seems that @parameters variable is now useless in acqui/lateorders.pl: 126 my @parameters = ( $delay ); 127 push @parameters, $estimateddeliverydatefrom_dt 128 ? $estimateddeliverydatefrom_dt->ymd() 129 : undef; 130 131 push @parameters, $estimateddeliverydateto_dt 132 ? $estimateddeliverydateto_dt->ymd() 133 : undef; Also, you remove the file t/db_dependent/Bookseller.t. That file contains a lot of test that are not related to C4::Bookseller and GetBooksellersWithLateOrders (AddBookseller, DelBookseller, get bookseller etc...). Are you sure these tests exist elsewhere ? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 5 16:29:00 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Jun 2020 14:29:00 +0000 Subject: [Koha-bugs] [Bug 25442] Release dates are missing from the timeline In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25442 --- Comment #7 from Martin Renvoize --- Nice.. I didn't think about looking at it from the tags perspective. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 5 16:35:02 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Jun 2020 14:35:02 +0000 Subject: [Koha-bugs] [Bug 25504] Wrong API spec breaks plack without meaningful error In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25504 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |RM_priority -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Jun 5 16:47:40 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Jun 2020 14:47:40 +0000 Subject: [Koha-bugs] [Bug 22522] API authentication breaks with updated Mojolicious version In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22522 --- Comment #56 from Kyle M Hall --- Created attachment 105591 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105591&action=edit [19.11.x] Bug 22522: Fail back to ->openapi->spec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 5 16:50:58 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Jun 2020 14:50:58 +0000 Subject: [Koha-bugs] [Bug 25554] Refactor rule kinds assignments in CirculationRules.pm In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25554 --- Comment #3 from Peter Vashchuk --- Yeah I thought about naming them similarly to what you proposed but it would undermine some decisions that were taken into consideration during refactor. The thing is, we need to add another item to "scope3" for Koha Finland, if we name those arrays something like I already did (scope1, scope2, scope3) all it requires is to add another item to array and we’re done, but if we rename those arrays like you suggested (branch_category, branch_itemtype, branch_category_itemtype) it will complicate things if we ever need to add any other element to any of those arrays. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 5 16:52:57 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Jun 2020 14:52:57 +0000 Subject: [Koha-bugs] [Bug 25681] New: Patron categories sorted inconsistently Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25681 Bug ID: 25681 Summary: Patron categories sorted inconsistently Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Patrons Assignee: koha-bugs at lists.koha-community.org Reporter: david.roberts at ptfs-europe.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com When you click on Patrons > New Patron, the patron categories in the drop down are sorted by description. However, when you edit a patron record, the categories are sorted by categorycode. These should be consistent, and as it isn't possible to edit the categorycode, ideally both drop downs should sort by category description. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 5 16:55:16 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Jun 2020 14:55:16 +0000 Subject: [Koha-bugs] [Bug 25681] Patron categories sorted inconsistently In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25681 Sally changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sally.healey at cheshireshared | |services.gov.uk -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 5 16:58:39 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Jun 2020 14:58:39 +0000 Subject: [Koha-bugs] [Bug 25273] Elasticsearch Authority matching is returning too many results In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25273 --- Comment #11 from Nick Clemens --- (In reply to Julian Maurice from comment #10) > Hi Nick, > > (In reply to Nick Clemens from comment #9) > > This may work in this simpler case, however, specifying the fields generates > > them in a fixed order, and authorities order can differ and has different > > meanings > > Can you provide a test plan with a complex case, which cannot be solved > using configuration only ? I don't have a specific example of an authority that doesn't work, but if we look at the example Alex provides: Before the patches, with mapping 150(abgvxyz) the two records are indexed with match-heading as: ['Waterworks'] ['Waterworks Costs','Waterworks generalsubdiv Costs'] After the patch: ['Waterworks'] ['Waterworks generalsubdiv Costs'] In both cases when linking we perform a search for: 'Waterworks generalsubdiv Costs' The matching works before only because we are already generating the heading search form and storing it in the index, the mappings don't affect the terms used for matching. Custom added authority types still use the hard coded hashes in C4/Heading/{marcflavour} to generate the heading search form, so will only work if they use a field defined there with or without the patches Adding the user defined fields only adds the possibility for mismatches, it doesn't add functionality. There are subdivisions that can be reordered (which mappings don't handle) and terms like '$aScience$vFiction' and '$aScience fiction' which can end up mismatching Since we are always using the standardized C4::Heading->search_form when performing the search we should also only store that search_form in the index -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 5 16:59:28 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Jun 2020 14:59:28 +0000 Subject: [Koha-bugs] [Bug 25266] Not all vendors are listed in the filters on the late order claims page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25266 --- Comment #25 from Jonathan Druart --- Created attachment 105592 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105592&action=edit Bug 25266: Remove uneeded var -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 5 17:00:19 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Jun 2020 15:00:19 +0000 Subject: [Koha-bugs] [Bug 25681] Patron categories sorted inconsistently In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25681 David Roberts changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |david.roberts at ptfs-europe.c |ity.org |om -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 5 17:01:31 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Jun 2020 15:01:31 +0000 Subject: [Koha-bugs] [Bug 25266] Not all vendors are listed in the filters on the late order claims page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25266 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #26 from Jonathan Druart --- (In reply to Alex Arnaud from comment #24) > Seems that @parameters variable is now useless in acqui/lateorders.pl: > > 126 my @parameters = ( $delay ); > 127 push @parameters, $estimateddeliverydatefrom_dt > 128 ? $estimateddeliverydatefrom_dt->ymd() > 129 : undef; > 130 > 131 push @parameters, $estimateddeliverydateto_dt > 132 ? $estimateddeliverydateto_dt->ymd() > 133 : undef; Indeed, fixed! > Also, you remove the file t/db_dependent/Bookseller.t. That file contains a > lot of test that are not related to C4::Bookseller and > GetBooksellersWithLateOrders (AddBookseller, DelBookseller, get bookseller > etc...). > > Are you sure these tests exist elsewhere ? Those CRUD subroutines have been moved to Koha::Acquisition::Booksellers. The whole test file was there to test GetBooksellersWithLateOrders, and a left over of the previous subroutines. There is some tests in t/db_dependent/Koha/Acquisition/Booksellers.t, that's enough to test Koha::Acquisition::Booksellers (most of CRUD methods rely on highly tested Koha::Object[s] anyway). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 5 17:10:21 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Jun 2020 15:10:21 +0000 Subject: [Koha-bugs] [Bug 25442] Release dates are missing from the timeline In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25442 --- Comment #8 from Martin Renvoize --- get_developers now uses tags for releases.. but tags aren't entirely consistent so some manual cleaning may be required.. I'll work through that and submit a patch here including both set of changes -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 5 17:13:48 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Jun 2020 15:13:48 +0000 Subject: [Koha-bugs] [Bug 23808] Creating Child Guarantee doesn't populate Guarantor Information In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23808 --- Comment #29 from Kelly McElligott --- I have tested this as we are hoping to have this rebase to happen so it can get pushed to 19.11. It is working! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 5 17:24:35 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Jun 2020 15:24:35 +0000 Subject: [Koha-bugs] [Bug 25677] Checkbox options for EDI accounts cannot be enabled In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25677 Fiona Borthwick changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fiona.borthwick at ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 5 17:25:57 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Jun 2020 15:25:57 +0000 Subject: [Koha-bugs] [Bug 25442] Release dates are missing from the timeline In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25442 --- Comment #9 from Jonathan Druart --- Please share the script in the release-tools repo. My code was: my $tags = `git log --tags --simplify-by-decoration --pretty="format:%at %d"|grep 'tag: v'|sort -n`; #2014-01-23 16:08:37 -0300 (tag: v3.12.09, 3.12.X) for my $tag ( split "\n", $tags ) { if ( $tag =~ m|^(?\d+)\s+\(tag: v(?\d+\.\d+\.\d+)| ) { my $version = $+{version}; my $epoch = $+{epoch}; $events->{$epoch} = { epoch => $epoch, description => "Koha $version released", tags => 'releases' }; } else { say "$tag DOES NOT MATCH"; } } -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 5 18:09:44 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Jun 2020 16:09:44 +0000 Subject: [Koha-bugs] [Bug 11426] Make HighlightOwnItemsOnOPAC work with XSLT In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11426 --- Comment #12 from Owen Leonard --- Jonathan are you unsatisfied with your solution for some reason? What do you think is unfinished? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 5 18:12:22 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Jun 2020 16:12:22 +0000 Subject: [Koha-bugs] [Bug 23423] Online resource links which are OPAC retrieve file references are not correctly formatted in the OPAC detail view In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23423 --- Comment #10 from Owen Leonard --- Is this still an issue? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 5 18:15:05 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Jun 2020 16:15:05 +0000 Subject: [Koha-bugs] [Bug 24807] Add "year" type to improve sorting by publication date In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24807 --- Comment #30 from Nick Clemens --- (In reply to Julian Maurice from comment #29) > > return map { s/[u]/0/gr } ( $value =~ /[0-9u]{4}/g ); > > This line has some problems IMO: > - It only considers years of 4 digits. I believe it is valid in MARC21 to > write years with 3 digits or less, so it should be possible to index those > values too. > - In UNIMARC uncertain digits can be replaced by a blank (space) in some > cases (100$a for instance : > https://www.transition-bibliographique.fr/wp-content/uploads/2018/07/B100-6- > 2010.pdf [in french, sorry]) >From what little I understand there, UNIMARC uses '#' as the unkown character? or '#' translates to blank? leading blanks should be preserved as 0? and trailing ranged as you say below? > - Replacing the uncertain character by 0 can be problematic. 197u is not > 1970. Ideally, searching for records published in 1975 should return records > where publication date is "197u", right ? Elasticsearch has an integer_range > data type that could be useful in this situation. What do you think ? That is interesting, how does the range affect sorting? Might it still be worthwhile to sort unknown/ranged dates either at start or end, so file the sort value as either 1970 or 1979? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 5 18:21:44 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Jun 2020 16:21:44 +0000 Subject: [Koha-bugs] [Bug 25651] Modifying an authorised value make it disappear In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25651 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 5 18:21:47 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Jun 2020 16:21:47 +0000 Subject: [Koha-bugs] [Bug 25651] Modifying an authorised value make it disappear In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25651 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #105486|0 |1 is obsolete| | --- Comment #3 from Nick Clemens --- Created attachment 105593 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105593&action=edit Bug 25651: Fix modification of authorised value When modifying an existing authorised value, the category is not correctly passed to the template and so it is not passed to the POST request, which results in the authorised value switching to category '', which effectively make it disappear from the interface. This patch fixes that. Signed-off-by: Sally Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 5 18:25:55 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Jun 2020 16:25:55 +0000 Subject: [Koha-bugs] [Bug 25651] Modifying an authorised value make it disappear In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25651 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick at bywatersolutions.com Depends on| |17355 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17355 [Bug 17355] Authorised value categories cannot be deleted -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 5 18:25:55 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Jun 2020 16:25:55 +0000 Subject: [Koha-bugs] [Bug 17355] Authorised value categories cannot be deleted In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17355 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |25651 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25651 [Bug 25651] Modifying an authorised value make it disappear -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 5 19:08:25 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Jun 2020 17:08:25 +0000 Subject: [Koha-bugs] [Bug 25442] Release dates are missing from the timeline In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25442 --- Comment #10 from Martin Renvoize --- Created attachment 105594 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105594&action=edit Bug 25442: Use tags to update history -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 5 19:09:22 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Jun 2020 17:09:22 +0000 Subject: [Koha-bugs] [Bug 25442] Release dates are missing from the timeline In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25442 --- Comment #11 from Martin Renvoize --- see alternative patch.. mostly from the updated get_developers with some manual interaction -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 5 20:10:51 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Jun 2020 18:10:51 +0000 Subject: [Koha-bugs] [Bug 23965] Use an external service to provide DVD cover images In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23965 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard at myacpl.org |koha-bugs at lists.koha-commun | |ity.org -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 5 20:15:54 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Jun 2020 18:15:54 +0000 Subject: [Koha-bugs] [Bug 19889] LocalHoldsPriority needs exclusions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19889 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED --- Comment #2 from Tomás Cohen Arazi --- # Work to be done: 1 - Add a new column to the items table - 'exclude_from_local_holds_priority' or similar 2 - This field should be settable on the edit item form, and bath modifications 3 - Modify existing local holds priority code to skip items with column flag 'exclude_from_local_holds_priority' set for checking local hold priorities 4 - Add a column to 'categories' => 'excluded_from_localholds_priority' 5 - Alter code to ignore local holds priority for these -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 5 20:43:40 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Jun 2020 18:43:40 +0000 Subject: [Koha-bugs] [Bug 25682] New: Style transfers interface to match checkin page Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25682 Bug ID: 25682 Summary: Style transfers interface to match checkin page Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard at myacpl.org Reporter: oleonard at myacpl.org QA Contact: testopia at bugs.koha-community.org CC: testopia at bugs.koha-community.org Depends on: 25537 The transfers page has fallen behind the style of the checkin and checkout pages. It should be made to look more consistent. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25537 [Bug 25537] Page reload at branchtransfers.pl loses destination branch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 5 20:43:40 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Jun 2020 18:43:40 +0000 Subject: [Koha-bugs] [Bug 25537] Page reload at branchtransfers.pl loses destination branch In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25537 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |25682 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25682 [Bug 25682] Style transfers interface to match checkin page -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 5 20:44:19 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Jun 2020 18:44:19 +0000 Subject: [Koha-bugs] [Bug 25682] Style transfers interface to match checkin page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25682 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrew at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 5 20:46:00 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Jun 2020 18:46:00 +0000 Subject: [Koha-bugs] [Bug 25657] Import Patron fails without userid - not stated as required field in notes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25657 --- Comment #6 from Elaine Bradtke --- We're using two different versions of the OS - The production system where the import works: Linux library.efdss.org 3.16.0-4-amd64 #1 SMP Debian 3.16.51-2 (2017-12-03) x86_64 The test system - where the import fails is running: Linux public 4.9.0-12-amd64 #1 SMP Debian 4.9.210-1 (2020-01-20) x86_64 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Jun 5 20:53:37 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Jun 2020 18:53:37 +0000 Subject: [Koha-bugs] [Bug 25638] API related tests failing on comparing floats In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25638 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 5 20:53:47 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Jun 2020 18:53:47 +0000 Subject: [Koha-bugs] [Bug 25638] API related tests failing on comparing floats In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25638 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #105590|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 5 20:53:56 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Jun 2020 18:53:56 +0000 Subject: [Koha-bugs] [Bug 25638] API related tests failing on comparing floats In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25638 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #105582|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 5 20:54:04 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Jun 2020 18:54:04 +0000 Subject: [Koha-bugs] [Bug 25638] API related tests failing on comparing floats In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25638 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #105583|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 5 20:55:56 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Jun 2020 18:55:56 +0000 Subject: [Koha-bugs] [Bug 25638] API related tests failing on comparing floats In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25638 --- Comment #8 from Tomás Cohen Arazi --- Created attachment 105595 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105595&action=edit Bug 25638: Add tests for JSON conversion vs DBD::mysql We have the situation of needing to cast numbers so they are not confused in JSON with strings by DBD::mysql returning them with the wrong internal flags. We have also recently removed the cast, and adding it back now. This test could help us detect this situation in case we make changes in the area, and even on specific libraries versions. Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 5 20:56:07 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Jun 2020 18:56:07 +0000 Subject: [Koha-bugs] [Bug 25638] API related tests failing on comparing floats In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25638 --- Comment #9 from Tomás Cohen Arazi --- Created attachment 105596 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105596&action=edit Bug 25638: Revert "Bug 25513: Remove unneeded integer casting in Koha::Object->TO_JSON" This reverts commit a79cf4150e8a08e743acc7d7147af91757d7a9b8. Signed-off-by: Martin Renvoize Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 5 20:56:18 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Jun 2020 18:56:18 +0000 Subject: [Koha-bugs] [Bug 25638] API related tests failing on comparing floats In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25638 --- Comment #10 from Tomás Cohen Arazi --- Created attachment 105597 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105597&action=edit Bug 25638: Fix float/decimal comparison in API related tests The previous fix from bug 25513 does not work in all versions we are supporting. Let's hack the float/decimal columns in the same way we did for integer. prove t/db_dependent/api/v1/acquisitions_vendors.t \ t/db_dependent/api/v1/patrons_accounts.t \ t/db_dependent/api/v1/acquisitions_orders.t Note that there is another error on U20 for acquisitions_orders.t Signed-off-by: Martin Renvoize Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 5 20:56:30 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Jun 2020 18:56:30 +0000 Subject: [Koha-bugs] [Bug 25638] API related tests failing on comparing floats In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25638 --- Comment #11 from Tomás Cohen Arazi --- Created attachment 105598 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105598&action=edit Bug 25638: Fix regression Now that float/decimal columns are not treated similar to integer ones, the default value handling we had set for numeric values is not trapping the float/decimal cases as it should. We love tests! Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 5 20:56:41 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Jun 2020 18:56:41 +0000 Subject: [Koha-bugs] [Bug 25638] API related tests failing on comparing floats In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25638 --- Comment #12 from Tomás Cohen Arazi --- Created attachment 105599 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105599&action=edit Bug 25638: Update TODO Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 5 21:09:47 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Jun 2020 19:09:47 +0000 Subject: [Koha-bugs] [Bug 23019] Ability to create 'matching profiles' when importing records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23019 Agustín Moyano changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 5 21:11:07 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Jun 2020 19:11:07 +0000 Subject: [Koha-bugs] [Bug 23019] Ability to create 'matching profiles' when importing records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23019 --- Comment #21 from Tomás Cohen Arazi --- (In reply to Abbey Holt from comment #16) > This is great! There is one area where my matching preferences would not > stick when I created a profile. If I select "No" under "Check for embedded > item record data" and click "Add profile", No switches back to Yes. My > selection for "how to process items" is remembered. It is just the yes-no > button that isn't being saved. Abbey, I think you need to acknowledge the attachments count on the bug, and tell the sandboxes that you want to SO 5 patches. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 5 21:27:39 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Jun 2020 19:27:39 +0000 Subject: [Koha-bugs] [Bug 23019] Ability to create 'matching profiles' when importing records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23019 ByWater Sandboxes changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #105536|0 |1 is obsolete| | --- Comment #22 from ByWater Sandboxes --- Created attachment 105600 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105600&action=edit Bug 23019: Update database structure and add atomic update Signed-off-by: Abbey Holt -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 5 21:27:42 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Jun 2020 19:27:42 +0000 Subject: [Koha-bugs] [Bug 23019] Ability to create 'matching profiles' when importing records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23019 ByWater Sandboxes changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #105537|0 |1 is obsolete| | --- Comment #23 from ByWater Sandboxes --- Created attachment 105601 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105601&action=edit Bug 23019: Add koha_object_class and koha_objects_class methods to ImportBatch.pm schema Signed-off-by: Abbey Holt -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 5 21:27:46 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Jun 2020 19:27:46 +0000 Subject: [Koha-bugs] [Bug 23019] Ability to create 'matching profiles' when importing records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23019 ByWater Sandboxes changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #105538|0 |1 is obsolete| | --- Comment #24 from ByWater Sandboxes --- Created attachment 105602 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105602&action=edit Bug 23019: Add ImportBatchesProfile schema and set is_boolean to parse_items column Signed-off-by: Abbey Holt -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 5 21:27:49 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Jun 2020 19:27:49 +0000 Subject: [Koha-bugs] [Bug 23019] Ability to create 'matching profiles' when importing records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23019 ByWater Sandboxes changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #105539|0 |1 is obsolete| | --- Comment #25 from ByWater Sandboxes --- Created attachment 105603 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105603&action=edit Bug 23019: Add tests Signed-off-by: Abbey Holt -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 5 21:27:52 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Jun 2020 19:27:52 +0000 Subject: [Koha-bugs] [Bug 23019] Ability to create 'matching profiles' when importing records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23019 ByWater Sandboxes changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #105555|0 |1 is obsolete| | --- Comment #26 from ByWater Sandboxes --- Created attachment 105604 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105604&action=edit Bug 23019: Add profiles to stage-import-batch and magnage-import-batch pages This patch adds the logic and the needed UI elements to be able to pre-load an import profile. It also displays which profile was used to stage an import in staged import manager. To test: 1. Apply all patches 2. Updatedatabase 3. Go to Stage MARC records for Import tool in admin, and upload a file with MARC records. CHECK => after uploading, there is a fieldset with the legend “Profile settings” => inside the fieldset there is a select labeled “Pre fill values with profile”. The only value it has is “Do not use profile”. 4. Change some settings, and set “profile 1” as profile name and click on “Add profile” SUCCESS => The select now has the new profile selected 5. Change profile select to “Do not use profile” SUCCESS => Default values are now displayed in the form 6. Reload the page and upload the file again SUCCESS => the select still has the profile recently added 7. Select the profile, change some parameter in the form and set the profile name to “profile 2”, and click add profile SUCCESS => there are two profiles now, and if you toggle between them, the parameter changes 8. Select profile 1, change one parameter and click on update profile SUCCESS => if you toggle that profile with the other, the new parameter of the value is shown when you select profile 1 9. Select profile 2, change some parameter and click Add profile (leaving the name as profile 2) SUCCESS => the page complains there is another profile with the same name, and asks if you want to replace it. 10. Click on accept SUCCESS => profile 2 now has the new value in the parameter 11. Select profile 2 and change the name to profile 1 SUCCESS => the page complains there is another profile with that name, and asks if you want to replace it 12. Click on accept SUCCESS => in profile select there is only one profile called profile 1 that has the values of profile 2 13. Select profile 1 and click remove profile SUCCESS => there is no profile in profile select. 14. Create a profile and click on “Stage for import” 15. Go to Staged MARC management page SUCCESS => Improt should have the name of the profile in profile column, and when you click on the file name, there should be the name of the profile in the details. 16. prove t/db_dependent/ImportBatch.t t/db_dependent/api/v1/import_batch_profiles.t 17. Sign off Signed-off-by: Abbey Holt Signed-off-by: Abbey Holt -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 5 21:31:41 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Jun 2020 19:31:41 +0000 Subject: [Koha-bugs] [Bug 25651] Modifying an authorised value make it disappear In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25651 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |nick at bywatersolutions.com |y.org | CC| |tomascohen at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 5 21:43:13 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Jun 2020 19:43:13 +0000 Subject: [Koha-bugs] [Bug 23019] Ability to create 'matching profiles' when importing records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23019 --- Comment #27 from Abbey Holt --- (In reply to Tomás Cohen Arazi from comment #21) > (In reply to Abbey Holt from comment #16) > > This is great! There is one area where my matching preferences would not > > stick when I created a profile. If I select "No" under "Check for embedded > > item record data" and click "Add profile", No switches back to Yes. My > > selection for "how to process items" is remembered. It is just the yes-no > > button that isn't being saved. > > Abbey, I think you need to acknowledge the attachments count on the bug, and > tell the sandboxes that you want to SO 5 patches. Thank you. I think I've signed off on everything now. Let me know if I need to do anything else! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 5 21:51:11 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Jun 2020 19:51:11 +0000 Subject: [Koha-bugs] [Bug 25624] Update patrons category script should allow finding null and not null and wildcards In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25624 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 5 21:51:14 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Jun 2020 19:51:14 +0000 Subject: [Koha-bugs] [Bug 25624] Update patrons category script should allow finding null and not null and wildcards In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25624 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #105439|0 |1 is obsolete| | --- Comment #2 from Andrew Fuerste-Henry --- Created attachment 105605 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105605&action=edit Bug 25624: Add not equal, like, not like, and support for nulls to update_patron_category To test: 1 - Run the script with no parameters and verify the help explains the parameters 2 - Try running with various fields, matching and not matching 3 - Test null values 4 - Test like values with wildcards 5 - Test like with the word null to find fields containing the word rather than being unset Signed-off-by: Rhonda Kuiper -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 5 21:58:53 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Jun 2020 19:58:53 +0000 Subject: [Koha-bugs] [Bug 25683] New: update_patron_categories.pl should recognize no fine history = 0 outstanding fines Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25683 Bug ID: 25683 Summary: update_patron_categories.pl should recognize no fine history = 0 outstanding fines Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Command-line Utilities Assignee: koha-bugs at lists.koha-community.org Reporter: andrew at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: robin at catalyst.net.nz Bug 17168 introduced update_patron_categories.pl, which can change patron categories based on fine totals. But it doesn't understand that an absence of fines is the same as $0 owed. To replicate: - Have a patron with nothing in accountlines - run update_patron_categories to find patrons with fines under $5 (-fu=5) - Your patron is not found - Give your patron a manual charge of $1 - rerun the cron, your patron is found - pay off your patron's fine, putting their balance at $0 - rerun the cron, your patron is found -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 5 21:59:03 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Jun 2020 19:59:03 +0000 Subject: [Koha-bugs] [Bug 25683] update_patron_categories.pl should recognize no fine history = 0 outstanding fines In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25683 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 5 21:59:11 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Jun 2020 19:59:11 +0000 Subject: [Koha-bugs] [Bug 25683] update_patron_categories.pl should recognize no fine history = 0 outstanding fines In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25683 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |17168 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17168 [Bug 17168] Add a command line script for updating patron category based on status -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Jun 5 21:59:11 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Jun 2020 19:59:11 +0000 Subject: [Koha-bugs] [Bug 17168] Add a command line script for updating patron category based on status In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17168 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |25683 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25683 [Bug 25683] update_patron_categories.pl should recognize no fine history = 0 outstanding fines -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 5 22:36:22 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Jun 2020 20:36:22 +0000 Subject: [Koha-bugs] [Bug 23994] AdditionalFields.t is failing randomly (U18) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23994 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |victor at tuxayo.net -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 5 22:41:40 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Jun 2020 20:41:40 +0000 Subject: [Koha-bugs] [Bug 23994] AdditionalFields.t is failing randomly (U18) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23994 --- Comment #5 from Victor Grousset/tuxayo --- (In reply to Lucas Gass from comment #3) > I cannot make this fail in 19.05.x, do we need it in that version? I have this failing locally often (whereas it seems ok in the CI), it must depend a lot of the machine. So need in 19.05.x is confirmed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 5 22:43:25 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Jun 2020 20:43:25 +0000 Subject: [Koha-bugs] [Bug 22522] API authentication breaks with updated Mojolicious version In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22522 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |victor at tuxayo.net -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 5 22:43:44 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Jun 2020 20:43:44 +0000 Subject: [Koha-bugs] [Bug 25638] API related tests failing on comparing floats In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25638 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |victor at tuxayo.net -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 5 22:44:03 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Jun 2020 20:44:03 +0000 Subject: [Koha-bugs] [Bug 25641] Koha/XSLT/Base.t is failing on U20 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25641 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |victor at tuxayo.net -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 5 22:47:10 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Jun 2020 20:47:10 +0000 Subject: [Koha-bugs] [Bug 25681] Patron categories sorted inconsistently In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25681 Lisette Scheer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lisetteslatah at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 5 22:58:32 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 05 Jun 2020 20:58:32 +0000 Subject: [Koha-bugs] [Bug 25680] When adding a new patron and missing to fill a field, on saving, the invalidFocus should show the focused field clearly in view. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25680 Lisette Scheer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lisetteslatah at gmail.com --- Comment #8 from Lisette Scheer --- In both my production server and a Bywater Sandbox the behavior already works. If I have a required field that isn't filled out it gets centered on the screen without applying the patch. I also tested to make sure it will do this if the "save" toolbar is covering the required field. Lisette -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jun 6 02:34:13 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 06 Jun 2020 00:34:13 +0000 Subject: [Koha-bugs] [Bug 25538] www/search_utf8.t is failing randomly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25538 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com --- Comment #3 from Tomás Cohen Arazi --- You need to make sure the used fw has the checked girls set to display in the relevant interface. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jun 6 02:34:40 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 06 Jun 2020 00:34:40 +0000 Subject: [Koha-bugs] [Bug 25124] MARC visibility settings not obeyed on OPAC result lists In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25124 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |DUPLICATE Status|NEW |RESOLVED --- Comment #1 from Tomás Cohen Arazi --- *** This bug has been marked as a duplicate of bug 24458 *** -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Jun 6 02:34:40 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 06 Jun 2020 00:34:40 +0000 Subject: [Koha-bugs] [Bug 24458] Search results don't use Koha::Filter::MARC::ViewPolicy In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24458 --- Comment #14 from Tomás Cohen Arazi --- *** Bug 25124 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jun 6 05:06:50 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 06 Jun 2020 03:06:50 +0000 Subject: [Koha-bugs] [Bug 25641] Koha/XSLT/Base.t is failing on U20 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25641 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #105469|0 |1 is obsolete| | --- Comment #3 from Victor Grousset/tuxayo --- Created attachment 105606 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105606&action=edit Bug 25641: Fix Koha/XSLT/Base.t failures on U20 There is a change in the version number. On U20 we get Opening and ending tag mismatch: a line 0 and b On others (D9, D10, U18) we get: Opening and ending tag mismatch: a line 1 and b I did not find where it did come from, so assuming it's just a minor change and won't have side-effects. Test plan: Make sure the tests pass on U20 and another OS Signed-off-by: Victor Grousset/tuxayo -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jun 6 05:11:10 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 06 Jun 2020 03:11:10 +0000 Subject: [Koha-bugs] [Bug 25641] Koha/XSLT/Base.t is failing on U20 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25641 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #4 from Victor Grousset/tuxayo --- It works! (U20, D10, D11) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jun 6 05:19:24 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 06 Jun 2020 03:19:24 +0000 Subject: [Koha-bugs] [Bug 25684] New: ElasticSearch 7 start crash: at least one of [discovery.seed_hosts, discovery.seed_providers, cluster.initial_master_nodes] must be configured Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25684 Bug ID: 25684 Summary: ElasticSearch 7 start crash: at least one of [discovery.seed_hosts, discovery.seed_providers, cluster.initial_master_nodes] must be configured Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Searching - Elasticsearch Assignee: koha-bugs at lists.koha-community.org Reporter: victor at tuxayo.net I just started koha-testing-docker with ES7 (ran ku-es7) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jun 6 05:22:21 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 06 Jun 2020 03:22:21 +0000 Subject: [Koha-bugs] [Bug 25684] ElasticSearch 7 start crash: at least one of [discovery.seed_hosts, discovery.seed_providers, cluster.initial_master_nodes] must be configured In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25684 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |25439 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25439 [Bug 25439] [Omnibus] Prepare Koha to ElasticSearch 7 - ES7 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Jun 6 05:22:21 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 06 Jun 2020 03:22:21 +0000 Subject: [Koha-bugs] [Bug 25439] [Omnibus] Prepare Koha to ElasticSearch 7 - ES7 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25439 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |25684 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25684 [Bug 25684] ElasticSearch 7 start crash: at least one of [discovery.seed_hosts, discovery.seed_providers, cluster.initial_master_nodes] must be configured -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Jun 6 05:23:26 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 06 Jun 2020 03:23:26 +0000 Subject: [Koha-bugs] [Bug 25684] ElasticSearch 7 start crash: at least one of [discovery.seed_hosts, discovery.seed_providers, cluster.initial_master_nodes] must be configured In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25684 --- Comment #1 from Victor Grousset/tuxayo --- Odd, ES6 doesn't do a deprecation warning about this. I though it worked like that so there would never be a bad surprise when upgrading to a major version. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jun 6 05:33:31 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 06 Jun 2020 03:33:31 +0000 Subject: [Koha-bugs] [Bug 23994] AdditionalFields.t is failing randomly (U18) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23994 --- Comment #6 from Victor Grousset/tuxayo --- Wait it's already in 19.11 since a long time. Great I can backport it :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jun 6 08:49:02 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 06 Jun 2020 06:49:02 +0000 Subject: [Koha-bugs] [Bug 24201] Attach desk to intranet session In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24201 Frédéric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |frederic at tamil.fr --- Comment #39 from Frédéric Demians --- What is exactly the status of this? Since bug 13881 is in master and 20.05, what is the plan to include the actual functionality? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jun 6 14:19:23 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 06 Jun 2020 12:19:23 +0000 Subject: [Koha-bugs] [Bug 24201] Attach desk to intranet session In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24201 --- Comment #40 from Nicolas Legrand --- I'm still working on it, it should be ready soon :). In June. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jun 6 15:27:51 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 06 Jun 2020 13:27:51 +0000 Subject: [Koha-bugs] [Bug 14648] Batch remove reserve items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14648 --- Comment #10 from Joe Sikowitz --- Created attachment 105607 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105607&action=edit Bug-14648-Batch-remove-reserve-items -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jun 6 15:28:08 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 06 Jun 2020 13:28:08 +0000 Subject: [Koha-bugs] [Bug 14648] Batch remove reserve items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14648 Joe Sikowitz changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jun 6 15:28:52 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 06 Jun 2020 13:28:52 +0000 Subject: [Koha-bugs] [Bug 14648] Batch remove reserve items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14648 --- Comment #11 from Joe Sikowitz --- Test Plan 1. Log in as a user with permissions to add and delete course reserves 2. Add the same items to multiple course reserves 3. Go to the main course reserves page (i.e. /cgi-bin/koha/course_reserves/course-reserves.pl) 4. Click the "- Batch remove items" button 5. Enter the barcodes that you added to multiple reserves in step 1 6. Click submit 7. Click Ok if you are ready to delete all of these items 8. Check each course reserve that you added the items to in step 1 to make sure the items you entered were deleted but nothing else 9. Log out 10. Log in as a user without permission to delete course reserves 11. Go to the main course reserves page (i.e. /cgi-bin/koha/course_reserves/course-reserves.pl) 12. You should not longer see the "- Batch remove items" button -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jun 6 15:29:17 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 06 Jun 2020 13:29:17 +0000 Subject: [Koha-bugs] [Bug 25657] Import Patron fails without userid - not stated as required field in notes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25657 --- Comment #7 from Katrin Fischer --- Hi Elaine, is userid listed in your BorrowerMandatoryFields system preference by chance? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Jun 6 16:41:08 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 06 Jun 2020 14:41:08 +0000 Subject: [Koha-bugs] [Bug 23019] Ability to create 'matching profiles' when importing records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23019 --- Comment #28 from Tomás Cohen Arazi --- (In reply to Abbey Holt from comment #27) > (In reply to Tomás Cohen Arazi from comment #21) > > (In reply to Abbey Holt from comment #16) > > > This is great! There is one area where my matching preferences would not > > > stick when I created a profile. If I select "No" under "Check for embedded > > > item record data" and click "Add profile", No switches back to Yes. My > > > selection for "how to process items" is remembered. It is just the yes-no > > > button that isn't being saved. > > > > Abbey, I think you need to acknowledge the attachments count on the bug, and > > tell the sandboxes that you want to SO 5 patches. > > > Thank you. I think I've signed off on everything now. Let me know if I need > to do anything else! That worked great! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jun 6 16:50:16 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 06 Jun 2020 14:50:16 +0000 Subject: [Koha-bugs] [Bug 22417] Add a task queue In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22417 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 7 00:40:11 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 06 Jun 2020 22:40:11 +0000 Subject: [Koha-bugs] [Bug 24986] Maximum row size reached soon for borrowers and deletedborrowers In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24986 --- Comment #9 from Katrin Fischer --- borrowers is heavily queried for reports I believe - I am not sure if adding JSON would make this harder. I believe it would at least be a different syntax to learn? What about changing datatypes as the message suggests? We have quite of a mix on the table at the moment that could need a clean-up. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 7 00:57:20 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 06 Jun 2020 22:57:20 +0000 Subject: [Koha-bugs] [Bug 25322] Adding a guarantor with no relationship defaults to father In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25322 --- Comment #27 from Katrin Fischer --- Hi, I'll try to test, but just to make sure there is no misunderstanding: the issue is not the missing empty option and that it could be configured. The issue is, that you can select empty and save, but it won't save as empty, but select the first of your values (most of the time father, if you haven't changed defaults) That's the unexpected behaviour. 1) Create a new user or modify an existing one. 2) Under Guarantor Information, click on "Search to add" button 3) Perform your search, and select user to act as a guarantor 4) Do not use the dropdown menu to select a relationship. 5) Save the record 6) It will show the relationship as 'father' Comment#25 would work for me, but I am still not sure it should block this patch, which is a bug fix. We will also need a clear explanation on the system preference. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 7 01:03:03 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 06 Jun 2020 23:03:03 +0000 Subject: [Koha-bugs] [Bug 25685] New: Pyh Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25685 Bug ID: 25685 Summary: Pyh Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: About Assignee: koha-bugs at lists.koha-community.org Reporter: pisangbakar711 at gmail.com QA Contact: testopia at bugs.koha-community.org -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 7 01:19:25 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 06 Jun 2020 23:19:25 +0000 Subject: [Koha-bugs] [Bug 25685] SPAM In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25685 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |INVALID Status|NEW |RESOLVED Summary|Pyh |SPAM -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Jun 7 06:49:45 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 07 Jun 2020 04:49:45 +0000 Subject: [Koha-bugs] [Bug 25686] New: Catalogue search result doesn't link to Normal display Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25686 Bug ID: 25686 Summary: Catalogue search result doesn't link to Normal display Change sponsored?: --- Product: Koha Version: 19.11 Hardware: All OS: All Status: NEW Severity: critical Priority: P5 - low Component: bugs.koha-community.org Assignee: koha-bugs at lists.koha-community.org Reporter: iming at rosewoodfarm.com.au QA Contact: testopia at bugs.koha-community.org Created attachment 105608 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105608&action=edit Screen shot After you make a search and the search result appears. Click on any title and you get an error message of "The record you requested does not exist ()". Upon close inspection, I noticed that when you mouseover a title on the search result list, the biblionumber for that item is missing from the link URL. For example: https://koha.rosewoodfarm.com.au/cgi-bin/koha/catalogue/detail.pl?biblionumber=#####&searchid=scs_1591504570600 Once you entered a biblionumber, the normal catalogue record is showing. So looks like biblionumber has dropped out for every catalogue record! I'm running Koha 19.11.06.000 and have never made any setting change. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Jun 7 12:00:05 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 07 Jun 2020 10:00:05 +0000 Subject: [Koha-bugs] [Bug 25641] Koha/XSLT/Base.t is failing on U20 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25641 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #5 from Jonathan Druart --- Skipping QA, I want this one pushed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 7 12:03:23 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 07 Jun 2020 10:03:23 +0000 Subject: [Koha-bugs] [Bug 25638] API related tests failing on comparing floats In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25638 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |20.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 7 12:03:25 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 07 Jun 2020 10:03:25 +0000 Subject: [Koha-bugs] [Bug 25638] API related tests failing on comparing floats In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25638 --- Comment #13 from Jonathan Druart --- Pushed to master for 20.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 7 12:03:27 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 07 Jun 2020 10:03:27 +0000 Subject: [Koha-bugs] [Bug 25641] Koha/XSLT/Base.t is failing on U20 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25641 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |20.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 7 12:03:29 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 07 Jun 2020 10:03:29 +0000 Subject: [Koha-bugs] [Bug 25641] Koha/XSLT/Base.t is failing on U20 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25641 --- Comment #6 from Jonathan Druart --- Pushed to master for 20.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 7 12:04:50 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 07 Jun 2020 10:04:50 +0000 Subject: [Koha-bugs] [Bug 17390] Add REST API endpoint for Authorised Values In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17390 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|kyle at bywatersolutions.com |jonathan.druart at bugs.koha-c | |ommunity.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 7 12:05:12 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 07 Jun 2020 10:05:12 +0000 Subject: [Koha-bugs] [Bug 17390] Add REST API endpoint for Authorised Values In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17390 --- Comment #6 from Jonathan Druart --- I am going to work on this. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 7 12:42:58 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 07 Jun 2020 10:42:58 +0000 Subject: [Koha-bugs] [Bug 25686] Catalogue search result doesn't link to Normal display In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25686 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|critical |normal --- Comment #1 from Katrin Fischer --- Hi, I have tested in 19.11.06 and the links work ok for me from catalog and cataloguing search. Usually the error you see appears when your index is not up to date and you have records in the result list that have since been removed from Koha. Please try a full reindex. I am lowering the severity for now. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 7 12:59:33 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 07 Jun 2020 10:59:33 +0000 Subject: [Koha-bugs] [Bug 25322] Adding a guarantor with no relationship defaults to father In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25322 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #28 from Katrin Fischer --- Ok, I understand the problem with this patch now. borrowerRelationship: |father|mother With the patch: When you add an empty entry to the system preference, you end up with 2 empty entries in the list. None of them can be saved. Without the patch: The | has no effect - it shows an empty entry with |father|mother and with father|mother. You can save the empty entry, but it will result in father. I am leaning towards comment#25 now. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 7 13:31:58 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 07 Jun 2020 11:31:58 +0000 Subject: [Koha-bugs] [Bug 14648] Batch remove reserve items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14648 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 7 13:32:02 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 07 Jun 2020 11:32:02 +0000 Subject: [Koha-bugs] [Bug 14648] Batch remove reserve items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14648 --- Comment #12 from Katrin Fischer --- Created attachment 105609 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105609&action=edit Bug 14648: Batch remove reserve items Adds "Batch remove items" button to course-reserves.tt. Creates batch_rm_items.pl and batch_rm_items.tt. Allows user to enter a list of barcode numbers so that they will be removed from all course reserves to which they are attached. A dialog box will provide a warning before the final deletion is made. Test Plan 1. Log in as a user with permissions to add and delete course reserves 2. Add the same items to multiple course reserves 3. Go to the main course reserves page (i.e. /cgi-bin/koha/course_reserves/course-reserves.pl) 4. Click the "- Batch remove items" button 5. Enter the barcodes that you added to multiple reserves in step 1 6. Click submit 7. Click Ok if you are ready to delete all of these items 8. Check each course reserve that you added the items to in step 1 to make sure the items you entered were deleted but nothing else 9. Log out 10. Log in as a user without permission to delete course reserves 11. Go to the main course reserves page (i.e. /cgi-bin/koha/course_reserves/course-reserves.pl) 12. You should not longer see the "- Batch remove items" button Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 7 13:32:06 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 07 Jun 2020 11:32:06 +0000 Subject: [Koha-bugs] [Bug 14648] Batch remove reserve items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14648 --- Comment #13 from Katrin Fischer --- Created attachment 105610 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105610&action=edit Bug 14648: (follow-up) Remove formatting from note for better translatability Removes to avoid that the sentence is split into separate parts in translation files. Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 7 13:32:33 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 07 Jun 2020 11:32:33 +0000 Subject: [Koha-bugs] [Bug 14648] Batch remove reserve items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14648 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #105607|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 7 13:34:05 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 07 Jun 2020 11:34:05 +0000 Subject: [Koha-bugs] [Bug 14648] Batch remove reserve items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14648 --- Comment #14 from Katrin Fischer --- Hi Joe, thx for the patch! I noticed the attached patch file had a bit of a strange description - are you using git bz for attaching your patches? It makes interaction with Bugzilla very easy. I've done a follow-up, that I'd like to explain a bit:

All course reserve items will be deleted from all courses to which they are attached.

Will result in 3 separate strings to translate. - All course reserve items will be deleted from - all - courses to which they are attached I've seen there is a pre-existing occurence on the batch add feature, but we should fix that another time. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 7 13:42:05 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 07 Jun 2020 11:42:05 +0000 Subject: [Koha-bugs] [Bug 25680] When adding a new patron and missing to fill a field, on saving, the invalidFocus should show the focused field clearly in view. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25680 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply --- Comment #9 from Katrin Fischer --- I've tried to test this. I've left off cardnumber and it didn't center, but only appeared at the bottom of the screen. I was using Firefox, wonder if the browser makes a difference? I wanted to compare with the patch, but it currently doesn't apply. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 7 13:43:02 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 07 Jun 2020 11:43:02 +0000 Subject: [Koha-bugs] [Bug 25442] Release dates are missing from the timeline In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25442 --- Comment #12 from Katrin Fischer --- Is the alternative ready for testing? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 7 13:51:13 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 07 Jun 2020 11:51:13 +0000 Subject: [Koha-bugs] [Bug 25554] Refactor rule kinds assignments in CirculationRules.pm In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25554 --- Comment #4 from Katrin Fischer --- Hi Peter, can you explain about your future needs? At the moment I am with Jonathan, I think readability is to be preferred, even if resulting in more code. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 7 13:52:58 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 07 Jun 2020 11:52:58 +0000 Subject: [Koha-bugs] [Bug 25686] Catalogue search result doesn't link to Normal display In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25686 --- Comment #2 from Iming Chan --- After upgraded to 20.05 and fully reindex, the problem still exist. However I just noticed that in the staff client, on the search result list, if you click on the image column (whether there is a cover image or not), it will take you to the normal display (full catalogue record). Whereas, if you click on the title hyperlink, the "biblionumber" is missing and thus cannot get to the normal (full record display). In the OPAC, click on the cover image will take you to the full catalogue record. However, when there is no cover image ("No cover image" hidden), then you cannot get into the full catalogue record. You get an error message (see screenshot attached). Does this have anything to do with Bug # 24740 (implemented recently)? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Jun 7 13:54:06 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 07 Jun 2020 11:54:06 +0000 Subject: [Koha-bugs] [Bug 25686] Catalogue search result doesn't link to Normal display In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25686 --- Comment #3 from Iming Chan --- Created attachment 105611 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105611&action=edit OPAC full catalogue record access error -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Jun 7 13:56:31 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 07 Jun 2020 11:56:31 +0000 Subject: [Koha-bugs] [Bug 25642] Technical notes are missing from the release In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25642 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 7 13:56:35 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 07 Jun 2020 11:56:35 +0000 Subject: [Koha-bugs] [Bug 25642] Technical notes are missing from the release In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25642 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #105505|0 |1 is obsolete| | --- Comment #7 from Katrin Fischer --- Created attachment 105612 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105612&action=edit Bug 25642: Add technical notes Signed-off-by: Martin Renvoize Signed-off-by: Bernardo Gonzalez Kriegel Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 7 13:56:38 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 07 Jun 2020 11:56:38 +0000 Subject: [Koha-bugs] [Bug 25642] Technical notes are missing from the release In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25642 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #105584|0 |1 is obsolete| | --- Comment #8 from Katrin Fischer --- Created attachment 105613 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105613&action=edit Bug 25642: Fix description of new feature in update_dbix_class_files.pl Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 7 13:58:17 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 07 Jun 2020 11:58:17 +0000 Subject: [Koha-bugs] [Bug 25686] Catalogue search result doesn't link to Normal display In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25686 --- Comment #4 from Katrin Fischer --- Which MARC format are you using? Have you chanced the XSLT files in any way? I believe this could also happen if your biblionumber is not stored in the expected MARC field. For MARC21 this would be 999. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Jun 7 13:59:19 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 07 Jun 2020 11:59:19 +0000 Subject: [Koha-bugs] [Bug 25611] Changing the vendor when creating the basket does not keep that new vendor In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25611 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Changing the vendor when |Changing the vendor when |creating the Basket does |creating the basket does |not keep that new vendor. |not keep that new vendor -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 7 14:00:33 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 07 Jun 2020 12:00:33 +0000 Subject: [Koha-bugs] [Bug 20554] New OPAC CSS In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20554 --- Comment #56 from Katrin Fischer --- (In reply to David Cook from comment #55) > By the way, fontfaceobserver.min.js is getting flagged as the > Miner.Jswebcoin virus by Symantec Endpoint Protection. > > It says that Symantec have had it flagged for more than 1 year, and that the > file is untrustworthy. > > I have examined the Javascript, and it really appears to be a false > positive, but I'm noting it here anyway. > > I'm going to look at removing fontfaceobserver locally so that it can pass > security checks for the time being. Hi David, if we need to do something about this, please file a new bug report. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 7 14:01:23 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 07 Jun 2020 12:01:23 +0000 Subject: [Koha-bugs] [Bug 25679] If no value is set in the system preference NoIssueCharge, odd yellow box appears In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25679 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|If no value is set in the |If no value is set in the |system preference |system preference |NoIssueCharge, Odd Yellow |NoIssueCharge, odd yellow |Box appears |box appears -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Jun 7 14:03:05 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 07 Jun 2020 12:03:05 +0000 Subject: [Koha-bugs] [Bug 25679] If no value is set in the system preference NoIssueCharge, odd yellow box appears In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25679 --- Comment #1 from Katrin Fischer --- I don't see this behaviour on master - can you confirm it's only on 19.11? For a change I think it would be nice if we allowed deactivating by leaving empty, as that would make it more consistent with the other fine limit related prefs. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Jun 7 14:09:01 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 07 Jun 2020 12:09:01 +0000 Subject: [Koha-bugs] [Bug 25687] New: Switch Y/N in EDI accounts table for Yes and No for better translatability Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25687 Bug ID: 25687 Summary: Switch Y/N in EDI accounts table for Yes and No for better translatability Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard at myacpl.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org I think it would be easier to read and understand - and to translate, if we showed Yes and No instead of Y and N in the EDI accounts table for the checkboxes. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 7 14:09:55 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 07 Jun 2020 12:09:55 +0000 Subject: [Koha-bugs] [Bug 25677] Checkbox options for EDI accounts cannot be enabled In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25677 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 7 14:09:58 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 07 Jun 2020 12:09:58 +0000 Subject: [Koha-bugs] [Bug 25677] Checkbox options for EDI accounts cannot be enabled In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25677 --- Comment #3 from Katrin Fischer --- Created attachment 105614 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105614&action=edit Bug 25677: Checkbox options for EDI accounts cannot be enabled Checking any of the checkboxes in the EDI Account editor does nothing. They always remain set to "off". Test Plan: 1) Browse to edi_accounts.pl 2) Create a new EDI account, check all the checkboxes 3) Edit the account, note none of the checkboxes are checked 4) Apply this patch 5) Repeat steps 1-2 6) Note the checkboxes remain checked Signed-off-by: Andrew Fuerste-Henry Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 7 14:13:14 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 07 Jun 2020 12:13:14 +0000 Subject: [Koha-bugs] [Bug 25469] Typo: Item does not belongs to your library In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25469 --- Comment #2 from Katrin Fischer --- Hi Owen, looking at the code I found a clue in Items.pm safe_to_delete: "not_same_branch" if the item is blocked by independent branches, I think you need to be: - not superlibrarian - IndependentBranches on - login branch != homebranch of the item -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 7 14:15:08 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 07 Jun 2020 12:15:08 +0000 Subject: [Koha-bugs] [Bug 25686] Catalogue search result doesn't link to Normal display In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25686 --- Comment #5 from Iming Chan --- We are using Marc21 and the default XSLT is used (admin preference never changed). We have always used 999 $c and $d for biblionumber (even though, we also copy the exact same number to 001). See screenshot attached. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 7 14:15:43 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 07 Jun 2020 12:15:43 +0000 Subject: [Koha-bugs] [Bug 25686] Catalogue search result doesn't link to Normal display In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25686 --- Comment #6 from Iming Chan --- Created attachment 105615 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105615&action=edit MARC screenshot. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Jun 7 14:16:43 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 07 Jun 2020 12:16:43 +0000 Subject: [Koha-bugs] [Bug 25675] System preference PatronSelfRegistration incorrectly described In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25675 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |String patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 7 14:16:46 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 07 Jun 2020 12:16:46 +0000 Subject: [Koha-bugs] [Bug 25675] System preference PatronSelfRegistration incorrectly described In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25675 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #105562|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer --- Created attachment 105616 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105616&action=edit Bug 25675: Reword and reorganize sysprefs related to patron self modification To Test: 1: apply patch 2: restart all 3: go to System Preferences > OPAC 4: confirm "Self registration" section is now labeled "Self registration and modification" 5: confirm OPACPatronDetails is now in the "Self registration and modification" section 6: confirm PatronSelfRegistration now reads "(Allow / Don't allow) library patrons to register for an account via the OPAC." 7: set OPACPatronDetails to Don't allow 8: set PatronSelfRegistration to Allow 9: log into the opac and verify you're not able to edit your patron details on an existing account Signed-off-by: DonnaB Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 7 14:18:51 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 07 Jun 2020 12:18:51 +0000 Subject: [Koha-bugs] [Bug 25686] Catalogue search result doesn't link to Normal display In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25686 --- Comment #7 from Katrin Fischer --- Sorry, not sure what's going on then. I can't replicate the bug on a fresh 19.11 installation. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Jun 7 14:21:03 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 07 Jun 2020 12:21:03 +0000 Subject: [Koha-bugs] [Bug 25686] Catalogue search result doesn't link to Normal display In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25686 --- Comment #8 from Iming Chan --- I suspect this problem only occurred after we upgraded to 19.11.06 as it was working fine last week. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Jun 7 14:23:44 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 07 Jun 2020 12:23:44 +0000 Subject: [Koha-bugs] [Bug 25658] Print icon sometimes obscures patron barcode In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25658 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 7 14:23:48 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 07 Jun 2020 12:23:48 +0000 Subject: [Koha-bugs] [Bug 25658] Print icon sometimes obscures patron barcode In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25658 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #105560|0 |1 is obsolete| | --- Comment #4 from Katrin Fischer --- Created attachment 105617 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105617&action=edit Bug 25658: Print icon sometimes obscures patron barcode This patch alters the style of the patron name/cardnumber label on the checkout screen so that it has a maximum width. This will help avoid the label being obscured by the print/close buttons displayed when DisplayClearScreenButton is enabled. To test, apply the patch and rebuild the staff client CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client). - Enable the DisplayClearScreenButton system preference. - Check out to a patron. Resize the browser to confirm that at narrower browser widths the patron name in the checkout form isn't obscured by the print and clear screen buttons. Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 7 14:42:06 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 07 Jun 2020 12:42:06 +0000 Subject: [Koha-bugs] [Bug 25554] Refactor rule kinds assignments in CirculationRules.pm In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25554 --- Comment #5 from Andrew Nugged --- Here we need to have more filtering criteria for smart-rules. For Finnish libraries, we added "ccode" and "sleving_location", two extra smart rule filters (but by the way also later we propose this for the community version) so we had before: my $scope3 = [ 'branchcode', 'categorycode', 'itemtype' ]; but now we have in our case: my $scope3 = [ 'branchcode', 'categorycode', 'itemtype', 'ccode', 'shelving_location' ]; and because of having only a single variable, we don't need to change any variable names down in the file, nor copy-paste dozen times like it is now the same array copypasted everywhere. But now proposal from Jonathan to name it something like "$branch_category_itemtype" will make this: my $branch_category_itemtype = [ 'branchcode', 'categorycode', 'itemtype' ]; becoming this (???): my $branch_category_itemtype_ccode_shelving_location = [ 'branchcode', 'categorycode', 'itemtype', 'ccode', 'shelving_location' ]; so when we add two extra items, we should again change all the code down below to the new variable name $branch_category_itemtype_ccode_shelving_location? Yikes! That's why we voting for "$scope3", because we have three scope sections, even logically separated: small one, middle, and full. ... Oh, or let's name it "$scope_full" if you ok? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 7 14:53:01 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 07 Jun 2020 12:53:01 +0000 Subject: [Koha-bugs] [Bug 25552] Add missing Claims Returned option to MarkLostItemsAsReturned In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25552 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #8 from Katrin Fischer --- I believe this is still not working right. The item is only returned when I check the 'charge lost fee' check box. Please explain, when adding a new patch. I think we are also going to need unit tests. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 7 15:08:01 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 07 Jun 2020 13:08:01 +0000 Subject: [Koha-bugs] [Bug 25676] Staff client catalog search shows incorrect item status under location In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25676 --- Comment #3 from Katrin Fischer --- I believe the issue is here: koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/results.tt: ([% onloan_items_loo.count | html %][% IF ( onloan_items_loo.longoverdue ) %], [% onloan_items_loo.longoverdue | html %] long overdue[% END %]) date due: [% onloan_items_loo.due_date | $KohaDates %] And that leads us to Search.pm making wrong assumptions: # if something's checked out and lost, mark it as 'long overdue' if ( $item->{itemlost} ) { $onloan_items->{$key}->{longoverdue}++; $longoverdue_count++; } And now we have an issue: we can't guarantee which value is the long overdue value lost value. If a library isn't using the long overdue prefs but using command line parameters. So maybe we need to change this to just show the lost description as is. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 7 15:08:09 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 07 Jun 2020 13:08:09 +0000 Subject: [Koha-bugs] [Bug 25676] Staff client catalog search shows incorrect item status under location In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25676 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Version|19.11 |master Severity|enhancement |normal -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Jun 7 15:10:47 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 07 Jun 2020 13:10:47 +0000 Subject: [Koha-bugs] [Bug 25643] Move maxreserves functionality into circulation rules In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25643 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Remove maxreserves syspref |Move maxreserves | |functionality into | |circulation rules -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 7 15:14:18 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 07 Jun 2020 13:14:18 +0000 Subject: [Koha-bugs] [Bug 25688] New: 'All libraries' terminology used on first page of circulation rules is confusing Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25688 Bug ID: 25688 Summary: 'All libraries' terminology used on first page of circulation rules is confusing Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard at myacpl.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org CC: andrew at bywatersolutions.com Our circulation rules page has undergone some terminology changes over the years, but at the moment, it seems quite confusing as discussions on some bugs (example: 25643) have shown. We say "default for all libraries" but actually, it's just "default for each libary" as the default rules page is used, when no library specific rule exists. Counts like 'number of holds' or 'number of checkouts' will not count for 'all libraries' but only for the 'individual library'. We should look for a way to make this more obvious in our wording. Would "default for a library" or "default for each library" work in English? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 7 15:14:18 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 07 Jun 2020 13:14:18 +0000 Subject: [Koha-bugs] [Bug 25643] Move maxreserves functionality into circulation rules In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25643 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=25688 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Jun 7 15:15:47 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 07 Jun 2020 13:15:47 +0000 Subject: [Koha-bugs] [Bug 25643] Move maxreserves functionality into circulation rules In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25643 --- Comment #12 from Katrin Fischer --- I think a new page would probably be best. Don't mix up things on the first page - it's already confusing. Funnily, when adding bug 25688 for the terminology issue, I found another really old bug about this problem: Bug 8371 - Add global level issuing rules (number of checkouts over all libraries, etc.) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 7 15:16:03 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 07 Jun 2020 13:16:03 +0000 Subject: [Koha-bugs] [Bug 25643] Move maxreserves functionality into circulation rules In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25643 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=8371 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 7 15:16:03 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 07 Jun 2020 13:16:03 +0000 Subject: [Koha-bugs] [Bug 8371] Add global level issuing rules (number of checkouts over all libraries, etc.) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8371 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=25643 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Jun 7 15:17:32 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 07 Jun 2020 13:17:32 +0000 Subject: [Koha-bugs] [Bug 23112] Add circulation process to inter-library loans In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23112 --- Comment #89 from Katrin Fischer --- (In reply to Jonathan Druart from comment #88) > +use Carp::Always; > > That should be removed, right? Should we file a new bug? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 7 15:19:26 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 07 Jun 2020 13:19:26 +0000 Subject: [Koha-bugs] [Bug 25593] Terminology: Fix "There is no order for this biblio." on catalog detail page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25593 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 7 15:19:30 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 07 Jun 2020 13:19:30 +0000 Subject: [Koha-bugs] [Bug 25593] Terminology: Fix "There is no order for this biblio." on catalog detail page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25593 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #105550|0 |1 is obsolete| | --- Comment #2 from Katrin Fischer --- Created attachment 105618 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105618&action=edit Bug 25593: Terminology: Fix "There is no order for this biblio." on catalog detail page This patch changes the phrase "There is no order for this biblio" to "There is no order for this bibliographic record." on the catalog detail page. To test, apply the patch and view the bibliographic detail page for a record which has no order associated with it. The text in the "Acquisitions details" tab should be correct. Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 7 15:20:25 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 07 Jun 2020 13:20:25 +0000 Subject: [Koha-bugs] [Bug 25593] Terminology: Fix "There is no order for this biblio." on catalog detail page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25593 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #3 from Katrin Fischer --- Moving this straight to PQA (simple string change). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 7 15:24:02 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 07 Jun 2020 13:24:02 +0000 Subject: [Koha-bugs] [Bug 25627] Move OPAC problem reports from administration to tools In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25627 --- Comment #2 from Katrin Fischer --- Hi Owen, thanks for taking this on! I was wondering if we should group it with patrons and circulation instead, as only logged in patrons can provide problem reports. What do you think? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 7 15:25:59 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 07 Jun 2020 13:25:59 +0000 Subject: [Koha-bugs] [Bug 25689] New: Move 'Manage OPAC problem reports' permission into tools Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25689 Bug ID: 25689 Summary: Move 'Manage OPAC problem reports' permission into tools Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Tools Assignee: koha-bugs at lists.koha-community.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org Depends on: 25627 There is no reason for this permission to be a module level permission - it has no sub permission and as such currently is not set up quite right (compare to others like editauthorities). I propose that we move it to the tools permissions after bug 25627 has been resolved. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25627 [Bug 25627] Move OPAC problem reports from administration to tools -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Jun 7 15:25:59 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 07 Jun 2020 13:25:59 +0000 Subject: [Koha-bugs] [Bug 25627] Move OPAC problem reports from administration to tools In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25627 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |25689 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25689 [Bug 25689] Move 'Manage OPAC problem reports' permission into tools -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 7 15:32:50 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 07 Jun 2020 13:32:50 +0000 Subject: [Koha-bugs] [Bug 25673] Access logging of borrower's personal information In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25673 --- Comment #1 from Katrin Fischer --- I think it really depends on the type of library, country, use cases etc. I think we'd definitely see some push back if we replaced the name by the cardnumber in general as this is seen as a feature. Libraries often know their patrons and want to see the names in a lot of cases. (think small company libraries, professors at universities etc.) But: we already have HidePatronName which makes this configurable in a lot of places that we could extend further. I think logging every page could get a lot pretty fast. Maybe we could start with viewing a patron record? (accessing the detail page) We should also make sure that patron batch edits are logged correctly. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 7 15:33:51 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 07 Jun 2020 13:33:51 +0000 Subject: [Koha-bugs] [Bug 20168] Update of the OPAC bootstrap template to bootstrap v4 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20168 --- Comment #7 from Katrin Fischer --- Hi Owen, is this ready for testing or are you still working on it? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 7 19:33:18 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 07 Jun 2020 17:33:18 +0000 Subject: [Koha-bugs] [Bug 25513] Integer casting in Koha::Object->TO_JSON causes random test failures In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25513 --- Comment #30 from Victor Grousset/tuxayo --- Hm, bug still happened on Ubuntu 18.04 for last 3 builds. https://jenkins.koha-community.org/job/Koha_Master_U18/813/ https://jenkins.koha-community.org/job/Koha_Master_U18/812/ https://jenkins.koha-community.org/job/Koha_Master_U18/811/ -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 7 23:41:20 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 07 Jun 2020 21:41:20 +0000 Subject: [Koha-bugs] [Bug 25659] Hide batch actions from reports results if no permissions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25659 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |23349 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23349 [Bug 23349] Add batch operations to staff interface catalog search results -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Jun 7 23:41:20 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 07 Jun 2020 21:41:20 +0000 Subject: [Koha-bugs] [Bug 23349] Add batch operations to staff interface catalog search results In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23349 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |25659 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25659 [Bug 25659] Hide batch actions from reports results if no permissions -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 8 00:19:17 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 07 Jun 2020 22:19:17 +0000 Subject: [Koha-bugs] [Bug 18974] Cataloging MARC21 record and adding item selenium test In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18974 --- Comment #18 from Victor Grousset/tuxayo --- (In reply to Jonathan Druart from comment #17) > I am not sure I understand. > Make the tests pass using the default framework will be a good first step. The issue is that I wasn't getting the same record from LOC every time. And some have missing 040 and 245. Which doesn't comply with the default framework. I've fixed this by searching for an ISBN instead of a title + author. > tuxayo: > > # Idea from the current cleanup(): (whose code seems mostly not related to > > this test) > > # - name the record specifically like test_cataloging_workflow > > # - delete it and it's related items > > # - question: isn't it risky about data integrity? > > Data integrity? Why? Due to direct SQL DB modification. Actually it's not risky, that just means I need advice from someone who knows what do delete to cleanup a record + item creation. i.e. In which tables they span + eventual stuff that the Koha data layer does. > > # Another idea: > > # - pick a random number and replace the ISBN by it > > You can generate random data using TestBuilder is you like, then delete the > object and reuse the data, like: Thanks, that will be handy for other tests. For this one, the need is more low level right? (A random ISBN to replace the one that came from Z39.50 to avoid collisions). So, easy also. > In basic_workflow.t we use hardcoded values, that can work too. It won't help here because the issue is when the test is ran twice. But before going into this (cleaning up) or creating unique data that won't collide went test is ran twice: Should we rely on bug 19821 instead? That would block this patch and there other (less than a month, on maybe I'm too optimistic) but allow to not add and test code to handle cleanup. Including the case of the test that failed or was interrupted. We aim for the new tests to be backportable right? If so, do you think bug 19821 could be backported? I can spend time on that for each branch (especially since I would like to improve the coverage down to my branch ^^) but not matter how much, I don't know if it would be OK from a QA POV. If we aim to backport and depending on bug 19821 prevents that, then I would lean towards doing the current way of cleanup. And benefit from bug 19821 only in a future cycle. == Annex == Current state: diff: https://gitlab.com/tuxayo/Koha/-/commit/8935d1edc50156cea9dc16b56284c2994d941a0d whole test file: https://gitlab.com/tuxayo/Koha/-/blob/8935d1edc50156cea9dc16b56284c2994d941a0d/t/db_dependent/selenium/cataloging_workflow.t -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 8 06:31:37 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Jun 2020 04:31:37 +0000 Subject: [Koha-bugs] [Bug 25690] New: SIP allows to check out an item with hold in transfer to another patron Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25690 Bug ID: 25690 Summary: SIP allows to check out an item with hold in transfer to another patron Change sponsored?: --- Product: Koha Version: 20.05 Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Circulation Assignee: koha-bugs at lists.koha-community.org Reporter: minna.kivinen at hamk.fi QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com When system preference AllowItemsOnHoldCheckout is enabled, SIP allows another patron to check out an item with hold in transfer. After that the item is attached both to hold (reserves-table) and issue (issues table). The system should allow to check out an item to another patron than the one with hold, when item is attached to hold and is in transfer. This bug leads to unfortunate situations where patron with hold never gets the item. Borrower can't renew item since there is the hold, but the borrower can check in the item by self service station and check out again despite the hold in item. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 8 07:10:36 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Jun 2020 05:10:36 +0000 Subject: [Koha-bugs] [Bug 25680] When adding a new patron and missing to fill a field, on saving, the invalidFocus should show the focused field clearly in view. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25680 --- Comment #10 from Timothy Alexis Vass --- (In reply to Katrin Fischer from comment #9) > I was using Firefox, wonder if > the browser makes a difference? In this situation does. :) > I wanted to compare with the patch, but it currently doesn't apply. Is there an error? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Jun 8 07:20:50 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Jun 2020 05:20:50 +0000 Subject: [Koha-bugs] [Bug 25680] When adding a new patron and missing to fill a field, on saving, the invalidFocus should show the focused field clearly in view. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25680 Timothy Alexis Vass changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #105577|0 |1 is obsolete| | --- Comment #11 from Timothy Alexis Vass --- Created attachment 105619 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105619&action=edit Bug 25680 - When adding a new patron and missing to fill a field, on saving, the invalidFocus should show the focused field clearly in view. This patch will center the focused field at the golden section in the window. To test: 1) Begin to add a new patron. 2) Leave a required field empty, which is outside the screen view, and click Save. 3) Notice that the field is at the bottom, behind the language bar if there is one. 4) Apply patch 5) Add a new patron. 6) Leave the required field empty again and Save. 7) Notice that the required field is now clearly shown in view. 8) Sign off. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 8 07:32:14 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Jun 2020 05:32:14 +0000 Subject: [Koha-bugs] [Bug 25680] When adding a new patron and missing to fill a field, on saving, the invalidFocus should show the focused field clearly in view. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25680 Timothy Alexis Vass changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #105574|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Jun 8 07:34:31 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Jun 2020 05:34:31 +0000 Subject: [Koha-bugs] [Bug 25680] When adding a new patron and missing to fill a field, on saving, the invalidFocus should show the focused field clearly in view. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25680 Timothy Alexis Vass changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff --- Comment #12 from Timothy Alexis Vass --- (In reply to Katrin Fischer from comment #9) > I wanted to compare with the patch, but it currently doesn't apply. There was an old attachment that I had to obsolete. Please try it again now with the correct one. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 8 07:38:55 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Jun 2020 05:38:55 +0000 Subject: [Koha-bugs] [Bug 25477] The responsive design in opac-main.tt should be correct In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25477 --- Comment #15 from Timothy Alexis Vass --- Options are nice, of course. But only when all available options are fully functional. I suggest we go forward with this. To replace the 3-column layout completely, since it is broken. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 8 07:50:53 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Jun 2020 05:50:53 +0000 Subject: [Koha-bugs] [Bug 24911] Exception holidays treated as unique holidays in calendar In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24911 --- Comment #4 from Emmi Takkinen --- (In reply to Katrin Fischer from comment #3) > Hm, I think there is no point to have an exception for a unique holiday = > you could just delete it. So maybe we should not allow exceptions in that > case and suggest to remove from the calendar instead? I agree. So we could just hide the option to generate exception when selected holiday is unique. Also seems like this was already reported in bug 9918. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 8 07:51:10 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Jun 2020 05:51:10 +0000 Subject: [Koha-bugs] [Bug 25513] Integer casting in Koha::Object->TO_JSON causes random test failures In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25513 --- Comment #31 from Jonathan Druart --- I confirm I can make it fail 100% of the time on U18, but only occasionally on D10 (hum?) On U18 it's failing on the tests we wrote for this specific problem ("Regression tests for bug 25513"), but on D10 it fails on another one: t/db_dependent/api/v1/acquisitions_orders.t .. 1/5 # Failed test 'SWAGGER3.3.2' # at t/db_dependent/api/v1/acquisitions_orders.t line 129. # Structures begin differing at: # $got->{ecost_tax_included} = '2.7621662673219e+21' # $expected->{ecost_tax_included} = '2762166267321895092224.000000' -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 8 09:02:35 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Jun 2020 07:02:35 +0000 Subject: [Koha-bugs] [Bug 25284] Can't open /var/log/koha/kohadev/opac-error.log (Permission denied) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25284 --- Comment #24 from Jonathan Druart --- There are users on the ML reporting such problems on upgrade. Should we deal with that somewhere else. Like in koha-common.postinst? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 8 09:06:02 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Jun 2020 07:06:02 +0000 Subject: [Koha-bugs] [Bug 25691] New: Debian packages point to /usr/share/doc/koha/README.Debian which does not exist Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25691 Bug ID: 25691 Summary: Debian packages point to /usr/share/doc/koha/README.Debian which does not exist Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Packaging Assignee: koha-bugs at lists.koha-community.org Reporter: jonathan.druart at bugs.koha-community.org QA Contact: testopia at bugs.koha-community.org CC: mirko at abunchofthings.net debian/changelog: * Add notes about README.Debian to package description and postinst output. debian/control: Please see /usr/share/doc/koha/README.Debian for instructions on how to debian/control.in: Please see /usr/share/doc/koha/README.Debian for instructions on how to debian/koha.postinst:Please see /usr/share/doc/koha/README.Debian for instructions on how to -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Jun 8 09:07:07 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Jun 2020 07:07:07 +0000 Subject: [Koha-bugs] [Bug 25691] Debian packages point to /usr/share/doc/koha/README.Debian which does not exist In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25691 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj at kohaaloha.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 8 09:35:28 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Jun 2020 07:35:28 +0000 Subject: [Koha-bugs] [Bug 18974] Cataloging MARC21 record and adding item selenium test In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18974 --- Comment #19 from Jonathan Druart --- (In reply to Victor Grousset/tuxayo from comment #18) > (In reply to Jonathan Druart from comment #17) > > I am not sure I understand. > > Make the tests pass using the default framework will be a good first step. > > The issue is that I wasn't getting the same record from LOC every time. And > some have missing 040 and 245. Which doesn't comply with the default > framework. > > I've fixed this by searching for an ISBN instead of a title + author. In a first step I'd not rely on network (so no search from LOC). > > tuxayo: > > > # Idea from the current cleanup(): (whose code seems mostly not related to > > > this test) > > > # - name the record specifically like test_cataloging_workflow > > > # - delete it and it's related items > > > # - question: isn't it risky about data integrity? > > > > Data integrity? Why? > > Due to direct SQL DB modification. Actually it's not risky, that just means > I need advice from someone who knows what do delete to cleanup a record + > item creation. i.e. In which tables they span + eventual stuff that the Koha > data layer does. I'd delete the item and record using selenium (click delete buttons). Then you need: itemtype and branches. Actually will you know which data you need to delete as you will have to create them. > > > # Another idea: > > > # - pick a random number and replace the ISBN by it > > > > You can generate random data using TestBuilder is you like, then delete the > > object and reuse the data, like: > > Thanks, that will be handy for other tests. For this one, the need is more > low level right? (A random ISBN to replace the one that came from Z39.50 to > avoid collisions). So, easy also. > > > In basic_workflow.t we use hardcoded values, that can work too. > > It won't help here because the issue is when the test is ran twice. It should not, if you cleanup if won't face issues if the test is ran several times. > But before going into this (cleaning up) or creating unique data that won't > collide went test is ran twice: Should we rely on bug 19821 instead? > That would block this patch and there other (less than a month, on maybe I'm > too optimistic) but allow to not add and test code to handle cleanup. > Including the case of the test that failed or was interrupted. No, don't rely on bug 19821. You will have to cleanup anyway. If the test explodes in mid-air there will be data that won't be removed. Don't bother about that, it is how it works already. > We aim for the new tests to be backportable right? > If so, do you think bug 19821 could be backported? I can spend time on that > for each branch (especially since I would like to improve the coverage down > to my branch ^^) but not matter how much, I don't know if it would be OK > from a QA POV. Master first, usually enhancements are not backported. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 8 10:13:49 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Jun 2020 08:13:49 +0000 Subject: [Koha-bugs] [Bug 25683] update_patron_categories.pl should recognize no fine history = 0 outstanding fines In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25683 --- Comment #1 from Jonathan Druart --- Created attachment 105620 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105620&action=edit Bug 25683: (bug 17168 follow-up) Don't consider negative balance Test plan: - Have a patron with nothing in accountlines - run update_patron_categories to find patrons with fines under $5 (-fu=5) - Your patron is not found - Give your patron a manual charge of $1 - rerun the cron, your patron is found - pay off your patron's fine, putting their balance at $0 - rerun the cron, your patron is not found -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 8 10:14:34 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Jun 2020 08:14:34 +0000 Subject: [Koha-bugs] [Bug 25683] update_patron_categories.pl should recognize no fine history = 0 outstanding fines In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25683 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |jonathan.druart at bugs.koha-c |ity.org |ommunity.org Status|NEW |In Discussion CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #2 from Jonathan Druart --- Isn't it actually a hidden feature to search for negative balance (credit)? If not you can test this patch! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 8 10:18:30 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Jun 2020 08:18:30 +0000 Subject: [Koha-bugs] [Bug 25266] Not all vendors are listed in the filters on the late order claims page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25266 Alex Arnaud changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #105329|0 |1 is obsolete| | --- Comment #27 from Alex Arnaud --- Created attachment 105621 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105621&action=edit Bug 25266: Build the vendor list from the order list This patch is removing the use of GetBooksellersWithLateOrders and use the late order list to generate the vendors. Test plan: Create several vendors, several orders, close the baskets Also create vendors that do not have orders (or basket not closed) Go to the late orders page and confirm that the list of vendors is correctly filled, select one, you can see the "select all" link in the header of the table QA: that would be good to test this with production data and compare execution time. Signed-off-by: Katrin Fischer Signed-off-by: Alex Arnaud -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 8 10:18:35 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Jun 2020 08:18:35 +0000 Subject: [Koha-bugs] [Bug 25266] Not all vendors are listed in the filters on the late order claims page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25266 Alex Arnaud changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #105330|0 |1 is obsolete| | --- Comment #28 from Alex Arnaud --- Created attachment 105622 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105622&action=edit Bug 25266: Remove C4::Bookseller This was the only occurrence of GetBooksellersWithLateOrders and it was the only subroutine of C4::Bookseller Signed-off-by: Katrin Fischer Signed-off-by: Alex Arnaud -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 8 10:18:38 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Jun 2020 08:18:38 +0000 Subject: [Koha-bugs] [Bug 25266] Not all vendors are listed in the filters on the late order claims page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25266 Alex Arnaud changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #105331|0 |1 is obsolete| | --- Comment #29 from Alex Arnaud --- Created attachment 105623 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105623&action=edit Bug 25266: Fix error when no later order If no late order we got: "Argument passed to the 'IN' operator can not be undefined" It highlights a context error Signed-off-by: Katrin Fischer Signed-off-by: Alex Arnaud -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 8 10:18:42 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Jun 2020 08:18:42 +0000 Subject: [Koha-bugs] [Bug 25266] Not all vendors are listed in the filters on the late order claims page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25266 Alex Arnaud changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #105592|0 |1 is obsolete| | --- Comment #30 from Alex Arnaud --- Created attachment 105624 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105624&action=edit Bug 25266: Remove uneeded var Signed-off-by: Alex Arnaud -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 8 10:19:09 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Jun 2020 08:19:09 +0000 Subject: [Koha-bugs] [Bug 25266] Not all vendors are listed in the filters on the late order claims page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25266 Alex Arnaud changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 8 10:21:04 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Jun 2020 08:21:04 +0000 Subject: [Koha-bugs] [Bug 25686] Catalogue search result doesn't link to Normal display In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25686 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #9 from Jonathan Druart --- What do you have in OPACXSLTResultsDisplay? Did you modify the default XSLT? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Jun 8 10:29:56 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Jun 2020 08:29:56 +0000 Subject: [Koha-bugs] [Bug 25686] Title in the catalogue search result doesn't open the full (normal) record display In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25686 Iming Chan changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Catalogue search result |Title in the catalogue |doesn't link to Normal |search result doesn't open |display |the full (normal) record | |display -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Jun 8 10:30:27 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Jun 2020 08:30:27 +0000 Subject: [Koha-bugs] [Bug 25686] Title in the catalogue search result doesn't open the full (normal) record display In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25686 --- Comment #10 from Jonathan Druart --- Also, try to restart memcached, then koha-common. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Jun 8 10:36:34 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Jun 2020 08:36:34 +0000 Subject: [Koha-bugs] [Bug 25686] Title in the catalogue search result doesn't open the full (normal) record display In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25686 --- Comment #11 from Iming Chan --- We have made no change to any of our setting. Our IT person has setup an auto upgrade of Koha when available and we got 19.11.06 recently. To attempt to fix this problem, we have upgraded to 20.05 since without luck. It seems that you have to click on the cover image instead of title to open the full catalogue (normal display). This causes a major problem in our OPAC as not all items have cover image. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 8 10:36:44 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Jun 2020 08:36:44 +0000 Subject: [Koha-bugs] [Bug 25442] Release dates are missing from the timeline In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25442 --- Comment #13 from Martin Renvoize --- Yes, please take a look at the alternative.. the script used to produce it is available here: https://gitlab.com/koha-community/release-tools/-/blob/master/bin/get_developers.pl With the relevant code changes in the last two commits, the former of which just uncomments the Time::Moment handling to ensure we use epoch time of the commit for the display line in the history and the latter adds handling to catching versions via git tags. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 8 10:37:46 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Jun 2020 08:37:46 +0000 Subject: [Koha-bugs] [Bug 25554] Refactor rule kinds assignments in CirculationRules.pm In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25554 --- Comment #6 from Jonathan Druart --- What about the following? $scopes => [ { scope => [ qw( branchcode ) ], rules => [ qw( refund ) ], }, { scope => [ qw( branchcode categorycode ) ], rules => [ qw( patron_maxissueqty patron_maxonsiteissueqty max_holds ... ) ], }, ... { scope => [ qw( branchcode categorycode itemtype ) ], rules => [ qw( article_requests auto_renew cap_fine_to_replacement_price ...) ], }, ]; ie you define using a different structure, then you "revert" it to generate the existing structure. Don't implement it yet, I am not sure I agree with myself :D -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 8 10:39:19 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Jun 2020 08:39:19 +0000 Subject: [Koha-bugs] [Bug 25686] Title in the catalogue search result doesn't open the full (normal) record display In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25686 --- Comment #12 from Iming Chan --- I'm suspecting this behaviour may have something to do with Bug # 24740. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 8 10:49:19 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Jun 2020 08:49:19 +0000 Subject: [Koha-bugs] [Bug 25442] Release dates are missing from the timeline In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25442 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #105523|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 8 10:49:36 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Jun 2020 08:49:36 +0000 Subject: [Koha-bugs] [Bug 25442] Release dates are missing from the timeline In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25442 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff Assignee|jonathan.druart at bugs.koha-c |martin.renvoize at ptfs-europe |ommunity.org |.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 8 11:02:38 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Jun 2020 09:02:38 +0000 Subject: [Koha-bugs] [Bug 25686] Title in the catalogue search result doesn't open the full (normal) record display In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25686 --- Comment #13 from Jonathan Druart --- I don't think it's related with bug 24740. Please confirm the value in the syspref and that you correctly restart the different services. The problem you have is that the variable "biblionumber" is not correctly picked for the XSLT processing. I also see different uncommon things in your catalogue: - https://snipboard.io/scgRqV.jpg - you have itemtypes with '*', like '*_LB', is that correct? Did you create it recently? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 8 11:02:51 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Jun 2020 09:02:51 +0000 Subject: [Koha-bugs] [Bug 25686] Title in the catalogue search result doesn't open the full (normal) record display In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25686 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Version|19.11 |master -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Jun 8 11:11:38 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Jun 2020 09:11:38 +0000 Subject: [Koha-bugs] [Bug 25526] Using Write Off Selected will not allow for a different amount to be written off In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25526 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |martin.renvoize at ptfs-europe |y.org |.com CC| |martin.renvoize at ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Jun 8 11:30:32 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Jun 2020 09:30:32 +0000 Subject: [Koha-bugs] [Bug 25692] New: update MARC::Transform in debian.koha-community.org Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25692 Bug ID: 25692 Summary: update MARC::Transform in debian.koha-community.org Change sponsored?: --- Product: Koha Version: 20.05 Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs at lists.koha-community.org Reporter: stephane.delaune at biblibre.com QA Contact: testopia at bugs.koha-community.org Hi, I am the developer of the Perl module MARC::Transform ( https://metacpan.org/pod/MARC::Transform ), this module is in version 0.003008 since april 2019 but, in debian.koha-community.org, the version is only 0.003006 that is 5 years old (2 versions late, including a bugfix) the MARC::Transform module has been updated in february on https://packages.qa.debian.org/libm/libmarc-transform-perl.html to this latest version 0.003008 unfortunately, and although I informed the main protagonists at that time (Mason James, Mirko Tietgen, Renvoize Martin), this updated version is not in debian.koha-community.org ( http://debian.koha-community.org/koha/dists/20.05/main/binary-amd64/Packages ) someone could update MARC::Transform in debian.koha-community.org ? regards -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Jun 8 11:30:36 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Jun 2020 09:30:36 +0000 Subject: [Koha-bugs] [Bug 25526] Using Write Off Selected will not allow for a different amount to be written off In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25526 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 8 11:35:26 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Jun 2020 09:35:26 +0000 Subject: [Koha-bugs] [Bug 25526] Using Write Off Selected will not allow for a different amount to be written off In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25526 --- Comment #4 from Martin Renvoize --- The proposed patch circumvents the serverside under-collection protection. To test: 1/ Disable javascript in the browser (in chrome you can do this via the developer tool > settings > disable Javascript) 2/ Attempt to pay part of a fine... enter an amount less than the 'amount being paid' into the 'amount tendered' box 3/ Without the patch, you would be faced with an undercollection error message (the yellow error box mentioned above) 4/ With the patch, you will not face any errors and the full payment amount will have been recorded against the accountable, not the lower amount you actually collected from the patron. Failing QA - Correct patch to follow. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 8 11:39:34 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Jun 2020 09:39:34 +0000 Subject: [Koha-bugs] [Bug 25526] Using Write Off Selected will not allow for a different amount to be written off In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25526 --- Comment #5 from Martin Renvoize --- Created attachment 105625 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105625&action=edit Bug 25526: [ALTERNATIVE] Equality matching is case sensative TEST PLAN: 1. Have a fine on a Patron's account. 2. Choose the "Write off Selected" button 3. Enter an amount less than the amount owed by the patron. 4. Koha will give a yellow box with a note "You must collect a value greater than or equal to 2.00." The $2.00 is the amount that is attempted to write off (the amount less than the amount owed). 5. Apply patch 6. Again try to writeoff an amount less than the amount owed. 7. You should be able to write it off. 8. Try paying an amount more than owed, you should still get an error. You shouldn't be able to write off more than the amount. 9. Follow the above steps via 'Pay selected' as aposed to 'Writeoff selected'. 10. You should not be able to 'Tender' less than the amount you have 'Paid'. 11. Disable Javascript and run through all the above steps. You should still be blocked where relevant. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Jun 8 11:39:34 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Jun 2020 09:39:34 +0000 Subject: [Koha-bugs] [Bug 22522] API authentication breaks with updated Mojolicious version In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22522 --- Comment #57 from Jonathan Druart --- Kyle, using master-bionic and 19.11.x + your patch I get: t/db_dependent/api/v1/acquisitions_funds.t ............. 1/13 # Failed test '401 Unauthorized' # at t/db_dependent/api/v1/acquisitions_funds.t line 67. # got: '200' # expected: '401' Use of uninitialized value $_[2] in hash element at /usr/share/perl5/Mojolicious/Plugin/OpenAPI.pm line 275. And lot of similar failures -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 8 11:41:23 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Jun 2020 09:41:23 +0000 Subject: [Koha-bugs] [Bug 25538] www/search_utf8.t is failing randomly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25538 --- Comment #4 from Jonathan Druart --- (In reply to Tomás Cohen Arazi from comment #3) > You need to make sure the used fw has the checked girls set to display in > the relevant interface. Why would that make it fail randomly? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 8 11:51:36 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Jun 2020 09:51:36 +0000 Subject: [Koha-bugs] [Bug 25526] Using Write Off Selected will not allow for a different amount to be written off In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25526 --- Comment #6 from Martin Renvoize --- Created attachment 105627 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105627&action=edit Bug 25526: Equality matching is case sensative TEST PLAN: 1. Have a fine on a Patron's account. 2. Choose the "Write off Selected" button 3. Enter an amount less than the amount owed by the patron. 4. Koha will give a yellow box with a note "You must collect a value greater than or equal to 2.00." The $2.00 is the amount that is attempted to write off (the amount less than the amount owed). 5. Apply patch 6. Again try to writeoff an amount less than the amount owed. 7. You should be able to write it off. 8. Try paying an amount more than owed, you should still get an error. You shouldn't be able to write off more than the amount. 9. Follow the above steps via 'Pay selected' as aposed to 'Writeoff selected'. 10. You should not be able to 'Tender' less than the amount you have 'Paid'. 11. Disable Javascript and run through all the above steps. You should still be blocked where relevant. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Jun 8 11:51:49 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Jun 2020 09:51:49 +0000 Subject: [Koha-bugs] [Bug 25526] Using Write Off Selected will not allow for a different amount to be written off In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25526 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #105528|0 |1 is obsolete| | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 8 11:51:58 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Jun 2020 09:51:58 +0000 Subject: [Koha-bugs] [Bug 25526] Using Write Off Selected will not allow for a different amount to be written off In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25526 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #105625|0 |1 is obsolete| | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 8 11:54:28 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Jun 2020 09:54:28 +0000 Subject: [Koha-bugs] [Bug 25526] Using Write Off Selected will not allow for a different amount to be written off In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25526 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #7 from Martin Renvoize --- Bonus points.. the updated patch also fixes a related error. Test Plan 1/ Check the write-off permissions for the same scenarios and you will find the prior to this patch, they were not properly adhered to at the serverside -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Jun 8 11:54:45 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Jun 2020 09:54:45 +0000 Subject: [Koha-bugs] [Bug 22417] Add a task queue In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22417 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #105543|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 8 11:55:34 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Jun 2020 09:55:34 +0000 Subject: [Koha-bugs] [Bug 22417] Add a task queue In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22417 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- URL| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=22417#c30 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 8 11:56:56 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Jun 2020 09:56:56 +0000 Subject: [Koha-bugs] [Bug 22522] API authentication breaks with updated Mojolicious version In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22522 --- Comment #58 from Martin Renvoize --- I think we need all the Auth.pm changes in the first patch on this series: -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 8 11:57:54 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Jun 2020 09:57:54 +0000 Subject: [Koha-bugs] [Bug 25692] update MARC::Transform in debian.koha-community.org In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25692 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org, | |mtj at kohaaloha.com Component|Architecture, internals, |Packaging |and plumbing | --- Comment #1 from Jonathan Druart --- Mason, could you have a look at this? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 8 12:01:49 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Jun 2020 10:01:49 +0000 Subject: [Koha-bugs] [Bug 24986] Maximum row size reached soon for borrowers and deletedborrowers In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24986 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #105548|0 |1 is obsolete| | --- Comment #10 from Martin Renvoize --- Created attachment 105628 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105628&action=edit Bug 24986: Modify some borrowers DB fields to (TINY|MEDIUM)TEXT Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 8 12:05:34 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Jun 2020 10:05:34 +0000 Subject: [Koha-bugs] [Bug 24986] Maximum row size reached soon for borrowers and deletedborrowers In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24986 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com Status|Needs Signoff |Signed Off --- Comment #11 from Martin Renvoize --- I think the patch proposed here is a good (and back portable) fix for the issue in hand so I'm signing off. However, I do think we should certainly split out addresses into their own table and follow proper 3rd normal form for then.. but I think that should be on it's own bug.. (actually.. i thought there was already a bug for that, but I can't seem to find it). As for using JSON.. I'm not sure what that would win us really.. I like JSON fields and used them in a postgres based system a while ago.. but the querying did end up considerably more complex in the end and I ended up converting some fields back to additional tables and using JOIN queries instead for performance and readability reasons (dbic isn't great with JSON queries yet either).. I'd say for now at least.. we don't have any cases where the advantage of JSON fields outweighs the cost.. yet.. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 8 12:13:33 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Jun 2020 10:13:33 +0000 Subject: [Koha-bugs] [Bug 14543] Order lines updated that have a tax rate not in gist will have tax rate set to 0! In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14543 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #105404|0 |1 is obsolete| | --- Comment #12 from Martin Renvoize --- Created attachment 105629 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105629&action=edit Bug 14543: Order lines updated that have a tax rate not in gist will have tax rate set to 0! If the tax rate for a given order line has been removed from the system preference gist, that tax rate will show in the pulldown as 0. If a librarian then saves the order line the original tax rate will be overwritten with 0%! Test Plan: 1) Find an order line 2) Remove the tax rate set for that order line from the syspref gist 3) Edit the order line 4) Note the tax rate is 0 5) Apply this patch 6) Edit the order line 7) Note the tax rate now displays with a warning Signed-off-by: Victor Grousset/tuxayo Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 8 12:13:36 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Jun 2020 10:13:36 +0000 Subject: [Koha-bugs] [Bug 14543] Order lines updated that have a tax rate not in gist will have tax rate set to 0! In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14543 --- Comment #13 from Martin Renvoize --- Created attachment 105630 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105630&action=edit Bug 14543: (QA follow-up) Add missing filter This patch adds a missing `| html` filter to the tax_rate value option that the patchset adds Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 8 12:14:03 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Jun 2020 10:14:03 +0000 Subject: [Koha-bugs] [Bug 14543] Order lines updated that have a tax rate not in gist will have tax rate set to 0! In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14543 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com Status|Signed Off |Passed QA --- Comment #14 from Martin Renvoize --- Works as expected, with QA followup we pass the QA scripts. Passing QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 8 12:21:51 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Jun 2020 10:21:51 +0000 Subject: [Koha-bugs] [Bug 11175] Show the parent record's component parts in the detailed views In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175 Joonas Kylmälä changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #79810|0 |1 is obsolete| | --- Comment #58 from Joonas Kylmälä --- Created attachment 105631 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105631&action=edit Bug 11175: Show record component parts in the detail view Shows the component records of a host, on the hosts detail view in staff client or OPAC, with clickable links to the component records. The host does not require linking entries to the components, but components do require a link to the host record via 773$w. Adds a new search index, Control-number-identifier (aka cni), which indexes the 003 controlfield. Adds 'Yet Another System Preference', ShowComponentRecords, which can be used to turn this feature on or off in staff client and/or OPAC, and defaults to off. When looking up the component part records, the code searches for records with (773$w=Host001 and 003=Host003) or 773$w='Host003 Host001' or, if the 003 is not defined in the Host, 773$w=Host001. Does not use easyanalytics or useControlNumber. Only for MARC21 biblios - UNIMARC has not been updated. staff-global.css and opac.css have not been recreated, so you need to use sass to recreate those from staff-global.scss and opac.scss Test plan: 0) Apply patch 1) perl bulkmarcimport -file /tmp/easypiano.mrc -m MARCXML (This file is an attachment on the bug) 2) rebuild the zebra biblio index 3) Search for "easy piano" in staff client, and go to the biblio detail page. You should not see anything different in the record detail page. 4) Do the same on OPAC. 5) Change the ShowComponentRecords syspref appropriately and check the record detail page in staff client and OPAC. You should see a list of component part records. Rebased-by: Joonas Kylmälä -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 8 12:26:36 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Jun 2020 10:26:36 +0000 Subject: [Koha-bugs] [Bug 11175] Show the parent record's component parts in the detailed views In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175 Joonas Kylmälä changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |ASSIGNED Assignee|pasi.kallinen at koha-suomi.fi |joonas.kylmala at helsinki.fi --- Comment #59 from Joonas Kylmälä --- I rebased the earlier patch and will now start working on follow-ups for the two problems raised by Josef in comment #38: 1. Please, provide tests for this method 2. Do not return explicit undef I think it's is not bad idea to finish this implementation, the refactoring to DB table based implementation can be done later, this already adds a nice UI. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 8 12:29:08 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Jun 2020 10:29:08 +0000 Subject: [Koha-bugs] [Bug 24986] Maximum row size reached soon for borrowers and deletedborrowers In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24986 --- Comment #12 from Jonathan Druart --- I think we need to recreate the problem and confirm that the patch fixes it. Not only guess it will do the trick (as I did). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 8 12:37:15 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Jun 2020 10:37:15 +0000 Subject: [Koha-bugs] [Bug 25537] Page reload at branchtransfers.pl loses destination branch In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25537 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #105476|0 |1 is obsolete| | --- Comment #3 from Martin Renvoize --- Created attachment 105632 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105632&action=edit Bug 25537: Page reload at branchtransfers.pl loses destination branch At branchtransfers.pl, one selects a destination branch and scans in any number of items to generate transfers to that branch. However, anything that makes the page reload causes your branch selection to be lost, reverting you back to whichever branch comes first alphabetically. This is an invitation to error when one has a stack of books to send all to the same branch. Could that error handling get moved into a modal or something that won't reload the page? Test Plan: 1) Place a hold on an item and set it to waiting 2) Initiate a branch transfer from branchtransfers.pl for any branch but the first in the pulldown branch selector 3) Choose to cancel the hold and transfer 4) Note the pulldown reverts to the first option 5) Apply this patch 6) Repeat steps 1-3 7) Note the pulldown retains your preveiously selected branch! Signed-off-by: Andrew Fuerste-Henry Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 8 12:37:43 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Jun 2020 10:37:43 +0000 Subject: [Koha-bugs] [Bug 25537] Page reload at branchtransfers.pl loses destination branch In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25537 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com Status|Signed Off |Passed QA --- Comment #4 from Martin Renvoize --- Simple and clear patch, no missing filters etc.. Passing QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 8 12:40:36 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Jun 2020 10:40:36 +0000 Subject: [Koha-bugs] [Bug 25284] Can't open /var/log/koha/kohadev/opac-error.log (Permission denied) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25284 --- Comment #25 from Jonathan Druart --- There is _check_and_fix_perms in koha-plack to fix plack.log and plack-error.log. But that does not seem the right place. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 8 13:04:19 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Jun 2020 11:04:19 +0000 Subject: [Koha-bugs] [Bug 24003] REST API should set C4::Context->userenv In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24003 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 8 13:04:23 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Jun 2020 11:04:23 +0000 Subject: [Koha-bugs] [Bug 24003] REST API should set C4::Context->userenv In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24003 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #105586|0 |1 is obsolete| | Attachment #105587|0 |1 is obsolete| | Attachment #105588|0 |1 is obsolete| | --- Comment #12 from Kyle M Hall --- Created attachment 105633 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105633&action=edit Bug 24003: Regression tests This patch adds regression tests for the different authentication mechanisms Koha supports. It highlights the fact that Koha expects userenv to be set on authentication. Signed-off-by: Tomas Cohen Arazi Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 8 13:04:44 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Jun 2020 11:04:44 +0000 Subject: [Koha-bugs] [Bug 24003] REST API should set C4::Context->userenv In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24003 --- Comment #13 from Kyle M Hall --- Created attachment 105634 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105634&action=edit Bug 24003: Make the API set userenv on authentication This patch makes the authentication step stash the user that got authenticated so code outside the Mojo part of Koha can use it (i.e. through the use of C4::Context->userenv). To test: 1. Apply the regression tests 2. Run: $ kshell k$ prove t/db_dependent/api/v1/auth_authenticate_api_request.t \ t/db_dependent/api/v1/auth_basic.t => FAIL: Tests fail! 3. Apply this patch 4. Repeat 2 => SUCCESS: Tests pass! Signed-off-by: Tomas Cohen Arazi Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 8 13:04:48 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Jun 2020 11:04:48 +0000 Subject: [Koha-bugs] [Bug 24003] REST API should set C4::Context->userenv In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24003 --- Comment #14 from Kyle M Hall --- Created attachment 105635 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105635&action=edit Bug 24003: (follow-up) Move interface setting to a more readable place Signed-off-by: Tomas Cohen Arazi Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 8 13:08:01 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Jun 2020 11:08:01 +0000 Subject: [Koha-bugs] [Bug 25634] koha-foreach exits too early if any command has non-zero status In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25634 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 8 13:08:04 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Jun 2020 11:08:04 +0000 Subject: [Koha-bugs] [Bug 25634] koha-foreach exits too early if any command has non-zero status In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25634 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #105478|0 |1 is obsolete| | --- Comment #7 from Kyle M Hall --- Created attachment 105636 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105636&action=edit Bug 25634: [Alternate] Warn if koha-shell returns non-zero in koha-foreach By putting koha-shell in an if statement, "set -e" will no longer cause the entire koha-foreach program to exit, if koha-shell returns a non-zero status. If a non-zero status is returned, we warn on it, and the caller of koha-foreach can interpret that command visually. To Test: 1) Write a shell script that says "Hello" and then exits with a 1 status 2) Run koha-foreach against that shell script with multiple instances available to koha-foreach 3) Before the patch, koha-foreach will die after the first "Hello" 4) After the patch, koha-foreach will continue, through all the instances, and report which instances returned non-zero statuses by which command. Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 8 13:16:40 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Jun 2020 11:16:40 +0000 Subject: [Koha-bugs] [Bug 25526] Using Write Off Selected will not allow for a different amount to be written off In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25526 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Jun 8 13:16:44 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Jun 2020 11:16:44 +0000 Subject: [Koha-bugs] [Bug 25526] Using Write Off Selected will not allow for a different amount to be written off In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25526 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #105627|0 |1 is obsolete| | --- Comment #8 from Kyle M Hall --- Created attachment 105637 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105637&action=edit Bug 25526: Equality matching is case sensative TEST PLAN: 1. Have a fine on a Patron's account. 2. Choose the "Write off Selected" button 3. Enter an amount less than the amount owed by the patron. 4. Koha will give a yellow box with a note "You must collect a value greater than or equal to 2.00." The $2.00 is the amount that is attempted to write off (the amount less than the amount owed). 5. Apply patch 6. Again try to writeoff an amount less than the amount owed. 7. You should be able to write it off. 8. Try paying an amount more than owed, you should still get an error. You shouldn't be able to write off more than the amount. 9. Follow the above steps via 'Pay selected' as aposed to 'Writeoff selected'. 10. You should not be able to 'Tender' less than the amount you have 'Paid'. 11. Disable Javascript and run through all the above steps. You should still be blocked where relevant. Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 8 13:21:30 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Jun 2020 11:21:30 +0000 Subject: [Koha-bugs] [Bug 25037] Add checkout_type to checkouts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25037 --- Comment #60 from Lari Taskula --- Created attachment 105638 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105638&action=edit Bug 25037: (follow-up) Fix checkout_type property description Also adds a test of the property to checkouts.t REST test. To test: 1. prove t/db_dependent/api/v1/checkouts.t -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 8 13:22:08 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Jun 2020 11:22:08 +0000 Subject: [Koha-bugs] [Bug 25037] Add checkout_type to checkouts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25037 Lari Taskula changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 8 13:22:35 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Jun 2020 11:22:35 +0000 Subject: [Koha-bugs] [Bug 25037] Add checkout_type to checkouts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25037 --- Comment #61 from Lari Taskula --- (In reply to Joonas Kylmälä from comment #59) > Comment on attachment 104268 [details] [review] > Bug 25037: Replace occurences to issues.onsite_checkout > > Review of attachment 104268 [details] [review]: > ----------------------------------------------------------------- > > I checked all the other patches and they were looking good! > > ::: api/v1/swagger/definitions/checkout.json > @@ +53,5 @@ > > "description": "Date the item was issued" > > }, > > + "checkout_type": { > > + "type": ["string", "null"], > > + "description": "Checkout type, an authorised value under CHECKOUT_TYPE category" > > The description is still from the v1 version where authorized values were > used. Could you here a) add enum for values "CHECKOUT" and "ONSITE" and b) > update the description. Done! Thanks for noticing. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 8 13:40:50 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Jun 2020 11:40:50 +0000 Subject: [Koha-bugs] [Bug 24003] REST API should set C4::Context->userenv In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24003 --- Comment #15 from Jonathan Druart --- Why are you only setting the borrowernumber? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 8 13:59:01 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Jun 2020 11:59:01 +0000 Subject: [Koha-bugs] [Bug 25284] Can't open /var/log/koha/kohadev/opac-error.log (Permission denied) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25284 --- Comment #26 from Tomás Cohen Arazi --- (In reply to Jonathan Druart from comment #25) > There is _check_and_fix_perms in koha-plack to fix plack.log and > plack-error.log. > But that does not seem the right place. koha-common.postinst -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 8 14:03:45 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Jun 2020 12:03:45 +0000 Subject: [Koha-bugs] [Bug 24003] REST API should set C4::Context->userenv In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24003 --- Comment #16 from Tomás Cohen Arazi --- (In reply to Jonathan Druart from comment #15) > Why are you only setting the borrowernumber? On the API, this is only relevant for action_logs and probably filtering in plural classes. If it is going to be used from the UI, then authentication would be cookie-based, which sets all the things anyway. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 8 14:06:48 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Jun 2020 12:06:48 +0000 Subject: [Koha-bugs] [Bug 6918] Can't place holds on 'on order' items with AllowOnShelfHolds off In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6918 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com Status|Signed Off |Failed QA --- Comment #54 from Martin Renvoize --- Sorry.. but I'm not seeing any Unit Tests... so failing QA for that. As a side note.. I think I would have preferred to see a new method 'CountItemsOrdered' as opposed to adding logic into 'CountItemsIssued' as it makes the methods purpose less well defined/clear. It could, of course, be entirely differently named or in the Koha::Object world perhaps be a chainable filter on an Koha::Items's set? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 8 14:09:07 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Jun 2020 12:09:07 +0000 Subject: [Koha-bugs] [Bug 25690] SIP allows to check out an item with hold in transfer to another patron In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25690 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrew at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 8 14:13:48 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Jun 2020 12:13:48 +0000 Subject: [Koha-bugs] [Bug 25693] New: Correct permissions must be set on logdir after an upgrade Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25693 Bug ID: 25693 Summary: Correct permissions must be set on logdir after an upgrade Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: major Priority: P5 - low Component: Packaging Assignee: jonathan.druart at bugs.koha-community.org Reporter: jonathan.druart at bugs.koha-community.org QA Contact: testopia at bugs.koha-community.org CC: mtj at kohaaloha.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 8 14:13:49 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Jun 2020 12:13:49 +0000 Subject: [Koha-bugs] [Bug 22522] API authentication breaks with updated Mojolicious version In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22522 --- Comment #59 from Martin Renvoize --- Created attachment 105639 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105639&action=edit Bug 22522: Add support for current Mojolicious in 19.11 This patch allows tests to succeed with the following versions: JSON::Validator 3.18 Mojolicious 8.32 Mojolicious::Plugin::OpenAPI 2.21 Also Mojolicious::Plugin::OpenAPI version 1.17 and later 1.x versions now work. Calling valid_input in under() would cause ' Use of uninitialized value $_[2] ' in more recent OpenAPI plugins, so that was changed too. As far as I can see this does not affect authorization. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 8 14:14:08 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Jun 2020 12:14:08 +0000 Subject: [Koha-bugs] [Bug 25284] Can't open /var/log/koha/kohadev/opac-error.log (Permission denied) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25284 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |25693 --- Comment #27 from Jonathan Druart --- See bug 25693. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25693 [Bug 25693] Correct permissions must be set on logdir after an upgrade -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 8 14:14:08 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Jun 2020 12:14:08 +0000 Subject: [Koha-bugs] [Bug 25693] Correct permissions must be set on logdir after an upgrade In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25693 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |25284 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25284 [Bug 25284] Can't open /var/log/koha/kohadev/opac-error.log (Permission denied) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 8 14:14:49 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Jun 2020 12:14:49 +0000 Subject: [Koha-bugs] [Bug 22522] API authentication breaks with updated Mojolicious version In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22522 --- Comment #60 from Martin Renvoize --- I believe my alternative to Kyle's should do the trick.. it's literally the REST/V1/Auth.pm changes from the first patch here, just without all the test updates included. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 8 14:15:00 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Jun 2020 12:15:00 +0000 Subject: [Koha-bugs] [Bug 25552] Add missing Claims Returned option to MarkLostItemsAsReturned In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25552 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #9 from Kyle M Hall --- (In reply to Katrin Fischer from comment #8) > I believe this is still not working right. The item is only returned when I > check the 'charge lost fee' check box. > > Please explain, when adding a new patch. I think we are also going to need > unit tests. My followup fixes exactly the issue you are describing. I just re-tested and it's still working for me. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 8 14:15:53 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Jun 2020 12:15:53 +0000 Subject: [Koha-bugs] [Bug 25693] Correct permissions must be set on logdir after an upgrade In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25693 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 8 14:15:56 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Jun 2020 12:15:56 +0000 Subject: [Koha-bugs] [Bug 25693] Correct permissions must be set on logdir after an upgrade In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25693 --- Comment #1 from Jonathan Druart --- Created attachment 105640 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105640&action=edit Bug 25693: Set correct permissions on logdir after an upgrade Since bug 25172 we are failing loudly if the permissions are not correct and that the logger cannot init successfully. We must set the correct permission on upgrading. koha-create deals with new installs -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 8 14:17:30 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Jun 2020 12:17:30 +0000 Subject: [Koha-bugs] [Bug 11175] Show the parent record's component parts in the detailed views In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175 --- Comment #60 from Joonas Kylmälä --- Created attachment 105641 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105641&action=edit Bug 11175: (follow-up) Don't return explicitly undef This would create in list context an list of one element that is undef, which we don't want, we want empty list if there are no components. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 8 14:18:18 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Jun 2020 12:18:18 +0000 Subject: [Koha-bugs] [Bug 22606] Memcached Issues after Upgrade In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22606 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |DUPLICATE CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #2 from Jonathan Druart --- *** This bug has been marked as a duplicate of bug 22217 *** -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Jun 8 14:18:18 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Jun 2020 12:18:18 +0000 Subject: [Koha-bugs] [Bug 22217] error "Connection to the memcached servers '__MEMCACHED_SERVERS__' failed" during install In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22217 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mehmet.akgul at mirakil.com --- Comment #6 from Jonathan Druart --- *** Bug 22606 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 8 14:22:08 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Jun 2020 12:22:08 +0000 Subject: [Koha-bugs] [Bug 24003] REST API should set C4::Context->userenv In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24003 --- Comment #17 from Jonathan Druart --- Say you are going to implement the DELETE route for items, you will need to call Koha::Item->safe_to_delete. 246 return "not_same_branch" 247 if defined C4::Context->userenv 248 and !C4::Context->IsSuperLibrarian() 249 and C4::Context->preference("IndependentBranches") 250 and ( C4::Context->userenv->{branch} ne $self->homebranch ); Don't you want the branch to be defined at this point? Isn't that the purpose of this patch? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 8 14:26:52 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Jun 2020 12:26:52 +0000 Subject: [Koha-bugs] [Bug 25693] Correct permissions must be set on logdir after an upgrade In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25693 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|major |blocker --- Comment #2 from Jonathan Druart --- Upping severity as it impacts stable release upgrades -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 8 14:32:41 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Jun 2020 12:32:41 +0000 Subject: [Koha-bugs] [Bug 25681] Patron categories sorted inconsistently In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25681 --- Comment #1 from Owen Leonard --- The "New patron" dropdown menu comes from patron-toolbar.inc, in which the patron categories are retrieved using a template plugin, Categories.pm. This lets the include file be embedded in multiple pages without modifying those pages' corresponding scripts to include category retrieval code. The patron entry page has its own code to retrieve both category type and category information. Perhaps the template plugin could be modified to provide more information when necessary? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 8 14:37:08 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Jun 2020 12:37:08 +0000 Subject: [Koha-bugs] [Bug 8371] Add global level issuing rules (number of checkouts over all libraries, etc.) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8371 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrew at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 8 14:45:34 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Jun 2020 12:45:34 +0000 Subject: [Koha-bugs] [Bug 22522] API authentication breaks with updated Mojolicious version In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22522 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #105591|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 8 14:49:09 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Jun 2020 12:49:09 +0000 Subject: [Koha-bugs] [Bug 22522] API authentication breaks with updated Mojolicious version In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22522 --- Comment #61 from Jonathan Druart --- still not working but it's better. Only 3 are failing now: t/db_dependent/api/v1/libraries.t t/db_dependent/api/v1/patrons.t t/db_dependent/api/v1/patrons_password.t with things like # Failed test 'has value for JSON Pointer "ARRAY(0x558849c58998)"' # at t/db_dependent/api/v1/libraries.t line 92. # Looks like you failed 17 tests of 51. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 8 15:00:22 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Jun 2020 13:00:22 +0000 Subject: [Koha-bugs] [Bug 24003] REST API should set C4::Context->userenv In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24003 --- Comment #18 from Tomás Cohen Arazi --- (In reply to Jonathan Druart from comment #17) > Say you are going to implement the DELETE route for items, you will need to > call Koha::Item->safe_to_delete. > > 246 return "not_same_branch" > > 247 if defined C4::Context->userenv > > 248 and !C4::Context->IsSuperLibrarian() > > 249 and C4::Context->preference("IndependentBranches") > 250 and ( C4::Context->userenv->{branch} ne $self->homebranch ); > > Don't you want the branch to be defined at this point? Isn't that the > purpose of this patch? I'm fixing a current bug on stable branches. If we were to think this in terms of the project future devs, I would rather stash the full Koha::Patron for the logged user and get rid of all that cruft we've been porting to Koha::* -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 8 15:07:36 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Jun 2020 13:07:36 +0000 Subject: [Koha-bugs] [Bug 25693] Correct permissions must be set on logdir after an upgrade In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25693 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Version|unspecified |master CC| |tomascohen at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 8 15:11:17 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Jun 2020 13:11:17 +0000 Subject: [Koha-bugs] [Bug 25693] Correct permissions must be set on logdir after an upgrade In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25693 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #3 from Tomás Cohen Arazi --- Extracted the code snippet and tested it on its own. Works as expected. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 8 15:11:21 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Jun 2020 13:11:21 +0000 Subject: [Koha-bugs] [Bug 25693] Correct permissions must be set on logdir after an upgrade In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25693 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #105640|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 8 15:11:58 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Jun 2020 13:11:58 +0000 Subject: [Koha-bugs] [Bug 25693] Correct permissions must be set on logdir after an upgrade In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25693 --- Comment #4 from Tomás Cohen Arazi --- Created attachment 105642 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105642&action=edit Bug 25693: Set correct permissions on logdir after an upgrade Since bug 25172 we are failing loudly if the permissions are not correct and that the logger cannot init successfully. We must set the correct permission on upgrading. koha-create deals with new installs Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 8 15:17:00 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Jun 2020 13:17:00 +0000 Subject: [Koha-bugs] [Bug 25552] Add missing Claims Returned option to MarkLostItemsAsReturned In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25552 --- Comment #10 from Kyle M Hall --- Created attachment 105643 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105643&action=edit Bug 25552: Unit tests -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 8 15:44:19 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Jun 2020 13:44:19 +0000 Subject: [Koha-bugs] [Bug 25693] Correct permissions must be set on logdir after an upgrade In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25693 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #105642|0 |1 is obsolete| | --- Comment #5 from Martin Renvoize --- Created attachment 105644 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105644&action=edit Bug 25693: Set correct permissions on logdir after an upgrade Since bug 25172 we are failing loudly if the permissions are not correct and that the logger cannot init successfully. We must set the correct permission on upgrading. koha-create deals with new installs Signed-off-by: Tomas Cohen Arazi Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 8 15:44:28 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Jun 2020 13:44:28 +0000 Subject: [Koha-bugs] [Bug 25693] Correct permissions must be set on logdir after an upgrade In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25693 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com QA Contact|testopia at bugs.koha-communit |martin.renvoize at ptfs-europe |y.org |.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 8 15:45:03 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Jun 2020 13:45:03 +0000 Subject: [Koha-bugs] [Bug 25693] Correct permissions must be set on logdir after an upgrade In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25693 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #6 from Martin Renvoize --- Built a package and trialled an upgrade.. worked as expected for me.. Passing QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 8 15:47:57 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Jun 2020 13:47:57 +0000 Subject: [Koha-bugs] [Bug 25599] Allow use of cataloguing placeholders when ACQ framework is used creating new record (UseACQFrameworkForBiblioRecords) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25599 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com QA Contact|testopia at bugs.koha-communit |martin.renvoize at ptfs-europe |y.org |.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 8 15:48:03 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Jun 2020 13:48:03 +0000 Subject: [Koha-bugs] [Bug 25599] Allow use of cataloguing placeholders when ACQ framework is used creating new record (UseACQFrameworkForBiblioRecords) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25599 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #105429|0 |1 is obsolete| | --- Comment #3 from Martin Renvoize --- Created attachment 105645 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105645&action=edit Bug 25599: Fix default value placeholders for UseACQFrameworkForBiblioRecords The feature was there but a condition disabled it. Test plan: - modify the default value for 008@ or another subfield in the ACQ framework using one or more of the placeholders above - activate UseACQFrameworkForBiblioRecords - create a basket - create an order from a new record - verify the values have been replaced Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 8 15:48:20 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Jun 2020 13:48:20 +0000 Subject: [Koha-bugs] [Bug 25599] Allow use of cataloguing placeholders when ACQ framework is used creating new record (UseACQFrameworkForBiblioRecords) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25599 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #4 from Martin Renvoize --- Good catch, works as expected now.. Passing QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 8 15:50:48 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Jun 2020 13:50:48 +0000 Subject: [Koha-bugs] [Bug 16994] Import and export MARC modification templates In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16994 Kelly McElligott changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kelly at bywatersolutions.com --- Comment #3 from Kelly McElligott --- This would be awesome in Mana! My first thought was exporting - as Owen commented, but Mana would be way easier and cooler. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 8 15:52:59 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Jun 2020 13:52:59 +0000 Subject: [Koha-bugs] [Bug 25677] Checkbox options for EDI accounts cannot be enabled In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25677 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #105564|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 8 16:00:42 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Jun 2020 14:00:42 +0000 Subject: [Koha-bugs] [Bug 14648] Batch remove reserve items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14648 --- Comment #15 from Joe Sikowitz --- Hi Katrin, thanks for the info. No, I haven't used git bz before, but I'll look at it and start to use it. I'm a bit new to the git/Bugzilla world so I'm still learning the ins and outs of getting my patches to the community. Thanks for all of your help! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 8 16:00:58 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Jun 2020 14:00:58 +0000 Subject: [Koha-bugs] [Bug 25545] Invoice page - Adjustments are not included in the Total + adjustments + shipment cost (Column tax. inc.) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25545 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |martin.renvoize at ptfs-europe |y.org |.com CC| |martin.renvoize at ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 8 16:01:53 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Jun 2020 14:01:53 +0000 Subject: [Koha-bugs] [Bug 25545] Invoice page - Adjustments are not included in the Total + adjustments + shipment cost (Column tax. inc.) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25545 --- Comment #7 from Martin Renvoize --- Not sure I agree with the capitalization change.. I'd say each 'piece' in the sum is it's own title.. as such should be treated as a noun and thus capitalized.. no? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 8 16:08:28 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Jun 2020 14:08:28 +0000 Subject: [Koha-bugs] [Bug 22522] API authentication breaks with updated Mojolicious version In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22522 --- Comment #62 from Martin Renvoize --- I've been looking at this and in reality.. I think what we really need is to just backport the whole set correctly.. I'm not sure what stopped it from being backported in the first place to be honest. I've had a go at backporting locally and it applies with minor conflicts to resolve on the 19.11 branch pretty easily. (all of it, including all the tests fixes).. The problem I'm having however, is that running all the tests to check they're now working against a KOHA_IMAGE=19.11-bionic koha-testing-docker crashes my dev server entirely for unknown reasons at the moment.. hence I've not submitted the set on mass yet. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 8 16:11:30 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Jun 2020 14:11:30 +0000 Subject: [Koha-bugs] [Bug 25545] Invoice page - Adjustments are not included in the Total + adjustments + shipment cost (Column tax. inc.) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25545 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #105443|0 |1 is obsolete| | --- Comment #8 from Martin Renvoize --- Created attachment 105646 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105646&action=edit Bug 25545: Add adjustments to total tax included Adjustments are not affected by tax, they are meant as a way to alter invoice values after receiving (damaged items, refuneds, extra charges, etc) When adjustments were added the tax included column was missed To test: - Add a basket with at least one order - Close it - Receive shipment - Receive the order - Finish receiving - Add an adjustment of any amount - Verify in the invoice details table: - Total tax exc. is showing including the adjustmnt - Total tax inc. is missing the adjustment - Apply patch - Reload - Total tax exc. is showing including the adjustmnt - Total tax inc. is showing including the adjustment Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 8 16:11:34 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Jun 2020 14:11:34 +0000 Subject: [Koha-bugs] [Bug 25545] Invoice page - Adjustments are not included in the Total + adjustments + shipment cost (Column tax. inc.) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25545 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #105444|0 |1 is obsolete| | --- Comment #9 from Martin Renvoize --- Created attachment 105647 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105647&action=edit Bug 25545: (follow-up) Fix capitalization Total + Adjustments + Shipment cost ($) changed to: Total + adjustments + shipment cost ($) Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 8 16:12:24 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Jun 2020 14:12:24 +0000 Subject: [Koha-bugs] [Bug 25545] Invoice page - Adjustments are not included in the Total + adjustments + shipment cost (Column tax. inc.) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25545 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #10 from Martin Renvoize --- No point in holding up QA.. I've SO'd on both, but leave the decision about capitalization I've raised to the RM -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 8 16:15:11 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Jun 2020 14:15:11 +0000 Subject: [Koha-bugs] [Bug 25694] New: Add ability to delete a Marc Modification Template when viewing Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25694 Bug ID: 25694 Summary: Add ability to delete a Marc Modification Template when viewing Change sponsored?: --- Product: Koha Version: 19.11 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Tools Assignee: koha-bugs at lists.koha-community.org Reporter: kelly at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org Currently, the ability to delete a Template in Marc Modification templates only exists from the marc_modification_templates.pl, however, it would be nice to have the ability to delete the template, when you are looking at the actions of that template. If you accidentally make two templates of the same name and want to delete one, it is hard to be sure which one you are deleting from the list of the templates without seeing the actions of each one. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 8 16:20:59 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Jun 2020 14:20:59 +0000 Subject: [Koha-bugs] [Bug 25634] koha-foreach exits too early if any command has non-zero status In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25634 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #105636|0 |1 is obsolete| | --- Comment #8 from Martin Renvoize --- Created attachment 105648 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105648&action=edit Bug 25634: [Alternate] Warn if koha-shell returns non-zero in koha-foreach By putting koha-shell in an if statement, "set -e" will no longer cause the entire koha-foreach program to exit, if koha-shell returns a non-zero status. If a non-zero status is returned, we warn on it, and the caller of koha-foreach can interpret that command visually. To Test: 1) Write a shell script that says "Hello" and then exits with a 1 status 2) Run koha-foreach against that shell script with multiple instances available to koha-foreach 3) Before the patch, koha-foreach will die after the first "Hello" 4) After the patch, koha-foreach will continue, through all the instances, and report which instances returned non-zero statuses by which command. Signed-off-by: Kyle M Hall Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 8 16:21:22 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Jun 2020 14:21:22 +0000 Subject: [Koha-bugs] [Bug 25634] koha-foreach exits too early if any command has non-zero status In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25634 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com Status|Signed Off |Passed QA --- Comment #9 from Martin Renvoize --- Works as expected, thanks. Passing QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 8 16:26:56 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Jun 2020 14:26:56 +0000 Subject: [Koha-bugs] [Bug 24201] Attach desk to intranet session In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24201 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_20_11_target -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 8 16:28:06 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Jun 2020 14:28:06 +0000 Subject: [Koha-bugs] [Bug 25642] Technical notes are missing from the release In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25642 --- Comment #9 from Martin Renvoize --- Thanks for providing the followup Katrin, you beat me :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 8 16:36:52 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Jun 2020 14:36:52 +0000 Subject: [Koha-bugs] [Bug 25642] Technical notes are missing from the release In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25642 --- Comment #10 from Katrin Fischer --- I didn't - Julian did :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 8 16:39:08 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Jun 2020 14:39:08 +0000 Subject: [Koha-bugs] [Bug 25545] Invoice page - Adjustments are not included in the Total + adjustments + shipment cost (Column tax. inc.) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25545 --- Comment #11 from Owen Leonard --- I think the follow-up is correct: "Total + adjustments + shipment cost" -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 8 16:43:49 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Jun 2020 14:43:49 +0000 Subject: [Koha-bugs] [Bug 25552] Add missing Claims Returned option to MarkLostItemsAsReturned In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25552 --- Comment #11 from Katrin Fischer --- I tested it twice, maybe messed up on git. I will redo the tests... again :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 8 16:47:17 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Jun 2020 14:47:17 +0000 Subject: [Koha-bugs] [Bug 23091] Add options to charge new or restore forgiven overdues when a lost item is returned In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23091 --- Comment #24 from Martin Renvoize --- (In reply to Andrew Fuerste-Henry from comment #23) > New error at the same place -- step 18, checking in a lost item while rule > is set to one of the new options. Here's the error: No branchcode argument > passed to Koha::Calendar->new at /kohadevbox/koha/C4/Overdues.pm line 319. > at /usr/share/perl/5.24/Carp.pm line 167 Interesting.. what value of 'CircControl' do you have? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 8 16:50:30 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Jun 2020 14:50:30 +0000 Subject: [Koha-bugs] [Bug 23091] Add options to charge new or restore forgiven overdues when a lost item is returned In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23091 --- Comment #25 from Andrew Fuerste-Henry --- I don't believe I'd changed it from the default in master, library the item is from. I can try to recreate the error later, if it's not happening for you. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 8 16:51:22 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Jun 2020 14:51:22 +0000 Subject: [Koha-bugs] [Bug 23091] Add options to charge new or restore forgiven overdues when a lost item is returned In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23091 --- Comment #26 from Martin Renvoize --- Created attachment 105649 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105649&action=edit Bug 23091: (QA follow-up) Fix unblessed item issue As highlighted by Andrew, the introduced call to _CalculateAndUpdateFine was passing a full item object instead of an unblessed hashref. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 8 16:51:52 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Jun 2020 14:51:52 +0000 Subject: [Koha-bugs] [Bug 23091] Add options to charge new or restore forgiven overdues when a lost item is returned In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23091 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #27 from Martin Renvoize --- Found it.. back to NSO -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 8 17:12:42 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Jun 2020 15:12:42 +0000 Subject: [Koha-bugs] [Bug 22522] API authentication breaks with updated Mojolicious version In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22522 --- Comment #63 from Tomás Cohen Arazi --- (In reply to Martin Renvoize from comment #62) > I've been looking at this and in reality.. I think what we really need is to > just backport the whole set correctly.. I'm not sure what stopped it from > being backported in the first place to be honest. > > I've had a go at backporting locally and it applies with minor conflicts to > resolve on the 19.11 branch pretty easily. (all of it, including all the > tests fixes).. The problem I'm having however, is that running all the tests > to check they're now working against a KOHA_IMAGE=19.11-bionic > koha-testing-docker crashes my dev server entirely for unknown reasons at > the moment.. hence I've not submitted the set on mass yet. Are you by chance running it with CPAN and COVERAGE? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 8 17:18:30 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Jun 2020 15:18:30 +0000 Subject: [Koha-bugs] [Bug 25695] New: Missing logging of $@ in onboarding.pl after eval block Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25695 Bug ID: 25695 Summary: Missing logging of $@ in onboarding.pl after eval block Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Installation and upgrade (web-based installer) Assignee: slavashishkin at gmail.com Reporter: slavashishkin at gmail.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, nugged at gmail.com, stalkernoid at gmail.com There is a forgotten warning in the second eval block just after the same eval block which has warning. This makes the error reason not logged. The solution is to add exactly the same ‘warn $@’ in consecutive eval block. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 8 17:25:25 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Jun 2020 15:25:25 +0000 Subject: [Koha-bugs] [Bug 22522] API authentication breaks with updated Mojolicious version In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22522 --- Comment #64 from Martin Renvoize --- Nope.. `KOHA_IMAGE=19.11-bionic docker-compose -f docker-compose.yml -f docker-compose.mariadb_d9.yml -p koha up --force-recreate` Then `kshell`, `kshell`, `prove -v t/db_dependant/api/v1/*` It get's about 2/3rds through then the host OS runs out of memory and starts OOMing, starting with ssh.. and finally it all just falls over and I have to restart my dev box. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 8 17:26:08 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Jun 2020 15:26:08 +0000 Subject: [Koha-bugs] [Bug 25695] Missing logging of $@ in onboarding.pl after eval block In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25695 --- Comment #1 from Slava Shishkin --- Created attachment 105650 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105650&action=edit Bug 25695: add a missing warning in onboarding.pl There is a forgotten warning in the second eval block just after the same eval block which has warning. This makes the error reason not logged. The solution is to add exactly the same 'warn $@' in consecutive eval block. Mentored-by: Andrew Nugged -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 8 17:27:13 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Jun 2020 15:27:13 +0000 Subject: [Koha-bugs] [Bug 22522] API authentication breaks with updated Mojolicious version In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22522 --- Comment #65 from Martin Renvoize --- https://gitlab.com/mrenvoize/Koha/-/commits/bug_22522 is my 19.11 branch with backported patches applied if it helps. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 8 17:39:15 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Jun 2020 15:39:15 +0000 Subject: [Koha-bugs] [Bug 15156] Get all Borrowers with pending/unpaid fines/accountlines In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15156 --- Comment #9 from Martin Renvoize --- Comment on attachment 99981 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99981 Bug 15156: Get all Borrowers with pending/unpaid fines/accountlines Review of attachment 99981: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=15156&attachment=99981) ----------------------------------------------------------------- ::: Koha/Account/Lines.pm @@ +23,4 @@ > use Koha::Account::Line; > > use base qw(Koha::Objects); > +use List::MoreUtils qw( uniq ); Unless I'm missing it.. you don't actually use 'uniq' here? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 8 17:48:59 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Jun 2020 15:48:59 +0000 Subject: [Koha-bugs] [Bug 24909] Add unprivileged route to get a bibliographic record In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24909 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas at bywatersolutions.com --- Comment #22 from Lucas Gass --- Is there any possibility that this could be backported to 19.11? Would be very helpful to have biblios endpoint accessible in the OPAC. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 8 18:15:30 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Jun 2020 16:15:30 +0000 Subject: [Koha-bugs] [Bug 22332] Limit to currently available items in home library In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22332 Christopher Brannon changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |cbrannon at cdalibrary.org --- Comment #3 from Christopher Brannon --- (In reply to Magnus Enger from comment #2) > But does "Limit to currently available items" work for you guys at all? It > does not work for me in 19.05.07. No, apparently it does not. Would like to see this fixed. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Jun 8 18:15:45 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Jun 2020 16:15:45 +0000 Subject: [Koha-bugs] [Bug 22332] Limit to currently available items in home library In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22332 --- Comment #4 from Christopher Brannon --- (In reply to Jessie Zairo from comment #0) > When performing a search in the staff client you have a facet option to > limit to currently available items. It would be useful for multi site > libraries to have a second option to limit to currently available items in > their home library (library they are set to) +1 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 8 19:12:43 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Jun 2020 17:12:43 +0000 Subject: [Koha-bugs] [Bug 25657] Import Patron fails without userid - not stated as required field in notes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25657 --- Comment #8 from Elaine Bradtke --- (In reply to Katrin Fischer from comment #7) > Hi Elaine, is userid listed in your BorrowerMandatoryFields system > preference by chance? surname|cardnumber is all we have - in both production and test sites. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 8 20:21:50 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Jun 2020 18:21:50 +0000 Subject: [Koha-bugs] [Bug 19885] Allow MaxOpenSuggestions to be set by patron type In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19885 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrew at bywatersolutions.com --- Comment #1 from Andrew Fuerste-Henry --- I've had a library ask how to prevent one or more categories from submitting purchase suggestions at all. If we could set some categories to 0 open suggestions, this would work for that library, too. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Jun 8 20:46:28 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Jun 2020 18:46:28 +0000 Subject: [Koha-bugs] [Bug 25695] Missing logging of $@ in onboarding.pl after eval block In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25695 Andrew Nugged changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 8 20:48:35 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Jun 2020 18:48:35 +0000 Subject: [Koha-bugs] [Bug 20168] Update of the OPAC bootstrap template to bootstrap v4 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20168 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Large patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 8 20:49:53 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Jun 2020 18:49:53 +0000 Subject: [Koha-bugs] [Bug 20168] Update of the OPAC bootstrap template to bootstrap v4 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20168 --- Comment #8 from Owen Leonard --- Remote branch: https://gitlab.com/koha-dev/koha-dev/-/tree/wip-2020-05-14-opac-bootstrap-4 Information and test plan: This patch updates the version of Bootstrap in the OPAC from 2.3.1 to 4.5.0. The Bootstrap JavaScript files have been replaced with custom builds of the 4.5.0 JavaScript source files. The Bootstrap CSS is now built into the OPAC CSS by loading the required Bootstrap 4.5.0 SCSS files in node_modules. OPAC SCSS now starts with Bootstrap customizations: /* Bootstrap variable customizations */ $headings-color: #727272; ... Followed by loading the necessary Bootstrap SCSS files: /* Bootstrap imports */ @import "../../../../../node_modules/bootstrap/scss/functions"; @import "../../../../../node_modules/bootstrap/scss/variables"; ... Followed by our CSS. The build process for generating compiled CSS now creates a file which bundles Bootstrap CSS and ours. Removed from the Koha source: Bootstrap CSS files, Bootstrap "glyphicons" images. The upgrade to Bootstrap 4 involved a lot of markup changes to conform with new Bootstrap classes, especially in classes related to the grid. Besides duplicating the grid we used before, this upgrade adds some new features made possible by Bootstrap 4.5's use of flexbox as a layout tool. This includes custom ordering of columns based on class names: https://getbootstrap.com/docs/4.5/layout/grid/#order-classes. Other areas where the most changes have been made: Navigation menus, breadcrumb menus, buttons, dropdowns. Unrelated changes: Indentation corrections, removal of invalid "// References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25554 Andrew Nugged changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |In Discussion --- Comment #7 from Andrew Nugged --- But that's not only about the assignment of $RULE_KINDS on the beginning, $scope3 also used in the code further, in two places: >+my $scope3 = [ 'branchcode', 'categorycode', 'itemtype' ]; ... > my $order_by = $params->{order_by} >- // { -desc => [ 'branchcode', 'categorycode', 'itemtype' ] }; >+ // { -desc => $scope3 }; ... > # Enforce scope; a rule should be set for its defined scope, no more, no less. >- foreach my $scope_level ( qw( branchcode categorycode itemtype ) ) { >+ foreach my $scope_level ( @$scope3 ) { > if ( grep /$scope_level/, @{ $kind_info->{scope} } ) { so just making pairs rules/scopes won't solve this, more advanced refactoring then needed. Let's think about this, yes (just thinking aloud here too :) ). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 8 21:00:16 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Jun 2020 19:00:16 +0000 Subject: [Koha-bugs] [Bug 25416] Add information about anonymous session for XSLT use In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25416 --- Comment #27 from Victor Grousset/tuxayo --- Enhancement not backported to 19.05.x (oldoldstable) It could eventually be backported if there is demand. Or if in the future it would help another patch to be backported. Because of this patch doing various change scattered in a file, not having it could cause conflicts. But until then, leaning on the conservative side by default for oldoldstable. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 8 21:06:33 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Jun 2020 19:06:33 +0000 Subject: [Koha-bugs] [Bug 25627] Move OPAC problem reports from administration to tools In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25627 --- Comment #3 from Owen Leonard --- (In reply to Katrin Fischer from comment #2) > I was wondering if we should group it with patrons and circulation instead, > as only logged in patrons can provide problem reports. My reasoning is that the problem reports are not really about patrons, they're about the OPAC itself. But I'm happy to modify the patch if others disagree! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 8 22:33:02 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Jun 2020 20:33:02 +0000 Subject: [Koha-bugs] [Bug 24854] Remove IDreamBooks integration In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24854 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |victor at tuxayo.net --- Comment #19 from Victor Grousset/tuxayo --- Backported to 19.05.x branch for 19.05.12 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 8 22:34:35 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Jun 2020 20:34:35 +0000 Subject: [Koha-bugs] [Bug 23994] AdditionalFields.t is failing randomly (U18) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23994 --- Comment #7 from Victor Grousset/tuxayo --- Backported to 19.05.x branch for 19.05.12 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 8 23:24:22 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Jun 2020 21:24:22 +0000 Subject: [Koha-bugs] [Bug 24458] Search results don't use Koha::Filter::MARC::ViewPolicy In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24458 --- Comment #15 from Victor Grousset/tuxayo --- Considering to backport to 19.05.X Why is bug 25416 a dependency? Trying to backport this bug without bug 25416 is the cause a few conflicts. But they can be reliably solved(independent changes). And t/db_dependent/Search.t still passes. But that's just a quick check. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 9 00:09:32 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Jun 2020 22:09:32 +0000 Subject: [Koha-bugs] [Bug 24683] Holds on biblios with different item types: rules for holds allowed are not applied correctly if any item type is available In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24683 --- Comment #8 from Andrew Nugged --- Created attachment 105651 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105651&action=edit Bug 24683: Subroutine name changed (fix), no code logic changed This is the intermediate refactor: renamed subroutine only. Naming mistake came because this sub is used to detect if anything available for hold, but it used in "if ANY UNAVAILABLE rule", so actually results of this sub negated (see below "return" in the code). In details: when previous refactor was done, name for subroutine was chosen wrongly in "opposite" direction from what it actually does: it was named "ItemsAnyAvailableForHold", but this subroutine gave truth (1) if at least one of the items available on shelf, not lost, not on loan, not held, and not restricted by smart rules and damaged status. So, if this sub says that item is still "available", this actually PREVENTS item from hold in parent sub (see negated return): sub IsAvailableForItemLevelRequest { ... my $any_available = ItemsAnyAvailableAndNotRestricted... return $any_available ? 0 : 1; # ^^^ if any available and not restricted - we don't allow # on-shelf holds ... I.e. like it named now: "ItemsAnyAvailableAndNotRestricted". Small aside fix: white space for '&&' inside brackets added to join operation by priority visually. Testing plan not needed: all places where sub used it just renamed. More: all this places/code was introduced in one older commit so there is also no overlaps or other calls/uses for this subroutine. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 9 00:10:28 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Jun 2020 22:10:28 +0000 Subject: [Koha-bugs] [Bug 24683] Holds on biblios with different item types: rules for holds allowed are not applied correctly if any item type is available In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24683 --- Comment #9 from Andrew Nugged --- Created attachment 105652 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105652&action=edit Bug 24683: Fix for take smart rules into account in "if all unavailable" Inside of ItemsAnyAvailableAndNotRestricted was no effect from main set of smart rules (per record and other limits): i.e. call to "CanItemBeReserved" was absent totally. Because of this there was a bug: for example none of two items were allowed to be held when first was allowed by one smart rule, BUT on loan, and second was disallowed by another smart rule (for example, 0 "Holds per record"), i.e. in this case both items unavailable: so on-shelf holds setting "allow hold if all unavailable" should allow to hold first one, and not the second one. But it was that both wasn't allowed to be held. Solution: call to sub "CanItemBeReserved" added so it checked for "...->{status} ne 'OK'" so now if item restricted by smart rule it also accounted as "unavailable" and "AnyAvailavble" not counts it. How to reproduce: 1. Add 2 smart rules (/cgi-bin/koha/admin/smart-rules.pl) with "on shelf holds": "if all unavailable" for all rules, no "item level holds", and set "holds per record" to 2 for "books" and "0" for "computer files". 2. Create only 2 items for one biblio, but different types, "book" and "computer file". For example in misc4dev env: /cgi-bin/koha/cataloguing/additem.pl?biblionumber=1#additem 3. Check out that item of type "book" to some person, for example, in misc4dev: /cgi-bin/koha/circ/circulation.pl?borrowernumber=2&barcode=3999900000001 4. Open reserve/request, for example, for item 1 and patron 1 in misc4dev env (/cgi-bin/koha/reserve/request.pl?biblionumber=1&borrowernumber=1) 5. It does not allow to hold, both red crossed, but computer file says "Exceeded max holds per record" because of "0" limit set on step 1. 6. Apply the patch. 7. Reload page on step 5 and see that "book" will be available for hold, but "computer file" still will be red-crossed "Exceeded max holds per record", now that's correct because both items unavailable: one because on load, another because of "0" limit for computer files. 8. Check-in book from step 3 so it will be returned to the library, 9. Reload page on step 5 and see that again no any holds available, but it's now also correct: "book" now returned but "on shelf holds" set to "if all unavailable". -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 9 00:47:19 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Jun 2020 22:47:19 +0000 Subject: [Koha-bugs] [Bug 25535] Hold API mapping maps cancellationdate to cancelation_date, but it should be cancellation_date In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25535 --- Comment #12 from Victor Grousset/tuxayo --- Backported to 19.05.x branch for 19.05.12 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 9 01:03:20 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Jun 2020 23:03:20 +0000 Subject: [Koha-bugs] [Bug 24458] Search results don't use Koha::Filter::MARC::ViewPolicy In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24458 --- Comment #16 from Tomás Cohen Arazi --- It was because I wrote one before the other, and the tests initially depended on on setup of the mocked things. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 9 01:07:58 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 08 Jun 2020 23:07:58 +0000 Subject: [Koha-bugs] [Bug 25524] Debian packages always append to /etc/koha/sites/$site/log4perl.conf In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25524 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |victor at tuxayo.net --- Comment #9 from Victor Grousset/tuxayo --- Missing dependencies for 19.05.x, can't backport. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 9 02:08:55 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jun 2020 00:08:55 +0000 Subject: [Koha-bugs] [Bug 25686] Title in the catalogue search result doesn't open the full (normal) record display In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25686 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au --- Comment #14 from David Cook --- The issue was due to Bug 24458. Iming's bibliographic frameworks are quite old I think, so they didn't have the OPAC and Intranet checkboxes ticked for the 999$c in the Default framework. While a fresh database will have the latest MARC bibliographic framework, upgraded databases never get updated MARC bibliographic framework data. This is an issue I've been pondering for years. Personally, I'd love to see the "Default Framework" be managed by Koha rather than by end users, so that we could constantly update it with the latest and greatest configuration. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jun 9 02:09:13 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jun 2020 00:09:13 +0000 Subject: [Koha-bugs] [Bug 25686] Title in the catalogue search result doesn't open the full (normal) record display In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25686 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=24458 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jun 9 02:09:13 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jun 2020 00:09:13 +0000 Subject: [Koha-bugs] [Bug 24458] Search results don't use Koha::Filter::MARC::ViewPolicy In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24458 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=25686 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 9 02:14:10 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jun 2020 00:14:10 +0000 Subject: [Koha-bugs] [Bug 24458] Search results don't use Koha::Filter::MARC::ViewPolicy In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24458 --- Comment #17 from David Cook --- I'm glad to see this change go in, but it appears that it caused Bug 25686, because the visibility for the 999$c was set to hide. I don't think that it's a bug or regression, but rather we should let people know somehow that they may need to update their MARC bibliographic frameworks, since they won't be automatically updated. I suppose that the release notes would've been the place for that, but perhaps it's too late for that? I think Koha should probably automatically update the "Default Framework" on upgrades. The first time we do it could be problematic, since people's changes would disappear (although we could back them up in an "Old Default Framework"), but I figure we need to have some strategy for delivering framework updates automatically. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 9 02:15:46 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jun 2020 00:15:46 +0000 Subject: [Koha-bugs] [Bug 25686] Title in the catalogue search result doesn't open the full (normal) record display In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25686 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |WORKSFORME -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 9 03:14:20 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jun 2020 01:14:20 +0000 Subject: [Koha-bugs] [Bug 25293] Don't call escapeHtml on null In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25293 --- Comment #8 from David Cook --- (In reply to Jonathan Druart from comment #7) > (In reply to David Cook from comment #5) > > I usually encounter this issue because of the Keyword To MARC mapping > > removal, which caused some really bad Koha to MARC mappings in the biblio. > > > > It caused a lot of problems for us. > > So, sign it off? That takes time and effort, and it isn't a local priority at the moment. It's on my TODO list, but it's a long list with other higher priorities. This issue almost always indicates a misconfiguration or bad data, so it's not really a critical issue. Since it's a non-critical issue, I could just sign it off, but I rather put the time in to test it fully. But that means it's not going to happen today. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 9 03:16:54 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jun 2020 01:16:54 +0000 Subject: [Koha-bugs] [Bug 25586] Something wrong with KOHA_HOME (?) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25586 --- Comment #10 from David Cook --- (In reply to Jonathan Druart from comment #9) > (In reply to Marcel de Rooy from comment #8) > > (In reply to Jonathan Druart from comment #6) > > > (In reply to David Cook from comment #4) > > > > I was wondering what KOHA_HOME was about yesterday... > > > > > > > > Maybe KOHA_HOME should be set to "/usr/share/koha" only if KOHA_HOME is > > > > unset. > > > > > > > > Then in kohadevbox and koha-testing-docker, an environmental variable can be > > > > set to a dev install location? > > > > > > We already have 'dev_install' and 'intranetdir' in koha-conf. I don't think > > > adding more variables will help. > > > > This is not a new variable. > > KOHA_HOME is not (hence this bug report). David's suggestion was to add a > new one. At least it's what I understood. I think you misunderstood me, Jonathan. I meant keeping the existing KOHA_HOME variable, but setting it differently (to make it easier to re-configure for dev environments and when using systemd services). -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jun 9 03:44:02 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jun 2020 01:44:02 +0000 Subject: [Koha-bugs] [Bug 20554] New OPAC CSS In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20554 --- Comment #57 from David Cook --- (In reply to Katrin Fischer from comment #56) > (In reply to David Cook from comment #55) > > By the way, fontfaceobserver.min.js is getting flagged as the > > Miner.Jswebcoin virus by Symantec Endpoint Protection. > > > > It says that Symantec have had it flagged for more than 1 year, and that the > > file is untrustworthy. > > > > I have examined the Javascript, and it really appears to be a false > > positive, but I'm noting it here anyway. > > > > I'm going to look at removing fontfaceobserver locally so that it can pass > > security checks for the time being. > > Hi David, if we need to do something about this, please file a new bug > report. At this point, I'm still waiting to hear back from Symantec. I'm hoping that they'll check this out, and update their virus definitions to no longer include fontfaceobserver. Locally, we've disabled fontfaceobserver for those using Symantec Endpoint Protection, so that they don't get the virus alert anymore. But I don't think there's anything that needs to be done on the Koha community side of things at this point. Just giving people a FYI. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 9 04:01:18 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jun 2020 02:01:18 +0000 Subject: [Koha-bugs] [Bug 25411] Plugin routes cannot have anonymous access In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25411 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |aleisha at catalyst.net.nz --- Comment #15 from Aleisha Amohia --- missing dependencies, not backported to 19.11.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 9 04:30:19 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jun 2020 02:30:19 +0000 Subject: [Koha-bugs] [Bug 25563] Cannot submit "add order from MARC file" form after alert In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25563 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |aleisha at catalyst.net.nz Version(s)|20.05.00 |20.05.00, 19.11.07 released in| | Status|Pushed to master |Pushed to stable --- Comment #7 from Aleisha Amohia --- backported to 19.11.x for 19.11.07 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 9 05:01:53 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jun 2020 03:01:53 +0000 Subject: [Koha-bugs] [Bug 24458] Search results don't use Koha::Filter::MARC::ViewPolicy In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24458 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |25457 See Also|https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=25457 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25457 [Bug 25457] The ViewPolicy filter should cache the MARC framework structure -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 9 05:01:53 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jun 2020 03:01:53 +0000 Subject: [Koha-bugs] [Bug 25457] The ViewPolicy filter should cache the MARC framework structure In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25457 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |24458 See Also|https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=24458 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24458 [Bug 24458] Search results don't use Koha::Filter::MARC::ViewPolicy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 9 05:27:13 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jun 2020 03:27:13 +0000 Subject: [Koha-bugs] [Bug 25168] mandatory field has been set in admin but purchase suggestion (in opac) allow to enter null value In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25168 --- Comment #14 from ciarebaha --- Created attachment 105653 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105653&action=edit HTML Source code -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 9 05:39:45 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jun 2020 03:39:45 +0000 Subject: [Koha-bugs] [Bug 25504] Wrong API spec breaks plack without meaningful error In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25504 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 9 05:55:30 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jun 2020 03:55:30 +0000 Subject: [Koha-bugs] [Bug 21366] add plack reload In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21366 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au --- Comment #3 from David Cook --- This would be great -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 9 06:02:00 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jun 2020 04:02:00 +0000 Subject: [Koha-bugs] [Bug 25168] mandatory field has been set in admin but purchase suggestion (in opac) allow to enter null value In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25168 --- Comment #15 from ciarebaha --- (In reply to Jonathan Druart from comment #13) > The HTML source of the page. I have attached the html code (downloaded directly from page). Please refer line 1118. It seems like the variable does not carry array value. What possibly is the cause? And how can i check? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 9 06:10:28 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jun 2020 04:10:28 +0000 Subject: [Koha-bugs] [Bug 22796] koha-common and mariadb start in the wrong order In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22796 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au --- Comment #3 from David Cook --- This is a really interesting point. I've been thinking a lot about database upgrades lately. Kong Gateway can be installed by a Debian package, but it requires a person running "kong migrations up" to trigger an actual database upgrade. Keycloak will apply database migrations/upgrades automatically when you start the application. I'd suggest moving a lot of the code from koha-common.postinst into the koha-common service (ie /etc/init.d/koha-common). Then koha-common.postinst could just restart the koha-common service. An optional dependency on Mariadb could be added, so koha-common would wait to restart until after Mariadb is available. If the Mariadb service isn't available on that server, it'll just ignore the dependency. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 9 06:19:07 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jun 2020 04:19:07 +0000 Subject: [Koha-bugs] [Bug 23128] Missing Net::OAuth2::AuthorizationServer dependency In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23128 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au --- Comment #11 from David Cook --- (In reply to Jonathan Druart from comment #10) > What is needed here? I imagine Mason probably just needs to remove libcryptx-perl from http://debian.koha-community.org/koha/pool/main/libc/libcryptx-perl/ -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 9 07:03:02 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jun 2020 05:03:02 +0000 Subject: [Koha-bugs] [Bug 25696] New: Test prediction pattern button is invalid HTML Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25696 Bug ID: 25696 Summary: Test prediction pattern button is invalid HTML Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Serials Assignee: koha-bugs at lists.koha-community.org Reporter: dcook at prosentient.com.au QA Contact: testopia at bugs.koha-community.org CC: colin.campbell at ptfs-europe.com It looks like the "Test prediction pattern" button is invalid HTML. Browsers like Chrome just fix it, but IE 11 complains about it. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 9 07:53:55 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jun 2020 05:53:55 +0000 Subject: [Koha-bugs] [Bug 25697] New: Tinymce doesn't load in IE 11 (due to Koha adding version number suffix to Javascript) Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25697 Bug ID: 25697 Summary: Tinymce doesn't load in IE 11 (due to Koha adding version number suffix to Javascript) Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs at lists.koha-community.org Reporter: dcook at prosentient.com.au QA Contact: testopia at bugs.koha-community.org Tinymce tries to set its base url by iterating through "script" elements looking for scripts like tinymce.min.js, and uses the baseurl of the script src attribute for its own baseurl. However, we provide something like tinymce.min_19.1106000.js, which will never match. This is OK in browsers like Chrome which support document.currentScript as a fallback. But IE 11 doesn't support document.currentScript. The simple solution is just to provide "suffix" and "base_url" when running tinyMCE.init. It's no big drama, and it means tinymce will work better cross-browser. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jun 9 08:07:53 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jun 2020 06:07:53 +0000 Subject: [Koha-bugs] [Bug 25696] Test prediction pattern button is invalid HTML In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25696 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 9 08:07:56 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jun 2020 06:07:56 +0000 Subject: [Koha-bugs] [Bug 25696] Test prediction pattern button is invalid HTML In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25696 --- Comment #1 from David Cook --- Created attachment 105654 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105654&action=edit Bug 25696: Correct "Test prediction pattern" HTML button This patch corrects the closing tag for the "Test prediction pattern" button from "" to "" Test plan: 1. Apply the patch 2. Create a serial subscription from a new or existing bib record 3. Choose any frequency, numbering pattern, and subscription start date you choose (ie fill out all mandatory subscription fields) 4. Click "Test prediction pattern" 5. Note that the prediction pattern appears on the right of the screen -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jun 9 08:12:50 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jun 2020 06:12:50 +0000 Subject: [Koha-bugs] [Bug 25697] Tinymce doesn't load in IE 11 (due to Koha adding version number suffix to Javascript) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25697 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 9 08:12:53 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jun 2020 06:12:53 +0000 Subject: [Koha-bugs] [Bug 25697] Tinymce doesn't load in IE 11 (due to Koha adding version number suffix to Javascript) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25697 --- Comment #1 from David Cook --- Created attachment 105655 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105655&action=edit Bug 25697: Declare base url and suffix in tinymce init This patch declares the base url and suffix in tinymce init, so that tinymce will initialize properly cross-browser. Without this change, tinymce will fail to initialize on IE 11. Test plan: 0. Apply patch 1. Open IE 11 2. Enable "UseWYSIWYGinSystemPreferences" system preference 3. Go to /cgi-bin/koha/admin/preferences.pl?tab=opac and note that tinymce initializes correctly 4. Go to /cgi-bin/koha/tools/koha-news.pl and create/edit a news item, and note that tinymce initializes correctly 5. Go to /cgi-bin/koha/admin/branches.pl and add/edit a library, and note that tinymce initializes correctly for "OPAC info" -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 9 08:54:50 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jun 2020 06:54:50 +0000 Subject: [Koha-bugs] [Bug 25698] New: Curbside Pickup Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25698 Bug ID: 25698 Summary: Curbside Pickup Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs at lists.koha-community.org Reporter: magnus at libriotech.no QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com Looks like Evergreen is getting this feature: https://librarytechnology.org/pr/25238 Maybe something for Koha too? :-) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jun 9 09:13:02 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jun 2020 07:13:02 +0000 Subject: [Koha-bugs] [Bug 25699] New: Edition information to Holds to pull report Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25699 Bug ID: 25699 Summary: Edition information to Holds to pull report Change sponsored?: --- Product: Koha Version: 20.05 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs at lists.koha-community.org Reporter: minna.kivinen at hamk.fi QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com Holds to pull -report should show edition information of a book. Edition information can be fetched from biblioitem -table, there is no need to get it from metadata -table. Edition can be printed with title -information. (Earlier it was possible to user Marc to keyword -feature, but there is not that anymore available). In scientific libraries it is very essential to know which edition is needed. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 9 09:56:42 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jun 2020 07:56:42 +0000 Subject: [Koha-bugs] [Bug 15156] Get all Borrowers with pending/unpaid fines/accountlines In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15156 Emmi Takkinen changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #99981|0 |1 is obsolete| | --- Comment #10 from Emmi Takkinen --- Created attachment 105656 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105656&action=edit Bug 15156: Get all Borrowers with pending/unpaid fines/accountlines Rebased patch and removed unnecessary line of code from Lines.pm. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 9 10:47:32 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jun 2020 08:47:32 +0000 Subject: [Koha-bugs] [Bug 23128] Missing Net::OAuth2::AuthorizationServer dependency In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23128 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|mirko at abunchofthings.net |mtj at kohaaloha.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 9 10:47:38 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jun 2020 08:47:38 +0000 Subject: [Koha-bugs] [Bug 23128] Missing Net::OAuth2::AuthorizationServer dependency In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23128 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 9 10:59:50 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jun 2020 08:59:50 +0000 Subject: [Koha-bugs] [Bug 25168] mandatory field has been set in admin but purchase suggestion (in opac) allow to enter null value In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25168 --- Comment #16 from Jonathan Druart --- The problematic line is: 1118 var FldsRequired = [ARRAY(0x66dd688)]; Can you open your file opac-suggestions.tt and copy what you have line 346 please? It must be 346 var FldsRequired = ['[% mandatoryfields.join("','") | html %]']; -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 9 11:05:50 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jun 2020 09:05:50 +0000 Subject: [Koha-bugs] [Bug 25457] The ViewPolicy filter should cache the MARC framework structure In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25457 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #5 from Jonathan Druart --- I don't see how it could be useful, you are calling GetMarcStructure that is doing exactly that. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 9 11:07:19 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jun 2020 09:07:19 +0000 Subject: [Koha-bugs] [Bug 24458] Search results don't use Koha::Filter::MARC::ViewPolicy In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24458 --- Comment #18 from Jonathan Druart --- David, What about adding a check in search_for_data_inconsistencies.pl? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 9 11:12:23 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jun 2020 09:12:23 +0000 Subject: [Koha-bugs] [Bug 20168] Update of the OPAC bootstrap template to bootstrap v4 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20168 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |RM_priority -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 9 11:23:43 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jun 2020 09:23:43 +0000 Subject: [Koha-bugs] [Bug 22672] Replace tags with AND tags with in the OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22672 --- Comment #12 from Timothy Alexis Vass --- It's definitely fine to replace and in both OPAC and STAFF. Is this ready to be implemented? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 9 11:28:56 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jun 2020 09:28:56 +0000 Subject: [Koha-bugs] [Bug 22522] API authentication breaks with updated Mojolicious version In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22522 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #105639|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 9 11:31:51 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jun 2020 09:31:51 +0000 Subject: [Koha-bugs] [Bug 22522] API authentication breaks with updated Mojolicious version In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22522 --- Comment #66 from Jonathan Druart --- Created attachment 105657 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105657&action=edit Bug 22522: [19.11.x] Add support for current Mojolicious and related packages This patch allows tests to succeed with the following versions: JSON::Validator 3.18 Mojolicious 8.32 Mojolicious::Plugin::OpenAPI 2.21 Also Mojolicious::Plugin::OpenAPI version 1.17 and later 1.x versions now work. Calling valid_input in under() would cause ' Use of uninitialized value $_[2] ' in more recent OpenAPI plugins, so that was changed too. As far as I can see this does not affect authorization. Signed-off-by: Martin Renvoize Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 9 11:31:56 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jun 2020 09:31:56 +0000 Subject: [Koha-bugs] [Bug 22522] API authentication breaks with updated Mojolicious version In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22522 --- Comment #67 from Jonathan Druart --- Created attachment 105658 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105658&action=edit Bug 22522: [19.11.x] Fix route typo Signed-off-by: Martin Renvoize Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 9 11:32:01 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jun 2020 09:32:01 +0000 Subject: [Koha-bugs] [Bug 22522] API authentication breaks with updated Mojolicious version In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22522 --- Comment #68 from Jonathan Druart --- Created attachment 105659 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105659&action=edit Bug 22522: [19.11.x] Fix several REST API tests Fixes among others the invalid use of json_has() which caused broken tests to pass with older Mojolicious versions. Signed-off-by: Martin Renvoize Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 9 11:32:16 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jun 2020 09:32:16 +0000 Subject: [Koha-bugs] [Bug 22522] API authentication breaks with updated Mojolicious version In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22522 --- Comment #69 from Jonathan Druart --- I have tested Martin's remote branch on master-bionic and 19.11-bionic: all tests pass! Aleisha, could you push those 3 patches (the 19.11 ones) and see how behave Jenkins? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 9 11:35:47 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jun 2020 09:35:47 +0000 Subject: [Koha-bugs] [Bug 24003] REST API should set C4::Context->userenv In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24003 --- Comment #19 from Jonathan Druart --- I have no idea which bug in stable we are trying to fix. Where is that describe? We should think "regression proof", if the userenv exists then it should be reliable. Having only the borrowerumber defined seems very wrong to me. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 9 12:09:02 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jun 2020 10:09:02 +0000 Subject: [Koha-bugs] [Bug 5198] HOLDPLACED being logged in patron messages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5198 Marjorie Barry-Vila changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marjorie.barry-vila at collect | |o.ca -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 9 12:31:33 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jun 2020 10:31:33 +0000 Subject: [Koha-bugs] [Bug 25442] Release dates are missing from the timeline In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25442 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |25700 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25700 [Bug 25700] Recent Kohacons are missing from the timeline -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 9 12:31:33 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jun 2020 10:31:33 +0000 Subject: [Koha-bugs] [Bug 25700] New: Recent Kohacons are missing from the timeline Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25700 Bug ID: 25700 Summary: Recent Kohacons are missing from the timeline Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Documentation Assignee: koha-bugs at lists.koha-community.org Reporter: martin.renvoize at ptfs-europe.com QA Contact: testopia at bugs.koha-community.org CC: jonathan.druart at bugs.koha-community.org, katrin.fischer at bsz-bw.de, martin.renvoize at ptfs-europe.com, testopia at bugs.koha-community.org Depends on: 25442 The last KohaCon entry in the history.txt on master is: 1381881600 October 16-22 2013 KohaCon 2013 and hackfest in Reno, Nevada, USA I think it probably needs a bit of updating! Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25442 [Bug 25442] Release dates are missing from the timeline -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 9 12:38:57 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jun 2020 10:38:57 +0000 Subject: [Koha-bugs] [Bug 22522] API authentication breaks with updated Mojolicious version In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22522 --- Comment #70 from Martin Renvoize --- Awesome.. glad to hear it worked well for your Jonathan.. I think my OOM's were local.. seems my dev server was due of a little maintenance and I can confirm that test now pass for me too :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 9 12:52:47 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jun 2020 10:52:47 +0000 Subject: [Koha-bugs] [Bug 25683] update_patron_categories.pl should recognize no fine history = 0 outstanding fines In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25683 --- Comment #3 from Nick Clemens --- Created attachment 105660 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105660&action=edit Bug 25683: [alternate] Patron with no accountlines should have 0 outstanding (not NULL) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 9 12:52:59 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jun 2020 10:52:59 +0000 Subject: [Koha-bugs] [Bug 25700] Recent Kohacons are missing from the timeline In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25700 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |Academy -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 9 12:53:04 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jun 2020 10:53:04 +0000 Subject: [Koha-bugs] [Bug 25700] Recent Kohacons are missing from the timeline In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25700 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |String patch -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jun 9 12:53:28 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jun 2020 10:53:28 +0000 Subject: [Koha-bugs] [Bug 25683] update_patron_categories.pl should recognize no fine history = 0 outstanding fines In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25683 --- Comment #4 from Nick Clemens --- (In reply to Jonathan Druart from comment #2) > Isn't it actually a hidden feature to search for negative balance (credit)? > > If not you can test this patch! I think the issue is that sum(amountoutstanding) is 'NULL' for patrons with no account history, it should be treated as 0 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 9 13:01:13 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jun 2020 11:01:13 +0000 Subject: [Koha-bugs] [Bug 25582] Don't show OPAC problems entry on dashboard when there are no reports In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25582 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david at davidnind.com --- Comment #2 from David Nind --- Created attachment 105661 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105661&action=edit Bug 25582 - Screenshot of border displaying on staff interface This works, but it leaves a border across the screen - see screen shot (this is after the patch is applied and there are no problem reports. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 9 13:24:47 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jun 2020 11:24:47 +0000 Subject: [Koha-bugs] [Bug 24003] REST API should set C4::Context->userenv In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24003 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 9 13:54:53 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jun 2020 11:54:53 +0000 Subject: [Koha-bugs] [Bug 25698] Curbside Pickup In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25698 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrew at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 9 14:01:22 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jun 2020 12:01:22 +0000 Subject: [Koha-bugs] [Bug 25683] update_patron_categories.pl should recognize no fine history = 0 outstanding fines In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25683 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #105660|0 |1 is obsolete| | --- Comment #5 from Nick Clemens --- Created attachment 105662 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105662&action=edit Bug 25683: [alternate] Patron with no accountlines should have 0 outstanding (not NULL) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 9 14:10:11 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jun 2020 12:10:11 +0000 Subject: [Koha-bugs] [Bug 25683] update_patron_categories.pl should recognize no fine history = 0 outstanding fines In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25683 --- Comment #6 from Jonathan Druart --- Nick, both changes are valid I think. My patch is fixing what is describe in comment 0. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 9 14:15:46 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jun 2020 12:15:46 +0000 Subject: [Koha-bugs] [Bug 25683] update_patron_categories.pl should recognize no fine history = 0 outstanding fines In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25683 --- Comment #7 from Andrew Fuerste-Henry --- I don't seem to have explained the issue well up front. Nick's patch addresses what I was looking at. Jonathan, I don't entirely follow what your patch is doing or why. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 9 14:23:59 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jun 2020 12:23:59 +0000 Subject: [Koha-bugs] [Bug 25683] update_patron_categories.pl should recognize no fine history = 0 outstanding fines In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25683 --- Comment #8 from Jonathan Druart --- There is a difference between no accountlines and sum(accountlines)=0. If I am dealing with the situation you described in comment 0: A patron had fines, but paied all of them: their balance is 0. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 9 14:26:47 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jun 2020 12:26:47 +0000 Subject: [Koha-bugs] [Bug 11299] Add a button to automatically link authority records in cataloguing (AJAX) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11299 Ray Delahunty changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |r.delahunty at arts.ac.uk -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 9 14:35:09 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jun 2020 12:35:09 +0000 Subject: [Koha-bugs] [Bug 25457] The ViewPolicy filter should cache the MARC framework structure In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25457 --- Comment #6 from Tomás Cohen Arazi --- (In reply to Jonathan Druart from comment #5) > I don't see how it could be useful, you are calling GetMarcStructure that is > doing exactly that. Is it storing the structure in L1? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 9 14:42:25 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jun 2020 12:42:25 +0000 Subject: [Koha-bugs] [Bug 25457] The ViewPolicy filter should cache the MARC framework structure In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25457 --- Comment #7 from Jonathan Druart --- yes of course. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 9 14:43:32 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jun 2020 12:43:32 +0000 Subject: [Koha-bugs] [Bug 25457] The ViewPolicy filter should cache the MARC framework structure In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25457 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |WORKSFORME Status|Signed Off |RESOLVED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 9 14:50:31 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jun 2020 12:50:31 +0000 Subject: [Koha-bugs] [Bug 25683] update_patron_categories.pl should recognize no fine history = 0 outstanding fines In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25683 --- Comment #9 from Nick Clemens --- (In reply to Jonathan Druart from comment #8) > There is a difference between no accountlines and sum(accountlines)=0. > > If I am dealing with the situation you described in comment 0: A patron had > fines, but paied all of them: their balance is 0. So your patch makes it be that a patron with 0 fines will not be returned if only a fine max is supplied? That is, it adds an assumption that you only want patrons with any fines if you supply a fine under amount? I do not think this is desired behaviour. I think the final step in comment 0 was a correct return and step 3 was the error -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 9 15:13:20 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jun 2020 13:13:20 +0000 Subject: [Koha-bugs] [Bug 25683] update_patron_categories.pl should recognize no fine history = 0 outstanding fines In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25683 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #105620|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 9 15:13:27 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jun 2020 13:13:27 +0000 Subject: [Koha-bugs] [Bug 25683] update_patron_categories.pl should recognize no fine history = 0 outstanding fines In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25683 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 9 15:14:01 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jun 2020 13:14:01 +0000 Subject: [Koha-bugs] [Bug 25683] update_patron_categories.pl should recognize no fine history = 0 outstanding fines In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25683 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|jonathan.druart at bugs.koha-c |nick at bywatersolutions.com |ommunity.org | --- Comment #10 from Jonathan Druart --- I obsoleted my patch. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 9 15:15:26 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jun 2020 13:15:26 +0000 Subject: [Koha-bugs] [Bug 22807] Accessibility: Add 'Skip to Main Content' link In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22807 --- Comment #2 from Martin Renvoize --- Created attachment 105663 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105663&action=edit Bug 22807: Add 'Skip to content' option This patch adds a 'Skip to content' link to the header bar which will only appear upon the first use of 'tab' to navigate after any fresh page load in the OPAC. Test plan 1/ Load any page in the OPAC 2/ Hit the `tab` key 3/ Note the new 'Skip to main content' link appears at the top left of the screen. 4/ Hit `Enter` 5/ Note the page scrolls to the area of the page that has the #maincontent id. 6/ Note that the link has been hidden 7/ Try tabbing around and note that the 'Skip to main content' option does not reapper 8/ Reload the page 9/ The 'Skip to main content' should appear again upon first use of 'Tab' 10/ Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 9 15:15:51 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jun 2020 13:15:51 +0000 Subject: [Koha-bugs] [Bug 22807] Accessibility: Add 'Skip to Main Content' link In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22807 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard at myacpl.org |martin.renvoize at ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 9 15:15:56 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jun 2020 13:15:56 +0000 Subject: [Koha-bugs] [Bug 22807] Accessibility: Add 'Skip to Main Content' link In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22807 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 9 15:16:52 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jun 2020 13:16:52 +0000 Subject: [Koha-bugs] [Bug 22807] Accessibility: Add 'Skip to Main Content' link In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22807 --- Comment #3 from Martin Renvoize --- Initial submission; could probably do with some refinement.. please test and let me know what you think. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 9 15:53:38 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jun 2020 13:53:38 +0000 Subject: [Koha-bugs] [Bug 22807] Accessibility: Add 'Skip to Main Content' link In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22807 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 9 16:10:58 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jun 2020 14:10:58 +0000 Subject: [Koha-bugs] [Bug 22807] Accessibility: Add 'Skip to Main Content' link In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22807 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #105663|0 |1 is obsolete| | --- Comment #4 from Martin Renvoize --- Created attachment 105664 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105664&action=edit Bug 22807: Add 'Skip to content' option This patch adds a 'Skip to content' link to the header bar which will only appear upon the first use of 'tab' to navigate after any fresh page load in the OPAC. Test plan 1/ Load any page in the OPAC 2/ Hit the `tab` key 3/ Note the new 'Skip to main content' link appears at the top left of the screen. 4/ Hit `Enter` 5/ Note the page scrolls to the area of the page that has the #maincontent id. 6/ Note that the link has been hidden -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 9 16:14:30 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jun 2020 14:14:30 +0000 Subject: [Koha-bugs] [Bug 25638] API related tests failing on comparing floats In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25638 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 9 16:16:18 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jun 2020 14:16:18 +0000 Subject: [Koha-bugs] [Bug 25638] API related tests failing on comparing floats In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25638 --- Comment #14 from Jonathan Druart --- Created attachment 105665 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105665&action=edit Bug 25638: Make the tests pass - ignoring the actual issue The API related tests still don't pass with the previous modifications. They pass on D10 but fail on U18 and I did not manage to find where the problems come from. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 9 16:17:28 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jun 2020 14:17:28 +0000 Subject: [Koha-bugs] [Bug 25638] API related tests failing on comparing floats In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25638 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |NEW Assignee|jonathan.druart at bugs.koha-c |chris at bigballofwax.co.nz |ommunity.org | --- Comment #15 from Jonathan Druart --- Pushing this last patch to turn Jenkins green and move on. However this still need to be addressed in my opinion. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 9 16:45:43 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jun 2020 14:45:43 +0000 Subject: [Koha-bugs] [Bug 15544] Zebra facets must be managed from the intranet In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15544 Alexander Borkowski changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |alexander.borkowski at kau.se -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 9 17:45:59 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jun 2020 15:45:59 +0000 Subject: [Koha-bugs] [Bug 24458] Search results don't use Koha::Filter::MARC::ViewPolicy In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24458 --- Comment #19 from Victor Grousset/tuxayo --- (In reply to Tomás Cohen Arazi from comment #16) > It was because I wrote one before the other, and the tests initially > depended on on setup of the mocked things. Ok, so I'll backport only this patchset. Since it's for a major bug, the conflicts are reliable to solve and IIUC there is no strong dependency that could cause undetected regressions. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 9 17:47:25 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jun 2020 15:47:25 +0000 Subject: [Koha-bugs] [Bug 24003] REST API should set C4::Context->userenv In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24003 --- Comment #20 from Tomás Cohen Arazi --- Created attachment 105666 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105666&action=edit Bug 24003: (follow-up) Add all userenv parameters This patch makes the API set more userenv params than just the borrowernumber. To test: 1. Apply this patch 2. Run: $ kshell k$ prove t/db_dependent/api/v1/auth_* => SUCCESS: All tests pass 3. Sign off :-D Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 9 17:48:57 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jun 2020 15:48:57 +0000 Subject: [Koha-bugs] [Bug 24003] REST API should set C4::Context->userenv In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24003 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 9 17:49:05 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jun 2020 15:49:05 +0000 Subject: [Koha-bugs] [Bug 24003] REST API should set C4::Context->userenv In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24003 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 9 17:49:59 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jun 2020 15:49:59 +0000 Subject: [Koha-bugs] [Bug 24003] REST API should set C4::Context->userenv In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24003 --- Comment #21 from Tomás Cohen Arazi --- The bug in stable is that any API interaction (the route /patrons changing data from an external source) ends with action_logs having the responsible for the action not set => bad. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 9 17:54:07 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jun 2020 15:54:07 +0000 Subject: [Koha-bugs] [Bug 25701] New: Facets display in random order Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25701 Bug ID: 25701 Summary: Facets display in random order Change sponsored?: --- Product: Koha Version: 19.11 Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: fiona.borthwick at ptfs-europe.com QA Contact: testopia at bugs.koha-community.org This issue has been raised by our customers following an upgrade to 19.11 but I can still reproduce at 20.05. It is also apparent on both the OPAC and the staff interface. Search the catalogue and see the results page. Facets on the left appear in one order. Repeat the same search immediately and the facets appear in a different order. There is no consistency to this random order. For example - search one: Holding Libraries Series Topics Authors Item types Places Locations Search two: Holding Libraries Topics Item types Series Authors Places Locations Each search we carry out seems to yield different facet orders. Whilst possibly cosmetic, our customers would like to see consistency - especially for the OPAC as it can cause confusion for end users. We have toggled use_zebra_facets between 0 and 1 in koha-conf.xml but makes no difference. Testing on a live server at 18.11, we can confirm that the order the facets appear remains consistent. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 9 18:03:20 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jun 2020 16:03:20 +0000 Subject: [Koha-bugs] [Bug 10205] koha-create error handling In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10205 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|tomascohen at gmail.com |koha-bugs at lists.koha-commun | |ity.org -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jun 9 18:15:42 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jun 2020 16:15:42 +0000 Subject: [Koha-bugs] [Bug 22807] Accessibility: Add 'Skip to Main Content' link In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22807 --- Comment #5 from Martin Renvoize --- Right.. so what this now needs is a consensus on each page as to what we should mark as 'maincontent'.. So far these pages are missing such a class: opac-alert-subscribe.tt opac-sendbasket.tt opac-basket.tt clubs/clubs-tab.tt clubs/enroll.tt sco/printslip.tt sco/sco-main.tt sco/help.tt opac-results-grouped.tt errors/errorpage.tt opac-course-details.tt opac-downloadcart.tt opac-showreviews-rss.tt opac-memberentry-update-submitted.tt opac-registration-invalid.tt opac-imageviewer.tt opac-mymessages.tt ilsdi.tt opac-reserve.tt opac-main.tt sci/sci-main.tt opac-addbybiblionumber.tt opac-memberentry.tt opac-idref.tt opac-blocked.tt opac-password-recovery.tt opac-browser.tt opac-registration-confirmation.tt opac-browse.tt opac-serial-issues.tt opac-patron-consent.tt opac-tags_subject.tt text/explodedterms.tt opac-sendshelf.tt opac-request-article.tt opac-retrieve-file.tt opac-sendshelfform.tt opac-course-reserves.tt svc/shelfbrowser.tt svc/suggestion.tt opac-shelves-rss.tt opac-privacy.tt opac-registration-email-sent.tt opac-ics.tt opac-messaging.tt opac-opensearch.tt opac-review.tt opac-passwd.tt opac-sendbasketform.tt opac-discharge.tt maintenance.tt opac-showmarc.tt opac-readingrecord.tt opac-news-rss.tt -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 9 18:15:48 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jun 2020 16:15:48 +0000 Subject: [Koha-bugs] [Bug 22807] Accessibility: Add 'Skip to Main Content' link In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22807 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 9 18:30:09 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jun 2020 16:30:09 +0000 Subject: [Koha-bugs] [Bug 23994] AdditionalFields.t is failing randomly (U18) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23994 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|19.11.00 |19.11.00, 19.05.12 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 9 18:30:15 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jun 2020 16:30:15 +0000 Subject: [Koha-bugs] [Bug 24854] Remove IDreamBooks integration In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24854 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|20.05.00, 19.11.06 |20.05.00, 19.11.06, released in| |19.05.12 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 9 18:30:38 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jun 2020 16:30:38 +0000 Subject: [Koha-bugs] [Bug 25535] Hold API mapping maps cancellationdate to cancelation_date, but it should be cancellation_date In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25535 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|20.05.00, 19.11.06 |20.05.00, 19.11.06, released in| |19.05.12 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 9 18:49:18 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jun 2020 16:49:18 +0000 Subject: [Koha-bugs] [Bug 11529] Add subtitle, medium and part fields to biblio table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11529 Liz Rea changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |wizzyrea at gmail.com Status|RESOLVED |REOPENED Resolution|FIXED |--- --- Comment #244 from Liz Rea --- We have seen this exact thing, and it's rather a huge problem for upgrading libraries going to 19.11 (In reply to David Cook from comment #243) > Turns out the database update for this change causes unexpected changes to > the "Koha to MARC mapping" (via the MARC frameworks) if you had additional > non-standard "Koha to MARC mapping" entries. > > Personally, I wouldn't have updated the marc_subfield_structure > automatically. > > Here's the query used: > UPDATE marc_subfield_structure JOIN fieldmapping ON tagfield = fieldcode AND > subfieldcode=tagsubfield SET kohafield='biblio.subtitle' WHERE > fieldmapping.frameworkcode=''" > > This would be a better query: > UPDATE marc_subfield_structure JOIN fieldmapping ON tagfield = fieldcode AND > subfieldcode=tagsubfield SET kohafield='biblio.subtitle' WHERE > fieldmapping.frameworkcode=''" and field='subtitle' > > Now I have a lot of different MARC fields mapped to biblio.subtitle 😅 > > Of course, even the modified query wouldn't be great, because in my case > 245$h would get mapped to biblio.title too which isn't what we'd want. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 9 18:49:21 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jun 2020 16:49:21 +0000 Subject: [Koha-bugs] [Bug 7384] Improve title display in cart and list emails by displaying subtitles, number and part information In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7384 Bug 7384 depends on bug 11529, which changed state. Bug 11529 Summary: Add subtitle, medium and part fields to biblio table https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11529 What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |REOPENED Resolution|FIXED |--- -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 9 18:49:21 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jun 2020 16:49:21 +0000 Subject: [Koha-bugs] [Bug 14911] Item search: Display additional 245 subfields in search results In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14911 Bug 14911 depends on bug 11529, which changed state. Bug 11529 Summary: Add subtitle, medium and part fields to biblio table https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11529 What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |REOPENED Resolution|FIXED |--- -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 9 18:49:21 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jun 2020 16:49:21 +0000 Subject: [Koha-bugs] [Bug 22569] Stock rotation: 'Transfers to send' report In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22569 Bug 22569 depends on bug 11529, which changed state. Bug 11529 Summary: Add subtitle, medium and part fields to biblio table https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11529 What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |REOPENED Resolution|FIXED |--- -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 9 18:49:22 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jun 2020 16:49:22 +0000 Subject: [Koha-bugs] [Bug 4164] Way to Clone Keyword Mapping to other Frameworks In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4164 Bug 4164 depends on bug 11529, which changed state. Bug 11529 Summary: Add subtitle, medium and part fields to biblio table https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11529 What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |REOPENED Resolution|FIXED |--- -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jun 9 18:49:22 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jun 2020 16:49:22 +0000 Subject: [Koha-bugs] [Bug 4166] No way to know what keywords to use for Keyword Mapping In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4166 Bug 4166 depends on bug 11529, which changed state. Bug 11529 Summary: Add subtitle, medium and part fields to biblio table https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11529 What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |REOPENED Resolution|FIXED |--- -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jun 9 18:49:22 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jun 2020 16:49:22 +0000 Subject: [Koha-bugs] [Bug 7074] Show subtitle, part and number of a record in list of checkins In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7074 Bug 7074 depends on bug 11529, which changed state. Bug 11529 Summary: Add subtitle, medium and part fields to biblio table https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11529 What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |REOPENED Resolution|FIXED |--- -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 9 18:49:22 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jun 2020 16:49:22 +0000 Subject: [Koha-bugs] [Bug 8265] Allow a better form of the title to be included in notices In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8265 Bug 8265 depends on bug 11529, which changed state. Bug 11529 Summary: Add subtitle, medium and part fields to biblio table https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11529 What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |REOPENED Resolution|FIXED |--- -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jun 9 18:49:22 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jun 2020 16:49:22 +0000 Subject: [Koha-bugs] [Bug 10953] Missing subtitle fieldmapping unless you use ru-RU or uk-UA In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10953 Bug 10953 depends on bug 11529, which changed state. Bug 11529 Summary: Add subtitle, medium and part fields to biblio table https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11529 What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |REOPENED Resolution|FIXED |--- -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 9 18:49:23 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jun 2020 16:49:23 +0000 Subject: [Koha-bugs] [Bug 15972] Make it possible to include additional title information in notices (such as 245$b) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15972 Bug 15972 depends on bug 11529, which changed state. Bug 11529 Summary: Add subtitle, medium and part fields to biblio table https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11529 What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |REOPENED Resolution|FIXED |--- -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 9 18:49:23 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jun 2020 16:49:23 +0000 Subject: [Koha-bugs] [Bug 22699] Remove documentation on Keywords to MARC mapping In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22699 Bug 22699 depends on bug 11529, which changed state. Bug 11529 Summary: Add subtitle, medium and part fields to biblio table https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11529 What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |REOPENED Resolution|FIXED |--- -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 9 19:51:46 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jun 2020 17:51:46 +0000 Subject: [Koha-bugs] [Bug 24854] Remove IDreamBooks integration In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24854 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 9 19:51:54 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jun 2020 17:51:54 +0000 Subject: [Koha-bugs] [Bug 24854] Remove IDreamBooks integration In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24854 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldstable |Pushed to oldoldstable -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 9 19:53:13 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jun 2020 17:53:13 +0000 Subject: [Koha-bugs] [Bug 23994] AdditionalFields.t is failing randomly (U18) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23994 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 9 19:53:18 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jun 2020 17:53:18 +0000 Subject: [Koha-bugs] [Bug 23994] AdditionalFields.t is failing randomly (U18) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23994 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 9 19:53:24 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jun 2020 17:53:24 +0000 Subject: [Koha-bugs] [Bug 23994] AdditionalFields.t is failing randomly (U18) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23994 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldstable |Pushed to oldoldstable -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 9 19:58:49 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jun 2020 17:58:49 +0000 Subject: [Koha-bugs] [Bug 24458] Search results don't use Koha::Filter::MARC::ViewPolicy In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24458 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 9 19:59:53 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jun 2020 17:59:53 +0000 Subject: [Koha-bugs] [Bug 24458] Search results don't use Koha::Filter::MARC::ViewPolicy In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24458 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|20.05.00, 19.11.06 |20.05.00, 19.11.06, released in| |19.05.12 Status|Pushed to oldstable |Pushed to oldoldstable --- Comment #20 from Victor Grousset/tuxayo --- Backported to 19.05.x branch for 19.05.12 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 9 19:59:56 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jun 2020 17:59:56 +0000 Subject: [Koha-bugs] [Bug 25535] Hold API mapping maps cancellationdate to cancelation_date, but it should be cancellation_date In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25535 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 9 20:00:02 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jun 2020 18:00:02 +0000 Subject: [Koha-bugs] [Bug 25535] Hold API mapping maps cancellationdate to cancelation_date, but it should be cancellation_date In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25535 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldstable |Pushed to oldoldstable -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 9 20:41:16 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jun 2020 18:41:16 +0000 Subject: [Koha-bugs] [Bug 25698] Curbside Pickup In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25698 Lisette Scheer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lisetteslatah at gmail.com --- Comment #1 from Lisette Scheer --- This would be super helpful. Lisette -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Jun 9 21:14:46 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jun 2020 19:14:46 +0000 Subject: [Koha-bugs] [Bug 11529] Add subtitle, medium and part fields to biblio table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11529 --- Comment #245 from Kyle M Hall --- Created attachment 105667 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105667&action=edit Bug 11529: Do not update marc mappings, print old mappings to upgrade log -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 9 21:16:18 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jun 2020 19:16:18 +0000 Subject: [Koha-bugs] [Bug 11529] Add subtitle, medium and part fields to biblio table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11529 --- Comment #246 from Kyle M Hall --- (In reply to Kyle M Hall from comment #245) > Created attachment 105667 [details] [review] > Bug 11529: Do not update marc mappings, print old mappings to upgrade log Nick and I have been looking into this and this patch seems to be the only reasonable solution. In a nutshell, what Nick was trying to accomplish with that update query just isn't possible anymore. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 9 21:48:14 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jun 2020 19:48:14 +0000 Subject: [Koha-bugs] [Bug 25582] Don't show OPAC problems entry on dashboard when there are no reports In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25582 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #105482|0 |1 is obsolete| | --- Comment #3 from Owen Leonard --- Created attachment 105668 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105668&action=edit Bug 25582: Don't show OPAC problems entry on dashboard when there are no reports This patch makes a minor correction to the template to correct the check on outstanding OPAC problem reports. An error was preventing the check from working correctly. To test, apply the patch and enable the OPACReportProblem system preference. - On the staff interface home page, check the area showing pending operations (suggestions, tags, etc.). - If you have no pending OPAC problem reports there should be no line for OPAC problem reports. - If necessary, mark all pending OPAC problem reports closed and confirm that when there are no outstanding reports the link is hidden. - Also test when there are no other outstanding reports in that section (suggestions, tags, patron modifications), nothing appears at all, not even the surrounding border. - If necessary, test that the link appears when you have one or more OPAC problem reports. - Go to the OPAC and use the "Report a problem" to submit a test report. - Check that the staff interface home page reflects that there is now a pending report. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 9 21:48:31 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jun 2020 19:48:31 +0000 Subject: [Koha-bugs] [Bug 25582] Don't show OPAC problems entry on dashboard when there are no reports In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25582 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #105668|0 |1 is obsolete| | --- Comment #4 from Owen Leonard --- Created attachment 105669 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105669&action=edit Bug 25582: Don't show OPAC problems entry on dashboard when there are no reports This patch makes a minor correction to the template to correct the check on outstanding OPAC problem reports. An error was preventing the check from working correctly. To test, apply the patch and enable the OPACReportProblem system preference. - On the staff interface home page, check the area showing pending operations (suggestions, tags, etc.). - If you have no pending OPAC problem reports there should be no line for OPAC problem reports. - If necessary, mark all pending OPAC problem reports closed and confirm that when there are no outstanding reports the link is hidden. - Also test when there are no other outstanding reports in that section (suggestions, tags, patron modifications), nothing appears at all, not even the surrounding border. - If necessary, test that the link appears when you have one or more OPAC problem reports. - Go to the OPAC and use the "Report a problem" to submit a test report. - Check that the staff interface home page reflects that there is now a pending report. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 9 22:09:52 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jun 2020 20:09:52 +0000 Subject: [Koha-bugs] [Bug 25687] Switch Y/N in EDI accounts table for Yes and No for better translatability In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25687 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Depends on| |25677 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25677 [Bug 25677] Checkbox options for EDI accounts cannot be enabled -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 9 22:09:52 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jun 2020 20:09:52 +0000 Subject: [Koha-bugs] [Bug 25677] Checkbox options for EDI accounts cannot be enabled In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25677 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |25687 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25687 [Bug 25687] Switch Y/N in EDI accounts table for Yes and No for better translatability -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 9 22:13:16 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jun 2020 20:13:16 +0000 Subject: [Koha-bugs] [Bug 25687] Switch Y/N in EDI accounts table for Yes and No for better translatability In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25687 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |String patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 9 22:13:19 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jun 2020 20:13:19 +0000 Subject: [Koha-bugs] [Bug 25687] Switch Y/N in EDI accounts table for Yes and No for better translatability In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25687 --- Comment #1 from Owen Leonard --- Created attachment 105670 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105670&action=edit Bug 25687: Switch Y/N in EDI accounts table for Yes and No for better translatability This patch changes the list of EDI accounts shown in EDI administration so that columns which previously used "Y" or "N" now show "Yes" or "No." To test, apply the patch and go to Administration -> EDI accounts. If necessary, add an EDI account. In the table of information about the EDI account, the columns with information about quotes, orders, invoices, responses, and auto-ordering should show "Yes" or "No" based on the account's settings. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 9 22:14:12 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jun 2020 20:14:12 +0000 Subject: [Koha-bugs] [Bug 25701] Facets display in random order In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25701 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Component|OPAC |MARC Bibliographic data | |support Version|19.11 |master Assignee|oleonard at myacpl.org |koha-bugs at lists.koha-commun | |ity.org -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 9 22:25:16 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jun 2020 20:25:16 +0000 Subject: [Koha-bugs] [Bug 9750] Bring routing lists into notices & slips In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9750 Donna changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bwsdonna at gmail.com --- Comment #5 from Donna --- This is still a commonly requested enhancement that would give users a great amount of flexibility. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 9 22:52:08 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jun 2020 20:52:08 +0000 Subject: [Koha-bugs] [Bug 25702] New: Actions button on Search results from Z39.50 is displayed incorrectly Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25702 Bug ID: 25702 Summary: Actions button on Search results from Z39.50 is displayed incorrectly Change sponsored?: --- Product: Koha Version: 20.05 Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Z39.50 / SRU / OpenSearch Servers Assignee: koha-bugs at lists.koha-community.org Reporter: jkniez at gmail.com QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl Created attachment 105671 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105671&action=edit Screenshot of the wrong position of the menu launched by Actions button When clicking on the Actions button in the Z39.50 Search Results window, sometimes the menu is not displayed correctly (actually it is displayed under or next to the table with Results and it is not visible in the displayed area). Usually it happens after clicking on the table row and then on the Actions button. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 9 22:52:49 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jun 2020 20:52:49 +0000 Subject: [Koha-bugs] [Bug 25702] Actions button on Search results from Z39.50 is displayed incorrectly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25702 Ján Kniez changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 - low |P3 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jun 10 01:12:43 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jun 2020 23:12:43 +0000 Subject: [Koha-bugs] [Bug 25703] New: AllowItemsOnHoldCheckoutSCO behavior. Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25703 Bug ID: 25703 Summary: AllowItemsOnHoldCheckoutSCO behavior. Change sponsored?: --- Product: Koha Version: 19.05 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Self checkout Assignee: koha-bugs at lists.koha-community.org Reporter: eveal at mckinneytexas.org QA Contact: testopia at bugs.koha-community.org The AllowItemsOnHoldCheckoutSCO syspref allows all items on hold to be checkout within the selfcheck module. It seems to me that the preference would be more useful if it only allowed items with "Pending" holds not "confirmed and waiting" holds. Ed -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 10 01:20:50 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jun 2020 23:20:50 +0000 Subject: [Koha-bugs] [Bug 24458] Search results don't use Koha::Filter::MARC::ViewPolicy In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24458 --- Comment #21 from David Cook --- (In reply to Jonathan Druart from comment #18) > David, What about adding a check in search_for_data_inconsistencies.pl? Yeah maybe. I wasn't familiar with search_for_data_inconsistencies.pl, so I just took a look. (It actually looks like it would benefit from Bug 25661.) I suppose /cgi-bin/koha/admin/checkmarc.pl would be the best place for a user initiated check. Maybe a Koha::Check::* or Koha::Validate::* module that could be used in both places. Alternatively, I suppose we could make ViewPolicy skip critical MARC fields... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 10 01:25:18 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jun 2020 23:25:18 +0000 Subject: [Koha-bugs] [Bug 11529] Add subtitle, medium and part fields to biblio table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11529 --- Comment #247 from David Cook --- (In reply to Kyle M Hall from comment #246) > (In reply to Kyle M Hall from comment #245) > > Created attachment 105667 [details] [review] [review] > > Bug 11529: Do not update marc mappings, print old mappings to upgrade log > > Nick and I have been looking into this and this patch seems to be the only > reasonable solution. In a nutshell, what Nick was trying to accomplish with > that update query just isn't possible anymore. Agreed. Your patch is the same thing I've already implemented locally, and I haven't had any issues since. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 10 01:29:33 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jun 2020 23:29:33 +0000 Subject: [Koha-bugs] [Bug 11529] Add subtitle, medium and part fields to biblio table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11529 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #105667|0 |1 is obsolete| | --- Comment #248 from David Cook --- Created attachment 105672 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105672&action=edit Bug 11529: Do not update marc mappings, print old mappings to upgrade log Signed-off-by: David Cook -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 10 01:30:02 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jun 2020 23:30:02 +0000 Subject: [Koha-bugs] [Bug 11529] Add subtitle, medium and part fields to biblio table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11529 --- Comment #249 from David Cook --- Not sure if this needed a sign off but did one anyway. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 10 01:39:13 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jun 2020 23:39:13 +0000 Subject: [Koha-bugs] [Bug 15544] Zebra facets must be managed from the intranet In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15544 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au --- Comment #10 from David Cook --- I'm not familiar with the Elasticsearch configurable facet code, but I wonder how easy it would be to adapt this Zebra code to work with it too. (Although these days I think it would make more sense just to work towards fully deprecating Zebra to be honest.) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 10 01:50:00 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jun 2020 23:50:00 +0000 Subject: [Koha-bugs] [Bug 25703] AllowItemsOnHoldCheckoutSCO behavior. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25703 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrew at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 10 01:51:49 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 09 Jun 2020 23:51:49 +0000 Subject: [Koha-bugs] [Bug 24458] Search results don't use Koha::Filter::MARC::ViewPolicy In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24458 --- Comment #22 from Tomás Cohen Arazi --- (In reply to David Cook from comment #17) > I'm glad to see this change go in, but it appears that it caused Bug 25686, > because the visibility for the 999$c was set to hide. > > I don't think that it's a bug or regression, but rather we should let people > know somehow that they may need to update their MARC bibliographic > frameworks, since they won't be automatically updated. > > I suppose that the release notes would've been the place for that, but > perhaps it's too late for that? > > I think Koha should probably automatically update the "Default Framework" on > upgrades. The first time we do it could be problematic, since people's > changes would disappear (although we could back them up in an "Old Default > Framework"), but I figure we need to have some strategy for delivering > framework updates automatically. I'm surprised by this, as I recall some bug excluding 999 from this, or maybe it was a comment on the tests because now I cannot find it in bugzilla. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 10 02:13:23 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Jun 2020 00:13:23 +0000 Subject: [Koha-bugs] [Bug 25704] New: With ICU chains on, searching by callnumbers does not produce accurate results Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25704 Bug ID: 25704 Summary: With ICU chains on, searching by callnumbers does not produce accurate results Change sponsored?: --- Product: Koha Version: 19.11 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Searching - Zebra Assignee: koha-bugs at lists.koha-community.org Reporter: kelly at bywatersolutions.com This seems to be a change in functionality around the 19.05.09 version, with ICU chains turned on, the ability to search using the "Call Number" option from the staff client or the OPAC search, is not working accurately. It will pull results but not all good results and certainly not find all the results for that particular search. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jun 10 04:04:28 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Jun 2020 02:04:28 +0000 Subject: [Koha-bugs] [Bug 22807] Accessibility: Add 'Skip to Main Content' link In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22807 --- Comment #6 from Hayley Mapley --- The main reason for wanting the 'Skip to main content' link in Koha I think is to bypass all the elements in the header such as the Cart, Lists, and Search bars. So for example we would not need it in opac-basket.tt, and in the opac-main.tt we'd want it around the .main div where all the text from News items and main user block are. Happy to defer to an expert as I am not one, if anyone else has thoughts! On the patch, it would be good to make it a bit brighter and bolder so it's more obvious, as it's not only visually impaired users who are keyboard only. Also, when I tested, the behaviour was weird and I'm not sure why, could be my internet? So will need another tester. But when I hit tab and then enter it wouldn't register for a bit, then I'd spam hit enter a couple of times and it would jump down. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 10 04:44:11 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Jun 2020 02:44:11 +0000 Subject: [Koha-bugs] [Bug 25168] mandatory field has been set in admin but purchase suggestion (in opac) allow to enter null value In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25168 ciarebaha changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|INVALID |FIXED --- Comment #17 from ciarebaha --- (In reply to Jonathan Druart from comment #16) > The problematic line is: > > 1118 var FldsRequired = [ARRAY(0x66dd688)]; > > Can you open your file opac-suggestions.tt and copy what you have line 346 > please? > > It must be > > 346 var FldsRequired = ['[% mandatoryfields.join("','") | html > %]']; The purchase suggestion already working now after we add .join (",") to opac.suggestion.tt. Thank you all. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 10 05:13:27 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Jun 2020 03:13:27 +0000 Subject: [Koha-bugs] [Bug 24458] Search results don't use Koha::Filter::MARC::ViewPolicy In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24458 --- Comment #23 from David Cook --- (In reply to Tomás Cohen Arazi from comment #22) > I'm surprised by this, as I recall some bug excluding 999 from this, or > maybe it was a comment on the tests because now I cannot find it in bugzilla. I see a comment in ./Koha/Filter/MARC/ViewPolicy.pm about how hiding the LDR causes "the MARCXML->MARC::Record->MARCXML transformation blows up"? I imagine the fix would be to have a hash containing critical fields based on the MARC schema (I don't recall if Unimarc uses 999$c as well or not), and then just consult that in _filter_field()? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 10 05:19:02 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Jun 2020 03:19:02 +0000 Subject: [Koha-bugs] [Bug 25704] With ICU chains on, searching by callnumbers does not produce accurate results In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25704 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au --- Comment #1 from David Cook --- Hmm the ICU files don't look like they've changed in 5 years, so nothing on that end. Without more detail, this might be considered a support report rather than a bug report. (I'd suggest turning up the verbosity on the Zebra server logging, and comparing ICU vs CHR call number searching to see what differences are happening at the Zebra server level.) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 10 05:20:30 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Jun 2020 03:20:30 +0000 Subject: [Koha-bugs] [Bug 22807] Accessibility: Add 'Skip to Main Content' link In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22807 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 10 05:32:12 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Jun 2020 03:32:12 +0000 Subject: [Koha-bugs] [Bug 22522] API authentication breaks with updated Mojolicious version In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22522 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |aleisha at catalyst.net.nz --- Comment #71 from Aleisha Amohia --- Hi all, the tests fail in Jenkins in 19.11. Output below: 10:41:09 koha_1 | DBD::mysql::st execute failed: Unknown column 'name' in 'where clause' [for Statement "SELECT COUNT( * ) FROM `cities` `me` WHERE ( `name` LIKE ? )" with ParamValues: 0="manuel%"] at /usr/share/perl5/DBIx/Class/Storage/DBI.pm line 1836. 10:41:09 koha_1 | 10:41:09 koha_1 | # Failed test '200 OK' 10:41:09 koha_1 | # at t/db_dependent/Koha/REST/Plugin/Objects.t line 155. 10:41:09 koha_1 | # got: '500' 10:41:09 koha_1 | # expected: '200' 10:41:09 koha_1 | 10:41:09 koha_1 | # Failed test 'has value for JSON Pointer "/0"' 10:41:09 koha_1 | # at t/db_dependent/Koha/REST/Plugin/Objects.t line 155. 10:41:09 koha_1 | 10:41:09 koha_1 | # Failed test 'has value for JSON Pointer "/1"' 10:41:09 koha_1 | # at t/db_dependent/Koha/REST/Plugin/Objects.t line 155. 10:41:09 koha_1 | 10:41:09 koha_1 | # Failed test 'has value for JSON Pointer "/2"' 10:41:09 koha_1 | # at t/db_dependent/Koha/REST/Plugin/Objects.t line 155. 10:41:09 koha_1 | 10:41:09 koha_1 | # Failed test 'exact match for JSON Pointer "/0/name"' 10:41:09 koha_1 | # at t/db_dependent/Koha/REST/Plugin/Objects.t line 155. 10:41:09 koha_1 | # got: undef 10:41:09 koha_1 | # expected: 'Manuel' 10:41:09 koha_1 | 10:41:09 koha_1 | # Failed test 'exact match for JSON Pointer "/1/name"' 10:41:09 koha_1 | # at t/db_dependent/Koha/REST/Plugin/Objects.t line 155. 10:41:09 koha_1 | # got: undef 10:41:09 koha_1 | # expected: 'Manuela' 10:41:09 koha_1 | 10:41:09 koha_1 | # Failed test 'exact match for JSON Pointer "/2/name"' 10:41:09 koha_1 | # at t/db_dependent/Koha/REST/Plugin/Objects.t line 155. 10:41:09 koha_1 | # got: undef 10:41:09 koha_1 | # expected: 'Manuelab' -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 10 05:35:21 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Jun 2020 03:35:21 +0000 Subject: [Koha-bugs] [Bug 25506] Perl undef warning on the "About Koha" page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25506 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|20.05.00 |20.05.00, 19.11.07 released in| | Status|Pushed to master |Pushed to stable CC| |aleisha at catalyst.net.nz --- Comment #5 from Aleisha Amohia --- backported to 19.11.x for 19.11.07 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 10 05:36:18 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Jun 2020 03:36:18 +0000 Subject: [Koha-bugs] [Bug 25452] Alternate email contact not displayed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25452 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|20.05.00 |20.05.00, 19.11.07 released in| | Status|Pushed to master |Pushed to stable CC| |aleisha at catalyst.net.nz --- Comment #7 from Aleisha Amohia --- backported to 19.11.x for 19.11.07 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 10 05:37:34 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Jun 2020 03:37:34 +0000 Subject: [Koha-bugs] [Bug 25428] Escaped HTML shows in authority detail view when subfield is a link In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25428 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|20.05.00 |20.05.00, 19.11.07 released in| | CC| |aleisha at catalyst.net.nz Status|Pushed to master |Pushed to stable --- Comment #5 from Aleisha Amohia --- backported to 19.11.x for 19.11.07 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jun 10 08:17:54 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Jun 2020 06:17:54 +0000 Subject: [Koha-bugs] [Bug 25690] SIP allows to check out an item with hold in transfer to another patron In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25690 --- Comment #1 from Minna Kivinen --- (In reply to Minna Kivinen from comment #0) > When system preference AllowItemsOnHoldCheckout is enabled, SIP allows > another patron to check out an item with hold in transfer. After that the > item is attached both to hold (reserves-table) and issue (issues table). > > The system should NOT allow to check out an item to another patron than the one > with hold, when item is attached to hold and is in transfer. > > This bug leads to unfortunate situations where patron with hold never gets > the item. Borrower can't renew item since there is the hold, but the > borrower can check in the item by self service station and check out again > despite the hold in item. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 10 08:21:20 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Jun 2020 06:21:20 +0000 Subject: [Koha-bugs] [Bug 25690] SIP allows to check out an item with hold in transfer to another patron In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25690 --- Comment #2 from Minna Kivinen --- Sorry, there is a typo in description. The system should NOT allow to check out an item to another patron than the one with hold, when item is attached to hold and is in transfer. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jun 10 08:21:58 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Jun 2020 06:21:58 +0000 Subject: [Koha-bugs] [Bug 25705] New: Viewing all serials issues should not require serials permissions Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25705 Bug ID: 25705 Summary: Viewing all serials issues should not require serials permissions Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Serials Assignee: koha-bugs at lists.koha-community.org Reporter: dcook at prosentient.com.au QA Contact: testopia at bugs.koha-community.org CC: colin.campbell at ptfs-europe.com On the "/cgi-bin/koha/opac-detail.pl?biblionumber=X" page, there is a link "More Details" (/cgi-bin/koha/opac-serial-issues.pl?biblionumber=X), which shows the "Full subscription history" (ie received issues) for a subscription for a bib record. The Staff Client does not have an equivalent. The "/cgi-bin/koha/catalogue/detail.pl?biblionumber=X" page has a "Subscription details" (/cgi-bin/koha/serials/subscription-detail.pl?subscriptionid=X) link, but that requires full Serials permissions. Plus, it's not really equivalent. The closest equivalent is "/cgi-bin/koha/serials/serials-collection.pl?subscriptionid=X", but it also requires full Serials module permissions. It does not make sense that an OPAC user can see more data than a Staff Client user. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 10 08:23:04 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Jun 2020 06:23:04 +0000 Subject: [Koha-bugs] [Bug 25705] Viewing all serials issues should not require serials permissions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25705 --- Comment #1 from David Cook --- I think the answer is probably to make a "/cgi-bin/koha/catalogue/serial-issues.pl" script. Rather than fiddling with permissions in the "serials" module, I figure we can just expose that data via the "catalogue" module. We could create a Template::Toolkit include that works in both modules to reduce copy/paste template boilerplate. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jun 10 08:36:10 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Jun 2020 06:36:10 +0000 Subject: [Koha-bugs] [Bug 25705] Viewing all serials issues should not require serials permissions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25705 --- Comment #2 from David Cook --- Actually, now I'm thinking that we should add a /api/v1/serials/issues REST API endpoint. We could then refactor the Staff Client and OPAC to use that API endpoint (starting with the /cgi-bin/koha/catalogue/detail.pl page). -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jun 10 08:37:14 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Jun 2020 06:37:14 +0000 Subject: [Koha-bugs] [Bug 11529] Add subtitle, medium and part fields to biblio table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11529 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|REOPENED |RESOLVED --- Comment #250 from Katrin Fischer --- (In reply to David Cook from comment #249) > Not sure if this needed a sign off but did one anyway. A sign off is great, but we'll also need this to be moved to a separate bug - this bug has been long released and we want the fix to show up with a nice description in the release notes. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 10 08:37:16 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Jun 2020 06:37:16 +0000 Subject: [Koha-bugs] [Bug 7384] Improve title display in cart and list emails by displaying subtitles, number and part information In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7384 Bug 7384 depends on bug 11529, which changed state. Bug 11529 Summary: Add subtitle, medium and part fields to biblio table https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11529 What |Removed |Added ---------------------------------------------------------------------------- Status|REOPENED |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 10 08:37:16 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Jun 2020 06:37:16 +0000 Subject: [Koha-bugs] [Bug 14911] Item search: Display additional 245 subfields in search results In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14911 Bug 14911 depends on bug 11529, which changed state. Bug 11529 Summary: Add subtitle, medium and part fields to biblio table https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11529 What |Removed |Added ---------------------------------------------------------------------------- Status|REOPENED |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 10 08:37:17 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Jun 2020 06:37:17 +0000 Subject: [Koha-bugs] [Bug 22569] Stock rotation: 'Transfers to send' report In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22569 Bug 22569 depends on bug 11529, which changed state. Bug 11529 Summary: Add subtitle, medium and part fields to biblio table https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11529 What |Removed |Added ---------------------------------------------------------------------------- Status|REOPENED |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 10 08:37:17 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Jun 2020 06:37:17 +0000 Subject: [Koha-bugs] [Bug 4164] Way to Clone Keyword Mapping to other Frameworks In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4164 Bug 4164 depends on bug 11529, which changed state. Bug 11529 Summary: Add subtitle, medium and part fields to biblio table https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11529 What |Removed |Added ---------------------------------------------------------------------------- Status|REOPENED |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug. You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 10 08:37:17 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Jun 2020 06:37:17 +0000 Subject: [Koha-bugs] [Bug 4166] No way to know what keywords to use for Keyword Mapping In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4166 Bug 4166 depends on bug 11529, which changed state. Bug 11529 Summary: Add subtitle, medium and part fields to biblio table https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11529 What |Removed |Added ---------------------------------------------------------------------------- Status|REOPENED |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jun 10 08:37:17 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Jun 2020 06:37:17 +0000 Subject: [Koha-bugs] [Bug 7074] Show subtitle, part and number of a record in list of checkins In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7074 Bug 7074 depends on bug 11529, which changed state. Bug 11529 Summary: Add subtitle, medium and part fields to biblio table https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11529 What |Removed |Added ---------------------------------------------------------------------------- Status|REOPENED |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 10 08:37:17 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Jun 2020 06:37:17 +0000 Subject: [Koha-bugs] [Bug 8265] Allow a better form of the title to be included in notices In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8265 Bug 8265 depends on bug 11529, which changed state. Bug 11529 Summary: Add subtitle, medium and part fields to biblio table https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11529 What |Removed |Added ---------------------------------------------------------------------------- Status|REOPENED |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 10 08:37:18 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Jun 2020 06:37:18 +0000 Subject: [Koha-bugs] [Bug 10953] Missing subtitle fieldmapping unless you use ru-RU or uk-UA In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10953 Bug 10953 depends on bug 11529, which changed state. Bug 11529 Summary: Add subtitle, medium and part fields to biblio table https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11529 What |Removed |Added ---------------------------------------------------------------------------- Status|REOPENED |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 10 08:37:18 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Jun 2020 06:37:18 +0000 Subject: [Koha-bugs] [Bug 15972] Make it possible to include additional title information in notices (such as 245$b) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15972 Bug 15972 depends on bug 11529, which changed state. Bug 11529 Summary: Add subtitle, medium and part fields to biblio table https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11529 What |Removed |Added ---------------------------------------------------------------------------- Status|REOPENED |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jun 10 08:37:18 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Jun 2020 06:37:18 +0000 Subject: [Koha-bugs] [Bug 22699] Remove documentation on Keywords to MARC mapping In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22699 Bug 22699 depends on bug 11529, which changed state. Bug 11529 Summary: Add subtitle, medium and part fields to biblio table https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11529 What |Removed |Added ---------------------------------------------------------------------------- Status|REOPENED |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jun 10 08:38:48 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Jun 2020 06:38:48 +0000 Subject: [Koha-bugs] [Bug 15544] Zebra facets must be managed from the intranet In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15544 --- Comment #11 from Katrin Fischer --- (In reply to David Cook from comment #10) > I'm not familiar with the Elasticsearch configurable facet code, but I > wonder how easy it would be to adapt this Zebra code to work with it too. > > (Although these days I think it would make more sense just to work towards > fully deprecating Zebra to be honest.) I think there is still a lot of libraries that profit from the low requirements of Zebra out there. I am not in favour of depracating it at this point in time. But we have certain features that are only developed for Elasticsearch. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 10 09:01:44 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Jun 2020 07:01:44 +0000 Subject: [Koha-bugs] [Bug 25168] mandatory field has been set in admin but purchase suggestion (in opac) allow to enter null value In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25168 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|FIXED |INVALID --- Comment #18 from Jonathan Druart --- This is the exact line that exists in 18.11.13 You should not edit your file manually, consider an upgrade instead. And, next time you open a bug report, please make sure you report the correct Koha version number! You can find it on the about page. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 10 09:26:35 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Jun 2020 07:26:35 +0000 Subject: [Koha-bugs] [Bug 25701] Facets display in random order In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25701 Jonathan Field changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.field at ptfs-europe. | |com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 10 10:03:03 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Jun 2020 08:03:03 +0000 Subject: [Koha-bugs] [Bug 22522] API authentication breaks with updated Mojolicious version In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22522 --- Comment #72 from Jonathan Druart --- 19.11: There is something wrong in the paths, and so plack does not start correctly. I have cherry-picked a07c5c153aaecc5cc8b0d1de5c53f184da5971b9 Bug 25279: Add general query parameters to the /cities route But there is still something wrong in the tests, name is not reversed with city_name but I did not find what was missing. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 10 10:23:44 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Jun 2020 08:23:44 +0000 Subject: [Koha-bugs] [Bug 25582] Don't show OPAC problems entry on dashboard when there are no reports In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25582 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 10 10:23:48 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Jun 2020 08:23:48 +0000 Subject: [Koha-bugs] [Bug 25582] Don't show OPAC problems entry on dashboard when there are no reports In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25582 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #105669|0 |1 is obsolete| | --- Comment #5 from David Nind --- Created attachment 105673 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105673&action=edit Bug 25582: Don't show OPAC problems entry on dashboard when there are no reports This patch makes a minor correction to the template to correct the check on outstanding OPAC problem reports. An error was preventing the check from working correctly. To test, apply the patch and enable the OPACReportProblem system preference. - On the staff interface home page, check the area showing pending operations (suggestions, tags, etc.). - If you have no pending OPAC problem reports there should be no line for OPAC problem reports. - If necessary, mark all pending OPAC problem reports closed and confirm that when there are no outstanding reports the link is hidden. - Also test when there are no other outstanding reports in that section (suggestions, tags, patron modifications), nothing appears at all, not even the surrounding border. - If necessary, test that the link appears when you have one or more OPAC problem reports. - Go to the OPAC and use the "Report a problem" to submit a test report. - Check that the staff interface home page reflects that there is now a pending report. Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 10 10:39:09 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Jun 2020 08:39:09 +0000 Subject: [Koha-bugs] [Bug 25507] PDF order print for German 2-pages is broken In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25507 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 10 10:39:12 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Jun 2020 08:39:12 +0000 Subject: [Koha-bugs] [Bug 25507] PDF order print for German 2-pages is broken In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25507 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #105295|0 |1 is obsolete| | --- Comment #3 from David Nind --- Created attachment 105674 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105674&action=edit Bug 25507: Fix table in basket group PDF German 2-pages A variable was doubled up which made the columns in the table of orders no longer line up (different number of headers to columns). To test: - Create at least one basket with one or more orders - Close the basket - Add the basket to a basket group manually or let Koha do it on closing - Change the OrderPdfFormat system preference to 'German 2-page' - Go to the basket group page and print the PDF of the basket - Verify the table of orders doesn't look right and runs outside the page - Apply patch - Repeat the PDF print - now table should look right Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 10 10:49:30 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Jun 2020 08:49:30 +0000 Subject: [Koha-bugs] [Bug 25538] www/search_utf8.t is failing randomly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25538 --- Comment #5 from Jonathan Druart --- This is because KOHA_OPAC_URL is not set. On both U18 and D11 I get the following (known error that should not have been ignored so long): root at c4adf9b9b785:koha(master|BISECTING)$ kshell bash: /root/.bashrc: Permission denied This can be recreated easily by defining a wrong KOHA_OPAC_URL. $ koha-shell ${KOHA_INSTANCE} -p -c "echo $KOHA_OPAC_URL" -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 10 10:50:27 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Jun 2020 08:50:27 +0000 Subject: [Koha-bugs] [Bug 25538] www/search_utf8.t is failing randomly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25538 --- Comment #6 from Jonathan Druart --- Created attachment 105675 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105675&action=edit Bug 25538: Don't run search_utf8.t if KOHA_*_URL empty -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 10 10:52:30 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Jun 2020 08:52:30 +0000 Subject: [Koha-bugs] [Bug 25701] Facets display in random order In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25701 Janet McGowan changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |janet.mcgowan at ptfs-europe.c | |om -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 10 10:55:02 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Jun 2020 08:55:02 +0000 Subject: [Koha-bugs] [Bug 25538] www/search_utf8.t is failing randomly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25538 --- Comment #7 from Jonathan Druart --- koha-testing-docker related issue: https://gitlab.com/koha-community/koha-testing-docker/-/issues/202 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 10 11:02:36 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Jun 2020 09:02:36 +0000 Subject: [Koha-bugs] [Bug 25706] New: Suggestions: Make fields for the items table available in AVAILABLE notice Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25706 Bug ID: 25706 Summary: Suggestions: Make fields for the items table available in AVAILABLE notice Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Notices Assignee: koha-bugs at lists.koha-community.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org The notice that is sent when an item from a suggestion becomes available has the letter code AVAILABLE. In this notice it would be very useful if information from the item could be added, like the callnumber and other location information of the new item. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jun 10 11:20:15 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Jun 2020 09:20:15 +0000 Subject: [Koha-bugs] [Bug 25538] www/search_utf8.t is failing randomly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25538 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 10 11:20:18 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Jun 2020 09:20:18 +0000 Subject: [Koha-bugs] [Bug 25538] www/search_utf8.t is failing randomly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25538 --- Comment #8 from Jonathan Druart --- Created attachment 105676 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105676&action=edit Bug 25538: Use sudo -i in koha-shell See man sudo, -i parameter. Should we expect regressions? Test plan: 0. Use D11 or U18. Don't apply this patch 1. $ echo $KOHA_INTRANET_URL $ sudo koha-shell kohadev $ echo $KOHA_INTRANET_URL 2. Apply this patch $ cp debian/scripts/koha-shell /usr/sbin/koha-shell 3. Repeat 1. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 10 11:20:40 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Jun 2020 09:20:40 +0000 Subject: [Koha-bugs] [Bug 25538] www/search_utf8.t is failing randomly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25538 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|chris at bigballofwax.co.nz |jonathan.druart at bugs.koha-c | |ommunity.org Severity|normal |major -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 10 11:36:11 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Jun 2020 09:36:11 +0000 Subject: [Koha-bugs] [Bug 25322] Adding a guarantor with no relationship defaults to father In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25322 Peter Vashchuk changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 10 11:36:15 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Jun 2020 09:36:15 +0000 Subject: [Koha-bugs] [Bug 25322] Adding a guarantor with no relationship defaults to father In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25322 Peter Vashchuk changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #105420|0 |1 is obsolete| | --- Comment #29 from Peter Vashchuk --- Created attachment 105677 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105677&action=edit Bug 25322: fix for not selected "relationship" defaults to father When a user creates a patron's guarantor on /cgi-bin/koha/members/memberentry.pl but doesn't select the relationship from a dropdown, the relationship defaults to first value, which in default sysprefs is "father". This may or may not be correct as this is not a conscious choice from the user. The solution is to make the "Relationship" field mandatory when there is no empty entry in the system preferences, always starting with an empty option but not allowing the user to save an empty entry. And if there is an empty option in sysprefs, it allows to save empty, as well as makes it default choice. To reproduce with default system preferences: 1) Create a new patron who is assumed to have a guarantor or modify the existing one. 2) Under "Guarantor Information" click on "Search to add" button. After performing the search, select a user to act as guarantor. Don't use the dropdown menu to select a relationship. Save your changes. 3) Observe that relationship is set as "father". 4) Apply the patch. 5) Repeat steps 1 and 2. 6) Observe that it doesn't allow you to save the form until you pick a relationship type. To reproduce with empty entry added to system preferences: 1) Add an empty entry to borrowerRelationship at /cgi-bin/koha/admin/preferences.pl?tab=patrons in Patron relationships section (example: "|father|mother"). 2) Create a new patron who is assumed to have a guarantor or modify the existing one. 3) Under "Guarantor Information" click on "Search to add" button. After performing the search, select a user to act as guarantor. Don't use the dropdown menu to select a relationship. Save your changes. 4) Observe that relationship is set as "father". 5) Apply the patch. 6) Repeat steps 1, 2 and 3. 7) Observe when you save the empty entry it does set the relationship as empty. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 10 11:55:18 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Jun 2020 09:55:18 +0000 Subject: [Koha-bugs] [Bug 22807] Accessibility: Add 'Skip to Main Content' link In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22807 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #105664|0 |1 is obsolete| | --- Comment #7 from Martin Renvoize --- Created attachment 105678 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105678&action=edit Bug 22807: Add 'Skip to content' option This patch adds a 'Skip to content' link to the header bar which will only appear upon the first use of 'tab' to navigate after any fresh page load in the OPAC. Test plan 1/ Load any page in the OPAC 2/ Hit the `tab` key 3/ Note the new 'Skip to main content' link appears at the top left of the screen. 4/ Hit `Enter` or Click the button 5/ Note the page scrolls to the area of the page that has the first block containing a .maincontent class. 6/ Note that the next available focusable element after the first .maincontent block has been given focus. 7/ Note that the link has been hidden -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 10 12:05:13 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Jun 2020 10:05:13 +0000 Subject: [Koha-bugs] [Bug 25707] New: Mappings update in bug 11529 causes data loss Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25707 Bug ID: 25707 Summary: Mappings update in bug 11529 causes data loss Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: critical Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs at lists.koha-community.org Reporter: nick at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org Turns out the database update for this change causes unexpected changes to the "Koha to MARC mapping" (via the MARC frameworks) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jun 10 12:05:28 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Jun 2020 10:05:28 +0000 Subject: [Koha-bugs] [Bug 22569] Stock rotation: 'Transfers to send' report In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22569 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|11529 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11529 [Bug 11529] Add subtitle, medium and part fields to biblio table -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 10 12:05:28 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Jun 2020 10:05:28 +0000 Subject: [Koha-bugs] [Bug 11529] Add subtitle, medium and part fields to biblio table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11529 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|22569 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22569 [Bug 22569] Stock rotation: 'Transfers to send' report -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 10 12:06:34 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Jun 2020 10:06:34 +0000 Subject: [Koha-bugs] [Bug 25701] Facets display in random order In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25701 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 10 12:06:37 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Jun 2020 10:06:37 +0000 Subject: [Koha-bugs] [Bug 25701] Facets display in random order In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25701 --- Comment #1 from Jonathan Druart --- Created attachment 105679 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105679&action=edit Bug 25701: (bug 14419 follow-up) Always display facet groups in the same order It seems that this regression comes from bug 14419, but I have not found a logic reason behind that. This patch restores the behaviour we always had: facet groups must be displayed in a given order: the Zebra index (au, ccode, holdingbranch, etc.) Test plan: Apply this patch, restart all and confirm that the facets are not moving up and down when you refresh your search result page. QA note: I think the following line must be removed @facets_loop = sort {defined $a->{expand} && defined $b->{expand} && $a->{expand} cmp $b->{expand}} @facets_loop; -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jun 10 12:06:50 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Jun 2020 10:06:50 +0000 Subject: [Koha-bugs] [Bug 25701] Facets display in random order In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25701 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |14419 Severity|minor |normal Assignee|koha-bugs at lists.koha-commun |jonathan.druart at bugs.koha-c |ity.org |ommunity.org CC| |jonathan.druart at bugs.koha-c | |ommunity.org Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14419 [Bug 14419] Expanding facets (Show more) performs a new search -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 10 12:06:50 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Jun 2020 10:06:50 +0000 Subject: [Koha-bugs] [Bug 14419] Expanding facets (Show more) performs a new search In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14419 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |25701 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25701 [Bug 25701] Facets display in random order -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 10 12:08:05 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Jun 2020 10:08:05 +0000 Subject: [Koha-bugs] [Bug 25683] update_patron_categories.pl should recognize no fine history = 0 outstanding fines In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25683 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david at davidnind.com --- Comment #11 from David Nind --- I'm a bit confused with this one, sorry! Using J patron category and Bobbie Middleton in koha-testing-docker - no transactions to start with. Before applying the patch, results are: perl update_patrons_category.pl -f J -t J -fu=5 -v No actions will be taken (test mode) Will update patrons from J to J with conditions below (if any) Conditions: Total fines less than 5 0 found, 0 updated After adding a charge of $1.00: perl update_patrons_category.pl -f J -t J -fu=5 -v No actions will be taken (test mode) Will update patrons from J to J with conditions below (if any) Conditions: Total fines less than 5 WOULD HAVE Updated Bobbie Middleton from J to J 1 found, 0 updated After paying off charge (balance is $0, two transactions with charge and payment) - two lines appear for patron, even though the their balance is $0: perl update_patrons_category.pl -f J -t J -fu=5 -v No actions will be taken (test mode) Will update patrons from J to J with conditions below (if any) Conditions: Total fines less than 5 WOULD HAVE Updated Bobbie Middleton from J to J WOULD HAVE Updated Bobbie Middleton from J to J 1 found, 0 updated After applying the patch: perl update_patrons_category.pl -f J -t J -fu=5 -v No actions will be taken (test mode) Will update patrons from J to J with conditions below (if any) Conditions: Total fines less than 5 WOULD HAVE Updated Bobbie Middleton from J to J WOULD HAVE Updated Bobbie Middleton from J to J WOULD HAVE Updated Gordon Peterson from J to J WOULD HAVE Updated Mae Kinney from J to J 3 found, 0 updated After applying the patch and adding another charge - Bobbie Middleton appears three times: perl update_patrons_category.pl -f J -t J -fu=5 -v No actions will be taken (test mode) Will update patrons from J to J with conditions below (if any) Conditions: Total fines less than 5 WOULD HAVE Updated Bobbie Middleton from J to J WOULD HAVE Updated Bobbie Middleton from J to J WOULD HAVE Updated Bobbie Middleton from J to J WOULD HAVE Updated Gordon Peterson from J to J WOULD HAVE Updated Mae Kinney from J to J 3 found, 0 updated Every transaction added increases the number of times they appear. If the above is what is expected then I'm happy to sign off! ==> Outcome after applying the patch is that all patrons for the category with charges under 5 should appear, even if they have a 0 balance -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 10 12:08:37 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Jun 2020 10:08:37 +0000 Subject: [Koha-bugs] [Bug 25707] Mappings update in bug 11529 causes data loss In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25707 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 10 12:08:39 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Jun 2020 10:08:39 +0000 Subject: [Koha-bugs] [Bug 25707] Mappings update in bug 11529 causes data loss In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25707 --- Comment #1 from Nick Clemens --- Created attachment 105680 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105680&action=edit Bug 25707: (bug 11529 follow-up) Do not update marc mappings, print old mappings to upgrade log This patch removes the update of marc frameworks from the updatedatabase script and warns the "MARC to Keyword" (fieldmappings ) to the upgrade log so they can be replaced manually Signed-off-by: David Cook -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jun 10 12:09:04 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Jun 2020 10:09:04 +0000 Subject: [Koha-bugs] [Bug 25707] Mappings update in bug 11529 causes data loss In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25707 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |kyle at bywatersolutions.com |ity.org | Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jun 10 12:12:45 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Jun 2020 10:12:45 +0000 Subject: [Koha-bugs] [Bug 22807] Accessibility: Add 'Skip to Main Content' link In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22807 --- Comment #8 from Martin Renvoize --- Patch updated to highlight the button more clearly and to move the focus as well as triggering a scroll event on click/enter. As for where the '.maincontent' is set, I intend to work my way through this… I've found a few cases where we have multiple '.maincontent' classes defined on the page which feels incorrect as well as many cases where there isn't one at all. I think all pages require such a tag; At least that's how I've read a recent accessibility report one of our customers has commissioned. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 10 12:15:12 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Jun 2020 10:15:12 +0000 Subject: [Koha-bugs] [Bug 22807] Accessibility: Add 'Skip to Main Content' link In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22807 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bolshawh at parliament.uk -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 10 12:25:32 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Jun 2020 10:25:32 +0000 Subject: [Koha-bugs] [Bug 25701] Facets display in random order In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25701 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 10 12:25:35 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Jun 2020 10:25:35 +0000 Subject: [Koha-bugs] [Bug 25701] Facets display in random order In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25701 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #105679|0 |1 is obsolete| | --- Comment #2 from David Nind --- Created attachment 105681 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105681&action=edit Bug 25701: (bug 14419 follow-up) Always display facet groups in the same order It seems that this regression comes from bug 14419, but I have not found a logic reason behind that. This patch restores the behaviour we always had: facet groups must be displayed in a given order: the Zebra index (au, ccode, holdingbranch, etc.) Test plan: Apply this patch, restart all and confirm that the facets are not moving up and down when you refresh your search result page. QA note: I think the following line must be removed @facets_loop = sort {defined $a->{expand} && defined $b->{expand} && $a->{expand} cmp $b->{expand}} @facets_loop; Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 10 12:33:16 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Jun 2020 10:33:16 +0000 Subject: [Koha-bugs] [Bug 25701] Facets display in random order In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25701 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick at bywatersolutions.com --- Comment #3 from Nick Clemens --- (In reply to Jonathan Druart from comment #1) > Created attachment 105679 [details] [review] > Bug 25701: (bug 14419 follow-up) Always display facet groups in the same > order > > It seems that this regression comes from bug 14419, but I have not found > a logic reason behind that. > I think the following line must be removed > @facets_loop = sort {defined $a->{expand} && defined $b->{expand} && > $a->{expand} cmp $b->{expand}} @facets_loop; Afaict the line you change in the patch never worked, we always relied on the secondary sort line you mention above. I removed the 'expand' field in my patches on 14419 set which broke the second (actual) sort I agree we should remove this line and fix the first sort -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 10 12:48:50 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Jun 2020 10:48:50 +0000 Subject: [Koha-bugs] [Bug 25701] Facets display in random order In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25701 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |3580 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3580 [Bug 3580] Control order in which facet categories display -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 10 12:48:50 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Jun 2020 10:48:50 +0000 Subject: [Koha-bugs] [Bug 3580] Control order in which facet categories display In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3580 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |25701 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25701 [Bug 25701] Facets display in random order -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 10 12:50:18 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Jun 2020 10:50:18 +0000 Subject: [Koha-bugs] [Bug 25701] Facets display in random order In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25701 --- Comment #4 from Jonathan Druart --- Nick, did you understand why your patches break the sort? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 10 13:00:45 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Jun 2020 11:00:45 +0000 Subject: [Koha-bugs] [Bug 25701] Facets display in random order In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25701 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 10 13:00:48 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Jun 2020 11:00:48 +0000 Subject: [Koha-bugs] [Bug 25701] Facets display in random order In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25701 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #105681|0 |1 is obsolete| | --- Comment #5 from Nick Clemens --- Created attachment 105682 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105682&action=edit Bug 25701: (bug 14419 follow-up) Always display facet groups in the same order It seems that this regression comes from bug 14419, but I have not found a logic reason behind that. This patch restores the behaviour we always had: facet groups must be displayed in a given order: the Zebra index (au, ccode, holdingbranch, etc.) Test plan: Apply this patch, restart all and confirm that the facets are not moving up and down when you refresh your search result page. QA note: I think the following line must be removed @facets_loop = sort {defined $a->{expand} && defined $b->{expand} && $a->{expand} cmp $b->{expand}} @facets_loop; Signed-off-by: David Nind Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 10 13:00:51 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Jun 2020 11:00:51 +0000 Subject: [Koha-bugs] [Bug 25701] Facets display in random order In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25701 --- Comment #6 from Nick Clemens --- Created attachment 105683 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105683&action=edit Bug 25701: Remove sort on removed field Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 10 13:01:50 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Jun 2020 11:01:50 +0000 Subject: [Koha-bugs] [Bug 25701] Facets display in random order In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25701 --- Comment #7 from Nick Clemens --- (In reply to Jonathan Druart from comment #4) > Nick, did you understand why your patches break the sort? Because I removed the 'expand' field - that was the sort that actually sorted. That initial sort did nothing. See bug 3580 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 10 13:02:06 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Jun 2020 11:02:06 +0000 Subject: [Koha-bugs] [Bug 25676] Staff client catalog search shows incorrect item status under location In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25676 --- Comment #4 from Jonathan Druart --- Created attachment 105684 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105684&action=edit Bug 25676: Display the correct Lost value in the result search -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 10 13:05:24 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Jun 2020 11:05:24 +0000 Subject: [Koha-bugs] [Bug 25676] Staff client catalog search shows incorrect item status under location In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25676 --- Comment #5 from Jonathan Druart --- I had a try to fix this, but it's confusing. About "(1, 1 Lost)", I never managed to display more that 1 on the same line. For onloan items, I can only see 1 line per line (they are not grouped if same code, location, cn, etc.) The idea here was to display: (2, 1 Lost, 1 Long overdue), depending on the description in the LOST av category. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 10 13:14:51 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Jun 2020 11:14:51 +0000 Subject: [Koha-bugs] [Bug 25699] Edition information to Holds to pull report In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25699 Andrew Nugged changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nugged at gmail.com, | |slavashishkin at gmail.com, | |stalkernoid at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 10 13:22:00 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Jun 2020 11:22:00 +0000 Subject: [Koha-bugs] [Bug 25538] www/search_utf8.t is failing randomly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25538 --- Comment #9 from Jonathan Druart --- Created attachment 105685 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105685&action=edit Bug 25538: Default to --login|-i if no command passed -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 10 13:48:06 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Jun 2020 11:48:06 +0000 Subject: [Koha-bugs] [Bug 25707] Mappings update in bug 11529 causes data loss In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25707 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org Depends on| |11529 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11529 [Bug 11529] Add subtitle, medium and part fields to biblio table -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 10 13:48:06 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Jun 2020 11:48:06 +0000 Subject: [Koha-bugs] [Bug 11529] Add subtitle, medium and part fields to biblio table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11529 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |25707 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25707 [Bug 25707] Mappings update in bug 11529 causes data loss -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 10 13:49:40 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Jun 2020 11:49:40 +0000 Subject: [Koha-bugs] [Bug 25538] www/search_utf8.t is failing randomly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25538 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #105675|0 |1 is obsolete| | --- Comment #10 from Martin Renvoize --- Created attachment 105686 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105686&action=edit Bug 25538: Don't run search_utf8.t if KOHA_*_URL empty Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 10 13:49:46 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Jun 2020 11:49:46 +0000 Subject: [Koha-bugs] [Bug 25538] www/search_utf8.t is failing randomly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25538 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #105685|0 |1 is obsolete| | --- Comment #12 from Martin Renvoize --- Created attachment 105688 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105688&action=edit Bug 25538: Default to --login|-i if no command passed Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 10 13:49:43 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Jun 2020 11:49:43 +0000 Subject: [Koha-bugs] [Bug 25538] www/search_utf8.t is failing randomly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25538 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #105676|0 |1 is obsolete| | --- Comment #11 from Martin Renvoize --- Created attachment 105687 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105687&action=edit Bug 25538: Use sudo -i in koha-shell See man sudo, -i parameter. Should we expect regressions? Test plan: 0. Use D11 or U18. Don't apply this patch 1. $ echo $KOHA_INTRANET_URL $ sudo koha-shell kohadev $ echo $KOHA_INTRANET_URL 2. Apply this patch $ cp debian/scripts/koha-shell /usr/sbin/koha-shell 3. Repeat 1. Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 10 13:50:54 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Jun 2020 11:50:54 +0000 Subject: [Koha-bugs] [Bug 25538] www/search_utf8.t is failing randomly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25538 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com Status|Needs Signoff |Signed Off --- Comment #13 from Martin Renvoize --- Looks good to me and works as expected when running in koha-testing-docker interactively. Signing off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 10 13:57:38 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Jun 2020 11:57:38 +0000 Subject: [Koha-bugs] [Bug 25707] Mappings update in bug 11529 causes data loss In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25707 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrew at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 10 14:02:49 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Jun 2020 12:02:49 +0000 Subject: [Koha-bugs] [Bug 25687] Switch Y/N in EDI accounts table for Yes and No for better translatability In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25687 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 10 14:02:53 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Jun 2020 12:02:53 +0000 Subject: [Koha-bugs] [Bug 25687] Switch Y/N in EDI accounts table for Yes and No for better translatability In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25687 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #105670|0 |1 is obsolete| | --- Comment #2 from Kyle M Hall --- Created attachment 105689 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105689&action=edit Bug 25687: Switch Y/N in EDI accounts table for Yes and No for better translatability This patch changes the list of EDI accounts shown in EDI administration so that columns which previously used "Y" or "N" now show "Yes" or "No." To test, apply the patch and go to Administration -> EDI accounts. If necessary, add an EDI account. In the table of information about the EDI account, the columns with information about quotes, orders, invoices, responses, and auto-ordering should show "Yes" or "No" based on the account's settings. Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 10 14:07:29 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Jun 2020 12:07:29 +0000 Subject: [Koha-bugs] [Bug 25699] Edition information to Holds to pull report In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25699 Andrew Nugged changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |stalkernoid at gmail.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 10 14:31:09 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Jun 2020 12:31:09 +0000 Subject: [Koha-bugs] [Bug 25683] update_patron_categories.pl should recognize no fine history = 0 outstanding fines In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25683 --- Comment #12 from Nick Clemens --- Created attachment 105690 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105690&action=edit Bug 25683: Fix grouping of results DBIX doesn't seem to work as I expected - if trying to group by we can only get the columns we grouped by, otherwise the queries are much more complicated and come out wrong This patch removes the 'amountoutstanding' from the query. Note that we do return patron object, however, to access all the columns we must discard_changes (or refetch) Also fixes a typo 'verbosse' To test: 1 - charge a $1 fine to a patron 2 - pay off the fine 3 - perl misc/cronjobs/update_patrons_category.pl -f J -t J -fu=5 -v 4 - Note the patron is returned twice 5 - export DBIC_TRACE=1 6 - repeat 3 - view the SQL query and see how odd it is 7 - Apply this patch 8 - repeat 3 - simpler query 9 - patron returned only once -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 10 14:37:02 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Jun 2020 12:37:02 +0000 Subject: [Koha-bugs] [Bug 25699] Edition information to Holds to pull report In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25699 Peter Vashchuk changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 10 14:37:06 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Jun 2020 12:37:06 +0000 Subject: [Koha-bugs] [Bug 25699] Edition information to Holds to pull report In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25699 --- Comment #1 from Peter Vashchuk --- Created attachment 105691 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105691&action=edit Bug 25699: Add edition information to "Holds to pull" report Added a feature that displays edition information of the book together with title in "Holds to pull" report. Edition information is fetched from "biblioitem" table as "editionstatement" and transferred to template. Those changes don't have performance impact because all tables including "biblioitem" were already used and joined in this request. Mentored-by: Andrew Nugged -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 10 14:39:15 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Jun 2020 12:39:15 +0000 Subject: [Koha-bugs] [Bug 24631] Plugin metadata should be outside the main class In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24631 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_20_11_target -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 10 15:12:47 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Jun 2020 13:12:47 +0000 Subject: [Koha-bugs] [Bug 22522] API authentication breaks with updated Mojolicious version In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22522 --- Comment #73 from Tomás Cohen Arazi --- Created attachment 105692 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105692&action=edit [19.11.x] Bug 22522: Adjust tests to previous changes Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 10 15:25:31 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Jun 2020 13:25:31 +0000 Subject: [Koha-bugs] [Bug 22522] API authentication breaks with updated Mojolicious version In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22522 --- Comment #74 from Jonathan Druart --- (In reply to Jonathan Druart from comment #72) > 19.11: There is something wrong in the paths, and so plack does not start > correctly. > I have cherry-picked a07c5c153aaecc5cc8b0d1de5c53f184da5971b9 > Bug 25279: Add general query parameters to the /cities route Forget about this. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 10 15:26:13 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Jun 2020 13:26:13 +0000 Subject: [Koha-bugs] [Bug 22522] API authentication breaks with updated Mojolicious version In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22522 --- Comment #75 from Jonathan Druart --- (In reply to Tomás Cohen Arazi from comment #73) > Created attachment 105692 [details] [review] > [19.11.x] Bug 22522: Adjust tests to previous changes > > Signed-off-by: Tomas Cohen Arazi Aleisha, this one is read for you :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 10 15:54:02 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Jun 2020 13:54:02 +0000 Subject: [Koha-bugs] [Bug 25134] Return claims column should not be shown if ClaimReturnedLostValue is not set In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25134 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrew at bywatersolutions.com --- Comment #3 from Andrew Fuerste-Henry --- Katrin, you also filed bug 25583, about how the Claims tab doesn't show if ClaimReturnedLostValue isn't set. If we make the return claims column also not show, does that resolve your issue in 25583? If both the column and the tab hid themselves when the syspref isn't set, then one wouldn't be able to generate a claim one was then unable to manage. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jun 10 15:54:18 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Jun 2020 13:54:18 +0000 Subject: [Koha-bugs] [Bug 24031] Add plugin hook after_hold_create In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24031 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 10 15:54:21 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Jun 2020 13:54:21 +0000 Subject: [Koha-bugs] [Bug 24031] Add plugin hook after_hold_create In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24031 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #98788|0 |1 is obsolete| | Attachment #98789|0 |1 is obsolete| | Attachment #105256|0 |1 is obsolete| | Attachment #105257|0 |1 is obsolete| | --- Comment #11 from Kyle M Hall --- Created attachment 105693 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105693&action=edit Bug 24031: Add plugin hook after_hold_create It is called after a hold has been placed Test plan: 1. Write a plugin that implements only after_hold_create (see `perldoc Koha::Plugins` for implementation details). Install it and enable it 2. Place a hold and verify that your plugin method has been called with the right parameters Signed-off-by: Kyle M Hall Signed-off-by: Pasi Kallinen Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 10 15:55:28 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Jun 2020 13:55:28 +0000 Subject: [Koha-bugs] [Bug 24031] Add plugin hook after_hold_create In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24031 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #105693|0 |1 is obsolete| | --- Comment #12 from Kyle M Hall --- Created attachment 105694 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105694&action=edit Bug 24031: Add plugin hook after_hold_create It is called after a hold has been placed Test plan: 1. Write a plugin that implements only after_hold_create (see `perldoc Koha::Plugins` for implementation details). Install it and enable it 2. Place a hold and verify that your plugin method has been called with the right parameters Signed-off-by: Kyle M Hall Signed-off-by: Pasi Kallinen Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 10 15:55:37 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Jun 2020 13:55:37 +0000 Subject: [Koha-bugs] [Bug 24031] Add plugin hook after_hold_create In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24031 --- Comment #13 from Kyle M Hall --- Created attachment 105695 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105695&action=edit Bug 24031: Fix warnings Signed-off-by: Kyle M Hall Signed-off-by: Pasi Kallinen Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 10 15:55:40 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Jun 2020 13:55:40 +0000 Subject: [Koha-bugs] [Bug 24031] Add plugin hook after_hold_create In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24031 --- Comment #14 from Kyle M Hall --- Created attachment 105696 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105696&action=edit Bug 24031: Remove check for syspref UseKohaPlugins UseKohaPlugins has been removed by bug 20415 Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 10 15:55:43 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Jun 2020 13:55:43 +0000 Subject: [Koha-bugs] [Bug 24031] Add plugin hook after_hold_create In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24031 --- Comment #15 from Kyle M Hall --- Created attachment 105697 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105697&action=edit Bug 24031: Add safety checks in Koha::Plugins::call - Check that the plugin has the method before calling it - Call the method in an eval block to prevent fatal errors Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 10 17:33:18 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Jun 2020 15:33:18 +0000 Subject: [Koha-bugs] [Bug 25538] www/search_utf8.t is failing randomly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25538 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |tomascohen at gmail.com |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 10 17:46:32 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Jun 2020 15:46:32 +0000 Subject: [Koha-bugs] [Bug 25538] www/search_utf8.t is failing randomly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25538 --- Comment #14 from Tomás Cohen Arazi --- I tried it on an Ubuntu 18.04 KTD (19.11-bionic) and it doesn't seem to fix the issue, and it also feels like it is choosing a different shell: root at 744612f9fc98:kohadevbox$ export KOHA_INTRANET_URL=hola root at 744612f9fc98:kohadevbox$ echo $KOHA_INTRANET_URL hola root at 744612f9fc98:kohadevbox$ koha/debian/scripts/koha-shell kohadev $ echo $KOHA_INTRANET_URL $ Will try on different images. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 10 17:47:20 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Jun 2020 15:47:20 +0000 Subject: [Koha-bugs] [Bug 25708] New: [OMNIBUS] Use allow/disallow terminology in code Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25708 Bug ID: 25708 Summary: [OMNIBUS] Use allow/disallow terminology in code Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs at lists.koha-community.org Reporter: nick at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org Allow/disallow terminology is preferable to whitelist/blacklist https://www.ncsc.gov.uk/blog-post/terminology-its-not-black-and-white. https://www.clockwork.com/news/creating-inclusive-naming-conventions-in-technology/ -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 10 17:58:11 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Jun 2020 15:58:11 +0000 Subject: [Koha-bugs] [Bug 25709] New: Rename systempreference to NotesDenylist Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25709 Bug ID: 25709 Summary: Rename systempreference to NotesDenylist Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs at lists.koha-community.org Reporter: nick at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 10 17:58:15 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Jun 2020 15:58:15 +0000 Subject: [Koha-bugs] [Bug 25526] Using Write Off Selected will not allow for a different amount to be written off In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25526 koha-US bug tracker changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bugzilla at koha-us.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 10 17:58:35 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Jun 2020 15:58:35 +0000 Subject: [Koha-bugs] [Bug 25709] Rename systempreference to NotesDenylist In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25709 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |25708 Assignee|koha-bugs at lists.koha-commun |nick at bywatersolutions.com |ity.org | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25708 [Bug 25708] [OMNIBUS] Use allow/disallow terminology in code -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 10 17:58:35 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Jun 2020 15:58:35 +0000 Subject: [Koha-bugs] [Bug 25708] [OMNIBUS] Use allow/disallow terminology in code In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25708 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |25709 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25709 [Bug 25709] Rename systempreference to NotesDenylist -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 10 17:59:34 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Jun 2020 15:59:34 +0000 Subject: [Koha-bugs] [Bug 22807] Accessibility: Add 'Skip to Main Content' link In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22807 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #105678|0 |1 is obsolete| | --- Comment #9 from Martin Renvoize --- Created attachment 105698 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105698&action=edit Bug 22807: Add 'Skip to content' option This patch adds a 'Skip to content' link to the header bar which will only appear upon the first use of 'tab' to navigate after any fresh page load in the OPAC. Test plan 1/ Load any page in the OPAC 2/ Hit the `tab` key 3/ Note the new 'Skip to main content' link appears at the top left of the screen. 4/ Hit `Enter` or Click the button 5/ Note the page scrolls to the area of the page that has the first block containing a .maincontent class. 6/ Note that the next available focusable element after the first .maincontent block has been given focus. 7/ Note that the link has been hidden -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 10 17:59:37 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Jun 2020 15:59:37 +0000 Subject: [Koha-bugs] [Bug 22807] Accessibility: Add 'Skip to Main Content' link In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22807 --- Comment #10 from Martin Renvoize --- Created attachment 105699 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105699&action=edit Bug 22807: Ensure only one maincontent on searcresults Prior to this patch, if you entered a search that returned zero results, you would end up with two 'maincontent' classes on the page -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 10 17:59:40 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Jun 2020 15:59:40 +0000 Subject: [Koha-bugs] [Bug 22807] Accessibility: Add 'Skip to Main Content' link In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22807 --- Comment #11 from Martin Renvoize --- Created attachment 105700 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105700&action=edit Bug 22807: Ensure .maincontent appears on all pages -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 10 17:59:46 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Jun 2020 15:59:46 +0000 Subject: [Koha-bugs] [Bug 17140] Incorrect rounding in total fines calculations, part 2 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17140 koha-US bug tracker changed: What |Removed |Added ---------------------------------------------------------------------------- CC|bugzilla at koha-us.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 10 18:03:51 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Jun 2020 16:03:51 +0000 Subject: [Koha-bugs] [Bug 25709] Rename systempreference to NotesDenylist In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25709 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 10 18:03:54 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Jun 2020 16:03:54 +0000 Subject: [Koha-bugs] [Bug 25709] Rename systempreference to NotesDenylist In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25709 --- Comment #1 from Nick Clemens --- Created attachment 105701 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105701&action=edit Bug 25709: Rename systemprefrence to NotesDenylist -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 10 18:06:18 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Jun 2020 16:06:18 +0000 Subject: [Koha-bugs] [Bug 25709] Rename systempreference to NotesDenylist In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25709 --- Comment #2 from Nick Clemens --- To test: 1 - Apply patch and updatedatabase 2 - git grep NotesBlacklist 3 - Note all remaining occurrences are translations 4 - Add a field (e.g. '520' ) to the NotesDenylist systempreference 5 - View a record with a 520 field on the opac 6 - Confirm the field does not show in the 'Title notes' tab -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 10 18:08:09 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Jun 2020 16:08:09 +0000 Subject: [Koha-bugs] [Bug 25698] Curbside Pickup In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25698 koha-US bug tracker changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bugzilla at koha-us.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 10 18:09:02 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Jun 2020 16:09:02 +0000 Subject: [Koha-bugs] [Bug 25698] Curbside Pickup In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25698 George Williams (NEKLS) changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |george at nekls.org --- Comment #2 from George Williams (NEKLS) --- Good idea. Especially with the current health emergency. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jun 10 18:10:42 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Jun 2020 16:10:42 +0000 Subject: [Koha-bugs] [Bug 25698] Curbside Pickup In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25698 Daniel Gaghan changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |daniel.gaghan at pueblolibrary | |.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 10 18:17:05 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Jun 2020 16:17:05 +0000 Subject: [Koha-bugs] [Bug 20948] Item-level hold info displayed regardless its priority (detail.pl) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20948 koha-US bug tracker changed: What |Removed |Added ---------------------------------------------------------------------------- CC|bugzilla at koha-us.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 10 18:17:14 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Jun 2020 16:17:14 +0000 Subject: [Koha-bugs] [Bug 20391] Koha creates new authorities for 100 & 700 tags bringing in the relator term into the new authority In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20391 koha-US bug tracker changed: What |Removed |Added ---------------------------------------------------------------------------- CC|bugzilla at koha-us.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 10 18:17:22 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Jun 2020 16:17:22 +0000 Subject: [Koha-bugs] [Bug 24371] OPAC 'Showing only available items/Show all items' is double encoded In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24371 koha-US bug tracker changed: What |Removed |Added ---------------------------------------------------------------------------- CC|bugzilla at koha-us.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 10 18:17:51 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Jun 2020 16:17:51 +0000 Subject: [Koha-bugs] [Bug 23129] Items holdingbranch should be set to the originating library when generating a transfer In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23129 koha-US bug tracker changed: What |Removed |Added ---------------------------------------------------------------------------- CC|bugzilla at koha-us.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 10 18:17:57 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Jun 2020 16:17:57 +0000 Subject: [Koha-bugs] [Bug 23039] Hold found modal on checkin screen ( circulation.pl ) obscures Check in message info In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23039 koha-US bug tracker changed: What |Removed |Added ---------------------------------------------------------------------------- CC|bugzilla at koha-us.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 10 18:24:44 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Jun 2020 16:24:44 +0000 Subject: [Koha-bugs] [Bug 8838] Digest option for HOLD notice In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8838 Lisette Scheer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lisetteslatah at gmail.com --- Comment #9 from Lisette Scheer --- This would be great to have as an option. We often get patrons who are annoyed they are getting a ton of e-mails or texts that they have holds in. Would it be possible to send a digest of everything in a set period? We send out hold notices every 15 minutes so it would be nice if we could send out 1 digest every 15 minutes or something? We'd still like patrons to get notices quickly we just don't want them getting spammed. Lisette -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 10 18:25:44 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Jun 2020 16:25:44 +0000 Subject: [Koha-bugs] [Bug 24881] Circulation.t still fails if tests are ran slowly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24881 --- Comment #19 from Victor Grousset/tuxayo --- On the CI of branch 19.05 I've had 3 failures on this test (can't replicate locally) koha_1 | # Failed test 'Hourly rental charge calculated correctly with finesCalendar = noFinesWhenClosed and closed Wednesdays (168h - 24h * 0.25u)' koha_1 | # at t/db_dependent/Circulation.t line 3245. koha_1 | # got: '30' koha_1 | # expected: '36' koha_1 | # Looks like you failed 1 test of 20. koha_1 | koha_1 | # Failed test 'Incremented fee tests' koha_1 | # at t/db_dependent/Circulation.t line 3270. https://jenkins.koha-community.org/view/19.05/job/Koha_19.05_D8/234/consoleText https://jenkins.koha-community.org/view/19.05/job/Koha_19.05_D9/228/consoleText https://jenkins.koha-community.org/view/19.05/job/Koha_19.05_U18/229/consoleText Does this look related to this bug? It seems to not affect 19.11, 20.05 and master after looking at all the test failure since almost 3 weeks in these branches. Which is why it might be related to this ticket. As 19.05 seems to be a bit different in regard to was happened in this ticket. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 10 18:28:31 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Jun 2020 16:28:31 +0000 Subject: [Koha-bugs] [Bug 24881] Circulation.t still fails if tests are ran slowly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24881 --- Comment #20 from Victor Grousset/tuxayo --- Locally I can have the following two possible errors. (confirmed only on 19.05.x) Patch from comment 1 (which in 19.05) doesn't seem to have an impact when kept or reverted. t/db_dependent/Circulation.t .. 29/46 # Failed test 'ISSUED_TO_ANOTHER question flag should be set if AutoReturnCheckedOutItems is disabled and item is checked out to another' # at t/db_dependent/Circulation.t line 1974. # got: undef # expected: '1' # Looks like you planned 2 tests but ran 1. # Looks like you failed 1 test of 1 run. t/db_dependent/Circulation.t .. 30/46 # Failed test 'CanBookBeIssued + AutoReturnCheckedOutItems' # at t/db_dependent/Circulation.t line 1981. Can't call method "borrowernumber" on an undefined value at t/db_dependent/Circulation.t line 1978. # Looks like your test exited with 255 just after 30. ##### And also ##### t/db_dependent/Circulation.t .. 28/46 # Failed test 'AddReturn must have debarred the patron' # at t/db_dependent/Circulation.t line 86. # got: '' # expected: '1' # AddReturn returned message $VAR1 = { # 'WasReturned' => 1 # }; # Failed test 'Test at line 1924' # at t/db_dependent/Circulation.t line 90. # got: '0' # expected: '1' # Failed test 'Test at line 1924' # at t/db_dependent/Circulation.t line 93. # got: undef # expected: '2020-06-22' # Looks like you failed 3 tests of 21. t/db_dependent/Circulation.t .. 29/46 # Failed test 'AddReturn + suspension_chargeperiod' # at t/db_dependent/Circulation.t line 1933. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 10 18:34:26 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Jun 2020 16:34:26 +0000 Subject: [Koha-bugs] [Bug 8838] Digest option for HOLD notice In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8838 rkuiper at roundrocktexas.gov changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |rkuiper at roundrocktexas.gov -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 10 18:36:54 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Jun 2020 16:36:54 +0000 Subject: [Koha-bugs] [Bug 8838] Digest option for HOLD notice In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8838 --- Comment #10 from rkuiper at roundrocktexas.gov --- This would be a great enhancement. We get comments on the number of emails and text message the patrons receive. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 10 18:40:11 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Jun 2020 16:40:11 +0000 Subject: [Koha-bugs] [Bug 25709] Rename systempreference to NotesDenylist In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25709 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 10 18:40:14 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Jun 2020 16:40:14 +0000 Subject: [Koha-bugs] [Bug 25709] Rename systempreference to NotesDenylist In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25709 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #105701|0 |1 is obsolete| | --- Comment #3 from Owen Leonard --- Created attachment 105702 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105702&action=edit Bug 25709: Rename systemprefrence to NotesDenylist Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 10 19:18:28 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Jun 2020 17:18:28 +0000 Subject: [Koha-bugs] [Bug 25692] update MARC::Transform in debian.koha-community.org In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25692 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff --- Comment #2 from Mason James --- (In reply to Jonathan Druart from comment #1) > Mason, could you have a look at this? hi folks, this is done... $ apt-cache policy libmarc-transform-perl libmarc-transform-perl: Installed: 0.003008-1~koha1 Candidate: 0.003008-1~koha1 Version table: *** 0.003008-1~koha1 500 500 http://debian.koha-community.org/koha stable/main amd64 Packages 100 /var/lib/dpkg/status 0.003006-1 500 500 http://deb.debian.org/debian stretch/main amd64 Packages -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jun 10 19:22:33 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Jun 2020 17:22:33 +0000 Subject: [Koha-bugs] [Bug 25692] update MARC::Transform in debian.koha-community.org In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25692 stephane.delaune at biblibre.com changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #3 from stephane.delaune at biblibre.com --- I see that it is the correct version on http://debian.koha-community.org/koha/dists/20.05/main/binary-amd64/Packages, so it's ok for me, thank you Mason -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jun 10 19:24:29 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Jun 2020 17:24:29 +0000 Subject: [Koha-bugs] [Bug 11175] Show the parent record's component parts in the detailed views In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175 --- Comment #61 from Joonas Kylmälä --- Created attachment 105703 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105703&action=edit Bug 11175: (follow-up) Don't return explicitly undef This would create in list context an list of one element that is undef, which we don't want, we want empty list if there are no components. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 10 19:26:03 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Jun 2020 17:26:03 +0000 Subject: [Koha-bugs] [Bug 25683] update_patron_categories.pl should recognize no fine history = 0 outstanding fines In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25683 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 10 19:26:06 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Jun 2020 17:26:06 +0000 Subject: [Koha-bugs] [Bug 25683] update_patron_categories.pl should recognize no fine history = 0 outstanding fines In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25683 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #105662|0 |1 is obsolete| | --- Comment #13 from David Nind --- Created attachment 105704 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105704&action=edit Bug 25683: [alternate] Patron with no accountlines should have 0 outstanding (not NULL) Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 10 19:26:10 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Jun 2020 17:26:10 +0000 Subject: [Koha-bugs] [Bug 25683] update_patron_categories.pl should recognize no fine history = 0 outstanding fines In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25683 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #105690|0 |1 is obsolete| | --- Comment #14 from David Nind --- Created attachment 105705 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105705&action=edit Bug 25683: Fix grouping of results DBIX doesn't seem to work as I expected - if trying to group by we can only get the columns we grouped by, otherwise the queries are much more complicated and come out wrong This patch removes the 'amountoutstanding' from the query. Note that we do return patron object, however, to access all the columns we must discard_changes (or refetch) Also fixes a typo 'verbosse' To test: 1 - charge a $1 fine to a patron 2 - pay off the fine 3 - perl misc/cronjobs/update_patrons_category.pl -f J -t J -fu=5 -v 4 - Note the patron is returned twice 5 - export DBIC_TRACE=1 6 - repeat 3 - view the SQL query and see how odd it is 7 - Apply this patch 8 - repeat 3 - simpler query 9 - patron returned only once Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 10 19:26:45 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Jun 2020 17:26:45 +0000 Subject: [Koha-bugs] [Bug 11175] Show the parent record's component parts in the detailed views In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175 Joonas Kylmälä changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #105703|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 10 19:27:13 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Jun 2020 17:27:13 +0000 Subject: [Koha-bugs] [Bug 11175] Show the parent record's component parts in the detailed views In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175 --- Comment #62 from Joonas Kylmälä --- Created attachment 105706 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105706&action=edit Bug 11175: (follow-up) Return empty array if no components -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 10 19:27:33 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Jun 2020 17:27:33 +0000 Subject: [Koha-bugs] [Bug 11175] Show the parent record's component parts in the detailed views In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175 --- Comment #63 from Joonas Kylmälä --- Created attachment 105707 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105707&action=edit Bug 11175: (follow-up) Add tests -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 10 19:31:35 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Jun 2020 17:31:35 +0000 Subject: [Koha-bugs] [Bug 11175] Show the parent record's component parts in the detailed views In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175 Joonas Kylmälä changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff --- Comment #64 from Joonas Kylmälä --- I added the missing tests and addressed the undef problem. In my kohadevbox setup however the test works only on the first run after running "reset_all". For some reason the Koha::Biblio->find accessor stops working, it could be something related to my setup, or there might be a bug in the test? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 10 19:34:14 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Jun 2020 17:34:14 +0000 Subject: [Koha-bugs] [Bug 11175] Show the parent record's component parts in the detailed views In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175 Joonas Kylmälä changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |In Discussion --- Comment #65 from Joonas Kylmälä --- I will do some more testing with the unit test issue to make sure its not a bug in the test code, so changing the status to "In discussion" until that is resolved. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 10 19:39:14 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Jun 2020 17:39:14 +0000 Subject: [Koha-bugs] [Bug 8838] Digest option for HOLD notice In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8838 --- Comment #11 from Christopher Brannon --- (In reply to Lisette Scheer from comment #9) > This would be great to have as an option. We often get patrons who are > annoyed they are getting a ton of e-mails or texts that they have holds in. > > Would it be possible to send a digest of everything in a set period? We send > out hold notices every 15 minutes so it would be nice if we could send out 1 > digest every 15 minutes or something? We'd still like patrons to get notices > quickly we just don't want them getting spammed. > > Lisette So, in theory, the regular hold notices would go out as frequent as it is set in it's own cron job, and then the digest would go out as frequent as it is set in a separate cron job. I would go for that. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 10 20:49:28 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Jun 2020 18:49:28 +0000 Subject: [Koha-bugs] [Bug 22807] Accessibility: Add 'Skip to Main Content' link In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22807 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 10 20:49:31 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Jun 2020 18:49:31 +0000 Subject: [Koha-bugs] [Bug 22807] Accessibility: Add 'Skip to Main Content' link In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22807 --- Comment #12 from Owen Leonard --- Created attachment 105708 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105708&action=edit Bug 22807: (follow-up) Add .maincontent class to libraries page This patch adds a missing "maincontent" class to the "all libraries" view. Previously it was only present on the single library view. To test, apply the patch and go to the "Libraries" page in the OPAC. - Hit the "tab" key to highlight the "Skip to main content" link. - Hit "Enter." - The page should scroll to the top of the list of libraries. - Open one of the library detail pages and confirm that the "Skip to main content" link works on that page too. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 10 20:55:47 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Jun 2020 18:55:47 +0000 Subject: [Koha-bugs] [Bug 22807] Accessibility: Add 'Skip to Main Content' link In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22807 --- Comment #13 from Owen Leonard --- Created attachment 105709 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105709&action=edit Bug 22807: (follow-up) Update style of skip button This patch updates the markup and style of the skip button, adapting (i.e. stealing) the style of the skip link at https://webaim.org. To test, apply the patch and rebuild the OPAC CSS: https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client Go to any page in the OPAC and hit the tab key. The "Skip to main content" link should appear. Tabbing away from it should cause the link to hide. Hitting the ENTER key when the link is highlighted should cause the page to scroll to the main content. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 10 21:53:30 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Jun 2020 19:53:30 +0000 Subject: [Koha-bugs] [Bug 16248] ModZebra doesn't update zebraqueue if ES is enabled In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16248 didier changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |25710 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25710 [Bug 25710] On ElasticSearch only system zebraqueue table is never purged -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 10 21:53:30 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Jun 2020 19:53:30 +0000 Subject: [Koha-bugs] [Bug 25710] New: On ElasticSearch only system zebraqueue table is never purged Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25710 Bug ID: 25710 Summary: On ElasticSearch only system zebraqueue table is never purged Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Searching Assignee: koha-bugs at lists.koha-community.org Reporter: didier.gautheron at biblibre.com QA Contact: testopia at bugs.koha-community.org Depends on: 21820, 16248 Even if there's no zebra server zebraqueue table is populated (with done == 0). misc/cronjobs/cleanup_database.pl is only deleting zebraqueue table with done == 1 But without a zebra indexer daemon nothing is setting zebraqueue.done to 1. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16248 [Bug 16248] ModZebra doesn't update zebraqueue if ES is enabled https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21820 [Bug 21820] Zebraqueue should not be added to -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 10 21:53:30 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Jun 2020 19:53:30 +0000 Subject: [Koha-bugs] [Bug 21820] Zebraqueue should not be added to In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21820 didier changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |25710 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25710 [Bug 25710] On ElasticSearch only system zebraqueue table is never purged -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Jun 10 23:54:31 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Jun 2020 21:54:31 +0000 Subject: [Koha-bugs] [Bug 21978] Add middle name field In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21978 --- Comment #1 from Christopher Brannon --- I cannot stress enough the importance of this field. I'm not sure why there is a hold back on this. I RARELY see a database that doesn't include a field for a middle name. Yes, I can probably hack something together with attributes, but this is information that really needs to be in the patron record. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 11 00:18:37 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Jun 2020 22:18:37 +0000 Subject: [Koha-bugs] [Bug 22807] Accessibility: Add 'Skip to Main Content' link In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22807 Hayley Mapley changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #105698|0 |1 is obsolete| | --- Comment #14 from Hayley Mapley --- Created attachment 105710 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105710&action=edit Bug 22807: Add 'Skip to content' option This patch adds a 'Skip to content' link to the header bar which will only appear upon the first use of 'tab' to navigate after any fresh page load in the OPAC. Test plan 1/ Load any page in the OPAC 2/ Hit the `tab` key 3/ Note the new 'Skip to main content' link appears at the top left of the screen. 4/ Hit `Enter` or Click the button 5/ Note the page scrolls to the area of the page that has the first block containing a .maincontent class. 6/ Note that the next available focusable element after the first .maincontent block has been given focus. 7/ Note that the link has been hidden Signed-off-by: Hayley Mapley -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 11 00:19:08 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Jun 2020 22:19:08 +0000 Subject: [Koha-bugs] [Bug 22807] Accessibility: Add 'Skip to Main Content' link In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22807 Hayley Mapley changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #105699|0 |1 is obsolete| | --- Comment #15 from Hayley Mapley --- Created attachment 105711 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105711&action=edit Bug 22807: Ensure only one maincontent on searcresults Prior to this patch, if you entered a search that returned zero results, you would end up with two 'maincontent' classes on the page Signed-off-by: Hayley Mapley -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 11 00:19:37 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Jun 2020 22:19:37 +0000 Subject: [Koha-bugs] [Bug 22807] Accessibility: Add 'Skip to Main Content' link In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22807 Hayley Mapley changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #105700|0 |1 is obsolete| | --- Comment #16 from Hayley Mapley --- Created attachment 105712 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105712&action=edit Bug 22807: Ensure .maincontent appears on all pages Signed-off-by: Hayley Mapley -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 11 00:20:20 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Jun 2020 22:20:20 +0000 Subject: [Koha-bugs] [Bug 22807] Accessibility: Add 'Skip to Main Content' link In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22807 Hayley Mapley changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #105708|0 |1 is obsolete| | --- Comment #17 from Hayley Mapley --- Created attachment 105713 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105713&action=edit Bug 22807: (follow-up) Add .maincontent class to libraries page This patch adds a missing "maincontent" class to the "all libraries" view. Previously it was only present on the single library view. To test, apply the patch and go to the "Libraries" page in the OPAC. - Hit the "tab" key to highlight the "Skip to main content" link. - Hit "Enter." - The page should scroll to the top of the list of libraries. - Open one of the library detail pages and confirm that the "Skip to main content" link works on that page too. Signed-off-by: Hayley Mapley -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 11 00:21:02 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Jun 2020 22:21:02 +0000 Subject: [Koha-bugs] [Bug 22807] Accessibility: Add 'Skip to Main Content' link In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22807 Hayley Mapley changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 11 00:21:04 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Jun 2020 22:21:04 +0000 Subject: [Koha-bugs] [Bug 22807] Accessibility: Add 'Skip to Main Content' link In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22807 Hayley Mapley changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #105709|0 |1 is obsolete| | --- Comment #18 from Hayley Mapley --- Created attachment 105714 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105714&action=edit Bug 22807: (follow-up) Update style of skip button This patch updates the markup and style of the skip button, adapting (i.e. stealing) the style of the skip link at https://webaim.org. To test, apply the patch and rebuild the OPAC CSS: https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client Go to any page in the OPAC and hit the tab key. The "Skip to main content" link should appear. Tabbing away from it should cause the link to hide. Hitting the ENTER key when the link is highlighted should cause the page to scroll to the main content. Signed-off-by: Hayley Mapley -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 11 00:23:58 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Jun 2020 22:23:58 +0000 Subject: [Koha-bugs] [Bug 22807] Accessibility: Add 'Skip to Main Content' link In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22807 --- Comment #19 from Hayley Mapley --- Encountered this warning when running the QA tools: Argument "" isn't numeric in numeric gt (>) at /home/vagrant/kohaclone/koha-tmpl/opac-tmpl/bootstrap/en/includes/masthead.inc line 56. Everything passed though. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 11 00:24:27 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Jun 2020 22:24:27 +0000 Subject: [Koha-bugs] [Bug 22807] Accessibility: Add 'Skip to Main Content' link In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22807 --- Comment #20 from Hayley Mapley --- Have tested in all the pages of the OPAC that I could find and all seems good. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 11 00:54:32 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Jun 2020 22:54:32 +0000 Subject: [Koha-bugs] [Bug 25151] Accessibility: The 'Your folder' page does not contain a level-one header In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25151 Hayley Mapley changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hayleymapley at catalyst.net.n | |z --- Comment #1 from Hayley Mapley --- Hi Martin, Could you please clarify where I can find the 'Your folder' page? I thought maybe you meant Lists, but that page has correct headings. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 11 00:57:33 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Jun 2020 22:57:33 +0000 Subject: [Koha-bugs] [Bug 25151] Accessibility: The 'Your folder' page does not contain a level-one header In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25151 --- Comment #2 from Hayley Mapley --- Ah it's en-GB for the cart! Got it. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 11 01:04:53 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Jun 2020 23:04:53 +0000 Subject: [Koha-bugs] [Bug 19889] LocalHoldsPriority needs exclusions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19889 Agustín Moyano changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 11 01:04:57 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Jun 2020 23:04:57 +0000 Subject: [Koha-bugs] [Bug 19889] LocalHoldsPriority needs exclusions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19889 --- Comment #3 from Agustín Moyano --- Created attachment 105715 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105715&action=edit Bug 19889: Add exclude_from_local_holds_priority columns to item, deleteditems and categories tables Sponsored-by: Cooperative Information Network (CIN) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 11 01:05:01 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Jun 2020 23:05:01 +0000 Subject: [Koha-bugs] [Bug 19889] LocalHoldsPriority needs exclusions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19889 --- Comment #4 from Agustín Moyano --- Created attachment 105716 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105716&action=edit Bug 19889: set exclude_from_local_holds_priority columns as boolean in schema Sponsored-by: Cooperative Information Network (CIN) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 11 01:05:06 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Jun 2020 23:05:06 +0000 Subject: [Koha-bugs] [Bug 19889] LocalHoldsPriority needs exclusions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19889 --- Comment #5 from Agustín Moyano --- Created attachment 105717 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105717&action=edit Bug 19889: Add tests Sponsored-by: Cooperative Information Network (CIN) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 11 01:05:11 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Jun 2020 23:05:11 +0000 Subject: [Koha-bugs] [Bug 19889] LocalHoldsPriority needs exclusions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19889 --- Comment #6 from Agustín Moyano --- Created attachment 105718 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105718&action=edit Bug 19889: Make it possible to exclude items and categories from local holds priority This patch adds the ability to exclude patrons (by category) from local holds, and items, by editing the item itself or by batch item modification tool. To test: 1. apply patches 2. updatedatabase 3. Enable LocalHoldsPriority preference, and leave LocalHoldsPriorityPatronControl in pickup library, and LocalHoldsPriorityItemControl in holding library. 4. Search for a biblio with one item. 5. Place a hold with a patron (patron1) and set pickup location to a different library of the item's home library 6. Place another hold with another patron (patron2) and set pickup location to be the same as the item's home library 7. ./misc/cronjobs/holds/build_holds_queue.pl 8. Go to circulation -> holds queue 9. Search by the item's home library CHECK => only the hold for patron2 (with the pickup location the same as the item's home library) appears in the table 10. Go back to the biblio details page and click on "Items" tab CHECK => There is a new section in the item's details between "Statuses" and "History" called "Priority" 11. Set exclude to "Yes" and update 12. repeat steps 7 to 9 SUCCESS => only the hold for patron1 now appears, even the other hold had local hold priority 13. Repeat step 10 and 11 but this time set exclude to "No" 14. repeat steps 7 to 9 CHECK => the hold for patron2 is back 15. Edit patron2's category and set exclude from local holds priority to "Yes" 16. Repeat steps 7 to 9 SUCCESS => the hold for patron1 is back 17. Go to tools -> Batch item modification and in barcode list place several (existing) barcodes and press continue CHECK => There is a new section in the bottom called "Priority" 18. Set exclude to "Yes" and save SUCCESS => all items in the list now have exclude setted to "Yes" 19. Try to checkout the first item to a patron3 SUCCESS => Alert message appears saying that patron1 has a hold on that item 20. Click on Yes and then checkin that item SUCCESS => There is a modal window saying that a hold was found for patron1 21. prove t/db_dependent/HoldsQueue.t t/db_dependent/Holds/LocalHoldsPriority.t 22. Sign off Sponsored-by: Cooperative Information Network (CIN) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 11 01:10:13 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Jun 2020 23:10:13 +0000 Subject: [Koha-bugs] [Bug 25151] Accessibility: The 'Your folder' page does not contain a level-one header In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25151 Hayley Mapley changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|oleonard at myacpl.org |hayleymapley at catalyst.net.n | |z -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 11 01:52:49 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 10 Jun 2020 23:52:49 +0000 Subject: [Koha-bugs] [Bug 25151] Accessibility: The 'Your folder' page does not contain a level-one header In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25151 --- Comment #3 from Hayley Mapley --- Created attachment 105719 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105719&action=edit Bug 25151: Fixing semantic headings in opac-basket.tt Test plan: 1) Apply the patch 2) Add items to your cart/folder/basket 3) Open up the basket and check that the main heading is now an h1 4) Check that the page looks fine -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 11 02:05:11 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Jun 2020 00:05:11 +0000 Subject: [Koha-bugs] [Bug 25151] Accessibility: The 'Your folder' page does not contain a level-one header In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25151 Hayley Mapley changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 11 02:06:46 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Jun 2020 00:06:46 +0000 Subject: [Koha-bugs] [Bug 25707] Mappings update in bug 11529 causes data loss In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25707 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au --- Comment #2 from David Cook --- I wouldn't say it causes data loss because the data is still in the MARC record but it causes... incorrect MARC to DB mappings? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 11 02:10:13 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Jun 2020 00:10:13 +0000 Subject: [Koha-bugs] [Bug 25707] Mappings update in bug 11529 causes incorrect MARC to DB data flow In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25707 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Mappings update in bug |Mappings update in bug |11529 causes data loss |11529 causes incorrect MARC | |to DB data flow -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 11 02:15:20 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Jun 2020 00:15:20 +0000 Subject: [Koha-bugs] [Bug 20391] Koha creates new authorities for 100 & 700 tags bringing in the relator term into the new authority In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20391 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 11 02:15:53 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Jun 2020 00:15:53 +0000 Subject: [Koha-bugs] [Bug 24675] No update of the list of MARC21 subfields in C4/Heading/MARC21.pm, Generated authorities are missing subfields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24675 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 11 02:19:19 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Jun 2020 00:19:19 +0000 Subject: [Koha-bugs] [Bug 24988] autorenew_checkouts should default to yes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24988 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |24476 CC| |dcook at prosentient.com.au Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24476 [Bug 24476] Allow patrons to opt-out of auto-renewal -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 11 02:19:19 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Jun 2020 00:19:19 +0000 Subject: [Koha-bugs] [Bug 24476] Allow patrons to opt-out of auto-renewal In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24476 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |24988 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24988 [Bug 24988] autorenew_checkouts should default to yes -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 11 02:46:17 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Jun 2020 00:46:17 +0000 Subject: [Koha-bugs] [Bug 25155] Accessibility: The 'Login modal' contains semantically incorrect headings In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25155 Hayley Mapley changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard at myacpl.org |hayleymapley at catalyst.net.n | |z Status|NEW |ASSIGNED CC| |hayleymapley at catalyst.net.n | |z -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 11 03:17:47 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Jun 2020 01:17:47 +0000 Subject: [Koha-bugs] [Bug 25155] Accessibility: The 'Login modal' contains semantically incorrect headings In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25155 Hayley Mapley changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 11 03:18:07 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Jun 2020 01:18:07 +0000 Subject: [Koha-bugs] [Bug 25155] Accessibility: The 'Login modal' contains semantically incorrect headings In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25155 --- Comment #1 from Hayley Mapley --- Created attachment 105720 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105720&action=edit Bug 25155: Fixing semantic headings in opac-auth.tt Test plan: 1) Follow test plan from comment #1 2) Apply the patch 3) Reload the page, and note that is still displays fine 4) Check that the main heading is now an h1, and that the other headings on the page make sense -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 11 06:06:08 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Jun 2020 04:06:08 +0000 Subject: [Koha-bugs] [Bug 25711] New: Add ability to define expiredpickup charge for patron category and item type Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25711 Bug ID: 25711 Summary: Add ability to define expiredpickup charge for patron category and item type Change sponsored?: --- Product: Koha Version: 20.05 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs at lists.koha-community.org Reporter: minna.kivinen at hamk.fi QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com ExpireReservesMaxPickUpDelayCharge allows one charge to be applied to all holds that expire. It would be better to have ability to define this charge in ciculation rules. There can be different charges for different types of materials for different patron categories. Related to this bug report: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18195 Charge for expired holds per patron category -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jun 11 06:29:20 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Jun 2020 04:29:20 +0000 Subject: [Koha-bugs] [Bug 24189] Can't login to SIP2 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24189 --- Comment #6 from ciarebaha --- (In reply to Jonathan Druart from comment #5) > (In reply to ciarebaha from comment #4) > > (In reply to Katrin Fischer from comment #2) > > > Did you set up your SIP user with circulate permissions in Koha and the conf > > > file correctly? > > > (https://koha-community.org/manual/19.11/en/html/apis_protocols.html#sip2) > > > > Yes, since this SIP already running since September 2019 & working fine > > before this, all the login id,password,permission already set up in koha > > patron & SIPconfig.xml. > > So my guess is that the SIP server is not running, try to start it with: > % koha-sip --start $INSTANCE > With $INSTANCE the name of you Koha installation. > > Lowering severity. The Sip2 service already started but selfcheck cannot established connection with Koha server. It seems failed to login. We got status 940 instead of 941. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 11 06:35:13 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Jun 2020 04:35:13 +0000 Subject: [Koha-bugs] [Bug 19532] Recalls for Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_20_11_target -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 11 08:13:41 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Jun 2020 06:13:41 +0000 Subject: [Koha-bugs] [Bug 25711] Add ability to define expiredpickup charge for patron category and item type In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25711 Andrew Nugged changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nugged at gmail.com, | |slavashishkin at gmail.com, | |stalkernoid at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 11 08:50:35 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Jun 2020 06:50:35 +0000 Subject: [Koha-bugs] [Bug 22807] Accessibility: Add 'Skip to Main Content' link In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22807 --- Comment #21 from Martin Renvoize --- Thanks for the followup's Owen, that styling look so much nicer :), and thanks for catching a missing case for the maincontent class :) Thanks for the quick signoff Hayley, it's great to see work moving forward on accessibility.. I see you've been working through some of the other bugs I have already reported :).. I'm working through a rather extensive report at the moment so will be adding bugs and working through them slowly, but any help is greatly appreciated :) Go team Koha! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 11 08:58:30 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Jun 2020 06:58:30 +0000 Subject: [Koha-bugs] [Bug 25151] Accessibility: The 'Your folder' page does not contain a level-one header In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25151 --- Comment #4 from Martin Renvoize --- Thanks for jumping on this Hayley.. sorry it wasn't as clear as it should have been.. I'm working through a massive report and missed the translation in this case. Testing now for SO :). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 11 09:13:34 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Jun 2020 07:13:34 +0000 Subject: [Koha-bugs] [Bug 25151] Accessibility: The 'Your folder' page does not contain a level-one header In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25151 --- Comment #5 from Martin Renvoize --- Hmm.. well this certainly improves the situation for screen readers and is exactly what I asked for.. but it seems to highlight some slightly odd css rules.. though at the moment I'm struggling to track down which ones are causing it. The 'h2' seems to appear larger than the 'h1' on the page.. which feel semantically incorrect visually. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 11 09:37:04 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Jun 2020 07:37:04 +0000 Subject: [Koha-bugs] [Bug 8720] A big part of systempreferences.pl/.tt is useless In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8720 Emmi Takkinen changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |emmi.takkinen at outlook.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 11 10:06:13 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Jun 2020 08:06:13 +0000 Subject: [Koha-bugs] [Bug 25155] Accessibility: The 'Login modal' contains semantically incorrect headings In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25155 --- Comment #2 from Martin Renvoize --- Sorry.. this is another case of a somewhat misdescribed bug.. I actually think the text in the original report this came from is also incorrect. Anyway.. the patchset does resolve a related bug which I have not yet filed... the only missing piece here is that the modal title is still an H3.. for which I'll add a followup. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 11 10:33:02 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Jun 2020 08:33:02 +0000 Subject: [Koha-bugs] [Bug 25538] www/search_utf8.t is failing randomly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25538 --- Comment #15 from Jonathan Druart --- $KOHA_INTRANET_URL is not supposed to be the one coming from the shell you had before (does it?). It is defined in the .bashrc of the kohadev-koha $ grep KOHA_INTRANET_URL /var/lib/koha/kohadev/.bashrc export KOHA_INTRANET_URL=http://koha:8081 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 11 10:41:46 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Jun 2020 08:41:46 +0000 Subject: [Koha-bugs] [Bug 25538] www/search_utf8.t is failing randomly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25538 --- Comment #16 from Jonathan Druart --- I think the env vars must be kept if --preserve-env is passed. But in that case we should do the test in the bashrc (if vars exist, don't reset them with the default values). Also I guess the following lines should be removed (var must be defined in bashrc?) 51 "env " 52 . "KOHA_CONF=/etc/koha/sites/$instance/koha-conf.xml " 53 . "PERL5LIB=$perl5lib But we are going to far, the whole script needs its own bug report (if the above is correct). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 11 11:00:34 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Jun 2020 09:00:34 +0000 Subject: [Koha-bugs] [Bug 24881] Circulation.t still fails if tests are ran slowly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24881 --- Comment #21 from Jonathan Druart --- Created attachment 105721 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105721&action=edit Bug 24881: [19.05.x] Try to fix random failure from Circulation.t This is a follow-up of bug 22917. Signed-off-by: Joy Nelson (cherry picked from commit b0551cfd178565b5b30980096f53d4fffcfca454) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 11 11:01:12 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Jun 2020 09:01:12 +0000 Subject: [Koha-bugs] [Bug 24881] Circulation.t still fails if tests are ran slowly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24881 --- Comment #22 from Jonathan Druart --- (In reply to Jonathan Druart from comment #21) > Created attachment 105721 [details] [review] > Bug 24881: [19.05.x] Try to fix random failure from Circulation.t > > This is a follow-up of bug 22917. > > Signed-off-by: Joy Nelson > (cherry picked from commit b0551cfd178565b5b30980096f53d4fffcfca454) Victor, this is a rebased patch of the 19.11.x version. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 11 11:02:42 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Jun 2020 09:02:42 +0000 Subject: [Koha-bugs] [Bug 21978] Add middle name field In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21978 Sally changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sally.healey at cheshireshared | |services.gov.uk --- Comment #2 from Sally --- +1. I agree - this would be very useful for librarians. The current set up leads to lots of confusion. Most staff lean to adding as much information as possible, especially with names which are common: e.g. First name: John Last name: Smith Becomes: First name: John David Last name: Smith But the addition of the middle name into the first name field means that the patron match feature doesn't work in all scenarios, because Koha (understandably) thinks that John David is a very different name to John. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jun 11 11:15:52 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Jun 2020 09:15:52 +0000 Subject: [Koha-bugs] [Bug 11175] Show the parent record's component parts in the detailed views In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175 Andrew Nugged changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nugged at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 11 11:16:19 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Jun 2020 09:16:19 +0000 Subject: [Koha-bugs] [Bug 25155] Accessibility: The 'Login modal' contains semantically incorrect headings In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25155 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #105720|0 |1 is obsolete| | --- Comment #3 from Martin Renvoize --- Created attachment 105722 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105722&action=edit Bug 25155: Fixing semantic headings in opac-auth.tt Test plan: 1) Follow test plan from comment #1 2) Apply the patch 3) Reload the page, and note that is still displays fine 4) Check that the main heading is now an h1, and that the other headings on the page make sense Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 11 11:16:22 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Jun 2020 09:16:22 +0000 Subject: [Koha-bugs] [Bug 25155] Accessibility: The 'Login modal' contains semantically incorrect headings In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25155 --- Comment #4 from Martin Renvoize --- Created attachment 105723 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105723&action=edit Bug 25155: Fixing semantic headings login modal The login modal headings were semantically incorrect prior to this patch. Test plan: 1) Click the 'Log in to your account' option to expose the modal 2) Use a headings inspector and note we jump from H1 (Page Title) -> H3 (Modal Title) 3) Apply the patch and reload the page. 4) Click the 'Log in to your account' option to expose the modal 5) The modal should still appear well formed 6) Use a headings inspector and note we jump from H1 (Page Title) -> H2 (Modal Title) -> H3 (Shibboleth title if enabled) Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 11 11:16:25 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Jun 2020 09:16:25 +0000 Subject: [Koha-bugs] [Bug 25155] Accessibility: The 'Login modal' contains semantically incorrect headings In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25155 --- Comment #5 from Martin Renvoize --- Created attachment 105724 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105724&action=edit Bug 25155: (follow-up) Increase headings levels by 1 In the previous patch we reduced the headings levels by 2, but this was one level too many as we already have an H1 in the navbar and so all other heading sets should start at level 2 to semantically follow the title heading. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 11 11:21:42 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Jun 2020 09:21:42 +0000 Subject: [Koha-bugs] [Bug 25155] Accessibility: The 'Login modal' contains semantically incorrect headings In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25155 --- Comment #6 from Martin Renvoize --- I've signed off the first patch, but added two followups I'm afraid so we still need an overall signoff. I'm using the headingsMap extension for chrome to highlight heading orders and catch errors. According to the report, a page should only ever contain one H1 level heading, and as we use h1 in the navbar for the logo that means all sets of headings anywhere else on the page should start at level 2.. hence the final followup. Thanks again for working on this Hayley :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 11 11:21:53 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Jun 2020 09:21:53 +0000 Subject: [Koha-bugs] [Bug 25155] Accessibility: The 'Login modal' contains semantically incorrect headings In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25155 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bolshawh at parliament.uk -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 11 11:22:23 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Jun 2020 09:22:23 +0000 Subject: [Koha-bugs] [Bug 25151] Accessibility: The 'Your folder' page does not contain a level-one header In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25151 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bolshawh at parliament.uk, | |oleonard at myacpl.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 11 11:42:34 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Jun 2020 09:42:34 +0000 Subject: [Koha-bugs] [Bug 25710] On ElasticSearch only system zebraqueue table is never purged In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25710 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org Component|Searching |Searching - Elasticsearch QA Contact|testopia at bugs.koha-communit | |y.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 11 12:05:50 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Jun 2020 10:05:50 +0000 Subject: [Koha-bugs] [Bug 25704] With ICU chains on, searching by callnumbers does not produce accurate results In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25704 --- Comment #2 from Katrin Fischer --- Did you change the UseICU system preference? I remember something about different 'quoting' that this influences. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jun 11 12:16:27 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Jun 2020 10:16:27 +0000 Subject: [Koha-bugs] [Bug 25507] PDF order print for German 2-pages is broken In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25507 --- Comment #4 from Katrin Fischer --- Thank you, David! The "German" fixes are a bit hard to get tested! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 11 12:19:03 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Jun 2020 10:19:03 +0000 Subject: [Koha-bugs] [Bug 25151] Accessibility: The 'Your cart' page does not contain a level-one header In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25151 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Accessibility: The 'Your |Accessibility: The 'Your |folder' page does not |cart' page does not contain |contain a level-one header |a level-one header -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 11 12:22:04 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Jun 2020 10:22:04 +0000 Subject: [Koha-bugs] [Bug 24189] Can't login to SIP2 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24189 --- Comment #7 from Katrin Fischer --- As you said it worked before: can you check if the user in Koha is still there? Has the right permissions? Is not expired? Password and username correct as defined in your SIP configuration file? Branchcodes correct? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 11 12:24:22 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Jun 2020 10:24:22 +0000 Subject: [Koha-bugs] [Bug 24189] Can't login to SIP2 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24189 --- Comment #8 from Katrin Fischer --- We also have 18.11 installations with SIP and so far, the connections work alright. That's why I think this is more a support request, than a bug at this point. You might get more help and ideas bringing this up on the mailing list. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jun 11 12:30:35 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Jun 2020 10:30:35 +0000 Subject: [Koha-bugs] [Bug 21978] Add middle name field In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21978 --- Comment #3 from Katrin Fischer --- In German we don't have the same concept of a middle name than in the US I think. I've kind of thought that you'd end up using the initials field for the second name that seems common. Would you mind explaining how this usually works? We've had a request for the 'father's name' as used in Russian (we support some libraries located in Ukraine and Russia) and they have been quite happy with using one of the existing fields we relabelled (not sure if it was alias or initials) I think requirements are quite different between countries, I'd like to learn more about it. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 11 12:32:11 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Jun 2020 10:32:11 +0000 Subject: [Koha-bugs] [Bug 21820] Zebraqueue should not be added to when only Elasticsearch is used In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21820 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Zebraqueue should not be |Zebraqueue should not be |added to |added to when only | |Elasticsearch is used --- Comment #1 from Katrin Fischer --- So I think maybe a new preference or option? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 11 12:48:39 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Jun 2020 10:48:39 +0000 Subject: [Koha-bugs] [Bug 25627] Move OPAC problem reports from administration to tools In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25627 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 11 12:48:42 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Jun 2020 10:48:42 +0000 Subject: [Koha-bugs] [Bug 25627] Move OPAC problem reports from administration to tools In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25627 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #105549|0 |1 is obsolete| | --- Comment #4 from David Nind --- Created attachment 105725 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105725&action=edit Bug 25627: Move OPAC problem reports from administration to tools This patch moves the OPAC problem report management page from the Administration section to the Tools section. I think this makes sense because management of reports is an ongoing task, not a configuration. To test, apply the patch and enable the OPACReportProblem system preference. - Go to Administration. There should be no link to OPAC problem reports. - Open an administration page which shows the Administration menu in the left-hand sidebar, e.g. Libraries. There should be no link to OPAC problem reports in the menu. - Go to Tools. There should be a link to OPAC problem reports in the "Addional tools" section. - Open the OPAC problem reports page and confirm that it works correctly. - The breadcrumbs menu should show "Tools > OPAC problem reports." - Confirm that the link in the sidebar menu works correctly. - If necessary, submit an OPAC problem report via the OPAC so that there is a pending report. Go to the staff interface home page and check that the "OPAC problem reports pending" link works correctly. Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 11 12:59:31 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Jun 2020 10:59:31 +0000 Subject: [Koha-bugs] [Bug 25236] Accessibility: The 'Refine your search' box contains semantically incorrect headings In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25236 --- Comment #1 from Martin Renvoize --- Created attachment 105726 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105726&action=edit Bug 25236: Fix semantic heading for opac-facets.inc Prior to this patch, the opac-facets side navigation box contained semantically incorrect headings. Test plan 1/ Perform a search which yields some results in the OPAC 2/ Inspect the 'Refine your search' elements on the left side of the screen. Note that the headings are H1 (Koha page title) > H4 (Refine your search) > H5 (Headings within 'Refine your search' box) 3/ Apply this patch and follow https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client 4/ Reload the page (Flushing the cache to ensure the CSS change load) 5/ Re-inspect the 'Refine your search' elements and note the heading semantics are now H1 (Title of page) > H2 (Refine your search) > H3 (Headings within 'Refine your search') 6/ Note the appearance of the box is still reasonable 7/ Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 11 12:59:34 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Jun 2020 10:59:34 +0000 Subject: [Koha-bugs] [Bug 25236] Accessibility: The 'Refine your search' box contains semantically incorrect headings In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25236 --- Comment #2 from Martin Renvoize --- Created attachment 105727 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105727&action=edit Bug 25236: Fix semantic heading for opac-topissues.inc Prior to this patch, the opac-topissues side navigation box contained semantically incorrect headings. Test plan 0/ Enable 'OpacTopIssues' 1/ Navigate to the top issues page via the 'Most popular' link 2/ Inspect the 'Refine your search' elements on the left side of the screen. Note that the headings are H1 (Koha page title) > H4 (Refine your search) 3/ Apply this patch 4/ Reload the page 5/ Re-inspect the 'Refine your search' elements and note the heading semantics are now H1 (Title of page) > H2 (Refine your search) 6/ Note the appearance of the box is still reasonable 7/ Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 11 12:59:37 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Jun 2020 10:59:37 +0000 Subject: [Koha-bugs] [Bug 25236] Accessibility: The 'Refine your search' box contains semantically incorrect headings In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25236 --- Comment #3 from Martin Renvoize --- Created attachment 105728 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105728&action=edit Bug 25236: Fix semantic heading for opac-full-serial-issues.tt Prior to this patch, the opac-full-serial-issues side navigation box contained semantically incorrect headings. Test plan 1/ Search for a serial with many linked issues 2/ Navigate to the detailed view of that serial 3/ Click on the 'More details' link after all the listed issues 4/ Inspect the 'Refine your search' elements on the left side of the screen. Note that the headings are H1 (Koha page title) > H4 (Refine your search) 3/ Apply this patch 4/ Reload the page 5/ Re-inspect the 'Refine your search' elements and note the heading semantics are now H1 (Title of page) > H2 (Refine your search) 6/ Note the appearance of the box is improved and consistent with elsewhere 7/ Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 11 13:01:11 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Jun 2020 11:01:11 +0000 Subject: [Koha-bugs] [Bug 25236] Accessibility: The 'Refine your search' box contains semantically incorrect headings In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25236 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #105726|0 |1 is obsolete| | --- Comment #4 from Martin Renvoize --- Created attachment 105729 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105729&action=edit Bug 25236: Fix semantic heading for opac-facets.inc Prior to this patch, the opac-facets side navigation box contained semantically incorrect headings. Test plan 1/ Perform a search which yields some results in the OPAC 2/ Inspect the 'Refine your search' elements on the left side of the screen. Note that the headings are H1 (Koha page title) > H4 (Refine your search) > H5 (Headings within 'Refine your search' box) 3/ Apply this patch and follow https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client 4/ Reload the page (Flushing the cache to ensure the CSS change load) 5/ Re-inspect the 'Refine your search' elements and note the heading semantics are now H1 (Title of page) > H2 (Refine your search) > H3 (Headings within 'Refine your search') 6/ Note the appearance of the box is still reasonable 7/ Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 11 13:01:14 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Jun 2020 11:01:14 +0000 Subject: [Koha-bugs] [Bug 25236] Accessibility: The 'Refine your search' box contains semantically incorrect headings In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25236 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #105727|0 |1 is obsolete| | --- Comment #5 from Martin Renvoize --- Created attachment 105730 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105730&action=edit Bug 25236: Fix semantic heading for opac-topissues.inc Prior to this patch, the opac-topissues side navigation box contained semantically incorrect headings. Test plan 0/ Enable 'OpacTopIssues' 1/ Navigate to the top issues page via the 'Most popular' link 2/ Inspect the 'Refine your search' elements on the left side of the screen. Note that the headings are H1 (Koha page title) > H4 (Refine your search) 3/ Apply this patch 4/ Reload the page 5/ Re-inspect the 'Refine your search' elements and note the heading semantics are now H1 (Title of page) > H2 (Refine your search) 6/ Note the appearance of the box is still reasonable 7/ Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 11 13:01:17 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Jun 2020 11:01:17 +0000 Subject: [Koha-bugs] [Bug 25236] Accessibility: The 'Refine your search' box contains semantically incorrect headings In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25236 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #105728|0 |1 is obsolete| | --- Comment #6 from Martin Renvoize --- Created attachment 105731 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105731&action=edit Bug 25236: Fix semantic heading for opac-full-serial-issues.tt Prior to this patch, the opac-full-serial-issues side navigation box contained semantically incorrect headings. Test plan 1/ Search for a serial with many linked issues 2/ Navigate to the detailed view of that serial 3/ Click on the 'More details' link after all the listed issues 4/ Inspect the 'Refine your search' elements on the left side of the screen. Note that the headings are H1 (Koha page title) > H4 (Refine your search) 3/ Apply this patch 4/ Reload the page 5/ Re-inspect the 'Refine your search' elements and note the heading semantics are now H1 (Title of page) > H2 (Refine your search) 6/ Note the appearance of the box is improved and consistent with elsewhere 7/ Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 11 13:01:34 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Jun 2020 11:01:34 +0000 Subject: [Koha-bugs] [Bug 25236] Accessibility: The 'Refine your search' box contains semantically incorrect headings In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25236 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 11 13:01:40 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Jun 2020 11:01:40 +0000 Subject: [Koha-bugs] [Bug 25236] Accessibility: The 'Refine your search' box contains semantically incorrect headings In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25236 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard at myacpl.org |martin.renvoize at ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 11 13:01:50 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Jun 2020 11:01:50 +0000 Subject: [Koha-bugs] [Bug 25236] Accessibility: The 'Refine your search' box contains semantically incorrect headings In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25236 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bolshawh at parliament.uk -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 11 13:02:00 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Jun 2020 11:02:00 +0000 Subject: [Koha-bugs] [Bug 25236] Accessibility: The 'Refine your search' box contains semantically incorrect headings In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25236 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hayleymapley at catalyst.net.n | |z -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 11 13:02:14 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Jun 2020 11:02:14 +0000 Subject: [Koha-bugs] [Bug 21978] Add middle name field In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21978 --- Comment #4 from Sally --- Hi Katrin, Ah yes, sorry, I can imagine that the differences between countries are quite pronounced - I think Christopher is in the US, but I'm in the UK. It's much more common here to have a middle name than not - there's a bit on Wikipedia about it, which refers to the UK and the US: https://en.wikipedia.org/wiki/Middle_name Koha has a comprehensive 'borrowersunwantedfield' system preference, so it would be great if we could offer this functionality because for those geographic areas where it's not relevant, it could be easily disabled. The issues with using Initials / Other Name: 1) Initials and Other Name are located at the foot of Patron Identity when joining a patron - this is not logical for a middle name, it should be Surname / First Name / Middle Name or First Name / Middle Name / Surname. The Patron Identity fields aren't trivial to move around with jquery (I think, please correct me if I'm wrong - I'm fairly new to jquery and happy to learn more). 2) If using Initials, the patron's middle name is never formatted within the patron's name on the checkout or details pages - it looks bizarre to UK eyes to have Mr John Smith on the details screen, and then the middle name below the patron's phone numbers; all of the names should be grouped together. 3) If using Other Name, the patron's middle name is bracketed - e.g. John (David) Smith, or quoted: Mr John Smith (card number) "David" - again, this looks really strange to UK eyes, because quotes and brackets imply that the name is fake or optional. This makes sense because that field is designed to be for a nickname that the patron prefers to be called - but it doesn't work for middle names at all. It's hard to explain, but I guess I would say that when it comes to identity, your middle name is a key part of your name - just as much as your first name or surname is. It would be great if: - Koha accepted middle names in a properly designed field - The middle name input field was located next to first name / surname on the patron identity screen - The content of the middle name field is displayed in context - e.g. on the details screen, instead of Title / First Name / Surname, it should be Title / First Name / Middle Name / Surname - Mr John David Smith. - It should be possible for the field to be entered into the borrowersunwantedfield system preference so other regions can switch the feature off -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jun 11 13:03:21 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Jun 2020 11:03:21 +0000 Subject: [Koha-bugs] [Bug 10662] Build OAI-PMH Harvesting Client In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10662 --- Comment #299 from David Cook --- (In reply to Michal Denar from comment #296) > Hello David, > I'm ready for testing:-) Just one basic point: Koha is global, plugins have > to be translatable. > Looks like Tomas has already added translations to a plugin (https://gitlab.com/thekesolutions/plugins/koha-plugin-pay-via-paypal/-/tree/master/Koha/Plugin/Com/Theke/PayViaPayPal), so I'll model my work on that. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 11 13:07:05 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Jun 2020 11:07:05 +0000 Subject: [Koha-bugs] [Bug 25519] [18.11] TinyMCE editor pop ups broken In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25519 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 11 13:07:08 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Jun 2020 11:07:08 +0000 Subject: [Koha-bugs] [Bug 25519] [18.11] TinyMCE editor pop ups broken In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25519 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #104965|0 |1 is obsolete| | --- Comment #3 from David Nind --- Created attachment 105732 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105732&action=edit Bug 25519: [18.11] Fix missing dialog.css in TinyMCE editor When using the TinyMCE editor in 18.11 all functionalities used from popups (anchors, images, links) are broken because dialog.css is missing. To test: First verify the problem on the following pages: 1) Tools > News - Add or edit a news entry 2) Administration > Libraries - Add or edit OPAC info for one of the libraries 3) Administration > System preferences - Activate UseWYSIWYGinSystemPreferences - Try the editor on any of the HTML preferences like OpacMainUserBlock Apply the patch and repeat. The styling should be back, which especially makes adding links usable again. Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 11 13:08:12 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Jun 2020 11:08:12 +0000 Subject: [Koha-bugs] [Bug 25704] With ICU chains on, searching by callnumbers does not produce accurate results In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25704 --- Comment #3 from Kelly McElligott --- Katrin, The ICU system preference is set to be activated, as well as being turned on in the backend. Is there a different system preference you are talking about? David, Thanks! I will have that angle looked into. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 11 13:08:14 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Jun 2020 11:08:14 +0000 Subject: [Koha-bugs] [Bug 10662] Build OAI-PMH Harvesting Client In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10662 --- Comment #300 from Michal Denar --- Hi David, yes, I saw this solution. JSON file is easy to edit, I like it. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 11 13:09:29 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Jun 2020 11:09:29 +0000 Subject: [Koha-bugs] [Bug 22417] Add a task queue In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22417 --- Comment #58 from Jonathan Druart --- Remote branch rebased against master, and adjusted. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 11 13:19:18 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Jun 2020 11:19:18 +0000 Subject: [Koha-bugs] [Bug 25238] Accessibility: Multiple 'H1' headings exist in the full record display In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25238 --- Comment #1 from Martin Renvoize --- Created attachment 105733 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105733&action=edit Bug 25238: Fix semantic heading for opac-details Prior to this patch the opac-details view contained multiple h1 level headings. Test plan 1/ Perform a search in the OPAC that will yield results 2/ Navigate to any results detailed view 3/ Inspect the page and note that two H1 level headings are present (Page title + Item title) 4/ Apply the patch 5/ Reload the page 6/ Inspect the page and ntoe that the 'Item title' is now a level 2 heading 7/ Note the page still appears nicely 8/ Signoff Bonus points: Check with XSLT views enabled and disabled, MARC21, UNIMARC and NORMARC variations. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 11 13:19:48 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Jun 2020 11:19:48 +0000 Subject: [Koha-bugs] [Bug 25238] Accessibility: Multiple 'H1' headings exist in the full record display In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25238 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard at myacpl.org |martin.renvoize at ptfs-europe | |.com Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 11 13:19:51 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Jun 2020 11:19:51 +0000 Subject: [Koha-bugs] [Bug 13327] OPACPopupAuthorsSearch doesn't work with XSLT views In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13327 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 11 13:19:51 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Jun 2020 11:19:51 +0000 Subject: [Koha-bugs] [Bug 12561] Omnibus: Deprecate non-XSLT detail and result views In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12561 Bug 12561 depends on bug 13327, which changed state. Bug 13327 Summary: OPACPopupAuthorsSearch doesn't work with XSLT views https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13327 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 11 13:19:52 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Jun 2020 11:19:52 +0000 Subject: [Koha-bugs] [Bug 24690] Make OPACPopupAuthorsSearch work with search terms containing parenthesis In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24690 Bug 24690 depends on bug 13327, which changed state. Bug 13327 Summary: OPACPopupAuthorsSearch doesn't work with XSLT views https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13327 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 11 13:20:21 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Jun 2020 11:20:21 +0000 Subject: [Koha-bugs] [Bug 25237] Accessibility: The 'Author details' in the full record display contains semantically incorrect headings In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25237 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |25238 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25238 [Bug 25238] Accessibility: Multiple 'H1' headings exist in the full record display -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 11 13:20:21 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Jun 2020 11:20:21 +0000 Subject: [Koha-bugs] [Bug 25238] Accessibility: Multiple 'H1' headings exist in the full record display In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25238 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |25237 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25237 [Bug 25237] Accessibility: The 'Author details' in the full record display contains semantically incorrect headings -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 11 13:20:55 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Jun 2020 11:20:55 +0000 Subject: [Koha-bugs] [Bug 25238] Accessibility: Multiple 'H1' headings exist in the full record display In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25238 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bolshawh at parliament.uk, | |hayleymapley at catalyst.net.n | |z -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 11 13:21:22 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Jun 2020 11:21:22 +0000 Subject: [Koha-bugs] [Bug 25238] Accessibility: Multiple 'H1' headings exist in the full record display In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25238 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|25150 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25150 [Bug 25150] Accessibility: 2.4.10 Section Headings -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 11 13:21:22 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Jun 2020 11:21:22 +0000 Subject: [Koha-bugs] [Bug 25150] Accessibility: 2.4.10 Section Headings In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25150 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|25238 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25238 [Bug 25238] Accessibility: Multiple 'H1' headings exist in the full record display -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 11 13:23:13 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Jun 2020 11:23:13 +0000 Subject: [Koha-bugs] [Bug 11426] Make HighlightOwnItemsOnOPAC work with XSLT In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11426 --- Comment #13 from Jonathan Druart --- I cannot remember exactly but I think the answer is in the patch comment: """ This xsl syntax is insane. We should add this ugly choose test all over this xsl file, then also in the detail page (with the class highlight-row-detail). """ -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 11 13:27:02 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Jun 2020 11:27:02 +0000 Subject: [Koha-bugs] [Bug 25237] Accessibility: The 'Author details' in the full record display contains semantically incorrect headings In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25237 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bolshawh at parliament.uk -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 11 13:29:03 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Jun 2020 11:29:03 +0000 Subject: [Koha-bugs] [Bug 10662] Build OAI-PMH Harvesting Client In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10662 --- Comment #301 from Magnus Enger --- (In reply to David Cook from comment #299) > Looks like Tomas has already added translations to a plugin > (https://gitlab.com/thekesolutions/plugins/koha-plugin-pay-via-paypal/-/tree/ > master/Koha/Plugin/Com/Theke/PayViaPayPal), so I'll model my work on that. Bonus points to the person who documents how it's done, for example on the wiki! :-) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 11 13:29:16 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Jun 2020 11:29:16 +0000 Subject: [Koha-bugs] [Bug 21978] Add middle name field In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21978 --- Comment #5 from Katrin Fischer --- Hi Sally, thanks for your answer, that's super helpful! I actually have multiple surnames too, but it's not so common here to use all of them. For me they only show up on my passport and when trying to enter them for a flight booking (because they insist it should match the passport and then complain when they are too long to fit :) ) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 11 13:35:21 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Jun 2020 11:35:21 +0000 Subject: [Koha-bugs] [Bug 25519] [18.11] TinyMCE editor pop ups broken In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25519 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |RESOLVED Resolution|--- |WONTFIX --- Comment #4 from Katrin Fischer --- David, thx for signing off - I kind of forgot about this one :( With the release of 20.05 this turned into a WONTFIX as 18.11 will see on more releases. It might still be helpful to someone investigating the same issue. I am closing the bug. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 11 13:43:32 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Jun 2020 11:43:32 +0000 Subject: [Koha-bugs] [Bug 25627] Move OPAC problem reports from administration to tools In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25627 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 11 13:43:36 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Jun 2020 11:43:36 +0000 Subject: [Koha-bugs] [Bug 25627] Move OPAC problem reports from administration to tools In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25627 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #105725|0 |1 is obsolete| | --- Comment #5 from Katrin Fischer --- Created attachment 105734 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105734&action=edit Bug 25627: Move OPAC problem reports from administration to tools This patch moves the OPAC problem report management page from the Administration section to the Tools section. I think this makes sense because management of reports is an ongoing task, not a configuration. To test, apply the patch and enable the OPACReportProblem system preference. - Go to Administration. There should be no link to OPAC problem reports. - Open an administration page which shows the Administration menu in the left-hand sidebar, e.g. Libraries. There should be no link to OPAC problem reports in the menu. - Go to Tools. There should be a link to OPAC problem reports in the "Addional tools" section. - Open the OPAC problem reports page and confirm that it works correctly. - The breadcrumbs menu should show "Tools > OPAC problem reports." - Confirm that the link in the sidebar menu works correctly. - If necessary, submit an OPAC problem report via the OPAC so that there is a pending report. Go to the staff interface home page and check that the "OPAC problem reports pending" link works correctly. Signed-off-by: David Nind Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 11 13:43:40 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Jun 2020 11:43:40 +0000 Subject: [Koha-bugs] [Bug 25627] Move OPAC problem reports from administration to tools In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25627 --- Comment #6 from Katrin Fischer --- Created attachment 105735 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105735&action=edit Bug 25627: Fix class and id in body tag This will also help if you want to use different colors for different modules. Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 11 13:43:50 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Jun 2020 11:43:50 +0000 Subject: [Koha-bugs] [Bug 25627] Move OPAC problem reports from administration to tools In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25627 --- Comment #7 from Katrin Fischer --- Persuaded :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 11 13:48:48 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Jun 2020 11:48:48 +0000 Subject: [Koha-bugs] [Bug 25687] Switch Y/N in EDI accounts table for Yes and No for better translatability In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25687 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 11 13:48:52 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Jun 2020 11:48:52 +0000 Subject: [Koha-bugs] [Bug 25687] Switch Y/N in EDI accounts table for Yes and No for better translatability In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25687 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #105689|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer --- Created attachment 105736 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105736&action=edit Bug 25687: Switch Y/N in EDI accounts table for Yes and No for better translatability This patch changes the list of EDI accounts shown in EDI administration so that columns which previously used "Y" or "N" now show "Yes" or "No." To test, apply the patch and go to Administration -> EDI accounts. If necessary, add an EDI account. In the table of information about the EDI account, the columns with information about quotes, orders, invoices, responses, and auto-ordering should show "Yes" or "No" based on the account's settings. Signed-off-by: Kyle M Hall Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 11 13:49:13 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Jun 2020 11:49:13 +0000 Subject: [Koha-bugs] [Bug 25687] Switch Y/N in EDI accounts table for Yes and No for better translatability In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25687 --- Comment #4 from Katrin Fischer --- You beat me to it, thank you, Owen! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 11 13:49:47 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Jun 2020 11:49:47 +0000 Subject: [Koha-bugs] [Bug 25237] Accessibility: The 'Author details' in the full record display contains semantically incorrect headings In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25237 --- Comment #1 from Martin Renvoize --- Created attachment 105737 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105737&action=edit Bug 25237: Fix semantic heading for opac-details Prior to this patch the opac-details view contained semantically incorrect h3 headings for the author information. Test plan 1/ Perform a search in the OPAC that will yield results 2/ Navigate to any results detailed view 3/ Inspect the page and note that there are semantically incorrect headings H1 (Page title) > H2 (Item title) > H5 (Author) 4/ Apply the patch 5/ Reload the page 6/ Inspect the page and note that the semantically incorrect author block has been converted to a span with an 'h3' class for styling 7/ Note the page still appears nicely 8/ Signoff Bonus points: Check with XSLT views enabled and disabled. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 11 13:50:02 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Jun 2020 11:50:02 +0000 Subject: [Koha-bugs] [Bug 25237] Accessibility: The 'Author details' in the full record display contains semantically incorrect headings In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25237 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Assignee|oleonard at myacpl.org |martin.renvoize at ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 11 13:50:18 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Jun 2020 11:50:18 +0000 Subject: [Koha-bugs] [Bug 25237] Accessibility: The 'Author details' in the full record display contains semantically incorrect headings In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25237 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hayleymapley at catalyst.net.n | |z -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 11 13:51:40 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Jun 2020 11:51:40 +0000 Subject: [Koha-bugs] [Bug 25507] PDF order print for German 2-pages is broken In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25507 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #105674|0 |1 is obsolete| | --- Comment #5 from Martin Renvoize --- Created attachment 105738 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105738&action=edit Bug 25507: Fix table in basket group PDF German 2-pages A variable was doubled up which made the columns in the table of orders no longer line up (different number of headers to columns). To test: - Create at least one basket with one or more orders - Close the basket - Add the basket to a basket group manually or let Koha do it on closing - Change the OrderPdfFormat system preference to 'German 2-page' - Go to the basket group page and print the PDF of the basket - Verify the table of orders doesn't look right and runs outside the page - Apply patch - Repeat the PDF print - now table should look right Signed-off-by: David Nind Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 11 13:52:06 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Jun 2020 11:52:06 +0000 Subject: [Koha-bugs] [Bug 25507] PDF order print for German 2-pages is broken In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25507 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com Status|Signed Off |Passed QA --- Comment #6 from Martin Renvoize --- Trivial fix that passes qa scripts, makes sense and passes local testing. Passing QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 11 13:52:18 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Jun 2020 11:52:18 +0000 Subject: [Koha-bugs] [Bug 25507] PDF order print for German 2-pages is broken In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25507 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |martin.renvoize at ptfs-europe |y.org |.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 11 13:52:40 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Jun 2020 11:52:40 +0000 Subject: [Koha-bugs] [Bug 24881] Circulation.t still fails if tests are ran slowly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24881 --- Comment #23 from Victor Grousset/tuxayo --- I can still get the following error locally. I confirm that have applied the patch of comment 21 on top of 19.05.x without reverting the old patch t/db_dependent/Circulation.t .. 29/46 # Failed test 'ISSUED_TO_ANOTHER question flag should be set if AutoReturnCheckedOutItems is disabled and item is checked out to another' # at t/db_dependent/Circulation.t line 1975. # got: undef # expected: '1' # Looks like you planned 2 tests but ran 1. t/db_dependent/Circulation.t .. 30/46 # Looks like you failed 1 test of 1 run. # Failed test 'CanBookBeIssued + AutoReturnCheckedOutItems' # at t/db_dependent/Circulation.t line 1982. Can't call method "borrowernumber" on an undefined value at t/db_dependent/Circulation.t line 1979. # Looks like your test exited with 255 just after 30. t/db_dependent/Circulation.t .. Dubious, test returned 255 (wstat 65280, 0xff00) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 11 13:53:39 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Jun 2020 11:53:39 +0000 Subject: [Koha-bugs] [Bug 25582] Don't show OPAC problems entry on dashboard when there are no reports In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25582 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 11 13:53:44 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Jun 2020 11:53:44 +0000 Subject: [Koha-bugs] [Bug 25582] Don't show OPAC problems entry on dashboard when there are no reports In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25582 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #105673|0 |1 is obsolete| | --- Comment #6 from Katrin Fischer --- Created attachment 105739 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105739&action=edit Bug 25582: Don't show OPAC problems entry on dashboard when there are no reports This patch makes a minor correction to the template to correct the check on outstanding OPAC problem reports. An error was preventing the check from working correctly. To test, apply the patch and enable the OPACReportProblem system preference. - On the staff interface home page, check the area showing pending operations (suggestions, tags, etc.). - If you have no pending OPAC problem reports there should be no line for OPAC problem reports. - If necessary, mark all pending OPAC problem reports closed and confirm that when there are no outstanding reports the link is hidden. - Also test when there are no other outstanding reports in that section (suggestions, tags, patron modifications), nothing appears at all, not even the surrounding border. - If necessary, test that the link appears when you have one or more OPAC problem reports. - Go to the OPAC and use the "Report a problem" to submit a test report. - Check that the staff interface home page reflects that there is now a pending report. Signed-off-by: David Nind Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 11 13:54:27 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Jun 2020 11:54:27 +0000 Subject: [Koha-bugs] [Bug 24881] Circulation.t still fails if tests are ran slowly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24881 --- Comment #24 from Victor Grousset/tuxayo --- Should I push the patch of comment 21 anyway? If we still expect to fix part of the flaky tests. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 11 14:02:33 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Jun 2020 12:02:33 +0000 Subject: [Koha-bugs] [Bug 25434] When viewing cart on small screen sizes selections-toolbar is hidden In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25434 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 11 14:02:38 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Jun 2020 12:02:38 +0000 Subject: [Koha-bugs] [Bug 25434] When viewing cart on small screen sizes selections-toolbar is hidden In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25434 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #105477|0 |1 is obsolete| | --- Comment #6 from Katrin Fischer --- Created attachment 105740 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105740&action=edit Bug 25434: Display selections-toolbar on small screens Signed-off-by: Lucas Gass Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 11 14:09:47 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Jun 2020 12:09:47 +0000 Subject: [Koha-bugs] [Bug 25239] Accessibility: The 'Confirm reservation page' contains semantically incorrect headings In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25239 --- Comment #1 from Martin Renvoize --- Created attachment 105741 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105741&action=edit Bug 25239: Fix semantic heading for opac-reserve.tt Prior to this patch, the opac-reserve contained semantically incorrect headings. Test plan 1/ Perform a search which yields some results in the OPAC 2/ Attempt to place a hold on an item. 3/ On the resulting screen, note that the headings are: H1 (Koha page title) > H3 (Confirm holds for) > H5 (Hold levels) 4/ Apply this patch and reload the page 5/ Re-inspect the elements in question note the heading semantics are now: H1 (Title of page) > H2 (Confirm holds for) > H3 (Hold levels) 6/ Note the appearance of the box is still reasonable 7/ Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 11 14:10:07 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Jun 2020 12:10:07 +0000 Subject: [Koha-bugs] [Bug 25239] Accessibility: The 'Confirm reservation page' contains semantically incorrect headings In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25239 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Assignee|oleonard at myacpl.org |martin.renvoize at ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 11 14:10:24 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Jun 2020 12:10:24 +0000 Subject: [Koha-bugs] [Bug 25239] Accessibility: The 'Confirm reservation page' contains semantically incorrect headings In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25239 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bolshawh at parliament.uk, | |hayleymapley at catalyst.net.n | |z -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 11 14:11:53 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Jun 2020 12:11:53 +0000 Subject: [Koha-bugs] [Bug 25709] Rename systempreference to NotesDenylist In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25709 --- Comment #4 from Katrin Fischer --- First: I very much agree with renaming this one! Just the new name is not really 'talking' to me. I'd like to suggest we maybe use something like: OpacNotesToHide or OpacNotesUnwanted There is also a tiny thing (would have fixed in a follow-up): FAIL installer/data/mysql/updatedatabase.pl OK critic FAIL forbidden patterns forbidden pattern: Use INSERT IGNORE INTO on inserting a new syspref (see bug 9071) (line 6380) It could be discussed if we want to change the former release notes - we had named it badly, we fixed it after realizing our error. But I can see it was a sponsored feature, so maybe this will be nicer for the library. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 11 14:12:12 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Jun 2020 12:12:12 +0000 Subject: [Koha-bugs] [Bug 25238] Accessibility: Multiple 'H1' headings exist in the full record display In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25238 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 11 14:12:15 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Jun 2020 12:12:15 +0000 Subject: [Koha-bugs] [Bug 25238] Accessibility: Multiple 'H1' headings exist in the full record display In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25238 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #105733|0 |1 is obsolete| | --- Comment #2 from Owen Leonard --- Created attachment 105742 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105742&action=edit Bug 25238: Fix semantic heading for opac-details Prior to this patch the opac-details view contained multiple h1 level headings. Test plan 1/ Perform a search in the OPAC that will yield results 2/ Navigate to any results detailed view 3/ Inspect the page and note that two H1 level headings are present (Page title + Item title) 4/ Apply the patch 5/ Reload the page 6/ Inspect the page and ntoe that the 'Item title' is now a level 2 heading 7/ Note the page still appears nicely 8/ Signoff Bonus points: Check with XSLT views enabled and disabled, MARC21, UNIMARC and NORMARC variations. Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 11 14:14:27 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Jun 2020 12:14:27 +0000 Subject: [Koha-bugs] [Bug 25712] New: Add plugin hooks to transform patron and item barcodes Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25712 Bug ID: 25712 Summary: Add plugin hooks to transform patron and item barcodes Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Plugin architecture Assignee: koha-bugs at lists.koha-community.org Reporter: kyle at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org Some of our partners have unusual barcode requirements that have required us to transform scanned barcodes using javascript. This is not the most reliable method. It would make more sense to have Koha transform the barcodes on the backend using a plugin. We should add hooks to transform and generate new item and patron barcodes. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jun 11 14:14:32 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Jun 2020 12:14:32 +0000 Subject: [Koha-bugs] [Bug 25712] Add plugin hooks to transform patron and item barcodes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25712 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |kyle at bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 11 14:14:58 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Jun 2020 12:14:58 +0000 Subject: [Koha-bugs] [Bug 25239] Accessibility: The 'Confirm hold page' contains semantically incorrect headings In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25239 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Accessibility: The 'Confirm |Accessibility: The 'Confirm |reservation page' contains |hold page' contains |semantically incorrect |semantically incorrect |headings |headings -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 11 14:16:01 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Jun 2020 12:16:01 +0000 Subject: [Koha-bugs] [Bug 22417] Add a task queue In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22417 --- Comment #59 from Tomás Cohen Arazi --- (In reply to Jonathan Druart from comment #56) > Can we dedicate this bug report to the base idea, then create bug report on > top of it for experiment? I'd like to avoid noise for testers and keep the > comment list easy to follow. I agree with that. As discussed by other means, my only concerns are: - should we make it opt-in at this stage (i.e. keep the current scripts, but have a config/syspref that defines if the rabbitmq + daemon should be used). As it is packaged in the supported distros/versions it is not *that* important but worth discussing. - I don't agree with pulling the rabbitmq-server package automatically on a Debian install. We don't do that with mysql-server/mariadb-server and we should follow that approach. i.e. on the install notes, there will be an entry, before installing koha-common, which will say 'RabbitMQ' and will explain that if you already have one running, you point to it when calling koha-create (bug 25674) and otherwise what command to run for installing it. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 11 14:18:01 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Jun 2020 12:18:01 +0000 Subject: [Koha-bugs] [Bug 25704] With ICU chains on, searching by callnumbers does not produce accurate results In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25704 --- Comment #4 from Katrin Fischer --- Hi Kelly, that was the one I was thinking about. It might still be worthwhile looing into what that pref does change... maybe this is a case where it needs to be taken into account? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 11 14:23:31 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Jun 2020 12:23:31 +0000 Subject: [Koha-bugs] [Bug 22087] It would be helpful to have City and State visible in member.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22087 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply --- Comment #29 from Katrin Fischer --- CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/css/staff-global.css -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 11 14:24:07 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Jun 2020 12:24:07 +0000 Subject: [Koha-bugs] [Bug 25070] Include files to display address and contact must be refactored In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25070 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |katrin.fischer at bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 11 14:25:54 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Jun 2020 12:25:54 +0000 Subject: [Koha-bugs] [Bug 25712] Add plugin hooks to transform patron and item barcodes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25712 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |24031 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24031 [Bug 24031] Add plugin hook after_hold_create -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 11 14:25:54 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Jun 2020 12:25:54 +0000 Subject: [Koha-bugs] [Bug 24031] Add plugin hook after_hold_create In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24031 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |25712 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25712 [Bug 25712] Add plugin hooks to transform patron and item barcodes -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 11 14:26:25 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Jun 2020 12:26:25 +0000 Subject: [Koha-bugs] [Bug 25713] New: get_qualified_table_name should be a class method rather than an object method Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25713 Bug ID: 25713 Summary: get_qualified_table_name should be a class method rather than an object method Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Plugin architecture Assignee: koha-bugs at lists.koha-community.org Reporter: dcook at prosentient.com.au QA Contact: testopia at bugs.koha-community.org It would be very useful if "get_qualified_table_name" were a class method rather than an object method. That way you should easily get a qualified table name from anywhere in a plugin without having to instantiate a plugin object. The current method could be updated to support either class or object method invocations. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jun 11 14:32:12 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Jun 2020 12:32:12 +0000 Subject: [Koha-bugs] [Bug 25154] Accessibility: The 'Search results' page does not use heading markup where content is introduced In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25154 --- Comment #1 from Martin Renvoize --- Created attachment 105743 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105743&action=edit Bug 25254: Add heading where content is introduced in opac-results.tt Prior to this patch, the search results page did not contain a semantically accurate heading to introduce he main content of the page. Test plan 1/ Perform a search in the OPAC that yields results 2/ Inspect the page and note that the 'title' stating how many results are found is not semantically marked up as a heading to introduce the content. 3/ Apply the patch 4/ Reload the page 5/ Inspect the page and note that the 'title' stating how many results are found is now properly marked up as a second level heading and appropriately designated as the start of the 'maincontent' block with an associated '.maincontent' class. 6/ Perform a search which yields zero results 7/ Note that the 'No results found' title is properly marked up as a second level heading. 8/ Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 11 14:32:38 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Jun 2020 12:32:38 +0000 Subject: [Koha-bugs] [Bug 25154] Accessibility: The 'Search results' page does not use heading markup where content is introduced In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25154 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Assignee|oleonard at myacpl.org |martin.renvoize at ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 11 14:32:48 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Jun 2020 12:32:48 +0000 Subject: [Koha-bugs] [Bug 25154] Accessibility: The 'Search results' page does not use heading markup where content is introduced In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25154 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bolshawh at parliament.uk -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 11 14:34:29 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Jun 2020 12:34:29 +0000 Subject: [Koha-bugs] [Bug 24031] Add plugin hook after_hold_create In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24031 --- Comment #16 from Kyle M Hall --- Needs hook listed in Koha::Plugin::Test with corresponding unit tests. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 11 14:34:36 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Jun 2020 12:34:36 +0000 Subject: [Koha-bugs] [Bug 24031] Add plugin hook after_hold_create In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24031 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 11 14:36:04 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Jun 2020 12:36:04 +0000 Subject: [Koha-bugs] [Bug 25714] New: Columns configuration doesn't apply Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25714 Bug ID: 25714 Summary: Columns configuration doesn't apply Change sponsored?: --- Product: Koha Version: 19.11 Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Acquisitions Assignee: koha-bugs at lists.koha-community.org Reporter: arthur.suzuki at biblibre.com QA Contact: testopia at bugs.koha-community.org -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jun 11 14:37:20 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Jun 2020 12:37:20 +0000 Subject: [Koha-bugs] [Bug 24555] POC Elasticsearch - Use boolean queries instead of full text queries In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24555 --- Comment #11 from Julian Maurice --- Created attachment 105744 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105744&action=edit Bug 24555: Fix searches like 'field-name:term' This is used for instance in Koha::Authorities::get_usage_count ("an:") -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 11 14:37:45 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Jun 2020 12:37:45 +0000 Subject: [Koha-bugs] [Bug 24555] POC Elasticsearch - Use boolean queries instead of full text queries In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24555 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |julian.maurice at biblibre.com Status|Signed Off |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 11 14:42:35 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Jun 2020 12:42:35 +0000 Subject: [Koha-bugs] [Bug 25070] Include files to display address and contact must be refactored In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25070 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 11 14:42:39 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Jun 2020 12:42:39 +0000 Subject: [Koha-bugs] [Bug 25070] Include files to display address and contact must be refactored In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25070 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #104659|0 |1 is obsolete| | --- Comment #39 from Katrin Fischer --- Created attachment 105745 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105745&action=edit Bug 25070: Centralize member-alt-address-style There are 5 includes files per value of AddressFormat (us, de, fr). The code is duplicated for each language, the only thing that changes is the order. Wwith this patchset we are going to refactore them to avoid further regressions. The idea is to remove all code that is duplicated and remove the need of having 5*3 files. We are going to limit them to 5 files, 1 per use. Note that we could go even further, for instance member-display-alt-address-style and member-display-address-style are quite identical. Test plan (for the whole patchset): - Create a patron with all the address, contact and alternate info filled - Edit them and save - Look at the patron's info (top left) in the patron module, and the patron detail view. - Play with the different values of AddressFormat The order and the info must be displayed identically before and after this patchset. No change is expected. Signed-off-by: David Nind Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 11 14:42:44 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Jun 2020 12:42:44 +0000 Subject: [Koha-bugs] [Bug 25070] Include files to display address and contact must be refactored In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25070 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #104660|0 |1 is obsolete| | --- Comment #40 from Katrin Fischer --- Created attachment 105746 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105746&action=edit Bug 25070: Centralize member-alt-contact-style Signed-off-by: David Nind Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 11 14:42:48 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Jun 2020 12:42:48 +0000 Subject: [Koha-bugs] [Bug 25070] Include files to display address and contact must be refactored In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25070 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #104661|0 |1 is obsolete| | --- Comment #41 from Katrin Fischer --- Created attachment 105747 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105747&action=edit Bug 25070: Centralize member-display-address-style Signed-off-by: David Nind Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 11 14:42:48 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Jun 2020 12:42:48 +0000 Subject: [Koha-bugs] [Bug 24986] Maximum row size reached soon for borrowers and deletedborrowers In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24986 --- Comment #13 from Magnus Enger --- I forgot to save a dump of the live database that had the problem, and now it has been deleted. I tried to make a fresh install of 18.11.x, then upgrade to master, but this did not trigger the error I saw on the live database. Sorry about that. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 11 14:42:53 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Jun 2020 12:42:53 +0000 Subject: [Koha-bugs] [Bug 25070] Include files to display address and contact must be refactored In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25070 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #104662|0 |1 is obsolete| | --- Comment #42 from Katrin Fischer --- Created attachment 105748 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105748&action=edit Bug 25070: Centralize member-display-alt-address-style Signed-off-by: David Nind Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 11 14:42:55 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Jun 2020 12:42:55 +0000 Subject: [Koha-bugs] [Bug 25714] Columns configuration doesn't apply In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25714 --- Comment #1 from Arthur Suzuki --- Columns quantity doesn't show up in basket table even when configured as not "hidden by default" in Administration. Also "unitprice" both "tax included" & "tax excluded" do not show up in the configurator althought they do in the basket table. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 11 14:42:58 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Jun 2020 12:42:58 +0000 Subject: [Koha-bugs] [Bug 25070] Include files to display address and contact must be refactored In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25070 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #104663|0 |1 is obsolete| | --- Comment #43 from Katrin Fischer --- Created attachment 105749 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105749&action=edit Bug 25070: Centralize member-main-address-style Signed-off-by: David Nind Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 11 14:43:02 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Jun 2020 12:43:02 +0000 Subject: [Koha-bugs] [Bug 25070] Include files to display address and contact must be refactored In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25070 --- Comment #44 from Katrin Fischer --- Created attachment 105750 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105750&action=edit Bug 25070: (QA follow-up) Fix capitalization: Street Number Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 11 14:43:48 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Jun 2020 12:43:48 +0000 Subject: [Koha-bugs] [Bug 25714] Columns configuration doesn't apply In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25714 Arthur Suzuki changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=23522 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 11 14:43:48 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Jun 2020 12:43:48 +0000 Subject: [Koha-bugs] [Bug 23522] Show "Actual price" in basket when available In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23522 Arthur Suzuki changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=25714 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 11 14:47:14 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Jun 2020 12:47:14 +0000 Subject: [Koha-bugs] [Bug 24986] Maximum row size reached soon for borrowers and deletedborrowers In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24986 --- Comment #14 from Magnus Enger --- BTW, the server where I saw the problem is running 10.3.23-MariaDB-1:10.3.23+maria~stretch, if that makes any difference. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 11 14:47:47 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Jun 2020 12:47:47 +0000 Subject: [Koha-bugs] [Bug 25670] Add a method to search by ordernumber on transfered ones as well to K:A:Orders In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25670 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 11 14:50:34 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Jun 2020 12:50:34 +0000 Subject: [Koha-bugs] =?utf-8?b?W0J1ZyAyNTcxNV0gTmV3OiBDb29raWUg4oCcQ0dJ?= =?utf-8?q?SESSID=E2=80=9D_will_be_soon_rejected?= Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25715 Bug ID: 25715 Summary: Cookie “CGISESSID” will be soon rejected Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs at lists.koha-community.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org Testing something else I noticed this warning in the console: Cookie “CGISESSID” will be soon rejected because it has the “sameSite” attribute set to “none” or an invalid value, without the “secure” attribute. To know more about the “sameSite“ attribute, read https://developer.mozilla.org/docs/Web/HTTP/Headers/Set-Cookie/SameSite Filing so we can check if changes need to be made. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jun 11 14:51:32 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Jun 2020 12:51:32 +0000 Subject: [Koha-bugs] [Bug 25363] Merge common.js with staff-global.js In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25363 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 11 14:51:36 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Jun 2020 12:51:36 +0000 Subject: [Koha-bugs] [Bug 25363] Merge common.js with staff-global.js In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25363 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #104388|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer --- Created attachment 105751 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105751&action=edit Bug 25363: Merge common.js with staff-global.js This patch merges the contents of common.js with staff-global.js. Both are included globally in the staff interface, and there doesn't seem to be any reason to require that the user downloads two different JavaScript files. To test, apply the patch and perform a catalog search in the staff client. View the detail page for a title in the search results. On the detail page you should see navigation controls in the sidebar for browsing through search results. Confirm they work correctly. Signed-off-by: Lucas Gass Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 11 14:55:00 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Jun 2020 12:55:00 +0000 Subject: [Koha-bugs] [Bug 25154] Accessibility: The 'Search results' page does not use heading markup where content is introduced In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25154 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #2 from Owen Leonard --- I don't think we want to add the "maincontent" class to the

. I think we should try to keep that class for container
s. Anyway, it's already added to the
right above the "[% IF ( searchdesc ) %]" block -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 11 14:55:51 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Jun 2020 12:55:51 +0000 Subject: [Koha-bugs] [Bug 10910] Add a warn when deleting a patron with pending suggestions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10910 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 11 14:55:56 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Jun 2020 12:55:56 +0000 Subject: [Koha-bugs] [Bug 10910] Add a warn when deleting a patron with pending suggestions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10910 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #104237|0 |1 is obsolete| | --- Comment #16 from Katrin Fischer --- Created attachment 105752 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105752&action=edit Bug 10910: Add a warning when deleting a patron with pending suggestions Test plan: >From the OPAC, add a suggestion >From the staff interface, try to delete the patron who created the suggestion => You get a warning message Signed-off-by: Victor Grousset/tuxayo Signed-off-by: Katrin Fischer Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 11 14:56:00 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Jun 2020 12:56:00 +0000 Subject: [Koha-bugs] [Bug 10910] Add a warn when deleting a patron with pending suggestions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10910 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #104238|0 |1 is obsolete| | --- Comment #17 from Katrin Fischer --- Created attachment 105753 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105753&action=edit Bug 10910: (follow-up) Move the suggestions note with the other non-blocking notes To test: - Add a credit to the patron's account - Make sure they got a pending suggestion - Try to delete - Verify you notes for both as list items Signed-off-by: Katrin Fischer Signed-off-by: Victor Grousset/tuxayo Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 11 15:04:00 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Jun 2020 13:04:00 +0000 Subject: [Koha-bugs] [Bug 25402] Put OPAC cart download options into dropdown menu In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25402 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #4 from Katrin Fischer --- Should/could we not remove downloadBasket with this patch? Was wondering because I expected the pull down code to be removed elsewhere in the patch set. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 11 15:07:21 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Jun 2020 13:07:21 +0000 Subject: [Koha-bugs] [Bug 25714] Columns configuration for order table doesn't apply In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25714 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Columns configuration |Columns configuration for |doesn't apply |order table doesn't apply --- Comment #2 from Katrin Fischer --- Can you specify your exact version? I think this has been fixed recently. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 11 15:08:04 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Jun 2020 13:08:04 +0000 Subject: [Koha-bugs] [Bug 25714] Columns configuration for order table doesn't apply In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25714 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |DUPLICATE --- Comment #3 from Katrin Fischer --- Thinking of bug 25557 as a duplicate - please update if I am mistaken :) *** This bug has been marked as a duplicate of bug 25557 *** -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 11 15:08:04 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Jun 2020 13:08:04 +0000 Subject: [Koha-bugs] [Bug 25557] Column config table in acquisitions order does not match the acq table in baskets In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25557 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |arthur.suzuki at biblibre.com --- Comment #10 from Katrin Fischer --- *** Bug 25714 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 11 15:08:08 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Jun 2020 13:08:08 +0000 Subject: [Koha-bugs] [Bug 24986] Maximum row size reached soon for borrowers and deletedborrowers In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24986 --- Comment #15 from Magnus Enger --- Tried again with an upgrade from 18.11.06 to 19.11.06 (so more specific than the first attempt, where I used the latest releases of 18.11.x and 19.11x), but still no luck. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 11 15:12:54 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Jun 2020 13:12:54 +0000 Subject: [Koha-bugs] [Bug 23403] SIP2 lends to wrong patron if cardnumber is missing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23403 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 11 15:14:04 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Jun 2020 13:14:04 +0000 Subject: [Koha-bugs] [Bug 5087] Option to not show CSV profiles in OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5087 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #13 from Katrin Fischer --- Hi Aleisha, thanks a lot for taking these on! 1) With this patch we will hide any CSV profiles now shown in the OPAC. I think we should add an update for the existing CSV profiles to check the checkbox, so that we have no change of behaviour on update. 2) Can you please make the same change for the lists download? That should then cover all bases! -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 11 15:15:46 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Jun 2020 13:15:46 +0000 Subject: [Koha-bugs] [Bug 25714] Columns configuration for order table doesn't apply In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25714 --- Comment #4 from Arthur Suzuki --- Created attachment 105754 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105754&action=edit Bug 25714: Basket columns configuration broken test plan: 1) try to change displayed column configuration for baskets 2) verify it doesn't work 3) apply patch 4) retry 1) and verify it works -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jun 11 15:17:28 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Jun 2020 13:17:28 +0000 Subject: [Koha-bugs] [Bug 25714] Columns configuration for order table doesn't apply In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25714 --- Comment #5 from Katrin Fischer --- Arthur, did you see? there is alrady a patch on the bug I linked in PQA. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jun 11 15:18:28 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Jun 2020 13:18:28 +0000 Subject: [Koha-bugs] [Bug 22417] Add a task queue In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22417 --- Comment #60 from Jonathan Druart --- (In reply to Tomás Cohen Arazi from comment #59) > (In reply to Jonathan Druart from comment #56) > > Can we dedicate this bug report to the base idea, then create bug report on > > top of it for experiment? I'd like to avoid noise for testers and keep the > > comment list easy to follow. > > I agree with that. > > As discussed by other means, my only concerns are: > - should we make it opt-in at this stage (i.e. keep the current scripts, but > have a config/syspref that defines if the rabbitmq + daemon should be used). > As it is packaged in the supported distros/versions it is not *that* > important but worth discussing. We could, but really I don't think it's worth the effort. We will have to maintain 2 different codes that do the same thing, and will slow down for sure the move for other scripts. > - I don't agree with pulling the rabbitmq-server package automatically on a > Debian install. We don't do that with mysql-server/mariadb-server and we > should follow that approach. i.e. on the install notes, there will be an > entry, before installing koha-common, which will say 'RabbitMQ' and will > explain that if you already have one running, you point to it when calling > koha-create (bug 25674) and otherwise what command to run for installing it. Yes sure, I agree. I will implement that as soon as this is PQA. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 11 15:19:22 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Jun 2020 13:19:22 +0000 Subject: [Koha-bugs] [Bug 22087] It would be helpful to have City and State visible in member.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22087 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #102507|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 11 15:19:29 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Jun 2020 13:19:29 +0000 Subject: [Koha-bugs] [Bug 25714] Columns configuration for order table doesn't apply In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25714 --- Comment #6 from Arthur Suzuki --- yep, just seen that! -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jun 11 15:20:49 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Jun 2020 13:20:49 +0000 Subject: [Koha-bugs] [Bug 22087] It would be helpful to have City and State visible in member.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22087 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off --- Comment #30 from Owen Leonard --- (In reply to Katrin Fischer from comment #29) > CONFLICT (content): Merge conflict in > koha-tmpl/intranet-tmpl/prog/css/staff-global.css I obsoleted the patch containing compiled CSS. Instead a "yarn build" step should be added to the test plan. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 11 15:23:47 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Jun 2020 13:23:47 +0000 Subject: [Koha-bugs] [Bug 22087] It would be helpful to have City and State visible in member.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22087 --- Comment #31 from Katrin Fischer --- Thx, I was a little too fast here as I had to also take care of the dependency bug. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 11 15:34:42 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Jun 2020 13:34:42 +0000 Subject: [Koha-bugs] [Bug 22087] Show city and state in patron search results In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22087 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|It would be helpful to have |Show city and state in |City and State visible in |patron search results |member.pl | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 11 15:36:33 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Jun 2020 13:36:33 +0000 Subject: [Koha-bugs] [Bug 22087] Show city and state in patron search results In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22087 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Version|unspecified |master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 11 15:36:36 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Jun 2020 13:36:36 +0000 Subject: [Koha-bugs] [Bug 23403] SIP2 lends to wrong patron if cardnumber is missing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23403 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldstable |Pushed to oldoldstable Version(s)|20.05.00, 19.11.06 |20.05.00, 19.11.06, released in| |19.05.12 --- Comment #37 from Victor Grousset/tuxayo --- Backported to 19.05.x branch for 19.05.12 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 11 15:43:06 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Jun 2020 13:43:06 +0000 Subject: [Koha-bugs] [Bug 24881] Circulation.t still fails if tests are ran slowly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24881 --- Comment #25 from Jonathan Druart --- (In reply to Victor Grousset/tuxayo from comment #23) > I can still get the following error locally. > I confirm that have applied the patch of comment 21 on top of 19.05.x > without reverting the old patch > > > t/db_dependent/Circulation.t .. 29/46 > # Failed test 'ISSUED_TO_ANOTHER question flag should be set if > AutoReturnCheckedOutItems is disabled and item is checked out to another' > # at t/db_dependent/Circulation.t line 1975. > # got: undef > # expected: '1' > # Looks like you planned 2 tests but ran 1. > t/db_dependent/Circulation.t .. 30/46 # Looks like you failed 1 test of > 1 run. > > # Failed test 'CanBookBeIssued + AutoReturnCheckedOutItems' > # at t/db_dependent/Circulation.t line 1982. > Can't call method "borrowernumber" on an undefined value at > t/db_dependent/Circulation.t line 1979. > # Looks like your test exited with 255 just after 30. > t/db_dependent/Circulation.t .. Dubious, test returned 255 (wstat 65280, > 0xff00) This is because 19.05 is lacking: Bug 24062: Make sure TestBuilder will stop generate X or other invalid category's types -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 11 15:43:16 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Jun 2020 13:43:16 +0000 Subject: [Koha-bugs] [Bug 24807] Add "year" type to improve sorting by publication date In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24807 anne-cecile.bories at iepg.fr changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |anne-cecile.bories at iepg.fr -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 11 15:47:32 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Jun 2020 13:47:32 +0000 Subject: [Koha-bugs] [Bug 24881] Circulation.t still fails if tests are ran slowly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24881 --- Comment #26 from Victor Grousset/tuxayo --- Great find, will try that. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 11 15:56:47 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Jun 2020 13:56:47 +0000 Subject: [Koha-bugs] [Bug 25155] Accessibility: The 'Login modal' contains semantically incorrect headings In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25155 PTFS Europe Sandboxes changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #105722|0 |1 is obsolete| | --- Comment #7 from PTFS Europe Sandboxes --- Created attachment 105755 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105755&action=edit Bug 25155: Fixing semantic headings in opac-auth.tt Test plan: 1) Follow test plan from comment #1 2) Apply the patch 3) Reload the page, and note that is still displays fine 4) Check that the main heading is now an h1, and that the other headings on the page make sense Signed-off-by: Martin Renvoize Signed-off-by: Sally -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 11 15:56:50 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Jun 2020 13:56:50 +0000 Subject: [Koha-bugs] [Bug 25155] Accessibility: The 'Login modal' contains semantically incorrect headings In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25155 PTFS Europe Sandboxes changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #105723|0 |1 is obsolete| | --- Comment #8 from PTFS Europe Sandboxes --- Created attachment 105756 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105756&action=edit Bug 25155: Fixing semantic headings login modal The login modal headings were semantically incorrect prior to this patch. Test plan: 1) Click the 'Log in to your account' option to expose the modal 2) Use a headings inspector and note we jump from H1 (Page Title) -> H3 (Modal Title) 3) Apply the patch and reload the page. 4) Click the 'Log in to your account' option to expose the modal 5) The modal should still appear well formed 6) Use a headings inspector and note we jump from H1 (Page Title) -> H2 (Modal Title) -> H3 (Shibboleth title if enabled) Signed-off-by: Martin Renvoize Signed-off-by: Sally -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 11 15:56:53 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Jun 2020 13:56:53 +0000 Subject: [Koha-bugs] [Bug 25155] Accessibility: The 'Login modal' contains semantically incorrect headings In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25155 PTFS Europe Sandboxes changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #105724|0 |1 is obsolete| | --- Comment #9 from PTFS Europe Sandboxes --- Created attachment 105757 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105757&action=edit Bug 25155: (follow-up) Increase headings levels by 1 In the previous patch we reduced the headings levels by 2, but this was one level too many as we already have an H1 in the navbar and so all other heading sets should start at level 2 to semantically follow the title heading. Signed-off-by: Sally -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 11 15:57:13 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Jun 2020 13:57:13 +0000 Subject: [Koha-bugs] [Bug 25155] Accessibility: The 'Login modal' contains semantically incorrect headings In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25155 Sally changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |sally.healey at cheshireshared | |services.gov.uk -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 11 16:18:03 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Jun 2020 14:18:03 +0000 Subject: [Koha-bugs] [Bug 25239] Accessibility: The 'Confirm hold page' contains semantically incorrect headings In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25239 PTFS Europe Sandboxes changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #105741|0 |1 is obsolete| | --- Comment #2 from PTFS Europe Sandboxes --- Created attachment 105758 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105758&action=edit Bug 25239: Fix semantic heading for opac-reserve.tt Prior to this patch, the opac-reserve contained semantically incorrect headings. Test plan 1/ Perform a search which yields some results in the OPAC 2/ Attempt to place a hold on an item. 3/ On the resulting screen, note that the headings are: H1 (Koha page title) > H3 (Confirm holds for) > H5 (Hold levels) 4/ Apply this patch and reload the page 5/ Re-inspect the elements in question note the heading semantics are now: H1 (Title of page) > H2 (Confirm holds for) > H3 (Hold levels) 6/ Note the appearance of the box is still reasonable 7/ Signoff Signed-off-by: Sally -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 11 16:24:48 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Jun 2020 14:24:48 +0000 Subject: [Koha-bugs] [Bug 25239] Accessibility: The 'Confirm hold page' contains semantically incorrect headings In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25239 Sally changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |sally.healey at cheshireshared | |services.gov.uk --- Comment #3 from Sally --- Works great - just a note for future testers, to make H3 (Hold levels) appear, do the following: 1/ Perform a search which yields some results in the OPAC 2/ Place a hold on an item 3/ Go back to the same record and attempt to place a second hold 4/ On the resulting screen, note that the headings are: H1 (Koha page title) > H3 (Confirm holds for) > H5 (Hold levels) 5/ Apply this patch and reload the page 6/ Re-inspect the elements in question note the heading semantics are now: H1 (Title of page) > H2 (Confirm holds for) > H3 (Hold levels) 7/ Note the appearance of the box is still reasonable 8/ Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 11 16:25:14 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Jun 2020 14:25:14 +0000 Subject: [Koha-bugs] [Bug 24405] Links in facets are styled differently than other links on the results page in OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24405 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #104628|0 |1 is obsolete| | --- Comment #3 from Martin Renvoize --- Created attachment 105759 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105759&action=edit Bug 24405: Make OPAC link underlining consistent This patch makes a minor modification to the OPAC CSS so that links are consistently displayed without underlines in their inactive state. This corrects two cases: Links in the facets sidebar and "Check all/none" links shown on search results. To test, apply the patch and rebuild the OPAC CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client). - In the OPAC, perform a search. - In the search results facets sidebar, confirm that links are not underlined. - At the top of the search results table, confirm that the "Select all" and "Clear all" links are not underlined. Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 11 16:25:42 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Jun 2020 14:25:42 +0000 Subject: [Koha-bugs] [Bug 24405] Links in facets are styled differently than other links on the results page in OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24405 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |martin.renvoize at ptfs-europe | |.com --- Comment #4 from Martin Renvoize --- Trivial patch, works as expected, no obvious side effects. Passing QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 11 16:25:49 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Jun 2020 14:25:49 +0000 Subject: [Koha-bugs] [Bug 24405] Links in facets are styled differently than other links on the results page in OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24405 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |martin.renvoize at ptfs-europe |y.org |.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 11 16:39:25 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Jun 2020 14:39:25 +0000 Subject: [Koha-bugs] [Bug 25236] Accessibility: The 'Refine your search' box contains semantically incorrect headings In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25236 PTFS Europe Sandboxes changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #105729|0 |1 is obsolete| | --- Comment #7 from PTFS Europe Sandboxes --- Created attachment 105760 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105760&action=edit Bug 25236: Fix semantic heading for opac-facets.inc Prior to this patch, the opac-facets side navigation box contained semantically incorrect headings. Test plan 1/ Perform a search which yields some results in the OPAC 2/ Inspect the 'Refine your search' elements on the left side of the screen. Note that the headings are H1 (Koha page title) > H4 (Refine your search) > H5 (Headings within 'Refine your search' box) 3/ Apply this patch and follow https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client 4/ Reload the page (Flushing the cache to ensure the CSS change load) 5/ Re-inspect the 'Refine your search' elements and note the heading semantics are now H1 (Title of page) > H2 (Refine your search) > H3 (Headings within 'Refine your search') 6/ Note the appearance of the box is still reasonable 7/ Signoff Signed-off-by: Sally -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 11 16:39:28 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Jun 2020 14:39:28 +0000 Subject: [Koha-bugs] [Bug 25236] Accessibility: The 'Refine your search' box contains semantically incorrect headings In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25236 PTFS Europe Sandboxes changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #105730|0 |1 is obsolete| | --- Comment #8 from PTFS Europe Sandboxes --- Created attachment 105761 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105761&action=edit Bug 25236: Fix semantic heading for opac-topissues.inc Prior to this patch, the opac-topissues side navigation box contained semantically incorrect headings. Test plan 0/ Enable 'OpacTopIssues' 1/ Navigate to the top issues page via the 'Most popular' link 2/ Inspect the 'Refine your search' elements on the left side of the screen. Note that the headings are H1 (Koha page title) > H4 (Refine your search) 3/ Apply this patch 4/ Reload the page 5/ Re-inspect the 'Refine your search' elements and note the heading semantics are now H1 (Title of page) > H2 (Refine your search) 6/ Note the appearance of the box is still reasonable 7/ Signoff Signed-off-by: Sally -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 11 16:39:31 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Jun 2020 14:39:31 +0000 Subject: [Koha-bugs] [Bug 25236] Accessibility: The 'Refine your search' box contains semantically incorrect headings In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25236 PTFS Europe Sandboxes changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #105731|0 |1 is obsolete| | --- Comment #9 from PTFS Europe Sandboxes --- Created attachment 105762 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105762&action=edit Bug 25236: Fix semantic heading for opac-full-serial-issues.tt Prior to this patch, the opac-full-serial-issues side navigation box contained semantically incorrect headings. Test plan 1/ Search for a serial with many linked issues 2/ Navigate to the detailed view of that serial 3/ Click on the 'More details' link after all the listed issues 4/ Inspect the 'Refine your search' elements on the left side of the screen. Note that the headings are H1 (Koha page title) > H4 (Refine your search) 3/ Apply this patch 4/ Reload the page 5/ Re-inspect the 'Refine your search' elements and note the heading semantics are now H1 (Title of page) > H2 (Refine your search) 6/ Note the appearance of the box is improved and consistent with elsewhere 7/ Signoff Signed-off-by: Sally -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 11 16:39:53 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Jun 2020 14:39:53 +0000 Subject: [Koha-bugs] [Bug 25236] Accessibility: The 'Refine your search' box contains semantically incorrect headings In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25236 Sally changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sally.healey at cheshireshared | |services.gov.uk Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 11 16:41:55 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Jun 2020 14:41:55 +0000 Subject: [Koha-bugs] [Bug 25538] www/search_utf8.t is failing randomly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25538 --- Comment #17 from Tomás Cohen Arazi --- (In reply to Jonathan Druart from comment #16) > I think the env vars must be kept if --preserve-env is passed. > But in that case we should do the test in the bashrc (if vars exist, don't > reset them with the default values). > > Also I guess the following lines should be removed (var must be defined in > bashrc?) > 51 "env " > 52 . "KOHA_CONF=/etc/koha/sites/$instance/koha-conf.xml " > 53 . "PERL5LIB=$perl5lib > > But we are going to far, the whole script needs its own bug report (if the > above is correct). It smells like this is a problem in KTD, the run.sh script should be doing things in a different way. We passed things like KOHA_INTRANET_URL to the koha-shell because the different default shells pick or not the variables depending on which is being used. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 11 16:46:11 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Jun 2020 14:46:11 +0000 Subject: [Koha-bugs] [Bug 25481] koha-plack not working under D10 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25481 --- Comment #16 from Victor Grousset/tuxayo --- is_z3950_enabled() and is_z3950_running() not in 19.05.x, not need to backport. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 11 16:47:27 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Jun 2020 14:47:27 +0000 Subject: [Koha-bugs] [Bug 25538] www/search_utf8.t is failing randomly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25538 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 11 16:47:31 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Jun 2020 14:47:31 +0000 Subject: [Koha-bugs] [Bug 25538] www/search_utf8.t is failing randomly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25538 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #105688|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 11 16:47:34 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Jun 2020 14:47:34 +0000 Subject: [Koha-bugs] [Bug 25538] www/search_utf8.t is failing randomly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25538 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #105686|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 11 16:47:37 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Jun 2020 14:47:37 +0000 Subject: [Koha-bugs] [Bug 25538] www/search_utf8.t is failing randomly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25538 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #105687|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 11 16:48:00 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Jun 2020 14:48:00 +0000 Subject: [Koha-bugs] [Bug 25538] www/search_utf8.t is failing randomly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25538 --- Comment #18 from Tomás Cohen Arazi --- Created attachment 105763 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105763&action=edit Bug 25538: Don't run search_utf8.t if KOHA_*_URL empty Signed-off-by: Martin Renvoize Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 11 16:48:05 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Jun 2020 14:48:05 +0000 Subject: [Koha-bugs] [Bug 25538] www/search_utf8.t is failing randomly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25538 --- Comment #19 from Tomás Cohen Arazi --- Created attachment 105764 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105764&action=edit Bug 25538: Use sudo -i in koha-shell See man sudo, -i parameter. Should we expect regressions? Test plan: 0. Use D11 or U18. Don't apply this patch 1. $ echo $KOHA_INTRANET_URL $ sudo koha-shell kohadev $ echo $KOHA_INTRANET_URL 2. Apply this patch $ cp debian/scripts/koha-shell /usr/sbin/koha-shell 3. Repeat 1. Signed-off-by: Martin Renvoize Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 11 16:48:09 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Jun 2020 14:48:09 +0000 Subject: [Koha-bugs] [Bug 25538] www/search_utf8.t is failing randomly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25538 --- Comment #20 from Tomás Cohen Arazi --- Created attachment 105765 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105765&action=edit Bug 25538: Default to --login|-i if no command passed Signed-off-by: Martin Renvoize Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 11 16:49:00 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Jun 2020 14:49:00 +0000 Subject: [Koha-bugs] [Bug 25538] www/search_utf8.t is failing randomly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25538 --- Comment #21 from Tomás Cohen Arazi --- It all makes sense now that I've spent enough time trying myself to fix. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 11 16:51:24 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Jun 2020 14:51:24 +0000 Subject: [Koha-bugs] [Bug 22417] Add a task queue In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22417 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- URL|https://bugs.koha-community |https://gitlab.com/joubu/Ko |.org/bugzilla3/show_bug.cgi |ha/commits/bug_22417 |?id=22417#c30 |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=22417#c30 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 11 16:51:36 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Jun 2020 14:51:36 +0000 Subject: [Koha-bugs] [Bug 22417] Add a task queue In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22417 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- URL|https://gitlab.com/joubu/Ko |https://gitlab.com/joubu/Ko |ha/commits/bug_22417 |ha/commits/bug_22417 |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=22417#c30 | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 11 16:54:09 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Jun 2020 14:54:09 +0000 Subject: [Koha-bugs] [Bug 25151] Accessibility: The 'Your cart' page does not contain a level-one header In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25151 PTFS Europe Sandboxes changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #105719|0 |1 is obsolete| | --- Comment #6 from PTFS Europe Sandboxes --- Created attachment 105766 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105766&action=edit Bug 25151: Fixing semantic headings in opac-basket.tt Test plan: 1) Apply the patch 2) Add items to your cart/folder/basket 3) Open up the basket and check that the main heading is now an h1 4) Check that the page looks fine Signed-off-by: Sally -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 11 16:54:33 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Jun 2020 14:54:33 +0000 Subject: [Koha-bugs] [Bug 25151] Accessibility: The 'Your cart' page does not contain a level-one header In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25151 Sally changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sally.healey at cheshireshared | |services.gov.uk Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 11 17:17:01 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Jun 2020 15:17:01 +0000 Subject: [Koha-bugs] [Bug 19705] DecreaseLoanHighHolds.t is still failing randomly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19705 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |victor at tuxayo.net --- Comment #8 from Victor Grousset/tuxayo --- After 188 local run I could reproduce on 19.05.x the failure that happening on this build: https://jenkins.koha-community.org/view/19.05/job/Koha_19.05_D9/229/consoleText t/db_dependent/DecreaseLoanHighHolds.t .. 2/17 # Failed test 'Static mode should exceed threshold' # at t/db_dependent/DecreaseLoanHighHolds.t line 131. # got: '0' # expected: '1' # Failed test 'Should have duration of 1' # at t/db_dependent/DecreaseLoanHighHolds.t line 133. # got: '0' # expected: '1' # Failed test 'due_date should be a DateTime object' # at t/db_dependent/DecreaseLoanHighHolds.t line 134. # got: '' # expected: 'DateTime' Can't call method "hour" on an undefined value at t/db_dependent/DecreaseLoanHighHolds.t line 137. # Looks like your test exited with 11 just after 5. t/db_dependent/DecreaseLoanHighHolds.t .. Dubious, test returned 11 (wstat 2816, 0xb00) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 11 17:17:11 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Jun 2020 15:17:11 +0000 Subject: [Koha-bugs] [Bug 25716] New: Add ability to specify additional options in koha-conf.xml for z3950_responder.pl when using koha-z3950-responder Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25716 Bug ID: 25716 Summary: Add ability to specify additional options in koha-conf.xml for z3950_responder.pl when using koha-z3950-responder Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs at lists.koha-community.org Reporter: kyle at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jun 11 17:23:15 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Jun 2020 15:23:15 +0000 Subject: [Koha-bugs] [Bug 25716] Add ability to specify additional options in koha-conf.xml for z3950_responder.pl when using koha-z3950-responder In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25716 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 11 17:23:17 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Jun 2020 15:23:17 +0000 Subject: [Koha-bugs] [Bug 25716] Add ability to specify additional options in koha-conf.xml for z3950_responder.pl when using koha-z3950-responder In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25716 --- Comment #1 from Kyle M Hall --- Created attachment 105767 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105767&action=edit Bug 25716: Add ability to specify additional options in koha-conf.xml for z3950_responder.pl when using koha-z3950-responder The z39.50 responder has a number of command line options that are not accessible if using the debian scripts to control it. We should be able to set those options in the koha conf file to be passed to the script itself. Test Plan: 1) Apply this patch 2) Copy your kohaclone's koha-z3950-responder to /usr/sbin/koha-z3950-responder if necessary 3) Add "--add-item-status k" inside your block in your koha-conf.xml file 4) Use koha-z3950-responder to start/restart the z39.50 responder, note the item status is now in subfield k! -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jun 11 17:26:36 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Jun 2020 15:26:36 +0000 Subject: [Koha-bugs] [Bug 25716] Add ability to specify additional options in koha-conf.xml for z3950_responder.pl when using koha-z3950-responder In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25716 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |kyle at bywatersolutions.com |y.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jun 11 17:27:57 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Jun 2020 15:27:57 +0000 Subject: [Koha-bugs] [Bug 25716] Add ability to specify additional options in koha-conf.xml for z3950_responder.pl when using koha-z3950-responder In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25716 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |minor -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 11 17:38:24 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Jun 2020 15:38:24 +0000 Subject: [Koha-bugs] [Bug 25100] Add ability to add custom text to top of the Self registration Form In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25100 Lisette Scheer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #4 from Lisette Scheer --- (In reply to Lucas Gass from comment #3) > 7. Test by only displaying this for certain branches and make sure it only > shows up on those branches. I can't get it to show up only for certain branches on branch selection. Otherwise it works great. Lisette -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 11 17:41:08 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Jun 2020 15:41:08 +0000 Subject: [Koha-bugs] [Bug 25154] Accessibility: The 'Search results' page does not use heading markup where content is introduced In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25154 --- Comment #3 from Martin Renvoize --- Created attachment 105768 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105768&action=edit Bug 25154: Add heading where content is introduced in opac-results.tt Prior to this patch, the search results page did not contain a semantically accurate heading to introduce he main content of the page. Test plan 1/ Perform a search in the OPAC that yields results 2/ Inspect the page and note that the 'title' stating how many results are found is not semantically marked up as a heading to introduce the content. 3/ Apply the patch 4/ Reload the page 5/ Inspect the page and note that the 'title' stating how many results are found is now properly marked up as a second level heading and appropriately designated as the start of the 'maincontent' block with an associated '.maincontent' class. 6/ Perform a search which yields zero results 7/ Note that the 'No results found' title is properly marked up as a second level heading. 8/ Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 11 17:41:32 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Jun 2020 15:41:32 +0000 Subject: [Koha-bugs] [Bug 25154] Accessibility: The 'Search results' page does not use heading markup where content is introduced In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25154 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #105743|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 11 17:42:41 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Jun 2020 15:42:41 +0000 Subject: [Koha-bugs] [Bug 25154] Accessibility: The 'Search results' page does not use heading markup where content is introduced In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25154 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #4 from Martin Renvoize --- Good catch.. new patch uploaded. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 11 17:52:49 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Jun 2020 15:52:49 +0000 Subject: [Koha-bugs] [Bug 22801] Advance search yr uses copydate instead of date-of-publication In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22801 --- Comment #4 from Marjorie Barry-Vila --- +1 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 11 17:58:01 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Jun 2020 15:58:01 +0000 Subject: [Koha-bugs] [Bug 19705] DecreaseLoanHighHolds.t is still failing randomly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19705 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |REOPENED Resolution|FIXED |--- --- Comment #9 from Victor Grousset/tuxayo --- It was like 30 min, so not so hard to reproduce (assuming it wasn't huge luck) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 11 17:58:01 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Jun 2020 15:58:01 +0000 Subject: [Koha-bugs] [Bug 25551] [OMNIBUS] Some tests are failing randomly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25551 Bug 25551 depends on bug 19705, which changed state. Bug 19705 Summary: DecreaseLoanHighHolds.t is still failing randomly https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19705 What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |REOPENED Resolution|FIXED |--- -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 11 17:58:01 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Jun 2020 15:58:01 +0000 Subject: [Koha-bugs] [Bug 21086] Wrong mock of DateTime->now in tests In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21086 Bug 21086 depends on bug 19705, which changed state. Bug 19705 Summary: DecreaseLoanHighHolds.t is still failing randomly https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19705 What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |REOPENED Resolution|FIXED |--- -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 11 18:01:20 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Jun 2020 16:01:20 +0000 Subject: [Koha-bugs] [Bug 25538] www/search_utf8.t is failing randomly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25538 --- Comment #22 from Jonathan Druart --- root at 3c7b0504a2a3:koha(master|BISECTING)$ cp debian/scripts/koha-shell /usr/sbin/koha-shell root at 3c7b0504a2a3:koha(master|BISECTING)$ kshell bash: /root/.bashrc: Permission denied kohadev-koha at 3c7b0504a2a3:/kohadevbox/koha$ pwd /kohadevbox/koha kohadev-koha at 3c7b0504a2a3:/kohadevbox/koha$ exit # Switching to branch bug_25538 root at 3c7b0504a2a3:koha(master|BISECTING)$ cp debian/scripts/koha-shell /usr/sbin/koha-shell root at 3c7b0504a2a3:koha(master|BISECTING)$ kshell kohadev-koha at 3c7b0504a2a3:~$ pwd /var/lib/koha/kohadev Isn't this actually a problem? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 11 18:03:37 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Jun 2020 16:03:37 +0000 Subject: [Koha-bugs] [Bug 25538] www/search_utf8.t is failing randomly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25538 --- Comment #23 from Jonathan Druart --- root at 3c7b0504a2a3:koha(master|BISECTING)$ koha-shell kohadev -p -c "prove t/DateUtils.t" t/DateUtils.t .. ok All tests successful. Files=1, Tests=79, 0 wallclock secs ( 0.02 usr 0.01 sys + 0.49 cusr 0.03 csys = 0.55 CPU) Result: PASS So I should not break the tests launched by ktd. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 11 18:07:02 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Jun 2020 16:07:02 +0000 Subject: [Koha-bugs] [Bug 25538] www/search_utf8.t is failing randomly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25538 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |20.11.00 released in| | Status|Passed QA |Pushed to master --- Comment #24 from Jonathan Druart --- Pushed to master for 20.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 11 18:09:53 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Jun 2020 16:09:53 +0000 Subject: [Koha-bugs] [Bug 25531] Patron may not be debarred if backdated return In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25531 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 11 18:09:58 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Jun 2020 16:09:58 +0000 Subject: [Koha-bugs] [Bug 24881] Circulation.t still fails if tests are ran slowly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24881 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 11 18:10:08 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Jun 2020 16:10:08 +0000 Subject: [Koha-bugs] [Bug 24062] Circulation tests fail randomly if patron category type is 'X' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24062 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |victor at tuxayo.net Status|Pushed to master |Pushed to stable -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 11 18:10:16 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Jun 2020 16:10:16 +0000 Subject: [Koha-bugs] [Bug 24062] Circulation tests fail randomly if patron category type is 'X' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24062 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 11 18:10:36 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Jun 2020 16:10:36 +0000 Subject: [Koha-bugs] [Bug 25531] Patron may not be debarred if backdated return In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25531 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|20.05.00, 19.11.06 |20.05.00, 19.11.06, released in| |19.05.12 Status|Pushed to oldstable |Pushed to oldoldstable --- Comment #18 from Victor Grousset/tuxayo --- Backported to 19.05.x branch for 19.05.12 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 11 18:11:04 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Jun 2020 16:11:04 +0000 Subject: [Koha-bugs] [Bug 24881] Circulation.t still fails if tests are ran slowly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24881 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|20.05.00, 19.11.06 |20.05.00, 19.11.06, released in| |19.05.12 --- Comment #27 from Victor Grousset/tuxayo --- Backported to 19.05.x branch for 19.05.12 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 11 18:11:09 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Jun 2020 16:11:09 +0000 Subject: [Koha-bugs] [Bug 24062] Circulation tests fail randomly if patron category type is 'X' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24062 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|19.11.00 |19.11.00, 19.05.12 released in| | Status|Pushed to oldstable |Pushed to oldoldstable --- Comment #14 from Victor Grousset/tuxayo --- Backported to 19.05.x branch for 19.05.12 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 11 18:11:13 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Jun 2020 16:11:13 +0000 Subject: [Koha-bugs] [Bug 24881] Circulation.t still fails if tests are ran slowly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24881 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldstable |Pushed to oldoldstable -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 11 18:19:32 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Jun 2020 16:19:32 +0000 Subject: [Koha-bugs] [Bug 25552] Add missing Claims Returned option to MarkLostItemsAsReturned In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25552 Daniel Gaghan changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |daniel.gaghan at pueblolibrary | |.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 11 18:27:42 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Jun 2020 16:27:42 +0000 Subject: [Koha-bugs] [Bug 21978] Add middle name field In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21978 --- Comment #6 from Christopher Brannon --- Sally, thanks for the input. This helps. I've played around with othername and initials, and neither appear in search results or suggestions, although you can include them for searching. This makes distinguishing one patron from the other difficult when this information doesn't show. And Sally is right...the brackets around the othername doesn't make sense if it is a middle name. Middle names are used in the US for more formal identification (and some people have multiple middle names), but not commonly used in greetings or business letters. So, to have a middle name field that is searchable, and shows in searches, and properly laid out, but something that can be excluded in communications and notices, and on screen greetings would be preferred. Currently we are using othernames for nicknames, like if Mary Jo prefers to be called MJ. So, we can't really use that. And initials are not as visible as othernames. We can always adjust things like that, but as stated above, they are not visible in searches. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 11 18:34:26 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Jun 2020 16:34:26 +0000 Subject: [Koha-bugs] [Bug 21978] Add middle name field In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21978 Mark Foster changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |markf at communitylibrary.net -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 11 18:35:21 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Jun 2020 16:35:21 +0000 Subject: [Koha-bugs] [Bug 25707] Mappings update in bug 11529 causes incorrect MARC to DB data flow In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25707 --- Comment #3 from Nick Clemens --- (In reply to David Cook from comment #2) > I wouldn't say it causes data loss because the data is still in the MARC > record but it causes... incorrect MARC to DB mappings? It overwrites existing mappings and they are not preserved, so the only way to recover is from backup. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 11 18:40:20 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Jun 2020 16:40:20 +0000 Subject: [Koha-bugs] [Bug 21978] Add middle name field In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21978 --- Comment #7 from Mark Foster --- +1 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 11 19:33:07 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Jun 2020 17:33:07 +0000 Subject: [Koha-bugs] [Bug 25563] Cannot submit "add order from MARC file" form after alert In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25563 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable Version(s)|20.05.00, 19.11.07 |20.05.00, 19.11.07, released in| |19.05.12 CC| |victor at tuxayo.net -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 11 19:33:21 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Jun 2020 17:33:21 +0000 Subject: [Koha-bugs] [Bug 25563] Cannot submit "add order from MARC file" form after alert In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25563 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldstable |Pushed to oldoldstable --- Comment #8 from Victor Grousset/tuxayo --- Backported to 19.05.x branch for 19.05.12 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 11 20:02:21 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Jun 2020 18:02:21 +0000 Subject: [Koha-bugs] [Bug 24986] Maximum row size reached soon for borrowers and deletedborrowers In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24986 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 11 20:02:24 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Jun 2020 18:02:24 +0000 Subject: [Koha-bugs] [Bug 24986] Maximum row size reached soon for borrowers and deletedborrowers In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24986 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #105628|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 11 20:03:17 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Jun 2020 18:03:17 +0000 Subject: [Koha-bugs] [Bug 24986] Maximum row size reached soon for borrowers and deletedborrowers In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24986 --- Comment #16 from Tomás Cohen Arazi --- Created attachment 105769 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105769&action=edit Bug 24986: Modify some borrowers DB fields to (TINY|MEDIUM)TEXT Signed-off-by: Martin Renvoize Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 11 20:03:27 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Jun 2020 18:03:27 +0000 Subject: [Koha-bugs] [Bug 24986] Maximum row size reached soon for borrowers and deletedborrowers In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24986 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |tomascohen at gmail.com |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 11 20:04:03 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Jun 2020 18:04:03 +0000 Subject: [Koha-bugs] [Bug 25707] Mappings update in bug 11529 causes incorrect MARC to DB data flow In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25707 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|kyle at bywatersolutions.com |nick at bywatersolutions.com CC| |tomascohen at gmail.com QA Contact|testopia at bugs.koha-communit |tomascohen at gmail.com |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 11 20:13:08 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Jun 2020 18:13:08 +0000 Subject: [Koha-bugs] [Bug 25707] Mappings update in bug 11529 causes incorrect MARC to DB data flow In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25707 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|nick at bywatersolutions.com |kyle at bywatersolutions.com Status|Signed Off |In Discussion --- Comment #4 from Tomás Cohen Arazi --- @Kyle I don't understand why are you taking out the WHERE condition. And the warning message could be more clear about why they are wrong, otherwise it just says 'go remap' to what?. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 11 20:22:33 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Jun 2020 18:22:33 +0000 Subject: [Koha-bugs] [Bug 25707] Mappings update in bug 11529 causes incorrect MARC to DB data flow In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25707 --- Comment #5 from Nick Clemens --- The where condition was there to not warn the mappings that we attempted to update. We are no longer making this attempt so we want to list the whole table Something like: The keyword to marc mapping feature is no longer supported. Above find the mappings that had been defined in your system. You will need to remap any desired MARC fields to the Koha field you desire in the Koha to MARC mappings page under Administration -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 11 20:23:50 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Jun 2020 18:23:50 +0000 Subject: [Koha-bugs] [Bug 25707] Mappings update in bug 11529 causes incorrect MARC to DB data flow In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25707 --- Comment #6 from Tomás Cohen Arazi --- (In reply to Nick Clemens from comment #5) > The where condition was there to not warn the mappings that we attempted to > update. We are no longer making this attempt so we want to list the whole > table I get it. > Something like: > The keyword to marc mapping feature is no longer supported. Above find the > mappings that had been defined in your system. You will need to remap any > desired MARC fields to the Koha field you desire in the Koha to MARC > mappings page under Administration That reads better :-D -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 11 20:37:08 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Jun 2020 18:37:08 +0000 Subject: [Koha-bugs] [Bug 25707] Mappings update in bug 11529 causes incorrect MARC to DB data flow In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25707 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 11 20:44:52 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Jun 2020 18:44:52 +0000 Subject: [Koha-bugs] [Bug 25154] Accessibility: The 'Search results' page does not use heading markup where content is introduced In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25154 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 11 20:44:54 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Jun 2020 18:44:54 +0000 Subject: [Koha-bugs] [Bug 25154] Accessibility: The 'Search results' page does not use heading markup where content is introduced In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25154 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #105768|0 |1 is obsolete| | --- Comment #5 from Owen Leonard --- Created attachment 105770 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105770&action=edit Bug 25154: Add heading where content is introduced in opac-results.tt Prior to this patch, the search results page did not contain a semantically accurate heading to introduce he main content of the page. Test plan 1/ Perform a search in the OPAC that yields results 2/ Inspect the page and note that the 'title' stating how many results are found is not semantically marked up as a heading to introduce the content. 3/ Apply the patch 4/ Reload the page 5/ Inspect the page and note that the 'title' stating how many results are found is now properly marked up as a second level heading and appropriately designated as the start of the 'maincontent' block with an associated '.maincontent' class. 6/ Perform a search which yields zero results 7/ Note that the 'No results found' title is properly marked up as a second level heading. 8/ Signoff Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 11 20:52:37 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Jun 2020 18:52:37 +0000 Subject: [Koha-bugs] [Bug 25707] Mappings update in bug 11529 causes incorrect MARC to DB data flow In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25707 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 11 20:52:40 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Jun 2020 18:52:40 +0000 Subject: [Koha-bugs] [Bug 25707] Mappings update in bug 11529 causes incorrect MARC to DB data flow In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25707 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #105680|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 11 20:53:42 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Jun 2020 18:53:42 +0000 Subject: [Koha-bugs] [Bug 25707] Mappings update in bug 11529 causes incorrect MARC to DB data flow In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25707 --- Comment #7 from Tomás Cohen Arazi --- Created attachment 105771 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105771&action=edit Bug 25707: (bug 11529 follow-up) Do not update marc mappings, print old mappings to upgrade log This patch removes the update of marc frameworks from the updatedatabase script and warns the "MARC to Keyword" (fieldmappings ) to the upgrade log so they can be replaced manually Signed-off-by: David Cook Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 11 20:53:48 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Jun 2020 18:53:48 +0000 Subject: [Koha-bugs] [Bug 25707] Mappings update in bug 11529 causes incorrect MARC to DB data flow In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25707 --- Comment #8 from Tomás Cohen Arazi --- Created attachment 105772 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105772&action=edit Bug 25707: (QA follow-up) Clearer message about what's going on Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 11 21:19:48 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Jun 2020 19:19:48 +0000 Subject: [Koha-bugs] [Bug 25702] Actions button on Search results from Z39.50 is displayed incorrectly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25702 --- Comment #1 from Katrin Fischer --- Hi Jan, I don't see this behaviour in my 20.05/master installations. Which browser are you using? Did you make any local changes? (I notice the window is quite big on your screenshot, did you change that manually or was something changed to achieve that?) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jun 11 21:22:17 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Jun 2020 19:22:17 +0000 Subject: [Koha-bugs] [Bug 25717] New: Improve messages for automatic renewal errors Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25717 Bug ID: 25717 Summary: Improve messages for automatic renewal errors Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs at lists.koha-community.org Reporter: caroline.cyr-la-rose at inlibro.com QA Contact: testopia at bugs.koha-community.org While translating I noticed a couple of errors in intranet-tmpl/prog/en/includes/renew_strings.inc The message for auto_too_late is currently "Scheduled for automatic renewal and cannot yet be any more". I propose something like "Scheduled for automatic renewal and cannot be renewed any more". Also, the message for auto_too_much_oweing is "Scheduled for automatic renewal" (which is the same message as for auto_renew) I propose "Scheduled for automatic renewal and cannot be renewed because the patron has too many outstanding charges". -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jun 11 21:23:47 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Jun 2020 19:23:47 +0000 Subject: [Koha-bugs] [Bug 25696] Test prediction pattern button is invalid HTML In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25696 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jun 11 21:23:50 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Jun 2020 19:23:50 +0000 Subject: [Koha-bugs] [Bug 25696] Test prediction pattern button is invalid HTML In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25696 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #105654|0 |1 is obsolete| | --- Comment #2 from Katrin Fischer --- Created attachment 105773 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105773&action=edit Bug 25696: Correct "Test prediction pattern" HTML button This patch corrects the closing tag for the "Test prediction pattern" button from "" to "" Test plan: 1. Apply the patch 2. Create a serial subscription from a new or existing bib record 3. Choose any frequency, numbering pattern, and subscription start date you choose (ie fill out all mandatory subscription fields) 4. Click "Test prediction pattern" 5. Note that the prediction pattern appears on the right of the screen Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jun 11 21:24:32 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Jun 2020 19:24:32 +0000 Subject: [Koha-bugs] [Bug 25696] Test prediction pattern button is invalid HTML In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25696 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #3 from Katrin Fischer --- Obvious one line fix - switching to PQA. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jun 11 21:28:42 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Jun 2020 19:28:42 +0000 Subject: [Koha-bugs] [Bug 25690] SIP should not allow to check out an item in transfer because of a hold to another patron In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25690 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|SIP allows to check out an |SIP should not allow to |item with hold in transfer |check out an item in |to another patron |transfer because of a hold | |to another patron -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jun 11 21:30:34 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Jun 2020 19:30:34 +0000 Subject: [Koha-bugs] [Bug 25686] Title in the catalogue search result doesn't open the full (normal) record display In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25686 --- Comment #15 from Katrin Fischer --- > This is an issue I've been pondering for years. Personally, I'd love to see > the "Default Framework" be managed by Koha rather than by end users, so that > we could constantly update it with the latest and greatest configuration. I am not sure about this, we'd need to allow local changes. For example we have several custom fields agreed on for data exchange in Germany and in between libraries in certain areas. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jun 11 21:30:48 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Jun 2020 19:30:48 +0000 Subject: [Koha-bugs] [Bug 25717] Improve messages for automatic renewal errors In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25717 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrew at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 11 21:35:15 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Jun 2020 19:35:15 +0000 Subject: [Koha-bugs] [Bug 25680] When adding a new patron and missing to fill a field, on saving, the invalidFocus should show the focused field clearly in view. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25680 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jun 11 21:35:19 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Jun 2020 19:35:19 +0000 Subject: [Koha-bugs] [Bug 25680] When adding a new patron and missing to fill a field, on saving, the invalidFocus should show the focused field clearly in view. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25680 --- Comment #13 from Katrin Fischer --- Created attachment 105774 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105774&action=edit Bug 25680: When adding a new patron and missing to fill a field, on saving, the invalidFocus should show the focused field clearly in view This patch will center the focused field at the golden section in the window. To test: 1) Begin to add a new patron. 2) Leave a required field empty, which is outside the screen view, and click Save. 3) Notice that the field is at the bottom, behind the language bar if there is one. 4) Apply patch 5) Add a new patron. 6) Leave the required field empty again and Save. 7) Notice that the required field is now clearly shown in view. 8) Sign off. Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jun 11 21:35:43 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Jun 2020 19:35:43 +0000 Subject: [Koha-bugs] [Bug 25680] When adding a new patron and missing to fill a field, on saving, the invalidFocus should show the focused field clearly in view. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25680 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #105619|0 |1 is obsolete| | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 11 21:36:41 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Jun 2020 19:36:41 +0000 Subject: [Koha-bugs] [Bug 25680] When adding a new patron and missing to fill a field, on saving, the invalidFocus should show the focused field clearly in view In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25680 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|When adding a new patron |When adding a new patron |and missing to fill a |and missing to fill a |field, on saving, the |field, on saving, the |invalidFocus should show |invalidFocus should show |the focused field clearly |the focused field clearly |in view. |in view --- Comment #14 from Katrin Fischer --- I could see the issue now with the field not being in view, maybe the difference was activating a second language for the staff interface. I've fixed the commit line (it has to be: Bug XXXX: for the QA tools to be happy) and signed off. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 11 21:50:37 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Jun 2020 19:50:37 +0000 Subject: [Koha-bugs] [Bug 25676] Staff client catalog search shows incorrect item status under location In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25676 --- Comment #6 from Katrin Fischer --- > The idea here was to display: > (2, 1 Lost, 1 Long overdue), depending on the description in the LOST av > category. I think maybe we should just give up on the grouping and say: 1 Lost, 1 Long overdue -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 11 21:53:13 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Jun 2020 19:53:13 +0000 Subject: [Koha-bugs] [Bug 25664] login_attempts for imported borrowers can be set to NULL In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25664 --- Comment #1 from Katrin Fischer --- hm the column is 'default 0', so I guess the import must explicitly set it to NULL somewhere? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jun 11 22:08:40 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Jun 2020 20:08:40 +0000 Subject: [Koha-bugs] [Bug 25718] New: Correct typo in additem.tt Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25718 Bug ID: 25718 Summary: Correct typo in additem.tt Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs at lists.koha-community.org Reporter: caroline.cyr-la-rose at inlibro.com QA Contact: testopia at bugs.koha-community.org In intranet-tmpl/prog/en/modules/cataloguing/additem.tt there is a sentence that says ": Last item for bibliographic record wich biblio-level hold on it." It should say ": Last item for bibliographic record with biblio-level hold on it." -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 11 22:35:44 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Jun 2020 20:35:44 +0000 Subject: [Koha-bugs] [Bug 25652] Holds Daily is not looking at Item Type when Not Allowing Holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25652 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal --- Comment #1 from Katrin Fischer --- This reads like a bug - updating. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jun 11 22:36:30 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Jun 2020 20:36:30 +0000 Subject: [Koha-bugs] [Bug 25635] overdue_notices.pl dies if no overdue rules are defined In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25635 --- Comment #6 from Katrin Fischer --- Will this be fixed by bug 17532 or do we need to adjust the overdues script as well? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Jun 11 22:49:07 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Jun 2020 20:49:07 +0000 Subject: [Koha-bugs] [Bug 22807] Accessibility: Add 'Skip to Main Content' link In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22807 --- Comment #22 from Hayley Mapley --- Happy to help out where I can Martin! We're not so busy at the moment, so I'm trying to contribute as much as I can in those fleeting moments :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 11 23:01:32 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Jun 2020 21:01:32 +0000 Subject: [Koha-bugs] [Bug 22522] API authentication breaks with updated Mojolicious version In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22522 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable Version(s)|20.05.00 |20.05.00, 19.11.07 released in| | --- Comment #76 from Aleisha Amohia --- Jenkins is happy now :) backported to 19.11.x for 19.11.07 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 11 23:06:17 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Jun 2020 21:06:17 +0000 Subject: [Koha-bugs] [Bug 25155] Accessibility: The 'Login modal' contains semantically incorrect headings In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25155 --- Comment #10 from Hayley Mapley --- Hi Martin, What are your thoughts on that navbar h1? To me semantically it doesn't feel like it makes much sense, it'll be considered empty or it'll say "logo" I think by screen readers which doesn't really inform users of the content of the page at all (if it's a screen reader people are using then the page title (tab) will be read so they'll know they're on Koha). I'd like to propose we remove that as h1, leave it as a link. Anyone else have input here? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 11 23:24:26 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Jun 2020 21:24:26 +0000 Subject: [Koha-bugs] [Bug 25161] Can not edit relationship or guarantee of guarantor from the guarantee form In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25161 Barbara Johnson changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |barbara.johnson at bedfordtx.g | |ov --- Comment #1 from Barbara Johnson --- Just noticed this today after our upgrade when we needed to change a father that was incorrectly listed with a relationship of mother. We definitely need to be able to edit rather than remove and then redo the info. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 11 23:31:08 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Jun 2020 21:31:08 +0000 Subject: [Koha-bugs] [Bug 25719] New: Add system preference for logged in patrons to display only the patron's first name Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25719 Bug ID: 25719 Summary: Add system preference for logged in patrons to display only the patron's first name Change sponsored?: --- Product: Koha Version: 19.11 Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: barbara.johnson at bedfordtx.gov QA Contact: testopia at bugs.koha-community.org We'd like to see a system preference created that would allow libraries to select whether they would like to display the full patron name or only the first name for patrons who are logged into the OPAC. This would provide a cleaner display since some patron names can be rather long. In addition, most commercial websites will only display a first name for logged in users. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 11 23:45:59 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Jun 2020 21:45:59 +0000 Subject: [Koha-bugs] [Bug 24612] expirationdate blank if patron has more than one item from bib on hold In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24612 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #105254|0 |1 is obsolete| | --- Comment #23 from Aleisha Amohia --- Created attachment 105775 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105775&action=edit Bug 24612: Fix existing ReserveSlip tests -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 12 00:37:20 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Jun 2020 22:37:20 +0000 Subject: [Koha-bugs] [Bug 24612] expirationdate blank if patron has more than one item from bib on hold In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24612 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable CC| |aleisha at catalyst.net.nz Version(s)|20.05.00 |20.05.00, 19.11.07 released in| | --- Comment #24 from Aleisha Amohia --- backported to 19.11.x for 19.11.07 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 12 00:37:49 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Jun 2020 22:37:49 +0000 Subject: [Koha-bugs] [Bug 25720] New: Add the ability to send an e-mail or notifications to a particular club Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25720 Bug ID: 25720 Summary: Add the ability to send an e-mail or notifications to a particular club Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Patrons Assignee: koha-bugs at lists.koha-community.org Reporter: cbrannon at cdalibrary.org QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com Would like to see a way of e-mailing/sending a print notice to those enrolled in a particular club. I could see a new action added to the club called Contact, and you could fill out a text field with your message, and there would be an option to add the patron's name, info from club fields, etc... similar to create a notice, but simpler for front line staff. Once done, you could preview, and it would show a screen with the first member's info filled out, and you could advance through the members to preview if you like, or if you are satisfied, send the e-mail to those members. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Jun 12 00:53:44 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Jun 2020 22:53:44 +0000 Subject: [Koha-bugs] [Bug 25721] New: Club enrollment notification Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25721 Bug ID: 25721 Summary: Club enrollment notification Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Patrons Assignee: koha-bugs at lists.koha-community.org Reporter: cbrannon at cdalibrary.org QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com Would like to see a club enrollment notification. Would like a field that can be setup in the club for who to notify (e-mail or e-mails separated by a comma or whatever), and then they would be notified when someone signs up. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 12 01:43:53 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Jun 2020 23:43:53 +0000 Subject: [Koha-bugs] [Bug 25506] Perl undef warning on the "About Koha" page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25506 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 12 01:44:14 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Jun 2020 23:44:14 +0000 Subject: [Koha-bugs] [Bug 25452] Alternate email contact not displayed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25452 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 12 01:44:43 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Jun 2020 23:44:43 +0000 Subject: [Koha-bugs] [Bug 25428] Escaped HTML shows in authority detail view when subfield is a link In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25428 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 12 01:45:06 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Jun 2020 23:45:06 +0000 Subject: [Koha-bugs] [Bug 22522] API authentication breaks with updated Mojolicious version In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22522 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 12 01:45:28 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Jun 2020 23:45:28 +0000 Subject: [Koha-bugs] [Bug 24612] expirationdate blank if patron has more than one item from bib on hold In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24612 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 12 01:45:53 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Jun 2020 23:45:53 +0000 Subject: [Koha-bugs] [Bug 24413] MarkLostItemsAsReturned functionality does not lift restrictions caused by long overdues In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24413 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable CC| |aleisha at catalyst.net.nz -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 12 01:46:12 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Jun 2020 23:46:12 +0000 Subject: [Koha-bugs] [Bug 24413] MarkLostItemsAsReturned functionality does not lift restrictions caused by long overdues In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24413 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable Version(s)|20.05.00 |20.05.00, 19.11.07 released in| | --- Comment #31 from Aleisha Amohia --- backported to 19.11.x for 19.11.07 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 12 01:46:36 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Jun 2020 23:46:36 +0000 Subject: [Koha-bugs] [Bug 25567] borrower_attribute_types.category_code must be set to undef if not set In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25567 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable CC| |aleisha at catalyst.net.nz -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 12 01:46:53 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Jun 2020 23:46:53 +0000 Subject: [Koha-bugs] [Bug 25567] borrower_attribute_types.category_code must be set to undef if not set In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25567 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable Version(s)|20.05.00 |20.05.00, 19.11.07 released in| | --- Comment #11 from Aleisha Amohia --- backported to 19.11.x for 19.11.07 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 12 01:47:58 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Jun 2020 23:47:58 +0000 Subject: [Koha-bugs] [Bug 24185] 'If all unavailable' state for 'on shelf holds' makes holds page very slow if there's a lot of items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24185 --- Comment #38 from Andrew Nugged --- I've backported this to v19.11.x because people requested: where I should push patches for 19.11.06? Should I create a separate ticket? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 12 01:48:49 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 11 Jun 2020 23:48:49 +0000 Subject: [Koha-bugs] [Bug 25473] Can't add order from MARC file, save button does nothing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25473 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |aleisha at catalyst.net.nz Status|Pushed to master |Pushed to stable -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 12 02:00:56 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Jun 2020 00:00:56 +0000 Subject: [Koha-bugs] [Bug 25506] Perl undef warning on the "About Koha" page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25506 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |victor at tuxayo.net Version(s)|20.05.00, 19.11.07 |20.05.00, 19.11.07, released in| |19.05.12 Status|Pushed to oldstable |Pushed to oldoldstable --- Comment #6 from Victor Grousset/tuxayo --- Backported to 19.05.x branch for 19.05.12 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 12 02:17:38 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Jun 2020 00:17:38 +0000 Subject: [Koha-bugs] [Bug 24229] /items API tests fail on Ubuntu 18.04 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24229 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable CC| |aleisha at catalyst.net.nz -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 12 03:07:39 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Jun 2020 01:07:39 +0000 Subject: [Koha-bugs] [Bug 25452] Alternate email contact not displayed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25452 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |victor at tuxayo.net Version(s)|20.05.00, 19.11.07 |20.05.00, 19.11.07, released in| |19.05.12 Status|Pushed to oldstable |Pushed to oldoldstable --- Comment #8 from Victor Grousset/tuxayo --- Backported to 19.05.x branch for 19.05.12 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 12 03:16:53 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Jun 2020 01:16:53 +0000 Subject: [Koha-bugs] [Bug 25428] Escaped HTML shows in authority detail view when subfield is a link In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25428 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |victor at tuxayo.net Status|Pushed to oldstable |Pushed to oldoldstable Version(s)|20.05.00, 19.11.07 |20.05.00, 19.11.07, released in| |19.05.12 --- Comment #6 from Victor Grousset/tuxayo --- Backported to 19.05.x branch for 19.05.12 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 12 03:18:06 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Jun 2020 01:18:06 +0000 Subject: [Koha-bugs] [Bug 25591] Update list-deps for Debian 10 and Ubuntu 20.04 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25591 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |aleisha at catalyst.net.nz --- Comment #30 from Aleisha Amohia --- assuming this is for 20.05 only, not backporting to 19.11.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 12 03:21:14 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Jun 2020 01:21:14 +0000 Subject: [Koha-bugs] [Bug 25517] Koha.mo not found on package installations / Translations not working In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25517 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable CC| |aleisha at catalyst.net.nz -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 12 03:24:37 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Jun 2020 01:24:37 +0000 Subject: [Koha-bugs] [Bug 25473] Can't add order from MARC file, save button does nothing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25473 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|20.05.00 |20.05.00, 19.11.07 released in| | Status|Pushed to stable |Pushed to oldstable --- Comment #14 from Aleisha Amohia --- backported to 19.11.x for 19.11.07 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 12 03:39:20 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Jun 2020 01:39:20 +0000 Subject: [Koha-bugs] [Bug 25540] Biblio.t is failing randomly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25540 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable CC| |aleisha at catalyst.net.nz -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 12 03:46:29 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Jun 2020 01:46:29 +0000 Subject: [Koha-bugs] [Bug 25540] Biblio.t is failing randomly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25540 --- Comment #16 from Aleisha Amohia --- tests not failing on 19.11.x so not backporting -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 12 04:05:56 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Jun 2020 02:05:56 +0000 Subject: [Koha-bugs] [Bug 25556] Holds blocked when empty holdallowed value present in circulation_rules In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25556 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |aleisha at catalyst.net.nz Status|Pushed to master |Pushed to stable --- Comment #23 from Aleisha Amohia --- missing dependencies, not backported to 19.11.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 12 04:17:08 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Jun 2020 02:17:08 +0000 Subject: [Koha-bugs] [Bug 24229] /items API tests fail on Ubuntu 18.04 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24229 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable Version(s)|20.05.00 |20.05.00, 19.11.07 released in| | --- Comment #18 from Aleisha Amohia --- backported to 19.11.x for 19.11.07 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 12 04:20:32 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Jun 2020 02:20:32 +0000 Subject: [Koha-bugs] [Bug 23727] Editing course reserve items is broken In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23727 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |aleisha at catalyst.net.nz --- Comment #57 from Aleisha Amohia --- Hey Kyle, can you please take a look at Joy's comment above about qa tests so I can backport to 19.11.x? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 12 04:27:45 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Jun 2020 02:27:45 +0000 Subject: [Koha-bugs] [Bug 23463] Move C4::Items CRUD subroutines to Koha::Item In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23463 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |aleisha at catalyst.net.nz Status|Pushed to master |Pushed to stable --- Comment #167 from Aleisha Amohia --- enhancement, not backported to 19.11.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 12 04:28:14 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Jun 2020 02:28:14 +0000 Subject: [Koha-bugs] [Bug 25608] (regression) Inventory is broken In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25608 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |aleisha at catalyst.net.nz Status|Pushed to master |Pushed to stable --- Comment #6 from Aleisha Amohia --- missing dependencies, not backported to 19.11.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 12 04:58:57 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Jun 2020 02:58:57 +0000 Subject: [Koha-bugs] [Bug 24417] Charges/Fees.t is failing randomly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24417 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |victor at tuxayo.net --- Comment #2 from Victor Grousset/tuxayo --- Same failure, Koha_19.05_U18 https://jenkins.koha-community.org/view/19.05/job/Koha_19.05_U18/234/consoleText -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 12 06:37:59 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Jun 2020 04:37:59 +0000 Subject: [Koha-bugs] [Bug 25635] overdue_notices.pl dies if no overdue rules are defined In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25635 --- Comment #7 from David Cook --- (In reply to Katrin Fischer from comment #6) > Will this be fixed by bug 17532 or do we need to adjust the overdues script > as well? Bug 17532 actually makes this a problem as noted in Bug 25634. Bug 25634 resolves the main problem that Bug 17532 introduced, but the overdues script should be adjusted anyway. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 12 06:48:32 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Jun 2020 04:48:32 +0000 Subject: [Koha-bugs] [Bug 25686] Title in the catalogue search result doesn't open the full (normal) record display In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25686 --- Comment #16 from David Cook --- (In reply to Katrin Fischer from comment #15) > > This is an issue I've been pondering for years. Personally, I'd love to see > > the "Default Framework" be managed by Koha rather than by end users, so that > > we could constantly update it with the latest and greatest configuration. > > I am not sure about this, we'd need to allow local changes. For example we > have several custom fields agreed on for data exchange in Germany and in > between libraries in certain areas. Hmm that's a good point. Maybe we should have a "Reference" MARC Bibliographic Framework that is not the "Default", but which gets updated during upgrades. Maybe we could have a "diff tool" for showing the differences between "Reference" and any other framework, and have a user-friendly method for updating other frameworks from the "Reference" framework. The onus would still be on Koha users to update their frameworks, but at least they'd have the ability to do it in a practical (and authoritative) way. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 12 06:50:14 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Jun 2020 04:50:14 +0000 Subject: [Koha-bugs] [Bug 25707] Mappings update in bug 11529 causes incorrect MARC to DB data flow In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25707 --- Comment #9 from David Cook --- (In reply to Nick Clemens from comment #3) > (In reply to David Cook from comment #2) > > I wouldn't say it causes data loss because the data is still in the MARC > > record but it causes... incorrect MARC to DB mappings? > > It overwrites existing mappings and they are not preserved, so the only way > to recover is from backup. Ohh I see what you mean. I thought you meant MARC data would be lost, but you're referring to the mapping data. That makes sense. Honestly, I didn't recover from the backups. I just reset the mappings to reasonable defaults. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 12 06:51:14 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Jun 2020 04:51:14 +0000 Subject: [Koha-bugs] [Bug 25707] Mappings update in bug 11529 causes incorrect MARC to DB data flow In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25707 --- Comment #10 from David Cook --- (In reply to David Cook from comment #9) > (In reply to Nick Clemens from comment #3) > > (In reply to David Cook from comment #2) > > > I wouldn't say it causes data loss because the data is still in the MARC > > > record but it causes... incorrect MARC to DB mappings? > > > > It overwrites existing mappings and they are not preserved, so the only way > > to recover is from backup. > > Ohh I see what you mean. I thought you meant MARC data would be lost, but > you're referring to the mapping data. That makes sense. > > Honestly, I didn't recover from the backups. I just reset the mappings to > reasonable defaults. Since the mappings can be re-created, I wasn't thinking of it as data loss, since the valuable data (the MARC data) is still preserved. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 12 06:58:20 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Jun 2020 04:58:20 +0000 Subject: [Koha-bugs] [Bug 22417] Add a task queue In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22417 --- Comment #61 from David Cook --- (In reply to Tomás Cohen Arazi from comment #59) > As discussed by other means, my only concerns are: > - should we make it opt-in at this stage (i.e. keep the current scripts, but > have a config/syspref that defines if the rabbitmq + daemon should be used). > As it is packaged in the supported distros/versions it is not *that* > important but worth discussing. With my local experiments, I've made it opt-in, so that I can manually switch over and evaluate whether my approach to the message queue is working well enough. I check to see if the "Net::Stomp" module is available and if the koha-conf.xml file has the configuration I need. That works well. > - I don't agree with pulling the rabbitmq-server package automatically on a > Debian install. We don't do that with mysql-server/mariadb-server and we > should follow that approach. i.e. on the install notes, there will be an > entry, before installing koha-common, which will say 'RabbitMQ' and will > explain that if you already have one running, you point to it when calling > koha-create (bug 25674) and otherwise what command to run for installing it. I agree. While we've decided to run rabbitmq-server locally on each server, it is a reasonable choice to use external RabbitMQ servers. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 12 07:00:02 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Jun 2020 05:00:02 +0000 Subject: [Koha-bugs] [Bug 22417] Add a task queue In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22417 --- Comment #62 from David Cook --- (In reply to Jonathan Druart from comment #60) > Yes sure, I agree. I will implement that as soon as this is PQA. Could you squash your commits and then post a patch here? I have directly fetched from your Gitlab during testing, but it does make testing and patch evaluation more difficult. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 12 07:13:39 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Jun 2020 05:13:39 +0000 Subject: [Koha-bugs] [Bug 22417] Add a task queue In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22417 --- Comment #63 from David Cook --- (In reply to Jonathan Druart from comment #60) > Yes sure, I agree. I will implement that as soon as this is PQA. The latest work still seems like work-in-progress to me? - Connection details and credentials are still hard-coded into Koha::BackgroundJob, and there is no way of passing in a virtual host (which we might not use out of the box, but it would be good to build in the support) - For instance, koha_worker.pl should be moved to "./misc/bin/koha_worker.pl". - I was thinking the "namespace" for the queues should use the database name instead, since non-Debian installs may or may not have correctly set memcached_namespace. - I don't think there's any service to start up koha_worker.pl? - I'm curious why koha_worker.pl doesn't use the /queue prefix (as suggested by https://www.rabbitmq.com/stomp.html). I think it works without it, as I have tested your patches, but I'm curious. - Could we use a "/" instead of a "-" for the queue destination. I think that would be more conventional. - Koha::BackgroundJob loads C4::MarcModificationTemplates and C4::Biblio but doesn't use them. I'd really like to see this code be plugin friendly from Day 1, which I think could be done with some updates to koha_worker.pl and Koha::BackgroundJob. At the moment, koha_worker.pl and Koha::BackgroundJob are hard-coded with 2 job_types. It wouldn't be difficult to move the job_types somewhere more configurable. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 12 07:16:22 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Jun 2020 05:16:22 +0000 Subject: [Koha-bugs] [Bug 22417] Add a task queue In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22417 --- Comment #64 from David Cook --- (In reply to David Cook from comment #62) > (In reply to Jonathan Druart from comment #60) > > Yes sure, I agree. I will implement that as soon as this is PQA. > > Could you squash your commits and then post a patch here? > If you squash your commits and post a patch here, I'd be happy to collaborate on this work. As you know, I've already got a similar implementation running locally for 1 Koha instance, and I am very keen to move forward with a community implementation instead. I also have a Koha Plugin in development which I would love to use with a message queue. Between Jonathan, Tomas, and David, I'm sure we can make this happen soon. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 12 07:17:45 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Jun 2020 05:17:45 +0000 Subject: [Koha-bugs] [Bug 25704] With ICU chains on, searching by callnumbers does not produce accurate results In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25704 --- Comment #5 from David Cook --- (In reply to Katrin Fischer from comment #4) > Hi Kelly, that was the one I was thinking about. It might still be > worthwhile looing into what that pref does change... maybe this is a case > where it needs to be taken into account? I was wondering about that as well, and the only thing I could see what some different quoting, so it would be interesting to compare the Zebra search results. Difficult to troubleshoot remotely though... -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 12 07:21:36 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Jun 2020 05:21:36 +0000 Subject: [Koha-bugs] [Bug 10662] Build OAI-PMH Harvesting Client In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10662 --- Comment #302 from David Cook --- (In reply to Michal Denar from comment #300) > Hi David, > yes, I saw this solution. JSON file is easy to edit, I like it. Oh, it's not a JSON file. It'll be Template::Toolkit template files. Still very easy. Examples: https://gitlab.com/thekesolutions/plugins/koha-plugin-pay-via-paypal/-/blob/master/Koha/Plugin/Com/Theke/PayViaPayPal/i18n/cs-CZ.inc https://gitlab.com/thekesolutions/plugins/koha-plugin-pay-via-paypal/-/blob/master/Koha/Plugin/Com/Theke/PayViaPayPal/i18n/zh-Hans-CN.inc -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 12 07:22:15 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Jun 2020 05:22:15 +0000 Subject: [Koha-bugs] [Bug 10662] Build OAI-PMH Harvesting Client In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10662 --- Comment #303 from David Cook --- (In reply to Magnus Enger from comment #301) > (In reply to David Cook from comment #299) > > Looks like Tomas has already added translations to a plugin > > (https://gitlab.com/thekesolutions/plugins/koha-plugin-pay-via-paypal/-/tree/ > > master/Koha/Plugin/Com/Theke/PayViaPayPal), so I'll model my work on that. > > Bonus points to the person who documents how it's done, for example on the > wiki! :-) I'm only one man... 😭 But noted heh. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 12 07:30:10 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Jun 2020 05:30:10 +0000 Subject: [Koha-bugs] [Bug 14723] Additional delivery notes to messages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14723 Emmi Takkinen changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #87531|0 |1 is obsolete| | CC| |emmi.takkinen at outlook.com --- Comment #34 from Emmi Takkinen --- Created attachment 105776 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105776&action=edit Bug 14723: Additional delivery notes to messages This patch adds additional delivery notes to messages in message queue as there can be multiple reasons for a delivery to fail. Currently in message_queue we are given only two delivery statuses for messages, "sent" and "failed". When the status becomes failed, we have no idea why it fails. This feature can be useful with SMS gateway providers. Many SMS gateways inform the application the reason of SMS delivery failure. With this feature, this information can now be stored. As well as for emails, instead of simply logging failures, we can now store the reason of failure directly into the message row of message_queue. Test plan: 1. Enable EnhancedMessagingPreferences syspref 2. Find a borrower with notices at members/notices.pl 3. Observe that there is no column for Delivery notes 4. Apply patch and run the given database update 5. Repeat step 1. 6. Observe that there is now a column for Delivery notes Sponsored-by: Hypernova Oy Signed-off-by: Liz Rea -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Jun 12 07:35:13 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Jun 2020 05:35:13 +0000 Subject: [Koha-bugs] [Bug 14723] Additional delivery notes to messages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14723 Emmi Takkinen changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |emmi.takkinen at outlook.com |ity.org | Status|Failed QA |Needs Signoff --- Comment #35 from Emmi Takkinen --- Created attachment 105777 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105777&action=edit Bug 14723: Make delivery notes translatable Delivery notes weren't translatable. This patch adds them in notices.tt. If note is Mail::Sendmail error generic 'Error occured while sending email' is shown. Also fixes MySQLisms and adds AFTER to atomicupdate file. Sponsored-by: Koha-Suomi Oy -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Jun 12 08:29:59 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Jun 2020 06:29:59 +0000 Subject: [Koha-bugs] [Bug 24185] 'If all unavailable' state for 'on shelf holds' makes holds page very slow if there's a lot of items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24185 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |aleisha at catalyst.net.nz --- Comment #39 from Katrin Fischer --- (In reply to Andrew Nugged from comment #38) > I've backported this to v19.11.x because people requested: where I should > push patches for 19.11.06? Should I create a separate ticket? Usually the same bug is used and you can state the version in your commit message for example by adding [19.11] at the beginning of the subject line so it shows in the list of patches here. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 12 08:38:59 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Jun 2020 06:38:59 +0000 Subject: [Koha-bugs] [Bug 10662] Build OAI-PMH Harvesting Client In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10662 --- Comment #304 from Michal Denar --- Hi, I could participate on documetation. But I'm not developer, I need some "how to" from David or Tomás, how integrate translation into code. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 12 08:47:07 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Jun 2020 06:47:07 +0000 Subject: [Koha-bugs] [Bug 24986] Maximum row size reached soon for borrowers and deletedborrowers In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24986 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl --- Comment #17 from Marcel de Rooy --- (In reply to Jonathan Druart from comment #12) > I think we need to recreate the problem and confirm that the patch fixes it. > Not only guess it will do the trick (as I did). Your patch looks good to me too. https://mariadb.com/kb/en/troubleshooting-row-size-too-large-errors-with-innodb/ Shows some examples with adding varchar fields to recreate ? Does this actually mean that we should always better choose for the TEXT variants instead of VARCHAR ? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 12 09:19:01 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Jun 2020 07:19:01 +0000 Subject: [Koha-bugs] [Bug 25641] Koha/XSLT/Base.t is failing on U20 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25641 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl --- Comment #7 from Marcel de Rooy --- Is U20 counting lines in a file from 0 now ? Maybe we should just use \d+ ? The line number is not really relevant.. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 12 09:24:11 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Jun 2020 07:24:11 +0000 Subject: [Koha-bugs] [Bug 25641] Koha/XSLT/Base.t is failing on U20 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25641 --- Comment #8 from Jonathan Druart --- That's how I fixed it at the beginning. But then it sounded more accurate to test 0|1. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 12 09:51:23 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Jun 2020 07:51:23 +0000 Subject: [Koha-bugs] [Bug 24986] Maximum row size reached soon for borrowers and deletedborrowers In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24986 --- Comment #18 from Marcel de Rooy --- Here is a first observation: Not a big production database, but on a small master. I can add 139 varchar(60) fields to borrowers and still create table x like borrowers. But if I add 140 fields, the create fails on row size. Note that 60 is chosen so that the varchar stays on the main data page, not on the overflow. With your patch, I hoped to add more than 140 fields. But it fails exactly at this same point! So the patch seems to make no difference?? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 12 09:52:39 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Jun 2020 07:52:39 +0000 Subject: [Koha-bugs] [Bug 25722] New: ActionLogs.t is failing randomly Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25722 Bug ID: 25722 Summary: ActionLogs.t is failing randomly Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Test Suite Assignee: chris at bigballofwax.co.nz Reporter: jonathan.druart at bugs.koha-community.org QA Contact: testopia at bugs.koha-community.org Blocks: 25551 I think it's the first time we see this one. It is very weird as logaction is super simple. Master_D10 #265 18:29:18 koha_1 | # Failed test 'search() return right number of action logs' 18:29:18 koha_1 | # at t/db_dependent/Koha/ActionLogs.t line 72. 18:29:18 koha_1 | # got: '2' 18:29:18 koha_1 | # expected: '1' 18:29:18 koha_1 | # Looks like you failed 1 test of 1. 18:29:18 koha_1 | 18:29:18 koha_1 | # Failed test 'search() tests' 18:29:18 koha_1 | # at t/db_dependent/Koha/ActionLogs.t line 75. 18:29:18 koha_1 | # Looks like you failed 1 test of 3. 18:29:18 koha_1 | [16:29:18] t/db_dependent/Koha/ActionLogs.t I don't manage to make it fail locally. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25551 [Bug 25551] [OMNIBUS] Some tests are failing randomly -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 12 09:52:39 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Jun 2020 07:52:39 +0000 Subject: [Koha-bugs] [Bug 25551] [OMNIBUS] Some tests are failing randomly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25551 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |25722 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25722 [Bug 25722] ActionLogs.t is failing randomly -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 12 09:56:47 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Jun 2020 07:56:47 +0000 Subject: [Koha-bugs] [Bug 25658] Print icon sometimes obscures patron barcode In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25658 Alex Arnaud changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #105617|0 |1 is obsolete| | --- Comment #5 from Alex Arnaud --- Created attachment 105778 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105778&action=edit Bug 25658: Print icon sometimes obscures patron barcode This patch alters the style of the patron name/cardnumber label on the checkout screen so that it has a maximum width. This will help avoid the label being obscured by the print/close buttons displayed when DisplayClearScreenButton is enabled. To test, apply the patch and rebuild the staff client CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client). - Enable the DisplayClearScreenButton system preference. - Check out to a patron. Resize the browser to confirm that at narrower browser widths the patron name in the checkout form isn't obscured by the print and clear screen buttons. Signed-off-by: Katrin Fischer Signed-off-by: Alex Arnaud -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 12 09:57:13 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Jun 2020 07:57:13 +0000 Subject: [Koha-bugs] [Bug 25658] Print icon sometimes obscures patron barcode In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25658 Alex Arnaud changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |alex.arnaud at biblibre.com Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 12 09:57:22 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Jun 2020 07:57:22 +0000 Subject: [Koha-bugs] [Bug 25658] Print icon sometimes obscures patron barcode In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25658 Alex Arnaud changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |alex.arnaud at biblibre.com |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 12 10:13:04 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Jun 2020 08:13:04 +0000 Subject: [Koha-bugs] [Bug 24986] Maximum row size reached soon for borrowers and deletedborrowers In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24986 --- Comment #19 from Marcel de Rooy --- Well, not completely. Hang on. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 12 10:43:06 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Jun 2020 08:43:06 +0000 Subject: [Koha-bugs] [Bug 24986] Maximum row size reached soon for borrowers and deletedborrowers In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24986 --- Comment #20 from Marcel de Rooy --- Another thing: If I add the 140 fields before the db revision, the solution in this patch should help me to recover, but unfortunately the db rev will not execute the change on the fields but list the Row size too large on them. So I would be stuck. So the troubleshooting page here gives me a solution that I cant apply. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 12 10:47:31 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Jun 2020 08:47:31 +0000 Subject: [Koha-bugs] [Bug 24986] Maximum row size reached soon for borrowers and deletedborrowers In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24986 --- Comment #21 from Marcel de Rooy --- With SET SESSION innodb_strict_mode=OFF; I can do: alter table borrowers modify column streettype varchar(256); -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 12 11:28:27 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Jun 2020 09:28:27 +0000 Subject: [Koha-bugs] [Bug 24986] Maximum row size reached soon for borrowers and deletedborrowers In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24986 --- Comment #22 from Marcel de Rooy --- Well, my conclusion for now is: I am all for pushing this change to prevent future problems. But my test tells me that when you already ran into this problem, you cant alter table anymore and resolve it like the dbrev does. I needed to set strict mode off to alter the 140 fields to TEXT. And even then it was not sufficient. Only when I dropped field 140, it was gone. Perhaps another limitation? InnoDB should allow 1000 columns, but I already passed some other limitation: Row size too large. The maximum row size for the used table type, not counting BLOBs, is 65535. Not sure, but it might help to combine the separate ALTERs into one statement instead of looping. And it might help to temporarily disable strict mode for the alter, but as I saw in my test, the change might not be enough to recover? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 12 11:30:53 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Jun 2020 09:30:53 +0000 Subject: [Koha-bugs] [Bug 24807] Add "year" type to improve sorting by publication date In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24807 --- Comment #31 from Julian Maurice --- (In reply to Nick Clemens from comment #30) > From what little I understand there, UNIMARC uses '#' as the unkown > character? or '#' translates to blank? I think that '#' translates to blank. UNIMARC cataloguing plugin for 100$a in Koha uses spaces. > leading blanks should be preserved as 0? I think so. > and trailing ranged as you say below? I don't know... > > > - Replacing the uncertain character by 0 can be problematic. 197u is not > > 1970. Ideally, searching for records published in 1975 should return records > > where publication date is "197u", right ? Elasticsearch has an integer_range > > data type that could be useful in this situation. What do you think ? > > That is interesting, how does the range affect sorting? Might it still be > worthwhile to sort unknown/ranged dates either at start or end, so file the > sort value as either 1970 or 1979? I have not tested integer_range yet. Rethinking about this, maybe replacing "uncertain" by 0 is good enough for now. Support for uncertain dates as ranges can be added later. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 12 11:41:41 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Jun 2020 09:41:41 +0000 Subject: [Koha-bugs] [Bug 22417] Add a task queue In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22417 --- Comment #65 from Jonathan Druart --- (In reply to David Cook from comment #63) > (In reply to Jonathan Druart from comment #60) > > Yes sure, I agree. I will implement that as soon as this is PQA. > > The latest work still seems like work-in-progress to me? Yes and no. It's ready for testing. I will address QA comment once this will hit the QA process. We will certainly deal with other additions on separate bug reports. > - Connection details and credentials are still hard-coded into > Koha::BackgroundJob, and there is no way of passing in a virtual host (which > we might not use out of the box, but it would be good to build in the > support) > - For instance, koha_worker.pl should be moved to > "./misc/bin/koha_worker.pl". It's in misc/background_jobs_worker.pl the koha_worker.pl script is part of a "DO NOT PUSH" patch and is there to understand what's going on. Please read the test plan from comment 30. > - I was thinking the "namespace" for the queues should use the database name > instead, since non-Debian installs may or may not have correctly set > memcached_namespace. Yes, it's in the comment: # This namespace is wrong, it must be a vhost instead. # But to do so it needs to be created on the server => much more work when a new Koha instance is created. # Also, here we just want the Koha instance's name, but it's not in the config... # Picking a random id (memcached_namespace) from the config That will be addressed on bug 25674. > - I don't think there's any service to start up koha_worker.pl? There is a patch titled "Add debian script koha-worker". > - I'm curious why koha_worker.pl doesn't use the /queue prefix (as suggested > by https://www.rabbitmq.com/stomp.html). I think it works without it, as I > have tested your patches, but I'm curious. It's also in Net::Stomp's POD, so I guess it's a good pattern to follow. I will submit a follow-up. > - Could we use a "/" instead of a "-" for the queue destination. I think > that would be more conventional. Agreed. > - Koha::BackgroundJob loads C4::MarcModificationTemplates and C4::Biblio but > doesn't use them. Yes, leftover. Thanks! > I'd really like to see this code be plugin friendly from Day 1, which I > think could be done with some updates to koha_worker.pl and > Koha::BackgroundJob. At the moment, koha_worker.pl and Koha::BackgroundJob > are hard-coded with 2 job_types. It wouldn't be difficult to move the > job_types somewhere more configurable. It won't from Day 1. I really need a sign from the community that we agree on a first move. Make it more complex now is not a good idea. Once we agreed on that I promise to move all the different background jobs we have in a short term. That will show us some pattern that is repeated and must be refactored. For instance when I rebased yesterday I had to fix a conflict with bug 18127 (see patch "Restore the 'add to list' feature"). It highlights an interesting feature that must be implemented: a post-process hook to display something specific to the job's report. I hard-coded it for now, but that would be something great to implement in the next steps, especially for the plugins. (In reply to David Cook from comment #64) > (In reply to David Cook from comment #62) > > (In reply to Jonathan Druart from comment #60) > > > Yes sure, I agree. I will implement that as soon as this is PQA. > > > > Could you squash your commits and then post a patch here? > > > > If you squash your commits and post a patch here, I'd be happy to > collaborate on this work. I would prefer to keep the history. Checking out a remote branch should not prevent you to collaborate, it's even more easier than attaching the patches from here :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 12 11:41:48 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Jun 2020 09:41:48 +0000 Subject: [Koha-bugs] [Bug 22417] Add a task queue In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22417 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 12 11:47:41 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Jun 2020 09:47:41 +0000 Subject: [Koha-bugs] [Bug 25037] Add checkout_type to checkouts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25037 Joonas Kylmälä changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 12 11:47:44 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Jun 2020 09:47:44 +0000 Subject: [Koha-bugs] [Bug 25037] Add checkout_type to checkouts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25037 Joonas Kylmälä changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #102663|0 |1 is obsolete| | Attachment #102664|0 |1 is obsolete| | Attachment #104267|0 |1 is obsolete| | Attachment #104268|0 |1 is obsolete| | Attachment #105638|0 |1 is obsolete| | --- Comment #62 from Joonas Kylmälä --- Created attachment 105780 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105780&action=edit Bug 25037: Convert issues.onsite_checkout to issues.checkout_type If onsite_checkout=1, checkout_type becomes "ONSITE" Else checkout_type becomes "CHECKOUT" To test: 1. perl installer/data/mysql/updatedatabase.pl Sponsored-by: The National Library of Finland Signed-off-by: Joonas Kylmälä -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 12 11:47:48 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Jun 2020 09:47:48 +0000 Subject: [Koha-bugs] [Bug 25037] Add checkout_type to checkouts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25037 --- Comment #63 from Joonas Kylmälä --- Created attachment 105781 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105781&action=edit Bug 25037: Schema changes Sponsored-by: The National Library of Finland Signed-off-by: Joonas Kylmälä -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 12 11:47:51 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Jun 2020 09:47:51 +0000 Subject: [Koha-bugs] [Bug 25037] Add checkout_type to checkouts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25037 --- Comment #64 from Joonas Kylmälä --- Created attachment 105782 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105782&action=edit Bug 25037: Add Koha::Checkouts checkout_type constants and TT plugin Also make it available for templates. To test: 1. prove t/db_dependent/Koha/Checkouts.t 2. prove t/db_dependent/Template/Plugin/Checkouts.t Sponsored-by: The National Library of Finland Signed-off-by: Joonas Kylmälä -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 12 11:47:55 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Jun 2020 09:47:55 +0000 Subject: [Koha-bugs] [Bug 25037] Add checkout_type to checkouts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25037 --- Comment #65 from Joonas Kylmälä --- Created attachment 105783 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105783&action=edit Bug 25037: Replace occurences to issues.onsite_checkout This patch replaces all occurences to issues.onsite_checkout so that on-site checkouts work normally. It does not replace any on-site checkout logic. To test: 1. Investigate Koha source files via command line. We must make sure there are no longer references to issues.onsite_checkout column. You can do this by searching all occurrences of onsite_checkout. grep -rn 'onsite_checkout' | grep -v '\.git' 2. Run all these commands in your command line interface: grep -rl --color=never 'onsite_checkout' | grep '^.*\.t$' | xargs prove prove t/db_dependent/Koha/Account/Line.t prove t/db_dependent/api/v1/checkouts.t 3. Verify koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt - Create a record and add two items to it - Checkout both of them, one as on-site checkout and one as normal - Go to INTRANET /cgi-bin/koha/catalogue/detail.pl?biblionumber=XXX where XXX is your record's biblionumber - Observe Holdings table column Status => your on-site checked out item should say "Currently in local use by ..." => your normal checked out item should say "Checked out to ..." 4. Verify koha-tmpl/opac-tmpl/bootstrap/en/includes/item-status.inc - Repeat step 3 but this time go to OPAC /cgi-bin/koha/opac-detail.pl?biblionumber=XXX where XXX is your record's biblionumber - Observe Holdings table column Status => your on-site checked out item should say "Currently in local use" => your normal checked out item should say "Checked out" 5. Verify koha-tmpl/intranet-tmpl/prog/en/modules/members/readingrec.tt - After step 4, go to INTRANET /cgi-bin/koha/members/readingrec.pl?borrowernumber=51 - You will see circulation history table. - Observe your two checkouts from step 3 - Click "Checkouts" tab - Observe your normal checkout in the list - Click "On-site checkouts"" tab - Observe your on-site checkout in the list 6. Verify koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-readingrecord.tt - Repeat step 5 but this time go to OPAC /cgi-bin/koha/opac-readingrecord.pl Sponsored-by: The National Library of Finland Signed-off-by: Joonas Kylmälä -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 12 11:47:59 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Jun 2020 09:47:59 +0000 Subject: [Koha-bugs] [Bug 25037] Add checkout_type to checkouts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25037 --- Comment #66 from Joonas Kylmälä --- Created attachment 105784 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105784&action=edit Bug 25037: (follow-up) Fix checkout_type property description Also adds a test of the property to checkouts.t REST test. To test: 1. prove t/db_dependent/api/v1/checkouts.t Signed-off-by: Joonas Kylmälä -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 12 11:53:21 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Jun 2020 09:53:21 +0000 Subject: [Koha-bugs] [Bug 22417] Add a task queue In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22417 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff --- Comment #66 from Jonathan Druart --- Branch updated: - 2 use statements removed (commit amended) - New commit to send/receive message to/from /queue Note that /queue/$namespace/$job_type does not work, I kept the dash: '/koha_kohadev/batch_biblio_record_modification' is not a valid queue destination -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 12 11:58:07 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Jun 2020 09:58:07 +0000 Subject: [Koha-bugs] [Bug 25112] Koha::CirculationRules->set_rules should handle scopes per rule In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25112 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #4 from Jonathan Druart --- I think that's expected. That may make the caller codes confusing. Why do you need that? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 12 12:04:15 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Jun 2020 10:04:15 +0000 Subject: [Koha-bugs] [Bug 25114] Remove duplicated logic from GetLoanLength() In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25114 Joonas Kylmälä changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 12 12:04:18 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Jun 2020 10:04:18 +0000 Subject: [Koha-bugs] [Bug 25114] Remove duplicated logic from GetLoanLength() In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25114 Joonas Kylmälä changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #102768|0 |1 is obsolete| | --- Comment #4 from Joonas Kylmälä --- Created attachment 105785 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105785&action=edit Bug 25114: Remove duplicated logic from GetLoanLength() Remove duplicated logic for searching circulation rules. This can be replaced with get_effective_rules(). To test: 1. prove t/db_dependent/Circulation/GetHardDueDate.t Signed-off-by: Joonas Kylmälä -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 12 12:04:45 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Jun 2020 10:04:45 +0000 Subject: [Koha-bugs] [Bug 25699] Edition information to Holds to pull report In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25699 Peter Vashchuk changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #105691|0 |1 is obsolete| | --- Comment #2 from Peter Vashchuk --- Created attachment 105786 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105786&action=edit Bug 25699: Add edition information to "Holds to pull" report Added a feature that displays edition information of the book together with title in "Holds to pull" report. Edition information is fetched from "biblioitem" table as "editionstatement" and transferred to template. Those changes don't have performance impact as all tables including "biblioitem" were already used and joined in this request. Mentored-by: Andrew Nugged -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 12 12:06:12 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Jun 2020 10:06:12 +0000 Subject: [Koha-bugs] [Bug 14315] Slow checkouts, caused by many 'special_holidays' definitions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14315 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com --- Comment #11 from Martin Renvoize --- I think this is still somewhat of an issue.. in my experience we've now worked through the IO bound performance issue with the caching bugs, but we still have some CPU bound issues relating to the slow instantiation speed of DateTime. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 12 12:11:03 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Jun 2020 10:11:03 +0000 Subject: [Koha-bugs] [Bug 25112] Koha::CirculationRules->set_rules should handle scopes per rule In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25112 Joonas Kylmälä changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 12 12:11:06 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Jun 2020 10:11:06 +0000 Subject: [Koha-bugs] [Bug 25112] Koha::CirculationRules->set_rules should handle scopes per rule In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25112 Joonas Kylmälä changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #102763|0 |1 is obsolete| | Attachment #102764|0 |1 is obsolete| | --- Comment #5 from Joonas Kylmälä --- Created attachment 105787 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105787&action=edit Bug 25112: Add a failing test for CirculationRules.t To reproduce the problem, do: 1. prove t/db_dependent/Koha/CirculationRules.t 2. Observe a failing test set_rule cannot set 'holdallowed' for a 'categorycode'! at t/db_dependent/Koha/CirculationRules.t line 304. Sponsored-by: The National Library of Finland Signed-off-by: Joonas Kylmälä -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 12 12:11:11 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Jun 2020 10:11:11 +0000 Subject: [Koha-bugs] [Bug 25112] Koha::CirculationRules->set_rules should handle scopes per rule In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25112 --- Comment #6 from Joonas Kylmälä --- Created attachment 105788 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105788&action=edit Bug 25112: Make set_rules() handle rule scopes Koha::CirculationRules->set_rules is currently too complicated to use. Right now, in order to specify multiple rules at once, they must all be rules that accept the same set of scopes. Otherwise we can get this type of errors: 1/9 set_rule cannot set 'holds_per_record' for a 'checkout_type'! at t/db_dependent/Circulation/GetHardDueDate.t line 215. Validating scopes at set_rule() is good, but set_rules() should examine each rule and pass the correct scope to set_rule() instead of passing all scopes to every rule like it is doing now. To test: 1. prove t/db_dependent/Koha/CirculationRules.t 2. Observe success Sponsored-by: The National Library of Finland Signed-off-by: Joonas Kylmälä -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 12 12:11:51 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Jun 2020 10:11:51 +0000 Subject: [Koha-bugs] [Bug 25624] Update patrons category script should allow finding null and not null and wildcards In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25624 Alex Arnaud changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |alex.arnaud at biblibre.com |y.org | CC| |alex.arnaud at biblibre.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 12 12:13:06 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Jun 2020 10:13:06 +0000 Subject: [Koha-bugs] [Bug 25723] New: Drop DateTime::Set as a dependancy Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25723 Bug ID: 25723 Summary: Drop DateTime::Set as a dependancy Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs at lists.koha-community.org Reporter: martin.renvoize at ptfs-europe.com QA Contact: testopia at bugs.koha-community.org DateTime::Set is used in one place and one place only, and we only utilise a single method from it. We should replace that occurrence, exception_holidays, with logic matching that from 'single_holidays' which achieves the same end. I will attempt to do that and profile the difference too. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 12 12:13:19 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Jun 2020 10:13:19 +0000 Subject: [Koha-bugs] [Bug 25723] Drop DateTime::Set as a dependancy In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25723 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |14315 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14315 [Bug 14315] Slow checkouts, caused by many 'special_holidays' definitions -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Jun 12 12:13:19 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Jun 2020 10:13:19 +0000 Subject: [Koha-bugs] [Bug 14315] Slow checkouts, caused by many 'special_holidays' definitions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14315 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |25723 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25723 [Bug 25723] Drop DateTime::Set as a dependancy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 12 12:19:43 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Jun 2020 10:19:43 +0000 Subject: [Koha-bugs] [Bug 25113] Make CirculationRules.t flexible for new scope combinations In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25113 Joonas Kylmälä changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |joonas.kylmala at helsinki.fi --- Comment #3 from Joonas Kylmälä --- In the patch you mention > This also obsoletes the "Get effective issuing rule in correct order" > test in t/db_dependent/Koha/IssuingRules.t why is it obsoleted? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 12 12:23:10 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Jun 2020 10:23:10 +0000 Subject: [Koha-bugs] [Bug 25723] Drop DateTime::Set as a dependancy In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25723 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 12 12:50:53 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Jun 2020 10:50:53 +0000 Subject: [Koha-bugs] [Bug 25724] New: Transferred item checked in to shelving cart has cart location removed when transfer is filled Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25724 Bug ID: 25724 Summary: Transferred item checked in to shelving cart has cart location removed when transfer is filled Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Circulation Assignee: koha-bugs at lists.koha-community.org Reporter: nick at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com To recreate: 1 - Set UpdateItemLocationOnCheckin to: _ALL_: CART 2 - SetAutomaticItemReturn = Do 3 - Check an item in at a different branch than it's homebranch to create a transfer 4 - Check the item in at it's homebranch 5 - View the item details page 6 - Item is not in CART location -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 12 12:55:49 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Jun 2020 10:55:49 +0000 Subject: [Koha-bugs] [Bug 25723] Drop DateTime::Set as a dependancy In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25723 --- Comment #1 from Martin Renvoize --- Created attachment 105789 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105789&action=edit Bug 25723: Drop DateTime::Set dependancy This patch removes our use of DateTime::Set and replaces it with a quick hashref implimentation -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Jun 12 12:56:07 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Jun 2020 10:56:07 +0000 Subject: [Koha-bugs] [Bug 25723] Drop DateTime::Set as a dependancy In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25723 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |martin.renvoize at ptfs-europe |ity.org |.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Jun 12 13:04:28 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Jun 2020 11:04:28 +0000 Subject: [Koha-bugs] [Bug 24153] Add a confirm flag to the cleanup_database.pl cronjob In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24153 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |julian.maurice at biblibre.com --- Comment #5 from Julian Maurice --- >From what I understand this a breaking change. For instance, for users that run this script in a cronjob, it will suddenly stop working. If the need is to have a dry-run mode, why not add a --dry-run option instead ? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 12 13:16:15 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Jun 2020 11:16:15 +0000 Subject: [Koha-bugs] [Bug 25724] Transferred item checked in to shelving cart has cart location removed when transfer is filled In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25724 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 12 13:16:18 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Jun 2020 11:16:18 +0000 Subject: [Koha-bugs] [Bug 25724] Transferred item checked in to shelving cart has cart location removed when transfer is filled In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25724 --- Comment #1 from Nick Clemens --- Created attachment 105790 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105790&action=edit Bug 25724: Unit tests -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Jun 12 13:16:20 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Jun 2020 11:16:20 +0000 Subject: [Koha-bugs] [Bug 25724] Transferred item checked in to shelving cart has cart location removed when transfer is filled In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25724 --- Comment #2 from Nick Clemens --- Created attachment 105791 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105791&action=edit Bug 25724: Do not call ModReserveStatus when completing transfer I can not see how this code is useful here. It checks for a reserve with priority 0 and found = NULL That is not a status that should occur when filling a transfer. Either the found is 'T' if we are transferring due to the hold, or the hold was placed after the transfer was initiated, and so the priority is not 0 Additional, AddReturn checks for reserves later and asks the staff to confirm waiting status. ModReserveStatus also calls CartToShelf regardless of what happens here. To test: 1 - Set UpdateItemLocationOnCheckin to: _ALL_: CART 2 - SetAutomaticItemReturn = Do 3 - Check an item in at a different branch than it's homebranch to create a transfer 4 - Check the item in at it's homebranch 5 - View the item details page 6 - Item is not in CART location 7 - Apply patch 8 - Repeat 9 - Item is in CART location after completion of transfer -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 12 13:21:27 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Jun 2020 11:21:27 +0000 Subject: [Koha-bugs] [Bug 24153] Add a confirm flag to the cleanup_database.pl cronjob In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24153 --- Comment #6 from Jonathan Druart --- Yes it will need to be advertised correctly in the release note. I think it makes sense to force the --confirm flag to effectively make the changes, it's what we do in most of the other scripts. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 12 13:41:53 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Jun 2020 11:41:53 +0000 Subject: [Koha-bugs] [Bug 25723] Drop DateTime::Set as a dependancy In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25723 --- Comment #2 from Martin Renvoize --- Created attachment 105792 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105792&action=edit Bug 25723: [DO NOT PUSH] Benchmark Script A quick benchmark to compare DateTime::Set->contains to a simple hashref lookup -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 12 13:41:56 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Jun 2020 11:41:56 +0000 Subject: [Koha-bugs] [Bug 25723] Drop DateTime::Set as a dependancy In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25723 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #105789|0 |1 is obsolete| | --- Comment #3 from Martin Renvoize --- Created attachment 105793 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105793&action=edit Bug 25723: Drop DateTime::Set dependancy This patch removes our use of DateTime::Set and replaces it with a quick hashref implimentation -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 12 13:42:33 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Jun 2020 11:42:33 +0000 Subject: [Koha-bugs] [Bug 25723] Drop DateTime::Set as a dependancy In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25723 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 12 13:44:05 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Jun 2020 11:44:05 +0000 Subject: [Koha-bugs] [Bug 25155] Accessibility: The 'Login modal' contains semantically incorrect headings In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25155 --- Comment #11 from Owen Leonard --- (In reply to Hayley Mapley from comment #10) > I'd like to propose we remove that as h1, leave it as a link. > Anyone else have input here? I've gone back and forth on this issue for a long time and I think I'm coming down on your side of it now. When using VoiceOver in macOS the page context is stated clearly, as you say, by the page title. In my test the logo is read correctly--the hidden text is used instead of the image, but it's not read any differently than the other menu links. I think it would be better to remove the H1 tag around the logo. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 12 13:49:09 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Jun 2020 11:49:09 +0000 Subject: [Koha-bugs] [Bug 25408] CanBookBeReserved should check "opacitemholds" policy In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25408 --- Comment #5 from Arthur Suzuki --- Well, seems this bug also impact holds placed with WebServices. CanItemBeReserved also miss this check... patch definitely need rework. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 12 13:50:03 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Jun 2020 11:50:03 +0000 Subject: [Koha-bugs] [Bug 25408] CanBookBeReserved & CanItemBeReserved should check "opacitemholds" policy In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25408 Arthur Suzuki changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|CanBookBeReserved should |CanBookBeReserved & |check "opacitemholds" |CanItemBeReserved should |policy |check "opacitemholds" | |policy --- Comment #6 from Arthur Suzuki --- Well, seems this bug also impact holds placed with WebServices. CanItemBeReserved also miss this check... patch definitely need rework. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 12 13:54:42 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Jun 2020 11:54:42 +0000 Subject: [Koha-bugs] [Bug 25723] Drop DateTime::Set as a dependancy In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25723 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #4 from Jonathan Druart --- t/db_dependent/Holidays.t is failing # Failed test 'No tests run for subtest "exception_holidays() tests"' # at t/db_dependent/Holidays.t line 79. Can't locate object method "iterator" via package "0" (perhaps you forgot to load "0"?) at t/db_dependent/Holidays.t line 67. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 12 14:03:54 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Jun 2020 12:03:54 +0000 Subject: [Koha-bugs] [Bug 25702] Actions button on Search results from Z39.50 is displayed incorrectly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25702 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |oleonard at myacpl.org |ity.org | Version|20.05 |master Status|NEW |ASSIGNED --- Comment #2 from Owen Leonard --- I am able to reproduce this problem in master. I'm investigating. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 12 14:17:22 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Jun 2020 12:17:22 +0000 Subject: [Koha-bugs] [Bug 14543] Order lines updated that have a tax rate not in gist will have tax rate set to 0! In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14543 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |20.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 12 14:17:24 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Jun 2020 12:17:24 +0000 Subject: [Koha-bugs] [Bug 14543] Order lines updated that have a tax rate not in gist will have tax rate set to 0! In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14543 --- Comment #15 from Jonathan Druart --- Pushed to master for 20.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 12 14:17:26 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Jun 2020 12:17:26 +0000 Subject: [Koha-bugs] [Bug 17842] Broken diacritics on records exported as MARC from cart In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17842 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |20.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 12 14:17:28 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Jun 2020 12:17:28 +0000 Subject: [Koha-bugs] [Bug 17842] Broken diacritics on records exported as MARC from cart In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17842 --- Comment #52 from Jonathan Druart --- Pushed to master for 20.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 12 14:17:30 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Jun 2020 12:17:30 +0000 Subject: [Koha-bugs] [Bug 25492] Your Account Menu button does nothing on mobile devices In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25492 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |20.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 12 14:17:32 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Jun 2020 12:17:32 +0000 Subject: [Koha-bugs] [Bug 25492] Your Account Menu button does nothing on mobile devices In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25492 --- Comment #5 from Jonathan Druart --- Pushed to master for 20.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 12 14:17:34 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Jun 2020 12:17:34 +0000 Subject: [Koha-bugs] [Bug 25557] Column config table in acquisitions order does not match the acq table in baskets In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25557 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |20.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 12 14:17:36 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Jun 2020 12:17:36 +0000 Subject: [Koha-bugs] [Bug 25557] Column config table in acquisitions order does not match the acq table in baskets In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25557 --- Comment #11 from Jonathan Druart --- Pushed to master for 20.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 12 14:17:38 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Jun 2020 12:17:38 +0000 Subject: [Koha-bugs] [Bug 25634] koha-foreach exits too early if any command has non-zero status In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25634 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |20.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 12 14:17:40 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Jun 2020 12:17:40 +0000 Subject: [Koha-bugs] [Bug 25634] koha-foreach exits too early if any command has non-zero status In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25634 --- Comment #10 from Jonathan Druart --- Pushed to master for 20.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 12 14:17:42 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Jun 2020 12:17:42 +0000 Subject: [Koha-bugs] [Bug 25651] Modifying an authorised value make it disappear In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25651 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |20.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 12 14:17:44 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Jun 2020 12:17:44 +0000 Subject: [Koha-bugs] [Bug 25651] Modifying an authorised value make it disappear In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25651 --- Comment #4 from Jonathan Druart --- Pushed to master for 20.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 12 14:17:46 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Jun 2020 12:17:46 +0000 Subject: [Koha-bugs] [Bug 25653] Authorities search does not retain selection In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25653 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |20.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 12 14:17:48 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Jun 2020 12:17:48 +0000 Subject: [Koha-bugs] [Bug 25653] Authorities search does not retain selection In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25653 --- Comment #5 from Jonathan Druart --- Pushed to master for 20.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 12 14:17:50 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Jun 2020 12:17:50 +0000 Subject: [Koha-bugs] [Bug 25677] Checkbox options for EDI accounts cannot be enabled In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25677 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |20.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 12 14:17:51 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Jun 2020 12:17:51 +0000 Subject: [Koha-bugs] [Bug 25677] Checkbox options for EDI accounts cannot be enabled In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25677 --- Comment #4 from Jonathan Druart --- Pushed to master for 20.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 12 14:17:54 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Jun 2020 12:17:54 +0000 Subject: [Koha-bugs] [Bug 25693] Correct permissions must be set on logdir after an upgrade In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25693 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |20.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 12 14:17:56 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Jun 2020 12:17:56 +0000 Subject: [Koha-bugs] [Bug 25693] Correct permissions must be set on logdir after an upgrade In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25693 --- Comment #7 from Jonathan Druart --- Pushed to master for 20.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 12 14:17:58 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Jun 2020 12:17:58 +0000 Subject: [Koha-bugs] [Bug 25707] Mappings update in bug 11529 causes incorrect MARC to DB data flow In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25707 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |20.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 12 14:18:00 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Jun 2020 12:18:00 +0000 Subject: [Koha-bugs] [Bug 25707] Mappings update in bug 11529 causes incorrect MARC to DB data flow In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25707 --- Comment #11 from Jonathan Druart --- Pushed to master for 20.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 12 14:18:49 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Jun 2020 12:18:49 +0000 Subject: [Koha-bugs] [Bug 25725] New: Jancok Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25725 Bug ID: 25725 Summary: Jancok Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: bugs.koha-community.org Assignee: koha-bugs at lists.koha-community.org Reporter: lanang.gaming06 at gmail.com QA Contact: testopia at bugs.koha-community.org Created attachment 105794 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105794&action=edit Gua Ganz -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Jun 12 14:19:38 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Jun 2020 12:19:38 +0000 Subject: [Koha-bugs] [Bug 24153] Add a confirm flag to the cleanup_database.pl cronjob In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24153 --- Comment #7 from Julian Maurice --- (In reply to Jonathan Druart from comment #6) > Yes it will need to be advertised correctly in the release note. Can it be written now in "Text to go in the release notes" ? :-D > I think it makes sense to force the --confirm flag to effectively make the > changes, it's what we do in most of the other scripts. I agree that it makes sense. This script removes data so we should prevent unwanted data loss. I just don't like breaking changes :-) I kind of like the `git clean` approach which requires a flag (-n, -f or -i), which forces users to read the documentation first. Maybe we can have similar behavior for scripts that remove data (just a thought for future scripts, not blocking) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 12 14:23:31 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Jun 2020 12:23:31 +0000 Subject: [Koha-bugs] [Bug 24417] Charges/Fees.t is failing randomly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24417 --- Comment #3 from Victor Grousset/tuxayo --- Was able to get a failure locally with koha-testing-docker with KOHA_IMAGE=19.05-stretch. Not sure if it's the same issue though. t/db_dependent/Koha/Charges/Fees.t .. 1/8 # Failed test 'from_date default set correctly to today' # at t/db_dependent/Koha/Charges/Fees.t line 199. # got: '2020-06-12T05:05:16' # expected: '2020-06-12T05:05:17' # Looks like you failed 1 test of 9. t/db_dependent/Koha/Charges/Fees.t .. 2/8 # Failed test 'new' # at t/db_dependent/Koha/Charges/Fees.t line 201. # Looks like you failed 1 test of 8. t/db_dependent/Koha/Charges/Fees.t .. Dubious, test returned 1 (wstat 256, 0x100) Failed 1/8 subtests -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 12 14:24:07 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Jun 2020 12:24:07 +0000 Subject: [Koha-bugs] [Bug 24417] Charges/Fees.t is failing randomly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24417 --- Comment #4 from Victor Grousset/tuxayo --- (after 3100 runs) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 12 14:31:30 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Jun 2020 12:31:30 +0000 Subject: [Koha-bugs] [Bug 25624] Update patrons category script should allow finding null and not null and wildcards In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25624 --- Comment #3 from Alex Arnaud --- Comment on attachment 105605 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105605 Bug 25624: Add not equal, like, not like, and support for nulls to update_patron_category Review of attachment 105605: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=25624&attachment=105605) ----------------------------------------------------------------- Can you add pod items for likefield and notlikefield options ? ::: misc/cronjobs/update_patrons_category.pl @@ +135,5 @@ > +Use this flag to specify a column in the borrowers table and update only patrons whose value in that column does not equal the value supplied (repeatable) > + > +e.g. > +--notfield email=NULL > +will update all patrons with no value for email all patrons with null email field ? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 12 14:36:34 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Jun 2020 12:36:34 +0000 Subject: [Koha-bugs] [Bug 25624] Update patrons category script should allow finding null and not null and wildcards In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25624 --- Comment #4 from Alex Arnaud --- No a blocker but a concern: not* options work with empty and non-empty values but not with null values. perl misc/cronjobs/update_patrons_category.pl -f S -t B -dn email=foo -v => matches all patrons with email different from "foo" or email eq ''. But not the null ones. Is it the wanted behavior ? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 12 14:37:56 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Jun 2020 12:37:56 +0000 Subject: [Koha-bugs] [Bug 25624] Update patrons category script should allow finding null and not null and wildcards In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25624 --- Comment #5 from Alex Arnaud --- (In reply to Alex Arnaud from comment #3) > > +will update all patrons with no value for email > > all patrons with null email field ? I mean: all patron with email different from null -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 12 14:43:53 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Jun 2020 12:43:53 +0000 Subject: [Koha-bugs] [Bug 19821] Run tests on a separate database In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19821 --- Comment #65 from Kyle M Hall --- (In reply to Jonathan Druart from comment #63) > (In reply to Kyle M Hall from comment #62) > > Jonathan, can we get a unified test plan for this patch set? I'm not sure if > > I'm testing wrong. Selenium tests pass in 'normal' mode, so I know it's not > > my Selenium container that's not problematic: > > Hi Kyle, > > The test plan provided by Victor is quite good. > > If you want to "just it passes" you can: > > 1. > $ mysql -h db -u root --password=password > > GRANT ALL PRIVILEGES ON `koha_test`.* TO 'koha_kohadev'; > > 2. > # Edit $KOHA_CONF and add > koha_test > > 3. > $ prove -Mt::lib::Bootstrap t/db_dependent/selenium/00-installation.t > > And the tests should pass. But the different steps described by Victor are > useful to understand how it works. $ prove -Mt::lib::Bootstrap t/db_dependent/selenium/00-installation.t DBD::mysql::db do failed: You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near '(0x562c034c75a0)' at line 1 at /kohadevbox/koha/t/lib/Bootstrap.pm line 30. DBIx::Class::Storage::DBI::catch {...} (): DBI Connection failed: DBI connect('database=ARRAY(0x562c034c75a0);host=db;port=3306','koha_kohadev',...) failed: Access denied for user 'koha_kohadev'@'%' to database 'ARRAY(0x562c034c75a0)' at /usr/share/perl5/DBIx/Class/Storage/DBI.pm line 1517. at /kohadevbox/koha/Koha/Database.pm line 116 END failed--call queue aborted. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 12 14:45:31 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Jun 2020 12:45:31 +0000 Subject: [Koha-bugs] [Bug 25725] SPAM In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25725 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |INVALID Summary|Jancok |SPAM -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Jun 12 14:52:23 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Jun 2020 12:52:23 +0000 Subject: [Koha-bugs] [Bug 25698] Curbside Pickup In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25698 Fiona Borthwick changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fiona.borthwick at ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 12 14:57:59 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Jun 2020 12:57:59 +0000 Subject: [Koha-bugs] [Bug 24417] Charges/Fees.t is failing randomly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24417 --- Comment #5 from Jonathan Druart --- (In reply to Victor Grousset/tuxayo from comment #3) > Was able to get a failure locally with koha-testing-docker with > KOHA_IMAGE=19.05-stretch. > Not sure if it's the same issue though. > > t/db_dependent/Koha/Charges/Fees.t .. 1/8 > # Failed test 'from_date default set correctly to today' > # at t/db_dependent/Koha/Charges/Fees.t line 199. > # got: '2020-06-12T05:05:16' > # expected: '2020-06-12T05:05:17' > # Looks like you failed 1 test of 9. > t/db_dependent/Koha/Charges/Fees.t .. 2/8 > # Failed test 'new' > # at t/db_dependent/Koha/Charges/Fees.t line 201. > # Looks like you failed 1 test of 8. > t/db_dependent/Koha/Charges/Fees.t .. Dubious, test returned 1 (wstat 256, > 0x100) > Failed 1/8 subtests This is something different. 201 is( $fees->from_date, dt_from_string(), 202 'from_date default set correctly to today' ); It can be fixed using t::lib::Dates::compare -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 12 15:22:40 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Jun 2020 13:22:40 +0000 Subject: [Koha-bugs] [Bug 24201] Attach desk to intranet session In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24201 Nicolas Legrand changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #103840|0 |1 is obsolete| | --- Comment #41 from Nicolas Legrand --- Created attachment 105795 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105795&action=edit Bug 24201: (follow-up) add desk choice with library choice You should be able to add desk choice when you are logging in or changing library. Test plan: 1. apply patch 2. log in, you should see desks if they are defined. All are disabled. 3. when choosing a library, it should enabled all desks it has and pick one. 4. the desk should be in your session (not working yet, I don't undersand how to do it) 5. change library from intranet 6. you should have the same behaviours PROBLEMS: 1. I don't know how to send desk from login page 2. What about multiple libraries with some not having desk? This patch assume that when you use desks, you use it for every libraries 3. when changing library, the bar displaying the library and the desk (up right) doesn't update the desk when arriving on the updated page of set-library.tt. It is changed only after having clicked on “continue” 4. should we keep a separate desk changing page or is it redundant? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 12 15:34:59 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Jun 2020 13:34:59 +0000 Subject: [Koha-bugs] [Bug 19185] Web installer and onboarding tool selenium test In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19185 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 12 15:35:04 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Jun 2020 13:35:04 +0000 Subject: [Koha-bugs] [Bug 19185] Web installer and onboarding tool selenium test In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19185 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #103406|0 |1 is obsolete| | Attachment #103407|0 |1 is obsolete| | Attachment #103416|0 |1 is obsolete| | --- Comment #34 from Kyle M Hall --- Created attachment 105796 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105796&action=edit Bug 19185: Use submit button if only one exists on the page During the installation process we do not have fieldset.action, in order to not complicate changes we are just going to use the submit button if only one exists. Signed-off-by: Martin Renvoize Signed-off-by: Victor Grousset/tuxayo Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 12 15:35:26 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Jun 2020 13:35:26 +0000 Subject: [Koha-bugs] [Bug 19185] Web installer and onboarding tool selenium test In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19185 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #105796|0 |1 is obsolete| | --- Comment #35 from Kyle M Hall --- Created attachment 105797 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105797&action=edit Bug 19185: Use submit button if only one exists on the page During the installation process we do not have fieldset.action, in order to not complicate changes we are just going to use the submit button if only one exists. Signed-off-by: Martin Renvoize Signed-off-by: Victor Grousset/tuxayo Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 12 15:36:14 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Jun 2020 13:36:14 +0000 Subject: [Koha-bugs] [Bug 19185] Web installer and onboarding tool selenium test In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19185 --- Comment #36 from Kyle M Hall --- Created attachment 105798 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105798&action=edit Bug 19185: Ease elements selection - The marcflavour select needs an id to be selected easily - "Continue to the next step" should be a button (like others) Signed-off-by: Martin Renvoize Signed-off-by: Victor Grousset/tuxayo Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 12 15:36:18 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Jun 2020 13:36:18 +0000 Subject: [Koha-bugs] [Bug 19185] Web installer and onboarding tool selenium test In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19185 --- Comment #37 from Kyle M Hall --- Created attachment 105799 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105799&action=edit Bug 19185: Add selenium tests for installation and onboarding process == Test plan == 1. Apply the patches (including bug 19821) 2. restart_all 3. prove -Mt::lib::Bootstrap t/db_dependent/selenium/00-installation.t 4. result: Config entry 'database_test' does not exist at /home/vagrant/kohaclone/t/lib/Bootstrap.pm line 18 5. Edit $KOHA_CONF, add a database_test entry identical to database You should have: koha_kohadev koha_kohadev 6. restart_all 7. prove -Mt::lib::Bootstrap t/db_dependent/selenium/00-installation.t 8. result: Entries 'database_test' and 'database' have the same value in your config at /home/vagrant/kohaclone/t/lib/Bootstrap.pm line 20. 9. Edit $KOHA_CONF, edit database_test with koha_test as DB name 10. restart_all 11. prove -Mt::lib::Bootstrap t/db_dependent/selenium/00-installation.t 12. result: Access denied for user 'koha_kohadev'@'localhost' to database 'koha_test' 13. Connect to the DBMS 14. Example for koha_testing_docker docker exec -it koha_db_1 bash mysql -u root --password=password 15. GRANT ALL PRIVILEGES ON `koha_test`.* TO 'koha_kohadev'; 16. prove -Mt::lib::Bootstrap t/db_dependent/selenium/00-installation.t 17. result: All tests successful. Signed-off-by: Martin Renvoize Signed-off-by: Victor Grousset/tuxayo Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 12 15:43:11 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Jun 2020 13:43:11 +0000 Subject: [Koha-bugs] [Bug 25726] New: Holds to Pull made empty by pathological holds Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25726 Bug ID: 25726 Summary: Holds to Pull made empty by pathological holds Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Circulation Assignee: koha-bugs at lists.koha-community.org Reporter: andrew at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com After upgrading to 19.11, we're seeing libraries where pendingreserves.pl comes up empty when it shouldn't be. After some digging, we found it was because the library had some bad holds in their reserves table -- lines where reserves.itemnumber is null but reserves.found is not null. That runs into an issue on this line of the Holds to Pull query: AND items.itemnumber NOT IN (select itemnumber FROM reserves where found IS NOT NULL) I don't know exactly what changed between 19.05 and 19.11 to change how Koha thinks about this. I also don't know how libraries have ended up with these pathological holds. But that's a separate bug. To recreate: 1- place 2 bib-level holds on available items 2- confirm they both show on Holds to Pull 3- edit one hold from the database to set found='T' 4- reload Holds to Pull, confirm it is now empty -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 12 15:44:00 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Jun 2020 13:44:00 +0000 Subject: [Koha-bugs] [Bug 24151] Add a pseudonymization process for patrons and transactions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24151 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |julian.maurice at biblibre.com Status|Signed Off |Patch doesn't apply --- Comment #54 from Julian Maurice --- Does not apply on master. Can you rebase please ? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 12 15:45:04 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Jun 2020 13:45:04 +0000 Subject: [Koha-bugs] [Bug 24152] Add the ability to purge pseudonymized data In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24152 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |BLOCKED CC| |julian.maurice at biblibre.com --- Comment #12 from Julian Maurice --- Changing status to BLOCKED because of dependency on bug 24151, which does not apply at the moment. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 12 15:45:36 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Jun 2020 13:45:36 +0000 Subject: [Koha-bugs] [Bug 24156] Basket - Make sort order and number of items to display configurable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24156 Alex Arnaud changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |alex.arnaud at biblibre.com QA Contact|testopia at bugs.koha-communit |alex.arnaud at biblibre.com |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 12 15:45:46 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Jun 2020 13:45:46 +0000 Subject: [Koha-bugs] [Bug 24156] Basket - Make sort order and number of items to display configurable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24156 Alex Arnaud changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 12 15:45:51 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Jun 2020 13:45:51 +0000 Subject: [Koha-bugs] [Bug 18519] Add ability to skip irrelevant dates in Koha::Calendar In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18519 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com --- Comment #1 from Martin Renvoize --- Well.. we could easily switch from an array which we iterate to a hashref we can to a direct lockup on within the single_holidays method.. that would be a good first step I think. The caveat is that we trade some RAM for performances.. but I don't think it was a deliberate act to choose and array over a hashref in the first place. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 12 15:45:54 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Jun 2020 13:45:54 +0000 Subject: [Koha-bugs] [Bug 24153] Add a confirm flag to the cleanup_database.pl cronjob In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24153 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |BLOCKED --- Comment #8 from Julian Maurice --- Changing status to BLOCKED because of dependency on bug 24152, which is BLOCKED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 12 15:46:11 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Jun 2020 13:46:11 +0000 Subject: [Koha-bugs] [Bug 24156] Basket - Make sort order and number of items to display configurable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24156 --- Comment #34 from Alex Arnaud --- Jonathan, can you rebase please ? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 12 15:46:35 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Jun 2020 13:46:35 +0000 Subject: [Koha-bugs] [Bug 18519] Add ability to skip irrelevant dates in Koha::Calendar In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18519 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |14315 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14315 [Bug 14315] Slow checkouts, caused by many 'special_holidays' definitions -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 12 15:46:35 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Jun 2020 13:46:35 +0000 Subject: [Koha-bugs] [Bug 14315] Slow checkouts, caused by many 'special_holidays' definitions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14315 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |18519 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18519 [Bug 18519] Add ability to skip irrelevant dates in Koha::Calendar -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 12 15:54:45 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Jun 2020 13:54:45 +0000 Subject: [Koha-bugs] [Bug 25726] Holds to Pull made empty by pathological holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25726 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 12 15:54:48 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Jun 2020 13:54:48 +0000 Subject: [Koha-bugs] [Bug 25726] Holds to Pull made empty by pathological holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25726 --- Comment #1 from Andrew Fuerste-Henry --- Created attachment 105800 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105800&action=edit Bug 25726: make holds to pull ignore holds where found is not null and itemnumber is null To test: 1- place 2 bib-level holds on available items 2- confirm they both show on Holds to Pull 3- edit one hold from the database to set found='T' 4- reload Holds to Pull, confirm it is now empty 5- apply patch 6- Reload Holds to Pull 7- confirm it now shows the hold you did not edit -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Jun 12 16:04:51 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Jun 2020 14:04:51 +0000 Subject: [Koha-bugs] [Bug 24151] Add a pseudonymization process for patrons and transactions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24151 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 12 16:04:55 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Jun 2020 14:04:55 +0000 Subject: [Koha-bugs] [Bug 24151] Add a pseudonymization process for patrons and transactions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24151 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #101034|0 |1 is obsolete| | Attachment #101035|0 |1 is obsolete| | Attachment #101036|0 |1 is obsolete| | Attachment #101037|0 |1 is obsolete| | Attachment #101038|0 |1 is obsolete| | Attachment #101039|0 |1 is obsolete| | Attachment #101040|0 |1 is obsolete| | Attachment #101041|0 |1 is obsolete| | Attachment #101042|0 |1 is obsolete| | Attachment #101043|0 |1 is obsolete| | Attachment #101044|0 |1 is obsolete| | Attachment #101045|0 |1 is obsolete| | Attachment #101046|0 |1 is obsolete| | Attachment #101047|0 |1 is obsolete| | Attachment #101048|0 |1 is obsolete| | Attachment #101049|0 |1 is obsolete| | --- Comment #55 from Jonathan Druart --- Created attachment 105801 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105801&action=edit Bug 24151: DB changes 1 new table: * pseudonymized_transactions 3 new sysprefs: * Pseudonymization * PseudonymizationPatronFields * PseudonymizationTransactionFields Sponsored-by: Association KohaLa - https://koha-fr.org/ Signed-off-by: Signed-off-by: Sonia Bouis -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 12 16:05:01 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Jun 2020 14:05:01 +0000 Subject: [Koha-bugs] [Bug 24151] Add a pseudonymization process for patrons and transactions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24151 --- Comment #56 from Jonathan Druart --- Created attachment 105802 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105802&action=edit Bug 24151: DBIC changes Signed-off-by: Signed-off-by: Sonia Bouis -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 12 16:05:05 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Jun 2020 14:05:05 +0000 Subject: [Koha-bugs] [Bug 24151] Add a pseudonymization process for patrons and transactions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24151 --- Comment #57 from Jonathan Druart --- Created attachment 105803 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105803&action=edit Bug 24151: Copy info to the pseudonymized table when a transaction is done This is the commit where you will find useful information about this development. The goal of this new feature is to add a way to pseudonymize patron's data, in a way they could not be personally identifiable. https://en.wikipedia.org/wiki/Pseudonymization There are different existing way to anonymize patron's information in Koha, but we loose the ability to make useful report. This development proposes to have 2 different tables: * 1 for transactions and patrons data (pseudonymized_transactions) * 1 for patrons' attributes (pseudonymized_borrower_attributes) Entries to pseudonymized_transactions are added when a new transaction (checkout, checkin, renew, on-site checkout) is done. Also, anonymized_borrower_attributes is populated if patron's attributes are marked as "keep for pseudonymization". To make those informations not identifiable to a patron, we are having a hashed_borrowernumber column in pseudonymized_transactions. This hash will be generated (Blowfish-based crypt) using a key stored in the Koha configuration. To make things configurable, we are adding 3 sysprefs and 1 new DB column: * syspref Pseudonymization to turn on/off the whole feature * syspref PseudonymizationPatronFields to list the informations of the patrons to sync * syspref PseudonymizationTransactionFields to list the informations of the transactions to copy * DB column borrower_attribute_types.keep_for_pseudonymization that is a boolean to enable/disable the copy of a given patron's attribute type. Test plan: 1/ Turn on Pseudonymization 2/ Define in PseudonymizationPatronFields and PseudonymizationTransactionFields the different fields you want to copy 3/ Go to the about page => You will see a warning about a missing config entry 4/ You need to generate a key and put it in the koha-conf.xml file. The following command will generate one: % htpasswd -bnBC 10 "" password | tr -d ':\n' | sed 's/$2y/$2a/' Then edit $KOHA_CONF and add it before of the end of the config section ($2a$10$PfdrEBdRcL2MZlEtKueyLegxI6zg735jD07GRnc1bt.N/ZYMvBAB2 5/ Restart memcached then plack (alias restart_all) => Everything is setup! 6/ Create a new transaction (checkin for instance) => Confirm that a new entry has been added to pseudonymized_transaction with the data you expect to be copied 7/ Edit some patron attribute types and tick "Keep for pseudonymization" 8/ Create a new transaction => Confirm that new entries have been added to pseudonymized_borrower_attributes 11/ Delete the patrons => Confirm that the entries still exist in the pseudonymized_* tables 12/ Purge the patrons (ie. use cleanup_database.pl to remove them from the deleted_borrowers table) => Confirm that the entries still exist in the pseudonymized_* tables See bug 24152 to remove data from the anonymized_* tables Sponsored-by: Association KohaLa - https://koha-fr.org/ Signed-off-by: Signed-off-by: Sonia Bouis -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 12 16:05:10 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Jun 2020 14:05:10 +0000 Subject: [Koha-bugs] [Bug 24151] Add a pseudonymization process for patrons and transactions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24151 --- Comment #58 from Jonathan Druart --- Created attachment 105804 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105804&action=edit Bug 24151: Add tests Sponsored-by: Association KohaLa - https://koha-fr.org/ Signed-off-by: Signed-off-by: Sonia Bouis -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 12 16:05:14 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Jun 2020 14:05:14 +0000 Subject: [Koha-bugs] [Bug 24151] Add a pseudonymization process for patrons and transactions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24151 --- Comment #59 from Jonathan Druart --- Created attachment 105805 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105805&action=edit Bug 24151: Add tests - if config does not exist Sponsored-by: Association KohaLa - https://koha-fr.org/ Signed-off-by: Signed-off-by: Sonia Bouis -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 12 16:05:18 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Jun 2020 14:05:18 +0000 Subject: [Koha-bugs] [Bug 24151] Add a pseudonymization process for patrons and transactions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24151 --- Comment #60 from Jonathan Druart --- Created attachment 105806 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105806&action=edit Bug 24151: Add warning to the about page if key is missing in the config Sponsored-by: Association KohaLa - https://koha-fr.org/ Signed-off-by: Signed-off-by: Sonia Bouis -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 12 16:05:22 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Jun 2020 14:05:22 +0000 Subject: [Koha-bugs] [Bug 24151] Add a pseudonymization process for patrons and transactions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24151 --- Comment #61 from Jonathan Druart --- Created attachment 105807 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105807&action=edit Bug 24151: Add key to the config Sponsored-by: Association KohaLa - https://koha-fr.org/ Signed-off-by: Signed-off-by: Sonia Bouis -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 12 16:05:27 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Jun 2020 14:05:27 +0000 Subject: [Koha-bugs] [Bug 24151] Add a pseudonymization process for patrons and transactions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24151 --- Comment #62 from Jonathan Druart --- Created attachment 105808 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105808&action=edit Bug 24151: DB changes - pseudonymized_borrower_attributes Add a new DB table pseudonymized_borrower_attributes Sponsored-by: Association KohaLa - https://koha-fr.org/ Signed-off-by: Signed-off-by: Sonia Bouis -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 12 16:05:31 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Jun 2020 14:05:31 +0000 Subject: [Koha-bugs] [Bug 24151] Add a pseudonymization process for patrons and transactions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24151 --- Comment #63 from Jonathan Druart --- Created attachment 105809 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105809&action=edit Bug 24151: Add new column borrower_attribute_types.keep_for_pseudonymization Sponsored-by: Association KohaLa - https://koha-fr.org/ Signed-off-by: Signed-off-by: Sonia Bouis -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 12 16:05:35 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Jun 2020 14:05:35 +0000 Subject: [Koha-bugs] [Bug 24151] Add a pseudonymization process for patrons and transactions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24151 --- Comment #64 from Jonathan Druart --- Created attachment 105810 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105810&action=edit Bug 24151: Adding keep_for_anonymized to the UI Sponsored-by: Association KohaLa - https://koha-fr.org/ Signed-off-by: Signed-off-by: Sonia Bouis -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 12 16:05:39 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Jun 2020 14:05:39 +0000 Subject: [Koha-bugs] [Bug 24151] Add a pseudonymization process for patrons and transactions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24151 --- Comment #65 from Jonathan Druart --- Created attachment 105811 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105811&action=edit Bug 24151: Sync patron's attributes Signed-off-by: Signed-off-by: Sonia Bouis -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 12 16:05:43 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Jun 2020 14:05:43 +0000 Subject: [Koha-bugs] [Bug 24151] Add a pseudonymization process for patrons and transactions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24151 --- Comment #66 from Jonathan Druart --- Created attachment 105812 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105812&action=edit Bug 24151: DBIC changes Signed-off-by: Signed-off-by: Sonia Bouis -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 12 16:05:48 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Jun 2020 14:05:48 +0000 Subject: [Koha-bugs] [Bug 24151] Add a pseudonymization process for patrons and transactions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24151 --- Comment #67 from Jonathan Druart --- Created attachment 105813 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105813&action=edit Bug 24151: Add boolean flag for has_cardnumber Signed-off-by: Signed-off-by: Sonia Bouis -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 12 16:05:51 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Jun 2020 14:05:51 +0000 Subject: [Koha-bugs] [Bug 24151] Add a pseudonymization process for patrons and transactions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24151 --- Comment #68 from Jonathan Druart --- Created attachment 105814 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105814&action=edit Bug 24151: Fix location on return The item's location where not passed to UpdateStat Signed-off-by: Signed-off-by: Sonia Bouis -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 12 16:06:03 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Jun 2020 14:06:03 +0000 Subject: [Koha-bugs] [Bug 24151] Add a pseudonymization process for patrons and transactions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24151 --- Comment #69 from Jonathan Druart --- Created attachment 105815 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105815&action=edit Bug 24151: Add items.homebranch to the list Signed-off-by: Signed-off-by: Sonia Bouis -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 12 16:06:09 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Jun 2020 14:06:09 +0000 Subject: [Koha-bugs] [Bug 24151] Add a pseudonymization process for patrons and transactions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24151 --- Comment #70 from Jonathan Druart --- Created attachment 105816 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105816&action=edit Bug 24151: DBIC changes Signed-off-by: Signed-off-by: Sonia Bouis -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 12 16:08:55 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Jun 2020 14:08:55 +0000 Subject: [Koha-bugs] [Bug 24152] Add the ability to purge pseudonymized data In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24152 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|BLOCKED |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 12 16:08:58 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Jun 2020 14:08:58 +0000 Subject: [Koha-bugs] [Bug 24152] Add the ability to purge pseudonymized data In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24152 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #101297|0 |1 is obsolete| | Attachment #101298|0 |1 is obsolete| | Attachment #101299|0 |1 is obsolete| | --- Comment #13 from Jonathan Druart --- Created attachment 105817 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105817&action=edit Bug 24152: Add method Koha::Objects->filter_by_last_update Signed-off-by: Signed-off-by: Sonia Bouis -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 12 16:09:02 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Jun 2020 14:09:02 +0000 Subject: [Koha-bugs] [Bug 24152] Add the ability to purge pseudonymized data In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24152 --- Comment #14 from Jonathan Druart --- Created attachment 105818 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105818&action=edit Bug 24152: Add a warning about the delete of statistics's table entries Signed-off-by: Signed-off-by: Sonia Bouis -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 12 16:09:05 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Jun 2020 14:09:05 +0000 Subject: [Koha-bugs] [Bug 24152] Add the ability to purge pseudonymized data In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24152 --- Comment #15 from Jonathan Druart --- Created attachment 105819 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105819&action=edit Bug 24152: Add the ability to purge pseudonymized tables anonymized_* tables have been added by bug 24151, this patch adds the usual way to purge data from them. The cleanup_database.pl script has been adjusted to take new parameters that will help to delete pseudonymized data. Test plan: Call the scrip with the new parameter to remove pseudonymized data * --pseudo-transactions DAYS will remove entries from pseudonymized_transactions older than DAYS day * --pseudo-transactions can be used without the parameter DAYS but with -- pseudo-transactions-from and/or --pseudo-transactions-to instead, to provide a range of date You can use the patch from bug 24153 to make the tests easier, data will not be deleted if the new --confirm flag is not passed. Sponsored-by: Association KohaLa - https://koha-fr.org/ Signed-off-by: Signed-off-by: Sonia Bouis -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 12 16:20:01 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Jun 2020 14:20:01 +0000 Subject: [Koha-bugs] [Bug 17390] Add REST API endpoint for Authorised Values In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17390 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 12 16:20:05 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Jun 2020 14:20:05 +0000 Subject: [Koha-bugs] [Bug 17390] Add REST API endpoint for Authorised Values In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17390 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #92036|0 |1 is obsolete| | Attachment #92037|0 |1 is obsolete| | --- Comment #7 from Jonathan Druart --- Created attachment 105820 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105820&action=edit Bug 17390: Add /authorised_values endpoint This patch add the different routes for authorised values: * GET /authorised_values * GET /authorised_values/{authorised_value_id} * POST /authorised_values * PUT /authorised_values/{authorised_value_id} * DELETE /authorised_values/{authorised_value_id} Test plan: - Make sure the tests in t/db_dependent/api/v1/authorised_values.t pass - Test the different routes. For instance: GET /authorised_values # list all the avs GET /authorised_values?category=YES_NO # list all the YES_NO avs POST /authorised_values { "category": "YES_NO", "description": "not sure", "opac_description": "something else", "value": "maybe" } DELETE /authorised_values/X # with X the AV id of "maybe" Sponsored-by: Orex Digital -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 12 16:20:54 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Jun 2020 14:20:54 +0000 Subject: [Koha-bugs] [Bug 17390] Add REST API endpoint for Authorised Values In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17390 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Change sponsored?|--- |Sponsored -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 12 16:23:01 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Jun 2020 14:23:01 +0000 Subject: [Koha-bugs] [Bug 25727] New: Update the Select2 JS lib Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25727 Bug ID: 25727 Summary: Update the Select2 JS lib Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Templates Assignee: jonathan.druart at bugs.koha-community.org Reporter: jonathan.druart at bugs.koha-community.org QA Contact: testopia at bugs.koha-community.org In order to benefit from the last feature of Select we should upgrade to the version 4. For instance it adds the ability to dynamically create new entries https://select2.org/tagging -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 12 16:23:18 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Jun 2020 14:23:18 +0000 Subject: [Koha-bugs] [Bug 25726] Holds to Pull made empty by pathological holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25726 ByWater Sandboxes changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #105800|0 |1 is obsolete| | --- Comment #2 from ByWater Sandboxes --- Created attachment 105821 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105821&action=edit Bug 25726: make holds to pull ignore holds where found is not null and itemnumber is null To test: 1- place 2 bib-level holds on available items 2- confirm they both show on Holds to Pull 3- edit one hold from the database to set found='T' 4- reload Holds to Pull, confirm it is now empty 5- apply patch 6- Reload Holds to Pull 7- confirm it now shows the hold you did not edit Signed-off-by: donnab -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 12 16:23:38 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Jun 2020 14:23:38 +0000 Subject: [Koha-bugs] [Bug 25726] Holds to Pull made empty by pathological holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25726 Donna changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bwsdonna at gmail.com Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Jun 12 16:25:12 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Jun 2020 14:25:12 +0000 Subject: [Koha-bugs] [Bug 25727] Update the Select2 JS lib In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25727 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 12 16:25:15 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Jun 2020 14:25:15 +0000 Subject: [Koha-bugs] [Bug 25727] Update the Select2 JS lib In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25727 --- Comment #1 from Jonathan Druart --- Created attachment 105822 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105822&action=edit Bug 25727: Upgrade the Select2 JS lib to version 4 In order to benefit from the last feature of Select we should upgrade to the version 4. For instance it adds the ability to dynamically create new entries https://select2.org/tagging Test plan: Confirm that there is no visible regression on dropdown list with select2 Like edit a bibliographic records, and the items. Sponsored-by: Orex Digital -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 12 16:44:10 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Jun 2020 14:44:10 +0000 Subject: [Koha-bugs] [Bug 19482] Elasticsearch - prevent removal / editing of required indexes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19482 --- Comment #43 from Alex Arnaud --- Comment on attachment 101313 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101313 Bug 19482 - Add support for defining 'mandatory' mappings Review of attachment 101313: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=19482&attachment=101313) ----------------------------------------------------------------- ::: koha-tmpl/intranet-tmpl/prog/en/modules/admin/searchengine/elasticsearch/mappings.tt @@ +200,5 @@ > + [% IF search_field.type == "string" %] > + > + [% ELSE %] > + > + [% END %] That makes the list empty instead of only disabled. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 12 16:45:34 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Jun 2020 14:45:34 +0000 Subject: [Koha-bugs] [Bug 19482] Elasticsearch - prevent removal / editing of required indexes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19482 Alex Arnaud changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #44 from Alex Arnaud --- As Jonathan said, Koha::SearchEngine::Elasticsearch::raw_elasticsearch_mappings need to be updated with the new mandatory field. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 12 16:52:55 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Jun 2020 14:52:55 +0000 Subject: [Koha-bugs] [Bug 24156] Basket - Make sort order and number of items to display configurable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24156 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 12 16:52:58 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Jun 2020 14:52:58 +0000 Subject: [Koha-bugs] [Bug 24156] Basket - Make sort order and number of items to display configurable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24156 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #99007|0 |1 is obsolete| | Attachment #99008|0 |1 is obsolete| | Attachment #99009|0 |1 is obsolete| | Attachment #99010|0 |1 is obsolete| | Attachment #99011|0 |1 is obsolete| | Attachment #99012|0 |1 is obsolete| | Attachment #99013|0 |1 is obsolete| | Attachment #99014|0 |1 is obsolete| | --- Comment #35 from Jonathan Druart --- Created attachment 105823 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105823&action=edit Bug 24156: DB changes Add a new table tables_settings to store default_display_length and default_sort_order. Signed-off-by: Liz Rea -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 12 16:53:02 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Jun 2020 14:53:02 +0000 Subject: [Koha-bugs] [Bug 24156] Basket - Make sort order and number of items to display configurable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24156 --- Comment #36 from Jonathan Druart --- Created attachment 105824 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105824&action=edit Bug 24156: DBIC changes Signed-off-by: Liz Rea -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 12 16:53:06 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Jun 2020 14:53:06 +0000 Subject: [Koha-bugs] [Bug 24156] Basket - Make sort order and number of items to display configurable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24156 --- Comment #37 from Jonathan Druart --- Created attachment 105825 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105825&action=edit Bug 24156: move ColumnsSettings to TablesSettings We are preparing the ground with this patch. As the "Columns settings" page will now add the ability to modify settings for the whole table, it makes sense to rename the file and the variables. Note that the controller script (admin/columns_settings.pl) and the yml (admin/columns_settings.yml) files have not been moved to not break shortcuts and abits people could have. But if QA decides, it could be easy to do. Signed-off-by: Liz Rea -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 12 16:53:11 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Jun 2020 14:53:11 +0000 Subject: [Koha-bugs] [Bug 24156] Basket - Make sort order and number of items to display configurable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24156 --- Comment #38 from Jonathan Druart --- Created attachment 105826 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105826&action=edit Bug 24156: Add columns_settings.yml changes Modification of the structure of the yml file. It was table: - column list It now becomes table: default_display_length: X default_sort_order: Y columns: - column list Signed-off-by: Liz Rea -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 12 16:53:16 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Jun 2020 14:53:16 +0000 Subject: [Koha-bugs] [Bug 24156] Basket - Make sort order and number of items to display configurable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24156 --- Comment #39 from Jonathan Druart --- Created attachment 105827 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105827&action=edit Bug 24156: Adjust other tables in the yml file To match the new structure, we adjust the other tables. Signed-off-by: Liz Rea -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 12 16:53:19 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Jun 2020 14:53:19 +0000 Subject: [Koha-bugs] [Bug 24156] Basket - Make sort order and number of items to display configurable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24156 --- Comment #40 from Jonathan Druart --- Created attachment 105828 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105828&action=edit Bug 24156: Make sort order and number of items to display configurable (basket page) This patch is the main patch of this patchset, you will find the description and the test plan. The idea of this new enhancement is to add the ability to define the default sort order and the default number of rows displayed on the acquisition basket page. The existing "columns settings" feature was replaced by a "tables settings" feature. To prepare the ground, there were some works that were needed: * rename variables and files * Modify the structure of the yml files * Create a new DB table to store the tables settings Test plan: 0) a. Execute the update DB entry to create the new table b. Restart all (to get a new version of the yml file, that is cached by memcached) c. Create several orders for a given basket 1) Go to the basket view page => The default values are the same than without this patchset, the number of entries to display is set to "20" and the table is sorted by basket number (first column) 2) Go to the "Columns settings" page 3) Unfold the "Acquisition" tab => Notice the 2 dropdown lists at the bottom of the basket table 4) Select different values for "Default display length" and "Default sort order" 5) Refresh the basket view page => Notice that the default settings are now effective on the table QA note: We can decide to replace the different occurrences of "Columns settings" by "Tables settings" if needed. Sponsored-by: Institute of Technology Tallaght Signed-off-by: Liz Rea Signed-off-by: Liz Rea -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 12 16:53:23 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Jun 2020 14:53:23 +0000 Subject: [Koha-bugs] [Bug 24156] Basket - Make sort order and number of items to display configurable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24156 --- Comment #41 from Jonathan Druart --- Created attachment 105829 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105829&action=edit Bug 24156: Fix set sort order to the first column In that case it's equal to 0 and we need to adjust the test condition. Signed-off-by: Liz Rea Signed-off-by: Liz Rea -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 12 16:54:32 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Jun 2020 14:54:32 +0000 Subject: [Koha-bugs] [Bug 24153] Add a confirm flag to the cleanup_database.pl cronjob In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24153 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|BLOCKED |Signed Off --- Comment #9 from Jonathan Druart --- (In reply to Julian Maurice from comment #8) > Changing status to BLOCKED because of dependency on bug 24152, which is > BLOCKED Rebased -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 12 16:55:29 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Jun 2020 14:55:29 +0000 Subject: [Koha-bugs] [Bug 24151] Add a pseudonymization process for patrons and transactions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24151 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- URL|https://gitlab.com/joubu/Ko | |ha/commits/bug_24151 | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 12 16:56:31 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Jun 2020 14:56:31 +0000 Subject: [Koha-bugs] [Bug 25723] Drop DateTime::Set as a dependancy In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25723 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #105792|0 |1 is obsolete| | --- Comment #5 from Martin Renvoize --- Created attachment 105830 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105830&action=edit Bug 25723: [DO NOT PUSH] Benchmark Script A quick benchmark to compare DateTime::Set->contains to a simple hashref lookup -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 12 16:56:34 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Jun 2020 14:56:34 +0000 Subject: [Koha-bugs] [Bug 25723] Drop DateTime::Set as a dependancy In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25723 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #105793|0 |1 is obsolete| | --- Comment #6 from Martin Renvoize --- Created attachment 105831 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105831&action=edit Bug 25723: Drop DateTime::Set dependancy This patch removes our use of DateTime::Set and replaces it with a quick hashref implimentation -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 12 16:56:38 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Jun 2020 14:56:38 +0000 Subject: [Koha-bugs] [Bug 25723] Drop DateTime::Set as a dependancy In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25723 --- Comment #7 from Martin Renvoize --- Created attachment 105832 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105832&action=edit Bug 25723: (follow-up) Fix Unit Test The unit test previously relied on the internals of exception_holidays. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 12 16:59:08 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Jun 2020 14:59:08 +0000 Subject: [Koha-bugs] [Bug 25728] New: Add the ability to create a new authorised value within the cataloguing module Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25728 Bug ID: 25728 Summary: Add the ability to create a new authorised value within the cataloguing module Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Cataloging Assignee: jonathan.druart at bugs.koha-community.org Reporter: jonathan.druart at bugs.koha-community.org QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl If you are editing a bibliographic record, then you realised that you need a new authorised values, you have to go to the admin module, and reload the page. It would be handy to create it directly from the cataloguing module. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 12 16:59:25 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Jun 2020 14:59:25 +0000 Subject: [Koha-bugs] [Bug 25728] Add the ability to create a new authorised value within the cataloguing module In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25728 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |17390, 25727 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17390 [Bug 17390] Add REST API endpoint for Authorised Values https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25727 [Bug 25727] Update the Select2 JS lib -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 12 16:59:25 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Jun 2020 14:59:25 +0000 Subject: [Koha-bugs] [Bug 17390] Add REST API endpoint for Authorised Values In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17390 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |25728 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25728 [Bug 25728] Add the ability to create a new authorised value within the cataloguing module -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 12 16:59:25 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Jun 2020 14:59:25 +0000 Subject: [Koha-bugs] [Bug 25727] Update the Select2 JS lib In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25727 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |25728 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25728 [Bug 25728] Add the ability to create a new authorised value within the cataloguing module -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 12 17:03:14 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Jun 2020 15:03:14 +0000 Subject: [Koha-bugs] [Bug 23151] Patron self modification sends null dateofbirth In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23151 Christopher Brannon changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |cbrannon at cdalibrary.org --- Comment #46 from Christopher Brannon --- This bug seems to be back in 19.11! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 12 17:03:20 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Jun 2020 15:03:20 +0000 Subject: [Koha-bugs] [Bug 25723] Drop DateTime::Set as a dependancy In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25723 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #105830|0 |1 is obsolete| | --- Comment #8 from Martin Renvoize --- Created attachment 105833 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105833&action=edit Bug 25723: [DO NOT PUSH] Benchmark Script A quick benchmark to compare DateTime::Set->contains to a simple hashref lookup -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 12 17:03:24 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Jun 2020 15:03:24 +0000 Subject: [Koha-bugs] [Bug 25723] Drop DateTime::Set as a dependancy In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25723 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #105831|0 |1 is obsolete| | --- Comment #9 from Martin Renvoize --- Created attachment 105834 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105834&action=edit Bug 25723: Drop DateTime::Set dependancy This patch removes our use of DateTime::Set and replaces it with a quick hashref implimentation -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 12 17:03:27 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Jun 2020 15:03:27 +0000 Subject: [Koha-bugs] [Bug 25723] Drop DateTime::Set as a dependancy In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25723 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #105832|0 |1 is obsolete| | --- Comment #10 from Martin Renvoize --- Created attachment 105835 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105835&action=edit Bug 25723: (follow-up) Fix Unit Test The unit test previously relied on the internals of exception_holidays. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 12 17:03:30 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Jun 2020 15:03:30 +0000 Subject: [Koha-bugs] [Bug 25723] Drop DateTime::Set as a dependancy In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25723 --- Comment #11 from Martin Renvoize --- Created attachment 105836 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105836&action=edit Bug 25723: Drop DateTime::Set from cpanfile -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 12 17:04:12 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Jun 2020 15:04:12 +0000 Subject: [Koha-bugs] [Bug 25723] Drop DateTime::Set as a dependancy In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25723 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 12 17:19:20 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Jun 2020 15:19:20 +0000 Subject: [Koha-bugs] [Bug 25728] Add the ability to create a new authorised value within the cataloguing module In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25728 --- Comment #1 from Jonathan Druart --- How it looks like: https://snipboard.io/FYuAay.jpg https://snipboard.io/CL7vTo.jpg https://snipboard.io/B5aJ7m.jpg https://snipboard.io/HL9lfO.jpg -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 12 17:20:41 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Jun 2020 15:20:41 +0000 Subject: [Koha-bugs] [Bug 25728] Add the ability to create a new authorised value within the cataloguing module In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25728 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 12 17:20:44 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Jun 2020 15:20:44 +0000 Subject: [Koha-bugs] [Bug 25728] Add the ability to create a new authorised value within the cataloguing module In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25728 --- Comment #2 from Jonathan Druart --- Created attachment 105837 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105837&action=edit Bug 25728: Create AV when cataloguing a bibliographic record This whole patch set adds the ability to create a new authorised value directly from the cataloguing module. It will prevent the cataloger to leave and reload the page if they need a new one. Test plan: If you are logged in with a patron with the manage_authorised_values subpermission you will be able to: * Edit a bibliographic record * Search for a subfield linked to an authorised values (not the "fake" AV like itemtypes, branches, cn) * Click the dropdown list and start searching for a value that does not exist * Click enter * Fill the fields in the popup * Save => Your dropdown list has the new AV :) Note: This does not work for the advanced editor. It does not have select2 applied to the selects. I have hardly tried but failed. Sponsored-by: Orex Digital -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 12 17:20:48 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 12 Jun 2020 15:20:48 +0000 Subject: [Koha-bugs] [Bug 25728] Add the ability to create a new authorised value within the cataloguing module In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25728 --- Comment #3 from Jonathan Druart --- Created attachment 105838 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105838&action=edit Bug 25728: Create AV when adding a new item We do a bit of refactoring to make the code reusable. Test plan: Same as the first patch but when adding/editing an item QA note: There is a warning from the QA tools FAIL koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/additem.tt FAIL js_in_body A