[Koha-bugs] [Bug 25554] Refactor rule kinds assignments in CirculationRules.pm

bugzilla-daemon at bugs.koha-community.org bugzilla-daemon at bugs.koha-community.org
Fri Jun 5 16:50:58 CEST 2020


https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25554

--- Comment #3 from Peter Vashchuk <stalkernoid at gmail.com> ---
Yeah I thought about naming them similarly to what you proposed but it would
undermine some decisions that were taken into consideration during refactor.

The thing is, we need to add another item to "scope3" for Koha Finland, if we
name those arrays something like I already did (scope1, scope2, scope3) all it
requires is to add another item to array and we’re done, but if we rename those
arrays like you suggested (branch_category, branch_itemtype,
branch_category_itemtype) it will complicate things if we ever need to add any
other element to any of those arrays.

-- 
You are receiving this mail because:
You are watching all bug changes.


More information about the Koha-bugs mailing list