[Koha-bugs] [Bug 25037] Add checkout_type to checkouts

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25037

--- Comment #61 from Lari Taskula <lari.taskula at hypernova.fi> ---
(In reply to Joonas Kylmälä from comment #59)
> Comment on attachment 104268 [details] [review]
> Bug 25037: Replace occurences to issues.onsite_checkout
> 
> Review of attachment 104268 [details] [review]:
> -----------------------------------------------------------------
> 
> I checked all the other patches and they were looking good!
> 
> ::: api/v1/swagger/definitions/checkout.json
> @@ +53,5 @@
> >        "description": "Date the item was issued"
> >      },
> > +    "checkout_type": {
> > +      "type": ["string", "null"],
> > +      "description": "Checkout type, an authorised value under CHECKOUT_TYPE category"
> 
> The description is still from the v1 version where authorized values were
> used. Could you here a) add enum for values "CHECKOUT" and "ONSITE" and b)
> update the description.

Done! Thanks for noticing.

-- 
You are receiving this mail because:
You are watching all bug changes.