[Koha-bugs] [Bug 6918] Can't place holds on 'on order' items with AllowOnShelfHolds off

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6918

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |martin.renvoize at ptfs-europe
                   |                            |.com
             Status|Signed Off                  |Failed QA

--- Comment #54 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Sorry.. but I'm not seeing any Unit Tests... so failing QA for that.

As a side note.. I think I would have preferred to see a new method
'CountItemsOrdered' as opposed to adding logic into 'CountItemsIssued' as it
makes the methods purpose less well defined/clear.  It could, of course, be
entirely differently named or in the Koha::Object world perhaps be a chainable
filter on an Koha::Items's set?

-- 
You are receiving this mail because:
You are watching all bug changes.