[Koha-bugs] [Bug 24003] REST API should set C4::Context->userenv

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24003

--- Comment #18 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
(In reply to Jonathan Druart from comment #17)
> Say you are going to implement the DELETE route for items, you will need to
> call Koha::Item->safe_to_delete.
> 
> 246     return "not_same_branch"                                            
> 
> 247       if defined C4::Context->userenv                                   
> 
> 248       and !C4::Context->IsSuperLibrarian()                              
> 
> 249       and C4::Context->preference("IndependentBranches")
> 250       and ( C4::Context->userenv->{branch} ne $self->homebranch );   
> 
> Don't you want the branch to be defined at this point? Isn't that the
> purpose of this patch?

I'm fixing a current bug on stable branches. If we were to think this in terms
of the project future devs, I would rather stash the full Koha::Patron for the
logged user and get rid of all that cruft we've been porting to Koha::*

-- 
You are receiving this mail because:
You are watching all bug changes.