[Koha-bugs] [Bug 25683] update_patron_categories.pl should recognize no fine history = 0 outstanding fines

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25683

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |david at davidnind.com

--- Comment #11 from David Nind <david at davidnind.com> ---
I'm a bit confused with this one, sorry!

Using J patron category and Bobbie Middleton in koha-testing-docker - no
transactions to start with.

Before applying the patch, results are:

  perl update_patrons_category.pl -f J -t J -fu=5 -v
  No actions will be taken (test mode)
  Will update patrons from J to J with conditions below (if any)
  Conditions:
      Total fines less than 5
  0 found, 0 updated

After adding a charge of $1.00:

  perl update_patrons_category.pl -f J -t J -fu=5 -v
  No actions will be taken (test mode)
  Will update patrons from J to J with conditions below (if any)
  Conditions:
      Total fines less than 5
  WOULD HAVE Updated Bobbie Middleton from J to J
  1 found, 0 updated

After paying off charge (balance is $0, two transactions with charge and
payment) - two lines appear for patron, even though the their balance is $0:

  perl update_patrons_category.pl -f J -t J -fu=5 -v
  No actions will be taken (test mode)
  Will update patrons from J to J with conditions below (if any)
  Conditions:
      Total fines less than 5
  WOULD HAVE Updated Bobbie Middleton from J to J
  WOULD HAVE Updated Bobbie Middleton from J to J
  1 found, 0 updated

After applying the patch:

  perl update_patrons_category.pl -f J -t J -fu=5 -v
  No actions will be taken (test mode)
  Will update patrons from J to J with conditions below (if any)
  Conditions:
      Total fines less than 5
  WOULD HAVE Updated Bobbie Middleton from J to J
  WOULD HAVE Updated Bobbie Middleton from J to J
  WOULD HAVE Updated Gordon Peterson from J to J
  WOULD HAVE Updated Mae Kinney from J to J
  3 found, 0 updated

After applying the patch and adding another charge - Bobbie Middleton appears
three times:

  perl update_patrons_category.pl -f J -t J -fu=5 -v
  No actions will be taken (test mode)
  Will update patrons from J to J with conditions below (if any)
  Conditions:
      Total fines less than 5
  WOULD HAVE Updated Bobbie Middleton from J to J
  WOULD HAVE Updated Bobbie Middleton from J to J
  WOULD HAVE Updated Bobbie Middleton from J to J
  WOULD HAVE Updated Gordon Peterson from J to J
  WOULD HAVE Updated Mae Kinney from J to J
  3 found, 0 updated

Every transaction added increases the number of times they appear.

If the above is what is expected then I'm happy to sign off!

==> Outcome after applying the patch is that all patrons for the category with
charges under 5 should appear, even if they have a 0 balance

-- 
You are receiving this mail because:
You are watching all bug changes.