[Koha-bugs] [Bug 25701] Facets display in random order

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25701

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |nick at bywatersolutions.com

--- Comment #3 from Nick Clemens <nick at bywatersolutions.com> ---
(In reply to Jonathan Druart from comment #1)
> Created attachment 105679 [details] [review]
> Bug 25701: (bug 14419 follow-up) Always display facet groups in the same
> order
> 
> It seems that this regression comes from bug 14419, but I have not found
> a logic reason behind that.
> I think the following line must be removed
> @facets_loop = sort {defined $a->{expand} && defined $b->{expand} &&
> $a->{expand} cmp $b->{expand}} @facets_loop;

Afaict the line you change in the patch never worked, we always relied on the
secondary sort line you mention above.

I removed the 'expand' field in my patches on 14419 set which broke the second
(actual) sort

I agree we should remove this line and fix the first sort

-- 
You are receiving this mail because:
You are watching all bug changes.