[Koha-bugs] [Bug 25037] Add checkout_type to checkouts

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25037

--- Comment #65 from Joonas Kylmälä <joonas.kylmala at helsinki.fi> ---
Created attachment 105783
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105783&action=edit
Bug 25037: Replace occurences to issues.onsite_checkout

This patch replaces all occurences to issues.onsite_checkout so that
on-site checkouts work normally.

It does not replace any on-site checkout logic.

To test:

1. Investigate Koha source files via command line. We must make sure
   there are no longer references to issues.onsite_checkout column.
   You can do this by searching all occurrences of onsite_checkout.

   grep -rn 'onsite_checkout' | grep -v '\.git'

2. Run all these commands in your command line interface:

grep -rl --color=never 'onsite_checkout' | grep '^.*\.t$' | xargs prove
prove t/db_dependent/Koha/Account/Line.t
prove t/db_dependent/api/v1/checkouts.t

3. Verify koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt
   - Create a record and add two items to it
   - Checkout both of them, one as on-site checkout and one as normal
   - Go to INTRANET /cgi-bin/koha/catalogue/detail.pl?biblionumber=XXX
     where XXX is your record's biblionumber
   - Observe Holdings table column Status
      => your on-site checked out item should say "Currently in local
         use by ..."
      => your normal checked out item should say "Checked out to ..."

4. Verify koha-tmpl/opac-tmpl/bootstrap/en/includes/item-status.inc
   - Repeat step 3 but this time go to OPAC
     /cgi-bin/koha/opac-detail.pl?biblionumber=XXX where XXX is your
     record's biblionumber
   - Observe Holdings table column Status
      => your on-site checked out item should say "Currently in local
         use"
      => your normal checked out item should say "Checked out"

5. Verify koha-tmpl/intranet-tmpl/prog/en/modules/members/readingrec.tt
   - After step 4, go to INTRANET
     /cgi-bin/koha/members/readingrec.pl?borrowernumber=51
   - You will see circulation history table.
   - Observe your two checkouts from step 3
   - Click "Checkouts" tab
   - Observe your normal checkout in the list
   - Click "On-site checkouts"" tab
   - Observe your on-site checkout in the list

6. Verify koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-readingrecord.tt
   - Repeat step 5 but this time go to OPAC
     /cgi-bin/koha/opac-readingrecord.pl

Sponsored-by: The National Library of Finland
Signed-off-by: Joonas Kylmälä <joonas.kylmala at helsinki.fi>

-- 
You are receiving this mail because:
You are watching all bug changes.