[Koha-bugs] [Bug 25724] Transferred item checked in to shelving cart has cart location removed when transfer is filled

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25724

--- Comment #2 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 105791
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105791&action=edit
Bug 25724: Do not call ModReserveStatus when completing transfer

I can not see how this code is useful here. It checks for a reserve with
priority 0 and found = NULL
That is not a status that should occur when filling a transfer. Either the
found is 'T' if we are transferring due
to the hold, or the hold was placed after the transfer was initiated, and so
the priority is not 0

Additional, AddReturn checks for reserves later and asks the staff to confirm
waiting status.

ModReserveStatus also calls CartToShelf regardless of what happens here.

To test:
1 - Set  UpdateItemLocationOnCheckin  to:
    _ALL_: CART
2 - SetAutomaticItemReturn = Do
3 - Check an item in at a different branch than it's homebranch to create a
transfer
4 - Check the item in at it's homebranch
5 - View the item details page
6 - Item is not in CART location
7 - Apply patch
8 - Repeat
9 - Item is in CART location after completion of transfer

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.