[Koha-bugs] [Bug 25726] New: Holds to Pull made empty by pathological holds

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25726

            Bug ID: 25726
           Summary: Holds to Pull made empty by pathological holds
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: major
          Priority: P5 - low
         Component: Circulation
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: andrew at bywatersolutions.com
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com

After upgrading to 19.11, we're seeing libraries where pendingreserves.pl comes
up empty when it shouldn't be. After some digging, we found it was because the
library had some bad holds in their reserves table -- lines where
reserves.itemnumber is null but reserves.found is not null. That runs into an
issue on this line of the Holds to Pull query:
    AND items.itemnumber NOT IN (select itemnumber FROM reserves where found IS
NOT NULL)

I don't know exactly what changed between 19.05 and 19.11 to change how Koha
thinks about this. I also don't know how libraries have ended up with these
pathological holds. But that's a separate bug.

To recreate:
1- place 2 bib-level holds on available items
2- confirm they both show on Holds to Pull
3- edit one hold from the database to set found='T'
4- reload Holds to Pull, confirm it is now empty

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.