[Koha-bugs] [Bug 25783] Holds Queue treating item-level holds as bib-level

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25783

--- Comment #2 from Kyle M Hall <kyle at bywatersolutions.com> ---
(In reply to Kyle M Hall from comment #1)
> Created attachment 105973 [details] [review]
> Bug 25783: Holds Queue treating item-level holds as bib-level
> 
> I discovered two issues. First, the holds queue builder does not honor
> the new item_level_hold flag. Instead, it only item_level_request if
> in the loop dealing with item level holds. This is incorrect. Item level
> holds may be trapped in the local holds priority loop as well. It's
> trivial to just pass though the correct item/biblio level hold flag.
> 
> In addition, in bug 23934 I removed the line of code that prevented
> local holds priority from working for item level holds. This change
> itself was good and correct. However, the code in that loop does not
> check to ensure the item matches the requested item! That means it can
> match an item level hold with the wrong item!
> 
> I do not know how to write a reproducable test plan for these issues.

I'm going to split the second issue out into it's own bug.

-- 
You are receiving this mail because:
You are watching all bug changes.