[Koha-bugs] [Bug 25533] Perl "not numeric" warning on the "Holds" page
bugzilla-daemon at bugs.koha-community.org
bugzilla-daemon at bugs.koha-community.org
Thu Jun 18 07:51:37 CEST 2020
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25533
Emmi Takkinen <emmi.takkinen at outlook.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #105101|0 |1
is obsolete| |
CC| |emmi.takkinen at outlook.com
--- Comment #2 from Emmi Takkinen <emmi.takkinen at outlook.com> ---
Created attachment 105995
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105995&action=edit
Bug 25533: Fix for 'Argument "" isn't numeric' warning
Perl warning on the intranet "Holds" page
(/cgi-bin/koha/reserve/request.pl)
Argument "" isn't numeric in numeric gt (>)
at .../C4/Reserves.pm line 2233.
Fixed by assigning 0 for $holds_per_record when it has value that can
be considered as false.
To test:
1) Ensure that values of "Holds per record" is set to Unlimited
on /cgi-bin/koha/admin/smart-rules.pl
2) Go to the intranet page (/cgi-bin/koha/reserve/request.pl).
3) Open item record, like
/cgi-bin/koha/reserve/request.pl?biblionumber=1&borrowernumber=1
4) Observe the warning in the log file.
5) Apply patch.
6) Repeat steps 2 and 3.
7) Check that previous warning was suppressed.
Mentored-by: Peter Vashchuk <stalkernoid at gmail.com>
Signed-off-by: Emmi Takkinen <emmi.takkinen at outlook.com>
--
You are receiving this mail because:
You are watching all bug changes.
More information about the Koha-bugs
mailing list