[Koha-bugs] [Bug 24151] Add a pseudonymization process for patrons and transactions

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24151

--- Comment #90 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Looks good to me, some additional comments:

t/db_dependent/Koha/Pseudonymization.t
Please add test descriptions. This is a good habit. If we dont do it now, we
will not.
# Subtest: Config does not exist
    ok 2
# Subtest: Koha::Anonymized::Transactions tests
    ok 3
    ok 4
    ok 5
    ok 6
    ok 7
    ok 8
    ok 9
    ok 10
    ok 11
    ok 12

$values->{branchcode} = $patron->branchcode; # FIXME Must be removed from the
pref options, or FK removed (?)
Adding a FIXME !

my $attributes =
Koha::Database->new->schema->resultset('PseudonymizedBorrowerAttribute')->search({transaction_id
=> $p->id });
So no Koha objects here but DBIx ?

$(htpasswd -bnBC 10 "" password | tr -d ':\n' | sed 's/$2y/$2a/');
Why do you change $2y to $2a ?
If I understand correctly, $2y signals use of a safer updated algorithm.

<key>$2a$10$PfdrEBdRcL2MZlEtKueyLegxI6zg735jD07GRnc1bt.N/ZYMvBAB2</key>
BAD choice for a new config variable! What is key? Where is it used for? Please
add pseudonymize or something ?

In general: We are filling these tables with transactions?  Are we going to
keep them indefinitely? What are the plans for cleanup etc.? This could be a
large table in no time.

-- 
You are receiving this mail because:
You are watching all bug changes.