[Koha-bugs] [Bug 18974] Cataloging MARC21 record and adding item selenium test

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18974

--- Comment #20 from Victor Grousset/tuxayo <victor at tuxayo.net> ---
(In reply to Jonathan Druart from comment #19)
> In a first step I'd not rely on network (so no search from LOC).

Good idea.

> I'd delete the item and record using selenium (click delete buttons).

Thanks, this is perfect to test these things also :)

> Then you need: itemtype and branches. Actually will you know which data you
> need to delete as you will have to create them.

I don't get this. Is there anything to cleanup other than the record and item
created just before?

> No, don't rely on bug 19821. You will have to cleanup anyway.

Ok, no bug 19821

> If the test explodes in mid-air there will be data that won't be removed.
> Don't bother about that, it is how it works already.

- if the test explodes before any creation: delete nothing
- if the test explodes after record creation: delete record
- if the test explodes after item creation or succeeds: delete booth
- if the deletion test fails: ???

Is there a less complex way to handle this?
Like having a test that creates, deletes and that's all. In case of a mid-air
failure, no separate cleanup.
How should it impact the other tests? If they rely on a precise number of order
of the items and records, then isn't that the issue?
Like that means we can't at all change the initial test data.


> > We aim for the new tests to be backportable right?
> > If so, do you think bug 19821 could be backported? I can spend time on that
> > for each branch (especially since I would like to improve the coverage down
> > to my branch ^^) but not matter how much, I don't know if it would be OK
> > from a QA POV.
> 
> Master first, usually enhancements are not backported.

That should be worth it if we are lucky that it works immediately which is very
likely in stable in beginning of the cycle.

-- 
You are receiving this mail because:
You are watching all bug changes.